Serge Guelton | 16228bc | 2019-01-03 15:44:24 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 2 | |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 3 | """A script to generate FileCheck statements for 'opt' regression tests. |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 4 | |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 5 | This script is a utility to update LLVM opt test cases with new |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 6 | FileCheck patterns. It can either update all of the tests in the file or |
| 7 | a single test function. |
Sanjay Patel | 4064158 | 2016-04-05 18:00:47 +0000 | [diff] [blame] | 8 | |
| 9 | Example usage: |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 10 | $ update_test_checks.py --opt=../bin/opt test/foo.ll |
Sanjay Patel | 4064158 | 2016-04-05 18:00:47 +0000 | [diff] [blame] | 11 | |
| 12 | Workflow: |
| 13 | 1. Make a compiler patch that requires updating some number of FileCheck lines |
| 14 | in regression test files. |
| 15 | 2. Save the patch and revert it from your local work area. |
| 16 | 3. Update the RUN-lines in the affected regression tests to look canonical. |
| 17 | Example: "; RUN: opt < %s -instcombine -S | FileCheck %s" |
| 18 | 4. Refresh the FileCheck lines for either the entire file or select functions by |
| 19 | running this script. |
| 20 | 5. Commit the fresh baseline of checks. |
| 21 | 6. Apply your patch from step 1 and rebuild your local binaries. |
| 22 | 7. Re-run this script on affected regression tests. |
| 23 | 8. Check the diffs to ensure the script has done something reasonable. |
| 24 | 9. Submit a patch including the regression test diffs for review. |
| 25 | |
| 26 | A common pattern is to have the script insert complete checking of every |
| 27 | instruction. Then, edit it down to only check the relevant instructions. |
| 28 | The script is designed to make adding checks to a test case fast, it is *not* |
| 29 | designed to be authoratitive about what constitutes a good test! |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 30 | """ |
| 31 | |
Serge Guelton | 4a27478 | 2019-01-03 14:11:33 +0000 | [diff] [blame] | 32 | from __future__ import print_function |
| 33 | |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 34 | import argparse |
Simon Pilgrim | f509fe4 | 2019-03-05 10:44:37 +0000 | [diff] [blame] | 35 | import glob |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 36 | import itertools |
| 37 | import os # Used to advertise this file's name ("autogenerated_note"). |
| 38 | import string |
| 39 | import subprocess |
| 40 | import sys |
| 41 | import tempfile |
| 42 | import re |
| 43 | |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 44 | from UpdateTestChecks import common |
| 45 | |
Sanjay Patel | 16be4df9 | 2016-04-05 19:50:21 +0000 | [diff] [blame] | 46 | ADVERT = '; NOTE: Assertions have been autogenerated by ' |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 47 | |
| 48 | # RegEx: this is where the magic happens. |
| 49 | |
Sanjay Patel | e54e6f5 | 2016-03-25 17:00:12 +0000 | [diff] [blame] | 50 | IR_FUNCTION_RE = re.compile('^\s*define\s+(?:internal\s+)?[^@]*@([\w-]+)\s*\(') |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 51 | |
| 52 | |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 53 | |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 54 | |
| 55 | |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 56 | def main(): |
Sanjay Patel | 4064158 | 2016-04-05 18:00:47 +0000 | [diff] [blame] | 57 | from argparse import RawTextHelpFormatter |
| 58 | parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 59 | parser.add_argument('-v', '--verbose', action='store_true', |
| 60 | help='Show verbose output') |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 61 | parser.add_argument('--opt-binary', default='opt', |
| 62 | help='The opt binary used to generate the test case') |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 63 | parser.add_argument( |
| 64 | '--function', help='The function in the test file to update') |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 65 | parser.add_argument('-u', '--update-only', action='store_true', |
Philip Reames | 9bf5938 | 2019-08-05 18:25:08 +0000 | [diff] [blame] | 66 | help='Only update test if it was already autogened') |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 67 | parser.add_argument('tests', nargs='+') |
| 68 | args = parser.parse_args() |
| 69 | |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 70 | script_name = os.path.basename(__file__) |
| 71 | autogenerated_note = (ADVERT + 'utils/' + script_name) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 72 | |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 73 | opt_basename = os.path.basename(args.opt_binary) |
Fangrui Song | 91ab86f | 2019-05-12 04:55:09 +0000 | [diff] [blame] | 74 | if not re.match(r'^opt(-\d+)?$', opt_basename): |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 75 | common.error('Unexpected opt name: ' + opt_basename) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 76 | sys.exit(1) |
Fangrui Song | 91ab86f | 2019-05-12 04:55:09 +0000 | [diff] [blame] | 77 | opt_basename = 'opt' |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 78 | |
David Bolvansky | fcffa7c | 2019-07-11 20:14:22 +0000 | [diff] [blame] | 79 | test_paths = [] |
| 80 | for test in args.tests: |
| 81 | if not glob.glob(test): |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 82 | common.warn("Test file '%s' was not found. Ignoring it." % (test,)) |
David Bolvansky | fcffa7c | 2019-07-11 20:14:22 +0000 | [diff] [blame] | 83 | continue |
| 84 | test_paths.append(test) |
| 85 | |
Simon Pilgrim | f509fe4 | 2019-03-05 10:44:37 +0000 | [diff] [blame] | 86 | for test in test_paths: |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 87 | if args.verbose: |
Fangrui Song | 1eb84c4 | 2019-08-06 09:44:18 +0000 | [diff] [blame] | 88 | print('Scanning for RUN lines in test file: ' + test, file=sys.stderr) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 89 | with open(test) as f: |
| 90 | input_lines = [l.rstrip() for l in f] |
| 91 | |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 92 | first_line = input_lines[0] if input_lines else "" |
| 93 | if 'autogenerated' in first_line and script_name not in first_line: |
| 94 | common.warn("Skipping test which wasn't autogenerated by " + script_name, test) |
| 95 | continue |
| 96 | |
Philip Reames | 9bf5938 | 2019-08-05 18:25:08 +0000 | [diff] [blame] | 97 | if args.update_only: |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 98 | if not first_line or 'autogenerated' not in first_line: |
| 99 | common.warn("Skipping test which isn't autogenerated: " + test) |
Fangrui Song | d24e6d7 | 2019-08-06 09:42:00 +0000 | [diff] [blame] | 100 | continue |
Philip Reames | 9bf5938 | 2019-08-05 18:25:08 +0000 | [diff] [blame] | 101 | |
Bryant Wong | 291264b | 2016-12-29 19:32:34 +0000 | [diff] [blame] | 102 | raw_lines = [m.group(1) |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 103 | for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m] |
Bryant Wong | 291264b | 2016-12-29 19:32:34 +0000 | [diff] [blame] | 104 | run_lines = [raw_lines[0]] if len(raw_lines) > 0 else [] |
| 105 | for l in raw_lines[1:]: |
Fangrui Song | d24e6d7 | 2019-08-06 09:42:00 +0000 | [diff] [blame] | 106 | if run_lines[-1].endswith('\\'): |
| 107 | run_lines[-1] = run_lines[-1].rstrip('\\') + ' ' + l |
Bryant Wong | 507256b | 2016-12-29 20:05:51 +0000 | [diff] [blame] | 108 | else: |
| 109 | run_lines.append(l) |
Bryant Wong | 291264b | 2016-12-29 19:32:34 +0000 | [diff] [blame] | 110 | |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 111 | if args.verbose: |
Serge Guelton | 4a27478 | 2019-01-03 14:11:33 +0000 | [diff] [blame] | 112 | print('Found %d RUN lines:' % (len(run_lines),), file=sys.stderr) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 113 | for l in run_lines: |
Serge Guelton | 4a27478 | 2019-01-03 14:11:33 +0000 | [diff] [blame] | 114 | print(' RUN: ' + l, file=sys.stderr) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 115 | |
| 116 | prefix_list = [] |
| 117 | for l in run_lines: |
Philip Reames | 9bf5938 | 2019-08-05 18:25:08 +0000 | [diff] [blame] | 118 | if '|' not in l: |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 119 | common.warn('Skipping unparseable RUN line: ' + l) |
Philip Reames | 9bf5938 | 2019-08-05 18:25:08 +0000 | [diff] [blame] | 120 | continue |
Fangrui Song | d24e6d7 | 2019-08-06 09:42:00 +0000 | [diff] [blame] | 121 | |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 122 | (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)]) |
David Bolvansky | 45be5e4 | 2019-07-29 17:41:00 +0000 | [diff] [blame] | 123 | common.verify_filecheck_prefixes(filecheck_cmd) |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 124 | if not tool_cmd.startswith(opt_basename + ' '): |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 125 | common.warn('Skipping non-%s RUN line: %s' % (opt_basename, l)) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 126 | continue |
| 127 | |
| 128 | if not filecheck_cmd.startswith('FileCheck '): |
David Bolvansky | 7169ea3 | 2019-08-07 14:44:50 +0000 | [diff] [blame] | 129 | common.warn('Skipping non-FileChecked RUN line: ' + l) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 130 | continue |
| 131 | |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 132 | tool_cmd_args = tool_cmd[len(opt_basename):].strip() |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 133 | tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip() |
| 134 | |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 135 | check_prefixes = [item for m in common.CHECK_PREFIX_RE.finditer(filecheck_cmd) |
Nikolai Bozhenov | 33ee40e | 2017-01-14 09:39:35 +0000 | [diff] [blame] | 136 | for item in m.group(1).split(',')] |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 137 | if not check_prefixes: |
| 138 | check_prefixes = ['CHECK'] |
| 139 | |
| 140 | # FIXME: We should use multiple check prefixes to common check lines. For |
| 141 | # now, we just ignore all but the last. |
| 142 | prefix_list.append((check_prefixes, tool_cmd_args)) |
| 143 | |
| 144 | func_dict = {} |
| 145 | for prefixes, _ in prefix_list: |
| 146 | for prefix in prefixes: |
| 147 | func_dict.update({prefix: dict()}) |
Sanjay Patel | cae64a0 | 2017-06-12 17:44:30 +0000 | [diff] [blame] | 148 | for prefixes, opt_args in prefix_list: |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 149 | if args.verbose: |
Serge Guelton | 4a27478 | 2019-01-03 14:11:33 +0000 | [diff] [blame] | 150 | print('Extracted opt cmd: ' + opt_basename + ' ' + opt_args, file=sys.stderr) |
| 151 | print('Extracted FileCheck prefixes: ' + str(prefixes), file=sys.stderr) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 152 | |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 153 | raw_tool_output = common.invoke_tool(args.opt_binary, opt_args, test) |
| 154 | common.build_function_body_dictionary( |
Fangrui Song | 4f0f426 | 2018-02-10 05:01:33 +0000 | [diff] [blame] | 155 | common.OPT_FUNCTION_RE, common.scrub_body, [], |
| 156 | raw_tool_output, prefixes, func_dict, args.verbose) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 157 | |
| 158 | is_in_function = False |
| 159 | is_in_function_start = False |
| 160 | prefix_set = set([prefix for prefixes, _ in prefix_list for prefix in prefixes]) |
| 161 | if args.verbose: |
Serge Guelton | 4a27478 | 2019-01-03 14:11:33 +0000 | [diff] [blame] | 162 | print('Rewriting FileCheck prefixes: %s' % (prefix_set,), file=sys.stderr) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 163 | output_lines = [] |
| 164 | output_lines.append(autogenerated_note) |
| 165 | |
| 166 | for input_line in input_lines: |
| 167 | if is_in_function_start: |
| 168 | if input_line == '': |
| 169 | continue |
| 170 | if input_line.lstrip().startswith(';'): |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 171 | m = common.CHECK_RE.match(input_line) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 172 | if not m or m.group(1) not in prefix_set: |
| 173 | output_lines.append(input_line) |
| 174 | continue |
| 175 | |
| 176 | # Print out the various check lines here. |
Simon Pilgrim | abba048 | 2018-04-05 09:30:42 +0000 | [diff] [blame] | 177 | common.add_ir_checks(output_lines, ';', prefix_list, func_dict, func_name) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 178 | is_in_function_start = False |
| 179 | |
| 180 | if is_in_function: |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 181 | if common.should_add_line_to_output(input_line, prefix_set): |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 182 | # This input line of the function body will go as-is into the output. |
Sanjay Patel | d859271 | 2016-03-27 20:43:02 +0000 | [diff] [blame] | 183 | # Except make leading whitespace uniform: 2 spaces. |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 184 | input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 185 | output_lines.append(input_line) |
| 186 | else: |
| 187 | continue |
| 188 | if input_line.strip() == '}': |
| 189 | is_in_function = False |
| 190 | continue |
| 191 | |
Sanjay Patel | 16be4df9 | 2016-04-05 19:50:21 +0000 | [diff] [blame] | 192 | # Discard any previous script advertising. |
| 193 | if input_line.startswith(ADVERT): |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 194 | continue |
| 195 | |
| 196 | # If it's outside a function, it just gets copied to the output. |
| 197 | output_lines.append(input_line) |
| 198 | |
| 199 | m = IR_FUNCTION_RE.match(input_line) |
| 200 | if not m: |
| 201 | continue |
Fangrui Song | ee4e2e7 | 2018-01-30 00:40:05 +0000 | [diff] [blame] | 202 | func_name = m.group(1) |
| 203 | if args.function is not None and func_name != args.function: |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 204 | # When filtering on a specific function, skip all others. |
| 205 | continue |
| 206 | is_in_function = is_in_function_start = True |
| 207 | |
| 208 | if args.verbose: |
Serge Guelton | 4a27478 | 2019-01-03 14:11:33 +0000 | [diff] [blame] | 209 | print('Writing %d lines to %s...' % (len(output_lines), test), file=sys.stderr) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 210 | |
| 211 | with open(test, 'wb') as f: |
Simon Pilgrim | d82bd4d | 2019-01-30 16:15:59 +0000 | [diff] [blame] | 212 | f.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines]) |
Sanjay Patel | fff7a3d | 2016-03-24 23:19:26 +0000 | [diff] [blame] | 213 | |
| 214 | |
| 215 | if __name__ == '__main__': |
| 216 | main() |