blob: fa8e1d45f1bded3bcd029f4cc3a16dfad0099f9f [file] [log] [blame]
Serge Guelton16228bc2019-01-03 15:44:24 +00001#!/usr/bin/env python
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00002
Sanjay Patelcae64a02017-06-12 17:44:30 +00003"""A script to generate FileCheck statements for 'opt' regression tests.
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00004
Sanjay Patelcae64a02017-06-12 17:44:30 +00005This script is a utility to update LLVM opt test cases with new
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00006FileCheck patterns. It can either update all of the tests in the file or
7a single test function.
Sanjay Patel40641582016-04-05 18:00:47 +00008
9Example usage:
Sanjay Patelcae64a02017-06-12 17:44:30 +000010$ update_test_checks.py --opt=../bin/opt test/foo.ll
Sanjay Patel40641582016-04-05 18:00:47 +000011
12Workflow:
131. Make a compiler patch that requires updating some number of FileCheck lines
14 in regression test files.
152. Save the patch and revert it from your local work area.
163. Update the RUN-lines in the affected regression tests to look canonical.
17 Example: "; RUN: opt < %s -instcombine -S | FileCheck %s"
184. Refresh the FileCheck lines for either the entire file or select functions by
19 running this script.
205. Commit the fresh baseline of checks.
216. Apply your patch from step 1 and rebuild your local binaries.
227. Re-run this script on affected regression tests.
238. Check the diffs to ensure the script has done something reasonable.
249. Submit a patch including the regression test diffs for review.
25
26A common pattern is to have the script insert complete checking of every
27instruction. Then, edit it down to only check the relevant instructions.
28The script is designed to make adding checks to a test case fast, it is *not*
29designed to be authoratitive about what constitutes a good test!
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000030"""
31
Serge Guelton4a274782019-01-03 14:11:33 +000032from __future__ import print_function
33
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000034import argparse
Simon Pilgrimf509fe42019-03-05 10:44:37 +000035import glob
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000036import itertools
37import os # Used to advertise this file's name ("autogenerated_note").
38import string
39import subprocess
40import sys
41import tempfile
42import re
43
Fangrui Songee4e2e72018-01-30 00:40:05 +000044from UpdateTestChecks import common
45
Sanjay Patel16be4df92016-04-05 19:50:21 +000046ADVERT = '; NOTE: Assertions have been autogenerated by '
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000047
48# RegEx: this is where the magic happens.
49
Sanjay Patele54e6f52016-03-25 17:00:12 +000050IR_FUNCTION_RE = re.compile('^\s*define\s+(?:internal\s+)?[^@]*@([\w-]+)\s*\(')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000051
52
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000053
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000054
55
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000056def main():
Sanjay Patel40641582016-04-05 18:00:47 +000057 from argparse import RawTextHelpFormatter
58 parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000059 parser.add_argument('-v', '--verbose', action='store_true',
60 help='Show verbose output')
Sanjay Patelcae64a02017-06-12 17:44:30 +000061 parser.add_argument('--opt-binary', default='opt',
62 help='The opt binary used to generate the test case')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000063 parser.add_argument(
64 '--function', help='The function in the test file to update')
David Bolvansky7169ea32019-08-07 14:44:50 +000065 parser.add_argument('-u', '--update-only', action='store_true',
Philip Reames9bf59382019-08-05 18:25:08 +000066 help='Only update test if it was already autogened')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000067 parser.add_argument('tests', nargs='+')
68 args = parser.parse_args()
69
David Bolvansky7169ea32019-08-07 14:44:50 +000070 script_name = os.path.basename(__file__)
71 autogenerated_note = (ADVERT + 'utils/' + script_name)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000072
Sanjay Patelcae64a02017-06-12 17:44:30 +000073 opt_basename = os.path.basename(args.opt_binary)
Fangrui Song91ab86f2019-05-12 04:55:09 +000074 if not re.match(r'^opt(-\d+)?$', opt_basename):
David Bolvansky7169ea32019-08-07 14:44:50 +000075 common.error('Unexpected opt name: ' + opt_basename)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000076 sys.exit(1)
Fangrui Song91ab86f2019-05-12 04:55:09 +000077 opt_basename = 'opt'
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000078
David Bolvanskyfcffa7c2019-07-11 20:14:22 +000079 test_paths = []
80 for test in args.tests:
81 if not glob.glob(test):
David Bolvansky7169ea32019-08-07 14:44:50 +000082 common.warn("Test file '%s' was not found. Ignoring it." % (test,))
David Bolvanskyfcffa7c2019-07-11 20:14:22 +000083 continue
84 test_paths.append(test)
85
Simon Pilgrimf509fe42019-03-05 10:44:37 +000086 for test in test_paths:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000087 if args.verbose:
Fangrui Song1eb84c42019-08-06 09:44:18 +000088 print('Scanning for RUN lines in test file: ' + test, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000089 with open(test) as f:
90 input_lines = [l.rstrip() for l in f]
91
David Bolvansky7169ea32019-08-07 14:44:50 +000092 first_line = input_lines[0] if input_lines else ""
93 if 'autogenerated' in first_line and script_name not in first_line:
94 common.warn("Skipping test which wasn't autogenerated by " + script_name, test)
95 continue
96
Philip Reames9bf59382019-08-05 18:25:08 +000097 if args.update_only:
David Bolvansky7169ea32019-08-07 14:44:50 +000098 if not first_line or 'autogenerated' not in first_line:
99 common.warn("Skipping test which isn't autogenerated: " + test)
Fangrui Songd24e6d72019-08-06 09:42:00 +0000100 continue
Philip Reames9bf59382019-08-05 18:25:08 +0000101
Bryant Wong291264b2016-12-29 19:32:34 +0000102 raw_lines = [m.group(1)
Fangrui Songee4e2e72018-01-30 00:40:05 +0000103 for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m]
Bryant Wong291264b2016-12-29 19:32:34 +0000104 run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
105 for l in raw_lines[1:]:
Fangrui Songd24e6d72019-08-06 09:42:00 +0000106 if run_lines[-1].endswith('\\'):
107 run_lines[-1] = run_lines[-1].rstrip('\\') + ' ' + l
Bryant Wong507256b2016-12-29 20:05:51 +0000108 else:
109 run_lines.append(l)
Bryant Wong291264b2016-12-29 19:32:34 +0000110
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000111 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000112 print('Found %d RUN lines:' % (len(run_lines),), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000113 for l in run_lines:
Serge Guelton4a274782019-01-03 14:11:33 +0000114 print(' RUN: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000115
116 prefix_list = []
117 for l in run_lines:
Philip Reames9bf59382019-08-05 18:25:08 +0000118 if '|' not in l:
David Bolvansky7169ea32019-08-07 14:44:50 +0000119 common.warn('Skipping unparseable RUN line: ' + l)
Philip Reames9bf59382019-08-05 18:25:08 +0000120 continue
Fangrui Songd24e6d72019-08-06 09:42:00 +0000121
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000122 (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)])
David Bolvansky45be5e42019-07-29 17:41:00 +0000123 common.verify_filecheck_prefixes(filecheck_cmd)
Sanjay Patelcae64a02017-06-12 17:44:30 +0000124 if not tool_cmd.startswith(opt_basename + ' '):
David Bolvansky7169ea32019-08-07 14:44:50 +0000125 common.warn('Skipping non-%s RUN line: %s' % (opt_basename, l))
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000126 continue
127
128 if not filecheck_cmd.startswith('FileCheck '):
David Bolvansky7169ea32019-08-07 14:44:50 +0000129 common.warn('Skipping non-FileChecked RUN line: ' + l)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000130 continue
131
Sanjay Patelcae64a02017-06-12 17:44:30 +0000132 tool_cmd_args = tool_cmd[len(opt_basename):].strip()
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000133 tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip()
134
Fangrui Songee4e2e72018-01-30 00:40:05 +0000135 check_prefixes = [item for m in common.CHECK_PREFIX_RE.finditer(filecheck_cmd)
Nikolai Bozhenov33ee40e2017-01-14 09:39:35 +0000136 for item in m.group(1).split(',')]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000137 if not check_prefixes:
138 check_prefixes = ['CHECK']
139
140 # FIXME: We should use multiple check prefixes to common check lines. For
141 # now, we just ignore all but the last.
142 prefix_list.append((check_prefixes, tool_cmd_args))
143
144 func_dict = {}
145 for prefixes, _ in prefix_list:
146 for prefix in prefixes:
147 func_dict.update({prefix: dict()})
Sanjay Patelcae64a02017-06-12 17:44:30 +0000148 for prefixes, opt_args in prefix_list:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000149 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000150 print('Extracted opt cmd: ' + opt_basename + ' ' + opt_args, file=sys.stderr)
151 print('Extracted FileCheck prefixes: ' + str(prefixes), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000152
Fangrui Songee4e2e72018-01-30 00:40:05 +0000153 raw_tool_output = common.invoke_tool(args.opt_binary, opt_args, test)
154 common.build_function_body_dictionary(
Fangrui Song4f0f4262018-02-10 05:01:33 +0000155 common.OPT_FUNCTION_RE, common.scrub_body, [],
156 raw_tool_output, prefixes, func_dict, args.verbose)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000157
158 is_in_function = False
159 is_in_function_start = False
160 prefix_set = set([prefix for prefixes, _ in prefix_list for prefix in prefixes])
161 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000162 print('Rewriting FileCheck prefixes: %s' % (prefix_set,), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000163 output_lines = []
164 output_lines.append(autogenerated_note)
165
166 for input_line in input_lines:
167 if is_in_function_start:
168 if input_line == '':
169 continue
170 if input_line.lstrip().startswith(';'):
Fangrui Songee4e2e72018-01-30 00:40:05 +0000171 m = common.CHECK_RE.match(input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000172 if not m or m.group(1) not in prefix_set:
173 output_lines.append(input_line)
174 continue
175
176 # Print out the various check lines here.
Simon Pilgrimabba0482018-04-05 09:30:42 +0000177 common.add_ir_checks(output_lines, ';', prefix_list, func_dict, func_name)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000178 is_in_function_start = False
179
180 if is_in_function:
Fangrui Songee4e2e72018-01-30 00:40:05 +0000181 if common.should_add_line_to_output(input_line, prefix_set):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000182 # This input line of the function body will go as-is into the output.
Sanjay Pateld8592712016-03-27 20:43:02 +0000183 # Except make leading whitespace uniform: 2 spaces.
Fangrui Songee4e2e72018-01-30 00:40:05 +0000184 input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000185 output_lines.append(input_line)
186 else:
187 continue
188 if input_line.strip() == '}':
189 is_in_function = False
190 continue
191
Sanjay Patel16be4df92016-04-05 19:50:21 +0000192 # Discard any previous script advertising.
193 if input_line.startswith(ADVERT):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000194 continue
195
196 # If it's outside a function, it just gets copied to the output.
197 output_lines.append(input_line)
198
199 m = IR_FUNCTION_RE.match(input_line)
200 if not m:
201 continue
Fangrui Songee4e2e72018-01-30 00:40:05 +0000202 func_name = m.group(1)
203 if args.function is not None and func_name != args.function:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000204 # When filtering on a specific function, skip all others.
205 continue
206 is_in_function = is_in_function_start = True
207
208 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000209 print('Writing %d lines to %s...' % (len(output_lines), test), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000210
211 with open(test, 'wb') as f:
Simon Pilgrimd82bd4d2019-01-30 16:15:59 +0000212 f.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines])
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000213
214
215if __name__ == '__main__':
216 main()