blob: 90c26e13db78af5aabf8457f2133cd54021aeca8 [file] [log] [blame]
Sebastian Pop41774802016-07-15 13:45:20 +00001//===- GVNHoist.cpp - Hoist scalar and load expressions -------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This pass hoists expressions from branches to a common dominator. It uses
11// GVN (global value numbering) to discover expressions computing the same
Aditya Kumarf24939b2016-08-13 11:56:50 +000012// values. The primary goals of code-hoisting are:
13// 1. To reduce the code size.
14// 2. In some cases reduce critical path (by exposing more ILP).
15//
Sebastian Pop41774802016-07-15 13:45:20 +000016// Hoisting may affect the performance in some cases. To mitigate that, hoisting
17// is disabled in the following cases.
18// 1. Scalars across calls.
19// 2. geps when corresponding load/store cannot be hoisted.
20//===----------------------------------------------------------------------===//
21
Sebastian Pop5ba9f242016-10-13 01:39:10 +000022#include "llvm/Transforms/Scalar/GVN.h"
Sebastian Pop41774802016-07-15 13:45:20 +000023#include "llvm/ADT/DenseMap.h"
24#include "llvm/ADT/SmallPtrSet.h"
25#include "llvm/ADT/Statistic.h"
26#include "llvm/Analysis/ValueTracking.h"
27#include "llvm/Transforms/Scalar.h"
David Majnemer68623a02016-07-25 02:21:25 +000028#include "llvm/Transforms/Utils/Local.h"
Sebastian Pop41774802016-07-15 13:45:20 +000029#include "llvm/Transforms/Utils/MemorySSA.h"
30
31using namespace llvm;
32
33#define DEBUG_TYPE "gvn-hoist"
34
35STATISTIC(NumHoisted, "Number of instructions hoisted");
36STATISTIC(NumRemoved, "Number of instructions removed");
37STATISTIC(NumLoadsHoisted, "Number of loads hoisted");
38STATISTIC(NumLoadsRemoved, "Number of loads removed");
39STATISTIC(NumStoresHoisted, "Number of stores hoisted");
40STATISTIC(NumStoresRemoved, "Number of stores removed");
41STATISTIC(NumCallsHoisted, "Number of calls hoisted");
42STATISTIC(NumCallsRemoved, "Number of calls removed");
43
44static cl::opt<int>
45 MaxHoistedThreshold("gvn-max-hoisted", cl::Hidden, cl::init(-1),
46 cl::desc("Max number of instructions to hoist "
47 "(default unlimited = -1)"));
48static cl::opt<int> MaxNumberOfBBSInPath(
49 "gvn-hoist-max-bbs", cl::Hidden, cl::init(4),
50 cl::desc("Max number of basic blocks on the path between "
51 "hoisting locations (default = 4, unlimited = -1)"));
52
Sebastian Pop38422b12016-07-26 00:15:08 +000053static cl::opt<int> MaxDepthInBB(
54 "gvn-hoist-max-depth", cl::Hidden, cl::init(100),
55 cl::desc("Hoist instructions from the beginning of the BB up to the "
56 "maximum specified depth (default = 100, unlimited = -1)"));
57
Sebastian Pop5ba9f242016-10-13 01:39:10 +000058static cl::opt<int>
59 MaxChainLength("gvn-hoist-max-chain-length", cl::Hidden, cl::init(10),
60 cl::desc("Maximum length of dependent chains to hoist "
61 "(default = 10, unlimited = -1)"));
Sebastian Pop2aadad72016-08-03 20:54:38 +000062
Sebastian Pop41774802016-07-15 13:45:20 +000063namespace {
64
65// Provides a sorting function based on the execution order of two instructions.
66struct SortByDFSIn {
67private:
Sebastian Pop91d4a302016-07-26 00:15:10 +000068 DenseMap<const Value *, unsigned> &DFSNumber;
Sebastian Pop41774802016-07-15 13:45:20 +000069
70public:
Sebastian Pop91d4a302016-07-26 00:15:10 +000071 SortByDFSIn(DenseMap<const Value *, unsigned> &D) : DFSNumber(D) {}
Sebastian Pop41774802016-07-15 13:45:20 +000072
73 // Returns true when A executes before B.
74 bool operator()(const Instruction *A, const Instruction *B) const {
75 // FIXME: libc++ has a std::sort() algorithm that will call the compare
76 // function on the same element. Once PR20837 is fixed and some more years
77 // pass by and all the buildbots have moved to a corrected std::sort(),
78 // enable the following assert:
79 //
80 // assert(A != B);
81
Sebastian Pop4ba7c882016-08-03 20:54:36 +000082 const BasicBlock *BA = A->getParent();
83 const BasicBlock *BB = B->getParent();
84 unsigned ADFS, BDFS;
85 if (BA == BB) {
86 ADFS = DFSNumber.lookup(A);
87 BDFS = DFSNumber.lookup(B);
88 } else {
89 ADFS = DFSNumber.lookup(BA);
90 BDFS = DFSNumber.lookup(BB);
91 }
Sebastian Pop5ba9f242016-10-13 01:39:10 +000092 assert(ADFS && BDFS);
Sebastian Pop91d4a302016-07-26 00:15:10 +000093 return ADFS < BDFS;
Sebastian Pop41774802016-07-15 13:45:20 +000094 }
95};
96
David Majnemer04c7c222016-07-18 06:11:37 +000097// A map from a pair of VNs to all the instructions with those VNs.
98typedef DenseMap<std::pair<unsigned, unsigned>, SmallVector<Instruction *, 4>>
99 VNtoInsns;
100// An invalid value number Used when inserting a single value number into
101// VNtoInsns.
Reid Kleckner3498ad12016-07-18 18:53:50 +0000102enum : unsigned { InvalidVN = ~2U };
Sebastian Pop41774802016-07-15 13:45:20 +0000103
104// Records all scalar instructions candidate for code hoisting.
105class InsnInfo {
106 VNtoInsns VNtoScalars;
107
108public:
109 // Inserts I and its value number in VNtoScalars.
110 void insert(Instruction *I, GVN::ValueTable &VN) {
111 // Scalar instruction.
112 unsigned V = VN.lookupOrAdd(I);
David Majnemer04c7c222016-07-18 06:11:37 +0000113 VNtoScalars[{V, InvalidVN}].push_back(I);
Sebastian Pop41774802016-07-15 13:45:20 +0000114 }
115
116 const VNtoInsns &getVNTable() const { return VNtoScalars; }
117};
118
119// Records all load instructions candidate for code hoisting.
120class LoadInfo {
121 VNtoInsns VNtoLoads;
122
123public:
124 // Insert Load and the value number of its memory address in VNtoLoads.
125 void insert(LoadInst *Load, GVN::ValueTable &VN) {
126 if (Load->isSimple()) {
127 unsigned V = VN.lookupOrAdd(Load->getPointerOperand());
David Majnemer04c7c222016-07-18 06:11:37 +0000128 VNtoLoads[{V, InvalidVN}].push_back(Load);
Sebastian Pop41774802016-07-15 13:45:20 +0000129 }
130 }
131
132 const VNtoInsns &getVNTable() const { return VNtoLoads; }
133};
134
135// Records all store instructions candidate for code hoisting.
136class StoreInfo {
137 VNtoInsns VNtoStores;
138
139public:
140 // Insert the Store and a hash number of the store address and the stored
141 // value in VNtoStores.
142 void insert(StoreInst *Store, GVN::ValueTable &VN) {
143 if (!Store->isSimple())
144 return;
145 // Hash the store address and the stored value.
146 Value *Ptr = Store->getPointerOperand();
147 Value *Val = Store->getValueOperand();
David Majnemer04c7c222016-07-18 06:11:37 +0000148 VNtoStores[{VN.lookupOrAdd(Ptr), VN.lookupOrAdd(Val)}].push_back(Store);
Sebastian Pop41774802016-07-15 13:45:20 +0000149 }
150
151 const VNtoInsns &getVNTable() const { return VNtoStores; }
152};
153
154// Records all call instructions candidate for code hoisting.
155class CallInfo {
156 VNtoInsns VNtoCallsScalars;
157 VNtoInsns VNtoCallsLoads;
158 VNtoInsns VNtoCallsStores;
159
160public:
161 // Insert Call and its value numbering in one of the VNtoCalls* containers.
162 void insert(CallInst *Call, GVN::ValueTable &VN) {
163 // A call that doesNotAccessMemory is handled as a Scalar,
164 // onlyReadsMemory will be handled as a Load instruction,
165 // all other calls will be handled as stores.
166 unsigned V = VN.lookupOrAdd(Call);
David Majnemer04c7c222016-07-18 06:11:37 +0000167 auto Entry = std::make_pair(V, InvalidVN);
Sebastian Pop41774802016-07-15 13:45:20 +0000168
169 if (Call->doesNotAccessMemory())
David Majnemer04c7c222016-07-18 06:11:37 +0000170 VNtoCallsScalars[Entry].push_back(Call);
Sebastian Pop41774802016-07-15 13:45:20 +0000171 else if (Call->onlyReadsMemory())
David Majnemer04c7c222016-07-18 06:11:37 +0000172 VNtoCallsLoads[Entry].push_back(Call);
Sebastian Pop41774802016-07-15 13:45:20 +0000173 else
David Majnemer04c7c222016-07-18 06:11:37 +0000174 VNtoCallsStores[Entry].push_back(Call);
Sebastian Pop41774802016-07-15 13:45:20 +0000175 }
176
177 const VNtoInsns &getScalarVNTable() const { return VNtoCallsScalars; }
178
179 const VNtoInsns &getLoadVNTable() const { return VNtoCallsLoads; }
180
181 const VNtoInsns &getStoreVNTable() const { return VNtoCallsStores; }
182};
183
184typedef DenseMap<const BasicBlock *, bool> BBSideEffectsSet;
185typedef SmallVector<Instruction *, 4> SmallVecInsn;
186typedef SmallVectorImpl<Instruction *> SmallVecImplInsn;
187
David Majnemer68623a02016-07-25 02:21:25 +0000188static void combineKnownMetadata(Instruction *ReplInst, Instruction *I) {
189 static const unsigned KnownIDs[] = {
190 LLVMContext::MD_tbaa, LLVMContext::MD_alias_scope,
191 LLVMContext::MD_noalias, LLVMContext::MD_range,
192 LLVMContext::MD_fpmath, LLVMContext::MD_invariant_load,
193 LLVMContext::MD_invariant_group};
194 combineMetadata(ReplInst, I, KnownIDs);
195}
196
Sebastian Pop41774802016-07-15 13:45:20 +0000197// This pass hoists common computations across branches sharing common
198// dominator. The primary goal is to reduce the code size, and in some
199// cases reduce critical path (by exposing more ILP).
200class GVNHoist {
201public:
Daniel Berlinea02eee2016-08-23 05:42:41 +0000202 GVNHoist(DominatorTree *DT, AliasAnalysis *AA, MemoryDependenceResults *MD,
203 MemorySSA *MSSA, bool OptForMinSize)
204 : DT(DT), AA(AA), MD(MD), MSSA(MSSA), OptForMinSize(OptForMinSize),
Aditya Kumar07cb3042016-11-29 14:34:01 +0000205 HoistingGeps(OptForMinSize), HoistedCtr(0) {
206 // Hoist as far as possible when optimizing for code-size.
207 if (OptForMinSize)
208 MaxNumberOfBBSInPath = -1;
209 }
210
Daniel Berlin65af45d2016-07-25 17:24:22 +0000211 bool run(Function &F) {
212 VN.setDomTree(DT);
213 VN.setAliasAnalysis(AA);
214 VN.setMemDep(MD);
215 bool Res = false;
Sebastian Pop4ba7c882016-08-03 20:54:36 +0000216 // Perform DFS Numbering of instructions.
217 unsigned BBI = 0;
218 for (const BasicBlock *BB : depth_first(&F.getEntryBlock())) {
219 DFSNumber[BB] = ++BBI;
220 unsigned I = 0;
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000221 for (auto &Inst : *BB)
Sebastian Pop4ba7c882016-08-03 20:54:36 +0000222 DFSNumber[&Inst] = ++I;
223 }
Daniel Berlin65af45d2016-07-25 17:24:22 +0000224
Sebastian Pop2aadad72016-08-03 20:54:38 +0000225 int ChainLength = 0;
226
Daniel Berlin65af45d2016-07-25 17:24:22 +0000227 // FIXME: use lazy evaluation of VN to avoid the fix-point computation.
228 while (1) {
Sebastian Pop2aadad72016-08-03 20:54:38 +0000229 if (MaxChainLength != -1 && ++ChainLength >= MaxChainLength)
230 return Res;
231
Daniel Berlin65af45d2016-07-25 17:24:22 +0000232 auto HoistStat = hoistExpressions(F);
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000233 if (HoistStat.first + HoistStat.second == 0)
Daniel Berlin65af45d2016-07-25 17:24:22 +0000234 return Res;
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000235
236 if (HoistStat.second > 0)
Daniel Berlin65af45d2016-07-25 17:24:22 +0000237 // To address a limitation of the current GVN, we need to rerun the
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000238 // hoisting after we hoisted loads or stores in order to be able to
239 // hoist all scalars dependent on the hoisted ld/st.
Daniel Berlin65af45d2016-07-25 17:24:22 +0000240 VN.clear();
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000241
Daniel Berlin65af45d2016-07-25 17:24:22 +0000242 Res = true;
243 }
244
245 return Res;
246 }
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000247
Daniel Berlin65af45d2016-07-25 17:24:22 +0000248private:
Sebastian Pop41774802016-07-15 13:45:20 +0000249 GVN::ValueTable VN;
250 DominatorTree *DT;
251 AliasAnalysis *AA;
252 MemoryDependenceResults *MD;
Daniel Berlinea02eee2016-08-23 05:42:41 +0000253 MemorySSA *MSSA;
Sebastian Pop41774802016-07-15 13:45:20 +0000254 const bool OptForMinSize;
Sebastian Pop55c30072016-07-27 05:48:12 +0000255 const bool HoistingGeps;
Sebastian Pop91d4a302016-07-26 00:15:10 +0000256 DenseMap<const Value *, unsigned> DFSNumber;
Sebastian Pop41774802016-07-15 13:45:20 +0000257 BBSideEffectsSet BBSideEffects;
David Majnemeraa241782016-07-18 00:35:01 +0000258 int HoistedCtr;
259
Sebastian Pop41774802016-07-15 13:45:20 +0000260 enum InsKind { Unknown, Scalar, Load, Store };
261
Sebastian Pop41774802016-07-15 13:45:20 +0000262 // Return true when there are exception handling in BB.
263 bool hasEH(const BasicBlock *BB) {
264 auto It = BBSideEffects.find(BB);
265 if (It != BBSideEffects.end())
266 return It->second;
267
268 if (BB->isEHPad() || BB->hasAddressTaken()) {
269 BBSideEffects[BB] = true;
270 return true;
271 }
272
273 if (BB->getTerminator()->mayThrow()) {
274 BBSideEffects[BB] = true;
275 return true;
276 }
277
278 BBSideEffects[BB] = false;
279 return false;
280 }
281
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000282 // Return true when a successor of BB dominates A.
283 bool successorDominate(const BasicBlock *BB, const BasicBlock *A) {
284 for (const BasicBlock *Succ : BB->getTerminator()->successors())
285 if (DT->dominates(Succ, A))
286 return true;
Sebastian Pop41774802016-07-15 13:45:20 +0000287
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000288 return false;
289 }
290
291 // Return true when all paths from HoistBB to the end of the function pass
292 // through one of the blocks in WL.
293 bool hoistingFromAllPaths(const BasicBlock *HoistBB,
294 SmallPtrSetImpl<const BasicBlock *> &WL) {
295
296 // Copy WL as the loop will remove elements from it.
297 SmallPtrSet<const BasicBlock *, 2> WorkList(WL.begin(), WL.end());
298
299 for (auto It = df_begin(HoistBB), E = df_end(HoistBB); It != E;) {
300 // There exists a path from HoistBB to the exit of the function if we are
301 // still iterating in DF traversal and we removed all instructions from
302 // the work list.
303 if (WorkList.empty())
Sebastian Pop41774802016-07-15 13:45:20 +0000304 return false;
305
306 const BasicBlock *BB = *It;
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000307 if (WorkList.erase(BB)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000308 // Stop DFS traversal when BB is in the work list.
309 It.skipChildren();
310 continue;
311 }
312
313 // Check for end of function, calls that do not return, etc.
314 if (!isGuaranteedToTransferExecutionToSuccessor(BB->getTerminator()))
315 return false;
316
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000317 // When reaching the back-edge of a loop, there may be a path through the
318 // loop that does not pass through B or C before exiting the loop.
319 if (successorDominate(BB, HoistBB))
320 return false;
321
Sebastian Pop41774802016-07-15 13:45:20 +0000322 // Increment DFS traversal when not skipping children.
323 ++It;
324 }
325
326 return true;
327 }
328
329 /* Return true when I1 appears before I2 in the instructions of BB. */
Sebastian Pop91d4a302016-07-26 00:15:10 +0000330 bool firstInBB(const Instruction *I1, const Instruction *I2) {
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000331 assert(I1->getParent() == I2->getParent());
Sebastian Pop91d4a302016-07-26 00:15:10 +0000332 unsigned I1DFS = DFSNumber.lookup(I1);
333 unsigned I2DFS = DFSNumber.lookup(I2);
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000334 assert(I1DFS && I2DFS);
Sebastian Pop91d4a302016-07-26 00:15:10 +0000335 return I1DFS < I2DFS;
Daniel Berlin40765a62016-07-25 18:19:49 +0000336 }
Sebastian Pop91d4a302016-07-26 00:15:10 +0000337
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000338 // Return true when there are memory uses of Def in BB.
339 bool hasMemoryUse(const Instruction *NewPt, MemoryDef *Def,
340 const BasicBlock *BB) {
341 const MemorySSA::AccessList *Acc = MSSA->getBlockAccesses(BB);
342 if (!Acc)
343 return false;
344
345 Instruction *OldPt = Def->getMemoryInst();
Sebastian Pop41774802016-07-15 13:45:20 +0000346 const BasicBlock *OldBB = OldPt->getParent();
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000347 const BasicBlock *NewBB = NewPt->getParent();
348 bool ReachedNewPt = false;
Sebastian Pop41774802016-07-15 13:45:20 +0000349
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000350 for (const MemoryAccess &MA : *Acc)
351 if (const MemoryUse *MU = dyn_cast<MemoryUse>(&MA)) {
352 Instruction *Insn = MU->getMemoryInst();
Sebastian Pop1531f302016-09-22 17:22:58 +0000353
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000354 // Do not check whether MU aliases Def when MU occurs after OldPt.
355 if (BB == OldBB && firstInBB(OldPt, Insn))
356 break;
357
358 // Do not check whether MU aliases Def when MU occurs before NewPt.
359 if (BB == NewBB) {
360 if (!ReachedNewPt) {
361 if (firstInBB(Insn, NewPt))
362 continue;
363 ReachedNewPt = true;
364 }
Sebastian Pop41774802016-07-15 13:45:20 +0000365 }
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000366 if (defClobbersUseOrDef(Def, MU, *AA))
Hans Wennborgc7957ef2016-09-22 21:20:53 +0000367 return true;
368 }
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000369
Sebastian Pop41774802016-07-15 13:45:20 +0000370 return false;
371 }
372
373 // Return true when there are exception handling or loads of memory Def
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000374 // between Def and NewPt. This function is only called for stores: Def is
375 // the MemoryDef of the store to be hoisted.
Sebastian Pop41774802016-07-15 13:45:20 +0000376
377 // Decrement by 1 NBBsOnAllPaths for each block between HoistPt and BB, and
378 // return true when the counter NBBsOnAllPaths reaces 0, except when it is
379 // initialized to -1 which is unlimited.
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000380 bool hasEHOrLoadsOnPath(const Instruction *NewPt, MemoryDef *Def,
381 int &NBBsOnAllPaths) {
Sebastian Pop41774802016-07-15 13:45:20 +0000382 const BasicBlock *NewBB = NewPt->getParent();
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000383 const BasicBlock *OldBB = Def->getBlock();
Sebastian Pop41774802016-07-15 13:45:20 +0000384 assert(DT->dominates(NewBB, OldBB) && "invalid path");
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000385 assert(DT->dominates(Def->getDefiningAccess()->getBlock(), NewBB) &&
Sebastian Pop41774802016-07-15 13:45:20 +0000386 "def does not dominate new hoisting point");
387
388 // Walk all basic blocks reachable in depth-first iteration on the inverse
389 // CFG from OldBB to NewBB. These blocks are all the blocks that may be
390 // executed between the execution of NewBB and OldBB. Hoisting an expression
391 // from OldBB into NewBB has to be safe on all execution paths.
392 for (auto I = idf_begin(OldBB), E = idf_end(OldBB); I != E;) {
393 if (*I == NewBB) {
394 // Stop traversal when reaching HoistPt.
395 I.skipChildren();
396 continue;
397 }
398
Aditya Kumar314ebe02016-11-29 14:36:27 +0000399 // Stop walk once the limit is reached.
400 if (NBBsOnAllPaths == 0)
401 return true;
402
Sebastian Pop41774802016-07-15 13:45:20 +0000403 // Impossible to hoist with exceptions on the path.
404 if (hasEH(*I))
405 return true;
406
407 // Check that we do not move a store past loads.
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000408 if (hasMemoryUse(NewPt, Def, *I))
Sebastian Pop41774802016-07-15 13:45:20 +0000409 return true;
410
Sebastian Pop41774802016-07-15 13:45:20 +0000411 // -1 is unlimited number of blocks on all paths.
412 if (NBBsOnAllPaths != -1)
413 --NBBsOnAllPaths;
414
415 ++I;
416 }
417
418 return false;
419 }
420
421 // Return true when there are exception handling between HoistPt and BB.
422 // Decrement by 1 NBBsOnAllPaths for each block between HoistPt and BB, and
423 // return true when the counter NBBsOnAllPaths reaches 0, except when it is
424 // initialized to -1 which is unlimited.
425 bool hasEHOnPath(const BasicBlock *HoistPt, const BasicBlock *BB,
426 int &NBBsOnAllPaths) {
427 assert(DT->dominates(HoistPt, BB) && "Invalid path");
428
429 // Walk all basic blocks reachable in depth-first iteration on
430 // the inverse CFG from BBInsn to NewHoistPt. These blocks are all the
431 // blocks that may be executed between the execution of NewHoistPt and
432 // BBInsn. Hoisting an expression from BBInsn into NewHoistPt has to be safe
433 // on all execution paths.
434 for (auto I = idf_begin(BB), E = idf_end(BB); I != E;) {
435 if (*I == HoistPt) {
436 // Stop traversal when reaching NewHoistPt.
437 I.skipChildren();
438 continue;
439 }
440
Sebastian Pop41774802016-07-15 13:45:20 +0000441 // Stop walk once the limit is reached.
442 if (NBBsOnAllPaths == 0)
443 return true;
444
Aditya Kumar314ebe02016-11-29 14:36:27 +0000445 // Impossible to hoist with exceptions on the path.
446 if (hasEH(*I))
447 return true;
448
Sebastian Pop41774802016-07-15 13:45:20 +0000449 // -1 is unlimited number of blocks on all paths.
450 if (NBBsOnAllPaths != -1)
451 --NBBsOnAllPaths;
452
453 ++I;
454 }
455
456 return false;
457 }
458
459 // Return true when it is safe to hoist a memory load or store U from OldPt
460 // to NewPt.
461 bool safeToHoistLdSt(const Instruction *NewPt, const Instruction *OldPt,
462 MemoryUseOrDef *U, InsKind K, int &NBBsOnAllPaths) {
463
464 // In place hoisting is safe.
465 if (NewPt == OldPt)
466 return true;
467
468 const BasicBlock *NewBB = NewPt->getParent();
469 const BasicBlock *OldBB = OldPt->getParent();
470 const BasicBlock *UBB = U->getBlock();
471
472 // Check for dependences on the Memory SSA.
473 MemoryAccess *D = U->getDefiningAccess();
474 BasicBlock *DBB = D->getBlock();
475 if (DT->properlyDominates(NewBB, DBB))
476 // Cannot move the load or store to NewBB above its definition in DBB.
477 return false;
478
479 if (NewBB == DBB && !MSSA->isLiveOnEntryDef(D))
David Majnemer4c66a712016-07-18 00:34:58 +0000480 if (auto *UD = dyn_cast<MemoryUseOrDef>(D))
Sebastian Pop91d4a302016-07-26 00:15:10 +0000481 if (firstInBB(NewPt, UD->getMemoryInst()))
Sebastian Pop41774802016-07-15 13:45:20 +0000482 // Cannot move the load or store to NewPt above its definition in D.
483 return false;
484
485 // Check for unsafe hoistings due to side effects.
486 if (K == InsKind::Store) {
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000487 if (hasEHOrLoadsOnPath(NewPt, dyn_cast<MemoryDef>(U), NBBsOnAllPaths))
Sebastian Pop41774802016-07-15 13:45:20 +0000488 return false;
489 } else if (hasEHOnPath(NewBB, OldBB, NBBsOnAllPaths))
490 return false;
491
492 if (UBB == NewBB) {
493 if (DT->properlyDominates(DBB, NewBB))
494 return true;
495 assert(UBB == DBB);
496 assert(MSSA->locallyDominates(D, U));
497 }
498
499 // No side effects: it is safe to hoist.
500 return true;
501 }
502
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000503 // Return true when it is safe to hoist scalar instructions from all blocks in
504 // WL to HoistBB.
505 bool safeToHoistScalar(const BasicBlock *HoistBB,
506 SmallPtrSetImpl<const BasicBlock *> &WL,
507 int &NBBsOnAllPaths) {
Aditya Kumar07cb3042016-11-29 14:34:01 +0000508 // Enable scalar hoisting at -Oz as it is safe to hoist scalars to a place
509 // where they are partially needed.
510 if (OptForMinSize)
511 return true;
512
513 // Check that the hoisted expression is needed on all paths.
514 if (!hoistingFromAllPaths(HoistBB, WL))
Sebastian Pop41774802016-07-15 13:45:20 +0000515 return false;
516
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000517 for (const BasicBlock *BB : WL)
518 if (hasEHOnPath(HoistBB, BB, NBBsOnAllPaths))
519 return false;
Sebastian Pop41774802016-07-15 13:45:20 +0000520
Sebastian Pop41774802016-07-15 13:45:20 +0000521 return true;
522 }
523
524 // Each element of a hoisting list contains the basic block where to hoist and
525 // a list of instructions to be hoisted.
526 typedef std::pair<BasicBlock *, SmallVecInsn> HoistingPointInfo;
527 typedef SmallVector<HoistingPointInfo, 4> HoistingPointList;
528
529 // Partition InstructionsToHoist into a set of candidates which can share a
530 // common hoisting point. The partitions are collected in HPL. IsScalar is
531 // true when the instructions in InstructionsToHoist are scalars. IsLoad is
532 // true when the InstructionsToHoist are loads, false when they are stores.
533 void partitionCandidates(SmallVecImplInsn &InstructionsToHoist,
534 HoistingPointList &HPL, InsKind K) {
535 // No need to sort for two instructions.
536 if (InstructionsToHoist.size() > 2) {
537 SortByDFSIn Pred(DFSNumber);
538 std::sort(InstructionsToHoist.begin(), InstructionsToHoist.end(), Pred);
539 }
540
Aditya Kumar314ebe02016-11-29 14:36:27 +0000541 int NumBBsOnAllPaths = MaxNumberOfBBSInPath;
Sebastian Pop41774802016-07-15 13:45:20 +0000542
543 SmallVecImplInsn::iterator II = InstructionsToHoist.begin();
544 SmallVecImplInsn::iterator Start = II;
545 Instruction *HoistPt = *II;
546 BasicBlock *HoistBB = HoistPt->getParent();
547 MemoryUseOrDef *UD;
548 if (K != InsKind::Scalar)
George Burgess IV66837ab2016-11-01 21:17:46 +0000549 UD = MSSA->getMemoryAccess(HoistPt);
Sebastian Pop41774802016-07-15 13:45:20 +0000550
551 for (++II; II != InstructionsToHoist.end(); ++II) {
552 Instruction *Insn = *II;
553 BasicBlock *BB = Insn->getParent();
554 BasicBlock *NewHoistBB;
555 Instruction *NewHoistPt;
556
Aditya Kumar314ebe02016-11-29 14:36:27 +0000557 if (BB == HoistBB) { // Both are in the same Basic Block.
Sebastian Pop41774802016-07-15 13:45:20 +0000558 NewHoistBB = HoistBB;
Sebastian Pop91d4a302016-07-26 00:15:10 +0000559 NewHoistPt = firstInBB(Insn, HoistPt) ? Insn : HoistPt;
Sebastian Pop41774802016-07-15 13:45:20 +0000560 } else {
Aditya Kumar314ebe02016-11-29 14:36:27 +0000561 // If the hoisting point contains one of the instructions,
562 // then hoist there, otherwise hoist before the terminator.
Sebastian Pop41774802016-07-15 13:45:20 +0000563 NewHoistBB = DT->findNearestCommonDominator(HoistBB, BB);
564 if (NewHoistBB == BB)
565 NewHoistPt = Insn;
566 else if (NewHoistBB == HoistBB)
567 NewHoistPt = HoistPt;
568 else
569 NewHoistPt = NewHoistBB->getTerminator();
570 }
571
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000572 SmallPtrSet<const BasicBlock *, 2> WL;
573 WL.insert(HoistBB);
574 WL.insert(BB);
575
Sebastian Pop41774802016-07-15 13:45:20 +0000576 if (K == InsKind::Scalar) {
Aditya Kumar314ebe02016-11-29 14:36:27 +0000577 if (safeToHoistScalar(NewHoistBB, WL, NumBBsOnAllPaths)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000578 // Extend HoistPt to NewHoistPt.
579 HoistPt = NewHoistPt;
580 HoistBB = NewHoistBB;
581 continue;
582 }
583 } else {
584 // When NewBB already contains an instruction to be hoisted, the
585 // expression is needed on all paths.
586 // Check that the hoisted expression is needed on all paths: it is
587 // unsafe to hoist loads to a place where there may be a path not
588 // loading from the same address: for instance there may be a branch on
589 // which the address of the load may not be initialized.
590 if ((HoistBB == NewHoistBB || BB == NewHoistBB ||
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000591 hoistingFromAllPaths(NewHoistBB, WL)) &&
Sebastian Pop41774802016-07-15 13:45:20 +0000592 // Also check that it is safe to move the load or store from HoistPt
593 // to NewHoistPt, and from Insn to NewHoistPt.
Aditya Kumar314ebe02016-11-29 14:36:27 +0000594 safeToHoistLdSt(NewHoistPt, HoistPt, UD, K, NumBBsOnAllPaths) &&
George Burgess IV66837ab2016-11-01 21:17:46 +0000595 safeToHoistLdSt(NewHoistPt, Insn, MSSA->getMemoryAccess(Insn),
Aditya Kumar314ebe02016-11-29 14:36:27 +0000596 K, NumBBsOnAllPaths)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000597 // Extend HoistPt to NewHoistPt.
598 HoistPt = NewHoistPt;
599 HoistBB = NewHoistBB;
600 continue;
601 }
602 }
603
604 // At this point it is not safe to extend the current hoisting to
605 // NewHoistPt: save the hoisting list so far.
606 if (std::distance(Start, II) > 1)
David Majnemer4c66a712016-07-18 00:34:58 +0000607 HPL.push_back({HoistBB, SmallVecInsn(Start, II)});
Sebastian Pop41774802016-07-15 13:45:20 +0000608
609 // Start over from BB.
610 Start = II;
611 if (K != InsKind::Scalar)
George Burgess IV66837ab2016-11-01 21:17:46 +0000612 UD = MSSA->getMemoryAccess(*Start);
Sebastian Pop41774802016-07-15 13:45:20 +0000613 HoistPt = Insn;
614 HoistBB = BB;
Aditya Kumar314ebe02016-11-29 14:36:27 +0000615 NumBBsOnAllPaths = MaxNumberOfBBSInPath;
Sebastian Pop41774802016-07-15 13:45:20 +0000616 }
617
618 // Save the last partition.
619 if (std::distance(Start, II) > 1)
David Majnemer4c66a712016-07-18 00:34:58 +0000620 HPL.push_back({HoistBB, SmallVecInsn(Start, II)});
Sebastian Pop41774802016-07-15 13:45:20 +0000621 }
622
623 // Initialize HPL from Map.
624 void computeInsertionPoints(const VNtoInsns &Map, HoistingPointList &HPL,
625 InsKind K) {
David Majnemer4c66a712016-07-18 00:34:58 +0000626 for (const auto &Entry : Map) {
Sebastian Pop41774802016-07-15 13:45:20 +0000627 if (MaxHoistedThreshold != -1 && ++HoistedCtr > MaxHoistedThreshold)
628 return;
629
David Majnemer4c66a712016-07-18 00:34:58 +0000630 const SmallVecInsn &V = Entry.second;
Sebastian Pop41774802016-07-15 13:45:20 +0000631 if (V.size() < 2)
632 continue;
633
634 // Compute the insertion point and the list of expressions to be hoisted.
635 SmallVecInsn InstructionsToHoist;
636 for (auto I : V)
637 if (!hasEH(I->getParent()))
638 InstructionsToHoist.push_back(I);
639
David Majnemer4c66a712016-07-18 00:34:58 +0000640 if (!InstructionsToHoist.empty())
Sebastian Pop41774802016-07-15 13:45:20 +0000641 partitionCandidates(InstructionsToHoist, HPL, K);
642 }
643 }
644
645 // Return true when all operands of Instr are available at insertion point
646 // HoistPt. When limiting the number of hoisted expressions, one could hoist
647 // a load without hoisting its access function. So before hoisting any
648 // expression, make sure that all its operands are available at insert point.
649 bool allOperandsAvailable(const Instruction *I,
650 const BasicBlock *HoistPt) const {
David Majnemer4c66a712016-07-18 00:34:58 +0000651 for (const Use &Op : I->operands())
652 if (const auto *Inst = dyn_cast<Instruction>(&Op))
653 if (!DT->dominates(Inst->getParent(), HoistPt))
654 return false;
Sebastian Pop41774802016-07-15 13:45:20 +0000655
656 return true;
657 }
658
Sebastian Pop55c30072016-07-27 05:48:12 +0000659 // Same as allOperandsAvailable with recursive check for GEP operands.
660 bool allGepOperandsAvailable(const Instruction *I,
661 const BasicBlock *HoistPt) const {
662 for (const Use &Op : I->operands())
663 if (const auto *Inst = dyn_cast<Instruction>(&Op))
664 if (!DT->dominates(Inst->getParent(), HoistPt)) {
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000665 if (const GetElementPtrInst *GepOp =
666 dyn_cast<GetElementPtrInst>(Inst)) {
Sebastian Pop55c30072016-07-27 05:48:12 +0000667 if (!allGepOperandsAvailable(GepOp, HoistPt))
668 return false;
669 // Gep is available if all operands of GepOp are available.
670 } else {
671 // Gep is not available if it has operands other than GEPs that are
672 // defined in blocks not dominating HoistPt.
673 return false;
674 }
675 }
676 return true;
677 }
678
679 // Make all operands of the GEP available.
680 void makeGepsAvailable(Instruction *Repl, BasicBlock *HoistPt,
681 const SmallVecInsn &InstructionsToHoist,
682 Instruction *Gep) const {
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000683 assert(allGepOperandsAvailable(Gep, HoistPt) &&
684 "GEP operands not available");
Sebastian Pop55c30072016-07-27 05:48:12 +0000685
686 Instruction *ClonedGep = Gep->clone();
687 for (unsigned i = 0, e = Gep->getNumOperands(); i != e; ++i)
688 if (Instruction *Op = dyn_cast<Instruction>(Gep->getOperand(i))) {
689
690 // Check whether the operand is already available.
691 if (DT->dominates(Op->getParent(), HoistPt))
692 continue;
693
694 // As a GEP can refer to other GEPs, recursively make all the operands
695 // of this GEP available at HoistPt.
696 if (GetElementPtrInst *GepOp = dyn_cast<GetElementPtrInst>(Op))
697 makeGepsAvailable(ClonedGep, HoistPt, InstructionsToHoist, GepOp);
698 }
699
700 // Copy Gep and replace its uses in Repl with ClonedGep.
701 ClonedGep->insertBefore(HoistPt->getTerminator());
702
703 // Conservatively discard any optimization hints, they may differ on the
704 // other paths.
705 ClonedGep->dropUnknownNonDebugMetadata();
706
707 // If we have optimization hints which agree with each other along different
708 // paths, preserve them.
709 for (const Instruction *OtherInst : InstructionsToHoist) {
710 const GetElementPtrInst *OtherGep;
711 if (auto *OtherLd = dyn_cast<LoadInst>(OtherInst))
712 OtherGep = cast<GetElementPtrInst>(OtherLd->getPointerOperand());
713 else
714 OtherGep = cast<GetElementPtrInst>(
715 cast<StoreInst>(OtherInst)->getPointerOperand());
Peter Collingbourne8f1dd5c2016-09-07 23:39:04 +0000716 ClonedGep->andIRFlags(OtherGep);
Sebastian Pop55c30072016-07-27 05:48:12 +0000717 }
718
719 // Replace uses of Gep with ClonedGep in Repl.
720 Repl->replaceUsesOfWith(Gep, ClonedGep);
721 }
722
723 // In the case Repl is a load or a store, we make all their GEPs
724 // available: GEPs are not hoisted by default to avoid the address
725 // computations to be hoisted without the associated load or store.
726 bool makeGepOperandsAvailable(Instruction *Repl, BasicBlock *HoistPt,
727 const SmallVecInsn &InstructionsToHoist) const {
Sebastian Pop41774802016-07-15 13:45:20 +0000728 // Check whether the GEP of a ld/st can be synthesized at HoistPt.
David Majnemerbd210122016-07-20 21:05:01 +0000729 GetElementPtrInst *Gep = nullptr;
Sebastian Pop41774802016-07-15 13:45:20 +0000730 Instruction *Val = nullptr;
Sebastian Pop55c30072016-07-27 05:48:12 +0000731 if (auto *Ld = dyn_cast<LoadInst>(Repl)) {
David Majnemerbd210122016-07-20 21:05:01 +0000732 Gep = dyn_cast<GetElementPtrInst>(Ld->getPointerOperand());
Sebastian Pop55c30072016-07-27 05:48:12 +0000733 } else if (auto *St = dyn_cast<StoreInst>(Repl)) {
David Majnemerbd210122016-07-20 21:05:01 +0000734 Gep = dyn_cast<GetElementPtrInst>(St->getPointerOperand());
Sebastian Pop41774802016-07-15 13:45:20 +0000735 Val = dyn_cast<Instruction>(St->getValueOperand());
Sebastian Pop31fd5062016-07-21 23:22:10 +0000736 // Check that the stored value is available.
Sebastian Pop0e2cec02016-07-22 00:07:01 +0000737 if (Val) {
738 if (isa<GetElementPtrInst>(Val)) {
739 // Check whether we can compute the GEP at HoistPt.
Sebastian Pop55c30072016-07-27 05:48:12 +0000740 if (!allGepOperandsAvailable(Val, HoistPt))
Sebastian Pop0e2cec02016-07-22 00:07:01 +0000741 return false;
742 } else if (!DT->dominates(Val->getParent(), HoistPt))
743 return false;
744 }
Sebastian Pop41774802016-07-15 13:45:20 +0000745 }
746
Sebastian Pop41774802016-07-15 13:45:20 +0000747 // Check whether we can compute the Gep at HoistPt.
Sebastian Pop55c30072016-07-27 05:48:12 +0000748 if (!Gep || !allGepOperandsAvailable(Gep, HoistPt))
Sebastian Pop41774802016-07-15 13:45:20 +0000749 return false;
750
Sebastian Pop55c30072016-07-27 05:48:12 +0000751 makeGepsAvailable(Repl, HoistPt, InstructionsToHoist, Gep);
Sebastian Pop41774802016-07-15 13:45:20 +0000752
Sebastian Pop55c30072016-07-27 05:48:12 +0000753 if (Val && isa<GetElementPtrInst>(Val))
754 makeGepsAvailable(Repl, HoistPt, InstructionsToHoist, Val);
Sebastian Pop41774802016-07-15 13:45:20 +0000755
756 return true;
757 }
758
759 std::pair<unsigned, unsigned> hoist(HoistingPointList &HPL) {
760 unsigned NI = 0, NL = 0, NS = 0, NC = 0, NR = 0;
761 for (const HoistingPointInfo &HP : HPL) {
762 // Find out whether we already have one of the instructions in HoistPt,
763 // in which case we do not have to move it.
764 BasicBlock *HoistPt = HP.first;
765 const SmallVecInsn &InstructionsToHoist = HP.second;
766 Instruction *Repl = nullptr;
767 for (Instruction *I : InstructionsToHoist)
Sebastian Pop586d3ea2016-07-27 05:13:52 +0000768 if (I->getParent() == HoistPt)
Sebastian Pop41774802016-07-15 13:45:20 +0000769 // If there are two instructions in HoistPt to be hoisted in place:
770 // update Repl to be the first one, such that we can rename the uses
771 // of the second based on the first.
Sebastian Pop586d3ea2016-07-27 05:13:52 +0000772 if (!Repl || firstInBB(I, Repl))
773 Repl = I;
Sebastian Pop41774802016-07-15 13:45:20 +0000774
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000775 // Keep track of whether we moved the instruction so we know whether we
776 // should move the MemoryAccess.
777 bool MoveAccess = true;
Sebastian Pop41774802016-07-15 13:45:20 +0000778 if (Repl) {
779 // Repl is already in HoistPt: it remains in place.
780 assert(allOperandsAvailable(Repl, HoistPt) &&
781 "instruction depends on operands that are not available");
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000782 MoveAccess = false;
Sebastian Pop41774802016-07-15 13:45:20 +0000783 } else {
784 // When we do not find Repl in HoistPt, select the first in the list
785 // and move it to HoistPt.
786 Repl = InstructionsToHoist.front();
787
788 // We can move Repl in HoistPt only when all operands are available.
789 // The order in which hoistings are done may influence the availability
790 // of operands.
Sebastian Pop429740a2016-08-04 23:49:05 +0000791 if (!allOperandsAvailable(Repl, HoistPt)) {
792
793 // When HoistingGeps there is nothing more we can do to make the
794 // operands available: just continue.
795 if (HoistingGeps)
796 continue;
797
798 // When not HoistingGeps we need to copy the GEPs.
799 if (!makeGepOperandsAvailable(Repl, HoistPt, InstructionsToHoist))
800 continue;
801 }
Sebastian Pop55c30072016-07-27 05:48:12 +0000802
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000803 // Move the instruction at the end of HoistPt.
Sebastian Pop4ba7c882016-08-03 20:54:36 +0000804 Instruction *Last = HoistPt->getTerminator();
Eli Friedmanc6885fc2016-12-07 19:55:59 +0000805 MD->removeInstruction(Repl);
Sebastian Pop4ba7c882016-08-03 20:54:36 +0000806 Repl->moveBefore(Last);
807
808 DFSNumber[Repl] = DFSNumber[Last]++;
Sebastian Pop41774802016-07-15 13:45:20 +0000809 }
810
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000811 MemoryAccess *NewMemAcc = MSSA->getMemoryAccess(Repl);
812
813 if (MoveAccess) {
814 if (MemoryUseOrDef *OldMemAcc =
815 dyn_cast_or_null<MemoryUseOrDef>(NewMemAcc)) {
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000816 // The definition of this ld/st will not change: ld/st hoisting is
817 // legal when the ld/st is not moved past its current definition.
818 MemoryAccess *Def = OldMemAcc->getDefiningAccess();
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000819 NewMemAcc =
820 MSSA->createMemoryAccessInBB(Repl, Def, HoistPt, MemorySSA::End);
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000821 OldMemAcc->replaceAllUsesWith(NewMemAcc);
822 MSSA->removeMemoryAccess(OldMemAcc);
823 }
824 }
825
Sebastian Pop41774802016-07-15 13:45:20 +0000826 if (isa<LoadInst>(Repl))
827 ++NL;
828 else if (isa<StoreInst>(Repl))
829 ++NS;
830 else if (isa<CallInst>(Repl))
831 ++NC;
832 else // Scalar
833 ++NI;
834
835 // Remove and rename all other instructions.
836 for (Instruction *I : InstructionsToHoist)
837 if (I != Repl) {
838 ++NR;
David Majnemer47285692016-07-25 02:21:23 +0000839 if (auto *ReplacementLoad = dyn_cast<LoadInst>(Repl)) {
840 ReplacementLoad->setAlignment(
841 std::min(ReplacementLoad->getAlignment(),
842 cast<LoadInst>(I)->getAlignment()));
Sebastian Pop41774802016-07-15 13:45:20 +0000843 ++NumLoadsRemoved;
David Majnemer47285692016-07-25 02:21:23 +0000844 } else if (auto *ReplacementStore = dyn_cast<StoreInst>(Repl)) {
845 ReplacementStore->setAlignment(
846 std::min(ReplacementStore->getAlignment(),
847 cast<StoreInst>(I)->getAlignment()));
Sebastian Pop41774802016-07-15 13:45:20 +0000848 ++NumStoresRemoved;
David Majnemer47285692016-07-25 02:21:23 +0000849 } else if (auto *ReplacementAlloca = dyn_cast<AllocaInst>(Repl)) {
850 ReplacementAlloca->setAlignment(
851 std::max(ReplacementAlloca->getAlignment(),
852 cast<AllocaInst>(I)->getAlignment()));
853 } else if (isa<CallInst>(Repl)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000854 ++NumCallsRemoved;
David Majnemer47285692016-07-25 02:21:23 +0000855 }
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000856
857 if (NewMemAcc) {
858 // Update the uses of the old MSSA access with NewMemAcc.
859 MemoryAccess *OldMA = MSSA->getMemoryAccess(I);
860 OldMA->replaceAllUsesWith(NewMemAcc);
861 MSSA->removeMemoryAccess(OldMA);
862 }
863
Peter Collingbourne8f1dd5c2016-09-07 23:39:04 +0000864 Repl->andIRFlags(I);
David Majnemer68623a02016-07-25 02:21:25 +0000865 combineKnownMetadata(Repl, I);
Sebastian Pop41774802016-07-15 13:45:20 +0000866 I->replaceAllUsesWith(Repl);
Sebastian Pop46601992016-08-27 02:48:41 +0000867 // Also invalidate the Alias Analysis cache.
868 MD->removeInstruction(I);
Sebastian Pop41774802016-07-15 13:45:20 +0000869 I->eraseFromParent();
870 }
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000871
872 // Remove MemorySSA phi nodes with the same arguments.
873 if (NewMemAcc) {
874 SmallPtrSet<MemoryPhi *, 4> UsePhis;
875 for (User *U : NewMemAcc->users())
876 if (MemoryPhi *Phi = dyn_cast<MemoryPhi>(U))
877 UsePhis.insert(Phi);
878
879 for (auto *Phi : UsePhis) {
880 auto In = Phi->incoming_values();
David Majnemer0a16c222016-08-11 21:15:00 +0000881 if (all_of(In, [&](Use &U) { return U == NewMemAcc; })) {
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000882 Phi->replaceAllUsesWith(NewMemAcc);
883 MSSA->removeMemoryAccess(Phi);
884 }
885 }
886 }
Sebastian Pop41774802016-07-15 13:45:20 +0000887 }
888
889 NumHoisted += NL + NS + NC + NI;
890 NumRemoved += NR;
891 NumLoadsHoisted += NL;
892 NumStoresHoisted += NS;
893 NumCallsHoisted += NC;
894 return {NI, NL + NC + NS};
895 }
896
897 // Hoist all expressions. Returns Number of scalars hoisted
898 // and number of non-scalars hoisted.
899 std::pair<unsigned, unsigned> hoistExpressions(Function &F) {
900 InsnInfo II;
901 LoadInfo LI;
902 StoreInfo SI;
903 CallInfo CI;
904 for (BasicBlock *BB : depth_first(&F.getEntryBlock())) {
Sebastian Pop38422b12016-07-26 00:15:08 +0000905 int InstructionNb = 0;
Sebastian Pop41774802016-07-15 13:45:20 +0000906 for (Instruction &I1 : *BB) {
Sebastian Pop38422b12016-07-26 00:15:08 +0000907 // Only hoist the first instructions in BB up to MaxDepthInBB. Hoisting
908 // deeper may increase the register pressure and compilation time.
909 if (MaxDepthInBB != -1 && InstructionNb++ >= MaxDepthInBB)
910 break;
911
Sebastian Pop440f15b2016-09-22 14:45:40 +0000912 // Do not value number terminator instructions.
Sebastian Pop5d68aa72016-09-22 15:08:09 +0000913 if (isa<TerminatorInst>(&I1))
Sebastian Pop440f15b2016-09-22 14:45:40 +0000914 break;
915
David Majnemer4c66a712016-07-18 00:34:58 +0000916 if (auto *Load = dyn_cast<LoadInst>(&I1))
Sebastian Pop41774802016-07-15 13:45:20 +0000917 LI.insert(Load, VN);
David Majnemer4c66a712016-07-18 00:34:58 +0000918 else if (auto *Store = dyn_cast<StoreInst>(&I1))
Sebastian Pop41774802016-07-15 13:45:20 +0000919 SI.insert(Store, VN);
David Majnemer4c66a712016-07-18 00:34:58 +0000920 else if (auto *Call = dyn_cast<CallInst>(&I1)) {
921 if (auto *Intr = dyn_cast<IntrinsicInst>(Call)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000922 if (isa<DbgInfoIntrinsic>(Intr) ||
923 Intr->getIntrinsicID() == Intrinsic::assume)
924 continue;
925 }
926 if (Call->mayHaveSideEffects()) {
927 if (!OptForMinSize)
928 break;
929 // We may continue hoisting across calls which write to memory.
930 if (Call->mayThrow())
931 break;
932 }
Matt Arsenault6ad97732016-08-04 20:52:57 +0000933
934 if (Call->isConvergent())
935 break;
936
Sebastian Pop41774802016-07-15 13:45:20 +0000937 CI.insert(Call, VN);
Sebastian Pop55c30072016-07-27 05:48:12 +0000938 } else if (HoistingGeps || !isa<GetElementPtrInst>(&I1))
Sebastian Pop41774802016-07-15 13:45:20 +0000939 // Do not hoist scalars past calls that may write to memory because
940 // that could result in spills later. geps are handled separately.
941 // TODO: We can relax this for targets like AArch64 as they have more
942 // registers than X86.
943 II.insert(&I1, VN);
944 }
945 }
946
947 HoistingPointList HPL;
948 computeInsertionPoints(II.getVNTable(), HPL, InsKind::Scalar);
949 computeInsertionPoints(LI.getVNTable(), HPL, InsKind::Load);
950 computeInsertionPoints(SI.getVNTable(), HPL, InsKind::Store);
951 computeInsertionPoints(CI.getScalarVNTable(), HPL, InsKind::Scalar);
952 computeInsertionPoints(CI.getLoadVNTable(), HPL, InsKind::Load);
953 computeInsertionPoints(CI.getStoreVNTable(), HPL, InsKind::Store);
954 return hoist(HPL);
955 }
Sebastian Pop41774802016-07-15 13:45:20 +0000956};
957
958class GVNHoistLegacyPass : public FunctionPass {
959public:
960 static char ID;
961
962 GVNHoistLegacyPass() : FunctionPass(ID) {
963 initializeGVNHoistLegacyPassPass(*PassRegistry::getPassRegistry());
964 }
965
966 bool runOnFunction(Function &F) override {
Paul Robinson2d23c022016-07-19 22:57:14 +0000967 if (skipFunction(F))
968 return false;
Sebastian Pop41774802016-07-15 13:45:20 +0000969 auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
970 auto &AA = getAnalysis<AAResultsWrapperPass>().getAAResults();
971 auto &MD = getAnalysis<MemoryDependenceWrapperPass>().getMemDep();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000972 auto &MSSA = getAnalysis<MemorySSAWrapperPass>().getMSSA();
Sebastian Pop41774802016-07-15 13:45:20 +0000973
Daniel Berlinea02eee2016-08-23 05:42:41 +0000974 GVNHoist G(&DT, &AA, &MD, &MSSA, F.optForMinSize());
Sebastian Pop41774802016-07-15 13:45:20 +0000975 return G.run(F);
976 }
977
978 void getAnalysisUsage(AnalysisUsage &AU) const override {
979 AU.addRequired<DominatorTreeWrapperPass>();
980 AU.addRequired<AAResultsWrapperPass>();
981 AU.addRequired<MemoryDependenceWrapperPass>();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000982 AU.addRequired<MemorySSAWrapperPass>();
Sebastian Pop41774802016-07-15 13:45:20 +0000983 AU.addPreserved<DominatorTreeWrapperPass>();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000984 AU.addPreserved<MemorySSAWrapperPass>();
Sebastian Pop41774802016-07-15 13:45:20 +0000985 }
986};
987} // namespace
988
Sebastian Pop5ba9f242016-10-13 01:39:10 +0000989PreservedAnalyses GVNHoistPass::run(Function &F, FunctionAnalysisManager &AM) {
Sebastian Pop41774802016-07-15 13:45:20 +0000990 DominatorTree &DT = AM.getResult<DominatorTreeAnalysis>(F);
991 AliasAnalysis &AA = AM.getResult<AAManager>(F);
992 MemoryDependenceResults &MD = AM.getResult<MemoryDependenceAnalysis>(F);
Daniel Berlinea02eee2016-08-23 05:42:41 +0000993 MemorySSA &MSSA = AM.getResult<MemorySSAAnalysis>(F).getMSSA();
994 GVNHoist G(&DT, &AA, &MD, &MSSA, F.optForMinSize());
Sebastian Pop41774802016-07-15 13:45:20 +0000995 if (!G.run(F))
996 return PreservedAnalyses::all();
997
998 PreservedAnalyses PA;
999 PA.preserve<DominatorTreeAnalysis>();
Daniel Berlinea02eee2016-08-23 05:42:41 +00001000 PA.preserve<MemorySSAAnalysis>();
Sebastian Pop41774802016-07-15 13:45:20 +00001001 return PA;
1002}
1003
1004char GVNHoistLegacyPass::ID = 0;
1005INITIALIZE_PASS_BEGIN(GVNHoistLegacyPass, "gvn-hoist",
1006 "Early GVN Hoisting of Expressions", false, false)
1007INITIALIZE_PASS_DEPENDENCY(MemoryDependenceWrapperPass)
Daniel Berlinea02eee2016-08-23 05:42:41 +00001008INITIALIZE_PASS_DEPENDENCY(MemorySSAWrapperPass)
Sebastian Pop41774802016-07-15 13:45:20 +00001009INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
1010INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
1011INITIALIZE_PASS_END(GVNHoistLegacyPass, "gvn-hoist",
1012 "Early GVN Hoisting of Expressions", false, false)
1013
1014FunctionPass *llvm::createGVNHoistPass() { return new GVNHoistLegacyPass(); }