blob: 89d3795b1b011e49bed752ede5f3dfa99dce3aac [file] [log] [blame]
George Karpenkov70c2ee32018-08-17 21:41:07 +00001//==-- RetainCountChecker.cpp - Checks for leaks and other issues -*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines the methods for RetainCountChecker, which implements
11// a reference count checker for Core Foundation and Cocoa on (Mac OS X).
12//
13//===----------------------------------------------------------------------===//
14
15#include "RetainCountChecker.h"
16
17using namespace clang;
18using namespace ento;
George Karpenkov70c2ee32018-08-17 21:41:07 +000019using namespace retaincountchecker;
20using llvm::StrInStrNoCase;
21
22REGISTER_MAP_WITH_PROGRAMSTATE(RefBindings, SymbolRef, RefVal)
23
24namespace clang {
25namespace ento {
26namespace retaincountchecker {
27
28const RefVal *getRefBinding(ProgramStateRef State, SymbolRef Sym) {
29 return State->get<RefBindings>(Sym);
30}
31
32ProgramStateRef setRefBinding(ProgramStateRef State, SymbolRef Sym,
33 RefVal Val) {
George Karpenkovd5ef0d22018-08-29 20:28:33 +000034 assert(Sym != nullptr);
George Karpenkov70c2ee32018-08-17 21:41:07 +000035 return State->set<RefBindings>(Sym, Val);
36}
37
38ProgramStateRef removeRefBinding(ProgramStateRef State, SymbolRef Sym) {
39 return State->remove<RefBindings>(Sym);
40}
41
42} // end namespace retaincountchecker
43} // end namespace ento
44} // end namespace clang
45
46void RefVal::print(raw_ostream &Out) const {
47 if (!T.isNull())
George Karpenkov081c4772018-10-23 23:11:50 +000048 Out << "Tracked " << T.getAsString() << " | ";
George Karpenkov70c2ee32018-08-17 21:41:07 +000049
50 switch (getKind()) {
51 default: llvm_unreachable("Invalid RefVal kind");
52 case Owned: {
53 Out << "Owned";
54 unsigned cnt = getCount();
55 if (cnt) Out << " (+ " << cnt << ")";
56 break;
57 }
58
59 case NotOwned: {
60 Out << "NotOwned";
61 unsigned cnt = getCount();
62 if (cnt) Out << " (+ " << cnt << ")";
63 break;
64 }
65
66 case ReturnedOwned: {
67 Out << "ReturnedOwned";
68 unsigned cnt = getCount();
69 if (cnt) Out << " (+ " << cnt << ")";
70 break;
71 }
72
73 case ReturnedNotOwned: {
74 Out << "ReturnedNotOwned";
75 unsigned cnt = getCount();
76 if (cnt) Out << " (+ " << cnt << ")";
77 break;
78 }
79
80 case Released:
81 Out << "Released";
82 break;
83
84 case ErrorDeallocNotOwned:
85 Out << "-dealloc (not-owned)";
86 break;
87
88 case ErrorLeak:
89 Out << "Leaked";
90 break;
91
92 case ErrorLeakReturned:
93 Out << "Leaked (Bad naming)";
94 break;
95
96 case ErrorUseAfterRelease:
97 Out << "Use-After-Release [ERROR]";
98 break;
99
100 case ErrorReleaseNotOwned:
101 Out << "Release of Not-Owned [ERROR]";
102 break;
103
104 case RefVal::ErrorOverAutorelease:
105 Out << "Over-autoreleased";
106 break;
107
108 case RefVal::ErrorReturnedNotOwned:
109 Out << "Non-owned object returned instead of owned";
110 break;
111 }
112
113 switch (getIvarAccessHistory()) {
114 case IvarAccessHistory::None:
115 break;
116 case IvarAccessHistory::AccessedDirectly:
117 Out << " [direct ivar access]";
118 break;
119 case IvarAccessHistory::ReleasedAfterDirectAccess:
120 Out << " [released after direct ivar access]";
121 }
122
123 if (ACnt) {
124 Out << " [autorelease -" << ACnt << ']';
125 }
126}
127
128namespace {
129class StopTrackingCallback final : public SymbolVisitor {
130 ProgramStateRef state;
131public:
132 StopTrackingCallback(ProgramStateRef st) : state(std::move(st)) {}
133 ProgramStateRef getState() const { return state; }
134
135 bool VisitSymbol(SymbolRef sym) override {
136 state = state->remove<RefBindings>(sym);
137 return true;
138 }
139};
140} // end anonymous namespace
141
142//===----------------------------------------------------------------------===//
143// Handle statements that may have an effect on refcounts.
144//===----------------------------------------------------------------------===//
145
146void RetainCountChecker::checkPostStmt(const BlockExpr *BE,
147 CheckerContext &C) const {
148
149 // Scan the BlockDecRefExprs for any object the retain count checker
150 // may be tracking.
151 if (!BE->getBlockDecl()->hasCaptures())
152 return;
153
154 ProgramStateRef state = C.getState();
155 auto *R = cast<BlockDataRegion>(C.getSVal(BE).getAsRegion());
156
157 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
158 E = R->referenced_vars_end();
159
160 if (I == E)
161 return;
162
163 // FIXME: For now we invalidate the tracking of all symbols passed to blocks
164 // via captured variables, even though captured variables result in a copy
165 // and in implicit increment/decrement of a retain count.
166 SmallVector<const MemRegion*, 10> Regions;
167 const LocationContext *LC = C.getLocationContext();
168 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
169
170 for ( ; I != E; ++I) {
171 const VarRegion *VR = I.getCapturedRegion();
172 if (VR->getSuperRegion() == R) {
173 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
174 }
175 Regions.push_back(VR);
176 }
177
George Karpenkovd3e76752018-10-23 23:12:12 +0000178 state = state->scanReachableSymbols<StopTrackingCallback>(Regions).getState();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000179 C.addTransition(state);
180}
181
182void RetainCountChecker::checkPostStmt(const CastExpr *CE,
183 CheckerContext &C) const {
184 const ObjCBridgedCastExpr *BE = dyn_cast<ObjCBridgedCastExpr>(CE);
185 if (!BE)
186 return;
187
188 ArgEffect AE = IncRef;
189
190 switch (BE->getBridgeKind()) {
191 case OBC_Bridge:
192 // Do nothing.
193 return;
194 case OBC_BridgeRetained:
195 AE = IncRef;
196 break;
197 case OBC_BridgeTransfer:
198 AE = DecRefBridgedTransferred;
199 break;
200 }
201
202 ProgramStateRef state = C.getState();
203 SymbolRef Sym = C.getSVal(CE).getAsLocSymbol();
204 if (!Sym)
205 return;
206 const RefVal* T = getRefBinding(state, Sym);
207 if (!T)
208 return;
209
210 RefVal::Kind hasErr = (RefVal::Kind) 0;
211 state = updateSymbol(state, Sym, *T, AE, hasErr, C);
212
213 if (hasErr) {
214 // FIXME: If we get an error during a bridge cast, should we report it?
215 return;
216 }
217
218 C.addTransition(state);
219}
220
221void RetainCountChecker::processObjCLiterals(CheckerContext &C,
222 const Expr *Ex) const {
223 ProgramStateRef state = C.getState();
224 const ExplodedNode *pred = C.getPredecessor();
225 for (const Stmt *Child : Ex->children()) {
226 SVal V = pred->getSVal(Child);
227 if (SymbolRef sym = V.getAsSymbol())
228 if (const RefVal* T = getRefBinding(state, sym)) {
229 RefVal::Kind hasErr = (RefVal::Kind) 0;
230 state = updateSymbol(state, sym, *T, MayEscape, hasErr, C);
231 if (hasErr) {
232 processNonLeakError(state, Child->getSourceRange(), hasErr, sym, C);
233 return;
234 }
235 }
236 }
237
238 // Return the object as autoreleased.
239 // RetEffect RE = RetEffect::MakeNotOwned(RetEffect::ObjC);
240 if (SymbolRef sym =
241 state->getSVal(Ex, pred->getLocationContext()).getAsSymbol()) {
242 QualType ResultTy = Ex->getType();
243 state = setRefBinding(state, sym,
244 RefVal::makeNotOwned(RetEffect::ObjC, ResultTy));
245 }
246
247 C.addTransition(state);
248}
249
250void RetainCountChecker::checkPostStmt(const ObjCArrayLiteral *AL,
251 CheckerContext &C) const {
252 // Apply the 'MayEscape' to all values.
253 processObjCLiterals(C, AL);
254}
255
256void RetainCountChecker::checkPostStmt(const ObjCDictionaryLiteral *DL,
257 CheckerContext &C) const {
258 // Apply the 'MayEscape' to all keys and values.
259 processObjCLiterals(C, DL);
260}
261
262void RetainCountChecker::checkPostStmt(const ObjCBoxedExpr *Ex,
263 CheckerContext &C) const {
264 const ExplodedNode *Pred = C.getPredecessor();
265 ProgramStateRef State = Pred->getState();
266
267 if (SymbolRef Sym = Pred->getSVal(Ex).getAsSymbol()) {
268 QualType ResultTy = Ex->getType();
269 State = setRefBinding(State, Sym,
270 RefVal::makeNotOwned(RetEffect::ObjC, ResultTy));
271 }
272
273 C.addTransition(State);
274}
275
276void RetainCountChecker::checkPostStmt(const ObjCIvarRefExpr *IRE,
277 CheckerContext &C) const {
278 Optional<Loc> IVarLoc = C.getSVal(IRE).getAs<Loc>();
279 if (!IVarLoc)
280 return;
281
282 ProgramStateRef State = C.getState();
283 SymbolRef Sym = State->getSVal(*IVarLoc).getAsSymbol();
284 if (!Sym || !dyn_cast_or_null<ObjCIvarRegion>(Sym->getOriginRegion()))
285 return;
286
287 // Accessing an ivar directly is unusual. If we've done that, be more
288 // forgiving about what the surrounding code is allowed to do.
289
290 QualType Ty = Sym->getType();
291 RetEffect::ObjKind Kind;
292 if (Ty->isObjCRetainableType())
293 Kind = RetEffect::ObjC;
294 else if (coreFoundation::isCFObjectRef(Ty))
295 Kind = RetEffect::CF;
296 else
297 return;
298
299 // If the value is already known to be nil, don't bother tracking it.
300 ConstraintManager &CMgr = State->getConstraintManager();
301 if (CMgr.isNull(State, Sym).isConstrainedTrue())
302 return;
303
304 if (const RefVal *RV = getRefBinding(State, Sym)) {
305 // If we've seen this symbol before, or we're only seeing it now because
306 // of something the analyzer has synthesized, don't do anything.
307 if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None ||
308 isSynthesizedAccessor(C.getStackFrame())) {
309 return;
310 }
311
312 // Note that this value has been loaded from an ivar.
313 C.addTransition(setRefBinding(State, Sym, RV->withIvarAccess()));
314 return;
315 }
316
317 RefVal PlusZero = RefVal::makeNotOwned(Kind, Ty);
318
319 // In a synthesized accessor, the effective retain count is +0.
320 if (isSynthesizedAccessor(C.getStackFrame())) {
321 C.addTransition(setRefBinding(State, Sym, PlusZero));
322 return;
323 }
324
325 State = setRefBinding(State, Sym, PlusZero.withIvarAccess());
326 C.addTransition(State);
327}
328
329void RetainCountChecker::checkPostCall(const CallEvent &Call,
330 CheckerContext &C) const {
331 RetainSummaryManager &Summaries = getSummaryManager(C);
George Karpenkovefef49c2018-08-21 03:09:02 +0000332
333 // Leave null if no receiver.
334 QualType ReceiverType;
335 if (const auto *MC = dyn_cast<ObjCMethodCall>(&Call)) {
336 if (MC->isInstanceMessage()) {
337 SVal ReceiverV = MC->getReceiverSVal();
338 if (SymbolRef Sym = ReceiverV.getAsLocSymbol())
339 if (const RefVal *T = getRefBinding(C.getState(), Sym))
340 ReceiverType = T->getType();
341 }
342 }
343
344 const RetainSummary *Summ = Summaries.getSummary(Call, ReceiverType);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000345
346 if (C.wasInlined) {
347 processSummaryOfInlined(*Summ, Call, C);
348 return;
349 }
350 checkSummary(*Summ, Call, C);
351}
352
353/// GetReturnType - Used to get the return type of a message expression or
354/// function call with the intention of affixing that type to a tracked symbol.
355/// While the return type can be queried directly from RetEx, when
356/// invoking class methods we augment to the return type to be that of
357/// a pointer to the class (as opposed it just being id).
358// FIXME: We may be able to do this with related result types instead.
359// This function is probably overestimating.
360static QualType GetReturnType(const Expr *RetE, ASTContext &Ctx) {
361 QualType RetTy = RetE->getType();
362 // If RetE is not a message expression just return its type.
363 // If RetE is a message expression, return its types if it is something
364 /// more specific than id.
365 if (const ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(RetE))
366 if (const ObjCObjectPointerType *PT = RetTy->getAs<ObjCObjectPointerType>())
367 if (PT->isObjCQualifiedIdType() || PT->isObjCIdType() ||
368 PT->isObjCClassType()) {
369 // At this point we know the return type of the message expression is
370 // id, id<...>, or Class. If we have an ObjCInterfaceDecl, we know this
371 // is a call to a class method whose type we can resolve. In such
372 // cases, promote the return type to XXX* (where XXX is the class).
373 const ObjCInterfaceDecl *D = ME->getReceiverInterface();
374 return !D ? RetTy :
375 Ctx.getObjCObjectPointerType(Ctx.getObjCInterfaceType(D));
376 }
377
378 return RetTy;
379}
380
George Karpenkov80c9e782018-08-22 01:16:49 +0000381static Optional<RefVal> refValFromRetEffect(RetEffect RE,
382 QualType ResultTy) {
383 if (RE.isOwned()) {
384 return RefVal::makeOwned(RE.getObjKind(), ResultTy);
385 } else if (RE.notOwned()) {
386 return RefVal::makeNotOwned(RE.getObjKind(), ResultTy);
387 }
388
389 return None;
390}
391
George Karpenkov70c2ee32018-08-17 21:41:07 +0000392// We don't always get the exact modeling of the function with regards to the
393// retain count checker even when the function is inlined. For example, we need
394// to stop tracking the symbols which were marked with StopTrackingHard.
395void RetainCountChecker::processSummaryOfInlined(const RetainSummary &Summ,
396 const CallEvent &CallOrMsg,
397 CheckerContext &C) const {
398 ProgramStateRef state = C.getState();
399
400 // Evaluate the effect of the arguments.
401 for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
402 if (Summ.getArg(idx) == StopTrackingHard) {
403 SVal V = CallOrMsg.getArgSVal(idx);
404 if (SymbolRef Sym = V.getAsLocSymbol()) {
405 state = removeRefBinding(state, Sym);
406 }
407 }
408 }
409
410 // Evaluate the effect on the message receiver.
George Karpenkov6e9fd132018-08-22 01:17:09 +0000411 if (const auto *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg)) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000412 if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
413 if (Summ.getReceiverEffect() == StopTrackingHard) {
414 state = removeRefBinding(state, Sym);
415 }
416 }
417 }
418
419 // Consult the summary for the return value.
420 RetEffect RE = Summ.getRetEffect();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000421
George Karpenkovd5ef0d22018-08-29 20:28:33 +0000422 if (SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol()) {
George Karpenkovd5ef0d22018-08-29 20:28:33 +0000423 if (RE.getKind() == RetEffect::NoRetHard)
424 state = removeRefBinding(state, Sym);
425 }
George Karpenkovab0011e2018-08-23 00:26:59 +0000426
George Karpenkov70c2ee32018-08-17 21:41:07 +0000427 C.addTransition(state);
428}
429
430static ProgramStateRef updateOutParameter(ProgramStateRef State,
431 SVal ArgVal,
432 ArgEffect Effect) {
433 auto *ArgRegion = dyn_cast_or_null<TypedValueRegion>(ArgVal.getAsRegion());
434 if (!ArgRegion)
435 return State;
436
437 QualType PointeeTy = ArgRegion->getValueType();
438 if (!coreFoundation::isCFObjectRef(PointeeTy))
439 return State;
440
441 SVal PointeeVal = State->getSVal(ArgRegion);
442 SymbolRef Pointee = PointeeVal.getAsLocSymbol();
443 if (!Pointee)
444 return State;
445
446 switch (Effect) {
447 case UnretainedOutParameter:
448 State = setRefBinding(State, Pointee,
449 RefVal::makeNotOwned(RetEffect::CF, PointeeTy));
450 break;
451 case RetainedOutParameter:
452 // Do nothing. Retained out parameters will either point to a +1 reference
453 // or NULL, but the way you check for failure differs depending on the API.
454 // Consequently, we don't have a good way to track them yet.
455 break;
456
457 default:
458 llvm_unreachable("only for out parameters");
459 }
460
461 return State;
462}
463
464void RetainCountChecker::checkSummary(const RetainSummary &Summ,
465 const CallEvent &CallOrMsg,
466 CheckerContext &C) const {
467 ProgramStateRef state = C.getState();
468
469 // Evaluate the effect of the arguments.
470 RefVal::Kind hasErr = (RefVal::Kind) 0;
471 SourceRange ErrorRange;
472 SymbolRef ErrorSym = nullptr;
473
474 for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
475 SVal V = CallOrMsg.getArgSVal(idx);
476
477 ArgEffect Effect = Summ.getArg(idx);
478 if (Effect == RetainedOutParameter || Effect == UnretainedOutParameter) {
479 state = updateOutParameter(state, V, Effect);
480 } else if (SymbolRef Sym = V.getAsLocSymbol()) {
481 if (const RefVal *T = getRefBinding(state, Sym)) {
482 state = updateSymbol(state, Sym, *T, Effect, hasErr, C);
483 if (hasErr) {
484 ErrorRange = CallOrMsg.getArgSourceRange(idx);
485 ErrorSym = Sym;
486 break;
487 }
488 }
489 }
490 }
491
George Karpenkovab0011e2018-08-23 00:26:59 +0000492 // Evaluate the effect on the message receiver / `this` argument.
George Karpenkov70c2ee32018-08-17 21:41:07 +0000493 bool ReceiverIsTracked = false;
494 if (!hasErr) {
George Karpenkovab0011e2018-08-23 00:26:59 +0000495 if (const auto *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg)) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000496 if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
497 if (const RefVal *T = getRefBinding(state, Sym)) {
498 ReceiverIsTracked = true;
499 state = updateSymbol(state, Sym, *T, Summ.getReceiverEffect(),
500 hasErr, C);
501 if (hasErr) {
502 ErrorRange = MsgInvocation->getOriginExpr()->getReceiverRange();
503 ErrorSym = Sym;
504 }
505 }
506 }
George Karpenkovab0011e2018-08-23 00:26:59 +0000507 } else if (const auto *MCall = dyn_cast<CXXMemberCall>(&CallOrMsg)) {
508 if (SymbolRef Sym = MCall->getCXXThisVal().getAsLocSymbol()) {
509 if (const RefVal *T = getRefBinding(state, Sym)) {
510 state = updateSymbol(state, Sym, *T, Summ.getThisEffect(),
511 hasErr, C);
512 if (hasErr) {
513 ErrorRange = MCall->getOriginExpr()->getSourceRange();
514 ErrorSym = Sym;
515 }
516 }
517 }
George Karpenkov70c2ee32018-08-17 21:41:07 +0000518 }
519 }
520
521 // Process any errors.
522 if (hasErr) {
523 processNonLeakError(state, ErrorRange, hasErr, ErrorSym, C);
524 return;
525 }
526
527 // Consult the summary for the return value.
528 RetEffect RE = Summ.getRetEffect();
529
530 if (RE.getKind() == RetEffect::OwnedWhenTrackedReceiver) {
531 if (ReceiverIsTracked)
532 RE = getSummaryManager(C).getObjAllocRetEffect();
533 else
534 RE = RetEffect::MakeNoRet();
535 }
536
George Karpenkov80c9e782018-08-22 01:16:49 +0000537 if (SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol()) {
538 QualType ResultTy = CallOrMsg.getResultType();
539 if (RE.notOwned()) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000540 const Expr *Ex = CallOrMsg.getOriginExpr();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000541 assert(Ex);
George Karpenkov80c9e782018-08-22 01:16:49 +0000542 ResultTy = GetReturnType(Ex, C.getASTContext());
George Karpenkov70c2ee32018-08-17 21:41:07 +0000543 }
George Karpenkov80c9e782018-08-22 01:16:49 +0000544 if (Optional<RefVal> updatedRefVal = refValFromRetEffect(RE, ResultTy))
545 state = setRefBinding(state, Sym, *updatedRefVal);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000546 }
547
548 // This check is actually necessary; otherwise the statement builder thinks
549 // we've hit a previously-found path.
550 // Normally addTransition takes care of this, but we want the node pointer.
551 ExplodedNode *NewNode;
552 if (state == C.getState()) {
553 NewNode = C.getPredecessor();
554 } else {
555 NewNode = C.addTransition(state);
556 }
557
558 // Annotate the node with summary we used.
559 if (NewNode) {
560 // FIXME: This is ugly. See checkEndAnalysis for why it's necessary.
561 if (ShouldResetSummaryLog) {
562 SummaryLog.clear();
563 ShouldResetSummaryLog = false;
564 }
565 SummaryLog[NewNode] = &Summ;
566 }
567}
568
569ProgramStateRef
570RetainCountChecker::updateSymbol(ProgramStateRef state, SymbolRef sym,
571 RefVal V, ArgEffect E, RefVal::Kind &hasErr,
572 CheckerContext &C) const {
573 bool IgnoreRetainMsg = (bool)C.getASTContext().getLangOpts().ObjCAutoRefCount;
574 switch (E) {
575 default:
576 break;
577 case IncRefMsg:
578 E = IgnoreRetainMsg ? DoNothing : IncRef;
579 break;
580 case DecRefMsg:
581 E = IgnoreRetainMsg ? DoNothing: DecRef;
582 break;
583 case DecRefMsgAndStopTrackingHard:
584 E = IgnoreRetainMsg ? StopTracking : DecRefAndStopTrackingHard;
585 break;
George Karpenkovbc0cddf2018-08-17 21:42:59 +0000586 case MakeCollectable:
587 E = DoNothing;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000588 }
589
590 // Handle all use-after-releases.
591 if (V.getKind() == RefVal::Released) {
592 V = V ^ RefVal::ErrorUseAfterRelease;
593 hasErr = V.getKind();
594 return setRefBinding(state, sym, V);
595 }
596
597 switch (E) {
598 case DecRefMsg:
599 case IncRefMsg:
George Karpenkovbc0cddf2018-08-17 21:42:59 +0000600 case MakeCollectable:
George Karpenkov70c2ee32018-08-17 21:41:07 +0000601 case DecRefMsgAndStopTrackingHard:
George Karpenkovbc0cddf2018-08-17 21:42:59 +0000602 llvm_unreachable("DecRefMsg/IncRefMsg/MakeCollectable already converted");
George Karpenkov70c2ee32018-08-17 21:41:07 +0000603
604 case UnretainedOutParameter:
605 case RetainedOutParameter:
606 llvm_unreachable("Applies to pointer-to-pointer parameters, which should "
607 "not have ref state.");
608
609 case Dealloc:
610 switch (V.getKind()) {
611 default:
612 llvm_unreachable("Invalid RefVal state for an explicit dealloc.");
613 case RefVal::Owned:
614 // The object immediately transitions to the released state.
615 V = V ^ RefVal::Released;
616 V.clearCounts();
617 return setRefBinding(state, sym, V);
618 case RefVal::NotOwned:
619 V = V ^ RefVal::ErrorDeallocNotOwned;
620 hasErr = V.getKind();
621 break;
622 }
623 break;
624
625 case MayEscape:
626 if (V.getKind() == RefVal::Owned) {
627 V = V ^ RefVal::NotOwned;
628 break;
629 }
630
Reid Kleckner4dc0b1a2018-11-01 19:54:45 +0000631 LLVM_FALLTHROUGH;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000632
633 case DoNothing:
634 return state;
635
636 case Autorelease:
637 // Update the autorelease counts.
638 V = V.autorelease();
639 break;
640
641 case StopTracking:
642 case StopTrackingHard:
643 return removeRefBinding(state, sym);
644
645 case IncRef:
646 switch (V.getKind()) {
647 default:
648 llvm_unreachable("Invalid RefVal state for a retain.");
649 case RefVal::Owned:
650 case RefVal::NotOwned:
651 V = V + 1;
652 break;
653 }
654 break;
655
656 case DecRef:
657 case DecRefBridgedTransferred:
658 case DecRefAndStopTrackingHard:
659 switch (V.getKind()) {
660 default:
661 // case 'RefVal::Released' handled above.
662 llvm_unreachable("Invalid RefVal state for a release.");
663
664 case RefVal::Owned:
665 assert(V.getCount() > 0);
666 if (V.getCount() == 1) {
667 if (E == DecRefBridgedTransferred ||
668 V.getIvarAccessHistory() ==
669 RefVal::IvarAccessHistory::AccessedDirectly)
670 V = V ^ RefVal::NotOwned;
671 else
672 V = V ^ RefVal::Released;
673 } else if (E == DecRefAndStopTrackingHard) {
674 return removeRefBinding(state, sym);
675 }
676
677 V = V - 1;
678 break;
679
680 case RefVal::NotOwned:
681 if (V.getCount() > 0) {
682 if (E == DecRefAndStopTrackingHard)
683 return removeRefBinding(state, sym);
684 V = V - 1;
685 } else if (V.getIvarAccessHistory() ==
686 RefVal::IvarAccessHistory::AccessedDirectly) {
687 // Assume that the instance variable was holding on the object at
688 // +1, and we just didn't know.
689 if (E == DecRefAndStopTrackingHard)
690 return removeRefBinding(state, sym);
691 V = V.releaseViaIvar() ^ RefVal::Released;
692 } else {
693 V = V ^ RefVal::ErrorReleaseNotOwned;
694 hasErr = V.getKind();
695 }
696 break;
697 }
698 break;
699 }
700 return setRefBinding(state, sym, V);
701}
702
703void RetainCountChecker::processNonLeakError(ProgramStateRef St,
704 SourceRange ErrorRange,
705 RefVal::Kind ErrorKind,
706 SymbolRef Sym,
707 CheckerContext &C) const {
708 // HACK: Ignore retain-count issues on values accessed through ivars,
709 // because of cases like this:
710 // [_contentView retain];
711 // [_contentView removeFromSuperview];
712 // [self addSubview:_contentView]; // invalidates 'self'
713 // [_contentView release];
714 if (const RefVal *RV = getRefBinding(St, Sym))
715 if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
716 return;
717
718 ExplodedNode *N = C.generateErrorNode(St);
719 if (!N)
720 return;
721
722 CFRefBug *BT;
723 switch (ErrorKind) {
724 default:
725 llvm_unreachable("Unhandled error.");
726 case RefVal::ErrorUseAfterRelease:
727 if (!useAfterRelease)
728 useAfterRelease.reset(new UseAfterRelease(this));
729 BT = useAfterRelease.get();
730 break;
731 case RefVal::ErrorReleaseNotOwned:
732 if (!releaseNotOwned)
733 releaseNotOwned.reset(new BadRelease(this));
734 BT = releaseNotOwned.get();
735 break;
736 case RefVal::ErrorDeallocNotOwned:
737 if (!deallocNotOwned)
738 deallocNotOwned.reset(new DeallocNotOwned(this));
739 BT = deallocNotOwned.get();
740 break;
741 }
742
743 assert(BT);
George Karpenkov6babf2a2018-09-21 20:36:21 +0000744 auto report = llvm::make_unique<CFRefReport>(
745 *BT, C.getASTContext().getLangOpts(), SummaryLog, N, Sym);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000746 report->addRange(ErrorRange);
747 C.emitReport(std::move(report));
748}
749
750//===----------------------------------------------------------------------===//
751// Handle the return values of retain-count-related functions.
752//===----------------------------------------------------------------------===//
753
754bool RetainCountChecker::evalCall(const CallExpr *CE, CheckerContext &C) const {
755 // Get the callee. We're only interested in simple C functions.
756 ProgramStateRef state = C.getState();
757 const FunctionDecl *FD = C.getCalleeDecl(CE);
758 if (!FD)
759 return false;
760
George Karpenkovc4d6b932018-08-17 21:42:05 +0000761 RetainSummaryManager &SmrMgr = getSummaryManager(C);
762 QualType ResultTy = CE->getCallReturnType(C.getASTContext());
George Karpenkov70c2ee32018-08-17 21:41:07 +0000763
George Karpenkov70c2ee32018-08-17 21:41:07 +0000764 // See if the function has 'rc_ownership_trusted_implementation'
765 // annotate attribute. If it does, we will not inline it.
766 bool hasTrustedImplementationAnnotation = false;
767
George Karpenkov41dc8de2018-10-11 22:59:16 +0000768 const LocationContext *LCtx = C.getLocationContext();
769
George Karpenkov3c2ed8f2018-10-25 23:38:07 +0000770 using BehaviorSummary = RetainSummaryManager::BehaviorSummary;
771 Optional<BehaviorSummary> BSmr =
772 SmrMgr.canEval(CE, FD, hasTrustedImplementationAnnotation);
773
George Karpenkovc4d6b932018-08-17 21:42:05 +0000774 // See if it's one of the specific functions we know how to eval.
George Karpenkov3c2ed8f2018-10-25 23:38:07 +0000775 if (!BSmr)
George Karpenkov70c2ee32018-08-17 21:41:07 +0000776 return false;
777
778 // Bind the return value.
George Karpenkov3c2ed8f2018-10-25 23:38:07 +0000779 if (BSmr == BehaviorSummary::Identity ||
780 BSmr == BehaviorSummary::IdentityOrZero) {
George Karpenkov48de5822018-10-23 23:11:30 +0000781 SVal RetVal = state->getSVal(CE->getArg(0), LCtx);
782
George Karpenkov70c2ee32018-08-17 21:41:07 +0000783 // If the receiver is unknown or the function has
784 // 'rc_ownership_trusted_implementation' annotate attribute, conjure a
785 // return value.
George Karpenkov48de5822018-10-23 23:11:30 +0000786 if (RetVal.isUnknown() ||
787 (hasTrustedImplementationAnnotation && !ResultTy.isNull())) {
788 SValBuilder &SVB = C.getSValBuilder();
789 RetVal =
790 SVB.conjureSymbolVal(nullptr, CE, LCtx, ResultTy, C.blockCount());
791 }
George Karpenkov3c2ed8f2018-10-25 23:38:07 +0000792 state = state->BindExpr(CE, LCtx, RetVal, /*Invalidate=*/false);
793
794 if (BSmr == BehaviorSummary::IdentityOrZero) {
795 // Add a branch where the output is zero.
796 ProgramStateRef NullOutputState = C.getState();
797
798 // Assume that output is zero on the other branch.
799 NullOutputState = NullOutputState->BindExpr(
800 CE, LCtx, C.getSValBuilder().makeNull(), /*Invalidate=*/false);
801
802 C.addTransition(NullOutputState);
803
804 // And on the original branch assume that both input and
805 // output are non-zero.
806 if (auto L = RetVal.getAs<DefinedOrUnknownSVal>())
807 state = state->assume(*L, /*Assumption=*/true);
808
809 }
George Karpenkov70c2ee32018-08-17 21:41:07 +0000810 }
George Karpenkov70c2ee32018-08-17 21:41:07 +0000811
George Karpenkov70c2ee32018-08-17 21:41:07 +0000812 C.addTransition(state);
813 return true;
814}
815
George Karpenkov04553e52018-09-21 20:37:20 +0000816ExplodedNode * RetainCountChecker::processReturn(const ReturnStmt *S,
817 CheckerContext &C) const {
818 ExplodedNode *Pred = C.getPredecessor();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000819
820 // Only adjust the reference count if this is the top-level call frame,
821 // and not the result of inlining. In the future, we should do
822 // better checking even for inlined calls, and see if they match
823 // with their expected semantics (e.g., the method should return a retained
824 // object, etc.).
825 if (!C.inTopFrame())
George Karpenkov04553e52018-09-21 20:37:20 +0000826 return Pred;
827
828 if (!S)
829 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000830
831 const Expr *RetE = S->getRetValue();
832 if (!RetE)
George Karpenkov04553e52018-09-21 20:37:20 +0000833 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000834
835 ProgramStateRef state = C.getState();
836 SymbolRef Sym =
837 state->getSValAsScalarOrLoc(RetE, C.getLocationContext()).getAsLocSymbol();
838 if (!Sym)
George Karpenkov04553e52018-09-21 20:37:20 +0000839 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000840
841 // Get the reference count binding (if any).
842 const RefVal *T = getRefBinding(state, Sym);
843 if (!T)
George Karpenkov04553e52018-09-21 20:37:20 +0000844 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000845
846 // Change the reference count.
847 RefVal X = *T;
848
849 switch (X.getKind()) {
850 case RefVal::Owned: {
851 unsigned cnt = X.getCount();
852 assert(cnt > 0);
853 X.setCount(cnt - 1);
854 X = X ^ RefVal::ReturnedOwned;
855 break;
856 }
857
858 case RefVal::NotOwned: {
859 unsigned cnt = X.getCount();
860 if (cnt) {
861 X.setCount(cnt - 1);
862 X = X ^ RefVal::ReturnedOwned;
George Karpenkov04553e52018-09-21 20:37:20 +0000863 } else {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000864 X = X ^ RefVal::ReturnedNotOwned;
865 }
866 break;
867 }
868
869 default:
George Karpenkov04553e52018-09-21 20:37:20 +0000870 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000871 }
872
873 // Update the binding.
874 state = setRefBinding(state, Sym, X);
George Karpenkov04553e52018-09-21 20:37:20 +0000875 Pred = C.addTransition(state);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000876
877 // At this point we have updated the state properly.
878 // Everything after this is merely checking to see if the return value has
879 // been over- or under-retained.
880
881 // Did we cache out?
882 if (!Pred)
George Karpenkov04553e52018-09-21 20:37:20 +0000883 return nullptr;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000884
885 // Update the autorelease counts.
886 static CheckerProgramPointTag AutoreleaseTag(this, "Autorelease");
George Karpenkov04553e52018-09-21 20:37:20 +0000887 state = handleAutoreleaseCounts(state, Pred, &AutoreleaseTag, C, Sym, X, S);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000888
George Karpenkov04553e52018-09-21 20:37:20 +0000889 // Have we generated a sink node?
George Karpenkov70c2ee32018-08-17 21:41:07 +0000890 if (!state)
George Karpenkov04553e52018-09-21 20:37:20 +0000891 return nullptr;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000892
893 // Get the updated binding.
894 T = getRefBinding(state, Sym);
895 assert(T);
896 X = *T;
897
898 // Consult the summary of the enclosing method.
899 RetainSummaryManager &Summaries = getSummaryManager(C);
900 const Decl *CD = &Pred->getCodeDecl();
901 RetEffect RE = RetEffect::MakeNoRet();
902
903 // FIXME: What is the convention for blocks? Is there one?
904 if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(CD)) {
905 const RetainSummary *Summ = Summaries.getMethodSummary(MD);
906 RE = Summ->getRetEffect();
907 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(CD)) {
908 if (!isa<CXXMethodDecl>(FD)) {
909 const RetainSummary *Summ = Summaries.getFunctionSummary(FD);
910 RE = Summ->getRetEffect();
911 }
912 }
913
George Karpenkov04553e52018-09-21 20:37:20 +0000914 return checkReturnWithRetEffect(S, C, Pred, RE, X, Sym, state);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000915}
916
George Karpenkov04553e52018-09-21 20:37:20 +0000917ExplodedNode * RetainCountChecker::checkReturnWithRetEffect(const ReturnStmt *S,
George Karpenkov70c2ee32018-08-17 21:41:07 +0000918 CheckerContext &C,
919 ExplodedNode *Pred,
920 RetEffect RE, RefVal X,
921 SymbolRef Sym,
922 ProgramStateRef state) const {
923 // HACK: Ignore retain-count issues on values accessed through ivars,
924 // because of cases like this:
925 // [_contentView retain];
926 // [_contentView removeFromSuperview];
927 // [self addSubview:_contentView]; // invalidates 'self'
928 // [_contentView release];
929 if (X.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
George Karpenkov04553e52018-09-21 20:37:20 +0000930 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000931
932 // Any leaks or other errors?
933 if (X.isReturnedOwned() && X.getCount() == 0) {
934 if (RE.getKind() != RetEffect::NoRet) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000935 if (!RE.isOwned()) {
George Karpenkov04553e52018-09-21 20:37:20 +0000936
George Karpenkov70c2ee32018-08-17 21:41:07 +0000937 // The returning type is a CF, we expect the enclosing method should
938 // return ownership.
George Karpenkov70c2ee32018-08-17 21:41:07 +0000939 X = X ^ RefVal::ErrorLeakReturned;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000940
George Karpenkov70c2ee32018-08-17 21:41:07 +0000941 // Generate an error node.
942 state = setRefBinding(state, Sym, X);
943
944 static CheckerProgramPointTag ReturnOwnLeakTag(this, "ReturnsOwnLeak");
945 ExplodedNode *N = C.addTransition(state, Pred, &ReturnOwnLeakTag);
946 if (N) {
947 const LangOptions &LOpts = C.getASTContext().getLangOpts();
George Karpenkov04553e52018-09-21 20:37:20 +0000948 auto R = llvm::make_unique<CFRefLeakReport>(
George Karpenkov6babf2a2018-09-21 20:36:21 +0000949 *getLeakAtReturnBug(LOpts), LOpts, SummaryLog, N, Sym, C,
George Karpenkov04553e52018-09-21 20:37:20 +0000950 IncludeAllocationLine);
951 C.emitReport(std::move(R));
George Karpenkov70c2ee32018-08-17 21:41:07 +0000952 }
George Karpenkov04553e52018-09-21 20:37:20 +0000953 return N;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000954 }
955 }
956 } else if (X.isReturnedNotOwned()) {
957 if (RE.isOwned()) {
958 if (X.getIvarAccessHistory() ==
959 RefVal::IvarAccessHistory::AccessedDirectly) {
960 // Assume the method was trying to transfer a +1 reference from a
961 // strong ivar to the caller.
962 state = setRefBinding(state, Sym,
963 X.releaseViaIvar() ^ RefVal::ReturnedOwned);
964 } else {
965 // Trying to return a not owned object to a caller expecting an
966 // owned object.
967 state = setRefBinding(state, Sym, X ^ RefVal::ErrorReturnedNotOwned);
968
969 static CheckerProgramPointTag
970 ReturnNotOwnedTag(this, "ReturnNotOwnedForOwned");
971
972 ExplodedNode *N = C.addTransition(state, Pred, &ReturnNotOwnedTag);
973 if (N) {
974 if (!returnNotOwnedForOwned)
975 returnNotOwnedForOwned.reset(new ReturnedNotOwnedForOwned(this));
976
George Karpenkov04553e52018-09-21 20:37:20 +0000977 auto R = llvm::make_unique<CFRefReport>(
George Karpenkov70c2ee32018-08-17 21:41:07 +0000978 *returnNotOwnedForOwned, C.getASTContext().getLangOpts(),
George Karpenkov04553e52018-09-21 20:37:20 +0000979 SummaryLog, N, Sym);
980 C.emitReport(std::move(R));
George Karpenkov70c2ee32018-08-17 21:41:07 +0000981 }
George Karpenkov04553e52018-09-21 20:37:20 +0000982 return N;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000983 }
984 }
985 }
George Karpenkov04553e52018-09-21 20:37:20 +0000986 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000987}
988
989//===----------------------------------------------------------------------===//
990// Check various ways a symbol can be invalidated.
991//===----------------------------------------------------------------------===//
992
993void RetainCountChecker::checkBind(SVal loc, SVal val, const Stmt *S,
994 CheckerContext &C) const {
995 // Are we storing to something that causes the value to "escape"?
996 bool escapes = true;
997
998 // A value escapes in three possible cases (this may change):
999 //
1000 // (1) we are binding to something that is not a memory region.
1001 // (2) we are binding to a memregion that does not have stack storage
1002 // (3) we are binding to a memregion with stack storage that the store
1003 // does not understand.
1004 ProgramStateRef state = C.getState();
1005
George Karpenkov6e9fd132018-08-22 01:17:09 +00001006 if (auto regionLoc = loc.getAs<loc::MemRegionVal>()) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001007 escapes = !regionLoc->getRegion()->hasStackStorage();
1008
1009 if (!escapes) {
1010 // To test (3), generate a new state with the binding added. If it is
1011 // the same state, then it escapes (since the store cannot represent
1012 // the binding).
1013 // Do this only if we know that the store is not supposed to generate the
1014 // same state.
1015 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1016 if (StoredVal != val)
1017 escapes = (state == (state->bindLoc(*regionLoc, val, C.getLocationContext())));
1018 }
1019 if (!escapes) {
1020 // Case 4: We do not currently model what happens when a symbol is
1021 // assigned to a struct field, so be conservative here and let the symbol
1022 // go. TODO: This could definitely be improved upon.
1023 escapes = !isa<VarRegion>(regionLoc->getRegion());
1024 }
1025 }
1026
1027 // If we are storing the value into an auto function scope variable annotated
1028 // with (__attribute__((cleanup))), stop tracking the value to avoid leak
1029 // false positives.
George Karpenkov6e9fd132018-08-22 01:17:09 +00001030 if (const auto *LVR = dyn_cast_or_null<VarRegion>(loc.getAsRegion())) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001031 const VarDecl *VD = LVR->getDecl();
1032 if (VD->hasAttr<CleanupAttr>()) {
1033 escapes = true;
1034 }
1035 }
1036
1037 // If our store can represent the binding and we aren't storing to something
1038 // that doesn't have local storage then just return and have the simulation
1039 // state continue as is.
1040 if (!escapes)
1041 return;
1042
1043 // Otherwise, find all symbols referenced by 'val' that we are tracking
1044 // and stop tracking them.
1045 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1046 C.addTransition(state);
1047}
1048
1049ProgramStateRef RetainCountChecker::evalAssume(ProgramStateRef state,
George Karpenkov6e9fd132018-08-22 01:17:09 +00001050 SVal Cond,
1051 bool Assumption) const {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001052 // FIXME: We may add to the interface of evalAssume the list of symbols
1053 // whose assumptions have changed. For now we just iterate through the
1054 // bindings and check if any of the tracked symbols are NULL. This isn't
1055 // too bad since the number of symbols we will track in practice are
1056 // probably small and evalAssume is only called at branches and a few
1057 // other places.
1058 RefBindingsTy B = state->get<RefBindings>();
1059
1060 if (B.isEmpty())
1061 return state;
1062
1063 bool changed = false;
1064 RefBindingsTy::Factory &RefBFactory = state->get_context<RefBindings>();
1065
1066 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1067 // Check if the symbol is null stop tracking the symbol.
1068 ConstraintManager &CMgr = state->getConstraintManager();
1069 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1070 if (AllocFailed.isConstrainedTrue()) {
1071 changed = true;
1072 B = RefBFactory.remove(B, I.getKey());
1073 }
1074 }
1075
1076 if (changed)
1077 state = state->set<RefBindings>(B);
1078
1079 return state;
1080}
1081
1082ProgramStateRef
1083RetainCountChecker::checkRegionChanges(ProgramStateRef state,
1084 const InvalidatedSymbols *invalidated,
1085 ArrayRef<const MemRegion *> ExplicitRegions,
1086 ArrayRef<const MemRegion *> Regions,
1087 const LocationContext *LCtx,
1088 const CallEvent *Call) const {
1089 if (!invalidated)
1090 return state;
1091
1092 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
1093 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1094 E = ExplicitRegions.end(); I != E; ++I) {
1095 if (const SymbolicRegion *SR = (*I)->StripCasts()->getAs<SymbolicRegion>())
1096 WhitelistedSymbols.insert(SR->getSymbol());
1097 }
1098
George Karpenkov6fd5c86d2018-10-31 17:38:29 +00001099 for (SymbolRef sym :
1100 llvm::make_range(invalidated->begin(), invalidated->end())) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001101 if (WhitelistedSymbols.count(sym))
1102 continue;
1103 // Remove any existing reference-count binding.
1104 state = removeRefBinding(state, sym);
1105 }
1106 return state;
1107}
1108
George Karpenkov70c2ee32018-08-17 21:41:07 +00001109ProgramStateRef
1110RetainCountChecker::handleAutoreleaseCounts(ProgramStateRef state,
1111 ExplodedNode *Pred,
1112 const ProgramPointTag *Tag,
1113 CheckerContext &Ctx,
George Karpenkov04553e52018-09-21 20:37:20 +00001114 SymbolRef Sym,
1115 RefVal V,
1116 const ReturnStmt *S) const {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001117 unsigned ACnt = V.getAutoreleaseCount();
1118
1119 // No autorelease counts? Nothing to be done.
1120 if (!ACnt)
1121 return state;
1122
1123 unsigned Cnt = V.getCount();
1124
1125 // FIXME: Handle sending 'autorelease' to already released object.
1126
1127 if (V.getKind() == RefVal::ReturnedOwned)
1128 ++Cnt;
1129
1130 // If we would over-release here, but we know the value came from an ivar,
1131 // assume it was a strong ivar that's just been relinquished.
1132 if (ACnt > Cnt &&
1133 V.getIvarAccessHistory() == RefVal::IvarAccessHistory::AccessedDirectly) {
1134 V = V.releaseViaIvar();
1135 --ACnt;
1136 }
1137
1138 if (ACnt <= Cnt) {
1139 if (ACnt == Cnt) {
1140 V.clearCounts();
George Karpenkov04553e52018-09-21 20:37:20 +00001141 if (V.getKind() == RefVal::ReturnedOwned) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001142 V = V ^ RefVal::ReturnedNotOwned;
George Karpenkov04553e52018-09-21 20:37:20 +00001143 } else {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001144 V = V ^ RefVal::NotOwned;
George Karpenkov04553e52018-09-21 20:37:20 +00001145 }
George Karpenkov70c2ee32018-08-17 21:41:07 +00001146 } else {
1147 V.setCount(V.getCount() - ACnt);
1148 V.setAutoreleaseCount(0);
1149 }
1150 return setRefBinding(state, Sym, V);
1151 }
1152
1153 // HACK: Ignore retain-count issues on values accessed through ivars,
1154 // because of cases like this:
1155 // [_contentView retain];
1156 // [_contentView removeFromSuperview];
1157 // [self addSubview:_contentView]; // invalidates 'self'
1158 // [_contentView release];
1159 if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1160 return state;
1161
1162 // Woah! More autorelease counts then retain counts left.
1163 // Emit hard error.
1164 V = V ^ RefVal::ErrorOverAutorelease;
1165 state = setRefBinding(state, Sym, V);
1166
1167 ExplodedNode *N = Ctx.generateSink(state, Pred, Tag);
1168 if (N) {
1169 SmallString<128> sbuf;
1170 llvm::raw_svector_ostream os(sbuf);
1171 os << "Object was autoreleased ";
1172 if (V.getAutoreleaseCount() > 1)
1173 os << V.getAutoreleaseCount() << " times but the object ";
1174 else
1175 os << "but ";
1176 os << "has a +" << V.getCount() << " retain count";
1177
1178 if (!overAutorelease)
1179 overAutorelease.reset(new OverAutorelease(this));
1180
1181 const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
George Karpenkov04553e52018-09-21 20:37:20 +00001182 auto R = llvm::make_unique<CFRefReport>(*overAutorelease, LOpts, SummaryLog,
1183 N, Sym, os.str());
1184 Ctx.emitReport(std::move(R));
George Karpenkov70c2ee32018-08-17 21:41:07 +00001185 }
1186
1187 return nullptr;
1188}
1189
1190ProgramStateRef
1191RetainCountChecker::handleSymbolDeath(ProgramStateRef state,
1192 SymbolRef sid, RefVal V,
1193 SmallVectorImpl<SymbolRef> &Leaked) const {
1194 bool hasLeak;
1195
1196 // HACK: Ignore retain-count issues on values accessed through ivars,
1197 // because of cases like this:
1198 // [_contentView retain];
1199 // [_contentView removeFromSuperview];
1200 // [self addSubview:_contentView]; // invalidates 'self'
1201 // [_contentView release];
1202 if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1203 hasLeak = false;
1204 else if (V.isOwned())
1205 hasLeak = true;
1206 else if (V.isNotOwned() || V.isReturnedOwned())
1207 hasLeak = (V.getCount() > 0);
1208 else
1209 hasLeak = false;
1210
1211 if (!hasLeak)
1212 return removeRefBinding(state, sid);
1213
1214 Leaked.push_back(sid);
1215 return setRefBinding(state, sid, V ^ RefVal::ErrorLeak);
1216}
1217
1218ExplodedNode *
1219RetainCountChecker::processLeaks(ProgramStateRef state,
1220 SmallVectorImpl<SymbolRef> &Leaked,
1221 CheckerContext &Ctx,
1222 ExplodedNode *Pred) const {
1223 // Generate an intermediate node representing the leak point.
1224 ExplodedNode *N = Ctx.addTransition(state, Pred);
1225
1226 if (N) {
1227 for (SmallVectorImpl<SymbolRef>::iterator
1228 I = Leaked.begin(), E = Leaked.end(); I != E; ++I) {
1229
1230 const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
1231 CFRefBug *BT = Pred ? getLeakWithinFunctionBug(LOpts)
1232 : getLeakAtReturnBug(LOpts);
1233 assert(BT && "BugType not initialized.");
1234
George Karpenkov6babf2a2018-09-21 20:36:21 +00001235 Ctx.emitReport(llvm::make_unique<CFRefLeakReport>(
1236 *BT, LOpts, SummaryLog, N, *I, Ctx, IncludeAllocationLine));
George Karpenkov70c2ee32018-08-17 21:41:07 +00001237 }
1238 }
1239
1240 return N;
1241}
1242
George Karpenkovb1b791b2018-08-17 21:43:27 +00001243static bool isISLObjectRef(QualType Ty) {
1244 return StringRef(Ty.getAsString()).startswith("isl_");
George Karpenkov70c2ee32018-08-17 21:41:07 +00001245}
1246
1247void RetainCountChecker::checkBeginFunction(CheckerContext &Ctx) const {
1248 if (!Ctx.inTopFrame())
1249 return;
1250
George Karpenkovc4d6b932018-08-17 21:42:05 +00001251 RetainSummaryManager &SmrMgr = getSummaryManager(Ctx);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001252 const LocationContext *LCtx = Ctx.getLocationContext();
1253 const FunctionDecl *FD = dyn_cast<FunctionDecl>(LCtx->getDecl());
1254
George Karpenkovc4d6b932018-08-17 21:42:05 +00001255 if (!FD || SmrMgr.isTrustedReferenceCountImplementation(FD))
George Karpenkov70c2ee32018-08-17 21:41:07 +00001256 return;
1257
1258 ProgramStateRef state = Ctx.getState();
George Karpenkovc4d6b932018-08-17 21:42:05 +00001259 const RetainSummary *FunctionSummary = SmrMgr.getFunctionSummary(FD);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001260 ArgEffects CalleeSideArgEffects = FunctionSummary->getArgEffects();
1261
1262 for (unsigned idx = 0, e = FD->getNumParams(); idx != e; ++idx) {
1263 const ParmVarDecl *Param = FD->getParamDecl(idx);
1264 SymbolRef Sym = state->getSVal(state->getRegion(Param, LCtx)).getAsSymbol();
1265
1266 QualType Ty = Param->getType();
1267 const ArgEffect *AE = CalleeSideArgEffects.lookup(idx);
George Karpenkovb1b791b2018-08-17 21:43:27 +00001268 if (AE && *AE == DecRef && isISLObjectRef(Ty)) {
George Karpenkov6e9fd132018-08-22 01:17:09 +00001269 state = setRefBinding(
1270 state, Sym, RefVal::makeOwned(RetEffect::ObjKind::Generalized, Ty));
George Karpenkovb1b791b2018-08-17 21:43:27 +00001271 } else if (isISLObjectRef(Ty)) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001272 state = setRefBinding(
1273 state, Sym,
1274 RefVal::makeNotOwned(RetEffect::ObjKind::Generalized, Ty));
1275 }
1276 }
1277
1278 Ctx.addTransition(state);
1279}
1280
1281void RetainCountChecker::checkEndFunction(const ReturnStmt *RS,
1282 CheckerContext &Ctx) const {
George Karpenkov04553e52018-09-21 20:37:20 +00001283 ExplodedNode *Pred = processReturn(RS, Ctx);
1284
1285 // Created state cached out.
1286 if (!Pred) {
1287 return;
1288 }
1289
1290 ProgramStateRef state = Pred->getState();
George Karpenkov70c2ee32018-08-17 21:41:07 +00001291 RefBindingsTy B = state->get<RefBindings>();
George Karpenkov70c2ee32018-08-17 21:41:07 +00001292
1293 // Don't process anything within synthesized bodies.
1294 const LocationContext *LCtx = Pred->getLocationContext();
1295 if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized()) {
1296 assert(!LCtx->inTopFrame());
1297 return;
1298 }
1299
1300 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1301 state = handleAutoreleaseCounts(state, Pred, /*Tag=*/nullptr, Ctx,
1302 I->first, I->second);
1303 if (!state)
1304 return;
1305 }
1306
1307 // If the current LocationContext has a parent, don't check for leaks.
1308 // We will do that later.
1309 // FIXME: we should instead check for imbalances of the retain/releases,
1310 // and suggest annotations.
1311 if (LCtx->getParent())
1312 return;
1313
1314 B = state->get<RefBindings>();
1315 SmallVector<SymbolRef, 10> Leaked;
1316
1317 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I)
1318 state = handleSymbolDeath(state, I->first, I->second, Leaked);
1319
1320 processLeaks(state, Leaked, Ctx, Pred);
1321}
1322
George Karpenkov70c2ee32018-08-17 21:41:07 +00001323void RetainCountChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1324 CheckerContext &C) const {
1325 ExplodedNode *Pred = C.getPredecessor();
1326
1327 ProgramStateRef state = C.getState();
1328 RefBindingsTy B = state->get<RefBindings>();
1329 SmallVector<SymbolRef, 10> Leaked;
1330
1331 // Update counts from autorelease pools
1332 for (SymbolReaper::dead_iterator I = SymReaper.dead_begin(),
1333 E = SymReaper.dead_end(); I != E; ++I) {
1334 SymbolRef Sym = *I;
1335 if (const RefVal *T = B.lookup(Sym)){
1336 // Use the symbol as the tag.
1337 // FIXME: This might not be as unique as we would like.
Artem Dergachev65b4d7d2018-10-15 17:47:56 +00001338 static CheckerProgramPointTag Tag(this, "DeadSymbolAutorelease");
1339 state = handleAutoreleaseCounts(state, Pred, &Tag, C, Sym, *T);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001340 if (!state)
1341 return;
1342
1343 // Fetch the new reference count from the state, and use it to handle
1344 // this symbol.
1345 state = handleSymbolDeath(state, *I, *getRefBinding(state, Sym), Leaked);
1346 }
1347 }
1348
1349 if (Leaked.empty()) {
1350 C.addTransition(state);
1351 return;
1352 }
1353
1354 Pred = processLeaks(state, Leaked, C, Pred);
1355
1356 // Did we cache out?
1357 if (!Pred)
1358 return;
1359
1360 // Now generate a new node that nukes the old bindings.
1361 // The only bindings left at this point are the leaked symbols.
1362 RefBindingsTy::Factory &F = state->get_context<RefBindings>();
1363 B = state->get<RefBindings>();
1364
1365 for (SmallVectorImpl<SymbolRef>::iterator I = Leaked.begin(),
1366 E = Leaked.end();
1367 I != E; ++I)
1368 B = F.remove(B, *I);
1369
1370 state = state->set<RefBindings>(B);
1371 C.addTransition(state, Pred);
1372}
1373
1374void RetainCountChecker::printState(raw_ostream &Out, ProgramStateRef State,
1375 const char *NL, const char *Sep) const {
1376
1377 RefBindingsTy B = State->get<RefBindings>();
1378
1379 if (B.isEmpty())
1380 return;
1381
1382 Out << Sep << NL;
1383
1384 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1385 Out << I->first << " : ";
1386 I->second.print(Out);
1387 Out << NL;
1388 }
1389}
1390
1391//===----------------------------------------------------------------------===//
George Karpenkov70c2ee32018-08-17 21:41:07 +00001392// Checker registration.
1393//===----------------------------------------------------------------------===//
1394
1395void ento::registerRetainCountChecker(CheckerManager &Mgr) {
Kristof Umannc83b0dd2018-11-02 15:48:10 +00001396 auto *Chk = Mgr.registerChecker<RetainCountChecker>();
1397
1398 AnalyzerOptions &Options = Mgr.getAnalyzerOptions();
1399
1400 Chk->IncludeAllocationLine = Options.getBooleanOption(
1401 "leak-diagnostics-reference-allocation", false, Chk);
1402 Chk->ShouldCheckOSObjectRetainCount = Options.getBooleanOption(
1403 "CheckOSObject", true, Chk);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001404}