Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 1 | //===-- SILowerControlFlow.cpp - Use predicates for control flow ----------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | /// \file |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 11 | /// \brief This pass lowers the pseudo control flow instructions to real |
| 12 | /// machine instructions. |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 13 | /// |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 14 | /// All control flow is handled using predicated instructions and |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 15 | /// a predicate stack. Each Scalar ALU controls the operations of 64 Vector |
| 16 | /// ALUs. The Scalar ALU can update the predicate for any of the Vector ALUs |
| 17 | /// by writting to the 64-bit EXEC register (each bit corresponds to a |
| 18 | /// single vector ALU). Typically, for predicates, a vector ALU will write |
| 19 | /// to its bit of the VCC register (like EXEC VCC is 64-bits, one for each |
| 20 | /// Vector ALU) and then the ScalarALU will AND the VCC register with the |
| 21 | /// EXEC to update the predicates. |
| 22 | /// |
| 23 | /// For example: |
| 24 | /// %VCC = V_CMP_GT_F32 %VGPR1, %VGPR2 |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 25 | /// %SGPR0 = SI_IF %VCC |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 26 | /// %VGPR0 = V_ADD_F32 %VGPR0, %VGPR0 |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 27 | /// %SGPR0 = SI_ELSE %SGPR0 |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 28 | /// %VGPR0 = V_SUB_F32 %VGPR0, %VGPR0 |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 29 | /// SI_END_CF %SGPR0 |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 30 | /// |
| 31 | /// becomes: |
| 32 | /// |
| 33 | /// %SGPR0 = S_AND_SAVEEXEC_B64 %VCC // Save and update the exec mask |
| 34 | /// %SGPR0 = S_XOR_B64 %SGPR0, %EXEC // Clear live bits from saved exec mask |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 35 | /// S_CBRANCH_EXECZ label0 // This instruction is an optional |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 36 | /// // optimization which allows us to |
| 37 | /// // branch if all the bits of |
| 38 | /// // EXEC are zero. |
| 39 | /// %VGPR0 = V_ADD_F32 %VGPR0, %VGPR0 // Do the IF block of the branch |
| 40 | /// |
| 41 | /// label0: |
| 42 | /// %SGPR0 = S_OR_SAVEEXEC_B64 %EXEC // Restore the exec mask for the Then block |
| 43 | /// %EXEC = S_XOR_B64 %SGPR0, %EXEC // Clear live bits from saved exec mask |
| 44 | /// S_BRANCH_EXECZ label1 // Use our branch optimization |
| 45 | /// // instruction again. |
| 46 | /// %VGPR0 = V_SUB_F32 %VGPR0, %VGPR // Do the THEN block |
| 47 | /// label1: |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 48 | /// %EXEC = S_OR_B64 %EXEC, %SGPR0 // Re-enable saved exec mask bits |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 49 | //===----------------------------------------------------------------------===// |
| 50 | |
| 51 | #include "AMDGPU.h" |
Eric Christopher | d913448 | 2014-08-04 21:25:23 +0000 | [diff] [blame] | 52 | #include "AMDGPUSubtarget.h" |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 53 | #include "SIInstrInfo.h" |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 54 | #include "llvm/ADT/SmallVector.h" |
| 55 | #include "llvm/ADT/StringRef.h" |
| 56 | #include "llvm/CodeGen/LiveIntervalAnalysis.h" |
| 57 | #include "llvm/CodeGen/MachineBasicBlock.h" |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 58 | #include "llvm/CodeGen/MachineFunction.h" |
| 59 | #include "llvm/CodeGen/MachineFunctionPass.h" |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 60 | #include "llvm/CodeGen/MachineInstr.h" |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 61 | #include "llvm/CodeGen/MachineInstrBuilder.h" |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 62 | #include "llvm/CodeGen/MachineOperand.h" |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 63 | #include "llvm/CodeGen/MachineRegisterInfo.h" |
Chandler Carruth | 6bda14b | 2017-06-06 11:49:48 +0000 | [diff] [blame] | 64 | #include "llvm/CodeGen/Passes.h" |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 65 | #include "llvm/CodeGen/SlotIndexes.h" |
| 66 | #include "llvm/MC/MCRegisterInfo.h" |
| 67 | #include "llvm/Pass.h" |
| 68 | #include "llvm/Target/TargetRegisterInfo.h" |
| 69 | #include <cassert> |
| 70 | #include <iterator> |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 71 | |
| 72 | using namespace llvm; |
| 73 | |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 74 | #define DEBUG_TYPE "si-lower-control-flow" |
| 75 | |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 76 | namespace { |
| 77 | |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 78 | class SILowerControlFlow : public MachineFunctionPass { |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 79 | private: |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 80 | const SIRegisterInfo *TRI = nullptr; |
| 81 | const SIInstrInfo *TII = nullptr; |
| 82 | LiveIntervals *LIS = nullptr; |
| 83 | MachineRegisterInfo *MRI = nullptr; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 84 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 85 | void emitIf(MachineInstr &MI); |
| 86 | void emitElse(MachineInstr &MI); |
| 87 | void emitBreak(MachineInstr &MI); |
| 88 | void emitIfBreak(MachineInstr &MI); |
| 89 | void emitElseBreak(MachineInstr &MI); |
| 90 | void emitLoop(MachineInstr &MI); |
| 91 | void emitEndCf(MachineInstr &MI); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 92 | |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 93 | void findMaskOperands(MachineInstr &MI, unsigned OpNo, |
| 94 | SmallVectorImpl<MachineOperand> &Src) const; |
| 95 | |
| 96 | void combineMasks(MachineInstr &MI); |
| 97 | |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 98 | public: |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 99 | static char ID; |
| 100 | |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 101 | SILowerControlFlow() : MachineFunctionPass(ID) {} |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 102 | |
Craig Topper | 5656db4 | 2014-04-29 07:57:24 +0000 | [diff] [blame] | 103 | bool runOnMachineFunction(MachineFunction &MF) override; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 104 | |
Mehdi Amini | 117296c | 2016-10-01 02:56:57 +0000 | [diff] [blame] | 105 | StringRef getPassName() const override { |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 106 | return "SI Lower control flow pseudo instructions"; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 107 | } |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 108 | |
| 109 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 110 | // Should preserve the same set that TwoAddressInstructions does. |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 111 | AU.addPreserved<SlotIndexes>(); |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 112 | AU.addPreserved<LiveIntervals>(); |
| 113 | AU.addPreservedID(LiveVariablesID); |
| 114 | AU.addPreservedID(MachineLoopInfoID); |
| 115 | AU.addPreservedID(MachineDominatorsID); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 116 | AU.setPreservesCFG(); |
| 117 | MachineFunctionPass::getAnalysisUsage(AU); |
| 118 | } |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 119 | }; |
| 120 | |
Eugene Zelenko | 734bb7b | 2017-01-20 17:52:16 +0000 | [diff] [blame] | 121 | } // end anonymous namespace |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 122 | |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 123 | char SILowerControlFlow::ID = 0; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 124 | |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 125 | INITIALIZE_PASS(SILowerControlFlow, DEBUG_TYPE, |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 126 | "SI lower control flow", false, false) |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 127 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 128 | static void setImpSCCDefDead(MachineInstr &MI, bool IsDead) { |
| 129 | MachineOperand &ImpDefSCC = MI.getOperand(3); |
| 130 | assert(ImpDefSCC.getReg() == AMDGPU::SCC && ImpDefSCC.isDef()); |
| 131 | |
| 132 | ImpDefSCC.setIsDead(IsDead); |
| 133 | } |
| 134 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 135 | char &llvm::SILowerControlFlowID = SILowerControlFlow::ID; |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 136 | |
Stanislav Mekhanoshin | 6c7a8d0 | 2017-08-04 06:58:42 +0000 | [diff] [blame] | 137 | static bool isSimpleIf(const MachineInstr &MI, const MachineRegisterInfo *MRI) { |
| 138 | unsigned SaveExecReg = MI.getOperand(0).getReg(); |
| 139 | auto U = MRI->use_instr_nodbg_begin(SaveExecReg); |
| 140 | |
| 141 | if (U == MRI->use_instr_nodbg_end() || |
| 142 | std::next(U) != MRI->use_instr_nodbg_end() || |
| 143 | U->getOpcode() != AMDGPU::SI_END_CF) |
| 144 | return false; |
| 145 | |
| 146 | // Check for SI_KILL_TERMINATOR on path from if to endif. |
| 147 | // if there is any such terminator simplififcations are not safe. |
| 148 | auto SMBB = MI.getParent(); |
| 149 | auto EMBB = U->getParent(); |
| 150 | DenseSet<const MachineBasicBlock*> Visited; |
| 151 | SmallVector<MachineBasicBlock*, 4> Worklist(SMBB->succ_begin(), |
| 152 | SMBB->succ_end()); |
| 153 | |
| 154 | while (!Worklist.empty()) { |
| 155 | MachineBasicBlock *MBB = Worklist.pop_back_val(); |
| 156 | |
| 157 | if (MBB == EMBB || !Visited.insert(MBB).second) |
| 158 | continue; |
| 159 | for(auto &Term : MBB->terminators()) |
| 160 | if (Term.getOpcode() == AMDGPU::SI_KILL_TERMINATOR) |
| 161 | return false; |
| 162 | |
| 163 | Worklist.append(MBB->succ_begin(), MBB->succ_end()); |
| 164 | } |
| 165 | |
| 166 | return true; |
| 167 | } |
| 168 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 169 | void SILowerControlFlow::emitIf(MachineInstr &MI) { |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 170 | MachineBasicBlock &MBB = *MI.getParent(); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 171 | const DebugLoc &DL = MI.getDebugLoc(); |
| 172 | MachineBasicBlock::iterator I(&MI); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 173 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 174 | MachineOperand &SaveExec = MI.getOperand(0); |
| 175 | MachineOperand &Cond = MI.getOperand(1); |
| 176 | assert(SaveExec.getSubReg() == AMDGPU::NoSubRegister && |
| 177 | Cond.getSubReg() == AMDGPU::NoSubRegister); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 178 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 179 | unsigned SaveExecReg = SaveExec.getReg(); |
Matt Arsenault | 657f871 | 2016-07-12 19:01:23 +0000 | [diff] [blame] | 180 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 181 | MachineOperand &ImpDefSCC = MI.getOperand(4); |
| 182 | assert(ImpDefSCC.getReg() == AMDGPU::SCC && ImpDefSCC.isDef()); |
| 183 | |
Stanislav Mekhanoshin | 3197eb6 | 2017-07-26 21:29:15 +0000 | [diff] [blame] | 184 | // If there is only one use of save exec register and that use is SI_END_CF, |
| 185 | // we can optimize SI_IF by returning the full saved exec mask instead of |
| 186 | // just cleared bits. |
Stanislav Mekhanoshin | 6c7a8d0 | 2017-08-04 06:58:42 +0000 | [diff] [blame] | 187 | bool SimpleIf = isSimpleIf(MI, MRI); |
Stanislav Mekhanoshin | 3197eb6 | 2017-07-26 21:29:15 +0000 | [diff] [blame] | 188 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 189 | // Add an implicit def of exec to discourage scheduling VALU after this which |
| 190 | // will interfere with trying to form s_and_saveexec_b64 later. |
Stanislav Mekhanoshin | 3197eb6 | 2017-07-26 21:29:15 +0000 | [diff] [blame] | 191 | unsigned CopyReg = SimpleIf ? SaveExecReg |
| 192 | : MRI->createVirtualRegister(&AMDGPU::SReg_64RegClass); |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 193 | MachineInstr *CopyExec = |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 194 | BuildMI(MBB, I, DL, TII->get(AMDGPU::COPY), CopyReg) |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 195 | .addReg(AMDGPU::EXEC) |
| 196 | .addReg(AMDGPU::EXEC, RegState::ImplicitDefine); |
| 197 | |
| 198 | unsigned Tmp = MRI->createVirtualRegister(&AMDGPU::SReg_64RegClass); |
| 199 | |
| 200 | MachineInstr *And = |
| 201 | BuildMI(MBB, I, DL, TII->get(AMDGPU::S_AND_B64), Tmp) |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 202 | .addReg(CopyReg) |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 203 | //.addReg(AMDGPU::EXEC) |
| 204 | .addReg(Cond.getReg()); |
| 205 | setImpSCCDefDead(*And, true); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 206 | |
Stanislav Mekhanoshin | 3197eb6 | 2017-07-26 21:29:15 +0000 | [diff] [blame] | 207 | MachineInstr *Xor = nullptr; |
| 208 | if (!SimpleIf) { |
| 209 | Xor = |
| 210 | BuildMI(MBB, I, DL, TII->get(AMDGPU::S_XOR_B64), SaveExecReg) |
| 211 | .addReg(Tmp) |
| 212 | .addReg(CopyReg); |
| 213 | setImpSCCDefDead(*Xor, ImpDefSCC.isDead()); |
| 214 | } |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 215 | |
| 216 | // Use a copy that is a terminator to get correct spill code placement it with |
| 217 | // fast regalloc. |
| 218 | MachineInstr *SetExec = |
| 219 | BuildMI(MBB, I, DL, TII->get(AMDGPU::S_MOV_B64_term), AMDGPU::EXEC) |
| 220 | .addReg(Tmp, RegState::Kill); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 221 | |
| 222 | // Insert a pseudo terminator to help keep the verifier happy. This will also |
| 223 | // be used later when inserting skips. |
Diana Picus | 116bbab | 2017-01-13 09:58:52 +0000 | [diff] [blame] | 224 | MachineInstr *NewBr = BuildMI(MBB, I, DL, TII->get(AMDGPU::SI_MASK_BRANCH)) |
| 225 | .add(MI.getOperand(2)); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 226 | |
| 227 | if (!LIS) { |
| 228 | MI.eraseFromParent(); |
| 229 | return; |
| 230 | } |
| 231 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 232 | LIS->InsertMachineInstrInMaps(*CopyExec); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 233 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 234 | // Replace with and so we don't need to fix the live interval for condition |
| 235 | // register. |
| 236 | LIS->ReplaceMachineInstrInMaps(MI, *And); |
| 237 | |
Stanislav Mekhanoshin | 3197eb6 | 2017-07-26 21:29:15 +0000 | [diff] [blame] | 238 | if (!SimpleIf) |
| 239 | LIS->InsertMachineInstrInMaps(*Xor); |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 240 | LIS->InsertMachineInstrInMaps(*SetExec); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 241 | LIS->InsertMachineInstrInMaps(*NewBr); |
| 242 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 243 | LIS->removeRegUnit(*MCRegUnitIterator(AMDGPU::EXEC, TRI)); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 244 | MI.eraseFromParent(); |
| 245 | |
| 246 | // FIXME: Is there a better way of adjusting the liveness? It shouldn't be |
| 247 | // hard to add another def here but I'm not sure how to correctly update the |
| 248 | // valno. |
| 249 | LIS->removeInterval(SaveExecReg); |
| 250 | LIS->createAndComputeVirtRegInterval(SaveExecReg); |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 251 | LIS->createAndComputeVirtRegInterval(Tmp); |
Stanislav Mekhanoshin | 3197eb6 | 2017-07-26 21:29:15 +0000 | [diff] [blame] | 252 | if (!SimpleIf) |
| 253 | LIS->createAndComputeVirtRegInterval(CopyReg); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 254 | } |
| 255 | |
| 256 | void SILowerControlFlow::emitElse(MachineInstr &MI) { |
| 257 | MachineBasicBlock &MBB = *MI.getParent(); |
Matt Arsenault | 657f871 | 2016-07-12 19:01:23 +0000 | [diff] [blame] | 258 | const DebugLoc &DL = MI.getDebugLoc(); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 259 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 260 | unsigned DstReg = MI.getOperand(0).getReg(); |
| 261 | assert(MI.getOperand(0).getSubReg() == AMDGPU::NoSubRegister); |
Matt Arsenault | 657f871 | 2016-07-12 19:01:23 +0000 | [diff] [blame] | 262 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 263 | bool ExecModified = MI.getOperand(3).getImm() != 0; |
| 264 | MachineBasicBlock::iterator Start = MBB.begin(); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 265 | |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 266 | // We are running before TwoAddressInstructions, and si_else's operands are |
| 267 | // tied. In order to correctly tie the registers, split this into a copy of |
| 268 | // the src like it does. |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 269 | unsigned CopyReg = MRI->createVirtualRegister(&AMDGPU::SReg_64RegClass); |
Stanislav Mekhanoshin | 6825770 | 2017-01-19 21:26:22 +0000 | [diff] [blame] | 270 | MachineInstr *CopyExec = |
| 271 | BuildMI(MBB, Start, DL, TII->get(AMDGPU::COPY), CopyReg) |
Diana Picus | 116bbab | 2017-01-13 09:58:52 +0000 | [diff] [blame] | 272 | .add(MI.getOperand(1)); // Saved EXEC |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 273 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 274 | // This must be inserted before phis and any spill code inserted before the |
| 275 | // else. |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 276 | unsigned SaveReg = ExecModified ? |
| 277 | MRI->createVirtualRegister(&AMDGPU::SReg_64RegClass) : DstReg; |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 278 | MachineInstr *OrSaveExec = |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 279 | BuildMI(MBB, Start, DL, TII->get(AMDGPU::S_OR_SAVEEXEC_B64), SaveReg) |
| 280 | .addReg(CopyReg); |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 281 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 282 | MachineBasicBlock *DestBB = MI.getOperand(2).getMBB(); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 283 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 284 | MachineBasicBlock::iterator ElsePt(MI); |
Matt Arsenault | 657f871 | 2016-07-12 19:01:23 +0000 | [diff] [blame] | 285 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 286 | if (ExecModified) { |
| 287 | MachineInstr *And = |
| 288 | BuildMI(MBB, ElsePt, DL, TII->get(AMDGPU::S_AND_B64), DstReg) |
| 289 | .addReg(AMDGPU::EXEC) |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 290 | .addReg(SaveReg); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 291 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 292 | if (LIS) |
| 293 | LIS->InsertMachineInstrInMaps(*And); |
Nicolai Haehnle | 213e87f | 2016-03-21 20:28:33 +0000 | [diff] [blame] | 294 | } |
| 295 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 296 | MachineInstr *Xor = |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 297 | BuildMI(MBB, ElsePt, DL, TII->get(AMDGPU::S_XOR_B64_term), AMDGPU::EXEC) |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 298 | .addReg(AMDGPU::EXEC) |
| 299 | .addReg(DstReg); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 300 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 301 | MachineInstr *Branch = |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 302 | BuildMI(MBB, ElsePt, DL, TII->get(AMDGPU::SI_MASK_BRANCH)) |
Matt Arsenault | f98a596 | 2016-08-27 00:42:21 +0000 | [diff] [blame] | 303 | .addMBB(DestBB); |
Matt Arsenault | 9babdf4 | 2016-06-22 20:15:28 +0000 | [diff] [blame] | 304 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 305 | if (!LIS) { |
| 306 | MI.eraseFromParent(); |
| 307 | return; |
| 308 | } |
| 309 | |
| 310 | LIS->RemoveMachineInstrFromMaps(MI); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 311 | MI.eraseFromParent(); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 312 | |
Stanislav Mekhanoshin | 6825770 | 2017-01-19 21:26:22 +0000 | [diff] [blame] | 313 | LIS->InsertMachineInstrInMaps(*CopyExec); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 314 | LIS->InsertMachineInstrInMaps(*OrSaveExec); |
| 315 | |
| 316 | LIS->InsertMachineInstrInMaps(*Xor); |
| 317 | LIS->InsertMachineInstrInMaps(*Branch); |
| 318 | |
| 319 | // src reg is tied to dst reg. |
| 320 | LIS->removeInterval(DstReg); |
| 321 | LIS->createAndComputeVirtRegInterval(DstReg); |
Stanislav Mekhanoshin | ae0f6620 | 2016-11-22 01:42:34 +0000 | [diff] [blame] | 322 | LIS->createAndComputeVirtRegInterval(CopyReg); |
| 323 | if (ExecModified) |
| 324 | LIS->createAndComputeVirtRegInterval(SaveReg); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 325 | |
| 326 | // Let this be recomputed. |
| 327 | LIS->removeRegUnit(*MCRegUnitIterator(AMDGPU::EXEC, TRI)); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 328 | } |
| 329 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 330 | void SILowerControlFlow::emitBreak(MachineInstr &MI) { |
Matt Arsenault | 48d70cb | 2016-07-09 17:18:39 +0000 | [diff] [blame] | 331 | MachineBasicBlock &MBB = *MI.getParent(); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 332 | const DebugLoc &DL = MI.getDebugLoc(); |
Matt Arsenault | 48d70cb | 2016-07-09 17:18:39 +0000 | [diff] [blame] | 333 | unsigned Dst = MI.getOperand(0).getReg(); |
Matt Arsenault | 48d70cb | 2016-07-09 17:18:39 +0000 | [diff] [blame] | 334 | |
Diana Picus | 116bbab | 2017-01-13 09:58:52 +0000 | [diff] [blame] | 335 | MachineInstr *Or = BuildMI(MBB, &MI, DL, TII->get(AMDGPU::S_OR_B64), Dst) |
| 336 | .addReg(AMDGPU::EXEC) |
| 337 | .add(MI.getOperand(1)); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 338 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 339 | if (LIS) |
| 340 | LIS->ReplaceMachineInstrInMaps(MI, *Or); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 341 | MI.eraseFromParent(); |
| 342 | } |
| 343 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 344 | void SILowerControlFlow::emitIfBreak(MachineInstr &MI) { |
| 345 | MI.setDesc(TII->get(AMDGPU::S_OR_B64)); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 346 | } |
| 347 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 348 | void SILowerControlFlow::emitElseBreak(MachineInstr &MI) { |
| 349 | MI.setDesc(TII->get(AMDGPU::S_OR_B64)); |
Tom Stellard | e7b907d | 2012-12-19 22:10:33 +0000 | [diff] [blame] | 350 | } |
| 351 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 352 | void SILowerControlFlow::emitLoop(MachineInstr &MI) { |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 353 | MachineBasicBlock &MBB = *MI.getParent(); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 354 | const DebugLoc &DL = MI.getDebugLoc(); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 355 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 356 | MachineInstr *AndN2 = |
Diana Picus | 116bbab | 2017-01-13 09:58:52 +0000 | [diff] [blame] | 357 | BuildMI(MBB, &MI, DL, TII->get(AMDGPU::S_ANDN2_B64_term), AMDGPU::EXEC) |
| 358 | .addReg(AMDGPU::EXEC) |
| 359 | .add(MI.getOperand(0)); |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 360 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 361 | MachineInstr *Branch = |
Diana Picus | 116bbab | 2017-01-13 09:58:52 +0000 | [diff] [blame] | 362 | BuildMI(MBB, &MI, DL, TII->get(AMDGPU::S_CBRANCH_EXECNZ)) |
| 363 | .add(MI.getOperand(1)); |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 364 | |
| 365 | if (LIS) { |
| 366 | LIS->ReplaceMachineInstrInMaps(MI, *AndN2); |
| 367 | LIS->InsertMachineInstrInMaps(*Branch); |
Michel Danzer | 9e61c4b | 2014-02-27 01:47:09 +0000 | [diff] [blame] | 368 | } |
Tom Stellard | be8ebee | 2013-01-18 21:15:50 +0000 | [diff] [blame] | 369 | |
| 370 | MI.eraseFromParent(); |
| 371 | } |
| 372 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 373 | void SILowerControlFlow::emitEndCf(MachineInstr &MI) { |
| 374 | MachineBasicBlock &MBB = *MI.getParent(); |
| 375 | const DebugLoc &DL = MI.getDebugLoc(); |
Matt Arsenault | 786724a | 2016-07-12 21:41:32 +0000 | [diff] [blame] | 376 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 377 | MachineBasicBlock::iterator InsPt = MBB.begin(); |
| 378 | MachineInstr *NewMI = |
Diana Picus | 116bbab | 2017-01-13 09:58:52 +0000 | [diff] [blame] | 379 | BuildMI(MBB, InsPt, DL, TII->get(AMDGPU::S_OR_B64), AMDGPU::EXEC) |
| 380 | .addReg(AMDGPU::EXEC) |
| 381 | .add(MI.getOperand(0)); |
Matt Arsenault | 786724a | 2016-07-12 21:41:32 +0000 | [diff] [blame] | 382 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 383 | if (LIS) |
| 384 | LIS->ReplaceMachineInstrInMaps(MI, *NewMI); |
Matt Arsenault | 786724a | 2016-07-12 21:41:32 +0000 | [diff] [blame] | 385 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 386 | MI.eraseFromParent(); |
| 387 | |
| 388 | if (LIS) |
| 389 | LIS->handleMove(*NewMI); |
Matt Arsenault | 786724a | 2016-07-12 21:41:32 +0000 | [diff] [blame] | 390 | } |
| 391 | |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 392 | // Returns replace operands for a logical operation, either single result |
| 393 | // for exec or two operands if source was another equivalent operation. |
| 394 | void SILowerControlFlow::findMaskOperands(MachineInstr &MI, unsigned OpNo, |
| 395 | SmallVectorImpl<MachineOperand> &Src) const { |
| 396 | MachineOperand &Op = MI.getOperand(OpNo); |
| 397 | if (!Op.isReg() || !TargetRegisterInfo::isVirtualRegister(Op.getReg())) { |
| 398 | Src.push_back(Op); |
| 399 | return; |
| 400 | } |
| 401 | |
| 402 | MachineInstr *Def = MRI->getUniqueVRegDef(Op.getReg()); |
| 403 | if (!Def || Def->getParent() != MI.getParent() || |
| 404 | !(Def->isFullCopy() || (Def->getOpcode() == MI.getOpcode()))) |
| 405 | return; |
| 406 | |
| 407 | // Make sure we do not modify exec between def and use. |
| 408 | // A copy with implcitly defined exec inserted earlier is an exclusion, it |
| 409 | // does not really modify exec. |
| 410 | for (auto I = Def->getIterator(); I != MI.getIterator(); ++I) |
| 411 | if (I->modifiesRegister(AMDGPU::EXEC, TRI) && |
| 412 | !(I->isCopy() && I->getOperand(0).getReg() != AMDGPU::EXEC)) |
| 413 | return; |
| 414 | |
| 415 | for (const auto &SrcOp : Def->explicit_operands()) |
| 416 | if (SrcOp.isUse() && (!SrcOp.isReg() || |
| 417 | TargetRegisterInfo::isVirtualRegister(SrcOp.getReg()) || |
| 418 | SrcOp.getReg() == AMDGPU::EXEC)) |
| 419 | Src.push_back(SrcOp); |
| 420 | } |
| 421 | |
| 422 | // Search and combine pairs of equivalent instructions, like |
| 423 | // S_AND_B64 x, (S_AND_B64 x, y) => S_AND_B64 x, y |
| 424 | // S_OR_B64 x, (S_OR_B64 x, y) => S_OR_B64 x, y |
| 425 | // One of the operands is exec mask. |
| 426 | void SILowerControlFlow::combineMasks(MachineInstr &MI) { |
| 427 | assert(MI.getNumExplicitOperands() == 3); |
| 428 | SmallVector<MachineOperand, 4> Ops; |
| 429 | unsigned OpToReplace = 1; |
| 430 | findMaskOperands(MI, 1, Ops); |
| 431 | if (Ops.size() == 1) OpToReplace = 2; // First operand can be exec or its copy |
| 432 | findMaskOperands(MI, 2, Ops); |
| 433 | if (Ops.size() != 3) return; |
| 434 | |
| 435 | unsigned UniqueOpndIdx; |
| 436 | if (Ops[0].isIdenticalTo(Ops[1])) UniqueOpndIdx = 2; |
| 437 | else if (Ops[0].isIdenticalTo(Ops[2])) UniqueOpndIdx = 1; |
| 438 | else if (Ops[1].isIdenticalTo(Ops[2])) UniqueOpndIdx = 1; |
| 439 | else return; |
| 440 | |
| 441 | unsigned Reg = MI.getOperand(OpToReplace).getReg(); |
| 442 | MI.RemoveOperand(OpToReplace); |
| 443 | MI.addOperand(Ops[UniqueOpndIdx]); |
| 444 | if (MRI->use_empty(Reg)) |
| 445 | MRI->getUniqueVRegDef(Reg)->eraseFromParent(); |
| 446 | } |
| 447 | |
Matt Arsenault | 55d49cf | 2016-02-12 02:16:10 +0000 | [diff] [blame] | 448 | bool SILowerControlFlow::runOnMachineFunction(MachineFunction &MF) { |
Matt Arsenault | 43e92fe | 2016-06-24 06:30:11 +0000 | [diff] [blame] | 449 | const SISubtarget &ST = MF.getSubtarget<SISubtarget>(); |
| 450 | TII = ST.getInstrInfo(); |
| 451 | TRI = &TII->getRegisterInfo(); |
| 452 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 453 | // This doesn't actually need LiveIntervals, but we can preserve them. |
| 454 | LIS = getAnalysisIfAvailable<LiveIntervals>(); |
Matt Arsenault | e674075 | 2016-09-29 01:44:16 +0000 | [diff] [blame] | 455 | MRI = &MF.getRegInfo(); |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 456 | |
Matt Arsenault | 9babdf4 | 2016-06-22 20:15:28 +0000 | [diff] [blame] | 457 | MachineFunction::iterator NextBB; |
Matt Arsenault | 9babdf4 | 2016-06-22 20:15:28 +0000 | [diff] [blame] | 458 | for (MachineFunction::iterator BI = MF.begin(), BE = MF.end(); |
| 459 | BI != BE; BI = NextBB) { |
| 460 | NextBB = std::next(BI); |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 461 | MachineBasicBlock &MBB = *BI; |
Matt Arsenault | 9babdf4 | 2016-06-22 20:15:28 +0000 | [diff] [blame] | 462 | |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 463 | MachineBasicBlock::iterator I, Next, Last; |
Nicolai Haehnle | 213e87f | 2016-03-21 20:28:33 +0000 | [diff] [blame] | 464 | |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 465 | for (I = MBB.begin(), Last = MBB.end(); I != MBB.end(); I = Next) { |
Benjamin Kramer | b6d0bd4 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 466 | Next = std::next(I); |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 467 | MachineInstr &MI = *I; |
Tom Stellard | 5d7aaae | 2014-02-10 16:58:30 +0000 | [diff] [blame] | 468 | |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 469 | switch (MI.getOpcode()) { |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 470 | case AMDGPU::SI_IF: |
| 471 | emitIf(MI); |
| 472 | break; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 473 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 474 | case AMDGPU::SI_ELSE: |
| 475 | emitElse(MI); |
| 476 | break; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 477 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 478 | case AMDGPU::SI_BREAK: |
| 479 | emitBreak(MI); |
| 480 | break; |
Matt Arsenault | 48d70cb | 2016-07-09 17:18:39 +0000 | [diff] [blame] | 481 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 482 | case AMDGPU::SI_IF_BREAK: |
| 483 | emitIfBreak(MI); |
| 484 | break; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 485 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 486 | case AMDGPU::SI_ELSE_BREAK: |
| 487 | emitElseBreak(MI); |
| 488 | break; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 489 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 490 | case AMDGPU::SI_LOOP: |
| 491 | emitLoop(MI); |
| 492 | break; |
Tom Stellard | f879435 | 2012-12-19 22:10:31 +0000 | [diff] [blame] | 493 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 494 | case AMDGPU::SI_END_CF: |
| 495 | emitEndCf(MI); |
| 496 | break; |
Matt Arsenault | b91805e | 2016-07-15 00:58:15 +0000 | [diff] [blame] | 497 | |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 498 | case AMDGPU::S_AND_B64: |
| 499 | case AMDGPU::S_OR_B64: |
| 500 | // Cleanup bit manipulations on exec mask |
| 501 | combineMasks(MI); |
| 502 | Last = I; |
| 503 | continue; |
| 504 | |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 505 | default: |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 506 | Last = I; |
| 507 | continue; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 508 | } |
Stanislav Mekhanoshin | 0ee250e | 2016-11-28 18:58:49 +0000 | [diff] [blame] | 509 | |
| 510 | // Replay newly inserted code to combine masks |
| 511 | Next = (Last == MBB.end()) ? MBB.begin() : Last; |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 512 | } |
| 513 | } |
Matt Arsenault | 78fc9da | 2016-08-22 19:33:16 +0000 | [diff] [blame] | 514 | |
Tom Stellard | 75aadc2 | 2012-12-11 21:25:42 +0000 | [diff] [blame] | 515 | return true; |
| 516 | } |