blob: 03ceac10beeca51367cee926ba20d2591b8ecb6e [file] [log] [blame]
Chris Lattner25e48dd2004-07-31 10:01:27 +00001//===-- BranchFolding.cpp - Fold machine code branch instructions ---------===//
Misha Brukman835702a2005-04-21 22:36:52 +00002//
Chris Lattner25e48dd2004-07-31 10:01:27 +00003// The LLVM Compiler Infrastructure
4//
Chris Lattnerf3ebc3f2007-12-29 20:36:04 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Misha Brukman835702a2005-04-21 22:36:52 +00007//
Chris Lattner25e48dd2004-07-31 10:01:27 +00008//===----------------------------------------------------------------------===//
9//
10// This pass forwards branches to unconditional branches to make them branch
11// directly to the target block. This pass often results in dead MBB's, which
12// it then removes.
13//
14// Note that this pass must be run after register allocation, it cannot handle
Jingyue Wu3a04dc62015-07-29 18:59:09 +000015// SSA form. It also must handle virtual registers for targets that emit virtual
16// ISA (e.g. NVPTX).
Chris Lattner25e48dd2004-07-31 10:01:27 +000017//
18//===----------------------------------------------------------------------===//
19
Evan Cheng3d2fce02009-09-04 07:47:40 +000020#include "BranchFolding.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000021#include "llvm/ADT/STLExtras.h"
22#include "llvm/ADT/SmallSet.h"
23#include "llvm/ADT/Statistic.h"
David Majnemer16193552015-10-04 02:22:52 +000024#include "llvm/CodeGen/Analysis.h"
Akira Hatanakabbd33f62014-08-07 19:30:13 +000025#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
26#include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
Chris Lattner25e48dd2004-07-31 10:01:27 +000027#include "llvm/CodeGen/MachineFunctionPass.h"
Chris Lattner56c9d252006-10-17 17:13:52 +000028#include "llvm/CodeGen/MachineJumpTableInfo.h"
Chad Rosier3b67c8d2015-03-10 16:22:52 +000029#include "llvm/CodeGen/MachineMemOperand.h"
Haicheng Wu5b458cc2016-06-09 15:24:29 +000030#include "llvm/CodeGen/MachineLoopInfo.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000031#include "llvm/CodeGen/MachineModuleInfo.h"
Jakob Stoklund Olesend1664a12012-03-27 17:06:09 +000032#include "llvm/CodeGen/MachineRegisterInfo.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000033#include "llvm/CodeGen/Passes.h"
Matthias Braun31d19d42016-05-10 03:21:59 +000034#include "llvm/CodeGen/TargetPassConfig.h"
Taewook Ohfb1833e2017-03-15 05:44:59 +000035#include "llvm/IR/DebugInfoMetadata.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000036#include "llvm/IR/Function.h"
Chris Lattner60c9d4d2006-10-21 00:47:49 +000037#include "llvm/Support/CommandLine.h"
Chris Lattner56ec81f2006-11-18 21:56:39 +000038#include "llvm/Support/Debug.h"
Torok Edwin56d06592009-07-11 20:10:48 +000039#include "llvm/Support/ErrorHandling.h"
Bill Wendlingc3f05e82009-08-22 20:03:00 +000040#include "llvm/Support/raw_ostream.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000041#include "llvm/Target/TargetInstrInfo.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000042#include "llvm/Target/TargetRegisterInfo.h"
Eric Christopherd9134482014-08-04 21:25:23 +000043#include "llvm/Target/TargetSubtargetInfo.h"
Jeff Cohen7d6f3db2006-11-05 19:31:28 +000044#include <algorithm>
Chris Lattner25e48dd2004-07-31 10:01:27 +000045using namespace llvm;
46
Matthias Braun1527baa2017-05-25 21:26:32 +000047#define DEBUG_TYPE "branch-folder"
Chandler Carruth1b9dde02014-04-22 02:02:50 +000048
Chris Lattneraee775a2006-12-19 22:41:21 +000049STATISTIC(NumDeadBlocks, "Number of dead blocks removed");
50STATISTIC(NumBranchOpts, "Number of branches optimized");
51STATISTIC(NumTailMerge , "Number of block tails merged");
Evan Chengcfdf3392011-05-12 00:56:58 +000052STATISTIC(NumHoist , "Number of times common instructions are hoisted");
Hans Wennborga4686012017-02-16 00:04:05 +000053STATISTIC(NumTailCalls, "Number of tail calls optimized");
Bob Wilson8984e6e2009-11-18 19:29:37 +000054
Dan Gohmanc86b5a12009-11-11 18:38:14 +000055static cl::opt<cl::boolOrDefault> FlagEnableTailMerge("enable-tail-merge",
Dale Johannesen82810c82007-05-22 17:14:46 +000056 cl::init(cl::BOU_UNSET), cl::Hidden);
Bob Wilson8984e6e2009-11-18 19:29:37 +000057
Dan Gohmand78c4002008-05-13 00:00:25 +000058// Throttle for huge numbers of predecessors (compile speed problems)
59static cl::opt<unsigned>
Dan Gohmanc86b5a12009-11-11 18:38:14 +000060TailMergeThreshold("tail-merge-threshold",
Dan Gohmand78c4002008-05-13 00:00:25 +000061 cl::desc("Max number of predecessors to consider tail merging"),
Dale Johannesen1d7e42c2008-10-27 02:10:21 +000062 cl::init(150), cl::Hidden);
Dale Johannesen86798e52007-06-08 01:08:52 +000063
Dan Gohman64b5d0f2009-11-11 19:48:59 +000064// Heuristic for tail merging (and, inversely, tail duplication).
65// TODO: This should be replaced with a target query.
66static cl::opt<unsigned>
Bob Wilson699f5b92009-11-16 17:56:13 +000067TailMergeSize("tail-merge-size",
Dan Gohman64b5d0f2009-11-11 19:48:59 +000068 cl::desc("Min number of instructions to consider tail merging"),
69 cl::init(3), cl::Hidden);
Devang Patel09f162c2007-05-01 21:15:47 +000070
Dan Gohmana9b40a6e2009-11-12 01:59:26 +000071namespace {
72 /// BranchFolderPass - Wrap branch folder in a machine function pass.
Andrew Trick58648e42012-02-08 21:22:48 +000073 class BranchFolderPass : public MachineFunctionPass {
Dan Gohmana9b40a6e2009-11-12 01:59:26 +000074 public:
75 static char ID;
Andrew Trick58648e42012-02-08 21:22:48 +000076 explicit BranchFolderPass(): MachineFunctionPass(ID) {}
Dan Gohmana9b40a6e2009-11-12 01:59:26 +000077
Craig Topper4584cd52014-03-07 09:26:03 +000078 bool runOnMachineFunction(MachineFunction &MF) override;
Andrew Trick58648e42012-02-08 21:22:48 +000079
Craig Topper4584cd52014-03-07 09:26:03 +000080 void getAnalysisUsage(AnalysisUsage &AU) const override {
Akira Hatanakabbd33f62014-08-07 19:30:13 +000081 AU.addRequired<MachineBlockFrequencyInfo>();
82 AU.addRequired<MachineBranchProbabilityInfo>();
Andrew Trick58648e42012-02-08 21:22:48 +000083 AU.addRequired<TargetPassConfig>();
84 MachineFunctionPass::getAnalysisUsage(AU);
85 }
Dan Gohmana9b40a6e2009-11-12 01:59:26 +000086 };
Alexander Kornienkof00654e2015-06-23 09:49:53 +000087}
Dan Gohmana9b40a6e2009-11-12 01:59:26 +000088
Evan Cheng3d2fce02009-09-04 07:47:40 +000089char BranchFolderPass::ID = 0;
Andrew Trick58648e42012-02-08 21:22:48 +000090char &llvm::BranchFolderPassID = BranchFolderPass::ID;
Chris Lattner25e48dd2004-07-31 10:01:27 +000091
Matthias Braun1527baa2017-05-25 21:26:32 +000092INITIALIZE_PASS(BranchFolderPass, DEBUG_TYPE,
Andrew Trick58648e42012-02-08 21:22:48 +000093 "Control Flow Optimizer", false, false)
Evan Cheng3d2fce02009-09-04 07:47:40 +000094
95bool BranchFolderPass::runOnMachineFunction(MachineFunction &MF) {
Andrew Kayloraa641a52016-04-22 22:06:11 +000096 if (skipFunction(*MF.getFunction()))
Paul Robinson7c99ec52014-03-31 17:43:35 +000097 return false;
98
Andrew Trick58648e42012-02-08 21:22:48 +000099 TargetPassConfig *PassConfig = &getAnalysis<TargetPassConfig>();
Vincent Lejeune92b0a642013-12-07 01:49:19 +0000100 // TailMerge can create jump into if branches that make CFG irreducible for
David Majnemer16193552015-10-04 02:22:52 +0000101 // HW that requires structurized CFG.
Vincent Lejeune92b0a642013-12-07 01:49:19 +0000102 bool EnableTailMerge = !MF.getTarget().requiresStructuredCFG() &&
David Majnemer4600c062015-10-01 21:04:13 +0000103 PassConfig->getEnableTailMerge();
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000104 BranchFolder::MBFIWrapper MBBFreqInfo(
105 getAnalysis<MachineBlockFrequencyInfo>());
106 BranchFolder Folder(EnableTailMerge, /*CommonHoist=*/true, MBBFreqInfo,
Akira Hatanakabbd33f62014-08-07 19:30:13 +0000107 getAnalysis<MachineBranchProbabilityInfo>());
Eric Christopherfc6de422014-08-05 02:39:49 +0000108 return Folder.OptimizeFunction(MF, MF.getSubtarget().getInstrInfo(),
109 MF.getSubtarget().getRegisterInfo(),
110 getAnalysisIfAvailable<MachineModuleInfo>());
Evan Cheng3d2fce02009-09-04 07:47:40 +0000111}
112
Akira Hatanakabbd33f62014-08-07 19:30:13 +0000113BranchFolder::BranchFolder(bool defaultEnableTailMerge, bool CommonHoist,
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000114 MBFIWrapper &FreqInfo,
Kyle Butt64e42812016-08-18 18:57:29 +0000115 const MachineBranchProbabilityInfo &ProbInfo,
116 unsigned MinTailLength)
117 : EnableHoistCommonCode(CommonHoist), MinCommonTailLength(MinTailLength),
118 MBBFreqInfo(FreqInfo), MBPI(ProbInfo) {
119 if (MinCommonTailLength == 0)
120 MinCommonTailLength = TailMergeSize;
Evan Cheng3d2fce02009-09-04 07:47:40 +0000121 switch (FlagEnableTailMerge) {
122 case cl::BOU_UNSET: EnableTailMerge = defaultEnableTailMerge; break;
123 case cl::BOU_TRUE: EnableTailMerge = true; break;
124 case cl::BOU_FALSE: EnableTailMerge = false; break;
125 }
Evan Cheng1f6e5eb2009-09-03 23:54:22 +0000126}
Chris Lattner25e48dd2004-07-31 10:01:27 +0000127
Chris Lattner73da3202006-10-17 23:17:27 +0000128void BranchFolder::RemoveDeadBlock(MachineBasicBlock *MBB) {
Jim Laskey9df1a1d2007-02-22 16:39:03 +0000129 assert(MBB->pred_empty() && "MBB must be dead!");
David Greened60abbf2009-12-24 00:34:21 +0000130 DEBUG(dbgs() << "\nRemoving MBB: " << *MBB);
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000131
Chris Lattner56c9d252006-10-17 17:13:52 +0000132 MachineFunction *MF = MBB->getParent();
133 // drop all successors.
134 while (!MBB->succ_empty())
135 MBB->removeSuccessor(MBB->succ_end()-1);
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000136
Rafael Espindola3aeaf9e2011-06-14 15:31:54 +0000137 // Avoid matching if this pointer gets reused.
138 TriedMerging.erase(MBB);
139
Chris Lattner56c9d252006-10-17 17:13:52 +0000140 // Remove the block.
Dan Gohman3b460302008-07-07 23:14:23 +0000141 MF->erase(MBB);
David Majnemer16193552015-10-04 02:22:52 +0000142 FuncletMembership.erase(MBB);
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000143 if (MLI)
144 MLI->removeBlock(MBB);
Chris Lattner56c9d252006-10-17 17:13:52 +0000145}
146
Evan Cheng3d2fce02009-09-04 07:47:40 +0000147bool BranchFolder::OptimizeFunction(MachineFunction &MF,
148 const TargetInstrInfo *tii,
149 const TargetRegisterInfo *tri,
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000150 MachineModuleInfo *mmi,
151 MachineLoopInfo *mli, bool AfterPlacement) {
Evan Cheng3d2fce02009-09-04 07:47:40 +0000152 if (!tii) return false;
Chris Lattner3218e0e2006-10-14 00:21:48 +0000153
Rafael Espindola3aeaf9e2011-06-14 15:31:54 +0000154 TriedMerging.clear();
155
Matthias Braune51c4352017-05-26 06:32:31 +0000156 MachineRegisterInfo &MRI = MF.getRegInfo();
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000157 AfterBlockPlacement = AfterPlacement;
Evan Cheng3d2fce02009-09-04 07:47:40 +0000158 TII = tii;
159 TRI = tri;
160 MMI = mmi;
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000161 MLI = mli;
Matthias Braune51c4352017-05-26 06:32:31 +0000162 this->MRI = &MRI;
Evan Cheng3d2fce02009-09-04 07:47:40 +0000163
Matthias Braunaeab09f2016-07-12 18:44:33 +0000164 UpdateLiveIns = MRI.tracksLiveness() && TRI->trackLivenessAfterRegAlloc(MF);
165 if (!UpdateLiveIns)
Jakob Stoklund Olesend1664a12012-03-27 17:06:09 +0000166 MRI.invalidateLiveness();
Evan Cheng9d339842008-04-10 02:32:10 +0000167
Dale Johannesen420a85d2007-05-15 21:19:17 +0000168 // Fix CFG. The later algorithms expect it to be right.
Evan Cheng3d2fce02009-09-04 07:47:40 +0000169 bool MadeChange = false;
Craig Topper5db36df2015-09-16 03:52:35 +0000170 for (MachineBasicBlock &MBB : MF) {
171 MachineBasicBlock *TBB = nullptr, *FBB = nullptr;
Owen Anderson4f6bf042008-08-14 22:49:33 +0000172 SmallVector<MachineOperand, 4> Cond;
Jacques Pienaar71c30a12016-07-15 14:41:04 +0000173 if (!TII->analyzeBranch(MBB, TBB, FBB, Cond, true))
Craig Topper5db36df2015-09-16 03:52:35 +0000174 MadeChange |= MBB.CorrectExtraCFGEdges(TBB, FBB, !Cond.empty());
Dale Johannesen420a85d2007-05-15 21:19:17 +0000175 }
176
David Majnemer16193552015-10-04 02:22:52 +0000177 // Recalculate funclet membership.
178 FuncletMembership = getFuncletMembership(MF);
179
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000180 bool MadeChangeThisIteration = true;
181 while (MadeChangeThisIteration) {
Evan Chengcfdf3392011-05-12 00:56:58 +0000182 MadeChangeThisIteration = TailMergeBlocks(MF);
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000183 // No need to clean up if tail merging does not change anything after the
184 // block placement.
185 if (!AfterBlockPlacement || MadeChangeThisIteration)
186 MadeChangeThisIteration |= OptimizeBranches(MF);
Evan Chengcfdf3392011-05-12 00:56:58 +0000187 if (EnableHoistCommonCode)
188 MadeChangeThisIteration |= HoistCommonCode(MF);
Evan Cheng3d2fce02009-09-04 07:47:40 +0000189 MadeChange |= MadeChangeThisIteration;
Chris Lattner25e48dd2004-07-31 10:01:27 +0000190 }
191
Bob Wilsonbc5af982010-03-19 19:05:41 +0000192 // See if any jump tables have become dead as the code generator
Chris Lattnerc07657f2006-10-28 18:34:47 +0000193 // did its thing.
194 MachineJumpTableInfo *JTI = MF.getJumpTableInfo();
Matthias Braunaeab09f2016-07-12 18:44:33 +0000195 if (!JTI)
Chris Lattnerb6db2c62010-01-25 23:26:13 +0000196 return MadeChange;
Andrew Trick9e761992012-02-08 21:22:43 +0000197
Bob Wilsonbc5af982010-03-19 19:05:41 +0000198 // Walk the function to find jump tables that are live.
199 BitVector JTIsLive(JTI->getJumpTables().size());
Craig Topper5db36df2015-09-16 03:52:35 +0000200 for (const MachineBasicBlock &BB : MF) {
201 for (const MachineInstr &I : BB)
202 for (const MachineOperand &Op : I.operands()) {
Chris Lattnerb6db2c62010-01-25 23:26:13 +0000203 if (!Op.isJTI()) continue;
Chris Lattnerc07657f2006-10-28 18:34:47 +0000204
Chris Lattnerb6db2c62010-01-25 23:26:13 +0000205 // Remember that this JT is live.
Bob Wilsonbc5af982010-03-19 19:05:41 +0000206 JTIsLive.set(Op.getIndex());
Chris Lattnerc07657f2006-10-28 18:34:47 +0000207 }
208 }
Evan Cheng3d2fce02009-09-04 07:47:40 +0000209
Bob Wilsonbc5af982010-03-19 19:05:41 +0000210 // Finally, remove dead jump tables. This happens when the
211 // indirect jump was unreachable (and thus deleted).
Chris Lattnerb6db2c62010-01-25 23:26:13 +0000212 for (unsigned i = 0, e = JTIsLive.size(); i != e; ++i)
213 if (!JTIsLive.test(i)) {
214 JTI->RemoveJumpTable(i);
215 MadeChange = true;
216 }
217
Evan Cheng3d2fce02009-09-04 07:47:40 +0000218 return MadeChange;
Chris Lattner25e48dd2004-07-31 10:01:27 +0000219}
220
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000221//===----------------------------------------------------------------------===//
222// Tail Merging of Blocks
223//===----------------------------------------------------------------------===//
224
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000225/// HashMachineInstr - Compute a hash value for MI and its operands.
Duncan P. N. Exon Smithd3a74672016-02-27 19:48:01 +0000226static unsigned HashMachineInstr(const MachineInstr &MI) {
227 unsigned Hash = MI.getOpcode();
228 for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) {
229 const MachineOperand &Op = MI.getOperand(i);
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000230
Benjamin Kramer8c57cfd2015-06-23 14:47:36 +0000231 // Merge in bits from the operand if easy. We can't use MachineOperand's
232 // hash_code here because it's not deterministic and we sort by hash value
233 // later.
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000234 unsigned OperandHash = 0;
235 switch (Op.getType()) {
NAKAMURA Takumi34d33762015-06-20 06:22:04 +0000236 case MachineOperand::MO_Register:
237 OperandHash = Op.getReg();
238 break;
239 case MachineOperand::MO_Immediate:
240 OperandHash = Op.getImm();
241 break;
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000242 case MachineOperand::MO_MachineBasicBlock:
243 OperandHash = Op.getMBB()->getNumber();
244 break;
245 case MachineOperand::MO_FrameIndex:
246 case MachineOperand::MO_ConstantPoolIndex:
247 case MachineOperand::MO_JumpTableIndex:
248 OperandHash = Op.getIndex();
249 break;
250 case MachineOperand::MO_GlobalAddress:
251 case MachineOperand::MO_ExternalSymbol:
252 // Global address / external symbol are too hard, don't bother, but do
253 // pull in the offset.
254 OperandHash = Op.getOffset();
255 break;
NAKAMURA Takumi34d33762015-06-20 06:22:04 +0000256 default:
257 break;
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000258 }
259
NAKAMURA Takumi34d33762015-06-20 06:22:04 +0000260 Hash += ((OperandHash << 3) | Op.getType()) << (i & 31);
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000261 }
262 return Hash;
263}
264
Dan Gohman2ad68de2010-05-03 14:35:47 +0000265/// HashEndOfMBB - Hash the last instruction in the MBB.
Duncan P. N. Exon Smithd3a74672016-02-27 19:48:01 +0000266static unsigned HashEndOfMBB(const MachineBasicBlock &MBB) {
267 MachineBasicBlock::const_iterator I = MBB.getLastNonDebugInstr();
268 if (I == MBB.end())
Benjamin Kramer6b568962015-06-23 14:47:29 +0000269 return 0;
NAKAMURA Takumi3746abb2015-06-20 06:21:48 +0000270
Duncan P. N. Exon Smithd3a74672016-02-27 19:48:01 +0000271 return HashMachineInstr(*I);
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000272}
273
274/// ComputeCommonTailLength - Given two machine basic blocks, compute the number
275/// of instructions they actually have in common together at their end. Return
276/// iterators for the first shared instruction in each block.
277static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1,
278 MachineBasicBlock *MBB2,
279 MachineBasicBlock::iterator &I1,
280 MachineBasicBlock::iterator &I2) {
281 I1 = MBB1->end();
282 I2 = MBB2->end();
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000283
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000284 unsigned TailLen = 0;
285 while (I1 != MBB1->begin() && I2 != MBB2->begin()) {
286 --I1; --I2;
Dale Johannesen0eebdbb2010-03-08 05:38:13 +0000287 // Skip debugging pseudos; necessary to avoid changing the code.
288 while (I1->isDebugValue()) {
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000289 if (I1==MBB1->begin()) {
290 while (I2->isDebugValue()) {
291 if (I2==MBB2->begin())
292 // I1==DBG at begin; I2==DBG at begin
293 return TailLen;
294 --I2;
295 }
296 ++I2;
297 // I1==DBG at begin; I2==non-DBG, or first of DBGs not at begin
Dale Johannesen0eebdbb2010-03-08 05:38:13 +0000298 return TailLen;
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000299 }
Dale Johannesen0eebdbb2010-03-08 05:38:13 +0000300 --I1;
301 }
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000302 // I1==first (untested) non-DBG preceding known match
Dale Johannesen0eebdbb2010-03-08 05:38:13 +0000303 while (I2->isDebugValue()) {
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000304 if (I2==MBB2->begin()) {
305 ++I1;
306 // I1==non-DBG, or first of DBGs not at begin; I2==DBG at begin
Dale Johannesen0eebdbb2010-03-08 05:38:13 +0000307 return TailLen;
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000308 }
Dale Johannesen0eebdbb2010-03-08 05:38:13 +0000309 --I2;
310 }
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000311 // I1, I2==first (untested) non-DBGs preceding known match
Duncan P. N. Exon Smithfd8cc232016-02-27 20:01:33 +0000312 if (!I1->isIdenticalTo(*I2) ||
Bill Wendlingf73340e2007-10-25 19:49:32 +0000313 // FIXME: This check is dubious. It's used to get around a problem where
Bill Wendling5f7ed002007-10-25 18:23:45 +0000314 // people incorrectly expect inline asm directives to remain in the same
315 // relative order. This is untenable because normal compiler
316 // optimizations (like this one) may reorder and/or merge these
317 // directives.
Chris Lattnerb06015a2010-02-09 19:54:29 +0000318 I1->isInlineAsm()) {
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000319 ++I1; ++I2;
320 break;
321 }
322 ++TailLen;
323 }
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000324 // Back past possible debugging pseudos at beginning of block. This matters
325 // when one block differs from the other only by whether debugging pseudos
Junmo Park7cc13f22015-12-04 02:06:59 +0000326 // are present at the beginning. (This way, the various checks later for
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000327 // I1==MBB1->begin() work as expected.)
328 if (I1 == MBB1->begin() && I2 != MBB2->begin()) {
329 --I2;
330 while (I2->isDebugValue()) {
Craig Topper2f6031c2012-10-07 20:31:05 +0000331 if (I2 == MBB2->begin())
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000332 return TailLen;
Dale Johannesen5ebe0c12010-03-10 05:45:47 +0000333 --I2;
334 }
335 ++I2;
336 }
337 if (I2 == MBB2->begin() && I1 != MBB1->begin()) {
338 --I1;
339 while (I1->isDebugValue()) {
340 if (I1 == MBB1->begin())
341 return TailLen;
342 --I1;
343 }
344 ++I1;
345 }
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000346 return TailLen;
347}
348
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000349void BranchFolder::ReplaceTailWithBranchTo(MachineBasicBlock::iterator OldInst,
350 MachineBasicBlock *NewDest) {
Evan Cheng2d51c7c2010-06-18 23:09:54 +0000351 TII->ReplaceTailWithBranchTo(OldInst, NewDest);
Eli Friedmanbf007362011-07-06 23:41:48 +0000352
Matthias Braun18198302016-12-16 23:55:37 +0000353 if (UpdateLiveIns) {
354 NewDest->clearLiveIns();
Matthias Braune51c4352017-05-26 06:32:31 +0000355 computeLiveIns(LiveRegs, *MRI, *NewDest);
Matthias Braun18198302016-12-16 23:55:37 +0000356 }
Eli Friedmanbf007362011-07-06 23:41:48 +0000357
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000358 ++NumTailMerge;
359}
360
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000361MachineBasicBlock *BranchFolder::SplitMBBAt(MachineBasicBlock &CurMBB,
Andrew Trick97a1d7c2013-06-24 01:55:01 +0000362 MachineBasicBlock::iterator BBI1,
363 const BasicBlock *BB) {
Evan Cheng37bb6172010-06-22 01:18:16 +0000364 if (!TII->isLegalToSplitMBBAt(CurMBB, BBI1))
Craig Topperc0196b12014-04-14 00:51:57 +0000365 return nullptr;
Evan Cheng37bb6172010-06-22 01:18:16 +0000366
Dan Gohman3b460302008-07-07 23:14:23 +0000367 MachineFunction &MF = *CurMBB.getParent();
368
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000369 // Create the fall-through block.
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +0000370 MachineFunction::iterator MBBI = CurMBB.getIterator();
Andrew Trick97a1d7c2013-06-24 01:55:01 +0000371 MachineBasicBlock *NewMBB =MF.CreateMachineBasicBlock(BB);
Dan Gohman3b460302008-07-07 23:14:23 +0000372 CurMBB.getParent()->insert(++MBBI, NewMBB);
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000373
374 // Move all the successors of this block to the specified block.
Dan Gohman6f880692008-06-19 17:22:29 +0000375 NewMBB->transferSuccessors(&CurMBB);
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000376
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000377 // Add an edge from CurMBB to NewMBB for the fall-through.
378 CurMBB.addSuccessor(NewMBB);
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000379
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000380 // Splice the code over.
381 NewMBB->splice(NewMBB->end(), &CurMBB, BBI1, CurMBB.end());
Dale Johannesend05a1a22007-03-20 21:35:06 +0000382
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000383 // NewMBB belongs to the same loop as CurMBB.
Taewook Oh4cf5c102017-02-21 00:12:38 +0000384 if (MLI)
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000385 if (MachineLoop *ML = MLI->getLoopFor(&CurMBB))
386 ML->addBasicBlockToLoop(NewMBB, MLI->getBase());
387
Akira Hatanakabbd33f62014-08-07 19:30:13 +0000388 // NewMBB inherits CurMBB's block frequency.
389 MBBFreqInfo.setBlockFreq(NewMBB, MBBFreqInfo.getBlockFreq(&CurMBB));
390
Matthias Braun18198302016-12-16 23:55:37 +0000391 if (UpdateLiveIns)
Matthias Braune51c4352017-05-26 06:32:31 +0000392 computeLiveIns(LiveRegs, *MRI, *NewMBB);
Dale Johannesend05a1a22007-03-20 21:35:06 +0000393
David Majnemer16193552015-10-04 02:22:52 +0000394 // Add the new block to the funclet.
395 const auto &FuncletI = FuncletMembership.find(&CurMBB);
Stephan Bergmann480de222016-03-31 15:42:01 +0000396 if (FuncletI != FuncletMembership.end()) {
397 auto n = FuncletI->second;
398 FuncletMembership[NewMBB] = n;
399 }
David Majnemer16193552015-10-04 02:22:52 +0000400
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000401 return NewMBB;
402}
403
Chris Lattner7cee6dd2006-11-01 19:36:29 +0000404/// EstimateRuntime - Make a rough estimate for how long it will take to run
405/// the specified code.
406static unsigned EstimateRuntime(MachineBasicBlock::iterator I,
Chris Lattnera98c6792008-01-07 01:56:04 +0000407 MachineBasicBlock::iterator E) {
Chris Lattner7cee6dd2006-11-01 19:36:29 +0000408 unsigned Time = 0;
409 for (; I != E; ++I) {
Dale Johannesen2061c842010-03-05 00:02:59 +0000410 if (I->isDebugValue())
411 continue;
Evan Cheng7f8e5632011-12-07 07:15:52 +0000412 if (I->isCall())
Chris Lattner7cee6dd2006-11-01 19:36:29 +0000413 Time += 10;
Evan Cheng7f8e5632011-12-07 07:15:52 +0000414 else if (I->mayLoad() || I->mayStore())
Chris Lattner7cee6dd2006-11-01 19:36:29 +0000415 Time += 2;
416 else
417 ++Time;
418 }
419 return Time;
420}
421
Dale Johannesen6e16d092007-05-10 01:01:49 +0000422// CurMBB needs to add an unconditional branch to SuccMBB (we removed these
423// branches temporarily for tail merging). In the case where CurMBB ends
424// with a conditional branch to the next block, optimize by reversing the
425// test and conditionally branching to SuccMBB instead.
Bob Wilson3794ec22009-11-16 18:08:46 +0000426static void FixTail(MachineBasicBlock *CurMBB, MachineBasicBlock *SuccBB,
Dale Johannesen6e16d092007-05-10 01:01:49 +0000427 const TargetInstrInfo *TII) {
428 MachineFunction *MF = CurMBB->getParent();
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +0000429 MachineFunction::iterator I = std::next(MachineFunction::iterator(CurMBB));
Craig Topperc0196b12014-04-14 00:51:57 +0000430 MachineBasicBlock *TBB = nullptr, *FBB = nullptr;
Owen Anderson4f6bf042008-08-14 22:49:33 +0000431 SmallVector<MachineOperand, 4> Cond;
Taewook Oh4cf5c102017-02-21 00:12:38 +0000432 DebugLoc dl = CurMBB->findBranchDebugLoc();
Jacques Pienaar71c30a12016-07-15 14:41:04 +0000433 if (I != MF->end() && !TII->analyzeBranch(*CurMBB, TBB, FBB, Cond, true)) {
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +0000434 MachineBasicBlock *NextBB = &*I;
Dale Johannesen66da8b52008-05-09 23:28:24 +0000435 if (TBB == NextBB && !Cond.empty() && !FBB) {
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +0000436 if (!TII->reverseBranchCondition(Cond)) {
437 TII->removeBranch(*CurMBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +0000438 TII->insertBranch(*CurMBB, SuccBB, nullptr, Cond, dl);
Dale Johannesen6e16d092007-05-10 01:01:49 +0000439 return;
440 }
441 }
442 }
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +0000443 TII->insertBranch(*CurMBB, SuccBB, nullptr,
Stuart Hastings0125b642010-06-17 22:43:56 +0000444 SmallVector<MachineOperand, 0>(), dl);
Dale Johannesen6e16d092007-05-10 01:01:49 +0000445}
446
Dan Gohman02b15542009-11-11 21:57:02 +0000447bool
448BranchFolder::MergePotentialsElt::operator<(const MergePotentialsElt &o) const {
449 if (getHash() < o.getHash())
450 return true;
Craig Topper2f6031c2012-10-07 20:31:05 +0000451 if (getHash() > o.getHash())
Dan Gohman02b15542009-11-11 21:57:02 +0000452 return false;
Craig Topper2f6031c2012-10-07 20:31:05 +0000453 if (getBlock()->getNumber() < o.getBlock()->getNumber())
Dan Gohman02b15542009-11-11 21:57:02 +0000454 return true;
Craig Topper2f6031c2012-10-07 20:31:05 +0000455 if (getBlock()->getNumber() > o.getBlock()->getNumber())
Dan Gohman02b15542009-11-11 21:57:02 +0000456 return false;
Craig Topper2f6031c2012-10-07 20:31:05 +0000457 // _GLIBCXX_DEBUG checks strict weak ordering, which involves comparing
458 // an object with itself.
Duncan Sandsd5ea1942007-07-11 08:47:55 +0000459#ifndef _GLIBCXX_DEBUG
Craig Topper2f6031c2012-10-07 20:31:05 +0000460 llvm_unreachable("Predecessor appears twice");
David Blaikie46a9f012012-01-20 21:51:11 +0000461#else
Craig Topper2f6031c2012-10-07 20:31:05 +0000462 return false;
David Blaikie46a9f012012-01-20 21:51:11 +0000463#endif
Dale Johannesena69ebdb2007-05-29 23:47:50 +0000464}
465
Akira Hatanakabbd33f62014-08-07 19:30:13 +0000466BlockFrequency
467BranchFolder::MBFIWrapper::getBlockFreq(const MachineBasicBlock *MBB) const {
468 auto I = MergedBBFreq.find(MBB);
469
470 if (I != MergedBBFreq.end())
471 return I->second;
472
473 return MBFI.getBlockFreq(MBB);
474}
475
476void BranchFolder::MBFIWrapper::setBlockFreq(const MachineBasicBlock *MBB,
477 BlockFrequency F) {
478 MergedBBFreq[MBB] = F;
479}
480
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000481raw_ostream &
482BranchFolder::MBFIWrapper::printBlockFreq(raw_ostream &OS,
483 const MachineBasicBlock *MBB) const {
484 return MBFI.printBlockFreq(OS, getBlockFreq(MBB));
485}
486
487raw_ostream &
488BranchFolder::MBFIWrapper::printBlockFreq(raw_ostream &OS,
489 const BlockFrequency Freq) const {
490 return MBFI.printBlockFreq(OS, Freq);
491}
492
Xinliang David Li538d6662017-02-15 19:21:04 +0000493void BranchFolder::MBFIWrapper::view(const Twine &Name, bool isSimple) {
494 MBFI.view(Name, isSimple);
495}
Xinliang David Lifd3f6452017-01-29 01:57:02 +0000496
Kyle Buttb15c0662017-01-31 23:48:32 +0000497uint64_t
498BranchFolder::MBFIWrapper::getEntryFreq() const {
499 return MBFI.getEntryFreq();
500}
501
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000502/// CountTerminators - Count the number of terminators in the given
503/// block and set I to the position of the first non-terminator, if there
504/// is one, or MBB->end() otherwise.
505static unsigned CountTerminators(MachineBasicBlock *MBB,
506 MachineBasicBlock::iterator &I) {
507 I = MBB->end();
508 unsigned NumTerms = 0;
509 for (;;) {
510 if (I == MBB->begin()) {
511 I = MBB->end();
512 break;
513 }
514 --I;
Evan Cheng7f8e5632011-12-07 07:15:52 +0000515 if (!I->isTerminator()) break;
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000516 ++NumTerms;
517 }
518 return NumTerms;
519}
520
Reid Klecknera622fc92017-02-14 21:02:24 +0000521/// A no successor, non-return block probably ends in unreachable and is cold.
522/// Also consider a block that ends in an indirect branch to be a return block,
523/// since many targets use plain indirect branches to return.
524static bool blockEndsInUnreachable(const MachineBasicBlock *MBB) {
525 if (!MBB->succ_empty())
526 return false;
527 if (MBB->empty())
528 return true;
529 return !(MBB->back().isReturn() || MBB->back().isIndirectBranch());
530}
531
Bob Wilson94f8f872009-10-29 18:40:06 +0000532/// ProfitableToMerge - Check if two machine basic blocks have a common tail
533/// and decide if it would be profitable to merge those tails. Return the
534/// length of the common tail and iterators to the first common instruction
535/// in each block.
Kyle Butt64e42812016-08-18 18:57:29 +0000536/// MBB1, MBB2 The blocks to check
537/// MinCommonTailLength Minimum size of tail block to be merged.
538/// CommonTailLen Out parameter to record the size of the shared tail between
539/// MBB1 and MBB2
540/// I1, I2 Iterator references that will be changed to point to the first
541/// instruction in the common tail shared by MBB1,MBB2
542/// SuccBB A common successor of MBB1, MBB2 which are in a canonical form
543/// relative to SuccBB
544/// PredBB The layout predecessor of SuccBB, if any.
545/// FuncletMembership map from block to funclet #.
546/// AfterPlacement True if we are merging blocks after layout. Stricter
547/// thresholds apply to prevent undoing tail-duplication.
David Majnemer16193552015-10-04 02:22:52 +0000548static bool
549ProfitableToMerge(MachineBasicBlock *MBB1, MachineBasicBlock *MBB2,
Kyle Butt64e42812016-08-18 18:57:29 +0000550 unsigned MinCommonTailLength, unsigned &CommonTailLen,
David Majnemer16193552015-10-04 02:22:52 +0000551 MachineBasicBlock::iterator &I1,
552 MachineBasicBlock::iterator &I2, MachineBasicBlock *SuccBB,
553 MachineBasicBlock *PredBB,
Kyle Butt71b1ca12016-08-10 18:36:18 +0000554 DenseMap<const MachineBasicBlock *, int> &FuncletMembership,
555 bool AfterPlacement) {
David Majnemer16193552015-10-04 02:22:52 +0000556 // It is never profitable to tail-merge blocks from two different funclets.
557 if (!FuncletMembership.empty()) {
558 auto Funclet1 = FuncletMembership.find(MBB1);
559 assert(Funclet1 != FuncletMembership.end());
560 auto Funclet2 = FuncletMembership.find(MBB2);
561 assert(Funclet2 != FuncletMembership.end());
562 if (Funclet1->second != Funclet2->second)
563 return false;
564 }
565
Bob Wilson94f8f872009-10-29 18:40:06 +0000566 CommonTailLen = ComputeCommonTailLength(MBB1, MBB2, I1, I2);
Bob Wilson94f8f872009-10-29 18:40:06 +0000567 if (CommonTailLen == 0)
568 return false;
Evan Chengb8ed4622011-02-21 23:39:48 +0000569 DEBUG(dbgs() << "Common tail length of BB#" << MBB1->getNumber()
570 << " and BB#" << MBB2->getNumber() << " is " << CommonTailLen
571 << '\n');
Bob Wilson94f8f872009-10-29 18:40:06 +0000572
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000573 // It's almost always profitable to merge any number of non-terminator
574 // instructions with the block that falls through into the common successor.
Kyle Butt71b1ca12016-08-10 18:36:18 +0000575 // This is true only for a single successor. For multiple successors, we are
576 // trading a conditional branch for an unconditional one.
577 // TODO: Re-visit successor size for non-layout tail merging.
578 if ((MBB1 == PredBB || MBB2 == PredBB) &&
579 (!AfterPlacement || MBB1->succ_size() == 1)) {
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000580 MachineBasicBlock::iterator I;
581 unsigned NumTerms = CountTerminators(MBB1 == PredBB ? MBB2 : MBB1, I);
582 if (CommonTailLen > NumTerms)
583 return true;
584 }
585
Reid Klecknera622fc92017-02-14 21:02:24 +0000586 // If these are identical non-return blocks with no successors, merge them.
587 // Such blocks are typically cold calls to noreturn functions like abort, and
588 // are unlikely to become a fallthrough target after machine block placement.
589 // Tail merging these blocks is unlikely to create additional unconditional
590 // branches, and will reduce the size of this cold code.
591 if (I1 == MBB1->begin() && I2 == MBB2->begin() &&
592 blockEndsInUnreachable(MBB1) && blockEndsInUnreachable(MBB2))
593 return true;
594
Dan Gohman09478e92009-11-12 00:39:10 +0000595 // If one of the blocks can be completely merged and happens to be in
596 // a position where the other could fall through into it, merge any number
597 // of instructions, because it can be done without a branch.
598 // TODO: If the blocks are not adjacent, move one of them so that they are?
599 if (MBB1->isLayoutSuccessor(MBB2) && I2 == MBB2->begin())
600 return true;
601 if (MBB2->isLayoutSuccessor(MBB1) && I1 == MBB1->begin())
602 return true;
603
Kyle Butta12bd752017-04-10 22:28:12 +0000604 // If both blocks are identical and end in a branch, merge them unless they
605 // both have a fallthrough predecessor and successor.
606 // We can only do this after block placement because it depends on whether
607 // there are fallthroughs, and we don't know until after layout.
608 if (AfterPlacement && I1 == MBB1->begin() && I2 == MBB2->begin()) {
609 auto BothFallThrough = [](MachineBasicBlock *MBB) {
610 if (MBB->succ_size() != 0 && !MBB->canFallThrough())
611 return false;
612 MachineFunction::iterator I(MBB);
613 MachineFunction *MF = MBB->getParent();
614 return (MBB != &*MF->begin()) && std::prev(I)->canFallThrough();
615 };
616 if (!BothFallThrough(MBB1) || !BothFallThrough(MBB2))
617 return true;
618 }
619
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000620 // If both blocks have an unconditional branch temporarily stripped out,
Dan Gohman225fa59c2009-11-13 21:02:15 +0000621 // count that as an additional common instruction for the following
Kyle Butt71b1ca12016-08-10 18:36:18 +0000622 // heuristics. This heuristic is only accurate for single-succ blocks, so to
623 // make sure that during layout merging and duplicating don't crash, we check
624 // for that when merging during layout.
Dan Gohman225fa59c2009-11-13 21:02:15 +0000625 unsigned EffectiveTailLen = CommonTailLen;
Bob Wilson699f5b92009-11-16 17:56:13 +0000626 if (SuccBB && MBB1 != PredBB && MBB2 != PredBB &&
Kyle Butt71b1ca12016-08-10 18:36:18 +0000627 (MBB1->succ_size() == 1 || !AfterPlacement) &&
Evan Cheng7f8e5632011-12-07 07:15:52 +0000628 !MBB1->back().isBarrier() &&
629 !MBB2->back().isBarrier())
Dan Gohman225fa59c2009-11-13 21:02:15 +0000630 ++EffectiveTailLen;
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000631
632 // Check if the common tail is long enough to be worthwhile.
Kyle Butt64e42812016-08-18 18:57:29 +0000633 if (EffectiveTailLen >= MinCommonTailLength)
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000634 return true;
635
Dan Gohman225fa59c2009-11-13 21:02:15 +0000636 // If we are optimizing for code size, 2 instructions in common is enough if
637 // we don't have to split a block. At worst we will be introducing 1 new
638 // branch instruction, which is likely to be smaller than the 2
639 // instructions that would be deleted in the merge.
Evan Chengb8ed4622011-02-21 23:39:48 +0000640 MachineFunction *MF = MBB1->getParent();
Rafael Espindola84921b92015-10-24 23:11:13 +0000641 return EffectiveTailLen >= 2 && MF->getFunction()->optForSize() &&
642 (I1 == MBB1->begin() || I2 == MBB2->begin());
Bob Wilson94f8f872009-10-29 18:40:06 +0000643}
644
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000645unsigned BranchFolder::ComputeSameTails(unsigned CurHash,
Kyle Butt64e42812016-08-18 18:57:29 +0000646 unsigned MinCommonTailLength,
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000647 MachineBasicBlock *SuccBB,
648 MachineBasicBlock *PredBB) {
Dale Johannesen66da8b52008-05-09 23:28:24 +0000649 unsigned maxCommonTailLength = 0U;
650 SameTails.clear();
651 MachineBasicBlock::iterator TrialBBI1, TrialBBI2;
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +0000652 MPIterator HighestMPIter = std::prev(MergePotentials.end());
653 for (MPIterator CurMPIter = std::prev(MergePotentials.end()),
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000654 B = MergePotentials.begin();
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +0000655 CurMPIter != B && CurMPIter->getHash() == CurHash; --CurMPIter) {
656 for (MPIterator I = std::prev(CurMPIter); I->getHash() == CurHash; --I) {
Bob Wilson94f8f872009-10-29 18:40:06 +0000657 unsigned CommonTailLen;
Dan Gohman02b15542009-11-11 21:57:02 +0000658 if (ProfitableToMerge(CurMPIter->getBlock(), I->getBlock(),
Kyle Butt64e42812016-08-18 18:57:29 +0000659 MinCommonTailLength,
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000660 CommonTailLen, TrialBBI1, TrialBBI2,
David Majnemer16193552015-10-04 02:22:52 +0000661 SuccBB, PredBB,
Kyle Butt71b1ca12016-08-10 18:36:18 +0000662 FuncletMembership,
663 AfterBlockPlacement)) {
Dale Johannesen66da8b52008-05-09 23:28:24 +0000664 if (CommonTailLen > maxCommonTailLength) {
665 SameTails.clear();
666 maxCommonTailLength = CommonTailLen;
667 HighestMPIter = CurMPIter;
Dan Gohman02b15542009-11-11 21:57:02 +0000668 SameTails.push_back(SameTailElt(CurMPIter, TrialBBI1));
Dale Johannesen66da8b52008-05-09 23:28:24 +0000669 }
670 if (HighestMPIter == CurMPIter &&
671 CommonTailLen == maxCommonTailLength)
Dan Gohman02b15542009-11-11 21:57:02 +0000672 SameTails.push_back(SameTailElt(I, TrialBBI2));
Dale Johannesen66da8b52008-05-09 23:28:24 +0000673 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000674 if (I == B)
Dale Johannesen66da8b52008-05-09 23:28:24 +0000675 break;
676 }
677 }
678 return maxCommonTailLength;
679}
680
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000681void BranchFolder::RemoveBlocksWithHash(unsigned CurHash,
Bob Wilson3794ec22009-11-16 18:08:46 +0000682 MachineBasicBlock *SuccBB,
683 MachineBasicBlock *PredBB) {
Dale Johannesenb28a17c2008-05-23 17:19:02 +0000684 MPIterator CurMPIter, B;
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +0000685 for (CurMPIter = std::prev(MergePotentials.end()),
686 B = MergePotentials.begin();
687 CurMPIter->getHash() == CurHash; --CurMPIter) {
Dale Johannesen66da8b52008-05-09 23:28:24 +0000688 // Put the unconditional branch back, if we need one.
Dan Gohman02b15542009-11-11 21:57:02 +0000689 MachineBasicBlock *CurMBB = CurMPIter->getBlock();
Dale Johannesen66da8b52008-05-09 23:28:24 +0000690 if (SuccBB && CurMBB != PredBB)
691 FixTail(CurMBB, SuccBB, TII);
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000692 if (CurMPIter == B)
Dale Johannesen66da8b52008-05-09 23:28:24 +0000693 break;
694 }
Dan Gohman02b15542009-11-11 21:57:02 +0000695 if (CurMPIter->getHash() != CurHash)
Dale Johannesenb28a17c2008-05-23 17:19:02 +0000696 CurMPIter++;
697 MergePotentials.erase(CurMPIter, MergePotentials.end());
Dale Johannesen66da8b52008-05-09 23:28:24 +0000698}
699
Evan Cheng37bb6172010-06-22 01:18:16 +0000700bool BranchFolder::CreateCommonTailOnlyBlock(MachineBasicBlock *&PredBB,
Andrew Trick97a1d7c2013-06-24 01:55:01 +0000701 MachineBasicBlock *SuccBB,
Evan Cheng37bb6172010-06-22 01:18:16 +0000702 unsigned maxCommonTailLength,
703 unsigned &commonTailIndex) {
704 commonTailIndex = 0;
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000705 unsigned TimeEstimate = ~0U;
Dan Gohmanb3bf49f2009-11-12 01:51:28 +0000706 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) {
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000707 // Use PredBB if possible; that doesn't require a new branch.
Dan Gohman02b15542009-11-11 21:57:02 +0000708 if (SameTails[i].getBlock() == PredBB) {
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000709 commonTailIndex = i;
710 break;
711 }
712 // Otherwise, make a (fairly bogus) choice based on estimate of
713 // how long it will take the various blocks to execute.
Dan Gohman02b15542009-11-11 21:57:02 +0000714 unsigned t = EstimateRuntime(SameTails[i].getBlock()->begin(),
715 SameTails[i].getTailStartPos());
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000716 if (t <= TimeEstimate) {
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000717 TimeEstimate = t;
718 commonTailIndex = i;
719 }
720 }
721
Dan Gohman02b15542009-11-11 21:57:02 +0000722 MachineBasicBlock::iterator BBI =
723 SameTails[commonTailIndex].getTailStartPos();
724 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000725
David Greened60abbf2009-12-24 00:34:21 +0000726 DEBUG(dbgs() << "\nSplitting BB#" << MBB->getNumber() << ", size "
Bill Wendlingc3f05e82009-08-22 20:03:00 +0000727 << maxCommonTailLength);
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000728
Andrew Trick97a1d7c2013-06-24 01:55:01 +0000729 // If the split block unconditionally falls-thru to SuccBB, it will be
730 // merged. In control flow terms it should then take SuccBB's name. e.g. If
731 // SuccBB is an inner loop, the common tail is still part of the inner loop.
732 const BasicBlock *BB = (SuccBB && MBB->succ_size() == 1) ?
733 SuccBB->getBasicBlock() : MBB->getBasicBlock();
734 MachineBasicBlock *newMBB = SplitMBBAt(*MBB, BBI, BB);
Evan Cheng37bb6172010-06-22 01:18:16 +0000735 if (!newMBB) {
736 DEBUG(dbgs() << "... failed!");
737 return false;
738 }
739
Dan Gohman02b15542009-11-11 21:57:02 +0000740 SameTails[commonTailIndex].setBlock(newMBB);
741 SameTails[commonTailIndex].setTailStartPos(newMBB->begin());
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000742
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000743 // If we split PredBB, newMBB is the new predecessor.
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000744 if (PredBB == MBB)
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000745 PredBB = newMBB;
746
Evan Cheng37bb6172010-06-22 01:18:16 +0000747 return true;
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000748}
749
Taewook Ohfb1833e2017-03-15 05:44:59 +0000750void BranchFolder::MergeCommonTailDebugLocs(unsigned commonTailIndex) {
751 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
752
753 std::vector<MachineBasicBlock::iterator> NextCommonInsts(SameTails.size());
754 for (unsigned int i = 0 ; i != SameTails.size() ; ++i) {
755 if (i != commonTailIndex)
756 NextCommonInsts[i] = SameTails[i].getTailStartPos();
757 else {
758 assert(SameTails[i].getTailStartPos() == MBB->begin() &&
759 "MBB is not a common tail only block");
760 }
761 }
762
763 for (auto &MI : *MBB) {
764 if (MI.isDebugValue())
765 continue;
766 DebugLoc DL = MI.getDebugLoc();
767 for (unsigned int i = 0 ; i < NextCommonInsts.size() ; i++) {
768 if (i == commonTailIndex)
769 continue;
770
771 auto &Pos = NextCommonInsts[i];
772 assert(Pos != SameTails[i].getBlock()->end() &&
773 "Reached BB end within common tail");
774 while (Pos->isDebugValue()) {
775 ++Pos;
776 assert(Pos != SameTails[i].getBlock()->end() &&
777 "Reached BB end within common tail");
778 }
779 assert(MI.isIdenticalTo(*Pos) && "Expected matching MIIs!");
780 DL = DILocation::getMergedLocation(DL, Pos->getDebugLoc());
781 NextCommonInsts[i] = ++Pos;
782 }
783 MI.setDebugLoc(DL);
784 }
785}
786
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000787static void
Matthias Braun4040c0f2016-09-20 01:14:42 +0000788mergeOperations(MachineBasicBlock::iterator MBBIStartPos,
789 MachineBasicBlock &MBBCommon) {
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000790 MachineBasicBlock *MBB = MBBIStartPos->getParent();
791 // Note CommonTailLen does not necessarily matches the size of
792 // the common BB nor all its instructions because of debug
793 // instructions differences.
794 unsigned CommonTailLen = 0;
795 for (auto E = MBB->end(); MBBIStartPos != E; ++MBBIStartPos)
796 ++CommonTailLen;
797
798 MachineBasicBlock::reverse_iterator MBBI = MBB->rbegin();
Chad Rosier99fb8d12015-03-10 20:29:59 +0000799 MachineBasicBlock::reverse_iterator MBBIE = MBB->rend();
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000800 MachineBasicBlock::reverse_iterator MBBICommon = MBBCommon.rbegin();
801 MachineBasicBlock::reverse_iterator MBBIECommon = MBBCommon.rend();
802
803 while (CommonTailLen--) {
Chad Rosier99fb8d12015-03-10 20:29:59 +0000804 assert(MBBI != MBBIE && "Reached BB end within common tail length!");
805 (void)MBBIE;
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000806
807 if (MBBI->isDebugValue()) {
808 ++MBBI;
809 continue;
810 }
811
812 while ((MBBICommon != MBBIECommon) && MBBICommon->isDebugValue())
813 ++MBBICommon;
814
815 assert(MBBICommon != MBBIECommon &&
816 "Reached BB end within common tail length!");
Duncan P. N. Exon Smithfd8cc232016-02-27 20:01:33 +0000817 assert(MBBICommon->isIdenticalTo(*MBBI) && "Expected matching MIIs!");
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000818
Matthias Braun4040c0f2016-09-20 01:14:42 +0000819 // Merge MMOs from memory operations in the common block.
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000820 if (MBBICommon->mayLoad() || MBBICommon->mayStore())
Junmo Park7ceec0b2016-01-11 07:15:38 +0000821 MBBICommon->setMemRefs(MBBICommon->mergeMemRefsWith(*MBBI));
Matthias Braun4040c0f2016-09-20 01:14:42 +0000822 // Drop undef flags if they aren't present in all merged instructions.
823 for (unsigned I = 0, E = MBBICommon->getNumOperands(); I != E; ++I) {
824 MachineOperand &MO = MBBICommon->getOperand(I);
825 if (MO.isReg() && MO.isUndef()) {
826 const MachineOperand &OtherMO = MBBI->getOperand(I);
827 if (!OtherMO.isUndef())
828 MO.setIsUndef(false);
829 }
830 }
Chad Rosier3b67c8d2015-03-10 16:22:52 +0000831
832 ++MBBI;
833 ++MBBICommon;
834 }
835}
836
Kyle Butt83a25792016-07-11 21:37:03 +0000837// See if any of the blocks in MergePotentials (which all have SuccBB as a
838// successor, or all have no successor if it is null) can be tail-merged.
839// If there is a successor, any blocks in MergePotentials that are not
840// tail-merged and are not immediately before Succ must have an unconditional
841// branch to Succ added (but the predecessor/successor lists need no
842// adjustment). The lone predecessor of Succ that falls through into Succ,
Dale Johannesen9a25b3a2007-05-07 20:57:21 +0000843// if any, is given in PredBB.
Kyle Butt64e42812016-08-18 18:57:29 +0000844// MinCommonTailLength - Except for the special cases below, tail-merge if
845// there are at least this many instructions in common.
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000846bool BranchFolder::TryTailMergeBlocks(MachineBasicBlock *SuccBB,
Kyle Butt64e42812016-08-18 18:57:29 +0000847 MachineBasicBlock *PredBB,
848 unsigned MinCommonTailLength) {
Evan Cheng3d2fce02009-09-04 07:47:40 +0000849 bool MadeChange = false;
850
David Greened60abbf2009-12-24 00:34:21 +0000851 DEBUG(dbgs() << "\nTryTailMergeBlocks: ";
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000852 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i)
David Greened60abbf2009-12-24 00:34:21 +0000853 dbgs() << "BB#" << MergePotentials[i].getBlock()->getNumber()
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000854 << (i == e-1 ? "" : ", ");
David Greened60abbf2009-12-24 00:34:21 +0000855 dbgs() << "\n";
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000856 if (SuccBB) {
David Greened60abbf2009-12-24 00:34:21 +0000857 dbgs() << " with successor BB#" << SuccBB->getNumber() << '\n';
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000858 if (PredBB)
David Greened60abbf2009-12-24 00:34:21 +0000859 dbgs() << " which has fall-through from BB#"
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000860 << PredBB->getNumber() << "\n";
861 }
David Greened60abbf2009-12-24 00:34:21 +0000862 dbgs() << "Looking for common tails of at least "
Kyle Butt64e42812016-08-18 18:57:29 +0000863 << MinCommonTailLength << " instruction"
864 << (MinCommonTailLength == 1 ? "" : "s") << '\n';
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000865 );
Dale Johannesen66da8b52008-05-09 23:28:24 +0000866
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000867 // Sort by hash value so that blocks with identical end sequences sort
868 // together.
Benjamin Kramer848c9fa2015-03-13 21:17:02 +0000869 array_pod_sort(MergePotentials.begin(), MergePotentials.end());
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000870
871 // Walk through equivalence sets looking for actual exact matches.
872 while (MergePotentials.size() > 1) {
Dan Gohman02b15542009-11-11 21:57:02 +0000873 unsigned CurHash = MergePotentials.back().getHash();
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000874
Dale Johannesen66da8b52008-05-09 23:28:24 +0000875 // Build SameTails, identifying the set of blocks with this hash code
876 // and with the maximum number of instructions in common.
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000877 unsigned maxCommonTailLength = ComputeSameTails(CurHash,
Kyle Butt64e42812016-08-18 18:57:29 +0000878 MinCommonTailLength,
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000879 SuccBB, PredBB);
Dale Johannesenf4a77d22007-05-23 21:07:20 +0000880
Kyle Butt64e42812016-08-18 18:57:29 +0000881 // If we didn't find any pair that has at least MinCommonTailLength
Dale Johannesencff7df22008-05-09 21:24:35 +0000882 // instructions in common, remove all blocks with this hash code and retry.
883 if (SameTails.empty()) {
Dale Johannesen66da8b52008-05-09 23:28:24 +0000884 RemoveBlocksWithHash(CurHash, SuccBB, PredBB);
Dale Johannesenf4a77d22007-05-23 21:07:20 +0000885 continue;
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000886 }
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000887
Dale Johannesencff7df22008-05-09 21:24:35 +0000888 // If one of the blocks is the entire common tail (and not the entry
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000889 // block, which we can't jump to), we can treat all blocks with this same
890 // tail at once. Use PredBB if that is one of the possibilities, as that
891 // will not introduce any extra branches.
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +0000892 MachineBasicBlock *EntryBB =
893 &MergePotentials.front().getBlock()->getParent()->front();
Dan Gohman02b15542009-11-11 21:57:02 +0000894 unsigned commonTailIndex = SameTails.size();
Dan Gohman09478e92009-11-12 00:39:10 +0000895 // If there are two blocks, check to see if one can be made to fall through
896 // into the other.
897 if (SameTails.size() == 2 &&
898 SameTails[0].getBlock()->isLayoutSuccessor(SameTails[1].getBlock()) &&
899 SameTails[1].tailIsWholeBlock())
900 commonTailIndex = 1;
901 else if (SameTails.size() == 2 &&
902 SameTails[1].getBlock()->isLayoutSuccessor(
903 SameTails[0].getBlock()) &&
904 SameTails[0].tailIsWholeBlock())
905 commonTailIndex = 0;
906 else {
907 // Otherwise just pick one, favoring the fall-through predecessor if
908 // there is one.
909 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) {
910 MachineBasicBlock *MBB = SameTails[i].getBlock();
911 if (MBB == EntryBB && SameTails[i].tailIsWholeBlock())
912 continue;
913 if (MBB == PredBB) {
914 commonTailIndex = i;
915 break;
916 }
917 if (SameTails[i].tailIsWholeBlock())
918 commonTailIndex = i;
Dale Johannesencff7df22008-05-09 21:24:35 +0000919 }
Dale Johannesencff7df22008-05-09 21:24:35 +0000920 }
Dale Johannesen3c0a1372007-06-01 23:02:45 +0000921
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000922 if (commonTailIndex == SameTails.size() ||
Dan Gohman02b15542009-11-11 21:57:02 +0000923 (SameTails[commonTailIndex].getBlock() == PredBB &&
924 !SameTails[commonTailIndex].tailIsWholeBlock())) {
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000925 // None of the blocks consist entirely of the common tail.
926 // Split a block so that one does.
Andrew Trick97a1d7c2013-06-24 01:55:01 +0000927 if (!CreateCommonTailOnlyBlock(PredBB, SuccBB,
Evan Cheng37bb6172010-06-22 01:18:16 +0000928 maxCommonTailLength, commonTailIndex)) {
929 RemoveBlocksWithHash(CurHash, SuccBB, PredBB);
930 continue;
931 }
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000932 }
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000933
Dan Gohman02b15542009-11-11 21:57:02 +0000934 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
Akira Hatanakabbd33f62014-08-07 19:30:13 +0000935
Marianne Mailhot-Sarrasineddc5b12016-03-10 21:54:25 +0000936 // Recompute common tail MBB's edge weights and block frequency.
Akira Hatanakabbd33f62014-08-07 19:30:13 +0000937 setCommonTailEdgeWeights(*MBB);
938
Taewook Oh1b192332017-03-15 06:29:23 +0000939 // Merge debug locations across identical instructions for common tail.
Taewook Ohfb1833e2017-03-15 05:44:59 +0000940 MergeCommonTailDebugLocs(commonTailIndex);
Robert Lougher660f2f92016-10-26 17:01:47 +0000941
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000942 // MBB is common tail. Adjust all other BB's to jump to this one.
943 // Traversal must be forwards so erases work.
David Greened60abbf2009-12-24 00:34:21 +0000944 DEBUG(dbgs() << "\nUsing common tail in BB#" << MBB->getNumber()
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000945 << " for ");
946 for (unsigned int i=0, e = SameTails.size(); i != e; ++i) {
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000947 if (commonTailIndex == i)
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000948 continue;
David Greened60abbf2009-12-24 00:34:21 +0000949 DEBUG(dbgs() << "BB#" << SameTails[i].getBlock()->getNumber()
Dan Gohman64b5d0f2009-11-11 19:48:59 +0000950 << (i == e-1 ? "" : ", "));
Matthias Braun4040c0f2016-09-20 01:14:42 +0000951 // Merge operations (MMOs, undef flags)
952 mergeOperations(SameTails[i].getTailStartPos(), *MBB);
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000953 // Hack the end off BB i, making it jump to BB commonTailIndex instead.
Dan Gohman02b15542009-11-11 21:57:02 +0000954 ReplaceTailWithBranchTo(SameTails[i].getTailStartPos(), MBB);
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000955 // BB i is no longer a predecessor of SuccBB; remove it from the worklist.
Dan Gohman02b15542009-11-11 21:57:02 +0000956 MergePotentials.erase(SameTails[i].getMPIter());
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000957 }
David Greened60abbf2009-12-24 00:34:21 +0000958 DEBUG(dbgs() << "\n");
Dale Johannesenc4c4d8e2008-05-12 20:33:57 +0000959 // We leave commonTailIndex in the worklist in case there are other blocks
960 // that match it with a smaller number of instructions.
Chris Lattnerf505a5a2006-11-01 01:16:12 +0000961 MadeChange = true;
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000962 }
Chris Lattner60c9d4d2006-10-21 00:47:49 +0000963 return MadeChange;
964}
965
Dale Johannesen9a25b3a2007-05-07 20:57:21 +0000966bool BranchFolder::TailMergeBlocks(MachineFunction &MF) {
Evan Cheng3d2fce02009-09-04 07:47:40 +0000967 bool MadeChange = false;
Bill Wendling041793c2012-05-23 22:09:50 +0000968 if (!EnableTailMerge) return MadeChange;
Dale Johannesen6e16d092007-05-10 01:01:49 +0000969
Dale Johannesen9a25b3a2007-05-07 20:57:21 +0000970 // First find blocks with no successors.
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000971 // Block placement does not create new tail merging opportunities for these
972 // blocks.
973 if (!AfterBlockPlacement) {
974 MergePotentials.clear();
975 for (MachineBasicBlock &MBB : MF) {
976 if (MergePotentials.size() == TailMergeThreshold)
977 break;
978 if (!TriedMerging.count(&MBB) && MBB.succ_empty())
979 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(MBB), &MBB));
980 }
981
982 // If this is a large problem, avoid visiting the same basic blocks
983 // multiple times.
Craig Topper5db36df2015-09-16 03:52:35 +0000984 if (MergePotentials.size() == TailMergeThreshold)
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000985 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i)
986 TriedMerging.insert(MergePotentials[i].getBlock());
987
988 // See if we can do any tail merging on those.
989 if (MergePotentials.size() >= 2)
Kyle Butt64e42812016-08-18 18:57:29 +0000990 MadeChange |= TryTailMergeBlocks(nullptr, nullptr, MinCommonTailLength);
Dale Johannesen9a25b3a2007-05-07 20:57:21 +0000991 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000992
Dale Johannesen6e16d092007-05-10 01:01:49 +0000993 // Look at blocks (IBB) with multiple predecessors (PBB).
994 // We change each predecessor to a canonical form, by
995 // (1) temporarily removing any unconditional branch from the predecessor
996 // to IBB, and
997 // (2) alter conditional branches so they branch to the other block
Dan Gohmanc86b5a12009-11-11 18:38:14 +0000998 // not IBB; this may require adding back an unconditional branch to IBB
Dale Johannesen6e16d092007-05-10 01:01:49 +0000999 // later, where there wasn't one coming in. E.g.
1000 // Bcc IBB
1001 // fallthrough to QBB
1002 // here becomes
1003 // Bncc QBB
1004 // with a conceptual B to IBB after that, which never actually exists.
1005 // With those changes, we see whether the predecessors' tails match,
1006 // and merge them if so. We change things out of canonical form and
1007 // back to the way they were later in the process. (OptimizeBranches
1008 // would undo some of this, but we can't use it, because we'd get into
1009 // a compile-time infinite loop repeatedly doing and undoing the same
1010 // transformations.)
Dale Johannesen9a25b3a2007-05-07 20:57:21 +00001011
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +00001012 for (MachineFunction::iterator I = std::next(MF.begin()), E = MF.end();
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001013 I != E; ++I) {
Bill Wendlinge351e8c2012-05-23 22:12:50 +00001014 if (I->pred_size() < 2) continue;
Bill Wendling041793c2012-05-23 22:09:50 +00001015 SmallPtrSet<MachineBasicBlock *, 8> UniquePreds;
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001016 MachineBasicBlock *IBB = &*I;
1017 MachineBasicBlock *PredBB = &*std::prev(I);
Bill Wendling041793c2012-05-23 22:09:50 +00001018 MergePotentials.clear();
Haicheng Wu7c4535d2016-08-12 23:13:38 +00001019 MachineLoop *ML;
1020
1021 // Bail if merging after placement and IBB is the loop header because
1022 // -- If merging predecessors that belong to the same loop as IBB, the
1023 // common tail of merged predecessors may become the loop top if block
1024 // placement is called again and the predecessors may branch to this common
1025 // tail and require more branches. This can be relaxed if
1026 // MachineBlockPlacement::findBestLoopTop is more flexible.
1027 // --If merging predecessors that do not belong to the same loop as IBB, the
1028 // loop info of IBB's loop and the other loops may be affected. Calling the
1029 // block placement again may make big change to the layout and eliminate the
1030 // reason to do tail merging here.
1031 if (AfterBlockPlacement && MLI) {
1032 ML = MLI->getLoopFor(IBB);
1033 if (ML && IBB == ML->getHeader())
1034 continue;
1035 }
1036
Craig Topper5db36df2015-09-16 03:52:35 +00001037 for (MachineBasicBlock *PBB : I->predecessors()) {
1038 if (MergePotentials.size() == TailMergeThreshold)
1039 break;
1040
Bill Wendling041793c2012-05-23 22:09:50 +00001041 if (TriedMerging.count(PBB))
1042 continue;
1043
1044 // Skip blocks that loop to themselves, can't tail merge these.
1045 if (PBB == IBB)
1046 continue;
1047
1048 // Visit each predecessor only once.
David Blaikie70573dc2014-11-19 07:49:26 +00001049 if (!UniquePreds.insert(PBB).second)
Bill Wendling041793c2012-05-23 22:09:50 +00001050 continue;
1051
1052 // Skip blocks which may jump to a landing pad. Can't tail merge these.
Reid Klecknered170792015-09-17 17:19:40 +00001053 if (PBB->hasEHPadSuccessor())
Bill Wendling041793c2012-05-23 22:09:50 +00001054 continue;
1055
Haicheng Wu7c4535d2016-08-12 23:13:38 +00001056 // After block placement, only consider predecessors that belong to the
1057 // same loop as IBB. The reason is the same as above when skipping loop
1058 // header.
Haicheng Wu5b458cc2016-06-09 15:24:29 +00001059 if (AfterBlockPlacement && MLI)
Haicheng Wu7c4535d2016-08-12 23:13:38 +00001060 if (ML != MLI->getLoopFor(PBB))
1061 continue;
Haicheng Wu5b458cc2016-06-09 15:24:29 +00001062
Craig Topperc0196b12014-04-14 00:51:57 +00001063 MachineBasicBlock *TBB = nullptr, *FBB = nullptr;
Bill Wendling041793c2012-05-23 22:09:50 +00001064 SmallVector<MachineOperand, 4> Cond;
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001065 if (!TII->analyzeBranch(*PBB, TBB, FBB, Cond, true)) {
Bill Wendling041793c2012-05-23 22:09:50 +00001066 // Failing case: IBB is the target of a cbr, and we cannot reverse the
1067 // branch.
1068 SmallVector<MachineOperand, 4> NewCond(Cond);
1069 if (!Cond.empty() && TBB == IBB) {
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001070 if (TII->reverseBranchCondition(NewCond))
Bill Wendling041793c2012-05-23 22:09:50 +00001071 continue;
1072 // This is the QBB case described above
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001073 if (!FBB) {
1074 auto Next = ++PBB->getIterator();
1075 if (Next != MF.end())
1076 FBB = &*Next;
1077 }
Dale Johannesen9a25b3a2007-05-07 20:57:21 +00001078 }
Bill Wendling041793c2012-05-23 22:09:50 +00001079
1080 // Failing case: the only way IBB can be reached from PBB is via
1081 // exception handling. Happens for landing pads. Would be nice to have
1082 // a bit in the edge so we didn't have to do all this.
Reid Kleckner0e288232015-08-27 23:27:47 +00001083 if (IBB->isEHPad()) {
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001084 MachineFunction::iterator IP = ++PBB->getIterator();
Craig Topperc0196b12014-04-14 00:51:57 +00001085 MachineBasicBlock *PredNextBB = nullptr;
Bill Wendling041793c2012-05-23 22:09:50 +00001086 if (IP != MF.end())
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001087 PredNextBB = &*IP;
Craig Topperc0196b12014-04-14 00:51:57 +00001088 if (!TBB) {
Bill Wendling041793c2012-05-23 22:09:50 +00001089 if (IBB != PredNextBB) // fallthrough
1090 continue;
1091 } else if (FBB) {
1092 if (TBB != IBB && FBB != IBB) // cbr then ubr
1093 continue;
1094 } else if (Cond.empty()) {
1095 if (TBB != IBB) // ubr
1096 continue;
1097 } else {
1098 if (TBB != IBB && IBB != PredNextBB) // cbr
1099 continue;
1100 }
1101 }
1102
1103 // Remove the unconditional branch at the end, if any.
1104 if (TBB && (Cond.empty() || FBB)) {
Taewook Oh4cf5c102017-02-21 00:12:38 +00001105 DebugLoc dl = PBB->findBranchDebugLoc();
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001106 TII->removeBranch(*PBB);
Bill Wendling041793c2012-05-23 22:09:50 +00001107 if (!Cond.empty())
1108 // reinsert conditional branch only, for now
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001109 TII->insertBranch(*PBB, (TBB == IBB) ? FBB : TBB, nullptr,
Craig Topperc0196b12014-04-14 00:51:57 +00001110 NewCond, dl);
Bill Wendling041793c2012-05-23 22:09:50 +00001111 }
1112
Duncan P. N. Exon Smithd3a74672016-02-27 19:48:01 +00001113 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(*PBB), PBB));
Dale Johannesen9a25b3a2007-05-07 20:57:21 +00001114 }
Dale Johannesen9a25b3a2007-05-07 20:57:21 +00001115 }
Bill Wendling041793c2012-05-23 22:09:50 +00001116
1117 // If this is a large problem, avoid visiting the same basic blocks multiple
1118 // times.
1119 if (MergePotentials.size() == TailMergeThreshold)
1120 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i)
1121 TriedMerging.insert(MergePotentials[i].getBlock());
1122
1123 if (MergePotentials.size() >= 2)
Kyle Butt64e42812016-08-18 18:57:29 +00001124 MadeChange |= TryTailMergeBlocks(IBB, PredBB, MinCommonTailLength);
Bill Wendling041793c2012-05-23 22:09:50 +00001125
1126 // Reinsert an unconditional branch if needed. The 1 below can occur as a
1127 // result of removing blocks in TryTailMergeBlocks.
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001128 PredBB = &*std::prev(I); // this may have been changed in TryTailMergeBlocks
Bill Wendling041793c2012-05-23 22:09:50 +00001129 if (MergePotentials.size() == 1 &&
1130 MergePotentials.begin()->getBlock() != PredBB)
1131 FixTail(MergePotentials.begin()->getBlock(), IBB, TII);
Dale Johannesen9a25b3a2007-05-07 20:57:21 +00001132 }
Bill Wendling041793c2012-05-23 22:09:50 +00001133
Dale Johannesen9a25b3a2007-05-07 20:57:21 +00001134 return MadeChange;
1135}
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001136
Akira Hatanakabbd33f62014-08-07 19:30:13 +00001137void BranchFolder::setCommonTailEdgeWeights(MachineBasicBlock &TailMBB) {
1138 SmallVector<BlockFrequency, 2> EdgeFreqLs(TailMBB.succ_size());
1139 BlockFrequency AccumulatedMBBFreq;
1140
1141 // Aggregate edge frequency of successor edge j:
1142 // edgeFreq(j) = sum (freq(bb) * edgeProb(bb, j)),
1143 // where bb is a basic block that is in SameTails.
1144 for (const auto &Src : SameTails) {
1145 const MachineBasicBlock *SrcMBB = Src.getBlock();
1146 BlockFrequency BlockFreq = MBBFreqInfo.getBlockFreq(SrcMBB);
1147 AccumulatedMBBFreq += BlockFreq;
1148
1149 // It is not necessary to recompute edge weights if TailBB has less than two
1150 // successors.
1151 if (TailMBB.succ_size() <= 1)
1152 continue;
1153
1154 auto EdgeFreq = EdgeFreqLs.begin();
1155
1156 for (auto SuccI = TailMBB.succ_begin(), SuccE = TailMBB.succ_end();
1157 SuccI != SuccE; ++SuccI, ++EdgeFreq)
1158 *EdgeFreq += BlockFreq * MBPI.getEdgeProbability(SrcMBB, *SuccI);
1159 }
1160
1161 MBBFreqInfo.setBlockFreq(&TailMBB, AccumulatedMBBFreq);
1162
1163 if (TailMBB.succ_size() <= 1)
1164 return;
1165
Cong Houd97c1002015-12-01 05:29:22 +00001166 auto SumEdgeFreq =
1167 std::accumulate(EdgeFreqLs.begin(), EdgeFreqLs.end(), BlockFrequency(0))
1168 .getFrequency();
Akira Hatanakabbd33f62014-08-07 19:30:13 +00001169 auto EdgeFreq = EdgeFreqLs.begin();
1170
Cong Houd97c1002015-12-01 05:29:22 +00001171 if (SumEdgeFreq > 0) {
1172 for (auto SuccI = TailMBB.succ_begin(), SuccE = TailMBB.succ_end();
1173 SuccI != SuccE; ++SuccI, ++EdgeFreq) {
1174 auto Prob = BranchProbability::getBranchProbability(
1175 EdgeFreq->getFrequency(), SumEdgeFreq);
1176 TailMBB.setSuccProbability(SuccI, Prob);
1177 }
1178 }
Akira Hatanakabbd33f62014-08-07 19:30:13 +00001179}
1180
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001181//===----------------------------------------------------------------------===//
1182// Branch Optimization
1183//===----------------------------------------------------------------------===//
1184
1185bool BranchFolder::OptimizeBranches(MachineFunction &MF) {
Evan Cheng3d2fce02009-09-04 07:47:40 +00001186 bool MadeChange = false;
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001187
Dale Johannesen12920dd2007-02-17 00:44:34 +00001188 // Make sure blocks are numbered in order
1189 MF.RenumberBlocks();
David Majnemer16193552015-10-04 02:22:52 +00001190 // Renumbering blocks alters funclet membership, recalculate it.
1191 FuncletMembership = getFuncletMembership(MF);
Dale Johannesen12920dd2007-02-17 00:44:34 +00001192
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +00001193 for (MachineFunction::iterator I = std::next(MF.begin()), E = MF.end();
Evan Chengcfdf3392011-05-12 00:56:58 +00001194 I != E; ) {
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001195 MachineBasicBlock *MBB = &*I++;
Evan Cheng3d2fce02009-09-04 07:47:40 +00001196 MadeChange |= OptimizeBlock(MBB);
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001197
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001198 // If it is dead, remove it.
Jim Laskey9df1a1d2007-02-22 16:39:03 +00001199 if (MBB->pred_empty()) {
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001200 RemoveDeadBlock(MBB);
1201 MadeChange = true;
1202 ++NumDeadBlocks;
1203 }
1204 }
David Majnemer16193552015-10-04 02:22:52 +00001205
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001206 return MadeChange;
1207}
1208
Dale Johannesen5ebe0c12010-03-10 05:45:47 +00001209// Blocks should be considered empty if they contain only debug info;
1210// else the debug info would affect codegen.
1211static bool IsEmptyBlock(MachineBasicBlock *MBB) {
Benjamin Kramer6b568962015-06-23 14:47:29 +00001212 return MBB->getFirstNonDebugInstr() == MBB->end();
Dale Johannesen5ebe0c12010-03-10 05:45:47 +00001213}
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001214
Dale Johannesene9b361b2010-03-10 19:57:56 +00001215// Blocks with only debug info and branches should be considered the same
1216// as blocks with only branches.
1217static bool IsBranchOnlyBlock(MachineBasicBlock *MBB) {
Benjamin Kramer6b568962015-06-23 14:47:29 +00001218 MachineBasicBlock::iterator I = MBB->getFirstNonDebugInstr();
1219 assert(I != MBB->end() && "empty block!");
1220 return I->isBranch();
Dale Johannesene9b361b2010-03-10 19:57:56 +00001221}
1222
Chris Lattner47ce2612006-11-18 20:47:54 +00001223/// IsBetterFallthrough - Return true if it would be clearly better to
1224/// fall-through to MBB1 than to fall through into MBB2. This has to return
1225/// a strict ordering, returning true for both (MBB1,MBB2) and (MBB2,MBB1) will
1226/// result in infinite loops.
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001227static bool IsBetterFallthrough(MachineBasicBlock *MBB1,
Chris Lattnera98c6792008-01-07 01:56:04 +00001228 MachineBasicBlock *MBB2) {
Chris Lattner7acdc17f2006-11-18 21:30:35 +00001229 // Right now, we use a simple heuristic. If MBB2 ends with a call, and
1230 // MBB1 doesn't, we prefer to fall through into MBB1. This allows us to
Chris Lattner47ce2612006-11-18 20:47:54 +00001231 // optimize branches that branch to either a return block or an assert block
1232 // into a fallthrough to the return.
Benjamin Kramer6b568962015-06-23 14:47:29 +00001233 MachineBasicBlock::iterator MBB1I = MBB1->getLastNonDebugInstr();
1234 MachineBasicBlock::iterator MBB2I = MBB2->getLastNonDebugInstr();
1235 if (MBB1I == MBB1->end() || MBB2I == MBB2->end())
1236 return false;
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001237
Christopher Lambd202e032007-12-10 07:24:06 +00001238 // If there is a clear successor ordering we make sure that one block
1239 // will fall through to the next
1240 if (MBB1->isSuccessor(MBB2)) return true;
1241 if (MBB2->isSuccessor(MBB1)) return false;
Chris Lattner47ce2612006-11-18 20:47:54 +00001242
Evan Cheng7f8e5632011-12-07 07:15:52 +00001243 return MBB2I->isCall() && !MBB1I->isCall();
Chris Lattner47ce2612006-11-18 20:47:54 +00001244}
1245
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001246/// getBranchDebugLoc - Find and return, if any, the DebugLoc of the branch
Benjamin Kramer6b568962015-06-23 14:47:29 +00001247/// instructions on the block.
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001248static DebugLoc getBranchDebugLoc(MachineBasicBlock &MBB) {
Benjamin Kramer6b568962015-06-23 14:47:29 +00001249 MachineBasicBlock::iterator I = MBB.getLastNonDebugInstr();
1250 if (I != MBB.end() && I->isBranch())
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001251 return I->getDebugLoc();
1252 return DebugLoc();
1253}
1254
Evan Cheng3d2fce02009-09-04 07:47:40 +00001255bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) {
1256 bool MadeChange = false;
Dan Gohmanf4141f12009-11-11 18:18:34 +00001257 MachineFunction &MF = *MBB->getParent();
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001258ReoptimizeBlock:
Evan Cheng3d2fce02009-09-04 07:47:40 +00001259
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001260 MachineFunction::iterator FallThrough = MBB->getIterator();
Chris Lattnerceb51d82006-10-24 01:12:32 +00001261 ++FallThrough;
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001262
David Majnemer16193552015-10-04 02:22:52 +00001263 // Make sure MBB and FallThrough belong to the same funclet.
1264 bool SameFunclet = true;
1265 if (!FuncletMembership.empty() && FallThrough != MF.end()) {
1266 auto MBBFunclet = FuncletMembership.find(MBB);
1267 assert(MBBFunclet != FuncletMembership.end());
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001268 auto FallThroughFunclet = FuncletMembership.find(&*FallThrough);
David Majnemer16193552015-10-04 02:22:52 +00001269 assert(FallThroughFunclet != FuncletMembership.end());
1270 SameFunclet = MBBFunclet->second == FallThroughFunclet->second;
1271 }
1272
Chris Lattner3e8e57c2006-10-13 20:43:10 +00001273 // If this block is empty, make everyone use its fall-through, not the block
Dale Johannesen1a401e62007-05-31 21:54:00 +00001274 // explicitly. Landing pads should not do this since the landing-pad table
Dan Gohman64997902009-10-30 02:13:27 +00001275 // points to this block. Blocks with their addresses taken shouldn't be
1276 // optimized away.
David Majnemer16193552015-10-04 02:22:52 +00001277 if (IsEmptyBlock(MBB) && !MBB->isEHPad() && !MBB->hasAddressTaken() &&
1278 SameFunclet) {
Chris Lattner4fe01c42006-10-21 05:08:28 +00001279 // Dead block? Leave for cleanup later.
Evan Cheng3d2fce02009-09-04 07:47:40 +00001280 if (MBB->pred_empty()) return MadeChange;
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001281
Dan Gohmanf4141f12009-11-11 18:18:34 +00001282 if (FallThrough == MF.end()) {
Chris Lattner56c9d252006-10-17 17:13:52 +00001283 // TODO: Simplify preds to not branch here if possible!
Reid Kleckner0e288232015-08-27 23:27:47 +00001284 } else if (FallThrough->isEHPad()) {
Pete Cooper4d8d2ec2015-04-30 18:58:23 +00001285 // Don't rewrite to a landing pad fallthough. That could lead to the case
1286 // where a BB jumps to more than one landing pad.
1287 // TODO: Is it ever worth rewriting predecessors which don't already
1288 // jump to a landing pad, and so can safely jump to the fallthrough?
Kyle Butt267164d2016-06-24 18:16:36 +00001289 } else if (MBB->isSuccessor(&*FallThrough)) {
Chris Lattner56c9d252006-10-17 17:13:52 +00001290 // Rewrite all predecessors of the old block to go to the fallthrough
1291 // instead.
Jim Laskey9df1a1d2007-02-22 16:39:03 +00001292 while (!MBB->pred_empty()) {
Chris Lattner3218e0e2006-10-14 00:21:48 +00001293 MachineBasicBlock *Pred = *(MBB->pred_end()-1);
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001294 Pred->ReplaceUsesOfBlockWith(MBB, &*FallThrough);
Chris Lattner3218e0e2006-10-14 00:21:48 +00001295 }
Chris Lattner56c9d252006-10-17 17:13:52 +00001296 // If MBB was the target of a jump table, update jump tables to go to the
1297 // fallthrough instead.
Chris Lattnerb6db2c62010-01-25 23:26:13 +00001298 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo())
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001299 MJTI->ReplaceMBBInJumpTables(MBB, &*FallThrough);
Chris Lattner3218e0e2006-10-14 00:21:48 +00001300 MadeChange = true;
Chris Lattner25e48dd2004-07-31 10:01:27 +00001301 }
Evan Cheng3d2fce02009-09-04 07:47:40 +00001302 return MadeChange;
Chris Lattner25e48dd2004-07-31 10:01:27 +00001303 }
1304
Chris Lattner3218e0e2006-10-14 00:21:48 +00001305 // Check to see if we can simplify the terminator of the block before this
1306 // one.
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +00001307 MachineBasicBlock &PrevBB = *std::prev(MachineFunction::iterator(MBB));
Chris Lattnerbca3e292006-10-17 18:16:40 +00001308
Craig Topperc0196b12014-04-14 00:51:57 +00001309 MachineBasicBlock *PriorTBB = nullptr, *PriorFBB = nullptr;
Owen Anderson4f6bf042008-08-14 22:49:33 +00001310 SmallVector<MachineOperand, 4> PriorCond;
Chris Lattner504eeda2006-10-29 21:05:41 +00001311 bool PriorUnAnalyzable =
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001312 TII->analyzeBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, true);
Chris Lattner4fe01c42006-10-21 05:08:28 +00001313 if (!PriorUnAnalyzable) {
1314 // If the CFG for the prior block has extra edges, remove them.
Evan Cheng2afd7022007-06-18 22:43:58 +00001315 MadeChange |= PrevBB.CorrectExtraCFGEdges(PriorTBB, PriorFBB,
1316 !PriorCond.empty());
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001317
Chris Lattner3218e0e2006-10-14 00:21:48 +00001318 // If the previous branch is conditional and both conditions go to the same
Chris Lattner3ca52182006-10-21 05:43:30 +00001319 // destination, remove the branch, replacing it with an unconditional one or
1320 // a fall-through.
Chris Lattner3218e0e2006-10-14 00:21:48 +00001321 if (PriorTBB && PriorTBB == PriorFBB) {
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001322 DebugLoc dl = getBranchDebugLoc(PrevBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001323 TII->removeBranch(PrevBB);
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001324 PriorCond.clear();
Chris Lattnerceb51d82006-10-24 01:12:32 +00001325 if (PriorTBB != MBB)
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001326 TII->insertBranch(PrevBB, PriorTBB, nullptr, PriorCond, dl);
Chris Lattner3218e0e2006-10-14 00:21:48 +00001327 MadeChange = true;
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001328 ++NumBranchOpts;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001329 goto ReoptimizeBlock;
Chris Lattner3218e0e2006-10-14 00:21:48 +00001330 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001331
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001332 // If the previous block unconditionally falls through to this block and
1333 // this block has no other predecessors, move the contents of this block
1334 // into the prior block. This doesn't usually happen when SimplifyCFG
Bob Wilson724d8a42009-11-17 17:40:31 +00001335 // has been used, but it can happen if tail merging splits a fall-through
1336 // predecessor of a block.
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001337 // This has to check PrevBB->succ_size() because EH edges are ignored by
1338 // AnalyzeBranch.
1339 if (PriorCond.empty() && !PriorTBB && MBB->pred_size() == 1 &&
1340 PrevBB.succ_size() == 1 &&
Reid Kleckner0e288232015-08-27 23:27:47 +00001341 !MBB->hasAddressTaken() && !MBB->isEHPad()) {
David Greened60abbf2009-12-24 00:34:21 +00001342 DEBUG(dbgs() << "\nMerging into block: " << PrevBB
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001343 << "From MBB: " << *MBB);
Devang Patelcdec1142011-05-26 21:49:28 +00001344 // Remove redundant DBG_VALUEs first.
Devang Patel42ddaa12011-05-26 21:47:59 +00001345 if (PrevBB.begin() != PrevBB.end()) {
1346 MachineBasicBlock::iterator PrevBBIter = PrevBB.end();
1347 --PrevBBIter;
1348 MachineBasicBlock::iterator MBBIter = MBB->begin();
Andrew Trick9e761992012-02-08 21:22:43 +00001349 // Check if DBG_VALUE at the end of PrevBB is identical to the
Devang Patelcdec1142011-05-26 21:49:28 +00001350 // DBG_VALUE at the beginning of MBB.
Devang Patel42ddaa12011-05-26 21:47:59 +00001351 while (PrevBBIter != PrevBB.begin() && MBBIter != MBB->end()
1352 && PrevBBIter->isDebugValue() && MBBIter->isDebugValue()) {
Duncan P. N. Exon Smithfd8cc232016-02-27 20:01:33 +00001353 if (!MBBIter->isIdenticalTo(*PrevBBIter))
Devang Patel42ddaa12011-05-26 21:47:59 +00001354 break;
Duncan P. N. Exon Smithebcce782016-02-27 20:27:44 +00001355 MachineInstr &DuplicateDbg = *MBBIter;
Devang Patel42ddaa12011-05-26 21:47:59 +00001356 ++MBBIter; -- PrevBBIter;
Duncan P. N. Exon Smithebcce782016-02-27 20:27:44 +00001357 DuplicateDbg.eraseFromParent();
Devang Patel42ddaa12011-05-26 21:47:59 +00001358 }
1359 }
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001360 PrevBB.splice(PrevBB.end(), MBB, MBB->begin(), MBB->end());
Chad Rosier5dfe6da2012-02-22 17:25:00 +00001361 PrevBB.removeSuccessor(PrevBB.succ_begin());
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001362 assert(PrevBB.succ_empty());
1363 PrevBB.transferSuccessors(MBB);
1364 MadeChange = true;
1365 return MadeChange;
1366 }
Bob Wilson699f5b92009-11-16 17:56:13 +00001367
Chris Lattner3218e0e2006-10-14 00:21:48 +00001368 // If the previous branch *only* branches to *this* block (conditional or
1369 // not) remove the branch.
Craig Topperc0196b12014-04-14 00:51:57 +00001370 if (PriorTBB == MBB && !PriorFBB) {
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001371 TII->removeBranch(PrevBB);
Chris Lattner3218e0e2006-10-14 00:21:48 +00001372 MadeChange = true;
Chris Lattner60c9d4d2006-10-21 00:47:49 +00001373 ++NumBranchOpts;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001374 goto ReoptimizeBlock;
Chris Lattner3218e0e2006-10-14 00:21:48 +00001375 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001376
Chris Lattner3ca52182006-10-21 05:43:30 +00001377 // If the prior block branches somewhere else on the condition and here if
1378 // the condition is false, remove the uncond second branch.
Chris Lattnerceb51d82006-10-24 01:12:32 +00001379 if (PriorFBB == MBB) {
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001380 DebugLoc dl = getBranchDebugLoc(PrevBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001381 TII->removeBranch(PrevBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001382 TII->insertBranch(PrevBB, PriorTBB, nullptr, PriorCond, dl);
Chris Lattner3ca52182006-10-21 05:43:30 +00001383 MadeChange = true;
1384 ++NumBranchOpts;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001385 goto ReoptimizeBlock;
Chris Lattner3ca52182006-10-21 05:43:30 +00001386 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001387
Chris Lattner28f17f42006-10-21 05:54:00 +00001388 // If the prior block branches here on true and somewhere else on false, and
1389 // if the branch condition is reversible, reverse the branch to create a
1390 // fall-through.
Chris Lattnerceb51d82006-10-24 01:12:32 +00001391 if (PriorTBB == MBB) {
Owen Anderson4f6bf042008-08-14 22:49:33 +00001392 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001393 if (!TII->reverseBranchCondition(NewPriorCond)) {
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001394 DebugLoc dl = getBranchDebugLoc(PrevBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001395 TII->removeBranch(PrevBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001396 TII->insertBranch(PrevBB, PriorFBB, nullptr, NewPriorCond, dl);
Chris Lattner28f17f42006-10-21 05:54:00 +00001397 MadeChange = true;
1398 ++NumBranchOpts;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001399 goto ReoptimizeBlock;
Chris Lattner28f17f42006-10-21 05:54:00 +00001400 }
1401 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001402
Dan Gohmanff97acd2009-10-22 00:03:58 +00001403 // If this block has no successors (e.g. it is a return block or ends with
1404 // a call to a no-return function like abort or __cxa_throw) and if the pred
1405 // falls through into this block, and if it would otherwise fall through
1406 // into the block after this, move this block to the end of the function.
Chris Lattner7acdc17f2006-11-18 21:30:35 +00001407 //
Chris Lattner47ce2612006-11-18 20:47:54 +00001408 // We consider it more likely that execution will stay in the function (e.g.
1409 // due to loops) than it is to exit it. This asserts in loops etc, moving
1410 // the assert condition out of the loop body.
Craig Topperc0196b12014-04-14 00:51:57 +00001411 if (MBB->succ_empty() && !PriorCond.empty() && !PriorFBB &&
Chris Lattner7acdc17f2006-11-18 21:30:35 +00001412 MachineFunction::iterator(PriorTBB) == FallThrough &&
Bob Wilson2d4ff122009-11-26 00:32:21 +00001413 !MBB->canFallThrough()) {
Chris Lattner56ec81f2006-11-18 21:56:39 +00001414 bool DoTransform = true;
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001415
Chris Lattner47ce2612006-11-18 20:47:54 +00001416 // We have to be careful that the succs of PredBB aren't both no-successor
1417 // blocks. If neither have successors and if PredBB is the second from
1418 // last block in the function, we'd just keep swapping the two blocks for
1419 // last. Only do the swap if one is clearly better to fall through than
1420 // the other.
Dan Gohmanf4141f12009-11-11 18:18:34 +00001421 if (FallThrough == --MF.end() &&
Chris Lattnera98c6792008-01-07 01:56:04 +00001422 !IsBetterFallthrough(PriorTBB, MBB))
Chris Lattner56ec81f2006-11-18 21:56:39 +00001423 DoTransform = false;
1424
Chris Lattner56ec81f2006-11-18 21:56:39 +00001425 if (DoTransform) {
Chris Lattner47ce2612006-11-18 20:47:54 +00001426 // Reverse the branch so we will fall through on the previous true cond.
Owen Anderson4f6bf042008-08-14 22:49:33 +00001427 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001428 if (!TII->reverseBranchCondition(NewPriorCond)) {
David Greened60abbf2009-12-24 00:34:21 +00001429 DEBUG(dbgs() << "\nMoving MBB: " << *MBB
Bill Wendlingc3f05e82009-08-22 20:03:00 +00001430 << "To make fallthrough to: " << *PriorTBB << "\n");
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001431
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001432 DebugLoc dl = getBranchDebugLoc(PrevBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001433 TII->removeBranch(PrevBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001434 TII->insertBranch(PrevBB, MBB, nullptr, NewPriorCond, dl);
Chris Lattner47ce2612006-11-18 20:47:54 +00001435
1436 // Move this block to the end of the function.
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001437 MBB->moveAfter(&MF.back());
Chris Lattner47ce2612006-11-18 20:47:54 +00001438 MadeChange = true;
1439 ++NumBranchOpts;
Evan Cheng3d2fce02009-09-04 07:47:40 +00001440 return MadeChange;
Chris Lattner47ce2612006-11-18 20:47:54 +00001441 }
1442 }
1443 }
Chris Lattner3218e0e2006-10-14 00:21:48 +00001444 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001445
Hans Wennborga4686012017-02-16 00:04:05 +00001446 if (!IsEmptyBlock(MBB) && MBB->pred_size() == 1 &&
1447 MF.getFunction()->optForSize()) {
1448 // Changing "Jcc foo; foo: jmp bar;" into "Jcc bar;" might change the branch
1449 // direction, thereby defeating careful block placement and regressing
1450 // performance. Therefore, only consider this for optsize functions.
1451 MachineInstr &TailCall = *MBB->getFirstNonDebugInstr();
1452 if (TII->isUnconditionalTailCall(TailCall)) {
1453 MachineBasicBlock *Pred = *MBB->pred_begin();
1454 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr;
1455 SmallVector<MachineOperand, 4> PredCond;
1456 bool PredAnalyzable =
1457 !TII->analyzeBranch(*Pred, PredTBB, PredFBB, PredCond, true);
1458
1459 if (PredAnalyzable && !PredCond.empty() && PredTBB == MBB) {
1460 // The predecessor has a conditional branch to this block which consists
1461 // of only a tail call. Try to fold the tail call into the conditional
1462 // branch.
1463 if (TII->canMakeTailCallConditional(PredCond, TailCall)) {
1464 // TODO: It would be nice if analyzeBranch() could provide a pointer
1465 // to the branch insturction so replaceBranchWithTailCall() doesn't
1466 // have to search for it.
1467 TII->replaceBranchWithTailCall(*Pred, PredCond, TailCall);
1468 ++NumTailCalls;
1469 Pred->removeSuccessor(MBB);
1470 MadeChange = true;
1471 return MadeChange;
1472 }
1473 }
1474 // If the predecessor is falling through to this block, we could reverse
1475 // the branch condition and fold the tail call into that. However, after
1476 // that we might have to re-arrange the CFG to fall through to the other
1477 // block and there is a high risk of regressing code size rather than
1478 // improving it.
1479 }
1480 }
1481
Chris Lattner4fe01c42006-10-21 05:08:28 +00001482 // Analyze the branch in the current block.
Craig Topperc0196b12014-04-14 00:51:57 +00001483 MachineBasicBlock *CurTBB = nullptr, *CurFBB = nullptr;
Owen Anderson4f6bf042008-08-14 22:49:33 +00001484 SmallVector<MachineOperand, 4> CurCond;
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001485 bool CurUnAnalyzable =
1486 TII->analyzeBranch(*MBB, CurTBB, CurFBB, CurCond, true);
Chris Lattner504eeda2006-10-29 21:05:41 +00001487 if (!CurUnAnalyzable) {
Chris Lattner4fe01c42006-10-21 05:08:28 +00001488 // If the CFG for the prior block has extra edges, remove them.
Evan Cheng2afd7022007-06-18 22:43:58 +00001489 MadeChange |= MBB->CorrectExtraCFGEdges(CurTBB, CurFBB, !CurCond.empty());
Chris Lattner3e8e57c2006-10-13 20:43:10 +00001490
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001491 // If this is a two-way branch, and the FBB branches to this block, reverse
Chris Lattnerbf3b57f2006-11-08 01:03:21 +00001492 // the condition so the single-basic-block loop is faster. Instead of:
1493 // Loop: xxx; jcc Out; jmp Loop
1494 // we want:
1495 // Loop: xxx; jncc Loop; jmp Out
1496 if (CurTBB && CurFBB && CurFBB == MBB && CurTBB != MBB) {
Owen Anderson4f6bf042008-08-14 22:49:33 +00001497 SmallVector<MachineOperand, 4> NewCond(CurCond);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001498 if (!TII->reverseBranchCondition(NewCond)) {
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001499 DebugLoc dl = getBranchDebugLoc(*MBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001500 TII->removeBranch(*MBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001501 TII->insertBranch(*MBB, CurFBB, CurTBB, NewCond, dl);
Chris Lattnerbf3b57f2006-11-08 01:03:21 +00001502 MadeChange = true;
1503 ++NumBranchOpts;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001504 goto ReoptimizeBlock;
Chris Lattnerbf3b57f2006-11-08 01:03:21 +00001505 }
1506 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001507
Chris Lattner4fe01c42006-10-21 05:08:28 +00001508 // If this branch is the only thing in its block, see if we can forward
1509 // other blocks across it.
Craig Topperc0196b12014-04-14 00:51:57 +00001510 if (CurTBB && CurCond.empty() && !CurFBB &&
Dale Johannesene9b361b2010-03-10 19:57:56 +00001511 IsBranchOnlyBlock(MBB) && CurTBB != MBB &&
Reid Klecknerb9204a52015-11-11 23:09:31 +00001512 !MBB->hasAddressTaken() && !MBB->isEHPad()) {
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001513 DebugLoc dl = getBranchDebugLoc(*MBB);
Chris Lattner4fe01c42006-10-21 05:08:28 +00001514 // This block may contain just an unconditional branch. Because there can
1515 // be 'non-branch terminators' in the block, try removing the branch and
1516 // then seeing if the block is empty.
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001517 TII->removeBranch(*MBB);
Dale Johannesen5ebe0c12010-03-10 05:45:47 +00001518 // If the only things remaining in the block are debug info, remove these
1519 // as well, so this will behave the same as an empty block in non-debug
1520 // mode.
Benjamin Kramer6b568962015-06-23 14:47:29 +00001521 if (IsEmptyBlock(MBB)) {
1522 // Make the block empty, losing the debug info (we could probably
1523 // improve this in some cases.)
1524 MBB->erase(MBB->begin(), MBB->end());
Dale Johannesen5ebe0c12010-03-10 05:45:47 +00001525 }
Chris Lattner4fe01c42006-10-21 05:08:28 +00001526 // If this block is just an unconditional branch to CurTBB, we can
1527 // usually completely eliminate the block. The only case we cannot
1528 // completely eliminate the block is when the block before this one
1529 // falls through into MBB and we can't understand the prior block's branch
1530 // condition.
Chris Lattneraf838382006-10-28 17:32:47 +00001531 if (MBB->empty()) {
Dan Gohman047a7672009-12-05 00:44:40 +00001532 bool PredHasNoFallThrough = !PrevBB.canFallThrough();
Chris Lattneraf838382006-10-28 17:32:47 +00001533 if (PredHasNoFallThrough || !PriorUnAnalyzable ||
1534 !PrevBB.isSuccessor(MBB)) {
1535 // If the prior block falls through into us, turn it into an
1536 // explicit branch to us to make updates simpler.
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001537 if (!PredHasNoFallThrough && PrevBB.isSuccessor(MBB) &&
Chris Lattneraf838382006-10-28 17:32:47 +00001538 PriorTBB != MBB && PriorFBB != MBB) {
Craig Topperc0196b12014-04-14 00:51:57 +00001539 if (!PriorTBB) {
1540 assert(PriorCond.empty() && !PriorFBB &&
Chris Lattnerc07657f2006-10-28 18:34:47 +00001541 "Bad branch analysis");
Chris Lattneraf838382006-10-28 17:32:47 +00001542 PriorTBB = MBB;
1543 } else {
Craig Topperc0196b12014-04-14 00:51:57 +00001544 assert(!PriorFBB && "Machine CFG out of date!");
Chris Lattneraf838382006-10-28 17:32:47 +00001545 PriorFBB = MBB;
1546 }
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001547 DebugLoc pdl = getBranchDebugLoc(PrevBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001548 TII->removeBranch(PrevBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001549 TII->insertBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, pdl);
Chris Lattner4fe01c42006-10-21 05:08:28 +00001550 }
Chris Lattner4fe01c42006-10-21 05:08:28 +00001551
Chris Lattneraf838382006-10-28 17:32:47 +00001552 // Iterate through all the predecessors, revectoring each in-turn.
David Greene451d1a62007-06-29 02:45:24 +00001553 size_t PI = 0;
Chris Lattneraf838382006-10-28 17:32:47 +00001554 bool DidChange = false;
1555 bool HasBranchToSelf = false;
David Greene451d1a62007-06-29 02:45:24 +00001556 while(PI != MBB->pred_size()) {
1557 MachineBasicBlock *PMBB = *(MBB->pred_begin() + PI);
1558 if (PMBB == MBB) {
Chris Lattneraf838382006-10-28 17:32:47 +00001559 // If this block has an uncond branch to itself, leave it.
1560 ++PI;
1561 HasBranchToSelf = true;
1562 } else {
1563 DidChange = true;
David Greene451d1a62007-06-29 02:45:24 +00001564 PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB);
Dale Johannesenb5714632009-05-11 21:54:13 +00001565 // If this change resulted in PMBB ending in a conditional
1566 // branch where both conditions go to the same destination,
1567 // change this to an unconditional branch (and fix the CFG).
Craig Topperc0196b12014-04-14 00:51:57 +00001568 MachineBasicBlock *NewCurTBB = nullptr, *NewCurFBB = nullptr;
Dale Johannesenb5714632009-05-11 21:54:13 +00001569 SmallVector<MachineOperand, 4> NewCurCond;
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001570 bool NewCurUnAnalyzable = TII->analyzeBranch(
1571 *PMBB, NewCurTBB, NewCurFBB, NewCurCond, true);
Dale Johannesenb5714632009-05-11 21:54:13 +00001572 if (!NewCurUnAnalyzable && NewCurTBB && NewCurTBB == NewCurFBB) {
Bill Wendling7c5dcb62012-03-07 08:49:42 +00001573 DebugLoc pdl = getBranchDebugLoc(*PMBB);
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00001574 TII->removeBranch(*PMBB);
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001575 NewCurCond.clear();
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001576 TII->insertBranch(*PMBB, NewCurTBB, nullptr, NewCurCond, pdl);
Dale Johannesenb5714632009-05-11 21:54:13 +00001577 MadeChange = true;
1578 ++NumBranchOpts;
Craig Topperc0196b12014-04-14 00:51:57 +00001579 PMBB->CorrectExtraCFGEdges(NewCurTBB, nullptr, false);
Dale Johannesenb5714632009-05-11 21:54:13 +00001580 }
Chris Lattneraf838382006-10-28 17:32:47 +00001581 }
Chris Lattner9f5a1292006-10-21 06:11:43 +00001582 }
Chris Lattner4fe01c42006-10-21 05:08:28 +00001583
Chris Lattneraf838382006-10-28 17:32:47 +00001584 // Change any jumptables to go to the new MBB.
Chris Lattnerb6db2c62010-01-25 23:26:13 +00001585 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo())
1586 MJTI->ReplaceMBBInJumpTables(MBB, CurTBB);
Chris Lattneraf838382006-10-28 17:32:47 +00001587 if (DidChange) {
1588 ++NumBranchOpts;
1589 MadeChange = true;
Evan Cheng3d2fce02009-09-04 07:47:40 +00001590 if (!HasBranchToSelf) return MadeChange;
Chris Lattneraf838382006-10-28 17:32:47 +00001591 }
Chris Lattner9f5a1292006-10-21 06:11:43 +00001592 }
Chris Lattner3e8e57c2006-10-13 20:43:10 +00001593 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001594
Chris Lattner4fe01c42006-10-21 05:08:28 +00001595 // Add the branch back if the block is more than just an uncond branch.
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001596 TII->insertBranch(*MBB, CurTBB, nullptr, CurCond, dl);
Chris Lattner25e48dd2004-07-31 10:01:27 +00001597 }
Chris Lattner504eeda2006-10-29 21:05:41 +00001598 }
1599
Bill Wendlinge8a525a2009-12-15 00:39:24 +00001600 // If the prior block doesn't fall through into this block, and if this
1601 // block doesn't fall through into some other block, see if we can find a
1602 // place to move this block where a fall-through will happen.
1603 if (!PrevBB.canFallThrough()) {
1604
Bob Wilsonbd22f192009-11-17 17:06:18 +00001605 // Now we know that there was no fall-through into this block, check to
1606 // see if it has a fall-through into its successor.
Bob Wilson2d4ff122009-11-26 00:32:21 +00001607 bool CurFallsThru = MBB->canFallThrough();
Bob Wilsonbd22f192009-11-17 17:06:18 +00001608
Reid Kleckner0e288232015-08-27 23:27:47 +00001609 if (!MBB->isEHPad()) {
Jim Laskey2dc52452007-02-21 22:42:20 +00001610 // Check all the predecessors of this block. If one of them has no fall
1611 // throughs, move this block right after it.
Craig Topper5db36df2015-09-16 03:52:35 +00001612 for (MachineBasicBlock *PredBB : MBB->predecessors()) {
Jim Laskey2dc52452007-02-21 22:42:20 +00001613 // Analyze the branch at the end of the pred.
Craig Topperc0196b12014-04-14 00:51:57 +00001614 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001615 SmallVector<MachineOperand, 4> PredCond;
Bill Wendlinge8a525a2009-12-15 00:39:24 +00001616 if (PredBB != MBB && !PredBB->canFallThrough() &&
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001617 !TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true) &&
1618 (!CurFallsThru || !CurTBB || !CurFBB) &&
1619 (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) {
Bill Wendlinge8a525a2009-12-15 00:39:24 +00001620 // If the current block doesn't fall through, just move it.
1621 // If the current block can fall through and does not end with a
1622 // conditional branch, we need to append an unconditional jump to
1623 // the (current) next block. To avoid a possible compile-time
1624 // infinite loop, move blocks only backward in this case.
1625 // Also, if there are already 2 branches here, we cannot add a third;
1626 // this means we have the case
1627 // Bcc next
1628 // B elsewhere
1629 // next:
Jim Laskey2dc52452007-02-21 22:42:20 +00001630 if (CurFallsThru) {
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001631 MachineBasicBlock *NextBB = &*std::next(MBB->getIterator());
Jim Laskey2dc52452007-02-21 22:42:20 +00001632 CurCond.clear();
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00001633 TII->insertBranch(*MBB, NextBB, nullptr, CurCond, DebugLoc());
Jim Laskey2dc52452007-02-21 22:42:20 +00001634 }
1635 MBB->moveAfter(PredBB);
1636 MadeChange = true;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001637 goto ReoptimizeBlock;
Chris Lattnerceb51d82006-10-24 01:12:32 +00001638 }
1639 }
Dale Johannesen12920dd2007-02-17 00:44:34 +00001640 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001641
Dale Johannesen12920dd2007-02-17 00:44:34 +00001642 if (!CurFallsThru) {
Chris Lattner504eeda2006-10-29 21:05:41 +00001643 // Check all successors to see if we can move this block before it.
Craig Topper5db36df2015-09-16 03:52:35 +00001644 for (MachineBasicBlock *SuccBB : MBB->successors()) {
Chris Lattner504eeda2006-10-29 21:05:41 +00001645 // Analyze the branch at the end of the block before the succ.
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001646 MachineFunction::iterator SuccPrev = --SuccBB->getIterator();
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001647
Chris Lattner4dbbace2007-04-30 23:35:00 +00001648 // If this block doesn't already fall-through to that successor, and if
1649 // the succ doesn't already have a block that can fall through into it,
1650 // and if the successor isn't an EH destination, we can arrange for the
1651 // fallthrough to happen.
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001652 if (SuccBB != MBB && &*SuccPrev != MBB &&
Bob Wilson2d4ff122009-11-26 00:32:21 +00001653 !SuccPrev->canFallThrough() && !CurUnAnalyzable &&
Reid Kleckner0e288232015-08-27 23:27:47 +00001654 !SuccBB->isEHPad()) {
Chris Lattner504eeda2006-10-29 21:05:41 +00001655 MBB->moveBefore(SuccBB);
1656 MadeChange = true;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001657 goto ReoptimizeBlock;
Chris Lattner504eeda2006-10-29 21:05:41 +00001658 }
1659 }
Dan Gohmanc86b5a12009-11-11 18:38:14 +00001660
Chris Lattner504eeda2006-10-29 21:05:41 +00001661 // Okay, there is no really great place to put this block. If, however,
1662 // the block before this one would be a fall-through if this block were
Andrew Kaylorff6a1ed2016-12-12 23:05:38 +00001663 // removed, move this block to the end of the function. There is no real
1664 // advantage in "falling through" to an EH block, so we don't want to
1665 // perform this transformation for that case.
1666 //
1667 // Also, Windows EH introduced the possibility of an arbitrary number of
1668 // successors to a given block. The analyzeBranch call does not consider
1669 // exception handling and so we can get in a state where a block
1670 // containing a call is followed by multiple EH blocks that would be
1671 // rotated infinitely at the end of the function if the transformation
1672 // below were performed for EH "FallThrough" blocks. Therefore, even if
1673 // that appears not to be happening anymore, we should assume that it is
1674 // possible and not remove the "!FallThrough()->isEHPad" condition below.
Craig Topperc0196b12014-04-14 00:51:57 +00001675 MachineBasicBlock *PrevTBB = nullptr, *PrevFBB = nullptr;
Dan Gohman64b5d0f2009-11-11 19:48:59 +00001676 SmallVector<MachineOperand, 4> PrevCond;
Dan Gohmanf4141f12009-11-11 18:18:34 +00001677 if (FallThrough != MF.end() &&
Andrew Kaylorff6a1ed2016-12-12 23:05:38 +00001678 !FallThrough->isEHPad() &&
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001679 !TII->analyzeBranch(PrevBB, PrevTBB, PrevFBB, PrevCond, true) &&
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001680 PrevBB.isSuccessor(&*FallThrough)) {
1681 MBB->moveAfter(&MF.back());
Chris Lattner504eeda2006-10-29 21:05:41 +00001682 MadeChange = true;
Evan Cheng3d2fce02009-09-04 07:47:40 +00001683 return MadeChange;
Chris Lattner504eeda2006-10-29 21:05:41 +00001684 }
Chris Lattnerceb51d82006-10-24 01:12:32 +00001685 }
Chris Lattner25e48dd2004-07-31 10:01:27 +00001686 }
Evan Cheng3d2fce02009-09-04 07:47:40 +00001687
1688 return MadeChange;
Chris Lattner25e48dd2004-07-31 10:01:27 +00001689}
Evan Chengcfdf3392011-05-12 00:56:58 +00001690
1691//===----------------------------------------------------------------------===//
1692// Hoist Common Code
1693//===----------------------------------------------------------------------===//
1694
Evan Chengcfdf3392011-05-12 00:56:58 +00001695bool BranchFolder::HoistCommonCode(MachineFunction &MF) {
1696 bool MadeChange = false;
1697 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ) {
Duncan P. N. Exon Smith980f8f22015-10-09 18:23:49 +00001698 MachineBasicBlock *MBB = &*I++;
Evan Chengcfdf3392011-05-12 00:56:58 +00001699 MadeChange |= HoistCommonCodeInSuccs(MBB);
1700 }
1701
1702 return MadeChange;
1703}
1704
1705/// findFalseBlock - BB has a fallthrough. Find its 'false' successor given
1706/// its 'true' successor.
1707static MachineBasicBlock *findFalseBlock(MachineBasicBlock *BB,
1708 MachineBasicBlock *TrueBB) {
Craig Topper5db36df2015-09-16 03:52:35 +00001709 for (MachineBasicBlock *SuccBB : BB->successors())
Evan Chengcfdf3392011-05-12 00:56:58 +00001710 if (SuccBB != TrueBB)
1711 return SuccBB;
Craig Topperc0196b12014-04-14 00:51:57 +00001712 return nullptr;
Evan Chengcfdf3392011-05-12 00:56:58 +00001713}
1714
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001715template <class Container>
1716static void addRegAndItsAliases(unsigned Reg, const TargetRegisterInfo *TRI,
1717 Container &Set) {
1718 if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
1719 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI)
1720 Set.insert(*AI);
1721 } else {
1722 Set.insert(Reg);
1723 }
1724}
1725
Evan Chengcfdf3392011-05-12 00:56:58 +00001726/// findHoistingInsertPosAndDeps - Find the location to move common instructions
Benjamin Kramerbde91762012-06-02 10:20:22 +00001727/// in successors to. The location is usually just before the terminator,
Evan Chengcfdf3392011-05-12 00:56:58 +00001728/// however if the terminator is a conditional branch and its previous
1729/// instruction is the flag setting instruction, the previous instruction is
1730/// the preferred location. This function also gathers uses and defs of the
1731/// instructions from the insertion point to the end of the block. The data is
1732/// used by HoistCommonCodeInSuccs to ensure safety.
1733static
1734MachineBasicBlock::iterator findHoistingInsertPosAndDeps(MachineBasicBlock *MBB,
1735 const TargetInstrInfo *TII,
1736 const TargetRegisterInfo *TRI,
1737 SmallSet<unsigned,4> &Uses,
1738 SmallSet<unsigned,4> &Defs) {
1739 MachineBasicBlock::iterator Loc = MBB->getFirstTerminator();
Duncan P. N. Exon Smith6307eb52016-02-23 02:46:52 +00001740 if (!TII->isUnpredicatedTerminator(*Loc))
Evan Chengcfdf3392011-05-12 00:56:58 +00001741 return MBB->end();
1742
Craig Topper5db36df2015-09-16 03:52:35 +00001743 for (const MachineOperand &MO : Loc->operands()) {
Evan Chengcfdf3392011-05-12 00:56:58 +00001744 if (!MO.isReg())
1745 continue;
1746 unsigned Reg = MO.getReg();
1747 if (!Reg)
1748 continue;
1749 if (MO.isUse()) {
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001750 addRegAndItsAliases(Reg, TRI, Uses);
Sasa Stankovic56c12e62014-06-05 13:42:48 +00001751 } else {
1752 if (!MO.isDead())
1753 // Don't try to hoist code in the rare case the terminator defines a
1754 // register that is later used.
1755 return MBB->end();
1756
1757 // If the terminator defines a register, make sure we don't hoist
1758 // the instruction whose def might be clobbered by the terminator.
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001759 addRegAndItsAliases(Reg, TRI, Defs);
Sasa Stankovic56c12e62014-06-05 13:42:48 +00001760 }
Evan Chengcfdf3392011-05-12 00:56:58 +00001761 }
1762
1763 if (Uses.empty())
1764 return Loc;
1765 if (Loc == MBB->begin())
1766 return MBB->end();
1767
1768 // The terminator is probably a conditional branch, try not to separate the
1769 // branch from condition setting instruction.
Florian Hahn3c8b8c92016-12-16 11:10:26 +00001770 MachineBasicBlock::iterator PI =
1771 skipDebugInstructionsBackward(std::prev(Loc), MBB->begin());
Evan Chengcfdf3392011-05-12 00:56:58 +00001772
1773 bool IsDef = false;
Craig Topper5db36df2015-09-16 03:52:35 +00001774 for (const MachineOperand &MO : PI->operands()) {
Jakob Stoklund Olesene9e30d02012-02-15 23:42:54 +00001775 // If PI has a regmask operand, it is probably a call. Separate away.
1776 if (MO.isRegMask())
1777 return Loc;
Evan Chengcfdf3392011-05-12 00:56:58 +00001778 if (!MO.isReg() || MO.isUse())
1779 continue;
1780 unsigned Reg = MO.getReg();
1781 if (!Reg)
1782 continue;
Craig Topper5db36df2015-09-16 03:52:35 +00001783 if (Uses.count(Reg)) {
Evan Chengcfdf3392011-05-12 00:56:58 +00001784 IsDef = true;
Craig Topper5db36df2015-09-16 03:52:35 +00001785 break;
1786 }
Evan Chengcfdf3392011-05-12 00:56:58 +00001787 }
1788 if (!IsDef)
1789 // The condition setting instruction is not just before the conditional
1790 // branch.
1791 return Loc;
1792
1793 // Be conservative, don't insert instruction above something that may have
1794 // side-effects. And since it's potentially bad to separate flag setting
1795 // instruction from the conditional branch, just abort the optimization
1796 // completely.
1797 // Also avoid moving code above predicated instruction since it's hard to
1798 // reason about register liveness with predicated instruction.
1799 bool DontMoveAcrossStore = true;
Duncan P. N. Exon Smith6307eb52016-02-23 02:46:52 +00001800 if (!PI->isSafeToMove(nullptr, DontMoveAcrossStore) || TII->isPredicated(*PI))
Evan Chengcfdf3392011-05-12 00:56:58 +00001801 return MBB->end();
1802
1803
1804 // Find out what registers are live. Note this routine is ignoring other live
1805 // registers which are only used by instructions in successor blocks.
Craig Topper5db36df2015-09-16 03:52:35 +00001806 for (const MachineOperand &MO : PI->operands()) {
Evan Chengcfdf3392011-05-12 00:56:58 +00001807 if (!MO.isReg())
1808 continue;
1809 unsigned Reg = MO.getReg();
1810 if (!Reg)
1811 continue;
1812 if (MO.isUse()) {
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001813 addRegAndItsAliases(Reg, TRI, Uses);
Evan Chengcfdf3392011-05-12 00:56:58 +00001814 } else {
Benjamin Kramerf29db272012-08-22 15:37:57 +00001815 if (Uses.erase(Reg)) {
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001816 if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
1817 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs)
1818 Uses.erase(*SubRegs); // Use sub-registers to be conservative
1819 }
Evan Chengcfdf3392011-05-12 00:56:58 +00001820 }
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001821 addRegAndItsAliases(Reg, TRI, Defs);
Evan Chengcfdf3392011-05-12 00:56:58 +00001822 }
1823 }
1824
1825 return PI;
1826}
1827
Evan Chengcfdf3392011-05-12 00:56:58 +00001828bool BranchFolder::HoistCommonCodeInSuccs(MachineBasicBlock *MBB) {
Craig Topperc0196b12014-04-14 00:51:57 +00001829 MachineBasicBlock *TBB = nullptr, *FBB = nullptr;
Evan Chengcfdf3392011-05-12 00:56:58 +00001830 SmallVector<MachineOperand, 4> Cond;
Jacques Pienaar71c30a12016-07-15 14:41:04 +00001831 if (TII->analyzeBranch(*MBB, TBB, FBB, Cond, true) || !TBB || Cond.empty())
Evan Chengcfdf3392011-05-12 00:56:58 +00001832 return false;
1833
1834 if (!FBB) FBB = findFalseBlock(MBB, TBB);
1835 if (!FBB)
1836 // Malformed bcc? True and false blocks are the same?
1837 return false;
1838
1839 // Restrict the optimization to cases where MBB is the only predecessor,
1840 // it is an obvious win.
1841 if (TBB->pred_size() > 1 || FBB->pred_size() > 1)
1842 return false;
1843
1844 // Find a suitable position to hoist the common instructions to. Also figure
1845 // out which registers are used or defined by instructions from the insertion
1846 // point to the end of the block.
1847 SmallSet<unsigned, 4> Uses, Defs;
1848 MachineBasicBlock::iterator Loc =
1849 findHoistingInsertPosAndDeps(MBB, TII, TRI, Uses, Defs);
1850 if (Loc == MBB->end())
1851 return false;
1852
1853 bool HasDups = false;
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001854 SmallVector<unsigned, 4> LocalDefs, LocalKills;
1855 SmallSet<unsigned, 4> ActiveDefsSet, AllDefsSet;
Evan Chengcfdf3392011-05-12 00:56:58 +00001856 MachineBasicBlock::iterator TIB = TBB->begin();
1857 MachineBasicBlock::iterator FIB = FBB->begin();
1858 MachineBasicBlock::iterator TIE = TBB->end();
1859 MachineBasicBlock::iterator FIE = FBB->end();
1860 while (TIB != TIE && FIB != FIE) {
1861 // Skip dbg_value instructions. These do not count.
Florian Hahn3c8b8c92016-12-16 11:10:26 +00001862 TIB = skipDebugInstructionsForward(TIB, TIE);
1863 FIB = skipDebugInstructionsForward(FIB, FIE);
1864 if (TIB == TIE || FIB == FIE)
1865 break;
1866
Duncan P. N. Exon Smithfd8cc232016-02-27 20:01:33 +00001867 if (!TIB->isIdenticalTo(*FIB, MachineInstr::CheckKillDead))
Evan Chengcfdf3392011-05-12 00:56:58 +00001868 break;
1869
Duncan P. N. Exon Smith6307eb52016-02-23 02:46:52 +00001870 if (TII->isPredicated(*TIB))
Evan Chengcfdf3392011-05-12 00:56:58 +00001871 // Hard to reason about register liveness with predicated instruction.
1872 break;
1873
1874 bool IsSafe = true;
Craig Topper5db36df2015-09-16 03:52:35 +00001875 for (MachineOperand &MO : TIB->operands()) {
Jakob Stoklund Olesene9e30d02012-02-15 23:42:54 +00001876 // Don't attempt to hoist instructions with register masks.
1877 if (MO.isRegMask()) {
1878 IsSafe = false;
1879 break;
1880 }
Evan Chengcfdf3392011-05-12 00:56:58 +00001881 if (!MO.isReg())
1882 continue;
1883 unsigned Reg = MO.getReg();
1884 if (!Reg)
1885 continue;
1886 if (MO.isDef()) {
1887 if (Uses.count(Reg)) {
1888 // Avoid clobbering a register that's used by the instruction at
1889 // the point of insertion.
1890 IsSafe = false;
1891 break;
1892 }
1893
1894 if (Defs.count(Reg) && !MO.isDead()) {
1895 // Don't hoist the instruction if the def would be clobber by the
1896 // instruction at the point insertion. FIXME: This is overly
1897 // conservative. It should be possible to hoist the instructions
1898 // in BB2 in the following example:
1899 // BB1:
1900 // r1, eflag = op1 r2, r3
1901 // brcc eflag
1902 //
1903 // BB2:
1904 // r1 = op2, ...
1905 // = op3, r1<kill>
1906 IsSafe = false;
1907 break;
1908 }
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001909 } else if (!ActiveDefsSet.count(Reg)) {
Evan Chengcfdf3392011-05-12 00:56:58 +00001910 if (Defs.count(Reg)) {
1911 // Use is defined by the instruction at the point of insertion.
1912 IsSafe = false;
1913 break;
1914 }
Evan Cheng5c03a6b2012-01-12 20:31:24 +00001915
1916 if (MO.isKill() && Uses.count(Reg))
1917 // Kills a register that's read by the instruction at the point of
1918 // insertion. Remove the kill marker.
1919 MO.setIsKill(false);
Evan Chengcfdf3392011-05-12 00:56:58 +00001920 }
1921 }
1922 if (!IsSafe)
1923 break;
1924
1925 bool DontMoveAcrossStore = true;
Matthias Braun07066cc2015-05-19 21:22:20 +00001926 if (!TIB->isSafeToMove(nullptr, DontMoveAcrossStore))
Evan Chengcfdf3392011-05-12 00:56:58 +00001927 break;
1928
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001929 // Remove kills from ActiveDefsSet, these registers had short live ranges.
Craig Topper5db36df2015-09-16 03:52:35 +00001930 for (const MachineOperand &MO : TIB->operands()) {
Jakob Stoklund Olesend633abe2011-08-05 18:47:07 +00001931 if (!MO.isReg() || !MO.isUse() || !MO.isKill())
1932 continue;
1933 unsigned Reg = MO.getReg();
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001934 if (!Reg)
Jakob Stoklund Olesend633abe2011-08-05 18:47:07 +00001935 continue;
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001936 if (!AllDefsSet.count(Reg)) {
1937 LocalKills.push_back(Reg);
1938 continue;
1939 }
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001940 if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
1941 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI)
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001942 ActiveDefsSet.erase(*AI);
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001943 } else {
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001944 ActiveDefsSet.erase(Reg);
Jingyue Wu3a04dc62015-07-29 18:59:09 +00001945 }
Jakob Stoklund Olesend633abe2011-08-05 18:47:07 +00001946 }
1947
Evan Cheng43054e62011-05-12 20:30:01 +00001948 // Track local defs so we can update liveins.
Craig Topper5db36df2015-09-16 03:52:35 +00001949 for (const MachineOperand &MO : TIB->operands()) {
Jakob Stoklund Olesend633abe2011-08-05 18:47:07 +00001950 if (!MO.isReg() || !MO.isDef() || MO.isDead())
Evan Cheng43054e62011-05-12 20:30:01 +00001951 continue;
1952 unsigned Reg = MO.getReg();
Dan Gohman0cfb5f82016-05-10 04:24:02 +00001953 if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg))
Evan Cheng43054e62011-05-12 20:30:01 +00001954 continue;
Jakob Stoklund Olesend633abe2011-08-05 18:47:07 +00001955 LocalDefs.push_back(Reg);
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001956 addRegAndItsAliases(Reg, TRI, ActiveDefsSet);
1957 addRegAndItsAliases(Reg, TRI, AllDefsSet);
Evan Cheng43054e62011-05-12 20:30:01 +00001958 }
1959
Chad Rosier5dfe6da2012-02-22 17:25:00 +00001960 HasDups = true;
Evan Chengcfdf3392011-05-12 00:56:58 +00001961 ++TIB;
1962 ++FIB;
1963 }
1964
1965 if (!HasDups)
1966 return false;
1967
1968 MBB->splice(Loc, TBB, TBB->begin(), TIB);
1969 FBB->erase(FBB->begin(), FIB);
Evan Cheng43054e62011-05-12 20:30:01 +00001970
1971 // Update livein's.
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001972 bool ChangedLiveIns = false;
Evan Cheng43054e62011-05-12 20:30:01 +00001973 for (unsigned i = 0, e = LocalDefs.size(); i != e; ++i) {
1974 unsigned Def = LocalDefs[i];
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001975 if (ActiveDefsSet.count(Def)) {
Evan Cheng43054e62011-05-12 20:30:01 +00001976 TBB->addLiveIn(Def);
1977 FBB->addLiveIn(Def);
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001978 ChangedLiveIns = true;
Evan Cheng43054e62011-05-12 20:30:01 +00001979 }
1980 }
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001981 for (unsigned K : LocalKills) {
1982 TBB->removeLiveIn(K);
1983 FBB->removeLiveIn(K);
1984 ChangedLiveIns = true;
1985 }
Evan Cheng43054e62011-05-12 20:30:01 +00001986
Krzysztof Parzyszek31d4b3b2017-05-05 12:20:07 +00001987 if (ChangedLiveIns) {
Ahmed Bougachab6782192016-09-12 16:05:31 +00001988 TBB->sortUniqueLiveIns();
1989 FBB->sortUniqueLiveIns();
1990 }
1991
Evan Chengcfdf3392011-05-12 00:56:58 +00001992 ++NumHoist;
1993 return true;
1994}