blob: 3f855844aed9b727a7ad3be3fe3e8615842c5a63 [file] [log] [blame]
Sam McCall9aad25f2017-12-05 07:20:26 +00001//===-- CodeCompleteTests.cpp -----------------------------------*- C++ -*-===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
Eric Liu6f648df2017-12-19 16:50:37 +00009
Sam McCall328cbdb2017-12-20 16:06:05 +000010#include "Annotations.h"
Sam McCall9aad25f2017-12-05 07:20:26 +000011#include "ClangdServer.h"
Sam McCall328cbdb2017-12-20 16:06:05 +000012#include "CodeComplete.h"
Sam McCall9aad25f2017-12-05 07:20:26 +000013#include "Compiler.h"
Ilya Biryukov5a85b8e2017-12-13 12:53:16 +000014#include "Matchers.h"
Sam McCall9aad25f2017-12-05 07:20:26 +000015#include "Protocol.h"
Sam McCalle746a2b2018-07-02 11:13:16 +000016#include "Quality.h"
Sam McCallb536a2a2017-12-19 12:23:48 +000017#include "SourceCode.h"
Ilya Biryukovcd5eb002018-02-12 11:37:28 +000018#include "SyncAPI.h"
Sam McCall9aad25f2017-12-05 07:20:26 +000019#include "TestFS.h"
Eric Liu6f648df2017-12-19 16:50:37 +000020#include "index/MemIndex.h"
Eric Liu5d2a8072018-07-23 10:56:37 +000021#include "clang/Sema/CodeCompleteConsumer.h"
Ilya Biryukovbe0eb8f2018-05-24 14:49:23 +000022#include "llvm/Support/Error.h"
Ilya Biryukov981a35d2018-05-28 12:11:37 +000023#include "llvm/Testing/Support/Error.h"
Sam McCallf6ae3232017-12-05 20:11:29 +000024#include "gmock/gmock.h"
Sam McCall9aad25f2017-12-05 07:20:26 +000025#include "gtest/gtest.h"
26
27namespace clang {
28namespace clangd {
Sam McCallf6ae3232017-12-05 20:11:29 +000029
Sam McCall9aad25f2017-12-05 07:20:26 +000030namespace {
31using namespace llvm;
Sam McCallf6ae3232017-12-05 20:11:29 +000032using ::testing::AllOf;
33using ::testing::Contains;
Ilya Biryukov5a5e1ca2017-12-29 14:59:22 +000034using ::testing::Each;
Sam McCallf6ae3232017-12-05 20:11:29 +000035using ::testing::ElementsAre;
Ilya Biryukov71028b82018-03-12 15:28:22 +000036using ::testing::Field;
Sam McCallc18c2802018-06-15 11:06:29 +000037using ::testing::HasSubstr;
Marc-Andre Laperle945b5a32018-06-05 14:01:40 +000038using ::testing::IsEmpty;
Sam McCallf6ae3232017-12-05 20:11:29 +000039using ::testing::Not;
Sam McCall3d139c52018-01-12 18:30:08 +000040using ::testing::UnorderedElementsAre;
Sam McCall9aad25f2017-12-05 07:20:26 +000041
42class IgnoreDiagnostics : public DiagnosticsConsumer {
Ilya Biryukov71028b82018-03-12 15:28:22 +000043 void onDiagnosticsReady(PathRef File,
Sam McCalla7bb0cc2018-03-12 23:22:35 +000044 std::vector<Diag> Diagnostics) override {}
Sam McCall9aad25f2017-12-05 07:20:26 +000045};
46
Sam McCallf6ae3232017-12-05 20:11:29 +000047// GMock helpers for matching completion items.
Sam McCalle746a2b2018-07-02 11:13:16 +000048MATCHER_P(Named, Name, "") { return arg.Name == Name; }
49MATCHER_P(Scope, S, "") { return arg.Scope == S; }
50MATCHER_P(Qualifier, Q, "") { return arg.RequiredQualifier == Q; }
Eric Liu8f3678d2018-06-15 13:34:18 +000051MATCHER_P(Labeled, Label, "") {
Sam McCalle746a2b2018-07-02 11:13:16 +000052 return arg.RequiredQualifier + arg.Name + arg.Signature == Label;
Eric Liu8f3678d2018-06-15 13:34:18 +000053}
54MATCHER_P(SigHelpLabeled, Label, "") { return arg.label == Label; }
Sam McCalle746a2b2018-07-02 11:13:16 +000055MATCHER_P(Kind, K, "") { return arg.Kind == K; }
56MATCHER_P(Doc, D, "") { return arg.Documentation == D; }
57MATCHER_P(ReturnType, D, "") { return arg.ReturnType == D; }
Eric Liu63f419a2018-05-15 15:29:32 +000058MATCHER_P(InsertInclude, IncludeHeader, "") {
Sam McCalle746a2b2018-07-02 11:13:16 +000059 return arg.Header == IncludeHeader && bool(arg.HeaderInsertion);
Eric Liu63f419a2018-05-15 15:29:32 +000060}
Sam McCalle746a2b2018-07-02 11:13:16 +000061MATCHER(InsertInclude, "") { return bool(arg.HeaderInsertion); }
62MATCHER_P(SnippetSuffix, Text, "") { return arg.SnippetSuffix == Text; }
Sam McCall2161ec72018-07-05 06:20:41 +000063MATCHER_P(Origin, OriginSet, "") { return arg.Origin == OriginSet; }
Eric Liu63f419a2018-05-15 15:29:32 +000064
Sam McCallf6ae3232017-12-05 20:11:29 +000065// Shorthand for Contains(Named(Name)).
Sam McCalle746a2b2018-07-02 11:13:16 +000066Matcher<const std::vector<CodeCompletion> &> Has(std::string Name) {
Sam McCallf6ae3232017-12-05 20:11:29 +000067 return Contains(Named(std::move(Name)));
68}
Sam McCalle746a2b2018-07-02 11:13:16 +000069Matcher<const std::vector<CodeCompletion> &> Has(std::string Name,
Sam McCall44fdcec22017-12-08 15:00:59 +000070 CompletionItemKind K) {
71 return Contains(AllOf(Named(std::move(Name)), Kind(K)));
Sam McCallf6ae3232017-12-05 20:11:29 +000072}
Sam McCalle746a2b2018-07-02 11:13:16 +000073MATCHER(IsDocumented, "") { return !arg.Documentation.empty(); }
Sam McCall9aad25f2017-12-05 07:20:26 +000074
Sam McCalla15c2d62018-01-18 09:27:56 +000075std::unique_ptr<SymbolIndex> memIndex(std::vector<Symbol> Symbols) {
76 SymbolSlab::Builder Slab;
77 for (const auto &Sym : Symbols)
78 Slab.insert(Sym);
79 return MemIndex::build(std::move(Slab).build());
80}
81
Kadir Cetinkaya2f84d912018-08-08 08:59:29 +000082CodeCompleteResult completions(ClangdServer &Server, StringRef TestCode,
83 Position point,
84 std::vector<Symbol> IndexSymbols = {},
85 clangd::CodeCompleteOptions Opts = {}) {
86 std::unique_ptr<SymbolIndex> OverrideIndex;
87 if (!IndexSymbols.empty()) {
88 assert(!Opts.Index && "both Index and IndexSymbols given!");
89 OverrideIndex = memIndex(std::move(IndexSymbols));
90 Opts.Index = OverrideIndex.get();
91 }
92
93 auto File = testPath("foo.cpp");
94 runAddDocument(Server, File, TestCode);
95 auto CompletionList = cantFail(runCodeComplete(Server, File, point, Opts));
96 return CompletionList;
97}
98
Sam McCalle746a2b2018-07-02 11:13:16 +000099CodeCompleteResult completions(ClangdServer &Server, StringRef Text,
100 std::vector<Symbol> IndexSymbols = {},
101 clangd::CodeCompleteOptions Opts = {}) {
Sam McCalla15c2d62018-01-18 09:27:56 +0000102 std::unique_ptr<SymbolIndex> OverrideIndex;
103 if (!IndexSymbols.empty()) {
104 assert(!Opts.Index && "both Index and IndexSymbols given!");
105 OverrideIndex = memIndex(std::move(IndexSymbols));
106 Opts.Index = OverrideIndex.get();
107 }
108
Sam McCallc1568062018-02-16 09:41:43 +0000109 auto File = testPath("foo.cpp");
Sam McCall328cbdb2017-12-20 16:06:05 +0000110 Annotations Test(Text);
Sam McCall7363a2f2018-03-05 17:28:54 +0000111 runAddDocument(Server, File, Test.code());
Sam McCalla7bb0cc2018-03-12 23:22:35 +0000112 auto CompletionList =
113 cantFail(runCodeComplete(Server, File, Test.point(), Opts));
Ilya Biryukov5a5e1ca2017-12-29 14:59:22 +0000114 return CompletionList;
Sam McCall9aad25f2017-12-05 07:20:26 +0000115}
116
Eric Liu63f419a2018-05-15 15:29:32 +0000117// Builds a server and runs code completion.
118// If IndexSymbols is non-empty, an index will be built and passed to opts.
Sam McCalle746a2b2018-07-02 11:13:16 +0000119CodeCompleteResult completions(StringRef Text,
120 std::vector<Symbol> IndexSymbols = {},
121 clangd::CodeCompleteOptions Opts = {}) {
Eric Liu63f419a2018-05-15 15:29:32 +0000122 MockFSProvider FS;
123 MockCompilationDatabase CDB;
124 IgnoreDiagnostics DiagConsumer;
125 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
126 return completions(Server, Text, std::move(IndexSymbols), std::move(Opts));
127}
128
Sam McCall545a20d2018-01-19 14:34:02 +0000129std::string replace(StringRef Haystack, StringRef Needle, StringRef Repl) {
130 std::string Result;
131 raw_string_ostream OS(Result);
132 std::pair<StringRef, StringRef> Split;
133 for (Split = Haystack.split(Needle); !Split.second.empty();
134 Split = Split.first.split(Needle))
135 OS << Split.first << Repl;
136 Result += Split.first;
137 OS.flush();
138 return Result;
139}
140
Sam McCalla15c2d62018-01-18 09:27:56 +0000141// Helpers to produce fake index symbols for memIndex() or completions().
Sam McCall545a20d2018-01-19 14:34:02 +0000142// USRFormat is a regex replacement string for the unqualified part of the USR.
143Symbol sym(StringRef QName, index::SymbolKind Kind, StringRef USRFormat) {
Sam McCalla15c2d62018-01-18 09:27:56 +0000144 Symbol Sym;
Sam McCall545a20d2018-01-19 14:34:02 +0000145 std::string USR = "c:"; // We synthesize a few simple cases of USRs by hand!
Sam McCalla15c2d62018-01-18 09:27:56 +0000146 size_t Pos = QName.rfind("::");
147 if (Pos == llvm::StringRef::npos) {
148 Sym.Name = QName;
149 Sym.Scope = "";
150 } else {
151 Sym.Name = QName.substr(Pos + 2);
Sam McCall8b2faee2018-01-19 22:18:21 +0000152 Sym.Scope = QName.substr(0, Pos + 2);
153 USR += "@N@" + replace(QName.substr(0, Pos), "::", "@N@"); // ns:: -> @N@ns
Sam McCalla15c2d62018-01-18 09:27:56 +0000154 }
Sam McCall545a20d2018-01-19 14:34:02 +0000155 USR += Regex("^.*$").sub(USRFormat, Sym.Name); // e.g. func -> @F@func#
156 Sym.ID = SymbolID(USR);
Sam McCalla15c2d62018-01-18 09:27:56 +0000157 Sym.SymInfo.Kind = Kind;
Marc-Andre Laperle945b5a32018-06-05 14:01:40 +0000158 Sym.IsIndexedForCodeCompletion = true;
Sam McCall2161ec72018-07-05 06:20:41 +0000159 Sym.Origin = SymbolOrigin::Static;
Sam McCalla15c2d62018-01-18 09:27:56 +0000160 return Sym;
161}
Sam McCall545a20d2018-01-19 14:34:02 +0000162Symbol func(StringRef Name) { // Assumes the function has no args.
163 return sym(Name, index::SymbolKind::Function, "@F@\\0#"); // no args
164}
165Symbol cls(StringRef Name) {
Eric Liu9b3cba72018-05-30 09:03:39 +0000166 return sym(Name, index::SymbolKind::Class, "@S@\\0");
Sam McCall545a20d2018-01-19 14:34:02 +0000167}
168Symbol var(StringRef Name) {
169 return sym(Name, index::SymbolKind::Variable, "@\\0");
170}
Sam McCalldc8abc42018-05-03 14:53:02 +0000171Symbol ns(StringRef Name) {
172 return sym(Name, index::SymbolKind::Namespace, "@N@\\0");
173}
174Symbol withReferences(int N, Symbol S) {
175 S.References = N;
176 return S;
177}
Sam McCalla15c2d62018-01-18 09:27:56 +0000178
Sam McCallf6ae3232017-12-05 20:11:29 +0000179TEST(CompletionTest, Limit) {
180 clangd::CodeCompleteOptions Opts;
181 Opts.Limit = 2;
182 auto Results = completions(R"cpp(
Sam McCall9aad25f2017-12-05 07:20:26 +0000183struct ClassWithMembers {
184 int AAA();
185 int BBB();
186 int CCC();
187}
Sam McCallf6ae3232017-12-05 20:11:29 +0000188int main() { ClassWithMembers().^ }
Sam McCall9aad25f2017-12-05 07:20:26 +0000189 )cpp",
Sam McCalla15c2d62018-01-18 09:27:56 +0000190 /*IndexSymbols=*/{}, Opts);
Sam McCall9aad25f2017-12-05 07:20:26 +0000191
Sam McCalle746a2b2018-07-02 11:13:16 +0000192 EXPECT_TRUE(Results.HasMore);
193 EXPECT_THAT(Results.Completions, ElementsAre(Named("AAA"), Named("BBB")));
Sam McCall9aad25f2017-12-05 07:20:26 +0000194}
195
Sam McCallf6ae3232017-12-05 20:11:29 +0000196TEST(CompletionTest, Filter) {
197 std::string Body = R"cpp(
Sam McCall8b2dcc12018-06-14 13:50:30 +0000198 #define MotorCar
199 int Car;
Sam McCall9aad25f2017-12-05 07:20:26 +0000200 struct S {
201 int FooBar;
202 int FooBaz;
203 int Qux;
204 };
205 )cpp";
Sam McCall8b2dcc12018-06-14 13:50:30 +0000206
207 // Only items matching the fuzzy query are returned.
Sam McCalle746a2b2018-07-02 11:13:16 +0000208 EXPECT_THAT(completions(Body + "int main() { S().Foba^ }").Completions,
Sam McCall8b2dcc12018-06-14 13:50:30 +0000209 AllOf(Has("FooBar"), Has("FooBaz"), Not(Has("Qux"))));
Sam McCall9aad25f2017-12-05 07:20:26 +0000210
Sam McCall8b2dcc12018-06-14 13:50:30 +0000211 // Macros require prefix match.
Sam McCalle746a2b2018-07-02 11:13:16 +0000212 EXPECT_THAT(completions(Body + "int main() { C^ }").Completions,
Sam McCall8b2dcc12018-06-14 13:50:30 +0000213 AllOf(Has("Car"), Not(Has("MotorCar"))));
Sam McCall9aad25f2017-12-05 07:20:26 +0000214}
215
Sam McCallf6ae3232017-12-05 20:11:29 +0000216void TestAfterDotCompletion(clangd::CodeCompleteOptions Opts) {
Sam McCall44fdcec22017-12-08 15:00:59 +0000217 auto Results = completions(
218 R"cpp(
219 #define MACRO X
Sam McCall9aad25f2017-12-05 07:20:26 +0000220
Sam McCall44fdcec22017-12-08 15:00:59 +0000221 int global_var;
Sam McCall9aad25f2017-12-05 07:20:26 +0000222
Sam McCall44fdcec22017-12-08 15:00:59 +0000223 int global_func();
Sam McCall9aad25f2017-12-05 07:20:26 +0000224
Sam McCall44fdcec22017-12-08 15:00:59 +0000225 struct GlobalClass {};
Sam McCall9aad25f2017-12-05 07:20:26 +0000226
Sam McCall44fdcec22017-12-08 15:00:59 +0000227 struct ClassWithMembers {
228 /// Doc for method.
229 int method();
Sam McCall9aad25f2017-12-05 07:20:26 +0000230
Sam McCall44fdcec22017-12-08 15:00:59 +0000231 int field;
232 private:
233 int private_field;
234 };
Sam McCall9aad25f2017-12-05 07:20:26 +0000235
Sam McCall44fdcec22017-12-08 15:00:59 +0000236 int test() {
237 struct LocalClass {};
Sam McCall9aad25f2017-12-05 07:20:26 +0000238
Sam McCall44fdcec22017-12-08 15:00:59 +0000239 /// Doc for local_var.
240 int local_var;
Sam McCall9aad25f2017-12-05 07:20:26 +0000241
Sam McCall44fdcec22017-12-08 15:00:59 +0000242 ClassWithMembers().^
243 }
244 )cpp",
Sam McCall545a20d2018-01-19 14:34:02 +0000245 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts);
Sam McCall9aad25f2017-12-05 07:20:26 +0000246
Sam McCallf6ae3232017-12-05 20:11:29 +0000247 // Class members. The only items that must be present in after-dot
248 // completion.
Sam McCalle746a2b2018-07-02 11:13:16 +0000249 EXPECT_THAT(Results.Completions,
250 AllOf(Has("method"), Has("field"), Not(Has("ClassWithMembers")),
Sam McCall4caa8512018-06-07 12:49:17 +0000251 Not(Has("operator=")), Not(Has("~ClassWithMembers"))));
Sam McCalle746a2b2018-07-02 11:13:16 +0000252 EXPECT_IFF(Opts.IncludeIneligibleResults, Results.Completions,
Sam McCall44fdcec22017-12-08 15:00:59 +0000253 Has("private_field"));
Sam McCallf6ae3232017-12-05 20:11:29 +0000254 // Global items.
Sam McCall545a20d2018-01-19 14:34:02 +0000255 EXPECT_THAT(
Sam McCalle746a2b2018-07-02 11:13:16 +0000256 Results.Completions,
Sam McCall545a20d2018-01-19 14:34:02 +0000257 Not(AnyOf(Has("global_var"), Has("index_var"), Has("global_func"),
258 Has("global_func()"), Has("index_func"), Has("GlobalClass"),
259 Has("IndexClass"), Has("MACRO"), Has("LocalClass"))));
Sam McCallf6ae3232017-12-05 20:11:29 +0000260 // There should be no code patterns (aka snippets) in after-dot
261 // completion. At least there aren't any we're aware of.
Sam McCalle746a2b2018-07-02 11:13:16 +0000262 EXPECT_THAT(Results.Completions,
263 Not(Contains(Kind(CompletionItemKind::Snippet))));
Sam McCallf6ae3232017-12-05 20:11:29 +0000264 // Check documentation.
Sam McCalle746a2b2018-07-02 11:13:16 +0000265 EXPECT_IFF(Opts.IncludeComments, Results.Completions,
266 Contains(IsDocumented()));
Sam McCallf6ae3232017-12-05 20:11:29 +0000267}
Sam McCall9aad25f2017-12-05 07:20:26 +0000268
Sam McCallf6ae3232017-12-05 20:11:29 +0000269void TestGlobalScopeCompletion(clangd::CodeCompleteOptions Opts) {
Sam McCall44fdcec22017-12-08 15:00:59 +0000270 auto Results = completions(
271 R"cpp(
272 #define MACRO X
Sam McCall9aad25f2017-12-05 07:20:26 +0000273
Sam McCall44fdcec22017-12-08 15:00:59 +0000274 int global_var;
275 int global_func();
Sam McCall9aad25f2017-12-05 07:20:26 +0000276
Sam McCall44fdcec22017-12-08 15:00:59 +0000277 struct GlobalClass {};
Sam McCall9aad25f2017-12-05 07:20:26 +0000278
Sam McCall44fdcec22017-12-08 15:00:59 +0000279 struct ClassWithMembers {
280 /// Doc for method.
281 int method();
282 };
Sam McCall9aad25f2017-12-05 07:20:26 +0000283
Sam McCall44fdcec22017-12-08 15:00:59 +0000284 int test() {
285 struct LocalClass {};
Sam McCall9aad25f2017-12-05 07:20:26 +0000286
Sam McCall44fdcec22017-12-08 15:00:59 +0000287 /// Doc for local_var.
288 int local_var;
Sam McCall9aad25f2017-12-05 07:20:26 +0000289
Sam McCall44fdcec22017-12-08 15:00:59 +0000290 ^
291 }
292 )cpp",
Sam McCall545a20d2018-01-19 14:34:02 +0000293 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts);
Sam McCallf6ae3232017-12-05 20:11:29 +0000294
295 // Class members. Should never be present in global completions.
Sam McCalle746a2b2018-07-02 11:13:16 +0000296 EXPECT_THAT(Results.Completions,
Sam McCallf6ae3232017-12-05 20:11:29 +0000297 Not(AnyOf(Has("method"), Has("method()"), Has("field"))));
298 // Global items.
Sam McCalle746a2b2018-07-02 11:13:16 +0000299 EXPECT_THAT(Results.Completions,
300 AllOf(Has("global_var"), Has("index_var"), Has("global_func"),
Sam McCall545a20d2018-01-19 14:34:02 +0000301 Has("index_func" /* our fake symbol doesn't include () */),
302 Has("GlobalClass"), Has("IndexClass")));
Sam McCallf6ae3232017-12-05 20:11:29 +0000303 // A macro.
Sam McCalle746a2b2018-07-02 11:13:16 +0000304 EXPECT_IFF(Opts.IncludeMacros, Results.Completions, Has("MACRO"));
Sam McCallf6ae3232017-12-05 20:11:29 +0000305 // Local items. Must be present always.
Sam McCalle746a2b2018-07-02 11:13:16 +0000306 EXPECT_THAT(Results.Completions,
Ilya Biryukov9b5ffc22017-12-12 12:56:46 +0000307 AllOf(Has("local_var"), Has("LocalClass"),
308 Contains(Kind(CompletionItemKind::Snippet))));
Sam McCallf6ae3232017-12-05 20:11:29 +0000309 // Check documentation.
Sam McCalle746a2b2018-07-02 11:13:16 +0000310 EXPECT_IFF(Opts.IncludeComments, Results.Completions,
311 Contains(IsDocumented()));
Sam McCallf6ae3232017-12-05 20:11:29 +0000312}
313
314TEST(CompletionTest, CompletionOptions) {
Sam McCall2c3849a2018-01-16 12:21:24 +0000315 auto Test = [&](const clangd::CodeCompleteOptions &Opts) {
316 TestAfterDotCompletion(Opts);
317 TestGlobalScopeCompletion(Opts);
318 };
319 // We used to test every combination of options, but that got too slow (2^N).
320 auto Flags = {
Ilya Biryukov71028b82018-03-12 15:28:22 +0000321 &clangd::CodeCompleteOptions::IncludeMacros,
Ilya Biryukov43714502018-05-16 12:32:44 +0000322 &clangd::CodeCompleteOptions::IncludeComments,
Ilya Biryukov71028b82018-03-12 15:28:22 +0000323 &clangd::CodeCompleteOptions::IncludeCodePatterns,
324 &clangd::CodeCompleteOptions::IncludeIneligibleResults,
Sam McCall2c3849a2018-01-16 12:21:24 +0000325 };
326 // Test default options.
327 Test({});
328 // Test with one flag flipped.
329 for (auto &F : Flags) {
330 clangd::CodeCompleteOptions O;
331 O.*F ^= true;
332 Test(O);
Sam McCall9aad25f2017-12-05 07:20:26 +0000333 }
334}
335
Sam McCall44fdcec22017-12-08 15:00:59 +0000336TEST(CompletionTest, Priorities) {
337 auto Internal = completions(R"cpp(
338 class Foo {
339 public: void pub();
340 protected: void prot();
341 private: void priv();
342 };
343 void Foo::pub() { this->^ }
344 )cpp");
Sam McCalle746a2b2018-07-02 11:13:16 +0000345 EXPECT_THAT(Internal.Completions,
Sam McCall44fdcec22017-12-08 15:00:59 +0000346 HasSubsequence(Named("priv"), Named("prot"), Named("pub")));
347
348 auto External = completions(R"cpp(
349 class Foo {
350 public: void pub();
351 protected: void prot();
352 private: void priv();
353 };
354 void test() {
355 Foo F;
356 F.^
357 }
358 )cpp");
Sam McCalle746a2b2018-07-02 11:13:16 +0000359 EXPECT_THAT(External.Completions,
Sam McCall44fdcec22017-12-08 15:00:59 +0000360 AllOf(Has("pub"), Not(Has("prot")), Not(Has("priv"))));
361}
362
363TEST(CompletionTest, Qualifiers) {
364 auto Results = completions(R"cpp(
365 class Foo {
366 public: int foo() const;
367 int bar() const;
368 };
369 class Bar : public Foo {
370 int foo() const;
371 };
372 void test() { Bar().^ }
373 )cpp");
Sam McCalle746a2b2018-07-02 11:13:16 +0000374 EXPECT_THAT(Results.Completions,
375 HasSubsequence(AllOf(Qualifier(""), Named("bar")),
376 AllOf(Qualifier("Foo::"), Named("foo"))));
377 EXPECT_THAT(Results.Completions,
378 Not(Contains(AllOf(Qualifier(""), Named("foo"))))); // private
Sam McCall44fdcec22017-12-08 15:00:59 +0000379}
380
Sam McCall4caa8512018-06-07 12:49:17 +0000381TEST(CompletionTest, InjectedTypename) {
382 // These are suppressed when accessed as a member...
Sam McCalle746a2b2018-07-02 11:13:16 +0000383 EXPECT_THAT(completions("struct X{}; void foo(){ X().^ }").Completions,
Sam McCall4caa8512018-06-07 12:49:17 +0000384 Not(Has("X")));
Sam McCalle746a2b2018-07-02 11:13:16 +0000385 EXPECT_THAT(completions("struct X{ void foo(){ this->^ } };").Completions,
Sam McCall4caa8512018-06-07 12:49:17 +0000386 Not(Has("X")));
387 // ...but accessible in other, more useful cases.
Sam McCalle746a2b2018-07-02 11:13:16 +0000388 EXPECT_THAT(completions("struct X{ void foo(){ ^ } };").Completions,
389 Has("X"));
390 EXPECT_THAT(
391 completions("struct Y{}; struct X:Y{ void foo(){ ^ } };").Completions,
392 Has("Y"));
Sam McCall4caa8512018-06-07 12:49:17 +0000393 EXPECT_THAT(
394 completions(
395 "template<class> struct Y{}; struct X:Y<int>{ void foo(){ ^ } };")
Sam McCalle746a2b2018-07-02 11:13:16 +0000396 .Completions,
Sam McCall4caa8512018-06-07 12:49:17 +0000397 Has("Y"));
398 // This case is marginal (`using X::X` is useful), we allow it for now.
Sam McCalle746a2b2018-07-02 11:13:16 +0000399 EXPECT_THAT(completions("struct X{}; void foo(){ X::^ }").Completions,
400 Has("X"));
Sam McCall4caa8512018-06-07 12:49:17 +0000401}
402
Sam McCall44fdcec22017-12-08 15:00:59 +0000403TEST(CompletionTest, Snippets) {
404 clangd::CodeCompleteOptions Opts;
Sam McCall44fdcec22017-12-08 15:00:59 +0000405 auto Results = completions(
406 R"cpp(
407 struct fake {
408 int a;
409 int f(int i, const float f) const;
410 };
411 int main() {
412 fake f;
413 f.^
414 }
415 )cpp",
Sam McCalla15c2d62018-01-18 09:27:56 +0000416 /*IndexSymbols=*/{}, Opts);
Sam McCalle746a2b2018-07-02 11:13:16 +0000417 EXPECT_THAT(
418 Results.Completions,
419 HasSubsequence(Named("a"),
420 SnippetSuffix("(${1:int i}, ${2:const float f})")));
Sam McCall44fdcec22017-12-08 15:00:59 +0000421}
422
423TEST(CompletionTest, Kinds) {
Sam McCall545a20d2018-01-19 14:34:02 +0000424 auto Results = completions(
425 R"cpp(
426 #define MACRO X
427 int variable;
428 struct Struct {};
429 int function();
430 int X = ^
431 )cpp",
432 {func("indexFunction"), var("indexVariable"), cls("indexClass")});
Sam McCalle746a2b2018-07-02 11:13:16 +0000433 EXPECT_THAT(Results.Completions,
Sam McCall545a20d2018-01-19 14:34:02 +0000434 AllOf(Has("function", CompletionItemKind::Function),
435 Has("variable", CompletionItemKind::Variable),
436 Has("int", CompletionItemKind::Keyword),
437 Has("Struct", CompletionItemKind::Class),
438 Has("MACRO", CompletionItemKind::Text),
439 Has("indexFunction", CompletionItemKind::Function),
440 Has("indexVariable", CompletionItemKind::Variable),
441 Has("indexClass", CompletionItemKind::Class)));
Sam McCall44fdcec22017-12-08 15:00:59 +0000442
Sam McCall44fdcec22017-12-08 15:00:59 +0000443 Results = completions("nam^");
Sam McCalle746a2b2018-07-02 11:13:16 +0000444 EXPECT_THAT(Results.Completions,
445 Has("namespace", CompletionItemKind::Snippet));
Sam McCall44fdcec22017-12-08 15:00:59 +0000446}
447
Sam McCall84652cc2018-01-12 16:16:09 +0000448TEST(CompletionTest, NoDuplicates) {
Sam McCall545a20d2018-01-19 14:34:02 +0000449 auto Results = completions(
450 R"cpp(
451 class Adapter {
Sam McCall545a20d2018-01-19 14:34:02 +0000452 };
Sam McCall84652cc2018-01-12 16:16:09 +0000453
Eric Liu9b3cba72018-05-30 09:03:39 +0000454 void f() {
Sam McCall545a20d2018-01-19 14:34:02 +0000455 Adapter^
456 }
457 )cpp",
458 {cls("Adapter")});
Sam McCall84652cc2018-01-12 16:16:09 +0000459
460 // Make sure there are no duplicate entries of 'Adapter'.
Sam McCalle746a2b2018-07-02 11:13:16 +0000461 EXPECT_THAT(Results.Completions, ElementsAre(Named("Adapter")));
Sam McCall84652cc2018-01-12 16:16:09 +0000462}
463
Sam McCall545a20d2018-01-19 14:34:02 +0000464TEST(CompletionTest, ScopedNoIndex) {
465 auto Results = completions(
466 R"cpp(
Sam McCall8b2dcc12018-06-14 13:50:30 +0000467 namespace fake { int BigBang, Babble, Box; };
468 int main() { fake::ba^ }
Sam McCall545a20d2018-01-19 14:34:02 +0000469 ")cpp");
Sam McCall8b2dcc12018-06-14 13:50:30 +0000470 // Babble is a better match than BigBang. Box doesn't match at all.
Sam McCalle746a2b2018-07-02 11:13:16 +0000471 EXPECT_THAT(Results.Completions,
472 ElementsAre(Named("Babble"), Named("BigBang")));
Sam McCall84652cc2018-01-12 16:16:09 +0000473}
474
Sam McCall545a20d2018-01-19 14:34:02 +0000475TEST(CompletionTest, Scoped) {
Sam McCalla15c2d62018-01-18 09:27:56 +0000476 auto Results = completions(
477 R"cpp(
Sam McCall8b2dcc12018-06-14 13:50:30 +0000478 namespace fake { int Babble, Box; };
479 int main() { fake::ba^ }
Sam McCall545a20d2018-01-19 14:34:02 +0000480 ")cpp",
481 {var("fake::BigBang")});
Sam McCalle746a2b2018-07-02 11:13:16 +0000482 EXPECT_THAT(Results.Completions,
483 ElementsAre(Named("Babble"), Named("BigBang")));
Sam McCalla15c2d62018-01-18 09:27:56 +0000484}
485
Sam McCall545a20d2018-01-19 14:34:02 +0000486TEST(CompletionTest, ScopedWithFilter) {
Sam McCalla15c2d62018-01-18 09:27:56 +0000487 auto Results = completions(
488 R"cpp(
489 void f() { ns::x^ }
490 )cpp",
491 {cls("ns::XYZ"), func("ns::foo")});
Sam McCalle746a2b2018-07-02 11:13:16 +0000492 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Named("XYZ")));
Sam McCalla15c2d62018-01-18 09:27:56 +0000493}
494
Sam McCalldc8abc42018-05-03 14:53:02 +0000495TEST(CompletionTest, ReferencesAffectRanking) {
Eric Liu84bd5db2018-07-25 11:26:35 +0000496 auto Results = completions("int main() { abs^ }", {ns("absl"), func("absb")});
497 EXPECT_THAT(Results.Completions, HasSubsequence(Named("absb"), Named("absl")));
Sam McCalldc8abc42018-05-03 14:53:02 +0000498 Results = completions("int main() { abs^ }",
Eric Liu84bd5db2018-07-25 11:26:35 +0000499 {withReferences(10000, ns("absl")), func("absb")});
500 EXPECT_THAT(Results.Completions,
501 HasSubsequence(Named("absl"), Named("absb")));
Sam McCalldc8abc42018-05-03 14:53:02 +0000502}
503
Sam McCall545a20d2018-01-19 14:34:02 +0000504TEST(CompletionTest, GlobalQualified) {
Sam McCalla15c2d62018-01-18 09:27:56 +0000505 auto Results = completions(
506 R"cpp(
507 void f() { ::^ }
508 )cpp",
509 {cls("XYZ")});
Sam McCalle746a2b2018-07-02 11:13:16 +0000510 EXPECT_THAT(Results.Completions,
511 AllOf(Has("XYZ", CompletionItemKind::Class),
512 Has("f", CompletionItemKind::Function)));
Sam McCalla15c2d62018-01-18 09:27:56 +0000513}
514
Sam McCall545a20d2018-01-19 14:34:02 +0000515TEST(CompletionTest, FullyQualified) {
Sam McCalla15c2d62018-01-18 09:27:56 +0000516 auto Results = completions(
517 R"cpp(
Sam McCall545a20d2018-01-19 14:34:02 +0000518 namespace ns { void bar(); }
Sam McCalla15c2d62018-01-18 09:27:56 +0000519 void f() { ::ns::^ }
520 )cpp",
521 {cls("ns::XYZ")});
Sam McCalle746a2b2018-07-02 11:13:16 +0000522 EXPECT_THAT(Results.Completions,
523 AllOf(Has("XYZ", CompletionItemKind::Class),
524 Has("bar", CompletionItemKind::Function)));
Sam McCall545a20d2018-01-19 14:34:02 +0000525}
526
527TEST(CompletionTest, SemaIndexMerge) {
528 auto Results = completions(
529 R"cpp(
530 namespace ns { int local; void both(); }
531 void f() { ::ns::^ }
532 )cpp",
533 {func("ns::both"), cls("ns::Index")});
534 // We get results from both index and sema, with no duplicates.
Sam McCall2161ec72018-07-05 06:20:41 +0000535 EXPECT_THAT(Results.Completions,
536 UnorderedElementsAre(
537 AllOf(Named("local"), Origin(SymbolOrigin::AST)),
538 AllOf(Named("Index"), Origin(SymbolOrigin::Static)),
539 AllOf(Named("both"),
540 Origin(SymbolOrigin::AST | SymbolOrigin::Static))));
Sam McCalla15c2d62018-01-18 09:27:56 +0000541}
542
Haojian Wu48b48652018-01-25 09:20:09 +0000543TEST(CompletionTest, SemaIndexMergeWithLimit) {
544 clangd::CodeCompleteOptions Opts;
545 Opts.Limit = 1;
546 auto Results = completions(
547 R"cpp(
548 namespace ns { int local; void both(); }
549 void f() { ::ns::^ }
550 )cpp",
551 {func("ns::both"), cls("ns::Index")}, Opts);
Sam McCalle746a2b2018-07-02 11:13:16 +0000552 EXPECT_EQ(Results.Completions.size(), Opts.Limit);
553 EXPECT_TRUE(Results.HasMore);
Haojian Wu48b48652018-01-25 09:20:09 +0000554}
555
Eric Liu63f419a2018-05-15 15:29:32 +0000556TEST(CompletionTest, IncludeInsertionPreprocessorIntegrationTests) {
557 MockFSProvider FS;
558 MockCompilationDatabase CDB;
559 std::string Subdir = testPath("sub");
560 std::string SearchDirArg = (llvm::Twine("-I") + Subdir).str();
561 CDB.ExtraClangFlags = {SearchDirArg.c_str()};
562 std::string BarHeader = testPath("sub/bar.h");
563 FS.Files[BarHeader] = "";
564
565 IgnoreDiagnostics DiagConsumer;
566 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
567 Symbol::Details Scratch;
568 auto BarURI = URI::createFile(BarHeader).toString();
569 Symbol Sym = cls("ns::X");
570 Sym.CanonicalDeclaration.FileURI = BarURI;
571 Scratch.IncludeHeader = BarURI;
572 Sym.Detail = &Scratch;
573 // Shoten include path based on search dirctory and insert.
574 auto Results = completions(Server,
575 R"cpp(
576 int main() { ns::^ }
577 )cpp",
578 {Sym});
Sam McCalle746a2b2018-07-02 11:13:16 +0000579 EXPECT_THAT(Results.Completions,
580 ElementsAre(AllOf(Named("X"), InsertInclude("\"bar.h\""))));
Eric Liu63f419a2018-05-15 15:29:32 +0000581 // Duplicate based on inclusions in preamble.
582 Results = completions(Server,
583 R"cpp(
584 #include "sub/bar.h" // not shortest, so should only match resolved.
585 int main() { ns::^ }
586 )cpp",
587 {Sym});
Sam McCalle746a2b2018-07-02 11:13:16 +0000588 EXPECT_THAT(Results.Completions, ElementsAre(AllOf(Named("X"), Labeled("X"),
589 Not(InsertInclude()))));
Eric Liu63f419a2018-05-15 15:29:32 +0000590}
591
Eric Liu9b3cba72018-05-30 09:03:39 +0000592TEST(CompletionTest, NoIncludeInsertionWhenDeclFoundInFile) {
593 MockFSProvider FS;
594 MockCompilationDatabase CDB;
595
596 IgnoreDiagnostics DiagConsumer;
597 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
598 Symbol::Details Scratch;
599 Symbol SymX = cls("ns::X");
600 Symbol SymY = cls("ns::Y");
601 std::string BarHeader = testPath("bar.h");
602 auto BarURI = URI::createFile(BarHeader).toString();
603 SymX.CanonicalDeclaration.FileURI = BarURI;
604 SymY.CanonicalDeclaration.FileURI = BarURI;
605 Scratch.IncludeHeader = "<bar>";
606 SymX.Detail = &Scratch;
607 SymY.Detail = &Scratch;
608 // Shoten include path based on search dirctory and insert.
609 auto Results = completions(Server,
610 R"cpp(
611 namespace ns {
612 class X;
613 class Y {}
614 }
615 int main() { ns::^ }
616 )cpp",
617 {SymX, SymY});
Sam McCalle746a2b2018-07-02 11:13:16 +0000618 EXPECT_THAT(Results.Completions,
619 ElementsAre(AllOf(Named("X"), Not(InsertInclude())),
620 AllOf(Named("Y"), Not(InsertInclude()))));
Eric Liu9b3cba72018-05-30 09:03:39 +0000621}
622
Sam McCalla15c2d62018-01-18 09:27:56 +0000623TEST(CompletionTest, IndexSuppressesPreambleCompletions) {
624 MockFSProvider FS;
625 MockCompilationDatabase CDB;
626 IgnoreDiagnostics DiagConsumer;
Sam McCall7363a2f2018-03-05 17:28:54 +0000627 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
Sam McCalla15c2d62018-01-18 09:27:56 +0000628
Sam McCallc1568062018-02-16 09:41:43 +0000629 FS.Files[testPath("bar.h")] =
Sam McCalld5ea3e32018-01-24 17:53:32 +0000630 R"cpp(namespace ns { struct preamble { int member; }; })cpp";
Sam McCallc1568062018-02-16 09:41:43 +0000631 auto File = testPath("foo.cpp");
Sam McCalla15c2d62018-01-18 09:27:56 +0000632 Annotations Test(R"cpp(
633 #include "bar.h"
634 namespace ns { int local; }
Sam McCalld5ea3e32018-01-24 17:53:32 +0000635 void f() { ns::^; }
636 void f() { ns::preamble().$2^; }
Sam McCalla15c2d62018-01-18 09:27:56 +0000637 )cpp");
Sam McCall7363a2f2018-03-05 17:28:54 +0000638 runAddDocument(Server, File, Test.code());
Sam McCalla15c2d62018-01-18 09:27:56 +0000639 clangd::CodeCompleteOptions Opts = {};
640
Sam McCalla15c2d62018-01-18 09:27:56 +0000641 auto I = memIndex({var("ns::index")});
642 Opts.Index = I.get();
Sam McCalla7bb0cc2018-03-12 23:22:35 +0000643 auto WithIndex = cantFail(runCodeComplete(Server, File, Test.point(), Opts));
Sam McCalle746a2b2018-07-02 11:13:16 +0000644 EXPECT_THAT(WithIndex.Completions,
Sam McCalla15c2d62018-01-18 09:27:56 +0000645 UnorderedElementsAre(Named("local"), Named("index")));
Sam McCalld5ea3e32018-01-24 17:53:32 +0000646 auto ClassFromPreamble =
Sam McCalla7bb0cc2018-03-12 23:22:35 +0000647 cantFail(runCodeComplete(Server, File, Test.point("2"), Opts));
Sam McCalle746a2b2018-07-02 11:13:16 +0000648 EXPECT_THAT(ClassFromPreamble.Completions, Contains(Named("member")));
Sam McCall0bb24cd2018-02-13 08:59:23 +0000649
650 Opts.Index = nullptr;
Sam McCalla7bb0cc2018-03-12 23:22:35 +0000651 auto WithoutIndex =
652 cantFail(runCodeComplete(Server, File, Test.point(), Opts));
Sam McCalle746a2b2018-07-02 11:13:16 +0000653 EXPECT_THAT(WithoutIndex.Completions,
Sam McCall0bb24cd2018-02-13 08:59:23 +0000654 UnorderedElementsAre(Named("local"), Named("preamble")));
Sam McCalla15c2d62018-01-18 09:27:56 +0000655}
656
657TEST(CompletionTest, DynamicIndexMultiFile) {
658 MockFSProvider FS;
659 MockCompilationDatabase CDB;
660 IgnoreDiagnostics DiagConsumer;
Sam McCall7363a2f2018-03-05 17:28:54 +0000661 auto Opts = ClangdServer::optsForTest();
662 Opts.BuildDynamicSymbolIndex = true;
663 ClangdServer Server(CDB, FS, DiagConsumer, Opts);
Sam McCalla15c2d62018-01-18 09:27:56 +0000664
Eric Liu709bde82018-02-19 18:48:44 +0000665 FS.Files[testPath("foo.h")] = R"cpp(
Sam McCalla15c2d62018-01-18 09:27:56 +0000666 namespace ns { class XYZ {}; void foo(int x) {} }
Eric Liu709bde82018-02-19 18:48:44 +0000667 )cpp";
Sam McCall7363a2f2018-03-05 17:28:54 +0000668 runAddDocument(Server, testPath("foo.cpp"), R"cpp(
Eric Liu709bde82018-02-19 18:48:44 +0000669 #include "foo.h"
Sam McCall0bb24cd2018-02-13 08:59:23 +0000670 )cpp");
Sam McCalla15c2d62018-01-18 09:27:56 +0000671
Sam McCallc1568062018-02-16 09:41:43 +0000672 auto File = testPath("bar.cpp");
Sam McCalla15c2d62018-01-18 09:27:56 +0000673 Annotations Test(R"cpp(
674 namespace ns {
675 class XXX {};
676 /// Doooc
677 void fooooo() {}
678 }
679 void f() { ns::^ }
680 )cpp");
Sam McCall7363a2f2018-03-05 17:28:54 +0000681 runAddDocument(Server, File, Test.code());
Sam McCalla15c2d62018-01-18 09:27:56 +0000682
Sam McCalla7bb0cc2018-03-12 23:22:35 +0000683 auto Results = cantFail(runCodeComplete(Server, File, Test.point(), {}));
Sam McCalla15c2d62018-01-18 09:27:56 +0000684 // "XYZ" and "foo" are not included in the file being completed but are still
685 // visible through the index.
Sam McCalle746a2b2018-07-02 11:13:16 +0000686 EXPECT_THAT(Results.Completions, Has("XYZ", CompletionItemKind::Class));
687 EXPECT_THAT(Results.Completions, Has("foo", CompletionItemKind::Function));
688 EXPECT_THAT(Results.Completions, Has("XXX", CompletionItemKind::Class));
689 EXPECT_THAT(Results.Completions,
690 Contains((Named("fooooo"), Kind(CompletionItemKind::Function),
691 Doc("Doooc"), ReturnType("void"))));
Sam McCalla15c2d62018-01-18 09:27:56 +0000692}
693
Ilya Biryukovc22d3442018-05-16 12:32:49 +0000694TEST(CompletionTest, Documentation) {
695 auto Results = completions(
696 R"cpp(
697 // Non-doxygen comment.
698 int foo();
699 /// Doxygen comment.
700 /// \param int a
701 int bar(int a);
702 /* Multi-line
703 block comment
704 */
705 int baz();
706
707 int x = ^
708 )cpp");
Sam McCalle746a2b2018-07-02 11:13:16 +0000709 EXPECT_THAT(Results.Completions,
Ilya Biryukovc22d3442018-05-16 12:32:49 +0000710 Contains(AllOf(Named("foo"), Doc("Non-doxygen comment."))));
711 EXPECT_THAT(
Sam McCalle746a2b2018-07-02 11:13:16 +0000712 Results.Completions,
Ilya Biryukovc22d3442018-05-16 12:32:49 +0000713 Contains(AllOf(Named("bar"), Doc("Doxygen comment.\n\\param int a"))));
Sam McCalle746a2b2018-07-02 11:13:16 +0000714 EXPECT_THAT(Results.Completions,
Ilya Biryukovc22d3442018-05-16 12:32:49 +0000715 Contains(AllOf(Named("baz"), Doc("Multi-line\nblock comment"))));
716}
717
Marc-Andre Laperle945b5a32018-06-05 14:01:40 +0000718TEST(CompletionTest, GlobalCompletionFiltering) {
719
720 Symbol Class = cls("XYZ");
721 Class.IsIndexedForCodeCompletion = false;
722 Symbol Func = func("XYZ::foooo");
723 Func.IsIndexedForCodeCompletion = false;
724
725 auto Results = completions(R"(// void f() {
726 XYZ::foooo^
727 })",
728 {Class, Func});
Sam McCalle746a2b2018-07-02 11:13:16 +0000729 EXPECT_THAT(Results.Completions, IsEmpty());
Marc-Andre Laperle945b5a32018-06-05 14:01:40 +0000730}
731
Haojian Wu58d208d2018-01-25 09:44:06 +0000732TEST(CodeCompleteTest, DisableTypoCorrection) {
733 auto Results = completions(R"cpp(
734 namespace clang { int v; }
735 void f() { clangd::^
736 )cpp");
Sam McCalle746a2b2018-07-02 11:13:16 +0000737 EXPECT_TRUE(Results.Completions.empty());
Haojian Wu58d208d2018-01-25 09:44:06 +0000738}
739
Ilya Biryukov53d6d932018-03-06 16:45:21 +0000740TEST(CodeCompleteTest, NoColonColonAtTheEnd) {
741 auto Results = completions(R"cpp(
742 namespace clang { }
743 void f() {
744 clan^
745 }
746 )cpp");
747
Sam McCalle746a2b2018-07-02 11:13:16 +0000748 EXPECT_THAT(Results.Completions, Contains(Labeled("clang")));
749 EXPECT_THAT(Results.Completions, Not(Contains(Labeled("clang::"))));
Ilya Biryukov53d6d932018-03-06 16:45:21 +0000750}
751
Ilya Biryukov94da7bd2018-03-16 15:23:44 +0000752TEST(CompletionTest, BacktrackCrashes) {
753 // Sema calls code completion callbacks twice in these cases.
754 auto Results = completions(R"cpp(
755 namespace ns {
756 struct FooBarBaz {};
757 } // namespace ns
758
759 int foo(ns::FooBar^
760 )cpp");
761
Sam McCalle746a2b2018-07-02 11:13:16 +0000762 EXPECT_THAT(Results.Completions, ElementsAre(Labeled("FooBarBaz")));
Ilya Biryukov94da7bd2018-03-16 15:23:44 +0000763
764 // Check we don't crash in that case too.
765 completions(R"cpp(
766 struct FooBarBaz {};
767 void test() {
768 if (FooBarBaz * x^) {}
769 }
770)cpp");
771}
772
Eric Liu42abe412018-05-24 11:20:19 +0000773TEST(CompletionTest, CompleteInMacroWithStringification) {
774 auto Results = completions(R"cpp(
775void f(const char *, int x);
776#define F(x) f(#x, x)
777
778namespace ns {
779int X;
780int Y;
781} // namespace ns
782
783int f(int input_num) {
784 F(ns::^)
785}
786)cpp");
787
Sam McCalle746a2b2018-07-02 11:13:16 +0000788 EXPECT_THAT(Results.Completions,
Eric Liu42abe412018-05-24 11:20:19 +0000789 UnorderedElementsAre(Named("X"), Named("Y")));
790}
791
792TEST(CompletionTest, CompleteInMacroAndNamespaceWithStringification) {
793 auto Results = completions(R"cpp(
794void f(const char *, int x);
795#define F(x) f(#x, x)
796
797namespace ns {
798int X;
799
800int f(int input_num) {
801 F(^)
802}
803} // namespace ns
804)cpp");
805
Sam McCalle746a2b2018-07-02 11:13:16 +0000806 EXPECT_THAT(Results.Completions, Contains(Named("X")));
Eric Liu42abe412018-05-24 11:20:19 +0000807}
808
Eric Liu485074f2018-07-11 13:15:31 +0000809TEST(CompletionTest, IgnoreCompleteInExcludedPPBranchWithRecoveryContext) {
Ilya Biryukov94da7bd2018-03-16 15:23:44 +0000810 auto Results = completions(R"cpp(
811 int bar(int param_in_bar) {
812 }
813
814 int foo(int param_in_foo) {
815#if 0
Eric Liu485074f2018-07-11 13:15:31 +0000816 // In recorvery mode, "param_in_foo" will also be suggested among many other
817 // unrelated symbols; however, this is really a special case where this works.
818 // If the #if block is outside of the function, "param_in_foo" is still
819 // suggested, but "bar" and "foo" are missing. So the recovery mode doesn't
820 // really provide useful results in excluded branches.
Ilya Biryukov94da7bd2018-03-16 15:23:44 +0000821 par^
822#endif
823 }
824)cpp");
825
Eric Liu485074f2018-07-11 13:15:31 +0000826 EXPECT_TRUE(Results.Completions.empty());
Ilya Biryukov94da7bd2018-03-16 15:23:44 +0000827}
828
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +0000829SignatureHelp signatures(StringRef Text,
830 std::vector<Symbol> IndexSymbols = {}) {
831 std::unique_ptr<SymbolIndex> Index;
832 if (!IndexSymbols.empty())
833 Index = memIndex(IndexSymbols);
834
Sam McCall800d4372017-12-19 10:29:27 +0000835 MockFSProvider FS;
836 MockCompilationDatabase CDB;
837 IgnoreDiagnostics DiagConsumer;
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +0000838 ClangdServer::Options Opts = ClangdServer::optsForTest();
839 Opts.StaticIndex = Index.get();
840
841 ClangdServer Server(CDB, FS, DiagConsumer, Opts);
Sam McCallc1568062018-02-16 09:41:43 +0000842 auto File = testPath("foo.cpp");
Sam McCall328cbdb2017-12-20 16:06:05 +0000843 Annotations Test(Text);
Sam McCall7363a2f2018-03-05 17:28:54 +0000844 runAddDocument(Server, File, Test.code());
Sam McCalla7bb0cc2018-03-12 23:22:35 +0000845 return cantFail(runSignatureHelp(Server, File, Test.point()));
Sam McCall800d4372017-12-19 10:29:27 +0000846}
847
848MATCHER_P(ParamsAre, P, "") {
849 if (P.size() != arg.parameters.size())
850 return false;
851 for (unsigned I = 0; I < P.size(); ++I)
852 if (P[I] != arg.parameters[I].label)
853 return false;
854 return true;
855}
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +0000856MATCHER_P(SigDoc, Doc, "") { return arg.documentation == Doc; }
Sam McCall800d4372017-12-19 10:29:27 +0000857
858Matcher<SignatureInformation> Sig(std::string Label,
859 std::vector<std::string> Params) {
Eric Liu8f3678d2018-06-15 13:34:18 +0000860 return AllOf(SigHelpLabeled(Label), ParamsAre(Params));
Sam McCall800d4372017-12-19 10:29:27 +0000861}
862
863TEST(SignatureHelpTest, Overloads) {
864 auto Results = signatures(R"cpp(
865 void foo(int x, int y);
866 void foo(int x, float y);
867 void foo(float x, int y);
868 void foo(float x, float y);
869 void bar(int x, int y = 0);
870 int main() { foo(^); }
871 )cpp");
872 EXPECT_THAT(Results.signatures,
873 UnorderedElementsAre(
874 Sig("foo(float x, float y) -> void", {"float x", "float y"}),
875 Sig("foo(float x, int y) -> void", {"float x", "int y"}),
876 Sig("foo(int x, float y) -> void", {"int x", "float y"}),
877 Sig("foo(int x, int y) -> void", {"int x", "int y"})));
878 // We always prefer the first signature.
879 EXPECT_EQ(0, Results.activeSignature);
880 EXPECT_EQ(0, Results.activeParameter);
881}
882
883TEST(SignatureHelpTest, DefaultArgs) {
884 auto Results = signatures(R"cpp(
885 void bar(int x, int y = 0);
886 void bar(float x = 0, int y = 42);
887 int main() { bar(^
888 )cpp");
889 EXPECT_THAT(Results.signatures,
890 UnorderedElementsAre(
891 Sig("bar(int x, int y = 0) -> void", {"int x", "int y = 0"}),
892 Sig("bar(float x = 0, int y = 42) -> void",
893 {"float x = 0", "int y = 42"})));
894 EXPECT_EQ(0, Results.activeSignature);
895 EXPECT_EQ(0, Results.activeParameter);
896}
897
898TEST(SignatureHelpTest, ActiveArg) {
899 auto Results = signatures(R"cpp(
900 int baz(int a, int b, int c);
901 int main() { baz(baz(1,2,3), ^); }
902 )cpp");
903 EXPECT_THAT(Results.signatures,
904 ElementsAre(Sig("baz(int a, int b, int c) -> int",
905 {"int a", "int b", "int c"})));
906 EXPECT_EQ(0, Results.activeSignature);
907 EXPECT_EQ(1, Results.activeParameter);
908}
909
Haojian Wu061c73e2018-01-23 11:37:26 +0000910class IndexRequestCollector : public SymbolIndex {
911public:
912 bool
Sam McCalld1a7a372018-01-31 13:40:48 +0000913 fuzzyFind(const FuzzyFindRequest &Req,
Haojian Wu061c73e2018-01-23 11:37:26 +0000914 llvm::function_ref<void(const Symbol &)> Callback) const override {
915 Requests.push_back(Req);
Sam McCallab8e3932018-02-19 13:04:41 +0000916 return true;
Haojian Wu061c73e2018-01-23 11:37:26 +0000917 }
918
Eric Liu9ec459f2018-03-14 09:48:05 +0000919 void lookup(const LookupRequest &,
920 llvm::function_ref<void(const Symbol &)>) const override {}
921
Haojian Wu65ac3212018-08-06 13:14:32 +0000922 void findOccurrences(const OccurrencesRequest &Req,
923 llvm::function_ref<void(const SymbolOccurrence &)>
924 Callback) const override {}
925
Kirill Bobyrevfc890012018-08-24 09:12:54 +0000926 // This is incorrect, but IndexRequestCollector is not an actual index and it
927 // isn't used in production code.
928 size_t estimateMemoryUsage() const override { return 0; }
929
Haojian Wu061c73e2018-01-23 11:37:26 +0000930 const std::vector<FuzzyFindRequest> allRequests() const { return Requests; }
931
932private:
933 mutable std::vector<FuzzyFindRequest> Requests;
934};
935
936std::vector<FuzzyFindRequest> captureIndexRequests(llvm::StringRef Code) {
937 clangd::CodeCompleteOptions Opts;
938 IndexRequestCollector Requests;
939 Opts.Index = &Requests;
940 completions(Code, {}, Opts);
941 return Requests.allRequests();
942}
943
944TEST(CompletionTest, UnqualifiedIdQuery) {
945 auto Requests = captureIndexRequests(R"cpp(
946 namespace std {}
947 using namespace std;
948 namespace ns {
949 void f() {
950 vec^
951 }
952 }
953 )cpp");
954
955 EXPECT_THAT(Requests,
956 ElementsAre(Field(&FuzzyFindRequest::Scopes,
957 UnorderedElementsAre("", "ns::", "std::"))));
958}
959
960TEST(CompletionTest, ResolvedQualifiedIdQuery) {
961 auto Requests = captureIndexRequests(R"cpp(
962 namespace ns1 {}
963 namespace ns2 {} // ignore
964 namespace ns3 { namespace nns3 {} }
965 namespace foo {
966 using namespace ns1;
967 using namespace ns3::nns3;
968 }
969 namespace ns {
970 void f() {
971 foo::^
972 }
973 }
974 )cpp");
975
976 EXPECT_THAT(Requests,
977 ElementsAre(Field(
978 &FuzzyFindRequest::Scopes,
979 UnorderedElementsAre("foo::", "ns1::", "ns3::nns3::"))));
980}
981
982TEST(CompletionTest, UnresolvedQualifierIdQuery) {
983 auto Requests = captureIndexRequests(R"cpp(
984 namespace a {}
985 using namespace a;
986 namespace ns {
987 void f() {
988 bar::^
989 }
990 } // namespace ns
991 )cpp");
992
993 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
994 UnorderedElementsAre("bar::"))));
995}
996
997TEST(CompletionTest, UnresolvedNestedQualifierIdQuery) {
998 auto Requests = captureIndexRequests(R"cpp(
999 namespace a {}
1000 using namespace a;
1001 namespace ns {
1002 void f() {
1003 ::a::bar::^
1004 }
1005 } // namespace ns
1006 )cpp");
1007
1008 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
1009 UnorderedElementsAre("a::bar::"))));
1010}
1011
1012TEST(CompletionTest, EmptyQualifiedQuery) {
1013 auto Requests = captureIndexRequests(R"cpp(
1014 namespace ns {
1015 void f() {
1016 ^
1017 }
1018 } // namespace ns
1019 )cpp");
1020
1021 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
1022 UnorderedElementsAre("", "ns::"))));
1023}
1024
1025TEST(CompletionTest, GlobalQualifiedQuery) {
1026 auto Requests = captureIndexRequests(R"cpp(
1027 namespace ns {
1028 void f() {
1029 ::^
1030 }
1031 } // namespace ns
1032 )cpp");
1033
1034 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
1035 UnorderedElementsAre(""))));
1036}
1037
Ilya Biryukova907ba42018-05-14 10:50:04 +00001038TEST(CompletionTest, NoIndexCompletionsInsideClasses) {
1039 auto Completions = completions(
1040 R"cpp(
1041 struct Foo {
1042 int SomeNameOfField;
1043 typedef int SomeNameOfTypedefField;
1044 };
1045
1046 Foo::^)cpp",
1047 {func("::SomeNameInTheIndex"), func("::Foo::SomeNameInTheIndex")});
1048
Sam McCalle746a2b2018-07-02 11:13:16 +00001049 EXPECT_THAT(Completions.Completions,
Ilya Biryukova907ba42018-05-14 10:50:04 +00001050 AllOf(Contains(Labeled("SomeNameOfField")),
1051 Contains(Labeled("SomeNameOfTypedefField")),
1052 Not(Contains(Labeled("SomeNameInTheIndex")))));
1053}
1054
1055TEST(CompletionTest, NoIndexCompletionsInsideDependentCode) {
1056 {
1057 auto Completions = completions(
1058 R"cpp(
1059 template <class T>
1060 void foo() {
1061 T::^
1062 }
1063 )cpp",
1064 {func("::SomeNameInTheIndex")});
1065
Sam McCalle746a2b2018-07-02 11:13:16 +00001066 EXPECT_THAT(Completions.Completions,
Ilya Biryukova907ba42018-05-14 10:50:04 +00001067 Not(Contains(Labeled("SomeNameInTheIndex"))));
1068 }
1069
1070 {
1071 auto Completions = completions(
1072 R"cpp(
1073 template <class T>
1074 void foo() {
1075 T::template Y<int>::^
1076 }
1077 )cpp",
1078 {func("::SomeNameInTheIndex")});
1079
Sam McCalle746a2b2018-07-02 11:13:16 +00001080 EXPECT_THAT(Completions.Completions,
Ilya Biryukova907ba42018-05-14 10:50:04 +00001081 Not(Contains(Labeled("SomeNameInTheIndex"))));
1082 }
1083
1084 {
1085 auto Completions = completions(
1086 R"cpp(
1087 template <class T>
1088 void foo() {
1089 T::foo::^
1090 }
1091 )cpp",
1092 {func("::SomeNameInTheIndex")});
1093
Sam McCalle746a2b2018-07-02 11:13:16 +00001094 EXPECT_THAT(Completions.Completions,
Ilya Biryukova907ba42018-05-14 10:50:04 +00001095 Not(Contains(Labeled("SomeNameInTheIndex"))));
1096 }
1097}
1098
Sam McCallc18c2802018-06-15 11:06:29 +00001099TEST(CompletionTest, OverloadBundling) {
1100 clangd::CodeCompleteOptions Opts;
1101 Opts.BundleOverloads = true;
1102
1103 std::string Context = R"cpp(
1104 struct X {
1105 // Overload with int
1106 int a(int);
1107 // Overload with bool
1108 int a(bool);
1109 int b(float);
1110 };
1111 int GFuncC(int);
1112 int GFuncD(int);
1113 )cpp";
1114
1115 // Member completions are bundled.
Sam McCalle746a2b2018-07-02 11:13:16 +00001116 EXPECT_THAT(completions(Context + "int y = X().^", {}, Opts).Completions,
Sam McCallc18c2802018-06-15 11:06:29 +00001117 UnorderedElementsAre(Labeled("a(…)"), Labeled("b(float)")));
1118
1119 // Non-member completions are bundled, including index+sema.
1120 Symbol NoArgsGFunc = func("GFuncC");
1121 EXPECT_THAT(
Sam McCalle746a2b2018-07-02 11:13:16 +00001122 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions,
Sam McCallc18c2802018-06-15 11:06:29 +00001123 UnorderedElementsAre(Labeled("GFuncC(…)"), Labeled("GFuncD(int)")));
1124
1125 // Differences in header-to-insert suppress bundling.
1126 Symbol::Details Detail;
1127 std::string DeclFile = URI::createFile(testPath("foo")).toString();
1128 NoArgsGFunc.CanonicalDeclaration.FileURI = DeclFile;
1129 Detail.IncludeHeader = "<foo>";
1130 NoArgsGFunc.Detail = &Detail;
1131 EXPECT_THAT(
Sam McCalle746a2b2018-07-02 11:13:16 +00001132 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions,
1133 UnorderedElementsAre(AllOf(Named("GFuncC"), InsertInclude("<foo>")),
1134 Labeled("GFuncC(int)"), Labeled("GFuncD(int)")));
Sam McCallc18c2802018-06-15 11:06:29 +00001135
1136 // Examine a bundled completion in detail.
Sam McCalle746a2b2018-07-02 11:13:16 +00001137 auto A =
1138 completions(Context + "int y = X().a^", {}, Opts).Completions.front();
1139 EXPECT_EQ(A.Name, "a");
1140 EXPECT_EQ(A.Signature, "(…)");
1141 EXPECT_EQ(A.BundleSize, 2u);
1142 EXPECT_EQ(A.Kind, CompletionItemKind::Method);
1143 EXPECT_EQ(A.ReturnType, "int"); // All overloads return int.
Sam McCallc18c2802018-06-15 11:06:29 +00001144 // For now we just return one of the doc strings arbitrarily.
Sam McCalle746a2b2018-07-02 11:13:16 +00001145 EXPECT_THAT(A.Documentation, AnyOf(HasSubstr("Overload with int"),
Sam McCallc18c2802018-06-15 11:06:29 +00001146 HasSubstr("Overload with bool")));
Kadir Cetinkaya516fcda2018-08-23 12:19:39 +00001147 EXPECT_EQ(A.SnippetSuffix, "($0)");
Sam McCallc18c2802018-06-15 11:06:29 +00001148}
1149
Ilya Biryukov30b04b12018-05-28 09:54:51 +00001150TEST(CompletionTest, DocumentationFromChangedFileCrash) {
Ilya Biryukovbe0eb8f2018-05-24 14:49:23 +00001151 MockFSProvider FS;
1152 auto FooH = testPath("foo.h");
1153 auto FooCpp = testPath("foo.cpp");
1154 FS.Files[FooH] = R"cpp(
1155 // this is my documentation comment.
1156 int func();
1157 )cpp";
1158 FS.Files[FooCpp] = "";
1159
1160 MockCompilationDatabase CDB;
1161 IgnoreDiagnostics DiagConsumer;
1162 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
1163
1164 Annotations Source(R"cpp(
1165 #include "foo.h"
1166 int func() {
1167 // This makes sure we have func from header in the AST.
1168 }
1169 int a = fun^
1170 )cpp");
1171 Server.addDocument(FooCpp, Source.code(), WantDiagnostics::Yes);
1172 // We need to wait for preamble to build.
1173 ASSERT_TRUE(Server.blockUntilIdleForTest());
1174
1175 // Change the header file. Completion will reuse the old preamble!
1176 FS.Files[FooH] = R"cpp(
1177 int func();
1178 )cpp";
1179
1180 clangd::CodeCompleteOptions Opts;
1181 Opts.IncludeComments = true;
Sam McCalle746a2b2018-07-02 11:13:16 +00001182 CodeCompleteResult Completions =
Ilya Biryukovbe0eb8f2018-05-24 14:49:23 +00001183 cantFail(runCodeComplete(Server, FooCpp, Source.point(), Opts));
1184 // We shouldn't crash. Unfortunately, current workaround is to not produce
1185 // comments for symbols from headers.
Sam McCalle746a2b2018-07-02 11:13:16 +00001186 EXPECT_THAT(Completions.Completions,
Ilya Biryukovbe0eb8f2018-05-24 14:49:23 +00001187 Contains(AllOf(Not(IsDocumented()), Named("func"))));
1188}
1189
Ilya Biryukov89fcf6b2018-06-15 08:31:17 +00001190TEST(CompletionTest, NonDocComments) {
1191 MockFSProvider FS;
1192 auto FooCpp = testPath("foo.cpp");
1193 FS.Files[FooCpp] = "";
1194
1195 MockCompilationDatabase CDB;
1196 IgnoreDiagnostics DiagConsumer;
1197 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
1198
1199 Annotations Source(R"cpp(
Ilya Biryukovda8dd8b2018-06-27 09:47:20 +00001200 // We ignore namespace comments, for rationale see CodeCompletionStrings.h.
1201 namespace comments_ns {
1202 }
1203
Ilya Biryukov89fcf6b2018-06-15 08:31:17 +00001204 // ------------------
1205 int comments_foo();
1206
1207 // A comment and a decl are separated by newlines.
1208 // Therefore, the comment shouldn't show up as doc comment.
1209
1210 int comments_bar();
1211
1212 // this comment should be in the results.
1213 int comments_baz();
1214
1215
1216 template <class T>
1217 struct Struct {
1218 int comments_qux();
1219 int comments_quux();
1220 };
1221
1222
1223 // This comment should not be there.
1224
1225 template <class T>
1226 int Struct<T>::comments_qux() {
1227 }
1228
1229 // This comment **should** be in results.
1230 template <class T>
1231 int Struct<T>::comments_quux() {
1232 int a = comments^;
1233 }
1234 )cpp");
Reid Kleckner80274b12018-06-18 18:55:10 +00001235 // FIXME: Auto-completion in a template requires disabling delayed template
1236 // parsing.
1237 CDB.ExtraClangFlags.push_back("-fno-delayed-template-parsing");
Ilya Biryukov89fcf6b2018-06-15 08:31:17 +00001238 Server.addDocument(FooCpp, Source.code(), WantDiagnostics::Yes);
Sam McCalle746a2b2018-07-02 11:13:16 +00001239 CodeCompleteResult Completions = cantFail(runCodeComplete(
Ilya Biryukov89fcf6b2018-06-15 08:31:17 +00001240 Server, FooCpp, Source.point(), clangd::CodeCompleteOptions()));
1241
1242 // We should not get any of those comments in completion.
1243 EXPECT_THAT(
Sam McCalle746a2b2018-07-02 11:13:16 +00001244 Completions.Completions,
Ilya Biryukov89fcf6b2018-06-15 08:31:17 +00001245 UnorderedElementsAre(AllOf(Not(IsDocumented()), Named("comments_foo")),
1246 AllOf(IsDocumented(), Named("comments_baz")),
1247 AllOf(IsDocumented(), Named("comments_quux")),
Ilya Biryukovda8dd8b2018-06-27 09:47:20 +00001248 AllOf(Not(IsDocumented()), Named("comments_ns")),
Ilya Biryukov89fcf6b2018-06-15 08:31:17 +00001249 // FIXME(ibiryukov): the following items should have
1250 // empty documentation, since they are separated from
1251 // a comment with an empty line. Unfortunately, I
1252 // couldn't make Sema tests pass if we ignore those.
1253 AllOf(IsDocumented(), Named("comments_bar")),
1254 AllOf(IsDocumented(), Named("comments_qux"))));
1255}
1256
Ilya Biryukov981a35d2018-05-28 12:11:37 +00001257TEST(CompletionTest, CompleteOnInvalidLine) {
1258 auto FooCpp = testPath("foo.cpp");
1259
1260 MockCompilationDatabase CDB;
1261 IgnoreDiagnostics DiagConsumer;
1262 MockFSProvider FS;
1263 FS.Files[FooCpp] = "// empty file";
1264
1265 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
1266 // Run completion outside the file range.
1267 Position Pos;
1268 Pos.line = 100;
1269 Pos.character = 0;
1270 EXPECT_THAT_EXPECTED(
1271 runCodeComplete(Server, FooCpp, Pos, clangd::CodeCompleteOptions()),
1272 Failed());
1273}
1274
Eric Liu7ad16962018-06-22 10:46:59 +00001275TEST(CompletionTest, QualifiedNames) {
1276 auto Results = completions(
1277 R"cpp(
1278 namespace ns { int local; void both(); }
1279 void f() { ::ns::^ }
1280 )cpp",
1281 {func("ns::both"), cls("ns::Index")});
1282 // We get results from both index and sema, with no duplicates.
Sam McCalle746a2b2018-07-02 11:13:16 +00001283 EXPECT_THAT(
1284 Results.Completions,
1285 UnorderedElementsAre(Scope("ns::"), Scope("ns::"), Scope("ns::")));
1286}
1287
1288TEST(CompletionTest, Render) {
1289 CodeCompletion C;
1290 C.Name = "x";
1291 C.Signature = "(bool) const";
1292 C.SnippetSuffix = "(${0:bool})";
1293 C.ReturnType = "int";
1294 C.RequiredQualifier = "Foo::";
1295 C.Scope = "ns::Foo::";
1296 C.Documentation = "This is x().";
1297 C.Header = "\"foo.h\"";
1298 C.Kind = CompletionItemKind::Method;
1299 C.Score.Total = 1.0;
Sam McCall4e5742a2018-07-06 11:50:49 +00001300 C.Origin = SymbolOrigin::AST | SymbolOrigin::Static;
Sam McCalle746a2b2018-07-02 11:13:16 +00001301
1302 CodeCompleteOptions Opts;
1303 Opts.IncludeIndicator.Insert = "^";
1304 Opts.IncludeIndicator.NoInsert = "";
1305 Opts.EnableSnippets = false;
1306
1307 auto R = C.render(Opts);
1308 EXPECT_EQ(R.label, "Foo::x(bool) const");
1309 EXPECT_EQ(R.insertText, "Foo::x");
1310 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText);
1311 EXPECT_EQ(R.filterText, "x");
1312 EXPECT_EQ(R.detail, "int\n\"foo.h\"");
1313 EXPECT_EQ(R.documentation, "This is x().");
1314 EXPECT_THAT(R.additionalTextEdits, IsEmpty());
Sam McCalle746a2b2018-07-02 11:13:16 +00001315 EXPECT_EQ(R.sortText, sortText(1.0, "x"));
1316
1317 Opts.EnableSnippets = true;
1318 R = C.render(Opts);
1319 EXPECT_EQ(R.insertText, "Foo::x(${0:bool})");
1320 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::Snippet);
1321
1322 C.HeaderInsertion.emplace();
1323 R = C.render(Opts);
1324 EXPECT_EQ(R.label, "^Foo::x(bool) const");
1325 EXPECT_THAT(R.additionalTextEdits, Not(IsEmpty()));
1326
Sam McCall2161ec72018-07-05 06:20:41 +00001327 Opts.ShowOrigins = true;
1328 R = C.render(Opts);
1329 EXPECT_EQ(R.label, "^[AS]Foo::x(bool) const");
1330
Sam McCalle746a2b2018-07-02 11:13:16 +00001331 C.BundleSize = 2;
1332 R = C.render(Opts);
1333 EXPECT_EQ(R.detail, "[2 overloads]\n\"foo.h\"");
Eric Liu7ad16962018-06-22 10:46:59 +00001334}
Ilya Biryukov981a35d2018-05-28 12:11:37 +00001335
Eric Liu485074f2018-07-11 13:15:31 +00001336TEST(CompletionTest, IgnoreRecoveryResults) {
1337 auto Results = completions(
1338 R"cpp(
1339 namespace ns { int NotRecovered() { return 0; } }
1340 void f() {
1341 // Sema enters recovery mode first and then normal mode.
1342 if (auto x = ns::NotRecover^)
1343 }
1344 )cpp");
1345 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Named("NotRecovered")));
1346}
1347
Eric Liuf433c2d2018-07-18 15:31:14 +00001348TEST(CompletionTest, ScopeOfClassFieldInConstructorInitializer) {
1349 auto Results = completions(
1350 R"cpp(
1351 namespace ns {
1352 class X { public: X(); int x_; };
1353 X::X() : x_^(0) {}
1354 }
1355 )cpp");
1356 EXPECT_THAT(Results.Completions,
1357 UnorderedElementsAre(AllOf(Scope("ns::X::"), Named("x_"))));
1358}
1359
Eric Liu5d2a8072018-07-23 10:56:37 +00001360TEST(CompletionTest, CodeCompletionContext) {
1361 auto Results = completions(
1362 R"cpp(
1363 namespace ns {
1364 class X { public: X(); int x_; };
1365 void f() {
1366 X x;
1367 x.^;
1368 }
1369 }
1370 )cpp");
1371
1372 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess);
1373}
1374
Kadir Cetinkaya2f84d912018-08-08 08:59:29 +00001375TEST(CompletionTest, FixItForArrowToDot) {
1376 MockFSProvider FS;
1377 MockCompilationDatabase CDB;
1378 IgnoreDiagnostics DiagConsumer;
1379 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
1380
1381 CodeCompleteOptions Opts;
1382 Opts.IncludeFixIts = true;
1383 Annotations TestCode(
1384 R"cpp(
1385 class Auxilary {
1386 public:
1387 void AuxFunction();
1388 };
1389 class ClassWithPtr {
1390 public:
1391 void MemberFunction();
1392 Auxilary* operator->() const;
1393 Auxilary* Aux;
1394 };
1395 void f() {
1396 ClassWithPtr x;
1397 x[[->]]^;
1398 }
1399 )cpp");
1400 auto Results =
1401 completions(Server, TestCode.code(), TestCode.point(), {}, Opts);
1402 EXPECT_EQ(Results.Completions.size(), 3u);
1403
1404 TextEdit ReplacementEdit;
1405 ReplacementEdit.range = TestCode.range();
1406 ReplacementEdit.newText = ".";
1407 for (const auto &C : Results.Completions) {
1408 EXPECT_TRUE(C.FixIts.size() == 1u || C.Name == "AuxFunction");
Haojian Wu1793bc92018-08-10 08:34:16 +00001409 if (!C.FixIts.empty()) {
Kadir Cetinkaya2f84d912018-08-08 08:59:29 +00001410 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit));
Haojian Wu1793bc92018-08-10 08:34:16 +00001411 }
Kadir Cetinkaya2f84d912018-08-08 08:59:29 +00001412 }
1413}
1414
1415TEST(CompletionTest, FixItForDotToArrow) {
1416 MockFSProvider FS;
1417 MockCompilationDatabase CDB;
1418 IgnoreDiagnostics DiagConsumer;
1419 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
1420
1421 CodeCompleteOptions Opts;
1422 Opts.IncludeFixIts = true;
1423 Annotations TestCode(
1424 R"cpp(
1425 class Auxilary {
1426 public:
1427 void AuxFunction();
1428 };
1429 class ClassWithPtr {
1430 public:
1431 void MemberFunction();
1432 Auxilary* operator->() const;
1433 Auxilary* Aux;
1434 };
1435 void f() {
1436 ClassWithPtr x;
1437 x[[.]]^;
1438 }
1439 )cpp");
1440 auto Results =
1441 completions(Server, TestCode.code(), TestCode.point(), {}, Opts);
1442 EXPECT_EQ(Results.Completions.size(), 3u);
1443
1444 TextEdit ReplacementEdit;
1445 ReplacementEdit.range = TestCode.range();
1446 ReplacementEdit.newText = "->";
1447 for (const auto &C : Results.Completions) {
1448 EXPECT_TRUE(C.FixIts.empty() || C.Name == "AuxFunction");
1449 if (!C.FixIts.empty()) {
1450 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit));
1451 }
1452 }
1453}
1454
Kadir Cetinkayaa9c9d002018-08-13 08:23:01 +00001455TEST(CompletionTest, RenderWithFixItMerged) {
1456 TextEdit FixIt;
1457 FixIt.range.end.character = 5;
1458 FixIt.newText = "->";
1459
1460 CodeCompletion C;
1461 C.Name = "x";
1462 C.RequiredQualifier = "Foo::";
1463 C.FixIts = {FixIt};
1464 C.CompletionTokenRange.start.character = 5;
1465
1466 CodeCompleteOptions Opts;
1467 Opts.IncludeFixIts = true;
1468
1469 auto R = C.render(Opts);
1470 EXPECT_TRUE(R.textEdit);
1471 EXPECT_EQ(R.textEdit->newText, "->Foo::x");
1472 EXPECT_TRUE(R.additionalTextEdits.empty());
1473}
1474
1475TEST(CompletionTest, RenderWithFixItNonMerged) {
1476 TextEdit FixIt;
1477 FixIt.range.end.character = 4;
1478 FixIt.newText = "->";
1479
1480 CodeCompletion C;
1481 C.Name = "x";
1482 C.RequiredQualifier = "Foo::";
1483 C.FixIts = {FixIt};
1484 C.CompletionTokenRange.start.character = 5;
1485
1486 CodeCompleteOptions Opts;
1487 Opts.IncludeFixIts = true;
1488
1489 auto R = C.render(Opts);
1490 EXPECT_TRUE(R.textEdit);
1491 EXPECT_EQ(R.textEdit->newText, "Foo::x");
1492 EXPECT_THAT(R.additionalTextEdits, UnorderedElementsAre(FixIt));
1493}
1494
1495TEST(CompletionTest, CompletionTokenRange) {
1496 MockFSProvider FS;
1497 MockCompilationDatabase CDB;
1498 IgnoreDiagnostics DiagConsumer;
1499 ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());
1500
1501 constexpr const char *TestCodes[] = {
1502 R"cpp(
1503 class Auxilary {
1504 public:
1505 void AuxFunction();
1506 };
1507 void f() {
1508 Auxilary x;
1509 x.[[Aux]]^;
1510 }
1511 )cpp",
1512 R"cpp(
1513 class Auxilary {
1514 public:
1515 void AuxFunction();
1516 };
1517 void f() {
1518 Auxilary x;
1519 x.[[]]^;
1520 }
1521 )cpp"};
1522 for (const auto &Text : TestCodes) {
1523 Annotations TestCode(Text);
1524 auto Results = completions(Server, TestCode.code(), TestCode.point());
1525
1526 EXPECT_EQ(Results.Completions.size(), 1u);
1527 EXPECT_THAT(Results.Completions.front().CompletionTokenRange, TestCode.range());
1528 }
1529}
1530
Kadir Cetinkayae486e372018-08-13 08:40:05 +00001531TEST(SignatureHelpTest, OverloadsOrdering) {
1532 const auto Results = signatures(R"cpp(
1533 void foo(int x);
1534 void foo(int x, float y);
1535 void foo(float x, int y);
1536 void foo(float x, float y);
1537 void foo(int x, int y = 0);
1538 int main() { foo(^); }
1539 )cpp");
1540 EXPECT_THAT(
1541 Results.signatures,
1542 ElementsAre(
1543 Sig("foo(int x) -> void", {"int x"}),
1544 Sig("foo(int x, int y = 0) -> void", {"int x", "int y = 0"}),
1545 Sig("foo(float x, int y) -> void", {"float x", "int y"}),
1546 Sig("foo(int x, float y) -> void", {"int x", "float y"}),
1547 Sig("foo(float x, float y) -> void", {"float x", "float y"})));
1548 // We always prefer the first signature.
1549 EXPECT_EQ(0, Results.activeSignature);
1550 EXPECT_EQ(0, Results.activeParameter);
1551}
1552
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001553TEST(SignatureHelpTest, InstantiatedSignatures) {
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001554 StringRef Sig0 = R"cpp(
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001555 template <class T>
1556 void foo(T, T, T);
1557
1558 int main() {
1559 foo<int>(^);
1560 }
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001561 )cpp";
1562
1563 EXPECT_THAT(signatures(Sig0).signatures,
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001564 ElementsAre(Sig("foo(T, T, T) -> void", {"T", "T", "T"})));
1565
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001566 StringRef Sig1 = R"cpp(
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001567 template <class T>
1568 void foo(T, T, T);
1569
1570 int main() {
1571 foo(10, ^);
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001572 })cpp";
1573
1574 EXPECT_THAT(signatures(Sig1).signatures,
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001575 ElementsAre(Sig("foo(T, T, T) -> void", {"T", "T", "T"})));
1576
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001577 StringRef Sig2 = R"cpp(
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001578 template <class ...T>
1579 void foo(T...);
1580
1581 int main() {
1582 foo<int>(^);
1583 }
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001584 )cpp";
1585
1586 EXPECT_THAT(signatures(Sig2).signatures,
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001587 ElementsAre(Sig("foo(T...) -> void", {"T..."})));
1588
1589 // It is debatable whether we should substitute the outer template parameter
1590 // ('T') in that case. Currently we don't substitute it in signature help, but
1591 // do substitute in code complete.
1592 // FIXME: make code complete and signature help consistent, figure out which
1593 // way is better.
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001594 StringRef Sig3 = R"cpp(
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001595 template <class T>
1596 struct X {
1597 template <class U>
1598 void foo(T, U);
1599 };
1600
1601 int main() {
1602 X<int>().foo<double>(^)
1603 }
Simon Pilgrim83552ee2018-08-16 11:41:19 +00001604 )cpp";
1605
1606 EXPECT_THAT(signatures(Sig3).signatures,
Ilya Biryukov8fd44bb2018-08-14 09:36:32 +00001607 ElementsAre(Sig("foo(T, U) -> void", {"T", "U"})));
1608}
1609
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +00001610TEST(SignatureHelpTest, IndexDocumentation) {
1611 Symbol::Details DocDetails;
1612 DocDetails.Documentation = "Doc from the index";
1613
1614 Symbol Foo0 = sym("foo", index::SymbolKind::Function, "@F@\\0#");
1615 Foo0.Detail = &DocDetails;
1616 Symbol Foo1 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#");
1617 Foo1.Detail = &DocDetails;
1618 Symbol Foo2 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#I#");
1619
Simon Pilgrim24d34922018-08-17 10:40:05 +00001620 StringRef Sig0 = R"cpp(
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +00001621 int foo();
1622 int foo(double);
1623
1624 void test() {
1625 foo(^);
1626 }
Simon Pilgrim24d34922018-08-17 10:40:05 +00001627 )cpp";
1628
1629 EXPECT_THAT(
1630 signatures(Sig0, {Foo0}).signatures,
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +00001631 ElementsAre(AllOf(Sig("foo() -> int", {}), SigDoc("Doc from the index")),
1632 AllOf(Sig("foo(double) -> int", {"double"}), SigDoc(""))));
1633
Simon Pilgrim24d34922018-08-17 10:40:05 +00001634 StringRef Sig1 = R"cpp(
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +00001635 int foo();
1636 // Overriden doc from sema
1637 int foo(int);
1638 // Doc from sema
1639 int foo(int, int);
1640
1641 void test() {
1642 foo(^);
1643 }
Simon Pilgrim24d34922018-08-17 10:40:05 +00001644 )cpp";
1645
1646 EXPECT_THAT(
1647 signatures(Sig1, {Foo0, Foo1, Foo2}).signatures,
Ilya Biryukov8a0f76b2018-08-17 09:32:30 +00001648 ElementsAre(AllOf(Sig("foo() -> int", {}), SigDoc("Doc from the index")),
1649 AllOf(Sig("foo(int) -> int", {"int"}),
1650 SigDoc("Overriden doc from sema")),
1651 AllOf(Sig("foo(int, int) -> int", {"int", "int"}),
1652 SigDoc("Doc from sema"))));
1653}
1654
Kadir Cetinkaya516fcda2018-08-23 12:19:39 +00001655TEST(CompletionTest, CompletionFunctionArgsDisabled) {
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001656 CodeCompleteOptions Opts;
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001657 Opts.EnableSnippets = true;
1658 Opts.EnableFunctionArgSnippets = false;
Kadir Cetinkaya516fcda2018-08-23 12:19:39 +00001659 const std::string Header =
1660 R"cpp(
1661 void xfoo();
1662 void xfoo(int x, int y);
1663 void xbar();
1664 void f() {
1665 )cpp";
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001666 {
Kadir Cetinkaya516fcda2018-08-23 12:19:39 +00001667 auto Results = completions(Header + "\nxfo^", {}, Opts);
1668 EXPECT_THAT(
1669 Results.Completions,
1670 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("()")),
1671 AllOf(Named("xfoo"), SnippetSuffix("($0)"))));
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001672 }
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001673 {
Kadir Cetinkaya516fcda2018-08-23 12:19:39 +00001674 auto Results = completions(Header + "\nxba^", {}, Opts);
1675 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf(
1676 Named("xbar"), SnippetSuffix("()"))));
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001677 }
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001678 {
Kadir Cetinkaya516fcda2018-08-23 12:19:39 +00001679 Opts.BundleOverloads = true;
1680 auto Results = completions(Header + "\nxfo^", {}, Opts);
1681 EXPECT_THAT(
1682 Results.Completions,
1683 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("($0)"))));
Kadir Cetinkaya6c9f15c2018-08-17 15:42:54 +00001684 }
1685}
1686
Kadir Cetinkayaf8b85a32018-08-23 13:14:50 +00001687TEST(CompletionTest, SuggestOverrides) {
1688 constexpr const char *const Text(R"cpp(
1689 class A {
1690 public:
1691 virtual void vfunc(bool param);
1692 virtual void vfunc(bool param, int p);
1693 void func(bool param);
1694 };
1695 class B : public A {
1696 virtual void ttt(bool param) const;
1697 void vfunc(bool param, int p) override;
1698 };
1699 class C : public B {
1700 public:
1701 void vfunc(bool param) override;
1702 ^
1703 };
1704 )cpp");
1705 const auto Results = completions(Text);
1706 EXPECT_THAT(Results.Completions,
1707 AllOf(Contains(Labeled("void vfunc(bool param, int p) override")),
1708 Contains(Labeled("void ttt(bool param) const override")),
1709 Not(Contains(Labeled("void vfunc(bool param) override")))));
1710}
1711
Sam McCall9aad25f2017-12-05 07:20:26 +00001712} // namespace
1713} // namespace clangd
1714} // namespace clang