blob: 8dbd62fbe01ab4846298640b7a280d220e1f2332 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
15#include "Sema.h"
Ted Kremeneke0e53132010-01-28 23:39:18 +000016#include "clang/Analysis/Analyses/PrintfFormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000017#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000018#include "clang/AST/CharUnits.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000019#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000020#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000021#include "clang/AST/ExprObjC.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000022#include "clang/AST/DeclObjC.h"
23#include "clang/AST/StmtCXX.h"
24#include "clang/AST/StmtObjC.h"
Chris Lattner719e6152009-02-18 19:21:10 +000025#include "clang/Lex/LiteralSupport.h"
Chris Lattner59907c42007-08-10 20:18:51 +000026#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000027#include "llvm/ADT/BitVector.h"
28#include "llvm/ADT/STLExtras.h"
Nate Begeman0d15c532010-06-13 04:47:52 +000029#include "llvm/ADT/StringExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000030#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000031#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000032#include "clang/Basic/TargetInfo.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000033#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000034using namespace clang;
35
Chris Lattner60800082009-02-18 17:49:48 +000036/// getLocationOfStringLiteralByte - Return a source location that points to the
37/// specified byte of the specified string literal.
38///
39/// Strings are amazingly complex. They can be formed from multiple tokens and
40/// can have escape sequences in them in addition to the usual trigraph and
41/// escaped newline business. This routine handles this complexity.
42///
43SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
44 unsigned ByteNo) const {
45 assert(!SL->isWide() && "This doesn't work for wide strings yet");
Mike Stump1eb44332009-09-09 15:08:12 +000046
Chris Lattner60800082009-02-18 17:49:48 +000047 // Loop over all of the tokens in this string until we find the one that
48 // contains the byte we're looking for.
49 unsigned TokNo = 0;
50 while (1) {
51 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
52 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
Mike Stump1eb44332009-09-09 15:08:12 +000053
Chris Lattner60800082009-02-18 17:49:48 +000054 // Get the spelling of the string so that we can get the data that makes up
55 // the string literal, not the identifier for the macro it is potentially
56 // expanded through.
57 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
58
59 // Re-lex the token to get its length and original spelling.
60 std::pair<FileID, unsigned> LocInfo =
61 SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
Douglas Gregorf715ca12010-03-16 00:06:06 +000062 bool Invalid = false;
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000063 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
Douglas Gregorf715ca12010-03-16 00:06:06 +000064 if (Invalid)
Douglas Gregoraea67db2010-03-15 22:54:52 +000065 return StrTokSpellingLoc;
66
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000067 const char *StrData = Buffer.data()+LocInfo.second;
Mike Stump1eb44332009-09-09 15:08:12 +000068
Chris Lattner60800082009-02-18 17:49:48 +000069 // Create a langops struct and enable trigraphs. This is sufficient for
70 // relexing tokens.
71 LangOptions LangOpts;
72 LangOpts.Trigraphs = true;
Mike Stump1eb44332009-09-09 15:08:12 +000073
Chris Lattner60800082009-02-18 17:49:48 +000074 // Create a lexer starting at the beginning of this token.
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000075 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
76 Buffer.end());
Chris Lattner60800082009-02-18 17:49:48 +000077 Token TheTok;
78 TheLexer.LexFromRawLexer(TheTok);
Mike Stump1eb44332009-09-09 15:08:12 +000079
Chris Lattner443e53c2009-02-18 19:26:42 +000080 // Use the StringLiteralParser to compute the length of the string in bytes.
Douglas Gregorb90f4b32010-05-26 05:35:51 +000081 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
Chris Lattner443e53c2009-02-18 19:26:42 +000082 unsigned TokNumBytes = SLP.GetStringLength();
Mike Stump1eb44332009-09-09 15:08:12 +000083
Chris Lattner2197c962009-02-18 18:52:52 +000084 // If the byte is in this token, return the location of the byte.
Chris Lattner60800082009-02-18 17:49:48 +000085 if (ByteNo < TokNumBytes ||
86 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
Mike Stump1eb44332009-09-09 15:08:12 +000087 unsigned Offset =
Douglas Gregorb90f4b32010-05-26 05:35:51 +000088 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
89 /*Complain=*/false);
Mike Stump1eb44332009-09-09 15:08:12 +000090
Chris Lattner719e6152009-02-18 19:21:10 +000091 // Now that we know the offset of the token in the spelling, use the
92 // preprocessor to get the offset in the original source.
93 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
Chris Lattner60800082009-02-18 17:49:48 +000094 }
Mike Stump1eb44332009-09-09 15:08:12 +000095
Chris Lattner60800082009-02-18 17:49:48 +000096 // Move to the next string token.
97 ++TokNo;
98 ByteNo -= TokNumBytes;
99 }
100}
101
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000102/// CheckablePrintfAttr - does a function call have a "printf" attribute
103/// and arguments that merit checking?
104bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
105 if (Format->getType() == "printf") return true;
106 if (Format->getType() == "printf0") {
107 // printf0 allows null "format" string; if so don't check format/args
108 unsigned format_idx = Format->getFormatIdx() - 1;
Sebastian Redl4a2614e2009-11-17 18:02:24 +0000109 // Does the index refer to the implicit object argument?
110 if (isa<CXXMemberCallExpr>(TheCall)) {
111 if (format_idx == 0)
112 return false;
113 --format_idx;
114 }
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000115 if (format_idx < TheCall->getNumArgs()) {
116 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
Ted Kremenekefaff192010-02-27 01:41:03 +0000117 if (!Format->isNullPointerConstant(Context,
118 Expr::NPC_ValueDependentIsNull))
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000119 return true;
120 }
121 }
122 return false;
123}
Chris Lattner60800082009-02-18 17:49:48 +0000124
Sebastian Redl0eb23302009-01-19 00:08:26 +0000125Action::OwningExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000126Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Sebastian Redl0eb23302009-01-19 00:08:26 +0000127 OwningExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000128
Anders Carlssond406bf02009-08-16 01:56:34 +0000129 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000130 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000131 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000132 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000133 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000134 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000135 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000136 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000137 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000138 if (SemaBuiltinVAStart(TheCall))
139 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000140 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000141 case Builtin::BI__builtin_isgreater:
142 case Builtin::BI__builtin_isgreaterequal:
143 case Builtin::BI__builtin_isless:
144 case Builtin::BI__builtin_islessequal:
145 case Builtin::BI__builtin_islessgreater:
146 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000147 if (SemaBuiltinUnorderedCompare(TheCall))
148 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000149 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000150 case Builtin::BI__builtin_fpclassify:
151 if (SemaBuiltinFPClassification(TheCall, 6))
152 return ExprError();
153 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000154 case Builtin::BI__builtin_isfinite:
155 case Builtin::BI__builtin_isinf:
156 case Builtin::BI__builtin_isinf_sign:
157 case Builtin::BI__builtin_isnan:
158 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000159 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000160 return ExprError();
161 break;
Eli Friedman6cfda232008-05-20 08:23:37 +0000162 case Builtin::BI__builtin_return_address:
Eric Christopher691ebc32010-04-17 02:26:23 +0000163 case Builtin::BI__builtin_frame_address: {
164 llvm::APSInt Result;
165 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000166 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000167 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000168 }
169 case Builtin::BI__builtin_eh_return_data_regno: {
170 llvm::APSInt Result;
171 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Chris Lattner21fb98e2009-09-23 06:06:36 +0000172 return ExprError();
173 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000174 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000175 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000176 return SemaBuiltinShuffleVector(TheCall);
177 // TheCall will be freed by the smart pointer here, but that's fine, since
178 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000179 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000180 if (SemaBuiltinPrefetch(TheCall))
181 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000182 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000183 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000184 if (SemaBuiltinObjectSize(TheCall))
185 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000186 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000187 case Builtin::BI__builtin_longjmp:
188 if (SemaBuiltinLongjmp(TheCall))
189 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000190 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000191 case Builtin::BI__sync_fetch_and_add:
192 case Builtin::BI__sync_fetch_and_sub:
193 case Builtin::BI__sync_fetch_and_or:
194 case Builtin::BI__sync_fetch_and_and:
195 case Builtin::BI__sync_fetch_and_xor:
196 case Builtin::BI__sync_add_and_fetch:
197 case Builtin::BI__sync_sub_and_fetch:
198 case Builtin::BI__sync_and_and_fetch:
199 case Builtin::BI__sync_or_and_fetch:
200 case Builtin::BI__sync_xor_and_fetch:
201 case Builtin::BI__sync_val_compare_and_swap:
202 case Builtin::BI__sync_bool_compare_and_swap:
203 case Builtin::BI__sync_lock_test_and_set:
204 case Builtin::BI__sync_lock_release:
205 if (SemaBuiltinAtomicOverloaded(TheCall))
206 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000207 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000208 }
209
210 // Since the target specific builtins for each arch overlap, only check those
211 // of the arch we are compiling for.
212 if (BuiltinID >= Builtin::FirstTSBuiltin) {
213 switch (Context.Target.getTriple().getArch()) {
214 case llvm::Triple::arm:
215 case llvm::Triple::thumb:
216 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
217 return ExprError();
218 break;
219 case llvm::Triple::x86:
220 case llvm::Triple::x86_64:
221 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
222 return ExprError();
223 break;
224 default:
225 break;
226 }
227 }
228
229 return move(TheCallResult);
230}
231
232bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
233 switch (BuiltinID) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000234 case X86::BI__builtin_ia32_palignr128:
235 case X86::BI__builtin_ia32_palignr: {
236 llvm::APSInt Result;
237 if (SemaBuiltinConstantArg(TheCall, 2, Result))
Nate Begeman26a31422010-06-08 02:47:44 +0000238 return true;
Eric Christopher691ebc32010-04-17 02:26:23 +0000239 break;
240 }
Anders Carlsson71993dd2007-08-17 05:31:46 +0000241 }
Nate Begeman26a31422010-06-08 02:47:44 +0000242 return false;
243}
Mike Stump1eb44332009-09-09 15:08:12 +0000244
Nate Begeman26a31422010-06-08 02:47:44 +0000245bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000246 llvm::APSInt Result;
247
Nate Begeman0d15c532010-06-13 04:47:52 +0000248 unsigned mask = 0;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000249 switch (BuiltinID) {
Nate Begeman0d15c532010-06-13 04:47:52 +0000250 case ARM::BI__builtin_neon_vaba_v: mask = 0x707; break;
251 case ARM::BI__builtin_neon_vabaq_v: mask = 0x7070000; break;
252 case ARM::BI__builtin_neon_vabal_v: mask = 0xE0E0000; break;
253 case ARM::BI__builtin_neon_vabd_v: mask = 0x717; break;
254 case ARM::BI__builtin_neon_vabdq_v: mask = 0x7170000; break;
255 case ARM::BI__builtin_neon_vabdl_v: mask = 0xE0E0000; break;
256 case ARM::BI__builtin_neon_vabs_v: mask = 0x17; break;
257 case ARM::BI__builtin_neon_vabsq_v: mask = 0x170000; break;
258 case ARM::BI__builtin_neon_vaddhn_v: mask = 0x707; break;
259 case ARM::BI__builtin_neon_vaddl_v: mask = 0xE0E0000; break;
260 case ARM::BI__builtin_neon_vaddw_v: mask = 0xE0E0000; break;
261 case ARM::BI__builtin_neon_vcage_v: mask = 0x400; break;
262 case ARM::BI__builtin_neon_vcageq_v: mask = 0x4000000; break;
263 case ARM::BI__builtin_neon_vcagt_v: mask = 0x400; break;
264 case ARM::BI__builtin_neon_vcagtq_v: mask = 0x4000000; break;
265 case ARM::BI__builtin_neon_vcale_v: mask = 0x400; break;
266 case ARM::BI__builtin_neon_vcaleq_v: mask = 0x4000000; break;
267 case ARM::BI__builtin_neon_vcalt_v: mask = 0x400; break;
268 case ARM::BI__builtin_neon_vcaltq_v: mask = 0x4000000; break;
269 case ARM::BI__builtin_neon_vcls_v: mask = 0x7; break;
270 case ARM::BI__builtin_neon_vclsq_v: mask = 0x70000; break;
271 case ARM::BI__builtin_neon_vclz_v: mask = 0x707; break;
272 case ARM::BI__builtin_neon_vclzq_v: mask = 0x7070000; break;
273 case ARM::BI__builtin_neon_vcnt_v: mask = 0x121; break;
274 case ARM::BI__builtin_neon_vcntq_v: mask = 0x1210000; break;
275 case ARM::BI__builtin_neon_vcvt_f16_v: mask = 0x80; break;
276 case ARM::BI__builtin_neon_vcvt_f32_v: mask = 0x404; break;
277 case ARM::BI__builtin_neon_vcvtq_f32_v: mask = 0x4040000; break;
278 case ARM::BI__builtin_neon_vcvt_f32_f16: mask = 0x100000; break;
279 case ARM::BI__builtin_neon_vcvt_n_f32_v: mask = 0x404; break;
280 case ARM::BI__builtin_neon_vcvtq_n_f32_v: mask = 0x4040000; break;
281 case ARM::BI__builtin_neon_vcvt_n_s32_v: mask = 0x4; break;
282 case ARM::BI__builtin_neon_vcvtq_n_s32_v: mask = 0x40000; break;
283 case ARM::BI__builtin_neon_vcvt_n_u32_v: mask = 0x400; break;
284 case ARM::BI__builtin_neon_vcvtq_n_u32_v: mask = 0x4000000; break;
285 case ARM::BI__builtin_neon_vcvt_s32_v: mask = 0x4; break;
286 case ARM::BI__builtin_neon_vcvtq_s32_v: mask = 0x40000; break;
287 case ARM::BI__builtin_neon_vcvt_u32_v: mask = 0x400; break;
288 case ARM::BI__builtin_neon_vcvtq_u32_v: mask = 0x4000000; break;
289 case ARM::BI__builtin_neon_vext_v: mask = 0xF6F; break;
290 case ARM::BI__builtin_neon_vextq_v: mask = 0xF6F0000; break;
291 case ARM::BI__builtin_neon_vhadd_v: mask = 0x707; break;
292 case ARM::BI__builtin_neon_vhaddq_v: mask = 0x7070000; break;
293 case ARM::BI__builtin_neon_vhsub_v: mask = 0x707; break;
294 case ARM::BI__builtin_neon_vhsubq_v: mask = 0x7070000; break;
295 case ARM::BI__builtin_neon_vld1_v: mask = 0xFFF; break;
296 case ARM::BI__builtin_neon_vld1q_v: mask = 0xFFF0000; break;
297 case ARM::BI__builtin_neon_vld1_dup_v: mask = 0xFFF; break;
298 case ARM::BI__builtin_neon_vld1q_dup_v: mask = 0xFFF0000; break;
299 case ARM::BI__builtin_neon_vld1_lane_v: mask = 0xFFF; break;
300 case ARM::BI__builtin_neon_vld1q_lane_v: mask = 0xFFF0000; break;
301 case ARM::BI__builtin_neon_vld2_v: mask = 0xFFF; break;
302 case ARM::BI__builtin_neon_vld2q_v: mask = 0x7F70000; break;
303 case ARM::BI__builtin_neon_vld2_dup_v: mask = 0xFFF; break;
304 case ARM::BI__builtin_neon_vld2_lane_v: mask = 0x7F7; break;
305 case ARM::BI__builtin_neon_vld2q_lane_v: mask = 0x6D60000; break;
306 case ARM::BI__builtin_neon_vld3_v: mask = 0xFFF; break;
307 case ARM::BI__builtin_neon_vld3q_v: mask = 0x7F70000; break;
308 case ARM::BI__builtin_neon_vld3_dup_v: mask = 0xFFF; break;
309 case ARM::BI__builtin_neon_vld3_lane_v: mask = 0x7F7; break;
310 case ARM::BI__builtin_neon_vld3q_lane_v: mask = 0x6D60000; break;
311 case ARM::BI__builtin_neon_vld4_v: mask = 0xFFF; break;
312 case ARM::BI__builtin_neon_vld4q_v: mask = 0x7F70000; break;
313 case ARM::BI__builtin_neon_vld4_dup_v: mask = 0xFFF; break;
314 case ARM::BI__builtin_neon_vld4_lane_v: mask = 0x7F7; break;
315 case ARM::BI__builtin_neon_vld4q_lane_v: mask = 0x6D60000; break;
316 case ARM::BI__builtin_neon_vmax_v: mask = 0x717; break;
317 case ARM::BI__builtin_neon_vmaxq_v: mask = 0x7170000; break;
318 case ARM::BI__builtin_neon_vmin_v: mask = 0x717; break;
319 case ARM::BI__builtin_neon_vminq_v: mask = 0x7170000; break;
320 case ARM::BI__builtin_neon_vmlal_v: mask = 0xE0E0000; break;
321 case ARM::BI__builtin_neon_vmlal_lane_v: mask = 0xC0C0000; break;
322 case ARM::BI__builtin_neon_vmla_lane_v: mask = 0x616; break;
323 case ARM::BI__builtin_neon_vmlaq_lane_v: mask = 0x6160000; break;
324 case ARM::BI__builtin_neon_vmlsl_v: mask = 0xE0E0000; break;
325 case ARM::BI__builtin_neon_vmlsl_lane_v: mask = 0xC0C0000; break;
326 case ARM::BI__builtin_neon_vmls_lane_v: mask = 0x616; break;
327 case ARM::BI__builtin_neon_vmlsq_lane_v: mask = 0x6160000; break;
328 case ARM::BI__builtin_neon_vmovl_v: mask = 0xE0E0000; break;
329 case ARM::BI__builtin_neon_vmovn_v: mask = 0x707; break;
330 case ARM::BI__builtin_neon_vmull_v: mask = 0xE4E0000; break;
331 case ARM::BI__builtin_neon_vmull_lane_v: mask = 0xC0C0000; break;
332 case ARM::BI__builtin_neon_vpadal_v: mask = 0xE0E; break;
333 case ARM::BI__builtin_neon_vpadalq_v: mask = 0xE0E0000; break;
334 case ARM::BI__builtin_neon_vpadd_v: mask = 0x717; break;
335 case ARM::BI__builtin_neon_vpaddl_v: mask = 0xE0E; break;
336 case ARM::BI__builtin_neon_vpaddlq_v: mask = 0xE0E0000; break;
337 case ARM::BI__builtin_neon_vpmax_v: mask = 0x717; break;
338 case ARM::BI__builtin_neon_vpmin_v: mask = 0x717; break;
339 case ARM::BI__builtin_neon_vqabs_v: mask = 0x7; break;
340 case ARM::BI__builtin_neon_vqabsq_v: mask = 0x70000; break;
341 case ARM::BI__builtin_neon_vqadd_v: mask = 0xF0F; break;
342 case ARM::BI__builtin_neon_vqaddq_v: mask = 0xF0F0000; break;
343 case ARM::BI__builtin_neon_vqdmlal_v: mask = 0xC0000; break;
344 case ARM::BI__builtin_neon_vqdmlal_lane_v: mask = 0xC0000; break;
345 case ARM::BI__builtin_neon_vqdmlsl_v: mask = 0xC0000; break;
346 case ARM::BI__builtin_neon_vqdmlsl_lane_v: mask = 0xC0000; break;
347 case ARM::BI__builtin_neon_vqdmulh_v: mask = 0x6; break;
348 case ARM::BI__builtin_neon_vqdmulhq_v: mask = 0x60000; break;
349 case ARM::BI__builtin_neon_vqdmulh_lane_v: mask = 0x6; break;
350 case ARM::BI__builtin_neon_vqdmulhq_lane_v: mask = 0x60000; break;
351 case ARM::BI__builtin_neon_vqdmull_v: mask = 0xC0000; break;
352 case ARM::BI__builtin_neon_vqdmull_lane_v: mask = 0xC0000; break;
353 case ARM::BI__builtin_neon_vqmovn_v: mask = 0x707; break;
354 case ARM::BI__builtin_neon_vqmovun_v: mask = 0x700; break;
355 case ARM::BI__builtin_neon_vqneg_v: mask = 0x7; break;
356 case ARM::BI__builtin_neon_vqnegq_v: mask = 0x70000; break;
357 case ARM::BI__builtin_neon_vqrdmulh_v: mask = 0x6; break;
358 case ARM::BI__builtin_neon_vqrdmulhq_v: mask = 0x60000; break;
359 case ARM::BI__builtin_neon_vqrdmulh_lane_v: mask = 0x6; break;
360 case ARM::BI__builtin_neon_vqrdmulhq_lane_v: mask = 0x60000; break;
361 case ARM::BI__builtin_neon_vqrshl_v: mask = 0xF0F; break;
362 case ARM::BI__builtin_neon_vqrshlq_v: mask = 0xF0F0000; break;
363 case ARM::BI__builtin_neon_vqrshrn_n_v: mask = 0x707; break;
364 case ARM::BI__builtin_neon_vqrshrun_n_v: mask = 0x700; break;
365 case ARM::BI__builtin_neon_vqshl_v: mask = 0xF0F; break;
366 case ARM::BI__builtin_neon_vqshlq_v: mask = 0xF0F0000; break;
367 case ARM::BI__builtin_neon_vqshlu_n_v: mask = 0xF00; break;
368 case ARM::BI__builtin_neon_vqshluq_n_v: mask = 0xF000000; break;
369 case ARM::BI__builtin_neon_vqshl_n_v: mask = 0xF0F; break;
370 case ARM::BI__builtin_neon_vqshlq_n_v: mask = 0xF0F0000; break;
371 case ARM::BI__builtin_neon_vqshrn_n_v: mask = 0x707; break;
372 case ARM::BI__builtin_neon_vqshrun_n_v: mask = 0x700; break;
373 case ARM::BI__builtin_neon_vqsub_v: mask = 0xF0F; break;
374 case ARM::BI__builtin_neon_vqsubq_v: mask = 0xF0F0000; break;
375 case ARM::BI__builtin_neon_vraddhn_v: mask = 0x707; break;
376 case ARM::BI__builtin_neon_vrecpe_v: mask = 0x410; break;
377 case ARM::BI__builtin_neon_vrecpeq_v: mask = 0x4100000; break;
378 case ARM::BI__builtin_neon_vrecps_v: mask = 0x10; break;
379 case ARM::BI__builtin_neon_vrecpsq_v: mask = 0x100000; break;
380 case ARM::BI__builtin_neon_vrhadd_v: mask = 0x707; break;
381 case ARM::BI__builtin_neon_vrhaddq_v: mask = 0x7070000; break;
382 case ARM::BI__builtin_neon_vrshl_v: mask = 0xF0F; break;
383 case ARM::BI__builtin_neon_vrshlq_v: mask = 0xF0F0000; break;
384 case ARM::BI__builtin_neon_vrshrn_n_v: mask = 0x707; break;
385 case ARM::BI__builtin_neon_vrshr_n_v: mask = 0xF0F; break;
386 case ARM::BI__builtin_neon_vrshrq_n_v: mask = 0xF0F0000; break;
387 case ARM::BI__builtin_neon_vrsqrte_v: mask = 0x410; break;
388 case ARM::BI__builtin_neon_vrsqrteq_v: mask = 0x4100000; break;
389 case ARM::BI__builtin_neon_vrsqrts_v: mask = 0x10; break;
390 case ARM::BI__builtin_neon_vrsqrtsq_v: mask = 0x100000; break;
391 case ARM::BI__builtin_neon_vrsra_n_v: mask = 0xF0F; break;
392 case ARM::BI__builtin_neon_vrsraq_n_v: mask = 0xF0F0000; break;
393 case ARM::BI__builtin_neon_vrsubhn_v: mask = 0x707; break;
394 case ARM::BI__builtin_neon_vshl_v: mask = 0xF0F; break;
395 case ARM::BI__builtin_neon_vshlq_v: mask = 0xF0F0000; break;
396 case ARM::BI__builtin_neon_vshll_n_v: mask = 0xE0E0000; break;
397 case ARM::BI__builtin_neon_vshl_n_v: mask = 0xF0F; break;
398 case ARM::BI__builtin_neon_vshlq_n_v: mask = 0xF0F0000; break;
399 case ARM::BI__builtin_neon_vshrn_n_v: mask = 0x707; break;
400 case ARM::BI__builtin_neon_vshr_n_v: mask = 0xF0F; break;
401 case ARM::BI__builtin_neon_vshrq_n_v: mask = 0xF0F0000; break;
402 case ARM::BI__builtin_neon_vsli_n_v: mask = 0xF6F; break;
403 case ARM::BI__builtin_neon_vsliq_n_v: mask = 0xF6F0000; break;
404 case ARM::BI__builtin_neon_vsra_n_v: mask = 0xF0F; break;
405 case ARM::BI__builtin_neon_vsraq_n_v: mask = 0xF0F0000; break;
406 case ARM::BI__builtin_neon_vsri_n_v: mask = 0xF6F; break;
407 case ARM::BI__builtin_neon_vsriq_n_v: mask = 0xF6F0000; break;
408 case ARM::BI__builtin_neon_vst1_v: mask = 0x9F; break;
409 case ARM::BI__builtin_neon_vst1q_v: mask = 0x9F0000; break;
410 case ARM::BI__builtin_neon_vst1_lane_v: mask = 0x9F; break;
411 case ARM::BI__builtin_neon_vst1q_lane_v: mask = 0x9F0000; break;
412 case ARM::BI__builtin_neon_vst2_v: mask = 0x9F; break;
413 case ARM::BI__builtin_neon_vst2q_v: mask = 0x970000; break;
414 case ARM::BI__builtin_neon_vst2_lane_v: mask = 0x97; break;
415 case ARM::BI__builtin_neon_vst2q_lane_v: mask = 0x960000; break;
416 case ARM::BI__builtin_neon_vst3_v: mask = 0x9F; break;
417 case ARM::BI__builtin_neon_vst3q_v: mask = 0x970000; break;
418 case ARM::BI__builtin_neon_vst3_lane_v: mask = 0x97; break;
419 case ARM::BI__builtin_neon_vst3q_lane_v: mask = 0x960000; break;
420 case ARM::BI__builtin_neon_vst4_v: mask = 0x9F; break;
421 case ARM::BI__builtin_neon_vst4q_v: mask = 0x970000; break;
422 case ARM::BI__builtin_neon_vst4_lane_v: mask = 0x97; break;
423 case ARM::BI__builtin_neon_vst4q_lane_v: mask = 0x960000; break;
424 case ARM::BI__builtin_neon_vsubhn_v: mask = 0x707; break;
425 case ARM::BI__builtin_neon_vsubl_v: mask = 0xE0E0000; break;
426 case ARM::BI__builtin_neon_vsubw_v: mask = 0xE0E0000; break;
427 case ARM::BI__builtin_neon_vtbl1_v: mask = 0x121; break;
428 case ARM::BI__builtin_neon_vtbl2_v: mask = 0x121; break;
429 case ARM::BI__builtin_neon_vtbl3_v: mask = 0x121; break;
430 case ARM::BI__builtin_neon_vtbl4_v: mask = 0x121; break;
431 case ARM::BI__builtin_neon_vtbx1_v: mask = 0x121; break;
432 case ARM::BI__builtin_neon_vtbx2_v: mask = 0x121; break;
433 case ARM::BI__builtin_neon_vtbx3_v: mask = 0x121; break;
434 case ARM::BI__builtin_neon_vtbx4_v: mask = 0x121; break;
435 case ARM::BI__builtin_neon_vtrn_v: mask = 0x777; break;
436 case ARM::BI__builtin_neon_vtrnq_v: mask = 0x7770000; break;
437 case ARM::BI__builtin_neon_vtst_v: mask = 0x700; break;
438 case ARM::BI__builtin_neon_vtstq_v: mask = 0x7000000; break;
439 case ARM::BI__builtin_neon_vuzp_v: mask = 0x777; break;
440 case ARM::BI__builtin_neon_vuzpq_v: mask = 0x7770000; break;
441 case ARM::BI__builtin_neon_vzip_v: mask = 0x373; break;
442 case ARM::BI__builtin_neon_vzipq_v: mask = 0x7770000; break;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000443 }
444
Nate Begeman0d15c532010-06-13 04:47:52 +0000445 // For NEON intrinsics which are overloaded on vector element type, validate
446 // the immediate which specifies which variant to emit.
447 if (mask) {
448 unsigned ArgNo = TheCall->getNumArgs()-1;
449 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
450 return true;
451
452 unsigned Val = Result.getLimitedValue(32);
453 if ((Val > 31) || (mask & (1 << Val)) == 0)
454 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
455 << TheCall->getArg(ArgNo)->getSourceRange();
456 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000457
Nate Begeman0d15c532010-06-13 04:47:52 +0000458 // For NEON intrinsics which take an immediate value as part of the
459 // instruction, range check them here.
460 unsigned i = 0, upper = 0;
461 switch (BuiltinID) {
462 default: return false;
463 };
464
465 if (SemaBuiltinConstantArg(TheCall, i, Result))
466 return true;
467
468 unsigned Val = Result.getZExtValue();
469 if (Val > upper)
470 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
471 << "0" << llvm::utostr(upper) << TheCall->getArg(i)->getSourceRange();
472
Nate Begeman26a31422010-06-08 02:47:44 +0000473 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000474}
Daniel Dunbarde454282008-10-02 18:44:07 +0000475
Anders Carlssond406bf02009-08-16 01:56:34 +0000476/// CheckFunctionCall - Check a direct function call for various correctness
477/// and safety properties not strictly enforced by the C type system.
478bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
479 // Get the IdentifierInfo* for the called function.
480 IdentifierInfo *FnInfo = FDecl->getIdentifier();
481
482 // None of the checks below are needed for functions that don't have
483 // simple names (e.g., C++ conversion functions).
484 if (!FnInfo)
485 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000486
Daniel Dunbarde454282008-10-02 18:44:07 +0000487 // FIXME: This mechanism should be abstracted to be less fragile and
488 // more efficient. For example, just map function ids to custom
489 // handlers.
490
Chris Lattner59907c42007-08-10 20:18:51 +0000491 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000492 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000493 if (CheckablePrintfAttr(Format, TheCall)) {
Ted Kremenek3d692df2009-02-27 17:58:43 +0000494 bool HasVAListArg = Format->getFirstArg() == 0;
Douglas Gregor3c385e52009-02-14 18:57:46 +0000495 CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
Ted Kremenek3d692df2009-02-27 17:58:43 +0000496 HasVAListArg ? 0 : Format->getFirstArg() - 1);
Douglas Gregor3c385e52009-02-14 18:57:46 +0000497 }
Chris Lattner59907c42007-08-10 20:18:51 +0000498 }
Mike Stump1eb44332009-09-09 15:08:12 +0000499
500 for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull;
Anders Carlssond406bf02009-08-16 01:56:34 +0000501 NonNull = NonNull->getNext<NonNullAttr>())
502 CheckNonNullArguments(NonNull, TheCall);
Sebastian Redl0eb23302009-01-19 00:08:26 +0000503
Anders Carlssond406bf02009-08-16 01:56:34 +0000504 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000505}
506
Anders Carlssond406bf02009-08-16 01:56:34 +0000507bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000508 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000509 const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000510 if (!Format)
Anders Carlssond406bf02009-08-16 01:56:34 +0000511 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000512
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000513 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
514 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000515 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000516
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000517 QualType Ty = V->getType();
518 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000519 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000520
Anders Carlssond406bf02009-08-16 01:56:34 +0000521 if (!CheckablePrintfAttr(Format, TheCall))
522 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000523
Anders Carlssond406bf02009-08-16 01:56:34 +0000524 bool HasVAListArg = Format->getFirstArg() == 0;
Anders Carlssond406bf02009-08-16 01:56:34 +0000525 CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
526 HasVAListArg ? 0 : Format->getFirstArg() - 1);
527
528 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000529}
530
Chris Lattner5caa3702009-05-08 06:58:22 +0000531/// SemaBuiltinAtomicOverloaded - We have a call to a function like
532/// __sync_fetch_and_add, which is an overloaded function based on the pointer
533/// type of its first argument. The main ActOnCallExpr routines have already
534/// promoted the types of arguments because all of these calls are prototyped as
535/// void(...).
536///
537/// This function goes through and does final semantic checking for these
538/// builtins,
539bool Sema::SemaBuiltinAtomicOverloaded(CallExpr *TheCall) {
540 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
541 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
542
543 // Ensure that we have at least one argument to do type inference from.
544 if (TheCall->getNumArgs() < 1)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000545 return Diag(TheCall->getLocEnd(),
546 diag::err_typecheck_call_too_few_args_at_least)
547 << 0 << 1 << TheCall->getNumArgs()
548 << TheCall->getCallee()->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000549
Chris Lattner5caa3702009-05-08 06:58:22 +0000550 // Inspect the first argument of the atomic builtin. This should always be
551 // a pointer type, whose element is an integral scalar or pointer type.
552 // Because it is a pointer type, we don't have to worry about any implicit
553 // casts here.
554 Expr *FirstArg = TheCall->getArg(0);
555 if (!FirstArg->getType()->isPointerType())
556 return Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
557 << FirstArg->getType() << FirstArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000558
Ted Kremenek6217b802009-07-29 21:53:49 +0000559 QualType ValType = FirstArg->getType()->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000560 if (!ValType->isIntegerType() && !ValType->isPointerType() &&
Chris Lattner5caa3702009-05-08 06:58:22 +0000561 !ValType->isBlockPointerType())
562 return Diag(DRE->getLocStart(),
563 diag::err_atomic_builtin_must_be_pointer_intptr)
564 << FirstArg->getType() << FirstArg->getSourceRange();
565
566 // We need to figure out which concrete builtin this maps onto. For example,
567 // __sync_fetch_and_add with a 2 byte object turns into
568 // __sync_fetch_and_add_2.
569#define BUILTIN_ROW(x) \
570 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
571 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000572
Chris Lattner5caa3702009-05-08 06:58:22 +0000573 static const unsigned BuiltinIndices[][5] = {
574 BUILTIN_ROW(__sync_fetch_and_add),
575 BUILTIN_ROW(__sync_fetch_and_sub),
576 BUILTIN_ROW(__sync_fetch_and_or),
577 BUILTIN_ROW(__sync_fetch_and_and),
578 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000579
Chris Lattner5caa3702009-05-08 06:58:22 +0000580 BUILTIN_ROW(__sync_add_and_fetch),
581 BUILTIN_ROW(__sync_sub_and_fetch),
582 BUILTIN_ROW(__sync_and_and_fetch),
583 BUILTIN_ROW(__sync_or_and_fetch),
584 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000585
Chris Lattner5caa3702009-05-08 06:58:22 +0000586 BUILTIN_ROW(__sync_val_compare_and_swap),
587 BUILTIN_ROW(__sync_bool_compare_and_swap),
588 BUILTIN_ROW(__sync_lock_test_and_set),
589 BUILTIN_ROW(__sync_lock_release)
590 };
Mike Stump1eb44332009-09-09 15:08:12 +0000591#undef BUILTIN_ROW
592
Chris Lattner5caa3702009-05-08 06:58:22 +0000593 // Determine the index of the size.
594 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000595 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000596 case 1: SizeIndex = 0; break;
597 case 2: SizeIndex = 1; break;
598 case 4: SizeIndex = 2; break;
599 case 8: SizeIndex = 3; break;
600 case 16: SizeIndex = 4; break;
601 default:
602 return Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
603 << FirstArg->getType() << FirstArg->getSourceRange();
604 }
Mike Stump1eb44332009-09-09 15:08:12 +0000605
Chris Lattner5caa3702009-05-08 06:58:22 +0000606 // Each of these builtins has one pointer argument, followed by some number of
607 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
608 // that we ignore. Find out which row of BuiltinIndices to read from as well
609 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000610 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000611 unsigned BuiltinIndex, NumFixed = 1;
612 switch (BuiltinID) {
613 default: assert(0 && "Unknown overloaded atomic builtin!");
614 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
615 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
616 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
617 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
618 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000619
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000620 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
621 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
622 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
623 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
624 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000625
Chris Lattner5caa3702009-05-08 06:58:22 +0000626 case Builtin::BI__sync_val_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000627 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000628 NumFixed = 2;
629 break;
630 case Builtin::BI__sync_bool_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000631 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000632 NumFixed = 2;
633 break;
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000634 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000635 case Builtin::BI__sync_lock_release:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000636 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000637 NumFixed = 0;
638 break;
639 }
Mike Stump1eb44332009-09-09 15:08:12 +0000640
Chris Lattner5caa3702009-05-08 06:58:22 +0000641 // Now that we know how many fixed arguments we expect, first check that we
642 // have at least that many.
643 if (TheCall->getNumArgs() < 1+NumFixed)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000644 return Diag(TheCall->getLocEnd(),
645 diag::err_typecheck_call_too_few_args_at_least)
646 << 0 << 1+NumFixed << TheCall->getNumArgs()
647 << TheCall->getCallee()->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000648
649
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000650 // Get the decl for the concrete builtin from this, we can tell what the
651 // concrete integer type we should convert to is.
652 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
653 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
654 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000655 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000656 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
657 TUScope, false, DRE->getLocStart()));
658 const FunctionProtoType *BuiltinFT =
John McCall183700f2009-09-21 23:43:11 +0000659 NewBuiltinDecl->getType()->getAs<FunctionProtoType>();
Ted Kremenek6217b802009-07-29 21:53:49 +0000660 ValType = BuiltinFT->getArgType(0)->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000661
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000662 // If the first type needs to be converted (e.g. void** -> int*), do it now.
663 if (BuiltinFT->getArgType(0) != FirstArg->getType()) {
Eli Friedman73c39ab2009-10-20 08:27:19 +0000664 ImpCastExprToType(FirstArg, BuiltinFT->getArgType(0), CastExpr::CK_BitCast);
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000665 TheCall->setArg(0, FirstArg);
666 }
Mike Stump1eb44332009-09-09 15:08:12 +0000667
Chris Lattner5caa3702009-05-08 06:58:22 +0000668 // Next, walk the valid ones promoting to the right type.
669 for (unsigned i = 0; i != NumFixed; ++i) {
670 Expr *Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000671
Chris Lattner5caa3702009-05-08 06:58:22 +0000672 // If the argument is an implicit cast, then there was a promotion due to
673 // "...", just remove it now.
674 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
675 Arg = ICE->getSubExpr();
676 ICE->setSubExpr(0);
677 ICE->Destroy(Context);
678 TheCall->setArg(i+1, Arg);
679 }
Mike Stump1eb44332009-09-09 15:08:12 +0000680
Chris Lattner5caa3702009-05-08 06:58:22 +0000681 // GCC does an implicit conversion to the pointer or integer ValType. This
682 // can fail in some cases (1i -> int**), check for this error case now.
Anders Carlssoncdb61972009-08-07 22:21:05 +0000683 CastExpr::CastKind Kind = CastExpr::CK_Unknown;
Anders Carlsson5cf86ba2010-04-24 19:06:50 +0000684 CXXBaseSpecifierArray BasePath;
685 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
Chris Lattner5caa3702009-05-08 06:58:22 +0000686 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000687
Chris Lattner5caa3702009-05-08 06:58:22 +0000688 // Okay, we have something that *can* be converted to the right type. Check
689 // to see if there is a potentially weird extension going on here. This can
690 // happen when you do an atomic operation on something like an char* and
691 // pass in 42. The 42 gets converted to char. This is even more strange
692 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000693 // FIXME: Do this check.
Anders Carlsson80971bd2010-04-24 16:36:20 +0000694 ImpCastExprToType(Arg, ValType, Kind);
Chris Lattner5caa3702009-05-08 06:58:22 +0000695 TheCall->setArg(i+1, Arg);
696 }
Mike Stump1eb44332009-09-09 15:08:12 +0000697
Chris Lattner5caa3702009-05-08 06:58:22 +0000698 // Switch the DeclRefExpr to refer to the new decl.
699 DRE->setDecl(NewBuiltinDecl);
700 DRE->setType(NewBuiltinDecl->getType());
Mike Stump1eb44332009-09-09 15:08:12 +0000701
Chris Lattner5caa3702009-05-08 06:58:22 +0000702 // Set the callee in the CallExpr.
703 // FIXME: This leaks the original parens and implicit casts.
704 Expr *PromotedCall = DRE;
705 UsualUnaryConversions(PromotedCall);
706 TheCall->setCallee(PromotedCall);
Mike Stump1eb44332009-09-09 15:08:12 +0000707
Chris Lattner5caa3702009-05-08 06:58:22 +0000708
709 // Change the result type of the call to match the result type of the decl.
710 TheCall->setType(NewBuiltinDecl->getResultType());
711 return false;
712}
713
714
Chris Lattner69039812009-02-18 06:01:06 +0000715/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +0000716/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +0000717/// FIXME: GCC currently emits the following warning:
Mike Stump1eb44332009-09-09 15:08:12 +0000718/// "warning: input conversion stopped due to an input byte that does not
Steve Narofffd942622009-04-13 20:26:29 +0000719/// belong to the input codeset UTF-8"
720/// Note: It might also make sense to do the UTF-16 conversion here (would
721/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +0000722bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +0000723 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +0000724 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
725
726 if (!Literal || Literal->isWide()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000727 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
728 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000729 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000730 }
Mike Stump1eb44332009-09-09 15:08:12 +0000731
Daniel Dunbarf015b032009-09-22 10:03:52 +0000732 const char *Data = Literal->getStrData();
733 unsigned Length = Literal->getByteLength();
Mike Stump1eb44332009-09-09 15:08:12 +0000734
Daniel Dunbarf015b032009-09-22 10:03:52 +0000735 for (unsigned i = 0; i < Length; ++i) {
736 if (!Data[i]) {
737 Diag(getLocationOfStringLiteralByte(Literal, i),
738 diag::warn_cfstring_literal_contains_nul_character)
739 << Arg->getSourceRange();
740 break;
741 }
742 }
Mike Stump1eb44332009-09-09 15:08:12 +0000743
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000744 return false;
Chris Lattner59907c42007-08-10 20:18:51 +0000745}
746
Chris Lattnerc27c6652007-12-20 00:05:45 +0000747/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
748/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +0000749bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
750 Expr *Fn = TheCall->getCallee();
751 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +0000752 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000753 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000754 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
755 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +0000756 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000757 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +0000758 return true;
759 }
Eli Friedman56f20ae2008-12-15 22:05:35 +0000760
761 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +0000762 return Diag(TheCall->getLocEnd(),
763 diag::err_typecheck_call_too_few_args_at_least)
764 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +0000765 }
766
Chris Lattnerc27c6652007-12-20 00:05:45 +0000767 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000768 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +0000769 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000770 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +0000771 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +0000772 else if (FunctionDecl *FD = getCurFunctionDecl())
773 isVariadic = FD->isVariadic();
774 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000775 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +0000776
Chris Lattnerc27c6652007-12-20 00:05:45 +0000777 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000778 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
779 return true;
780 }
Mike Stump1eb44332009-09-09 15:08:12 +0000781
Chris Lattner30ce3442007-12-19 23:59:04 +0000782 // Verify that the second argument to the builtin is the last argument of the
783 // current function or method.
784 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +0000785 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000786
Anders Carlsson88cf2262008-02-11 04:20:54 +0000787 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
788 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000789 // FIXME: This isn't correct for methods (results in bogus warning).
790 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +0000791 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000792 if (CurBlock)
793 LastArg = *(CurBlock->TheDecl->param_end()-1);
794 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +0000795 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000796 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000797 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000798 SecondArgIsLastNamedArgument = PV == LastArg;
799 }
800 }
Mike Stump1eb44332009-09-09 15:08:12 +0000801
Chris Lattner30ce3442007-12-19 23:59:04 +0000802 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +0000803 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +0000804 diag::warn_second_parameter_of_va_start_not_last_named_argument);
805 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +0000806}
Chris Lattner30ce3442007-12-19 23:59:04 +0000807
Chris Lattner1b9a0792007-12-20 00:26:33 +0000808/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
809/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +0000810bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
811 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +0000812 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000813 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +0000814 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +0000815 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000816 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000817 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000818 << SourceRange(TheCall->getArg(2)->getLocStart(),
819 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000820
Chris Lattner925e60d2007-12-28 05:29:59 +0000821 Expr *OrigArg0 = TheCall->getArg(0);
822 Expr *OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +0000823
Chris Lattner1b9a0792007-12-20 00:26:33 +0000824 // Do standard promotions between the two arguments, returning their common
825 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +0000826 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
Daniel Dunbar403bc2b2009-02-19 19:28:43 +0000827
828 // Make sure any conversions are pushed back into the call; this is
829 // type safe since unordered compare builtins are declared as "_Bool
830 // foo(...)".
831 TheCall->setArg(0, OrigArg0);
832 TheCall->setArg(1, OrigArg1);
Mike Stump1eb44332009-09-09 15:08:12 +0000833
Douglas Gregorcde01732009-05-19 22:10:17 +0000834 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
835 return false;
836
Chris Lattner1b9a0792007-12-20 00:26:33 +0000837 // If the common type isn't a real floating type, then the arguments were
838 // invalid for this operation.
839 if (!Res->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000840 return Diag(OrigArg0->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000841 diag::err_typecheck_call_invalid_ordered_compare)
Chris Lattnerd1625842008-11-24 06:25:27 +0000842 << OrigArg0->getType() << OrigArg1->getType()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000843 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000844
Chris Lattner1b9a0792007-12-20 00:26:33 +0000845 return false;
846}
847
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000848/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
849/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000850/// to check everything. We expect the last argument to be a floating point
851/// value.
852bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
853 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +0000854 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000855 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000856 if (TheCall->getNumArgs() > NumArgs)
857 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000858 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000859 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000860 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000861 (*(TheCall->arg_end()-1))->getLocEnd());
862
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000863 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +0000864
Eli Friedman9ac6f622009-08-31 20:06:00 +0000865 if (OrigArg->isTypeDependent())
866 return false;
867
Chris Lattner81368fb2010-05-06 05:50:07 +0000868 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +0000869 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000870 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000871 diag::err_typecheck_call_invalid_unary_fp)
872 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000873
Chris Lattner81368fb2010-05-06 05:50:07 +0000874 // If this is an implicit conversion from float -> double, remove it.
875 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
876 Expr *CastArg = Cast->getSubExpr();
877 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
878 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
879 "promotion from float to double is the only expected cast here");
880 Cast->setSubExpr(0);
881 Cast->Destroy(Context);
882 TheCall->setArg(NumArgs-1, CastArg);
883 OrigArg = CastArg;
884 }
885 }
886
Eli Friedman9ac6f622009-08-31 20:06:00 +0000887 return false;
888}
889
Eli Friedmand38617c2008-05-14 19:38:39 +0000890/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
891// This is declared to take (...), so we have to check everything.
Sebastian Redl0eb23302009-01-19 00:08:26 +0000892Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000893 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000894 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +0000895 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +0000896 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +0000897 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000898
Nate Begeman37b6a572010-06-08 00:16:34 +0000899 // Determine which of the following types of shufflevector we're checking:
900 // 1) unary, vector mask: (lhs, mask)
901 // 2) binary, vector mask: (lhs, rhs, mask)
902 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
903 QualType resType = TheCall->getArg(0)->getType();
904 unsigned numElements = 0;
905
Douglas Gregorcde01732009-05-19 22:10:17 +0000906 if (!TheCall->getArg(0)->isTypeDependent() &&
907 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000908 QualType LHSType = TheCall->getArg(0)->getType();
909 QualType RHSType = TheCall->getArg(1)->getType();
910
911 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000912 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000913 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000914 TheCall->getArg(1)->getLocEnd());
915 return ExprError();
916 }
Nate Begeman37b6a572010-06-08 00:16:34 +0000917
918 numElements = LHSType->getAs<VectorType>()->getNumElements();
919 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +0000920
Nate Begeman37b6a572010-06-08 00:16:34 +0000921 // Check to see if we have a call with 2 vector arguments, the unary shuffle
922 // with mask. If so, verify that RHS is an integer vector type with the
923 // same number of elts as lhs.
924 if (TheCall->getNumArgs() == 2) {
925 if (!RHSType->isIntegerType() ||
926 RHSType->getAs<VectorType>()->getNumElements() != numElements)
927 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
928 << SourceRange(TheCall->getArg(1)->getLocStart(),
929 TheCall->getArg(1)->getLocEnd());
930 numResElements = numElements;
931 }
932 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000933 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000934 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000935 TheCall->getArg(1)->getLocEnd());
936 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +0000937 } else if (numElements != numResElements) {
938 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
939 resType = Context.getVectorType(eltType, numResElements, false, false);
Douglas Gregorcde01732009-05-19 22:10:17 +0000940 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000941 }
942
943 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000944 if (TheCall->getArg(i)->isTypeDependent() ||
945 TheCall->getArg(i)->isValueDependent())
946 continue;
947
Nate Begeman37b6a572010-06-08 00:16:34 +0000948 llvm::APSInt Result(32);
949 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
950 return ExprError(Diag(TheCall->getLocStart(),
951 diag::err_shufflevector_nonconstant_argument)
952 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +0000953
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000954 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000955 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000956 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000957 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000958 }
959
960 llvm::SmallVector<Expr*, 32> exprs;
961
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000962 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +0000963 exprs.push_back(TheCall->getArg(i));
964 TheCall->setArg(i, 0);
965 }
966
Nate Begemana88dc302009-08-12 02:10:25 +0000967 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +0000968 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +0000969 TheCall->getCallee()->getLocStart(),
970 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +0000971}
Chris Lattner30ce3442007-12-19 23:59:04 +0000972
Daniel Dunbar4493f792008-07-21 22:59:13 +0000973/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
974// This is declared to take (const void*, ...) and can take two
975// optional constant int args.
976bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000977 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000978
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000979 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +0000980 return Diag(TheCall->getLocEnd(),
981 diag::err_typecheck_call_too_many_args_at_most)
982 << 0 /*function call*/ << 3 << NumArgs
983 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000984
985 // Argument 0 is checked for us and the remaining arguments must be
986 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000987 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +0000988 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +0000989
Eli Friedman9aef7262009-12-04 00:30:06 +0000990 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +0000991 if (SemaBuiltinConstantArg(TheCall, i, Result))
992 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000993
Daniel Dunbar4493f792008-07-21 22:59:13 +0000994 // FIXME: gcc issues a warning and rewrites these to 0. These
995 // seems especially odd for the third argument since the default
996 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000997 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +0000998 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000999 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001000 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001001 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +00001002 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001003 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001004 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001005 }
1006 }
1007
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001008 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +00001009}
1010
Eric Christopher691ebc32010-04-17 02:26:23 +00001011/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1012/// TheCall is a constant expression.
1013bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1014 llvm::APSInt &Result) {
1015 Expr *Arg = TheCall->getArg(ArgNum);
1016 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1017 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1018
1019 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1020
1021 if (!Arg->isIntegerConstantExpr(Result, Context))
1022 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +00001023 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +00001024
Chris Lattner21fb98e2009-09-23 06:06:36 +00001025 return false;
1026}
1027
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001028/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1029/// int type). This simply type checks that type is one of the defined
1030/// constants (0-3).
Eric Christopherfee667f2009-12-23 03:49:37 +00001031// For compatability check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001032bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +00001033 llvm::APSInt Result;
1034
1035 // Check constant-ness first.
1036 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1037 return true;
1038
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001039 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001040 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001041 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1042 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001043 }
1044
1045 return false;
1046}
1047
Eli Friedman586d6a82009-05-03 06:04:26 +00001048/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +00001049/// This checks that val is a constant 1.
1050bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1051 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +00001052 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +00001053
Eric Christopher691ebc32010-04-17 02:26:23 +00001054 // TODO: This is less than ideal. Overload this to take a value.
1055 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1056 return true;
1057
1058 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +00001059 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1060 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1061
1062 return false;
1063}
1064
Ted Kremenekd30ef872009-01-12 23:09:09 +00001065// Handle i > 1 ? "x" : "y", recursivelly
Ted Kremenek082d9362009-03-20 21:35:28 +00001066bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
1067 bool HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001068 unsigned format_idx, unsigned firstDataArg) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001069 if (E->isTypeDependent() || E->isValueDependent())
1070 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001071
1072 switch (E->getStmtClass()) {
1073 case Stmt::ConditionalOperatorClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +00001074 const ConditionalOperator *C = cast<ConditionalOperator>(E);
Chris Lattner813b70d2009-12-22 06:00:13 +00001075 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001076 HasVAListArg, format_idx, firstDataArg)
Ted Kremenekd30ef872009-01-12 23:09:09 +00001077 && SemaCheckStringLiteral(C->getRHS(), TheCall,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001078 HasVAListArg, format_idx, firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001079 }
1080
1081 case Stmt::ImplicitCastExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +00001082 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001083 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001084 format_idx, firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001085 }
1086
1087 case Stmt::ParenExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +00001088 const ParenExpr *Expr = cast<ParenExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001089 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001090 format_idx, firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001091 }
Mike Stump1eb44332009-09-09 15:08:12 +00001092
Ted Kremenek082d9362009-03-20 21:35:28 +00001093 case Stmt::DeclRefExprClass: {
1094 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001095
Ted Kremenek082d9362009-03-20 21:35:28 +00001096 // As an exception, do not flag errors for variables binding to
1097 // const string literals.
1098 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1099 bool isConstant = false;
1100 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001101
Ted Kremenek082d9362009-03-20 21:35:28 +00001102 if (const ArrayType *AT = Context.getAsArrayType(T)) {
1103 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001104 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +00001105 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +00001106 PT->getPointeeType().isConstant(Context);
1107 }
Mike Stump1eb44332009-09-09 15:08:12 +00001108
Ted Kremenek082d9362009-03-20 21:35:28 +00001109 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +00001110 if (const Expr *Init = VD->getAnyInitializer())
Ted Kremenek082d9362009-03-20 21:35:28 +00001111 return SemaCheckStringLiteral(Init, TheCall,
1112 HasVAListArg, format_idx, firstDataArg);
1113 }
Mike Stump1eb44332009-09-09 15:08:12 +00001114
Anders Carlssond966a552009-06-28 19:55:58 +00001115 // For vprintf* functions (i.e., HasVAListArg==true), we add a
1116 // special check to see if the format string is a function parameter
1117 // of the function calling the printf function. If the function
1118 // has an attribute indicating it is a printf-like function, then we
1119 // should suppress warnings concerning non-literals being used in a call
1120 // to a vprintf function. For example:
1121 //
1122 // void
1123 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1124 // va_list ap;
1125 // va_start(ap, fmt);
1126 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
1127 // ...
1128 //
1129 //
1130 // FIXME: We don't have full attribute support yet, so just check to see
1131 // if the argument is a DeclRefExpr that references a parameter. We'll
1132 // add proper support for checking the attribute later.
1133 if (HasVAListArg)
1134 if (isa<ParmVarDecl>(VD))
1135 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +00001136 }
Mike Stump1eb44332009-09-09 15:08:12 +00001137
Ted Kremenek082d9362009-03-20 21:35:28 +00001138 return false;
1139 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001140
Anders Carlsson8f031b32009-06-27 04:05:33 +00001141 case Stmt::CallExprClass: {
1142 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001143 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +00001144 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
1145 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
1146 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +00001147 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001148 unsigned ArgIndex = FA->getFormatIdx();
1149 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001150
1151 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
Anders Carlsson8f031b32009-06-27 04:05:33 +00001152 format_idx, firstDataArg);
1153 }
1154 }
1155 }
1156 }
Mike Stump1eb44332009-09-09 15:08:12 +00001157
Anders Carlsson8f031b32009-06-27 04:05:33 +00001158 return false;
1159 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001160 case Stmt::ObjCStringLiteralClass:
1161 case Stmt::StringLiteralClass: {
1162 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001163
Ted Kremenek082d9362009-03-20 21:35:28 +00001164 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001165 StrE = ObjCFExpr->getString();
1166 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001167 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001168
Ted Kremenekd30ef872009-01-12 23:09:09 +00001169 if (StrE) {
Mike Stump1eb44332009-09-09 15:08:12 +00001170 CheckPrintfString(StrE, E, TheCall, HasVAListArg, format_idx,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001171 firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001172 return true;
1173 }
Mike Stump1eb44332009-09-09 15:08:12 +00001174
Ted Kremenekd30ef872009-01-12 23:09:09 +00001175 return false;
1176 }
Mike Stump1eb44332009-09-09 15:08:12 +00001177
Ted Kremenek082d9362009-03-20 21:35:28 +00001178 default:
1179 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001180 }
1181}
1182
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001183void
Mike Stump1eb44332009-09-09 15:08:12 +00001184Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
1185 const CallExpr *TheCall) {
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001186 for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end();
1187 i != e; ++i) {
Chris Lattner12b97ff2009-05-25 18:23:36 +00001188 const Expr *ArgExpr = TheCall->getArg(*i);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001189 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001190 Expr::NPC_ValueDependentIsNotNull))
Chris Lattner12b97ff2009-05-25 18:23:36 +00001191 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
1192 << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001193 }
1194}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001195
Chris Lattner59907c42007-08-10 20:18:51 +00001196/// CheckPrintfArguments - Check calls to printf (and similar functions) for
Mike Stump1eb44332009-09-09 15:08:12 +00001197/// correct use of format strings.
Ted Kremenek71895b92007-08-14 17:39:48 +00001198///
1199/// HasVAListArg - A predicate indicating whether the printf-like
1200/// function is passed an explicit va_arg argument (e.g., vprintf)
1201///
1202/// format_idx - The index into Args for the format string.
1203///
1204/// Improper format strings to functions in the printf family can be
1205/// the source of bizarre bugs and very serious security holes. A
1206/// good source of information is available in the following paper
1207/// (which includes additional references):
Chris Lattner59907c42007-08-10 20:18:51 +00001208///
1209/// FormatGuard: Automatic Protection From printf Format String
1210/// Vulnerabilities, Proceedings of the 10th USENIX Security Symposium, 2001.
Ted Kremenek71895b92007-08-14 17:39:48 +00001211///
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001212/// TODO:
Ted Kremenek71895b92007-08-14 17:39:48 +00001213/// Functionality implemented:
1214///
1215/// We can statically check the following properties for string
1216/// literal format strings for non v.*printf functions (where the
1217/// arguments are passed directly):
1218//
1219/// (1) Are the number of format conversions equal to the number of
1220/// data arguments?
1221///
1222/// (2) Does each format conversion correctly match the type of the
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001223/// corresponding data argument?
Ted Kremenek71895b92007-08-14 17:39:48 +00001224///
1225/// Moreover, for all printf functions we can:
1226///
1227/// (3) Check for a missing format string (when not caught by type checking).
1228///
1229/// (4) Check for no-operation flags; e.g. using "#" with format
1230/// conversion 'c' (TODO)
1231///
1232/// (5) Check the use of '%n', a major source of security holes.
1233///
1234/// (6) Check for malformed format conversions that don't specify anything.
1235///
1236/// (7) Check for empty format strings. e.g: printf("");
1237///
1238/// (8) Check that the format string is a wide literal.
1239///
1240/// All of these checks can be done by parsing the format string.
1241///
Chris Lattner59907c42007-08-10 20:18:51 +00001242void
Mike Stump1eb44332009-09-09 15:08:12 +00001243Sema::CheckPrintfArguments(const CallExpr *TheCall, bool HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001244 unsigned format_idx, unsigned firstDataArg) {
Ted Kremenek082d9362009-03-20 21:35:28 +00001245 const Expr *Fn = TheCall->getCallee();
Chris Lattner925e60d2007-12-28 05:29:59 +00001246
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001247 // The way the format attribute works in GCC, the implicit this argument
1248 // of member functions is counted. However, it doesn't appear in our own
1249 // lists, so decrement format_idx in that case.
1250 if (isa<CXXMemberCallExpr>(TheCall)) {
1251 // Catch a format attribute mistakenly referring to the object argument.
1252 if (format_idx == 0)
1253 return;
1254 --format_idx;
1255 if(firstDataArg != 0)
1256 --firstDataArg;
1257 }
1258
Mike Stump1eb44332009-09-09 15:08:12 +00001259 // CHECK: printf-like function is called with no format string.
Chris Lattner925e60d2007-12-28 05:29:59 +00001260 if (format_idx >= TheCall->getNumArgs()) {
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001261 Diag(TheCall->getRParenLoc(), diag::warn_printf_missing_format_string)
1262 << Fn->getSourceRange();
Ted Kremenek71895b92007-08-14 17:39:48 +00001263 return;
1264 }
Mike Stump1eb44332009-09-09 15:08:12 +00001265
Ted Kremenek082d9362009-03-20 21:35:28 +00001266 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001267
Chris Lattner59907c42007-08-10 20:18:51 +00001268 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001269 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001270 // Dynamically generated format strings are difficult to
1271 // automatically vet at compile time. Requiring that format strings
1272 // are string literals: (1) permits the checking of format strings by
1273 // the compiler and thereby (2) can practically remove the source of
1274 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001275
Mike Stump1eb44332009-09-09 15:08:12 +00001276 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001277 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001278 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001279 // the same format string checking logic for both ObjC and C strings.
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001280 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
1281 firstDataArg))
1282 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001283
Chris Lattner655f1412009-04-29 04:59:47 +00001284 // If there are no arguments specified, warn with -Wformat-security, otherwise
1285 // warn only with -Wformat-nonliteral.
1286 if (TheCall->getNumArgs() == format_idx+1)
Mike Stump1eb44332009-09-09 15:08:12 +00001287 Diag(TheCall->getArg(format_idx)->getLocStart(),
Chris Lattner655f1412009-04-29 04:59:47 +00001288 diag::warn_printf_nonliteral_noargs)
1289 << OrigFormatExpr->getSourceRange();
1290 else
Mike Stump1eb44332009-09-09 15:08:12 +00001291 Diag(TheCall->getArg(format_idx)->getLocStart(),
Chris Lattner655f1412009-04-29 04:59:47 +00001292 diag::warn_printf_nonliteral)
1293 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001294}
Ted Kremenek71895b92007-08-14 17:39:48 +00001295
Ted Kremeneke0e53132010-01-28 23:39:18 +00001296namespace {
Ted Kremenek74d56a12010-02-04 20:46:58 +00001297class CheckPrintfHandler : public analyze_printf::FormatStringHandler {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001298 Sema &S;
1299 const StringLiteral *FExpr;
1300 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001301 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001302 const unsigned NumDataArgs;
1303 const bool IsObjCLiteral;
1304 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001305 const bool HasVAListArg;
1306 const CallExpr *TheCall;
1307 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001308 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001309 bool usesPositionalArgs;
1310 bool atFirstArg;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001311public:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001312 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001313 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001314 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001315 const char *beg, bool hasVAListArg,
1316 const CallExpr *theCall, unsigned formatIdx)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001317 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001318 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001319 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001320 IsObjCLiteral(isObjCLiteral), Beg(beg),
1321 HasVAListArg(hasVAListArg),
Ted Kremenekefaff192010-02-27 01:41:03 +00001322 TheCall(theCall), FormatIdx(formatIdx),
1323 usesPositionalArgs(false), atFirstArg(true) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001324 CoveredArgs.resize(numDataArgs);
1325 CoveredArgs.reset();
1326 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001327
Ted Kremenek07d161f2010-01-29 01:50:07 +00001328 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001329
Ted Kremenek808015a2010-01-29 03:16:21 +00001330 void HandleIncompleteFormatSpecifier(const char *startSpecifier,
1331 unsigned specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001332
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001333 bool
Ted Kremenek74d56a12010-02-04 20:46:58 +00001334 HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS,
1335 const char *startSpecifier,
1336 unsigned specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001337
Ted Kremenekefaff192010-02-27 01:41:03 +00001338 virtual void HandleInvalidPosition(const char *startSpecifier,
1339 unsigned specifierLen,
1340 analyze_printf::PositionContext p);
1341
1342 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1343
Ted Kremeneke0e53132010-01-28 23:39:18 +00001344 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001345
Ted Kremeneke0e53132010-01-28 23:39:18 +00001346 bool HandleFormatSpecifier(const analyze_printf::FormatSpecifier &FS,
1347 const char *startSpecifier,
1348 unsigned specifierLen);
1349private:
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001350 SourceRange getFormatStringRange();
1351 SourceRange getFormatSpecifierRange(const char *startSpecifier,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001352 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001353 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001354
Ted Kremenekefaff192010-02-27 01:41:03 +00001355 bool HandleAmount(const analyze_printf::OptionalAmount &Amt, unsigned k,
1356 const char *startSpecifier, unsigned specifierLen);
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001357 void HandleFlags(const analyze_printf::FormatSpecifier &FS,
1358 llvm::StringRef flag, llvm::StringRef cspec,
1359 const char *startSpecifier, unsigned specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001360
Ted Kremenek0d277352010-01-29 01:06:55 +00001361 const Expr *getDataArg(unsigned i) const;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001362};
1363}
1364
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001365SourceRange CheckPrintfHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001366 return OrigFormatExpr->getSourceRange();
1367}
1368
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001369SourceRange CheckPrintfHandler::
1370getFormatSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
1371 return SourceRange(getLocationOfByte(startSpecifier),
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001372 getLocationOfByte(startSpecifier+specifierLen-1));
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001373}
1374
Ted Kremeneke0e53132010-01-28 23:39:18 +00001375SourceLocation CheckPrintfHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001376 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001377}
1378
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001379void CheckPrintfHandler::
Ted Kremenek808015a2010-01-29 03:16:21 +00001380HandleIncompleteFormatSpecifier(const char *startSpecifier,
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001381 unsigned specifierLen) {
Ted Kremenek808015a2010-01-29 03:16:21 +00001382 SourceLocation Loc = getLocationOfByte(startSpecifier);
1383 S.Diag(Loc, diag::warn_printf_incomplete_specifier)
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001384 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek808015a2010-01-29 03:16:21 +00001385}
1386
Ted Kremenekefaff192010-02-27 01:41:03 +00001387void
1388CheckPrintfHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1389 analyze_printf::PositionContext p) {
1390 SourceLocation Loc = getLocationOfByte(startPos);
1391 S.Diag(Loc, diag::warn_printf_invalid_positional_specifier)
1392 << (unsigned) p << getFormatSpecifierRange(startPos, posLen);
1393}
1394
1395void CheckPrintfHandler::HandleZeroPosition(const char *startPos,
1396 unsigned posLen) {
1397 SourceLocation Loc = getLocationOfByte(startPos);
1398 S.Diag(Loc, diag::warn_printf_zero_positional_specifier)
1399 << getFormatSpecifierRange(startPos, posLen);
1400}
1401
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001402bool CheckPrintfHandler::
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001403HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS,
1404 const char *startSpecifier,
1405 unsigned specifierLen) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001406
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001407 unsigned argIndex = FS.getArgIndex();
1408 bool keepGoing = true;
1409 if (argIndex < NumDataArgs) {
1410 // Consider the argument coverered, even though the specifier doesn't
1411 // make sense.
1412 CoveredArgs.set(argIndex);
1413 }
1414 else {
1415 // If argIndex exceeds the number of data arguments we
1416 // don't issue a warning because that is just a cascade of warnings (and
1417 // they may have intended '%%' anyway). We don't want to continue processing
1418 // the format string after this point, however, as we will like just get
1419 // gibberish when trying to match arguments.
1420 keepGoing = false;
1421 }
1422
Ted Kremenek808015a2010-01-29 03:16:21 +00001423 const analyze_printf::ConversionSpecifier &CS =
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001424 FS.getConversionSpecifier();
Ted Kremenek808015a2010-01-29 03:16:21 +00001425 SourceLocation Loc = getLocationOfByte(CS.getStart());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001426 S.Diag(Loc, diag::warn_printf_invalid_conversion)
Ted Kremenek808015a2010-01-29 03:16:21 +00001427 << llvm::StringRef(CS.getStart(), CS.getLength())
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001428 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001429
1430 return keepGoing;
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001431}
1432
Ted Kremeneke0e53132010-01-28 23:39:18 +00001433void CheckPrintfHandler::HandleNullChar(const char *nullCharacter) {
1434 // The presence of a null character is likely an error.
1435 S.Diag(getLocationOfByte(nullCharacter),
1436 diag::warn_printf_format_string_contains_null_char)
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001437 << getFormatStringRange();
Ted Kremeneke0e53132010-01-28 23:39:18 +00001438}
1439
Ted Kremenek0d277352010-01-29 01:06:55 +00001440const Expr *CheckPrintfHandler::getDataArg(unsigned i) const {
Ted Kremenek6ee76532010-03-25 03:59:12 +00001441 return TheCall->getArg(FirstDataArg + i);
Ted Kremenek0d277352010-01-29 01:06:55 +00001442}
1443
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001444void CheckPrintfHandler::HandleFlags(const analyze_printf::FormatSpecifier &FS,
1445 llvm::StringRef flag,
1446 llvm::StringRef cspec,
1447 const char *startSpecifier,
1448 unsigned specifierLen) {
1449 const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier();
1450 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_nonsensical_flag)
1451 << flag << cspec << getFormatSpecifierRange(startSpecifier, specifierLen);
1452}
1453
Ted Kremenek0d277352010-01-29 01:06:55 +00001454bool
1455CheckPrintfHandler::HandleAmount(const analyze_printf::OptionalAmount &Amt,
Ted Kremenekefaff192010-02-27 01:41:03 +00001456 unsigned k, const char *startSpecifier,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001457 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001458
1459 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001460 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001461 unsigned argIndex = Amt.getArgIndex();
1462 if (argIndex >= NumDataArgs) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001463 S.Diag(getLocationOfByte(Amt.getStart()),
1464 diag::warn_printf_asterisk_missing_arg)
1465 << k << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001466 // Don't do any more checking. We will just emit
1467 // spurious errors.
1468 return false;
1469 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001470
Ted Kremenek0d277352010-01-29 01:06:55 +00001471 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001472 // Although not in conformance with C99, we also allow the argument to be
1473 // an 'unsigned int' as that is a reasonably safe case. GCC also
1474 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001475 CoveredArgs.set(argIndex);
1476 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001477 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001478
1479 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1480 assert(ATR.isValid());
1481
1482 if (!ATR.matchesType(S.Context, T)) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001483 S.Diag(getLocationOfByte(Amt.getStart()),
1484 diag::warn_printf_asterisk_wrong_type)
1485 << k
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001486 << ATR.getRepresentativeType(S.Context) << T
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001487 << getFormatSpecifierRange(startSpecifier, specifierLen)
1488 << Arg->getSourceRange();
Ted Kremenek0d277352010-01-29 01:06:55 +00001489 // Don't do any more checking. We will just emit
1490 // spurious errors.
1491 return false;
1492 }
1493 }
1494 }
1495 return true;
1496}
Ted Kremenek0d277352010-01-29 01:06:55 +00001497
Ted Kremeneke0e53132010-01-28 23:39:18 +00001498bool
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001499CheckPrintfHandler::HandleFormatSpecifier(const analyze_printf::FormatSpecifier
1500 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001501 const char *startSpecifier,
1502 unsigned specifierLen) {
1503
Ted Kremenekefaff192010-02-27 01:41:03 +00001504 using namespace analyze_printf;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001505 const ConversionSpecifier &CS = FS.getConversionSpecifier();
1506
Ted Kremenekefaff192010-02-27 01:41:03 +00001507 if (atFirstArg) {
1508 atFirstArg = false;
1509 usesPositionalArgs = FS.usesPositionalArg();
1510 }
1511 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1512 // Cannot mix-and-match positional and non-positional arguments.
1513 S.Diag(getLocationOfByte(CS.getStart()),
1514 diag::warn_printf_mix_positional_nonpositional_args)
1515 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001516 return false;
1517 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001518
Ted Kremenekefaff192010-02-27 01:41:03 +00001519 // First check if the field width, precision, and conversion specifier
1520 // have matching data arguments.
1521 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
1522 startSpecifier, specifierLen)) {
1523 return false;
1524 }
1525
1526 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
1527 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001528 return false;
1529 }
1530
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001531 if (!CS.consumesDataArgument()) {
1532 // FIXME: Technically specifying a precision or field width here
1533 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001534 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001535 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001536
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001537 // Consume the argument.
1538 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00001539 if (argIndex < NumDataArgs) {
1540 // The check to see if the argIndex is valid will come later.
1541 // We set the bit here because we may exit early from this
1542 // function if we encounter some other error.
1543 CoveredArgs.set(argIndex);
1544 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001545
1546 // Check for using an Objective-C specific conversion specifier
1547 // in a non-ObjC literal.
1548 if (!IsObjCLiteral && CS.isObjCArg()) {
1549 return HandleInvalidConversionSpecifier(FS, startSpecifier, specifierLen);
1550 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001551
Ted Kremeneke82d8042010-01-29 01:35:25 +00001552 // Are we using '%n'? Issue a warning about this being
1553 // a possible security issue.
1554 if (CS.getKind() == ConversionSpecifier::OutIntPtrArg) {
1555 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001556 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremeneke82d8042010-01-29 01:35:25 +00001557 // Continue checking the other format specifiers.
1558 return true;
1559 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001560
1561 if (CS.getKind() == ConversionSpecifier::VoidPtrArg) {
1562 if (FS.getPrecision().getHowSpecified() != OptionalAmount::NotSpecified)
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001563 S.Diag(getLocationOfByte(CS.getStart()),
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001564 diag::warn_printf_nonsensical_precision)
1565 << CS.getCharacters()
1566 << getFormatSpecifierRange(startSpecifier, specifierLen);
1567 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001568 if (CS.getKind() == ConversionSpecifier::VoidPtrArg ||
1569 CS.getKind() == ConversionSpecifier::CStrArg) {
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001570 // FIXME: Instead of using "0", "+", etc., eventually get them from
1571 // the FormatSpecifier.
1572 if (FS.hasLeadingZeros())
1573 HandleFlags(FS, "0", CS.getCharacters(), startSpecifier, specifierLen);
1574 if (FS.hasPlusPrefix())
1575 HandleFlags(FS, "+", CS.getCharacters(), startSpecifier, specifierLen);
1576 if (FS.hasSpacePrefix())
1577 HandleFlags(FS, " ", CS.getCharacters(), startSpecifier, specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001578 }
1579
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001580 // The remaining checks depend on the data arguments.
1581 if (HasVAListArg)
1582 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001583
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001584 if (argIndex >= NumDataArgs) {
Ted Kremenek6ee76532010-03-25 03:59:12 +00001585 if (FS.usesPositionalArg()) {
1586 S.Diag(getLocationOfByte(CS.getStart()),
1587 diag::warn_printf_positional_arg_exceeds_data_args)
1588 << (argIndex+1) << NumDataArgs
1589 << getFormatSpecifierRange(startSpecifier, specifierLen);
1590 }
1591 else {
1592 S.Diag(getLocationOfByte(CS.getStart()),
1593 diag::warn_printf_insufficient_data_args)
1594 << getFormatSpecifierRange(startSpecifier, specifierLen);
1595 }
1596
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001597 // Don't do any more checking.
1598 return false;
1599 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001600
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001601 // Now type check the data expression that matches the
1602 // format specifier.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001603 const Expr *Ex = getDataArg(argIndex);
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001604 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001605 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
1606 // Check if we didn't match because of an implicit cast from a 'char'
1607 // or 'short' to an 'int'. This is done because printf is a varargs
1608 // function.
1609 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
1610 if (ICE->getType() == S.Context.IntTy)
1611 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
1612 return true;
Ted Kremenek105d41c2010-02-01 19:38:10 +00001613
Tom Care3bfc5f42010-06-09 04:11:11 +00001614 // We may be able to offer a FixItHint if it is a supported type.
1615 FormatSpecifier fixedFS = FS;
1616 bool success = fixedFS.fixType(Ex->getType());
1617
1618 if (success) {
1619 // Get the fix string from the fixed format specifier
1620 llvm::SmallString<128> buf;
1621 llvm::raw_svector_ostream os(buf);
1622 fixedFS.toString(os);
1623
1624 S.Diag(getLocationOfByte(CS.getStart()),
1625 diag::warn_printf_conversion_argument_type_mismatch)
1626 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1627 << getFormatSpecifierRange(startSpecifier, specifierLen)
1628 << Ex->getSourceRange()
1629 << FixItHint::CreateReplacement(
1630 getFormatSpecifierRange(startSpecifier, specifierLen),
1631 os.str());
1632 }
1633 else {
1634 S.Diag(getLocationOfByte(CS.getStart()),
1635 diag::warn_printf_conversion_argument_type_mismatch)
1636 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1637 << getFormatSpecifierRange(startSpecifier, specifierLen)
1638 << Ex->getSourceRange();
1639 }
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001640 }
Ted Kremeneke0e53132010-01-28 23:39:18 +00001641
1642 return true;
1643}
1644
Ted Kremenek07d161f2010-01-29 01:50:07 +00001645void CheckPrintfHandler::DoneProcessing() {
1646 // Does the number of data arguments exceed the number of
1647 // format conversions in the format string?
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001648 if (!HasVAListArg) {
1649 // Find any arguments that weren't covered.
1650 CoveredArgs.flip();
1651 signed notCoveredArg = CoveredArgs.find_first();
1652 if (notCoveredArg >= 0) {
1653 assert((unsigned)notCoveredArg < NumDataArgs);
1654 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
1655 diag::warn_printf_data_arg_not_used)
1656 << getFormatStringRange();
1657 }
1658 }
Ted Kremenek07d161f2010-01-29 01:50:07 +00001659}
Ted Kremeneke0e53132010-01-28 23:39:18 +00001660
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001661void Sema::CheckPrintfString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001662 const Expr *OrigFormatExpr,
1663 const CallExpr *TheCall, bool HasVAListArg,
1664 unsigned format_idx, unsigned firstDataArg) {
1665
Ted Kremeneke0e53132010-01-28 23:39:18 +00001666 // CHECK: is the format string a wide literal?
1667 if (FExpr->isWide()) {
1668 Diag(FExpr->getLocStart(),
1669 diag::warn_printf_format_string_is_wide_literal)
1670 << OrigFormatExpr->getSourceRange();
1671 return;
1672 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001673
Ted Kremeneke0e53132010-01-28 23:39:18 +00001674 // Str - The format string. NOTE: this is NOT null-terminated!
1675 const char *Str = FExpr->getStrData();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001676
Ted Kremeneke0e53132010-01-28 23:39:18 +00001677 // CHECK: empty format string?
1678 unsigned StrLen = FExpr->getByteLength();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001679
Ted Kremeneke0e53132010-01-28 23:39:18 +00001680 if (StrLen == 0) {
1681 Diag(FExpr->getLocStart(), diag::warn_printf_empty_format_string)
1682 << OrigFormatExpr->getSourceRange();
1683 return;
1684 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001685
Ted Kremenek6ee76532010-03-25 03:59:12 +00001686 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001687 TheCall->getNumArgs() - firstDataArg,
Ted Kremenek0d277352010-01-29 01:06:55 +00001688 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1689 HasVAListArg, TheCall, format_idx);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001690
Ted Kremenek74d56a12010-02-04 20:46:58 +00001691 if (!analyze_printf::ParseFormatString(H, Str, Str + StrLen))
Ted Kremenek808015a2010-01-29 03:16:21 +00001692 H.DoneProcessing();
Ted Kremenekce7024e2010-01-28 01:18:22 +00001693}
1694
Ted Kremenek06de2762007-08-17 16:46:58 +00001695//===--- CHECK: Return Address of Stack Variable --------------------------===//
1696
1697static DeclRefExpr* EvalVal(Expr *E);
1698static DeclRefExpr* EvalAddr(Expr* E);
1699
1700/// CheckReturnStackAddr - Check if a return statement returns the address
1701/// of a stack variable.
1702void
1703Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1704 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00001705
Ted Kremenek06de2762007-08-17 16:46:58 +00001706 // Perform checking for returned stack addresses.
Steve Naroffdd972f22008-09-05 22:11:13 +00001707 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001708 if (DeclRefExpr *DR = EvalAddr(RetValExp))
Chris Lattner3c73c412008-11-19 08:23:25 +00001709 Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
Chris Lattner08631c52008-11-23 21:45:46 +00001710 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001711
Steve Naroffc50a4a52008-09-16 22:25:10 +00001712 // Skip over implicit cast expressions when checking for block expressions.
Chris Lattner4ca606e2009-09-08 00:36:37 +00001713 RetValExp = RetValExp->IgnoreParenCasts();
Steve Naroffc50a4a52008-09-16 22:25:10 +00001714
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001715 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
Mike Stump397195b2009-04-17 00:09:41 +00001716 if (C->hasBlockDeclRefExprs())
1717 Diag(C->getLocStart(), diag::err_ret_local_block)
1718 << C->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001719
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001720 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1721 Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1722 << ALE->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001723
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001724 } else if (lhsType->isReferenceType()) {
1725 // Perform checking for stack values returned by reference.
Douglas Gregor49badde2008-10-27 19:41:14 +00001726 // Check for a reference to the stack
1727 if (DeclRefExpr *DR = EvalVal(RetValExp))
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001728 Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
Chris Lattner08631c52008-11-23 21:45:46 +00001729 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Ted Kremenek06de2762007-08-17 16:46:58 +00001730 }
1731}
1732
1733/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1734/// check if the expression in a return statement evaluates to an address
1735/// to a location on the stack. The recursion is used to traverse the
1736/// AST of the return expression, with recursion backtracking when we
1737/// encounter a subexpression that (1) clearly does not lead to the address
1738/// of a stack variable or (2) is something we cannot determine leads to
1739/// the address of a stack variable based on such local checking.
1740///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001741/// EvalAddr processes expressions that are pointers that are used as
1742/// references (and not L-values). EvalVal handles all other values.
Mike Stump1eb44332009-09-09 15:08:12 +00001743/// At the base case of the recursion is a check for a DeclRefExpr* in
Ted Kremenek06de2762007-08-17 16:46:58 +00001744/// the refers to a stack variable.
1745///
1746/// This implementation handles:
1747///
1748/// * pointer-to-pointer casts
1749/// * implicit conversions from array references to pointers
1750/// * taking the address of fields
1751/// * arbitrary interplay between "&" and "*" operators
1752/// * pointer arithmetic from an address of a stack variable
1753/// * taking the address of an array element where the array is on the stack
1754static DeclRefExpr* EvalAddr(Expr *E) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001755 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00001756 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00001757 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001758 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001759 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00001760
Ted Kremenek06de2762007-08-17 16:46:58 +00001761 // Our "symbolic interpreter" is just a dispatch off the currently
1762 // viewed AST node. We then recursively traverse the AST by calling
1763 // EvalAddr and EvalVal appropriately.
1764 switch (E->getStmtClass()) {
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001765 case Stmt::ParenExprClass:
1766 // Ignore parentheses.
1767 return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
Ted Kremenek06de2762007-08-17 16:46:58 +00001768
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001769 case Stmt::UnaryOperatorClass: {
1770 // The only unary operator that make sense to handle here
1771 // is AddrOf. All others don't make sense as pointers.
1772 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001773
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001774 if (U->getOpcode() == UnaryOperator::AddrOf)
1775 return EvalVal(U->getSubExpr());
1776 else
Ted Kremenek06de2762007-08-17 16:46:58 +00001777 return NULL;
1778 }
Mike Stump1eb44332009-09-09 15:08:12 +00001779
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001780 case Stmt::BinaryOperatorClass: {
1781 // Handle pointer arithmetic. All other binary operators are not valid
1782 // in this context.
1783 BinaryOperator *B = cast<BinaryOperator>(E);
1784 BinaryOperator::Opcode op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00001785
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001786 if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
1787 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001788
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001789 Expr *Base = B->getLHS();
1790
1791 // Determine which argument is the real pointer base. It could be
1792 // the RHS argument instead of the LHS.
1793 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00001794
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001795 assert (Base->getType()->isPointerType());
1796 return EvalAddr(Base);
1797 }
Steve Naroff61f40a22008-09-10 19:17:48 +00001798
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001799 // For conditional operators we need to see if either the LHS or RHS are
1800 // valid DeclRefExpr*s. If one of them is valid, we return it.
1801 case Stmt::ConditionalOperatorClass: {
1802 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001803
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001804 // Handle the GNU extension for missing LHS.
1805 if (Expr *lhsExpr = C->getLHS())
1806 if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1807 return LHS;
1808
1809 return EvalAddr(C->getRHS());
1810 }
Mike Stump1eb44332009-09-09 15:08:12 +00001811
Ted Kremenek54b52742008-08-07 00:49:01 +00001812 // For casts, we need to handle conversions from arrays to
1813 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00001814 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00001815 case Stmt::CStyleCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001816 case Stmt::CXXFunctionalCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00001817 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00001818 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00001819
Steve Naroffdd972f22008-09-05 22:11:13 +00001820 if (SubExpr->getType()->isPointerType() ||
1821 SubExpr->getType()->isBlockPointerType() ||
1822 SubExpr->getType()->isObjCQualifiedIdType())
Ted Kremenek54b52742008-08-07 00:49:01 +00001823 return EvalAddr(SubExpr);
1824 else if (T->isArrayType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001825 return EvalVal(SubExpr);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001826 else
Ted Kremenek54b52742008-08-07 00:49:01 +00001827 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001828 }
Mike Stump1eb44332009-09-09 15:08:12 +00001829
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001830 // C++ casts. For dynamic casts, static casts, and const casts, we
1831 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00001832 // through the cast. In the case the dynamic cast doesn't fail (and
1833 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001834 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00001835 // FIXME: The comment about is wrong; we're not always converting
1836 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00001837 // handle references to objects.
1838 case Stmt::CXXStaticCastExprClass:
1839 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001840 case Stmt::CXXConstCastExprClass:
1841 case Stmt::CXXReinterpretCastExprClass: {
1842 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00001843 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001844 return EvalAddr(S);
1845 else
1846 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001847 }
Mike Stump1eb44332009-09-09 15:08:12 +00001848
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001849 // Everything else: we simply don't reason about them.
1850 default:
1851 return NULL;
1852 }
Ted Kremenek06de2762007-08-17 16:46:58 +00001853}
Mike Stump1eb44332009-09-09 15:08:12 +00001854
Ted Kremenek06de2762007-08-17 16:46:58 +00001855
1856/// EvalVal - This function is complements EvalAddr in the mutual recursion.
1857/// See the comments for EvalAddr for more details.
1858static DeclRefExpr* EvalVal(Expr *E) {
Mike Stump1eb44332009-09-09 15:08:12 +00001859
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001860 // We should only be called for evaluating non-pointer expressions, or
1861 // expressions with a pointer type that are not used as references but instead
1862 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00001863
Ted Kremenek06de2762007-08-17 16:46:58 +00001864 // Our "symbolic interpreter" is just a dispatch off the currently
1865 // viewed AST node. We then recursively traverse the AST by calling
1866 // EvalAddr and EvalVal appropriately.
1867 switch (E->getStmtClass()) {
Douglas Gregora2813ce2009-10-23 18:54:35 +00001868 case Stmt::DeclRefExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001869 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
1870 // at code that refers to a variable's name. We check if it has local
1871 // storage within the function, and if so, return the expression.
1872 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001873
Ted Kremenek06de2762007-08-17 16:46:58 +00001874 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Mike Stump1eb44332009-09-09 15:08:12 +00001875 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1876
Ted Kremenek06de2762007-08-17 16:46:58 +00001877 return NULL;
1878 }
Mike Stump1eb44332009-09-09 15:08:12 +00001879
Ted Kremenek06de2762007-08-17 16:46:58 +00001880 case Stmt::ParenExprClass:
1881 // Ignore parentheses.
1882 return EvalVal(cast<ParenExpr>(E)->getSubExpr());
Mike Stump1eb44332009-09-09 15:08:12 +00001883
Ted Kremenek06de2762007-08-17 16:46:58 +00001884 case Stmt::UnaryOperatorClass: {
1885 // The only unary operator that make sense to handle here
1886 // is Deref. All others don't resolve to a "name." This includes
1887 // handling all sorts of rvalues passed to a unary operator.
1888 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001889
Ted Kremenek06de2762007-08-17 16:46:58 +00001890 if (U->getOpcode() == UnaryOperator::Deref)
1891 return EvalAddr(U->getSubExpr());
1892
1893 return NULL;
1894 }
Mike Stump1eb44332009-09-09 15:08:12 +00001895
Ted Kremenek06de2762007-08-17 16:46:58 +00001896 case Stmt::ArraySubscriptExprClass: {
1897 // Array subscripts are potential references to data on the stack. We
1898 // retrieve the DeclRefExpr* for the array variable if it indeed
1899 // has local storage.
Ted Kremenek23245122007-08-20 16:18:38 +00001900 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00001901 }
Mike Stump1eb44332009-09-09 15:08:12 +00001902
Ted Kremenek06de2762007-08-17 16:46:58 +00001903 case Stmt::ConditionalOperatorClass: {
1904 // For conditional operators we need to see if either the LHS or RHS are
1905 // non-NULL DeclRefExpr's. If one is non-NULL, we return it.
1906 ConditionalOperator *C = cast<ConditionalOperator>(E);
1907
Anders Carlsson39073232007-11-30 19:04:31 +00001908 // Handle the GNU extension for missing LHS.
1909 if (Expr *lhsExpr = C->getLHS())
1910 if (DeclRefExpr *LHS = EvalVal(lhsExpr))
1911 return LHS;
1912
1913 return EvalVal(C->getRHS());
Ted Kremenek06de2762007-08-17 16:46:58 +00001914 }
Mike Stump1eb44332009-09-09 15:08:12 +00001915
Ted Kremenek06de2762007-08-17 16:46:58 +00001916 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00001917 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001918 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001919
Ted Kremenek06de2762007-08-17 16:46:58 +00001920 // Check for indirect access. We only want direct field accesses.
1921 if (!M->isArrow())
1922 return EvalVal(M->getBase());
1923 else
1924 return NULL;
1925 }
Mike Stump1eb44332009-09-09 15:08:12 +00001926
Ted Kremenek06de2762007-08-17 16:46:58 +00001927 // Everything else: we simply don't reason about them.
1928 default:
1929 return NULL;
1930 }
1931}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001932
1933//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
1934
1935/// Check for comparisons of floating point operands using != and ==.
1936/// Issue a warning if these are no self-comparisons, as they are not likely
1937/// to do what the programmer intended.
1938void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
1939 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00001940
Ted Kremenek4e99a5f2008-01-17 16:57:34 +00001941 Expr* LeftExprSansParen = lex->IgnoreParens();
Ted Kremenek32e97b62008-01-17 17:55:13 +00001942 Expr* RightExprSansParen = rex->IgnoreParens();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001943
1944 // Special case: check for x == x (which is OK).
1945 // Do not emit warnings for such cases.
1946 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
1947 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
1948 if (DRL->getDecl() == DRR->getDecl())
1949 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001950
1951
Ted Kremenek1b500bb2007-11-29 00:59:04 +00001952 // Special case: check for comparisons against literals that can be exactly
1953 // represented by APFloat. In such cases, do not emit a warning. This
1954 // is a heuristic: often comparison against such literals are used to
1955 // detect if a value in a variable has not changed. This clearly can
1956 // lead to false negatives.
1957 if (EmitWarning) {
1958 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
1959 if (FLL->isExact())
1960 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001961 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00001962 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
1963 if (FLR->isExact())
1964 EmitWarning = false;
1965 }
1966 }
Mike Stump1eb44332009-09-09 15:08:12 +00001967
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001968 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00001969 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001970 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00001971 if (CL->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001972 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001973
Sebastian Redl0eb23302009-01-19 00:08:26 +00001974 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001975 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00001976 if (CR->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001977 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001978
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001979 // Emit the diagnostic.
1980 if (EmitWarning)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001981 Diag(loc, diag::warn_floatingpoint_eq)
1982 << lex->getSourceRange() << rex->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001983}
John McCallba26e582010-01-04 23:21:16 +00001984
John McCallf2370c92010-01-06 05:24:50 +00001985//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
1986//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00001987
John McCallf2370c92010-01-06 05:24:50 +00001988namespace {
John McCallba26e582010-01-04 23:21:16 +00001989
John McCallf2370c92010-01-06 05:24:50 +00001990/// Structure recording the 'active' range of an integer-valued
1991/// expression.
1992struct IntRange {
1993 /// The number of bits active in the int.
1994 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00001995
John McCallf2370c92010-01-06 05:24:50 +00001996 /// True if the int is known not to have negative values.
1997 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00001998
John McCallf2370c92010-01-06 05:24:50 +00001999 IntRange() {}
2000 IntRange(unsigned Width, bool NonNegative)
2001 : Width(Width), NonNegative(NonNegative)
2002 {}
John McCallba26e582010-01-04 23:21:16 +00002003
John McCallf2370c92010-01-06 05:24:50 +00002004 // Returns the range of the bool type.
2005 static IntRange forBoolType() {
2006 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00002007 }
2008
John McCallf2370c92010-01-06 05:24:50 +00002009 // Returns the range of an integral type.
2010 static IntRange forType(ASTContext &C, QualType T) {
2011 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00002012 }
2013
John McCallf2370c92010-01-06 05:24:50 +00002014 // Returns the range of an integeral type based on its canonical
2015 // representation.
2016 static IntRange forCanonicalType(ASTContext &C, const Type *T) {
2017 assert(T->isCanonicalUnqualified());
2018
2019 if (const VectorType *VT = dyn_cast<VectorType>(T))
2020 T = VT->getElementType().getTypePtr();
2021 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
2022 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00002023
2024 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
2025 EnumDecl *Enum = ET->getDecl();
2026 unsigned NumPositive = Enum->getNumPositiveBits();
2027 unsigned NumNegative = Enum->getNumNegativeBits();
2028
2029 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
2030 }
John McCallf2370c92010-01-06 05:24:50 +00002031
2032 const BuiltinType *BT = cast<BuiltinType>(T);
2033 assert(BT->isInteger());
2034
2035 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
2036 }
2037
2038 // Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002039 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00002040 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00002041 L.NonNegative && R.NonNegative);
2042 }
2043
2044 // Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002045 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00002046 return IntRange(std::min(L.Width, R.Width),
2047 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00002048 }
2049};
2050
2051IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
2052 if (value.isSigned() && value.isNegative())
2053 return IntRange(value.getMinSignedBits(), false);
2054
2055 if (value.getBitWidth() > MaxWidth)
2056 value.trunc(MaxWidth);
2057
2058 // isNonNegative() just checks the sign bit without considering
2059 // signedness.
2060 return IntRange(value.getActiveBits(), true);
2061}
2062
John McCall0acc3112010-01-06 22:57:21 +00002063IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
John McCallf2370c92010-01-06 05:24:50 +00002064 unsigned MaxWidth) {
2065 if (result.isInt())
2066 return GetValueRange(C, result.getInt(), MaxWidth);
2067
2068 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00002069 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
2070 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
2071 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
2072 R = IntRange::join(R, El);
2073 }
John McCallf2370c92010-01-06 05:24:50 +00002074 return R;
2075 }
2076
2077 if (result.isComplexInt()) {
2078 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
2079 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
2080 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00002081 }
2082
2083 // This can happen with lossless casts to intptr_t of "based" lvalues.
2084 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00002085 // FIXME: The only reason we need to pass the type in here is to get
2086 // the sign right on this one case. It would be nice if APValue
2087 // preserved this.
John McCallf2370c92010-01-06 05:24:50 +00002088 assert(result.isLValue());
John McCall0acc3112010-01-06 22:57:21 +00002089 return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
John McCall51313c32010-01-04 23:31:57 +00002090}
John McCallf2370c92010-01-06 05:24:50 +00002091
2092/// Pseudo-evaluate the given integer expression, estimating the
2093/// range of values it might take.
2094///
2095/// \param MaxWidth - the width to which the value will be truncated
2096IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
2097 E = E->IgnoreParens();
2098
2099 // Try a full evaluation first.
2100 Expr::EvalResult result;
2101 if (E->Evaluate(result, C))
John McCall0acc3112010-01-06 22:57:21 +00002102 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00002103
2104 // I think we only want to look through implicit casts here; if the
2105 // user has an explicit widening cast, we should treat the value as
2106 // being of the new, wider type.
2107 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
2108 if (CE->getCastKind() == CastExpr::CK_NoOp)
2109 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
2110
2111 IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
2112
John McCall60fad452010-01-06 22:07:33 +00002113 bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
2114 if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
2115 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
2116
John McCallf2370c92010-01-06 05:24:50 +00002117 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00002118 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00002119 return OutputTypeRange;
2120
2121 IntRange SubRange
2122 = GetExprRange(C, CE->getSubExpr(),
2123 std::min(MaxWidth, OutputTypeRange.Width));
2124
2125 // Bail out if the subexpr's range is as wide as the cast type.
2126 if (SubRange.Width >= OutputTypeRange.Width)
2127 return OutputTypeRange;
2128
2129 // Otherwise, we take the smaller width, and we're non-negative if
2130 // either the output type or the subexpr is.
2131 return IntRange(SubRange.Width,
2132 SubRange.NonNegative || OutputTypeRange.NonNegative);
2133 }
2134
2135 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
2136 // If we can fold the condition, just take that operand.
2137 bool CondResult;
2138 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
2139 return GetExprRange(C, CondResult ? CO->getTrueExpr()
2140 : CO->getFalseExpr(),
2141 MaxWidth);
2142
2143 // Otherwise, conservatively merge.
2144 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
2145 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
2146 return IntRange::join(L, R);
2147 }
2148
2149 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
2150 switch (BO->getOpcode()) {
2151
2152 // Boolean-valued operations are single-bit and positive.
2153 case BinaryOperator::LAnd:
2154 case BinaryOperator::LOr:
2155 case BinaryOperator::LT:
2156 case BinaryOperator::GT:
2157 case BinaryOperator::LE:
2158 case BinaryOperator::GE:
2159 case BinaryOperator::EQ:
2160 case BinaryOperator::NE:
2161 return IntRange::forBoolType();
2162
John McCallc0cd21d2010-02-23 19:22:29 +00002163 // The type of these compound assignments is the type of the LHS,
2164 // so the RHS is not necessarily an integer.
2165 case BinaryOperator::MulAssign:
2166 case BinaryOperator::DivAssign:
2167 case BinaryOperator::RemAssign:
2168 case BinaryOperator::AddAssign:
2169 case BinaryOperator::SubAssign:
2170 return IntRange::forType(C, E->getType());
2171
John McCallf2370c92010-01-06 05:24:50 +00002172 // Operations with opaque sources are black-listed.
2173 case BinaryOperator::PtrMemD:
2174 case BinaryOperator::PtrMemI:
2175 return IntRange::forType(C, E->getType());
2176
John McCall60fad452010-01-06 22:07:33 +00002177 // Bitwise-and uses the *infinum* of the two source ranges.
2178 case BinaryOperator::And:
John McCallc0cd21d2010-02-23 19:22:29 +00002179 case BinaryOperator::AndAssign:
John McCall60fad452010-01-06 22:07:33 +00002180 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
2181 GetExprRange(C, BO->getRHS(), MaxWidth));
2182
John McCallf2370c92010-01-06 05:24:50 +00002183 // Left shift gets black-listed based on a judgement call.
2184 case BinaryOperator::Shl:
John McCall3aae6092010-04-07 01:14:35 +00002185 // ...except that we want to treat '1 << (blah)' as logically
2186 // positive. It's an important idiom.
2187 if (IntegerLiteral *I
2188 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
2189 if (I->getValue() == 1) {
2190 IntRange R = IntRange::forType(C, E->getType());
2191 return IntRange(R.Width, /*NonNegative*/ true);
2192 }
2193 }
2194 // fallthrough
2195
John McCallc0cd21d2010-02-23 19:22:29 +00002196 case BinaryOperator::ShlAssign:
John McCallf2370c92010-01-06 05:24:50 +00002197 return IntRange::forType(C, E->getType());
2198
John McCall60fad452010-01-06 22:07:33 +00002199 // Right shift by a constant can narrow its left argument.
John McCallc0cd21d2010-02-23 19:22:29 +00002200 case BinaryOperator::Shr:
2201 case BinaryOperator::ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00002202 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2203
2204 // If the shift amount is a positive constant, drop the width by
2205 // that much.
2206 llvm::APSInt shift;
2207 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
2208 shift.isNonNegative()) {
2209 unsigned zext = shift.getZExtValue();
2210 if (zext >= L.Width)
2211 L.Width = (L.NonNegative ? 0 : 1);
2212 else
2213 L.Width -= zext;
2214 }
2215
2216 return L;
2217 }
2218
2219 // Comma acts as its right operand.
John McCallf2370c92010-01-06 05:24:50 +00002220 case BinaryOperator::Comma:
2221 return GetExprRange(C, BO->getRHS(), MaxWidth);
2222
John McCall60fad452010-01-06 22:07:33 +00002223 // Black-list pointer subtractions.
John McCallf2370c92010-01-06 05:24:50 +00002224 case BinaryOperator::Sub:
2225 if (BO->getLHS()->getType()->isPointerType())
2226 return IntRange::forType(C, E->getType());
2227 // fallthrough
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002228
John McCallf2370c92010-01-06 05:24:50 +00002229 default:
2230 break;
2231 }
2232
2233 // Treat every other operator as if it were closed on the
2234 // narrowest type that encompasses both operands.
2235 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2236 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
2237 return IntRange::join(L, R);
2238 }
2239
2240 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
2241 switch (UO->getOpcode()) {
2242 // Boolean-valued operations are white-listed.
2243 case UnaryOperator::LNot:
2244 return IntRange::forBoolType();
2245
2246 // Operations with opaque sources are black-listed.
2247 case UnaryOperator::Deref:
2248 case UnaryOperator::AddrOf: // should be impossible
2249 case UnaryOperator::OffsetOf:
2250 return IntRange::forType(C, E->getType());
2251
2252 default:
2253 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
2254 }
2255 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00002256
2257 if (dyn_cast<OffsetOfExpr>(E)) {
2258 IntRange::forType(C, E->getType());
2259 }
John McCallf2370c92010-01-06 05:24:50 +00002260
2261 FieldDecl *BitField = E->getBitField();
2262 if (BitField) {
2263 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
2264 unsigned BitWidth = BitWidthAP.getZExtValue();
2265
2266 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
2267 }
2268
2269 return IntRange::forType(C, E->getType());
2270}
John McCall51313c32010-01-04 23:31:57 +00002271
John McCall323ed742010-05-06 08:58:33 +00002272IntRange GetExprRange(ASTContext &C, Expr *E) {
2273 return GetExprRange(C, E, C.getIntWidth(E->getType()));
2274}
2275
John McCall51313c32010-01-04 23:31:57 +00002276/// Checks whether the given value, which currently has the given
2277/// source semantics, has the same value when coerced through the
2278/// target semantics.
John McCallf2370c92010-01-06 05:24:50 +00002279bool IsSameFloatAfterCast(const llvm::APFloat &value,
2280 const llvm::fltSemantics &Src,
2281 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002282 llvm::APFloat truncated = value;
2283
2284 bool ignored;
2285 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
2286 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
2287
2288 return truncated.bitwiseIsEqual(value);
2289}
2290
2291/// Checks whether the given value, which currently has the given
2292/// source semantics, has the same value when coerced through the
2293/// target semantics.
2294///
2295/// The value might be a vector of floats (or a complex number).
John McCallf2370c92010-01-06 05:24:50 +00002296bool IsSameFloatAfterCast(const APValue &value,
2297 const llvm::fltSemantics &Src,
2298 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002299 if (value.isFloat())
2300 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
2301
2302 if (value.isVector()) {
2303 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
2304 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
2305 return false;
2306 return true;
2307 }
2308
2309 assert(value.isComplexFloat());
2310 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
2311 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
2312}
2313
John McCall323ed742010-05-06 08:58:33 +00002314void AnalyzeImplicitConversions(Sema &S, Expr *E);
2315
2316bool IsZero(Sema &S, Expr *E) {
2317 llvm::APSInt Value;
2318 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
2319}
2320
2321void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
2322 BinaryOperator::Opcode op = E->getOpcode();
2323 if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) {
2324 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2325 << "< 0" << "false"
2326 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2327 } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) {
2328 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2329 << ">= 0" << "true"
2330 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2331 } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) {
2332 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2333 << "0 >" << "false"
2334 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2335 } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) {
2336 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2337 << "0 <=" << "true"
2338 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2339 }
2340}
2341
2342/// Analyze the operands of the given comparison. Implements the
2343/// fallback case from AnalyzeComparison.
2344void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
2345 AnalyzeImplicitConversions(S, E->getLHS());
2346 AnalyzeImplicitConversions(S, E->getRHS());
2347}
John McCall51313c32010-01-04 23:31:57 +00002348
John McCallba26e582010-01-04 23:21:16 +00002349/// \brief Implements -Wsign-compare.
2350///
2351/// \param lex the left-hand expression
2352/// \param rex the right-hand expression
2353/// \param OpLoc the location of the joining operator
John McCalld1b47bf2010-03-11 19:43:18 +00002354/// \param BinOpc binary opcode or 0
John McCall323ed742010-05-06 08:58:33 +00002355void AnalyzeComparison(Sema &S, BinaryOperator *E) {
2356 // The type the comparison is being performed in.
2357 QualType T = E->getLHS()->getType();
2358 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
2359 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00002360
John McCall323ed742010-05-06 08:58:33 +00002361 // We don't do anything special if this isn't an unsigned integral
2362 // comparison: we're only interested in integral comparisons, and
2363 // signed comparisons only happen in cases we don't care to warn about.
2364 if (!T->isUnsignedIntegerType())
2365 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00002366
John McCall323ed742010-05-06 08:58:33 +00002367 Expr *lex = E->getLHS()->IgnoreParenImpCasts();
2368 Expr *rex = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00002369
John McCall323ed742010-05-06 08:58:33 +00002370 // Check to see if one of the (unmodified) operands is of different
2371 // signedness.
2372 Expr *signedOperand, *unsignedOperand;
2373 if (lex->getType()->isSignedIntegerType()) {
2374 assert(!rex->getType()->isSignedIntegerType() &&
2375 "unsigned comparison between two signed integer expressions?");
2376 signedOperand = lex;
2377 unsignedOperand = rex;
2378 } else if (rex->getType()->isSignedIntegerType()) {
2379 signedOperand = rex;
2380 unsignedOperand = lex;
John McCallba26e582010-01-04 23:21:16 +00002381 } else {
John McCall323ed742010-05-06 08:58:33 +00002382 CheckTrivialUnsignedComparison(S, E);
2383 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002384 }
2385
John McCall323ed742010-05-06 08:58:33 +00002386 // Otherwise, calculate the effective range of the signed operand.
2387 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00002388
John McCall323ed742010-05-06 08:58:33 +00002389 // Go ahead and analyze implicit conversions in the operands. Note
2390 // that we skip the implicit conversions on both sides.
2391 AnalyzeImplicitConversions(S, lex);
2392 AnalyzeImplicitConversions(S, rex);
John McCallba26e582010-01-04 23:21:16 +00002393
John McCall323ed742010-05-06 08:58:33 +00002394 // If the signed range is non-negative, -Wsign-compare won't fire,
2395 // but we should still check for comparisons which are always true
2396 // or false.
2397 if (signedRange.NonNegative)
2398 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002399
2400 // For (in)equality comparisons, if the unsigned operand is a
2401 // constant which cannot collide with a overflowed signed operand,
2402 // then reinterpreting the signed operand as unsigned will not
2403 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00002404 if (E->isEqualityOp()) {
2405 unsigned comparisonWidth = S.Context.getIntWidth(T);
2406 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00002407
John McCall323ed742010-05-06 08:58:33 +00002408 // We should never be unable to prove that the unsigned operand is
2409 // non-negative.
2410 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
2411
2412 if (unsignedRange.Width < comparisonWidth)
2413 return;
2414 }
2415
2416 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
2417 << lex->getType() << rex->getType()
2418 << lex->getSourceRange() << rex->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00002419}
2420
John McCall51313c32010-01-04 23:31:57 +00002421/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
John McCall323ed742010-05-06 08:58:33 +00002422void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
John McCall51313c32010-01-04 23:31:57 +00002423 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
2424}
2425
John McCall323ed742010-05-06 08:58:33 +00002426void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
2427 bool *ICContext = 0) {
2428 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00002429
John McCall323ed742010-05-06 08:58:33 +00002430 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
2431 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
2432 if (Source == Target) return;
2433 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00002434
2435 // Never diagnose implicit casts to bool.
2436 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
2437 return;
2438
2439 // Strip vector types.
2440 if (isa<VectorType>(Source)) {
2441 if (!isa<VectorType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002442 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
John McCall51313c32010-01-04 23:31:57 +00002443
2444 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
2445 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
2446 }
2447
2448 // Strip complex types.
2449 if (isa<ComplexType>(Source)) {
2450 if (!isa<ComplexType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002451 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
John McCall51313c32010-01-04 23:31:57 +00002452
2453 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
2454 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
2455 }
2456
2457 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
2458 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
2459
2460 // If the source is floating point...
2461 if (SourceBT && SourceBT->isFloatingPoint()) {
2462 // ...and the target is floating point...
2463 if (TargetBT && TargetBT->isFloatingPoint()) {
2464 // ...then warn if we're dropping FP rank.
2465
2466 // Builtin FP kinds are ordered by increasing FP rank.
2467 if (SourceBT->getKind() > TargetBT->getKind()) {
2468 // Don't warn about float constants that are precisely
2469 // representable in the target type.
2470 Expr::EvalResult result;
John McCall323ed742010-05-06 08:58:33 +00002471 if (E->Evaluate(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00002472 // Value might be a float, a float vector, or a float complex.
2473 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00002474 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2475 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00002476 return;
2477 }
2478
John McCall323ed742010-05-06 08:58:33 +00002479 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00002480 }
2481 return;
2482 }
2483
2484 // If the target is integral, always warn.
2485 if ((TargetBT && TargetBT->isInteger()))
2486 // TODO: don't warn for integer values?
John McCall323ed742010-05-06 08:58:33 +00002487 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
John McCall51313c32010-01-04 23:31:57 +00002488
2489 return;
2490 }
2491
John McCallf2370c92010-01-06 05:24:50 +00002492 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00002493 return;
2494
John McCall323ed742010-05-06 08:58:33 +00002495 IntRange SourceRange = GetExprRange(S.Context, E);
2496 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00002497
2498 if (SourceRange.Width > TargetRange.Width) {
John McCall51313c32010-01-04 23:31:57 +00002499 // People want to build with -Wshorten-64-to-32 and not -Wconversion
2500 // and by god we'll let them.
John McCallf2370c92010-01-06 05:24:50 +00002501 if (SourceRange.Width == 64 && TargetRange.Width == 32)
John McCall323ed742010-05-06 08:58:33 +00002502 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
2503 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
2504 }
2505
2506 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
2507 (!TargetRange.NonNegative && SourceRange.NonNegative &&
2508 SourceRange.Width == TargetRange.Width)) {
2509 unsigned DiagID = diag::warn_impcast_integer_sign;
2510
2511 // Traditionally, gcc has warned about this under -Wsign-compare.
2512 // We also want to warn about it in -Wconversion.
2513 // So if -Wconversion is off, use a completely identical diagnostic
2514 // in the sign-compare group.
2515 // The conditional-checking code will
2516 if (ICContext) {
2517 DiagID = diag::warn_impcast_integer_sign_conditional;
2518 *ICContext = true;
2519 }
2520
2521 return DiagnoseImpCast(S, E, T, DiagID);
John McCall51313c32010-01-04 23:31:57 +00002522 }
2523
2524 return;
2525}
2526
John McCall323ed742010-05-06 08:58:33 +00002527void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
2528
2529void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
2530 bool &ICContext) {
2531 E = E->IgnoreParenImpCasts();
2532
2533 if (isa<ConditionalOperator>(E))
2534 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
2535
2536 AnalyzeImplicitConversions(S, E);
2537 if (E->getType() != T)
2538 return CheckImplicitConversion(S, E, T, &ICContext);
2539 return;
2540}
2541
2542void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
2543 AnalyzeImplicitConversions(S, E->getCond());
2544
2545 bool Suspicious = false;
2546 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
2547 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
2548
2549 // If -Wconversion would have warned about either of the candidates
2550 // for a signedness conversion to the context type...
2551 if (!Suspicious) return;
2552
2553 // ...but it's currently ignored...
2554 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
2555 return;
2556
2557 // ...and -Wsign-compare isn't...
2558 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
2559 return;
2560
2561 // ...then check whether it would have warned about either of the
2562 // candidates for a signedness conversion to the condition type.
2563 if (E->getType() != T) {
2564 Suspicious = false;
2565 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
2566 E->getType(), &Suspicious);
2567 if (!Suspicious)
2568 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
2569 E->getType(), &Suspicious);
2570 if (!Suspicious)
2571 return;
2572 }
2573
2574 // If so, emit a diagnostic under -Wsign-compare.
2575 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
2576 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
2577 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
2578 << lex->getType() << rex->getType()
2579 << lex->getSourceRange() << rex->getSourceRange();
2580}
2581
2582/// AnalyzeImplicitConversions - Find and report any interesting
2583/// implicit conversions in the given expression. There are a couple
2584/// of competing diagnostics here, -Wconversion and -Wsign-compare.
2585void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
2586 QualType T = OrigE->getType();
2587 Expr *E = OrigE->IgnoreParenImpCasts();
2588
2589 // For conditional operators, we analyze the arguments as if they
2590 // were being fed directly into the output.
2591 if (isa<ConditionalOperator>(E)) {
2592 ConditionalOperator *CO = cast<ConditionalOperator>(E);
2593 CheckConditionalOperator(S, CO, T);
2594 return;
2595 }
2596
2597 // Go ahead and check any implicit conversions we might have skipped.
2598 // The non-canonical typecheck is just an optimization;
2599 // CheckImplicitConversion will filter out dead implicit conversions.
2600 if (E->getType() != T)
2601 CheckImplicitConversion(S, E, T);
2602
2603 // Now continue drilling into this expression.
2604
2605 // Skip past explicit casts.
2606 if (isa<ExplicitCastExpr>(E)) {
2607 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
2608 return AnalyzeImplicitConversions(S, E);
2609 }
2610
2611 // Do a somewhat different check with comparison operators.
2612 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
2613 return AnalyzeComparison(S, cast<BinaryOperator>(E));
2614
2615 // These break the otherwise-useful invariant below. Fortunately,
2616 // we don't really need to recurse into them, because any internal
2617 // expressions should have been analyzed already when they were
2618 // built into statements.
2619 if (isa<StmtExpr>(E)) return;
2620
2621 // Don't descend into unevaluated contexts.
2622 if (isa<SizeOfAlignOfExpr>(E)) return;
2623
2624 // Now just recurse over the expression's children.
2625 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
2626 I != IE; ++I)
2627 AnalyzeImplicitConversions(S, cast<Expr>(*I));
2628}
2629
2630} // end anonymous namespace
2631
2632/// Diagnoses "dangerous" implicit conversions within the given
2633/// expression (which is a full expression). Implements -Wconversion
2634/// and -Wsign-compare.
2635void Sema::CheckImplicitConversions(Expr *E) {
2636 // Don't diagnose in unevaluated contexts.
2637 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
2638 return;
2639
2640 // Don't diagnose for value- or type-dependent expressions.
2641 if (E->isTypeDependent() || E->isValueDependent())
2642 return;
2643
2644 AnalyzeImplicitConversions(*this, E);
2645}
2646
Mike Stumpf8c49212010-01-21 03:59:47 +00002647/// CheckParmsForFunctionDef - Check that the parameters of the given
2648/// function are appropriate for the definition of a function. This
2649/// takes care of any checks that cannot be performed on the
2650/// declaration itself, e.g., that the types of each of the function
2651/// parameters are complete.
2652bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2653 bool HasInvalidParm = false;
2654 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2655 ParmVarDecl *Param = FD->getParamDecl(p);
2656
2657 // C99 6.7.5.3p4: the parameters in a parameter type list in a
2658 // function declarator that is part of a function definition of
2659 // that function shall not have incomplete type.
2660 //
2661 // This is also C++ [dcl.fct]p6.
2662 if (!Param->isInvalidDecl() &&
2663 RequireCompleteType(Param->getLocation(), Param->getType(),
2664 diag::err_typecheck_decl_incomplete_type)) {
2665 Param->setInvalidDecl();
2666 HasInvalidParm = true;
2667 }
2668
2669 // C99 6.9.1p5: If the declarator includes a parameter type list, the
2670 // declaration of each parameter shall include an identifier.
2671 if (Param->getIdentifier() == 0 &&
2672 !Param->isImplicit() &&
2673 !getLangOptions().CPlusPlus)
2674 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00002675
2676 // C99 6.7.5.3p12:
2677 // If the function declarator is not part of a definition of that
2678 // function, parameters may have incomplete type and may use the [*]
2679 // notation in their sequences of declarator specifiers to specify
2680 // variable length array types.
2681 QualType PType = Param->getOriginalType();
2682 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
2683 if (AT->getSizeModifier() == ArrayType::Star) {
2684 // FIXME: This diagnosic should point the the '[*]' if source-location
2685 // information is added for it.
2686 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
2687 }
2688 }
Mike Stumpf8c49212010-01-21 03:59:47 +00002689 }
2690
2691 return HasInvalidParm;
2692}