Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 1 | /* |
Rob Clark | 8bb0daf | 2013-02-11 12:43:09 -0500 | [diff] [blame] | 2 | * drivers/gpu/drm/omapdrm/omap_crtc.c |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 3 | * |
| 4 | * Copyright (C) 2011 Texas Instruments |
| 5 | * Author: Rob Clark <rob@ti.com> |
| 6 | * |
| 7 | * This program is free software; you can redistribute it and/or modify it |
| 8 | * under the terms of the GNU General Public License version 2 as published by |
| 9 | * the Free Software Foundation. |
| 10 | * |
| 11 | * This program is distributed in the hope that it will be useful, but WITHOUT |
| 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
| 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for |
| 14 | * more details. |
| 15 | * |
| 16 | * You should have received a copy of the GNU General Public License along with |
| 17 | * this program. If not, see <http://www.gnu.org/licenses/>. |
| 18 | */ |
| 19 | |
Laurent Pinchart | 69a1226 | 2015-03-05 21:38:16 +0200 | [diff] [blame] | 20 | #include <drm/drm_atomic.h> |
| 21 | #include <drm/drm_atomic_helper.h> |
Laurent Pinchart | 2d278f5 | 2015-03-05 21:31:37 +0200 | [diff] [blame] | 22 | #include <drm/drm_crtc.h> |
| 23 | #include <drm/drm_crtc_helper.h> |
Andy Gross | b9ed9f0 | 2012-10-16 00:17:40 -0500 | [diff] [blame] | 24 | #include <drm/drm_mode.h> |
Daniel Vetter | 3cb9ae4 | 2014-10-29 10:03:57 +0100 | [diff] [blame] | 25 | #include <drm/drm_plane_helper.h> |
Laurent Pinchart | 2d278f5 | 2015-03-05 21:31:37 +0200 | [diff] [blame] | 26 | |
| 27 | #include "omap_drv.h" |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 28 | |
| 29 | #define to_omap_crtc(x) container_of(x, struct omap_crtc, base) |
| 30 | |
| 31 | struct omap_crtc { |
| 32 | struct drm_crtc base; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 33 | |
Rob Clark | bb5c2d9 | 2012-01-16 12:51:16 -0600 | [diff] [blame] | 34 | const char *name; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 35 | enum omap_channel channel; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 36 | |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 37 | struct omap_video_timings timings; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 38 | |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 39 | struct omap_drm_irq vblank_irq; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 40 | struct omap_drm_irq error_irq; |
| 41 | |
Tomi Valkeinen | a36af73 | 2015-02-26 15:20:24 +0200 | [diff] [blame] | 42 | bool ignore_digit_sync_lost; |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 43 | |
| 44 | bool pending; |
| 45 | wait_queue_head_t pending_wait; |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 46 | }; |
| 47 | |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 48 | /* ----------------------------------------------------------------------------- |
| 49 | * Helper Functions |
| 50 | */ |
| 51 | |
Archit Taneja | 0d8f371 | 2013-03-26 19:15:19 +0530 | [diff] [blame] | 52 | uint32_t pipe2vbl(struct drm_crtc *crtc) |
| 53 | { |
| 54 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
| 55 | |
| 56 | return dispc_mgr_get_vsync_irq(omap_crtc->channel); |
| 57 | } |
| 58 | |
Laurent Pinchart | 4029755 | 2015-05-28 02:34:05 +0300 | [diff] [blame] | 59 | struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc) |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 60 | { |
| 61 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
| 62 | return &omap_crtc->timings; |
| 63 | } |
| 64 | |
| 65 | enum omap_channel omap_crtc_channel(struct drm_crtc *crtc) |
| 66 | { |
| 67 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
| 68 | return omap_crtc->channel; |
| 69 | } |
| 70 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 71 | int omap_crtc_wait_pending(struct drm_crtc *crtc) |
| 72 | { |
| 73 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
| 74 | |
Tomi Valkeinen | 61f3c40 | 2015-11-19 17:31:25 +0200 | [diff] [blame] | 75 | /* |
| 76 | * Timeout is set to a "sufficiently" high value, which should cover |
| 77 | * a single frame refresh even on slower displays. |
| 78 | */ |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 79 | return wait_event_timeout(omap_crtc->pending_wait, |
| 80 | !omap_crtc->pending, |
Tomi Valkeinen | 61f3c40 | 2015-11-19 17:31:25 +0200 | [diff] [blame] | 81 | msecs_to_jiffies(250)); |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 82 | } |
| 83 | |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 84 | /* ----------------------------------------------------------------------------- |
| 85 | * DSS Manager Functions |
| 86 | */ |
| 87 | |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 88 | /* |
| 89 | * Manager-ops, callbacks from output when they need to configure |
| 90 | * the upstream part of the video pipe. |
| 91 | * |
| 92 | * Most of these we can ignore until we add support for command-mode |
| 93 | * panels.. for video-mode the crtc-helpers already do an adequate |
| 94 | * job of sequencing the setup of the video pipe in the proper order |
| 95 | */ |
| 96 | |
Tomi Valkeinen | 04b1fc0 | 2013-05-14 10:55:19 +0300 | [diff] [blame] | 97 | /* ovl-mgr-id -> crtc */ |
| 98 | static struct omap_crtc *omap_crtcs[8]; |
Tomi Valkeinen | 3a92413 | 2015-10-21 16:34:08 +0300 | [diff] [blame] | 99 | static struct omap_dss_device *omap_crtc_output[8]; |
Tomi Valkeinen | 04b1fc0 | 2013-05-14 10:55:19 +0300 | [diff] [blame] | 100 | |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 101 | /* we can probably ignore these until we support command-mode panels: */ |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 102 | static int omap_crtc_dss_connect(enum omap_channel channel, |
Tomi Valkeinen | 1f68d9c | 2013-04-19 15:09:34 +0300 | [diff] [blame] | 103 | struct omap_dss_device *dst) |
Tomi Valkeinen | a7e71e7 | 2013-05-08 16:23:32 +0300 | [diff] [blame] | 104 | { |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 105 | struct omap_overlay_manager *mgr = omap_dss_get_overlay_manager(channel); |
| 106 | |
| 107 | if (omap_crtc_output[channel]) |
Tomi Valkeinen | a7e71e7 | 2013-05-08 16:23:32 +0300 | [diff] [blame] | 108 | return -EINVAL; |
| 109 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 110 | if ((dispc_mgr_get_supported_outputs(channel) & dst->id) == 0) |
Tomi Valkeinen | a7e71e7 | 2013-05-08 16:23:32 +0300 | [diff] [blame] | 111 | return -EINVAL; |
| 112 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 113 | omap_crtc_output[channel] = dst; |
Tomi Valkeinen | 4923950 | 2015-11-05 09:34:31 +0200 | [diff] [blame^] | 114 | dst->dispc_channel_connected = true; |
Tomi Valkeinen | 3a92413 | 2015-10-21 16:34:08 +0300 | [diff] [blame] | 115 | |
Tomi Valkeinen | a7e71e7 | 2013-05-08 16:23:32 +0300 | [diff] [blame] | 116 | dst->manager = mgr; |
| 117 | mgr->output = dst; |
| 118 | |
| 119 | return 0; |
| 120 | } |
| 121 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 122 | static void omap_crtc_dss_disconnect(enum omap_channel channel, |
Tomi Valkeinen | 1f68d9c | 2013-04-19 15:09:34 +0300 | [diff] [blame] | 123 | struct omap_dss_device *dst) |
Tomi Valkeinen | a7e71e7 | 2013-05-08 16:23:32 +0300 | [diff] [blame] | 124 | { |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 125 | struct omap_overlay_manager *mgr = omap_dss_get_overlay_manager(channel); |
| 126 | |
| 127 | omap_crtc_output[channel] = NULL; |
Tomi Valkeinen | 4923950 | 2015-11-05 09:34:31 +0200 | [diff] [blame^] | 128 | dst->dispc_channel_connected = false; |
Tomi Valkeinen | 3a92413 | 2015-10-21 16:34:08 +0300 | [diff] [blame] | 129 | |
Tomi Valkeinen | a7e71e7 | 2013-05-08 16:23:32 +0300 | [diff] [blame] | 130 | mgr->output->manager = NULL; |
| 131 | mgr->output = NULL; |
| 132 | } |
| 133 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 134 | static void omap_crtc_dss_start_update(enum omap_channel channel) |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 135 | { |
| 136 | } |
| 137 | |
Laurent Pinchart | 4029755 | 2015-05-28 02:34:05 +0300 | [diff] [blame] | 138 | /* Called only from the encoder enable/disable and suspend/resume handlers. */ |
Laurent Pinchart | 8472b57 | 2015-01-15 00:45:17 +0200 | [diff] [blame] | 139 | static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) |
| 140 | { |
| 141 | struct drm_device *dev = crtc->dev; |
| 142 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
| 143 | enum omap_channel channel = omap_crtc->channel; |
| 144 | struct omap_irq_wait *wait; |
| 145 | u32 framedone_irq, vsync_irq; |
| 146 | int ret; |
| 147 | |
Tomi Valkeinen | 3a92413 | 2015-10-21 16:34:08 +0300 | [diff] [blame] | 148 | if (omap_crtc_output[channel]->output_type == OMAP_DISPLAY_TYPE_HDMI) { |
Tomi Valkeinen | 4e4b53c | 2015-03-24 15:46:35 +0200 | [diff] [blame] | 149 | dispc_mgr_enable(channel, enable); |
| 150 | return; |
| 151 | } |
| 152 | |
Laurent Pinchart | 8472b57 | 2015-01-15 00:45:17 +0200 | [diff] [blame] | 153 | if (dispc_mgr_is_enabled(channel) == enable) |
| 154 | return; |
| 155 | |
Tomi Valkeinen | ef42228 | 2015-02-26 15:20:25 +0200 | [diff] [blame] | 156 | if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) { |
| 157 | /* |
| 158 | * Digit output produces some sync lost interrupts during the |
| 159 | * first frame when enabling, so we need to ignore those. |
| 160 | */ |
| 161 | omap_crtc->ignore_digit_sync_lost = true; |
| 162 | } |
Laurent Pinchart | 8472b57 | 2015-01-15 00:45:17 +0200 | [diff] [blame] | 163 | |
| 164 | framedone_irq = dispc_mgr_get_framedone_irq(channel); |
| 165 | vsync_irq = dispc_mgr_get_vsync_irq(channel); |
| 166 | |
| 167 | if (enable) { |
| 168 | wait = omap_irq_wait_init(dev, vsync_irq, 1); |
| 169 | } else { |
| 170 | /* |
| 171 | * When we disable the digit output, we need to wait for |
| 172 | * FRAMEDONE to know that DISPC has finished with the output. |
| 173 | * |
| 174 | * OMAP2/3 does not have FRAMEDONE irq for digit output, and in |
| 175 | * that case we need to use vsync interrupt, and wait for both |
| 176 | * even and odd frames. |
| 177 | */ |
| 178 | |
| 179 | if (framedone_irq) |
| 180 | wait = omap_irq_wait_init(dev, framedone_irq, 1); |
| 181 | else |
| 182 | wait = omap_irq_wait_init(dev, vsync_irq, 2); |
| 183 | } |
| 184 | |
| 185 | dispc_mgr_enable(channel, enable); |
| 186 | |
| 187 | ret = omap_irq_wait(dev, wait, msecs_to_jiffies(100)); |
| 188 | if (ret) { |
| 189 | dev_err(dev->dev, "%s: timeout waiting for %s\n", |
| 190 | omap_crtc->name, enable ? "enable" : "disable"); |
| 191 | } |
| 192 | |
Tomi Valkeinen | ef42228 | 2015-02-26 15:20:25 +0200 | [diff] [blame] | 193 | if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) { |
| 194 | omap_crtc->ignore_digit_sync_lost = false; |
| 195 | /* make sure the irq handler sees the value above */ |
| 196 | mb(); |
| 197 | } |
Laurent Pinchart | 8472b57 | 2015-01-15 00:45:17 +0200 | [diff] [blame] | 198 | } |
| 199 | |
Tomi Valkeinen | 506096a | 2014-04-03 13:11:54 +0300 | [diff] [blame] | 200 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 201 | static int omap_crtc_dss_enable(enum omap_channel channel) |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 202 | { |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 203 | struct omap_crtc *omap_crtc = omap_crtcs[channel]; |
Laurent Pinchart | dee8260 | 2015-03-06 19:00:18 +0200 | [diff] [blame] | 204 | struct omap_overlay_manager_info info; |
Tomi Valkeinen | 506096a | 2014-04-03 13:11:54 +0300 | [diff] [blame] | 205 | |
Laurent Pinchart | dee8260 | 2015-03-06 19:00:18 +0200 | [diff] [blame] | 206 | memset(&info, 0, sizeof(info)); |
| 207 | info.default_color = 0x00000000; |
| 208 | info.trans_key = 0x00000000; |
| 209 | info.trans_key_type = OMAP_DSS_COLOR_KEY_GFX_DST; |
| 210 | info.trans_enabled = false; |
| 211 | |
| 212 | dispc_mgr_setup(omap_crtc->channel, &info); |
Tomi Valkeinen | 506096a | 2014-04-03 13:11:54 +0300 | [diff] [blame] | 213 | dispc_mgr_set_timings(omap_crtc->channel, |
| 214 | &omap_crtc->timings); |
Laurent Pinchart | 8472b57 | 2015-01-15 00:45:17 +0200 | [diff] [blame] | 215 | omap_crtc_set_enabled(&omap_crtc->base, true); |
Tomi Valkeinen | 506096a | 2014-04-03 13:11:54 +0300 | [diff] [blame] | 216 | |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 217 | return 0; |
| 218 | } |
| 219 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 220 | static void omap_crtc_dss_disable(enum omap_channel channel) |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 221 | { |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 222 | struct omap_crtc *omap_crtc = omap_crtcs[channel]; |
Tomi Valkeinen | 506096a | 2014-04-03 13:11:54 +0300 | [diff] [blame] | 223 | |
Laurent Pinchart | 8472b57 | 2015-01-15 00:45:17 +0200 | [diff] [blame] | 224 | omap_crtc_set_enabled(&omap_crtc->base, false); |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 225 | } |
| 226 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 227 | static void omap_crtc_dss_set_timings(enum omap_channel channel, |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 228 | const struct omap_video_timings *timings) |
| 229 | { |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 230 | struct omap_crtc *omap_crtc = omap_crtcs[channel]; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 231 | DBG("%s", omap_crtc->name); |
| 232 | omap_crtc->timings = *timings; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 233 | } |
| 234 | |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 235 | static void omap_crtc_dss_set_lcd_config(enum omap_channel channel, |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 236 | const struct dss_lcd_mgr_config *config) |
| 237 | { |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 238 | struct omap_crtc *omap_crtc = omap_crtcs[channel]; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 239 | DBG("%s", omap_crtc->name); |
| 240 | dispc_mgr_set_lcd_config(omap_crtc->channel, config); |
| 241 | } |
| 242 | |
Laurent Pinchart | 4343f0f | 2015-03-05 22:01:02 +0200 | [diff] [blame] | 243 | static int omap_crtc_dss_register_framedone( |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 244 | enum omap_channel channel, |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 245 | void (*handler)(void *), void *data) |
| 246 | { |
| 247 | return 0; |
| 248 | } |
| 249 | |
Laurent Pinchart | 4343f0f | 2015-03-05 22:01:02 +0200 | [diff] [blame] | 250 | static void omap_crtc_dss_unregister_framedone( |
Tomi Valkeinen | e5cbb6e | 2015-11-04 19:36:26 +0200 | [diff] [blame] | 251 | enum omap_channel channel, |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 252 | void (*handler)(void *), void *data) |
| 253 | { |
| 254 | } |
| 255 | |
| 256 | static const struct dss_mgr_ops mgr_ops = { |
Laurent Pinchart | 4343f0f | 2015-03-05 22:01:02 +0200 | [diff] [blame] | 257 | .connect = omap_crtc_dss_connect, |
| 258 | .disconnect = omap_crtc_dss_disconnect, |
| 259 | .start_update = omap_crtc_dss_start_update, |
| 260 | .enable = omap_crtc_dss_enable, |
| 261 | .disable = omap_crtc_dss_disable, |
| 262 | .set_timings = omap_crtc_dss_set_timings, |
| 263 | .set_lcd_config = omap_crtc_dss_set_lcd_config, |
| 264 | .register_framedone_handler = omap_crtc_dss_register_framedone, |
| 265 | .unregister_framedone_handler = omap_crtc_dss_unregister_framedone, |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 266 | }; |
| 267 | |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 268 | /* ----------------------------------------------------------------------------- |
Laurent Pinchart | 1d5e5ea | 2015-01-18 16:57:36 +0200 | [diff] [blame] | 269 | * Setup, Flush and Page Flip |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 270 | */ |
| 271 | |
Laurent Pinchart | fa16d26 | 2015-03-06 16:01:53 +0200 | [diff] [blame] | 272 | static void omap_crtc_complete_page_flip(struct drm_crtc *crtc) |
Laurent Pinchart | 15d02e9 | 2015-01-25 22:42:30 +0200 | [diff] [blame] | 273 | { |
Laurent Pinchart | fa16d26 | 2015-03-06 16:01:53 +0200 | [diff] [blame] | 274 | struct drm_pending_vblank_event *event; |
Laurent Pinchart | 15d02e9 | 2015-01-25 22:42:30 +0200 | [diff] [blame] | 275 | struct drm_device *dev = crtc->dev; |
Laurent Pinchart | fa16d26 | 2015-03-06 16:01:53 +0200 | [diff] [blame] | 276 | unsigned long flags; |
Laurent Pinchart | 15d02e9 | 2015-01-25 22:42:30 +0200 | [diff] [blame] | 277 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 278 | event = crtc->state->event; |
Laurent Pinchart | fa16d26 | 2015-03-06 16:01:53 +0200 | [diff] [blame] | 279 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 280 | if (!event) |
Laurent Pinchart | c397cfd | 2015-01-25 22:42:30 +0200 | [diff] [blame] | 281 | return; |
| 282 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 283 | spin_lock_irqsave(&dev->event_lock, flags); |
Laurent Pinchart | c397cfd | 2015-01-25 22:42:30 +0200 | [diff] [blame] | 284 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 285 | list_del(&event->base.link); |
| 286 | |
| 287 | /* |
| 288 | * Queue the event for delivery if it's still linked to a file |
| 289 | * handle, otherwise just destroy it. |
| 290 | */ |
| 291 | if (event->base.file_priv) |
| 292 | drm_crtc_send_vblank_event(crtc, event); |
| 293 | else |
| 294 | event->base.destroy(&event->base); |
| 295 | |
| 296 | spin_unlock_irqrestore(&dev->event_lock, flags); |
Laurent Pinchart | 15d02e9 | 2015-01-25 22:42:30 +0200 | [diff] [blame] | 297 | } |
| 298 | |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 299 | static void omap_crtc_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus) |
| 300 | { |
| 301 | struct omap_crtc *omap_crtc = |
| 302 | container_of(irq, struct omap_crtc, error_irq); |
Tomi Valkeinen | a36af73 | 2015-02-26 15:20:24 +0200 | [diff] [blame] | 303 | |
| 304 | if (omap_crtc->ignore_digit_sync_lost) { |
| 305 | irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT; |
| 306 | if (!irqstatus) |
| 307 | return; |
| 308 | } |
| 309 | |
Tomi Valkeinen | 3b143fc | 2014-11-19 12:50:13 +0200 | [diff] [blame] | 310 | DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_crtc->name, irqstatus); |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 311 | } |
| 312 | |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 313 | static void omap_crtc_vblank_irq(struct omap_drm_irq *irq, uint32_t irqstatus) |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 314 | { |
| 315 | struct omap_crtc *omap_crtc = |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 316 | container_of(irq, struct omap_crtc, vblank_irq); |
| 317 | struct drm_device *dev = omap_crtc->base.dev; |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 318 | |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 319 | if (dispc_mgr_go_busy(omap_crtc->channel)) |
| 320 | return; |
| 321 | |
| 322 | DBG("%s: apply done", omap_crtc->name); |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 323 | |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 324 | __omap_irq_unregister(dev, &omap_crtc->vblank_irq); |
| 325 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 326 | rmb(); |
| 327 | WARN_ON(!omap_crtc->pending); |
| 328 | omap_crtc->pending = false; |
| 329 | wmb(); |
| 330 | |
| 331 | /* wake up userspace */ |
Laurent Pinchart | fa16d26 | 2015-03-06 16:01:53 +0200 | [diff] [blame] | 332 | omap_crtc_complete_page_flip(&omap_crtc->base); |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 333 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 334 | /* wake up omap_atomic_complete */ |
| 335 | wake_up(&omap_crtc->pending_wait); |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 336 | } |
| 337 | |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 338 | /* ----------------------------------------------------------------------------- |
| 339 | * CRTC Functions |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 340 | */ |
| 341 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 342 | static void omap_crtc_destroy(struct drm_crtc *crtc) |
| 343 | { |
| 344 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 345 | |
| 346 | DBG("%s", omap_crtc->name); |
| 347 | |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 348 | WARN_ON(omap_crtc->vblank_irq.registered); |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 349 | omap_irq_unregister(crtc->dev, &omap_crtc->error_irq); |
| 350 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 351 | drm_crtc_cleanup(crtc); |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 352 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 353 | kfree(omap_crtc); |
| 354 | } |
| 355 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 356 | static bool omap_crtc_mode_fixup(struct drm_crtc *crtc, |
Laurent Pinchart | e811f5a | 2012-07-17 17:56:50 +0200 | [diff] [blame] | 357 | const struct drm_display_mode *mode, |
Rob Clark | bb5c2d9 | 2012-01-16 12:51:16 -0600 | [diff] [blame] | 358 | struct drm_display_mode *adjusted_mode) |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 359 | { |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 360 | return true; |
| 361 | } |
| 362 | |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 363 | static void omap_crtc_enable(struct drm_crtc *crtc) |
| 364 | { |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 365 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 366 | |
| 367 | DBG("%s", omap_crtc->name); |
| 368 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 369 | rmb(); |
| 370 | WARN_ON(omap_crtc->pending); |
| 371 | omap_crtc->pending = true; |
| 372 | wmb(); |
| 373 | |
| 374 | omap_irq_register(crtc->dev, &omap_crtc->vblank_irq); |
| 375 | |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 376 | drm_crtc_vblank_on(crtc); |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 377 | } |
| 378 | |
| 379 | static void omap_crtc_disable(struct drm_crtc *crtc) |
| 380 | { |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 381 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 382 | |
| 383 | DBG("%s", omap_crtc->name); |
| 384 | |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 385 | drm_crtc_vblank_off(crtc); |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 386 | } |
| 387 | |
Laurent Pinchart | f7a73b6 | 2015-03-05 13:45:14 +0200 | [diff] [blame] | 388 | static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc) |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 389 | { |
| 390 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
Laurent Pinchart | f7a73b6 | 2015-03-05 13:45:14 +0200 | [diff] [blame] | 391 | struct drm_display_mode *mode = &crtc->state->adjusted_mode; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 392 | |
| 393 | DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x", |
Laurent Pinchart | f7a73b6 | 2015-03-05 13:45:14 +0200 | [diff] [blame] | 394 | omap_crtc->name, mode->base.id, mode->name, |
| 395 | mode->vrefresh, mode->clock, |
| 396 | mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal, |
| 397 | mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal, |
| 398 | mode->type, mode->flags); |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 399 | |
| 400 | copy_timings_drm_to_omap(&omap_crtc->timings, mode); |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 401 | } |
| 402 | |
Daniel Vetter | c201d00 | 2015-08-06 14:09:35 +0200 | [diff] [blame] | 403 | static void omap_crtc_atomic_begin(struct drm_crtc *crtc, |
| 404 | struct drm_crtc_state *old_crtc_state) |
Laurent Pinchart | de8e410 | 2015-03-05 13:39:56 +0200 | [diff] [blame] | 405 | { |
Laurent Pinchart | de8e410 | 2015-03-05 13:39:56 +0200 | [diff] [blame] | 406 | } |
| 407 | |
Daniel Vetter | c201d00 | 2015-08-06 14:09:35 +0200 | [diff] [blame] | 408 | static void omap_crtc_atomic_flush(struct drm_crtc *crtc, |
| 409 | struct drm_crtc_state *old_crtc_state) |
Laurent Pinchart | de8e410 | 2015-03-05 13:39:56 +0200 | [diff] [blame] | 410 | { |
Tomi Valkeinen | 6646dfd | 2015-06-08 13:08:25 +0300 | [diff] [blame] | 411 | struct omap_crtc *omap_crtc = to_omap_crtc(crtc); |
| 412 | |
| 413 | WARN_ON(omap_crtc->vblank_irq.registered); |
| 414 | |
| 415 | if (dispc_mgr_is_enabled(omap_crtc->channel)) { |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 416 | |
Tomi Valkeinen | 6646dfd | 2015-06-08 13:08:25 +0300 | [diff] [blame] | 417 | DBG("%s: GO", omap_crtc->name); |
| 418 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 419 | rmb(); |
| 420 | WARN_ON(omap_crtc->pending); |
| 421 | omap_crtc->pending = true; |
| 422 | wmb(); |
| 423 | |
Tomi Valkeinen | 6646dfd | 2015-06-08 13:08:25 +0300 | [diff] [blame] | 424 | dispc_mgr_go(omap_crtc->channel); |
| 425 | omap_irq_register(crtc->dev, &omap_crtc->vblank_irq); |
Tomi Valkeinen | 6646dfd | 2015-06-08 13:08:25 +0300 | [diff] [blame] | 426 | } |
Laurent Pinchart | de8e410 | 2015-03-05 13:39:56 +0200 | [diff] [blame] | 427 | } |
| 428 | |
Tomi Valkeinen | 6bdad6c | 2016-02-18 18:47:14 +0200 | [diff] [blame] | 429 | static bool omap_crtc_is_plane_prop(struct drm_device *dev, |
| 430 | struct drm_property *property) |
| 431 | { |
| 432 | struct omap_drm_private *priv = dev->dev_private; |
| 433 | |
| 434 | return property == priv->zorder_prop || |
| 435 | property == dev->mode_config.rotation_property; |
| 436 | } |
| 437 | |
Laurent Pinchart | afc3493 | 2015-03-06 18:35:16 +0200 | [diff] [blame] | 438 | static int omap_crtc_atomic_set_property(struct drm_crtc *crtc, |
| 439 | struct drm_crtc_state *state, |
| 440 | struct drm_property *property, |
| 441 | uint64_t val) |
Rob Clark | 3c810c6 | 2012-08-15 15:18:01 -0500 | [diff] [blame] | 442 | { |
Tomi Valkeinen | 6bdad6c | 2016-02-18 18:47:14 +0200 | [diff] [blame] | 443 | struct drm_device *dev = crtc->dev; |
Rob Clark | 1e0fdfc | 2012-09-04 11:36:20 -0500 | [diff] [blame] | 444 | |
Tomi Valkeinen | 6bdad6c | 2016-02-18 18:47:14 +0200 | [diff] [blame] | 445 | if (omap_crtc_is_plane_prop(dev, property)) { |
| 446 | struct drm_plane_state *plane_state; |
| 447 | struct drm_plane *plane = crtc->primary; |
Laurent Pinchart | afc3493 | 2015-03-06 18:35:16 +0200 | [diff] [blame] | 448 | |
Tomi Valkeinen | 6bdad6c | 2016-02-18 18:47:14 +0200 | [diff] [blame] | 449 | /* |
| 450 | * Delegate property set to the primary plane. Get the plane |
| 451 | * state and set the property directly. |
| 452 | */ |
Laurent Pinchart | afc3493 | 2015-03-06 18:35:16 +0200 | [diff] [blame] | 453 | |
Tomi Valkeinen | 6bdad6c | 2016-02-18 18:47:14 +0200 | [diff] [blame] | 454 | plane_state = drm_atomic_get_plane_state(state->state, plane); |
| 455 | if (IS_ERR(plane_state)) |
| 456 | return PTR_ERR(plane_state); |
| 457 | |
| 458 | return drm_atomic_plane_set_property(plane, plane_state, |
| 459 | property, val); |
| 460 | } |
| 461 | |
| 462 | return -EINVAL; |
Laurent Pinchart | afc3493 | 2015-03-06 18:35:16 +0200 | [diff] [blame] | 463 | } |
| 464 | |
| 465 | static int omap_crtc_atomic_get_property(struct drm_crtc *crtc, |
| 466 | const struct drm_crtc_state *state, |
| 467 | struct drm_property *property, |
| 468 | uint64_t *val) |
| 469 | { |
Tomi Valkeinen | 6bdad6c | 2016-02-18 18:47:14 +0200 | [diff] [blame] | 470 | struct drm_device *dev = crtc->dev; |
| 471 | |
| 472 | if (omap_crtc_is_plane_prop(dev, property)) { |
| 473 | /* |
| 474 | * Delegate property get to the primary plane. The |
| 475 | * drm_atomic_plane_get_property() function isn't exported, but |
| 476 | * can be called through drm_object_property_get_value() as that |
| 477 | * will call drm_atomic_get_property() for atomic drivers. |
| 478 | */ |
| 479 | return drm_object_property_get_value(&crtc->primary->base, |
| 480 | property, val); |
| 481 | } |
| 482 | |
| 483 | return -EINVAL; |
Rob Clark | 3c810c6 | 2012-08-15 15:18:01 -0500 | [diff] [blame] | 484 | } |
| 485 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 486 | static const struct drm_crtc_funcs omap_crtc_funcs = { |
Laurent Pinchart | 69a1226 | 2015-03-05 21:38:16 +0200 | [diff] [blame] | 487 | .reset = drm_atomic_helper_crtc_reset, |
Laurent Pinchart | 9416c9d | 2015-03-05 21:54:54 +0200 | [diff] [blame] | 488 | .set_config = drm_atomic_helper_set_config, |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 489 | .destroy = omap_crtc_destroy, |
Laurent Pinchart | fa16d26 | 2015-03-06 16:01:53 +0200 | [diff] [blame] | 490 | .page_flip = drm_atomic_helper_page_flip, |
Laurent Pinchart | afc3493 | 2015-03-06 18:35:16 +0200 | [diff] [blame] | 491 | .set_property = drm_atomic_helper_crtc_set_property, |
Laurent Pinchart | 69a1226 | 2015-03-05 21:38:16 +0200 | [diff] [blame] | 492 | .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, |
| 493 | .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, |
Laurent Pinchart | afc3493 | 2015-03-06 18:35:16 +0200 | [diff] [blame] | 494 | .atomic_set_property = omap_crtc_atomic_set_property, |
| 495 | .atomic_get_property = omap_crtc_atomic_get_property, |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 496 | }; |
| 497 | |
| 498 | static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = { |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 499 | .mode_fixup = omap_crtc_mode_fixup, |
Laurent Pinchart | f7a73b6 | 2015-03-05 13:45:14 +0200 | [diff] [blame] | 500 | .mode_set_nofb = omap_crtc_mode_set_nofb, |
Laurent Pinchart | f1d57fb | 2015-03-05 22:13:22 +0200 | [diff] [blame] | 501 | .disable = omap_crtc_disable, |
| 502 | .enable = omap_crtc_enable, |
Laurent Pinchart | de8e410 | 2015-03-05 13:39:56 +0200 | [diff] [blame] | 503 | .atomic_begin = omap_crtc_atomic_begin, |
| 504 | .atomic_flush = omap_crtc_atomic_flush, |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 505 | }; |
| 506 | |
Laurent Pinchart | 971fb3e | 2015-01-18 01:12:59 +0200 | [diff] [blame] | 507 | /* ----------------------------------------------------------------------------- |
| 508 | * Init and Cleanup |
| 509 | */ |
Tomi Valkeinen | e2f8fd7 | 2014-04-02 14:31:57 +0300 | [diff] [blame] | 510 | |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 511 | static const char *channel_names[] = { |
Laurent Pinchart | 222025e | 2015-01-11 00:02:07 +0200 | [diff] [blame] | 512 | [OMAP_DSS_CHANNEL_LCD] = "lcd", |
| 513 | [OMAP_DSS_CHANNEL_DIGIT] = "tv", |
| 514 | [OMAP_DSS_CHANNEL_LCD2] = "lcd2", |
| 515 | [OMAP_DSS_CHANNEL_LCD3] = "lcd3", |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 516 | }; |
| 517 | |
Tomi Valkeinen | 04b1fc0 | 2013-05-14 10:55:19 +0300 | [diff] [blame] | 518 | void omap_crtc_pre_init(void) |
| 519 | { |
| 520 | dss_install_mgr_ops(&mgr_ops); |
| 521 | } |
| 522 | |
Archit Taneja | 3a01ab2 | 2014-01-02 14:49:51 +0530 | [diff] [blame] | 523 | void omap_crtc_pre_uninit(void) |
| 524 | { |
| 525 | dss_uninstall_mgr_ops(); |
| 526 | } |
| 527 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 528 | /* initialize crtc */ |
| 529 | struct drm_crtc *omap_crtc_init(struct drm_device *dev, |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 530 | struct drm_plane *plane, enum omap_channel channel, int id) |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 531 | { |
| 532 | struct drm_crtc *crtc = NULL; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 533 | struct omap_crtc *omap_crtc; |
Laurent Pinchart | ef6b0e0 | 2015-01-11 00:11:18 +0200 | [diff] [blame] | 534 | int ret; |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 535 | |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 536 | DBG("%s", channel_names[channel]); |
| 537 | |
| 538 | omap_crtc = kzalloc(sizeof(*omap_crtc), GFP_KERNEL); |
Joe Perches | 78110bb | 2013-02-11 09:41:29 -0800 | [diff] [blame] | 539 | if (!omap_crtc) |
Laurent Pinchart | ef6b0e0 | 2015-01-11 00:11:18 +0200 | [diff] [blame] | 540 | return NULL; |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 541 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 542 | crtc = &omap_crtc->base; |
Rob Clark | bb5c2d9 | 2012-01-16 12:51:16 -0600 | [diff] [blame] | 543 | |
Tomi Valkeinen | 5f741b3 | 2015-05-29 16:01:18 +0300 | [diff] [blame] | 544 | init_waitqueue_head(&omap_crtc->pending_wait); |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 545 | |
Archit Taneja | 0d8f371 | 2013-03-26 19:15:19 +0530 | [diff] [blame] | 546 | omap_crtc->channel = channel; |
Archit Taneja | 0d8f371 | 2013-03-26 19:15:19 +0530 | [diff] [blame] | 547 | omap_crtc->name = channel_names[channel]; |
Archit Taneja | 0d8f371 | 2013-03-26 19:15:19 +0530 | [diff] [blame] | 548 | |
Laurent Pinchart | a42133a | 2015-01-17 19:09:26 +0200 | [diff] [blame] | 549 | omap_crtc->vblank_irq.irqmask = pipe2vbl(crtc); |
| 550 | omap_crtc->vblank_irq.irq = omap_crtc_vblank_irq; |
Rob Clark | f5f9454 | 2012-12-04 13:59:12 -0600 | [diff] [blame] | 551 | |
| 552 | omap_crtc->error_irq.irqmask = |
| 553 | dispc_mgr_get_sync_lost_irq(channel); |
| 554 | omap_crtc->error_irq.irq = omap_crtc_error_irq; |
| 555 | omap_irq_register(dev, &omap_crtc->error_irq); |
| 556 | |
Laurent Pinchart | ef6b0e0 | 2015-01-11 00:11:18 +0200 | [diff] [blame] | 557 | ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL, |
Ville Syrjälä | f988287 | 2015-12-09 16:19:31 +0200 | [diff] [blame] | 558 | &omap_crtc_funcs, NULL); |
Laurent Pinchart | ef6b0e0 | 2015-01-11 00:11:18 +0200 | [diff] [blame] | 559 | if (ret < 0) { |
| 560 | kfree(omap_crtc); |
| 561 | return NULL; |
| 562 | } |
| 563 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 564 | drm_crtc_helper_add(crtc, &omap_crtc_helper_funcs); |
| 565 | |
Laurent Pinchart | ef6b0e0 | 2015-01-11 00:11:18 +0200 | [diff] [blame] | 566 | omap_plane_install_properties(crtc->primary, &crtc->base); |
Rob Clark | 3c810c6 | 2012-08-15 15:18:01 -0500 | [diff] [blame] | 567 | |
Tomi Valkeinen | 04b1fc0 | 2013-05-14 10:55:19 +0300 | [diff] [blame] | 568 | omap_crtcs[channel] = omap_crtc; |
| 569 | |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 570 | return crtc; |
Rob Clark | cd5351f | 2011-11-12 12:09:40 -0600 | [diff] [blame] | 571 | } |