Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright © 2014 Intel Corporation |
| 3 | * |
| 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 5 | * copy of this software and associated documentation files (the "Software"), |
| 6 | * to deal in the Software without restriction, including without limitation |
| 7 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 8 | * and/or sell copies of the Software, and to permit persons to whom the |
| 9 | * Software is furnished to do so, subject to the following conditions: |
| 10 | * |
| 11 | * The above copyright notice and this permission notice (including the next |
| 12 | * paragraph) shall be included in all copies or substantial portions of the |
| 13 | * Software. |
| 14 | * |
| 15 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
| 16 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 17 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 18 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
| 19 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING |
| 20 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER |
| 21 | * DEALINGS IN THE SOFTWARE. |
| 22 | */ |
| 23 | |
| 24 | #include <linux/kernel.h> |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 25 | #include <linux/component.h> |
| 26 | #include <drm/i915_component.h> |
| 27 | #include "intel_drv.h" |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 28 | |
| 29 | #include <drm/drmP.h> |
| 30 | #include <drm/drm_edid.h> |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 31 | #include "i915_drv.h" |
| 32 | |
Jani Nikula | 28855d2 | 2014-10-27 16:27:00 +0200 | [diff] [blame] | 33 | /** |
| 34 | * DOC: High Definition Audio over HDMI and Display Port |
| 35 | * |
| 36 | * The graphics and audio drivers together support High Definition Audio over |
| 37 | * HDMI and Display Port. The audio programming sequences are divided into audio |
| 38 | * codec and controller enable and disable sequences. The graphics driver |
| 39 | * handles the audio codec sequences, while the audio driver handles the audio |
| 40 | * controller sequences. |
| 41 | * |
| 42 | * The disable sequences must be performed before disabling the transcoder or |
| 43 | * port. The enable sequences may only be performed after enabling the |
Jani Nikula | 3e6da4a | 2015-07-02 16:05:27 +0300 | [diff] [blame] | 44 | * transcoder and port, and after completed link training. Therefore the audio |
| 45 | * enable/disable sequences are part of the modeset sequence. |
Jani Nikula | 28855d2 | 2014-10-27 16:27:00 +0200 | [diff] [blame] | 46 | * |
| 47 | * The codec and controller sequences could be done either parallel or serial, |
| 48 | * but generally the ELDV/PD change in the codec sequence indicates to the audio |
| 49 | * driver that the controller sequence should start. Indeed, most of the |
| 50 | * co-operation between the graphics and audio drivers is handled via audio |
| 51 | * related registers. (The notable exception is the power management, not |
| 52 | * covered here.) |
| 53 | */ |
| 54 | |
Jani Nikula | 87fcb2a | 2014-10-27 16:26:44 +0200 | [diff] [blame] | 55 | static const struct { |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 56 | int clock; |
| 57 | u32 config; |
| 58 | } hdmi_audio_clock[] = { |
| 59 | { DIV_ROUND_UP(25200 * 1000, 1001), AUD_CONFIG_PIXEL_CLOCK_HDMI_25175 }, |
| 60 | { 25200, AUD_CONFIG_PIXEL_CLOCK_HDMI_25200 }, /* default per bspec */ |
| 61 | { 27000, AUD_CONFIG_PIXEL_CLOCK_HDMI_27000 }, |
| 62 | { 27000 * 1001 / 1000, AUD_CONFIG_PIXEL_CLOCK_HDMI_27027 }, |
| 63 | { 54000, AUD_CONFIG_PIXEL_CLOCK_HDMI_54000 }, |
| 64 | { 54000 * 1001 / 1000, AUD_CONFIG_PIXEL_CLOCK_HDMI_54054 }, |
| 65 | { DIV_ROUND_UP(74250 * 1000, 1001), AUD_CONFIG_PIXEL_CLOCK_HDMI_74176 }, |
| 66 | { 74250, AUD_CONFIG_PIXEL_CLOCK_HDMI_74250 }, |
| 67 | { DIV_ROUND_UP(148500 * 1000, 1001), AUD_CONFIG_PIXEL_CLOCK_HDMI_148352 }, |
| 68 | { 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 }, |
| 69 | }; |
| 70 | |
| 71 | /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */ |
| 72 | static u32 audio_config_hdmi_pixel_clock(struct drm_display_mode *mode) |
| 73 | { |
| 74 | int i; |
| 75 | |
| 76 | for (i = 0; i < ARRAY_SIZE(hdmi_audio_clock); i++) { |
| 77 | if (mode->clock == hdmi_audio_clock[i].clock) |
| 78 | break; |
| 79 | } |
| 80 | |
| 81 | if (i == ARRAY_SIZE(hdmi_audio_clock)) { |
| 82 | DRM_DEBUG_KMS("HDMI audio pixel clock setting for %d not found, falling back to defaults\n", mode->clock); |
| 83 | i = 1; |
| 84 | } |
| 85 | |
| 86 | DRM_DEBUG_KMS("Configuring HDMI audio for pixel clock %d (0x%08x)\n", |
| 87 | hdmi_audio_clock[i].clock, |
| 88 | hdmi_audio_clock[i].config); |
| 89 | |
| 90 | return hdmi_audio_clock[i].config; |
| 91 | } |
| 92 | |
| 93 | static bool intel_eld_uptodate(struct drm_connector *connector, |
| 94 | int reg_eldv, uint32_t bits_eldv, |
| 95 | int reg_elda, uint32_t bits_elda, |
| 96 | int reg_edid) |
| 97 | { |
| 98 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
| 99 | uint8_t *eld = connector->eld; |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 100 | uint32_t tmp; |
| 101 | int i; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 102 | |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 103 | tmp = I915_READ(reg_eldv); |
| 104 | tmp &= bits_eldv; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 105 | |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 106 | if (!tmp) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 107 | return false; |
| 108 | |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 109 | tmp = I915_READ(reg_elda); |
| 110 | tmp &= ~bits_elda; |
| 111 | I915_WRITE(reg_elda, tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 112 | |
Jani Nikula | 938fd8a | 2014-10-28 16:20:48 +0200 | [diff] [blame] | 113 | for (i = 0; i < drm_eld_size(eld) / 4; i++) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 114 | if (I915_READ(reg_edid) != *((uint32_t *)eld + i)) |
| 115 | return false; |
| 116 | |
| 117 | return true; |
| 118 | } |
| 119 | |
Jani Nikula | 76d8d3e | 2014-10-27 16:26:57 +0200 | [diff] [blame] | 120 | static void g4x_audio_codec_disable(struct intel_encoder *encoder) |
| 121 | { |
| 122 | struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; |
| 123 | uint32_t eldv, tmp; |
| 124 | |
| 125 | DRM_DEBUG_KMS("Disable audio codec\n"); |
| 126 | |
| 127 | tmp = I915_READ(G4X_AUD_VID_DID); |
| 128 | if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL) |
| 129 | eldv = G4X_ELDV_DEVCL_DEVBLC; |
| 130 | else |
| 131 | eldv = G4X_ELDV_DEVCTG; |
| 132 | |
| 133 | /* Invalidate ELD */ |
| 134 | tmp = I915_READ(G4X_AUD_CNTL_ST); |
| 135 | tmp &= ~eldv; |
| 136 | I915_WRITE(G4X_AUD_CNTL_ST, tmp); |
| 137 | } |
| 138 | |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 139 | static void g4x_audio_codec_enable(struct drm_connector *connector, |
| 140 | struct intel_encoder *encoder, |
| 141 | struct drm_display_mode *mode) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 142 | { |
| 143 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
| 144 | uint8_t *eld = connector->eld; |
| 145 | uint32_t eldv; |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 146 | uint32_t tmp; |
| 147 | int len, i; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 148 | |
Jani Nikula | d5ee08d | 2014-10-27 16:26:58 +0200 | [diff] [blame] | 149 | DRM_DEBUG_KMS("Enable audio codec, %u bytes ELD\n", eld[2]); |
| 150 | |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 151 | tmp = I915_READ(G4X_AUD_VID_DID); |
| 152 | if (tmp == INTEL_AUDIO_DEVBLC || tmp == INTEL_AUDIO_DEVCL) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 153 | eldv = G4X_ELDV_DEVCL_DEVBLC; |
| 154 | else |
| 155 | eldv = G4X_ELDV_DEVCTG; |
| 156 | |
| 157 | if (intel_eld_uptodate(connector, |
| 158 | G4X_AUD_CNTL_ST, eldv, |
Jani Nikula | c46f111 | 2014-10-27 16:26:52 +0200 | [diff] [blame] | 159 | G4X_AUD_CNTL_ST, G4X_ELD_ADDR_MASK, |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 160 | G4X_HDMIW_HDMIEDID)) |
| 161 | return; |
| 162 | |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 163 | tmp = I915_READ(G4X_AUD_CNTL_ST); |
Jani Nikula | c46f111 | 2014-10-27 16:26:52 +0200 | [diff] [blame] | 164 | tmp &= ~(eldv | G4X_ELD_ADDR_MASK); |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 165 | len = (tmp >> 9) & 0x1f; /* ELD buffer size */ |
| 166 | I915_WRITE(G4X_AUD_CNTL_ST, tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 167 | |
Jani Nikula | 938fd8a | 2014-10-28 16:20:48 +0200 | [diff] [blame] | 168 | len = min(drm_eld_size(eld) / 4, len); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 169 | DRM_DEBUG_DRIVER("ELD size %d\n", len); |
| 170 | for (i = 0; i < len; i++) |
| 171 | I915_WRITE(G4X_HDMIW_HDMIEDID, *((uint32_t *)eld + i)); |
| 172 | |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 173 | tmp = I915_READ(G4X_AUD_CNTL_ST); |
| 174 | tmp |= eldv; |
| 175 | I915_WRITE(G4X_AUD_CNTL_ST, tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 176 | } |
| 177 | |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 178 | static void hsw_audio_codec_disable(struct intel_encoder *encoder) |
| 179 | { |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 180 | struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; |
| 181 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
| 182 | enum pipe pipe = intel_crtc->pipe; |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 183 | uint32_t tmp; |
| 184 | |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 185 | DRM_DEBUG_KMS("Disable audio codec on pipe %c\n", pipe_name(pipe)); |
| 186 | |
| 187 | /* Disable timestamps */ |
| 188 | tmp = I915_READ(HSW_AUD_CFG(pipe)); |
| 189 | tmp &= ~AUD_CONFIG_N_VALUE_INDEX; |
| 190 | tmp |= AUD_CONFIG_N_PROG_ENABLE; |
| 191 | tmp &= ~AUD_CONFIG_UPPER_N_MASK; |
| 192 | tmp &= ~AUD_CONFIG_LOWER_N_MASK; |
| 193 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) |
| 194 | tmp |= AUD_CONFIG_N_VALUE_INDEX; |
| 195 | I915_WRITE(HSW_AUD_CFG(pipe), tmp); |
| 196 | |
| 197 | /* Invalidate ELD */ |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 198 | tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD); |
Jani Nikula | 82910ac | 2014-10-27 16:26:59 +0200 | [diff] [blame] | 199 | tmp &= ~AUDIO_ELD_VALID(pipe); |
Jani Nikula | eb45fa0 | 2014-11-18 12:11:29 +0200 | [diff] [blame] | 200 | tmp &= ~AUDIO_OUTPUT_ENABLE(pipe); |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 201 | I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp); |
| 202 | } |
| 203 | |
| 204 | static void hsw_audio_codec_enable(struct drm_connector *connector, |
| 205 | struct intel_encoder *encoder, |
| 206 | struct drm_display_mode *mode) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 207 | { |
| 208 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
Jani Nikula | 820d2d7 | 2014-10-27 16:26:47 +0200 | [diff] [blame] | 209 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 210 | enum pipe pipe = intel_crtc->pipe; |
| 211 | const uint8_t *eld = connector->eld; |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 212 | uint32_t tmp; |
| 213 | int len, i; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 214 | |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 215 | DRM_DEBUG_KMS("Enable audio codec on pipe %c, %u bytes ELD\n", |
Jani Nikula | 938fd8a | 2014-10-28 16:20:48 +0200 | [diff] [blame] | 216 | pipe_name(pipe), drm_eld_size(eld)); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 217 | |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 218 | /* Enable audio presence detect, invalidate ELD */ |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 219 | tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD); |
Jani Nikula | 82910ac | 2014-10-27 16:26:59 +0200 | [diff] [blame] | 220 | tmp |= AUDIO_OUTPUT_ENABLE(pipe); |
| 221 | tmp &= ~AUDIO_ELD_VALID(pipe); |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 222 | I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp); |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 223 | |
| 224 | /* |
| 225 | * FIXME: We're supposed to wait for vblank here, but we have vblanks |
| 226 | * disabled during the mode set. The proper fix would be to push the |
| 227 | * rest of the setup into a vblank work item, queued here, but the |
| 228 | * infrastructure is not there yet. |
| 229 | */ |
| 230 | |
| 231 | /* Reset ELD write address */ |
| 232 | tmp = I915_READ(HSW_AUD_DIP_ELD_CTRL(pipe)); |
| 233 | tmp &= ~IBX_ELD_ADDRESS_MASK; |
| 234 | I915_WRITE(HSW_AUD_DIP_ELD_CTRL(pipe), tmp); |
| 235 | |
| 236 | /* Up to 84 bytes of hw ELD buffer */ |
Jani Nikula | 938fd8a | 2014-10-28 16:20:48 +0200 | [diff] [blame] | 237 | len = min(drm_eld_size(eld), 84); |
| 238 | for (i = 0; i < len / 4; i++) |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 239 | I915_WRITE(HSW_AUD_EDID_DATA(pipe), *((uint32_t *)eld + i)); |
| 240 | |
| 241 | /* ELD valid */ |
| 242 | tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD); |
Jani Nikula | 82910ac | 2014-10-27 16:26:59 +0200 | [diff] [blame] | 243 | tmp |= AUDIO_ELD_VALID(pipe); |
Jani Nikula | 5fad84a | 2014-11-04 10:30:23 +0200 | [diff] [blame] | 244 | I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp); |
| 245 | |
| 246 | /* Enable timestamps */ |
| 247 | tmp = I915_READ(HSW_AUD_CFG(pipe)); |
| 248 | tmp &= ~AUD_CONFIG_N_VALUE_INDEX; |
| 249 | tmp &= ~AUD_CONFIG_N_PROG_ENABLE; |
| 250 | tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK; |
| 251 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) |
| 252 | tmp |= AUD_CONFIG_N_VALUE_INDEX; |
| 253 | else |
| 254 | tmp |= audio_config_hdmi_pixel_clock(mode); |
| 255 | I915_WRITE(HSW_AUD_CFG(pipe), tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 256 | } |
| 257 | |
Jani Nikula | 495a5bb | 2014-10-27 16:26:55 +0200 | [diff] [blame] | 258 | static void ilk_audio_codec_disable(struct intel_encoder *encoder) |
| 259 | { |
| 260 | struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; |
| 261 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
| 262 | struct intel_digital_port *intel_dig_port = |
| 263 | enc_to_dig_port(&encoder->base); |
| 264 | enum port port = intel_dig_port->port; |
| 265 | enum pipe pipe = intel_crtc->pipe; |
| 266 | uint32_t tmp, eldv; |
| 267 | int aud_config; |
| 268 | int aud_cntrl_st2; |
| 269 | |
| 270 | DRM_DEBUG_KMS("Disable audio codec on port %c, pipe %c\n", |
| 271 | port_name(port), pipe_name(pipe)); |
| 272 | |
Jani Nikula | d3902c3 | 2015-05-04 17:20:49 +0300 | [diff] [blame] | 273 | if (WARN_ON(port == PORT_A)) |
| 274 | return; |
| 275 | |
Jani Nikula | 495a5bb | 2014-10-27 16:26:55 +0200 | [diff] [blame] | 276 | if (HAS_PCH_IBX(dev_priv->dev)) { |
| 277 | aud_config = IBX_AUD_CFG(pipe); |
| 278 | aud_cntrl_st2 = IBX_AUD_CNTL_ST2; |
| 279 | } else if (IS_VALLEYVIEW(dev_priv)) { |
| 280 | aud_config = VLV_AUD_CFG(pipe); |
| 281 | aud_cntrl_st2 = VLV_AUD_CNTL_ST2; |
| 282 | } else { |
| 283 | aud_config = CPT_AUD_CFG(pipe); |
| 284 | aud_cntrl_st2 = CPT_AUD_CNTRL_ST2; |
| 285 | } |
| 286 | |
| 287 | /* Disable timestamps */ |
| 288 | tmp = I915_READ(aud_config); |
| 289 | tmp &= ~AUD_CONFIG_N_VALUE_INDEX; |
| 290 | tmp |= AUD_CONFIG_N_PROG_ENABLE; |
| 291 | tmp &= ~AUD_CONFIG_UPPER_N_MASK; |
| 292 | tmp &= ~AUD_CONFIG_LOWER_N_MASK; |
| 293 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) |
| 294 | tmp |= AUD_CONFIG_N_VALUE_INDEX; |
| 295 | I915_WRITE(aud_config, tmp); |
| 296 | |
Jani Nikula | d3902c3 | 2015-05-04 17:20:49 +0300 | [diff] [blame] | 297 | eldv = IBX_ELD_VALID(port); |
Jani Nikula | 495a5bb | 2014-10-27 16:26:55 +0200 | [diff] [blame] | 298 | |
| 299 | /* Invalidate ELD */ |
| 300 | tmp = I915_READ(aud_cntrl_st2); |
| 301 | tmp &= ~eldv; |
| 302 | I915_WRITE(aud_cntrl_st2, tmp); |
| 303 | } |
| 304 | |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 305 | static void ilk_audio_codec_enable(struct drm_connector *connector, |
| 306 | struct intel_encoder *encoder, |
| 307 | struct drm_display_mode *mode) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 308 | { |
| 309 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
Jani Nikula | 820d2d7 | 2014-10-27 16:26:47 +0200 | [diff] [blame] | 310 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 311 | struct intel_digital_port *intel_dig_port = |
| 312 | enc_to_dig_port(&encoder->base); |
| 313 | enum port port = intel_dig_port->port; |
| 314 | enum pipe pipe = intel_crtc->pipe; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 315 | uint8_t *eld = connector->eld; |
| 316 | uint32_t eldv; |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 317 | uint32_t tmp; |
| 318 | int len, i; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 319 | int hdmiw_hdmiedid; |
| 320 | int aud_config; |
| 321 | int aud_cntl_st; |
| 322 | int aud_cntrl_st2; |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 323 | |
| 324 | DRM_DEBUG_KMS("Enable audio codec on port %c, pipe %c, %u bytes ELD\n", |
Jani Nikula | 938fd8a | 2014-10-28 16:20:48 +0200 | [diff] [blame] | 325 | port_name(port), pipe_name(pipe), drm_eld_size(eld)); |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 326 | |
Jani Nikula | d3902c3 | 2015-05-04 17:20:49 +0300 | [diff] [blame] | 327 | if (WARN_ON(port == PORT_A)) |
| 328 | return; |
| 329 | |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 330 | /* |
| 331 | * FIXME: We're supposed to wait for vblank here, but we have vblanks |
| 332 | * disabled during the mode set. The proper fix would be to push the |
| 333 | * rest of the setup into a vblank work item, queued here, but the |
| 334 | * infrastructure is not there yet. |
| 335 | */ |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 336 | |
| 337 | if (HAS_PCH_IBX(connector->dev)) { |
| 338 | hdmiw_hdmiedid = IBX_HDMIW_HDMIEDID(pipe); |
| 339 | aud_config = IBX_AUD_CFG(pipe); |
| 340 | aud_cntl_st = IBX_AUD_CNTL_ST(pipe); |
| 341 | aud_cntrl_st2 = IBX_AUD_CNTL_ST2; |
| 342 | } else if (IS_VALLEYVIEW(connector->dev)) { |
| 343 | hdmiw_hdmiedid = VLV_HDMIW_HDMIEDID(pipe); |
| 344 | aud_config = VLV_AUD_CFG(pipe); |
| 345 | aud_cntl_st = VLV_AUD_CNTL_ST(pipe); |
| 346 | aud_cntrl_st2 = VLV_AUD_CNTL_ST2; |
| 347 | } else { |
| 348 | hdmiw_hdmiedid = CPT_HDMIW_HDMIEDID(pipe); |
| 349 | aud_config = CPT_AUD_CFG(pipe); |
| 350 | aud_cntl_st = CPT_AUD_CNTL_ST(pipe); |
| 351 | aud_cntrl_st2 = CPT_AUD_CNTRL_ST2; |
| 352 | } |
| 353 | |
Jani Nikula | d3902c3 | 2015-05-04 17:20:49 +0300 | [diff] [blame] | 354 | eldv = IBX_ELD_VALID(port); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 355 | |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 356 | /* Invalidate ELD */ |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 357 | tmp = I915_READ(aud_cntrl_st2); |
| 358 | tmp &= ~eldv; |
| 359 | I915_WRITE(aud_cntrl_st2, tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 360 | |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 361 | /* Reset ELD write address */ |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 362 | tmp = I915_READ(aud_cntl_st); |
Jani Nikula | c46f111 | 2014-10-27 16:26:52 +0200 | [diff] [blame] | 363 | tmp &= ~IBX_ELD_ADDRESS_MASK; |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 364 | I915_WRITE(aud_cntl_st, tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 365 | |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 366 | /* Up to 84 bytes of hw ELD buffer */ |
Jani Nikula | 938fd8a | 2014-10-28 16:20:48 +0200 | [diff] [blame] | 367 | len = min(drm_eld_size(eld), 84); |
| 368 | for (i = 0; i < len / 4; i++) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 369 | I915_WRITE(hdmiw_hdmiedid, *((uint32_t *)eld + i)); |
| 370 | |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 371 | /* ELD valid */ |
Jani Nikula | f9f682a | 2014-10-27 16:26:45 +0200 | [diff] [blame] | 372 | tmp = I915_READ(aud_cntrl_st2); |
| 373 | tmp |= eldv; |
| 374 | I915_WRITE(aud_cntrl_st2, tmp); |
Jani Nikula | c6bde93 | 2014-11-04 10:31:28 +0200 | [diff] [blame] | 375 | |
| 376 | /* Enable timestamps */ |
| 377 | tmp = I915_READ(aud_config); |
| 378 | tmp &= ~AUD_CONFIG_N_VALUE_INDEX; |
| 379 | tmp &= ~AUD_CONFIG_N_PROG_ENABLE; |
| 380 | tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK; |
| 381 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) |
| 382 | tmp |= AUD_CONFIG_N_VALUE_INDEX; |
| 383 | else |
| 384 | tmp |= audio_config_hdmi_pixel_clock(mode); |
| 385 | I915_WRITE(aud_config, tmp); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 386 | } |
| 387 | |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 388 | /** |
| 389 | * intel_audio_codec_enable - Enable the audio codec for HD audio |
| 390 | * @intel_encoder: encoder on which to enable audio |
| 391 | * |
| 392 | * The enable sequences may only be performed after enabling the transcoder and |
| 393 | * port, and after completed link training. |
| 394 | */ |
| 395 | void intel_audio_codec_enable(struct intel_encoder *intel_encoder) |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 396 | { |
Jani Nikula | 33d1e7c6 | 2014-10-27 16:26:46 +0200 | [diff] [blame] | 397 | struct drm_encoder *encoder = &intel_encoder->base; |
| 398 | struct intel_crtc *crtc = to_intel_crtc(encoder->crtc); |
Ander Conselvan de Oliveira | 6e3c971 | 2015-01-15 14:55:25 +0200 | [diff] [blame] | 399 | struct drm_display_mode *mode = &crtc->config->base.adjusted_mode; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 400 | struct drm_connector *connector; |
| 401 | struct drm_device *dev = encoder->dev; |
| 402 | struct drm_i915_private *dev_priv = dev->dev_private; |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 403 | struct i915_audio_component *acomp = dev_priv->audio_component; |
| 404 | struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder); |
| 405 | enum port port = intel_dig_port->port; |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 406 | |
| 407 | connector = drm_select_eld(encoder, mode); |
| 408 | if (!connector) |
| 409 | return; |
| 410 | |
| 411 | DRM_DEBUG_DRIVER("ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n", |
| 412 | connector->base.id, |
| 413 | connector->name, |
| 414 | connector->encoder->base.id, |
| 415 | connector->encoder->name); |
| 416 | |
Jani Nikula | 6189b03 | 2014-10-28 13:53:01 +0200 | [diff] [blame] | 417 | /* ELD Conn_Type */ |
| 418 | connector->eld[5] &= ~(3 << 2); |
| 419 | if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) |
| 420 | connector->eld[5] |= (1 << 2); |
| 421 | |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 422 | connector->eld[6] = drm_av_sync_delay(connector, mode) / 2; |
| 423 | |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 424 | if (dev_priv->display.audio_codec_enable) |
| 425 | dev_priv->display.audio_codec_enable(connector, intel_encoder, mode); |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 426 | |
| 427 | if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) |
David Henningsson | f0675d4 | 2015-09-03 11:51:34 +0200 | [diff] [blame] | 428 | acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr, (int) port); |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 429 | } |
| 430 | |
| 431 | /** |
| 432 | * intel_audio_codec_disable - Disable the audio codec for HD audio |
Geliang Tang | 95d0be6 | 2015-09-15 06:04:36 -0700 | [diff] [blame^] | 433 | * @intel_encoder: encoder on which to disable audio |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 434 | * |
| 435 | * The disable sequences must be performed before disabling the transcoder or |
| 436 | * port. |
| 437 | */ |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 438 | void intel_audio_codec_disable(struct intel_encoder *intel_encoder) |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 439 | { |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 440 | struct drm_encoder *encoder = &intel_encoder->base; |
| 441 | struct drm_device *dev = encoder->dev; |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 442 | struct drm_i915_private *dev_priv = dev->dev_private; |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 443 | struct i915_audio_component *acomp = dev_priv->audio_component; |
| 444 | struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder); |
| 445 | enum port port = intel_dig_port->port; |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 446 | |
| 447 | if (dev_priv->display.audio_codec_disable) |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 448 | dev_priv->display.audio_codec_disable(intel_encoder); |
| 449 | |
| 450 | if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) |
David Henningsson | f0675d4 | 2015-09-03 11:51:34 +0200 | [diff] [blame] | 451 | acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr, (int) port); |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 452 | } |
| 453 | |
| 454 | /** |
| 455 | * intel_init_audio - Set up chip specific audio functions |
| 456 | * @dev: drm device |
| 457 | */ |
| 458 | void intel_init_audio(struct drm_device *dev) |
| 459 | { |
| 460 | struct drm_i915_private *dev_priv = dev->dev_private; |
| 461 | |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 462 | if (IS_G4X(dev)) { |
| 463 | dev_priv->display.audio_codec_enable = g4x_audio_codec_enable; |
Jani Nikula | 76d8d3e | 2014-10-27 16:26:57 +0200 | [diff] [blame] | 464 | dev_priv->display.audio_codec_disable = g4x_audio_codec_disable; |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 465 | } else if (IS_VALLEYVIEW(dev)) { |
| 466 | dev_priv->display.audio_codec_enable = ilk_audio_codec_enable; |
Jani Nikula | 495a5bb | 2014-10-27 16:26:55 +0200 | [diff] [blame] | 467 | dev_priv->display.audio_codec_disable = ilk_audio_codec_disable; |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 468 | } else if (IS_HASWELL(dev) || INTEL_INFO(dev)->gen >= 8) { |
| 469 | dev_priv->display.audio_codec_enable = hsw_audio_codec_enable; |
| 470 | dev_priv->display.audio_codec_disable = hsw_audio_codec_disable; |
| 471 | } else if (HAS_PCH_SPLIT(dev)) { |
| 472 | dev_priv->display.audio_codec_enable = ilk_audio_codec_enable; |
Jani Nikula | 495a5bb | 2014-10-27 16:26:55 +0200 | [diff] [blame] | 473 | dev_priv->display.audio_codec_disable = ilk_audio_codec_disable; |
Jani Nikula | 69bfe1a | 2014-10-27 16:26:50 +0200 | [diff] [blame] | 474 | } |
Jani Nikula | 7c10a2b | 2014-10-27 16:26:43 +0200 | [diff] [blame] | 475 | } |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 476 | |
| 477 | static void i915_audio_component_get_power(struct device *dev) |
| 478 | { |
| 479 | intel_display_power_get(dev_to_i915(dev), POWER_DOMAIN_AUDIO); |
| 480 | } |
| 481 | |
| 482 | static void i915_audio_component_put_power(struct device *dev) |
| 483 | { |
| 484 | intel_display_power_put(dev_to_i915(dev), POWER_DOMAIN_AUDIO); |
| 485 | } |
| 486 | |
Lu, Han | 632f3ab | 2015-05-05 09:05:47 +0800 | [diff] [blame] | 487 | static void i915_audio_component_codec_wake_override(struct device *dev, |
| 488 | bool enable) |
| 489 | { |
| 490 | struct drm_i915_private *dev_priv = dev_to_i915(dev); |
| 491 | u32 tmp; |
| 492 | |
| 493 | if (!IS_SKYLAKE(dev_priv)) |
| 494 | return; |
| 495 | |
| 496 | /* |
| 497 | * Enable/disable generating the codec wake signal, overriding the |
| 498 | * internal logic to generate the codec wake to controller. |
| 499 | */ |
| 500 | tmp = I915_READ(HSW_AUD_CHICKENBIT); |
| 501 | tmp &= ~SKL_AUD_CODEC_WAKE_SIGNAL; |
| 502 | I915_WRITE(HSW_AUD_CHICKENBIT, tmp); |
| 503 | usleep_range(1000, 1500); |
| 504 | |
| 505 | if (enable) { |
| 506 | tmp = I915_READ(HSW_AUD_CHICKENBIT); |
| 507 | tmp |= SKL_AUD_CODEC_WAKE_SIGNAL; |
| 508 | I915_WRITE(HSW_AUD_CHICKENBIT, tmp); |
| 509 | usleep_range(1000, 1500); |
| 510 | } |
| 511 | } |
| 512 | |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 513 | /* Get CDCLK in kHz */ |
| 514 | static int i915_audio_component_get_cdclk_freq(struct device *dev) |
| 515 | { |
| 516 | struct drm_i915_private *dev_priv = dev_to_i915(dev); |
| 517 | int ret; |
| 518 | |
| 519 | if (WARN_ON_ONCE(!HAS_DDI(dev_priv))) |
| 520 | return -ENODEV; |
| 521 | |
| 522 | intel_display_power_get(dev_priv, POWER_DOMAIN_AUDIO); |
Ville Syrjälä | 1652d19 | 2015-03-31 14:12:01 +0300 | [diff] [blame] | 523 | ret = dev_priv->display.get_display_clock_speed(dev_priv->dev); |
| 524 | |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 525 | intel_display_power_put(dev_priv, POWER_DOMAIN_AUDIO); |
| 526 | |
| 527 | return ret; |
| 528 | } |
| 529 | |
| 530 | static const struct i915_audio_component_ops i915_audio_component_ops = { |
| 531 | .owner = THIS_MODULE, |
| 532 | .get_power = i915_audio_component_get_power, |
| 533 | .put_power = i915_audio_component_put_power, |
Lu, Han | 632f3ab | 2015-05-05 09:05:47 +0800 | [diff] [blame] | 534 | .codec_wake_override = i915_audio_component_codec_wake_override, |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 535 | .get_cdclk_freq = i915_audio_component_get_cdclk_freq, |
| 536 | }; |
| 537 | |
| 538 | static int i915_audio_component_bind(struct device *i915_dev, |
| 539 | struct device *hda_dev, void *data) |
| 540 | { |
| 541 | struct i915_audio_component *acomp = data; |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 542 | struct drm_i915_private *dev_priv = dev_to_i915(i915_dev); |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 543 | |
| 544 | if (WARN_ON(acomp->ops || acomp->dev)) |
| 545 | return -EEXIST; |
| 546 | |
David Henningsson | d5f362a | 2015-09-03 11:51:35 +0200 | [diff] [blame] | 547 | drm_modeset_lock_all(dev_priv->dev); |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 548 | acomp->ops = &i915_audio_component_ops; |
| 549 | acomp->dev = i915_dev; |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 550 | dev_priv->audio_component = acomp; |
David Henningsson | d5f362a | 2015-09-03 11:51:35 +0200 | [diff] [blame] | 551 | drm_modeset_unlock_all(dev_priv->dev); |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 552 | |
| 553 | return 0; |
| 554 | } |
| 555 | |
| 556 | static void i915_audio_component_unbind(struct device *i915_dev, |
| 557 | struct device *hda_dev, void *data) |
| 558 | { |
| 559 | struct i915_audio_component *acomp = data; |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 560 | struct drm_i915_private *dev_priv = dev_to_i915(i915_dev); |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 561 | |
David Henningsson | d5f362a | 2015-09-03 11:51:35 +0200 | [diff] [blame] | 562 | drm_modeset_lock_all(dev_priv->dev); |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 563 | acomp->ops = NULL; |
| 564 | acomp->dev = NULL; |
David Henningsson | 51e1d83 | 2015-08-19 10:48:56 +0200 | [diff] [blame] | 565 | dev_priv->audio_component = NULL; |
David Henningsson | d5f362a | 2015-09-03 11:51:35 +0200 | [diff] [blame] | 566 | drm_modeset_unlock_all(dev_priv->dev); |
Imre Deak | 58fddc2 | 2015-01-08 17:54:14 +0200 | [diff] [blame] | 567 | } |
| 568 | |
| 569 | static const struct component_ops i915_audio_component_bind_ops = { |
| 570 | .bind = i915_audio_component_bind, |
| 571 | .unbind = i915_audio_component_unbind, |
| 572 | }; |
| 573 | |
| 574 | /** |
| 575 | * i915_audio_component_init - initialize and register the audio component |
| 576 | * @dev_priv: i915 device instance |
| 577 | * |
| 578 | * This will register with the component framework a child component which |
| 579 | * will bind dynamically to the snd_hda_intel driver's corresponding master |
| 580 | * component when the latter is registered. During binding the child |
| 581 | * initializes an instance of struct i915_audio_component which it receives |
| 582 | * from the master. The master can then start to use the interface defined by |
| 583 | * this struct. Each side can break the binding at any point by deregistering |
| 584 | * its own component after which each side's component unbind callback is |
| 585 | * called. |
| 586 | * |
| 587 | * We ignore any error during registration and continue with reduced |
| 588 | * functionality (i.e. without HDMI audio). |
| 589 | */ |
| 590 | void i915_audio_component_init(struct drm_i915_private *dev_priv) |
| 591 | { |
| 592 | int ret; |
| 593 | |
| 594 | ret = component_add(dev_priv->dev->dev, &i915_audio_component_bind_ops); |
| 595 | if (ret < 0) { |
| 596 | DRM_ERROR("failed to add audio component (%d)\n", ret); |
| 597 | /* continue with reduced functionality */ |
| 598 | return; |
| 599 | } |
| 600 | |
| 601 | dev_priv->audio_component_registered = true; |
| 602 | } |
| 603 | |
| 604 | /** |
| 605 | * i915_audio_component_cleanup - deregister the audio component |
| 606 | * @dev_priv: i915 device instance |
| 607 | * |
| 608 | * Deregisters the audio component, breaking any existing binding to the |
| 609 | * corresponding snd_hda_intel driver's master component. |
| 610 | */ |
| 611 | void i915_audio_component_cleanup(struct drm_i915_private *dev_priv) |
| 612 | { |
| 613 | if (!dev_priv->audio_component_registered) |
| 614 | return; |
| 615 | |
| 616 | component_del(dev_priv->dev->dev, &i915_audio_component_bind_ops); |
| 617 | dev_priv->audio_component_registered = false; |
| 618 | } |