blob: 335c00209f746fb003d6133413a67a5ec68297bc [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af82016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
22
23/* bpf_check() is a static code analyzer that walks eBPF program
24 * instruction by instruction and updates register/stack state.
25 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
26 *
27 * The first pass is depth-first-search to check that the program is a DAG.
28 * It rejects the following programs:
29 * - larger than BPF_MAXINSNS insns
30 * - if loop is present (detected via back-edge)
31 * - unreachable insns exist (shouldn't be a forest. program = one function)
32 * - out of bounds or malformed jumps
33 * The second pass is all possible path descent from the 1st insn.
34 * Since it's analyzing all pathes through the program, the length of the
35 * analysis is limited to 32k insn, which may be hit even if total number of
36 * insn is less then 4K, but there are too many branches that change stack/regs.
37 * Number of 'branches to be analyzed' is limited to 1k
38 *
39 * On entry to each instruction, each register has a type, and the instruction
40 * changes the types of the registers depending on instruction semantics.
41 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
42 * copied to R1.
43 *
44 * All registers are 64-bit.
45 * R0 - return register
46 * R1-R5 argument passing registers
47 * R6-R9 callee saved registers
48 * R10 - frame pointer read-only
49 *
50 * At the start of BPF program the register R1 contains a pointer to bpf_context
51 * and has type PTR_TO_CTX.
52 *
53 * Verifier tracks arithmetic operations on pointers in case:
54 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
55 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
56 * 1st insn copies R10 (which has FRAME_PTR) type into R1
57 * and 2nd arithmetic instruction is pattern matched to recognize
58 * that it wants to construct a pointer to some element within stack.
59 * So after 2nd insn, the register R1 has type PTR_TO_STACK
60 * (and -20 constant is saved for further stack bounds checking).
61 * Meaning that this reg is a pointer to stack plus known immediate constant.
62 *
63 * Most of the time the registers have UNKNOWN_VALUE type, which
64 * means the register has some value, but it's not a valid pointer.
65 * (like pointer plus pointer becomes UNKNOWN_VALUE type)
66 *
67 * When verifier sees load or store instructions the type of base register
68 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, FRAME_PTR. These are three pointer
69 * types recognized by check_mem_access() function.
70 *
71 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
72 * and the range of [ptr, ptr + map's value_size) is accessible.
73 *
74 * registers used to pass values to function calls are checked against
75 * function argument constraints.
76 *
77 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
78 * It means that the register type passed to this function must be
79 * PTR_TO_STACK and it will be used inside the function as
80 * 'pointer to map element key'
81 *
82 * For example the argument constraints for bpf_map_lookup_elem():
83 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
84 * .arg1_type = ARG_CONST_MAP_PTR,
85 * .arg2_type = ARG_PTR_TO_MAP_KEY,
86 *
87 * ret_type says that this function returns 'pointer to map elem value or null'
88 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
89 * 2nd argument should be a pointer to stack, which will be used inside
90 * the helper function as a pointer to map element key.
91 *
92 * On the kernel side the helper function looks like:
93 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
94 * {
95 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
96 * void *key = (void *) (unsigned long) r2;
97 * void *value;
98 *
99 * here kernel can access 'key' and 'map' pointers safely, knowing that
100 * [key, key + map->key_size) bytes are valid and were initialized on
101 * the stack of eBPF program.
102 * }
103 *
104 * Corresponding eBPF program may look like:
105 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
106 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
107 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
108 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
109 * here verifier looks at prototype of map_lookup_elem() and sees:
110 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
111 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
112 *
113 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
114 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
115 * and were initialized prior to this call.
116 * If it's ok, then verifier allows this BPF_CALL insn and looks at
117 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
118 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
119 * returns ether pointer to map value or NULL.
120 *
121 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
122 * insn, the register holding that pointer in the true branch changes state to
123 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
124 * branch. See check_cond_jmp_op().
125 *
126 * After the call R0 is set to return type of the function and registers R1-R5
127 * are set to NOT_INIT to indicate that they are no longer readable.
128 */
129
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700130/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100131struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700132 /* verifer state is 'st'
133 * before processing instruction 'insn_idx'
134 * and after processing instruction 'prev_insn_idx'
135 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100136 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700137 int insn_idx;
138 int prev_insn_idx;
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100139 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700140};
141
Daniel Borkmann577aa832017-05-18 03:00:06 +0200142#define BPF_COMPLEXITY_LIMIT_INSNS 98304
Daniel Borkmann07016152016-04-05 22:33:17 +0200143#define BPF_COMPLEXITY_LIMIT_STACK 1024
144
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200145struct bpf_call_arg_meta {
146 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200147 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200148 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200149 int regno;
150 int access_size;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200151};
152
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700153/* verbose verifier prints what it's seeing
154 * bpf_check() is called under lock, so no race to access these global vars
155 */
156static u32 log_level, log_size, log_len;
157static char *log_buf;
158
159static DEFINE_MUTEX(bpf_verifier_lock);
160
161/* log_level controls verbosity level of eBPF verifier.
162 * verbose() is used to dump the verification trace to the log, so the user
163 * can figure out what's wrong with the program
164 */
Daniel Borkmann1d056d92015-11-03 11:39:20 +0100165static __printf(1, 2) void verbose(const char *fmt, ...)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700166{
167 va_list args;
168
169 if (log_level == 0 || log_len >= log_size - 1)
170 return;
171
172 va_start(args, fmt);
173 log_len += vscnprintf(log_buf + log_len, log_size - log_len, fmt, args);
174 va_end(args);
175}
176
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700177/* string representation of 'enum bpf_reg_type' */
178static const char * const reg_type_str[] = {
179 [NOT_INIT] = "?",
180 [UNKNOWN_VALUE] = "inv",
181 [PTR_TO_CTX] = "ctx",
182 [CONST_PTR_TO_MAP] = "map_ptr",
183 [PTR_TO_MAP_VALUE] = "map_value",
184 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Josef Bacik48461132016-09-28 10:54:32 -0400185 [PTR_TO_MAP_VALUE_ADJ] = "map_value_adj",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700186 [FRAME_PTR] = "fp",
187 [PTR_TO_STACK] = "fp",
188 [CONST_IMM] = "imm",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700189 [PTR_TO_PACKET] = "pkt",
190 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700191};
192
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100193static void print_verifier_state(struct bpf_verifier_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700194{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100195 struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700196 enum bpf_reg_type t;
197 int i;
198
199 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700200 reg = &state->regs[i];
201 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700202 if (t == NOT_INIT)
203 continue;
204 verbose(" R%d=%s", i, reg_type_str[t]);
205 if (t == CONST_IMM || t == PTR_TO_STACK)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700206 verbose("%lld", reg->imm);
207 else if (t == PTR_TO_PACKET)
208 verbose("(id=%d,off=%d,r=%d)",
209 reg->id, reg->off, reg->range);
210 else if (t == UNKNOWN_VALUE && reg->imm)
211 verbose("%lld", reg->imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700212 else if (t == CONST_PTR_TO_MAP || t == PTR_TO_MAP_VALUE ||
Josef Bacik48461132016-09-28 10:54:32 -0400213 t == PTR_TO_MAP_VALUE_OR_NULL ||
214 t == PTR_TO_MAP_VALUE_ADJ)
Thomas Graf14117072016-10-18 19:51:19 +0200215 verbose("(ks=%d,vs=%d,id=%u)",
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700216 reg->map_ptr->key_size,
Thomas Graf14117072016-10-18 19:51:19 +0200217 reg->map_ptr->value_size,
218 reg->id);
Josef Bacik48461132016-09-28 10:54:32 -0400219 if (reg->min_value != BPF_REGISTER_MIN_RANGE)
Josef Bacikf23cc642016-11-14 15:45:36 -0500220 verbose(",min_value=%lld",
221 (long long)reg->min_value);
Josef Bacik48461132016-09-28 10:54:32 -0400222 if (reg->max_value != BPF_REGISTER_MAX_RANGE)
223 verbose(",max_value=%llu",
224 (unsigned long long)reg->max_value);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700225 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700226 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700227 if (state->stack_slot_type[i] == STACK_SPILL)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700228 verbose(" fp%d=%s", -MAX_BPF_STACK + i,
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700229 reg_type_str[state->spilled_regs[i / BPF_REG_SIZE].type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700230 }
231 verbose("\n");
232}
233
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700234static const char *const bpf_class_string[] = {
235 [BPF_LD] = "ld",
236 [BPF_LDX] = "ldx",
237 [BPF_ST] = "st",
238 [BPF_STX] = "stx",
239 [BPF_ALU] = "alu",
240 [BPF_JMP] = "jmp",
241 [BPF_RET] = "BUG",
242 [BPF_ALU64] = "alu64",
243};
244
Alexei Starovoitov687f0712015-09-08 13:40:01 -0700245static const char *const bpf_alu_string[16] = {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700246 [BPF_ADD >> 4] = "+=",
247 [BPF_SUB >> 4] = "-=",
248 [BPF_MUL >> 4] = "*=",
249 [BPF_DIV >> 4] = "/=",
250 [BPF_OR >> 4] = "|=",
251 [BPF_AND >> 4] = "&=",
252 [BPF_LSH >> 4] = "<<=",
253 [BPF_RSH >> 4] = ">>=",
254 [BPF_NEG >> 4] = "neg",
255 [BPF_MOD >> 4] = "%=",
256 [BPF_XOR >> 4] = "^=",
257 [BPF_MOV >> 4] = "=",
258 [BPF_ARSH >> 4] = "s>>=",
259 [BPF_END >> 4] = "endian",
260};
261
262static const char *const bpf_ldst_string[] = {
263 [BPF_W >> 3] = "u32",
264 [BPF_H >> 3] = "u16",
265 [BPF_B >> 3] = "u8",
266 [BPF_DW >> 3] = "u64",
267};
268
Alexei Starovoitov687f0712015-09-08 13:40:01 -0700269static const char *const bpf_jmp_string[16] = {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700270 [BPF_JA >> 4] = "jmp",
271 [BPF_JEQ >> 4] = "==",
272 [BPF_JGT >> 4] = ">",
273 [BPF_JGE >> 4] = ">=",
274 [BPF_JSET >> 4] = "&",
275 [BPF_JNE >> 4] = "!=",
276 [BPF_JSGT >> 4] = "s>",
277 [BPF_JSGE >> 4] = "s>=",
278 [BPF_CALL >> 4] = "call",
279 [BPF_EXIT >> 4] = "exit",
280};
281
Daniel Borkmannced0a312017-05-08 00:04:09 +0200282static void print_bpf_insn(const struct bpf_verifier_env *env,
283 const struct bpf_insn *insn)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700284{
285 u8 class = BPF_CLASS(insn->code);
286
287 if (class == BPF_ALU || class == BPF_ALU64) {
288 if (BPF_SRC(insn->code) == BPF_X)
289 verbose("(%02x) %sr%d %s %sr%d\n",
290 insn->code, class == BPF_ALU ? "(u32) " : "",
291 insn->dst_reg,
292 bpf_alu_string[BPF_OP(insn->code) >> 4],
293 class == BPF_ALU ? "(u32) " : "",
294 insn->src_reg);
295 else
296 verbose("(%02x) %sr%d %s %s%d\n",
297 insn->code, class == BPF_ALU ? "(u32) " : "",
298 insn->dst_reg,
299 bpf_alu_string[BPF_OP(insn->code) >> 4],
300 class == BPF_ALU ? "(u32) " : "",
301 insn->imm);
302 } else if (class == BPF_STX) {
303 if (BPF_MODE(insn->code) == BPF_MEM)
304 verbose("(%02x) *(%s *)(r%d %+d) = r%d\n",
305 insn->code,
306 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
307 insn->dst_reg,
308 insn->off, insn->src_reg);
309 else if (BPF_MODE(insn->code) == BPF_XADD)
310 verbose("(%02x) lock *(%s *)(r%d %+d) += r%d\n",
311 insn->code,
312 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
313 insn->dst_reg, insn->off,
314 insn->src_reg);
315 else
316 verbose("BUG_%02x\n", insn->code);
317 } else if (class == BPF_ST) {
318 if (BPF_MODE(insn->code) != BPF_MEM) {
319 verbose("BUG_st_%02x\n", insn->code);
320 return;
321 }
322 verbose("(%02x) *(%s *)(r%d %+d) = %d\n",
323 insn->code,
324 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
325 insn->dst_reg,
326 insn->off, insn->imm);
327 } else if (class == BPF_LDX) {
328 if (BPF_MODE(insn->code) != BPF_MEM) {
329 verbose("BUG_ldx_%02x\n", insn->code);
330 return;
331 }
332 verbose("(%02x) r%d = *(%s *)(r%d %+d)\n",
333 insn->code, insn->dst_reg,
334 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
335 insn->src_reg, insn->off);
336 } else if (class == BPF_LD) {
337 if (BPF_MODE(insn->code) == BPF_ABS) {
338 verbose("(%02x) r0 = *(%s *)skb[%d]\n",
339 insn->code,
340 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
341 insn->imm);
342 } else if (BPF_MODE(insn->code) == BPF_IND) {
343 verbose("(%02x) r0 = *(%s *)skb[r%d + %d]\n",
344 insn->code,
345 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
346 insn->src_reg, insn->imm);
Daniel Borkmannced0a312017-05-08 00:04:09 +0200347 } else if (BPF_MODE(insn->code) == BPF_IMM &&
348 BPF_SIZE(insn->code) == BPF_DW) {
349 /* At this point, we already made sure that the second
350 * part of the ldimm64 insn is accessible.
351 */
352 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
353 bool map_ptr = insn->src_reg == BPF_PSEUDO_MAP_FD;
354
355 if (map_ptr && !env->allow_ptr_leaks)
356 imm = 0;
357
358 verbose("(%02x) r%d = 0x%llx\n", insn->code,
359 insn->dst_reg, (unsigned long long)imm);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700360 } else {
361 verbose("BUG_ld_%02x\n", insn->code);
362 return;
363 }
364 } else if (class == BPF_JMP) {
365 u8 opcode = BPF_OP(insn->code);
366
367 if (opcode == BPF_CALL) {
368 verbose("(%02x) call %d\n", insn->code, insn->imm);
369 } else if (insn->code == (BPF_JMP | BPF_JA)) {
370 verbose("(%02x) goto pc%+d\n",
371 insn->code, insn->off);
372 } else if (insn->code == (BPF_JMP | BPF_EXIT)) {
373 verbose("(%02x) exit\n", insn->code);
374 } else if (BPF_SRC(insn->code) == BPF_X) {
375 verbose("(%02x) if r%d %s r%d goto pc%+d\n",
376 insn->code, insn->dst_reg,
377 bpf_jmp_string[BPF_OP(insn->code) >> 4],
378 insn->src_reg, insn->off);
379 } else {
380 verbose("(%02x) if r%d %s 0x%x goto pc%+d\n",
381 insn->code, insn->dst_reg,
382 bpf_jmp_string[BPF_OP(insn->code) >> 4],
383 insn->imm, insn->off);
384 }
385 } else {
386 verbose("(%02x) %s\n", insn->code, bpf_class_string[class]);
387 }
388}
389
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100390static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700391{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100392 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700393 int insn_idx;
394
395 if (env->head == NULL)
396 return -1;
397
398 memcpy(&env->cur_state, &env->head->st, sizeof(env->cur_state));
399 insn_idx = env->head->insn_idx;
400 if (prev_insn_idx)
401 *prev_insn_idx = env->head->prev_insn_idx;
402 elem = env->head->next;
403 kfree(env->head);
404 env->head = elem;
405 env->stack_size--;
406 return insn_idx;
407}
408
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100409static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
410 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700411{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100412 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700413
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100414 elem = kmalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700415 if (!elem)
416 goto err;
417
418 memcpy(&elem->st, &env->cur_state, sizeof(env->cur_state));
419 elem->insn_idx = insn_idx;
420 elem->prev_insn_idx = prev_insn_idx;
421 elem->next = env->head;
422 env->head = elem;
423 env->stack_size++;
Daniel Borkmann07016152016-04-05 22:33:17 +0200424 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700425 verbose("BPF program is too complex\n");
426 goto err;
427 }
428 return &elem->st;
429err:
430 /* pop all elements and return */
431 while (pop_stack(env, NULL) >= 0);
432 return NULL;
433}
434
435#define CALLER_SAVED_REGS 6
436static const int caller_saved[CALLER_SAVED_REGS] = {
437 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
438};
439
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100440static void init_reg_state(struct bpf_reg_state *regs)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700441{
442 int i;
443
444 for (i = 0; i < MAX_BPF_REG; i++) {
445 regs[i].type = NOT_INIT;
446 regs[i].imm = 0;
Josef Bacik48461132016-09-28 10:54:32 -0400447 regs[i].min_value = BPF_REGISTER_MIN_RANGE;
448 regs[i].max_value = BPF_REGISTER_MAX_RANGE;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700449 }
450
451 /* frame pointer */
452 regs[BPF_REG_FP].type = FRAME_PTR;
453
454 /* 1st arg to a function */
455 regs[BPF_REG_1].type = PTR_TO_CTX;
456}
457
Daniel Borkmann0e0f1d62016-12-18 01:52:59 +0100458static void __mark_reg_unknown_value(struct bpf_reg_state *regs, u32 regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700459{
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700460 regs[regno].type = UNKNOWN_VALUE;
Thomas Graf14117072016-10-18 19:51:19 +0200461 regs[regno].id = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700462 regs[regno].imm = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700463}
464
Daniel Borkmann0e0f1d62016-12-18 01:52:59 +0100465static void mark_reg_unknown_value(struct bpf_reg_state *regs, u32 regno)
466{
467 BUG_ON(regno >= MAX_BPF_REG);
468 __mark_reg_unknown_value(regs, regno);
469}
470
Josef Bacik48461132016-09-28 10:54:32 -0400471static void reset_reg_range_values(struct bpf_reg_state *regs, u32 regno)
472{
473 regs[regno].min_value = BPF_REGISTER_MIN_RANGE;
474 regs[regno].max_value = BPF_REGISTER_MAX_RANGE;
475}
476
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700477enum reg_arg_type {
478 SRC_OP, /* register is used as source operand */
479 DST_OP, /* register is used as destination operand */
480 DST_OP_NO_MARK /* same as above, check only, don't mark */
481};
482
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100483static int check_reg_arg(struct bpf_reg_state *regs, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700484 enum reg_arg_type t)
485{
486 if (regno >= MAX_BPF_REG) {
487 verbose("R%d is invalid\n", regno);
488 return -EINVAL;
489 }
490
491 if (t == SRC_OP) {
492 /* check whether register used as source operand can be read */
493 if (regs[regno].type == NOT_INIT) {
494 verbose("R%d !read_ok\n", regno);
495 return -EACCES;
496 }
497 } else {
498 /* check whether register used as dest operand can be written to */
499 if (regno == BPF_REG_FP) {
500 verbose("frame pointer is read only\n");
501 return -EACCES;
502 }
503 if (t == DST_OP)
504 mark_reg_unknown_value(regs, regno);
505 }
506 return 0;
507}
508
509static int bpf_size_to_bytes(int bpf_size)
510{
511 if (bpf_size == BPF_W)
512 return 4;
513 else if (bpf_size == BPF_H)
514 return 2;
515 else if (bpf_size == BPF_B)
516 return 1;
517 else if (bpf_size == BPF_DW)
518 return 8;
519 else
520 return -EINVAL;
521}
522
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700523static bool is_spillable_regtype(enum bpf_reg_type type)
524{
525 switch (type) {
526 case PTR_TO_MAP_VALUE:
527 case PTR_TO_MAP_VALUE_OR_NULL:
528 case PTR_TO_STACK:
529 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700530 case PTR_TO_PACKET:
531 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700532 case FRAME_PTR:
533 case CONST_PTR_TO_MAP:
534 return true;
535 default:
536 return false;
537 }
538}
539
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700540/* check_stack_read/write functions track spill/fill of registers,
541 * stack boundary and alignment are checked in check_mem_access()
542 */
Alexei Starovoitovdef8c1d2018-05-15 09:27:05 -0700543static int check_stack_write(struct bpf_verifier_env *env,
544 struct bpf_verifier_state *state, int off,
545 int size, int value_regno, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700546{
Ben Hutchings9c33b842018-12-05 22:45:15 +0000547 int i, spi = (MAX_BPF_STACK + off) / BPF_REG_SIZE;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700548 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
549 * so it's aligned access and [off, off + size) are within stack limits
550 */
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700551
552 if (value_regno >= 0 &&
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700553 is_spillable_regtype(state->regs[value_regno].type)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700554
555 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700556 if (size != BPF_REG_SIZE) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700557 verbose("invalid size of register spill\n");
558 return -EACCES;
559 }
560
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700561 /* save register state */
Ben Hutchings9c33b842018-12-05 22:45:15 +0000562 state->spilled_regs[spi] = state->regs[value_regno];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700563
Alexei Starovoitovdef8c1d2018-05-15 09:27:05 -0700564 for (i = 0; i < BPF_REG_SIZE; i++) {
565 if (state->stack_slot_type[MAX_BPF_STACK + off + i] == STACK_MISC &&
566 !env->allow_ptr_leaks) {
567 int *poff = &env->insn_aux_data[insn_idx].sanitize_stack_off;
568 int soff = (-spi - 1) * BPF_REG_SIZE;
569
570 /* detected reuse of integer stack slot with a pointer
571 * which means either llvm is reusing stack slot or
572 * an attacker is trying to exploit CVE-2018-3639
573 * (speculative store bypass)
574 * Have to sanitize that slot with preemptive
575 * store of zero.
576 */
577 if (*poff && *poff != soff) {
578 /* disallow programs where single insn stores
579 * into two different stack slots, since verifier
580 * cannot sanitize them
581 */
582 verbose("insn %d cannot access two stack slots fp%d and fp%d",
583 insn_idx, *poff, soff);
584 return -EINVAL;
585 }
586 *poff = soff;
587 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700588 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_SPILL;
Alexei Starovoitovdef8c1d2018-05-15 09:27:05 -0700589 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700590 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700591 /* regular write of data into stack */
Ben Hutchings9c33b842018-12-05 22:45:15 +0000592 state->spilled_regs[spi] = (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700593
594 for (i = 0; i < size; i++)
595 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_MISC;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700596 }
597 return 0;
598}
599
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100600static int check_stack_read(struct bpf_verifier_state *state, int off, int size,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700601 int value_regno)
602{
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700603 u8 *slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700604 int i;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700605
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700606 slot_type = &state->stack_slot_type[MAX_BPF_STACK + off];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700607
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700608 if (slot_type[0] == STACK_SPILL) {
609 if (size != BPF_REG_SIZE) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700610 verbose("invalid size of register spill\n");
611 return -EACCES;
612 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700613 for (i = 1; i < BPF_REG_SIZE; i++) {
614 if (slot_type[i] != STACK_SPILL) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700615 verbose("corrupted spill memory\n");
616 return -EACCES;
617 }
618 }
619
620 if (value_regno >= 0)
621 /* restore register state from stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700622 state->regs[value_regno] =
623 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700624 return 0;
625 } else {
626 for (i = 0; i < size; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700627 if (slot_type[i] != STACK_MISC) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700628 verbose("invalid read from stack off %d+%d size %d\n",
629 off, i, size);
630 return -EACCES;
631 }
632 }
633 if (value_regno >= 0)
634 /* have read misc data from the stack */
635 mark_reg_unknown_value(state->regs, value_regno);
636 return 0;
637 }
638}
639
640/* check read/write into map element returned by bpf_map_lookup_elem() */
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100641static int check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700642 int size)
643{
644 struct bpf_map *map = env->cur_state.regs[regno].map_ptr;
645
646 if (off < 0 || off + size > map->value_size) {
647 verbose("invalid access to map value, value_size=%d off=%d size=%d\n",
648 map->value_size, off, size);
649 return -EACCES;
650 }
651 return 0;
652}
653
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700654#define MAX_PACKET_OFF 0xffff
655
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100656static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200657 const struct bpf_call_arg_meta *meta)
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700658{
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200659 switch (env->prog->type) {
660 case BPF_PROG_TYPE_SCHED_CLS:
661 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700662 case BPF_PROG_TYPE_XDP:
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200663 if (meta)
664 return meta->pkt_access;
665
666 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700667 return true;
668 default:
669 return false;
670 }
671}
672
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100673static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700674 int size)
675{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100676 struct bpf_reg_state *regs = env->cur_state.regs;
677 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700678
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700679 off += reg->off;
Daniel Borkmannb399cf62016-09-20 00:26:12 +0200680 if (off < 0 || size <= 0 || off + size > reg->range) {
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700681 verbose("invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
682 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700683 return -EACCES;
684 }
685 return 0;
686}
687
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700688/* check access to 'struct bpf_context' fields */
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100689static int check_ctx_access(struct bpf_verifier_env *env, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700690 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700691{
Jakub Kicinski13a27df2016-09-21 11:43:58 +0100692 /* for analyzer ctx accesses are already validated and converted */
693 if (env->analyzer_ops)
694 return 0;
695
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700696 if (env->prog->aux->ops->is_valid_access &&
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700697 env->prog->aux->ops->is_valid_access(off, size, t, reg_type)) {
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700698 /* remember the offset of last byte accessed in ctx */
699 if (env->prog->aux->max_ctx_offset < off + size)
700 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700701 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700702 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700703
704 verbose("invalid bpf_context access off=%d size=%d\n", off, size);
705 return -EACCES;
706}
707
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +0200708static bool __is_pointer_value(bool allow_ptr_leaks,
709 const struct bpf_reg_state *reg)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700710{
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +0200711 if (allow_ptr_leaks)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700712 return false;
713
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +0200714 switch (reg->type) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700715 case UNKNOWN_VALUE:
716 case CONST_IMM:
717 return false;
718 default:
719 return true;
720 }
721}
722
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +0200723static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
724{
725 return __is_pointer_value(env->allow_ptr_leaks, &env->cur_state.regs[regno]);
726}
727
Daniel Borkmannf531fbb2018-01-29 02:49:01 +0100728static bool is_ctx_reg(struct bpf_verifier_env *env, int regno)
729{
730 const struct bpf_reg_state *reg = &env->cur_state.regs[regno];
731
732 return reg->type == PTR_TO_CTX;
733}
734
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100735static int check_ptr_alignment(struct bpf_verifier_env *env,
736 struct bpf_reg_state *reg, int off, int size)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700737{
Josef Bacik48461132016-09-28 10:54:32 -0400738 if (reg->type != PTR_TO_PACKET && reg->type != PTR_TO_MAP_VALUE_ADJ) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700739 if (off % size != 0) {
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100740 verbose("misaligned access off %d size %d\n",
741 off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700742 return -EACCES;
743 } else {
744 return 0;
745 }
746 }
747
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700748 if (IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
749 /* misaligned access to packet is ok on x86,arm,arm64 */
750 return 0;
751
752 if (reg->id && size != 1) {
753 verbose("Unknown packet alignment. Only byte-sized access allowed\n");
754 return -EACCES;
755 }
756
757 /* skb->data is NET_IP_ALIGN-ed */
Josef Bacik48461132016-09-28 10:54:32 -0400758 if (reg->type == PTR_TO_PACKET &&
759 (NET_IP_ALIGN + reg->off + off) % size != 0) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700760 verbose("misaligned packet access off %d+%d+%d size %d\n",
761 NET_IP_ALIGN, reg->off, off, size);
762 return -EACCES;
763 }
764 return 0;
765}
766
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700767/* check whether memory at (regno + off) is accessible for t = (read | write)
768 * if t==write, value_regno is a register which value is stored into memory
769 * if t==read, value_regno is a register which will receive the value from memory
770 * if t==write && value_regno==-1, some unknown value is stored into memory
771 * if t==read && value_regno==-1, don't care what we read from memory
772 */
Ben Hutchings62e08652018-12-05 22:41:36 +0000773static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700774 int bpf_size, enum bpf_access_type t,
775 int value_regno)
776{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100777 struct bpf_verifier_state *state = &env->cur_state;
778 struct bpf_reg_state *reg = &state->regs[regno];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700779 int size, err = 0;
780
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700781 if (reg->type == PTR_TO_STACK)
782 off += reg->imm;
Alex Gartrell24b4d2a2015-07-23 14:24:40 -0700783
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700784 size = bpf_size_to_bytes(bpf_size);
785 if (size < 0)
786 return size;
787
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700788 err = check_ptr_alignment(env, reg, off, size);
789 if (err)
790 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700791
Josef Bacik48461132016-09-28 10:54:32 -0400792 if (reg->type == PTR_TO_MAP_VALUE ||
793 reg->type == PTR_TO_MAP_VALUE_ADJ) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700794 if (t == BPF_WRITE && value_regno >= 0 &&
795 is_pointer_value(env, value_regno)) {
796 verbose("R%d leaks addr into map\n", value_regno);
797 return -EACCES;
798 }
Josef Bacik48461132016-09-28 10:54:32 -0400799
800 /* If we adjusted the register to this map value at all then we
801 * need to change off and size to min_value and max_value
802 * respectively to make sure our theoretical access will be
803 * safe.
804 */
805 if (reg->type == PTR_TO_MAP_VALUE_ADJ) {
806 if (log_level)
807 print_verifier_state(state);
808 env->varlen_map_value_access = true;
809 /* The minimum value is only important with signed
810 * comparisons where we can't assume the floor of a
811 * value is 0. If we are using signed variables for our
812 * index'es we need to make sure that whatever we use
813 * will have a set floor within our range.
814 */
Josef Bacikf23cc642016-11-14 15:45:36 -0500815 if (reg->min_value < 0) {
Josef Bacik48461132016-09-28 10:54:32 -0400816 verbose("R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
817 regno);
818 return -EACCES;
819 }
820 err = check_map_access(env, regno, reg->min_value + off,
821 size);
822 if (err) {
823 verbose("R%d min value is outside of the array range\n",
824 regno);
825 return err;
826 }
827
828 /* If we haven't set a max value then we need to bail
829 * since we can't be sure we won't do bad things.
830 */
831 if (reg->max_value == BPF_REGISTER_MAX_RANGE) {
832 verbose("R%d unbounded memory access, make sure to bounds check any array access into a map\n",
833 regno);
834 return -EACCES;
835 }
836 off += reg->max_value;
837 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700838 err = check_map_access(env, regno, off, size);
839 if (!err && t == BPF_READ && value_regno >= 0)
840 mark_reg_unknown_value(state->regs, value_regno);
841
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700842 } else if (reg->type == PTR_TO_CTX) {
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700843 enum bpf_reg_type reg_type = UNKNOWN_VALUE;
844
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700845 if (t == BPF_WRITE && value_regno >= 0 &&
846 is_pointer_value(env, value_regno)) {
847 verbose("R%d leaks addr into ctx\n", value_regno);
848 return -EACCES;
849 }
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700850 err = check_ctx_access(env, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700851 if (!err && t == BPF_READ && value_regno >= 0) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700852 mark_reg_unknown_value(state->regs, value_regno);
Mickaël Salaün19553512016-09-24 20:01:50 +0200853 /* note that reg.[id|off|range] == 0 */
854 state->regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700855 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700856
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700857 } else if (reg->type == FRAME_PTR || reg->type == PTR_TO_STACK) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700858 if (off >= 0 || off < -MAX_BPF_STACK) {
859 verbose("invalid stack off=%d size=%d\n", off, size);
860 return -EACCES;
861 }
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700862 if (t == BPF_WRITE) {
863 if (!env->allow_ptr_leaks &&
864 state->stack_slot_type[MAX_BPF_STACK + off] == STACK_SPILL &&
865 size != BPF_REG_SIZE) {
866 verbose("attempt to corrupt spilled pointer on stack\n");
867 return -EACCES;
868 }
Alexei Starovoitovdef8c1d2018-05-15 09:27:05 -0700869 err = check_stack_write(env, state, off, size,
870 value_regno, insn_idx);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700871 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700872 err = check_stack_read(state, off, size, value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700873 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700874 } else if (state->regs[regno].type == PTR_TO_PACKET) {
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200875 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL)) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700876 verbose("cannot write into packet\n");
877 return -EACCES;
878 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700879 if (t == BPF_WRITE && value_regno >= 0 &&
880 is_pointer_value(env, value_regno)) {
881 verbose("R%d leaks addr into packet\n", value_regno);
882 return -EACCES;
883 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700884 err = check_packet_access(env, regno, off, size);
885 if (!err && t == BPF_READ && value_regno >= 0)
886 mark_reg_unknown_value(state->regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700887 } else {
888 verbose("R%d invalid mem access '%s'\n",
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700889 regno, reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700890 return -EACCES;
891 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700892
893 if (!err && size <= 2 && value_regno >= 0 && env->allow_ptr_leaks &&
894 state->regs[value_regno].type == UNKNOWN_VALUE) {
895 /* 1 or 2 byte load zero-extends, determine the number of
896 * zero upper bits. Not doing it fo 4 byte load, since
897 * such values cannot be added to ptr_to_packet anyway.
898 */
899 state->regs[value_regno].imm = 64 - size * 8;
900 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700901 return err;
902}
903
Ben Hutchings62e08652018-12-05 22:41:36 +0000904static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700905{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100906 struct bpf_reg_state *regs = env->cur_state.regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700907 int err;
908
909 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
910 insn->imm != 0) {
911 verbose("BPF_XADD uses reserved fields\n");
912 return -EINVAL;
913 }
914
915 /* check src1 operand */
916 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
917 if (err)
918 return err;
919
920 /* check src2 operand */
921 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
922 if (err)
923 return err;
924
Daniel Borkmanncd5de9c2017-06-29 03:04:59 +0200925 if (is_pointer_value(env, insn->src_reg)) {
926 verbose("R%d leaks addr into mem\n", insn->src_reg);
927 return -EACCES;
928 }
929
Daniel Borkmannf531fbb2018-01-29 02:49:01 +0100930 if (is_ctx_reg(env, insn->dst_reg)) {
931 verbose("BPF_XADD stores into R%d context is not allowed\n",
932 insn->dst_reg);
933 return -EACCES;
934 }
935
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700936 /* check whether atomic_add can read the memory */
Ben Hutchings62e08652018-12-05 22:41:36 +0000937 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700938 BPF_SIZE(insn->code), BPF_READ, -1);
939 if (err)
940 return err;
941
942 /* check whether atomic_add can write into the same memory */
Ben Hutchings62e08652018-12-05 22:41:36 +0000943 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700944 BPF_SIZE(insn->code), BPF_WRITE, -1);
945}
946
947/* when register 'regno' is passed into function that will read 'access_size'
948 * bytes from that pointer, make sure that it's within stack boundary
949 * and all elements of stack are initialized
950 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100951static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +0200952 int access_size, bool zero_size_allowed,
953 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700954{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100955 struct bpf_verifier_state *state = &env->cur_state;
956 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700957 int off, i;
958
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +0100959 if (regs[regno].type != PTR_TO_STACK) {
960 if (zero_size_allowed && access_size == 0 &&
961 regs[regno].type == CONST_IMM &&
962 regs[regno].imm == 0)
963 return 0;
964
965 verbose("R%d type=%s expected=%s\n", regno,
966 reg_type_str[regs[regno].type],
967 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700968 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +0100969 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700970
971 off = regs[regno].imm;
972 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
973 access_size <= 0) {
974 verbose("invalid stack type R%d off=%d access_size=%d\n",
975 regno, off, access_size);
976 return -EACCES;
977 }
978
Daniel Borkmann435faee12016-04-13 00:10:51 +0200979 if (meta && meta->raw_mode) {
980 meta->access_size = access_size;
981 meta->regno = regno;
982 return 0;
983 }
984
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700985 for (i = 0; i < access_size; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700986 if (state->stack_slot_type[MAX_BPF_STACK + off + i] != STACK_MISC) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700987 verbose("invalid indirect read from stack off %d+%d size %d\n",
988 off, i, access_size);
989 return -EACCES;
990 }
991 }
992 return 0;
993}
994
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100995static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200996 enum bpf_arg_type arg_type,
997 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700998{
Jakub Kicinski58e2af82016-09-21 11:43:57 +0100999 struct bpf_reg_state *regs = env->cur_state.regs, *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001000 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001001 int err = 0;
1002
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001003 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001004 return 0;
1005
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001006 if (type == NOT_INIT) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001007 verbose("R%d !read_ok\n", regno);
1008 return -EACCES;
1009 }
1010
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001011 if (arg_type == ARG_ANYTHING) {
1012 if (is_pointer_value(env, regno)) {
1013 verbose("R%d leaks addr into helper function\n", regno);
1014 return -EACCES;
1015 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001016 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001017 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001018
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001019 if (type == PTR_TO_PACKET && !may_access_direct_pkt_data(env, meta)) {
1020 verbose("helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001021 return -EACCES;
1022 }
1023
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001024 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001025 arg_type == ARG_PTR_TO_MAP_VALUE) {
1026 expected_type = PTR_TO_STACK;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001027 if (type != PTR_TO_PACKET && type != expected_type)
1028 goto err_type;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001029 } else if (arg_type == ARG_CONST_STACK_SIZE ||
1030 arg_type == ARG_CONST_STACK_SIZE_OR_ZERO) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001031 expected_type = CONST_IMM;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001032 if (type != expected_type)
1033 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001034 } else if (arg_type == ARG_CONST_MAP_PTR) {
1035 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001036 if (type != expected_type)
1037 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001038 } else if (arg_type == ARG_PTR_TO_CTX) {
1039 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001040 if (type != expected_type)
1041 goto err_type;
Daniel Borkmann435faee12016-04-13 00:10:51 +02001042 } else if (arg_type == ARG_PTR_TO_STACK ||
1043 arg_type == ARG_PTR_TO_RAW_STACK) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001044 expected_type = PTR_TO_STACK;
1045 /* One exception here. In case function allows for NULL to be
1046 * passed in as argument, it's a CONST_IMM type. Final test
1047 * happens during stack boundary checking.
1048 */
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001049 if (type == CONST_IMM && reg->imm == 0)
1050 /* final test in check_stack_boundary() */;
1051 else if (type != PTR_TO_PACKET && type != expected_type)
1052 goto err_type;
Daniel Borkmann435faee12016-04-13 00:10:51 +02001053 meta->raw_mode = arg_type == ARG_PTR_TO_RAW_STACK;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001054 } else {
1055 verbose("unsupported arg_type %d\n", arg_type);
1056 return -EFAULT;
1057 }
1058
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001059 if (arg_type == ARG_CONST_MAP_PTR) {
1060 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001061 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001062 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1063 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1064 * check that [key, key + map->key_size) are within
1065 * stack limits and initialized
1066 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001067 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001068 /* in function declaration map_ptr must come before
1069 * map_key, so that it's verified and known before
1070 * we have to check map_key here. Otherwise it means
1071 * that kernel subsystem misconfigured verifier
1072 */
1073 verbose("invalid map_ptr to access map->key\n");
1074 return -EACCES;
1075 }
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001076 if (type == PTR_TO_PACKET)
1077 err = check_packet_access(env, regno, 0,
1078 meta->map_ptr->key_size);
1079 else
1080 err = check_stack_boundary(env, regno,
1081 meta->map_ptr->key_size,
1082 false, NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001083 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1084 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1085 * check [value, value + map->value_size) validity
1086 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001087 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001088 /* kernel subsystem misconfigured verifier */
1089 verbose("invalid map_ptr to access map->value\n");
1090 return -EACCES;
1091 }
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001092 if (type == PTR_TO_PACKET)
1093 err = check_packet_access(env, regno, 0,
1094 meta->map_ptr->value_size);
1095 else
1096 err = check_stack_boundary(env, regno,
1097 meta->map_ptr->value_size,
1098 false, NULL);
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001099 } else if (arg_type == ARG_CONST_STACK_SIZE ||
1100 arg_type == ARG_CONST_STACK_SIZE_OR_ZERO) {
1101 bool zero_size_allowed = (arg_type == ARG_CONST_STACK_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001102
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001103 /* bpf_xxx(..., buf, len) call will access 'len' bytes
1104 * from stack pointer 'buf'. Check it
1105 * note: regno == len, regno - 1 == buf
1106 */
1107 if (regno == 0) {
1108 /* kernel subsystem misconfigured verifier */
1109 verbose("ARG_CONST_STACK_SIZE cannot be first argument\n");
1110 return -EACCES;
1111 }
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001112 if (regs[regno - 1].type == PTR_TO_PACKET)
1113 err = check_packet_access(env, regno - 1, 0, reg->imm);
1114 else
1115 err = check_stack_boundary(env, regno - 1, reg->imm,
1116 zero_size_allowed, meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001117 }
1118
1119 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001120err_type:
1121 verbose("R%d type=%s expected=%s\n", regno,
1122 reg_type_str[type], reg_type_str[expected_type]);
1123 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001124}
1125
Kaixu Xia35578d72015-08-06 07:02:35 +00001126static int check_map_func_compatibility(struct bpf_map *map, int func_id)
1127{
Kaixu Xia35578d72015-08-06 07:02:35 +00001128 if (!map)
1129 return 0;
1130
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001131 /* We need a two way check, first is from map perspective ... */
1132 switch (map->map_type) {
1133 case BPF_MAP_TYPE_PROG_ARRAY:
1134 if (func_id != BPF_FUNC_tail_call)
1135 goto error;
1136 break;
1137 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
1138 if (func_id != BPF_FUNC_perf_event_read &&
1139 func_id != BPF_FUNC_perf_event_output)
1140 goto error;
1141 break;
1142 case BPF_MAP_TYPE_STACK_TRACE:
1143 if (func_id != BPF_FUNC_get_stackid)
1144 goto error;
1145 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07001146 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04001147 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001148 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001149 goto error;
1150 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001151 default:
1152 break;
1153 }
1154
1155 /* ... and second from the function itself. */
1156 switch (func_id) {
1157 case BPF_FUNC_tail_call:
1158 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
1159 goto error;
1160 break;
1161 case BPF_FUNC_perf_event_read:
1162 case BPF_FUNC_perf_event_output:
1163 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
1164 goto error;
1165 break;
1166 case BPF_FUNC_get_stackid:
1167 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
1168 goto error;
1169 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001170 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02001171 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001172 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
1173 goto error;
1174 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001175 default:
1176 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00001177 }
1178
1179 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001180error:
1181 verbose("cannot pass map_type %d into func %d\n",
1182 map->map_type, func_id);
1183 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00001184}
1185
Daniel Borkmann435faee12016-04-13 00:10:51 +02001186static int check_raw_mode(const struct bpf_func_proto *fn)
1187{
1188 int count = 0;
1189
1190 if (fn->arg1_type == ARG_PTR_TO_RAW_STACK)
1191 count++;
1192 if (fn->arg2_type == ARG_PTR_TO_RAW_STACK)
1193 count++;
1194 if (fn->arg3_type == ARG_PTR_TO_RAW_STACK)
1195 count++;
1196 if (fn->arg4_type == ARG_PTR_TO_RAW_STACK)
1197 count++;
1198 if (fn->arg5_type == ARG_PTR_TO_RAW_STACK)
1199 count++;
1200
1201 return count > 1 ? -EINVAL : 0;
1202}
1203
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001204static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001205{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001206 struct bpf_verifier_state *state = &env->cur_state;
1207 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001208 int i;
1209
1210 for (i = 0; i < MAX_BPF_REG; i++)
1211 if (regs[i].type == PTR_TO_PACKET ||
1212 regs[i].type == PTR_TO_PACKET_END)
1213 mark_reg_unknown_value(regs, i);
1214
1215 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
1216 if (state->stack_slot_type[i] != STACK_SPILL)
1217 continue;
1218 reg = &state->spilled_regs[i / BPF_REG_SIZE];
1219 if (reg->type != PTR_TO_PACKET &&
1220 reg->type != PTR_TO_PACKET_END)
1221 continue;
1222 reg->type = UNKNOWN_VALUE;
1223 reg->imm = 0;
1224 }
1225}
1226
Alexei Starovoitova9bfac142018-01-07 17:33:02 -08001227static int check_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001228{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001229 struct bpf_verifier_state *state = &env->cur_state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001230 const struct bpf_func_proto *fn = NULL;
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001231 struct bpf_reg_state *regs = state->regs;
1232 struct bpf_reg_state *reg;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001233 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001234 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001235 int i, err;
1236
1237 /* find function prototype */
1238 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
1239 verbose("invalid func %d\n", func_id);
1240 return -EINVAL;
1241 }
1242
1243 if (env->prog->aux->ops->get_func_proto)
1244 fn = env->prog->aux->ops->get_func_proto(func_id);
1245
1246 if (!fn) {
1247 verbose("unknown func %d\n", func_id);
1248 return -EINVAL;
1249 }
1250
1251 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01001252 if (!env->prog->gpl_compatible && fn->gpl_only) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001253 verbose("cannot call GPL only function from proprietary program\n");
1254 return -EINVAL;
1255 }
1256
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001257 changes_data = bpf_helper_changes_skb_data(fn->func);
1258
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001259 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001260 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001261
Daniel Borkmann435faee12016-04-13 00:10:51 +02001262 /* We only support one arg being in raw mode at the moment, which
1263 * is sufficient for the helper functions we have right now.
1264 */
1265 err = check_raw_mode(fn);
1266 if (err) {
1267 verbose("kernel subsystem misconfigured func %d\n", func_id);
1268 return err;
1269 }
1270
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001271 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001272 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001273 if (err)
1274 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001275 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001276 if (err)
1277 return err;
Alexei Starovoitova9bfac142018-01-07 17:33:02 -08001278 if (func_id == BPF_FUNC_tail_call) {
1279 if (meta.map_ptr == NULL) {
1280 verbose("verifier bug\n");
1281 return -EINVAL;
1282 }
1283 env->insn_aux_data[insn_idx].map_ptr = meta.map_ptr;
1284 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001285 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001286 if (err)
1287 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001288 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001289 if (err)
1290 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001291 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001292 if (err)
1293 return err;
1294
Daniel Borkmann435faee12016-04-13 00:10:51 +02001295 /* Mark slots with STACK_MISC in case of raw mode, stack offset
1296 * is inferred from register state.
1297 */
1298 for (i = 0; i < meta.access_size; i++) {
Ben Hutchings62e08652018-12-05 22:41:36 +00001299 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B, BPF_WRITE, -1);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001300 if (err)
1301 return err;
1302 }
1303
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001304 /* reset caller saved regs */
1305 for (i = 0; i < CALLER_SAVED_REGS; i++) {
1306 reg = regs + caller_saved[i];
1307 reg->type = NOT_INIT;
1308 reg->imm = 0;
1309 }
1310
1311 /* update return register */
1312 if (fn->ret_type == RET_INTEGER) {
1313 regs[BPF_REG_0].type = UNKNOWN_VALUE;
1314 } else if (fn->ret_type == RET_VOID) {
1315 regs[BPF_REG_0].type = NOT_INIT;
1316 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
1317 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Josef Bacik48461132016-09-28 10:54:32 -04001318 regs[BPF_REG_0].max_value = regs[BPF_REG_0].min_value = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001319 /* remember map_ptr, so that check_map_access()
1320 * can check 'value_size' boundary of memory access
1321 * to map element returned from bpf_map_lookup_elem()
1322 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001323 if (meta.map_ptr == NULL) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001324 verbose("kernel subsystem misconfigured verifier\n");
1325 return -EINVAL;
1326 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001327 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf14117072016-10-18 19:51:19 +02001328 regs[BPF_REG_0].id = ++env->id_gen;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001329 } else {
1330 verbose("unknown return type %d of func %d\n",
1331 fn->ret_type, func_id);
1332 return -EINVAL;
1333 }
Alexei Starovoitov04fd61a2015-05-19 16:59:03 -07001334
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001335 err = check_map_func_compatibility(meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00001336 if (err)
1337 return err;
Alexei Starovoitov04fd61a2015-05-19 16:59:03 -07001338
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001339 if (changes_data)
1340 clear_all_pkt_pointers(env);
1341 return 0;
1342}
1343
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001344static int check_packet_ptr_add(struct bpf_verifier_env *env,
1345 struct bpf_insn *insn)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001346{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001347 struct bpf_reg_state *regs = env->cur_state.regs;
1348 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1349 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
1350 struct bpf_reg_state tmp_reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001351 s32 imm;
1352
1353 if (BPF_SRC(insn->code) == BPF_K) {
1354 /* pkt_ptr += imm */
1355 imm = insn->imm;
1356
1357add_imm:
1358 if (imm <= 0) {
1359 verbose("addition of negative constant to packet pointer is not allowed\n");
1360 return -EACCES;
1361 }
1362 if (imm >= MAX_PACKET_OFF ||
1363 imm + dst_reg->off >= MAX_PACKET_OFF) {
1364 verbose("constant %d is too large to add to packet pointer\n",
1365 imm);
1366 return -EACCES;
1367 }
1368 /* a constant was added to pkt_ptr.
1369 * Remember it while keeping the same 'id'
1370 */
1371 dst_reg->off += imm;
1372 } else {
Alexei Starovoitov1b9b69e2016-05-19 18:17:14 -07001373 if (src_reg->type == PTR_TO_PACKET) {
1374 /* R6=pkt(id=0,off=0,r=62) R7=imm22; r7 += r6 */
1375 tmp_reg = *dst_reg; /* save r7 state */
1376 *dst_reg = *src_reg; /* copy pkt_ptr state r6 into r7 */
1377 src_reg = &tmp_reg; /* pretend it's src_reg state */
1378 /* if the checks below reject it, the copy won't matter,
1379 * since we're rejecting the whole program. If all ok,
1380 * then imm22 state will be added to r7
1381 * and r7 will be pkt(id=0,off=22,r=62) while
1382 * r6 will stay as pkt(id=0,off=0,r=62)
1383 */
1384 }
1385
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001386 if (src_reg->type == CONST_IMM) {
1387 /* pkt_ptr += reg where reg is known constant */
1388 imm = src_reg->imm;
1389 goto add_imm;
1390 }
1391 /* disallow pkt_ptr += reg
1392 * if reg is not uknown_value with guaranteed zero upper bits
1393 * otherwise pkt_ptr may overflow and addition will become
1394 * subtraction which is not allowed
1395 */
1396 if (src_reg->type != UNKNOWN_VALUE) {
1397 verbose("cannot add '%s' to ptr_to_packet\n",
1398 reg_type_str[src_reg->type]);
1399 return -EACCES;
1400 }
1401 if (src_reg->imm < 48) {
1402 verbose("cannot add integer value with %lld upper zero bits to ptr_to_packet\n",
1403 src_reg->imm);
1404 return -EACCES;
1405 }
1406 /* dst_reg stays as pkt_ptr type and since some positive
1407 * integer value was added to the pointer, increment its 'id'
1408 */
Jakub Kicinski1f415a72016-08-02 16:12:14 +01001409 dst_reg->id = ++env->id_gen;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001410
1411 /* something was added to pkt_ptr, set range and off to zero */
1412 dst_reg->off = 0;
1413 dst_reg->range = 0;
1414 }
1415 return 0;
1416}
1417
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001418static int evaluate_reg_alu(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001419{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001420 struct bpf_reg_state *regs = env->cur_state.regs;
1421 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001422 u8 opcode = BPF_OP(insn->code);
1423 s64 imm_log2;
1424
1425 /* for type == UNKNOWN_VALUE:
1426 * imm > 0 -> number of zero upper bits
1427 * imm == 0 -> don't track which is the same as all bits can be non-zero
1428 */
1429
1430 if (BPF_SRC(insn->code) == BPF_X) {
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001431 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001432
1433 if (src_reg->type == UNKNOWN_VALUE && src_reg->imm > 0 &&
1434 dst_reg->imm && opcode == BPF_ADD) {
1435 /* dreg += sreg
1436 * where both have zero upper bits. Adding them
1437 * can only result making one more bit non-zero
1438 * in the larger value.
1439 * Ex. 0xffff (imm=48) + 1 (imm=63) = 0x10000 (imm=47)
1440 * 0xffff (imm=48) + 0xffff = 0x1fffe (imm=47)
1441 */
1442 dst_reg->imm = min(dst_reg->imm, src_reg->imm);
1443 dst_reg->imm--;
1444 return 0;
1445 }
1446 if (src_reg->type == CONST_IMM && src_reg->imm > 0 &&
1447 dst_reg->imm && opcode == BPF_ADD) {
1448 /* dreg += sreg
1449 * where dreg has zero upper bits and sreg is const.
1450 * Adding them can only result making one more bit
1451 * non-zero in the larger value.
1452 */
1453 imm_log2 = __ilog2_u64((long long)src_reg->imm);
1454 dst_reg->imm = min(dst_reg->imm, 63 - imm_log2);
1455 dst_reg->imm--;
1456 return 0;
1457 }
1458 /* all other cases non supported yet, just mark dst_reg */
1459 dst_reg->imm = 0;
1460 return 0;
1461 }
1462
1463 /* sign extend 32-bit imm into 64-bit to make sure that
1464 * negative values occupy bit 63. Note ilog2() would have
1465 * been incorrect, since sizeof(insn->imm) == 4
1466 */
1467 imm_log2 = __ilog2_u64((long long)insn->imm);
1468
1469 if (dst_reg->imm && opcode == BPF_LSH) {
1470 /* reg <<= imm
1471 * if reg was a result of 2 byte load, then its imm == 48
1472 * which means that upper 48 bits are zero and shifting this reg
1473 * left by 4 would mean that upper 44 bits are still zero
1474 */
1475 dst_reg->imm -= insn->imm;
1476 } else if (dst_reg->imm && opcode == BPF_MUL) {
1477 /* reg *= imm
1478 * if multiplying by 14 subtract 4
1479 * This is conservative calculation of upper zero bits.
1480 * It's not trying to special case insn->imm == 1 or 0 cases
1481 */
1482 dst_reg->imm -= imm_log2 + 1;
1483 } else if (opcode == BPF_AND) {
1484 /* reg &= imm */
1485 dst_reg->imm = 63 - imm_log2;
1486 } else if (dst_reg->imm && opcode == BPF_ADD) {
1487 /* reg += imm */
1488 dst_reg->imm = min(dst_reg->imm, 63 - imm_log2);
1489 dst_reg->imm--;
1490 } else if (opcode == BPF_RSH) {
1491 /* reg >>= imm
1492 * which means that after right shift, upper bits will be zero
1493 * note that verifier already checked that
1494 * 0 <= imm < 64 for shift insn
1495 */
1496 dst_reg->imm += insn->imm;
1497 if (unlikely(dst_reg->imm > 64))
1498 /* some dumb code did:
1499 * r2 = *(u32 *)mem;
1500 * r2 >>= 32;
1501 * and all bits are zero now */
1502 dst_reg->imm = 64;
1503 } else {
1504 /* all other alu ops, means that we don't know what will
1505 * happen to the value, mark it with unknown number of zero bits
1506 */
1507 dst_reg->imm = 0;
1508 }
1509
1510 if (dst_reg->imm < 0) {
1511 /* all 64 bits of the register can contain non-zero bits
1512 * and such value cannot be added to ptr_to_packet, since it
1513 * may overflow, mark it as unknown to avoid further eval
1514 */
1515 dst_reg->imm = 0;
1516 }
1517 return 0;
1518}
1519
John Fastabende37bdee2017-07-02 02:13:30 +02001520static int evaluate_reg_imm_alu_unknown(struct bpf_verifier_env *env,
1521 struct bpf_insn *insn)
1522{
1523 struct bpf_reg_state *regs = env->cur_state.regs;
1524 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1525 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
1526 u8 opcode = BPF_OP(insn->code);
1527 s64 imm_log2 = __ilog2_u64((long long)dst_reg->imm);
1528
1529 /* BPF_X code with src_reg->type UNKNOWN_VALUE here. */
1530 if (src_reg->imm > 0 && dst_reg->imm) {
1531 switch (opcode) {
1532 case BPF_ADD:
1533 /* dreg += sreg
1534 * where both have zero upper bits. Adding them
1535 * can only result making one more bit non-zero
1536 * in the larger value.
1537 * Ex. 0xffff (imm=48) + 1 (imm=63) = 0x10000 (imm=47)
1538 * 0xffff (imm=48) + 0xffff = 0x1fffe (imm=47)
1539 */
1540 dst_reg->imm = min(src_reg->imm, 63 - imm_log2);
1541 dst_reg->imm--;
1542 break;
1543 case BPF_AND:
1544 /* dreg &= sreg
1545 * AND can not extend zero bits only shrink
1546 * Ex. 0x00..00ffffff
1547 * & 0x0f..ffffffff
1548 * ----------------
1549 * 0x00..00ffffff
1550 */
1551 dst_reg->imm = max(src_reg->imm, 63 - imm_log2);
1552 break;
1553 case BPF_OR:
1554 /* dreg |= sreg
1555 * OR can only extend zero bits
1556 * Ex. 0x00..00ffffff
1557 * | 0x0f..ffffffff
1558 * ----------------
1559 * 0x0f..00ffffff
1560 */
1561 dst_reg->imm = min(src_reg->imm, 63 - imm_log2);
1562 break;
1563 case BPF_SUB:
1564 case BPF_MUL:
1565 case BPF_RSH:
1566 case BPF_LSH:
1567 /* These may be flushed out later */
1568 default:
1569 mark_reg_unknown_value(regs, insn->dst_reg);
1570 }
1571 } else {
1572 mark_reg_unknown_value(regs, insn->dst_reg);
1573 }
1574
1575 dst_reg->type = UNKNOWN_VALUE;
1576 return 0;
1577}
1578
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001579static int evaluate_reg_imm_alu(struct bpf_verifier_env *env,
1580 struct bpf_insn *insn)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001581{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001582 struct bpf_reg_state *regs = env->cur_state.regs;
1583 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1584 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001585 u8 opcode = BPF_OP(insn->code);
1586
John Fastabende37bdee2017-07-02 02:13:30 +02001587 if (BPF_SRC(insn->code) == BPF_X && src_reg->type == UNKNOWN_VALUE)
1588 return evaluate_reg_imm_alu_unknown(env, insn);
1589
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001590 /* dst_reg->type == CONST_IMM here, simulate execution of 'add' insn.
1591 * Don't care about overflow or negative values, just add them
1592 */
1593 if (opcode == BPF_ADD && BPF_SRC(insn->code) == BPF_K)
1594 dst_reg->imm += insn->imm;
1595 else if (opcode == BPF_ADD && BPF_SRC(insn->code) == BPF_X &&
1596 src_reg->type == CONST_IMM)
1597 dst_reg->imm += src_reg->imm;
1598 else
1599 mark_reg_unknown_value(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001600 return 0;
1601}
1602
Josef Bacik48461132016-09-28 10:54:32 -04001603static void check_reg_overflow(struct bpf_reg_state *reg)
1604{
1605 if (reg->max_value > BPF_REGISTER_MAX_RANGE)
1606 reg->max_value = BPF_REGISTER_MAX_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001607 if (reg->min_value < BPF_REGISTER_MIN_RANGE ||
1608 reg->min_value > BPF_REGISTER_MAX_RANGE)
Josef Bacik48461132016-09-28 10:54:32 -04001609 reg->min_value = BPF_REGISTER_MIN_RANGE;
1610}
1611
1612static void adjust_reg_min_max_vals(struct bpf_verifier_env *env,
1613 struct bpf_insn *insn)
1614{
1615 struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg;
Josef Bacikf23cc642016-11-14 15:45:36 -05001616 s64 min_val = BPF_REGISTER_MIN_RANGE;
1617 u64 max_val = BPF_REGISTER_MAX_RANGE;
Josef Bacik48461132016-09-28 10:54:32 -04001618 bool min_set = false, max_set = false;
1619 u8 opcode = BPF_OP(insn->code);
1620
1621 dst_reg = &regs[insn->dst_reg];
1622 if (BPF_SRC(insn->code) == BPF_X) {
1623 check_reg_overflow(&regs[insn->src_reg]);
1624 min_val = regs[insn->src_reg].min_value;
1625 max_val = regs[insn->src_reg].max_value;
1626
1627 /* If the source register is a random pointer then the
1628 * min_value/max_value values represent the range of the known
1629 * accesses into that value, not the actual min/max value of the
1630 * register itself. In this case we have to reset the reg range
1631 * values so we know it is not safe to look at.
1632 */
1633 if (regs[insn->src_reg].type != CONST_IMM &&
1634 regs[insn->src_reg].type != UNKNOWN_VALUE) {
1635 min_val = BPF_REGISTER_MIN_RANGE;
1636 max_val = BPF_REGISTER_MAX_RANGE;
1637 }
1638 } else if (insn->imm < BPF_REGISTER_MAX_RANGE &&
1639 (s64)insn->imm > BPF_REGISTER_MIN_RANGE) {
1640 min_val = max_val = insn->imm;
1641 min_set = max_set = true;
1642 }
1643
1644 /* We don't know anything about what was done to this register, mark it
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02001645 * as unknown. Also, if both derived bounds came from signed/unsigned
1646 * mixed compares and one side is unbounded, we cannot really do anything
1647 * with them as boundaries cannot be trusted. Thus, arithmetic of two
1648 * regs of such kind will get invalidated bounds on the dst side.
Josef Bacik48461132016-09-28 10:54:32 -04001649 */
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02001650 if ((min_val == BPF_REGISTER_MIN_RANGE &&
1651 max_val == BPF_REGISTER_MAX_RANGE) ||
1652 (BPF_SRC(insn->code) == BPF_X &&
1653 ((min_val != BPF_REGISTER_MIN_RANGE &&
1654 max_val == BPF_REGISTER_MAX_RANGE) ||
1655 (min_val == BPF_REGISTER_MIN_RANGE &&
1656 max_val != BPF_REGISTER_MAX_RANGE) ||
1657 (dst_reg->min_value != BPF_REGISTER_MIN_RANGE &&
1658 dst_reg->max_value == BPF_REGISTER_MAX_RANGE) ||
1659 (dst_reg->min_value == BPF_REGISTER_MIN_RANGE &&
1660 dst_reg->max_value != BPF_REGISTER_MAX_RANGE)) &&
1661 regs[insn->dst_reg].value_from_signed !=
1662 regs[insn->src_reg].value_from_signed)) {
Josef Bacik48461132016-09-28 10:54:32 -04001663 reset_reg_range_values(regs, insn->dst_reg);
1664 return;
1665 }
1666
Josef Bacikf23cc642016-11-14 15:45:36 -05001667 /* If one of our values was at the end of our ranges then we can't just
1668 * do our normal operations to the register, we need to set the values
1669 * to the min/max since they are undefined.
1670 */
Edward Cree655da3d2017-07-21 14:37:34 +01001671 if (opcode != BPF_SUB) {
1672 if (min_val == BPF_REGISTER_MIN_RANGE)
1673 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1674 if (max_val == BPF_REGISTER_MAX_RANGE)
1675 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
1676 }
Josef Bacikf23cc642016-11-14 15:45:36 -05001677
Josef Bacik48461132016-09-28 10:54:32 -04001678 switch (opcode) {
1679 case BPF_ADD:
Josef Bacikf23cc642016-11-14 15:45:36 -05001680 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1681 dst_reg->min_value += min_val;
1682 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1683 dst_reg->max_value += max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001684 break;
1685 case BPF_SUB:
Edward Cree655da3d2017-07-21 14:37:34 +01001686 /* If one of our values was at the end of our ranges, then the
1687 * _opposite_ value in the dst_reg goes to the end of our range.
1688 */
1689 if (min_val == BPF_REGISTER_MIN_RANGE)
1690 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
1691 if (max_val == BPF_REGISTER_MAX_RANGE)
1692 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001693 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
Edward Cree655da3d2017-07-21 14:37:34 +01001694 dst_reg->min_value -= max_val;
Josef Bacikf23cc642016-11-14 15:45:36 -05001695 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
Edward Cree655da3d2017-07-21 14:37:34 +01001696 dst_reg->max_value -= min_val;
Josef Bacik48461132016-09-28 10:54:32 -04001697 break;
1698 case BPF_MUL:
Josef Bacikf23cc642016-11-14 15:45:36 -05001699 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1700 dst_reg->min_value *= min_val;
1701 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1702 dst_reg->max_value *= max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001703 break;
1704 case BPF_AND:
Josef Bacikf23cc642016-11-14 15:45:36 -05001705 /* Disallow AND'ing of negative numbers, ain't nobody got time
1706 * for that. Otherwise the minimum is 0 and the max is the max
1707 * value we could AND against.
1708 */
1709 if (min_val < 0)
1710 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1711 else
1712 dst_reg->min_value = 0;
Josef Bacik48461132016-09-28 10:54:32 -04001713 dst_reg->max_value = max_val;
1714 break;
1715 case BPF_LSH:
1716 /* Gotta have special overflow logic here, if we're shifting
1717 * more than MAX_RANGE then just assume we have an invalid
1718 * range.
1719 */
1720 if (min_val > ilog2(BPF_REGISTER_MAX_RANGE))
1721 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001722 else if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
Josef Bacik48461132016-09-28 10:54:32 -04001723 dst_reg->min_value <<= min_val;
1724
1725 if (max_val > ilog2(BPF_REGISTER_MAX_RANGE))
1726 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001727 else if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
Josef Bacik48461132016-09-28 10:54:32 -04001728 dst_reg->max_value <<= max_val;
1729 break;
1730 case BPF_RSH:
Josef Bacikf23cc642016-11-14 15:45:36 -05001731 /* RSH by a negative number is undefined, and the BPF_RSH is an
1732 * unsigned shift, so make the appropriate casts.
Josef Bacik48461132016-09-28 10:54:32 -04001733 */
Josef Bacikf23cc642016-11-14 15:45:36 -05001734 if (min_val < 0 || dst_reg->min_value < 0)
1735 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1736 else
1737 dst_reg->min_value =
1738 (u64)(dst_reg->min_value) >> min_val;
1739 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1740 dst_reg->max_value >>= max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001741 break;
1742 default:
1743 reset_reg_range_values(regs, insn->dst_reg);
1744 break;
1745 }
1746
1747 check_reg_overflow(dst_reg);
1748}
1749
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001750/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001751static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001752{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001753 struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001754 u8 opcode = BPF_OP(insn->code);
1755 int err;
1756
1757 if (opcode == BPF_END || opcode == BPF_NEG) {
1758 if (opcode == BPF_NEG) {
1759 if (BPF_SRC(insn->code) != 0 ||
1760 insn->src_reg != BPF_REG_0 ||
1761 insn->off != 0 || insn->imm != 0) {
1762 verbose("BPF_NEG uses reserved fields\n");
1763 return -EINVAL;
1764 }
1765 } else {
1766 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
Edward Creee1594922017-09-15 14:37:38 +01001767 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
1768 BPF_CLASS(insn->code) == BPF_ALU64) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001769 verbose("BPF_END uses reserved fields\n");
1770 return -EINVAL;
1771 }
1772 }
1773
1774 /* check src operand */
1775 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1776 if (err)
1777 return err;
1778
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001779 if (is_pointer_value(env, insn->dst_reg)) {
1780 verbose("R%d pointer arithmetic prohibited\n",
1781 insn->dst_reg);
1782 return -EACCES;
1783 }
1784
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001785 /* check dest operand */
1786 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1787 if (err)
1788 return err;
1789
1790 } else if (opcode == BPF_MOV) {
1791
1792 if (BPF_SRC(insn->code) == BPF_X) {
1793 if (insn->imm != 0 || insn->off != 0) {
1794 verbose("BPF_MOV uses reserved fields\n");
1795 return -EINVAL;
1796 }
1797
1798 /* check src operand */
1799 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1800 if (err)
1801 return err;
1802 } else {
1803 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1804 verbose("BPF_MOV uses reserved fields\n");
1805 return -EINVAL;
1806 }
1807 }
1808
1809 /* check dest operand */
1810 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1811 if (err)
1812 return err;
1813
Josef Bacik48461132016-09-28 10:54:32 -04001814 /* we are setting our register to something new, we need to
1815 * reset its range values.
1816 */
1817 reset_reg_range_values(regs, insn->dst_reg);
1818
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001819 if (BPF_SRC(insn->code) == BPF_X) {
1820 if (BPF_CLASS(insn->code) == BPF_ALU64) {
1821 /* case: R1 = R2
1822 * copy register state to dest reg
1823 */
1824 regs[insn->dst_reg] = regs[insn->src_reg];
1825 } else {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001826 if (is_pointer_value(env, insn->src_reg)) {
1827 verbose("R%d partial copy of pointer\n",
1828 insn->src_reg);
1829 return -EACCES;
1830 }
Thomas Graf14117072016-10-18 19:51:19 +02001831 mark_reg_unknown_value(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001832 }
1833 } else {
1834 /* case: R = imm
1835 * remember the value we stored into this reg
1836 */
Daniel Borkmann3695b3b2017-12-22 16:29:05 +01001837 u64 imm;
1838
1839 if (BPF_CLASS(insn->code) == BPF_ALU64)
1840 imm = insn->imm;
1841 else
1842 imm = (u32)insn->imm;
1843
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001844 regs[insn->dst_reg].type = CONST_IMM;
Daniel Borkmann3695b3b2017-12-22 16:29:05 +01001845 regs[insn->dst_reg].imm = imm;
1846 regs[insn->dst_reg].max_value = imm;
1847 regs[insn->dst_reg].min_value = imm;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001848 }
1849
1850 } else if (opcode > BPF_END) {
1851 verbose("invalid BPF_ALU opcode %x\n", opcode);
1852 return -EINVAL;
1853
1854 } else { /* all other ALU ops: and, sub, xor, add, ... */
1855
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001856 if (BPF_SRC(insn->code) == BPF_X) {
1857 if (insn->imm != 0 || insn->off != 0) {
1858 verbose("BPF_ALU uses reserved fields\n");
1859 return -EINVAL;
1860 }
1861 /* check src1 operand */
1862 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1863 if (err)
1864 return err;
1865 } else {
1866 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1867 verbose("BPF_ALU uses reserved fields\n");
1868 return -EINVAL;
1869 }
1870 }
1871
1872 /* check src2 operand */
1873 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1874 if (err)
1875 return err;
1876
1877 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
1878 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
1879 verbose("div by zero\n");
1880 return -EINVAL;
1881 }
1882
Daniel Borkmannfcabc6d2018-01-29 02:48:57 +01001883 if (opcode == BPF_ARSH && BPF_CLASS(insn->code) != BPF_ALU64) {
1884 verbose("BPF_ARSH not supported for 32 bit ALU\n");
1885 return -EINVAL;
1886 }
1887
Rabin Vincent229394e2016-01-12 20:17:08 +01001888 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
1889 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
1890 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
1891
1892 if (insn->imm < 0 || insn->imm >= size) {
1893 verbose("invalid shift %d\n", insn->imm);
1894 return -EINVAL;
1895 }
1896 }
1897
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001898 /* check dest operand */
1899 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
1900 if (err)
1901 return err;
1902
1903 dst_reg = &regs[insn->dst_reg];
1904
Josef Bacik48461132016-09-28 10:54:32 -04001905 /* first we want to adjust our ranges. */
1906 adjust_reg_min_max_vals(env, insn);
1907
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001908 /* pattern match 'bpf_add Rx, imm' instruction */
1909 if (opcode == BPF_ADD && BPF_CLASS(insn->code) == BPF_ALU64 &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001910 dst_reg->type == FRAME_PTR && BPF_SRC(insn->code) == BPF_K) {
1911 dst_reg->type = PTR_TO_STACK;
1912 dst_reg->imm = insn->imm;
1913 return 0;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001914 } else if (opcode == BPF_ADD &&
1915 BPF_CLASS(insn->code) == BPF_ALU64 &&
Yonghong Song7bca0a92017-04-29 22:52:42 -07001916 dst_reg->type == PTR_TO_STACK &&
1917 ((BPF_SRC(insn->code) == BPF_X &&
1918 regs[insn->src_reg].type == CONST_IMM) ||
1919 BPF_SRC(insn->code) == BPF_K)) {
Daniel Borkmannd75d3ee2017-12-22 16:29:04 +01001920 if (BPF_SRC(insn->code) == BPF_X) {
1921 /* check in case the register contains a big
1922 * 64-bit value
1923 */
1924 if (regs[insn->src_reg].imm < -MAX_BPF_STACK ||
1925 regs[insn->src_reg].imm > MAX_BPF_STACK) {
1926 verbose("R%d value too big in R%d pointer arithmetic\n",
1927 insn->src_reg, insn->dst_reg);
1928 return -EACCES;
1929 }
Yonghong Song7bca0a92017-04-29 22:52:42 -07001930 dst_reg->imm += regs[insn->src_reg].imm;
Daniel Borkmannd75d3ee2017-12-22 16:29:04 +01001931 } else {
1932 /* safe against overflow: addition of 32-bit
1933 * numbers in 64-bit representation
1934 */
Yonghong Song7bca0a92017-04-29 22:52:42 -07001935 dst_reg->imm += insn->imm;
Daniel Borkmannd75d3ee2017-12-22 16:29:04 +01001936 }
1937 if (dst_reg->imm > 0 || dst_reg->imm < -MAX_BPF_STACK) {
1938 verbose("R%d out-of-bounds pointer arithmetic\n",
1939 insn->dst_reg);
1940 return -EACCES;
1941 }
Yonghong Song7bca0a92017-04-29 22:52:42 -07001942 return 0;
1943 } else if (opcode == BPF_ADD &&
1944 BPF_CLASS(insn->code) == BPF_ALU64 &&
Alexei Starovoitov1b9b69e2016-05-19 18:17:14 -07001945 (dst_reg->type == PTR_TO_PACKET ||
1946 (BPF_SRC(insn->code) == BPF_X &&
1947 regs[insn->src_reg].type == PTR_TO_PACKET))) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001948 /* ptr_to_packet += K|X */
1949 return check_packet_ptr_add(env, insn);
1950 } else if (BPF_CLASS(insn->code) == BPF_ALU64 &&
1951 dst_reg->type == UNKNOWN_VALUE &&
1952 env->allow_ptr_leaks) {
1953 /* unknown += K|X */
1954 return evaluate_reg_alu(env, insn);
1955 } else if (BPF_CLASS(insn->code) == BPF_ALU64 &&
1956 dst_reg->type == CONST_IMM &&
1957 env->allow_ptr_leaks) {
1958 /* reg_imm += K|X */
1959 return evaluate_reg_imm_alu(env, insn);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001960 } else if (is_pointer_value(env, insn->dst_reg)) {
1961 verbose("R%d pointer arithmetic prohibited\n",
1962 insn->dst_reg);
1963 return -EACCES;
1964 } else if (BPF_SRC(insn->code) == BPF_X &&
1965 is_pointer_value(env, insn->src_reg)) {
1966 verbose("R%d pointer arithmetic prohibited\n",
1967 insn->src_reg);
1968 return -EACCES;
1969 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001970
Josef Bacik48461132016-09-28 10:54:32 -04001971 /* If we did pointer math on a map value then just set it to our
1972 * PTR_TO_MAP_VALUE_ADJ type so we can deal with any stores or
1973 * loads to this register appropriately, otherwise just mark the
1974 * register as unknown.
1975 */
1976 if (env->allow_ptr_leaks &&
Daniel Borkmann8d674be2017-03-31 02:24:02 +02001977 BPF_CLASS(insn->code) == BPF_ALU64 && opcode == BPF_ADD &&
Josef Bacik48461132016-09-28 10:54:32 -04001978 (dst_reg->type == PTR_TO_MAP_VALUE ||
1979 dst_reg->type == PTR_TO_MAP_VALUE_ADJ))
1980 dst_reg->type = PTR_TO_MAP_VALUE_ADJ;
1981 else
1982 mark_reg_unknown_value(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001983 }
1984
1985 return 0;
1986}
1987
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001988static void find_good_pkt_pointers(struct bpf_verifier_state *state,
1989 struct bpf_reg_state *dst_reg)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001990{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01001991 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001992 int i;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02001993
1994 /* LLVM can generate two kind of checks:
1995 *
1996 * Type 1:
1997 *
1998 * r2 = r3;
1999 * r2 += 8;
2000 * if (r2 > pkt_end) goto <handle exception>
2001 * <access okay>
2002 *
2003 * Where:
2004 * r2 == dst_reg, pkt_end == src_reg
2005 * r2=pkt(id=n,off=8,r=0)
2006 * r3=pkt(id=n,off=0,r=0)
2007 *
2008 * Type 2:
2009 *
2010 * r2 = r3;
2011 * r2 += 8;
2012 * if (pkt_end >= r2) goto <access okay>
2013 * <handle exception>
2014 *
2015 * Where:
2016 * pkt_end == dst_reg, r2 == src_reg
2017 * r2=pkt(id=n,off=8,r=0)
2018 * r3=pkt(id=n,off=0,r=0)
2019 *
2020 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
2021 * so that range of bytes [r3, r3 + 8) is safe to access.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002022 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002023
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002024 for (i = 0; i < MAX_BPF_REG; i++)
2025 if (regs[i].type == PTR_TO_PACKET && regs[i].id == dst_reg->id)
Alexei Starovoitov0ea3c232017-03-24 15:57:33 -07002026 /* keep the maximum range already checked */
2027 regs[i].range = max(regs[i].range, dst_reg->off);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002028
2029 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
2030 if (state->stack_slot_type[i] != STACK_SPILL)
2031 continue;
2032 reg = &state->spilled_regs[i / BPF_REG_SIZE];
2033 if (reg->type == PTR_TO_PACKET && reg->id == dst_reg->id)
Alexei Starovoitov0ea3c232017-03-24 15:57:33 -07002034 reg->range = max(reg->range, dst_reg->off);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002035 }
2036}
2037
Josef Bacik48461132016-09-28 10:54:32 -04002038/* Adjusts the register min/max values in the case that the dst_reg is the
2039 * variable register that we are working on, and src_reg is a constant or we're
2040 * simply doing a BPF_K check.
2041 */
2042static void reg_set_min_max(struct bpf_reg_state *true_reg,
2043 struct bpf_reg_state *false_reg, u64 val,
2044 u8 opcode)
2045{
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002046 bool value_from_signed = true;
2047 bool is_range = true;
2048
Josef Bacik48461132016-09-28 10:54:32 -04002049 switch (opcode) {
2050 case BPF_JEQ:
2051 /* If this is false then we know nothing Jon Snow, but if it is
2052 * true then we know for sure.
2053 */
2054 true_reg->max_value = true_reg->min_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002055 is_range = false;
Josef Bacik48461132016-09-28 10:54:32 -04002056 break;
2057 case BPF_JNE:
2058 /* If this is true we know nothing Jon Snow, but if it is false
2059 * we know the value for sure;
2060 */
2061 false_reg->max_value = false_reg->min_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002062 is_range = false;
Josef Bacik48461132016-09-28 10:54:32 -04002063 break;
2064 case BPF_JGT:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002065 value_from_signed = false;
2066 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002067 case BPF_JSGT:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002068 if (true_reg->value_from_signed != value_from_signed)
2069 reset_reg_range_values(true_reg, 0);
2070 if (false_reg->value_from_signed != value_from_signed)
2071 reset_reg_range_values(false_reg, 0);
2072 if (opcode == BPF_JGT) {
2073 /* Unsigned comparison, the minimum value is 0. */
2074 false_reg->min_value = 0;
2075 }
Josef Bacik48461132016-09-28 10:54:32 -04002076 /* If this is false then we know the maximum val is val,
2077 * otherwise we know the min val is val+1.
2078 */
2079 false_reg->max_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002080 false_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002081 true_reg->min_value = val + 1;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002082 true_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002083 break;
2084 case BPF_JGE:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002085 value_from_signed = false;
2086 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002087 case BPF_JSGE:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002088 if (true_reg->value_from_signed != value_from_signed)
2089 reset_reg_range_values(true_reg, 0);
2090 if (false_reg->value_from_signed != value_from_signed)
2091 reset_reg_range_values(false_reg, 0);
2092 if (opcode == BPF_JGE) {
2093 /* Unsigned comparison, the minimum value is 0. */
2094 false_reg->min_value = 0;
2095 }
Josef Bacik48461132016-09-28 10:54:32 -04002096 /* If this is false then we know the maximum value is val - 1,
2097 * otherwise we know the mimimum value is val.
2098 */
2099 false_reg->max_value = val - 1;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002100 false_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002101 true_reg->min_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002102 true_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002103 break;
2104 default:
2105 break;
2106 }
2107
2108 check_reg_overflow(false_reg);
2109 check_reg_overflow(true_reg);
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002110 if (is_range) {
2111 if (__is_pointer_value(false, false_reg))
2112 reset_reg_range_values(false_reg, 0);
2113 if (__is_pointer_value(false, true_reg))
2114 reset_reg_range_values(true_reg, 0);
2115 }
Josef Bacik48461132016-09-28 10:54:32 -04002116}
2117
2118/* Same as above, but for the case that dst_reg is a CONST_IMM reg and src_reg
2119 * is the variable reg.
2120 */
2121static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
2122 struct bpf_reg_state *false_reg, u64 val,
2123 u8 opcode)
2124{
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002125 bool value_from_signed = true;
2126 bool is_range = true;
2127
Josef Bacik48461132016-09-28 10:54:32 -04002128 switch (opcode) {
2129 case BPF_JEQ:
2130 /* If this is false then we know nothing Jon Snow, but if it is
2131 * true then we know for sure.
2132 */
2133 true_reg->max_value = true_reg->min_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002134 is_range = false;
Josef Bacik48461132016-09-28 10:54:32 -04002135 break;
2136 case BPF_JNE:
2137 /* If this is true we know nothing Jon Snow, but if it is false
2138 * we know the value for sure;
2139 */
2140 false_reg->max_value = false_reg->min_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002141 is_range = false;
Josef Bacik48461132016-09-28 10:54:32 -04002142 break;
2143 case BPF_JGT:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002144 value_from_signed = false;
2145 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002146 case BPF_JSGT:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002147 if (true_reg->value_from_signed != value_from_signed)
2148 reset_reg_range_values(true_reg, 0);
2149 if (false_reg->value_from_signed != value_from_signed)
2150 reset_reg_range_values(false_reg, 0);
2151 if (opcode == BPF_JGT) {
2152 /* Unsigned comparison, the minimum value is 0. */
2153 true_reg->min_value = 0;
2154 }
Josef Bacik48461132016-09-28 10:54:32 -04002155 /*
2156 * If this is false, then the val is <= the register, if it is
2157 * true the register <= to the val.
2158 */
2159 false_reg->min_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002160 false_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002161 true_reg->max_value = val - 1;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002162 true_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002163 break;
2164 case BPF_JGE:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002165 value_from_signed = false;
2166 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002167 case BPF_JSGE:
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002168 if (true_reg->value_from_signed != value_from_signed)
2169 reset_reg_range_values(true_reg, 0);
2170 if (false_reg->value_from_signed != value_from_signed)
2171 reset_reg_range_values(false_reg, 0);
2172 if (opcode == BPF_JGE) {
2173 /* Unsigned comparison, the minimum value is 0. */
2174 true_reg->min_value = 0;
2175 }
Josef Bacik48461132016-09-28 10:54:32 -04002176 /* If this is false then constant < register, if it is true then
2177 * the register < constant.
2178 */
2179 false_reg->min_value = val + 1;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002180 false_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002181 true_reg->max_value = val;
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002182 true_reg->value_from_signed = value_from_signed;
Josef Bacik48461132016-09-28 10:54:32 -04002183 break;
2184 default:
2185 break;
2186 }
2187
2188 check_reg_overflow(false_reg);
2189 check_reg_overflow(true_reg);
Daniel Borkmannbf5b91b2017-07-21 00:00:21 +02002190 if (is_range) {
2191 if (__is_pointer_value(false, false_reg))
2192 reset_reg_range_values(false_reg, 0);
2193 if (__is_pointer_value(false, true_reg))
2194 reset_reg_range_values(true_reg, 0);
2195 }
Josef Bacik48461132016-09-28 10:54:32 -04002196}
2197
Thomas Graf14117072016-10-18 19:51:19 +02002198static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
2199 enum bpf_reg_type type)
2200{
2201 struct bpf_reg_state *reg = &regs[regno];
2202
2203 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
2204 reg->type = type;
Daniel Borkmann1889d6d2016-12-15 01:30:06 +01002205 /* We don't need id from this point onwards anymore, thus we
2206 * should better reset it, so that state pruning has chances
2207 * to take effect.
2208 */
2209 reg->id = 0;
Thomas Graf14117072016-10-18 19:51:19 +02002210 if (type == UNKNOWN_VALUE)
Daniel Borkmann0e0f1d62016-12-18 01:52:59 +01002211 __mark_reg_unknown_value(regs, regno);
Thomas Graf14117072016-10-18 19:51:19 +02002212 }
2213}
2214
2215/* The logic is similar to find_good_pkt_pointers(), both could eventually
2216 * be folded together at some point.
2217 */
2218static void mark_map_regs(struct bpf_verifier_state *state, u32 regno,
2219 enum bpf_reg_type type)
2220{
2221 struct bpf_reg_state *regs = state->regs;
Daniel Borkmann1889d6d2016-12-15 01:30:06 +01002222 u32 id = regs[regno].id;
Thomas Graf14117072016-10-18 19:51:19 +02002223 int i;
2224
2225 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmann1889d6d2016-12-15 01:30:06 +01002226 mark_map_reg(regs, i, id, type);
Thomas Graf14117072016-10-18 19:51:19 +02002227
2228 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
2229 if (state->stack_slot_type[i] != STACK_SPILL)
2230 continue;
Daniel Borkmann1889d6d2016-12-15 01:30:06 +01002231 mark_map_reg(state->spilled_regs, i / BPF_REG_SIZE, id, type);
Thomas Graf14117072016-10-18 19:51:19 +02002232 }
2233}
2234
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002235static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002236 struct bpf_insn *insn, int *insn_idx)
2237{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002238 struct bpf_verifier_state *other_branch, *this_branch = &env->cur_state;
2239 struct bpf_reg_state *regs = this_branch->regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002240 u8 opcode = BPF_OP(insn->code);
2241 int err;
2242
2243 if (opcode > BPF_EXIT) {
2244 verbose("invalid BPF_JMP opcode %x\n", opcode);
2245 return -EINVAL;
2246 }
2247
2248 if (BPF_SRC(insn->code) == BPF_X) {
2249 if (insn->imm != 0) {
2250 verbose("BPF_JMP uses reserved fields\n");
2251 return -EINVAL;
2252 }
2253
2254 /* check src1 operand */
2255 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2256 if (err)
2257 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002258
2259 if (is_pointer_value(env, insn->src_reg)) {
2260 verbose("R%d pointer comparison prohibited\n",
2261 insn->src_reg);
2262 return -EACCES;
2263 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002264 } else {
2265 if (insn->src_reg != BPF_REG_0) {
2266 verbose("BPF_JMP uses reserved fields\n");
2267 return -EINVAL;
2268 }
2269 }
2270
2271 /* check src2 operand */
2272 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
2273 if (err)
2274 return err;
2275
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002276 dst_reg = &regs[insn->dst_reg];
2277
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002278 /* detect if R == 0 where R was initialized to zero earlier */
2279 if (BPF_SRC(insn->code) == BPF_K &&
2280 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002281 dst_reg->type == CONST_IMM && dst_reg->imm == insn->imm) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002282 if (opcode == BPF_JEQ) {
2283 /* if (imm == imm) goto pc+off;
2284 * only follow the goto, ignore fall-through
2285 */
2286 *insn_idx += insn->off;
2287 return 0;
2288 } else {
2289 /* if (imm != imm) goto pc+off;
2290 * only follow fall-through branch, since
2291 * that's where the program will go
2292 */
2293 return 0;
2294 }
2295 }
2296
2297 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
2298 if (!other_branch)
2299 return -EFAULT;
2300
Josef Bacik48461132016-09-28 10:54:32 -04002301 /* detect if we are comparing against a constant value so we can adjust
2302 * our min/max values for our dst register.
2303 */
2304 if (BPF_SRC(insn->code) == BPF_X) {
2305 if (regs[insn->src_reg].type == CONST_IMM)
2306 reg_set_min_max(&other_branch->regs[insn->dst_reg],
2307 dst_reg, regs[insn->src_reg].imm,
2308 opcode);
2309 else if (dst_reg->type == CONST_IMM)
2310 reg_set_min_max_inv(&other_branch->regs[insn->src_reg],
2311 &regs[insn->src_reg], dst_reg->imm,
2312 opcode);
2313 } else {
2314 reg_set_min_max(&other_branch->regs[insn->dst_reg],
2315 dst_reg, insn->imm, opcode);
2316 }
2317
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002318 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002319 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002320 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
2321 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf14117072016-10-18 19:51:19 +02002322 /* Mark all identical map registers in each branch as either
2323 * safe or unknown depending R == 0 or R != 0 conditional.
2324 */
2325 mark_map_regs(this_branch, insn->dst_reg,
2326 opcode == BPF_JEQ ? PTR_TO_MAP_VALUE : UNKNOWN_VALUE);
2327 mark_map_regs(other_branch, insn->dst_reg,
2328 opcode == BPF_JEQ ? UNKNOWN_VALUE : PTR_TO_MAP_VALUE);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002329 } else if (BPF_SRC(insn->code) == BPF_X && opcode == BPF_JGT &&
2330 dst_reg->type == PTR_TO_PACKET &&
2331 regs[insn->src_reg].type == PTR_TO_PACKET_END) {
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002332 find_good_pkt_pointers(this_branch, dst_reg);
2333 } else if (BPF_SRC(insn->code) == BPF_X && opcode == BPF_JGE &&
2334 dst_reg->type == PTR_TO_PACKET_END &&
2335 regs[insn->src_reg].type == PTR_TO_PACKET) {
2336 find_good_pkt_pointers(other_branch, &regs[insn->src_reg]);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002337 } else if (is_pointer_value(env, insn->dst_reg)) {
2338 verbose("R%d pointer comparison prohibited\n", insn->dst_reg);
2339 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002340 }
2341 if (log_level)
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002342 print_verifier_state(this_branch);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002343 return 0;
2344}
2345
Alexei Starovoitov0246e642014-09-26 00:17:04 -07002346/* return the map pointer stored inside BPF_LD_IMM64 instruction */
2347static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
2348{
2349 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
2350
2351 return (struct bpf_map *) (unsigned long) imm64;
2352}
2353
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002354/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002355static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002356{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002357 struct bpf_reg_state *regs = env->cur_state.regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002358 int err;
2359
2360 if (BPF_SIZE(insn->code) != BPF_DW) {
2361 verbose("invalid BPF_LD_IMM insn\n");
2362 return -EINVAL;
2363 }
2364 if (insn->off != 0) {
2365 verbose("BPF_LD_IMM64 uses reserved fields\n");
2366 return -EINVAL;
2367 }
2368
2369 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
2370 if (err)
2371 return err;
2372
Jakub Kicinski6b173872016-09-21 11:43:59 +01002373 if (insn->src_reg == 0) {
2374 /* generic move 64-bit immediate into a register,
2375 * only analyzer needs to collect the ld_imm value.
2376 */
2377 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
2378
2379 if (!env->analyzer_ops)
2380 return 0;
2381
2382 regs[insn->dst_reg].type = CONST_IMM;
2383 regs[insn->dst_reg].imm = imm;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002384 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01002385 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002386
2387 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
2388 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
2389
2390 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
2391 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
2392 return 0;
2393}
2394
Daniel Borkmann96be4322015-03-01 12:31:46 +01002395static bool may_access_skb(enum bpf_prog_type type)
2396{
2397 switch (type) {
2398 case BPF_PROG_TYPE_SOCKET_FILTER:
2399 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee82015-03-20 15:11:11 +01002400 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01002401 return true;
2402 default:
2403 return false;
2404 }
2405}
2406
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002407/* verify safety of LD_ABS|LD_IND instructions:
2408 * - they can only appear in the programs where ctx == skb
2409 * - since they are wrappers of function calls, they scratch R1-R5 registers,
2410 * preserve R6-R9, and store return value into R0
2411 *
2412 * Implicit input:
2413 * ctx == skb == R6 == CTX
2414 *
2415 * Explicit input:
2416 * SRC == any register
2417 * IMM == 32-bit immediate
2418 *
2419 * Output:
2420 * R0 - 8/16/32-bit skb data converted to cpu endianness
2421 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002422static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002423{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002424 struct bpf_reg_state *regs = env->cur_state.regs;
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002425 u8 mode = BPF_MODE(insn->code);
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002426 struct bpf_reg_state *reg;
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002427 int i, err;
2428
Daniel Borkmann24701ec2015-03-01 12:31:47 +01002429 if (!may_access_skb(env->prog->type)) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002430 verbose("BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002431 return -EINVAL;
2432 }
2433
2434 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07002435 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002436 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002437 verbose("BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002438 return -EINVAL;
2439 }
2440
2441 /* check whether implicit source operand (register R6) is readable */
2442 err = check_reg_arg(regs, BPF_REG_6, SRC_OP);
2443 if (err)
2444 return err;
2445
2446 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
2447 verbose("at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
2448 return -EINVAL;
2449 }
2450
2451 if (mode == BPF_IND) {
2452 /* check explicit source operand */
2453 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2454 if (err)
2455 return err;
2456 }
2457
2458 /* reset caller saved regs to unreadable */
2459 for (i = 0; i < CALLER_SAVED_REGS; i++) {
2460 reg = regs + caller_saved[i];
2461 reg->type = NOT_INIT;
2462 reg->imm = 0;
2463 }
2464
2465 /* mark destination R0 register as readable, since it contains
2466 * the value fetched from the packet
2467 */
2468 regs[BPF_REG_0].type = UNKNOWN_VALUE;
2469 return 0;
2470}
2471
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002472/* non-recursive DFS pseudo code
2473 * 1 procedure DFS-iterative(G,v):
2474 * 2 label v as discovered
2475 * 3 let S be a stack
2476 * 4 S.push(v)
2477 * 5 while S is not empty
2478 * 6 t <- S.pop()
2479 * 7 if t is what we're looking for:
2480 * 8 return t
2481 * 9 for all edges e in G.adjacentEdges(t) do
2482 * 10 if edge e is already labelled
2483 * 11 continue with the next edge
2484 * 12 w <- G.adjacentVertex(t,e)
2485 * 13 if vertex w is not discovered and not explored
2486 * 14 label e as tree-edge
2487 * 15 label w as discovered
2488 * 16 S.push(w)
2489 * 17 continue at 5
2490 * 18 else if vertex w is discovered
2491 * 19 label e as back-edge
2492 * 20 else
2493 * 21 // vertex w is explored
2494 * 22 label e as forward- or cross-edge
2495 * 23 label t as explored
2496 * 24 S.pop()
2497 *
2498 * convention:
2499 * 0x10 - discovered
2500 * 0x11 - discovered and fall-through edge labelled
2501 * 0x12 - discovered and fall-through and branch edges labelled
2502 * 0x20 - explored
2503 */
2504
2505enum {
2506 DISCOVERED = 0x10,
2507 EXPLORED = 0x20,
2508 FALLTHROUGH = 1,
2509 BRANCH = 2,
2510};
2511
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002512#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002513
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002514static int *insn_stack; /* stack of insns to process */
2515static int cur_stack; /* current stack index */
2516static int *insn_state;
2517
2518/* t, w, e - match pseudo-code above:
2519 * t - index of current instruction
2520 * w - next instruction
2521 * e - edge
2522 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002523static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002524{
2525 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
2526 return 0;
2527
2528 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
2529 return 0;
2530
2531 if (w < 0 || w >= env->prog->len) {
2532 verbose("jump out of range from insn %d to %d\n", t, w);
2533 return -EINVAL;
2534 }
2535
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002536 if (e == BRANCH)
2537 /* mark branch target for state pruning */
2538 env->explored_states[w] = STATE_LIST_MARK;
2539
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002540 if (insn_state[w] == 0) {
2541 /* tree-edge */
2542 insn_state[t] = DISCOVERED | e;
2543 insn_state[w] = DISCOVERED;
2544 if (cur_stack >= env->prog->len)
2545 return -E2BIG;
2546 insn_stack[cur_stack++] = w;
2547 return 1;
2548 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
2549 verbose("back-edge from insn %d to %d\n", t, w);
2550 return -EINVAL;
2551 } else if (insn_state[w] == EXPLORED) {
2552 /* forward- or cross-edge */
2553 insn_state[t] = DISCOVERED | e;
2554 } else {
2555 verbose("insn state internal bug\n");
2556 return -EFAULT;
2557 }
2558 return 0;
2559}
2560
2561/* non-recursive depth-first-search to detect loops in BPF program
2562 * loop == back-edge in directed graph
2563 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002564static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002565{
2566 struct bpf_insn *insns = env->prog->insnsi;
2567 int insn_cnt = env->prog->len;
2568 int ret = 0;
2569 int i, t;
2570
2571 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
2572 if (!insn_state)
2573 return -ENOMEM;
2574
2575 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
2576 if (!insn_stack) {
2577 kfree(insn_state);
2578 return -ENOMEM;
2579 }
2580
2581 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
2582 insn_stack[0] = 0; /* 0 is the first instruction */
2583 cur_stack = 1;
2584
2585peek_stack:
2586 if (cur_stack == 0)
2587 goto check_state;
2588 t = insn_stack[cur_stack - 1];
2589
2590 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
2591 u8 opcode = BPF_OP(insns[t].code);
2592
2593 if (opcode == BPF_EXIT) {
2594 goto mark_explored;
2595 } else if (opcode == BPF_CALL) {
2596 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2597 if (ret == 1)
2598 goto peek_stack;
2599 else if (ret < 0)
2600 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02002601 if (t + 1 < insn_cnt)
2602 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002603 } else if (opcode == BPF_JA) {
2604 if (BPF_SRC(insns[t].code) != BPF_K) {
2605 ret = -EINVAL;
2606 goto err_free;
2607 }
2608 /* unconditional jump with single edge */
2609 ret = push_insn(t, t + insns[t].off + 1,
2610 FALLTHROUGH, env);
2611 if (ret == 1)
2612 goto peek_stack;
2613 else if (ret < 0)
2614 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002615 /* tell verifier to check for equivalent states
2616 * after every call and jump
2617 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07002618 if (t + 1 < insn_cnt)
2619 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002620 } else {
2621 /* conditional jump with two edges */
Daniel Borkmann577aa832017-05-18 03:00:06 +02002622 env->explored_states[t] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002623 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2624 if (ret == 1)
2625 goto peek_stack;
2626 else if (ret < 0)
2627 goto err_free;
2628
2629 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
2630 if (ret == 1)
2631 goto peek_stack;
2632 else if (ret < 0)
2633 goto err_free;
2634 }
2635 } else {
2636 /* all other non-branch instructions with single
2637 * fall-through edge
2638 */
2639 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2640 if (ret == 1)
2641 goto peek_stack;
2642 else if (ret < 0)
2643 goto err_free;
2644 }
2645
2646mark_explored:
2647 insn_state[t] = EXPLORED;
2648 if (cur_stack-- <= 0) {
2649 verbose("pop stack internal bug\n");
2650 ret = -EFAULT;
2651 goto err_free;
2652 }
2653 goto peek_stack;
2654
2655check_state:
2656 for (i = 0; i < insn_cnt; i++) {
2657 if (insn_state[i] != EXPLORED) {
2658 verbose("unreachable insn %d\n", i);
2659 ret = -EINVAL;
2660 goto err_free;
2661 }
2662 }
2663 ret = 0; /* cfg looks good */
2664
2665err_free:
2666 kfree(insn_state);
2667 kfree(insn_stack);
2668 return ret;
2669}
2670
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002671/* the following conditions reduce the number of explored insns
2672 * from ~140k to ~80k for ultra large programs that use a lot of ptr_to_packet
2673 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002674static bool compare_ptrs_to_packet(struct bpf_reg_state *old,
2675 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002676{
2677 if (old->id != cur->id)
2678 return false;
2679
2680 /* old ptr_to_packet is more conservative, since it allows smaller
2681 * range. Ex:
2682 * old(off=0,r=10) is equal to cur(off=0,r=20), because
2683 * old(off=0,r=10) means that with range=10 the verifier proceeded
2684 * further and found no issues with the program. Now we're in the same
2685 * spot with cur(off=0,r=20), so we're safe too, since anything further
2686 * will only be looking at most 10 bytes after this pointer.
2687 */
2688 if (old->off == cur->off && old->range < cur->range)
2689 return true;
2690
2691 /* old(off=20,r=10) is equal to cur(off=22,re=22 or 5 or 0)
2692 * since both cannot be used for packet access and safe(old)
2693 * pointer has smaller off that could be used for further
2694 * 'if (ptr > data_end)' check
2695 * Ex:
2696 * old(off=20,r=10) and cur(off=22,r=22) and cur(off=22,r=0) mean
2697 * that we cannot access the packet.
2698 * The safe range is:
2699 * [ptr, ptr + range - off)
2700 * so whenever off >=range, it means no safe bytes from this pointer.
2701 * When comparing old->off <= cur->off, it means that older code
2702 * went with smaller offset and that offset was later
2703 * used to figure out the safe range after 'if (ptr > data_end)' check
2704 * Say, 'old' state was explored like:
2705 * ... R3(off=0, r=0)
2706 * R4 = R3 + 20
2707 * ... now R4(off=20,r=0) <-- here
2708 * if (R4 > data_end)
2709 * ... R4(off=20,r=20), R3(off=0,r=20) and R3 can be used to access.
2710 * ... the code further went all the way to bpf_exit.
2711 * Now the 'cur' state at the mark 'here' has R4(off=30,r=0).
2712 * old_R4(off=20,r=0) equal to cur_R4(off=30,r=0), since if the verifier
2713 * goes further, such cur_R4 will give larger safe packet range after
2714 * 'if (R4 > data_end)' and all further insn were already good with r=20,
2715 * so they will be good with r=30 and we can prune the search.
2716 */
2717 if (old->off <= cur->off &&
2718 old->off >= old->range && cur->off >= cur->range)
2719 return true;
2720
2721 return false;
2722}
2723
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002724/* compare two verifier states
2725 *
2726 * all states stored in state_list are known to be valid, since
2727 * verifier reached 'bpf_exit' instruction through them
2728 *
2729 * this function is called when verifier exploring different branches of
2730 * execution popped from the state stack. If it sees an old state that has
2731 * more strict register state and more strict stack state then this execution
2732 * branch doesn't need to be explored further, since verifier already
2733 * concluded that more strict state leads to valid finish.
2734 *
2735 * Therefore two states are equivalent if register state is more conservative
2736 * and explored stack state is more conservative than the current one.
2737 * Example:
2738 * explored current
2739 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
2740 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
2741 *
2742 * In other words if current stack state (one being explored) has more
2743 * valid slots than old one that already passed validation, it means
2744 * the verifier can stop exploring and conclude that current state is valid too
2745 *
2746 * Similarly with registers. If explored state has register type as invalid
2747 * whereas register type in current state is meaningful, it means that
2748 * the current state will reach 'bpf_exit' instruction safely
2749 */
Josef Bacik48461132016-09-28 10:54:32 -04002750static bool states_equal(struct bpf_verifier_env *env,
2751 struct bpf_verifier_state *old,
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002752 struct bpf_verifier_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002753{
Josef Bacike2d2afe2016-11-29 12:27:09 -05002754 bool varlen_map_access = env->varlen_map_value_access;
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002755 struct bpf_reg_state *rold, *rcur;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002756 int i;
2757
2758 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002759 rold = &old->regs[i];
2760 rcur = &cur->regs[i];
2761
2762 if (memcmp(rold, rcur, sizeof(*rold)) == 0)
2763 continue;
2764
Josef Bacik48461132016-09-28 10:54:32 -04002765 /* If the ranges were not the same, but everything else was and
2766 * we didn't do a variable access into a map then we are a-ok.
2767 */
Josef Bacike2d2afe2016-11-29 12:27:09 -05002768 if (!varlen_map_access &&
Alexei Starovoitovb7f5aa12016-12-07 10:57:59 -08002769 memcmp(rold, rcur, offsetofend(struct bpf_reg_state, id)) == 0)
Josef Bacik48461132016-09-28 10:54:32 -04002770 continue;
2771
Josef Bacike2d2afe2016-11-29 12:27:09 -05002772 /* If we didn't map access then again we don't care about the
2773 * mismatched range values and it's ok if our old type was
Ben Hutchings37435f72017-12-23 02:26:17 +00002774 * UNKNOWN and we didn't go to a NOT_INIT'ed or pointer reg.
Josef Bacike2d2afe2016-11-29 12:27:09 -05002775 */
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002776 if (rold->type == NOT_INIT ||
Josef Bacike2d2afe2016-11-29 12:27:09 -05002777 (!varlen_map_access && rold->type == UNKNOWN_VALUE &&
Ben Hutchings37435f72017-12-23 02:26:17 +00002778 rcur->type != NOT_INIT &&
2779 !__is_pointer_value(env->allow_ptr_leaks, rcur)))
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002780 continue;
2781
Daniel Borkmann577aa832017-05-18 03:00:06 +02002782 /* Don't care about the reg->id in this case. */
2783 if (rold->type == PTR_TO_MAP_VALUE_OR_NULL &&
2784 rcur->type == PTR_TO_MAP_VALUE_OR_NULL &&
2785 rold->map_ptr == rcur->map_ptr)
2786 continue;
2787
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002788 if (rold->type == PTR_TO_PACKET && rcur->type == PTR_TO_PACKET &&
2789 compare_ptrs_to_packet(rold, rcur))
2790 continue;
2791
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002792 return false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002793 }
2794
2795 for (i = 0; i < MAX_BPF_STACK; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002796 if (old->stack_slot_type[i] == STACK_INVALID)
2797 continue;
2798 if (old->stack_slot_type[i] != cur->stack_slot_type[i])
2799 /* Ex: old explored (safe) state has STACK_SPILL in
2800 * this stack slot, but current has has STACK_MISC ->
2801 * this verifier states are not equivalent,
2802 * return false to continue verification of this path
2803 */
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002804 return false;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002805 if (i % BPF_REG_SIZE)
2806 continue;
2807 if (memcmp(&old->spilled_regs[i / BPF_REG_SIZE],
2808 &cur->spilled_regs[i / BPF_REG_SIZE],
2809 sizeof(old->spilled_regs[0])))
2810 /* when explored and current stack slot types are
2811 * the same, check that stored pointers types
2812 * are the same as well.
2813 * Ex: explored safe path could have stored
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002814 * (bpf_reg_state) {.type = PTR_TO_STACK, .imm = -8}
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002815 * but current path has stored:
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002816 * (bpf_reg_state) {.type = PTR_TO_STACK, .imm = -16}
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002817 * such verifier states are not equivalent.
2818 * return false to continue verification of this path
2819 */
2820 return false;
2821 else
2822 continue;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002823 }
2824 return true;
2825}
2826
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002827static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002828{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002829 struct bpf_verifier_state_list *new_sl;
2830 struct bpf_verifier_state_list *sl;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002831
2832 sl = env->explored_states[insn_idx];
2833 if (!sl)
2834 /* this 'insn_idx' instruction wasn't marked, so we will not
2835 * be doing state search here
2836 */
2837 return 0;
2838
2839 while (sl != STATE_LIST_MARK) {
Josef Bacik48461132016-09-28 10:54:32 -04002840 if (states_equal(env, &sl->state, &env->cur_state))
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002841 /* reached equivalent register/stack state,
2842 * prune the search
2843 */
2844 return 1;
2845 sl = sl->next;
2846 }
2847
2848 /* there were no equivalent states, remember current one.
2849 * technically the current state is not proven to be safe yet,
2850 * but it will either reach bpf_exit (which means it's safe) or
2851 * it will be rejected. Since there are no loops, we won't be
2852 * seeing this 'insn_idx' instruction again on the way to bpf_exit
2853 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002854 new_sl = kmalloc(sizeof(struct bpf_verifier_state_list), GFP_USER);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002855 if (!new_sl)
2856 return -ENOMEM;
2857
2858 /* add new state to the head of linked list */
2859 memcpy(&new_sl->state, &env->cur_state, sizeof(env->cur_state));
2860 new_sl->next = env->explored_states[insn_idx];
2861 env->explored_states[insn_idx] = new_sl;
2862 return 0;
2863}
2864
Jakub Kicinski13a27df2016-09-21 11:43:58 +01002865static int ext_analyzer_insn_hook(struct bpf_verifier_env *env,
2866 int insn_idx, int prev_insn_idx)
2867{
2868 if (!env->analyzer_ops || !env->analyzer_ops->insn_hook)
2869 return 0;
2870
2871 return env->analyzer_ops->insn_hook(env, insn_idx, prev_insn_idx);
2872}
2873
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002874static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002875{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002876 struct bpf_verifier_state *state = &env->cur_state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002877 struct bpf_insn *insns = env->prog->insnsi;
Jakub Kicinski58e2af82016-09-21 11:43:57 +01002878 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002879 int insn_cnt = env->prog->len;
2880 int insn_idx, prev_insn_idx = 0;
2881 int insn_processed = 0;
2882 bool do_print_state = false;
2883
2884 init_reg_state(regs);
2885 insn_idx = 0;
Josef Bacik48461132016-09-28 10:54:32 -04002886 env->varlen_map_value_access = false;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002887 for (;;) {
2888 struct bpf_insn *insn;
2889 u8 class;
2890 int err;
2891
2892 if (insn_idx >= insn_cnt) {
2893 verbose("invalid insn idx %d insn_cnt %d\n",
2894 insn_idx, insn_cnt);
2895 return -EFAULT;
2896 }
2897
2898 insn = &insns[insn_idx];
2899 class = BPF_CLASS(insn->code);
2900
Daniel Borkmann07016152016-04-05 22:33:17 +02002901 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002902 verbose("BPF program is too large. Proccessed %d insn\n",
2903 insn_processed);
2904 return -E2BIG;
2905 }
2906
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002907 err = is_state_visited(env, insn_idx);
2908 if (err < 0)
2909 return err;
2910 if (err == 1) {
2911 /* found equivalent state, can prune the search */
2912 if (log_level) {
2913 if (do_print_state)
2914 verbose("\nfrom %d to %d: safe\n",
2915 prev_insn_idx, insn_idx);
2916 else
2917 verbose("%d: safe\n", insn_idx);
2918 }
2919 goto process_bpf_exit;
2920 }
2921
Alexei Starovoitovae30c982018-12-03 22:46:04 -08002922 if (signal_pending(current))
2923 return -EAGAIN;
2924
Daniel Borkmann577aa832017-05-18 03:00:06 +02002925 if (need_resched())
2926 cond_resched();
2927
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002928 if (log_level && do_print_state) {
2929 verbose("\nfrom %d to %d:", prev_insn_idx, insn_idx);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002930 print_verifier_state(&env->cur_state);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002931 do_print_state = false;
2932 }
2933
2934 if (log_level) {
2935 verbose("%d: ", insn_idx);
Daniel Borkmannced0a312017-05-08 00:04:09 +02002936 print_bpf_insn(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002937 }
2938
Jakub Kicinski13a27df2016-09-21 11:43:58 +01002939 err = ext_analyzer_insn_hook(env, insn_idx, prev_insn_idx);
2940 if (err)
2941 return err;
2942
Daniel Borkmann7b5b73e2017-12-22 16:29:03 +01002943 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002944 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002945 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002946 if (err)
2947 return err;
2948
2949 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002950 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002951
2952 /* check for reserved fields is already done */
2953
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002954 /* check src operand */
2955 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2956 if (err)
2957 return err;
2958
2959 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
2960 if (err)
2961 return err;
2962
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07002963 src_reg_type = regs[insn->src_reg].type;
2964
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002965 /* check that memory (src_reg + off) is readable,
2966 * the state of dst_reg will be updated by this func
2967 */
Ben Hutchings62e08652018-12-05 22:41:36 +00002968 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002969 BPF_SIZE(insn->code), BPF_READ,
2970 insn->dst_reg);
2971 if (err)
2972 return err;
2973
Josef Bacik48461132016-09-28 10:54:32 -04002974 reset_reg_range_values(regs, insn->dst_reg);
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07002975 if (BPF_SIZE(insn->code) != BPF_W &&
2976 BPF_SIZE(insn->code) != BPF_DW) {
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07002977 insn_idx++;
2978 continue;
2979 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002980
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002981 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
2982
2983 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002984 /* saw a valid insn
2985 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002986 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002987 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002988 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002989
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002990 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002991 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002992 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002993 /* ABuser program is trying to use the same insn
2994 * dst_reg = *(u32*) (src_reg + off)
2995 * with different pointer types:
2996 * src_reg == ctx in one branch and
2997 * src_reg == stack|map in some other branch.
2998 * Reject it.
2999 */
3000 verbose("same insn cannot be used with different pointers\n");
3001 return -EINVAL;
3002 }
3003
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003004 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003005 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003006
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003007 if (BPF_MODE(insn->code) == BPF_XADD) {
Ben Hutchings62e08652018-12-05 22:41:36 +00003008 err = check_xadd(env, insn_idx, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003009 if (err)
3010 return err;
3011 insn_idx++;
3012 continue;
3013 }
3014
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003015 /* check src1 operand */
3016 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
3017 if (err)
3018 return err;
3019 /* check src2 operand */
3020 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
3021 if (err)
3022 return err;
3023
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003024 dst_reg_type = regs[insn->dst_reg].type;
3025
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003026 /* check that memory (dst_reg + off) is writeable */
Ben Hutchings62e08652018-12-05 22:41:36 +00003027 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003028 BPF_SIZE(insn->code), BPF_WRITE,
3029 insn->src_reg);
3030 if (err)
3031 return err;
3032
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003033 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
3034
3035 if (*prev_dst_type == NOT_INIT) {
3036 *prev_dst_type = dst_reg_type;
3037 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003038 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003039 *prev_dst_type == PTR_TO_CTX)) {
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003040 verbose("same insn cannot be used with different pointers\n");
3041 return -EINVAL;
3042 }
3043
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003044 } else if (class == BPF_ST) {
3045 if (BPF_MODE(insn->code) != BPF_MEM ||
3046 insn->src_reg != BPF_REG_0) {
3047 verbose("BPF_ST uses reserved fields\n");
3048 return -EINVAL;
3049 }
3050 /* check src operand */
3051 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
3052 if (err)
3053 return err;
3054
Daniel Borkmannf531fbb2018-01-29 02:49:01 +01003055 if (is_ctx_reg(env, insn->dst_reg)) {
3056 verbose("BPF_ST stores into R%d context is not allowed\n",
3057 insn->dst_reg);
3058 return -EACCES;
3059 }
3060
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003061 /* check that memory (dst_reg + off) is writeable */
Ben Hutchings62e08652018-12-05 22:41:36 +00003062 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003063 BPF_SIZE(insn->code), BPF_WRITE,
3064 -1);
3065 if (err)
3066 return err;
3067
3068 } else if (class == BPF_JMP) {
3069 u8 opcode = BPF_OP(insn->code);
3070
3071 if (opcode == BPF_CALL) {
3072 if (BPF_SRC(insn->code) != BPF_K ||
3073 insn->off != 0 ||
3074 insn->src_reg != BPF_REG_0 ||
3075 insn->dst_reg != BPF_REG_0) {
3076 verbose("BPF_CALL uses reserved fields\n");
3077 return -EINVAL;
3078 }
3079
Alexei Starovoitova9bfac142018-01-07 17:33:02 -08003080 err = check_call(env, insn->imm, insn_idx);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003081 if (err)
3082 return err;
3083
3084 } else if (opcode == BPF_JA) {
3085 if (BPF_SRC(insn->code) != BPF_K ||
3086 insn->imm != 0 ||
3087 insn->src_reg != BPF_REG_0 ||
3088 insn->dst_reg != BPF_REG_0) {
3089 verbose("BPF_JA uses reserved fields\n");
3090 return -EINVAL;
3091 }
3092
3093 insn_idx += insn->off + 1;
3094 continue;
3095
3096 } else if (opcode == BPF_EXIT) {
3097 if (BPF_SRC(insn->code) != BPF_K ||
3098 insn->imm != 0 ||
3099 insn->src_reg != BPF_REG_0 ||
3100 insn->dst_reg != BPF_REG_0) {
3101 verbose("BPF_EXIT uses reserved fields\n");
3102 return -EINVAL;
3103 }
3104
3105 /* eBPF calling convetion is such that R0 is used
3106 * to return the value from eBPF program.
3107 * Make sure that it's readable at this time
3108 * of bpf_exit, which means that program wrote
3109 * something into it earlier
3110 */
3111 err = check_reg_arg(regs, BPF_REG_0, SRC_OP);
3112 if (err)
3113 return err;
3114
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003115 if (is_pointer_value(env, BPF_REG_0)) {
3116 verbose("R0 leaks addr as return value\n");
3117 return -EACCES;
3118 }
3119
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003120process_bpf_exit:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003121 insn_idx = pop_stack(env, &prev_insn_idx);
3122 if (insn_idx < 0) {
3123 break;
3124 } else {
3125 do_print_state = true;
3126 continue;
3127 }
3128 } else {
3129 err = check_cond_jmp_op(env, insn, &insn_idx);
3130 if (err)
3131 return err;
3132 }
3133 } else if (class == BPF_LD) {
3134 u8 mode = BPF_MODE(insn->code);
3135
3136 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003137 err = check_ld_abs(env, insn);
3138 if (err)
3139 return err;
3140
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003141 } else if (mode == BPF_IMM) {
3142 err = check_ld_imm(env, insn);
3143 if (err)
3144 return err;
3145
3146 insn_idx++;
Daniel Borkmann7b5b73e2017-12-22 16:29:03 +01003147 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003148 } else {
3149 verbose("invalid BPF_LD mode\n");
3150 return -EINVAL;
3151 }
Josef Bacik48461132016-09-28 10:54:32 -04003152 reset_reg_range_values(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003153 } else {
3154 verbose("unknown insn class %d\n", class);
3155 return -EINVAL;
3156 }
3157
3158 insn_idx++;
3159 }
3160
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003161 verbose("processed %d insns\n", insn_processed);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003162 return 0;
3163}
3164
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07003165static int check_map_prog_compatibility(struct bpf_map *map,
3166 struct bpf_prog *prog)
3167
3168{
3169 if (prog->type == BPF_PROG_TYPE_PERF_EVENT &&
3170 (map->map_type == BPF_MAP_TYPE_HASH ||
3171 map->map_type == BPF_MAP_TYPE_PERCPU_HASH) &&
3172 (map->map_flags & BPF_F_NO_PREALLOC)) {
3173 verbose("perf_event programs can only use preallocated hash map\n");
3174 return -EINVAL;
3175 }
3176 return 0;
3177}
3178
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003179/* look for pseudo eBPF instructions that access map FDs and
3180 * replace them with actual map pointers
3181 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003182static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003183{
3184 struct bpf_insn *insn = env->prog->insnsi;
3185 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07003186 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003187
3188 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003189 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003190 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003191 verbose("BPF_LDX uses reserved fields\n");
3192 return -EINVAL;
3193 }
3194
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003195 if (BPF_CLASS(insn->code) == BPF_STX &&
3196 ((BPF_MODE(insn->code) != BPF_MEM &&
3197 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
3198 verbose("BPF_STX uses reserved fields\n");
3199 return -EINVAL;
3200 }
3201
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003202 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
3203 struct bpf_map *map;
3204 struct fd f;
3205
3206 if (i == insn_cnt - 1 || insn[1].code != 0 ||
3207 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
3208 insn[1].off != 0) {
3209 verbose("invalid bpf_ld_imm64 insn\n");
3210 return -EINVAL;
3211 }
3212
3213 if (insn->src_reg == 0)
3214 /* valid generic load 64-bit imm */
3215 goto next_insn;
3216
3217 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
3218 verbose("unrecognized bpf_ld_imm64 insn\n");
3219 return -EINVAL;
3220 }
3221
3222 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01003223 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003224 if (IS_ERR(map)) {
3225 verbose("fd %d is not pointing to valid bpf_map\n",
3226 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003227 return PTR_ERR(map);
3228 }
3229
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07003230 err = check_map_prog_compatibility(map, env->prog);
3231 if (err) {
3232 fdput(f);
3233 return err;
3234 }
3235
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003236 /* store map pointer inside BPF_LD_IMM64 instruction */
3237 insn[0].imm = (u32) (unsigned long) map;
3238 insn[1].imm = ((u64) (unsigned long) map) >> 32;
3239
3240 /* check whether we recorded this map already */
3241 for (j = 0; j < env->used_map_cnt; j++)
3242 if (env->used_maps[j] == map) {
3243 fdput(f);
3244 goto next_insn;
3245 }
3246
3247 if (env->used_map_cnt >= MAX_USED_MAPS) {
3248 fdput(f);
3249 return -E2BIG;
3250 }
3251
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003252 /* hold the map. If the program is rejected by verifier,
3253 * the map will be released by release_maps() or it
3254 * will be used by the valid program until it's unloaded
Jakub Kicinskie31a06e2018-05-03 18:37:17 -07003255 * and all maps are released in free_used_maps()
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003256 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07003257 map = bpf_map_inc(map, false);
3258 if (IS_ERR(map)) {
3259 fdput(f);
3260 return PTR_ERR(map);
3261 }
3262 env->used_maps[env->used_map_cnt++] = map;
3263
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003264 fdput(f);
3265next_insn:
3266 insn++;
3267 i++;
3268 }
3269 }
3270
3271 /* now all pseudo BPF_LD_IMM64 instructions load valid
3272 * 'struct bpf_map *' into a register instead of user map_fd.
3273 * These pointers will be used later by verifier to validate map access.
3274 */
3275 return 0;
3276}
3277
3278/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003279static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003280{
3281 int i;
3282
3283 for (i = 0; i < env->used_map_cnt; i++)
3284 bpf_map_put(env->used_maps[i]);
3285}
3286
3287/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003288static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003289{
3290 struct bpf_insn *insn = env->prog->insnsi;
3291 int insn_cnt = env->prog->len;
3292 int i;
3293
3294 for (i = 0; i < insn_cnt; i++, insn++)
3295 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
3296 insn->src_reg = 0;
3297}
3298
Daniel Borkmann565f0122017-12-22 16:29:02 +01003299/* single env->prog->insni[off] instruction was replaced with the range
3300 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
3301 * [0, off) and [off, end) to new locations, so the patched range stays zero
3302 */
3303static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
3304 u32 off, u32 cnt)
3305{
3306 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
Daniel Borkmann7b5b73e2017-12-22 16:29:03 +01003307 int i;
Daniel Borkmann565f0122017-12-22 16:29:02 +01003308
3309 if (cnt == 1)
3310 return 0;
3311 new_data = vzalloc(sizeof(struct bpf_insn_aux_data) * prog_len);
3312 if (!new_data)
3313 return -ENOMEM;
3314 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
3315 memcpy(new_data + off + cnt - 1, old_data + off,
3316 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
Daniel Borkmann7b5b73e2017-12-22 16:29:03 +01003317 for (i = off; i < off + cnt - 1; i++)
3318 new_data[i].seen = true;
Daniel Borkmann565f0122017-12-22 16:29:02 +01003319 env->insn_aux_data = new_data;
3320 vfree(old_data);
3321 return 0;
3322}
3323
3324static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
3325 const struct bpf_insn *patch, u32 len)
3326{
3327 struct bpf_prog *new_prog;
3328
3329 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
3330 if (!new_prog)
3331 return NULL;
3332 if (adjust_insn_aux_data(env, new_prog->len, off, len))
3333 return NULL;
3334 return new_prog;
3335}
3336
Daniel Borkmann7b5b73e2017-12-22 16:29:03 +01003337/* The verifier does more data flow analysis than llvm and will not explore
3338 * branches that are dead at run time. Malicious programs can have dead code
3339 * too. Therefore replace all dead at-run-time code with nops.
3340 */
3341static void sanitize_dead_code(struct bpf_verifier_env *env)
3342{
3343 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
3344 struct bpf_insn nop = BPF_MOV64_REG(BPF_REG_0, BPF_REG_0);
3345 struct bpf_insn *insn = env->prog->insnsi;
3346 const int insn_cnt = env->prog->len;
3347 int i;
3348
3349 for (i = 0; i < insn_cnt; i++) {
3350 if (aux_data[i].seen)
3351 continue;
3352 memcpy(insn + i, &nop, sizeof(nop));
3353 }
3354}
3355
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003356/* convert load instructions that access fields of 'struct __sk_buff'
3357 * into sequence of instructions that access fields of 'struct sk_buff'
3358 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003359static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003360{
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003361 const struct bpf_verifier_ops *ops = env->prog->aux->ops;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003362 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003363 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003364 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003365 enum bpf_access_type type;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003366 int i, cnt, delta = 0;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003367
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003368 if (ops->gen_prologue) {
3369 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
3370 env->prog);
3371 if (cnt >= ARRAY_SIZE(insn_buf)) {
3372 verbose("bpf verifier is misconfigured\n");
3373 return -EINVAL;
3374 } else if (cnt) {
Daniel Borkmann565f0122017-12-22 16:29:02 +01003375 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003376 if (!new_prog)
3377 return -ENOMEM;
Daniel Borkmann565f0122017-12-22 16:29:02 +01003378
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003379 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003380 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003381 }
3382 }
3383
3384 if (!ops->convert_ctx_access)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003385 return 0;
3386
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003387 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003388
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003389 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07003390 if (insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
3391 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003392 type = BPF_READ;
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07003393 else if (insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
3394 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003395 type = BPF_WRITE;
3396 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003397 continue;
3398
Alexei Starovoitovdef8c1d2018-05-15 09:27:05 -07003399 if (type == BPF_WRITE &&
3400 env->insn_aux_data[i + delta].sanitize_stack_off) {
3401 struct bpf_insn patch[] = {
3402 /* Sanitize suspicious stack slot with zero.
3403 * There are no memory dependencies for this store,
3404 * since it's only using frame pointer and immediate
3405 * constant of zero
3406 */
3407 BPF_ST_MEM(BPF_DW, BPF_REG_FP,
3408 env->insn_aux_data[i + delta].sanitize_stack_off,
3409 0),
3410 /* the original STX instruction will immediately
3411 * overwrite the same stack slot with appropriate value
3412 */
3413 *insn,
3414 };
3415
3416 cnt = ARRAY_SIZE(patch);
3417 new_prog = bpf_patch_insn_data(env, i + delta, patch, cnt);
3418 if (!new_prog)
3419 return -ENOMEM;
3420
3421 delta += cnt - 1;
3422 env->prog = new_prog;
3423 insn = new_prog->insnsi + i + delta;
3424 continue;
3425 }
3426
Daniel Borkmann565f0122017-12-22 16:29:02 +01003427 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003428 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003429
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003430 cnt = ops->convert_ctx_access(type, insn->dst_reg, insn->src_reg,
3431 insn->off, insn_buf, env->prog);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003432 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
3433 verbose("bpf verifier is misconfigured\n");
3434 return -EINVAL;
3435 }
3436
Daniel Borkmann565f0122017-12-22 16:29:02 +01003437 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003438 if (!new_prog)
3439 return -ENOMEM;
3440
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003441 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003442
3443 /* keep walking new program and skip insns we just inserted */
3444 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003445 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003446 }
3447
3448 return 0;
3449}
3450
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003451/* fixup insn->imm field of bpf_call instructions
Alexei Starovoitov28035362017-03-15 18:26:39 -07003452 *
3453 * this function is called after eBPF program passed verification
3454 */
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003455static int fixup_bpf_calls(struct bpf_verifier_env *env)
Alexei Starovoitov28035362017-03-15 18:26:39 -07003456{
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003457 struct bpf_prog *prog = env->prog;
3458 struct bpf_insn *insn = prog->insnsi;
Alexei Starovoitov28035362017-03-15 18:26:39 -07003459 const struct bpf_func_proto *fn;
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003460 const int insn_cnt = prog->len;
Alexei Starovoitova9bfac142018-01-07 17:33:02 -08003461 struct bpf_insn insn_buf[16];
3462 struct bpf_prog *new_prog;
3463 struct bpf_map *map_ptr;
3464 int i, cnt, delta = 0;
3465
Alexei Starovoitov28035362017-03-15 18:26:39 -07003466
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003467 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov265d7652018-01-29 02:49:00 +01003468 if (insn->code == (BPF_ALU | BPF_MOD | BPF_X) ||
3469 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
3470 /* due to JIT bugs clear upper 32-bits of src register
3471 * before div/mod operation
3472 */
3473 insn_buf[0] = BPF_MOV32_REG(insn->src_reg, insn->src_reg);
3474 insn_buf[1] = *insn;
3475 cnt = 2;
3476 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
3477 if (!new_prog)
3478 return -ENOMEM;
3479
3480 delta += cnt - 1;
3481 env->prog = prog = new_prog;
3482 insn = new_prog->insnsi + i + delta;
3483 continue;
3484 }
3485
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003486 if (insn->code != (BPF_JMP | BPF_CALL))
3487 continue;
Alexei Starovoitov28035362017-03-15 18:26:39 -07003488
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003489 if (insn->imm == BPF_FUNC_get_route_realm)
3490 prog->dst_needed = 1;
3491 if (insn->imm == BPF_FUNC_get_prandom_u32)
3492 bpf_user_rnd_init_once();
3493 if (insn->imm == BPF_FUNC_tail_call) {
3494 /* mark bpf_tail_call as different opcode to avoid
3495 * conditional branch in the interpeter for every normal
3496 * call and to prevent accidental JITing by JIT compiler
3497 * that doesn't support bpf_tail_call yet
3498 */
3499 insn->imm = 0;
3500 insn->code |= BPF_X;
Alexei Starovoitova9bfac142018-01-07 17:33:02 -08003501
3502 /* instead of changing every JIT dealing with tail_call
3503 * emit two extra insns:
3504 * if (index >= max_entries) goto out;
3505 * index &= array->index_mask;
3506 * to avoid out-of-bounds cpu speculation
3507 */
3508 map_ptr = env->insn_aux_data[i + delta].map_ptr;
3509 if (!map_ptr->unpriv_array)
3510 continue;
3511 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
3512 map_ptr->max_entries, 2);
3513 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
3514 container_of(map_ptr,
3515 struct bpf_array,
3516 map)->index_mask);
3517 insn_buf[2] = *insn;
3518 cnt = 3;
3519 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
3520 if (!new_prog)
3521 return -ENOMEM;
3522
3523 delta += cnt - 1;
3524 env->prog = prog = new_prog;
3525 insn = new_prog->insnsi + i + delta;
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003526 continue;
Alexei Starovoitov28035362017-03-15 18:26:39 -07003527 }
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003528
3529 fn = prog->aux->ops->get_func_proto(insn->imm);
3530 /* all functions that have prototype and verifier allowed
3531 * programs to call them, must be real in-kernel functions
3532 */
3533 if (!fn->func) {
3534 verbose("kernel subsystem misconfigured func %d\n",
3535 insn->imm);
3536 return -EFAULT;
3537 }
3538 insn->imm = fn->func - __bpf_call_base;
Alexei Starovoitov28035362017-03-15 18:26:39 -07003539 }
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003540
3541 return 0;
Alexei Starovoitov28035362017-03-15 18:26:39 -07003542}
3543
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003544static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003545{
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003546 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003547 int i;
3548
3549 if (!env->explored_states)
3550 return;
3551
3552 for (i = 0; i < env->prog->len; i++) {
3553 sl = env->explored_states[i];
3554
3555 if (sl)
3556 while (sl != STATE_LIST_MARK) {
3557 sln = sl->next;
3558 kfree(sl);
3559 sl = sln;
3560 }
3561 }
3562
3563 kfree(env->explored_states);
3564}
3565
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003566int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003567{
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003568 char __user *log_ubuf = NULL;
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003569 struct bpf_verifier_env *env;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003570 int ret = -EINVAL;
3571
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003572 if ((*prog)->len <= 0 || (*prog)->len > BPF_MAXINSNS)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003573 return -E2BIG;
3574
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003575 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003576 * allocate/free it every time bpf_check() is called
3577 */
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003578 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003579 if (!env)
3580 return -ENOMEM;
3581
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003582 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
3583 (*prog)->len);
3584 ret = -ENOMEM;
3585 if (!env->insn_aux_data)
3586 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003587 env->prog = *prog;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003588
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003589 /* grab the mutex to protect few globals used by verifier */
3590 mutex_lock(&bpf_verifier_lock);
3591
3592 if (attr->log_level || attr->log_buf || attr->log_size) {
3593 /* user requested verbose verifier output
3594 * and supplied buffer to store the verification trace
3595 */
3596 log_level = attr->log_level;
3597 log_ubuf = (char __user *) (unsigned long) attr->log_buf;
3598 log_size = attr->log_size;
3599 log_len = 0;
3600
3601 ret = -EINVAL;
3602 /* log_* values have to be sane */
3603 if (log_size < 128 || log_size > UINT_MAX >> 8 ||
3604 log_level == 0 || log_ubuf == NULL)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003605 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003606
3607 ret = -ENOMEM;
3608 log_buf = vmalloc(log_size);
3609 if (!log_buf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003610 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003611 } else {
3612 log_level = 0;
3613 }
3614
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003615 ret = replace_map_fd_with_map_ptr(env);
3616 if (ret < 0)
3617 goto skip_full_check;
3618
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003619 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af82016-09-21 11:43:57 +01003620 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003621 GFP_USER);
3622 ret = -ENOMEM;
3623 if (!env->explored_states)
3624 goto skip_full_check;
3625
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003626 ret = check_cfg(env);
3627 if (ret < 0)
3628 goto skip_full_check;
3629
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003630 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
3631
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003632 ret = do_check(env);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003633
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003634skip_full_check:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003635 while (pop_stack(env, NULL) >= 0);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003636 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003637
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003638 if (ret == 0)
Daniel Borkmann7b5b73e2017-12-22 16:29:03 +01003639 sanitize_dead_code(env);
3640
3641 if (ret == 0)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003642 /* program is valid, convert *(u32*)(ctx + off) accesses */
3643 ret = convert_ctx_accesses(env);
3644
Alexei Starovoitov28035362017-03-15 18:26:39 -07003645 if (ret == 0)
Alexei Starovoitovf55093d2017-03-15 18:26:40 -07003646 ret = fixup_bpf_calls(env);
Alexei Starovoitov28035362017-03-15 18:26:39 -07003647
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003648 if (log_level && log_len >= log_size - 1) {
3649 BUG_ON(log_len >= log_size);
3650 /* verifier log exceeded user supplied buffer */
3651 ret = -ENOSPC;
3652 /* fall through to return what was recorded */
3653 }
3654
3655 /* copy verifier log back to user space including trailing zero */
3656 if (log_level && copy_to_user(log_ubuf, log_buf, log_len + 1) != 0) {
3657 ret = -EFAULT;
3658 goto free_log_buf;
3659 }
3660
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003661 if (ret == 0 && env->used_map_cnt) {
3662 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003663 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
3664 sizeof(env->used_maps[0]),
3665 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003666
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003667 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003668 ret = -ENOMEM;
3669 goto free_log_buf;
3670 }
3671
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003672 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003673 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003674 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003675
3676 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
3677 * bpf_ld_imm64 instructions
3678 */
3679 convert_pseudo_ld_imm64(env);
3680 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003681
3682free_log_buf:
3683 if (log_level)
3684 vfree(log_buf);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003685 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003686 /* if we didn't copy map pointers into bpf_prog_info, release
Jakub Kicinskie31a06e2018-05-03 18:37:17 -07003687 * them now. Otherwise free_used_maps() will release them.
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003688 */
3689 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003690 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003691err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003692 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003693 vfree(env->insn_aux_data);
3694err_free_env:
3695 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003696 return ret;
3697}
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003698
3699int bpf_analyzer(struct bpf_prog *prog, const struct bpf_ext_analyzer_ops *ops,
3700 void *priv)
3701{
3702 struct bpf_verifier_env *env;
3703 int ret;
3704
3705 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
3706 if (!env)
3707 return -ENOMEM;
3708
3709 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
3710 prog->len);
3711 ret = -ENOMEM;
3712 if (!env->insn_aux_data)
3713 goto err_free_env;
3714 env->prog = prog;
3715 env->analyzer_ops = ops;
3716 env->analyzer_priv = priv;
3717
3718 /* grab the mutex to protect few globals used by verifier */
3719 mutex_lock(&bpf_verifier_lock);
3720
3721 log_level = 0;
3722
3723 env->explored_states = kcalloc(env->prog->len,
3724 sizeof(struct bpf_verifier_state_list *),
3725 GFP_KERNEL);
3726 ret = -ENOMEM;
3727 if (!env->explored_states)
3728 goto skip_full_check;
3729
3730 ret = check_cfg(env);
3731 if (ret < 0)
3732 goto skip_full_check;
3733
3734 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
3735
3736 ret = do_check(env);
3737
3738skip_full_check:
3739 while (pop_stack(env, NULL) >= 0);
3740 free_states(env);
3741
3742 mutex_unlock(&bpf_verifier_lock);
3743 vfree(env->insn_aux_data);
3744err_free_env:
3745 kfree(env);
3746 return ret;
3747}
3748EXPORT_SYMBOL_GPL(bpf_analyzer);