Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright © 2015 Intel Corporation |
| 3 | * |
| 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 5 | * copy of this software and associated documentation files (the "Software"), |
| 6 | * to deal in the Software without restriction, including without limitation |
| 7 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 8 | * and/or sell copies of the Software, and to permit persons to whom the |
| 9 | * Software is furnished to do so, subject to the following conditions: |
| 10 | * |
| 11 | * The above copyright notice and this permission notice (including the next |
| 12 | * paragraph) shall be included in all copies or substantial portions of the |
| 13 | * Software. |
| 14 | * |
| 15 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
| 16 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 17 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 18 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
| 19 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING |
| 20 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS |
| 21 | * IN THE SOFTWARE. |
| 22 | * |
| 23 | */ |
| 24 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 25 | #include <linux/kthread.h> |
Ingo Molnar | ae7e81c | 2017-02-01 18:07:51 +0100 | [diff] [blame] | 26 | #include <uapi/linux/sched/types.h> |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 27 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 28 | #include "i915_drv.h" |
| 29 | |
Chris Wilson | b92326a | 2017-12-09 12:47:10 +0000 | [diff] [blame] | 30 | #ifdef CONFIG_SMP |
| 31 | #define task_asleep(tsk) ((tsk)->state & TASK_NORMAL && !(tsk)->on_cpu) |
| 32 | #else |
| 33 | #define task_asleep(tsk) ((tsk)->state & TASK_NORMAL) |
| 34 | #endif |
| 35 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 36 | static unsigned int __intel_breadcrumbs_wakeup(struct intel_breadcrumbs *b) |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 37 | { |
Chris Wilson | 56299fb | 2017-02-27 20:58:48 +0000 | [diff] [blame] | 38 | struct intel_wait *wait; |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 39 | unsigned int result = 0; |
| 40 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 41 | lockdep_assert_held(&b->irq_lock); |
| 42 | |
| 43 | wait = b->irq_wait; |
Chris Wilson | 56299fb | 2017-02-27 20:58:48 +0000 | [diff] [blame] | 44 | if (wait) { |
Chris Wilson | b92326a | 2017-12-09 12:47:10 +0000 | [diff] [blame] | 45 | /* |
| 46 | * N.B. Since task_asleep() and ttwu are not atomic, the |
| 47 | * waiter may actually go to sleep after the check, causing |
| 48 | * us to suppress a valid wakeup. We prefer to reduce the |
| 49 | * number of false positive missed_breadcrumb() warnings |
| 50 | * at the expense of a few false negatives, as it it easy |
| 51 | * to trigger a false positive under heavy load. Enough |
| 52 | * signal should remain from genuine missed_breadcrumb() |
| 53 | * for us to detect in CI. |
| 54 | */ |
| 55 | bool was_asleep = task_asleep(wait->tsk); |
| 56 | |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 57 | result = ENGINE_WAKEUP_WAITER; |
Chris Wilson | b92326a | 2017-12-09 12:47:10 +0000 | [diff] [blame] | 58 | if (wake_up_process(wait->tsk) && was_asleep) |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 59 | result |= ENGINE_WAKEUP_ASLEEP; |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 60 | } |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 61 | |
| 62 | return result; |
| 63 | } |
| 64 | |
| 65 | unsigned int intel_engine_wakeup(struct intel_engine_cs *engine) |
| 66 | { |
| 67 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 467221b | 2017-03-20 14:31:33 +0000 | [diff] [blame] | 68 | unsigned long flags; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 69 | unsigned int result; |
| 70 | |
Chris Wilson | 467221b | 2017-03-20 14:31:33 +0000 | [diff] [blame] | 71 | spin_lock_irqsave(&b->irq_lock, flags); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 72 | result = __intel_breadcrumbs_wakeup(b); |
Chris Wilson | 467221b | 2017-03-20 14:31:33 +0000 | [diff] [blame] | 73 | spin_unlock_irqrestore(&b->irq_lock, flags); |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 74 | |
| 75 | return result; |
| 76 | } |
| 77 | |
Chris Wilson | 2246bea | 2017-02-17 15:13:00 +0000 | [diff] [blame] | 78 | static unsigned long wait_timeout(void) |
| 79 | { |
| 80 | return round_jiffies_up(jiffies + DRM_I915_HANGCHECK_JIFFIES); |
| 81 | } |
| 82 | |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 83 | static noinline void missed_breadcrumb(struct intel_engine_cs *engine) |
| 84 | { |
Chris Wilson | 832265d | 2017-12-08 01:23:01 +0000 | [diff] [blame] | 85 | if (drm_debug & DRM_UT_DRIVER) { |
| 86 | struct drm_printer p = drm_debug_printer(__func__); |
| 87 | |
| 88 | intel_engine_dump(engine, &p, |
| 89 | "%s missed breadcrumb at %pS\n", |
| 90 | engine->name, __builtin_return_address(0)); |
| 91 | } |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 92 | |
| 93 | set_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings); |
| 94 | } |
| 95 | |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 96 | static void intel_breadcrumbs_hangcheck(struct timer_list *t) |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 97 | { |
Chris Wilson | b92326a | 2017-12-09 12:47:10 +0000 | [diff] [blame] | 98 | struct intel_engine_cs *engine = |
| 99 | from_timer(engine, t, breadcrumbs.hangcheck); |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 100 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 101 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 102 | if (!b->irq_armed) |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 103 | return; |
| 104 | |
Chris Wilson | 2246bea | 2017-02-17 15:13:00 +0000 | [diff] [blame] | 105 | if (b->hangcheck_interrupts != atomic_read(&engine->irq_count)) { |
| 106 | b->hangcheck_interrupts = atomic_read(&engine->irq_count); |
| 107 | mod_timer(&b->hangcheck, wait_timeout()); |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 108 | return; |
| 109 | } |
| 110 | |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 111 | /* We keep the hangcheck timer alive until we disarm the irq, even |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 112 | * if there are no waiters at present. |
| 113 | * |
| 114 | * If the waiter was currently running, assume it hasn't had a chance |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 115 | * to process the pending interrupt (e.g, low priority task on a loaded |
| 116 | * system) and wait until it sleeps before declaring a missed interrupt. |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 117 | * |
| 118 | * If the waiter was asleep (and not even pending a wakeup), then we |
| 119 | * must have missed an interrupt as the GPU has stopped advancing |
| 120 | * but we still have a waiter. Assuming all batches complete within |
| 121 | * DRM_I915_HANGCHECK_JIFFIES [1.5s]! |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 122 | */ |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 123 | if (intel_engine_wakeup(engine) & ENGINE_WAKEUP_ASLEEP) { |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 124 | missed_breadcrumb(engine); |
Chris Wilson | b92326a | 2017-12-09 12:47:10 +0000 | [diff] [blame] | 125 | mod_timer(&b->fake_irq, jiffies + 1); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 126 | } else { |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 127 | mod_timer(&b->hangcheck, wait_timeout()); |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 128 | } |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 129 | } |
| 130 | |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 131 | static void intel_breadcrumbs_fake_irq(struct timer_list *t) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 132 | { |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 133 | struct intel_engine_cs *engine = from_timer(engine, t, |
| 134 | breadcrumbs.fake_irq); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 135 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 136 | |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 137 | /* The timer persists in case we cannot enable interrupts, |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 138 | * or if we have previously seen seqno/interrupt incoherency |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 139 | * ("missed interrupt" syndrome, better known as a "missed breadcrumb"). |
| 140 | * Here the worker will wake up every jiffie in order to kick the |
| 141 | * oldest waiter to do the coherent seqno check. |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 142 | */ |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 143 | |
Tvrtko Ursulin | a9e6493 | 2017-03-06 15:03:20 +0000 | [diff] [blame] | 144 | spin_lock_irq(&b->irq_lock); |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 145 | if (b->irq_armed && !__intel_breadcrumbs_wakeup(b)) |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 146 | __intel_engine_disarm_breadcrumbs(engine); |
Tvrtko Ursulin | a9e6493 | 2017-03-06 15:03:20 +0000 | [diff] [blame] | 147 | spin_unlock_irq(&b->irq_lock); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 148 | if (!b->irq_armed) |
Chris Wilson | 19d0a57 | 2017-02-27 20:58:49 +0000 | [diff] [blame] | 149 | return; |
| 150 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 151 | mod_timer(&b->fake_irq, jiffies + 1); |
Chris Wilson | 19d0a57 | 2017-02-27 20:58:49 +0000 | [diff] [blame] | 152 | |
| 153 | /* Ensure that even if the GPU hangs, we get woken up. |
| 154 | * |
| 155 | * However, note that if no one is waiting, we never notice |
| 156 | * a gpu hang. Eventually, we will have to wait for a resource |
| 157 | * held by the GPU and so trigger a hangcheck. In the most |
| 158 | * pathological case, this will be upon memory starvation! To |
| 159 | * prevent this, we also queue the hangcheck from the retire |
| 160 | * worker. |
| 161 | */ |
| 162 | i915_queue_hangcheck(engine->i915); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 163 | } |
| 164 | |
| 165 | static void irq_enable(struct intel_engine_cs *engine) |
| 166 | { |
Chris Wilson | c16c4ba | 2017-11-07 10:20:03 +0000 | [diff] [blame] | 167 | /* |
| 168 | * FIXME: Ideally we want this on the API boundary, but for the |
| 169 | * sake of testing with mock breadcrumbs (no HW so unable to |
| 170 | * enable irqs) we place it deep within the bowels, at the point |
| 171 | * of no return. |
| 172 | */ |
| 173 | GEM_BUG_ON(!intel_irqs_enabled(engine->i915)); |
| 174 | |
Chris Wilson | 3d5564e | 2016-07-01 17:23:23 +0100 | [diff] [blame] | 175 | /* Enabling the IRQ may miss the generation of the interrupt, but |
| 176 | * we still need to force the barrier before reading the seqno, |
| 177 | * just in case. |
| 178 | */ |
Chris Wilson | 538b257 | 2017-01-24 15:18:05 +0000 | [diff] [blame] | 179 | set_bit(ENGINE_IRQ_BREADCRUMB, &engine->irq_posted); |
Chris Wilson | 31bb59c | 2016-07-01 17:23:27 +0100 | [diff] [blame] | 180 | |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 181 | /* Caller disables interrupts */ |
| 182 | spin_lock(&engine->i915->irq_lock); |
Chris Wilson | 31bb59c | 2016-07-01 17:23:27 +0100 | [diff] [blame] | 183 | engine->irq_enable(engine); |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 184 | spin_unlock(&engine->i915->irq_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 185 | } |
| 186 | |
| 187 | static void irq_disable(struct intel_engine_cs *engine) |
| 188 | { |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 189 | /* Caller disables interrupts */ |
| 190 | spin_lock(&engine->i915->irq_lock); |
Chris Wilson | 31bb59c | 2016-07-01 17:23:27 +0100 | [diff] [blame] | 191 | engine->irq_disable(engine); |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 192 | spin_unlock(&engine->i915->irq_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 193 | } |
| 194 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 195 | void __intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine) |
| 196 | { |
| 197 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 198 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 199 | lockdep_assert_held(&b->irq_lock); |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 200 | GEM_BUG_ON(b->irq_wait); |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 201 | GEM_BUG_ON(!b->irq_armed); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 202 | |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 203 | GEM_BUG_ON(!b->irq_enabled); |
| 204 | if (!--b->irq_enabled) |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 205 | irq_disable(engine); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 206 | |
| 207 | b->irq_armed = false; |
| 208 | } |
| 209 | |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 210 | void intel_engine_pin_breadcrumbs_irq(struct intel_engine_cs *engine) |
| 211 | { |
| 212 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 213 | |
| 214 | spin_lock_irq(&b->irq_lock); |
| 215 | if (!b->irq_enabled++) |
| 216 | irq_enable(engine); |
| 217 | GEM_BUG_ON(!b->irq_enabled); /* no overflow! */ |
| 218 | spin_unlock_irq(&b->irq_lock); |
| 219 | } |
| 220 | |
| 221 | void intel_engine_unpin_breadcrumbs_irq(struct intel_engine_cs *engine) |
| 222 | { |
| 223 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 224 | |
| 225 | spin_lock_irq(&b->irq_lock); |
| 226 | GEM_BUG_ON(!b->irq_enabled); /* no underflow! */ |
| 227 | if (!--b->irq_enabled) |
| 228 | irq_disable(engine); |
| 229 | spin_unlock_irq(&b->irq_lock); |
| 230 | } |
| 231 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 232 | void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine) |
| 233 | { |
| 234 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 832265d | 2017-12-08 01:23:01 +0000 | [diff] [blame] | 235 | struct intel_wait *wait, *n; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 236 | |
| 237 | if (!b->irq_armed) |
Chris Wilson | 776bc27 | 2017-12-08 12:10:33 +0000 | [diff] [blame] | 238 | goto wakeup_signaler; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 239 | |
Chris Wilson | 832265d | 2017-12-08 01:23:01 +0000 | [diff] [blame] | 240 | /* |
| 241 | * We only disarm the irq when we are idle (all requests completed), |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 242 | * so if the bottom-half remains asleep, it missed the request |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 243 | * completion. |
| 244 | */ |
Chris Wilson | 832265d | 2017-12-08 01:23:01 +0000 | [diff] [blame] | 245 | if (intel_engine_wakeup(engine) & ENGINE_WAKEUP_ASLEEP) |
| 246 | missed_breadcrumb(engine); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 247 | |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 248 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | a5cae7b | 2017-03-15 21:07:24 +0000 | [diff] [blame] | 249 | |
| 250 | spin_lock(&b->irq_lock); |
Chris Wilson | 832265d | 2017-12-08 01:23:01 +0000 | [diff] [blame] | 251 | b->irq_wait = NULL; |
Chris Wilson | e5330ac | 2017-10-31 12:22:35 +0000 | [diff] [blame] | 252 | if (b->irq_armed) |
| 253 | __intel_engine_disarm_breadcrumbs(engine); |
Chris Wilson | a5cae7b | 2017-03-15 21:07:24 +0000 | [diff] [blame] | 254 | spin_unlock(&b->irq_lock); |
| 255 | |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 256 | rbtree_postorder_for_each_entry_safe(wait, n, &b->waiters, node) { |
| 257 | RB_CLEAR_NODE(&wait->node); |
Chris Wilson | 832265d | 2017-12-08 01:23:01 +0000 | [diff] [blame] | 258 | wake_up_process(wait->tsk); |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 259 | } |
| 260 | b->waiters = RB_ROOT; |
| 261 | |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 262 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | 776bc27 | 2017-12-08 12:10:33 +0000 | [diff] [blame] | 263 | |
| 264 | /* |
| 265 | * The signaling thread may be asleep holding a reference to a request, |
| 266 | * that had its signaling cancelled prior to being preempted. We need |
| 267 | * to kick the signaler, just in case, to release any such reference. |
| 268 | */ |
| 269 | wakeup_signaler: |
| 270 | wake_up_process(b->signaler); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 271 | } |
| 272 | |
Chris Wilson | 6ef98ea | 2017-02-17 15:13:03 +0000 | [diff] [blame] | 273 | static bool use_fake_irq(const struct intel_breadcrumbs *b) |
| 274 | { |
| 275 | const struct intel_engine_cs *engine = |
| 276 | container_of(b, struct intel_engine_cs, breadcrumbs); |
| 277 | |
| 278 | if (!test_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings)) |
| 279 | return false; |
| 280 | |
| 281 | /* Only start with the heavy weight fake irq timer if we have not |
| 282 | * seen any interrupts since enabling it the first time. If the |
| 283 | * interrupts are still arriving, it means we made a mistake in our |
| 284 | * engine->seqno_barrier(), a timing error that should be transient |
| 285 | * and unlikely to reoccur. |
| 286 | */ |
| 287 | return atomic_read(&engine->irq_count) == b->hangcheck_interrupts; |
| 288 | } |
| 289 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 290 | static void enable_fake_irq(struct intel_breadcrumbs *b) |
| 291 | { |
| 292 | /* Ensure we never sleep indefinitely */ |
| 293 | if (!b->irq_enabled || use_fake_irq(b)) |
| 294 | mod_timer(&b->fake_irq, jiffies + 1); |
| 295 | else |
| 296 | mod_timer(&b->hangcheck, wait_timeout()); |
| 297 | } |
| 298 | |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 299 | static bool __intel_breadcrumbs_enable_irq(struct intel_breadcrumbs *b) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 300 | { |
| 301 | struct intel_engine_cs *engine = |
| 302 | container_of(b, struct intel_engine_cs, breadcrumbs); |
| 303 | struct drm_i915_private *i915 = engine->i915; |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 304 | bool enabled; |
| 305 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 306 | lockdep_assert_held(&b->irq_lock); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 307 | if (b->irq_armed) |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 308 | return false; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 309 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 310 | /* The breadcrumb irq will be disarmed on the interrupt after the |
| 311 | * waiters are signaled. This gives us a single interrupt window in |
| 312 | * which we can add a new waiter and avoid the cost of re-enabling |
| 313 | * the irq. |
| 314 | */ |
| 315 | b->irq_armed = true; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 316 | |
Chris Wilson | f97fbf9 | 2017-02-13 17:15:14 +0000 | [diff] [blame] | 317 | if (I915_SELFTEST_ONLY(b->mock)) { |
| 318 | /* For our mock objects we want to avoid interaction |
| 319 | * with the real hardware (which is not set up). So |
| 320 | * we simply pretend we have enabled the powerwell |
| 321 | * and the irq, and leave it up to the mock |
| 322 | * implementation to call intel_engine_wakeup() |
| 323 | * itself when it wants to simulate a user interrupt, |
| 324 | */ |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 325 | return true; |
Chris Wilson | f97fbf9 | 2017-02-13 17:15:14 +0000 | [diff] [blame] | 326 | } |
| 327 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 328 | /* Since we are waiting on a request, the GPU should be busy |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 329 | * and should have its own rpm reference. This is tracked |
| 330 | * by i915->gt.awake, we can forgo holding our own wakref |
| 331 | * for the interrupt as before i915->gt.awake is released (when |
| 332 | * the driver is idle) we disarm the breadcrumbs. |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 333 | */ |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 334 | |
| 335 | /* No interrupts? Kick the waiter every jiffie! */ |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 336 | enabled = false; |
| 337 | if (!b->irq_enabled++ && |
| 338 | !test_bit(engine->id, &i915->gpu_error.test_irq_rings)) { |
| 339 | irq_enable(engine); |
| 340 | enabled = true; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 341 | } |
| 342 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 343 | enable_fake_irq(b); |
Chris Wilson | bcbd5c3 | 2017-10-25 15:39:42 +0100 | [diff] [blame] | 344 | return enabled; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 345 | } |
| 346 | |
| 347 | static inline struct intel_wait *to_wait(struct rb_node *node) |
| 348 | { |
Chris Wilson | d856786 | 2016-12-20 10:40:03 +0000 | [diff] [blame] | 349 | return rb_entry(node, struct intel_wait, node); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 350 | } |
| 351 | |
| 352 | static inline void __intel_breadcrumbs_finish(struct intel_breadcrumbs *b, |
| 353 | struct intel_wait *wait) |
| 354 | { |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 355 | lockdep_assert_held(&b->rb_lock); |
Chris Wilson | 908a6cb | 2017-03-15 21:07:25 +0000 | [diff] [blame] | 356 | GEM_BUG_ON(b->irq_wait == wait); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 357 | |
| 358 | /* This request is completed, so remove it from the tree, mark it as |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 359 | * complete, and *then* wake up the associated task. N.B. when the |
| 360 | * task wakes up, it will find the empty rb_node, discern that it |
| 361 | * has already been removed from the tree and skip the serialisation |
| 362 | * of the b->rb_lock and b->irq_lock. This means that the destruction |
| 363 | * of the intel_wait is not serialised with the interrupt handler |
| 364 | * by the waiter - it must instead be serialised by the caller. |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 365 | */ |
| 366 | rb_erase(&wait->node, &b->waiters); |
| 367 | RB_CLEAR_NODE(&wait->node); |
| 368 | |
| 369 | wake_up_process(wait->tsk); /* implicit smp_wmb() */ |
| 370 | } |
| 371 | |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 372 | static inline void __intel_breadcrumbs_next(struct intel_engine_cs *engine, |
| 373 | struct rb_node *next) |
| 374 | { |
| 375 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 376 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 377 | spin_lock(&b->irq_lock); |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 378 | GEM_BUG_ON(!b->irq_armed); |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 379 | GEM_BUG_ON(!b->irq_wait); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 380 | b->irq_wait = to_wait(next); |
| 381 | spin_unlock(&b->irq_lock); |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 382 | |
| 383 | /* We always wake up the next waiter that takes over as the bottom-half |
| 384 | * as we may delegate not only the irq-seqno barrier to the next waiter |
| 385 | * but also the task of waking up concurrent waiters. |
| 386 | */ |
| 387 | if (next) |
| 388 | wake_up_process(to_wait(next)->tsk); |
| 389 | } |
| 390 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 391 | static bool __intel_engine_add_wait(struct intel_engine_cs *engine, |
| 392 | struct intel_wait *wait) |
| 393 | { |
| 394 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 395 | struct rb_node **p, *parent, *completed; |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 396 | bool first, armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 397 | u32 seqno; |
| 398 | |
Chris Wilson | c68ce69 | 2018-01-02 19:25:00 +0000 | [diff] [blame^] | 399 | GEM_BUG_ON(!wait->seqno); |
| 400 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 401 | /* Insert the request into the retirement ordered list |
| 402 | * of waiters by walking the rbtree. If we are the oldest |
| 403 | * seqno in the tree (the first to be retired), then |
| 404 | * set ourselves as the bottom-half. |
| 405 | * |
| 406 | * As we descend the tree, prune completed branches since we hold the |
| 407 | * spinlock we know that the first_waiter must be delayed and can |
| 408 | * reduce some of the sequential wake up latency if we take action |
| 409 | * ourselves and wake up the completed tasks in parallel. Also, by |
| 410 | * removing stale elements in the tree, we may be able to reduce the |
| 411 | * ping-pong between the old bottom-half and ourselves as first-waiter. |
| 412 | */ |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 413 | armed = false; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 414 | first = true; |
| 415 | parent = NULL; |
| 416 | completed = NULL; |
Chris Wilson | 1b7744e | 2016-07-01 17:23:17 +0100 | [diff] [blame] | 417 | seqno = intel_engine_get_seqno(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 418 | |
| 419 | /* If the request completed before we managed to grab the spinlock, |
| 420 | * return now before adding ourselves to the rbtree. We let the |
| 421 | * current bottom-half handle any pending wakeups and instead |
| 422 | * try and get out of the way quickly. |
| 423 | */ |
| 424 | if (i915_seqno_passed(seqno, wait->seqno)) { |
| 425 | RB_CLEAR_NODE(&wait->node); |
| 426 | return first; |
| 427 | } |
| 428 | |
| 429 | p = &b->waiters.rb_node; |
| 430 | while (*p) { |
| 431 | parent = *p; |
| 432 | if (wait->seqno == to_wait(parent)->seqno) { |
| 433 | /* We have multiple waiters on the same seqno, select |
| 434 | * the highest priority task (that with the smallest |
| 435 | * task->prio) to serve as the bottom-half for this |
| 436 | * group. |
| 437 | */ |
| 438 | if (wait->tsk->prio > to_wait(parent)->tsk->prio) { |
| 439 | p = &parent->rb_right; |
| 440 | first = false; |
| 441 | } else { |
| 442 | p = &parent->rb_left; |
| 443 | } |
| 444 | } else if (i915_seqno_passed(wait->seqno, |
| 445 | to_wait(parent)->seqno)) { |
| 446 | p = &parent->rb_right; |
| 447 | if (i915_seqno_passed(seqno, to_wait(parent)->seqno)) |
| 448 | completed = parent; |
| 449 | else |
| 450 | first = false; |
| 451 | } else { |
| 452 | p = &parent->rb_left; |
| 453 | } |
| 454 | } |
| 455 | rb_link_node(&wait->node, parent, p); |
| 456 | rb_insert_color(&wait->node, &b->waiters); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 457 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 458 | if (first) { |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 459 | spin_lock(&b->irq_lock); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 460 | b->irq_wait = wait; |
Chris Wilson | 0417131 | 2016-07-06 12:39:00 +0100 | [diff] [blame] | 461 | /* After assigning ourselves as the new bottom-half, we must |
| 462 | * perform a cursory check to prevent a missed interrupt. |
| 463 | * Either we miss the interrupt whilst programming the hardware, |
| 464 | * or if there was a previous waiter (for a later seqno) they |
| 465 | * may be woken instead of us (due to the inherent race |
Chris Wilson | aca34b6 | 2016-07-06 12:39:02 +0100 | [diff] [blame] | 466 | * in the unlocked read of b->irq_seqno_bh in the irq handler) |
| 467 | * and so we miss the wake up. |
Chris Wilson | 0417131 | 2016-07-06 12:39:00 +0100 | [diff] [blame] | 468 | */ |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 469 | armed = __intel_breadcrumbs_enable_irq(b); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 470 | spin_unlock(&b->irq_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 471 | } |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 472 | |
| 473 | if (completed) { |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 474 | /* Advance the bottom-half (b->irq_wait) before we wake up |
| 475 | * the waiters who may scribble over their intel_wait |
| 476 | * just as the interrupt handler is dereferencing it via |
| 477 | * b->irq_wait. |
| 478 | */ |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 479 | if (!first) { |
| 480 | struct rb_node *next = rb_next(completed); |
| 481 | GEM_BUG_ON(next == &wait->node); |
| 482 | __intel_breadcrumbs_next(engine, next); |
| 483 | } |
| 484 | |
| 485 | do { |
| 486 | struct intel_wait *crumb = to_wait(completed); |
| 487 | completed = rb_prev(completed); |
| 488 | __intel_breadcrumbs_finish(b, crumb); |
| 489 | } while (completed); |
| 490 | } |
| 491 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 492 | GEM_BUG_ON(!b->irq_wait); |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 493 | GEM_BUG_ON(!b->irq_armed); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 494 | GEM_BUG_ON(rb_first(&b->waiters) != &b->irq_wait->node); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 495 | |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 496 | return armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 497 | } |
| 498 | |
| 499 | bool intel_engine_add_wait(struct intel_engine_cs *engine, |
| 500 | struct intel_wait *wait) |
| 501 | { |
| 502 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 503 | bool armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 504 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 505 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 506 | armed = __intel_engine_add_wait(engine, wait); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 507 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 508 | if (armed) |
| 509 | return armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 510 | |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 511 | /* Make the caller recheck if its request has already started. */ |
| 512 | return i915_seqno_passed(intel_engine_get_seqno(engine), |
| 513 | wait->seqno - 1); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 514 | } |
| 515 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 516 | static inline bool chain_wakeup(struct rb_node *rb, int priority) |
| 517 | { |
| 518 | return rb && to_wait(rb)->tsk->prio <= priority; |
| 519 | } |
| 520 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 521 | static inline int wakeup_priority(struct intel_breadcrumbs *b, |
| 522 | struct task_struct *tsk) |
| 523 | { |
| 524 | if (tsk == b->signaler) |
| 525 | return INT_MIN; |
| 526 | else |
| 527 | return tsk->prio; |
| 528 | } |
| 529 | |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 530 | static void __intel_engine_remove_wait(struct intel_engine_cs *engine, |
| 531 | struct intel_wait *wait) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 532 | { |
| 533 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 534 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 535 | lockdep_assert_held(&b->rb_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 536 | |
| 537 | if (RB_EMPTY_NODE(&wait->node)) |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 538 | goto out; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 539 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 540 | if (b->irq_wait == wait) { |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 541 | const int priority = wakeup_priority(b, wait->tsk); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 542 | struct rb_node *next; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 543 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 544 | /* We are the current bottom-half. Find the next candidate, |
| 545 | * the first waiter in the queue on the remaining oldest |
| 546 | * request. As multiple seqnos may complete in the time it |
| 547 | * takes us to wake up and find the next waiter, we have to |
| 548 | * wake up that waiter for it to perform its own coherent |
| 549 | * completion check. |
| 550 | */ |
| 551 | next = rb_next(&wait->node); |
| 552 | if (chain_wakeup(next, priority)) { |
| 553 | /* If the next waiter is already complete, |
| 554 | * wake it up and continue onto the next waiter. So |
| 555 | * if have a small herd, they will wake up in parallel |
| 556 | * rather than sequentially, which should reduce |
| 557 | * the overall latency in waking all the completed |
| 558 | * clients. |
| 559 | * |
| 560 | * However, waking up a chain adds extra latency to |
| 561 | * the first_waiter. This is undesirable if that |
| 562 | * waiter is a high priority task. |
| 563 | */ |
Chris Wilson | 1b7744e | 2016-07-01 17:23:17 +0100 | [diff] [blame] | 564 | u32 seqno = intel_engine_get_seqno(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 565 | |
| 566 | while (i915_seqno_passed(seqno, to_wait(next)->seqno)) { |
| 567 | struct rb_node *n = rb_next(next); |
| 568 | |
| 569 | __intel_breadcrumbs_finish(b, to_wait(next)); |
| 570 | next = n; |
| 571 | if (!chain_wakeup(next, priority)) |
| 572 | break; |
| 573 | } |
| 574 | } |
| 575 | |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 576 | __intel_breadcrumbs_next(engine, next); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 577 | } else { |
| 578 | GEM_BUG_ON(rb_first(&b->waiters) == &wait->node); |
| 579 | } |
| 580 | |
| 581 | GEM_BUG_ON(RB_EMPTY_NODE(&wait->node)); |
| 582 | rb_erase(&wait->node, &b->waiters); |
Chris Wilson | c534612 | 2017-11-15 12:14:58 +0000 | [diff] [blame] | 583 | RB_CLEAR_NODE(&wait->node); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 584 | |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 585 | out: |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 586 | GEM_BUG_ON(b->irq_wait == wait); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 587 | GEM_BUG_ON(rb_first(&b->waiters) != |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 588 | (b->irq_wait ? &b->irq_wait->node : NULL)); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 589 | } |
| 590 | |
| 591 | void intel_engine_remove_wait(struct intel_engine_cs *engine, |
| 592 | struct intel_wait *wait) |
| 593 | { |
| 594 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 595 | |
| 596 | /* Quick check to see if this waiter was already decoupled from |
| 597 | * the tree by the bottom-half to avoid contention on the spinlock |
| 598 | * by the herd. |
| 599 | */ |
Chris Wilson | 908a6cb | 2017-03-15 21:07:25 +0000 | [diff] [blame] | 600 | if (RB_EMPTY_NODE(&wait->node)) { |
| 601 | GEM_BUG_ON(READ_ONCE(b->irq_wait) == wait); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 602 | return; |
Chris Wilson | 908a6cb | 2017-03-15 21:07:25 +0000 | [diff] [blame] | 603 | } |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 604 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 605 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 606 | __intel_engine_remove_wait(engine, wait); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 607 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 608 | } |
| 609 | |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 610 | static bool signal_valid(const struct drm_i915_gem_request *request) |
| 611 | { |
| 612 | return intel_wait_check_request(&request->signaling.wait, request); |
| 613 | } |
| 614 | |
| 615 | static bool signal_complete(const struct drm_i915_gem_request *request) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 616 | { |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 617 | if (!request) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 618 | return false; |
| 619 | |
| 620 | /* If another process served as the bottom-half it may have already |
| 621 | * signalled that this wait is already completed. |
| 622 | */ |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 623 | if (intel_wait_complete(&request->signaling.wait)) |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 624 | return signal_valid(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 625 | |
| 626 | /* Carefully check if the request is complete, giving time for the |
| 627 | * seqno to be visible or if the GPU hung. |
| 628 | */ |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 629 | if (__i915_request_irq_complete(request)) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 630 | return true; |
| 631 | |
| 632 | return false; |
| 633 | } |
| 634 | |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 635 | static struct drm_i915_gem_request *to_signaler(struct rb_node *rb) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 636 | { |
Chris Wilson | d856786 | 2016-12-20 10:40:03 +0000 | [diff] [blame] | 637 | return rb_entry(rb, struct drm_i915_gem_request, signaling.node); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 638 | } |
| 639 | |
| 640 | static void signaler_set_rtpriority(void) |
| 641 | { |
| 642 | struct sched_param param = { .sched_priority = 1 }; |
| 643 | |
| 644 | sched_setscheduler_nocheck(current, SCHED_FIFO, ¶m); |
| 645 | } |
| 646 | |
| 647 | static int intel_breadcrumbs_signaler(void *arg) |
| 648 | { |
| 649 | struct intel_engine_cs *engine = arg; |
| 650 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 651 | struct drm_i915_gem_request *request; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 652 | |
| 653 | /* Install ourselves with high priority to reduce signalling latency */ |
| 654 | signaler_set_rtpriority(); |
| 655 | |
| 656 | do { |
Chris Wilson | a7980a6 | 2017-04-04 13:05:31 +0100 | [diff] [blame] | 657 | bool do_schedule = true; |
| 658 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 659 | set_current_state(TASK_INTERRUPTIBLE); |
| 660 | |
| 661 | /* We are either woken up by the interrupt bottom-half, |
| 662 | * or by a client adding a new signaller. In both cases, |
| 663 | * the GPU seqno may have advanced beyond our oldest signal. |
| 664 | * If it has, propagate the signal, remove the waiter and |
| 665 | * check again with the next oldest signal. Otherwise we |
| 666 | * need to wait for a new interrupt from the GPU or for |
| 667 | * a new client. |
| 668 | */ |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 669 | rcu_read_lock(); |
| 670 | request = rcu_dereference(b->first_signal); |
| 671 | if (request) |
| 672 | request = i915_gem_request_get_rcu(request); |
| 673 | rcu_read_unlock(); |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 674 | if (signal_complete(request)) { |
Chris Wilson | 7c9e934 | 2017-01-24 11:00:09 +0000 | [diff] [blame] | 675 | local_bh_disable(); |
| 676 | dma_fence_signal(&request->fence); |
| 677 | local_bh_enable(); /* kick start the tasklets */ |
| 678 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 679 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 680 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 681 | /* Wake up all other completed waiters and select the |
| 682 | * next bottom-half for the next user interrupt. |
| 683 | */ |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 684 | __intel_engine_remove_wait(engine, |
| 685 | &request->signaling.wait); |
Chris Wilson | 5590af3 | 2016-09-09 14:11:54 +0100 | [diff] [blame] | 686 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 687 | /* Find the next oldest signal. Note that as we have |
| 688 | * not been holding the lock, another client may |
| 689 | * have installed an even older signal than the one |
| 690 | * we just completed - so double check we are still |
| 691 | * the oldest before picking the next one. |
| 692 | */ |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 693 | if (request == rcu_access_pointer(b->first_signal)) { |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 694 | struct rb_node *rb = |
| 695 | rb_next(&request->signaling.node); |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 696 | rcu_assign_pointer(b->first_signal, |
| 697 | rb ? to_signaler(rb) : NULL); |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 698 | } |
| 699 | rb_erase(&request->signaling.node, &b->signals); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 700 | RB_CLEAR_NODE(&request->signaling.node); |
| 701 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 702 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 703 | |
Chris Wilson | e8a261e | 2016-07-20 13:31:49 +0100 | [diff] [blame] | 704 | i915_gem_request_put(request); |
Chris Wilson | a7980a6 | 2017-04-04 13:05:31 +0100 | [diff] [blame] | 705 | |
| 706 | /* If the engine is saturated we may be continually |
| 707 | * processing completed requests. This angers the |
| 708 | * NMI watchdog if we never let anything else |
| 709 | * have access to the CPU. Let's pretend to be nice |
| 710 | * and relinquish the CPU if we burn through the |
| 711 | * entire RT timeslice! |
| 712 | */ |
| 713 | do_schedule = need_resched(); |
| 714 | } |
| 715 | |
| 716 | if (unlikely(do_schedule)) { |
Chris Wilson | b1becb8 | 2017-04-03 11:51:24 +0100 | [diff] [blame] | 717 | if (kthread_should_park()) |
| 718 | kthread_parkme(); |
| 719 | |
Chris Wilson | 776bc27 | 2017-12-08 12:10:33 +0000 | [diff] [blame] | 720 | if (unlikely(kthread_should_stop())) { |
| 721 | i915_gem_request_put(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 722 | break; |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 723 | } |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 724 | |
| 725 | schedule(); |
| 726 | } |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 727 | i915_gem_request_put(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 728 | } while (1); |
| 729 | __set_current_state(TASK_RUNNING); |
| 730 | |
| 731 | return 0; |
| 732 | } |
| 733 | |
Chris Wilson | f7b02a5 | 2017-04-26 09:06:59 +0100 | [diff] [blame] | 734 | void intel_engine_enable_signaling(struct drm_i915_gem_request *request, |
| 735 | bool wakeup) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 736 | { |
| 737 | struct intel_engine_cs *engine = request->engine; |
| 738 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 754c9fd | 2017-02-23 07:44:14 +0000 | [diff] [blame] | 739 | u32 seqno; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 740 | |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 741 | /* Note that we may be called from an interrupt handler on another |
| 742 | * device (e.g. nouveau signaling a fence completion causing us |
| 743 | * to submit a request, and so enable signaling). As such, |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 744 | * we need to make sure that all other users of b->rb_lock protect |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 745 | * against interrupts, i.e. use spin_lock_irqsave. |
| 746 | */ |
| 747 | |
| 748 | /* locked by dma_fence_enable_sw_signaling() (irqsafe fence->lock) */ |
Chris Wilson | e60a870 | 2017-03-02 11:51:30 +0000 | [diff] [blame] | 749 | GEM_BUG_ON(!irqs_disabled()); |
Chris Wilson | 6752041 | 2017-03-02 13:28:01 +0000 | [diff] [blame] | 750 | lockdep_assert_held(&request->lock); |
Chris Wilson | 754c9fd | 2017-02-23 07:44:14 +0000 | [diff] [blame] | 751 | |
| 752 | seqno = i915_gem_request_global_seqno(request); |
| 753 | if (!seqno) |
Chris Wilson | 65e4760 | 2016-10-28 13:58:49 +0100 | [diff] [blame] | 754 | return; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 755 | |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 756 | request->signaling.wait.tsk = b->signaler; |
Chris Wilson | 56299fb | 2017-02-27 20:58:48 +0000 | [diff] [blame] | 757 | request->signaling.wait.request = request; |
Chris Wilson | 754c9fd | 2017-02-23 07:44:14 +0000 | [diff] [blame] | 758 | request->signaling.wait.seqno = seqno; |
Chris Wilson | e8a261e | 2016-07-20 13:31:49 +0100 | [diff] [blame] | 759 | i915_gem_request_get(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 760 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 761 | spin_lock(&b->rb_lock); |
Chris Wilson | 4a50d20 | 2016-07-26 12:01:50 +0100 | [diff] [blame] | 762 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 763 | /* First add ourselves into the list of waiters, but register our |
| 764 | * bottom-half as the signaller thread. As per usual, only the oldest |
| 765 | * waiter (not just signaller) is tasked as the bottom-half waking |
| 766 | * up all completed waiters after the user interrupt. |
| 767 | * |
| 768 | * If we are the oldest waiter, enable the irq (after which we |
| 769 | * must double check that the seqno did not complete). |
| 770 | */ |
Chris Wilson | f7b02a5 | 2017-04-26 09:06:59 +0100 | [diff] [blame] | 771 | wakeup &= __intel_engine_add_wait(engine, &request->signaling.wait); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 772 | |
Chris Wilson | 735e0eb | 2017-06-08 12:14:04 +0100 | [diff] [blame] | 773 | if (!__i915_gem_request_completed(request, seqno)) { |
| 774 | struct rb_node *parent, **p; |
| 775 | bool first; |
| 776 | |
| 777 | /* Now insert ourselves into the retirement ordered list of |
| 778 | * signals on this engine. We track the oldest seqno as that |
| 779 | * will be the first signal to complete. |
| 780 | */ |
| 781 | parent = NULL; |
| 782 | first = true; |
| 783 | p = &b->signals.rb_node; |
| 784 | while (*p) { |
| 785 | parent = *p; |
| 786 | if (i915_seqno_passed(seqno, |
| 787 | to_signaler(parent)->signaling.wait.seqno)) { |
| 788 | p = &parent->rb_right; |
| 789 | first = false; |
| 790 | } else { |
| 791 | p = &parent->rb_left; |
| 792 | } |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 793 | } |
Chris Wilson | 735e0eb | 2017-06-08 12:14:04 +0100 | [diff] [blame] | 794 | rb_link_node(&request->signaling.node, parent, p); |
| 795 | rb_insert_color(&request->signaling.node, &b->signals); |
| 796 | if (first) |
| 797 | rcu_assign_pointer(b->first_signal, request); |
| 798 | } else { |
| 799 | __intel_engine_remove_wait(engine, &request->signaling.wait); |
| 800 | i915_gem_request_put(request); |
| 801 | wakeup = false; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 802 | } |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 803 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 804 | spin_unlock(&b->rb_lock); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 805 | |
| 806 | if (wakeup) |
| 807 | wake_up_process(b->signaler); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 808 | } |
| 809 | |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 810 | void intel_engine_cancel_signaling(struct drm_i915_gem_request *request) |
| 811 | { |
| 812 | struct intel_engine_cs *engine = request->engine; |
| 813 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 814 | |
Chris Wilson | e60a870 | 2017-03-02 11:51:30 +0000 | [diff] [blame] | 815 | GEM_BUG_ON(!irqs_disabled()); |
Chris Wilson | 6752041 | 2017-03-02 13:28:01 +0000 | [diff] [blame] | 816 | lockdep_assert_held(&request->lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 817 | GEM_BUG_ON(!request->signaling.wait.seqno); |
| 818 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 819 | spin_lock(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 820 | |
| 821 | if (!RB_EMPTY_NODE(&request->signaling.node)) { |
| 822 | if (request == rcu_access_pointer(b->first_signal)) { |
| 823 | struct rb_node *rb = |
| 824 | rb_next(&request->signaling.node); |
| 825 | rcu_assign_pointer(b->first_signal, |
| 826 | rb ? to_signaler(rb) : NULL); |
| 827 | } |
| 828 | rb_erase(&request->signaling.node, &b->signals); |
| 829 | RB_CLEAR_NODE(&request->signaling.node); |
| 830 | i915_gem_request_put(request); |
| 831 | } |
| 832 | |
| 833 | __intel_engine_remove_wait(engine, &request->signaling.wait); |
| 834 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 835 | spin_unlock(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 836 | |
| 837 | request->signaling.wait.seqno = 0; |
| 838 | } |
| 839 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 840 | int intel_engine_init_breadcrumbs(struct intel_engine_cs *engine) |
| 841 | { |
| 842 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 843 | struct task_struct *tsk; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 844 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 845 | spin_lock_init(&b->rb_lock); |
| 846 | spin_lock_init(&b->irq_lock); |
| 847 | |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 848 | timer_setup(&b->fake_irq, intel_breadcrumbs_fake_irq, 0); |
| 849 | timer_setup(&b->hangcheck, intel_breadcrumbs_hangcheck, 0); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 850 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 851 | /* Spawn a thread to provide a common bottom-half for all signals. |
| 852 | * As this is an asynchronous interface we cannot steal the current |
| 853 | * task for handling the bottom-half to the user interrupt, therefore |
| 854 | * we create a thread to do the coherent seqno dance after the |
| 855 | * interrupt and then signal the waitqueue (via the dma-buf/fence). |
| 856 | */ |
| 857 | tsk = kthread_run(intel_breadcrumbs_signaler, engine, |
| 858 | "i915/signal:%d", engine->id); |
| 859 | if (IS_ERR(tsk)) |
| 860 | return PTR_ERR(tsk); |
| 861 | |
| 862 | b->signaler = tsk; |
| 863 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 864 | return 0; |
| 865 | } |
| 866 | |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 867 | static void cancel_fake_irq(struct intel_engine_cs *engine) |
| 868 | { |
| 869 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 870 | |
| 871 | del_timer_sync(&b->hangcheck); |
| 872 | del_timer_sync(&b->fake_irq); |
| 873 | clear_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings); |
| 874 | } |
| 875 | |
| 876 | void intel_engine_reset_breadcrumbs(struct intel_engine_cs *engine) |
| 877 | { |
| 878 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 879 | |
| 880 | cancel_fake_irq(engine); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 881 | spin_lock_irq(&b->irq_lock); |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 882 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 883 | if (b->irq_enabled) |
| 884 | irq_enable(engine); |
| 885 | else |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 886 | irq_disable(engine); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 887 | |
| 888 | /* We set the IRQ_BREADCRUMB bit when we enable the irq presuming the |
| 889 | * GPU is active and may have already executed the MI_USER_INTERRUPT |
| 890 | * before the CPU is ready to receive. However, the engine is currently |
| 891 | * idle (we haven't started it yet), there is no possibility for a |
| 892 | * missed interrupt as we enabled the irq and so we can clear the |
| 893 | * immediate wakeup (until a real interrupt arrives for the waiter). |
| 894 | */ |
| 895 | clear_bit(ENGINE_IRQ_BREADCRUMB, &engine->irq_posted); |
| 896 | |
| 897 | if (b->irq_armed) |
| 898 | enable_fake_irq(b); |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 899 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 900 | spin_unlock_irq(&b->irq_lock); |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 901 | } |
| 902 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 903 | void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine) |
| 904 | { |
| 905 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 906 | |
Chris Wilson | 381744f | 2016-11-21 11:07:59 +0000 | [diff] [blame] | 907 | /* The engines should be idle and all requests accounted for! */ |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 908 | WARN_ON(READ_ONCE(b->irq_wait)); |
Chris Wilson | 381744f | 2016-11-21 11:07:59 +0000 | [diff] [blame] | 909 | WARN_ON(!RB_EMPTY_ROOT(&b->waiters)); |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 910 | WARN_ON(rcu_access_pointer(b->first_signal)); |
Chris Wilson | 381744f | 2016-11-21 11:07:59 +0000 | [diff] [blame] | 911 | WARN_ON(!RB_EMPTY_ROOT(&b->signals)); |
| 912 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 913 | if (!IS_ERR_OR_NULL(b->signaler)) |
| 914 | kthread_stop(b->signaler); |
| 915 | |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 916 | cancel_fake_irq(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 917 | } |
| 918 | |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 919 | bool intel_breadcrumbs_busy(struct intel_engine_cs *engine) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 920 | { |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 921 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 922 | bool busy = false; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 923 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 924 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | 6a5d1db | 2016-11-08 14:37:19 +0000 | [diff] [blame] | 925 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 926 | if (b->irq_wait) { |
| 927 | wake_up_process(b->irq_wait->tsk); |
Chris Wilson | 4bd6639 | 2017-03-15 21:07:22 +0000 | [diff] [blame] | 928 | busy = true; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 929 | } |
| 930 | |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 931 | if (rcu_access_pointer(b->first_signal)) { |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 932 | wake_up_process(b->signaler); |
Chris Wilson | 4bd6639 | 2017-03-15 21:07:22 +0000 | [diff] [blame] | 933 | busy = true; |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 934 | } |
| 935 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 936 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 937 | |
| 938 | return busy; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 939 | } |
Chris Wilson | f97fbf9 | 2017-02-13 17:15:14 +0000 | [diff] [blame] | 940 | |
| 941 | #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) |
| 942 | #include "selftests/intel_breadcrumbs.c" |
| 943 | #endif |