blob: 758e69f8e8a80b0d99a90a98b24d61e597d7074d [file] [log] [blame]
Andreas Gampee1459ae2016-06-29 09:36:30 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
xueliang.zhong7f88c1a2018-11-06 11:42:41 +000017#include <algorithm>
Igor Murashkin5573c372017-11-16 13:34:30 -080018#include <regex>
Andreas Gampe7adeda82016-07-25 08:27:35 -070019#include <sstream>
Andreas Gampee1459ae2016-06-29 09:36:30 -070020#include <string>
21#include <vector>
Andreas Gampee1459ae2016-06-29 09:36:30 -070022
Andreas Gampe46ee31b2016-12-14 10:11:49 -080023#include <sys/wait.h>
24#include <unistd.h>
25
Andreas Gampe57943812017-12-06 21:39:13 -080026#include <android-base/logging.h>
Andreas Gampe50f9dc22018-11-05 10:29:43 -080027#include <android-base/macros.h>
Andreas Gampe57943812017-12-06 21:39:13 -080028#include <android-base/stringprintf.h>
Andreas Gampe46ee31b2016-12-14 10:11:49 -080029
Andreas Gampee1459ae2016-06-29 09:36:30 -070030#include "common_runtime_test.h"
31
xueliang.zhong7f88c1a2018-11-06 11:42:41 +000032#include "arch/instruction_set_features.h"
Andreas Gampee1459ae2016-06-29 09:36:30 -070033#include "base/macros.h"
Andreas Gampeb486a982017-06-01 13:45:54 -070034#include "base/mutex-inl.h"
David Sehrc431b9d2018-03-02 12:01:51 -080035#include "base/utils.h"
David Sehr013fd802018-01-11 22:55:24 -080036#include "dex/art_dex_file_loader.h"
Mathieu Chartier05f90d12018-02-07 13:47:17 -080037#include "dex/base64_test_util.h"
David Sehr312f3b22018-03-19 08:39:26 -070038#include "dex/bytecode_utils.h"
Mathieu Chartier2242ef12018-07-23 18:14:13 -070039#include "dex/class_accessor-inl.h"
David Sehr9e734c72018-01-04 17:56:19 -080040#include "dex/code_item_accessors-inl.h"
41#include "dex/dex_file-inl.h"
42#include "dex/dex_file_loader.h"
Andreas Gampee1459ae2016-06-29 09:36:30 -070043#include "dex2oat_environment_test.h"
Andreas Gampef7882972017-03-20 16:35:24 -070044#include "dex2oat_return_codes.h"
Andreas Gampee15b9b12018-10-29 12:54:27 -070045#include "gc_root-inl.h"
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -070046#include "intern_table-inl.h"
Andreas Gampe67f02822016-06-24 21:05:23 -070047#include "oat.h"
48#include "oat_file.h"
David Sehr82d046e2018-04-23 08:14:19 -070049#include "profile/profile_compilation_info.h"
Mathieu Chartier792111c2018-02-15 13:02:15 -080050#include "vdex_file.h"
51#include "ziparchive/zip_writer.h"
Andreas Gampee1459ae2016-06-29 09:36:30 -070052
Andreas Gampee1459ae2016-06-29 09:36:30 -070053namespace art {
54
Mathieu Chartierea650f32017-05-24 12:04:13 -070055static constexpr size_t kMaxMethodIds = 65535;
Mathieu Chartier9e050df2017-08-09 10:05:47 -070056static constexpr bool kDebugArgs = false;
Mathieu Chartier02129102017-12-22 11:04:01 -080057static const char* kDisableCompactDex = "--compact-dex-level=none";
Mathieu Chartierea650f32017-05-24 12:04:13 -070058
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080059using android::base::StringPrintf;
60
Andreas Gampee1459ae2016-06-29 09:36:30 -070061class Dex2oatTest : public Dex2oatEnvironmentTest {
62 public:
Roland Levillainf73caca2018-08-24 17:19:07 +010063 void TearDown() override {
Andreas Gampee1459ae2016-06-29 09:36:30 -070064 Dex2oatEnvironmentTest::TearDown();
65
66 output_ = "";
67 error_msg_ = "";
68 success_ = false;
69 }
70
71 protected:
Mathieu Chartier9e050df2017-08-09 10:05:47 -070072 int GenerateOdexForTestWithStatus(const std::vector<std::string>& dex_locations,
Andreas Gampef7882972017-03-20 16:35:24 -070073 const std::string& odex_location,
74 CompilerFilter::Filter filter,
75 std::string* error_msg,
76 const std::vector<std::string>& extra_args = {},
77 bool use_fd = false) {
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080078 std::unique_ptr<File> oat_file;
Andreas Gampee1459ae2016-06-29 09:36:30 -070079 std::vector<std::string> args;
Mathieu Chartier9e050df2017-08-09 10:05:47 -070080 // Add dex file args.
81 for (const std::string& dex_location : dex_locations) {
82 args.push_back("--dex-file=" + dex_location);
83 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080084 if (use_fd) {
85 oat_file.reset(OS::CreateEmptyFile(odex_location.c_str()));
86 CHECK(oat_file != nullptr) << odex_location;
87 args.push_back("--oat-fd=" + std::to_string(oat_file->Fd()));
Mathieu Chartier046854b2017-03-01 17:16:22 -080088 args.push_back("--oat-location=" + odex_location);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080089 } else {
90 args.push_back("--oat-file=" + odex_location);
91 }
Andreas Gampee1459ae2016-06-29 09:36:30 -070092 args.push_back("--compiler-filter=" + CompilerFilter::NameOfFilter(filter));
93 args.push_back("--runtime-arg");
94 args.push_back("-Xnorelocate");
95
Andreas Gampe50f9dc22018-11-05 10:29:43 -080096 // Unless otherwise stated, use a small amount of threads, so that potential aborts are
97 // shorter. This can be overridden with extra_args.
98 args.push_back("-j4");
99
Andreas Gampee1459ae2016-06-29 09:36:30 -0700100 args.insert(args.end(), extra_args.begin(), extra_args.end());
101
Andreas Gampef7882972017-03-20 16:35:24 -0700102 int status = Dex2Oat(args, error_msg);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800103 if (oat_file != nullptr) {
Andreas Gampef7882972017-03-20 16:35:24 -0700104 CHECK_EQ(oat_file->FlushClose(), 0) << "Could not flush and close oat file";
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800105 }
Andreas Gampef7882972017-03-20 16:35:24 -0700106 return status;
107 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700108
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800109 ::testing::AssertionResult GenerateOdexForTest(
Andreas Gampe641a4732017-08-24 13:21:35 -0700110 const std::string& dex_location,
111 const std::string& odex_location,
112 CompilerFilter::Filter filter,
113 const std::vector<std::string>& extra_args = {},
114 bool expect_success = true,
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800115 bool use_fd = false) WARN_UNUSED {
116 return GenerateOdexForTest(dex_location,
117 odex_location,
118 filter,
119 extra_args,
120 expect_success,
121 use_fd,
122 [](const OatFile&) {});
Andreas Gampe641a4732017-08-24 13:21:35 -0700123 }
124
Andreas Gampe80ddf272018-01-11 09:41:00 -0800125 bool test_accepts_odex_file_on_failure = false;
126
Andreas Gampe641a4732017-08-24 13:21:35 -0700127 template <typename T>
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800128 ::testing::AssertionResult GenerateOdexForTest(
Andreas Gampe641a4732017-08-24 13:21:35 -0700129 const std::string& dex_location,
130 const std::string& odex_location,
131 CompilerFilter::Filter filter,
132 const std::vector<std::string>& extra_args,
133 bool expect_success,
134 bool use_fd,
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800135 T check_oat) WARN_UNUSED {
Andreas Gampef7882972017-03-20 16:35:24 -0700136 std::string error_msg;
Mathieu Chartier9e050df2017-08-09 10:05:47 -0700137 int status = GenerateOdexForTestWithStatus({dex_location},
Andreas Gampef7882972017-03-20 16:35:24 -0700138 odex_location,
139 filter,
140 &error_msg,
141 extra_args,
142 use_fd);
Andreas Gampe80ddf272018-01-11 09:41:00 -0800143 bool success = (WIFEXITED(status) && WEXITSTATUS(status) == 0);
Andreas Gampee1459ae2016-06-29 09:36:30 -0700144 if (expect_success) {
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800145 if (!success) {
146 return ::testing::AssertionFailure()
147 << "Failed to compile odex: " << error_msg << std::endl << output_;
148 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700149
150 // Verify the odex file was generated as expected.
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100151 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100152 odex_location.c_str(),
Andreas Gampee1459ae2016-06-29 09:36:30 -0700153 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100154 /*executable=*/ false,
155 /*low_4gb=*/ false,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700156 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100157 /*reservation=*/ nullptr,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700158 &error_msg));
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800159 if (odex_file == nullptr) {
160 return ::testing::AssertionFailure() << "Could not open odex file: " << error_msg;
161 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700162
163 CheckFilter(filter, odex_file->GetCompilerFilter());
Calin Juravle1ce70852017-06-28 10:59:03 -0700164 check_oat(*(odex_file.get()));
Andreas Gampee1459ae2016-06-29 09:36:30 -0700165 } else {
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800166 if (success) {
167 return ::testing::AssertionFailure() << "Succeeded to compile odex: " << output_;
168 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700169
170 error_msg_ = error_msg;
171
Andreas Gampe80ddf272018-01-11 09:41:00 -0800172 if (!test_accepts_odex_file_on_failure) {
173 // Verify there's no loadable odex file.
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100174 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100175 odex_location.c_str(),
Andreas Gampe80ddf272018-01-11 09:41:00 -0800176 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100177 /*executable=*/ false,
178 /*low_4gb=*/ false,
Andreas Gampe80ddf272018-01-11 09:41:00 -0800179 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100180 /*reservation=*/ nullptr,
Andreas Gampe80ddf272018-01-11 09:41:00 -0800181 &error_msg));
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800182 if (odex_file != nullptr) {
183 return ::testing::AssertionFailure() << "Could open odex file: " << error_msg;
184 }
Andreas Gampe80ddf272018-01-11 09:41:00 -0800185 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700186 }
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800187 return ::testing::AssertionSuccess();
Andreas Gampee1459ae2016-06-29 09:36:30 -0700188 }
189
Calin Juravle1ccf6132017-08-02 17:46:53 -0700190 // Check the input compiler filter against the generated oat file's filter. May be overridden
Andreas Gampee1459ae2016-06-29 09:36:30 -0700191 // in subclasses when equality is not expected.
192 virtual void CheckFilter(CompilerFilter::Filter expected, CompilerFilter::Filter actual) {
193 EXPECT_EQ(expected, actual);
194 }
195
Andreas Gampef7882972017-03-20 16:35:24 -0700196 int Dex2Oat(const std::vector<std::string>& dex2oat_args, std::string* error_msg) {
Vladimir Marko7a85e702018-12-03 18:47:23 +0000197 std::vector<std::string> argv;
198 if (!CommonRuntimeTest::StartDex2OatCommandLine(&argv, error_msg)) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700199 return false;
200 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700201
Vladimir Marko7a85e702018-12-03 18:47:23 +0000202 Runtime* runtime = Runtime::Current();
Andreas Gampee1459ae2016-06-29 09:36:30 -0700203 if (!runtime->IsVerificationEnabled()) {
Nicolas Geoffray49cda062017-04-21 13:08:25 +0100204 argv.push_back("--compiler-filter=assume-verified");
Andreas Gampee1459ae2016-06-29 09:36:30 -0700205 }
206
207 if (runtime->MustRelocateIfPossible()) {
208 argv.push_back("--runtime-arg");
209 argv.push_back("-Xrelocate");
210 } else {
211 argv.push_back("--runtime-arg");
212 argv.push_back("-Xnorelocate");
213 }
214
215 if (!kIsTargetBuild) {
216 argv.push_back("--host");
217 }
218
Andreas Gampee1459ae2016-06-29 09:36:30 -0700219 argv.insert(argv.end(), dex2oat_args.begin(), dex2oat_args.end());
220
221 // We must set --android-root.
222 const char* android_root = getenv("ANDROID_ROOT");
223 CHECK(android_root != nullptr);
224 argv.push_back("--android-root=" + std::string(android_root));
225
Mathieu Chartier9e050df2017-08-09 10:05:47 -0700226 if (kDebugArgs) {
227 std::string all_args;
228 for (const std::string& arg : argv) {
229 all_args += arg + " ";
230 }
231 LOG(ERROR) << all_args;
232 }
233
Andreas Gampe38aa0b52018-07-10 23:26:55 -0700234 // We need dex2oat to actually log things.
235 auto post_fork_fn = []() { return setenv("ANDROID_LOG_TAGS", "*:d", 1) == 0; };
236 ForkAndExecResult res = ForkAndExec(argv, post_fork_fn, &output_);
237 if (res.stage != ForkAndExecResult::kFinished) {
238 *error_msg = strerror(errno);
239 return -1;
Nicolas Geoffray56fe0f02016-06-30 15:07:46 +0100240 }
Andreas Gampe38aa0b52018-07-10 23:26:55 -0700241 success_ = res.StandardSuccess();
242 return res.status_code;
Andreas Gampee1459ae2016-06-29 09:36:30 -0700243 }
244
245 std::string output_ = "";
246 std::string error_msg_ = "";
247 bool success_ = false;
248};
249
250class Dex2oatSwapTest : public Dex2oatTest {
251 protected:
252 void RunTest(bool use_fd, bool expect_use, const std::vector<std::string>& extra_args = {}) {
253 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
254 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
255
Andreas Gampe7adeda82016-07-25 08:27:35 -0700256 Copy(GetTestDexFileName(), dex_location);
Andreas Gampee1459ae2016-06-29 09:36:30 -0700257
258 std::vector<std::string> copy(extra_args);
259
260 std::unique_ptr<ScratchFile> sf;
261 if (use_fd) {
262 sf.reset(new ScratchFile());
Andreas Gampe46ee31b2016-12-14 10:11:49 -0800263 copy.push_back(android::base::StringPrintf("--swap-fd=%d", sf->GetFd()));
Andreas Gampee1459ae2016-06-29 09:36:30 -0700264 } else {
265 std::string swap_location = GetOdexDir() + "/Dex2OatSwapTest.odex.swap";
266 copy.push_back("--swap-file=" + swap_location);
267 }
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800268 ASSERT_TRUE(GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed, copy));
Andreas Gampee1459ae2016-06-29 09:36:30 -0700269
270 CheckValidity();
271 ASSERT_TRUE(success_);
272 CheckResult(expect_use);
273 }
274
Andreas Gampe7adeda82016-07-25 08:27:35 -0700275 virtual std::string GetTestDexFileName() {
Vladimir Marko15357702017-02-09 10:37:31 +0000276 return Dex2oatEnvironmentTest::GetTestDexFileName("VerifierDeps");
Andreas Gampe7adeda82016-07-25 08:27:35 -0700277 }
278
279 virtual void CheckResult(bool expect_use) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700280 if (kIsTargetBuild) {
281 CheckTargetResult(expect_use);
282 } else {
283 CheckHostResult(expect_use);
284 }
285 }
286
Andreas Gampe7adeda82016-07-25 08:27:35 -0700287 virtual void CheckTargetResult(bool expect_use ATTRIBUTE_UNUSED) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700288 // TODO: Ignore for now, as we won't capture any output (it goes to the logcat). We may do
289 // something for variants with file descriptor where we can control the lifetime of
290 // the swap file and thus take a look at it.
291 }
292
Andreas Gampe7adeda82016-07-25 08:27:35 -0700293 virtual void CheckHostResult(bool expect_use) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700294 if (!kIsTargetBuild) {
295 if (expect_use) {
296 EXPECT_NE(output_.find("Large app, accepted running with swap."), std::string::npos)
297 << output_;
298 } else {
299 EXPECT_EQ(output_.find("Large app, accepted running with swap."), std::string::npos)
300 << output_;
301 }
302 }
303 }
304
305 // Check whether the dex2oat run was really successful.
Andreas Gampe7adeda82016-07-25 08:27:35 -0700306 virtual void CheckValidity() {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700307 if (kIsTargetBuild) {
308 CheckTargetValidity();
309 } else {
310 CheckHostValidity();
311 }
312 }
313
Andreas Gampe7adeda82016-07-25 08:27:35 -0700314 virtual void CheckTargetValidity() {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700315 // TODO: Ignore for now, as we won't capture any output (it goes to the logcat). We may do
316 // something for variants with file descriptor where we can control the lifetime of
317 // the swap file and thus take a look at it.
318 }
319
320 // On the host, we can get the dex2oat output. Here, look for "dex2oat took."
Andreas Gampe7adeda82016-07-25 08:27:35 -0700321 virtual void CheckHostValidity() {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700322 EXPECT_NE(output_.find("dex2oat took"), std::string::npos) << output_;
323 }
324};
325
326TEST_F(Dex2oatSwapTest, DoNotUseSwapDefaultSingleSmall) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100327 RunTest(/*use_fd=*/ false, /*expect_use=*/ false);
328 RunTest(/*use_fd=*/ true, /*expect_use=*/ false);
Andreas Gampee1459ae2016-06-29 09:36:30 -0700329}
330
331TEST_F(Dex2oatSwapTest, DoNotUseSwapSingle) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100332 RunTest(/*use_fd=*/ false, /*expect_use=*/ false, { "--swap-dex-size-threshold=0" });
333 RunTest(/*use_fd=*/ true, /*expect_use=*/ false, { "--swap-dex-size-threshold=0" });
Andreas Gampee1459ae2016-06-29 09:36:30 -0700334}
335
336TEST_F(Dex2oatSwapTest, DoNotUseSwapSmall) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100337 RunTest(/*use_fd=*/ false, /*expect_use=*/ false, { "--swap-dex-count-threshold=0" });
338 RunTest(/*use_fd=*/ true, /*expect_use=*/ false, { "--swap-dex-count-threshold=0" });
Andreas Gampee1459ae2016-06-29 09:36:30 -0700339}
340
341TEST_F(Dex2oatSwapTest, DoUseSwapSingleSmall) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100342 RunTest(/*use_fd=*/ false,
343 /*expect_use=*/ true,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700344 { "--swap-dex-size-threshold=0", "--swap-dex-count-threshold=0" });
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100345 RunTest(/*use_fd=*/ true,
346 /*expect_use=*/ true,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700347 { "--swap-dex-size-threshold=0", "--swap-dex-count-threshold=0" });
348}
349
Andreas Gampe7adeda82016-07-25 08:27:35 -0700350class Dex2oatSwapUseTest : public Dex2oatSwapTest {
351 protected:
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100352 void CheckHostResult(bool expect_use) override {
Andreas Gampe7adeda82016-07-25 08:27:35 -0700353 if (!kIsTargetBuild) {
354 if (expect_use) {
355 EXPECT_NE(output_.find("Large app, accepted running with swap."), std::string::npos)
356 << output_;
357 } else {
358 EXPECT_EQ(output_.find("Large app, accepted running with swap."), std::string::npos)
359 << output_;
360 }
361 }
362 }
363
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100364 std::string GetTestDexFileName() override {
Andreas Gampe7adeda82016-07-25 08:27:35 -0700365 // Use Statics as it has a handful of functions.
366 return CommonRuntimeTest::GetTestDexFileName("Statics");
367 }
368
369 void GrabResult1() {
370 if (!kIsTargetBuild) {
371 native_alloc_1_ = ParseNativeAlloc();
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100372 swap_1_ = ParseSwap(/*expected=*/ false);
Andreas Gampe7adeda82016-07-25 08:27:35 -0700373 } else {
374 native_alloc_1_ = std::numeric_limits<size_t>::max();
375 swap_1_ = 0;
376 }
377 }
378
379 void GrabResult2() {
380 if (!kIsTargetBuild) {
381 native_alloc_2_ = ParseNativeAlloc();
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100382 swap_2_ = ParseSwap(/*expected=*/ true);
Andreas Gampe7adeda82016-07-25 08:27:35 -0700383 } else {
384 native_alloc_2_ = 0;
385 swap_2_ = std::numeric_limits<size_t>::max();
386 }
387 }
388
389 private:
390 size_t ParseNativeAlloc() {
391 std::regex native_alloc_regex("dex2oat took.*native alloc=[^ ]+ \\(([0-9]+)B\\)");
392 std::smatch native_alloc_match;
393 bool found = std::regex_search(output_, native_alloc_match, native_alloc_regex);
394 if (!found) {
395 EXPECT_TRUE(found);
396 return 0;
397 }
398 if (native_alloc_match.size() != 2U) {
399 EXPECT_EQ(native_alloc_match.size(), 2U);
400 return 0;
401 }
402
403 std::istringstream stream(native_alloc_match[1].str());
404 size_t value;
405 stream >> value;
406
407 return value;
408 }
409
410 size_t ParseSwap(bool expected) {
411 std::regex swap_regex("dex2oat took[^\\n]+swap=[^ ]+ \\(([0-9]+)B\\)");
412 std::smatch swap_match;
413 bool found = std::regex_search(output_, swap_match, swap_regex);
414 if (found != expected) {
415 EXPECT_EQ(expected, found);
416 return 0;
417 }
418
419 if (!found) {
420 return 0;
421 }
422
423 if (swap_match.size() != 2U) {
424 EXPECT_EQ(swap_match.size(), 2U);
425 return 0;
426 }
427
428 std::istringstream stream(swap_match[1].str());
429 size_t value;
430 stream >> value;
431
432 return value;
433 }
434
435 protected:
436 size_t native_alloc_1_;
437 size_t native_alloc_2_;
438
439 size_t swap_1_;
440 size_t swap_2_;
441};
442
443TEST_F(Dex2oatSwapUseTest, CheckSwapUsage) {
Roland Levillain05e34f42018-05-24 13:19:05 +0000444 // Native memory usage isn't correctly tracked when running under ASan.
445 TEST_DISABLED_FOR_MEMORY_TOOL();
Andreas Gampef4a67fd2017-05-04 09:55:36 -0700446
Vladimir Marko57070da2017-02-14 16:16:30 +0000447 // The `native_alloc_2_ >= native_alloc_1_` assertion below may not
Roland Levillain19772bf2017-02-16 11:28:10 +0000448 // hold true on some x86 systems; disable this test while we
449 // investigate (b/29259363).
450 TEST_DISABLED_FOR_X86();
Vladimir Marko57070da2017-02-14 16:16:30 +0000451
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100452 RunTest(/*use_fd=*/ false,
453 /*expect_use=*/ false);
Andreas Gampe7adeda82016-07-25 08:27:35 -0700454 GrabResult1();
455 std::string output_1 = output_;
456
457 output_ = "";
458
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100459 RunTest(/*use_fd=*/ false,
460 /*expect_use=*/ true,
Andreas Gampe7adeda82016-07-25 08:27:35 -0700461 { "--swap-dex-size-threshold=0", "--swap-dex-count-threshold=0" });
462 GrabResult2();
463 std::string output_2 = output_;
464
465 if (native_alloc_2_ >= native_alloc_1_ || swap_1_ >= swap_2_) {
466 EXPECT_LT(native_alloc_2_, native_alloc_1_);
467 EXPECT_LT(swap_1_, swap_2_);
468
469 LOG(ERROR) << output_1;
470 LOG(ERROR) << output_2;
471 }
472}
473
Andreas Gampe67f02822016-06-24 21:05:23 -0700474class Dex2oatVeryLargeTest : public Dex2oatTest {
475 protected:
476 void CheckFilter(CompilerFilter::Filter input ATTRIBUTE_UNUSED,
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100477 CompilerFilter::Filter result ATTRIBUTE_UNUSED) override {
Andreas Gampe67f02822016-06-24 21:05:23 -0700478 // Ignore, we'll do our own checks.
479 }
480
481 void RunTest(CompilerFilter::Filter filter,
482 bool expect_large,
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700483 bool expect_downgrade,
Andreas Gampe67f02822016-06-24 21:05:23 -0700484 const std::vector<std::string>& extra_args = {}) {
485 std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
486 std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700487 std::string app_image_file = GetScratchDir() + "/Test.art";
Andreas Gampe67f02822016-06-24 21:05:23 -0700488
489 Copy(GetDexSrc1(), dex_location);
490
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700491 std::vector<std::string> new_args(extra_args);
492 new_args.push_back("--app-image-file=" + app_image_file);
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800493 ASSERT_TRUE(GenerateOdexForTest(dex_location, odex_location, filter, new_args));
Andreas Gampe67f02822016-06-24 21:05:23 -0700494
495 CheckValidity();
496 ASSERT_TRUE(success_);
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700497 CheckResult(dex_location,
498 odex_location,
499 app_image_file,
500 filter,
501 expect_large,
502 expect_downgrade);
Andreas Gampe67f02822016-06-24 21:05:23 -0700503 }
504
505 void CheckResult(const std::string& dex_location,
506 const std::string& odex_location,
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700507 const std::string& app_image_file,
Andreas Gampe67f02822016-06-24 21:05:23 -0700508 CompilerFilter::Filter filter,
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700509 bool expect_large,
510 bool expect_downgrade) {
511 if (expect_downgrade) {
512 EXPECT_TRUE(expect_large);
513 }
Andreas Gampe67f02822016-06-24 21:05:23 -0700514 // Host/target independent checks.
515 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100516 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100517 odex_location.c_str(),
Andreas Gampe67f02822016-06-24 21:05:23 -0700518 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100519 /*executable=*/ false,
520 /*low_4gb=*/ false,
Andreas Gampe67f02822016-06-24 21:05:23 -0700521 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100522 /*reservation=*/ nullptr,
Andreas Gampe67f02822016-06-24 21:05:23 -0700523 &error_msg));
524 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700525 EXPECT_GT(app_image_file.length(), 0u);
526 std::unique_ptr<File> file(OS::OpenFileForReading(app_image_file.c_str()));
Andreas Gampe67f02822016-06-24 21:05:23 -0700527 if (expect_large) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700528 // Note: we cannot check the following
529 // EXPECT_FALSE(CompilerFilter::IsAotCompilationEnabled(odex_file->GetCompilerFilter()));
Andreas Gampe67f02822016-06-24 21:05:23 -0700530 // The reason is that the filter override currently happens when the dex files are
531 // loaded in dex2oat, which is after the oat file has been started. Thus, the header
532 // store cannot be changed, and the original filter is set in stone.
533
534 for (const OatDexFile* oat_dex_file : odex_file->GetOatDexFiles()) {
535 std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg);
536 ASSERT_TRUE(dex_file != nullptr);
537 uint32_t class_def_count = dex_file->NumClassDefs();
538 ASSERT_LT(class_def_count, std::numeric_limits<uint16_t>::max());
539 for (uint16_t class_def_index = 0; class_def_index < class_def_count; ++class_def_index) {
540 OatFile::OatClass oat_class = oat_dex_file->GetOatClass(class_def_index);
541 EXPECT_EQ(oat_class.GetType(), OatClassType::kOatClassNoneCompiled);
542 }
543 }
544
545 // If the input filter was "below," it should have been used.
Nicolas Geoffray49cda062017-04-21 13:08:25 +0100546 if (!CompilerFilter::IsAsGoodAs(CompilerFilter::kExtract, filter)) {
Andreas Gampe67f02822016-06-24 21:05:23 -0700547 EXPECT_EQ(odex_file->GetCompilerFilter(), filter);
548 }
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700549
550 // If expect large, make sure the app image isn't generated or is empty.
551 if (file != nullptr) {
552 EXPECT_EQ(file->GetLength(), 0u);
553 }
Andreas Gampe67f02822016-06-24 21:05:23 -0700554 } else {
555 EXPECT_EQ(odex_file->GetCompilerFilter(), filter);
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700556 ASSERT_TRUE(file != nullptr) << app_image_file;
557 EXPECT_GT(file->GetLength(), 0u);
Andreas Gampe67f02822016-06-24 21:05:23 -0700558 }
559
560 // Host/target dependent checks.
561 if (kIsTargetBuild) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700562 CheckTargetResult(expect_downgrade);
Andreas Gampe67f02822016-06-24 21:05:23 -0700563 } else {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700564 CheckHostResult(expect_downgrade);
Andreas Gampe67f02822016-06-24 21:05:23 -0700565 }
566 }
567
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700568 void CheckTargetResult(bool expect_downgrade ATTRIBUTE_UNUSED) {
Andreas Gampe67f02822016-06-24 21:05:23 -0700569 // TODO: Ignore for now. May do something for fd things.
570 }
571
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700572 void CheckHostResult(bool expect_downgrade) {
Andreas Gampe67f02822016-06-24 21:05:23 -0700573 if (!kIsTargetBuild) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700574 if (expect_downgrade) {
575 EXPECT_NE(output_.find("Very large app, downgrading to"), std::string::npos) << output_;
Andreas Gampe67f02822016-06-24 21:05:23 -0700576 } else {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700577 EXPECT_EQ(output_.find("Very large app, downgrading to"), std::string::npos) << output_;
Andreas Gampe67f02822016-06-24 21:05:23 -0700578 }
579 }
580 }
581
582 // Check whether the dex2oat run was really successful.
583 void CheckValidity() {
584 if (kIsTargetBuild) {
585 CheckTargetValidity();
586 } else {
587 CheckHostValidity();
588 }
589 }
590
591 void CheckTargetValidity() {
592 // TODO: Ignore for now.
593 }
594
595 // On the host, we can get the dex2oat output. Here, look for "dex2oat took."
596 void CheckHostValidity() {
597 EXPECT_NE(output_.find("dex2oat took"), std::string::npos) << output_;
598 }
599};
600
601TEST_F(Dex2oatVeryLargeTest, DontUseVeryLarge) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700602 RunTest(CompilerFilter::kAssumeVerified, false, false);
603 RunTest(CompilerFilter::kExtract, false, false);
604 RunTest(CompilerFilter::kQuicken, false, false);
605 RunTest(CompilerFilter::kSpeed, false, false);
Andreas Gampe67f02822016-06-24 21:05:23 -0700606
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700607 RunTest(CompilerFilter::kAssumeVerified, false, false, { "--very-large-app-threshold=10000000" });
608 RunTest(CompilerFilter::kExtract, false, false, { "--very-large-app-threshold=10000000" });
609 RunTest(CompilerFilter::kQuicken, false, false, { "--very-large-app-threshold=10000000" });
610 RunTest(CompilerFilter::kSpeed, false, false, { "--very-large-app-threshold=10000000" });
Andreas Gampe67f02822016-06-24 21:05:23 -0700611}
612
613TEST_F(Dex2oatVeryLargeTest, UseVeryLarge) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700614 RunTest(CompilerFilter::kAssumeVerified, true, false, { "--very-large-app-threshold=100" });
615 RunTest(CompilerFilter::kExtract, true, false, { "--very-large-app-threshold=100" });
616 RunTest(CompilerFilter::kQuicken, true, true, { "--very-large-app-threshold=100" });
617 RunTest(CompilerFilter::kSpeed, true, true, { "--very-large-app-threshold=100" });
Andreas Gampe67f02822016-06-24 21:05:23 -0700618}
619
Mathieu Chartier97ab5e32017-02-22 13:35:44 -0800620// Regressin test for b/35665292.
621TEST_F(Dex2oatVeryLargeTest, SpeedProfileNoProfile) {
622 // Test that dex2oat doesn't crash with speed-profile but no input profile.
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700623 RunTest(CompilerFilter::kSpeedProfile, false, false);
Mathieu Chartier97ab5e32017-02-22 13:35:44 -0800624}
625
Jeff Hao608f2ce2016-10-19 11:17:11 -0700626class Dex2oatLayoutTest : public Dex2oatTest {
627 protected:
628 void CheckFilter(CompilerFilter::Filter input ATTRIBUTE_UNUSED,
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100629 CompilerFilter::Filter result ATTRIBUTE_UNUSED) override {
Jeff Hao608f2ce2016-10-19 11:17:11 -0700630 // Ignore, we'll do our own checks.
631 }
632
Jeff Hao41fba6a2016-11-28 11:53:33 -0800633 // Emits a profile with a single dex file with the given location and a single class index of 1.
634 void GenerateProfile(const std::string& test_profile,
635 const std::string& dex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800636 size_t num_classes,
Jeff Hao41fba6a2016-11-28 11:53:33 -0800637 uint32_t checksum) {
Andreas Gampedfcd82c2018-10-16 20:22:37 -0700638 int profile_test_fd = open(test_profile.c_str(),
639 O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
640 0644);
Jeff Hao41fba6a2016-11-28 11:53:33 -0800641 CHECK_GE(profile_test_fd, 0);
642
643 ProfileCompilationInfo info;
644 std::string profile_key = ProfileCompilationInfo::GetProfileDexFileKey(dex_location);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800645 for (size_t i = 0; i < num_classes; ++i) {
Mathieu Chartierea650f32017-05-24 12:04:13 -0700646 info.AddClassIndex(profile_key, checksum, dex::TypeIndex(1 + i), kMaxMethodIds);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800647 }
Jeff Hao41fba6a2016-11-28 11:53:33 -0800648 bool result = info.Save(profile_test_fd);
649 close(profile_test_fd);
650 ASSERT_TRUE(result);
651 }
652
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800653 void CompileProfileOdex(const std::string& dex_location,
654 const std::string& odex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800655 const std::string& app_image_file_name,
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800656 bool use_fd,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800657 size_t num_profile_classes,
Nicolas Geoffray97fa9922017-03-09 13:13:25 +0000658 const std::vector<std::string>& extra_args = {},
659 bool expect_success = true) {
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800660 const std::string profile_location = GetScratchDir() + "/primary.prof";
Jeff Hao41fba6a2016-11-28 11:53:33 -0800661 const char* location = dex_location.c_str();
662 std::string error_msg;
663 std::vector<std::unique_ptr<const DexFile>> dex_files;
David Sehr013fd802018-01-11 22:55:24 -0800664 const ArtDexFileLoader dex_file_loader;
665 ASSERT_TRUE(dex_file_loader.Open(
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100666 location, location, /*verify=*/ true, /*verify_checksum=*/ true, &error_msg, &dex_files));
Jeff Hao41fba6a2016-11-28 11:53:33 -0800667 EXPECT_EQ(dex_files.size(), 1U);
668 std::unique_ptr<const DexFile>& dex_file = dex_files[0];
Mathieu Chartier046854b2017-03-01 17:16:22 -0800669 GenerateProfile(profile_location,
670 dex_location,
671 num_profile_classes,
672 dex_file->GetLocationChecksum());
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800673 std::vector<std::string> copy(extra_args);
674 copy.push_back("--profile-file=" + profile_location);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800675 std::unique_ptr<File> app_image_file;
676 if (!app_image_file_name.empty()) {
677 if (use_fd) {
678 app_image_file.reset(OS::CreateEmptyFile(app_image_file_name.c_str()));
679 copy.push_back("--app-image-fd=" + std::to_string(app_image_file->Fd()));
680 } else {
681 copy.push_back("--app-image-file=" + app_image_file_name);
682 }
683 }
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800684 ASSERT_TRUE(GenerateOdexForTest(dex_location,
685 odex_location,
686 CompilerFilter::kSpeedProfile,
687 copy,
688 expect_success,
689 use_fd));
Mathieu Chartier046854b2017-03-01 17:16:22 -0800690 if (app_image_file != nullptr) {
691 ASSERT_EQ(app_image_file->FlushCloseOrErase(), 0) << "Could not flush and close art file";
692 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800693 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700694
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100695 uint64_t GetImageObjectSectionSize(const std::string& image_file_name) {
Mathieu Chartier046854b2017-03-01 17:16:22 -0800696 EXPECT_FALSE(image_file_name.empty());
697 std::unique_ptr<File> file(OS::OpenFileForReading(image_file_name.c_str()));
698 CHECK(file != nullptr);
699 ImageHeader image_header;
700 const bool success = file->ReadFully(&image_header, sizeof(image_header));
701 CHECK(success);
702 CHECK(image_header.IsValid());
703 ReaderMutexLock mu(Thread::Current(), *Locks::mutator_lock_);
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100704 return image_header.GetObjectsSection().Size();
Mathieu Chartier046854b2017-03-01 17:16:22 -0800705 }
706
707 void RunTest(bool app_image) {
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800708 std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
709 std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
Mathieu Chartier046854b2017-03-01 17:16:22 -0800710 std::string app_image_file = app_image ? (GetOdexDir() + "/DexOdexNoOat.art"): "";
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800711 Copy(GetDexSrc2(), dex_location);
712
Mathieu Chartier046854b2017-03-01 17:16:22 -0800713 uint64_t image_file_empty_profile = 0;
714 if (app_image) {
715 CompileProfileOdex(dex_location,
716 odex_location,
717 app_image_file,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100718 /*use_fd=*/ false,
719 /*num_profile_classes=*/ 0);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800720 CheckValidity();
721 ASSERT_TRUE(success_);
722 // Don't check the result since CheckResult relies on the class being in the profile.
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100723 image_file_empty_profile = GetImageObjectSectionSize(app_image_file);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800724 EXPECT_GT(image_file_empty_profile, 0u);
725 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700726
Mathieu Chartier046854b2017-03-01 17:16:22 -0800727 // Small profile.
728 CompileProfileOdex(dex_location,
729 odex_location,
730 app_image_file,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100731 /*use_fd=*/ false,
732 /*num_profile_classes=*/ 1);
Jeff Hao608f2ce2016-10-19 11:17:11 -0700733 CheckValidity();
734 ASSERT_TRUE(success_);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800735 CheckResult(dex_location, odex_location, app_image_file);
736
737 if (app_image) {
738 // Test that the profile made a difference by adding more classes.
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100739 const uint64_t image_file_small_profile = GetImageObjectSectionSize(app_image_file);
740 ASSERT_LT(image_file_empty_profile, image_file_small_profile);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800741 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700742 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800743
744 void RunTestVDex() {
745 std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
746 std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
747 std::string vdex_location = GetOdexDir() + "/DexOdexNoOat.vdex";
Mathieu Chartier046854b2017-03-01 17:16:22 -0800748 std::string app_image_file_name = GetOdexDir() + "/DexOdexNoOat.art";
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800749 Copy(GetDexSrc2(), dex_location);
750
751 std::unique_ptr<File> vdex_file1(OS::CreateEmptyFile(vdex_location.c_str()));
752 CHECK(vdex_file1 != nullptr) << vdex_location;
753 ScratchFile vdex_file2;
754 {
755 std::string input_vdex = "--input-vdex-fd=-1";
756 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
757 CompileProfileOdex(dex_location,
758 odex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800759 app_image_file_name,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100760 /*use_fd=*/ true,
761 /*num_profile_classes=*/ 1,
Mathieu Chartierf1609832018-01-31 03:09:56 -0800762 { input_vdex, output_vdex });
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800763 EXPECT_GT(vdex_file1->GetLength(), 0u);
764 }
765 {
Nicolas Geoffray97fa9922017-03-09 13:13:25 +0000766 // Test that vdex and dexlayout fail gracefully.
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800767 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_file1->Fd());
768 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file2.GetFd());
769 CompileProfileOdex(dex_location,
770 odex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800771 app_image_file_name,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100772 /*use_fd=*/ true,
773 /*num_profile_classes=*/ 1,
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800774 { input_vdex, output_vdex },
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100775 /*expect_success=*/ true);
Nicolas Geoffray4e868fa2017-04-21 17:16:44 +0100776 EXPECT_GT(vdex_file2.GetFile()->GetLength(), 0u);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800777 }
778 ASSERT_EQ(vdex_file1->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
779 CheckValidity();
Nicolas Geoffray4e868fa2017-04-21 17:16:44 +0100780 ASSERT_TRUE(success_);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800781 }
782
Mathieu Chartier046854b2017-03-01 17:16:22 -0800783 void CheckResult(const std::string& dex_location,
784 const std::string& odex_location,
785 const std::string& app_image_file_name) {
Jeff Hao608f2ce2016-10-19 11:17:11 -0700786 // Host/target independent checks.
787 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100788 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100789 odex_location.c_str(),
Jeff Hao608f2ce2016-10-19 11:17:11 -0700790 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100791 /*executable=*/ false,
792 /*low_4gb=*/ false,
Jeff Hao608f2ce2016-10-19 11:17:11 -0700793 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100794 /*reservation=*/ nullptr,
Jeff Hao608f2ce2016-10-19 11:17:11 -0700795 &error_msg));
796 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
797
Jeff Hao042e8982016-10-19 11:17:11 -0700798 const char* location = dex_location.c_str();
799 std::vector<std::unique_ptr<const DexFile>> dex_files;
David Sehr013fd802018-01-11 22:55:24 -0800800 const ArtDexFileLoader dex_file_loader;
801 ASSERT_TRUE(dex_file_loader.Open(
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100802 location, location, /*verify=*/ true, /*verify_checksum=*/ true, &error_msg, &dex_files));
Jeff Hao042e8982016-10-19 11:17:11 -0700803 EXPECT_EQ(dex_files.size(), 1U);
804 std::unique_ptr<const DexFile>& old_dex_file = dex_files[0];
805
Jeff Hao608f2ce2016-10-19 11:17:11 -0700806 for (const OatDexFile* oat_dex_file : odex_file->GetOatDexFiles()) {
Jeff Hao042e8982016-10-19 11:17:11 -0700807 std::unique_ptr<const DexFile> new_dex_file = oat_dex_file->OpenDexFile(&error_msg);
808 ASSERT_TRUE(new_dex_file != nullptr);
809 uint32_t class_def_count = new_dex_file->NumClassDefs();
Jeff Hao608f2ce2016-10-19 11:17:11 -0700810 ASSERT_LT(class_def_count, std::numeric_limits<uint16_t>::max());
Jeff Hao042e8982016-10-19 11:17:11 -0700811 ASSERT_GE(class_def_count, 2U);
812
Mathieu Chartier24066ec2017-10-21 16:01:08 -0700813 // Make sure the indexes stay the same.
Jeff Hao042e8982016-10-19 11:17:11 -0700814 std::string old_class0 = old_dex_file->PrettyType(old_dex_file->GetClassDef(0).class_idx_);
815 std::string old_class1 = old_dex_file->PrettyType(old_dex_file->GetClassDef(1).class_idx_);
816 std::string new_class0 = new_dex_file->PrettyType(new_dex_file->GetClassDef(0).class_idx_);
817 std::string new_class1 = new_dex_file->PrettyType(new_dex_file->GetClassDef(1).class_idx_);
Mathieu Chartier24066ec2017-10-21 16:01:08 -0700818 EXPECT_EQ(old_class0, new_class0);
819 EXPECT_EQ(old_class1, new_class1);
Jeff Hao608f2ce2016-10-19 11:17:11 -0700820 }
821
Jeff Haoc155b052017-01-17 17:43:29 -0800822 EXPECT_EQ(odex_file->GetCompilerFilter(), CompilerFilter::kSpeedProfile);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800823
824 if (!app_image_file_name.empty()) {
825 // Go peek at the image header to make sure it was large enough to contain the class.
826 std::unique_ptr<File> file(OS::OpenFileForReading(app_image_file_name.c_str()));
827 ImageHeader image_header;
828 bool success = file->ReadFully(&image_header, sizeof(image_header));
829 ASSERT_TRUE(success);
830 ASSERT_TRUE(image_header.IsValid());
Vladimir Markocd87c3e2017-09-05 13:11:57 +0100831 EXPECT_GT(image_header.GetObjectsSection().Size(), 0u);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800832 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700833 }
834
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800835 // Check whether the dex2oat run was really successful.
836 void CheckValidity() {
837 if (kIsTargetBuild) {
838 CheckTargetValidity();
839 } else {
840 CheckHostValidity();
Jeff Hao608f2ce2016-10-19 11:17:11 -0700841 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800842 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700843
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800844 void CheckTargetValidity() {
845 // TODO: Ignore for now.
846 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700847
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800848 // On the host, we can get the dex2oat output. Here, look for "dex2oat took."
849 void CheckHostValidity() {
850 EXPECT_NE(output_.find("dex2oat took"), std::string::npos) << output_;
851 }
852};
Jeff Hao608f2ce2016-10-19 11:17:11 -0700853
854TEST_F(Dex2oatLayoutTest, TestLayout) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100855 RunTest(/*app_image=*/ false);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800856}
857
858TEST_F(Dex2oatLayoutTest, TestLayoutAppImage) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100859 RunTest(/*app_image=*/ true);
Jeff Hao608f2ce2016-10-19 11:17:11 -0700860}
861
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800862TEST_F(Dex2oatLayoutTest, TestVdexLayout) {
863 RunTestVDex();
864}
865
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100866class Dex2oatUnquickenTest : public Dex2oatTest {
867 protected:
868 void RunUnquickenMultiDex() {
869 std::string dex_location = GetScratchDir() + "/UnquickenMultiDex.jar";
870 std::string odex_location = GetOdexDir() + "/UnquickenMultiDex.odex";
871 std::string vdex_location = GetOdexDir() + "/UnquickenMultiDex.vdex";
872 Copy(GetTestDexFileName("MultiDex"), dex_location);
873
874 std::unique_ptr<File> vdex_file1(OS::CreateEmptyFile(vdex_location.c_str()));
875 CHECK(vdex_file1 != nullptr) << vdex_location;
876 // Quicken the dex file into a vdex file.
877 {
878 std::string input_vdex = "--input-vdex-fd=-1";
879 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800880 ASSERT_TRUE(GenerateOdexForTest(dex_location,
881 odex_location,
882 CompilerFilter::kQuicken,
883 { input_vdex, output_vdex },
884 /* expect_success= */ true,
885 /* use_fd= */ true));
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100886 EXPECT_GT(vdex_file1->GetLength(), 0u);
887 }
888 // Unquicken by running the verify compiler filter on the vdex file.
889 {
890 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_file1->Fd());
891 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800892 ASSERT_TRUE(GenerateOdexForTest(dex_location,
893 odex_location,
894 CompilerFilter::kVerify,
895 { input_vdex, output_vdex, kDisableCompactDex },
896 /* expect_success= */ true,
897 /* use_fd= */ true));
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100898 }
899 ASSERT_EQ(vdex_file1->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
900 CheckResult(dex_location, odex_location);
901 ASSERT_TRUE(success_);
902 }
903
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800904 void RunUnquickenMultiDexCDex() {
905 std::string dex_location = GetScratchDir() + "/UnquickenMultiDex.jar";
906 std::string odex_location = GetOdexDir() + "/UnquickenMultiDex.odex";
907 std::string odex_location2 = GetOdexDir() + "/UnquickenMultiDex2.odex";
908 std::string vdex_location = GetOdexDir() + "/UnquickenMultiDex.vdex";
909 std::string vdex_location2 = GetOdexDir() + "/UnquickenMultiDex2.vdex";
910 Copy(GetTestDexFileName("MultiDex"), dex_location);
911
912 std::unique_ptr<File> vdex_file1(OS::CreateEmptyFile(vdex_location.c_str()));
913 std::unique_ptr<File> vdex_file2(OS::CreateEmptyFile(vdex_location2.c_str()));
914 CHECK(vdex_file1 != nullptr) << vdex_location;
915 CHECK(vdex_file2 != nullptr) << vdex_location2;
916
917 // Quicken the dex file into a vdex file.
918 {
919 std::string input_vdex = "--input-vdex-fd=-1";
920 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800921 ASSERT_TRUE(GenerateOdexForTest(dex_location,
922 odex_location,
923 CompilerFilter::kQuicken,
924 { input_vdex, output_vdex, "--compact-dex-level=fast"},
925 /* expect_success= */ true,
926 /* use_fd= */ true));
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800927 EXPECT_GT(vdex_file1->GetLength(), 0u);
928 }
929
930 // Unquicken by running the verify compiler filter on the vdex file.
931 {
932 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_file1->Fd());
933 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file2->Fd());
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800934 ASSERT_TRUE(GenerateOdexForTest(dex_location,
935 odex_location2,
936 CompilerFilter::kVerify,
937 { input_vdex, output_vdex, "--compact-dex-level=none"},
938 /* expect_success= */ true,
939 /* use_fd= */ true));
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800940 }
941 ASSERT_EQ(vdex_file1->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
942 ASSERT_EQ(vdex_file2->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
943 CheckResult(dex_location, odex_location2);
944 ASSERT_TRUE(success_);
945 }
946
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100947 void CheckResult(const std::string& dex_location, const std::string& odex_location) {
948 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100949 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100950 odex_location.c_str(),
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100951 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100952 /*executable=*/ false,
953 /*low_4gb=*/ false,
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100954 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100955 /*reservation=*/ nullptr,
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100956 &error_msg));
957 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
958 ASSERT_GE(odex_file->GetOatDexFiles().size(), 1u);
959
960 // Iterate over the dex files and ensure there is no quickened instruction.
961 for (const OatDexFile* oat_dex_file : odex_file->GetOatDexFiles()) {
962 std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg);
Mathieu Chartier2242ef12018-07-23 18:14:13 -0700963 for (ClassAccessor accessor : dex_file->GetClasses()) {
964 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
965 for (const DexInstructionPcPair& inst : method.GetInstructions()) {
966 ASSERT_FALSE(inst->IsQuickened()) << inst->Opcode() << " " << output_;
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100967 }
968 }
969 }
970 }
971 }
972};
973
974TEST_F(Dex2oatUnquickenTest, UnquickenMultiDex) {
975 RunUnquickenMultiDex();
976}
977
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800978TEST_F(Dex2oatUnquickenTest, UnquickenMultiDexCDex) {
979 RunUnquickenMultiDexCDex();
980}
981
Andreas Gampe2e8a2562017-01-18 20:39:02 -0800982class Dex2oatWatchdogTest : public Dex2oatTest {
983 protected:
984 void RunTest(bool expect_success, const std::vector<std::string>& extra_args = {}) {
985 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
986 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
987
988 Copy(GetTestDexFileName(), dex_location);
989
990 std::vector<std::string> copy(extra_args);
991
992 std::string swap_location = GetOdexDir() + "/Dex2OatSwapTest.odex.swap";
993 copy.push_back("--swap-file=" + swap_location);
Andreas Gampe22fa3762017-10-23 20:58:12 -0700994 copy.push_back("-j512"); // Excessive idle threads just slow down dex2oat.
Andreas Gampe50f9dc22018-11-05 10:29:43 -0800995 ASSERT_TRUE(GenerateOdexForTest(dex_location,
996 odex_location,
997 CompilerFilter::kSpeed,
998 copy,
999 expect_success));
Andreas Gampe2e8a2562017-01-18 20:39:02 -08001000 }
1001
1002 std::string GetTestDexFileName() {
1003 return GetDexSrc1();
1004 }
1005};
1006
1007TEST_F(Dex2oatWatchdogTest, TestWatchdogOK) {
1008 // Check with default.
1009 RunTest(true);
1010
1011 // Check with ten minutes.
1012 RunTest(true, { "--watchdog-timeout=600000" });
1013}
1014
1015TEST_F(Dex2oatWatchdogTest, TestWatchdogTrigger) {
Roland Levillain1fb24e22019-01-09 13:33:37 +00001016 // This test is frequently interrupted by timeout_dumper on host (x86);
1017 // disable it while we investigate (b/121352534).
1018 TEST_DISABLED_FOR_X86();
1019
Andreas Gampe80ddf272018-01-11 09:41:00 -08001020 // The watchdog is independent of dex2oat and will not delete intermediates. It is possible
1021 // that the compilation succeeds and the file is completely written by the time the watchdog
1022 // kills dex2oat (but the dex2oat threads must have been scheduled pretty badly).
1023 test_accepts_odex_file_on_failure = true;
1024
Andreas Gampe2e8a2562017-01-18 20:39:02 -08001025 // Check with ten milliseconds.
1026 RunTest(false, { "--watchdog-timeout=10" });
1027}
1028
Andreas Gampef7882972017-03-20 16:35:24 -07001029class Dex2oatReturnCodeTest : public Dex2oatTest {
1030 protected:
1031 int RunTest(const std::vector<std::string>& extra_args = {}) {
1032 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
1033 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
1034
1035 Copy(GetTestDexFileName(), dex_location);
1036
1037 std::string error_msg;
Mathieu Chartier9e050df2017-08-09 10:05:47 -07001038 return GenerateOdexForTestWithStatus({dex_location},
Andreas Gampef7882972017-03-20 16:35:24 -07001039 odex_location,
1040 CompilerFilter::kSpeed,
1041 &error_msg,
1042 extra_args);
1043 }
1044
1045 std::string GetTestDexFileName() {
1046 return GetDexSrc1();
1047 }
1048};
1049
1050TEST_F(Dex2oatReturnCodeTest, TestCreateRuntime) {
Andreas Gampefd80b172017-04-26 22:25:31 -07001051 TEST_DISABLED_FOR_MEMORY_TOOL(); // b/19100793
Andreas Gampef7882972017-03-20 16:35:24 -07001052 int status = RunTest({ "--boot-image=/this/does/not/exist/yolo.oat" });
1053 EXPECT_EQ(static_cast<int>(dex2oat::ReturnCode::kCreateRuntime), WEXITSTATUS(status)) << output_;
1054}
1055
Calin Juravle1ce70852017-06-28 10:59:03 -07001056class Dex2oatClassLoaderContextTest : public Dex2oatTest {
1057 protected:
1058 void RunTest(const char* class_loader_context,
1059 const char* expected_classpath_key,
1060 bool expected_success,
Nicolas Geoffrayf0d30022018-11-20 17:45:38 +00001061 bool use_second_source = false,
1062 bool generate_image = false) {
Calin Juravle1ce70852017-06-28 10:59:03 -07001063 std::string dex_location = GetUsedDexLocation();
1064 std::string odex_location = GetUsedOatLocation();
1065
1066 Copy(use_second_source ? GetDexSrc2() : GetDexSrc1(), dex_location);
1067
1068 std::string error_msg;
1069 std::vector<std::string> extra_args;
1070 if (class_loader_context != nullptr) {
1071 extra_args.push_back(std::string("--class-loader-context=") + class_loader_context);
1072 }
Nicolas Geoffrayf0d30022018-11-20 17:45:38 +00001073 if (generate_image) {
1074 extra_args.push_back(std::string("--app-image-file=") + GetUsedImageLocation());
1075 }
Calin Juravle1ce70852017-06-28 10:59:03 -07001076 auto check_oat = [expected_classpath_key](const OatFile& oat_file) {
1077 ASSERT_TRUE(expected_classpath_key != nullptr);
1078 const char* classpath = oat_file.GetOatHeader().GetStoreValueByKey(OatHeader::kClassPathKey);
1079 ASSERT_TRUE(classpath != nullptr);
1080 ASSERT_STREQ(expected_classpath_key, classpath);
1081 };
1082
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001083 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1084 odex_location,
1085 CompilerFilter::kQuicken,
1086 extra_args,
1087 expected_success,
1088 /*use_fd*/ false,
1089 check_oat));
Calin Juravle1ce70852017-06-28 10:59:03 -07001090 }
1091
1092 std::string GetUsedDexLocation() {
1093 return GetScratchDir() + "/Context.jar";
1094 }
1095
1096 std::string GetUsedOatLocation() {
1097 return GetOdexDir() + "/Context.odex";
1098 }
1099
Nicolas Geoffrayf0d30022018-11-20 17:45:38 +00001100 std::string GetUsedImageLocation() {
1101 return GetOdexDir() + "/Context.art";
1102 }
1103
Calin Juravle7b0648a2017-07-07 18:40:50 -07001104 const char* kEmptyClassPathKey = "PCL[]";
Calin Juravle1ce70852017-06-28 10:59:03 -07001105};
1106
1107TEST_F(Dex2oatClassLoaderContextTest, InvalidContext) {
1108 RunTest("Invalid[]", /*expected_classpath_key*/ nullptr, /*expected_success*/ false);
1109}
1110
1111TEST_F(Dex2oatClassLoaderContextTest, EmptyContext) {
1112 RunTest("PCL[]", kEmptyClassPathKey, /*expected_success*/ true);
1113}
1114
1115TEST_F(Dex2oatClassLoaderContextTest, SpecialContext) {
1116 RunTest(OatFile::kSpecialSharedLibrary,
1117 OatFile::kSpecialSharedLibrary,
1118 /*expected_success*/ true);
1119}
1120
1121TEST_F(Dex2oatClassLoaderContextTest, ContextWithTheSourceDexFiles) {
1122 std::string context = "PCL[" + GetUsedDexLocation() + "]";
1123 RunTest(context.c_str(), kEmptyClassPathKey, /*expected_success*/ true);
1124}
1125
1126TEST_F(Dex2oatClassLoaderContextTest, ContextWithOtherDexFiles) {
1127 std::vector<std::unique_ptr<const DexFile>> dex_files = OpenTestDexFiles("Nested");
Calin Juravle1ce70852017-06-28 10:59:03 -07001128
1129 std::string context = "PCL[" + dex_files[0]->GetLocation() + "]";
Calin Juravle7b0648a2017-07-07 18:40:50 -07001130 std::string expected_classpath_key = "PCL[" +
1131 dex_files[0]->GetLocation() + "*" + std::to_string(dex_files[0]->GetLocationChecksum()) + "]";
Calin Juravle1ce70852017-06-28 10:59:03 -07001132 RunTest(context.c_str(), expected_classpath_key.c_str(), true);
1133}
1134
1135TEST_F(Dex2oatClassLoaderContextTest, ContextWithStrippedDexFiles) {
1136 std::string stripped_classpath = GetScratchDir() + "/stripped_classpath.jar";
1137 Copy(GetStrippedDexSrc1(), stripped_classpath);
1138
1139 std::string context = "PCL[" + stripped_classpath + "]";
1140 // Expect an empty context because stripped dex files cannot be open.
Calin Juravle7b0648a2017-07-07 18:40:50 -07001141 RunTest(context.c_str(), kEmptyClassPathKey , /*expected_success*/ true);
Calin Juravle1ce70852017-06-28 10:59:03 -07001142}
1143
1144TEST_F(Dex2oatClassLoaderContextTest, ContextWithStrippedDexFilesBackedByOdex) {
1145 std::string stripped_classpath = GetScratchDir() + "/stripped_classpath.jar";
1146 std::string odex_for_classpath = GetOdexDir() + "/stripped_classpath.odex";
1147
1148 Copy(GetDexSrc1(), stripped_classpath);
1149
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001150 ASSERT_TRUE(GenerateOdexForTest(stripped_classpath,
1151 odex_for_classpath,
1152 CompilerFilter::kQuicken,
1153 {},
1154 true));
Calin Juravle1ce70852017-06-28 10:59:03 -07001155
1156 // Strip the dex file
1157 Copy(GetStrippedDexSrc1(), stripped_classpath);
1158
1159 std::string context = "PCL[" + stripped_classpath + "]";
Calin Juravle7b0648a2017-07-07 18:40:50 -07001160 std::string expected_classpath_key;
Calin Juravle1ce70852017-06-28 10:59:03 -07001161 {
1162 // Open the oat file to get the expected classpath.
Nicolas Geoffray29742602017-12-14 10:09:03 +00001163 OatFileAssistant oat_file_assistant(stripped_classpath.c_str(), kRuntimeISA, false, false);
Calin Juravle1ce70852017-06-28 10:59:03 -07001164 std::unique_ptr<OatFile> oat_file(oat_file_assistant.GetBestOatFile());
1165 std::vector<std::unique_ptr<const DexFile>> oat_dex_files =
1166 OatFileAssistant::LoadDexFiles(*oat_file, stripped_classpath.c_str());
Calin Juravle7b0648a2017-07-07 18:40:50 -07001167 expected_classpath_key = "PCL[";
1168 for (size_t i = 0; i < oat_dex_files.size(); i++) {
1169 if (i > 0) {
1170 expected_classpath_key + ":";
1171 }
1172 expected_classpath_key += oat_dex_files[i]->GetLocation() + "*" +
1173 std::to_string(oat_dex_files[i]->GetLocationChecksum());
1174 }
1175 expected_classpath_key += "]";
Calin Juravle1ce70852017-06-28 10:59:03 -07001176 }
1177
1178 RunTest(context.c_str(),
Calin Juravle7b0648a2017-07-07 18:40:50 -07001179 expected_classpath_key.c_str(),
Calin Juravle1ce70852017-06-28 10:59:03 -07001180 /*expected_success*/ true,
1181 /*use_second_source*/ true);
1182}
1183
1184TEST_F(Dex2oatClassLoaderContextTest, ContextWithNotExistentDexFiles) {
1185 std::string context = "PCL[does_not_exists.dex]";
1186 // Expect an empty context because stripped dex files cannot be open.
1187 RunTest(context.c_str(), kEmptyClassPathKey, /*expected_success*/ true);
1188}
1189
Calin Juravlec79470d2017-07-12 17:37:42 -07001190TEST_F(Dex2oatClassLoaderContextTest, ChainContext) {
1191 std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Nested");
1192 std::vector<std::unique_ptr<const DexFile>> dex_files2 = OpenTestDexFiles("MultiDex");
1193
1194 std::string context = "PCL[" + GetTestDexFileName("Nested") + "];" +
1195 "DLC[" + GetTestDexFileName("MultiDex") + "]";
1196 std::string expected_classpath_key = "PCL[" + CreateClassPathWithChecksums(dex_files1) + "];" +
1197 "DLC[" + CreateClassPathWithChecksums(dex_files2) + "]";
1198
1199 RunTest(context.c_str(), expected_classpath_key.c_str(), true);
1200}
1201
Nicolas Geoffray6b9fd8c2018-11-16 10:25:42 +00001202TEST_F(Dex2oatClassLoaderContextTest, ContextWithSharedLibrary) {
1203 std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Nested");
1204 std::vector<std::unique_ptr<const DexFile>> dex_files2 = OpenTestDexFiles("MultiDex");
1205
1206 std::string context = "PCL[" + GetTestDexFileName("Nested") + "]" +
1207 "{PCL[" + GetTestDexFileName("MultiDex") + "]}";
1208 std::string expected_classpath_key = "PCL[" + CreateClassPathWithChecksums(dex_files1) + "]" +
1209 "{PCL[" + CreateClassPathWithChecksums(dex_files2) + "]}";
1210 RunTest(context.c_str(), expected_classpath_key.c_str(), true);
1211}
1212
Nicolas Geoffrayf0d30022018-11-20 17:45:38 +00001213TEST_F(Dex2oatClassLoaderContextTest, ContextWithSharedLibraryAndImage) {
1214 std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Nested");
1215 std::vector<std::unique_ptr<const DexFile>> dex_files2 = OpenTestDexFiles("MultiDex");
1216
1217 std::string context = "PCL[" + GetTestDexFileName("Nested") + "]" +
1218 "{PCL[" + GetTestDexFileName("MultiDex") + "]}";
1219 std::string expected_classpath_key = "PCL[" + CreateClassPathWithChecksums(dex_files1) + "]" +
1220 "{PCL[" + CreateClassPathWithChecksums(dex_files2) + "]}";
1221 RunTest(context.c_str(),
1222 expected_classpath_key.c_str(),
1223 /*expected_success=*/ true,
1224 /*use_second_source=*/ false,
1225 /*generate_image=*/ true);
1226}
1227
1228TEST_F(Dex2oatClassLoaderContextTest, ContextWithSameSharedLibrariesAndImage) {
1229 std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Nested");
1230 std::vector<std::unique_ptr<const DexFile>> dex_files2 = OpenTestDexFiles("MultiDex");
1231
1232 std::string context = "PCL[" + GetTestDexFileName("Nested") + "]" +
1233 "{PCL[" + GetTestDexFileName("MultiDex") + "]" +
1234 "#PCL[" + GetTestDexFileName("MultiDex") + "]}";
1235 std::string expected_classpath_key = "PCL[" + CreateClassPathWithChecksums(dex_files1) + "]" +
1236 "{PCL[" + CreateClassPathWithChecksums(dex_files2) + "]" +
1237 "#PCL[" + CreateClassPathWithChecksums(dex_files2) + "]}";
1238 RunTest(context.c_str(),
1239 expected_classpath_key.c_str(),
1240 /*expected_success=*/ true,
1241 /*use_second_source=*/ false,
1242 /*generate_image=*/ true);
1243}
1244
1245TEST_F(Dex2oatClassLoaderContextTest, ContextWithSharedLibrariesDependenciesAndImage) {
1246 std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Nested");
1247 std::vector<std::unique_ptr<const DexFile>> dex_files2 = OpenTestDexFiles("MultiDex");
1248
1249 std::string context = "PCL[" + GetTestDexFileName("Nested") + "]" +
1250 "{PCL[" + GetTestDexFileName("MultiDex") + "]" +
1251 "{PCL[" + GetTestDexFileName("Nested") + "]}}";
1252 std::string expected_classpath_key = "PCL[" + CreateClassPathWithChecksums(dex_files1) + "]" +
1253 "{PCL[" + CreateClassPathWithChecksums(dex_files2) + "]" +
1254 "{PCL[" + CreateClassPathWithChecksums(dex_files1) + "]}}";
1255 RunTest(context.c_str(),
1256 expected_classpath_key.c_str(),
1257 /*expected_success=*/ true,
1258 /*use_second_source=*/ false,
1259 /*generate_image=*/ true);
1260}
1261
Mathieu Chartier9e050df2017-08-09 10:05:47 -07001262class Dex2oatDeterminism : public Dex2oatTest {};
1263
1264TEST_F(Dex2oatDeterminism, UnloadCompile) {
1265 if (!kUseReadBarrier &&
1266 gc::kCollectorTypeDefault != gc::kCollectorTypeCMS &&
1267 gc::kCollectorTypeDefault != gc::kCollectorTypeMS) {
1268 LOG(INFO) << "Test requires determinism support.";
1269 return;
1270 }
1271 Runtime* const runtime = Runtime::Current();
1272 std::string out_dir = GetScratchDir();
1273 const std::string base_oat_name = out_dir + "/base.oat";
1274 const std::string base_vdex_name = out_dir + "/base.vdex";
1275 const std::string unload_oat_name = out_dir + "/unload.oat";
1276 const std::string unload_vdex_name = out_dir + "/unload.vdex";
1277 const std::string no_unload_oat_name = out_dir + "/nounload.oat";
1278 const std::string no_unload_vdex_name = out_dir + "/nounload.vdex";
1279 const std::string app_image_name = out_dir + "/unload.art";
1280 std::string error_msg;
1281 const std::vector<gc::space::ImageSpace*>& spaces = runtime->GetHeap()->GetBootImageSpaces();
1282 ASSERT_GT(spaces.size(), 0u);
1283 const std::string image_location = spaces[0]->GetImageLocation();
1284 // Without passing in an app image, it will unload in between compilations.
1285 const int res = GenerateOdexForTestWithStatus(
1286 GetLibCoreDexFileNames(),
1287 base_oat_name,
1288 CompilerFilter::Filter::kQuicken,
1289 &error_msg,
1290 {"--force-determinism", "--avoid-storing-invocation"});
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001291 ASSERT_EQ(res, 0);
Mathieu Chartier9e050df2017-08-09 10:05:47 -07001292 Copy(base_oat_name, unload_oat_name);
1293 Copy(base_vdex_name, unload_vdex_name);
1294 std::unique_ptr<File> unload_oat(OS::OpenFileForReading(unload_oat_name.c_str()));
1295 std::unique_ptr<File> unload_vdex(OS::OpenFileForReading(unload_vdex_name.c_str()));
1296 ASSERT_TRUE(unload_oat != nullptr);
1297 ASSERT_TRUE(unload_vdex != nullptr);
1298 EXPECT_GT(unload_oat->GetLength(), 0u);
1299 EXPECT_GT(unload_vdex->GetLength(), 0u);
1300 // Regenerate with an app image to disable the dex2oat unloading and verify that the output is
1301 // the same.
1302 const int res2 = GenerateOdexForTestWithStatus(
1303 GetLibCoreDexFileNames(),
1304 base_oat_name,
1305 CompilerFilter::Filter::kQuicken,
1306 &error_msg,
1307 {"--force-determinism", "--avoid-storing-invocation", "--app-image-file=" + app_image_name});
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001308 ASSERT_EQ(res2, 0);
Mathieu Chartier9e050df2017-08-09 10:05:47 -07001309 Copy(base_oat_name, no_unload_oat_name);
1310 Copy(base_vdex_name, no_unload_vdex_name);
1311 std::unique_ptr<File> no_unload_oat(OS::OpenFileForReading(no_unload_oat_name.c_str()));
1312 std::unique_ptr<File> no_unload_vdex(OS::OpenFileForReading(no_unload_vdex_name.c_str()));
1313 ASSERT_TRUE(no_unload_oat != nullptr);
1314 ASSERT_TRUE(no_unload_vdex != nullptr);
1315 EXPECT_GT(no_unload_oat->GetLength(), 0u);
1316 EXPECT_GT(no_unload_vdex->GetLength(), 0u);
1317 // Verify that both of the files are the same (odex and vdex).
1318 EXPECT_EQ(unload_oat->GetLength(), no_unload_oat->GetLength());
1319 EXPECT_EQ(unload_vdex->GetLength(), no_unload_vdex->GetLength());
1320 EXPECT_EQ(unload_oat->Compare(no_unload_oat.get()), 0)
1321 << unload_oat_name << " " << no_unload_oat_name;
1322 EXPECT_EQ(unload_vdex->Compare(no_unload_vdex.get()), 0)
1323 << unload_vdex_name << " " << no_unload_vdex_name;
1324 // App image file.
1325 std::unique_ptr<File> app_image_file(OS::OpenFileForReading(app_image_name.c_str()));
1326 ASSERT_TRUE(app_image_file != nullptr);
1327 EXPECT_GT(app_image_file->GetLength(), 0u);
1328}
1329
Mathieu Chartier120aa282017-08-05 16:03:03 -07001330// Test that dexlayout section info is correctly written to the oat file for profile based
1331// compilation.
1332TEST_F(Dex2oatTest, LayoutSections) {
1333 using Hotness = ProfileCompilationInfo::MethodHotness;
1334 std::unique_ptr<const DexFile> dex(OpenTestDexFile("ManyMethods"));
1335 ScratchFile profile_file;
1336 // We can only layout method indices with code items, figure out which ones have this property
1337 // first.
1338 std::vector<uint16_t> methods;
1339 {
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08001340 const dex::TypeId* type_id = dex->FindTypeId("LManyMethods;");
Mathieu Chartier120aa282017-08-05 16:03:03 -07001341 dex::TypeIndex type_idx = dex->GetIndexForTypeId(*type_id);
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001342 ClassAccessor accessor(*dex, *dex->FindClassDef(type_idx));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001343 std::set<size_t> code_item_offsets;
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001344 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1345 const uint16_t method_idx = method.GetIndex();
1346 const size_t code_item_offset = method.GetCodeItemOffset();
Mathieu Chartier120aa282017-08-05 16:03:03 -07001347 if (code_item_offsets.insert(code_item_offset).second) {
1348 // Unique code item, add the method index.
1349 methods.push_back(method_idx);
1350 }
1351 }
Mathieu Chartier120aa282017-08-05 16:03:03 -07001352 }
1353 ASSERT_GE(methods.size(), 8u);
1354 std::vector<uint16_t> hot_methods = {methods[1], methods[3], methods[5]};
1355 std::vector<uint16_t> startup_methods = {methods[1], methods[2], methods[7]};
1356 std::vector<uint16_t> post_methods = {methods[0], methods[2], methods[6]};
1357 // Here, we build the profile from the method lists.
1358 ProfileCompilationInfo info;
1359 info.AddMethodsForDex(
1360 static_cast<Hotness::Flag>(Hotness::kFlagHot | Hotness::kFlagStartup),
1361 dex.get(),
1362 hot_methods.begin(),
1363 hot_methods.end());
1364 info.AddMethodsForDex(
1365 Hotness::kFlagStartup,
1366 dex.get(),
1367 startup_methods.begin(),
1368 startup_methods.end());
1369 info.AddMethodsForDex(
1370 Hotness::kFlagPostStartup,
1371 dex.get(),
1372 post_methods.begin(),
1373 post_methods.end());
1374 for (uint16_t id : hot_methods) {
1375 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsHot());
1376 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsStartup());
1377 }
1378 for (uint16_t id : startup_methods) {
1379 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsStartup());
1380 }
1381 for (uint16_t id : post_methods) {
1382 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsPostStartup());
1383 }
1384 // Save the profile since we want to use it with dex2oat to produce an oat file.
1385 ASSERT_TRUE(info.Save(profile_file.GetFd()));
1386 // Generate a profile based odex.
1387 const std::string dir = GetScratchDir();
1388 const std::string oat_filename = dir + "/base.oat";
1389 const std::string vdex_filename = dir + "/base.vdex";
1390 std::string error_msg;
1391 const int res = GenerateOdexForTestWithStatus(
1392 {dex->GetLocation()},
1393 oat_filename,
1394 CompilerFilter::Filter::kQuicken,
1395 &error_msg,
1396 {"--profile-file=" + profile_file.GetFilename()});
1397 EXPECT_EQ(res, 0);
1398
1399 // Open our generated oat file.
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001400 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001401 oat_filename.c_str(),
Mathieu Chartier120aa282017-08-05 16:03:03 -07001402 oat_filename.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001403 /*executable=*/ false,
1404 /*low_4gb=*/ false,
Mathieu Chartier120aa282017-08-05 16:03:03 -07001405 dex->GetLocation().c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001406 /*reservation=*/ nullptr,
Mathieu Chartier120aa282017-08-05 16:03:03 -07001407 &error_msg));
1408 ASSERT_TRUE(odex_file != nullptr);
1409 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
1410 ASSERT_EQ(oat_dex_files.size(), 1u);
1411 // Check that the code sections match what we expect.
1412 for (const OatDexFile* oat_dex : oat_dex_files) {
1413 const DexLayoutSections* const sections = oat_dex->GetDexLayoutSections();
1414 // Testing of logging the sections.
1415 ASSERT_TRUE(sections != nullptr);
1416 LOG(INFO) << *sections;
1417
1418 // Load the sections into temporary variables for convenience.
1419 const DexLayoutSection& code_section =
1420 sections->sections_[static_cast<size_t>(DexLayoutSections::SectionType::kSectionTypeCode)];
1421 const DexLayoutSection::Subsection& section_hot_code =
1422 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeHot)];
1423 const DexLayoutSection::Subsection& section_sometimes_used =
1424 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeSometimesUsed)];
1425 const DexLayoutSection::Subsection& section_startup_only =
1426 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeStartupOnly)];
1427 const DexLayoutSection::Subsection& section_unused =
1428 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeUnused)];
1429
1430 // All the sections should be non-empty.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001431 EXPECT_GT(section_hot_code.Size(), 0u);
1432 EXPECT_GT(section_sometimes_used.Size(), 0u);
1433 EXPECT_GT(section_startup_only.Size(), 0u);
1434 EXPECT_GT(section_unused.Size(), 0u);
Mathieu Chartier120aa282017-08-05 16:03:03 -07001435
1436 // Open the dex file since we need to peek at the code items to verify the layout matches what
1437 // we expect.
1438 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1439 ASSERT_TRUE(dex_file != nullptr) << error_msg;
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08001440 const dex::TypeId* type_id = dex_file->FindTypeId("LManyMethods;");
Mathieu Chartier120aa282017-08-05 16:03:03 -07001441 ASSERT_TRUE(type_id != nullptr);
1442 dex::TypeIndex type_idx = dex_file->GetIndexForTypeId(*type_id);
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08001443 const dex::ClassDef* class_def = dex_file->FindClassDef(type_idx);
Mathieu Chartier120aa282017-08-05 16:03:03 -07001444 ASSERT_TRUE(class_def != nullptr);
1445
1446 // Count how many code items are for each category, there should be at least one per category.
1447 size_t hot_count = 0;
1448 size_t post_startup_count = 0;
1449 size_t startup_count = 0;
1450 size_t unused_count = 0;
1451 // Visit all of the methdos of the main class and cross reference the method indices to their
1452 // corresponding code item offsets to verify the layout.
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001453 ClassAccessor accessor(*dex_file, *class_def);
1454 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1455 const size_t method_idx = method.GetIndex();
1456 const size_t code_item_offset = method.GetCodeItemOffset();
Mathieu Chartier120aa282017-08-05 16:03:03 -07001457 const bool is_hot = ContainsElement(hot_methods, method_idx);
1458 const bool is_startup = ContainsElement(startup_methods, method_idx);
1459 const bool is_post_startup = ContainsElement(post_methods, method_idx);
1460 if (is_hot) {
1461 // Hot is highest precedence, check that the hot methods are in the hot section.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001462 EXPECT_TRUE(section_hot_code.Contains(code_item_offset));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001463 ++hot_count;
1464 } else if (is_post_startup) {
1465 // Post startup is sometimes used section.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001466 EXPECT_TRUE(section_sometimes_used.Contains(code_item_offset));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001467 ++post_startup_count;
1468 } else if (is_startup) {
1469 // Startup at this point means not hot or post startup, these must be startup only then.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001470 EXPECT_TRUE(section_startup_only.Contains(code_item_offset));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001471 ++startup_count;
1472 } else {
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001473 if (section_unused.Contains(code_item_offset)) {
Alan Leung9595fd32017-10-17 17:08:19 -07001474 // If no flags are set, the method should be unused ...
1475 ++unused_count;
1476 } else {
1477 // or this method is part of the last code item and the end is 4 byte aligned.
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001478 for (const ClassAccessor::Method& method2 : accessor.GetMethods()) {
1479 EXPECT_LE(method2.GetCodeItemOffset(), code_item_offset);
Alan Leung9595fd32017-10-17 17:08:19 -07001480 }
1481 uint32_t code_item_size = dex_file->FindCodeItemOffset(*class_def, method_idx);
1482 EXPECT_EQ((code_item_offset + code_item_size) % 4, 0u);
1483 }
Mathieu Chartier120aa282017-08-05 16:03:03 -07001484 }
1485 }
Mathieu Chartier120aa282017-08-05 16:03:03 -07001486 EXPECT_GT(hot_count, 0u);
1487 EXPECT_GT(post_startup_count, 0u);
1488 EXPECT_GT(startup_count, 0u);
1489 EXPECT_GT(unused_count, 0u);
1490 }
1491}
1492
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001493// Test that generating compact dex works.
1494TEST_F(Dex2oatTest, GenerateCompactDex) {
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001495 // Generate a compact dex based odex.
1496 const std::string dir = GetScratchDir();
1497 const std::string oat_filename = dir + "/base.oat";
1498 const std::string vdex_filename = dir + "/base.vdex";
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001499 const std::string dex_location = GetTestDexFileName("MultiDex");
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001500 std::string error_msg;
1501 const int res = GenerateOdexForTestWithStatus(
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001502 { dex_location },
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001503 oat_filename,
1504 CompilerFilter::Filter::kQuicken,
1505 &error_msg,
1506 {"--compact-dex-level=fast"});
1507 EXPECT_EQ(res, 0);
1508 // Open our generated oat file.
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001509 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001510 oat_filename.c_str(),
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001511 oat_filename.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001512 /*executable=*/ false,
1513 /*low_4gb=*/ false,
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001514 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001515 /*reservation=*/ nullptr,
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001516 &error_msg));
1517 ASSERT_TRUE(odex_file != nullptr);
1518 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001519 ASSERT_GT(oat_dex_files.size(), 1u);
1520 // Check that each dex is a compact dex file.
1521 std::vector<std::unique_ptr<const CompactDexFile>> compact_dex_files;
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001522 for (const OatDexFile* oat_dex : oat_dex_files) {
1523 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1524 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1525 ASSERT_TRUE(dex_file->IsCompactDexFile());
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001526 compact_dex_files.push_back(
1527 std::unique_ptr<const CompactDexFile>(dex_file.release()->AsCompactDexFile()));
1528 }
1529 for (const std::unique_ptr<const CompactDexFile>& dex_file : compact_dex_files) {
1530 // Test that every code item is in the owned section.
1531 const CompactDexFile::Header& header = dex_file->GetHeader();
1532 EXPECT_LE(header.OwnedDataBegin(), header.OwnedDataEnd());
1533 EXPECT_LE(header.OwnedDataBegin(), header.data_size_);
1534 EXPECT_LE(header.OwnedDataEnd(), header.data_size_);
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001535 for (ClassAccessor accessor : dex_file->GetClasses()) {
1536 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1537 if (method.GetCodeItemOffset() != 0u) {
1538 ASSERT_GE(method.GetCodeItemOffset(), header.OwnedDataBegin());
1539 ASSERT_LT(method.GetCodeItemOffset(), header.OwnedDataEnd());
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001540 }
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001541 }
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001542 }
1543 // Test that the owned sections don't overlap.
1544 for (const std::unique_ptr<const CompactDexFile>& other_dex : compact_dex_files) {
1545 if (dex_file != other_dex) {
1546 ASSERT_TRUE(
1547 (dex_file->GetHeader().OwnedDataBegin() >= other_dex->GetHeader().OwnedDataEnd()) ||
1548 (dex_file->GetHeader().OwnedDataEnd() <= other_dex->GetHeader().OwnedDataBegin()));
1549 }
1550 }
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001551 }
1552}
1553
Andreas Gampef39208f2017-10-19 15:06:59 -07001554class Dex2oatVerifierAbort : public Dex2oatTest {};
1555
1556TEST_F(Dex2oatVerifierAbort, HardFail) {
1557 // Use VerifierDeps as it has hard-failing classes.
1558 std::unique_ptr<const DexFile> dex(OpenTestDexFile("VerifierDeps"));
1559 std::string out_dir = GetScratchDir();
1560 const std::string base_oat_name = out_dir + "/base.oat";
1561 std::string error_msg;
1562 const int res_fail = GenerateOdexForTestWithStatus(
1563 {dex->GetLocation()},
1564 base_oat_name,
1565 CompilerFilter::Filter::kQuicken,
1566 &error_msg,
1567 {"--abort-on-hard-verifier-error"});
1568 EXPECT_NE(0, res_fail);
1569
1570 const int res_no_fail = GenerateOdexForTestWithStatus(
1571 {dex->GetLocation()},
1572 base_oat_name,
1573 CompilerFilter::Filter::kQuicken,
1574 &error_msg,
1575 {"--no-abort-on-hard-verifier-error"});
1576 EXPECT_EQ(0, res_no_fail);
1577}
1578
1579TEST_F(Dex2oatVerifierAbort, SoftFail) {
1580 // Use VerifierDepsMulti as it has hard-failing classes.
1581 std::unique_ptr<const DexFile> dex(OpenTestDexFile("VerifierDepsMulti"));
1582 std::string out_dir = GetScratchDir();
1583 const std::string base_oat_name = out_dir + "/base.oat";
1584 std::string error_msg;
1585 const int res_fail = GenerateOdexForTestWithStatus(
1586 {dex->GetLocation()},
1587 base_oat_name,
1588 CompilerFilter::Filter::kQuicken,
1589 &error_msg,
1590 {"--abort-on-soft-verifier-error"});
1591 EXPECT_NE(0, res_fail);
1592
1593 const int res_no_fail = GenerateOdexForTestWithStatus(
1594 {dex->GetLocation()},
1595 base_oat_name,
1596 CompilerFilter::Filter::kQuicken,
1597 &error_msg,
1598 {"--no-abort-on-soft-verifier-error"});
1599 EXPECT_EQ(0, res_no_fail);
1600}
1601
Andreas Gampecac31ad2017-11-06 20:01:17 -08001602class Dex2oatDedupeCode : public Dex2oatTest {};
1603
1604TEST_F(Dex2oatDedupeCode, DedupeTest) {
1605 // Use MyClassNatives. It has lots of native methods that will produce deduplicate-able code.
1606 std::unique_ptr<const DexFile> dex(OpenTestDexFile("MyClassNatives"));
1607 std::string out_dir = GetScratchDir();
1608 const std::string base_oat_name = out_dir + "/base.oat";
1609 size_t no_dedupe_size = 0;
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001610 ASSERT_TRUE(GenerateOdexForTest(dex->GetLocation(),
1611 base_oat_name,
1612 CompilerFilter::Filter::kSpeed,
1613 { "--deduplicate-code=false" },
1614 true, // expect_success
1615 false, // use_fd
1616 [&no_dedupe_size](const OatFile& o) {
1617 no_dedupe_size = o.Size();
1618 }));
Andreas Gampecac31ad2017-11-06 20:01:17 -08001619
1620 size_t dedupe_size = 0;
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001621 ASSERT_TRUE(GenerateOdexForTest(dex->GetLocation(),
1622 base_oat_name,
1623 CompilerFilter::Filter::kSpeed,
1624 { "--deduplicate-code=true" },
1625 true, // expect_success
1626 false, // use_fd
1627 [&dedupe_size](const OatFile& o) {
1628 dedupe_size = o.Size();
1629 }));
Andreas Gampecac31ad2017-11-06 20:01:17 -08001630
1631 EXPECT_LT(dedupe_size, no_dedupe_size);
1632}
1633
Nicolas Geoffrayf3075272018-01-08 12:41:19 +00001634TEST_F(Dex2oatTest, UncompressedTest) {
1635 std::unique_ptr<const DexFile> dex(OpenTestDexFile("MainUncompressed"));
1636 std::string out_dir = GetScratchDir();
1637 const std::string base_oat_name = out_dir + "/base.oat";
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001638 ASSERT_TRUE(GenerateOdexForTest(dex->GetLocation(),
1639 base_oat_name,
1640 CompilerFilter::Filter::kQuicken,
1641 { },
1642 true, // expect_success
1643 false, // use_fd
1644 [](const OatFile& o) {
1645 CHECK(!o.ContainsDexCode());
1646 }));
Nicolas Geoffrayf3075272018-01-08 12:41:19 +00001647}
1648
Mathieu Chartier700a9852018-02-06 18:27:38 -08001649TEST_F(Dex2oatTest, EmptyUncompressedDexTest) {
1650 std::string out_dir = GetScratchDir();
1651 const std::string base_oat_name = out_dir + "/base.oat";
1652 std::string error_msg;
1653 int status = GenerateOdexForTestWithStatus(
1654 { GetTestDexFileName("MainEmptyUncompressed") },
1655 base_oat_name,
1656 CompilerFilter::Filter::kQuicken,
1657 &error_msg,
1658 { },
1659 /*use_fd*/ false);
1660 // Expect to fail with code 1 and not SIGSEGV or SIGABRT.
1661 ASSERT_TRUE(WIFEXITED(status));
1662 ASSERT_EQ(WEXITSTATUS(status), 1) << error_msg;
1663}
1664
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001665// Dex file that has duplicate methods have different code items and debug info.
1666static const char kDuplicateMethodInputDex[] =
1667 "ZGV4CjAzOQDEy8VPdj4qHpgPYFWtLCtOykfFP4kB8tGYDAAAcAAAAHhWNBIAAAAAAAAAANALAABI"
1668 "AAAAcAAAAA4AAACQAQAABQAAAMgBAAANAAAABAIAABkAAABsAgAABAAAADQDAADgCAAAuAMAADgI"
1669 "AABCCAAASggAAE8IAABcCAAAaggAAHkIAACICAAAlggAAKQIAACyCAAAwAgAAM4IAADcCAAA6ggA"
1670 "APgIAAD7CAAA/wgAABcJAAAuCQAARQkAAFQJAAB4CQAAmAkAALsJAADSCQAA5gkAAPoJAAAVCgAA"
1671 "KQoAADsKAABCCgAASgoAAFIKAABbCgAAZAoAAGwKAAB0CgAAfAoAAIQKAACMCgAAlAoAAJwKAACk"
1672 "CgAArQoAALcKAADACgAAwwoAAMcKAADcCgAA6QoAAPEKAAD3CgAA/QoAAAMLAAAJCwAAEAsAABcL"
1673 "AAAdCwAAIwsAACkLAAAvCwAANQsAADsLAABBCwAARwsAAE0LAABSCwAAWwsAAF4LAABoCwAAbwsA"
1674 "ABEAAAASAAAAEwAAABQAAAAVAAAAFgAAABcAAAAYAAAAGQAAABoAAAAbAAAAHAAAAC4AAAAwAAAA"
1675 "DwAAAAkAAAAAAAAAEAAAAAoAAACoBwAALgAAAAwAAAAAAAAALwAAAAwAAACoBwAALwAAAAwAAACw"
1676 "BwAAAgAJADUAAAACAAkANgAAAAIACQA3AAAAAgAJADgAAAACAAkAOQAAAAIACQA6AAAAAgAJADsA"
1677 "AAACAAkAPAAAAAIACQA9AAAAAgAJAD4AAAACAAkAPwAAAAIACQBAAAAACwAHAEIAAAAAAAIAAQAA"
1678 "AAAAAwAeAAAAAQACAAEAAAABAAMAHgAAAAIAAgAAAAAAAgACAAEAAAADAAIAAQAAAAMAAgAfAAAA"
1679 "AwACACAAAAADAAIAIQAAAAMAAgAiAAAAAwACACMAAAADAAIAJAAAAAMAAgAlAAAAAwACACYAAAAD"
1680 "AAIAJwAAAAMAAgAoAAAAAwACACkAAAADAAIAKgAAAAMABAA0AAAABwADAEMAAAAIAAIAAQAAAAoA"
1681 "AgABAAAACgABADIAAAAKAAAARQAAAAAAAAAAAAAACAAAAAAAAAAdAAAAaAcAALYHAAAAAAAAAQAA"
1682 "AAAAAAAIAAAAAAAAAB0AAAB4BwAAxAcAAAAAAAACAAAAAAAAAAgAAAAAAAAAHQAAAIgHAADSBwAA"
1683 "AAAAAAMAAAAAAAAACAAAAAAAAAAdAAAAmAcAAPoHAAAAAAAAAAAAAAEAAAAAAAAArAYAADEAAAAa"
1684 "AAMAaQAAABoABABpAAEAGgAHAGkABAAaAAgAaQAFABoACQBpAAYAGgAKAGkABwAaAAsAaQAIABoA"
1685 "DABpAAkAGgANAGkACgAaAA4AaQALABoABQBpAAIAGgAGAGkAAwAOAAAAAQABAAEAAACSBgAABAAA"
1686 "AHAQFQAAAA4ABAABAAIAAACWBgAAFwAAAGIADAAiAQoAcBAWAAEAGgICAG4gFwAhAG4gFwAxAG4Q"
1687 "GAABAAwBbiAUABAADgAAAAEAAQABAAAAngYAAAQAAABwEBUAAAAOAAIAAQACAAAAogYAAAYAAABi"
1688 "AAwAbiAUABAADgABAAEAAQAAAKgGAAAEAAAAcBAVAAAADgABAAEAAQAAALsGAAAEAAAAcBAVAAAA"
1689 "DgABAAAAAQAAAL8GAAAGAAAAYgAAAHEQAwAAAA4AAQAAAAEAAADEBgAABgAAAGIAAQBxEAMAAAAO"
1690 "AAEAAAABAAAA8QYAAAYAAABiAAIAcRABAAAADgABAAAAAQAAAPYGAAAGAAAAYgADAHEQAwAAAA4A"
1691 "AQAAAAEAAADJBgAABgAAAGIABABxEAMAAAAOAAEAAAABAAAAzgYAAAYAAABiAAEAcRADAAAADgAB"
1692 "AAAAAQAAANMGAAAGAAAAYgAGAHEQAwAAAA4AAQAAAAEAAADYBgAABgAAAGIABwBxEAMAAAAOAAEA"
1693 "AAABAAAA3QYAAAYAAABiAAgAcRABAAAADgABAAAAAQAAAOIGAAAGAAAAYgAJAHEQAwAAAA4AAQAA"
1694 "AAEAAADnBgAABgAAAGIACgBxEAMAAAAOAAEAAAABAAAA7AYAAAYAAABiAAsAcRABAAAADgABAAEA"
1695 "AAAAAPsGAAAlAAAAcQAHAAAAcQAIAAAAcQALAAAAcQAMAAAAcQANAAAAcQAOAAAAcQAPAAAAcQAQ"
1696 "AAAAcQARAAAAcQASAAAAcQAJAAAAcQAKAAAADgAnAA4AKQFFDgEWDwAhAA4AIwFFDloAEgAOABMA"
1697 "DktLS0tLS0tLS0tLABEADgAuAA5aADIADloANgAOWgA6AA5aAD4ADloAQgAOWgBGAA5aAEoADloA"
1698 "TgAOWgBSAA5aAFYADloAWgAOWgBeATQOPDw8PDw8PDw8PDw8AAIEAUYYAwIFAjEECEEXLAIFAjEE"
1699 "CEEXKwIFAjEECEEXLQIGAUYcAxgAGAEYAgAAAAIAAAAMBwAAEgcAAAIAAAAMBwAAGwcAAAIAAAAM"
1700 "BwAAJAcAAAEAAAAtBwAAPAcAAAAAAAAAAAAAAAAAAEgHAAAAAAAAAAAAAAAAAABUBwAAAAAAAAAA"
1701 "AAAAAAAAYAcAAAAAAAAAAAAAAAAAAAEAAAAJAAAAAQAAAA0AAAACAACAgASsCAEIxAgAAAIAAoCA"
1702 "BIQJAQicCQwAAgAACQEJAQkBCQEJAQkBCQEJAQkBCQEJAQkEiIAEuAcBgIAEuAkAAA4ABoCABNAJ"
1703 "AQnoCQAJhAoACaAKAAm8CgAJ2AoACfQKAAmQCwAJrAsACcgLAAnkCwAJgAwACZwMAAm4DAg8Y2xp"
1704 "bml0PgAGPGluaXQ+AANBQUEAC0hlbGxvIFdvcmxkAAxIZWxsbyBXb3JsZDEADUhlbGxvIFdvcmxk"
1705 "MTAADUhlbGxvIFdvcmxkMTEADEhlbGxvIFdvcmxkMgAMSGVsbG8gV29ybGQzAAxIZWxsbyBXb3Js"
1706 "ZDQADEhlbGxvIFdvcmxkNQAMSGVsbG8gV29ybGQ2AAxIZWxsbyBXb3JsZDcADEhlbGxvIFdvcmxk"
1707 "OAAMSGVsbG8gV29ybGQ5AAFMAAJMTAAWTE1hbnlNZXRob2RzJFByaW50ZXIyOwAVTE1hbnlNZXRo"
1708 "b2RzJFByaW50ZXI7ABVMTWFueU1ldGhvZHMkU3RyaW5nczsADUxNYW55TWV0aG9kczsAIkxkYWx2"
1709 "aWsvYW5ub3RhdGlvbi9FbmNsb3NpbmdDbGFzczsAHkxkYWx2aWsvYW5ub3RhdGlvbi9Jbm5lckNs"
1710 "YXNzOwAhTGRhbHZpay9hbm5vdGF0aW9uL01lbWJlckNsYXNzZXM7ABVMamF2YS9pby9QcmludFN0"
1711 "cmVhbTsAEkxqYXZhL2xhbmcvT2JqZWN0OwASTGphdmEvbGFuZy9TdHJpbmc7ABlMamF2YS9sYW5n"
1712 "L1N0cmluZ0J1aWxkZXI7ABJMamF2YS9sYW5nL1N5c3RlbTsAEE1hbnlNZXRob2RzLmphdmEABVBy"
1713 "aW50AAZQcmludDAABlByaW50MQAHUHJpbnQxMAAHUHJpbnQxMQAGUHJpbnQyAAZQcmludDMABlBy"
1714 "aW50NAAGUHJpbnQ1AAZQcmludDYABlByaW50NwAGUHJpbnQ4AAZQcmludDkAB1ByaW50ZXIACFBy"
1715 "aW50ZXIyAAdTdHJpbmdzAAFWAAJWTAATW0xqYXZhL2xhbmcvU3RyaW5nOwALYWNjZXNzRmxhZ3MA"
1716 "BmFwcGVuZAAEYXJncwAEbWFpbgAEbXNnMAAEbXNnMQAFbXNnMTAABW1zZzExAARtc2cyAARtc2cz"
1717 "AARtc2c0AARtc2c1AARtc2c2AARtc2c3AARtc2c4AARtc2c5AARuYW1lAANvdXQAB3ByaW50bG4A"
1718 "AXMACHRvU3RyaW5nAAV2YWx1ZQBffn5EOHsibWluLWFwaSI6MTAwMDAsInNoYS0xIjoiZmViODZj"
1719 "MDA2ZWZhY2YxZDc5ODRiODVlMTc5MGZlZjdhNzY3YWViYyIsInZlcnNpb24iOiJ2MS4xLjUtZGV2"
1720 "In0AEAAAAAAAAAABAAAAAAAAAAEAAABIAAAAcAAAAAIAAAAOAAAAkAEAAAMAAAAFAAAAyAEAAAQA"
1721 "AAANAAAABAIAAAUAAAAZAAAAbAIAAAYAAAAEAAAANAMAAAEgAAAUAAAAuAMAAAMgAAAUAAAAkgYA"
1722 "AAQgAAAFAAAADAcAAAMQAAAEAAAAOQcAAAYgAAAEAAAAaAcAAAEQAAACAAAAqAcAAAAgAAAEAAAA"
1723 "tgcAAAIgAABIAAAAOAgAAAAQAAABAAAA0AsAAAAAAAA=";
1724
1725static void WriteBase64ToFile(const char* base64, File* file) {
1726 // Decode base64.
1727 CHECK(base64 != nullptr);
1728 size_t length;
1729 std::unique_ptr<uint8_t[]> bytes(DecodeBase64(base64, &length));
1730 CHECK(bytes != nullptr);
1731 if (!file->WriteFully(bytes.get(), length)) {
1732 PLOG(FATAL) << "Failed to write base64 as file";
1733 }
1734}
1735
1736TEST_F(Dex2oatTest, CompactDexGenerationFailure) {
1737 ScratchFile temp_dex;
1738 WriteBase64ToFile(kDuplicateMethodInputDex, temp_dex.GetFile());
1739 std::string out_dir = GetScratchDir();
1740 const std::string oat_filename = out_dir + "/base.oat";
1741 // The dex won't pass the method verifier, only use the verify filter.
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001742 ASSERT_TRUE(GenerateOdexForTest(temp_dex.GetFilename(),
1743 oat_filename,
1744 CompilerFilter::Filter::kVerify,
1745 { },
1746 true, // expect_success
1747 false, // use_fd
1748 [](const OatFile& o) {
1749 CHECK(o.ContainsDexCode());
1750 }));
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001751 // Open our generated oat file.
1752 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001753 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001754 oat_filename.c_str(),
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001755 oat_filename.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001756 /*executable=*/ false,
1757 /*low_4gb=*/ false,
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001758 temp_dex.GetFilename().c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001759 /*reservation=*/ nullptr,
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001760 &error_msg));
1761 ASSERT_TRUE(odex_file != nullptr);
1762 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
1763 ASSERT_EQ(oat_dex_files.size(), 1u);
1764 // The dexes should have failed to convert to compact dex.
1765 for (const OatDexFile* oat_dex : oat_dex_files) {
1766 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1767 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1768 ASSERT_TRUE(!dex_file->IsCompactDexFile());
1769 }
1770}
1771
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001772TEST_F(Dex2oatTest, CompactDexGenerationFailureMultiDex) {
1773 // Create a multidex file with only one dex that gets rejected for cdex conversion.
1774 ScratchFile apk_file;
1775 {
Andreas Gampedfcd82c2018-10-16 20:22:37 -07001776 FILE* file = fdopen(DupCloexec(apk_file.GetFd()), "w+b");
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001777 ZipWriter writer(file);
1778 // Add vdex to zip.
1779 writer.StartEntry("classes.dex", ZipWriter::kCompress);
1780 size_t length = 0u;
1781 std::unique_ptr<uint8_t[]> bytes(DecodeBase64(kDuplicateMethodInputDex, &length));
1782 ASSERT_GE(writer.WriteBytes(&bytes[0], length), 0);
1783 writer.FinishEntry();
1784 writer.StartEntry("classes2.dex", ZipWriter::kCompress);
1785 std::unique_ptr<const DexFile> dex(OpenTestDexFile("ManyMethods"));
1786 ASSERT_GE(writer.WriteBytes(dex->Begin(), dex->Size()), 0);
1787 writer.FinishEntry();
1788 writer.Finish();
1789 ASSERT_EQ(apk_file.GetFile()->Flush(), 0);
1790 }
Andreas Gampebc802de2018-06-20 17:24:11 -07001791 const std::string& dex_location = apk_file.GetFilename();
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001792 const std::string odex_location = GetOdexDir() + "/output.odex";
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001793 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1794 odex_location,
1795 CompilerFilter::kQuicken,
1796 { "--compact-dex-level=fast" },
1797 true));
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001798}
1799
Andreas Gampe25419b52018-02-08 21:30:26 -08001800TEST_F(Dex2oatTest, StderrLoggerOutput) {
1801 std::string dex_location = GetScratchDir() + "/Dex2OatStderrLoggerTest.jar";
1802 std::string odex_location = GetOdexDir() + "/Dex2OatStderrLoggerTest.odex";
1803
1804 // Test file doesn't matter.
1805 Copy(GetDexSrc1(), dex_location);
1806
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001807 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1808 odex_location,
1809 CompilerFilter::kQuicken,
1810 { "--runtime-arg", "-Xuse-stderr-logger" },
1811 true));
Andreas Gampe25419b52018-02-08 21:30:26 -08001812 // Look for some random part of dex2oat logging. With the stderr logger this should be captured,
1813 // even on device.
1814 EXPECT_NE(std::string::npos, output_.find("dex2oat took"));
1815}
1816
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001817TEST_F(Dex2oatTest, VerifyCompilationReason) {
1818 std::string dex_location = GetScratchDir() + "/Dex2OatCompilationReason.jar";
1819 std::string odex_location = GetOdexDir() + "/Dex2OatCompilationReason.odex";
1820
1821 // Test file doesn't matter.
1822 Copy(GetDexSrc1(), dex_location);
1823
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001824 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1825 odex_location,
1826 CompilerFilter::kVerify,
1827 { "--compilation-reason=install" },
1828 true));
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001829 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001830 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001831 odex_location.c_str(),
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001832 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001833 /*executable=*/ false,
1834 /*low_4gb=*/ false,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001835 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001836 /*reservation=*/ nullptr,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001837 &error_msg));
1838 ASSERT_TRUE(odex_file != nullptr);
1839 ASSERT_STREQ("install", odex_file->GetCompilationReason());
1840}
1841
1842TEST_F(Dex2oatTest, VerifyNoCompilationReason) {
1843 std::string dex_location = GetScratchDir() + "/Dex2OatNoCompilationReason.jar";
1844 std::string odex_location = GetOdexDir() + "/Dex2OatNoCompilationReason.odex";
1845
1846 // Test file doesn't matter.
1847 Copy(GetDexSrc1(), dex_location);
1848
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001849 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1850 odex_location,
1851 CompilerFilter::kVerify,
1852 {},
1853 true));
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001854 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001855 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001856 odex_location.c_str(),
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001857 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001858 /*executable=*/ false,
1859 /*low_4gb=*/ false,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001860 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001861 /*reservation=*/ nullptr,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001862 &error_msg));
1863 ASSERT_TRUE(odex_file != nullptr);
1864 ASSERT_EQ(nullptr, odex_file->GetCompilationReason());
1865}
1866
Mathieu Chartier792111c2018-02-15 13:02:15 -08001867TEST_F(Dex2oatTest, DontExtract) {
1868 std::unique_ptr<const DexFile> dex(OpenTestDexFile("ManyMethods"));
1869 std::string error_msg;
1870 const std::string out_dir = GetScratchDir();
1871 const std::string dex_location = dex->GetLocation();
1872 const std::string odex_location = out_dir + "/base.oat";
1873 const std::string vdex_location = out_dir + "/base.vdex";
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001874 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1875 odex_location,
1876 CompilerFilter::Filter::kVerify,
1877 { "--copy-dex-files=false" },
1878 true, // expect_success
1879 false, // use_fd
1880 [](const OatFile&) {}));
Mathieu Chartier792111c2018-02-15 13:02:15 -08001881 {
1882 // Check the vdex doesn't have dex.
1883 std::unique_ptr<VdexFile> vdex(VdexFile::Open(vdex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001884 /*writable=*/ false,
1885 /*low_4gb=*/ false,
1886 /*unquicken=*/ false,
Mathieu Chartier792111c2018-02-15 13:02:15 -08001887 &error_msg));
1888 ASSERT_TRUE(vdex != nullptr);
Nicolas Geoffray3a293552018-03-02 10:52:16 +00001889 EXPECT_FALSE(vdex->HasDexSection()) << output_;
Mathieu Chartier792111c2018-02-15 13:02:15 -08001890 }
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001891 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001892 odex_location.c_str(),
Mathieu Chartier792111c2018-02-15 13:02:15 -08001893 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001894 /*executable=*/ false,
1895 /*low_4gb=*/ false,
Mathieu Chartier792111c2018-02-15 13:02:15 -08001896 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001897 /*reservation=*/ nullptr,
Mathieu Chartier792111c2018-02-15 13:02:15 -08001898 &error_msg));
1899 ASSERT_TRUE(odex_file != nullptr) << dex_location;
1900 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
1901 ASSERT_EQ(oat_dex_files.size(), 1u);
1902 // Verify that the oat file can still open the dex files.
1903 for (const OatDexFile* oat_dex : oat_dex_files) {
1904 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1905 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1906 }
1907 // Create a dm file and use it to verify.
1908 // Add produced artifacts to a zip file that doesn't contain the classes.dex.
1909 ScratchFile dm_file;
1910 {
1911 std::unique_ptr<File> vdex_file(OS::OpenFileForReading(vdex_location.c_str()));
1912 ASSERT_TRUE(vdex_file != nullptr);
1913 ASSERT_GT(vdex_file->GetLength(), 0u);
Andreas Gampedfcd82c2018-10-16 20:22:37 -07001914 FILE* file = fdopen(DupCloexec(dm_file.GetFd()), "w+b");
Mathieu Chartier792111c2018-02-15 13:02:15 -08001915 ZipWriter writer(file);
1916 auto write_all_bytes = [&](File* file) {
1917 std::unique_ptr<uint8_t[]> bytes(new uint8_t[file->GetLength()]);
1918 ASSERT_TRUE(file->ReadFully(&bytes[0], file->GetLength()));
1919 ASSERT_GE(writer.WriteBytes(&bytes[0], file->GetLength()), 0);
1920 };
1921 // Add vdex to zip.
1922 writer.StartEntry(VdexFile::kVdexNameInDmFile, ZipWriter::kCompress);
1923 write_all_bytes(vdex_file.get());
1924 writer.FinishEntry();
1925 writer.Finish();
1926 ASSERT_EQ(dm_file.GetFile()->Flush(), 0);
1927 }
1928
Mathieu Chartier2eabc612018-05-25 14:31:16 -07001929 auto generate_and_check = [&](CompilerFilter::Filter filter) {
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001930 output_.clear();
1931 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1932 odex_location,
1933 filter,
1934 { "--dump-timings",
1935 "--dm-file=" + dm_file.GetFilename(),
1936 // Pass -Xuse-stderr-logger have dex2oat output in output_ on
1937 // target.
1938 "--runtime-arg",
1939 "-Xuse-stderr-logger" },
1940 true, // expect_success
1941 false, // use_fd
1942 [](const OatFile& o) {
1943 CHECK(o.ContainsDexCode());
1944 }));
Mathieu Chartier2eabc612018-05-25 14:31:16 -07001945 // Check the output for "Fast verify", this is printed from --dump-timings.
1946 std::istringstream iss(output_);
1947 std::string line;
1948 bool found_fast_verify = false;
1949 const std::string kFastVerifyString = "Fast Verify";
1950 while (std::getline(iss, line) && !found_fast_verify) {
1951 found_fast_verify = found_fast_verify || line.find(kFastVerifyString) != std::string::npos;
1952 }
1953 EXPECT_TRUE(found_fast_verify) << "Expected to find " << kFastVerifyString << "\n" << output_;
1954 };
1955
Mathieu Chartier792111c2018-02-15 13:02:15 -08001956 // Generate a quickened dex by using the input dm file to verify.
Mathieu Chartier2eabc612018-05-25 14:31:16 -07001957 generate_and_check(CompilerFilter::Filter::kQuicken);
1958 // Use verify compiler filter to sanity check that FastVerify works for that filter too.
1959 generate_and_check(CompilerFilter::Filter::kVerify);
Mathieu Chartier792111c2018-02-15 13:02:15 -08001960}
1961
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001962// Test that dex files with quickened opcodes aren't dequickened.
1963TEST_F(Dex2oatTest, QuickenedInput) {
1964 std::string error_msg;
1965 ScratchFile temp_dex;
1966 MutateDexFile(temp_dex.GetFile(), GetTestDexFileName("ManyMethods"), [] (DexFile* dex) {
1967 bool mutated_successfully = false;
1968 // Change the dex instructions to make an opcode that spans past the end of the code item.
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001969 for (ClassAccessor accessor : dex->GetClasses()) {
1970 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1971 CodeItemInstructionAccessor instructions = method.GetInstructions();
1972 // Make a quickened instruction that doesn't run past the end of the code item.
1973 if (instructions.InsnsSizeInCodeUnits() > 2) {
1974 const_cast<Instruction&>(instructions.InstructionAt(0)).SetOpcode(
1975 Instruction::IGET_BYTE_QUICK);
1976 mutated_successfully = true;
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001977 }
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001978 }
1979 }
1980 CHECK(mutated_successfully)
1981 << "Failed to find candidate code item with only one code unit in last instruction.";
1982 });
1983
Andreas Gampebc802de2018-06-20 17:24:11 -07001984 const std::string& dex_location = temp_dex.GetFilename();
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001985 std::string odex_location = GetOdexDir() + "/quickened.odex";
1986 std::string vdex_location = GetOdexDir() + "/quickened.vdex";
1987 std::unique_ptr<File> vdex_output(OS::CreateEmptyFile(vdex_location.c_str()));
1988 // Quicken the dex
1989 {
1990 std::string input_vdex = "--input-vdex-fd=-1";
1991 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_output->Fd());
Andreas Gampe50f9dc22018-11-05 10:29:43 -08001992 ASSERT_TRUE(GenerateOdexForTest(dex_location,
1993 odex_location,
1994 CompilerFilter::kQuicken,
1995 // Disable cdex since we want to compare against the original
1996 // dex file after unquickening.
1997 { input_vdex, output_vdex, kDisableCompactDex },
1998 /* expect_success= */ true,
1999 /* use_fd= */ true));
Mathieu Chartier2daa1342018-02-20 16:19:28 -08002000 }
2001 // Unquicken by running the verify compiler filter on the vdex file and verify it matches.
2002 std::string odex_location2 = GetOdexDir() + "/unquickened.odex";
2003 std::string vdex_location2 = GetOdexDir() + "/unquickened.vdex";
2004 std::unique_ptr<File> vdex_unquickened(OS::CreateEmptyFile(vdex_location2.c_str()));
2005 {
2006 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_output->Fd());
2007 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_unquickened->Fd());
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002008 ASSERT_TRUE(GenerateOdexForTest(dex_location,
2009 odex_location2,
2010 CompilerFilter::kVerify,
2011 // Disable cdex to avoid needing to write out the shared
2012 // section.
2013 { input_vdex, output_vdex, kDisableCompactDex },
2014 /* expect_success= */ true,
2015 /* use_fd= */ true));
Mathieu Chartier2daa1342018-02-20 16:19:28 -08002016 }
2017 ASSERT_EQ(vdex_unquickened->Flush(), 0) << "Could not flush and close vdex file";
2018 ASSERT_TRUE(success_);
2019 {
2020 // Check that hte vdex has one dex and compare it to the original one.
2021 std::unique_ptr<VdexFile> vdex(VdexFile::Open(vdex_location2.c_str(),
2022 /*writable*/ false,
2023 /*low_4gb*/ false,
2024 /*unquicken*/ false,
2025 &error_msg));
2026 std::vector<std::unique_ptr<const DexFile>> dex_files;
2027 bool result = vdex->OpenAllDexFiles(&dex_files, &error_msg);
2028 ASSERT_TRUE(result) << error_msg;
2029 ASSERT_EQ(dex_files.size(), 1u) << error_msg;
2030 ScratchFile temp;
2031 ASSERT_TRUE(temp.GetFile()->WriteFully(dex_files[0]->Begin(), dex_files[0]->Size()));
2032 ASSERT_EQ(temp.GetFile()->Flush(), 0) << "Could not flush extracted dex";
2033 EXPECT_EQ(temp.GetFile()->Compare(temp_dex.GetFile()), 0);
2034 }
2035 ASSERT_EQ(vdex_output->FlushCloseOrErase(), 0) << "Could not flush and close";
2036 ASSERT_EQ(vdex_unquickened->FlushCloseOrErase(), 0) << "Could not flush and close";
2037}
2038
Mathieu Chartierd45863a2018-03-21 18:16:36 -07002039// Test that compact dex generation with invalid dex files doesn't crash dex2oat. b/75970654
2040TEST_F(Dex2oatTest, CompactDexInvalidSource) {
2041 ScratchFile invalid_dex;
2042 {
Andreas Gampedfcd82c2018-10-16 20:22:37 -07002043 FILE* file = fdopen(DupCloexec(invalid_dex.GetFd()), "w+b");
Mathieu Chartierd45863a2018-03-21 18:16:36 -07002044 ZipWriter writer(file);
2045 writer.StartEntry("classes.dex", ZipWriter::kAlign32);
2046 DexFile::Header header = {};
2047 StandardDexFile::WriteMagic(header.magic_);
2048 StandardDexFile::WriteCurrentVersion(header.magic_);
2049 header.file_size_ = 4 * KB;
2050 header.data_size_ = 4 * KB;
2051 header.data_off_ = 10 * MB;
2052 header.map_off_ = 10 * MB;
2053 header.class_defs_off_ = 10 * MB;
2054 header.class_defs_size_ = 10000;
2055 ASSERT_GE(writer.WriteBytes(&header, sizeof(header)), 0);
2056 writer.FinishEntry();
2057 writer.Finish();
2058 ASSERT_EQ(invalid_dex.GetFile()->Flush(), 0);
2059 }
Andreas Gampebc802de2018-06-20 17:24:11 -07002060 const std::string& dex_location = invalid_dex.GetFilename();
Mathieu Chartierd45863a2018-03-21 18:16:36 -07002061 const std::string odex_location = GetOdexDir() + "/output.odex";
2062 std::string error_msg;
2063 int status = GenerateOdexForTestWithStatus(
2064 {dex_location},
2065 odex_location,
2066 CompilerFilter::kQuicken,
2067 &error_msg,
2068 { "--compact-dex-level=fast" });
2069 ASSERT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) != 0) << status << " " << output_;
2070}
2071
Mathieu Chartier14e7bad2018-03-22 14:33:20 -07002072// Test that dex2oat with a CompactDex file in the APK fails.
2073TEST_F(Dex2oatTest, CompactDexInZip) {
2074 CompactDexFile::Header header = {};
2075 CompactDexFile::WriteMagic(header.magic_);
2076 CompactDexFile::WriteCurrentVersion(header.magic_);
2077 header.file_size_ = sizeof(CompactDexFile::Header);
2078 header.data_off_ = 10 * MB;
2079 header.map_off_ = 10 * MB;
2080 header.class_defs_off_ = 10 * MB;
2081 header.class_defs_size_ = 10000;
2082 // Create a zip containing the invalid dex.
2083 ScratchFile invalid_dex_zip;
2084 {
Andreas Gampedfcd82c2018-10-16 20:22:37 -07002085 FILE* file = fdopen(DupCloexec(invalid_dex_zip.GetFd()), "w+b");
Mathieu Chartier14e7bad2018-03-22 14:33:20 -07002086 ZipWriter writer(file);
2087 writer.StartEntry("classes.dex", ZipWriter::kCompress);
2088 ASSERT_GE(writer.WriteBytes(&header, sizeof(header)), 0);
2089 writer.FinishEntry();
2090 writer.Finish();
2091 ASSERT_EQ(invalid_dex_zip.GetFile()->Flush(), 0);
2092 }
2093 // Create the dex file directly.
2094 ScratchFile invalid_dex;
2095 {
2096 ASSERT_GE(invalid_dex.GetFile()->WriteFully(&header, sizeof(header)), 0);
2097 ASSERT_EQ(invalid_dex.GetFile()->Flush(), 0);
2098 }
2099 std::string error_msg;
2100 int status = 0u;
2101
2102 status = GenerateOdexForTestWithStatus(
2103 { invalid_dex_zip.GetFilename() },
2104 GetOdexDir() + "/output_apk.odex",
2105 CompilerFilter::kQuicken,
2106 &error_msg,
2107 { "--compact-dex-level=fast" });
2108 ASSERT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) != 0) << status << " " << output_;
2109
2110 status = GenerateOdexForTestWithStatus(
2111 { invalid_dex.GetFilename() },
2112 GetOdexDir() + "/output.odex",
2113 CompilerFilter::kQuicken,
2114 &error_msg,
2115 { "--compact-dex-level=fast" });
2116 ASSERT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) != 0) << status << " " << output_;
2117}
2118
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002119TEST_F(Dex2oatTest, AppImageNoProfile) {
2120 ScratchFile app_image_file;
2121 const std::string out_dir = GetScratchDir();
2122 const std::string odex_location = out_dir + "/base.odex";
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002123 ASSERT_TRUE(GenerateOdexForTest(GetTestDexFileName("ManyMethods"),
2124 odex_location,
2125 CompilerFilter::Filter::kSpeedProfile,
2126 { "--app-image-fd=" + std::to_string(app_image_file.GetFd()) },
2127 true, // expect_success
2128 false, // use_fd
2129 [](const OatFile&) {}));
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002130 // Open our generated oat file.
2131 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002132 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01002133 odex_location.c_str(),
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002134 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002135 /*executable=*/ false,
2136 /*low_4gb=*/ false,
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002137 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002138 /*reservation=*/ nullptr,
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002139 &error_msg));
2140 ASSERT_TRUE(odex_file != nullptr);
2141 ImageHeader header = {};
2142 ASSERT_TRUE(app_image_file.GetFile()->PreadFully(
2143 reinterpret_cast<void*>(&header),
2144 sizeof(header),
2145 /*offset*/ 0u)) << app_image_file.GetFile()->GetLength();
2146 EXPECT_GT(header.GetImageSection(ImageHeader::kSectionObjects).Size(), 0u);
2147 EXPECT_EQ(header.GetImageSection(ImageHeader::kSectionArtMethods).Size(), 0u);
2148 EXPECT_EQ(header.GetImageSection(ImageHeader::kSectionArtFields).Size(), 0u);
2149}
2150
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002151TEST_F(Dex2oatTest, AppImageResolveStrings) {
2152 using Hotness = ProfileCompilationInfo::MethodHotness;
2153 // Create a profile with the startup method marked.
2154 ScratchFile profile_file;
Mathieu Chartierc2109c62019-03-20 13:34:39 -07002155 ScratchFile temp_dex;
2156 const std::string& dex_location = temp_dex.GetFilename();
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002157 std::vector<uint16_t> methods;
Mathieu Chartier22752772018-10-18 14:18:59 -07002158 std::vector<dex::TypeIndex> classes;
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002159 {
Mathieu Chartierc2109c62019-03-20 13:34:39 -07002160 MutateDexFile(temp_dex.GetFile(), GetTestDexFileName("StringLiterals"), [&] (DexFile* dex) {
2161 bool mutated_successfully = false;
2162 // Change the dex instructions to make an opcode that spans past the end of the code item.
2163 for (ClassAccessor accessor : dex->GetClasses()) {
2164 if (accessor.GetDescriptor() == std::string("LStringLiterals$StartupClass;")) {
2165 classes.push_back(accessor.GetClassIdx());
2166 }
2167 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
2168 std::string method_name(dex->GetMethodName(dex->GetMethodId(method.GetIndex())));
2169 CodeItemInstructionAccessor instructions = method.GetInstructions();
2170 if (method_name == "startUpMethod2") {
2171 // Make an instruction that runs past the end of the code item and verify that it
2172 // doesn't cause dex2oat to crash.
2173 ASSERT_TRUE(instructions.begin() != instructions.end());
2174 DexInstructionIterator last_instruction = instructions.begin();
2175 for (auto dex_it = instructions.begin(); dex_it != instructions.end(); ++dex_it) {
2176 last_instruction = dex_it;
2177 }
2178 ASSERT_EQ(last_instruction->SizeInCodeUnits(), 1u);
2179 // Set the opcode to something that will go past the end of the code item.
2180 const_cast<Instruction&>(last_instruction.Inst()).SetOpcode(
2181 Instruction::CONST_STRING_JUMBO);
2182 mutated_successfully = true;
2183 // Test that the safe iterator doesn't go past the end.
2184 SafeDexInstructionIterator it2(instructions.begin(), instructions.end());
2185 while (!it2.IsErrorState()) {
2186 ++it2;
2187 }
2188 EXPECT_TRUE(it2 == last_instruction);
2189 EXPECT_TRUE(it2 < instructions.end());
2190 methods.push_back(method.GetIndex());
2191 mutated_successfully = true;
2192 } else if (method_name == "startUpMethod") {
2193 methods.push_back(method.GetIndex());
2194 }
Mathieu Chartier22752772018-10-18 14:18:59 -07002195 }
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002196 }
Mathieu Chartierc2109c62019-03-20 13:34:39 -07002197 CHECK(mutated_successfully)
2198 << "Failed to find candidate code item with only one code unit in last instruction.";
2199 });
2200 }
2201 std::unique_ptr<const DexFile> dex_file(OpenDexFile(temp_dex.GetFilename().c_str()));
2202 {
Mathieu Chartier22752772018-10-18 14:18:59 -07002203 ASSERT_GT(classes.size(), 0u);
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002204 ASSERT_GT(methods.size(), 0u);
2205 // Here, we build the profile from the method lists.
2206 ProfileCompilationInfo info;
Mathieu Chartierc2109c62019-03-20 13:34:39 -07002207 info.AddClassesForDex(dex_file.get(), classes.begin(), classes.end());
2208 info.AddMethodsForDex(Hotness::kFlagStartup, dex_file.get(), methods.begin(), methods.end());
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002209 // Save the profile since we want to use it with dex2oat to produce an oat file.
2210 ASSERT_TRUE(info.Save(profile_file.GetFd()));
2211 }
2212 const std::string out_dir = GetScratchDir();
2213 const std::string odex_location = out_dir + "/base.odex";
2214 const std::string app_image_location = out_dir + "/base.art";
Mathieu Chartierc2109c62019-03-20 13:34:39 -07002215 ASSERT_TRUE(GenerateOdexForTest(dex_location,
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002216 odex_location,
2217 CompilerFilter::Filter::kSpeedProfile,
2218 { "--app-image-file=" + app_image_location,
2219 "--resolve-startup-const-strings=true",
2220 "--profile-file=" + profile_file.GetFilename()},
2221 /* expect_success= */ true,
2222 /* use_fd= */ false,
2223 [](const OatFile&) {}));
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002224 // Open our generated oat file.
2225 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002226 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002227 odex_location.c_str(),
2228 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002229 /*executable=*/ false,
2230 /*low_4gb=*/ false,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002231 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002232 /*reservation=*/ nullptr,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002233 &error_msg));
2234 ASSERT_TRUE(odex_file != nullptr);
2235 // Check the strings in the app image intern table only contain the "startup" strigs.
2236 {
2237 ScopedObjectAccess soa(Thread::Current());
2238 std::unique_ptr<gc::space::ImageSpace> space =
2239 gc::space::ImageSpace::CreateFromAppImage(app_image_location.c_str(),
2240 odex_file.get(),
2241 &error_msg);
2242 ASSERT_TRUE(space != nullptr) << error_msg;
2243 std::set<std::string> seen;
2244 InternTable intern_table;
2245 intern_table.AddImageStringsToTable(space.get(), [&](InternTable::UnorderedSet& interns)
2246 REQUIRES_SHARED(Locks::mutator_lock_) {
2247 for (const GcRoot<mirror::String>& str : interns) {
2248 seen.insert(str.Read()->ToModifiedUtf8());
2249 }
2250 });
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002251 // Ensure that the dex cache has a preresolved string array.
2252 std::set<std::string> preresolved_seen;
2253 bool saw_dexcache = false;
2254 space->GetLiveBitmap()->VisitAllMarked(
2255 [&](mirror::Object* obj) REQUIRES_SHARED(Locks::mutator_lock_) {
2256 if (obj->IsDexCache<kVerifyNone>()) {
2257 ObjPtr<mirror::DexCache> dex_cache = obj->AsDexCache();
2258 GcRoot<mirror::String>* preresolved_strings = dex_cache->GetPreResolvedStrings();
Mathieu Chartierc2109c62019-03-20 13:34:39 -07002259 ASSERT_EQ(dex_file->NumStringIds(), dex_cache->NumPreResolvedStrings());
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002260 for (size_t i = 0; i < dex_cache->NumPreResolvedStrings(); ++i) {
2261 ObjPtr<mirror::String> string = preresolved_strings[i].Read<kWithoutReadBarrier>();
2262 if (string != nullptr) {
2263 preresolved_seen.insert(string->ToModifiedUtf8());
2264 }
2265 }
2266 saw_dexcache = true;
2267 }
2268 });
2269 ASSERT_TRUE(saw_dexcache);
2270 // Everything in the preresolved array should also be in the intern table.
2271 for (const std::string& str : preresolved_seen) {
2272 EXPECT_TRUE(seen.find(str) != seen.end());
2273 }
Mathieu Chartier22752772018-10-18 14:18:59 -07002274 // Normal methods
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002275 EXPECT_TRUE(preresolved_seen.find("Loading ") != preresolved_seen.end());
2276 EXPECT_TRUE(preresolved_seen.find("Starting up") != preresolved_seen.end());
2277 EXPECT_TRUE(preresolved_seen.find("abcd.apk") != preresolved_seen.end());
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002278 EXPECT_TRUE(seen.find("Unexpected error") == seen.end());
2279 EXPECT_TRUE(seen.find("Shutting down!") == seen.end());
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002280 EXPECT_TRUE(preresolved_seen.find("Unexpected error") == preresolved_seen.end());
2281 EXPECT_TRUE(preresolved_seen.find("Shutting down!") == preresolved_seen.end());
Mathieu Chartier22752772018-10-18 14:18:59 -07002282 // Classes initializers
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002283 EXPECT_TRUE(preresolved_seen.find("Startup init") != preresolved_seen.end());
Mathieu Chartier22752772018-10-18 14:18:59 -07002284 EXPECT_TRUE(seen.find("Other class init") == seen.end());
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002285 EXPECT_TRUE(preresolved_seen.find("Other class init") == preresolved_seen.end());
2286 // Expect the sets match.
2287 EXPECT_GE(seen.size(), preresolved_seen.size());
Mathieu Chartier8cc418e2018-10-31 10:54:30 -07002288
2289 // Verify what strings are marked as boot image.
2290 std::set<std::string> boot_image_strings;
2291 std::set<std::string> app_image_strings;
2292
2293 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
2294 intern_table.VisitInterns([&](const GcRoot<mirror::String>& root)
2295 REQUIRES_SHARED(Locks::mutator_lock_) {
2296 boot_image_strings.insert(root.Read()->ToModifiedUtf8());
2297 }, /*visit_boot_images=*/true, /*visit_non_boot_images=*/false);
2298 intern_table.VisitInterns([&](const GcRoot<mirror::String>& root)
2299 REQUIRES_SHARED(Locks::mutator_lock_) {
2300 app_image_strings.insert(root.Read()->ToModifiedUtf8());
2301 }, /*visit_boot_images=*/false, /*visit_non_boot_images=*/true);
2302 EXPECT_EQ(boot_image_strings.size(), 0u);
2303 EXPECT_TRUE(app_image_strings == seen);
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002304 }
2305}
2306
2307
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002308TEST_F(Dex2oatClassLoaderContextTest, StoredClassLoaderContext) {
Mathieu Chartierc4440772018-04-16 14:40:56 -07002309 std::vector<std::unique_ptr<const DexFile>> dex_files = OpenTestDexFiles("MultiDex");
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002310 const std::string out_dir = GetScratchDir();
2311 const std::string odex_location = out_dir + "/base.odex";
Mathieu Chartierc4440772018-04-16 14:40:56 -07002312 const std::string valid_context = "PCL[" + dex_files[0]->GetLocation() + "]";
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002313 const std::string stored_context = "PCL[/system/not_real_lib.jar]";
Mathieu Chartierc4440772018-04-16 14:40:56 -07002314 std::string expected_stored_context = "PCL[";
2315 size_t index = 1;
2316 for (const std::unique_ptr<const DexFile>& dex_file : dex_files) {
2317 const bool is_first = index == 1u;
2318 if (!is_first) {
2319 expected_stored_context += ":";
2320 }
2321 expected_stored_context += "/system/not_real_lib.jar";
2322 if (!is_first) {
2323 expected_stored_context += "!classes" + std::to_string(index) + ".dex";
2324 }
2325 expected_stored_context += "*" + std::to_string(dex_file->GetLocationChecksum());
2326 ++index;
2327 }
2328 expected_stored_context += + "]";
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002329 // The class path should not be valid and should fail being stored.
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002330 EXPECT_TRUE(GenerateOdexForTest(GetTestDexFileName("ManyMethods"),
2331 odex_location,
2332 CompilerFilter::Filter::kQuicken,
2333 { "--class-loader-context=" + stored_context },
2334 true, // expect_success
2335 false, // use_fd
2336 [&](const OatFile& oat_file) {
Mathieu Chartierc4440772018-04-16 14:40:56 -07002337 EXPECT_NE(oat_file.GetClassLoaderContext(), stored_context) << output_;
2338 EXPECT_NE(oat_file.GetClassLoaderContext(), valid_context) << output_;
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002339 }));
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002340 // The stored context should match what we expect even though it's invalid.
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002341 EXPECT_TRUE(GenerateOdexForTest(GetTestDexFileName("ManyMethods"),
2342 odex_location,
2343 CompilerFilter::Filter::kQuicken,
2344 { "--class-loader-context=" + valid_context,
2345 "--stored-class-loader-context=" + stored_context },
2346 true, // expect_success
2347 false, // use_fd
2348 [&](const OatFile& oat_file) {
Mathieu Chartierc4440772018-04-16 14:40:56 -07002349 EXPECT_EQ(oat_file.GetClassLoaderContext(), expected_stored_context) << output_;
Andreas Gampe50f9dc22018-11-05 10:29:43 -08002350 }));
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002351}
2352
xueliang.zhong7f88c1a2018-11-06 11:42:41 +00002353class Dex2oatISAFeaturesRuntimeDetectionTest : public Dex2oatTest {
2354 protected:
2355 void RunTest(const std::vector<std::string>& extra_args = {}) {
2356 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
2357 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
2358
2359 Copy(GetTestDexFileName(), dex_location);
2360
2361 ASSERT_TRUE(GenerateOdexForTest(dex_location,
2362 odex_location,
2363 CompilerFilter::kSpeed,
2364 extra_args));
2365 }
2366
2367 std::string GetTestDexFileName() {
2368 return GetDexSrc1();
2369 }
2370};
2371
2372TEST_F(Dex2oatISAFeaturesRuntimeDetectionTest, TestCurrentRuntimeFeaturesAsDex2OatArguments) {
2373 std::vector<std::string> argv;
2374 Runtime::Current()->AddCurrentRuntimeFeaturesAsDex2OatArguments(&argv);
2375 auto option_pos =
2376 std::find(std::begin(argv), std::end(argv), "--instruction-set-features=runtime");
2377 if (InstructionSetFeatures::IsRuntimeDetectionSupported()) {
2378 EXPECT_TRUE(kIsTargetBuild);
2379 EXPECT_NE(option_pos, std::end(argv));
2380 } else {
2381 EXPECT_EQ(option_pos, std::end(argv));
2382 }
2383
2384 RunTest();
2385}
2386
Andreas Gampee1459ae2016-06-29 09:36:30 -07002387} // namespace art