buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ian Rogers | e77493c | 2014-08-20 15:08:45 -0700 | [diff] [blame] | 17 | #include "base/bit_vector-inl.h" |
Andreas Gampe | 0b9203e | 2015-01-22 20:39:27 -0800 | [diff] [blame] | 18 | #include "base/logging.h" |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 19 | #include "dataflow_iterator-inl.h" |
Andreas Gampe | 0b9203e | 2015-01-22 20:39:27 -0800 | [diff] [blame] | 20 | #include "dex_flags.h" |
| 21 | #include "driver/compiler_driver.h" |
| 22 | #include "driver/dex_compilation_unit.h" |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 23 | #include "global_value_numbering.h" |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 24 | #include "local_value_numbering.h" |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 25 | #include "mir_field_info.h" |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 26 | #include "quick/dex_file_method_inliner.h" |
| 27 | #include "quick/dex_file_to_method_inliner_map.h" |
Andreas Gampe | 53c913b | 2014-08-12 23:19:23 -0700 | [diff] [blame] | 28 | #include "stack.h" |
Vladimir Marko | 69f08ba | 2014-04-11 12:28:11 +0100 | [diff] [blame] | 29 | #include "utils/scoped_arena_containers.h" |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 30 | |
| 31 | namespace art { |
| 32 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 33 | static unsigned int Predecessors(BasicBlock* bb) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 34 | return bb->predecessors.size(); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 35 | } |
| 36 | |
| 37 | /* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */ |
Razvan A Lupusoru | d04d309 | 2014-08-04 12:30:20 -0700 | [diff] [blame] | 38 | void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) { |
buzbee | 862a760 | 2013-04-05 10:58:54 -0700 | [diff] [blame] | 39 | is_constant_v_->SetBit(ssa_reg); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 40 | constant_values_[ssa_reg] = value; |
Vladimir Marko | 066f9e4 | 2015-01-16 16:04:43 +0000 | [diff] [blame] | 41 | reg_location_[ssa_reg].is_const = true; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 42 | } |
| 43 | |
Razvan A Lupusoru | d04d309 | 2014-08-04 12:30:20 -0700 | [diff] [blame] | 44 | void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) { |
buzbee | 862a760 | 2013-04-05 10:58:54 -0700 | [diff] [blame] | 45 | is_constant_v_->SetBit(ssa_reg); |
Serguei Katkov | 597da1f | 2014-07-15 17:25:46 +0700 | [diff] [blame] | 46 | is_constant_v_->SetBit(ssa_reg + 1); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 47 | constant_values_[ssa_reg] = Low32Bits(value); |
| 48 | constant_values_[ssa_reg + 1] = High32Bits(value); |
Vladimir Marko | 066f9e4 | 2015-01-16 16:04:43 +0000 | [diff] [blame] | 49 | reg_location_[ssa_reg].is_const = true; |
| 50 | reg_location_[ssa_reg + 1].is_const = true; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 51 | } |
| 52 | |
Jean Christophe Beyler | 4e97c53 | 2014-01-07 10:07:18 -0800 | [diff] [blame] | 53 | void MIRGraph::DoConstantPropagation(BasicBlock* bb) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 54 | MIR* mir; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 55 | |
| 56 | for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
Alexei Zavjalov | 9d89466 | 2014-04-21 20:45:24 +0700 | [diff] [blame] | 57 | // Skip pass if BB has MIR without SSA representation. |
Jean Christophe Beyler | cc794c3 | 2014-05-02 09:34:13 -0700 | [diff] [blame] | 58 | if (mir->ssa_rep == nullptr) { |
Alexei Zavjalov | 9d89466 | 2014-04-21 20:45:24 +0700 | [diff] [blame] | 59 | return; |
| 60 | } |
| 61 | |
Jean Christophe Beyler | cc794c3 | 2014-05-02 09:34:13 -0700 | [diff] [blame] | 62 | uint64_t df_attributes = GetDataFlowAttributes(mir); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 63 | |
Ian Rogers | 29a2648 | 2014-05-02 15:27:29 -0700 | [diff] [blame] | 64 | MIR::DecodedInstruction* d_insn = &mir->dalvikInsn; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 65 | |
| 66 | if (!(df_attributes & DF_HAS_DEFS)) continue; |
| 67 | |
| 68 | /* Handle instructions that set up constants directly */ |
| 69 | if (df_attributes & DF_SETS_CONST) { |
| 70 | if (df_attributes & DF_DA) { |
| 71 | int32_t vB = static_cast<int32_t>(d_insn->vB); |
| 72 | switch (d_insn->opcode) { |
| 73 | case Instruction::CONST_4: |
| 74 | case Instruction::CONST_16: |
| 75 | case Instruction::CONST: |
| 76 | SetConstant(mir->ssa_rep->defs[0], vB); |
| 77 | break; |
| 78 | case Instruction::CONST_HIGH16: |
| 79 | SetConstant(mir->ssa_rep->defs[0], vB << 16); |
| 80 | break; |
| 81 | case Instruction::CONST_WIDE_16: |
| 82 | case Instruction::CONST_WIDE_32: |
| 83 | SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB)); |
| 84 | break; |
| 85 | case Instruction::CONST_WIDE: |
Brian Carlstrom | b1eba21 | 2013-07-17 18:07:19 -0700 | [diff] [blame] | 86 | SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 87 | break; |
| 88 | case Instruction::CONST_WIDE_HIGH16: |
| 89 | SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48); |
| 90 | break; |
| 91 | default: |
| 92 | break; |
| 93 | } |
| 94 | } |
| 95 | /* Handle instructions that set up constants directly */ |
| 96 | } else if (df_attributes & DF_IS_MOVE) { |
| 97 | int i; |
| 98 | |
| 99 | for (i = 0; i < mir->ssa_rep->num_uses; i++) { |
buzbee | 862a760 | 2013-04-05 10:58:54 -0700 | [diff] [blame] | 100 | if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 101 | } |
| 102 | /* Move a register holding a constant to another register */ |
| 103 | if (i == mir->ssa_rep->num_uses) { |
| 104 | SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]); |
| 105 | if (df_attributes & DF_A_WIDE) { |
| 106 | SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]); |
| 107 | } |
| 108 | } |
| 109 | } |
| 110 | } |
| 111 | /* TODO: implement code to handle arithmetic operations */ |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 112 | } |
| 113 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 114 | /* Advance to next strictly dominated MIR node in an extended basic block */ |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 115 | MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 116 | BasicBlock* bb = *p_bb; |
| 117 | if (mir != NULL) { |
| 118 | mir = mir->next; |
Serguei Katkov | ea39216 | 2015-01-29 17:08:05 +0600 | [diff] [blame] | 119 | while (mir == NULL) { |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 120 | bb = GetBasicBlock(bb->fall_through); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 121 | if ((bb == NULL) || Predecessors(bb) != 1) { |
Serguei Katkov | ea39216 | 2015-01-29 17:08:05 +0600 | [diff] [blame] | 122 | // mir is null and we cannot proceed further. |
| 123 | break; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 124 | } else { |
Serguei Katkov | ea39216 | 2015-01-29 17:08:05 +0600 | [diff] [blame] | 125 | *p_bb = bb; |
| 126 | mir = bb->first_mir_insn; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 127 | } |
| 128 | } |
| 129 | } |
| 130 | return mir; |
| 131 | } |
| 132 | |
| 133 | /* |
| 134 | * To be used at an invoke mir. If the logically next mir node represents |
| 135 | * a move-result, return it. Else, return NULL. If a move-result exists, |
| 136 | * it is required to immediately follow the invoke with no intervening |
| 137 | * opcodes or incoming arcs. However, if the result of the invoke is not |
| 138 | * used, a move-result may not be present. |
| 139 | */ |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 140 | MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 141 | BasicBlock* tbb = bb; |
| 142 | mir = AdvanceMIR(&tbb, mir); |
| 143 | while (mir != NULL) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 144 | if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) || |
| 145 | (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) || |
| 146 | (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) { |
| 147 | break; |
| 148 | } |
| 149 | // Keep going if pseudo op, otherwise terminate |
Jean Christophe Beyler | 2ab40eb | 2014-06-02 09:03:14 -0700 | [diff] [blame] | 150 | if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 151 | mir = AdvanceMIR(&tbb, mir); |
buzbee | 35ba7f3 | 2014-05-31 08:59:01 -0700 | [diff] [blame] | 152 | } else { |
| 153 | mir = NULL; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 154 | } |
| 155 | } |
| 156 | return mir; |
| 157 | } |
| 158 | |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 159 | BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 160 | if (bb->block_type == kDead) { |
| 161 | return NULL; |
| 162 | } |
| 163 | DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode) |
| 164 | || (bb->block_type == kExitBlock)); |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 165 | BasicBlock* bb_taken = GetBasicBlock(bb->taken); |
| 166 | BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through); |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 167 | if (((bb_fall_through == NULL) && (bb_taken != NULL)) && |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 168 | ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) { |
buzbee | cbcfaf3 | 2013-08-19 07:37:40 -0700 | [diff] [blame] | 169 | // Follow simple unconditional branches. |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 170 | bb = bb_taken; |
buzbee | cbcfaf3 | 2013-08-19 07:37:40 -0700 | [diff] [blame] | 171 | } else { |
| 172 | // Follow simple fallthrough |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 173 | bb = (bb_taken != NULL) ? NULL : bb_fall_through; |
buzbee | cbcfaf3 | 2013-08-19 07:37:40 -0700 | [diff] [blame] | 174 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 175 | if (bb == NULL || (Predecessors(bb) != 1)) { |
| 176 | return NULL; |
| 177 | } |
| 178 | DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock)); |
| 179 | return bb; |
| 180 | } |
| 181 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 182 | static MIR* FindPhi(BasicBlock* bb, int ssa_name) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 183 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
| 184 | if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) { |
| 185 | for (int i = 0; i < mir->ssa_rep->num_uses; i++) { |
| 186 | if (mir->ssa_rep->uses[i] == ssa_name) { |
| 187 | return mir; |
| 188 | } |
| 189 | } |
| 190 | } |
| 191 | } |
| 192 | return NULL; |
| 193 | } |
| 194 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 195 | static SelectInstructionKind SelectKind(MIR* mir) { |
Chao-ying Fu | 8ac41af | 2014-10-01 16:53:04 -0700 | [diff] [blame] | 196 | // Work with the case when mir is nullptr. |
| 197 | if (mir == nullptr) { |
| 198 | return kSelectNone; |
| 199 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 200 | switch (mir->dalvikInsn.opcode) { |
| 201 | case Instruction::MOVE: |
| 202 | case Instruction::MOVE_OBJECT: |
| 203 | case Instruction::MOVE_16: |
| 204 | case Instruction::MOVE_OBJECT_16: |
| 205 | case Instruction::MOVE_FROM16: |
| 206 | case Instruction::MOVE_OBJECT_FROM16: |
| 207 | return kSelectMove; |
Brian Carlstrom | 6f485c6 | 2013-07-18 15:35:35 -0700 | [diff] [blame] | 208 | case Instruction::CONST: |
| 209 | case Instruction::CONST_4: |
| 210 | case Instruction::CONST_16: |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 211 | return kSelectConst; |
Brian Carlstrom | 6f485c6 | 2013-07-18 15:35:35 -0700 | [diff] [blame] | 212 | case Instruction::GOTO: |
| 213 | case Instruction::GOTO_16: |
| 214 | case Instruction::GOTO_32: |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 215 | return kSelectGoto; |
Brian Carlstrom | 02c8cc6 | 2013-07-18 15:54:44 -0700 | [diff] [blame] | 216 | default: |
| 217 | return kSelectNone; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 218 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 219 | } |
| 220 | |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 221 | static constexpr ConditionCode kIfCcZConditionCodes[] = { |
| 222 | kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe |
| 223 | }; |
| 224 | |
Andreas Gampe | 785d2f2 | 2014-11-03 22:57:30 -0800 | [diff] [blame] | 225 | static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1, |
| 226 | "if_ccz_ccodes_size1"); |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 227 | |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 228 | static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) { |
| 229 | return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ]; |
| 230 | } |
| 231 | |
Andreas Gampe | 785d2f2 | 2014-11-03 22:57:30 -0800 | [diff] [blame] | 232 | static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode"); |
| 233 | static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode"); |
| 234 | static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode"); |
| 235 | static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode"); |
| 236 | static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode"); |
| 237 | static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode"); |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 238 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 239 | int MIRGraph::GetSSAUseCount(int s_reg) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 240 | DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size()); |
| 241 | return raw_use_counts_[s_reg]; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 242 | } |
| 243 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 244 | size_t MIRGraph::GetNumBytesForSpecialTemps() const { |
| 245 | // This logic is written with assumption that Method* is only special temp. |
| 246 | DCHECK_EQ(max_available_special_compiler_temps_, 1u); |
| 247 | return sizeof(StackReference<mirror::ArtMethod>); |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 248 | } |
| 249 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 250 | size_t MIRGraph::GetNumAvailableVRTemps() { |
| 251 | // First take into account all temps reserved for backend. |
| 252 | if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) { |
| 253 | return 0; |
| 254 | } |
| 255 | |
| 256 | // Calculate remaining ME temps available. |
| 257 | size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_; |
| 258 | |
| 259 | if (num_non_special_compiler_temps_ >= remaining_me_temps) { |
| 260 | return 0; |
| 261 | } else { |
| 262 | return remaining_me_temps - num_non_special_compiler_temps_; |
| 263 | } |
| 264 | } |
Bill Buzbee | 00e1ec6 | 2014-02-27 23:44:13 +0000 | [diff] [blame] | 265 | |
| 266 | // FIXME - will probably need to revisit all uses of this, as type not defined. |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 267 | static const RegLocation temp_loc = {kLocCompilerTemp, |
buzbee | 091cc40 | 2014-03-31 10:14:40 -0700 | [diff] [blame] | 268 | 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/, |
Bill Buzbee | 00e1ec6 | 2014-02-27 23:44:13 +0000 | [diff] [blame] | 269 | RegStorage(), INVALID_SREG, INVALID_SREG}; |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 270 | |
| 271 | CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) { |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 272 | // Once the compiler temps have been committed, new ones cannot be requested anymore. |
| 273 | DCHECK_EQ(compiler_temps_committed_, false); |
| 274 | // Make sure that reserved for BE set is sane. |
| 275 | DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_); |
| 276 | |
| 277 | bool verbose = cu_->verbose; |
| 278 | const char* ct_type_str = nullptr; |
| 279 | |
| 280 | if (verbose) { |
| 281 | switch (ct_type) { |
| 282 | case kCompilerTempBackend: |
| 283 | ct_type_str = "backend"; |
| 284 | break; |
| 285 | case kCompilerTempSpecialMethodPtr: |
| 286 | ct_type_str = "method*"; |
| 287 | break; |
| 288 | case kCompilerTempVR: |
| 289 | ct_type_str = "VR"; |
| 290 | break; |
| 291 | default: |
| 292 | ct_type_str = "unknown"; |
| 293 | break; |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 294 | } |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 295 | LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is " |
| 296 | << (wide ? "wide is being requested." : "not wide is being requested."); |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 297 | } |
| 298 | |
| 299 | CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp), |
Vladimir Marko | 83cc7ae | 2014-02-12 18:02:05 +0000 | [diff] [blame] | 300 | kArenaAllocRegAlloc)); |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 301 | |
| 302 | // Create the type of temp requested. Special temps need special handling because |
| 303 | // they have a specific virtual register assignment. |
| 304 | if (ct_type == kCompilerTempSpecialMethodPtr) { |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 305 | // This has a special location on stack which is 32-bit or 64-bit depending |
| 306 | // on mode. However, we don't want to overlap with non-special section |
| 307 | // and thus even for 64-bit, we allow only a non-wide temp to be requested. |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 308 | DCHECK_EQ(wide, false); |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 309 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 310 | // The vreg is always the first special temp for method ptr. |
| 311 | compiler_temp->v_reg = GetFirstSpecialTempVR(); |
| 312 | |
| 313 | } else if (ct_type == kCompilerTempBackend) { |
| 314 | requested_backend_temp_ = true; |
| 315 | |
| 316 | // Make sure that we are not exceeding temps reserved for BE. |
| 317 | // Since VR temps cannot be requested once the BE temps are requested, we |
| 318 | // allow reservation of VR temps as well for BE. We |
| 319 | size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps(); |
| 320 | if (available_temps <= 0 || (available_temps <= 1 && wide)) { |
| 321 | if (verbose) { |
| 322 | LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available."; |
| 323 | } |
| 324 | return nullptr; |
| 325 | } |
| 326 | |
| 327 | // Update the remaining reserved temps since we have now used them. |
| 328 | // Note that the code below is actually subtracting to remove them from reserve |
| 329 | // once they have been claimed. It is careful to not go below zero. |
| 330 | if (reserved_temps_for_backend_ >= 1) { |
| 331 | reserved_temps_for_backend_--; |
| 332 | } |
| 333 | if (wide && reserved_temps_for_backend_ >= 1) { |
| 334 | reserved_temps_for_backend_--; |
| 335 | } |
| 336 | |
| 337 | // The new non-special compiler temp must receive a unique v_reg. |
| 338 | compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_; |
| 339 | num_non_special_compiler_temps_++; |
| 340 | } else if (ct_type == kCompilerTempVR) { |
| 341 | // Once we start giving out BE temps, we don't allow anymore ME temps to be requested. |
| 342 | // This is done in order to prevent problems with ssa since these structures are allocated |
| 343 | // and managed by the ME. |
| 344 | DCHECK_EQ(requested_backend_temp_, false); |
| 345 | |
| 346 | // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded. |
| 347 | size_t available_temps = GetNumAvailableVRTemps(); |
| 348 | if (available_temps <= 0 || (available_temps <= 1 && wide)) { |
| 349 | if (verbose) { |
| 350 | LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available."; |
| 351 | } |
| 352 | return nullptr; |
| 353 | } |
| 354 | |
| 355 | // The new non-special compiler temp must receive a unique v_reg. |
| 356 | compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_; |
| 357 | num_non_special_compiler_temps_++; |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 358 | } else { |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 359 | UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << "."; |
| 360 | } |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 361 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 362 | // We allocate an sreg as well to make developer life easier. |
| 363 | // However, if this is requested from an ME pass that will recalculate ssa afterwards, |
| 364 | // this sreg is no longer valid. The caller should be aware of this. |
| 365 | compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg); |
| 366 | |
| 367 | if (verbose) { |
| 368 | LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg |
| 369 | << " and s" << compiler_temp->s_reg_low << " has been created."; |
| 370 | } |
| 371 | |
| 372 | if (wide) { |
| 373 | // Only non-special temps are handled as wide for now. |
| 374 | // Note that the number of non special temps is incremented below. |
| 375 | DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR); |
| 376 | |
| 377 | // Ensure that the two registers are consecutive. |
| 378 | int ssa_reg_low = compiler_temp->s_reg_low; |
| 379 | int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1); |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 380 | num_non_special_compiler_temps_++; |
| 381 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 382 | if (verbose) { |
| 383 | LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v" |
| 384 | << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << "."; |
| 385 | } |
Chao-ying Fu | 54d36b6 | 2014-05-22 17:25:02 -0700 | [diff] [blame] | 386 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 387 | if (reg_location_ != nullptr) { |
| 388 | reg_location_[ssa_reg_high] = temp_loc; |
| 389 | reg_location_[ssa_reg_high].high_word = true; |
| 390 | reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low; |
| 391 | reg_location_[ssa_reg_high].wide = true; |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 392 | } |
| 393 | } |
| 394 | |
Razvan A Lupusoru | 8d0d03e | 2014-06-06 17:04:52 -0700 | [diff] [blame] | 395 | // If the register locations have already been allocated, add the information |
| 396 | // about the temp. We will not overflow because they have been initialized |
| 397 | // to support the maximum number of temps. For ME temps that have multiple |
| 398 | // ssa versions, the structures below will be expanded on the post pass cleanup. |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 399 | if (reg_location_ != nullptr) { |
| 400 | int ssa_reg_low = compiler_temp->s_reg_low; |
| 401 | reg_location_[ssa_reg_low] = temp_loc; |
| 402 | reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low; |
| 403 | reg_location_[ssa_reg_low].wide = wide; |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 404 | } |
| 405 | |
Razvan A Lupusoru | da7a69b | 2014-01-08 15:09:50 -0800 | [diff] [blame] | 406 | return compiler_temp; |
| 407 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 408 | |
Vladimir Marko | 7ab2fce | 2014-11-28 13:38:28 +0000 | [diff] [blame] | 409 | static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) { |
| 410 | bool is_taken; |
| 411 | switch (opcode) { |
| 412 | case Instruction::IF_EQ: is_taken = (src1 == src2); break; |
| 413 | case Instruction::IF_NE: is_taken = (src1 != src2); break; |
| 414 | case Instruction::IF_LT: is_taken = (src1 < src2); break; |
| 415 | case Instruction::IF_GE: is_taken = (src1 >= src2); break; |
| 416 | case Instruction::IF_GT: is_taken = (src1 > src2); break; |
| 417 | case Instruction::IF_LE: is_taken = (src1 <= src2); break; |
| 418 | case Instruction::IF_EQZ: is_taken = (src1 == 0); break; |
| 419 | case Instruction::IF_NEZ: is_taken = (src1 != 0); break; |
| 420 | case Instruction::IF_LTZ: is_taken = (src1 < 0); break; |
| 421 | case Instruction::IF_GEZ: is_taken = (src1 >= 0); break; |
| 422 | case Instruction::IF_GTZ: is_taken = (src1 > 0); break; |
| 423 | case Instruction::IF_LEZ: is_taken = (src1 <= 0); break; |
| 424 | default: |
| 425 | LOG(FATAL) << "Unexpected opcode " << opcode; |
| 426 | UNREACHABLE(); |
| 427 | } |
| 428 | return is_taken; |
| 429 | } |
| 430 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 431 | /* Do some MIR-level extended basic block optimizations */ |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 432 | bool MIRGraph::BasicBlockOpt(BasicBlock* bb) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 433 | if (bb->block_type == kDead) { |
| 434 | return true; |
| 435 | } |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 436 | // Currently multiply-accumulate backend supports are only available on arm32 and arm64. |
| 437 | if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) { |
| 438 | MultiplyAddOpt(bb); |
| 439 | } |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 440 | bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 441 | std::unique_ptr<ScopedArenaAllocator> allocator; |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 442 | std::unique_ptr<GlobalValueNumbering> global_valnum; |
Ian Rogers | 700a402 | 2014-05-19 16:49:03 -0700 | [diff] [blame] | 443 | std::unique_ptr<LocalValueNumbering> local_valnum; |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 444 | if (use_lvn) { |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 445 | allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack)); |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 446 | global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(), |
| 447 | GlobalValueNumbering::kModeLvn)); |
Vladimir Marko | b19955d | 2014-07-29 12:04:10 +0100 | [diff] [blame] | 448 | local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id, |
| 449 | allocator.get())); |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 450 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 451 | while (bb != NULL) { |
| 452 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
| 453 | // TUNING: use the returned value number for CSE. |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 454 | if (use_lvn) { |
| 455 | local_valnum->GetValueNumber(mir); |
| 456 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 457 | // Look for interesting opcodes, skip otherwise |
| 458 | Instruction::Code opcode = mir->dalvikInsn.opcode; |
| 459 | switch (opcode) { |
Vladimir Marko | 7ab2fce | 2014-11-28 13:38:28 +0000 | [diff] [blame] | 460 | case Instruction::IF_EQ: |
| 461 | case Instruction::IF_NE: |
| 462 | case Instruction::IF_LT: |
| 463 | case Instruction::IF_GE: |
| 464 | case Instruction::IF_GT: |
| 465 | case Instruction::IF_LE: |
| 466 | if (!IsConst(mir->ssa_rep->uses[1])) { |
| 467 | break; |
| 468 | } |
| 469 | FALLTHROUGH_INTENDED; |
| 470 | case Instruction::IF_EQZ: |
| 471 | case Instruction::IF_NEZ: |
| 472 | case Instruction::IF_LTZ: |
| 473 | case Instruction::IF_GEZ: |
| 474 | case Instruction::IF_GTZ: |
| 475 | case Instruction::IF_LEZ: |
| 476 | // Result known at compile time? |
| 477 | if (IsConst(mir->ssa_rep->uses[0])) { |
| 478 | int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0; |
| 479 | bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs); |
| 480 | BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken; |
| 481 | if (is_taken) { |
| 482 | // Replace with GOTO. |
| 483 | bb->fall_through = NullBasicBlockId; |
| 484 | mir->dalvikInsn.opcode = Instruction::GOTO; |
| 485 | mir->dalvikInsn.vA = |
| 486 | IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB; |
| 487 | } else { |
| 488 | // Make NOP. |
| 489 | bb->taken = NullBasicBlockId; |
| 490 | mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop); |
| 491 | } |
| 492 | mir->ssa_rep->num_uses = 0; |
| 493 | BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill); |
| 494 | successor_to_unlink->ErasePredecessor(bb->id); |
Vladimir Marko | 341e425 | 2014-12-19 10:29:51 +0000 | [diff] [blame] | 495 | // We have changed the graph structure. |
| 496 | dfs_orders_up_to_date_ = false; |
| 497 | domination_up_to_date_ = false; |
| 498 | topological_order_up_to_date_ = false; |
| 499 | // Keep MIR SSA rep, the worst that can happen is a Phi with just 1 input. |
Vladimir Marko | 7ab2fce | 2014-11-28 13:38:28 +0000 | [diff] [blame] | 500 | } |
| 501 | break; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 502 | case Instruction::CMPL_FLOAT: |
| 503 | case Instruction::CMPL_DOUBLE: |
| 504 | case Instruction::CMPG_FLOAT: |
| 505 | case Instruction::CMPG_DOUBLE: |
| 506 | case Instruction::CMP_LONG: |
buzbee | 1fd3346 | 2013-03-25 13:40:45 -0700 | [diff] [blame] | 507 | if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 508 | // Bitcode doesn't allow this optimization. |
| 509 | break; |
| 510 | } |
| 511 | if (mir->next != NULL) { |
| 512 | MIR* mir_next = mir->next; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 513 | // Make sure result of cmp is used by next insn and nowhere else |
Jean Christophe Beyler | c26efa8 | 2014-06-01 11:39:39 -0700 | [diff] [blame] | 514 | if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) && |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 515 | (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) && |
| 516 | (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) { |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 517 | mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode); |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 518 | switch (opcode) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 519 | case Instruction::CMPL_FLOAT: |
| 520 | mir_next->dalvikInsn.opcode = |
| 521 | static_cast<Instruction::Code>(kMirOpFusedCmplFloat); |
| 522 | break; |
| 523 | case Instruction::CMPL_DOUBLE: |
| 524 | mir_next->dalvikInsn.opcode = |
| 525 | static_cast<Instruction::Code>(kMirOpFusedCmplDouble); |
| 526 | break; |
| 527 | case Instruction::CMPG_FLOAT: |
| 528 | mir_next->dalvikInsn.opcode = |
| 529 | static_cast<Instruction::Code>(kMirOpFusedCmpgFloat); |
| 530 | break; |
| 531 | case Instruction::CMPG_DOUBLE: |
| 532 | mir_next->dalvikInsn.opcode = |
| 533 | static_cast<Instruction::Code>(kMirOpFusedCmpgDouble); |
| 534 | break; |
| 535 | case Instruction::CMP_LONG: |
| 536 | mir_next->dalvikInsn.opcode = |
| 537 | static_cast<Instruction::Code>(kMirOpFusedCmpLong); |
| 538 | break; |
| 539 | default: LOG(ERROR) << "Unexpected opcode: " << opcode; |
| 540 | } |
| 541 | mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop); |
Zheng Xu | b218c85 | 2014-12-08 18:18:01 +0800 | [diff] [blame] | 542 | // Clear use count of temp VR. |
| 543 | use_counts_[mir->ssa_rep->defs[0]] = 0; |
| 544 | raw_use_counts_[mir->ssa_rep->defs[0]] = 0; |
Jean Christophe Beyler | c26efa8 | 2014-06-01 11:39:39 -0700 | [diff] [blame] | 545 | // Copy the SSA information that is relevant. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 546 | mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses; |
| 547 | mir_next->ssa_rep->uses = mir->ssa_rep->uses; |
| 548 | mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use; |
| 549 | mir_next->ssa_rep->num_defs = 0; |
| 550 | mir->ssa_rep->num_uses = 0; |
| 551 | mir->ssa_rep->num_defs = 0; |
Jean Christophe Beyler | c26efa8 | 2014-06-01 11:39:39 -0700 | [diff] [blame] | 552 | // Copy in the decoded instruction information for potential SSA re-creation. |
| 553 | mir_next->dalvikInsn.vA = mir->dalvikInsn.vB; |
| 554 | mir_next->dalvikInsn.vB = mir->dalvikInsn.vC; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 555 | } |
| 556 | } |
| 557 | break; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 558 | default: |
| 559 | break; |
| 560 | } |
| 561 | // Is this the select pattern? |
Razvan A Lupusoru | e27b3bf | 2014-01-23 09:41:45 -0800 | [diff] [blame] | 562 | // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 563 | // TUNING: expand to support IF_xx compare & branches |
Elliott Hughes | 956af0f | 2014-12-11 14:34:28 -0800 | [diff] [blame] | 564 | if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 || |
Serban Constantinescu | 05e27ff | 2014-05-28 13:21:45 +0100 | [diff] [blame] | 565 | cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) && |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 566 | IsInstructionIfCcZ(mir->dalvikInsn.opcode)) { |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 567 | BasicBlock* ft = GetBasicBlock(bb->fall_through); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 568 | DCHECK(ft != NULL); |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 569 | BasicBlock* ft_ft = GetBasicBlock(ft->fall_through); |
| 570 | BasicBlock* ft_tk = GetBasicBlock(ft->taken); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 571 | |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 572 | BasicBlock* tk = GetBasicBlock(bb->taken); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 573 | DCHECK(tk != NULL); |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 574 | BasicBlock* tk_ft = GetBasicBlock(tk->fall_through); |
| 575 | BasicBlock* tk_tk = GetBasicBlock(tk->taken); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 576 | |
| 577 | /* |
| 578 | * In the select pattern, the taken edge goes to a block that unconditionally |
| 579 | * transfers to the rejoin block and the fall_though edge goes to a block that |
| 580 | * unconditionally falls through to the rejoin block. |
| 581 | */ |
| 582 | if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) && |
| 583 | (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) { |
| 584 | /* |
Vladimir Marko | 8b858e1 | 2014-11-27 14:52:37 +0000 | [diff] [blame] | 585 | * Okay - we have the basic diamond shape. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 586 | */ |
Serban Constantinescu | 05e27ff | 2014-05-28 13:21:45 +0100 | [diff] [blame] | 587 | |
| 588 | // TODO: Add logic for LONG. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 589 | // Are the block bodies something we can handle? |
| 590 | if ((ft->first_mir_insn == ft->last_mir_insn) && |
| 591 | (tk->first_mir_insn != tk->last_mir_insn) && |
| 592 | (tk->first_mir_insn->next == tk->last_mir_insn) && |
| 593 | ((SelectKind(ft->first_mir_insn) == kSelectMove) || |
| 594 | (SelectKind(ft->first_mir_insn) == kSelectConst)) && |
| 595 | (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) && |
| 596 | (SelectKind(tk->last_mir_insn) == kSelectGoto)) { |
| 597 | // Almost there. Are the instructions targeting the same vreg? |
| 598 | MIR* if_true = tk->first_mir_insn; |
| 599 | MIR* if_false = ft->first_mir_insn; |
| 600 | // It's possible that the target of the select isn't used - skip those (rare) cases. |
| 601 | MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]); |
| 602 | if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) { |
| 603 | /* |
| 604 | * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the |
| 605 | * Phi node in the merge block and delete it (while using the SSA name |
| 606 | * of the merge as the target of the SELECT. Delete both taken and |
| 607 | * fallthrough blocks, and set fallthrough to merge block. |
| 608 | * NOTE: not updating other dataflow info (no longer used at this point). |
| 609 | * If this changes, need to update i_dom, etc. here (and in CombineBlocks). |
| 610 | */ |
Vladimir Marko | a1a7074 | 2014-03-03 10:28:05 +0000 | [diff] [blame] | 611 | mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 612 | mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect); |
| 613 | bool const_form = (SelectKind(if_true) == kSelectConst); |
| 614 | if ((SelectKind(if_true) == kSelectMove)) { |
| 615 | if (IsConst(if_true->ssa_rep->uses[0]) && |
| 616 | IsConst(if_false->ssa_rep->uses[0])) { |
| 617 | const_form = true; |
| 618 | if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]); |
| 619 | if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]); |
| 620 | } |
| 621 | } |
| 622 | if (const_form) { |
Razvan A Lupusoru | e27b3bf | 2014-01-23 09:41:45 -0800 | [diff] [blame] | 623 | /* |
| 624 | * TODO: If both constants are the same value, then instead of generating |
| 625 | * a select, we should simply generate a const bytecode. This should be |
| 626 | * considered after inlining which can lead to CFG of this form. |
| 627 | */ |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 628 | // "true" set val in vB |
| 629 | mir->dalvikInsn.vB = if_true->dalvikInsn.vB; |
| 630 | // "false" set val in vC |
| 631 | mir->dalvikInsn.vC = if_false->dalvikInsn.vB; |
| 632 | } else { |
| 633 | DCHECK_EQ(SelectKind(if_true), kSelectMove); |
| 634 | DCHECK_EQ(SelectKind(if_false), kSelectMove); |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 635 | int32_t* src_ssa = arena_->AllocArray<int32_t>(3, kArenaAllocDFInfo); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 636 | src_ssa[0] = mir->ssa_rep->uses[0]; |
| 637 | src_ssa[1] = if_true->ssa_rep->uses[0]; |
| 638 | src_ssa[2] = if_false->ssa_rep->uses[0]; |
| 639 | mir->ssa_rep->uses = src_ssa; |
| 640 | mir->ssa_rep->num_uses = 3; |
| 641 | } |
| 642 | mir->ssa_rep->num_defs = 1; |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 643 | mir->ssa_rep->defs = arena_->AllocArray<int32_t>(1, kArenaAllocDFInfo); |
| 644 | mir->ssa_rep->fp_def = arena_->AllocArray<bool>(1, kArenaAllocDFInfo); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 645 | mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0]; |
buzbee | 817e45a | 2013-05-30 18:59:12 -0700 | [diff] [blame] | 646 | // Match type of uses to def. |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 647 | mir->ssa_rep->fp_use = arena_->AllocArray<bool>(mir->ssa_rep->num_uses, |
| 648 | kArenaAllocDFInfo); |
buzbee | 817e45a | 2013-05-30 18:59:12 -0700 | [diff] [blame] | 649 | for (int i = 0; i < mir->ssa_rep->num_uses; i++) { |
| 650 | mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0]; |
| 651 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 652 | /* |
| 653 | * There is usually a Phi node in the join block for our two cases. If the |
| 654 | * Phi node only contains our two cases as input, we will use the result |
| 655 | * SSA name of the Phi node as our select result and delete the Phi. If |
| 656 | * the Phi node has more than two operands, we will arbitrarily use the SSA |
Vladimir Marko | 341e425 | 2014-12-19 10:29:51 +0000 | [diff] [blame] | 657 | * name of the "false" path, delete the SSA name of the "true" path from the |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 658 | * Phi node (and fix up the incoming arc list). |
| 659 | */ |
| 660 | if (phi->ssa_rep->num_uses == 2) { |
| 661 | mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0]; |
Vladimir Marko | 341e425 | 2014-12-19 10:29:51 +0000 | [diff] [blame] | 662 | // Rather than changing the Phi to kMirOpNop, remove it completely. |
| 663 | // This avoids leaving other Phis after kMirOpNop (i.e. a non-Phi) insn. |
| 664 | tk_tk->RemoveMIR(phi); |
| 665 | int dead_false_def = if_false->ssa_rep->defs[0]; |
| 666 | raw_use_counts_[dead_false_def] = use_counts_[dead_false_def] = 0; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 667 | } else { |
Vladimir Marko | 341e425 | 2014-12-19 10:29:51 +0000 | [diff] [blame] | 668 | int live_def = if_false->ssa_rep->defs[0]; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 669 | mir->ssa_rep->defs[0] = live_def; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 670 | } |
Vladimir Marko | 341e425 | 2014-12-19 10:29:51 +0000 | [diff] [blame] | 671 | int dead_true_def = if_true->ssa_rep->defs[0]; |
| 672 | raw_use_counts_[dead_true_def] = use_counts_[dead_true_def] = 0; |
| 673 | // We want to remove ft and tk and link bb directly to ft_ft. First, we need |
| 674 | // to update all Phi inputs correctly with UpdatePredecessor(ft->id, bb->id) |
| 675 | // since the live_def above comes from ft->first_mir_insn (if_false). |
| 676 | DCHECK(if_false == ft->first_mir_insn); |
| 677 | ft_ft->UpdatePredecessor(ft->id, bb->id); |
| 678 | // Correct the rest of the links between bb, ft and ft_ft. |
| 679 | ft->ErasePredecessor(bb->id); |
| 680 | ft->fall_through = NullBasicBlockId; |
| 681 | bb->fall_through = ft_ft->id; |
| 682 | // Now we can kill tk and ft. |
| 683 | tk->Kill(this); |
| 684 | ft->Kill(this); |
| 685 | // NOTE: DFS order, domination info and topological order are still usable |
| 686 | // despite the newly dead blocks. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 687 | } |
| 688 | } |
| 689 | } |
| 690 | } |
| 691 | } |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 692 | bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 693 | } |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 694 | if (use_lvn && UNLIKELY(!global_valnum->Good())) { |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 695 | LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file); |
| 696 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 697 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 698 | return true; |
| 699 | } |
| 700 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 701 | /* Collect stats on number of checks removed */ |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 702 | void MIRGraph::CountChecks(class BasicBlock* bb) { |
buzbee | 862a760 | 2013-04-05 10:58:54 -0700 | [diff] [blame] | 703 | if (bb->data_flow_info != NULL) { |
| 704 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
| 705 | if (mir->ssa_rep == NULL) { |
| 706 | continue; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 707 | } |
Jean Christophe Beyler | cc794c3 | 2014-05-02 09:34:13 -0700 | [diff] [blame] | 708 | uint64_t df_attributes = GetDataFlowAttributes(mir); |
buzbee | 862a760 | 2013-04-05 10:58:54 -0700 | [diff] [blame] | 709 | if (df_attributes & DF_HAS_NULL_CHKS) { |
| 710 | checkstats_->null_checks++; |
| 711 | if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) { |
| 712 | checkstats_->null_checks_eliminated++; |
| 713 | } |
| 714 | } |
| 715 | if (df_attributes & DF_HAS_RANGE_CHKS) { |
| 716 | checkstats_->range_checks++; |
| 717 | if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) { |
| 718 | checkstats_->range_checks_eliminated++; |
| 719 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 720 | } |
| 721 | } |
| 722 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 723 | } |
| 724 | |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 725 | /* Try to make common case the fallthrough path. */ |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 726 | bool MIRGraph::LayoutBlocks(BasicBlock* bb) { |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 727 | // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 728 | if (!bb->explicit_throw) { |
| 729 | return false; |
| 730 | } |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 731 | |
| 732 | // If we visited it, we are done. |
| 733 | if (bb->visited) { |
| 734 | return false; |
| 735 | } |
| 736 | bb->visited = true; |
| 737 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 738 | BasicBlock* walker = bb; |
| 739 | while (true) { |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 740 | // Check termination conditions. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 741 | if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) { |
| 742 | break; |
| 743 | } |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 744 | DCHECK(!walker->predecessors.empty()); |
| 745 | BasicBlock* prev = GetBasicBlock(walker->predecessors[0]); |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 746 | |
| 747 | // If we visited the predecessor, we are done. |
| 748 | if (prev->visited) { |
| 749 | return false; |
| 750 | } |
| 751 | prev->visited = true; |
| 752 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 753 | if (prev->conditional_branch) { |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 754 | if (GetBasicBlock(prev->fall_through) == walker) { |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 755 | // Already done - return. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 756 | break; |
| 757 | } |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 758 | DCHECK_EQ(walker, GetBasicBlock(prev->taken)); |
Jean Christophe Beyler | 75bcc37 | 2014-09-04 08:15:11 -0700 | [diff] [blame] | 759 | // Got one. Flip it and exit. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 760 | Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode; |
| 761 | switch (opcode) { |
| 762 | case Instruction::IF_EQ: opcode = Instruction::IF_NE; break; |
| 763 | case Instruction::IF_NE: opcode = Instruction::IF_EQ; break; |
| 764 | case Instruction::IF_LT: opcode = Instruction::IF_GE; break; |
| 765 | case Instruction::IF_GE: opcode = Instruction::IF_LT; break; |
| 766 | case Instruction::IF_GT: opcode = Instruction::IF_LE; break; |
| 767 | case Instruction::IF_LE: opcode = Instruction::IF_GT; break; |
| 768 | case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break; |
| 769 | case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break; |
| 770 | case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break; |
| 771 | case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break; |
| 772 | case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break; |
| 773 | case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break; |
| 774 | default: LOG(FATAL) << "Unexpected opcode " << opcode; |
| 775 | } |
| 776 | prev->last_mir_insn->dalvikInsn.opcode = opcode; |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 777 | BasicBlockId t_bb = prev->taken; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 778 | prev->taken = prev->fall_through; |
| 779 | prev->fall_through = t_bb; |
| 780 | break; |
| 781 | } |
| 782 | walker = prev; |
| 783 | } |
| 784 | return false; |
| 785 | } |
| 786 | |
| 787 | /* Combine any basic blocks terminated by instructions that we now know can't throw */ |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 788 | void MIRGraph::CombineBlocks(class BasicBlock* bb) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 789 | // Loop here to allow combining a sequence of blocks |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 790 | while ((bb->block_type == kDalvikByteCode) && |
| 791 | (bb->last_mir_insn != nullptr) && |
| 792 | (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) { |
| 793 | MIR* mir = bb->last_mir_insn; |
| 794 | DCHECK(bb->first_mir_insn != nullptr); |
| 795 | |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 796 | // Get the paired insn and check if it can still throw. |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 797 | MIR* throw_insn = mir->meta.throw_insn; |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 798 | if (CanThrow(throw_insn)) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 799 | break; |
| 800 | } |
| 801 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 802 | // OK - got one. Combine |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 803 | BasicBlock* bb_next = GetBasicBlock(bb->fall_through); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 804 | DCHECK(!bb_next->catch_entry); |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 805 | DCHECK_EQ(bb_next->predecessors.size(), 1u); |
Razvan A Lupusoru | c7a77bf | 2014-10-29 18:42:27 -0700 | [diff] [blame] | 806 | |
| 807 | // Now move instructions from bb_next to bb. Start off with doing a sanity check |
| 808 | // that kMirOpCheck's throw instruction is first one in the bb_next. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 809 | DCHECK_EQ(bb_next->first_mir_insn, throw_insn); |
Razvan A Lupusoru | c7a77bf | 2014-10-29 18:42:27 -0700 | [diff] [blame] | 810 | // Now move all instructions (throw instruction to last one) from bb_next to bb. |
| 811 | MIR* last_to_move = bb_next->last_mir_insn; |
| 812 | bb_next->RemoveMIRList(throw_insn, last_to_move); |
| 813 | bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move); |
| 814 | // The kMirOpCheck instruction is not needed anymore. |
| 815 | mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop); |
| 816 | bb->RemoveMIR(mir); |
| 817 | |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 818 | // Before we overwrite successors, remove their predecessor links to bb. |
| 819 | bb_next->ErasePredecessor(bb->id); |
| 820 | if (bb->taken != NullBasicBlockId) { |
| 821 | DCHECK_EQ(bb->successor_block_list_type, kNotUsed); |
| 822 | BasicBlock* bb_taken = GetBasicBlock(bb->taken); |
| 823 | // bb->taken will be overwritten below. |
| 824 | DCHECK_EQ(bb_taken->block_type, kExceptionHandling); |
| 825 | DCHECK_EQ(bb_taken->predecessors.size(), 1u); |
| 826 | DCHECK_EQ(bb_taken->predecessors[0], bb->id); |
| 827 | bb_taken->predecessors.clear(); |
| 828 | bb_taken->block_type = kDead; |
| 829 | DCHECK(bb_taken->data_flow_info == nullptr); |
| 830 | } else { |
| 831 | DCHECK_EQ(bb->successor_block_list_type, kCatch); |
| 832 | for (SuccessorBlockInfo* succ_info : bb->successor_blocks) { |
| 833 | if (succ_info->block != NullBasicBlockId) { |
| 834 | BasicBlock* succ_bb = GetBasicBlock(succ_info->block); |
| 835 | DCHECK(succ_bb->catch_entry); |
| 836 | succ_bb->ErasePredecessor(bb->id); |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 837 | } |
| 838 | } |
| 839 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 840 | // Use the successor info from the next block |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 841 | bb->successor_block_list_type = bb_next->successor_block_list_type; |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 842 | bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying. |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 843 | bb_next->successor_block_list_type = kNotUsed; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 844 | // Use the ending block linkage from the next block |
| 845 | bb->fall_through = bb_next->fall_through; |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 846 | bb_next->fall_through = NullBasicBlockId; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 847 | bb->taken = bb_next->taken; |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 848 | bb_next->taken = NullBasicBlockId; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 849 | /* |
Junmo Park | f1770fd | 2014-08-12 09:34:54 +0900 | [diff] [blame] | 850 | * If lower-half of pair of blocks to combine contained |
| 851 | * a return or a conditional branch or an explicit throw, |
| 852 | * move the flag to the newly combined block. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 853 | */ |
| 854 | bb->terminated_by_return = bb_next->terminated_by_return; |
Junmo Park | f1770fd | 2014-08-12 09:34:54 +0900 | [diff] [blame] | 855 | bb->conditional_branch = bb_next->conditional_branch; |
| 856 | bb->explicit_throw = bb_next->explicit_throw; |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 857 | // Merge the use_lvn flag. |
| 858 | bb->use_lvn |= bb_next->use_lvn; |
| 859 | |
| 860 | // Kill the unused block. |
| 861 | bb_next->data_flow_info = nullptr; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 862 | |
| 863 | /* |
| 864 | * NOTE: we aren't updating all dataflow info here. Should either make sure this pass |
| 865 | * happens after uses of i_dominated, dom_frontier or update the dataflow info here. |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 866 | * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 867 | */ |
| 868 | |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 869 | // Kill bb_next and remap now-dead id to parent. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 870 | bb_next->block_type = kDead; |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 871 | bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.) |
buzbee | 1fd3346 | 2013-03-25 13:40:45 -0700 | [diff] [blame] | 872 | block_id_map_.Overwrite(bb_next->id, bb->id); |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 873 | // Update predecessors in children. |
| 874 | ChildBlockIterator iter(bb, this); |
| 875 | for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) { |
| 876 | child->UpdatePredecessor(bb_next->id, bb->id); |
| 877 | } |
| 878 | |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 879 | // DFS orders, domination and topological order are not up to date anymore. |
Vladimir Marko | 312eb25 | 2014-10-07 15:01:57 +0100 | [diff] [blame] | 880 | dfs_orders_up_to_date_ = false; |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 881 | domination_up_to_date_ = false; |
| 882 | topological_order_up_to_date_ = false; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 883 | |
| 884 | // Now, loop back and see if we can keep going |
| 885 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 886 | } |
| 887 | |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 888 | bool MIRGraph::EliminateNullChecksGate() { |
| 889 | if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 || |
| 890 | (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) { |
| 891 | return false; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 892 | } |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 893 | |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 894 | DCHECK(temp_scoped_alloc_.get() == nullptr); |
| 895 | temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack)); |
Razvan A Lupusoru | c7a77bf | 2014-10-29 18:42:27 -0700 | [diff] [blame] | 896 | temp_.nce.num_vregs = GetNumOfCodeAndTempVRs(); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 897 | temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector( |
| 898 | temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck); |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 899 | temp_.nce.ending_vregs_to_check_matrix = |
| 900 | temp_scoped_alloc_->AllocArray<ArenaBitVector*>(GetNumBlocks(), kArenaAllocMisc); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 901 | std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr); |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 902 | |
| 903 | // reset MIR_MARK |
| 904 | AllNodesIterator iter(this); |
| 905 | for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) { |
| 906 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
| 907 | mir->optimization_flags &= ~MIR_MARK; |
| 908 | } |
| 909 | } |
| 910 | |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 911 | return true; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 912 | } |
| 913 | |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 914 | /* |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 915 | * Eliminate unnecessary null checks for a basic block. |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 916 | */ |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 917 | bool MIRGraph::EliminateNullChecks(BasicBlock* bb) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 918 | if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) { |
| 919 | // Ignore the kExitBlock as well. |
| 920 | DCHECK(bb->first_mir_insn == nullptr); |
| 921 | return false; |
| 922 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 923 | |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 924 | ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check; |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 925 | /* |
| 926 | * Set initial state. Catch blocks don't need any special treatment. |
| 927 | */ |
| 928 | if (bb->block_type == kEntryBlock) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 929 | vregs_to_check->ClearAllBits(); |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 930 | // Assume all ins are objects. |
| 931 | for (uint16_t in_reg = GetFirstInVR(); |
| 932 | in_reg < GetNumOfCodeVRs(); in_reg++) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 933 | vregs_to_check->SetBit(in_reg); |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 934 | } |
| 935 | if ((cu_->access_flags & kAccStatic) == 0) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 936 | // If non-static method, mark "this" as non-null. |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 937 | int this_reg = GetFirstInVR(); |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 938 | vregs_to_check->ClearBit(this_reg); |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 939 | } |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 940 | } else { |
| 941 | DCHECK_EQ(bb->block_type, kDalvikByteCode); |
| 942 | // Starting state is union of all incoming arcs. |
| 943 | bool copied_first = false; |
| 944 | for (BasicBlockId pred_id : bb->predecessors) { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 945 | if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 946 | continue; |
| 947 | } |
| 948 | BasicBlock* pred_bb = GetBasicBlock(pred_id); |
| 949 | DCHECK(pred_bb != nullptr); |
| 950 | MIR* null_check_insn = nullptr; |
| 951 | if (pred_bb->block_type == kDalvikByteCode) { |
| 952 | // Check to see if predecessor had an explicit null-check. |
| 953 | MIR* last_insn = pred_bb->last_mir_insn; |
| 954 | if (last_insn != nullptr) { |
| 955 | Instruction::Code last_opcode = last_insn->dalvikInsn.opcode; |
| 956 | if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) || |
| 957 | (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) { |
| 958 | // Remember the null check insn if there's no other predecessor requiring null check. |
| 959 | if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) { |
| 960 | null_check_insn = last_insn; |
| 961 | } |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 962 | } |
Ian Rogers | 22fd6a0 | 2013-06-13 15:06:54 -0700 | [diff] [blame] | 963 | } |
| 964 | } |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 965 | if (!copied_first) { |
| 966 | copied_first = true; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 967 | vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]); |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 968 | } else { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 969 | vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]); |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 970 | } |
| 971 | if (null_check_insn != nullptr) { |
| 972 | vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA); |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 973 | } |
| 974 | } |
| 975 | DCHECK(copied_first); // At least one predecessor must have been processed before this bb. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 976 | } |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 977 | // At this point, vregs_to_check shows which sregs have an object definition with |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 978 | // no intervening uses. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 979 | |
| 980 | // Walk through the instruction in the block, updating as necessary |
| 981 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
Jean Christophe Beyler | cc794c3 | 2014-05-02 09:34:13 -0700 | [diff] [blame] | 982 | uint64_t df_attributes = GetDataFlowAttributes(mir); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 983 | |
Razvan A Lupusoru | c7a77bf | 2014-10-29 18:42:27 -0700 | [diff] [blame] | 984 | if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) { |
| 985 | // The algorithm was written in a phi agnostic way. |
| 986 | continue; |
| 987 | } |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 988 | |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 989 | // Might need a null check? |
| 990 | if (df_attributes & DF_HAS_NULL_CHKS) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 991 | int src_vreg; |
| 992 | if (df_attributes & DF_NULL_CHK_OUT0) { |
| 993 | DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u); |
| 994 | src_vreg = mir->dalvikInsn.vC; |
| 995 | } else if (df_attributes & DF_NULL_CHK_B) { |
| 996 | DCHECK_NE(df_attributes & DF_REF_B, 0u); |
| 997 | src_vreg = mir->dalvikInsn.vB; |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 998 | } else { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 999 | DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u); |
| 1000 | DCHECK_NE(df_attributes & DF_REF_A, 0u); |
| 1001 | src_vreg = mir->dalvikInsn.vA; |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1002 | } |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1003 | if (!vregs_to_check->IsBitSet(src_vreg)) { |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1004 | // Eliminate the null check. |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 1005 | mir->optimization_flags |= MIR_MARK; |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1006 | } else { |
| 1007 | // Do the null check. |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 1008 | mir->optimization_flags &= ~MIR_MARK; |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1009 | // Mark src_vreg as null-checked. |
| 1010 | vregs_to_check->ClearBit(src_vreg); |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1011 | } |
| 1012 | } |
| 1013 | |
| 1014 | if ((df_attributes & DF_A_WIDE) || |
| 1015 | (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) { |
| 1016 | continue; |
| 1017 | } |
| 1018 | |
| 1019 | /* |
| 1020 | * First, mark all object definitions as requiring null check. |
| 1021 | * Note: we can't tell if a CONST definition might be used as an object, so treat |
| 1022 | * them all as object definitions. |
| 1023 | */ |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1024 | if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) || |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1025 | (df_attributes & DF_SETS_CONST)) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1026 | vregs_to_check->SetBit(mir->dalvikInsn.vA); |
buzbee | 4db179d | 2013-10-23 12:16:39 -0700 | [diff] [blame] | 1027 | } |
| 1028 | |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1029 | // Then, remove mark from all object definitions we know are non-null. |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1030 | if (df_attributes & DF_NON_NULL_DST) { |
| 1031 | // Mark target of NEW* as non-null |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1032 | DCHECK_NE(df_attributes & DF_REF_A, 0u); |
| 1033 | vregs_to_check->ClearBit(mir->dalvikInsn.vA); |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1034 | } |
| 1035 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1036 | // Mark non-null returns from invoke-style NEW* |
| 1037 | if (df_attributes & DF_NON_NULL_RET) { |
| 1038 | MIR* next_mir = mir->next; |
| 1039 | // Next should be an MOVE_RESULT_OBJECT |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1040 | if (UNLIKELY(next_mir == nullptr)) { |
| 1041 | // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch |
| 1042 | // target, so the MOVE_RESULT cannot be broken away into another block. |
| 1043 | LOG(WARNING) << "Unexpected end of block following new"; |
| 1044 | } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) { |
| 1045 | LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1046 | } else { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1047 | // Mark as null checked. |
| 1048 | vregs_to_check->ClearBit(next_mir->dalvikInsn.vA); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1049 | } |
| 1050 | } |
| 1051 | |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1052 | // Propagate null check state on register copies. |
| 1053 | if (df_attributes & DF_NULL_TRANSFER_0) { |
| 1054 | DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1)); |
| 1055 | if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) { |
| 1056 | vregs_to_check->SetBit(mir->dalvikInsn.vA); |
Bill Buzbee | 0b1191c | 2013-10-28 22:11:59 +0000 | [diff] [blame] | 1057 | } else { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1058 | vregs_to_check->ClearBit(mir->dalvikInsn.vA); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1059 | } |
| 1060 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1061 | } |
| 1062 | |
| 1063 | // Did anything change? |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1064 | bool nce_changed = false; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1065 | ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id]; |
Vladimir Marko | 5229cf1 | 2014-10-09 14:57:59 +0100 | [diff] [blame] | 1066 | if (old_ending_ssa_regs_to_check == nullptr) { |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 1067 | DCHECK(temp_scoped_alloc_.get() != nullptr); |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1068 | nce_changed = vregs_to_check->GetHighestBitSet() != -1; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1069 | temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check; |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1070 | // Create a new vregs_to_check for next BB. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1071 | temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector( |
| 1072 | temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck); |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1073 | } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) { |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 1074 | nce_changed = true; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1075 | temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check; |
| 1076 | temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1077 | } |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 1078 | return nce_changed; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1079 | } |
| 1080 | |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 1081 | void MIRGraph::EliminateNullChecksEnd() { |
| 1082 | // Clean up temporaries. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1083 | temp_.nce.num_vregs = 0u; |
| 1084 | temp_.nce.work_vregs_to_check = nullptr; |
| 1085 | temp_.nce.ending_vregs_to_check_matrix = nullptr; |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 1086 | DCHECK(temp_scoped_alloc_.get() != nullptr); |
| 1087 | temp_scoped_alloc_.reset(); |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 1088 | |
| 1089 | // converge MIR_MARK with MIR_IGNORE_NULL_CHECK |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 1090 | AllNodesIterator iter(this); |
| 1091 | for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) { |
| 1092 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1093 | constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck; |
Andreas Gampe | 785d2f2 | 2014-11-03 22:57:30 -0800 | [diff] [blame] | 1094 | static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift"); |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 1095 | uint16_t mirMarkAdjustedToIgnoreNullCheck = |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1096 | (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift; |
Yevgeny Rouban | 423b137 | 2014-10-15 17:32:25 +0700 | [diff] [blame] | 1097 | mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck; |
| 1098 | } |
| 1099 | } |
Vladimir Marko | 67c72b8 | 2014-10-09 12:26:10 +0100 | [diff] [blame] | 1100 | } |
| 1101 | |
| 1102 | /* |
| 1103 | * Perform type and size inference for a basic block. |
| 1104 | */ |
| 1105 | bool MIRGraph::InferTypes(BasicBlock* bb) { |
| 1106 | if (bb->data_flow_info == nullptr) return false; |
| 1107 | |
| 1108 | bool infer_changed = false; |
| 1109 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
| 1110 | if (mir->ssa_rep == NULL) { |
| 1111 | continue; |
| 1112 | } |
| 1113 | |
| 1114 | // Propagate type info. |
| 1115 | infer_changed = InferTypeAndSize(bb, mir, infer_changed); |
| 1116 | } |
| 1117 | |
| 1118 | return infer_changed; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1119 | } |
| 1120 | |
| 1121 | bool MIRGraph::EliminateClassInitChecksGate() { |
| 1122 | if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 || |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1123 | (merged_df_flags_ & DF_CLINIT) == 0) { |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1124 | return false; |
| 1125 | } |
| 1126 | |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1127 | DCHECK(temp_scoped_alloc_.get() == nullptr); |
| 1128 | temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack)); |
| 1129 | |
| 1130 | // Each insn we use here has at least 2 code units, offset/2 will be a unique index. |
Razvan A Lupusoru | 7503597 | 2014-09-11 15:24:59 -0700 | [diff] [blame] | 1131 | const size_t end = (GetNumDalvikInsns() + 1u) / 2u; |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 1132 | temp_.cice.indexes = temp_scoped_alloc_->AllocArray<uint16_t>(end, kArenaAllocGrowableArray); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1133 | std::fill_n(temp_.cice.indexes, end, 0xffffu); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1134 | |
| 1135 | uint32_t unique_class_count = 0u; |
| 1136 | { |
| 1137 | // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested |
| 1138 | // ScopedArenaAllocator. |
| 1139 | |
| 1140 | // Embed the map value in the entry to save space. |
| 1141 | struct MapEntry { |
| 1142 | // Map key: the class identified by the declaring dex file and type index. |
| 1143 | const DexFile* declaring_dex_file; |
| 1144 | uint16_t declaring_class_idx; |
| 1145 | // Map value: index into bit vectors of classes requiring initialization checks. |
| 1146 | uint16_t index; |
| 1147 | }; |
| 1148 | struct MapEntryComparator { |
| 1149 | bool operator()(const MapEntry& lhs, const MapEntry& rhs) const { |
| 1150 | if (lhs.declaring_class_idx != rhs.declaring_class_idx) { |
| 1151 | return lhs.declaring_class_idx < rhs.declaring_class_idx; |
| 1152 | } |
| 1153 | return lhs.declaring_dex_file < rhs.declaring_dex_file; |
| 1154 | } |
| 1155 | }; |
| 1156 | |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1157 | ScopedArenaAllocator allocator(&cu_->arena_stack); |
Vladimir Marko | 69f08ba | 2014-04-11 12:28:11 +0100 | [diff] [blame] | 1158 | ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(), |
| 1159 | allocator.Adapter()); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1160 | |
| 1161 | // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs. |
| 1162 | AllNodesIterator iter(this); |
| 1163 | for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1164 | if (bb->block_type == kDalvikByteCode) { |
| 1165 | for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) { |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1166 | if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1167 | const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir); |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1168 | if (!field_info.IsReferrersClass()) { |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1169 | DCHECK_LT(class_to_index_map.size(), 0xffffu); |
| 1170 | MapEntry entry = { |
| 1171 | // Treat unresolved fields as if each had its own class. |
| 1172 | field_info.IsResolved() ? field_info.DeclaringDexFile() |
| 1173 | : nullptr, |
| 1174 | field_info.IsResolved() ? field_info.DeclaringClassIndex() |
| 1175 | : field_info.FieldIndex(), |
| 1176 | static_cast<uint16_t>(class_to_index_map.size()) |
| 1177 | }; |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1178 | uint16_t index = class_to_index_map.insert(entry).first->index; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1179 | // Using offset/2 for index into temp_.cice.indexes. |
| 1180 | temp_.cice.indexes[mir->offset / 2u] = index; |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1181 | } |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1182 | } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) { |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1183 | const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir); |
| 1184 | DCHECK(method_info.IsStatic()); |
| 1185 | if (method_info.FastPath() && !method_info.IsReferrersClass()) { |
| 1186 | MapEntry entry = { |
| 1187 | method_info.DeclaringDexFile(), |
| 1188 | method_info.DeclaringClassIndex(), |
| 1189 | static_cast<uint16_t>(class_to_index_map.size()) |
| 1190 | }; |
| 1191 | uint16_t index = class_to_index_map.insert(entry).first->index; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1192 | // Using offset/2 for index into temp_.cice.indexes. |
| 1193 | temp_.cice.indexes[mir->offset / 2u] = index; |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1194 | } |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1195 | } |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1196 | } |
| 1197 | } |
| 1198 | } |
| 1199 | unique_class_count = static_cast<uint32_t>(class_to_index_map.size()); |
| 1200 | } |
| 1201 | |
| 1202 | if (unique_class_count == 0u) { |
| 1203 | // All SGET/SPUTs refer to initialized classes. Nothing to do. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1204 | temp_.cice.indexes = nullptr; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1205 | temp_scoped_alloc_.reset(); |
| 1206 | return false; |
| 1207 | } |
| 1208 | |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1209 | // 2 bits for each class: is class initialized, is class in dex cache. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1210 | temp_.cice.num_class_bits = 2u * unique_class_count; |
| 1211 | temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector( |
| 1212 | temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck); |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 1213 | temp_.cice.ending_classes_to_check_matrix = |
| 1214 | temp_scoped_alloc_->AllocArray<ArenaBitVector*>(GetNumBlocks(), kArenaAllocMisc); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1215 | std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr); |
| 1216 | DCHECK_GT(temp_.cice.num_class_bits, 0u); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1217 | return true; |
| 1218 | } |
| 1219 | |
| 1220 | /* |
| 1221 | * Eliminate unnecessary class initialization checks for a basic block. |
| 1222 | */ |
| 1223 | bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) { |
| 1224 | DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u); |
Vladimir Marko | 7baa6f8 | 2014-10-09 18:01:24 +0100 | [diff] [blame] | 1225 | if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) { |
| 1226 | // Ignore the kExitBlock as well. |
| 1227 | DCHECK(bb->first_mir_insn == nullptr); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1228 | return false; |
| 1229 | } |
| 1230 | |
| 1231 | /* |
Vladimir Marko | 0a810d2 | 2014-07-11 14:44:36 +0100 | [diff] [blame] | 1232 | * Set initial state. Catch blocks don't need any special treatment. |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1233 | */ |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1234 | ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1235 | DCHECK(classes_to_check != nullptr); |
Vladimir Marko | 0a810d2 | 2014-07-11 14:44:36 +0100 | [diff] [blame] | 1236 | if (bb->block_type == kEntryBlock) { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1237 | classes_to_check->SetInitialBits(temp_.cice.num_class_bits); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1238 | } else { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1239 | // Starting state is union of all incoming arcs. |
| 1240 | bool copied_first = false; |
| 1241 | for (BasicBlockId pred_id : bb->predecessors) { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1242 | if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) { |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1243 | continue; |
| 1244 | } |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1245 | if (!copied_first) { |
| 1246 | copied_first = true; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1247 | classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]); |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1248 | } else { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1249 | classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]); |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1250 | } |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1251 | } |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1252 | DCHECK(copied_first); // At least one predecessor must have been processed before this bb. |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1253 | } |
| 1254 | // At this point, classes_to_check shows which classes need clinit checks. |
| 1255 | |
| 1256 | // Walk through the instruction in the block, updating as necessary |
| 1257 | for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1258 | uint16_t index = temp_.cice.indexes[mir->offset / 2u]; |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1259 | if (index != 0xffffu) { |
| 1260 | bool check_initialization = false; |
| 1261 | bool check_dex_cache = false; |
| 1262 | |
| 1263 | // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC. |
| 1264 | // Dex instructions with width 1 can have the same offset/2. |
| 1265 | |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1266 | if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) { |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1267 | check_initialization = true; |
| 1268 | check_dex_cache = true; |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1269 | } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) { |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1270 | check_initialization = true; |
| 1271 | // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache. |
| 1272 | } |
| 1273 | |
| 1274 | if (check_dex_cache) { |
| 1275 | uint32_t check_dex_cache_index = 2u * index + 1u; |
| 1276 | if (!classes_to_check->IsBitSet(check_dex_cache_index)) { |
| 1277 | // Eliminate the class init check. |
| 1278 | mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE; |
| 1279 | } else { |
| 1280 | // Do the class init check. |
| 1281 | mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE; |
| 1282 | } |
| 1283 | classes_to_check->ClearBit(check_dex_cache_index); |
| 1284 | } |
| 1285 | if (check_initialization) { |
| 1286 | uint32_t check_clinit_index = 2u * index; |
| 1287 | if (!classes_to_check->IsBitSet(check_clinit_index)) { |
| 1288 | // Eliminate the class init check. |
| 1289 | mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED; |
| 1290 | } else { |
| 1291 | // Do the class init check. |
| 1292 | mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1293 | } |
| 1294 | // Mark the class as initialized. |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1295 | classes_to_check->ClearBit(check_clinit_index); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1296 | } |
| 1297 | } |
| 1298 | } |
| 1299 | |
| 1300 | // Did anything change? |
| 1301 | bool changed = false; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1302 | ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id]; |
Vladimir Marko | 5229cf1 | 2014-10-09 14:57:59 +0100 | [diff] [blame] | 1303 | if (old_ending_classes_to_check == nullptr) { |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1304 | DCHECK(temp_scoped_alloc_.get() != nullptr); |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1305 | changed = classes_to_check->GetHighestBitSet() != -1; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1306 | temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check; |
Vladimir Marko | 5229cf1 | 2014-10-09 14:57:59 +0100 | [diff] [blame] | 1307 | // Create a new classes_to_check for next BB. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1308 | temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector( |
| 1309 | temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck); |
Vladimir Marko | 5229cf1 | 2014-10-09 14:57:59 +0100 | [diff] [blame] | 1310 | } else if (!classes_to_check->Equal(old_ending_classes_to_check)) { |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1311 | changed = true; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1312 | temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check; |
| 1313 | temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB. |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1314 | } |
| 1315 | return changed; |
| 1316 | } |
| 1317 | |
| 1318 | void MIRGraph::EliminateClassInitChecksEnd() { |
| 1319 | // Clean up temporaries. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1320 | temp_.cice.num_class_bits = 0u; |
| 1321 | temp_.cice.work_classes_to_check = nullptr; |
| 1322 | temp_.cice.ending_classes_to_check_matrix = nullptr; |
| 1323 | DCHECK(temp_.cice.indexes != nullptr); |
| 1324 | temp_.cice.indexes = nullptr; |
Vladimir Marko | bfea9c2 | 2014-01-17 17:49:33 +0000 | [diff] [blame] | 1325 | DCHECK(temp_scoped_alloc_.get() != nullptr); |
| 1326 | temp_scoped_alloc_.reset(); |
| 1327 | } |
| 1328 | |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1329 | bool MIRGraph::ApplyGlobalValueNumberingGate() { |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 1330 | if (GlobalValueNumbering::Skip(cu_)) { |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1331 | return false; |
| 1332 | } |
| 1333 | |
| 1334 | DCHECK(temp_scoped_alloc_ == nullptr); |
| 1335 | temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack)); |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1336 | temp_.gvn.ifield_ids_ = |
| 1337 | GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_); |
| 1338 | temp_.gvn.sfield_ids_ = |
| 1339 | GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1340 | DCHECK(temp_.gvn.gvn == nullptr); |
| 1341 | temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering( |
| 1342 | cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1343 | return true; |
| 1344 | } |
| 1345 | |
| 1346 | bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1347 | DCHECK(temp_.gvn.gvn != nullptr); |
| 1348 | LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1349 | if (lvn != nullptr) { |
| 1350 | for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) { |
| 1351 | lvn->GetValueNumber(mir); |
| 1352 | } |
| 1353 | } |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1354 | bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1355 | return change; |
| 1356 | } |
| 1357 | |
| 1358 | void MIRGraph::ApplyGlobalValueNumberingEnd() { |
| 1359 | // Perform modifications. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1360 | DCHECK(temp_.gvn.gvn != nullptr); |
| 1361 | if (temp_.gvn.gvn->Good()) { |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 1362 | if (max_nested_loops_ != 0u) { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1363 | temp_.gvn.gvn->StartPostProcessing(); |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 1364 | TopologicalSortIterator iter(this); |
| 1365 | for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) { |
| 1366 | ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN. |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1367 | LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator); |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 1368 | if (lvn != nullptr) { |
| 1369 | for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) { |
| 1370 | lvn->GetValueNumber(mir); |
| 1371 | } |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1372 | bool change = temp_.gvn.gvn->FinishBasicBlock(bb); |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 1373 | DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1374 | } |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1375 | } |
| 1376 | } |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 1377 | // GVN was successful, running the LVN would be useless. |
| 1378 | cu_->disable_opt |= (1u << kLocalValueNumbering); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1379 | } else { |
| 1380 | LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file); |
| 1381 | } |
| 1382 | |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1383 | delete temp_.gvn.gvn; |
| 1384 | temp_.gvn.gvn = nullptr; |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1385 | temp_.gvn.ifield_ids_ = nullptr; |
| 1386 | temp_.gvn.sfield_ids_ = nullptr; |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 1387 | DCHECK(temp_scoped_alloc_ != nullptr); |
| 1388 | temp_scoped_alloc_.reset(); |
| 1389 | } |
| 1390 | |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1391 | void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) { |
| 1392 | uint32_t method_index = invoke->meta.method_lowering_info; |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1393 | if (temp_.smi.processed_indexes->IsBitSet(method_index)) { |
| 1394 | iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index]; |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1395 | DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex()); |
| 1396 | return; |
| 1397 | } |
| 1398 | |
| 1399 | const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke); |
| 1400 | MethodReference target = method_info.GetTargetMethod(); |
| 1401 | DexCompilationUnit inlined_unit( |
| 1402 | cu_, cu_->class_loader, cu_->class_linker, *target.dex_file, |
| 1403 | nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index, |
| 1404 | 0u /* access_flags not used */, nullptr /* verified_method not used */); |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1405 | DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode); |
| 1406 | MirIFieldLoweringInfo inlined_field_info(field_idx, type); |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1407 | MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u); |
| 1408 | DCHECK(inlined_field_info.IsResolved()); |
| 1409 | |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1410 | uint32_t field_info_index = ifield_lowering_infos_.size(); |
| 1411 | ifield_lowering_infos_.push_back(inlined_field_info); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1412 | temp_.smi.processed_indexes->SetBit(method_index); |
| 1413 | temp_.smi.lowering_infos[method_index] = field_info_index; |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1414 | iget_or_iput->meta.ifield_lowering_info = field_info_index; |
| 1415 | } |
| 1416 | |
Razvan A Lupusoru | cb80474 | 2014-07-09 16:42:19 -0700 | [diff] [blame] | 1417 | bool MIRGraph::InlineSpecialMethodsGate() { |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1418 | if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 || |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 1419 | method_lowering_infos_.size() == 0u) { |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1420 | return false; |
| 1421 | } |
| 1422 | if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) { |
| 1423 | // This isn't the Quick compiler. |
| 1424 | return false; |
| 1425 | } |
| 1426 | return true; |
| 1427 | } |
| 1428 | |
Razvan A Lupusoru | cb80474 | 2014-07-09 16:42:19 -0700 | [diff] [blame] | 1429 | void MIRGraph::InlineSpecialMethodsStart() { |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1430 | // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from |
| 1431 | // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index. |
| 1432 | |
| 1433 | DCHECK(temp_scoped_alloc_.get() == nullptr); |
| 1434 | temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack)); |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1435 | temp_.smi.num_indexes = method_lowering_infos_.size(); |
| 1436 | temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector( |
| 1437 | temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc); |
| 1438 | temp_.smi.processed_indexes->ClearAllBits(); |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 1439 | temp_.smi.lowering_infos = |
| 1440 | temp_scoped_alloc_->AllocArray<uint16_t>(temp_.smi.num_indexes, kArenaAllocGrowableArray); |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1441 | } |
| 1442 | |
Razvan A Lupusoru | cb80474 | 2014-07-09 16:42:19 -0700 | [diff] [blame] | 1443 | void MIRGraph::InlineSpecialMethods(BasicBlock* bb) { |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1444 | if (bb->block_type != kDalvikByteCode) { |
| 1445 | return; |
| 1446 | } |
| 1447 | for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) { |
Jean Christophe Beyler | 2ab40eb | 2014-06-02 09:03:14 -0700 | [diff] [blame] | 1448 | if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) { |
buzbee | 35ba7f3 | 2014-05-31 08:59:01 -0700 | [diff] [blame] | 1449 | continue; |
| 1450 | } |
Jean Christophe Beyler | fb0ea2d | 2014-07-29 13:20:42 -0700 | [diff] [blame] | 1451 | if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) { |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1452 | continue; |
| 1453 | } |
| 1454 | const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir); |
| 1455 | if (!method_info.FastPath()) { |
| 1456 | continue; |
| 1457 | } |
Razvan A Lupusoru | c80605d | 2014-09-11 14:12:17 -0700 | [diff] [blame] | 1458 | |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1459 | InvokeType sharp_type = method_info.GetSharpType(); |
Razvan A Lupusoru | c80605d | 2014-09-11 14:12:17 -0700 | [diff] [blame] | 1460 | if ((sharp_type != kDirect) && (sharp_type != kStatic)) { |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1461 | continue; |
| 1462 | } |
Razvan A Lupusoru | c80605d | 2014-09-11 14:12:17 -0700 | [diff] [blame] | 1463 | |
| 1464 | if (sharp_type == kStatic) { |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 1465 | bool needs_clinit = !method_info.IsClassInitialized() && |
| 1466 | ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0); |
Razvan A Lupusoru | c80605d | 2014-09-11 14:12:17 -0700 | [diff] [blame] | 1467 | if (needs_clinit) { |
| 1468 | continue; |
| 1469 | } |
| 1470 | } |
| 1471 | |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1472 | DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr); |
| 1473 | MethodReference target = method_info.GetTargetMethod(); |
| 1474 | if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file) |
| 1475 | ->GenInline(this, bb, mir, target.dex_method_index)) { |
Razvan A Lupusoru | cb80474 | 2014-07-09 16:42:19 -0700 | [diff] [blame] | 1476 | if (cu_->verbose || cu_->print_pass) { |
| 1477 | LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " (" |
| 1478 | << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file) |
| 1479 | << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file) |
| 1480 | << "\" @0x" << std::hex << mir->offset; |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1481 | } |
| 1482 | } |
| 1483 | } |
| 1484 | } |
| 1485 | |
Razvan A Lupusoru | cb80474 | 2014-07-09 16:42:19 -0700 | [diff] [blame] | 1486 | void MIRGraph::InlineSpecialMethodsEnd() { |
Vladimir Marko | f585e54 | 2014-11-21 13:41:32 +0000 | [diff] [blame] | 1487 | // Clean up temporaries. |
| 1488 | DCHECK(temp_.smi.lowering_infos != nullptr); |
| 1489 | temp_.smi.lowering_infos = nullptr; |
| 1490 | temp_.smi.num_indexes = 0u; |
| 1491 | DCHECK(temp_.smi.processed_indexes != nullptr); |
| 1492 | temp_.smi.processed_indexes = nullptr; |
Vladimir Marko | 9820b7c | 2014-01-02 16:40:37 +0000 | [diff] [blame] | 1493 | DCHECK(temp_scoped_alloc_.get() != nullptr); |
| 1494 | temp_scoped_alloc_.reset(); |
| 1495 | } |
| 1496 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 1497 | void MIRGraph::DumpCheckStats() { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1498 | Checkstats* stats = |
Vladimir Marko | 83cc7ae | 2014-02-12 18:02:05 +0000 | [diff] [blame] | 1499 | static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo)); |
buzbee | 1fd3346 | 2013-03-25 13:40:45 -0700 | [diff] [blame] | 1500 | checkstats_ = stats; |
buzbee | 56c7178 | 2013-09-05 17:13:19 -0700 | [diff] [blame] | 1501 | AllNodesIterator iter(this); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1502 | for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) { |
| 1503 | CountChecks(bb); |
| 1504 | } |
| 1505 | if (stats->null_checks > 0) { |
| 1506 | float eliminated = static_cast<float>(stats->null_checks_eliminated); |
| 1507 | float checks = static_cast<float>(stats->null_checks); |
| 1508 | LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " " |
| 1509 | << stats->null_checks_eliminated << " of " << stats->null_checks << " -> " |
| 1510 | << (eliminated/checks) * 100.0 << "%"; |
| 1511 | } |
| 1512 | if (stats->range_checks > 0) { |
| 1513 | float eliminated = static_cast<float>(stats->range_checks_eliminated); |
| 1514 | float checks = static_cast<float>(stats->range_checks); |
| 1515 | LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " " |
| 1516 | << stats->range_checks_eliminated << " of " << stats->range_checks << " -> " |
| 1517 | << (eliminated/checks) * 100.0 << "%"; |
| 1518 | } |
| 1519 | } |
| 1520 | |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 1521 | bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) { |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1522 | if (bb->visited) return false; |
| 1523 | if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode) |
| 1524 | || (bb->block_type == kExitBlock))) { |
| 1525 | // Ignore special blocks |
| 1526 | bb->visited = true; |
| 1527 | return false; |
| 1528 | } |
| 1529 | // Must be head of extended basic block. |
| 1530 | BasicBlock* start_bb = bb; |
buzbee | 0d82948 | 2013-10-11 15:24:55 -0700 | [diff] [blame] | 1531 | extended_basic_blocks_.push_back(bb->id); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1532 | bool terminated_by_return = false; |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 1533 | bool do_local_value_numbering = false; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1534 | // Visit blocks strictly dominated by this head. |
| 1535 | while (bb != NULL) { |
| 1536 | bb->visited = true; |
| 1537 | terminated_by_return |= bb->terminated_by_return; |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 1538 | do_local_value_numbering |= bb->use_lvn; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1539 | bb = NextDominatedBlock(bb); |
| 1540 | } |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 1541 | if (terminated_by_return || do_local_value_numbering) { |
| 1542 | // Do lvn for all blocks in this extended set. |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1543 | bb = start_bb; |
| 1544 | while (bb != NULL) { |
buzbee | 1da1e2f | 2013-11-15 13:37:01 -0800 | [diff] [blame] | 1545 | bb->use_lvn = do_local_value_numbering; |
| 1546 | bb->dominates_return = terminated_by_return; |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1547 | bb = NextDominatedBlock(bb); |
| 1548 | } |
| 1549 | } |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 1550 | return false; // Not iterative - return value will be ignored |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1551 | } |
| 1552 | |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 1553 | void MIRGraph::BasicBlockOptimizationStart() { |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1554 | if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) { |
| 1555 | temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack)); |
| 1556 | temp_.gvn.ifield_ids_ = |
| 1557 | GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_); |
| 1558 | temp_.gvn.sfield_ids_ = |
| 1559 | GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_); |
| 1560 | } |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 1561 | } |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1562 | |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 1563 | void MIRGraph::BasicBlockOptimization() { |
Jean Christophe Beyler | 4e97c53 | 2014-01-07 10:07:18 -0800 | [diff] [blame] | 1564 | if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) { |
| 1565 | ClearAllVisitedFlags(); |
| 1566 | PreOrderDfsIterator iter2(this); |
| 1567 | for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) { |
| 1568 | BuildExtendedBBList(bb); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1569 | } |
Jean Christophe Beyler | 4e97c53 | 2014-01-07 10:07:18 -0800 | [diff] [blame] | 1570 | // Perform extended basic block optimizations. |
| 1571 | for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) { |
| 1572 | BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i])); |
| 1573 | } |
| 1574 | } else { |
| 1575 | PreOrderDfsIterator iter(this); |
| 1576 | for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) { |
| 1577 | BasicBlockOpt(bb); |
| 1578 | } |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1579 | } |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 1580 | } |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1581 | |
Vladimir Marko | ffda499 | 2014-12-18 17:05:58 +0000 | [diff] [blame] | 1582 | void MIRGraph::BasicBlockOptimizationEnd() { |
Vladimir Marko | af6925b | 2014-10-31 16:37:32 +0000 | [diff] [blame] | 1583 | // Clean up after LVN. |
| 1584 | temp_.gvn.ifield_ids_ = nullptr; |
| 1585 | temp_.gvn.sfield_ids_ = nullptr; |
| 1586 | temp_scoped_alloc_.reset(); |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1587 | } |
| 1588 | |
Vladimir Marko | 8b858e1 | 2014-11-27 14:52:37 +0000 | [diff] [blame] | 1589 | bool MIRGraph::EliminateSuspendChecksGate() { |
| 1590 | if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled. |
| 1591 | GetMaxNestedLoops() == 0u || // Nothing to do. |
| 1592 | GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.]. |
| 1593 | // Exclude 32 as well to keep bit shifts well-defined. |
| 1594 | !HasInvokes()) { // No invokes to actually eliminate any suspend checks. |
| 1595 | return false; |
| 1596 | } |
| 1597 | if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) { |
| 1598 | temp_.sce.inliner = |
| 1599 | cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file); |
| 1600 | } |
Vladimir Marko | e4fcc5b | 2015-02-13 10:28:29 +0000 | [diff] [blame^] | 1601 | suspend_checks_in_loops_ = arena_->AllocArray<uint32_t>(GetNumBlocks(), kArenaAllocMisc); |
Vladimir Marko | 8b858e1 | 2014-11-27 14:52:37 +0000 | [diff] [blame] | 1602 | return true; |
| 1603 | } |
| 1604 | |
| 1605 | bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) { |
| 1606 | if (bb->block_type != kDalvikByteCode) { |
| 1607 | return false; |
| 1608 | } |
| 1609 | DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth); |
| 1610 | if (bb->nesting_depth == 0u) { |
| 1611 | // Out of loops. |
| 1612 | DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized. |
| 1613 | return false; |
| 1614 | } |
| 1615 | uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads. |
| 1616 | bool found_invoke = false; |
| 1617 | for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) { |
| 1618 | if (IsInstructionInvoke(mir->dalvikInsn.opcode) && |
| 1619 | (temp_.sce.inliner == nullptr || |
| 1620 | !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) { |
| 1621 | // Non-intrinsic invoke, rely on a suspend point in the invoked method. |
| 1622 | found_invoke = true; |
| 1623 | break; |
| 1624 | } |
| 1625 | } |
| 1626 | if (!found_invoke) { |
| 1627 | // Intersect suspend checks from predecessors. |
| 1628 | uint16_t bb_topo_idx = topological_order_indexes_[bb->id]; |
| 1629 | uint32_t pred_mask_union = 0u; |
| 1630 | for (BasicBlockId pred_id : bb->predecessors) { |
| 1631 | uint16_t pred_topo_idx = topological_order_indexes_[pred_id]; |
| 1632 | if (pred_topo_idx < bb_topo_idx) { |
| 1633 | // Determine the loop depth of the predecessors relative to this block. |
| 1634 | size_t pred_loop_depth = topological_order_loop_head_stack_.size(); |
| 1635 | while (pred_loop_depth != 0u && |
| 1636 | pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) { |
| 1637 | --pred_loop_depth; |
| 1638 | } |
| 1639 | DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth); |
| 1640 | uint32_t pred_mask = (1u << pred_loop_depth) - 1u; |
| 1641 | // Intersect pred_mask bits in suspend_checks_in_loops with |
| 1642 | // suspend_checks_in_loops_[pred_id]. |
| 1643 | uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id]; |
| 1644 | suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks; |
| 1645 | pred_mask_union |= pred_mask; |
| 1646 | } |
| 1647 | } |
| 1648 | DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u), |
| 1649 | pred_mask_union); |
| 1650 | suspend_checks_in_loops &= pred_mask_union; |
| 1651 | } |
| 1652 | suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops; |
| 1653 | if (suspend_checks_in_loops == 0u) { |
| 1654 | return false; |
| 1655 | } |
| 1656 | // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate. |
| 1657 | if (bb->taken != NullBasicBlockId) { |
| 1658 | DCHECK(bb->last_mir_insn != nullptr); |
| 1659 | DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) || |
| 1660 | IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) || |
| 1661 | IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) || |
| 1662 | (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat && |
| 1663 | static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong)); |
| 1664 | if (!IsSuspendCheckEdge(bb, bb->taken) && |
| 1665 | (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) { |
| 1666 | bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK; |
| 1667 | } |
| 1668 | } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) { |
| 1669 | // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check. |
| 1670 | MIR* mir = NewMIR(); |
| 1671 | mir->dalvikInsn.opcode = Instruction::GOTO; |
| 1672 | mir->dalvikInsn.vA = 0; // Branch offset. |
| 1673 | mir->offset = GetBasicBlock(bb->fall_through)->start_offset; |
| 1674 | mir->m_unit_index = current_method_; |
| 1675 | mir->ssa_rep = reinterpret_cast<SSARepresentation*>( |
| 1676 | arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized. |
| 1677 | bb->AppendMIR(mir); |
| 1678 | std::swap(bb->fall_through, bb->taken); // The fall-through has become taken. |
| 1679 | } |
| 1680 | return true; |
| 1681 | } |
| 1682 | |
| 1683 | void MIRGraph::EliminateSuspendChecksEnd() { |
| 1684 | temp_.sce.inliner = nullptr; |
| 1685 | } |
| 1686 | |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1687 | bool MIRGraph::CanThrow(MIR* mir) { |
| 1688 | if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) { |
| 1689 | return false; |
| 1690 | } |
| 1691 | const int opt_flags = mir->optimization_flags; |
| 1692 | uint64_t df_attributes = GetDataFlowAttributes(mir); |
| 1693 | |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1694 | // First, check if the insn can still throw NPE. |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1695 | if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) { |
| 1696 | return true; |
| 1697 | } |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1698 | |
| 1699 | // Now process specific instructions. |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1700 | if ((df_attributes & DF_IFIELD) != 0) { |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1701 | // The IGET/IPUT family. We have processed the IGET/IPUT null check above. |
| 1702 | DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0); |
| 1703 | // If not fast, weird things can happen and the insn can throw. |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1704 | const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir); |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1705 | bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut(); |
| 1706 | return !fast; |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1707 | } else if ((df_attributes & DF_SFIELD) != 0) { |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1708 | // The SGET/SPUT family. Check for potentially throwing class initialization. |
| 1709 | // Also, if not fast, weird things can happen and the insn can throw. |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1710 | const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir); |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1711 | bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut(); |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1712 | bool is_class_initialized = field_info.IsClassInitialized() || |
| 1713 | ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0); |
Vladimir Marko | 315cc20 | 2014-12-18 17:01:02 +0000 | [diff] [blame] | 1714 | return !(fast && is_class_initialized); |
| 1715 | } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) { |
| 1716 | // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above. |
| 1717 | DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0); |
| 1718 | // Non-throwing only if range check has been eliminated. |
| 1719 | return ((opt_flags & MIR_IGNORE_RANGE_CHECK) == 0); |
| 1720 | } else if (mir->dalvikInsn.opcode == Instruction::ARRAY_LENGTH || |
| 1721 | mir->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA || |
| 1722 | static_cast<int>(mir->dalvikInsn.opcode) == kMirOpNullCheck) { |
| 1723 | // No more checks for these (null check was processed above). |
| 1724 | return false; |
Ningsheng Jian | a262f77 | 2014-11-25 16:48:07 +0800 | [diff] [blame] | 1725 | } |
| 1726 | return true; |
| 1727 | } |
| 1728 | |
| 1729 | bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) { |
| 1730 | DCHECK(first->ssa_rep != nullptr); |
| 1731 | DCHECK(second->ssa_rep != nullptr); |
| 1732 | if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) { |
| 1733 | int vreg0 = SRegToVReg(second->ssa_rep->defs[0]); |
| 1734 | int vreg1 = (second->ssa_rep->num_defs == 2) ? |
| 1735 | SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG; |
| 1736 | for (int i = 0; i < first->ssa_rep->num_uses; i++) { |
| 1737 | int32_t use = SRegToVReg(first->ssa_rep->uses[i]); |
| 1738 | if (use == vreg0 || use == vreg1) { |
| 1739 | return true; |
| 1740 | } |
| 1741 | } |
| 1742 | } |
| 1743 | return false; |
| 1744 | } |
| 1745 | |
| 1746 | void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend, |
| 1747 | bool is_wide, bool is_sub) { |
| 1748 | if (is_wide) { |
| 1749 | if (is_sub) { |
| 1750 | add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong); |
| 1751 | } else { |
| 1752 | add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong); |
| 1753 | } |
| 1754 | } else { |
| 1755 | if (is_sub) { |
| 1756 | add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt); |
| 1757 | } else { |
| 1758 | add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt); |
| 1759 | } |
| 1760 | } |
| 1761 | add_mir->ssa_rep->num_uses = is_wide ? 6 : 3; |
| 1762 | int32_t addend0 = INVALID_SREG; |
| 1763 | int32_t addend1 = INVALID_SREG; |
| 1764 | if (is_wide) { |
| 1765 | addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0]; |
| 1766 | addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1]; |
| 1767 | } else { |
| 1768 | addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0]; |
| 1769 | } |
| 1770 | |
| 1771 | AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses); |
| 1772 | add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0]; |
| 1773 | add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1]; |
| 1774 | // Clear the original multiply product ssa use count, as it is not used anymore. |
| 1775 | raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0; |
| 1776 | use_counts_[mul_mir->ssa_rep->defs[0]] = 0; |
| 1777 | if (is_wide) { |
| 1778 | DCHECK_EQ(add_mir->ssa_rep->num_uses, 6); |
| 1779 | add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2]; |
| 1780 | add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3]; |
| 1781 | add_mir->ssa_rep->uses[4] = addend0; |
| 1782 | add_mir->ssa_rep->uses[5] = addend1; |
| 1783 | raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0; |
| 1784 | use_counts_[mul_mir->ssa_rep->defs[1]] = 0; |
| 1785 | } else { |
| 1786 | DCHECK_EQ(add_mir->ssa_rep->num_uses, 3); |
| 1787 | add_mir->ssa_rep->uses[2] = addend0; |
| 1788 | } |
| 1789 | // Copy in the decoded instruction information. |
| 1790 | add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]); |
| 1791 | if (is_wide) { |
| 1792 | add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]); |
| 1793 | add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]); |
| 1794 | } else { |
| 1795 | add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]); |
| 1796 | add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]); |
| 1797 | } |
| 1798 | // Original multiply MIR is set to Nop. |
| 1799 | mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop); |
| 1800 | } |
| 1801 | |
| 1802 | void MIRGraph::MultiplyAddOpt(BasicBlock* bb) { |
| 1803 | if (bb->block_type == kDead) { |
| 1804 | return; |
| 1805 | } |
| 1806 | ScopedArenaAllocator allocator(&cu_->arena_stack); |
| 1807 | ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter()); |
| 1808 | ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it; |
| 1809 | for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) { |
| 1810 | Instruction::Code opcode = mir->dalvikInsn.opcode; |
| 1811 | bool is_sub = true; |
| 1812 | bool is_candidate_multiply = false; |
| 1813 | switch (opcode) { |
| 1814 | case Instruction::MUL_INT: |
| 1815 | case Instruction::MUL_INT_2ADDR: |
| 1816 | is_candidate_multiply = true; |
| 1817 | break; |
| 1818 | case Instruction::MUL_LONG: |
| 1819 | case Instruction::MUL_LONG_2ADDR: |
| 1820 | if (cu_->target64) { |
| 1821 | is_candidate_multiply = true; |
| 1822 | } |
| 1823 | break; |
| 1824 | case Instruction::ADD_INT: |
| 1825 | case Instruction::ADD_INT_2ADDR: |
| 1826 | is_sub = false; |
| 1827 | FALLTHROUGH_INTENDED; |
| 1828 | case Instruction::SUB_INT: |
| 1829 | case Instruction::SUB_INT_2ADDR: |
| 1830 | if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) { |
| 1831 | // a*b+c |
| 1832 | CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */, |
| 1833 | false /* is_wide */, false /* is_sub */); |
| 1834 | ssa_mul_map.erase(mir->ssa_rep->uses[0]); |
| 1835 | } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) { |
| 1836 | // c+a*b or c-a*b |
| 1837 | CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */, |
| 1838 | false /* is_wide */, is_sub); |
| 1839 | ssa_mul_map.erase(map_it); |
| 1840 | } |
| 1841 | break; |
| 1842 | case Instruction::ADD_LONG: |
| 1843 | case Instruction::ADD_LONG_2ADDR: |
| 1844 | is_sub = false; |
| 1845 | FALLTHROUGH_INTENDED; |
| 1846 | case Instruction::SUB_LONG: |
| 1847 | case Instruction::SUB_LONG_2ADDR: |
| 1848 | if (!cu_->target64) { |
| 1849 | break; |
| 1850 | } |
| 1851 | if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) { |
| 1852 | // a*b+c |
| 1853 | CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */, |
| 1854 | true /* is_wide */, false /* is_sub */); |
| 1855 | ssa_mul_map.erase(map_it); |
| 1856 | } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) { |
| 1857 | // c+a*b or c-a*b |
| 1858 | CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */, |
| 1859 | true /* is_wide */, is_sub); |
| 1860 | ssa_mul_map.erase(map_it); |
| 1861 | } |
| 1862 | break; |
| 1863 | default: |
| 1864 | if (!ssa_mul_map.empty() && CanThrow(mir)) { |
| 1865 | // Should not combine multiply and add MIRs across potential exception. |
| 1866 | ssa_mul_map.clear(); |
| 1867 | } |
| 1868 | break; |
| 1869 | } |
| 1870 | |
| 1871 | // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses. |
| 1872 | // It is because that current RA may allocate the same physical register to them. For this |
| 1873 | // kind of cases, the multiplier has been updated, we should not use updated value to the |
| 1874 | // multiply-add insn. |
| 1875 | if (ssa_mul_map.size() > 0) { |
| 1876 | for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) { |
| 1877 | MIR* mul = it->second; |
| 1878 | if (HasAntiDependency(mul, mir)) { |
| 1879 | it = ssa_mul_map.erase(it); |
| 1880 | } else { |
| 1881 | ++it; |
| 1882 | } |
| 1883 | } |
| 1884 | } |
| 1885 | |
| 1886 | if (is_candidate_multiply && |
| 1887 | (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) { |
| 1888 | ssa_mul_map.Put(mir->ssa_rep->defs[0], mir); |
| 1889 | } |
| 1890 | } |
| 1891 | } |
| 1892 | |
buzbee | 311ca16 | 2013-02-28 15:56:43 -0800 | [diff] [blame] | 1893 | } // namespace art |