blob: e01fbbf756acf774541fc387d09a1498deac7655 [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008# SANITIZE_HOST is only in effect if the module is already using clang (host
9# modules that haven't set `LOCAL_CLANG := false` and device modules that
10# have set `LOCAL_CLANG := true`.
11my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070012my_global_sanitize_diag :=
Dan Albert4c401412015-08-19 20:13:33 -070013ifeq ($(my_clang),true)
14 ifdef LOCAL_IS_HOST_MODULE
15 my_global_sanitize := $(strip $(SANITIZE_HOST))
16
17 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
18 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
19 else
20 my_global_sanitize := $(strip $(SANITIZE_TARGET))
Ivan Lozano4a363732017-06-28 09:11:26 -070021 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070022 endif
23endif
24
Ivan Lozanob4749cb2017-07-21 10:33:32 -070025# Disable global integer_overflow in excluded paths.
26ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
27 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
28 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
29
30 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
31 $(filter $(dir)%,$(LOCAL_PATH)))),)
32 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
33 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
34 endif
35endif
36
Dan Albert4c401412015-08-19 20:13:33 -070037ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070038 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070039endif
Ivan Lozano4a363732017-06-28 09:11:26 -070040ifneq ($(my_global_sanitize_diag),)
41 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
42endif
Dan Albert4c401412015-08-19 20:13:33 -070043
Andreas Gampe6b30d772016-06-27 15:15:31 -070044# The sanitizer specified in the product configuration wins over the previous.
45ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
46 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
47 ifeq ($(my_sanitize),never)
48 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070049 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070050 endif
51endif
52
Colin Cross23618422016-11-02 15:05:21 -070053ifndef LOCAL_IS_HOST_MODULE
54 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
55 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
56 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
57 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070058 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070059 endif
Andreas Gampecd257402016-06-20 17:36:49 -070060endif
61
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070062# Add a filter point based on module owner (to lighten the burden). The format is a space- or
63# colon-separated list of owner names.
64ifneq (,$(SANITIZE_NEVER_BY_OWNER))
65 ifneq (,$(LOCAL_MODULE_OWNER))
66 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
67 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
68 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070069 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070070 endif
71 endif
72endif
73
Dan Albert08cca282014-12-11 18:56:26 -080074# Don't apply sanitizers to NDK code.
75ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -070076 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -070077 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070078 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -070079endif
80
Dan Albert4c401412015-08-19 20:13:33 -070081# Never always wins.
82ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -080083 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070084 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -080085endif
86
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -080087# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -080088ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -080089 my_sanitize := $(filter-out cfi,$(my_sanitize))
90 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
91endif
92
Vishwath Mohana2046062017-02-07 20:28:07 -080093# Disable CFI for arm32 (b/35157333).
94ifneq ($(filter arm,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
95 my_sanitize := $(filter-out cfi,$(my_sanitize))
96 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
97endif
98
Vishwath Mohanc026f6d2017-04-20 07:39:13 -070099# Also disable CFI if ASAN is enabled.
100ifneq ($(filter address,$(my_sanitize)),)
101 my_sanitize := $(filter-out cfi,$(my_sanitize))
102 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
103endif
104
Evgenii Stepanov8c50e3c2017-01-31 17:08:33 -0800105# CFI needs gold linker, and mips toolchain does not have one.
106ifneq ($(filter mips mips64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
107 my_sanitize := $(filter-out cfi,$(my_sanitize))
108 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
109endif
110
Ivan Lozano4a363732017-06-28 09:11:26 -0700111# Support for local sanitize blacklist paths.
112ifneq ($(my_sanitize)$(my_global_sanitize),)
113 ifneq ($(LOCAL_SANITIZE_BLACKLIST),)
114 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLACKLIST)
115 endif
116endif
117
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700118# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700119ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
120 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
121 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
122 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
123 endif
124endif
125
Evgenii Stepanov42823662016-05-12 13:07:17 -0700126my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
127ifneq ($(my_nosanitize),)
128 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
129endif
130
Dan Alberta6311b72015-07-30 10:17:33 -0700131# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
132# its use an error. For multilib cases, don't use it for the 32-bit case.
133ifneq ($(filter thread,$(my_sanitize)),)
134 ifeq ($(my_32_64_bit_suffix),32)
135 ifeq ($(my_module_multilib),both)
136 my_sanitize := $(filter-out thread,$(my_sanitize))
137 else
138 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
139 endif
140 endif
141endif
142
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700143ifneq ($(filter safe-stack,$(my_sanitize)),)
144 ifeq ($(my_32_64_bit_suffix),32)
145 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
146 endif
147endif
148
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700149# Undefined symbols can occur if a non-sanitized library links
150# sanitized static libraries. That's OK, because the executable
151# always depends on the ASan runtime library, which defines these
152# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700153ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700154 ifndef LOCAL_IS_HOST_MODULE
155 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
156 ifeq ($(my_sanitize),)
157 my_allow_undefined_symbols := true
158 endif
159 endif
160 endif
161endif
162
Dan Albert94b57912015-04-17 09:48:33 -0700163# Sanitizers can only be used with clang.
164ifneq ($(my_clang),true)
165 ifneq ($(my_sanitize),)
166 $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of sanitizers requires LOCAL_CLANG := true)
167 endif
168endif
169
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700170ifneq ($(filter default-ub,$(my_sanitize)),)
171 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800172endif
173
Ivan Krasin74b32b82015-09-18 11:54:43 -0700174ifneq ($(filter coverage,$(my_sanitize)),)
175 ifeq ($(filter address,$(my_sanitize)),)
176 $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of 'coverage' also requires 'address')
177 endif
Zach Rigglebe0811f2017-08-21 17:07:42 -0400178 my_cflags += -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp
Ivan Krasin74b32b82015-09-18 11:54:43 -0700179 my_sanitize := $(filter-out coverage,$(my_sanitize))
180endif
181
Ivan Lozano4a363732017-06-28 09:11:26 -0700182ifneq ($(filter integer_overflow,$(my_sanitize)),)
183 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
184 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
185
186 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
187 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
188 my_cflags += -fsanitize=signed-integer-overflow
189 endif
190 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
191 my_cflags += -fsanitize=unsigned-integer-overflow
192 endif
193 my_cflags += -fsanitize-trap=all
194 my_cflags += -ftrap-function=abort
195 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
196
197 # Check for diagnostics mode (on by default).
198 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
199 my_cflags += -fno-sanitize-trap=signed-integer-overflow,unsigned-integer-overflow
200 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY) $(my_shared_libraries)
201 endif
202 endif
203 endif
204 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
205endif
206
207# Makes sure integer_overflow diagnostics is removed from the diagnostics list
208# even if integer_overflow is not set for some reason.
209ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
210 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
211endif
212
Dan Albert08cca282014-12-11 18:56:26 -0800213ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800214 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800215 my_cflags += -fsanitize=$(fsanitize_arg)
216
217 ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700218 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800219 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700220 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700221 my_cflags += -fsanitize-trap=all
222 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700223 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700224 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700225 my_shared_libraries += libdl
226 endif
Dan Albert08cca282014-12-11 18:56:26 -0800227 endif
228endif
229
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700230ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800231 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
232 # LLVM is not set up to do this on a function basis, so force Thumb on the
233 # entire module.
234 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800235 my_cflags += $(CFI_EXTRA_CFLAGS)
236 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800237 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Evgenii Stepanov8c50e3c2017-01-31 17:08:33 -0800238 # Workaround for b/33678192. CFI jumptables need Thumb2 codegen. Revert when
239 # Clang is updated past r290384.
240 ifneq ($(filter arm,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
241 my_ldflags += -march=armv7-a
242 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700243endif
244
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800245# If local or global modules need ASAN, add linker flags.
246ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700247 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
248 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800249 # -nodefaultlibs (provided with libc++) prevents the driver from linking
250 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700251 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700252 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800253 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700254 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800255 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
256 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
257 $(my_shared_libraries)
258 endif
259 ifeq (,$(filter $(LOCAL_MODULE),$(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES)))
260 my_static_libraries += $(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES)
261 endif
262
263 # Do not add unnecessary dependency in shared libraries.
264 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
265 my_ldflags += -Wl,--as-needed
266 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700267
Colin Crossd08699e2016-07-17 15:28:07 -0700268 ifeq ($(LOCAL_MODULE_CLASS),EXECUTABLES)
269 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
270 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
271 # Make sure linker_asan get installed.
272 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
273 endif
274 endif
Dan Albert08cca282014-12-11 18:56:26 -0800275 endif
276endif
277
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800278# If local module needs ASAN, add compiler flags.
279ifneq ($(filter address,$(my_sanitize)),)
280 # Frame pointer based unwinder in ASan requires ARM frame setup.
281 LOCAL_ARM_MODE := arm
282 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
283 ifndef LOCAL_IS_HOST_MODULE
284 my_cflags += -mllvm -asan-globals=0
285 endif
286endif
287
Dan Albert9f176552015-04-28 11:26:45 -0700288ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
289 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700290 my_cflags += -fsanitize-recover=$(recover_arg)
291endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700292
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800293ifneq ($(my_sanitize_diag),)
294 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700295 my_cflags += -fno-sanitize-trap=$(notrap_arg)
296 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
297 ifeq ($(filter address thread,$(my_sanitize)),)
298 # Does not have to be the first DT_NEEDED unlike ASan.
299 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
300 endif
301endif