Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES2.cpp: Validation functions for OpenGL ES 2.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES2.h" |
| 10 | #include "libANGLE/validationES.h" |
| 11 | #include "libANGLE/Context.h" |
| 12 | #include "libANGLE/Texture.h" |
| 13 | #include "libANGLE/Framebuffer.h" |
| 14 | #include "libANGLE/Renderbuffer.h" |
| 15 | #include "libANGLE/formatutils.h" |
| 16 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 17 | |
| 18 | #include "common/mathutil.h" |
| 19 | #include "common/utilities.h" |
| 20 | |
| 21 | namespace gl |
| 22 | { |
| 23 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 24 | static bool ValidateSubImageParams2D(Context *context, bool compressed, GLsizei width, GLsizei height, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | GLint xoffset, GLint yoffset, GLint level, GLenum format, GLenum type, |
| 26 | gl::Texture2D *texture) |
| 27 | { |
| 28 | if (!texture) |
| 29 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 30 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 31 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 32 | } |
| 33 | |
| 34 | if (compressed != texture->isCompressed(level)) |
| 35 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 36 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 37 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 38 | } |
| 39 | |
| 40 | if (format != GL_NONE) |
| 41 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 42 | if (gl::GetFormatTypeInfo(format, type).internalFormat != texture->getInternalFormat(level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 43 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 44 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 45 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 46 | } |
| 47 | } |
| 48 | |
| 49 | if (compressed) |
| 50 | { |
Geoff Lang | a836e48 | 2014-04-28 10:08:27 -0400 | [diff] [blame] | 51 | if ((width % 4 != 0 && width != texture->getWidth(level)) || |
| 52 | (height % 4 != 0 && height != texture->getHeight(level))) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 53 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 54 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 55 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 56 | } |
| 57 | } |
| 58 | |
| 59 | if (xoffset + width > texture->getWidth(level) || |
| 60 | yoffset + height > texture->getHeight(level)) |
| 61 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 62 | context->recordError(Error(GL_INVALID_VALUE)); |
| 63 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 64 | } |
| 65 | |
| 66 | return true; |
| 67 | } |
| 68 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 69 | static bool ValidateSubImageParamsCube(Context *context, bool compressed, GLsizei width, GLsizei height, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 70 | GLint xoffset, GLint yoffset, GLenum target, GLint level, GLenum format, GLenum type, |
| 71 | gl::TextureCubeMap *texture) |
| 72 | { |
| 73 | if (!texture) |
| 74 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 75 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 76 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 77 | } |
| 78 | |
| 79 | if (compressed != texture->isCompressed(target, level)) |
| 80 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 81 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 82 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 83 | } |
| 84 | |
| 85 | if (format != GL_NONE) |
| 86 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 87 | if (gl::GetFormatTypeInfo(format, type).internalFormat != texture->getInternalFormat(target, level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 88 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 89 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 90 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 91 | } |
| 92 | } |
| 93 | |
| 94 | if (compressed) |
| 95 | { |
| 96 | if ((width % 4 != 0 && width != texture->getWidth(target, 0)) || |
| 97 | (height % 4 != 0 && height != texture->getHeight(target, 0))) |
| 98 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 99 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 100 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 101 | } |
| 102 | } |
| 103 | |
| 104 | if (xoffset + width > texture->getWidth(target, level) || |
| 105 | yoffset + height > texture->getHeight(target, level)) |
| 106 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 107 | context->recordError(Error(GL_INVALID_VALUE)); |
| 108 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 109 | } |
| 110 | |
| 111 | return true; |
| 112 | } |
| 113 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 114 | bool ValidateES2TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 115 | GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, |
| 116 | GLint border, GLenum format, GLenum type, const GLvoid *pixels) |
| 117 | { |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 118 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 119 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 120 | context->recordError(Error(GL_INVALID_ENUM)); |
| 121 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 122 | } |
| 123 | |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 124 | if (!ValidImageSize(context, target, level, width, height, 1)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 125 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 126 | context->recordError(Error(GL_INVALID_VALUE)); |
| 127 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 128 | } |
| 129 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 130 | if (level < 0 || xoffset < 0 || |
| 131 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 132 | std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 133 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 134 | context->recordError(Error(GL_INVALID_VALUE)); |
| 135 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 136 | } |
| 137 | |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 138 | if (!isSubImage && !isCompressed && internalformat != format) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 139 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 140 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 141 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 142 | } |
| 143 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 144 | const gl::Caps &caps = context->getCaps(); |
| 145 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 146 | gl::Texture *texture = NULL; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 147 | GLenum textureInternalFormat = GL_NONE; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 148 | switch (target) |
| 149 | { |
| 150 | case GL_TEXTURE_2D: |
| 151 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 152 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 153 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 154 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 155 | context->recordError(Error(GL_INVALID_VALUE)); |
| 156 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 157 | } |
| 158 | |
| 159 | gl::Texture2D *tex2d = context->getTexture2D(); |
| 160 | if (tex2d) |
| 161 | { |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 162 | textureInternalFormat = tex2d->getInternalFormat(level); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 163 | texture = tex2d; |
| 164 | } |
| 165 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 166 | if (isSubImage && !ValidateSubImageParams2D(context, isCompressed, width, height, xoffset, yoffset, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 167 | level, format, type, tex2d)) |
| 168 | { |
| 169 | return false; |
| 170 | } |
| 171 | |
| 172 | texture = tex2d; |
| 173 | } |
| 174 | break; |
| 175 | |
| 176 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 177 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 178 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 179 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 180 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 181 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| 182 | { |
| 183 | if (!isSubImage && width != height) |
| 184 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 185 | context->recordError(Error(GL_INVALID_VALUE)); |
| 186 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 187 | } |
| 188 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 189 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level) || |
| 190 | static_cast<GLuint>(height) > (caps.maxCubeMapTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 191 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 192 | context->recordError(Error(GL_INVALID_VALUE)); |
| 193 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 194 | } |
| 195 | |
| 196 | gl::TextureCubeMap *texCube = context->getTextureCubeMap(); |
| 197 | if (texCube) |
| 198 | { |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 199 | textureInternalFormat = texCube->getInternalFormat(target, level); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 200 | texture = texCube; |
| 201 | } |
| 202 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 203 | if (isSubImage && !ValidateSubImageParamsCube(context, isCompressed, width, height, xoffset, yoffset, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 204 | target, level, format, type, texCube)) |
| 205 | { |
| 206 | return false; |
| 207 | } |
| 208 | } |
| 209 | break; |
| 210 | |
| 211 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 212 | context->recordError(Error(GL_INVALID_ENUM)); |
| 213 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 214 | } |
| 215 | |
| 216 | if (!texture) |
| 217 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 218 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 219 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 220 | } |
| 221 | |
| 222 | if (!isSubImage && texture->isImmutable()) |
| 223 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 224 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 225 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 226 | } |
| 227 | |
| 228 | // Verify zero border |
| 229 | if (border != 0) |
| 230 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 231 | context->recordError(Error(GL_INVALID_VALUE)); |
| 232 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 233 | } |
| 234 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 235 | GLenum actualInternalFormat = isSubImage ? textureInternalFormat : internalformat; |
| 236 | if (isCompressed) |
| 237 | { |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 238 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
| 239 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 240 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 241 | return false; |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 242 | } |
| 243 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 244 | switch (actualInternalFormat) |
| 245 | { |
| 246 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 247 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 248 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 249 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 250 | context->recordError(Error(GL_INVALID_ENUM)); |
| 251 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 252 | } |
| 253 | break; |
| 254 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 255 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 256 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 257 | context->recordError(Error(GL_INVALID_ENUM)); |
| 258 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 259 | } |
| 260 | break; |
| 261 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 262 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 263 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 264 | context->recordError(Error(GL_INVALID_ENUM)); |
| 265 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 266 | } |
| 267 | break; |
| 268 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 269 | context->recordError(Error(GL_INVALID_ENUM)); |
| 270 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 271 | } |
| 272 | } |
| 273 | else |
| 274 | { |
| 275 | // validate <type> by itself (used as secondary key below) |
| 276 | switch (type) |
| 277 | { |
| 278 | case GL_UNSIGNED_BYTE: |
| 279 | case GL_UNSIGNED_SHORT_5_6_5: |
| 280 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 281 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 282 | case GL_UNSIGNED_SHORT: |
| 283 | case GL_UNSIGNED_INT: |
| 284 | case GL_UNSIGNED_INT_24_8_OES: |
| 285 | case GL_HALF_FLOAT_OES: |
| 286 | case GL_FLOAT: |
| 287 | break; |
| 288 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 289 | context->recordError(Error(GL_INVALID_ENUM)); |
| 290 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 291 | } |
| 292 | |
| 293 | // validate <format> + <type> combinations |
| 294 | // - invalid <format> -> sets INVALID_ENUM |
| 295 | // - invalid <format>+<type> combination -> sets INVALID_OPERATION |
| 296 | switch (format) |
| 297 | { |
| 298 | case GL_ALPHA: |
| 299 | case GL_LUMINANCE: |
| 300 | case GL_LUMINANCE_ALPHA: |
| 301 | switch (type) |
| 302 | { |
| 303 | case GL_UNSIGNED_BYTE: |
| 304 | case GL_FLOAT: |
| 305 | case GL_HALF_FLOAT_OES: |
| 306 | break; |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 307 | default: |
| 308 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 309 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 310 | } |
| 311 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 312 | case GL_RED: |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 313 | case GL_RG: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 314 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 315 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 316 | context->recordError(Error(GL_INVALID_ENUM)); |
| 317 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 318 | } |
| 319 | switch (type) |
| 320 | { |
| 321 | case GL_UNSIGNED_BYTE: |
| 322 | case GL_FLOAT: |
| 323 | case GL_HALF_FLOAT_OES: |
| 324 | break; |
| 325 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 326 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 327 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 328 | } |
| 329 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 330 | case GL_RGB: |
| 331 | switch (type) |
| 332 | { |
| 333 | case GL_UNSIGNED_BYTE: |
| 334 | case GL_UNSIGNED_SHORT_5_6_5: |
| 335 | case GL_FLOAT: |
| 336 | case GL_HALF_FLOAT_OES: |
| 337 | break; |
| 338 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 339 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 340 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 341 | } |
| 342 | break; |
| 343 | case GL_RGBA: |
| 344 | switch (type) |
| 345 | { |
| 346 | case GL_UNSIGNED_BYTE: |
| 347 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 348 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 349 | case GL_FLOAT: |
| 350 | case GL_HALF_FLOAT_OES: |
| 351 | break; |
| 352 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 353 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 354 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 355 | } |
| 356 | break; |
| 357 | case GL_BGRA_EXT: |
| 358 | switch (type) |
| 359 | { |
| 360 | case GL_UNSIGNED_BYTE: |
| 361 | break; |
| 362 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 363 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 364 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 365 | } |
| 366 | break; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 367 | case GL_SRGB_EXT: |
| 368 | case GL_SRGB_ALPHA_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 369 | if (!context->getExtensions().sRGB) |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 370 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 371 | context->recordError(Error(GL_INVALID_ENUM)); |
| 372 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 373 | } |
| 374 | switch (type) |
| 375 | { |
| 376 | case GL_UNSIGNED_BYTE: |
| 377 | break; |
| 378 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 379 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 380 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 381 | } |
| 382 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 383 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: // error cases for compressed textures are handled below |
| 384 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 385 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 386 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
| 387 | break; |
| 388 | case GL_DEPTH_COMPONENT: |
| 389 | switch (type) |
| 390 | { |
| 391 | case GL_UNSIGNED_SHORT: |
| 392 | case GL_UNSIGNED_INT: |
| 393 | break; |
| 394 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 395 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 396 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 397 | } |
| 398 | break; |
| 399 | case GL_DEPTH_STENCIL_OES: |
| 400 | switch (type) |
| 401 | { |
| 402 | case GL_UNSIGNED_INT_24_8_OES: |
| 403 | break; |
| 404 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 405 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 406 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 407 | } |
| 408 | break; |
| 409 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 410 | context->recordError(Error(GL_INVALID_ENUM)); |
| 411 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 412 | } |
| 413 | |
| 414 | switch (format) |
| 415 | { |
| 416 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 417 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 418 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 419 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 420 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 421 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 422 | } |
| 423 | else |
| 424 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 425 | context->recordError(Error(GL_INVALID_ENUM)); |
| 426 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 427 | } |
| 428 | break; |
| 429 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 430 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 431 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 432 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 433 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 434 | } |
| 435 | else |
| 436 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 437 | context->recordError(Error(GL_INVALID_ENUM)); |
| 438 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 439 | } |
| 440 | break; |
| 441 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 442 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 443 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 444 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 445 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 446 | } |
| 447 | else |
| 448 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 449 | context->recordError(Error(GL_INVALID_ENUM)); |
| 450 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 451 | } |
| 452 | break; |
| 453 | case GL_DEPTH_COMPONENT: |
| 454 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 455 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 456 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 457 | context->recordError(Error(GL_INVALID_VALUE)); |
| 458 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 459 | } |
| 460 | if (target != GL_TEXTURE_2D) |
| 461 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 462 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 463 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 464 | } |
| 465 | // OES_depth_texture supports loading depth data and multiple levels, |
| 466 | // but ANGLE_depth_texture does not |
| 467 | if (pixels != NULL || level != 0) |
| 468 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 469 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 470 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 471 | } |
| 472 | break; |
| 473 | default: |
| 474 | break; |
| 475 | } |
| 476 | |
| 477 | if (type == GL_FLOAT) |
| 478 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 479 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 480 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 481 | context->recordError(Error(GL_INVALID_ENUM)); |
| 482 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 483 | } |
| 484 | } |
| 485 | else if (type == GL_HALF_FLOAT_OES) |
| 486 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 487 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 488 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 489 | context->recordError(Error(GL_INVALID_ENUM)); |
| 490 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 491 | } |
| 492 | } |
| 493 | } |
| 494 | |
| 495 | return true; |
| 496 | } |
| 497 | |
| 498 | |
| 499 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 500 | bool ValidateES2CopyTexImageParameters(Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 501 | GLint xoffset, GLint yoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 502 | GLint border) |
| 503 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 504 | GLenum textureInternalFormat = GL_NONE; |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 505 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 506 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 507 | xoffset, yoffset, 0, x, y, width, height, border, &textureInternalFormat)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 508 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 509 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 510 | } |
| 511 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 512 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 513 | GLenum colorbufferFormat = framebuffer->getReadColorbuffer()->getInternalFormat(); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 514 | GLenum textureFormat = gl::GetInternalFormatInfo(textureInternalFormat).format; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 515 | |
| 516 | // [OpenGL ES 2.0.24] table 3.9 |
| 517 | if (isSubImage) |
| 518 | { |
| 519 | switch (textureFormat) |
| 520 | { |
| 521 | case GL_ALPHA: |
| 522 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 523 | colorbufferFormat != GL_RGBA4 && |
| 524 | colorbufferFormat != GL_RGB5_A1 && |
| 525 | colorbufferFormat != GL_RGBA8_OES) |
| 526 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 527 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 528 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 529 | } |
| 530 | break; |
| 531 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 532 | if (colorbufferFormat != GL_R8_EXT && |
| 533 | colorbufferFormat != GL_RG8_EXT && |
| 534 | colorbufferFormat != GL_RGB565 && |
| 535 | colorbufferFormat != GL_RGB8_OES && |
| 536 | colorbufferFormat != GL_RGBA4 && |
| 537 | colorbufferFormat != GL_RGB5_A1 && |
| 538 | colorbufferFormat != GL_RGBA8_OES) |
| 539 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 540 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 541 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 542 | } |
| 543 | break; |
| 544 | case GL_RED_EXT: |
| 545 | if (colorbufferFormat != GL_R8_EXT && |
| 546 | colorbufferFormat != GL_RG8_EXT && |
| 547 | colorbufferFormat != GL_RGB565 && |
| 548 | colorbufferFormat != GL_RGB8_OES && |
| 549 | colorbufferFormat != GL_RGBA4 && |
| 550 | colorbufferFormat != GL_RGB5_A1 && |
| 551 | colorbufferFormat != GL_RGBA8_OES) |
| 552 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 553 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 554 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 555 | } |
| 556 | break; |
| 557 | case GL_RG_EXT: |
| 558 | if (colorbufferFormat != GL_RG8_EXT && |
| 559 | colorbufferFormat != GL_RGB565 && |
| 560 | colorbufferFormat != GL_RGB8_OES && |
| 561 | colorbufferFormat != GL_RGBA4 && |
| 562 | colorbufferFormat != GL_RGB5_A1 && |
| 563 | colorbufferFormat != GL_RGBA8_OES) |
| 564 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 565 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 566 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 567 | } |
| 568 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 569 | case GL_RGB: |
| 570 | if (colorbufferFormat != GL_RGB565 && |
| 571 | colorbufferFormat != GL_RGB8_OES && |
| 572 | colorbufferFormat != GL_RGBA4 && |
| 573 | colorbufferFormat != GL_RGB5_A1 && |
| 574 | colorbufferFormat != GL_RGBA8_OES) |
| 575 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 576 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 577 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 578 | } |
| 579 | break; |
| 580 | case GL_LUMINANCE_ALPHA: |
| 581 | case GL_RGBA: |
| 582 | if (colorbufferFormat != GL_RGBA4 && |
| 583 | colorbufferFormat != GL_RGB5_A1 && |
| 584 | colorbufferFormat != GL_RGBA8_OES) |
| 585 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 586 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 587 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 588 | } |
| 589 | break; |
| 590 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 591 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 592 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 593 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 594 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 595 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 596 | case GL_DEPTH_COMPONENT: |
| 597 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 598 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 599 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 600 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 601 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 602 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 603 | } |
| 604 | } |
| 605 | else |
| 606 | { |
| 607 | switch (internalformat) |
| 608 | { |
| 609 | case GL_ALPHA: |
| 610 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 611 | colorbufferFormat != GL_RGBA4 && |
| 612 | colorbufferFormat != GL_RGB5_A1 && |
| 613 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame^] | 614 | colorbufferFormat != GL_RGBA8_OES && |
| 615 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 616 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 617 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 618 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 619 | } |
| 620 | break; |
| 621 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 622 | if (colorbufferFormat != GL_R8_EXT && |
| 623 | colorbufferFormat != GL_RG8_EXT && |
| 624 | colorbufferFormat != GL_RGB565 && |
| 625 | colorbufferFormat != GL_RGB8_OES && |
| 626 | colorbufferFormat != GL_RGBA4 && |
| 627 | colorbufferFormat != GL_RGB5_A1 && |
| 628 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame^] | 629 | colorbufferFormat != GL_RGBA8_OES && |
| 630 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 631 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 632 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 633 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 634 | } |
| 635 | break; |
| 636 | case GL_RED_EXT: |
| 637 | if (colorbufferFormat != GL_R8_EXT && |
| 638 | colorbufferFormat != GL_RG8_EXT && |
| 639 | colorbufferFormat != GL_RGB565 && |
| 640 | colorbufferFormat != GL_RGB8_OES && |
| 641 | colorbufferFormat != GL_RGBA4 && |
| 642 | colorbufferFormat != GL_RGB5_A1 && |
| 643 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame^] | 644 | colorbufferFormat != GL_RGBA8_OES && |
| 645 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 646 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 647 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 648 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 649 | } |
| 650 | break; |
| 651 | case GL_RG_EXT: |
| 652 | if (colorbufferFormat != GL_RG8_EXT && |
| 653 | colorbufferFormat != GL_RGB565 && |
| 654 | colorbufferFormat != GL_RGB8_OES && |
| 655 | colorbufferFormat != GL_RGBA4 && |
| 656 | colorbufferFormat != GL_RGB5_A1 && |
| 657 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame^] | 658 | colorbufferFormat != GL_RGBA8_OES && |
| 659 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 660 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 661 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 662 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 663 | } |
| 664 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 665 | case GL_RGB: |
| 666 | if (colorbufferFormat != GL_RGB565 && |
| 667 | colorbufferFormat != GL_RGB8_OES && |
| 668 | colorbufferFormat != GL_RGBA4 && |
| 669 | colorbufferFormat != GL_RGB5_A1 && |
| 670 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame^] | 671 | colorbufferFormat != GL_RGBA8_OES && |
| 672 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 673 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 674 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 675 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 676 | } |
| 677 | break; |
| 678 | case GL_LUMINANCE_ALPHA: |
| 679 | case GL_RGBA: |
| 680 | if (colorbufferFormat != GL_RGBA4 && |
| 681 | colorbufferFormat != GL_RGB5_A1 && |
| 682 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame^] | 683 | colorbufferFormat != GL_RGBA8_OES && |
| 684 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 685 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 686 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 687 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 688 | } |
| 689 | break; |
| 690 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 691 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 692 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 693 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 694 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 695 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 696 | } |
| 697 | else |
| 698 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 699 | context->recordError(Error(GL_INVALID_ENUM)); |
| 700 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 701 | } |
| 702 | break; |
| 703 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 704 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 705 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 706 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 707 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 708 | } |
| 709 | else |
| 710 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 711 | context->recordError(Error(GL_INVALID_ENUM)); |
| 712 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 713 | } |
| 714 | break; |
| 715 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 716 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 717 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 718 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 719 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 720 | } |
| 721 | else |
| 722 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 723 | context->recordError(Error(GL_INVALID_ENUM)); |
| 724 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 725 | } |
| 726 | break; |
| 727 | case GL_DEPTH_COMPONENT: |
| 728 | case GL_DEPTH_COMPONENT16: |
| 729 | case GL_DEPTH_COMPONENT32_OES: |
| 730 | case GL_DEPTH_STENCIL_OES: |
| 731 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 732 | if (context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 733 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 734 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 735 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 736 | } |
| 737 | else |
| 738 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 739 | context->recordError(Error(GL_INVALID_ENUM)); |
| 740 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 741 | } |
| 742 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 743 | context->recordError(Error(GL_INVALID_ENUM)); |
| 744 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 745 | } |
| 746 | } |
| 747 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 748 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 749 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 750 | } |
| 751 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 752 | bool ValidateES2TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 753 | GLsizei width, GLsizei height) |
| 754 | { |
| 755 | if (target != GL_TEXTURE_2D && target != GL_TEXTURE_CUBE_MAP) |
| 756 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 757 | context->recordError(Error(GL_INVALID_ENUM)); |
| 758 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 759 | } |
| 760 | |
| 761 | if (width < 1 || height < 1 || levels < 1) |
| 762 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 763 | context->recordError(Error(GL_INVALID_VALUE)); |
| 764 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 765 | } |
| 766 | |
| 767 | if (target == GL_TEXTURE_CUBE_MAP && width != height) |
| 768 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 769 | context->recordError(Error(GL_INVALID_VALUE)); |
| 770 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 771 | } |
| 772 | |
| 773 | if (levels != 1 && levels != gl::log2(std::max(width, height)) + 1) |
| 774 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 775 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 776 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 777 | } |
| 778 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 779 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 780 | if (formatInfo.format == GL_NONE || formatInfo.type == GL_NONE) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 781 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 782 | context->recordError(Error(GL_INVALID_ENUM)); |
| 783 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 784 | } |
| 785 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 786 | const gl::Caps &caps = context->getCaps(); |
| 787 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 788 | switch (target) |
| 789 | { |
| 790 | case GL_TEXTURE_2D: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 791 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 792 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 793 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 794 | context->recordError(Error(GL_INVALID_VALUE)); |
| 795 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 796 | } |
| 797 | break; |
| 798 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 799 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize || |
| 800 | static_cast<GLuint>(height) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 801 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 802 | context->recordError(Error(GL_INVALID_VALUE)); |
| 803 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 804 | } |
| 805 | break; |
| 806 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 807 | context->recordError(Error(GL_INVALID_ENUM)); |
| 808 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 809 | } |
| 810 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 811 | if (levels != 1 && !context->getExtensions().textureNPOT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 812 | { |
| 813 | if (!gl::isPow2(width) || !gl::isPow2(height)) |
| 814 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 815 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 816 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 817 | } |
| 818 | } |
| 819 | |
| 820 | switch (internalformat) |
| 821 | { |
| 822 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 823 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 824 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 825 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 826 | context->recordError(Error(GL_INVALID_ENUM)); |
| 827 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 828 | } |
| 829 | break; |
| 830 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 831 | if (!context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 832 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 833 | context->recordError(Error(GL_INVALID_ENUM)); |
| 834 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 835 | } |
| 836 | break; |
| 837 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 838 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 839 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 840 | context->recordError(Error(GL_INVALID_ENUM)); |
| 841 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 842 | } |
| 843 | break; |
| 844 | case GL_RGBA32F_EXT: |
| 845 | case GL_RGB32F_EXT: |
| 846 | case GL_ALPHA32F_EXT: |
| 847 | case GL_LUMINANCE32F_EXT: |
| 848 | case GL_LUMINANCE_ALPHA32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 849 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 850 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 851 | context->recordError(Error(GL_INVALID_ENUM)); |
| 852 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 853 | } |
| 854 | break; |
| 855 | case GL_RGBA16F_EXT: |
| 856 | case GL_RGB16F_EXT: |
| 857 | case GL_ALPHA16F_EXT: |
| 858 | case GL_LUMINANCE16F_EXT: |
| 859 | case GL_LUMINANCE_ALPHA16F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 860 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 861 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 862 | context->recordError(Error(GL_INVALID_ENUM)); |
| 863 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 864 | } |
| 865 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 866 | case GL_R8_EXT: |
| 867 | case GL_RG8_EXT: |
| 868 | case GL_R16F_EXT: |
| 869 | case GL_RG16F_EXT: |
| 870 | case GL_R32F_EXT: |
| 871 | case GL_RG32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 872 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 873 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 874 | context->recordError(Error(GL_INVALID_ENUM)); |
| 875 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 876 | } |
| 877 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 878 | case GL_DEPTH_COMPONENT16: |
| 879 | case GL_DEPTH_COMPONENT32_OES: |
| 880 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 881 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 882 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 883 | context->recordError(Error(GL_INVALID_ENUM)); |
| 884 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 885 | } |
| 886 | if (target != GL_TEXTURE_2D) |
| 887 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 888 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 889 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 890 | } |
| 891 | // ANGLE_depth_texture only supports 1-level textures |
| 892 | if (levels != 1) |
| 893 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 894 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 895 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 896 | } |
| 897 | break; |
| 898 | default: |
| 899 | break; |
| 900 | } |
| 901 | |
| 902 | gl::Texture *texture = NULL; |
| 903 | switch(target) |
| 904 | { |
| 905 | case GL_TEXTURE_2D: |
| 906 | texture = context->getTexture2D(); |
| 907 | break; |
| 908 | case GL_TEXTURE_CUBE_MAP: |
| 909 | texture = context->getTextureCubeMap(); |
| 910 | break; |
| 911 | default: |
| 912 | UNREACHABLE(); |
| 913 | } |
| 914 | |
| 915 | if (!texture || texture->id() == 0) |
| 916 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 917 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 918 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 919 | } |
| 920 | |
| 921 | if (texture->isImmutable()) |
| 922 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 923 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 924 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 925 | } |
| 926 | |
| 927 | return true; |
| 928 | } |
| 929 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 930 | // check for combinations of format and type that are valid for ReadPixels |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 931 | bool ValidES2ReadFormatType(Context *context, GLenum format, GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 932 | { |
| 933 | switch (format) |
| 934 | { |
| 935 | case GL_RGBA: |
| 936 | switch (type) |
| 937 | { |
| 938 | case GL_UNSIGNED_BYTE: |
| 939 | break; |
| 940 | default: |
| 941 | return false; |
| 942 | } |
| 943 | break; |
| 944 | case GL_BGRA_EXT: |
| 945 | switch (type) |
| 946 | { |
| 947 | case GL_UNSIGNED_BYTE: |
| 948 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 949 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 950 | break; |
| 951 | default: |
| 952 | return false; |
| 953 | } |
| 954 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 955 | case GL_RG_EXT: |
| 956 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 957 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 958 | { |
| 959 | return false; |
| 960 | } |
| 961 | switch (type) |
| 962 | { |
| 963 | case GL_UNSIGNED_BYTE: |
| 964 | break; |
| 965 | default: |
| 966 | return false; |
| 967 | } |
| 968 | break; |
| 969 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 970 | default: |
| 971 | return false; |
| 972 | } |
| 973 | return true; |
| 974 | } |
| 975 | |
| 976 | } |