daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 12 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 13 | #include "compiler/translator/Cache.h" |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 14 | #include "compiler/translator/glslang.h" |
| 15 | #include "compiler/translator/ValidateSwitch.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 16 | #include "compiler/translator/ValidateGlobalInitializer.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 17 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 18 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 19 | namespace sh |
| 20 | { |
| 21 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 22 | /////////////////////////////////////////////////////////////////////// |
| 23 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 24 | // Sub- vector and matrix fields |
| 25 | // |
| 26 | //////////////////////////////////////////////////////////////////////// |
| 27 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 28 | namespace |
| 29 | { |
| 30 | |
| 31 | const int kWebGLMaxStructNesting = 4; |
| 32 | |
| 33 | bool ContainsSampler(const TType &type) |
| 34 | { |
| 35 | if (IsSampler(type.getBasicType())) |
| 36 | return true; |
| 37 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 38 | if (type.getBasicType() == EbtStruct) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 39 | { |
| 40 | const TFieldList &fields = type.getStruct()->fields(); |
| 41 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 42 | { |
| 43 | if (ContainsSampler(*fields[i]->type())) |
| 44 | return true; |
| 45 | } |
| 46 | } |
| 47 | |
| 48 | return false; |
| 49 | } |
| 50 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 51 | // Get a token from an image argument to use as an error message token. |
| 52 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 53 | { |
| 54 | ASSERT(IsImage(imageNode->getBasicType())); |
| 55 | while (imageNode->getAsBinaryNode() && |
| 56 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 57 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 58 | { |
| 59 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 60 | } |
| 61 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 62 | if (imageSymbol) |
| 63 | { |
| 64 | return imageSymbol->getSymbol().c_str(); |
| 65 | } |
| 66 | return "image"; |
| 67 | } |
| 68 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 69 | } // namespace |
| 70 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 71 | TParseContext::TParseContext(TSymbolTable &symt, |
| 72 | TExtensionBehavior &ext, |
| 73 | sh::GLenum type, |
| 74 | ShShaderSpec spec, |
| 75 | ShCompileOptions options, |
| 76 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 77 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 78 | const ShBuiltInResources &resources) |
| 79 | : intermediate(), |
| 80 | symbolTable(symt), |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 81 | mDeferredNonEmptyDeclarationErrorCheck(false), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 82 | mShaderType(type), |
| 83 | mShaderSpec(spec), |
| 84 | mCompileOptions(options), |
| 85 | mShaderVersion(100), |
| 86 | mTreeRoot(nullptr), |
| 87 | mLoopNestingLevel(0), |
| 88 | mStructNestingLevel(0), |
| 89 | mSwitchNestingLevel(0), |
| 90 | mCurrentFunctionType(nullptr), |
| 91 | mFunctionReturnsValue(false), |
| 92 | mChecksPrecisionErrors(checksPrecErrors), |
| 93 | mFragmentPrecisionHighOnESSL1(false), |
| 94 | mDefaultMatrixPacking(EmpColumnMajor), |
| 95 | mDefaultBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 96 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 97 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 98 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 99 | mShaderVersion, |
| 100 | mShaderType, |
| 101 | resources.WEBGL_debug_shader_precision == 1), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 102 | mPreprocessor(mDiagnostics, &mDirectiveHandler, pp::PreprocessorSettings()), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 103 | mScanner(nullptr), |
| 104 | mUsesFragData(false), |
| 105 | mUsesFragColor(false), |
| 106 | mUsesSecondaryOutputs(false), |
| 107 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 108 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 109 | mMultiviewAvailable(resources.OVR_multiview == 1), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 110 | mComputeShaderLocalSizeDeclared(false), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 111 | mNumViews(-1), |
| 112 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 113 | mMaxImageUnits(resources.MaxImageUnits), |
| 114 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 115 | mMaxUniformLocations(resources.MaxUniformLocations), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 116 | mDeclaringFunction(false) |
| 117 | { |
| 118 | mComputeShaderLocalSize.fill(-1); |
| 119 | } |
| 120 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 121 | // |
| 122 | // Look at a '.' field selector string and change it into offsets |
| 123 | // for a vector. |
| 124 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 125 | bool TParseContext::parseVectorFields(const TString &compString, |
| 126 | int vecSize, |
| 127 | TVectorFields &fields, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 128 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 129 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 130 | fields.num = (int)compString.size(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 131 | if (fields.num > 4) |
| 132 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 133 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 134 | return false; |
| 135 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 136 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 137 | enum |
| 138 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 139 | exyzw, |
| 140 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 141 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 142 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 143 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 144 | for (int i = 0; i < fields.num; ++i) |
| 145 | { |
| 146 | switch (compString[i]) |
| 147 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 148 | case 'x': |
| 149 | fields.offsets[i] = 0; |
| 150 | fieldSet[i] = exyzw; |
| 151 | break; |
| 152 | case 'r': |
| 153 | fields.offsets[i] = 0; |
| 154 | fieldSet[i] = ergba; |
| 155 | break; |
| 156 | case 's': |
| 157 | fields.offsets[i] = 0; |
| 158 | fieldSet[i] = estpq; |
| 159 | break; |
| 160 | case 'y': |
| 161 | fields.offsets[i] = 1; |
| 162 | fieldSet[i] = exyzw; |
| 163 | break; |
| 164 | case 'g': |
| 165 | fields.offsets[i] = 1; |
| 166 | fieldSet[i] = ergba; |
| 167 | break; |
| 168 | case 't': |
| 169 | fields.offsets[i] = 1; |
| 170 | fieldSet[i] = estpq; |
| 171 | break; |
| 172 | case 'z': |
| 173 | fields.offsets[i] = 2; |
| 174 | fieldSet[i] = exyzw; |
| 175 | break; |
| 176 | case 'b': |
| 177 | fields.offsets[i] = 2; |
| 178 | fieldSet[i] = ergba; |
| 179 | break; |
| 180 | case 'p': |
| 181 | fields.offsets[i] = 2; |
| 182 | fieldSet[i] = estpq; |
| 183 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 184 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 185 | case 'w': |
| 186 | fields.offsets[i] = 3; |
| 187 | fieldSet[i] = exyzw; |
| 188 | break; |
| 189 | case 'a': |
| 190 | fields.offsets[i] = 3; |
| 191 | fieldSet[i] = ergba; |
| 192 | break; |
| 193 | case 'q': |
| 194 | fields.offsets[i] = 3; |
| 195 | fieldSet[i] = estpq; |
| 196 | break; |
| 197 | default: |
| 198 | error(line, "illegal vector field selection", compString.c_str()); |
| 199 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 200 | } |
| 201 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 202 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 203 | for (int i = 0; i < fields.num; ++i) |
| 204 | { |
| 205 | if (fields.offsets[i] >= vecSize) |
| 206 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 207 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 208 | return false; |
| 209 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 210 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 211 | if (i > 0) |
| 212 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 213 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 214 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 215 | error(line, "illegal - vector component fields not from the same set", |
| 216 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 217 | return false; |
| 218 | } |
| 219 | } |
| 220 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 221 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 222 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 223 | } |
| 224 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 225 | /////////////////////////////////////////////////////////////////////// |
| 226 | // |
| 227 | // Errors |
| 228 | // |
| 229 | //////////////////////////////////////////////////////////////////////// |
| 230 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 231 | // |
| 232 | // Used by flex/bison to output all syntax and parsing errors. |
| 233 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 234 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 235 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 236 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 237 | } |
| 238 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 239 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 240 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 241 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 242 | } |
| 243 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 244 | void TParseContext::outOfRangeError(bool isError, |
| 245 | const TSourceLoc &loc, |
| 246 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 247 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 248 | { |
| 249 | if (isError) |
| 250 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 251 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 252 | } |
| 253 | else |
| 254 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 255 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 256 | } |
| 257 | } |
| 258 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 259 | // |
| 260 | // Same error message for all places assignments don't work. |
| 261 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 262 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 263 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 264 | std::stringstream reasonStream; |
| 265 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 266 | std::string reason = reasonStream.str(); |
| 267 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 268 | } |
| 269 | |
| 270 | // |
| 271 | // Same error message for all places unary operations don't work. |
| 272 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 273 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 274 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 275 | std::stringstream reasonStream; |
| 276 | reasonStream << "wrong operand type - no operation '" << op |
| 277 | << "' exists that takes an operand of type " << operand |
| 278 | << " (or there is no acceptable conversion)"; |
| 279 | std::string reason = reasonStream.str(); |
| 280 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 281 | } |
| 282 | |
| 283 | // |
| 284 | // Same error message for all binary operations don't work. |
| 285 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 286 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 287 | const char *op, |
| 288 | TString left, |
| 289 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 290 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 291 | std::stringstream reasonStream; |
| 292 | reasonStream << "wrong operand types - no operation '" << op |
| 293 | << "' exists that takes a left-hand operand of type '" << left |
| 294 | << "' and a right operand of type '" << right |
| 295 | << "' (or there is no acceptable conversion)"; |
| 296 | std::string reason = reasonStream.str(); |
| 297 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 298 | } |
| 299 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 300 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 301 | TPrecision precision, |
| 302 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 303 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 304 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 305 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 306 | |
| 307 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 308 | { |
| 309 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 310 | } |
| 311 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 312 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 313 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 314 | switch (type) |
| 315 | { |
| 316 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 317 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 318 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 319 | case EbtInt: |
| 320 | case EbtUInt: |
| 321 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 322 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 323 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 324 | default: |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 325 | if (IsOpaqueType(type)) |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 326 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 327 | error(line, "No precision specified", getBasicString(type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 328 | return; |
| 329 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 330 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 331 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 332 | } |
| 333 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 334 | // Both test and if necessary, spit out an error, to see if the node is really |
| 335 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 336 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 337 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 338 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 339 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 340 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 341 | |
| 342 | if (swizzleNode) |
| 343 | { |
| 344 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 345 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 346 | { |
| 347 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 348 | return false; |
| 349 | } |
| 350 | return ok; |
| 351 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 352 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 353 | if (binaryNode) |
| 354 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 355 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 356 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 357 | case EOpIndexDirect: |
| 358 | case EOpIndexIndirect: |
| 359 | case EOpIndexDirectStruct: |
| 360 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 361 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 362 | default: |
| 363 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 364 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 365 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 366 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 367 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 368 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 369 | std::string message; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 370 | switch (node->getQualifier()) |
| 371 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 372 | case EvqConst: |
| 373 | message = "can't modify a const"; |
| 374 | break; |
| 375 | case EvqConstReadOnly: |
| 376 | message = "can't modify a const"; |
| 377 | break; |
| 378 | case EvqAttribute: |
| 379 | message = "can't modify an attribute"; |
| 380 | break; |
| 381 | case EvqFragmentIn: |
| 382 | message = "can't modify an input"; |
| 383 | break; |
| 384 | case EvqVertexIn: |
| 385 | message = "can't modify an input"; |
| 386 | break; |
| 387 | case EvqUniform: |
| 388 | message = "can't modify a uniform"; |
| 389 | break; |
| 390 | case EvqVaryingIn: |
| 391 | message = "can't modify a varying"; |
| 392 | break; |
| 393 | case EvqFragCoord: |
| 394 | message = "can't modify gl_FragCoord"; |
| 395 | break; |
| 396 | case EvqFrontFacing: |
| 397 | message = "can't modify gl_FrontFacing"; |
| 398 | break; |
| 399 | case EvqPointCoord: |
| 400 | message = "can't modify gl_PointCoord"; |
| 401 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 402 | case EvqNumWorkGroups: |
| 403 | message = "can't modify gl_NumWorkGroups"; |
| 404 | break; |
| 405 | case EvqWorkGroupSize: |
| 406 | message = "can't modify gl_WorkGroupSize"; |
| 407 | break; |
| 408 | case EvqWorkGroupID: |
| 409 | message = "can't modify gl_WorkGroupID"; |
| 410 | break; |
| 411 | case EvqLocalInvocationID: |
| 412 | message = "can't modify gl_LocalInvocationID"; |
| 413 | break; |
| 414 | case EvqGlobalInvocationID: |
| 415 | message = "can't modify gl_GlobalInvocationID"; |
| 416 | break; |
| 417 | case EvqLocalInvocationIndex: |
| 418 | message = "can't modify gl_LocalInvocationIndex"; |
| 419 | break; |
Olli Etuaho | 7142f6c | 2017-05-05 17:07:26 +0300 | [diff] [blame] | 420 | case EvqViewIDOVR: |
| 421 | message = "can't modify gl_ViewID_OVR"; |
| 422 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 423 | case EvqComputeIn: |
| 424 | message = "can't modify work group size variable"; |
| 425 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 426 | default: |
| 427 | // |
| 428 | // Type that can't be written to? |
| 429 | // |
| 430 | if (node->getBasicType() == EbtVoid) |
| 431 | { |
| 432 | message = "can't modify void"; |
| 433 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 434 | if (IsOpaqueType(node->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 435 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 436 | message = "can't modify a variable with type "; |
| 437 | message += getBasicString(node->getBasicType()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 438 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 439 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 440 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 441 | if (message.empty() && binaryNode == 0 && symNode == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 442 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 443 | error(line, "l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 444 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 445 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 446 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 447 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 448 | // |
| 449 | // Everything else is okay, no error. |
| 450 | // |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 451 | if (message.empty()) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 452 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 453 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 454 | // |
| 455 | // If we get here, we have an error and a message. |
| 456 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 457 | if (symNode) |
| 458 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 459 | const char *symbol = symNode->getSymbol().c_str(); |
| 460 | std::stringstream reasonStream; |
| 461 | reasonStream << "l-value required (" << message << " \"" << symbol << "\")"; |
| 462 | std::string reason = reasonStream.str(); |
| 463 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 464 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 465 | else |
| 466 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 467 | std::stringstream reasonStream; |
| 468 | reasonStream << "l-value required (" << message << ")"; |
| 469 | std::string reason = reasonStream.str(); |
| 470 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 471 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 472 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 473 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 474 | } |
| 475 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 476 | // Both test, and if necessary spit out an error, to see if the node is really |
| 477 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 478 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 479 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 480 | if (node->getQualifier() != EvqConst) |
| 481 | { |
| 482 | error(node->getLine(), "constant expression required", ""); |
| 483 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 484 | } |
| 485 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 486 | // Both test, and if necessary spit out an error, to see if the node is really |
| 487 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 488 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 489 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 490 | if (!node->isScalarInt()) |
| 491 | { |
| 492 | error(node->getLine(), "integer expression required", token); |
| 493 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 494 | } |
| 495 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 496 | // Both test, and if necessary spit out an error, to see if we are currently |
| 497 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 498 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 499 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 500 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 501 | { |
| 502 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 503 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 504 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 505 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 506 | } |
| 507 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 508 | // For now, keep it simple: if it starts "gl_", it's reserved, independent |
| 509 | // of scope. Except, if the symbol table is at the built-in push-level, |
| 510 | // which is when we are parsing built-ins. |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 511 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a |
| 512 | // webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 513 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 514 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 515 | static const char *reservedErrMsg = "reserved built-in name"; |
| 516 | if (!symbolTable.atBuiltInLevel()) |
| 517 | { |
| 518 | if (identifier.compare(0, 3, "gl_") == 0) |
| 519 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 520 | error(line, reservedErrMsg, "gl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 521 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 522 | } |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 523 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 524 | { |
| 525 | if (identifier.compare(0, 6, "webgl_") == 0) |
| 526 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 527 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 528 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 529 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 530 | if (identifier.compare(0, 7, "_webgl_") == 0) |
| 531 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 532 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 533 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 534 | } |
| 535 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 536 | if (identifier.find("__") != TString::npos) |
| 537 | { |
| 538 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 539 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 540 | "possible future keywords", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 541 | identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 542 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 543 | } |
| 544 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 545 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 546 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 547 | } |
| 548 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 549 | // Make sure the argument types are correct for constructing a specific type. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 550 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 551 | const TIntermSequence *arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 552 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 553 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 554 | if (arguments->empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 555 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 556 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 557 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 558 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 559 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 560 | for (TIntermNode *arg : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 561 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 562 | const TIntermTyped *argTyped = arg->getAsTyped(); |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 563 | ASSERT(argTyped != nullptr); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 564 | if (type.getBasicType() != EbtStruct && IsOpaqueType(argTyped->getBasicType())) |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 565 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 566 | std::string reason("cannot convert a variable with type "); |
| 567 | reason += getBasicString(argTyped->getBasicType()); |
| 568 | error(line, reason.c_str(), "constructor"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 569 | return false; |
| 570 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 571 | if (argTyped->getBasicType() == EbtVoid) |
| 572 | { |
| 573 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 574 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 575 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 576 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 577 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 578 | if (type.isArray()) |
| 579 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 580 | // The size of an unsized constructor should already have been determined. |
| 581 | ASSERT(!type.isUnsizedArray()); |
| 582 | if (static_cast<size_t>(type.getArraySize()) != arguments->size()) |
| 583 | { |
| 584 | error(line, "array constructor needs one argument per array element", "constructor"); |
| 585 | return false; |
| 586 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 587 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 588 | // the array. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 589 | for (TIntermNode *const &argNode : *arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 590 | { |
| 591 | const TType &argType = argNode->getAsTyped()->getType(); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 592 | if (argType.isArray()) |
| 593 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 594 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 595 | return false; |
| 596 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 597 | if (!argType.sameElementType(type)) |
| 598 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 599 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 600 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 601 | } |
| 602 | } |
| 603 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 604 | else if (type.getBasicType() == EbtStruct) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 605 | { |
| 606 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 607 | if (fields.size() != arguments->size()) |
| 608 | { |
| 609 | error(line, |
| 610 | "Number of constructor parameters does not match the number of structure fields", |
| 611 | "constructor"); |
| 612 | return false; |
| 613 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 614 | |
| 615 | for (size_t i = 0; i < fields.size(); i++) |
| 616 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 617 | if (i >= arguments->size() || |
| 618 | (*arguments)[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 619 | { |
| 620 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 621 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 622 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 623 | } |
| 624 | } |
| 625 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 626 | else |
| 627 | { |
| 628 | // We're constructing a scalar, vector, or matrix. |
| 629 | |
| 630 | // Note: It's okay to have too many components available, but not okay to have unused |
| 631 | // arguments. 'full' will go to true when enough args have been seen. If we loop again, |
| 632 | // there is an extra argument, so 'overFull' will become true. |
| 633 | |
| 634 | size_t size = 0; |
| 635 | bool full = false; |
| 636 | bool overFull = false; |
| 637 | bool matrixArg = false; |
| 638 | for (TIntermNode *arg : *arguments) |
| 639 | { |
| 640 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 641 | ASSERT(argTyped != nullptr); |
| 642 | |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame^] | 643 | if (argTyped->getBasicType() == EbtStruct) |
| 644 | { |
| 645 | error(line, "a struct cannot be used as a constructor argument for this type", |
| 646 | "constructor"); |
| 647 | return false; |
| 648 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 649 | if (argTyped->getType().isArray()) |
| 650 | { |
| 651 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 652 | return false; |
| 653 | } |
| 654 | if (argTyped->getType().isMatrix()) |
| 655 | { |
| 656 | matrixArg = true; |
| 657 | } |
| 658 | |
| 659 | size += argTyped->getType().getObjectSize(); |
| 660 | if (full) |
| 661 | { |
| 662 | overFull = true; |
| 663 | } |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame^] | 664 | if (size >= type.getObjectSize()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 665 | { |
| 666 | full = true; |
| 667 | } |
| 668 | } |
| 669 | |
| 670 | if (type.isMatrix() && matrixArg) |
| 671 | { |
| 672 | if (arguments->size() != 1) |
| 673 | { |
| 674 | error(line, "constructing matrix from matrix can only take one argument", |
| 675 | "constructor"); |
| 676 | return false; |
| 677 | } |
| 678 | } |
| 679 | else |
| 680 | { |
| 681 | if (size != 1 && size < type.getObjectSize()) |
| 682 | { |
| 683 | error(line, "not enough data provided for construction", "constructor"); |
| 684 | return false; |
| 685 | } |
| 686 | if (overFull) |
| 687 | { |
| 688 | error(line, "too many arguments", "constructor"); |
| 689 | return false; |
| 690 | } |
| 691 | } |
| 692 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 693 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 694 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 695 | } |
| 696 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 697 | // This function checks to see if a void variable has been declared and raise an error message for |
| 698 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 699 | // |
| 700 | // returns true in case of an error |
| 701 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 702 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 703 | const TString &identifier, |
| 704 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 705 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 706 | if (type == EbtVoid) |
| 707 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 708 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 709 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 710 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 711 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 712 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 713 | } |
| 714 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 715 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 716 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 717 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 718 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 719 | if (type->getBasicType() != EbtBool || type->isArray() || type->isMatrix() || type->isVector()) |
| 720 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 721 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 722 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 723 | } |
| 724 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 725 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 726 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 727 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 728 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 729 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 730 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 731 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 732 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 733 | } |
| 734 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 735 | bool TParseContext::checkIsNotOpaqueType(const TSourceLoc &line, |
| 736 | const TTypeSpecifierNonArray &pType, |
| 737 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 738 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 739 | if (pType.type == EbtStruct) |
| 740 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 741 | if (ContainsSampler(*pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 742 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 743 | std::stringstream reasonStream; |
| 744 | reasonStream << reason << " (structure contains a sampler)"; |
| 745 | std::string reasonStr = reasonStream.str(); |
| 746 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 747 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 748 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 749 | // only samplers need to be checked from structs, since other opaque types can't be struct |
| 750 | // members. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 751 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 752 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 753 | else if (IsOpaqueType(pType.type)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 754 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 755 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 756 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 757 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 758 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 759 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 760 | } |
| 761 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 762 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 763 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 764 | { |
| 765 | if (pType.layoutQualifier.location != -1) |
| 766 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 767 | error(line, "location must only be specified for a single input or output variable", |
| 768 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 769 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 770 | } |
| 771 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 772 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 773 | const TLayoutQualifier &layoutQualifier) |
| 774 | { |
| 775 | if (layoutQualifier.location != -1) |
| 776 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 777 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 778 | if (mShaderVersion >= 310) |
| 779 | { |
| 780 | errorMsg = |
| 781 | "invalid layout qualifier: only valid on program inputs, outputs, and uniforms"; |
| 782 | } |
| 783 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 784 | } |
| 785 | } |
| 786 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 787 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 788 | TQualifier qualifier, |
| 789 | const TType &type) |
| 790 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 791 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 792 | if (IsOpaqueType(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 793 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 794 | error(line, "opaque types cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 795 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 796 | } |
| 797 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 798 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 799 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 800 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 801 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 802 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 803 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 804 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 805 | // fold as array size. |
| 806 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 807 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 808 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 809 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 810 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 811 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 812 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 813 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 814 | if (constant->getBasicType() == EbtUInt) |
| 815 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 816 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 817 | } |
| 818 | else |
| 819 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 820 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 821 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 822 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 823 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 824 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 825 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 826 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 827 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 828 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 829 | } |
| 830 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 831 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 832 | { |
| 833 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 834 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 835 | } |
| 836 | |
| 837 | // The size of arrays is restricted here to prevent issues further down the |
| 838 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 839 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 840 | const unsigned int sizeLimit = 65536; |
| 841 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 842 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 843 | { |
| 844 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 845 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 846 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 847 | |
| 848 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 849 | } |
| 850 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 851 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 852 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 853 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 854 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 855 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 856 | (elementQualifier.qualifier == EvqVertexIn) || |
| 857 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 858 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 859 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 860 | TType(elementQualifier).getQualifierString()); |
| 861 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 862 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 863 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 864 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 865 | } |
| 866 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 867 | // See if this element type can be formed into an array. |
| 868 | bool TParseContext::checkIsValidTypeForArray(const TSourceLoc &line, const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 869 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 870 | // |
| 871 | // Can the type be an array? |
| 872 | // |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 873 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 874 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 875 | error(line, "cannot declare arrays of arrays", |
| 876 | TType(elementType).getCompleteString().c_str()); |
| 877 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 878 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 879 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 880 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 881 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 882 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 883 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 884 | { |
| 885 | error(line, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 886 | TType(elementType).getCompleteString().c_str()); |
| 887 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 888 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 889 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 890 | return true; |
| 891 | } |
| 892 | |
| 893 | // Check if this qualified element type can be formed into an array. |
| 894 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 895 | const TPublicType &elementType) |
| 896 | { |
| 897 | if (checkIsValidTypeForArray(indexLocation, elementType)) |
| 898 | { |
| 899 | return checkIsValidQualifierForArray(indexLocation, elementType); |
| 900 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 901 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 902 | } |
| 903 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 904 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 905 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 906 | const TString &identifier, |
| 907 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 908 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 909 | ASSERT(type != nullptr); |
| 910 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 911 | { |
| 912 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 913 | type->qualifier = EvqTemporary; |
| 914 | |
| 915 | // Generate informative error messages for ESSL1. |
| 916 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 917 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 918 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 919 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 920 | "structures containing arrays may not be declared constant since they cannot be " |
| 921 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 922 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 923 | } |
| 924 | else |
| 925 | { |
| 926 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 927 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 928 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 929 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 930 | if (type->isUnsizedArray()) |
| 931 | { |
| 932 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 933 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 934 | } |
| 935 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 936 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 937 | // and update the symbol table. |
| 938 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 939 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 940 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 941 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 942 | const TString &identifier, |
| 943 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 944 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 945 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 946 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 947 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 948 | checkBindingIsValid(line, type); |
| 949 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 950 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 951 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 952 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 953 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 954 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 955 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 956 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 957 | if (static_cast<int>(type.getArraySize()) == maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 958 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 959 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 960 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 961 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 962 | } |
| 963 | } |
| 964 | else |
| 965 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 966 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 967 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 968 | return false; |
| 969 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 970 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 971 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 972 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 973 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 974 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 975 | (*variable) = new TVariable(&identifier, type); |
| 976 | if (!symbolTable.declare(*variable)) |
| 977 | { |
| 978 | error(line, "redefinition", identifier.c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 979 | *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 980 | return false; |
| 981 | } |
| 982 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 983 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 984 | return false; |
| 985 | |
| 986 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 987 | } |
| 988 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 989 | void TParseContext::checkIsParameterQualifierValid( |
| 990 | const TSourceLoc &line, |
| 991 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 992 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 993 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 994 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 995 | |
| 996 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 997 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 998 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 999 | } |
| 1000 | |
| 1001 | if (!IsImage(type->getBasicType())) |
| 1002 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1003 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1004 | } |
| 1005 | else |
| 1006 | { |
| 1007 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1008 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1009 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1010 | type->setQualifier(typeQualifier.qualifier); |
| 1011 | |
| 1012 | if (typeQualifier.precision != EbpUndefined) |
| 1013 | { |
| 1014 | type->setPrecision(typeQualifier.precision); |
| 1015 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1016 | } |
| 1017 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1018 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1019 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1020 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1021 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1022 | if (iter == extBehavior.end()) |
| 1023 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1024 | error(line, "extension is not supported", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1025 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1026 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 1027 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1028 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 1029 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1030 | // TODO(oetuaho@nvidia.com): This is slightly hacky. Might be better if symbols could be |
| 1031 | // associated with more than one extension. |
| 1032 | if (extension == "GL_OVR_multiview") |
| 1033 | { |
| 1034 | return checkCanUseExtension(line, "GL_OVR_multiview2"); |
| 1035 | } |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1036 | error(line, "extension is disabled", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1037 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1038 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1039 | if (iter->second == EBhWarn) |
| 1040 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1041 | warning(line, "extension is being used", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1042 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1043 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1044 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1045 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1046 | } |
| 1047 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1048 | // ESSL 3.00.6 section 4.8 Empty Declarations: "The combinations of qualifiers that cause |
| 1049 | // compile-time or link-time errors are the same whether or not the declaration is empty". |
| 1050 | // This function implements all the checks that are done on qualifiers regardless of if the |
| 1051 | // declaration is empty. |
| 1052 | void TParseContext::declarationQualifierErrorCheck(const sh::TQualifier qualifier, |
| 1053 | const sh::TLayoutQualifier &layoutQualifier, |
| 1054 | const TSourceLoc &location) |
| 1055 | { |
| 1056 | if (qualifier == EvqShared && !layoutQualifier.isEmpty()) |
| 1057 | { |
| 1058 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1059 | } |
| 1060 | |
| 1061 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1062 | { |
| 1063 | error(location, "layout qualifier only valid for interface blocks", |
| 1064 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
| 1065 | return; |
| 1066 | } |
| 1067 | |
| 1068 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1069 | { |
| 1070 | error(location, "layout qualifier only valid for interface blocks", |
| 1071 | getBlockStorageString(layoutQualifier.blockStorage)); |
| 1072 | return; |
| 1073 | } |
| 1074 | |
| 1075 | if (qualifier == EvqFragmentOut) |
| 1076 | { |
| 1077 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1078 | { |
| 1079 | error(location, "invalid layout qualifier combination", "yuv"); |
| 1080 | return; |
| 1081 | } |
| 1082 | } |
| 1083 | else |
| 1084 | { |
| 1085 | checkYuvIsNotSpecified(location, layoutQualifier.yuv); |
| 1086 | } |
| 1087 | |
| 1088 | bool canHaveLocation = qualifier == EvqVertexIn || qualifier == EvqFragmentOut; |
| 1089 | if (mShaderVersion >= 310 && qualifier == EvqUniform) |
| 1090 | { |
| 1091 | canHaveLocation = true; |
| 1092 | // We're not checking whether the uniform location is in range here since that depends on |
| 1093 | // the type of the variable. |
| 1094 | // The type can only be fully determined for non-empty declarations. |
| 1095 | } |
| 1096 | if (!canHaveLocation) |
| 1097 | { |
| 1098 | checkLocationIsNotSpecified(location, layoutQualifier); |
| 1099 | } |
| 1100 | } |
| 1101 | |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1102 | void TParseContext::emptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1103 | const TSourceLoc &location) |
| 1104 | { |
| 1105 | if (publicType.isUnsizedArray()) |
| 1106 | { |
| 1107 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1108 | // error. It is assumed that this applies to empty declarations as well. |
| 1109 | error(location, "empty array declaration needs to specify a size", ""); |
| 1110 | } |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1111 | } |
| 1112 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1113 | // These checks are done for all declarations that are non-empty. They're done for non-empty |
| 1114 | // declarations starting a declarator list, and declarators that follow an empty declaration. |
| 1115 | void TParseContext::nonEmptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1116 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1117 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1118 | switch (publicType.qualifier) |
| 1119 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1120 | case EvqVaryingIn: |
| 1121 | case EvqVaryingOut: |
| 1122 | case EvqAttribute: |
| 1123 | case EvqVertexIn: |
| 1124 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1125 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1126 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1127 | { |
| 1128 | error(identifierLocation, "cannot be used with a structure", |
| 1129 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1130 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1131 | } |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1132 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1133 | default: |
| 1134 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1135 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1136 | std::string reason(getBasicString(publicType.getBasicType())); |
| 1137 | reason += "s must be uniform"; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1138 | if (publicType.qualifier != EvqUniform && |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1139 | !checkIsNotOpaqueType(identifierLocation, publicType.typeSpecifierNonArray, reason.c_str())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1140 | { |
| 1141 | return; |
| 1142 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1143 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1144 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1145 | publicType.qualifier != EvqConst) && |
| 1146 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1147 | { |
| 1148 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1149 | getQualifierString(publicType.qualifier)); |
| 1150 | return; |
| 1151 | } |
| 1152 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1153 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1154 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1155 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1156 | // But invalid shaders may still reach here with an unsized array declaration. |
| 1157 | if (!publicType.isUnsizedArray()) |
| 1158 | { |
| 1159 | TType type(publicType); |
| 1160 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1161 | publicType.layoutQualifier); |
| 1162 | } |
| 1163 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1164 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1165 | // check for layout qualifier issues |
| 1166 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1167 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1168 | if (IsImage(publicType.getBasicType())) |
| 1169 | { |
| 1170 | |
| 1171 | switch (layoutQualifier.imageInternalFormat) |
| 1172 | { |
| 1173 | case EiifRGBA32F: |
| 1174 | case EiifRGBA16F: |
| 1175 | case EiifR32F: |
| 1176 | case EiifRGBA8: |
| 1177 | case EiifRGBA8_SNORM: |
| 1178 | if (!IsFloatImage(publicType.getBasicType())) |
| 1179 | { |
| 1180 | error(identifierLocation, |
| 1181 | "internal image format requires a floating image type", |
| 1182 | getBasicString(publicType.getBasicType())); |
| 1183 | return; |
| 1184 | } |
| 1185 | break; |
| 1186 | case EiifRGBA32I: |
| 1187 | case EiifRGBA16I: |
| 1188 | case EiifRGBA8I: |
| 1189 | case EiifR32I: |
| 1190 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1191 | { |
| 1192 | error(identifierLocation, |
| 1193 | "internal image format requires an integer image type", |
| 1194 | getBasicString(publicType.getBasicType())); |
| 1195 | return; |
| 1196 | } |
| 1197 | break; |
| 1198 | case EiifRGBA32UI: |
| 1199 | case EiifRGBA16UI: |
| 1200 | case EiifRGBA8UI: |
| 1201 | case EiifR32UI: |
| 1202 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1203 | { |
| 1204 | error(identifierLocation, |
| 1205 | "internal image format requires an unsigned image type", |
| 1206 | getBasicString(publicType.getBasicType())); |
| 1207 | return; |
| 1208 | } |
| 1209 | break; |
| 1210 | case EiifUnspecified: |
| 1211 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1212 | return; |
| 1213 | default: |
| 1214 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1215 | return; |
| 1216 | } |
| 1217 | |
| 1218 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1219 | switch (layoutQualifier.imageInternalFormat) |
| 1220 | { |
| 1221 | case EiifR32F: |
| 1222 | case EiifR32I: |
| 1223 | case EiifR32UI: |
| 1224 | break; |
| 1225 | default: |
| 1226 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1227 | { |
| 1228 | error(identifierLocation, "layout qualifier", |
| 1229 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1230 | "image variables must be qualified readonly and/or writeonly"); |
| 1231 | return; |
| 1232 | } |
| 1233 | break; |
| 1234 | } |
| 1235 | } |
| 1236 | else |
| 1237 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1238 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1239 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1240 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1241 | } |
| 1242 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1243 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1244 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1245 | { |
| 1246 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
| 1247 | int arraySize = type.isArray() ? type.getArraySize() : 1; |
| 1248 | if (IsImage(type.getBasicType())) |
| 1249 | { |
| 1250 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1251 | } |
| 1252 | else if (IsSampler(type.getBasicType())) |
| 1253 | { |
| 1254 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1255 | } |
| 1256 | else |
| 1257 | { |
| 1258 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1259 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1260 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1261 | } |
| 1262 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1263 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1264 | const TString &layoutQualifierName, |
| 1265 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1266 | { |
| 1267 | |
| 1268 | if (mShaderVersion < versionRequired) |
| 1269 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1270 | error(location, "invalid layout qualifier: not supported", layoutQualifierName.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1271 | } |
| 1272 | } |
| 1273 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1274 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1275 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1276 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1277 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1278 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1279 | { |
| 1280 | if (localSize[i] != -1) |
| 1281 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1282 | error(location, |
| 1283 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1284 | "global layout declaration", |
| 1285 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1286 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1287 | } |
| 1288 | } |
| 1289 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1290 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1291 | } |
| 1292 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1293 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1294 | TLayoutImageInternalFormat internalFormat) |
| 1295 | { |
| 1296 | if (internalFormat != EiifUnspecified) |
| 1297 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1298 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1299 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1300 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1301 | } |
| 1302 | |
| 1303 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1304 | { |
| 1305 | if (binding != -1) |
| 1306 | { |
| 1307 | error(location, |
| 1308 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1309 | "binding"); |
| 1310 | } |
| 1311 | } |
| 1312 | |
| 1313 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, int binding, int arraySize) |
| 1314 | { |
| 1315 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1316 | if (binding >= 0 && binding + arraySize > mMaxImageUnits) |
| 1317 | { |
| 1318 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1319 | } |
| 1320 | } |
| 1321 | |
| 1322 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1323 | int binding, |
| 1324 | int arraySize) |
| 1325 | { |
| 1326 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1327 | if (binding >= 0 && binding + arraySize > mMaxCombinedTextureImageUnits) |
| 1328 | { |
| 1329 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1330 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1331 | } |
| 1332 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1333 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1334 | int objectLocationCount, |
| 1335 | const TLayoutQualifier &layoutQualifier) |
| 1336 | { |
| 1337 | int loc = layoutQualifier.location; |
| 1338 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1339 | { |
| 1340 | error(location, "Uniform location out of range", "location"); |
| 1341 | } |
| 1342 | } |
| 1343 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1344 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1345 | { |
| 1346 | if (yuv != false) |
| 1347 | { |
| 1348 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1349 | } |
| 1350 | } |
| 1351 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1352 | void TParseContext::functionCallLValueErrorCheck(const TFunction *fnCandidate, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1353 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1354 | { |
| 1355 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1356 | { |
| 1357 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
| 1358 | if (qual == EvqOut || qual == EvqInOut) |
| 1359 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1360 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1361 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1362 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1363 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1364 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 1365 | fnCall->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1366 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1367 | } |
| 1368 | } |
| 1369 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1370 | } |
| 1371 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1372 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1373 | const TQualifier qualifier, |
| 1374 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1375 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1376 | if (!invariant) |
| 1377 | return; |
| 1378 | |
| 1379 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1380 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1381 | // input variables in the fragment shader can be also qualified as invariant |
| 1382 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1383 | { |
| 1384 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1385 | } |
| 1386 | } |
| 1387 | else |
| 1388 | { |
| 1389 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1390 | { |
| 1391 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1392 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1393 | } |
| 1394 | } |
| 1395 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1396 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1397 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1398 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1399 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1400 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1401 | } |
| 1402 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1403 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1404 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1405 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1406 | } |
| 1407 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1408 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1409 | const char *extName, |
| 1410 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1411 | { |
| 1412 | pp::SourceLocation srcLoc; |
| 1413 | srcLoc.file = loc.first_file; |
| 1414 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1415 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1416 | } |
| 1417 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1418 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1419 | const char *name, |
| 1420 | const char *value, |
| 1421 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1422 | { |
| 1423 | pp::SourceLocation srcLoc; |
| 1424 | srcLoc.file = loc.first_file; |
| 1425 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1426 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1427 | } |
| 1428 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1429 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1430 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1431 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1432 | for (size_t i = 0u; i < result.size(); ++i) |
| 1433 | { |
| 1434 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1435 | { |
| 1436 | result[i] = 1; |
| 1437 | } |
| 1438 | else |
| 1439 | { |
| 1440 | result[i] = mComputeShaderLocalSize[i]; |
| 1441 | } |
| 1442 | } |
| 1443 | return result; |
| 1444 | } |
| 1445 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1446 | ///////////////////////////////////////////////////////////////////////////////// |
| 1447 | // |
| 1448 | // Non-Errors. |
| 1449 | // |
| 1450 | ///////////////////////////////////////////////////////////////////////////////// |
| 1451 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1452 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1453 | const TString *name, |
| 1454 | const TSymbol *symbol) |
| 1455 | { |
Yunchao He | d7297bf | 2017-04-19 15:27:10 +0800 | [diff] [blame] | 1456 | const TVariable *variable = nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1457 | |
| 1458 | if (!symbol) |
| 1459 | { |
| 1460 | error(location, "undeclared identifier", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1461 | } |
| 1462 | else if (!symbol->isVariable()) |
| 1463 | { |
| 1464 | error(location, "variable expected", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1465 | } |
| 1466 | else |
| 1467 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1468 | variable = static_cast<const TVariable *>(symbol); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1469 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1470 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1471 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1472 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1473 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1474 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1475 | |
| 1476 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1477 | TQualifier qualifier = variable->getType().getQualifier(); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1478 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1479 | { |
| 1480 | mUsesFragData = true; |
| 1481 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1482 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1483 | { |
| 1484 | mUsesFragColor = true; |
| 1485 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1486 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1487 | { |
| 1488 | mUsesSecondaryOutputs = true; |
| 1489 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1490 | |
| 1491 | // This validation is not quite correct - it's only an error to write to |
| 1492 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1493 | // be rewarded for reading from undefined varaibles, return an error |
| 1494 | // if they are both referenced, rather than assigned. |
| 1495 | if (mUsesFragData && mUsesFragColor) |
| 1496 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1497 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1498 | if (mUsesSecondaryOutputs) |
| 1499 | { |
| 1500 | errorMessage = |
| 1501 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1502 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1503 | } |
| 1504 | error(location, errorMessage, name->c_str()); |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1505 | } |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 1506 | |
| 1507 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1508 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1509 | qualifier == EvqWorkGroupSize) |
| 1510 | { |
| 1511 | error(location, |
| 1512 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1513 | "gl_WorkGroupSize"); |
| 1514 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1515 | } |
| 1516 | |
| 1517 | if (!variable) |
| 1518 | { |
| 1519 | TType type(EbtFloat, EbpUndefined); |
| 1520 | TVariable *fakeVariable = new TVariable(name, type); |
| 1521 | symbolTable.declare(fakeVariable); |
| 1522 | variable = fakeVariable; |
| 1523 | } |
| 1524 | |
| 1525 | return variable; |
| 1526 | } |
| 1527 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1528 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1529 | const TString *name, |
| 1530 | const TSymbol *symbol) |
| 1531 | { |
| 1532 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1533 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1534 | if (variable->getType().getQualifier() == EvqViewIDOVR && IsWebGLBasedSpec(mShaderSpec) && |
| 1535 | mShaderType == GL_FRAGMENT_SHADER && !isExtensionEnabled("GL_OVR_multiview2")) |
| 1536 | { |
| 1537 | // WEBGL_multiview spec |
| 1538 | error(location, "Need to enable OVR_multiview2 to use gl_ViewID_OVR in fragment shader", |
| 1539 | "gl_ViewID_OVR"); |
| 1540 | } |
| 1541 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1542 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1543 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1544 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1545 | return intermediate.addConstantUnion(constArray, variable->getType(), location); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1546 | } |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1547 | else if (variable->getType().getQualifier() == EvqWorkGroupSize && |
| 1548 | mComputeShaderLocalSizeDeclared) |
| 1549 | { |
| 1550 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1551 | // needs to be added to the AST as a constant and not as a symbol. |
| 1552 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1553 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1554 | for (size_t i = 0; i < 3; ++i) |
| 1555 | { |
| 1556 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1557 | } |
| 1558 | |
| 1559 | ASSERT(variable->getType().getBasicType() == EbtUInt); |
| 1560 | ASSERT(variable->getType().getObjectSize() == 3); |
| 1561 | |
| 1562 | TType type(variable->getType()); |
| 1563 | type.setQualifier(EvqConst); |
| 1564 | return intermediate.addConstantUnion(constArray, type, location); |
| 1565 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1566 | else |
| 1567 | { |
| 1568 | return intermediate.addSymbol(variable->getUniqueId(), variable->getName(), |
| 1569 | variable->getType(), location); |
| 1570 | } |
| 1571 | } |
| 1572 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1573 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1574 | // Initializers show up in several places in the grammar. Have one set of |
| 1575 | // code to handle them here. |
| 1576 | // |
Jamie Madill | 3b5c2da | 2014-08-19 15:23:32 -0400 | [diff] [blame] | 1577 | // Returns true on error, false if no error |
| 1578 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1579 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1580 | const TString &identifier, |
| 1581 | const TPublicType &pType, |
| 1582 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1583 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1584 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1585 | ASSERT(initNode != nullptr); |
| 1586 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1587 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1588 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1589 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1590 | if (type.isUnsizedArray()) |
| 1591 | { |
Olli Etuaho | 02bd82c | 2016-11-03 10:29:43 +0000 | [diff] [blame] | 1592 | // We have not checked yet whether the initializer actually is an array or not. |
| 1593 | if (initializer->isArray()) |
| 1594 | { |
| 1595 | type.setArraySize(initializer->getArraySize()); |
| 1596 | } |
| 1597 | else |
| 1598 | { |
| 1599 | // Having a non-array initializer for an unsized array will result in an error later, |
| 1600 | // so we don't generate an error message here. |
| 1601 | type.setArraySize(1u); |
| 1602 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1603 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1604 | if (!declareVariable(line, identifier, type, &variable)) |
| 1605 | { |
| 1606 | return true; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1607 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1608 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1609 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1610 | if (symbolTable.atGlobalLevel() && |
| 1611 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1612 | { |
| 1613 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1614 | // we want to steer developers towards only using constant expressions. |
| 1615 | error(line, "global variable initializers must be constant expressions", "="); |
| 1616 | return true; |
| 1617 | } |
| 1618 | if (globalInitWarning) |
| 1619 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1620 | warning( |
| 1621 | line, |
| 1622 | "global variable initializers should be constant expressions " |
| 1623 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1624 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1625 | } |
| 1626 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1627 | // |
| 1628 | // identifier must be of type constant, a global, or a temporary |
| 1629 | // |
| 1630 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1631 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1632 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1633 | error(line, " cannot initialize this type of qualifier ", |
| 1634 | variable->getType().getQualifierString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1635 | return true; |
| 1636 | } |
| 1637 | // |
| 1638 | // test for and propagate constant |
| 1639 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1640 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1641 | if (qualifier == EvqConst) |
| 1642 | { |
| 1643 | if (qualifier != initializer->getType().getQualifier()) |
| 1644 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1645 | std::stringstream reasonStream; |
| 1646 | reasonStream << "assigning non-constant to '" << variable->getType().getCompleteString() |
| 1647 | << "'"; |
| 1648 | std::string reason = reasonStream.str(); |
| 1649 | error(line, reason.c_str(), "="); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1650 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1651 | return true; |
| 1652 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1653 | if (type != initializer->getType()) |
| 1654 | { |
| 1655 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1656 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1657 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1658 | return true; |
| 1659 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1660 | |
| 1661 | // Save the constant folded value to the variable if possible. For example array |
| 1662 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1663 | // in the shader is avoided. |
| 1664 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1665 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1666 | if (initializer->getAsConstantUnion()) |
| 1667 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1668 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1669 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1670 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1671 | } |
| 1672 | else if (initializer->getAsSymbolNode()) |
| 1673 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1674 | const TSymbol *symbol = |
| 1675 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1676 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1677 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1678 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1679 | if (constArray) |
| 1680 | { |
| 1681 | variable->shareConstPointer(constArray); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1682 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1683 | return false; |
| 1684 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1685 | } |
| 1686 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1687 | |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1688 | TIntermSymbol *intermSymbol = intermediate.addSymbol( |
| 1689 | variable->getUniqueId(), variable->getName(), variable->getType(), line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1690 | *initNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1691 | if (*initNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1692 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1693 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
| 1694 | return true; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1695 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1696 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1697 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1698 | } |
| 1699 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 1700 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 1701 | { |
| 1702 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 1703 | typeSpecifier->getBasicType()); |
| 1704 | |
| 1705 | if (mShaderVersion < 300 && typeSpecifier->array) |
| 1706 | { |
| 1707 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 1708 | typeSpecifier->clearArrayness(); |
| 1709 | } |
| 1710 | } |
| 1711 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1712 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1713 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1714 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1715 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1716 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1717 | TPublicType returnType = typeSpecifier; |
| 1718 | returnType.qualifier = typeQualifier.qualifier; |
| 1719 | returnType.invariant = typeQualifier.invariant; |
| 1720 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1721 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1722 | returnType.precision = typeSpecifier.precision; |
| 1723 | |
| 1724 | if (typeQualifier.precision != EbpUndefined) |
| 1725 | { |
| 1726 | returnType.precision = typeQualifier.precision; |
| 1727 | } |
| 1728 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1729 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 1730 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1731 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1732 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 1733 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1734 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1735 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1736 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1737 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1738 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1739 | if (typeSpecifier.array) |
| 1740 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1741 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1742 | returnType.clearArrayness(); |
| 1743 | } |
| 1744 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1745 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1746 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1747 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1748 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1749 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1750 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1751 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1752 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1753 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1754 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1755 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1756 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1757 | } |
| 1758 | } |
| 1759 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1760 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1761 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1762 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1763 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1764 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1765 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 1766 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1767 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1768 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 1769 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1770 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1771 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1772 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1773 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1774 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1775 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1776 | } |
| 1777 | |
| 1778 | return returnType; |
| 1779 | } |
| 1780 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1781 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 1782 | const TPublicType &type, |
| 1783 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1784 | { |
| 1785 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1786 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1787 | { |
| 1788 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1789 | } |
| 1790 | |
| 1791 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 1792 | switch (qualifier) |
| 1793 | { |
| 1794 | case EvqVertexIn: |
| 1795 | // ESSL 3.00 section 4.3.4 |
| 1796 | if (type.array) |
| 1797 | { |
| 1798 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1799 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1800 | // Vertex inputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1801 | return; |
| 1802 | case EvqFragmentOut: |
| 1803 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1804 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1805 | { |
| 1806 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1807 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1808 | // Fragment outputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1809 | return; |
| 1810 | default: |
| 1811 | break; |
| 1812 | } |
| 1813 | |
| 1814 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 1815 | // restrictions. |
| 1816 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1817 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 1818 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1819 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 1820 | { |
| 1821 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 1822 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1823 | } |
| 1824 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1825 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1826 | { |
| 1827 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 1828 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 1829 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 1830 | if (type.array) |
| 1831 | { |
| 1832 | error(qualifierLocation, "cannot be an array of structures", |
| 1833 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1834 | } |
| 1835 | if (type.isStructureContainingArrays()) |
| 1836 | { |
| 1837 | error(qualifierLocation, "cannot be a structure containing an array", |
| 1838 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1839 | } |
| 1840 | if (type.isStructureContainingType(EbtStruct)) |
| 1841 | { |
| 1842 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 1843 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1844 | } |
| 1845 | if (type.isStructureContainingType(EbtBool)) |
| 1846 | { |
| 1847 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 1848 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1849 | } |
| 1850 | } |
| 1851 | } |
| 1852 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1853 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 1854 | { |
| 1855 | if (qualifier.getType() == QtStorage) |
| 1856 | { |
| 1857 | const TStorageQualifierWrapper &storageQualifier = |
| 1858 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 1859 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 1860 | !symbolTable.atGlobalLevel()) |
| 1861 | { |
| 1862 | error(storageQualifier.getLine(), |
| 1863 | "Local variables can only use the const storage qualifier.", |
| 1864 | storageQualifier.getQualifierString().c_str()); |
| 1865 | } |
| 1866 | } |
| 1867 | } |
| 1868 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1869 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1870 | const TSourceLoc &location) |
| 1871 | { |
| 1872 | if (memoryQualifier.readonly) |
| 1873 | { |
| 1874 | error(location, "Only allowed with images.", "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1875 | } |
| 1876 | if (memoryQualifier.writeonly) |
| 1877 | { |
| 1878 | error(location, "Only allowed with images.", "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1879 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1880 | if (memoryQualifier.coherent) |
| 1881 | { |
| 1882 | error(location, "Only allowed with images.", "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1883 | } |
| 1884 | if (memoryQualifier.restrictQualifier) |
| 1885 | { |
| 1886 | error(location, "Only allowed with images.", "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1887 | } |
| 1888 | if (memoryQualifier.volatileQualifier) |
| 1889 | { |
| 1890 | error(location, "Only allowed with images.", "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1891 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1892 | } |
| 1893 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1894 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 1895 | TPublicType &publicType, |
| 1896 | const TSourceLoc &identifierOrTypeLocation, |
| 1897 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1898 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1899 | TType type(publicType); |
| 1900 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 1901 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 1902 | { |
| 1903 | TQualifier qualifier = type.getQualifier(); |
| 1904 | |
| 1905 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 1906 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 1907 | // affected variable declarations: |
| 1908 | // |
| 1909 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 1910 | // elsewhere, in TranslatorGLSL.) |
| 1911 | // |
| 1912 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 1913 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 1914 | // the way this is currently implemented we have to enable this compiler option before |
| 1915 | // parsing the shader and determining the shading language version it uses. If this were |
| 1916 | // implemented as a post-pass, the workaround could be more targeted. |
| 1917 | // |
| 1918 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 1919 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 1920 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 1921 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 1922 | { |
| 1923 | type.setInvariant(true); |
| 1924 | } |
| 1925 | } |
| 1926 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1927 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 1928 | identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1929 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1930 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1931 | mDeferredNonEmptyDeclarationErrorCheck = emptyDeclaration; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1932 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1933 | TIntermSymbol *symbol = nullptr; |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1934 | if (emptyDeclaration) |
| 1935 | { |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1936 | emptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1937 | // In most cases we don't need to create a symbol node for an empty declaration. |
| 1938 | // But if the empty declaration is declaring a struct type, the symbol node will store that. |
| 1939 | if (type.getBasicType() == EbtStruct) |
| 1940 | { |
| 1941 | symbol = intermediate.addSymbol(0, "", type, identifierOrTypeLocation); |
| 1942 | } |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1943 | } |
| 1944 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1945 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1946 | nonEmptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1947 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1948 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1949 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1950 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1951 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1952 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1953 | if (variable) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1954 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1955 | symbol = intermediate.addSymbol(variable->getUniqueId(), identifier, type, |
| 1956 | identifierOrTypeLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1957 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1958 | } |
| 1959 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1960 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1961 | declaration->setLine(identifierOrTypeLocation); |
| 1962 | if (symbol) |
| 1963 | { |
| 1964 | declaration->appendDeclarator(symbol); |
| 1965 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1966 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1967 | } |
| 1968 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1969 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 1970 | const TSourceLoc &identifierLocation, |
| 1971 | const TString &identifier, |
| 1972 | const TSourceLoc &indexLocation, |
| 1973 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1974 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1975 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1976 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1977 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 1978 | identifierLocation); |
| 1979 | |
| 1980 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1981 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1982 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1983 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1984 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1985 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1986 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1987 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1988 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1989 | // Make the type an array even if size check failed. |
| 1990 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 1991 | arrayType.setArraySize(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1992 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1993 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1994 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1995 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1996 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1997 | declaration->setLine(identifierLocation); |
| 1998 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1999 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2000 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2001 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2002 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2003 | declaration->appendDeclarator(symbol); |
| 2004 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2005 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2006 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2007 | } |
| 2008 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2009 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2010 | const TSourceLoc &identifierLocation, |
| 2011 | const TString &identifier, |
| 2012 | const TSourceLoc &initLocation, |
| 2013 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2014 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2015 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2016 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2017 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2018 | identifierLocation); |
| 2019 | |
| 2020 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2021 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2022 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2023 | declaration->setLine(identifierLocation); |
| 2024 | |
| 2025 | TIntermBinary *initNode = nullptr; |
| 2026 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2027 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2028 | if (initNode) |
| 2029 | { |
| 2030 | declaration->appendDeclarator(initNode); |
| 2031 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2032 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2033 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2034 | } |
| 2035 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2036 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2037 | TPublicType &publicType, |
| 2038 | const TSourceLoc &identifierLocation, |
| 2039 | const TString &identifier, |
| 2040 | const TSourceLoc &indexLocation, |
| 2041 | TIntermTyped *indexExpression, |
| 2042 | const TSourceLoc &initLocation, |
| 2043 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2044 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2045 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2046 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2047 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2048 | identifierLocation); |
| 2049 | |
| 2050 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2051 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2052 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2053 | |
| 2054 | TPublicType arrayType(publicType); |
| 2055 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2056 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2057 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2058 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2059 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2060 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2061 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2062 | } |
| 2063 | // Make the type an array even if size check failed. |
| 2064 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2065 | arrayType.setArraySize(size); |
| 2066 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2067 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2068 | declaration->setLine(identifierLocation); |
| 2069 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2070 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2071 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2072 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2073 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2074 | if (initNode) |
| 2075 | { |
| 2076 | declaration->appendDeclarator(initNode); |
| 2077 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2078 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2079 | |
| 2080 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2081 | } |
| 2082 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2083 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2084 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2085 | const TSourceLoc &identifierLoc, |
| 2086 | const TString *identifier, |
| 2087 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2088 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2089 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2090 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2091 | if (!typeQualifier.invariant) |
| 2092 | { |
| 2093 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 2094 | return nullptr; |
| 2095 | } |
| 2096 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2097 | { |
| 2098 | return nullptr; |
| 2099 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2100 | if (!symbol) |
| 2101 | { |
| 2102 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2103 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2104 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2105 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2106 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2107 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2108 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2109 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2110 | if (typeQualifier.precision != EbpUndefined) |
| 2111 | { |
| 2112 | error(identifierLoc, "invariant declaration specifies precision", |
| 2113 | getPrecisionString(typeQualifier.precision)); |
| 2114 | } |
| 2115 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2116 | { |
| 2117 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2118 | } |
| 2119 | |
| 2120 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
| 2121 | ASSERT(variable); |
| 2122 | const TType &type = variable->getType(); |
| 2123 | |
| 2124 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2125 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2126 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2127 | |
| 2128 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 2129 | |
| 2130 | TIntermSymbol *intermSymbol = |
| 2131 | intermediate.addSymbol(variable->getUniqueId(), *identifier, type, identifierLoc); |
| 2132 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2133 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2134 | } |
| 2135 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2136 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2137 | const TSourceLoc &identifierLocation, |
| 2138 | const TString &identifier, |
| 2139 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2140 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2141 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2142 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2143 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2144 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2145 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2146 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2147 | } |
| 2148 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2149 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2150 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2151 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2152 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2153 | TVariable *variable = nullptr; |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2154 | TType type(publicType); |
| 2155 | declareVariable(identifierLocation, identifier, type, &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2156 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2157 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierLocation); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2158 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2159 | { |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2160 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2161 | declarationOut->appendDeclarator(symbol); |
| 2162 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2163 | } |
| 2164 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2165 | void TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 2166 | const TSourceLoc &identifierLocation, |
| 2167 | const TString &identifier, |
| 2168 | const TSourceLoc &arrayLocation, |
| 2169 | TIntermTyped *indexExpression, |
| 2170 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2171 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2172 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2173 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2174 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2175 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2176 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2177 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2178 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2179 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2180 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2181 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2182 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2183 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2184 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2185 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2186 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2187 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 693c9aa | 2015-04-07 17:50:36 +0300 | [diff] [blame] | 2188 | arrayType.setArraySize(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2189 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2190 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2191 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2192 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2193 | TIntermSymbol *symbol = |
| 2194 | intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2195 | if (variable && symbol) |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2196 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2197 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2198 | declarationOut->appendDeclarator(symbol); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2199 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2200 | } |
| 2201 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2202 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2203 | const TSourceLoc &identifierLocation, |
| 2204 | const TString &identifier, |
| 2205 | const TSourceLoc &initLocation, |
| 2206 | TIntermTyped *initializer, |
| 2207 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2208 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2209 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2210 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2211 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2212 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2213 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2214 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2215 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2216 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2217 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2218 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2219 | TIntermBinary *initNode = nullptr; |
| 2220 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2221 | { |
| 2222 | // |
| 2223 | // build the intermediate representation |
| 2224 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2225 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2226 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2227 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2228 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2229 | } |
| 2230 | } |
| 2231 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2232 | void TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
| 2233 | const TSourceLoc &identifierLocation, |
| 2234 | const TString &identifier, |
| 2235 | const TSourceLoc &indexLocation, |
| 2236 | TIntermTyped *indexExpression, |
| 2237 | const TSourceLoc &initLocation, |
| 2238 | TIntermTyped *initializer, |
| 2239 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2240 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2241 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2242 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2243 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2244 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2245 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2246 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2247 | } |
| 2248 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2249 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2250 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2251 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2252 | |
| 2253 | TPublicType arrayType(publicType); |
| 2254 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2255 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2256 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2257 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2258 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2259 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2260 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2261 | } |
| 2262 | // Make the type an array even if size check failed. |
| 2263 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2264 | arrayType.setArraySize(size); |
| 2265 | |
| 2266 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2267 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2268 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2269 | { |
| 2270 | if (initNode) |
| 2271 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2272 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2273 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2274 | } |
| 2275 | } |
| 2276 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2277 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2278 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2279 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2280 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2281 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2282 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2283 | typeQualifier.line); |
| 2284 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2285 | // It should never be the case, but some strange parser errors can send us here. |
| 2286 | if (layoutQualifier.isEmpty()) |
| 2287 | { |
| 2288 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2289 | return; |
| 2290 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2291 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2292 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2293 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2294 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2295 | return; |
| 2296 | } |
| 2297 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2298 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 2299 | |
| 2300 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2301 | |
| 2302 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2303 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2304 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 2305 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2306 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2307 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2308 | if (mComputeShaderLocalSizeDeclared && |
| 2309 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 2310 | { |
| 2311 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 2312 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2313 | return; |
| 2314 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2315 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2316 | if (mShaderVersion < 310) |
| 2317 | { |
| 2318 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2319 | return; |
| 2320 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2321 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2322 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2323 | { |
| 2324 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2325 | return; |
| 2326 | } |
| 2327 | |
| 2328 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 2329 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 2330 | |
| 2331 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 2332 | maxComputeWorkGroupSize->getConstPointer(); |
| 2333 | |
| 2334 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 2335 | { |
| 2336 | if (layoutQualifier.localSize[i] != -1) |
| 2337 | { |
| 2338 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 2339 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 2340 | if (mComputeShaderLocalSize[i] < 1 || |
| 2341 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 2342 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2343 | std::stringstream reasonStream; |
| 2344 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 2345 | << maxComputeWorkGroupSizeValue; |
| 2346 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2347 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2348 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2349 | return; |
| 2350 | } |
| 2351 | } |
| 2352 | } |
| 2353 | |
| 2354 | mComputeShaderLocalSizeDeclared = true; |
| 2355 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2356 | else if (mMultiviewAvailable && |
| 2357 | (isExtensionEnabled("GL_OVR_multiview") || isExtensionEnabled("GL_OVR_multiview2")) && |
| 2358 | typeQualifier.qualifier == EvqVertexIn) |
| 2359 | { |
| 2360 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 2361 | // specification. |
| 2362 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 2363 | { |
| 2364 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 2365 | "layout"); |
| 2366 | return; |
| 2367 | } |
| 2368 | |
| 2369 | if (layoutQualifier.numViews == -1) |
| 2370 | { |
| 2371 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 2372 | return; |
| 2373 | } |
| 2374 | |
| 2375 | if (layoutQualifier.numViews > mMaxNumViews) |
| 2376 | { |
| 2377 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 2378 | "layout"); |
| 2379 | return; |
| 2380 | } |
| 2381 | |
| 2382 | mNumViews = layoutQualifier.numViews; |
| 2383 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2384 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2385 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2386 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2387 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2388 | return; |
| 2389 | } |
| 2390 | |
| 2391 | if (typeQualifier.qualifier != EvqUniform) |
| 2392 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2393 | error(typeQualifier.line, "invalid qualifier: global layout must be uniform", |
| 2394 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2395 | return; |
| 2396 | } |
| 2397 | |
| 2398 | if (mShaderVersion < 300) |
| 2399 | { |
| 2400 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 2401 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2402 | return; |
| 2403 | } |
| 2404 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2405 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2406 | |
| 2407 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 2408 | { |
| 2409 | mDefaultMatrixPacking = layoutQualifier.matrixPacking; |
| 2410 | } |
| 2411 | |
| 2412 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 2413 | { |
| 2414 | mDefaultBlockStorage = layoutQualifier.blockStorage; |
| 2415 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2416 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2417 | } |
| 2418 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2419 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 2420 | const TFunction &function, |
| 2421 | const TSourceLoc &location, |
| 2422 | bool insertParametersToSymbolTable) |
| 2423 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 2424 | TIntermFunctionPrototype *prototype = |
| 2425 | new TIntermFunctionPrototype(function.getReturnType(), TSymbolUniqueId(function)); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2426 | // TODO(oetuaho@nvidia.com): Instead of converting the function information here, the node could |
| 2427 | // point to the data that already exists in the symbol table. |
| 2428 | prototype->getFunctionSymbolInfo()->setFromFunction(function); |
| 2429 | prototype->setLine(location); |
| 2430 | |
| 2431 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 2432 | { |
| 2433 | const TConstParameter ¶m = function.getParam(i); |
| 2434 | |
| 2435 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 2436 | // be used for unused args). |
| 2437 | if (param.name != nullptr) |
| 2438 | { |
| 2439 | TVariable *variable = new TVariable(param.name, *param.type); |
| 2440 | |
| 2441 | // Insert the parameter in the symbol table. |
| 2442 | if (insertParametersToSymbolTable && !symbolTable.declare(variable)) |
| 2443 | { |
| 2444 | error(location, "redefinition", variable->getName().c_str()); |
| 2445 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2446 | continue; |
| 2447 | } |
| 2448 | TIntermSymbol *symbol = intermediate.addSymbol( |
| 2449 | variable->getUniqueId(), variable->getName(), variable->getType(), location); |
| 2450 | prototype->appendParameter(symbol); |
| 2451 | } |
| 2452 | else |
| 2453 | { |
| 2454 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2455 | } |
| 2456 | } |
| 2457 | return prototype; |
| 2458 | } |
| 2459 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 2460 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 2461 | const TFunction &parsedFunction, |
| 2462 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2463 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2464 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 2465 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 2466 | // function is declared multiple times. |
| 2467 | TFunction *function = static_cast<TFunction *>( |
| 2468 | symbolTable.find(parsedFunction.getMangledName(), getShaderVersion())); |
| 2469 | if (function->hasPrototypeDeclaration() && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2470 | { |
| 2471 | // ESSL 1.00.17 section 4.2.7. |
| 2472 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 2473 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2474 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2475 | function->setHasPrototypeDeclaration(); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2476 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2477 | TIntermFunctionPrototype *prototype = |
| 2478 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2479 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2480 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2481 | |
| 2482 | if (!symbolTable.atGlobalLevel()) |
| 2483 | { |
| 2484 | // ESSL 3.00.4 section 4.2.4. |
| 2485 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2486 | } |
| 2487 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2488 | return prototype; |
| 2489 | } |
| 2490 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2491 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2492 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2493 | TIntermBlock *functionBody, |
| 2494 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2495 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2496 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2497 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 2498 | { |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2499 | error(location, "function does not return a value:", |
| 2500 | functionPrototype->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2501 | } |
| 2502 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2503 | if (functionBody == nullptr) |
| 2504 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2505 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2506 | functionBody->setLine(location); |
| 2507 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2508 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2509 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2510 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2511 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2512 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2513 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2514 | } |
| 2515 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2516 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
| 2517 | TFunction **function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2518 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2519 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2520 | ASSERT(function); |
| 2521 | ASSERT(*function); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2522 | const TSymbol *builtIn = |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2523 | symbolTable.findBuiltIn((*function)->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2524 | |
| 2525 | if (builtIn) |
| 2526 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2527 | error(location, "built-in functions cannot be redefined", (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2528 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2529 | else |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2530 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2531 | TFunction *prevDec = static_cast<TFunction *>( |
| 2532 | symbolTable.find((*function)->getMangledName(), getShaderVersion())); |
| 2533 | |
| 2534 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function as it |
| 2535 | // would have just been put in the symbol table. Otherwise, we're looking up an earlier |
| 2536 | // occurance. |
| 2537 | if (*function != prevDec) |
| 2538 | { |
| 2539 | // Swap the parameters of the previous declaration to the parameters of the function |
| 2540 | // definition (parameter names may differ). |
| 2541 | prevDec->swapParameters(**function); |
| 2542 | |
| 2543 | // The function definition will share the same symbol as any previous declaration. |
| 2544 | *function = prevDec; |
| 2545 | } |
| 2546 | |
| 2547 | if ((*function)->isDefined()) |
| 2548 | { |
| 2549 | error(location, "function already has a body", (*function)->getName().c_str()); |
| 2550 | } |
| 2551 | |
| 2552 | (*function)->setDefined(); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2553 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2554 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2555 | // Remember the return type for later checking for return statements. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2556 | mCurrentFunctionType = &((*function)->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2557 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2558 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2559 | *prototypeOut = createPrototypeNodeFromFunction(**function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2560 | setLoopNestingLevel(0); |
| 2561 | } |
| 2562 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2563 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2564 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2565 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2566 | // We don't know at this point whether this is a function definition or a prototype. |
| 2567 | // The definition production code will check for redefinitions. |
| 2568 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2569 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2570 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 2571 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2572 | // |
| 2573 | TFunction *prevDec = |
| 2574 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2575 | |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2576 | if (getShaderVersion() >= 300 && |
| 2577 | symbolTable.hasUnmangledBuiltInForShaderVersion(function->getName().c_str(), |
| 2578 | getShaderVersion())) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2579 | { |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2580 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as functions. |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2581 | // Therefore overloading or redefining builtin functions is an error. |
| 2582 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 2583 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2584 | } |
| 2585 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2586 | { |
| 2587 | if (prevDec->getReturnType() != function->getReturnType()) |
| 2588 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2589 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2590 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2591 | } |
| 2592 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 2593 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2594 | if (prevDec->getParam(i).type->getQualifier() != |
| 2595 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2596 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2597 | error(location, |
| 2598 | "function must have the same parameter qualifiers in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2599 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2600 | } |
| 2601 | } |
| 2602 | } |
| 2603 | |
| 2604 | // |
| 2605 | // Check for previously declared variables using the same name. |
| 2606 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2607 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2608 | if (prevSym) |
| 2609 | { |
| 2610 | if (!prevSym->isFunction()) |
| 2611 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2612 | error(location, "redefinition of a function", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2613 | } |
| 2614 | } |
| 2615 | else |
| 2616 | { |
| 2617 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2618 | symbolTable.getOuterLevel()->insertUnmangled(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2619 | } |
| 2620 | |
| 2621 | // We're at the inner scope level of the function's arguments and body statement. |
| 2622 | // Add the function prototype to the surrounding scope instead. |
| 2623 | symbolTable.getOuterLevel()->insert(function); |
| 2624 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 2625 | // Raise error message if main function takes any parameters or return anything other than void |
| 2626 | if (function->getName() == "main") |
| 2627 | { |
| 2628 | if (function->getParamCount() > 0) |
| 2629 | { |
| 2630 | error(location, "function cannot take any parameter(s)", "main"); |
| 2631 | } |
| 2632 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 2633 | { |
| 2634 | error(location, "main function cannot return a value", |
| 2635 | function->getReturnType().getBasicString()); |
| 2636 | } |
| 2637 | } |
| 2638 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2639 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2640 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 2641 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2642 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 2643 | // |
| 2644 | return function; |
| 2645 | } |
| 2646 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2647 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 2648 | const TString *name, |
| 2649 | const TSourceLoc &location) |
| 2650 | { |
| 2651 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 2652 | { |
| 2653 | error(location, "no qualifiers allowed for function return", |
| 2654 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2655 | } |
| 2656 | if (!type.layoutQualifier.isEmpty()) |
| 2657 | { |
| 2658 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2659 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2660 | // make sure an opaque type is not involved as well... |
| 2661 | std::string reason(getBasicString(type.getBasicType())); |
| 2662 | reason += "s can't be function return values"; |
| 2663 | checkIsNotOpaqueType(location, type.typeSpecifierNonArray, reason.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2664 | if (mShaderVersion < 300) |
| 2665 | { |
| 2666 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 2667 | // return values in ESSL 1.00. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2668 | ASSERT(type.arraySize == 0 || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2669 | |
| 2670 | if (type.isStructureContainingArrays()) |
| 2671 | { |
| 2672 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 2673 | error(location, "structures containing arrays can't be function return values", |
| 2674 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2675 | } |
| 2676 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2677 | |
| 2678 | // Add the function as a prototype after parsing it (we do not support recursion) |
| 2679 | return new TFunction(name, new TType(type)); |
| 2680 | } |
| 2681 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 2682 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicType) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2683 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2684 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2685 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2686 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 2687 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2688 | } |
| 2689 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 2690 | TType *type = new TType(publicType); |
| 2691 | if (!type->canBeConstructed()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2692 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 2693 | error(publicType.getLine(), "cannot construct this type", |
| 2694 | getBasicString(publicType.getBasicType())); |
| 2695 | type->setBasicType(EbtFloat); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2696 | } |
| 2697 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 2698 | return new TFunction(nullptr, type, EOpConstruct); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2699 | } |
| 2700 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2701 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 2702 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2703 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2704 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2705 | // |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2706 | TIntermTyped *TParseContext::addConstructor(TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2707 | TType type, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2708 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2709 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2710 | if (type.isUnsizedArray()) |
| 2711 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2712 | if (arguments->empty()) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 2713 | { |
| 2714 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 2715 | type.setArraySize(1u); |
| 2716 | return TIntermTyped::CreateZero(type); |
| 2717 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2718 | type.setArraySize(static_cast<unsigned int>(arguments->size())); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2719 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2720 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 2721 | if (!checkConstructorArguments(line, arguments, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2722 | { |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2723 | return TIntermTyped::CreateZero(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2724 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2725 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 2726 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2727 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2728 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2729 | TIntermTyped *constConstructor = |
| 2730 | intermediate.foldAggregateBuiltIn(constructorNode, mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2731 | if (constConstructor) |
| 2732 | { |
| 2733 | return constConstructor; |
| 2734 | } |
| 2735 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2736 | return constructorNode; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2737 | } |
| 2738 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2739 | // |
| 2740 | // Interface/uniform blocks |
| 2741 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2742 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2743 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2744 | const TSourceLoc &nameLine, |
| 2745 | const TString &blockName, |
| 2746 | TFieldList *fieldList, |
| 2747 | const TString *instanceName, |
| 2748 | const TSourceLoc &instanceLine, |
| 2749 | TIntermTyped *arrayIndex, |
| 2750 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2751 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2752 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2753 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2754 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2755 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2756 | if (typeQualifier.qualifier != EvqUniform) |
| 2757 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2758 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform", |
| 2759 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2760 | } |
| 2761 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2762 | if (typeQualifier.invariant) |
| 2763 | { |
| 2764 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 2765 | } |
| 2766 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2767 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 2768 | |
| 2769 | // TODO(oetuaho): Remove this and support binding for blocks. |
| 2770 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2771 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2772 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 2773 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2774 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2775 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2776 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2777 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 2778 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2779 | blockLayoutQualifier.matrixPacking = mDefaultMatrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2780 | } |
| 2781 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2782 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 2783 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2784 | blockLayoutQualifier.blockStorage = mDefaultBlockStorage; |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2785 | } |
| 2786 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2787 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2788 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2789 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 2790 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2791 | TSymbol *blockNameSymbol = new TInterfaceBlockName(&blockName); |
| 2792 | if (!symbolTable.declare(blockNameSymbol)) |
| 2793 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2794 | error(nameLine, "redefinition of an interface block name", blockName.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2795 | } |
| 2796 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2797 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2798 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2799 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2800 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2801 | TType *fieldType = field->type(); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2802 | if (IsOpaqueType(fieldType->getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2803 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2804 | std::string reason("unsupported type - "); |
| 2805 | reason += fieldType->getBasicString(); |
| 2806 | reason += " types are not allowed in interface blocks"; |
| 2807 | error(field->line(), reason.c_str(), fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2808 | } |
| 2809 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2810 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2811 | switch (qualifier) |
| 2812 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2813 | case EvqGlobal: |
| 2814 | case EvqUniform: |
| 2815 | break; |
| 2816 | default: |
| 2817 | error(field->line(), "invalid qualifier on interface block member", |
| 2818 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2819 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2820 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2821 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2822 | if (fieldType->isInvariant()) |
| 2823 | { |
| 2824 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 2825 | } |
| 2826 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2827 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2828 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2829 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2830 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2831 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2832 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2833 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 2834 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2835 | } |
| 2836 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2837 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2838 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2839 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2840 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2841 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2842 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2843 | warning(field->line(), |
| 2844 | "extraneous layout qualifier: only has an effect on matrix types", |
| 2845 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2846 | } |
| 2847 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2848 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2849 | } |
| 2850 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2851 | // add array index |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2852 | unsigned int arraySize = 0; |
| 2853 | if (arrayIndex != nullptr) |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2854 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2855 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2856 | } |
| 2857 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2858 | TInterfaceBlock *interfaceBlock = |
| 2859 | new TInterfaceBlock(&blockName, fieldList, instanceName, arraySize, blockLayoutQualifier); |
| 2860 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier, |
| 2861 | arraySize); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2862 | |
| 2863 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2864 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2865 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2866 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2867 | { |
| 2868 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2869 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2870 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2871 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2872 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2873 | |
| 2874 | // set parent pointer of the field variable |
| 2875 | fieldType->setInterfaceBlock(interfaceBlock); |
| 2876 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2877 | TVariable *fieldVariable = new TVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2878 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 2879 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2880 | if (!symbolTable.declare(fieldVariable)) |
| 2881 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2882 | error(field->line(), "redefinition of an interface block member name", |
| 2883 | field->name().c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2884 | } |
| 2885 | } |
| 2886 | } |
| 2887 | else |
| 2888 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2889 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 2890 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2891 | // add a symbol for this interface block |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2892 | TVariable *instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2893 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2894 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2895 | if (!symbolTable.declare(instanceTypeDef)) |
| 2896 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2897 | error(instanceLine, "redefinition of an interface block instance name", |
| 2898 | instanceName->c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2899 | } |
| 2900 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2901 | symbolId = instanceTypeDef->getUniqueId(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2902 | symbolName = instanceTypeDef->getName(); |
| 2903 | } |
| 2904 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2905 | TIntermSymbol *blockSymbol = |
| 2906 | intermediate.addSymbol(symbolId, symbolName, interfaceBlockType, typeQualifier.line); |
| 2907 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2908 | declaration->appendDeclarator(blockSymbol); |
| 2909 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2910 | |
| 2911 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2912 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2913 | } |
| 2914 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2915 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2916 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2917 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2918 | |
| 2919 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2920 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2921 | if (mStructNestingLevel > 1) |
| 2922 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2923 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2924 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2925 | } |
| 2926 | |
| 2927 | void TParseContext::exitStructDeclaration() |
| 2928 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2929 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2930 | } |
| 2931 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2932 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2933 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 2934 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2935 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2936 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2937 | } |
| 2938 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2939 | if (field.type()->getBasicType() != EbtStruct) |
| 2940 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2941 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2942 | } |
| 2943 | |
| 2944 | // We're already inside a structure definition at this point, so add |
| 2945 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2946 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 2947 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2948 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2949 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 2950 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2951 | std::string reason = reasonStream.str(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2952 | error(line, reason.c_str(), field.name().c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2953 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2954 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2955 | } |
| 2956 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 2957 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2958 | // Parse an array index expression |
| 2959 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2960 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 2961 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2962 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2963 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2964 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 2965 | { |
| 2966 | if (baseExpression->getAsSymbolNode()) |
| 2967 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2968 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 2969 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2970 | } |
| 2971 | else |
| 2972 | { |
| 2973 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 2974 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2975 | |
| 2976 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 2977 | unionArray->setFConst(0.0f); |
| 2978 | return intermediate.addConstantUnion(unionArray, TType(EbtFloat, EbpHigh, EvqConst), |
| 2979 | location); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2980 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 2981 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 2982 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 2983 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2984 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 2985 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 2986 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 2987 | // index is a constant expression. |
| 2988 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 2989 | { |
| 2990 | if (baseExpression->isInterfaceBlock()) |
| 2991 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2992 | error(location, |
| 2993 | "array indexes for interface blocks arrays must be constant integral expressions", |
| 2994 | "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2995 | } |
| 2996 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 2997 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2998 | error(location, |
| 2999 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3000 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3001 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3002 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3003 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3004 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3005 | } |
| 3006 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3007 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3008 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3009 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3010 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3011 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3012 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3013 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3014 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3015 | int index = indexConstantUnion->getIConst(0); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3016 | |
| 3017 | int safeIndex = -1; |
| 3018 | |
| 3019 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3020 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3021 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3022 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3023 | if (mShaderSpec == SH_WEBGL2_SPEC) |
| 3024 | { |
| 3025 | // Error has been already generated if index is not const. |
| 3026 | if (indexExpression->getQualifier() == EvqConst) |
| 3027 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3028 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3029 | } |
| 3030 | safeIndex = 0; |
| 3031 | } |
| 3032 | else if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
| 3033 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3034 | outOfRangeError(outOfRangeIndexIsError, location, |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3035 | "array index for gl_FragData must be zero when " |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3036 | "GL_EXT_draw_buffers is disabled", |
| 3037 | "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3038 | safeIndex = 0; |
| 3039 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3040 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3041 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 3042 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3043 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3044 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3045 | baseExpression->getArraySize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3046 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3047 | } |
| 3048 | } |
| 3049 | else if (baseExpression->isMatrix()) |
| 3050 | { |
| 3051 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3052 | baseExpression->getType().getCols(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3053 | "matrix field selection out of range"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3054 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3055 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3056 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3057 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3058 | baseExpression->getType().getNominalSize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3059 | "vector field selection out of range"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3060 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3061 | |
| 3062 | ASSERT(safeIndex >= 0); |
| 3063 | // Data of constant unions can't be changed, because it may be shared with other |
| 3064 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 3065 | // sanitized object. |
| 3066 | if (safeIndex != index) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3067 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3068 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 3069 | safeConstantUnion->setIConst(safeIndex); |
| 3070 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3071 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3072 | |
| 3073 | return intermediate.addIndex(EOpIndexDirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3074 | mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3075 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3076 | else |
| 3077 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3078 | return intermediate.addIndex(EOpIndexIndirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3079 | mDiagnostics); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3080 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3081 | } |
| 3082 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3083 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 3084 | const TSourceLoc &location, |
| 3085 | int index, |
| 3086 | int arraySize, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3087 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3088 | { |
| 3089 | if (index >= arraySize || index < 0) |
| 3090 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3091 | std::stringstream reasonStream; |
| 3092 | reasonStream << reason << " '" << index << "'"; |
| 3093 | std::string token = reasonStream.str(); |
| 3094 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3095 | if (index < 0) |
| 3096 | { |
| 3097 | return 0; |
| 3098 | } |
| 3099 | else |
| 3100 | { |
| 3101 | return arraySize - 1; |
| 3102 | } |
| 3103 | } |
| 3104 | return index; |
| 3105 | } |
| 3106 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3107 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 3108 | const TSourceLoc &dotLocation, |
| 3109 | const TString &fieldString, |
| 3110 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3111 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3112 | if (baseExpression->isArray()) |
| 3113 | { |
| 3114 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3115 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3116 | } |
| 3117 | |
| 3118 | if (baseExpression->isVector()) |
| 3119 | { |
| 3120 | TVectorFields fields; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3121 | if (!parseVectorFields(fieldString, baseExpression->getNominalSize(), fields, |
| 3122 | fieldLocation)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3123 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3124 | fields.num = 1; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3125 | fields.offsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3126 | } |
| 3127 | |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 3128 | return TIntermediate::AddSwizzle(baseExpression, fields, dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3129 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3130 | else if (baseExpression->getBasicType() == EbtStruct) |
| 3131 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3132 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3133 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3134 | { |
| 3135 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3136 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3137 | } |
| 3138 | else |
| 3139 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3140 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3141 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3142 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3143 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3144 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3145 | { |
| 3146 | fieldFound = true; |
| 3147 | break; |
| 3148 | } |
| 3149 | } |
| 3150 | if (fieldFound) |
| 3151 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3152 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3153 | index->setLine(fieldLocation); |
| 3154 | return intermediate.addIndex(EOpIndexDirectStruct, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3155 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3156 | } |
| 3157 | else |
| 3158 | { |
| 3159 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3160 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3161 | } |
| 3162 | } |
| 3163 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3164 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3165 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3166 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3167 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3168 | { |
| 3169 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3170 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3171 | } |
| 3172 | else |
| 3173 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3174 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3175 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3176 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3177 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3178 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3179 | { |
| 3180 | fieldFound = true; |
| 3181 | break; |
| 3182 | } |
| 3183 | } |
| 3184 | if (fieldFound) |
| 3185 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3186 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3187 | index->setLine(fieldLocation); |
| 3188 | return intermediate.addIndex(EOpIndexDirectInterfaceBlock, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3189 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3190 | } |
| 3191 | else |
| 3192 | { |
| 3193 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3194 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3195 | } |
| 3196 | } |
| 3197 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3198 | else |
| 3199 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3200 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3201 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3202 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3203 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3204 | } |
| 3205 | else |
| 3206 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3207 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3208 | " field selection requires structure, vector, or interface block on left hand " |
| 3209 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3210 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3211 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3212 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3213 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3214 | } |
| 3215 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3216 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3217 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3218 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3219 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3220 | |
| 3221 | if (qualifierType == "shared") |
| 3222 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3223 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3224 | { |
| 3225 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 3226 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3227 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3228 | } |
| 3229 | else if (qualifierType == "packed") |
| 3230 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3231 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3232 | { |
| 3233 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 3234 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3235 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3236 | } |
| 3237 | else if (qualifierType == "std140") |
| 3238 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3239 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3240 | } |
| 3241 | else if (qualifierType == "row_major") |
| 3242 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3243 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3244 | } |
| 3245 | else if (qualifierType == "column_major") |
| 3246 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3247 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3248 | } |
| 3249 | else if (qualifierType == "location") |
| 3250 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3251 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
| 3252 | qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3253 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3254 | else if (qualifierType == "yuv" && isExtensionEnabled("GL_EXT_YUV_target") && |
| 3255 | mShaderType == GL_FRAGMENT_SHADER) |
| 3256 | { |
| 3257 | qualifier.yuv = true; |
| 3258 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3259 | else if (qualifierType == "rgba32f") |
| 3260 | { |
| 3261 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3262 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 3263 | } |
| 3264 | else if (qualifierType == "rgba16f") |
| 3265 | { |
| 3266 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3267 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 3268 | } |
| 3269 | else if (qualifierType == "r32f") |
| 3270 | { |
| 3271 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3272 | qualifier.imageInternalFormat = EiifR32F; |
| 3273 | } |
| 3274 | else if (qualifierType == "rgba8") |
| 3275 | { |
| 3276 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3277 | qualifier.imageInternalFormat = EiifRGBA8; |
| 3278 | } |
| 3279 | else if (qualifierType == "rgba8_snorm") |
| 3280 | { |
| 3281 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3282 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 3283 | } |
| 3284 | else if (qualifierType == "rgba32i") |
| 3285 | { |
| 3286 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3287 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 3288 | } |
| 3289 | else if (qualifierType == "rgba16i") |
| 3290 | { |
| 3291 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3292 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 3293 | } |
| 3294 | else if (qualifierType == "rgba8i") |
| 3295 | { |
| 3296 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3297 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 3298 | } |
| 3299 | else if (qualifierType == "r32i") |
| 3300 | { |
| 3301 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3302 | qualifier.imageInternalFormat = EiifR32I; |
| 3303 | } |
| 3304 | else if (qualifierType == "rgba32ui") |
| 3305 | { |
| 3306 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3307 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 3308 | } |
| 3309 | else if (qualifierType == "rgba16ui") |
| 3310 | { |
| 3311 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3312 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 3313 | } |
| 3314 | else if (qualifierType == "rgba8ui") |
| 3315 | { |
| 3316 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3317 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 3318 | } |
| 3319 | else if (qualifierType == "r32ui") |
| 3320 | { |
| 3321 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3322 | qualifier.imageInternalFormat = EiifR32UI; |
| 3323 | } |
| 3324 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3325 | else |
| 3326 | { |
| 3327 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3328 | } |
| 3329 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3330 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3331 | } |
| 3332 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3333 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 3334 | const TSourceLoc &qualifierTypeLine, |
| 3335 | int intValue, |
| 3336 | const TSourceLoc &intValueLine, |
| 3337 | const std::string &intValueString, |
| 3338 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3339 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3340 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3341 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3342 | if (intValue < 1) |
| 3343 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3344 | std::stringstream reasonStream; |
| 3345 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 3346 | std::string reason = reasonStream.str(); |
| 3347 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3348 | } |
| 3349 | (*localSize)[index] = intValue; |
| 3350 | } |
| 3351 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3352 | void TParseContext::parseNumViews(int intValue, |
| 3353 | const TSourceLoc &intValueLine, |
| 3354 | const std::string &intValueString, |
| 3355 | int *numViews) |
| 3356 | { |
| 3357 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 3358 | // specification. |
| 3359 | if (intValue < 1) |
| 3360 | { |
| 3361 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 3362 | } |
| 3363 | *numViews = intValue; |
| 3364 | } |
| 3365 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3366 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3367 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3368 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3369 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3370 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3371 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3372 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3373 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3374 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3375 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3376 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 3377 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3378 | if (intValue < 0) |
| 3379 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3380 | error(intValueLine, "out of range: location must be non-negative", |
| 3381 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3382 | } |
| 3383 | else |
| 3384 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3385 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 3386 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3387 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3388 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3389 | else if (qualifierType == "binding") |
| 3390 | { |
| 3391 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3392 | if (intValue < 0) |
| 3393 | { |
| 3394 | error(intValueLine, "out of range: binding must be non-negative", |
| 3395 | intValueString.c_str()); |
| 3396 | } |
| 3397 | else |
| 3398 | { |
| 3399 | qualifier.binding = intValue; |
| 3400 | } |
| 3401 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3402 | else if (qualifierType == "local_size_x") |
| 3403 | { |
| 3404 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 3405 | &qualifier.localSize); |
| 3406 | } |
| 3407 | else if (qualifierType == "local_size_y") |
| 3408 | { |
| 3409 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 3410 | &qualifier.localSize); |
| 3411 | } |
| 3412 | else if (qualifierType == "local_size_z") |
| 3413 | { |
| 3414 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 3415 | &qualifier.localSize); |
| 3416 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3417 | else if (qualifierType == "num_views" && mMultiviewAvailable && |
| 3418 | (isExtensionEnabled("GL_OVR_multiview") || isExtensionEnabled("GL_OVR_multiview2")) && |
| 3419 | mShaderType == GL_VERTEX_SHADER) |
| 3420 | { |
| 3421 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 3422 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3423 | else |
| 3424 | { |
| 3425 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3426 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3427 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3428 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3429 | } |
| 3430 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 3431 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 3432 | { |
| 3433 | return new TTypeQualifierBuilder( |
| 3434 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 3435 | mShaderVersion); |
| 3436 | } |
| 3437 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3438 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3439 | TLayoutQualifier rightQualifier, |
| 3440 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3441 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3442 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3443 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3444 | } |
| 3445 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3446 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 3447 | const TFieldList *newlyAddedFields, |
| 3448 | const TSourceLoc &location) |
| 3449 | { |
| 3450 | for (TField *field : *newlyAddedFields) |
| 3451 | { |
| 3452 | for (TField *oldField : *processedFields) |
| 3453 | { |
| 3454 | if (oldField->name() == field->name()) |
| 3455 | { |
| 3456 | error(location, "duplicate field name in structure", field->name().c_str()); |
| 3457 | } |
| 3458 | } |
| 3459 | processedFields->push_back(field); |
| 3460 | } |
| 3461 | return processedFields; |
| 3462 | } |
| 3463 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3464 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 3465 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3466 | TPublicType *typeSpecifier, |
| 3467 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3468 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3469 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3470 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3471 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 3472 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3473 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3474 | typeSpecifier->invariant = typeQualifier.invariant; |
| 3475 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3476 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3477 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3478 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3479 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3480 | } |
| 3481 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3482 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
| 3483 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3484 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3485 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 3486 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3487 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3488 | checkIsNonVoid(typeSpecifier.getLine(), (*fieldList)[0]->name(), typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3489 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3490 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3491 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3492 | for (unsigned int i = 0; i < fieldList->size(); ++i) |
| 3493 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3494 | // |
| 3495 | // Careful not to replace already known aspects of type, like array-ness |
| 3496 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3497 | TType *type = (*fieldList)[i]->type(); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3498 | type->setBasicType(typeSpecifier.getBasicType()); |
| 3499 | type->setPrimarySize(typeSpecifier.getPrimarySize()); |
| 3500 | type->setSecondarySize(typeSpecifier.getSecondarySize()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3501 | type->setPrecision(typeSpecifier.precision); |
| 3502 | type->setQualifier(typeSpecifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3503 | type->setLayoutQualifier(typeSpecifier.layoutQualifier); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3504 | type->setMemoryQualifier(typeSpecifier.memoryQualifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3505 | type->setInvariant(typeSpecifier.invariant); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3506 | |
| 3507 | // don't allow arrays of arrays |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3508 | if (type->isArray()) |
| 3509 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3510 | checkIsValidTypeForArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3511 | } |
| 3512 | if (typeSpecifier.array) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3513 | type->setArraySize(static_cast<unsigned int>(typeSpecifier.arraySize)); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3514 | if (typeSpecifier.getUserDef()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3515 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3516 | type->setStruct(typeSpecifier.getUserDef()->getStruct()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3517 | } |
| 3518 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3519 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*fieldList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3520 | } |
| 3521 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3522 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3523 | } |
| 3524 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3525 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 3526 | const TSourceLoc &nameLine, |
| 3527 | const TString *structName, |
| 3528 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3529 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3530 | TStructure *structure = new TStructure(structName, fieldList); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3531 | TType *structureType = new TType(structure); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3532 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3533 | // Store a bool in the struct if we're at global scope, to allow us to |
| 3534 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3535 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 3536 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3537 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3538 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3539 | checkIsNotReserved(nameLine, *structName); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3540 | TVariable *userTypeDef = new TVariable(structName, *structureType, true); |
| 3541 | if (!symbolTable.declare(userTypeDef)) |
| 3542 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3543 | error(nameLine, "redefinition of a struct", structName->c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3544 | } |
| 3545 | } |
| 3546 | |
| 3547 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3548 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3549 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3550 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3551 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3552 | switch (qualifier) |
| 3553 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3554 | case EvqGlobal: |
| 3555 | case EvqTemporary: |
| 3556 | break; |
| 3557 | default: |
| 3558 | error(field.line(), "invalid qualifier on struct member", |
| 3559 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3560 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3561 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3562 | if (field.type()->isInvariant()) |
| 3563 | { |
| 3564 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 3565 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3566 | if (IsImage(field.type()->getBasicType())) |
| 3567 | { |
| 3568 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 3569 | } |
| 3570 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3571 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 3572 | |
| 3573 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3574 | |
| 3575 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3576 | } |
| 3577 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3578 | TTypeSpecifierNonArray typeSpecifierNonArray; |
| 3579 | typeSpecifierNonArray.initialize(EbtStruct, structLine); |
| 3580 | typeSpecifierNonArray.userDef = structureType; |
| 3581 | typeSpecifierNonArray.isStructSpecifier = true; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3582 | exitStructDeclaration(); |
| 3583 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3584 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3585 | } |
| 3586 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3587 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3588 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3589 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3590 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3591 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3592 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3593 | init->isVector()) |
| 3594 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3595 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 3596 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3597 | return nullptr; |
| 3598 | } |
| 3599 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3600 | if (statementList) |
| 3601 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3602 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3603 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3604 | return nullptr; |
| 3605 | } |
| 3606 | } |
| 3607 | |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3608 | TIntermSwitch *node = intermediate.addSwitch(init, statementList, loc); |
| 3609 | if (node == nullptr) |
| 3610 | { |
| 3611 | error(loc, "erroneous switch statement", "switch"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3612 | return nullptr; |
| 3613 | } |
| 3614 | return node; |
| 3615 | } |
| 3616 | |
| 3617 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 3618 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3619 | if (mSwitchNestingLevel == 0) |
| 3620 | { |
| 3621 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3622 | return nullptr; |
| 3623 | } |
| 3624 | if (condition == nullptr) |
| 3625 | { |
| 3626 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3627 | return nullptr; |
| 3628 | } |
| 3629 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3630 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3631 | { |
| 3632 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3633 | } |
| 3634 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3635 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 3636 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 3637 | // fold in case labels. |
| 3638 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3639 | { |
| 3640 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3641 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3642 | TIntermCase *node = intermediate.addCase(condition, loc); |
| 3643 | if (node == nullptr) |
| 3644 | { |
| 3645 | error(loc, "erroneous case statement", "case"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3646 | return nullptr; |
| 3647 | } |
| 3648 | return node; |
| 3649 | } |
| 3650 | |
| 3651 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 3652 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3653 | if (mSwitchNestingLevel == 0) |
| 3654 | { |
| 3655 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3656 | return nullptr; |
| 3657 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3658 | TIntermCase *node = intermediate.addCase(nullptr, loc); |
| 3659 | if (node == nullptr) |
| 3660 | { |
| 3661 | error(loc, "erroneous default statement", "default"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3662 | return nullptr; |
| 3663 | } |
| 3664 | return node; |
| 3665 | } |
| 3666 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3667 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 3668 | TIntermTyped *child, |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3669 | const TSourceLoc &loc) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3670 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3671 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3672 | |
| 3673 | switch (op) |
| 3674 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3675 | case EOpLogicalNot: |
| 3676 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 3677 | child->isVector()) |
| 3678 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3679 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3680 | return nullptr; |
| 3681 | } |
| 3682 | break; |
| 3683 | case EOpBitwiseNot: |
| 3684 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 3685 | child->isMatrix() || child->isArray()) |
| 3686 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3687 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3688 | return nullptr; |
| 3689 | } |
| 3690 | break; |
| 3691 | case EOpPostIncrement: |
| 3692 | case EOpPreIncrement: |
| 3693 | case EOpPostDecrement: |
| 3694 | case EOpPreDecrement: |
| 3695 | case EOpNegative: |
| 3696 | case EOpPositive: |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 3697 | if (child->getBasicType() == EbtStruct || child->isInterfaceBlock() || |
| 3698 | child->getBasicType() == EbtBool || child->isArray() || |
| 3699 | IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3700 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3701 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3702 | return nullptr; |
| 3703 | } |
| 3704 | // Operators for built-ins are already type checked against their prototype. |
| 3705 | default: |
| 3706 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3707 | } |
| 3708 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3709 | TIntermUnary *node = new TIntermUnary(op, child); |
| 3710 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3711 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3712 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3713 | if (foldedNode) |
| 3714 | return foldedNode; |
| 3715 | |
| 3716 | return node; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3717 | } |
| 3718 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3719 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 3720 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3721 | TIntermTyped *node = createUnaryMath(op, child, loc); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3722 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3723 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3724 | return child; |
| 3725 | } |
| 3726 | return node; |
| 3727 | } |
| 3728 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3729 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 3730 | TIntermTyped *child, |
| 3731 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3732 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3733 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3734 | return addUnaryMath(op, child, loc); |
| 3735 | } |
| 3736 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3737 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 3738 | TIntermTyped *left, |
| 3739 | TIntermTyped *right, |
| 3740 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3741 | { |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 3742 | // Check opaque types are not allowed to be operands in expressions other than array indexing |
| 3743 | // and structure member selection. |
| 3744 | if (IsOpaqueType(left->getBasicType()) || IsOpaqueType(right->getBasicType())) |
| 3745 | { |
| 3746 | switch (op) |
| 3747 | { |
| 3748 | case EOpIndexDirect: |
| 3749 | case EOpIndexIndirect: |
| 3750 | break; |
| 3751 | case EOpIndexDirectStruct: |
| 3752 | UNREACHABLE(); |
| 3753 | |
| 3754 | default: |
| 3755 | error(loc, "Invalid operation for variables with an opaque type", |
| 3756 | GetOperatorString(op)); |
| 3757 | return false; |
| 3758 | } |
| 3759 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3760 | |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3761 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 3762 | { |
| 3763 | switch (op) |
| 3764 | { |
| 3765 | case EOpIndexDirectStruct: |
| 3766 | ASSERT(left->getType().getStruct()); |
| 3767 | break; |
| 3768 | case EOpEqual: |
| 3769 | case EOpNotEqual: |
| 3770 | case EOpAssign: |
| 3771 | case EOpInitialize: |
| 3772 | if (left->getType() != right->getType()) |
| 3773 | { |
| 3774 | return false; |
| 3775 | } |
| 3776 | break; |
| 3777 | default: |
| 3778 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 3779 | return false; |
| 3780 | } |
| 3781 | } |
| 3782 | |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 3783 | if (left->isInterfaceBlock() || right->isInterfaceBlock()) |
| 3784 | { |
| 3785 | switch (op) |
| 3786 | { |
| 3787 | case EOpIndexDirectInterfaceBlock: |
| 3788 | ASSERT(left->getType().getInterfaceBlock()); |
| 3789 | break; |
| 3790 | default: |
| 3791 | error(loc, "Invalid operation for interface blocks", GetOperatorString(op)); |
| 3792 | return false; |
| 3793 | } |
| 3794 | } |
| 3795 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3796 | if (left->isArray() || right->isArray()) |
| 3797 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3798 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3799 | { |
| 3800 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3801 | return false; |
| 3802 | } |
| 3803 | |
| 3804 | if (left->isArray() != right->isArray()) |
| 3805 | { |
| 3806 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 3807 | return false; |
| 3808 | } |
| 3809 | |
| 3810 | switch (op) |
| 3811 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3812 | case EOpEqual: |
| 3813 | case EOpNotEqual: |
| 3814 | case EOpAssign: |
| 3815 | case EOpInitialize: |
| 3816 | break; |
| 3817 | default: |
| 3818 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3819 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3820 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 3821 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3822 | if (left->getArraySize() != right->getArraySize()) |
| 3823 | { |
| 3824 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 3825 | return false; |
| 3826 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3827 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3828 | |
| 3829 | // Check ops which require integer / ivec parameters |
| 3830 | bool isBitShift = false; |
| 3831 | switch (op) |
| 3832 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3833 | case EOpBitShiftLeft: |
| 3834 | case EOpBitShiftRight: |
| 3835 | case EOpBitShiftLeftAssign: |
| 3836 | case EOpBitShiftRightAssign: |
| 3837 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 3838 | // check that the basic type is an integer type. |
| 3839 | isBitShift = true; |
| 3840 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 3841 | { |
| 3842 | return false; |
| 3843 | } |
| 3844 | break; |
| 3845 | case EOpBitwiseAnd: |
| 3846 | case EOpBitwiseXor: |
| 3847 | case EOpBitwiseOr: |
| 3848 | case EOpBitwiseAndAssign: |
| 3849 | case EOpBitwiseXorAssign: |
| 3850 | case EOpBitwiseOrAssign: |
| 3851 | // It is enough to check the type of only one operand, since later it |
| 3852 | // is checked that the operand types match. |
| 3853 | if (!IsInteger(left->getBasicType())) |
| 3854 | { |
| 3855 | return false; |
| 3856 | } |
| 3857 | break; |
| 3858 | default: |
| 3859 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3860 | } |
| 3861 | |
| 3862 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 3863 | // So the basic type should usually match. |
| 3864 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 3865 | { |
| 3866 | return false; |
| 3867 | } |
| 3868 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3869 | // Check that: |
| 3870 | // 1. Type sizes match exactly on ops that require that. |
| 3871 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 3872 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3873 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3874 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3875 | case EOpAssign: |
| 3876 | case EOpInitialize: |
| 3877 | case EOpEqual: |
| 3878 | case EOpNotEqual: |
| 3879 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 3880 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 3881 | { |
| 3882 | error(loc, "undefined operation for structs containing arrays", |
| 3883 | GetOperatorString(op)); |
| 3884 | return false; |
| 3885 | } |
| 3886 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 3887 | // we interpret the spec so that this extends to structs containing samplers, |
| 3888 | // similarly to ESSL 1.00 spec. |
| 3889 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 3890 | left->getType().isStructureContainingSamplers()) |
| 3891 | { |
| 3892 | error(loc, "undefined operation for structs containing samplers", |
| 3893 | GetOperatorString(op)); |
| 3894 | return false; |
| 3895 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3896 | |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3897 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 3898 | (left->getSecondarySize() != right->getSecondarySize())) |
| 3899 | { |
| 3900 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 3901 | return false; |
| 3902 | } |
| 3903 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3904 | case EOpLessThan: |
| 3905 | case EOpGreaterThan: |
| 3906 | case EOpLessThanEqual: |
| 3907 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3908 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3909 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3910 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3911 | return false; |
| 3912 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3913 | break; |
| 3914 | case EOpAdd: |
| 3915 | case EOpSub: |
| 3916 | case EOpDiv: |
| 3917 | case EOpIMod: |
| 3918 | case EOpBitShiftLeft: |
| 3919 | case EOpBitShiftRight: |
| 3920 | case EOpBitwiseAnd: |
| 3921 | case EOpBitwiseXor: |
| 3922 | case EOpBitwiseOr: |
| 3923 | case EOpAddAssign: |
| 3924 | case EOpSubAssign: |
| 3925 | case EOpDivAssign: |
| 3926 | case EOpIModAssign: |
| 3927 | case EOpBitShiftLeftAssign: |
| 3928 | case EOpBitShiftRightAssign: |
| 3929 | case EOpBitwiseAndAssign: |
| 3930 | case EOpBitwiseXorAssign: |
| 3931 | case EOpBitwiseOrAssign: |
| 3932 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 3933 | { |
| 3934 | return false; |
| 3935 | } |
| 3936 | |
| 3937 | // Are the sizes compatible? |
| 3938 | if (left->getNominalSize() != right->getNominalSize() || |
| 3939 | left->getSecondarySize() != right->getSecondarySize()) |
| 3940 | { |
| 3941 | // If the nominal sizes of operands do not match: |
| 3942 | // One of them must be a scalar. |
| 3943 | if (!left->isScalar() && !right->isScalar()) |
| 3944 | return false; |
| 3945 | |
| 3946 | // In the case of compound assignment other than multiply-assign, |
| 3947 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 3948 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 3949 | // vector either. |
| 3950 | if (!right->isScalar() && |
| 3951 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 3952 | return false; |
| 3953 | } |
| 3954 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3955 | default: |
| 3956 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3957 | } |
| 3958 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3959 | return true; |
| 3960 | } |
| 3961 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3962 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 3963 | const TType &left, |
| 3964 | const TType &right) |
| 3965 | { |
| 3966 | switch (op) |
| 3967 | { |
| 3968 | case EOpMul: |
| 3969 | case EOpMulAssign: |
| 3970 | return left.getNominalSize() == right.getNominalSize() && |
| 3971 | left.getSecondarySize() == right.getSecondarySize(); |
| 3972 | case EOpVectorTimesScalar: |
| 3973 | return true; |
| 3974 | case EOpVectorTimesScalarAssign: |
| 3975 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 3976 | return left.isVector() && !right.isVector(); |
| 3977 | case EOpVectorTimesMatrix: |
| 3978 | return left.getNominalSize() == right.getRows(); |
| 3979 | case EOpVectorTimesMatrixAssign: |
| 3980 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 3981 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 3982 | left.getNominalSize() == right.getCols(); |
| 3983 | case EOpMatrixTimesVector: |
| 3984 | return left.getCols() == right.getNominalSize(); |
| 3985 | case EOpMatrixTimesScalar: |
| 3986 | return true; |
| 3987 | case EOpMatrixTimesScalarAssign: |
| 3988 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 3989 | return !right.isVector(); |
| 3990 | case EOpMatrixTimesMatrix: |
| 3991 | return left.getCols() == right.getRows(); |
| 3992 | case EOpMatrixTimesMatrixAssign: |
| 3993 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 3994 | // We need to check two things: |
| 3995 | // 1. The matrix multiplication step is valid. |
| 3996 | // 2. The result will have the same number of columns as the lvalue. |
| 3997 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 3998 | |
| 3999 | default: |
| 4000 | UNREACHABLE(); |
| 4001 | return false; |
| 4002 | } |
| 4003 | } |
| 4004 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4005 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 4006 | TIntermTyped *left, |
| 4007 | TIntermTyped *right, |
| 4008 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4009 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4010 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4011 | return nullptr; |
| 4012 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4013 | switch (op) |
| 4014 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4015 | case EOpEqual: |
| 4016 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4017 | case EOpLessThan: |
| 4018 | case EOpGreaterThan: |
| 4019 | case EOpLessThanEqual: |
| 4020 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4021 | break; |
| 4022 | case EOpLogicalOr: |
| 4023 | case EOpLogicalXor: |
| 4024 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4025 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4026 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4027 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4028 | { |
| 4029 | return nullptr; |
| 4030 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4031 | // Basic types matching should have been already checked. |
| 4032 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4033 | break; |
| 4034 | case EOpAdd: |
| 4035 | case EOpSub: |
| 4036 | case EOpDiv: |
| 4037 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4038 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4039 | !right->getType().getStruct()); |
| 4040 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4041 | { |
| 4042 | return nullptr; |
| 4043 | } |
| 4044 | break; |
| 4045 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4046 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4047 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4048 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4049 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4050 | { |
| 4051 | return nullptr; |
| 4052 | } |
| 4053 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4054 | default: |
| 4055 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4056 | } |
| 4057 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4058 | if (op == EOpMul) |
| 4059 | { |
| 4060 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 4061 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4062 | { |
| 4063 | return nullptr; |
| 4064 | } |
| 4065 | } |
| 4066 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4067 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4068 | node->setLine(loc); |
| 4069 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4070 | // See if we can fold constants. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4071 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4072 | if (foldedNode) |
| 4073 | return foldedNode; |
| 4074 | |
| 4075 | return node; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4076 | } |
| 4077 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4078 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 4079 | TIntermTyped *left, |
| 4080 | TIntermTyped *right, |
| 4081 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4082 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4083 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4084 | if (node == 0) |
| 4085 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4086 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4087 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4088 | return left; |
| 4089 | } |
| 4090 | return node; |
| 4091 | } |
| 4092 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4093 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 4094 | TIntermTyped *left, |
| 4095 | TIntermTyped *right, |
| 4096 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4097 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4098 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4099 | if (node == 0) |
| 4100 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4101 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4102 | right->getCompleteString()); |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 4103 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4104 | unionArray->setBConst(false); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4105 | return intermediate.addConstantUnion(unionArray, TType(EbtBool, EbpUndefined, EvqConst), |
| 4106 | loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4107 | } |
| 4108 | return node; |
| 4109 | } |
| 4110 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 4111 | TIntermBinary *TParseContext::createAssign(TOperator op, |
| 4112 | TIntermTyped *left, |
| 4113 | TIntermTyped *right, |
| 4114 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4115 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4116 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4117 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4118 | if (op == EOpMulAssign) |
| 4119 | { |
| 4120 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 4121 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4122 | { |
| 4123 | return nullptr; |
| 4124 | } |
| 4125 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4126 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4127 | node->setLine(loc); |
| 4128 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4129 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4130 | } |
| 4131 | return nullptr; |
| 4132 | } |
| 4133 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4134 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 4135 | TIntermTyped *left, |
| 4136 | TIntermTyped *right, |
| 4137 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4138 | { |
| 4139 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 4140 | if (node == nullptr) |
| 4141 | { |
| 4142 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4143 | return left; |
| 4144 | } |
| 4145 | return node; |
| 4146 | } |
| 4147 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4148 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 4149 | TIntermTyped *right, |
| 4150 | const TSourceLoc &loc) |
| 4151 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4152 | // WebGL2 section 5.26, the following results in an error: |
| 4153 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4154 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 4155 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 4156 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 4157 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4158 | { |
| 4159 | error(loc, |
| 4160 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 4161 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4162 | } |
| 4163 | |
Olli Etuaho | 4db7ded | 2016-10-13 12:23:11 +0100 | [diff] [blame] | 4164 | return TIntermediate::AddComma(left, right, loc, mShaderVersion); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4165 | } |
| 4166 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4167 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 4168 | { |
| 4169 | switch (op) |
| 4170 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4171 | case EOpContinue: |
| 4172 | if (mLoopNestingLevel <= 0) |
| 4173 | { |
| 4174 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4175 | } |
| 4176 | break; |
| 4177 | case EOpBreak: |
| 4178 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 4179 | { |
| 4180 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4181 | } |
| 4182 | break; |
| 4183 | case EOpReturn: |
| 4184 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 4185 | { |
| 4186 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4187 | } |
| 4188 | break; |
| 4189 | default: |
| 4190 | // No checks for discard |
| 4191 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4192 | } |
| 4193 | return intermediate.addBranch(op, loc); |
| 4194 | } |
| 4195 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4196 | TIntermBranch *TParseContext::addBranch(TOperator op, |
| 4197 | TIntermTyped *returnValue, |
| 4198 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4199 | { |
| 4200 | ASSERT(op == EOpReturn); |
| 4201 | mFunctionReturnsValue = true; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4202 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4203 | { |
| 4204 | error(loc, "void function cannot return a value", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4205 | } |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4206 | else if (*mCurrentFunctionType != returnValue->getType()) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4207 | { |
| 4208 | error(loc, "function return is not matching type:", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4209 | } |
| 4210 | return intermediate.addBranch(op, returnValue, loc); |
| 4211 | } |
| 4212 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4213 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 4214 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4215 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4216 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4217 | TIntermNode *offset = nullptr; |
| 4218 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4219 | if (name == "texelFetchOffset" || name == "textureLodOffset" || |
| 4220 | name == "textureProjLodOffset" || name == "textureGradOffset" || |
| 4221 | name == "textureProjGradOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4222 | { |
| 4223 | offset = arguments->back(); |
| 4224 | } |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4225 | else if (name == "textureOffset" || name == "textureProjOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4226 | { |
| 4227 | // A bias parameter might follow the offset parameter. |
| 4228 | ASSERT(arguments->size() >= 3); |
| 4229 | offset = (*arguments)[2]; |
| 4230 | } |
| 4231 | if (offset != nullptr) |
| 4232 | { |
| 4233 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 4234 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 4235 | { |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4236 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4237 | name.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4238 | } |
| 4239 | else |
| 4240 | { |
| 4241 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 4242 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 4243 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 4244 | for (size_t i = 0u; i < size; ++i) |
| 4245 | { |
| 4246 | int offsetValue = values[i].getIConst(); |
| 4247 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 4248 | { |
| 4249 | std::stringstream tokenStream; |
| 4250 | tokenStream << offsetValue; |
| 4251 | std::string token = tokenStream.str(); |
| 4252 | error(offset->getLine(), "Texture offset value out of valid range", |
| 4253 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4254 | } |
| 4255 | } |
| 4256 | } |
| 4257 | } |
| 4258 | } |
| 4259 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4260 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 4261 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 4262 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4263 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4264 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
| 4265 | |
| 4266 | if (name.compare(0, 5, "image") == 0) |
| 4267 | { |
| 4268 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4269 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4270 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4271 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4272 | |
| 4273 | if (name.compare(5, 5, "Store") == 0) |
| 4274 | { |
| 4275 | if (memoryQualifier.readonly) |
| 4276 | { |
| 4277 | error(imageNode->getLine(), |
| 4278 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4279 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4280 | } |
| 4281 | } |
| 4282 | else if (name.compare(5, 4, "Load") == 0) |
| 4283 | { |
| 4284 | if (memoryQualifier.writeonly) |
| 4285 | { |
| 4286 | error(imageNode->getLine(), |
| 4287 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4288 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4289 | } |
| 4290 | } |
| 4291 | } |
| 4292 | } |
| 4293 | |
| 4294 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 4295 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 4296 | const TFunction *functionDefinition, |
| 4297 | const TIntermAggregate *functionCall) |
| 4298 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4299 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4300 | |
| 4301 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 4302 | |
| 4303 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 4304 | |
| 4305 | for (size_t i = 0; i < arguments.size(); ++i) |
| 4306 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4307 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 4308 | const TType &functionArgumentType = typedArgument->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4309 | const TType &functionParameterType = *functionDefinition->getParam(i).type; |
| 4310 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 4311 | |
| 4312 | if (IsImage(functionArgumentType.getBasicType())) |
| 4313 | { |
| 4314 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 4315 | functionArgumentType.getMemoryQualifier(); |
| 4316 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 4317 | functionParameterType.getMemoryQualifier(); |
| 4318 | if (functionArgumentMemoryQualifier.readonly && |
| 4319 | !functionParameterMemoryQualifier.readonly) |
| 4320 | { |
| 4321 | error(functionCall->getLine(), |
| 4322 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4323 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4324 | } |
| 4325 | |
| 4326 | if (functionArgumentMemoryQualifier.writeonly && |
| 4327 | !functionParameterMemoryQualifier.writeonly) |
| 4328 | { |
| 4329 | error(functionCall->getLine(), |
| 4330 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4331 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4332 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4333 | |
| 4334 | if (functionArgumentMemoryQualifier.coherent && |
| 4335 | !functionParameterMemoryQualifier.coherent) |
| 4336 | { |
| 4337 | error(functionCall->getLine(), |
| 4338 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4339 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4340 | } |
| 4341 | |
| 4342 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 4343 | !functionParameterMemoryQualifier.volatileQualifier) |
| 4344 | { |
| 4345 | error(functionCall->getLine(), |
| 4346 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4347 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4348 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4349 | } |
| 4350 | } |
| 4351 | } |
| 4352 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4353 | TIntermSequence *TParseContext::createEmptyArgumentsList() |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4354 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4355 | return new TIntermSequence(); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4356 | } |
| 4357 | |
| 4358 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4359 | TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4360 | TIntermNode *thisNode, |
| 4361 | const TSourceLoc &loc) |
| 4362 | { |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4363 | if (thisNode != nullptr) |
| 4364 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4365 | return addMethod(fnCall, arguments, thisNode, loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4366 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4367 | |
| 4368 | TOperator op = fnCall->getBuiltInOp(); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 4369 | if (op == EOpConstruct) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4370 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 4371 | return addConstructor(arguments, fnCall->getReturnType(), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4372 | } |
| 4373 | else |
| 4374 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 4375 | ASSERT(op == EOpNull); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4376 | return addNonConstructorFunctionCall(fnCall, arguments, loc); |
| 4377 | } |
| 4378 | } |
| 4379 | |
| 4380 | TIntermTyped *TParseContext::addMethod(TFunction *fnCall, |
| 4381 | TIntermSequence *arguments, |
| 4382 | TIntermNode *thisNode, |
| 4383 | const TSourceLoc &loc) |
| 4384 | { |
| 4385 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 4386 | int arraySize = 0; |
| 4387 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 4388 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 4389 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 4390 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
| 4391 | // So accessing fnCall->getName() below is safe. |
| 4392 | if (fnCall->getName() != "length") |
| 4393 | { |
| 4394 | error(loc, "invalid method", fnCall->getName().c_str()); |
| 4395 | } |
| 4396 | else if (!arguments->empty()) |
| 4397 | { |
| 4398 | error(loc, "method takes no parameters", "length"); |
| 4399 | } |
| 4400 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 4401 | { |
| 4402 | error(loc, "length can only be called on arrays", "length"); |
| 4403 | } |
| 4404 | else |
| 4405 | { |
| 4406 | arraySize = typedThis->getArraySize(); |
| 4407 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4408 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4409 | // This code path can be hit with expressions like these: |
| 4410 | // (a = b).length() |
| 4411 | // (func()).length() |
| 4412 | // (int[3](0, 1, 2)).length() |
| 4413 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 4414 | // expression. |
| 4415 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 4416 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 4417 | // length method applied". |
| 4418 | error(loc, "length can only be called on array names, not on array expressions", |
| 4419 | "length"); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4420 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4421 | } |
| 4422 | unionArray->setIConst(arraySize); |
| 4423 | return intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), loc); |
| 4424 | } |
| 4425 | |
| 4426 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunction *fnCall, |
| 4427 | TIntermSequence *arguments, |
| 4428 | const TSourceLoc &loc) |
| 4429 | { |
| 4430 | // First find by unmangled name to check whether the function name has been |
| 4431 | // hidden by a variable name or struct typename. |
| 4432 | // If a function is found, check for one with a matching argument list. |
| 4433 | bool builtIn; |
| 4434 | const TSymbol *symbol = symbolTable.find(fnCall->getName(), mShaderVersion, &builtIn); |
| 4435 | if (symbol != nullptr && !symbol->isFunction()) |
| 4436 | { |
| 4437 | error(loc, "function name expected", fnCall->getName().c_str()); |
| 4438 | } |
| 4439 | else |
| 4440 | { |
| 4441 | symbol = symbolTable.find(TFunction::GetMangledNameFromCall(fnCall->getName(), *arguments), |
| 4442 | mShaderVersion, &builtIn); |
| 4443 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4444 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4445 | error(loc, "no matching overloaded function found", fnCall->getName().c_str()); |
| 4446 | } |
| 4447 | else |
| 4448 | { |
| 4449 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4450 | // |
| 4451 | // A declared function. |
| 4452 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 4453 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4454 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4455 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4456 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4457 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4458 | if (builtIn && op != EOpNull) |
| 4459 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4460 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4461 | if (fnCandidate->getParamCount() == 1) |
| 4462 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4463 | // Treat it like a built-in unary operator. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4464 | TIntermNode *unaryParamNode = arguments->front(); |
| 4465 | TIntermTyped *callNode = createUnaryMath(op, unaryParamNode->getAsTyped(), loc); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4466 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4467 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4468 | } |
| 4469 | else |
| 4470 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4471 | TIntermAggregate *callNode = |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4472 | TIntermAggregate::Create(fnCandidate->getReturnType(), op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4473 | callNode->setLine(loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4474 | |
| 4475 | // Some built-in functions have out parameters too. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4476 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4477 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4478 | // See if we can constant fold a built-in. Note that this may be possible even |
| 4479 | // if it is not const-qualified. |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4480 | TIntermTyped *foldedNode = |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4481 | intermediate.foldAggregateBuiltIn(callNode, mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4482 | if (foldedNode) |
| 4483 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4484 | return foldedNode; |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4485 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4486 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4487 | } |
| 4488 | } |
| 4489 | else |
| 4490 | { |
| 4491 | // This is a real function call |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4492 | TIntermAggregate *callNode = nullptr; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4493 | |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4494 | // If builtIn == false, the function is user defined - could be an overloaded |
| 4495 | // built-in as well. |
| 4496 | // if builtIn == true, it's a builtIn function with no op associated with it. |
| 4497 | // This needs to happen after the function info including name is set. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4498 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4499 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4500 | callNode = TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4501 | checkTextureOffsetConst(callNode); |
| 4502 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4503 | } |
| 4504 | else |
| 4505 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4506 | callNode = TIntermAggregate::CreateFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4507 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4508 | } |
| 4509 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4510 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4511 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4512 | callNode->setLine(loc); |
| 4513 | |
| 4514 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4515 | } |
| 4516 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4517 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4518 | |
| 4519 | // Error message was already written. Put on a dummy node for error recovery. |
| 4520 | return TIntermTyped::CreateZero(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4521 | } |
| 4522 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4523 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4524 | TIntermTyped *trueExpression, |
| 4525 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4526 | const TSourceLoc &loc) |
| 4527 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4528 | checkIsScalarBool(loc, cond); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4529 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4530 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4531 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4532 | binaryOpError(loc, "?:", trueExpression->getCompleteString(), |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4533 | falseExpression->getCompleteString()); |
| 4534 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4535 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 4536 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 4537 | { |
| 4538 | // ESSL 1.00 section 4.1.7 |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4539 | // ESSL 3.00.6 section 4.1.7 |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 4540 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 4541 | // Note that structs containing opaque types don't need to be checked as structs are |
| 4542 | // forbidden below. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4543 | error(loc, "ternary operator is not allowed for opaque types", "?:"); |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 4544 | return falseExpression; |
| 4545 | } |
| 4546 | |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4547 | // ESSL 1.00.17 sections 5.2 and 5.7: |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4548 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4549 | // ESSL 3.00.6 section 5.7: |
| 4550 | // Ternary operator support is optional for arrays. No certainty that it works across all |
| 4551 | // devices with struct either, so we err on the side of caution here. TODO (oetuaho@nvidia.com): |
| 4552 | // Would be nice to make the spec and implementation agree completely here. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4553 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4554 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4555 | error(loc, "ternary operator is not allowed for structures or arrays", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4556 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4557 | } |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4558 | if (trueExpression->getBasicType() == EbtInterfaceBlock) |
| 4559 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4560 | error(loc, "ternary operator is not allowed for interface blocks", "?:"); |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4561 | return falseExpression; |
| 4562 | } |
| 4563 | |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4564 | // WebGL2 section 5.26, the following results in an error: |
| 4565 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4566 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4567 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 4568 | error(loc, "ternary operator is not allowed for void", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4569 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4570 | } |
| 4571 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4572 | return TIntermediate::AddTernarySelection(cond, trueExpression, falseExpression, loc); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4573 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4574 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4575 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4576 | // Parse an array of strings using yyparse. |
| 4577 | // |
| 4578 | // Returns 0 for success. |
| 4579 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4580 | int PaParseStrings(size_t count, |
| 4581 | const char *const string[], |
| 4582 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4583 | TParseContext *context) |
| 4584 | { |
Yunchao He | 4f28544 | 2017-04-21 12:15:49 +0800 | [diff] [blame] | 4585 | if ((count == 0) || (string == nullptr)) |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4586 | return 1; |
| 4587 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4588 | if (glslang_initialize(context)) |
| 4589 | return 1; |
| 4590 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 4591 | int error = glslang_scan(count, string, length, context); |
| 4592 | if (!error) |
| 4593 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4594 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 4595 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 4596 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 4597 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4598 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 4599 | |
| 4600 | } // namespace sh |