Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES3.cpp: Validation functions for OpenGL ES 3.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES3.h" |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 10 | |
Jamie Madill | 5ea762a | 2017-06-07 14:59:51 -0400 | [diff] [blame] | 11 | #include "anglebase/numerics/safe_conversions.h" |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 12 | #include "common/mathutil.h" |
| 13 | #include "common/utilities.h" |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 14 | #include "libANGLE/Context.h" |
Martin Radev | 137032d | 2017-07-13 10:11:12 +0300 | [diff] [blame] | 15 | #include "libANGLE/ErrorStrings.h" |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 16 | #include "libANGLE/Framebuffer.h" |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 17 | #include "libANGLE/FramebufferAttachment.h" |
Jamie Madill | 231c7f5 | 2017-04-26 13:45:37 -0400 | [diff] [blame] | 18 | #include "libANGLE/Renderbuffer.h" |
| 19 | #include "libANGLE/Texture.h" |
| 20 | #include "libANGLE/formatutils.h" |
| 21 | #include "libANGLE/validationES.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 22 | |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 23 | using namespace angle; |
| 24 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | namespace gl |
| 26 | { |
| 27 | |
Martin Radev | 137032d | 2017-07-13 10:11:12 +0300 | [diff] [blame] | 28 | namespace |
| 29 | { |
| 30 | bool ValidateFramebufferTextureMultiviewBaseANGLE(Context *context, |
| 31 | GLenum target, |
| 32 | GLenum attachment, |
| 33 | GLuint texture, |
| 34 | GLint level, |
| 35 | GLsizei numViews) |
| 36 | { |
| 37 | if (!context->getExtensions().multiview) |
| 38 | { |
| 39 | context->handleError(InvalidOperation() << "ANGLE_multiview is not available."); |
| 40 | return false; |
| 41 | } |
| 42 | |
| 43 | if (!ValidateFramebufferTextureBase(context, target, attachment, texture, level)) |
| 44 | { |
| 45 | return false; |
| 46 | } |
| 47 | |
| 48 | if (numViews < 1) |
| 49 | { |
| 50 | context->handleError(InvalidValue() << "numViews cannot be less than 1."); |
| 51 | return false; |
| 52 | } |
| 53 | |
| 54 | const Extensions &extensions = context->getExtensions(); |
| 55 | if (static_cast<GLuint>(numViews) > extensions.maxViews) |
| 56 | { |
| 57 | context->handleError(InvalidValue() |
| 58 | << "numViews cannot be greater than GL_MAX_VIEWS_ANGLE."); |
| 59 | return false; |
| 60 | } |
| 61 | |
| 62 | return true; |
| 63 | } |
| 64 | |
| 65 | bool ValidateFramebufferTextureMultiviewLevelAndFormat(Context *context, |
| 66 | Texture *texture, |
| 67 | GLint level) |
| 68 | { |
| 69 | GLenum texTarget = texture->getTarget(); |
| 70 | if (!ValidMipLevel(context, texTarget, level)) |
| 71 | { |
| 72 | ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel); |
| 73 | return false; |
| 74 | } |
| 75 | |
| 76 | const auto &format = texture->getFormat(texTarget, level); |
| 77 | if (format.info->compressed) |
| 78 | { |
| 79 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), CompressedTexturesNotAttachable); |
| 80 | return false; |
| 81 | } |
| 82 | return true; |
| 83 | } |
| 84 | |
Jamie Madill | ff325f1 | 2017-08-26 15:06:05 -0400 | [diff] [blame] | 85 | bool ValidateUniformES3(Context *context, GLenum uniformType, GLint location, GLint count) |
| 86 | { |
| 87 | if (context->getClientMajorVersion() < 3) |
| 88 | { |
| 89 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 90 | return false; |
| 91 | } |
| 92 | |
| 93 | return ValidateUniform(context, uniformType, location, count); |
| 94 | } |
| 95 | |
Jamie Madill | c8c9581 | 2017-08-26 18:40:09 -0400 | [diff] [blame] | 96 | bool ValidateUniformMatrixES3(Context *context, |
| 97 | GLenum valueType, |
| 98 | GLint location, |
| 99 | GLsizei count, |
| 100 | GLboolean transpose) |
| 101 | { |
| 102 | // Check for ES3 uniform entry points |
| 103 | if (context->getClientMajorVersion() < 3) |
| 104 | { |
| 105 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 106 | return false; |
| 107 | } |
| 108 | |
| 109 | return ValidateUniformMatrix(context, valueType, location, count, transpose); |
| 110 | } |
| 111 | |
Jamie Madill | ff325f1 | 2017-08-26 15:06:05 -0400 | [diff] [blame] | 112 | } // anonymous namespace |
Martin Radev | 137032d | 2017-07-13 10:11:12 +0300 | [diff] [blame] | 113 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 114 | static bool ValidateTexImageFormatCombination(gl::Context *context, |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 115 | GLenum target, |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 116 | GLenum internalFormat, |
| 117 | GLenum format, |
| 118 | GLenum type) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 119 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 120 | |
| 121 | // The type and format are valid if any supported internal format has that type and format |
Geoff Lang | 6d1ccf0 | 2017-04-24 14:09:58 -0400 | [diff] [blame] | 122 | if (!ValidES3Format(format)) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 123 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 124 | ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFormat); |
Geoff Lang | 6d1ccf0 | 2017-04-24 14:09:58 -0400 | [diff] [blame] | 125 | return false; |
| 126 | } |
| 127 | |
| 128 | if (!ValidES3Type(type)) |
| 129 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 130 | ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType); |
Geoff Lang | 6d1ccf0 | 2017-04-24 14:09:58 -0400 | [diff] [blame] | 131 | return false; |
| 132 | } |
| 133 | |
| 134 | // For historical reasons, glTexImage2D and glTexImage3D pass in their internal format as a |
| 135 | // GLint instead of a GLenum. Therefor an invalid internal format gives a GL_INVALID_VALUE |
| 136 | // error instead of a GL_INVALID_ENUM error. As this validation function is only called in |
| 137 | // the validation codepaths for glTexImage2D/3D, we record a GL_INVALID_VALUE error. |
| 138 | if (!ValidES3InternalFormat(internalFormat)) |
| 139 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 140 | ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidInternalFormat); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 141 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 142 | } |
| 143 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 144 | // From the ES 3.0 spec section 3.8.3: |
| 145 | // Textures with a base internal format of DEPTH_COMPONENT or DEPTH_STENCIL are supported by |
| 146 | // texture image specification commands only if target is TEXTURE_2D, TEXTURE_2D_ARRAY, or |
| 147 | // TEXTURE_CUBE_MAP.Using these formats in conjunction with any other target will result in an |
| 148 | // INVALID_OPERATION error. |
| 149 | if (target == GL_TEXTURE_3D && (format == GL_DEPTH_COMPONENT || format == GL_DEPTH_STENCIL)) |
| 150 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 151 | context->handleError(InvalidOperation() << "Format cannot be GL_DEPTH_COMPONENT or " |
| 152 | "GL_DEPTH_STENCIL if target is " |
| 153 | "GL_TEXTURE_3D"); |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 154 | return false; |
| 155 | } |
| 156 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 157 | // Check if this is a valid format combination to load texture data |
Jamie Madill | 55e9821 | 2016-10-05 16:39:13 -0400 | [diff] [blame] | 158 | if (!ValidES3FormatCombination(format, type, internalFormat)) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 159 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 160 | context->handleError(InvalidOperation() |
| 161 | << "Invalid combination of format, type and internalFormat."); |
Geoff Lang | 6d1ccf0 | 2017-04-24 14:09:58 -0400 | [diff] [blame] | 162 | return false; |
| 163 | } |
| 164 | |
| 165 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalFormat, type); |
| 166 | if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions())) |
| 167 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 168 | context->handleError(InvalidOperation() << "Unsupported internal format."); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 169 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 170 | } |
| 171 | |
| 172 | return true; |
| 173 | } |
| 174 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 175 | bool ValidateES3TexImageParametersBase(Context *context, |
| 176 | GLenum target, |
| 177 | GLint level, |
| 178 | GLenum internalformat, |
| 179 | bool isCompressed, |
| 180 | bool isSubImage, |
| 181 | GLint xoffset, |
| 182 | GLint yoffset, |
| 183 | GLint zoffset, |
| 184 | GLsizei width, |
| 185 | GLsizei height, |
| 186 | GLsizei depth, |
| 187 | GLint border, |
| 188 | GLenum format, |
| 189 | GLenum type, |
Geoff Lang | ff5b2d5 | 2016-09-07 11:32:23 -0400 | [diff] [blame] | 190 | GLsizei imageSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 191 | const void *pixels) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 192 | { |
| 193 | // Validate image size |
Austin Kinross | 08528e1 | 2015-10-07 16:24:40 -0700 | [diff] [blame] | 194 | if (!ValidImageSizeParameters(context, target, level, width, height, depth, isSubImage)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 195 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 196 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 197 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 198 | } |
| 199 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 200 | // Verify zero border |
| 201 | if (border != 0) |
| 202 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 203 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 204 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 205 | } |
| 206 | |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 207 | if (xoffset < 0 || yoffset < 0 || zoffset < 0 || |
| 208 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 209 | std::numeric_limits<GLsizei>::max() - yoffset < height || |
| 210 | std::numeric_limits<GLsizei>::max() - zoffset < depth) |
| 211 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 212 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 213 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 214 | } |
| 215 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 216 | const gl::Caps &caps = context->getCaps(); |
| 217 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 218 | switch (target) |
| 219 | { |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 220 | case GL_TEXTURE_2D: |
| 221 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 222 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
| 223 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 224 | context->handleError(InvalidValue()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 225 | return false; |
| 226 | } |
| 227 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 228 | |
Corentin Wallez | 13c0dd4 | 2017-07-04 18:27:01 -0400 | [diff] [blame] | 229 | case GL_TEXTURE_RECTANGLE_ANGLE: |
| 230 | ASSERT(level == 0); |
| 231 | if (static_cast<GLuint>(width) > caps.maxRectangleTextureSize || |
| 232 | static_cast<GLuint>(height) > caps.maxRectangleTextureSize) |
| 233 | { |
| 234 | context->handleError(InvalidValue()); |
| 235 | return false; |
| 236 | } |
| 237 | if (isCompressed) |
| 238 | { |
| 239 | context->handleError(InvalidEnum() |
| 240 | << "Rectangle texture cannot have a compressed format."); |
| 241 | return false; |
| 242 | } |
| 243 | break; |
| 244 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 245 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 246 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 247 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 248 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 249 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 250 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| 251 | if (!isSubImage && width != height) |
| 252 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 253 | context->handleError(InvalidValue()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 254 | return false; |
| 255 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 256 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 257 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level)) |
| 258 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 259 | context->handleError(InvalidValue()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 260 | return false; |
| 261 | } |
| 262 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 263 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 264 | case GL_TEXTURE_3D: |
| 265 | if (static_cast<GLuint>(width) > (caps.max3DTextureSize >> level) || |
| 266 | static_cast<GLuint>(height) > (caps.max3DTextureSize >> level) || |
| 267 | static_cast<GLuint>(depth) > (caps.max3DTextureSize >> level)) |
| 268 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 269 | context->handleError(InvalidValue()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 270 | return false; |
| 271 | } |
| 272 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 273 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 274 | case GL_TEXTURE_2D_ARRAY: |
| 275 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 276 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level) || |
| 277 | static_cast<GLuint>(depth) > caps.maxArrayTextureLayers) |
| 278 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 279 | context->handleError(InvalidValue()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 280 | return false; |
| 281 | } |
| 282 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 283 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 284 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 285 | context->handleError(InvalidEnum()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 286 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 287 | } |
| 288 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 289 | gl::Texture *texture = |
| 290 | context->getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 291 | if (!texture) |
| 292 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 293 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 294 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 295 | } |
| 296 | |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 297 | if (texture->getImmutableFormat() && !isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 298 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 299 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 300 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 301 | } |
| 302 | |
| 303 | // Validate texture formats |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame] | 304 | GLenum actualInternalFormat = |
Geoff Lang | c4e9366 | 2017-05-01 10:45:59 -0400 | [diff] [blame] | 305 | isSubImage ? texture->getFormat(target, level).info->internalFormat : internalformat; |
Geoff Lang | c51642b | 2016-11-14 16:18:26 -0500 | [diff] [blame] | 306 | if (isSubImage && actualInternalFormat == GL_NONE) |
| 307 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 308 | context->handleError(InvalidOperation() << "Texture level does not exist."); |
Geoff Lang | c51642b | 2016-11-14 16:18:26 -0500 | [diff] [blame] | 309 | return false; |
| 310 | } |
| 311 | |
Geoff Lang | c4e9366 | 2017-05-01 10:45:59 -0400 | [diff] [blame] | 312 | const gl::InternalFormat &actualFormatInfo = isSubImage |
| 313 | ? *texture->getFormat(target, level).info |
| 314 | : GetInternalFormatInfo(internalformat, type); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 315 | if (isCompressed) |
| 316 | { |
tmartino | 7c10269 | 2015-10-02 16:43:40 -0400 | [diff] [blame] | 317 | if (!actualFormatInfo.compressed) |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 318 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 319 | context->handleError( |
| 320 | InvalidEnum() << "internalformat is not a supported compressed internal format."); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 321 | return false; |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 322 | } |
| 323 | |
Geoff Lang | 966c940 | 2017-04-18 12:38:27 -0400 | [diff] [blame] | 324 | if (isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 325 | { |
Geoff Lang | 966c940 | 2017-04-18 12:38:27 -0400 | [diff] [blame] | 326 | if (!ValidCompressedSubImageSize( |
| 327 | context, actualFormatInfo.internalFormat, xoffset, yoffset, width, height, |
| 328 | texture->getWidth(target, level), texture->getHeight(target, level))) |
| 329 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 330 | context->handleError(InvalidOperation() << "Invalid compressed format dimension."); |
Geoff Lang | 966c940 | 2017-04-18 12:38:27 -0400 | [diff] [blame] | 331 | return false; |
| 332 | } |
| 333 | |
| 334 | if (format != actualInternalFormat) |
| 335 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 336 | context->handleError(InvalidOperation() |
| 337 | << "Format must match the internal format of the texture."); |
Geoff Lang | 966c940 | 2017-04-18 12:38:27 -0400 | [diff] [blame] | 338 | return false; |
| 339 | } |
| 340 | } |
| 341 | else |
| 342 | { |
| 343 | if (!ValidCompressedImageSize(context, actualInternalFormat, level, width, height)) |
| 344 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 345 | context->handleError(InvalidOperation() << "Invalid compressed format dimension."); |
Geoff Lang | 966c940 | 2017-04-18 12:38:27 -0400 | [diff] [blame] | 346 | return false; |
| 347 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 348 | } |
| 349 | |
Geoff Lang | eb66a6e | 2016-10-31 13:06:12 -0400 | [diff] [blame] | 350 | if (!actualFormatInfo.textureSupport(context->getClientVersion(), context->getExtensions())) |
Geoff Lang | 839ce0b | 2015-10-23 13:13:12 -0400 | [diff] [blame] | 351 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 352 | context->handleError(InvalidEnum()); |
Geoff Lang | 839ce0b | 2015-10-23 13:13:12 -0400 | [diff] [blame] | 353 | return false; |
| 354 | } |
| 355 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 356 | if (target == GL_TEXTURE_3D) |
| 357 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 358 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 359 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 360 | } |
| 361 | } |
| 362 | else |
| 363 | { |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 364 | if (!ValidateTexImageFormatCombination(context, target, actualInternalFormat, format, type)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 365 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 366 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 367 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 368 | } |
| 369 | |
| 370 | // Validate sub image parameters |
| 371 | if (isSubImage) |
| 372 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 373 | if (isCompressed != actualFormatInfo.compressed) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 374 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 375 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 376 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 377 | } |
| 378 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 379 | if (xoffset < 0 || yoffset < 0 || zoffset < 0) |
| 380 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 381 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 382 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 383 | } |
| 384 | |
| 385 | if (std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 386 | std::numeric_limits<GLsizei>::max() - yoffset < height || |
| 387 | std::numeric_limits<GLsizei>::max() - zoffset < depth) |
| 388 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 389 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 390 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 391 | } |
| 392 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 393 | if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) || |
| 394 | static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) || |
| 395 | static_cast<size_t>(zoffset + depth) > texture->getDepth(target, level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 396 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 397 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 398 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 399 | } |
| 400 | } |
| 401 | |
Geoff Lang | dbcced8 | 2017-06-06 15:55:54 -0400 | [diff] [blame] | 402 | GLenum sizeCheckFormat = isSubImage ? format : internalformat; |
| 403 | if (!ValidImageDataSize(context, target, width, height, depth, sizeCheckFormat, type, pixels, |
| 404 | imageSize)) |
Geoff Lang | ff5b2d5 | 2016-09-07 11:32:23 -0400 | [diff] [blame] | 405 | { |
| 406 | return false; |
| 407 | } |
| 408 | |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 409 | // Check for pixel unpack buffer related API errors |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 410 | gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER); |
Corentin Wallez | ece7c5a | 2016-09-21 15:28:23 -0400 | [diff] [blame] | 411 | if (pixelUnpackBuffer != nullptr) |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 412 | { |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 413 | // ...data is not evenly divisible into the number of bytes needed to store in memory a |
| 414 | // datum |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 415 | // indicated by type. |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 416 | if (!isCompressed) |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 417 | { |
Geoff Lang | ff5b2d5 | 2016-09-07 11:32:23 -0400 | [diff] [blame] | 418 | size_t offset = reinterpret_cast<size_t>(pixels); |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 419 | size_t dataBytesPerPixel = static_cast<size_t>(gl::GetTypeInfo(type).bytes); |
| 420 | |
Geoff Lang | ff5b2d5 | 2016-09-07 11:32:23 -0400 | [diff] [blame] | 421 | if ((offset % dataBytesPerPixel) != 0) |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 422 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 423 | context->handleError(InvalidOperation() |
| 424 | << "Reads would overflow the pixel unpack buffer."); |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 425 | return false; |
| 426 | } |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 427 | } |
| 428 | |
Jamie Madill | 7a5f738 | 2014-03-05 15:01:24 -0500 | [diff] [blame] | 429 | // ...the buffer object's data store is currently mapped. |
Brandon Jones | d38f926 | 2014-06-18 16:26:45 -0700 | [diff] [blame] | 430 | if (pixelUnpackBuffer->isMapped()) |
Jamie Madill | 7a5f738 | 2014-03-05 15:01:24 -0500 | [diff] [blame] | 431 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 432 | context->handleError(InvalidOperation() << "Pixel unpack buffer is mapped."); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 433 | return false; |
Jamie Madill | 7a5f738 | 2014-03-05 15:01:24 -0500 | [diff] [blame] | 434 | } |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 435 | } |
| 436 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 437 | return true; |
| 438 | } |
| 439 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 440 | bool ValidateES3TexImage2DParameters(Context *context, |
| 441 | GLenum target, |
| 442 | GLint level, |
| 443 | GLenum internalformat, |
| 444 | bool isCompressed, |
| 445 | bool isSubImage, |
| 446 | GLint xoffset, |
| 447 | GLint yoffset, |
| 448 | GLint zoffset, |
| 449 | GLsizei width, |
| 450 | GLsizei height, |
| 451 | GLsizei depth, |
| 452 | GLint border, |
| 453 | GLenum format, |
| 454 | GLenum type, |
Geoff Lang | ff5b2d5 | 2016-09-07 11:32:23 -0400 | [diff] [blame] | 455 | GLsizei imageSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 456 | const void *pixels) |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 457 | { |
| 458 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 459 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 460 | context->handleError(InvalidEnum()); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 461 | return false; |
| 462 | } |
| 463 | |
| 464 | return ValidateES3TexImageParametersBase(context, target, level, internalformat, isCompressed, |
| 465 | isSubImage, xoffset, yoffset, zoffset, width, height, |
Geoff Lang | ff5b2d5 | 2016-09-07 11:32:23 -0400 | [diff] [blame] | 466 | depth, border, format, type, imageSize, pixels); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 467 | } |
| 468 | |
| 469 | bool ValidateES3TexImage3DParameters(Context *context, |
| 470 | GLenum target, |
| 471 | GLint level, |
| 472 | GLenum internalformat, |
| 473 | bool isCompressed, |
| 474 | bool isSubImage, |
| 475 | GLint xoffset, |
| 476 | GLint yoffset, |
| 477 | GLint zoffset, |
| 478 | GLsizei width, |
| 479 | GLsizei height, |
| 480 | GLsizei depth, |
| 481 | GLint border, |
| 482 | GLenum format, |
| 483 | GLenum type, |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 484 | GLsizei bufSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 485 | const void *pixels) |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 486 | { |
| 487 | if (!ValidTexture3DDestinationTarget(context, target)) |
| 488 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 489 | context->handleError(InvalidEnum()); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 490 | return false; |
| 491 | } |
| 492 | |
| 493 | return ValidateES3TexImageParametersBase(context, target, level, internalformat, isCompressed, |
| 494 | isSubImage, xoffset, yoffset, zoffset, width, height, |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 495 | depth, border, format, type, bufSize, pixels); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 496 | } |
| 497 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 498 | struct EffectiveInternalFormatInfo |
| 499 | { |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 500 | GLenum effectiveFormat; |
| 501 | GLenum destFormat; |
| 502 | GLuint minRedBits; |
| 503 | GLuint maxRedBits; |
| 504 | GLuint minGreenBits; |
| 505 | GLuint maxGreenBits; |
| 506 | GLuint minBlueBits; |
| 507 | GLuint maxBlueBits; |
| 508 | GLuint minAlphaBits; |
| 509 | GLuint maxAlphaBits; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 510 | }; |
| 511 | |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 512 | static bool QueryEffectiveFormatList(const InternalFormat &srcFormat, |
| 513 | GLenum targetFormat, |
| 514 | const EffectiveInternalFormatInfo *list, |
| 515 | size_t size, |
| 516 | GLenum *outEffectiveFormat) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 517 | { |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 518 | for (size_t curFormat = 0; curFormat < size; ++curFormat) |
| 519 | { |
| 520 | const EffectiveInternalFormatInfo &formatInfo = list[curFormat]; |
| 521 | if ((formatInfo.destFormat == targetFormat) && |
| 522 | (formatInfo.minRedBits <= srcFormat.redBits && |
| 523 | formatInfo.maxRedBits >= srcFormat.redBits) && |
| 524 | (formatInfo.minGreenBits <= srcFormat.greenBits && |
| 525 | formatInfo.maxGreenBits >= srcFormat.greenBits) && |
| 526 | (formatInfo.minBlueBits <= srcFormat.blueBits && |
| 527 | formatInfo.maxBlueBits >= srcFormat.blueBits) && |
| 528 | (formatInfo.minAlphaBits <= srcFormat.alphaBits && |
| 529 | formatInfo.maxAlphaBits >= srcFormat.alphaBits)) |
| 530 | { |
| 531 | *outEffectiveFormat = formatInfo.effectiveFormat; |
| 532 | return true; |
| 533 | } |
| 534 | } |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 535 | |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 536 | *outEffectiveFormat = GL_NONE; |
| 537 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 538 | } |
| 539 | |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 540 | bool GetSizedEffectiveInternalFormatInfo(const InternalFormat &srcFormat, |
| 541 | GLenum *outEffectiveFormat) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 542 | { |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 543 | // OpenGL ES 3.0.3 Specification, Table 3.17, pg 141: |
| 544 | // Effective internal format coresponding to destination internal format and linear source |
| 545 | // buffer component sizes. |
| 546 | // | Source channel min/max sizes | |
| 547 | // Effective Internal Format | N/A | R | G | B | A | |
| 548 | // clang-format off |
| 549 | constexpr EffectiveInternalFormatInfo list[] = { |
| 550 | { GL_ALPHA8_EXT, GL_NONE, 0, 0, 0, 0, 0, 0, 1, 8 }, |
| 551 | { GL_R8, GL_NONE, 1, 8, 0, 0, 0, 0, 0, 0 }, |
| 552 | { GL_RG8, GL_NONE, 1, 8, 1, 8, 0, 0, 0, 0 }, |
| 553 | { GL_RGB565, GL_NONE, 1, 5, 1, 6, 1, 5, 0, 0 }, |
| 554 | { GL_RGB8, GL_NONE, 6, 8, 7, 8, 6, 8, 0, 0 }, |
| 555 | { GL_RGBA4, GL_NONE, 1, 4, 1, 4, 1, 4, 1, 4 }, |
| 556 | { GL_RGB5_A1, GL_NONE, 5, 5, 5, 5, 5, 5, 1, 1 }, |
| 557 | { GL_RGBA8, GL_NONE, 5, 8, 5, 8, 5, 8, 2, 8 }, |
| 558 | { GL_RGB10_A2, GL_NONE, 9, 10, 9, 10, 9, 10, 2, 2 }, |
| 559 | }; |
| 560 | // clang-format on |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 561 | |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 562 | return QueryEffectiveFormatList(srcFormat, GL_NONE, list, ArraySize(list), outEffectiveFormat); |
| 563 | } |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 564 | |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 565 | bool GetUnsizedEffectiveInternalFormatInfo(const InternalFormat &srcFormat, |
| 566 | const InternalFormat &destFormat, |
| 567 | GLenum *outEffectiveFormat) |
| 568 | { |
| 569 | constexpr GLuint umax = UINT_MAX; |
| 570 | |
| 571 | // OpenGL ES 3.0.3 Specification, Table 3.17, pg 141: |
| 572 | // Effective internal format coresponding to destination internal format andlinear source buffer |
| 573 | // component sizes. |
| 574 | // | Source channel min/max sizes | |
| 575 | // Effective Internal Format | Dest Format | R | G | B | A | |
| 576 | // clang-format off |
| 577 | constexpr EffectiveInternalFormatInfo list[] = { |
| 578 | { GL_ALPHA8_EXT, GL_ALPHA, 0, umax, 0, umax, 0, umax, 1, 8 }, |
| 579 | { GL_LUMINANCE8_EXT, GL_LUMINANCE, 1, 8, 0, umax, 0, umax, 0, umax }, |
| 580 | { GL_LUMINANCE8_ALPHA8_EXT, GL_LUMINANCE_ALPHA, 1, 8, 0, umax, 0, umax, 1, 8 }, |
| 581 | { GL_RGB565, GL_RGB, 1, 5, 1, 6, 1, 5, 0, umax }, |
| 582 | { GL_RGB8, GL_RGB, 6, 8, 7, 8, 6, 8, 0, umax }, |
| 583 | { GL_RGBA4, GL_RGBA, 1, 4, 1, 4, 1, 4, 1, 4 }, |
| 584 | { GL_RGB5_A1, GL_RGBA, 5, 5, 5, 5, 5, 5, 1, 1 }, |
| 585 | { GL_RGBA8, GL_RGBA, 5, 8, 5, 8, 5, 8, 5, 8 }, |
| 586 | }; |
| 587 | // clang-format on |
| 588 | |
| 589 | return QueryEffectiveFormatList(srcFormat, destFormat.format, list, ArraySize(list), |
| 590 | outEffectiveFormat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 591 | } |
| 592 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 593 | static bool GetEffectiveInternalFormat(const InternalFormat &srcFormat, |
| 594 | const InternalFormat &destFormat, |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 595 | GLenum *outEffectiveFormat) |
| 596 | { |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 597 | if (destFormat.sized) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 598 | { |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 599 | return GetSizedEffectiveInternalFormatInfo(srcFormat, outEffectiveFormat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 600 | } |
| 601 | else |
| 602 | { |
Jamie Madill | 76648fe | 2016-10-05 17:01:41 -0400 | [diff] [blame] | 603 | return GetUnsizedEffectiveInternalFormatInfo(srcFormat, destFormat, outEffectiveFormat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 604 | } |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 605 | } |
| 606 | |
Corentin Wallez | 7628768 | 2016-04-25 09:23:38 -0400 | [diff] [blame] | 607 | static bool EqualOrFirstZero(GLuint first, GLuint second) |
| 608 | { |
| 609 | return first == 0 || first == second; |
| 610 | } |
| 611 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 612 | static bool IsValidES3CopyTexImageCombination(const InternalFormat &textureFormatInfo, |
| 613 | const InternalFormat &framebufferFormatInfo, |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 614 | GLuint readBufferHandle) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 615 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 616 | if (!ValidES3CopyConversion(textureFormatInfo.format, framebufferFormatInfo.format)) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 617 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 618 | return false; |
| 619 | } |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 620 | |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 621 | // Section 3.8.5 of the GLES 3.0.3 spec states that source and destination formats |
| 622 | // must both be signed, unsigned, or fixed point and both source and destinations |
| 623 | // must be either both SRGB or both not SRGB. EXT_color_buffer_float adds allowed |
| 624 | // conversion between fixed and floating point. |
| 625 | |
| 626 | if ((textureFormatInfo.colorEncoding == GL_SRGB) != |
| 627 | (framebufferFormatInfo.colorEncoding == GL_SRGB)) |
| 628 | { |
| 629 | return false; |
| 630 | } |
| 631 | |
| 632 | if (((textureFormatInfo.componentType == GL_INT) != |
| 633 | (framebufferFormatInfo.componentType == GL_INT)) || |
| 634 | ((textureFormatInfo.componentType == GL_UNSIGNED_INT) != |
| 635 | (framebufferFormatInfo.componentType == GL_UNSIGNED_INT))) |
| 636 | { |
| 637 | return false; |
| 638 | } |
| 639 | |
| 640 | if ((textureFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || |
| 641 | textureFormatInfo.componentType == GL_SIGNED_NORMALIZED || |
| 642 | textureFormatInfo.componentType == GL_FLOAT) && |
| 643 | !(framebufferFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || |
| 644 | framebufferFormatInfo.componentType == GL_SIGNED_NORMALIZED || |
| 645 | framebufferFormatInfo.componentType == GL_FLOAT)) |
| 646 | { |
| 647 | return false; |
| 648 | } |
| 649 | |
| 650 | // GLES specification 3.0.3, sec 3.8.5, pg 139-140: |
| 651 | // The effective internal format of the source buffer is determined with the following rules |
| 652 | // applied in order: |
| 653 | // * If the source buffer is a texture or renderbuffer that was created with a sized internal |
| 654 | // format then the effective internal format is the source buffer's sized internal format. |
| 655 | // * If the source buffer is a texture that was created with an unsized base internal format, |
| 656 | // then the effective internal format is the source image array's effective internal |
| 657 | // format, as specified by table 3.12, which is determined from the <format> and <type> |
| 658 | // that were used when the source image array was specified by TexImage*. |
| 659 | // * Otherwise the effective internal format is determined by the row in table 3.17 or 3.18 |
| 660 | // where Destination Internal Format matches internalformat and where the [source channel |
| 661 | // sizes] are consistent with the values of the source buffer's [channel sizes]. Table 3.17 |
| 662 | // is used if the FRAMEBUFFER_ATTACHMENT_ENCODING is LINEAR and table 3.18 is used if the |
| 663 | // FRAMEBUFFER_ATTACHMENT_ENCODING is SRGB. |
Yunchao He | d7297bf | 2017-04-19 15:27:10 +0800 | [diff] [blame] | 664 | const InternalFormat *sourceEffectiveFormat = nullptr; |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 665 | if (readBufferHandle != 0) |
| 666 | { |
| 667 | // Not the default framebuffer, therefore the read buffer must be a user-created texture or |
| 668 | // renderbuffer |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 669 | if (framebufferFormatInfo.sized) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 670 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 671 | sourceEffectiveFormat = &framebufferFormatInfo; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 672 | } |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 673 | else |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 674 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 675 | // Renderbuffers cannot be created with an unsized internal format, so this must be an |
| 676 | // unsized-format texture. We can use the same table we use when creating textures to |
| 677 | // get its effective sized format. |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 678 | sourceEffectiveFormat = |
| 679 | &GetSizedInternalFormatInfo(framebufferFormatInfo.sizedInternalFormat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 680 | } |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 681 | } |
| 682 | else |
| 683 | { |
| 684 | // The effective internal format must be derived from the source framebuffer's channel |
| 685 | // sizes. This is done in GetEffectiveInternalFormat for linear buffers (table 3.17) |
| 686 | if (framebufferFormatInfo.colorEncoding == GL_LINEAR) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 687 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 688 | GLenum effectiveFormat; |
| 689 | if (GetEffectiveInternalFormat(framebufferFormatInfo, textureFormatInfo, |
| 690 | &effectiveFormat)) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 691 | { |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 692 | sourceEffectiveFormat = &GetSizedInternalFormatInfo(effectiveFormat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 693 | } |
| 694 | else |
| 695 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 696 | return false; |
| 697 | } |
| 698 | } |
| 699 | else if (framebufferFormatInfo.colorEncoding == GL_SRGB) |
| 700 | { |
| 701 | // SRGB buffers can only be copied to sized format destinations according to table 3.18 |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 702 | if (textureFormatInfo.sized && |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 703 | (framebufferFormatInfo.redBits >= 1 && framebufferFormatInfo.redBits <= 8) && |
| 704 | (framebufferFormatInfo.greenBits >= 1 && framebufferFormatInfo.greenBits <= 8) && |
| 705 | (framebufferFormatInfo.blueBits >= 1 && framebufferFormatInfo.blueBits <= 8) && |
| 706 | (framebufferFormatInfo.alphaBits >= 1 && framebufferFormatInfo.alphaBits <= 8)) |
| 707 | { |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 708 | sourceEffectiveFormat = &GetSizedInternalFormatInfo(GL_SRGB8_ALPHA8); |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 709 | } |
| 710 | else |
| 711 | { |
| 712 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 713 | } |
| 714 | } |
| 715 | else |
| 716 | { |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 717 | UNREACHABLE(); |
| 718 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 719 | } |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 720 | } |
| 721 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 722 | if (textureFormatInfo.sized) |
Jamie Madill | 21b786b | 2016-11-01 17:41:31 -0400 | [diff] [blame] | 723 | { |
| 724 | // Section 3.8.5 of the GLES 3.0.3 spec, pg 139, requires that, if the destination format is |
| 725 | // sized, component sizes of the source and destination formats must exactly match if the |
| 726 | // destination format exists. |
| 727 | if (!EqualOrFirstZero(textureFormatInfo.redBits, sourceEffectiveFormat->redBits) || |
| 728 | !EqualOrFirstZero(textureFormatInfo.greenBits, sourceEffectiveFormat->greenBits) || |
| 729 | !EqualOrFirstZero(textureFormatInfo.blueBits, sourceEffectiveFormat->blueBits) || |
| 730 | !EqualOrFirstZero(textureFormatInfo.alphaBits, sourceEffectiveFormat->alphaBits)) |
| 731 | { |
| 732 | return false; |
| 733 | } |
| 734 | } |
| 735 | |
| 736 | return true; // A conversion function exists, and no rule in the specification has precluded |
| 737 | // conversion between these formats. |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 738 | } |
| 739 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 740 | bool ValidateES3CopyTexImageParametersBase(ValidationContext *context, |
| 741 | GLenum target, |
| 742 | GLint level, |
| 743 | GLenum internalformat, |
| 744 | bool isSubImage, |
| 745 | GLint xoffset, |
| 746 | GLint yoffset, |
| 747 | GLint zoffset, |
| 748 | GLint x, |
| 749 | GLint y, |
| 750 | GLsizei width, |
| 751 | GLsizei height, |
| 752 | GLint border) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 753 | { |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 754 | Format textureFormat = Format::Invalid(); |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 755 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 756 | xoffset, yoffset, zoffset, x, y, width, height, border, |
| 757 | &textureFormat)) |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 758 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 759 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 760 | } |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 761 | ASSERT(textureFormat.valid() || !isSubImage); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 762 | |
Jamie Madill | 51f40ec | 2016-06-15 14:06:00 -0400 | [diff] [blame] | 763 | const auto &state = context->getGLState(); |
| 764 | gl::Framebuffer *framebuffer = state.getReadFramebuffer(); |
| 765 | GLuint readFramebufferID = framebuffer->id(); |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 766 | |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 767 | if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 768 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 769 | context->handleError(InvalidFramebufferOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 770 | return false; |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 771 | } |
| 772 | |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 773 | if (readFramebufferID != 0 && framebuffer->getSamples(context) != 0) |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 774 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 775 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 776 | return false; |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 777 | } |
| 778 | |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 779 | const FramebufferAttachment *source = framebuffer->getReadColorbuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 780 | |
| 781 | if (isSubImage) |
| 782 | { |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 783 | if (!IsValidES3CopyTexImageCombination(*textureFormat.info, *source->getFormat().info, |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 784 | readFramebufferID)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 785 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 786 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 787 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 788 | } |
| 789 | } |
Shannon Woods | 4d161ba | 2014-03-17 18:13:30 -0400 | [diff] [blame] | 790 | else |
| 791 | { |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 792 | // Use format/type from the source FBO. (Might not be perfect for all cases?) |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 793 | const InternalFormat &framebufferFormat = *source->getFormat().info; |
| 794 | const InternalFormat ©Format = GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE); |
Jamie Madill | 0c8abca | 2016-07-22 20:21:26 -0400 | [diff] [blame] | 795 | if (!IsValidES3CopyTexImageCombination(copyFormat, framebufferFormat, readFramebufferID)) |
Shannon Woods | 4d161ba | 2014-03-17 18:13:30 -0400 | [diff] [blame] | 796 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 797 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 798 | return false; |
Shannon Woods | 4d161ba | 2014-03-17 18:13:30 -0400 | [diff] [blame] | 799 | } |
| 800 | } |
| 801 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 802 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 803 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 804 | } |
| 805 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 806 | bool ValidateES3CopyTexImage2DParameters(ValidationContext *context, |
| 807 | GLenum target, |
| 808 | GLint level, |
| 809 | GLenum internalformat, |
| 810 | bool isSubImage, |
| 811 | GLint xoffset, |
| 812 | GLint yoffset, |
| 813 | GLint zoffset, |
| 814 | GLint x, |
| 815 | GLint y, |
| 816 | GLsizei width, |
| 817 | GLsizei height, |
| 818 | GLint border) |
| 819 | { |
| 820 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 821 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 822 | context->handleError(InvalidEnum()); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 823 | return false; |
| 824 | } |
| 825 | |
| 826 | return ValidateES3CopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 827 | xoffset, yoffset, zoffset, x, y, width, height, |
| 828 | border); |
| 829 | } |
| 830 | |
| 831 | bool ValidateES3CopyTexImage3DParameters(ValidationContext *context, |
| 832 | GLenum target, |
| 833 | GLint level, |
| 834 | GLenum internalformat, |
| 835 | bool isSubImage, |
| 836 | GLint xoffset, |
| 837 | GLint yoffset, |
| 838 | GLint zoffset, |
| 839 | GLint x, |
| 840 | GLint y, |
| 841 | GLsizei width, |
| 842 | GLsizei height, |
| 843 | GLint border) |
| 844 | { |
| 845 | if (!ValidTexture3DDestinationTarget(context, target)) |
| 846 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 847 | context->handleError(InvalidEnum()); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 848 | return false; |
| 849 | } |
| 850 | |
| 851 | return ValidateES3CopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 852 | xoffset, yoffset, zoffset, x, y, width, height, |
| 853 | border); |
| 854 | } |
| 855 | |
| 856 | bool ValidateES3TexStorageParametersBase(Context *context, |
| 857 | GLenum target, |
| 858 | GLsizei levels, |
| 859 | GLenum internalformat, |
| 860 | GLsizei width, |
| 861 | GLsizei height, |
| 862 | GLsizei depth) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 863 | { |
| 864 | if (width < 1 || height < 1 || depth < 1 || levels < 1) |
| 865 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 866 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 867 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 868 | } |
| 869 | |
Geoff Lang | b92c133 | 2015-09-04 12:54:55 -0400 | [diff] [blame] | 870 | GLsizei maxDim = std::max(width, height); |
| 871 | if (target != GL_TEXTURE_2D_ARRAY) |
| 872 | { |
| 873 | maxDim = std::max(maxDim, depth); |
| 874 | } |
| 875 | |
| 876 | if (levels > gl::log2(maxDim) + 1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 877 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 878 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 879 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 880 | } |
| 881 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 882 | const gl::Caps &caps = context->getCaps(); |
| 883 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 884 | switch (target) |
| 885 | { |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 886 | case GL_TEXTURE_2D: |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 887 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 888 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 889 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 890 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 891 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 892 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 893 | } |
| 894 | } |
| 895 | break; |
| 896 | |
Corentin Wallez | 13c0dd4 | 2017-07-04 18:27:01 -0400 | [diff] [blame] | 897 | case GL_TEXTURE_RECTANGLE_ANGLE: |
| 898 | { |
| 899 | if (static_cast<GLuint>(width) > caps.maxRectangleTextureSize || |
| 900 | static_cast<GLuint>(height) > caps.maxRectangleTextureSize || levels != 1) |
| 901 | { |
| 902 | context->handleError(InvalidValue()); |
| 903 | return false; |
| 904 | } |
| 905 | } |
| 906 | break; |
| 907 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 908 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 909 | { |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 910 | if (width != height) |
| 911 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 912 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 913 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 914 | } |
| 915 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 916 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 917 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 918 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 919 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 920 | } |
| 921 | } |
| 922 | break; |
| 923 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 924 | case GL_TEXTURE_3D: |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 925 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 926 | if (static_cast<GLuint>(width) > caps.max3DTextureSize || |
| 927 | static_cast<GLuint>(height) > caps.max3DTextureSize || |
| 928 | static_cast<GLuint>(depth) > caps.max3DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 929 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 930 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 931 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 932 | } |
| 933 | } |
| 934 | break; |
| 935 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 936 | case GL_TEXTURE_2D_ARRAY: |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 937 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 938 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 939 | static_cast<GLuint>(height) > caps.max2DTextureSize || |
| 940 | static_cast<GLuint>(depth) > caps.maxArrayTextureLayers) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 941 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 942 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 943 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 944 | } |
| 945 | } |
| 946 | break; |
| 947 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 948 | default: |
| 949 | UNREACHABLE(); |
| 950 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 951 | } |
| 952 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 953 | gl::Texture *texture = context->getTargetTexture(target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 954 | if (!texture || texture->id() == 0) |
| 955 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 956 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 957 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 958 | } |
| 959 | |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 960 | if (texture->getImmutableFormat()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 961 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 962 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 963 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 964 | } |
| 965 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 966 | const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalformat); |
Geoff Lang | eb66a6e | 2016-10-31 13:06:12 -0400 | [diff] [blame] | 967 | if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions())) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 968 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 969 | context->handleError(InvalidEnum()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 970 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 971 | } |
| 972 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 973 | if (!formatInfo.sized) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 974 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 975 | context->handleError(InvalidEnum()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 976 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 977 | } |
| 978 | |
Corentin Wallez | 13c0dd4 | 2017-07-04 18:27:01 -0400 | [diff] [blame] | 979 | if (formatInfo.compressed && target == GL_TEXTURE_RECTANGLE_ANGLE) |
| 980 | { |
| 981 | context->handleError(InvalidEnum() << "Rectangle texture cannot have a compressed format."); |
| 982 | return false; |
| 983 | } |
| 984 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 985 | return true; |
| 986 | } |
| 987 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 988 | bool ValidateES3TexStorage2DParameters(Context *context, |
| 989 | GLenum target, |
| 990 | GLsizei levels, |
| 991 | GLenum internalformat, |
| 992 | GLsizei width, |
| 993 | GLsizei height, |
| 994 | GLsizei depth) |
| 995 | { |
| 996 | if (!ValidTexture2DTarget(context, target)) |
| 997 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 998 | context->handleError(InvalidEnum()); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 999 | return false; |
| 1000 | } |
| 1001 | |
| 1002 | return ValidateES3TexStorageParametersBase(context, target, levels, internalformat, width, |
| 1003 | height, depth); |
| 1004 | } |
| 1005 | |
| 1006 | bool ValidateES3TexStorage3DParameters(Context *context, |
| 1007 | GLenum target, |
| 1008 | GLsizei levels, |
| 1009 | GLenum internalformat, |
| 1010 | GLsizei width, |
| 1011 | GLsizei height, |
| 1012 | GLsizei depth) |
| 1013 | { |
| 1014 | if (!ValidTexture3DTarget(context, target)) |
| 1015 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1016 | context->handleError(InvalidEnum()); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1017 | return false; |
| 1018 | } |
| 1019 | |
| 1020 | return ValidateES3TexStorageParametersBase(context, target, levels, internalformat, width, |
| 1021 | height, depth); |
| 1022 | } |
| 1023 | |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1024 | bool ValidateBeginQuery(gl::Context *context, GLenum target, GLuint id) |
| 1025 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1026 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1027 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1028 | context->handleError(InvalidOperation() << "GLES version < 3.0"); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1029 | return false; |
| 1030 | } |
| 1031 | |
| 1032 | return ValidateBeginQueryBase(context, target, id); |
| 1033 | } |
| 1034 | |
| 1035 | bool ValidateEndQuery(gl::Context *context, GLenum target) |
| 1036 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1037 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1038 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1039 | context->handleError(InvalidOperation() << "GLES version < 3.0"); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1040 | return false; |
| 1041 | } |
| 1042 | |
| 1043 | return ValidateEndQueryBase(context, target); |
| 1044 | } |
| 1045 | |
| 1046 | bool ValidateGetQueryiv(Context *context, GLenum target, GLenum pname, GLint *params) |
| 1047 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1048 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1049 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1050 | context->handleError(InvalidOperation() << "GLES version < 3.0"); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1051 | return false; |
| 1052 | } |
| 1053 | |
Geoff Lang | 2186c38 | 2016-10-14 10:54:54 -0400 | [diff] [blame] | 1054 | return ValidateGetQueryivBase(context, target, pname, nullptr); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1055 | } |
| 1056 | |
| 1057 | bool ValidateGetQueryObjectuiv(Context *context, GLuint id, GLenum pname, GLuint *params) |
| 1058 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1059 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1060 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1061 | context->handleError(InvalidOperation() << "GLES version < 3.0"); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1062 | return false; |
| 1063 | } |
| 1064 | |
Geoff Lang | 2186c38 | 2016-10-14 10:54:54 -0400 | [diff] [blame] | 1065 | return ValidateGetQueryObjectValueBase(context, id, pname, nullptr); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1066 | } |
| 1067 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1068 | bool ValidateFramebufferTextureLayer(Context *context, |
| 1069 | GLenum target, |
| 1070 | GLenum attachment, |
| 1071 | GLuint texture, |
| 1072 | GLint level, |
| 1073 | GLint layer) |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1074 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1075 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1076 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1077 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1078 | return false; |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1079 | } |
| 1080 | |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1081 | if (layer < 0) |
| 1082 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1083 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1084 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1085 | } |
| 1086 | |
| 1087 | if (!ValidateFramebufferTextureBase(context, target, attachment, texture, level)) |
| 1088 | { |
| 1089 | return false; |
| 1090 | } |
| 1091 | |
| 1092 | const gl::Caps &caps = context->getCaps(); |
| 1093 | if (texture != 0) |
| 1094 | { |
| 1095 | gl::Texture *tex = context->getTexture(texture); |
| 1096 | ASSERT(tex); |
| 1097 | |
| 1098 | switch (tex->getTarget()) |
| 1099 | { |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1100 | case GL_TEXTURE_2D_ARRAY: |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1101 | { |
| 1102 | if (level > gl::log2(caps.max2DTextureSize)) |
| 1103 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1104 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1105 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1106 | } |
| 1107 | |
| 1108 | if (static_cast<GLuint>(layer) >= caps.maxArrayTextureLayers) |
| 1109 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1110 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1111 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1112 | } |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1113 | } |
| 1114 | break; |
| 1115 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1116 | case GL_TEXTURE_3D: |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1117 | { |
| 1118 | if (level > gl::log2(caps.max3DTextureSize)) |
| 1119 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1120 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1121 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1122 | } |
| 1123 | |
| 1124 | if (static_cast<GLuint>(layer) >= caps.max3DTextureSize) |
| 1125 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1126 | context->handleError(InvalidValue()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1127 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1128 | } |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1129 | } |
| 1130 | break; |
| 1131 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1132 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1133 | context->handleError(InvalidOperation()); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1134 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1135 | } |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 1136 | |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame] | 1137 | const auto &format = tex->getFormat(tex->getTarget(), level); |
| 1138 | if (format.info->compressed) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 1139 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1140 | context->handleError(InvalidOperation()); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 1141 | return false; |
| 1142 | } |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1143 | } |
| 1144 | |
| 1145 | return true; |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1146 | } |
| 1147 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1148 | bool ValidateInvalidateFramebuffer(Context *context, |
| 1149 | GLenum target, |
| 1150 | GLsizei numAttachments, |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1151 | const GLenum *attachments) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1152 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1153 | if (context->getClientMajorVersion() < 3) |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1154 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 1155 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1156 | return false; |
| 1157 | } |
| 1158 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1159 | bool defaultFramebuffer = false; |
| 1160 | |
| 1161 | switch (target) |
| 1162 | { |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1163 | case GL_DRAW_FRAMEBUFFER: |
| 1164 | case GL_FRAMEBUFFER: |
| 1165 | defaultFramebuffer = context->getGLState().getDrawFramebuffer()->id() == 0; |
| 1166 | break; |
| 1167 | case GL_READ_FRAMEBUFFER: |
| 1168 | defaultFramebuffer = context->getGLState().getReadFramebuffer()->id() == 0; |
| 1169 | break; |
| 1170 | default: |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 1171 | ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget); |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1172 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1173 | } |
| 1174 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1175 | return ValidateDiscardFramebufferBase(context, target, numAttachments, attachments, |
| 1176 | defaultFramebuffer); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1177 | } |
| 1178 | |
Jamie Madill | 3ef140a | 2017-08-26 23:11:21 -0400 | [diff] [blame] | 1179 | bool ValidateInvalidateSubFramebuffer(Context *context, |
| 1180 | GLenum target, |
| 1181 | GLsizei numAttachments, |
| 1182 | const GLenum *attachments, |
| 1183 | GLint x, |
| 1184 | GLint y, |
| 1185 | GLsizei width, |
| 1186 | GLsizei height) |
| 1187 | { |
| 1188 | return ValidateInvalidateFramebuffer(context, target, numAttachments, attachments); |
| 1189 | } |
| 1190 | |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1191 | bool ValidateClearBuffer(ValidationContext *context) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1192 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1193 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1194 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1195 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1196 | return false; |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1197 | } |
| 1198 | |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 1199 | if (context->getGLState().getDrawFramebuffer()->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1200 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1201 | context->handleError(InvalidFramebufferOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1202 | return false; |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1203 | } |
| 1204 | |
| 1205 | return true; |
| 1206 | } |
| 1207 | |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1208 | bool ValidateDrawRangeElements(Context *context, |
| 1209 | GLenum mode, |
| 1210 | GLuint start, |
| 1211 | GLuint end, |
| 1212 | GLsizei count, |
| 1213 | GLenum type, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1214 | const void *indices) |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1215 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1216 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1217 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 1218 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1219 | return false; |
| 1220 | } |
| 1221 | |
| 1222 | if (end < start) |
| 1223 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1224 | context->handleError(InvalidValue() << "end < start"); |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1225 | return false; |
| 1226 | } |
| 1227 | |
Jamie Madill | 9c9b40a | 2017-04-26 16:31:57 -0400 | [diff] [blame] | 1228 | if (!ValidateDrawElementsCommon(context, mode, count, type, indices, 0)) |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1229 | { |
| 1230 | return false; |
| 1231 | } |
| 1232 | |
Jamie Madill | 9c9b40a | 2017-04-26 16:31:57 -0400 | [diff] [blame] | 1233 | // Use the parameter buffer to retrieve and cache the index range. |
| 1234 | const auto ¶ms = context->getParams<HasIndexRange>(); |
| 1235 | const auto &indexRangeOpt = params.getIndexRange(); |
| 1236 | if (!indexRangeOpt.valid()) |
| 1237 | { |
| 1238 | // Unexpected error. |
| 1239 | return false; |
| 1240 | } |
| 1241 | |
| 1242 | if (indexRangeOpt.value().end > end || indexRangeOpt.value().start < start) |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1243 | { |
| 1244 | // GL spec says that behavior in this case is undefined - generating an error is fine. |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1245 | context->handleError(InvalidOperation() << "Indices are out of the start, end range."); |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1246 | return false; |
| 1247 | } |
| 1248 | return true; |
| 1249 | } |
| 1250 | |
He Yunchao | ced53ae | 2016-11-29 15:00:51 +0800 | [diff] [blame] | 1251 | bool ValidateGetUniformuiv(Context *context, GLuint program, GLint location, GLuint *params) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1252 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1253 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1254 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1255 | context->handleError(InvalidOperation()); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1256 | return false; |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1257 | } |
| 1258 | |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1259 | return ValidateGetUniformBase(context, program, location); |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1260 | } |
| 1261 | |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1262 | bool ValidateReadBuffer(Context *context, GLenum src) |
| 1263 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1264 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1265 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1266 | context->handleError(InvalidOperation()); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1267 | return false; |
| 1268 | } |
| 1269 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 1270 | const Framebuffer *readFBO = context->getGLState().getReadFramebuffer(); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1271 | |
| 1272 | if (readFBO == nullptr) |
| 1273 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1274 | context->handleError(InvalidOperation() << "No active read framebuffer."); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1275 | return false; |
| 1276 | } |
| 1277 | |
| 1278 | if (src == GL_NONE) |
| 1279 | { |
| 1280 | return true; |
| 1281 | } |
| 1282 | |
Olli Etuaho | 84c9f59 | 2016-03-09 14:37:25 +0200 | [diff] [blame] | 1283 | if (src != GL_BACK && (src < GL_COLOR_ATTACHMENT0 || src > GL_COLOR_ATTACHMENT31)) |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1284 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1285 | context->handleError(InvalidEnum() << "Unknown enum for 'src' in ReadBuffer"); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1286 | return false; |
| 1287 | } |
| 1288 | |
| 1289 | if (readFBO->id() == 0) |
| 1290 | { |
| 1291 | if (src != GL_BACK) |
| 1292 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1293 | context->handleError( |
| 1294 | InvalidOperation() |
| 1295 | << "'src' must be GL_NONE or GL_BACK when reading from the default framebuffer."); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1296 | return false; |
| 1297 | } |
| 1298 | } |
| 1299 | else |
| 1300 | { |
| 1301 | GLuint drawBuffer = static_cast<GLuint>(src - GL_COLOR_ATTACHMENT0); |
| 1302 | |
| 1303 | if (drawBuffer >= context->getCaps().maxDrawBuffers) |
| 1304 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1305 | context->handleError(InvalidOperation() << "'src' is greater than MAX_DRAW_BUFFERS."); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1306 | return false; |
| 1307 | } |
| 1308 | } |
| 1309 | |
| 1310 | return true; |
| 1311 | } |
| 1312 | |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1313 | bool ValidateCompressedTexImage3D(Context *context, |
| 1314 | GLenum target, |
| 1315 | GLint level, |
| 1316 | GLenum internalformat, |
| 1317 | GLsizei width, |
| 1318 | GLsizei height, |
| 1319 | GLsizei depth, |
| 1320 | GLint border, |
| 1321 | GLsizei imageSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1322 | const void *data) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1323 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1324 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1325 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1326 | context->handleError(InvalidOperation()); |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1327 | return false; |
| 1328 | } |
| 1329 | |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1330 | if (!ValidTextureTarget(context, target)) |
| 1331 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1332 | context->handleError(InvalidEnum()); |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1333 | return false; |
| 1334 | } |
| 1335 | |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1336 | // Validate image size |
| 1337 | if (!ValidImageSizeParameters(context, target, level, width, height, depth, false)) |
| 1338 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1339 | context->handleError(InvalidValue()); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1340 | return false; |
| 1341 | } |
| 1342 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 1343 | const InternalFormat &formatInfo = GetSizedInternalFormatInfo(internalformat); |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1344 | if (!formatInfo.compressed) |
| 1345 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1346 | context->handleError(InvalidEnum() << "Not a valid compressed texture format"); |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1347 | return false; |
| 1348 | } |
| 1349 | |
Jamie Madill | 513558d | 2016-06-02 13:04:11 -0400 | [diff] [blame] | 1350 | auto blockSizeOrErr = |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1351 | formatInfo.computeCompressedImageSize(GL_UNSIGNED_BYTE, gl::Extents(width, height, depth)); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1352 | if (blockSizeOrErr.isError()) |
| 1353 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1354 | context->handleError(InvalidValue()); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1355 | return false; |
| 1356 | } |
| 1357 | if (imageSize < 0 || static_cast<GLuint>(imageSize) != blockSizeOrErr.getResult()) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1358 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1359 | context->handleError(InvalidValue()); |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1360 | return false; |
| 1361 | } |
| 1362 | |
| 1363 | // 3D texture target validation |
| 1364 | if (target != GL_TEXTURE_3D && target != GL_TEXTURE_2D_ARRAY) |
| 1365 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1366 | context->handleError(InvalidEnum() << "Must specify a valid 3D texture destination target"); |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1367 | return false; |
| 1368 | } |
| 1369 | |
| 1370 | // validateES3TexImageFormat sets the error code if there is an error |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1371 | if (!ValidateES3TexImage3DParameters(context, target, level, internalformat, true, false, 0, 0, |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1372 | 0, width, height, depth, border, GL_NONE, GL_NONE, -1, |
| 1373 | data)) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1374 | { |
| 1375 | return false; |
| 1376 | } |
| 1377 | |
| 1378 | return true; |
| 1379 | } |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1380 | |
Corentin Wallez | b293160 | 2017-04-11 15:58:57 -0400 | [diff] [blame] | 1381 | bool ValidateCompressedTexImage3DRobustANGLE(Context *context, |
| 1382 | GLenum target, |
| 1383 | GLint level, |
| 1384 | GLenum internalformat, |
| 1385 | GLsizei width, |
| 1386 | GLsizei height, |
| 1387 | GLsizei depth, |
| 1388 | GLint border, |
| 1389 | GLsizei imageSize, |
| 1390 | GLsizei dataSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1391 | const void *data) |
Corentin Wallez | b293160 | 2017-04-11 15:58:57 -0400 | [diff] [blame] | 1392 | { |
| 1393 | if (!ValidateRobustCompressedTexImageBase(context, imageSize, dataSize)) |
| 1394 | { |
| 1395 | return false; |
| 1396 | } |
| 1397 | |
| 1398 | return ValidateCompressedTexImage3D(context, target, level, internalformat, width, height, |
| 1399 | depth, border, imageSize, data); |
| 1400 | } |
| 1401 | |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1402 | bool ValidateBindVertexArray(Context *context, GLuint array) |
| 1403 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1404 | if (context->getClientMajorVersion() < 3) |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1405 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1406 | context->handleError(InvalidOperation()); |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1407 | return false; |
| 1408 | } |
| 1409 | |
| 1410 | return ValidateBindVertexArrayBase(context, array); |
| 1411 | } |
| 1412 | |
Jamie Madill | d757673 | 2017-08-26 18:49:50 -0400 | [diff] [blame] | 1413 | bool ValidateIsVertexArray(Context *context, GLuint array) |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1414 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1415 | if (context->getClientMajorVersion() < 3) |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1416 | { |
Jamie Madill | d757673 | 2017-08-26 18:49:50 -0400 | [diff] [blame] | 1417 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1418 | return false; |
| 1419 | } |
| 1420 | |
| 1421 | return true; |
| 1422 | } |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1423 | |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1424 | static bool ValidateBindBufferCommon(Context *context, |
| 1425 | GLenum target, |
| 1426 | GLuint index, |
| 1427 | GLuint buffer, |
| 1428 | GLintptr offset, |
| 1429 | GLsizeiptr size) |
| 1430 | { |
| 1431 | if (context->getClientMajorVersion() < 3) |
| 1432 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1433 | context->handleError(InvalidOperation()); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1434 | return false; |
| 1435 | } |
| 1436 | |
| 1437 | if (buffer != 0 && offset < 0) |
| 1438 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1439 | context->handleError(InvalidValue() << "buffer is non-zero and offset is negative."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1440 | return false; |
| 1441 | } |
| 1442 | |
| 1443 | if (!context->getGLState().isBindGeneratesResourceEnabled() && |
| 1444 | !context->isBufferGenerated(buffer)) |
| 1445 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1446 | context->handleError(InvalidOperation() << "Buffer was not generated."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1447 | return false; |
| 1448 | } |
| 1449 | |
| 1450 | const Caps &caps = context->getCaps(); |
| 1451 | switch (target) |
| 1452 | { |
| 1453 | case GL_TRANSFORM_FEEDBACK_BUFFER: |
| 1454 | { |
| 1455 | if (index >= caps.maxTransformFeedbackSeparateAttributes) |
| 1456 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1457 | context->handleError(InvalidValue() << "index is greater than or equal to the " |
| 1458 | "number of TRANSFORM_FEEDBACK_BUFFER " |
| 1459 | "indexed binding points."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1460 | return false; |
| 1461 | } |
| 1462 | if (buffer != 0 && ((offset % 4) != 0 || (size % 4) != 0)) |
| 1463 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1464 | context->handleError(InvalidValue() << "offset and size must be multiple of 4."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1465 | return false; |
| 1466 | } |
| 1467 | |
| 1468 | TransformFeedback *curTransformFeedback = |
| 1469 | context->getGLState().getCurrentTransformFeedback(); |
| 1470 | if (curTransformFeedback && curTransformFeedback->isActive()) |
| 1471 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1472 | context->handleError(InvalidOperation() |
| 1473 | << "target is TRANSFORM_FEEDBACK_BUFFER and transform " |
| 1474 | "feedback is currently active."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1475 | return false; |
| 1476 | } |
| 1477 | break; |
| 1478 | } |
| 1479 | case GL_UNIFORM_BUFFER: |
| 1480 | { |
| 1481 | if (index >= caps.maxUniformBufferBindings) |
| 1482 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1483 | context->handleError(InvalidValue() << "index is greater than or equal to the " |
| 1484 | "number of UNIFORM_BUFFER indexed " |
| 1485 | "binding points."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1486 | return false; |
| 1487 | } |
| 1488 | |
| 1489 | if (buffer != 0 && (offset % caps.uniformBufferOffsetAlignment) != 0) |
| 1490 | { |
| 1491 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1492 | InvalidValue() |
| 1493 | << "offset must be multiple of value of UNIFORM_BUFFER_OFFSET_ALIGNMENT."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1494 | return false; |
| 1495 | } |
| 1496 | break; |
| 1497 | } |
| 1498 | case GL_ATOMIC_COUNTER_BUFFER: |
| 1499 | { |
| 1500 | if (context->getClientVersion() < ES_3_1) |
| 1501 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1502 | context->handleError(InvalidEnum() |
| 1503 | << "ATOMIC_COUNTER_BUFFER is not supported before GLES 3.1"); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1504 | return false; |
| 1505 | } |
| 1506 | if (index >= caps.maxAtomicCounterBufferBindings) |
| 1507 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1508 | context->handleError(InvalidValue() << "index is greater than or equal to the " |
| 1509 | "number of ATOMIC_COUNTER_BUFFER " |
| 1510 | "indexed binding points."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1511 | return false; |
| 1512 | } |
| 1513 | if (buffer != 0 && (offset % 4) != 0) |
| 1514 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1515 | context->handleError(InvalidValue() << "offset must be a multiple of 4."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1516 | return false; |
| 1517 | } |
| 1518 | break; |
| 1519 | } |
| 1520 | case GL_SHADER_STORAGE_BUFFER: |
| 1521 | { |
| 1522 | if (context->getClientVersion() < ES_3_1) |
| 1523 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1524 | context->handleError(InvalidEnum() |
| 1525 | << "SHADER_STORAGE_BUFFER is not supported in GLES3."); |
Jiajia Qin | f546e7d | 2017-03-27 14:12:59 +0800 | [diff] [blame] | 1526 | return false; |
| 1527 | } |
| 1528 | if (index >= caps.maxShaderStorageBufferBindings) |
| 1529 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1530 | context->handleError(InvalidValue() << "index is greater than or equal to the " |
| 1531 | "number of SHADER_STORAGE_BUFFER " |
| 1532 | "indexed binding points."); |
Jiajia Qin | f546e7d | 2017-03-27 14:12:59 +0800 | [diff] [blame] | 1533 | return false; |
| 1534 | } |
| 1535 | if (buffer != 0 && (offset % caps.shaderStorageBufferOffsetAlignment) != 0) |
| 1536 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1537 | context->handleError(InvalidValue() << "offset must be multiple of value of " |
| 1538 | "SHADER_STORAGE_BUFFER_OFFSET_" |
| 1539 | "ALIGNMENT."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1540 | return false; |
| 1541 | } |
| 1542 | break; |
| 1543 | } |
| 1544 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1545 | context->handleError(InvalidEnum() << "the target is not supported."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1546 | return false; |
| 1547 | } |
| 1548 | |
| 1549 | return true; |
| 1550 | } |
| 1551 | |
| 1552 | bool ValidateBindBufferBase(Context *context, GLenum target, GLuint index, GLuint buffer) |
| 1553 | { |
| 1554 | return ValidateBindBufferCommon(context, target, index, buffer, 0, 0); |
| 1555 | } |
| 1556 | |
| 1557 | bool ValidateBindBufferRange(Context *context, |
| 1558 | GLenum target, |
| 1559 | GLuint index, |
| 1560 | GLuint buffer, |
| 1561 | GLintptr offset, |
| 1562 | GLsizeiptr size) |
| 1563 | { |
| 1564 | if (buffer != 0 && size <= 0) |
| 1565 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1566 | context->handleError(InvalidValue() |
| 1567 | << "buffer is non-zero and size is less than or equal to zero."); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 1568 | return false; |
| 1569 | } |
| 1570 | return ValidateBindBufferCommon(context, target, index, buffer, offset, size); |
| 1571 | } |
| 1572 | |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1573 | bool ValidateProgramBinary(Context *context, |
| 1574 | GLuint program, |
| 1575 | GLenum binaryFormat, |
| 1576 | const void *binary, |
| 1577 | GLint length) |
| 1578 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1579 | if (context->getClientMajorVersion() < 3) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1580 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1581 | context->handleError(InvalidOperation()); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1582 | return false; |
| 1583 | } |
| 1584 | |
| 1585 | return ValidateProgramBinaryBase(context, program, binaryFormat, binary, length); |
| 1586 | } |
| 1587 | |
| 1588 | bool ValidateGetProgramBinary(Context *context, |
| 1589 | GLuint program, |
| 1590 | GLsizei bufSize, |
| 1591 | GLsizei *length, |
| 1592 | GLenum *binaryFormat, |
| 1593 | void *binary) |
| 1594 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1595 | if (context->getClientMajorVersion() < 3) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1596 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1597 | context->handleError(InvalidOperation()); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1598 | return false; |
| 1599 | } |
| 1600 | |
| 1601 | return ValidateGetProgramBinaryBase(context, program, bufSize, length, binaryFormat, binary); |
| 1602 | } |
| 1603 | |
Olli Etuaho | f0fee07 | 2016-03-30 15:11:58 +0300 | [diff] [blame] | 1604 | bool ValidateProgramParameteri(Context *context, GLuint program, GLenum pname, GLint value) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1605 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1606 | if (context->getClientMajorVersion() < 3) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1607 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 1608 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1609 | return false; |
| 1610 | } |
| 1611 | |
| 1612 | if (GetValidProgram(context, program) == nullptr) |
| 1613 | { |
| 1614 | return false; |
| 1615 | } |
| 1616 | |
| 1617 | switch (pname) |
| 1618 | { |
| 1619 | case GL_PROGRAM_BINARY_RETRIEVABLE_HINT: |
Olli Etuaho | f0fee07 | 2016-03-30 15:11:58 +0300 | [diff] [blame] | 1620 | if (value != GL_FALSE && value != GL_TRUE) |
| 1621 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1622 | context->handleError(InvalidValue() |
| 1623 | << "Invalid value, expected GL_FALSE or GL_TRUE: " << value); |
Olli Etuaho | f0fee07 | 2016-03-30 15:11:58 +0300 | [diff] [blame] | 1624 | return false; |
| 1625 | } |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1626 | break; |
| 1627 | |
Yunchao He | 61afff1 | 2017-03-14 15:34:03 +0800 | [diff] [blame] | 1628 | case GL_PROGRAM_SEPARABLE: |
| 1629 | if (context->getClientVersion() < ES_3_1) |
| 1630 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1631 | context->handleError(InvalidEnum() |
| 1632 | << "PROGRAM_SEPARABLE is not supported before GLES 3.1"); |
Yunchao He | 61afff1 | 2017-03-14 15:34:03 +0800 | [diff] [blame] | 1633 | return false; |
| 1634 | } |
| 1635 | |
| 1636 | if (value != GL_FALSE && value != GL_TRUE) |
| 1637 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1638 | context->handleError(InvalidValue() |
| 1639 | << "Invalid value, expected GL_FALSE or GL_TRUE: " << value); |
Yunchao He | 61afff1 | 2017-03-14 15:34:03 +0800 | [diff] [blame] | 1640 | return false; |
| 1641 | } |
| 1642 | break; |
| 1643 | |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1644 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1645 | context->handleError(InvalidEnum() |
| 1646 | << "Invalid pname: 0x" << std::hex << std::uppercase << pname); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1647 | return false; |
| 1648 | } |
| 1649 | |
| 1650 | return true; |
| 1651 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1652 | |
| 1653 | bool ValidateBlitFramebuffer(Context *context, |
| 1654 | GLint srcX0, |
| 1655 | GLint srcY0, |
| 1656 | GLint srcX1, |
| 1657 | GLint srcY1, |
| 1658 | GLint dstX0, |
| 1659 | GLint dstY0, |
| 1660 | GLint dstX1, |
| 1661 | GLint dstY1, |
| 1662 | GLbitfield mask, |
| 1663 | GLenum filter) |
| 1664 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1665 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1666 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1667 | context->handleError(InvalidOperation()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1668 | return false; |
| 1669 | } |
| 1670 | |
| 1671 | return ValidateBlitFramebufferParameters(context, srcX0, srcY0, srcX1, srcY1, dstX0, dstY0, |
| 1672 | dstX1, dstY1, mask, filter); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1673 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1674 | |
| 1675 | bool ValidateClearBufferiv(ValidationContext *context, |
| 1676 | GLenum buffer, |
| 1677 | GLint drawbuffer, |
| 1678 | const GLint *value) |
| 1679 | { |
| 1680 | switch (buffer) |
| 1681 | { |
| 1682 | case GL_COLOR: |
| 1683 | if (drawbuffer < 0 || |
| 1684 | static_cast<GLuint>(drawbuffer) >= context->getCaps().maxDrawBuffers) |
| 1685 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1686 | context->handleError(InvalidValue()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1687 | return false; |
| 1688 | } |
Geoff Lang | 76e6565 | 2017-03-27 14:58:02 -0400 | [diff] [blame] | 1689 | if (context->getExtensions().webglCompatibility) |
| 1690 | { |
| 1691 | constexpr GLenum validComponentTypes[] = {GL_INT}; |
Geoff Lang | 0fb0864 | 2017-07-04 15:07:23 -0400 | [diff] [blame] | 1692 | if (!ValidateWebGLFramebufferAttachmentClearType( |
Geoff Lang | 76e6565 | 2017-03-27 14:58:02 -0400 | [diff] [blame] | 1693 | context, drawbuffer, validComponentTypes, ArraySize(validComponentTypes))) |
| 1694 | { |
| 1695 | return false; |
| 1696 | } |
| 1697 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1698 | break; |
| 1699 | |
| 1700 | case GL_STENCIL: |
| 1701 | if (drawbuffer != 0) |
| 1702 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1703 | context->handleError(InvalidValue()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1704 | return false; |
| 1705 | } |
| 1706 | break; |
| 1707 | |
| 1708 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1709 | context->handleError(InvalidEnum()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1710 | return false; |
| 1711 | } |
| 1712 | |
| 1713 | return ValidateClearBuffer(context); |
| 1714 | } |
| 1715 | |
| 1716 | bool ValidateClearBufferuiv(ValidationContext *context, |
| 1717 | GLenum buffer, |
| 1718 | GLint drawbuffer, |
| 1719 | const GLuint *value) |
| 1720 | { |
| 1721 | switch (buffer) |
| 1722 | { |
| 1723 | case GL_COLOR: |
| 1724 | if (drawbuffer < 0 || |
| 1725 | static_cast<GLuint>(drawbuffer) >= context->getCaps().maxDrawBuffers) |
| 1726 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1727 | context->handleError(InvalidValue()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1728 | return false; |
| 1729 | } |
Geoff Lang | 76e6565 | 2017-03-27 14:58:02 -0400 | [diff] [blame] | 1730 | if (context->getExtensions().webglCompatibility) |
| 1731 | { |
| 1732 | constexpr GLenum validComponentTypes[] = {GL_UNSIGNED_INT}; |
Geoff Lang | 0fb0864 | 2017-07-04 15:07:23 -0400 | [diff] [blame] | 1733 | if (!ValidateWebGLFramebufferAttachmentClearType( |
Geoff Lang | 76e6565 | 2017-03-27 14:58:02 -0400 | [diff] [blame] | 1734 | context, drawbuffer, validComponentTypes, ArraySize(validComponentTypes))) |
| 1735 | { |
| 1736 | return false; |
| 1737 | } |
| 1738 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1739 | break; |
| 1740 | |
| 1741 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1742 | context->handleError(InvalidEnum()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1743 | return false; |
| 1744 | } |
| 1745 | |
| 1746 | return ValidateClearBuffer(context); |
| 1747 | } |
| 1748 | |
| 1749 | bool ValidateClearBufferfv(ValidationContext *context, |
| 1750 | GLenum buffer, |
| 1751 | GLint drawbuffer, |
| 1752 | const GLfloat *value) |
| 1753 | { |
| 1754 | switch (buffer) |
| 1755 | { |
| 1756 | case GL_COLOR: |
| 1757 | if (drawbuffer < 0 || |
| 1758 | static_cast<GLuint>(drawbuffer) >= context->getCaps().maxDrawBuffers) |
| 1759 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1760 | context->handleError(InvalidValue()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1761 | return false; |
| 1762 | } |
Geoff Lang | 76e6565 | 2017-03-27 14:58:02 -0400 | [diff] [blame] | 1763 | if (context->getExtensions().webglCompatibility) |
| 1764 | { |
| 1765 | constexpr GLenum validComponentTypes[] = {GL_FLOAT, GL_UNSIGNED_NORMALIZED, |
| 1766 | GL_SIGNED_NORMALIZED}; |
Geoff Lang | 0fb0864 | 2017-07-04 15:07:23 -0400 | [diff] [blame] | 1767 | if (!ValidateWebGLFramebufferAttachmentClearType( |
Geoff Lang | 76e6565 | 2017-03-27 14:58:02 -0400 | [diff] [blame] | 1768 | context, drawbuffer, validComponentTypes, ArraySize(validComponentTypes))) |
| 1769 | { |
| 1770 | return false; |
| 1771 | } |
| 1772 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1773 | break; |
| 1774 | |
| 1775 | case GL_DEPTH: |
| 1776 | if (drawbuffer != 0) |
| 1777 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1778 | context->handleError(InvalidValue()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1779 | return false; |
| 1780 | } |
| 1781 | break; |
| 1782 | |
| 1783 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1784 | context->handleError(InvalidEnum()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1785 | return false; |
| 1786 | } |
| 1787 | |
| 1788 | return ValidateClearBuffer(context); |
| 1789 | } |
| 1790 | |
| 1791 | bool ValidateClearBufferfi(ValidationContext *context, |
| 1792 | GLenum buffer, |
| 1793 | GLint drawbuffer, |
| 1794 | GLfloat depth, |
| 1795 | GLint stencil) |
| 1796 | { |
| 1797 | switch (buffer) |
| 1798 | { |
| 1799 | case GL_DEPTH_STENCIL: |
| 1800 | if (drawbuffer != 0) |
| 1801 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1802 | context->handleError(InvalidValue()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1803 | return false; |
| 1804 | } |
| 1805 | break; |
| 1806 | |
| 1807 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1808 | context->handleError(InvalidEnum()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1809 | return false; |
| 1810 | } |
| 1811 | |
| 1812 | return ValidateClearBuffer(context); |
| 1813 | } |
| 1814 | |
| 1815 | bool ValidateDrawBuffers(ValidationContext *context, GLsizei n, const GLenum *bufs) |
| 1816 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1817 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1818 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 1819 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1820 | return false; |
| 1821 | } |
| 1822 | |
| 1823 | return ValidateDrawBuffersBase(context, n, bufs); |
| 1824 | } |
| 1825 | |
| 1826 | bool ValidateCopyTexSubImage3D(Context *context, |
| 1827 | GLenum target, |
| 1828 | GLint level, |
| 1829 | GLint xoffset, |
| 1830 | GLint yoffset, |
| 1831 | GLint zoffset, |
| 1832 | GLint x, |
| 1833 | GLint y, |
| 1834 | GLsizei width, |
| 1835 | GLsizei height) |
| 1836 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1837 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1838 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1839 | context->handleError(InvalidOperation()); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1840 | return false; |
| 1841 | } |
| 1842 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1843 | return ValidateES3CopyTexImage3DParameters(context, target, level, GL_NONE, true, xoffset, |
| 1844 | yoffset, zoffset, x, y, width, height, 0); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1845 | } |
| 1846 | |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1847 | bool ValidateTexImage3D(Context *context, |
| 1848 | GLenum target, |
| 1849 | GLint level, |
| 1850 | GLint internalformat, |
| 1851 | GLsizei width, |
| 1852 | GLsizei height, |
| 1853 | GLsizei depth, |
| 1854 | GLint border, |
| 1855 | GLenum format, |
| 1856 | GLenum type, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1857 | const void *pixels) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1858 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1859 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1860 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1861 | context->handleError(InvalidOperation()); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1862 | return false; |
| 1863 | } |
| 1864 | |
| 1865 | return ValidateES3TexImage3DParameters(context, target, level, internalformat, false, false, 0, |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1866 | 0, 0, width, height, depth, border, format, type, -1, |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1867 | pixels); |
| 1868 | } |
| 1869 | |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1870 | bool ValidateTexImage3DRobustANGLE(Context *context, |
| 1871 | GLenum target, |
| 1872 | GLint level, |
| 1873 | GLint internalformat, |
| 1874 | GLsizei width, |
| 1875 | GLsizei height, |
| 1876 | GLsizei depth, |
| 1877 | GLint border, |
| 1878 | GLenum format, |
| 1879 | GLenum type, |
| 1880 | GLsizei bufSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1881 | const void *pixels) |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1882 | { |
| 1883 | if (context->getClientMajorVersion() < 3) |
| 1884 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1885 | context->handleError(InvalidOperation()); |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1886 | return false; |
| 1887 | } |
| 1888 | |
| 1889 | if (!ValidateRobustEntryPoint(context, bufSize)) |
| 1890 | { |
| 1891 | return false; |
| 1892 | } |
| 1893 | |
| 1894 | return ValidateES3TexImage3DParameters(context, target, level, internalformat, false, false, 0, |
| 1895 | 0, 0, width, height, depth, border, format, type, |
| 1896 | bufSize, pixels); |
| 1897 | } |
| 1898 | |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1899 | bool ValidateTexSubImage3D(Context *context, |
| 1900 | GLenum target, |
| 1901 | GLint level, |
| 1902 | GLint xoffset, |
| 1903 | GLint yoffset, |
| 1904 | GLint zoffset, |
| 1905 | GLsizei width, |
| 1906 | GLsizei height, |
| 1907 | GLsizei depth, |
| 1908 | GLenum format, |
| 1909 | GLenum type, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1910 | const void *pixels) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1911 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1912 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1913 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1914 | context->handleError(InvalidOperation()); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1915 | return false; |
| 1916 | } |
| 1917 | |
| 1918 | return ValidateES3TexImage3DParameters(context, target, level, GL_NONE, false, true, xoffset, |
| 1919 | yoffset, zoffset, width, height, depth, 0, format, type, |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1920 | -1, pixels); |
| 1921 | } |
| 1922 | |
| 1923 | bool ValidateTexSubImage3DRobustANGLE(Context *context, |
| 1924 | GLenum target, |
| 1925 | GLint level, |
| 1926 | GLint xoffset, |
| 1927 | GLint yoffset, |
| 1928 | GLint zoffset, |
| 1929 | GLsizei width, |
| 1930 | GLsizei height, |
| 1931 | GLsizei depth, |
| 1932 | GLenum format, |
| 1933 | GLenum type, |
| 1934 | GLsizei bufSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1935 | const void *pixels) |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1936 | { |
| 1937 | if (context->getClientMajorVersion() < 3) |
| 1938 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1939 | context->handleError(InvalidOperation()); |
Geoff Lang | c52f6f1 | 2016-10-14 10:18:00 -0400 | [diff] [blame] | 1940 | return false; |
| 1941 | } |
| 1942 | |
| 1943 | if (!ValidateRobustEntryPoint(context, bufSize)) |
| 1944 | { |
| 1945 | return false; |
| 1946 | } |
| 1947 | |
| 1948 | return ValidateES3TexImage3DParameters(context, target, level, GL_NONE, false, true, xoffset, |
| 1949 | yoffset, zoffset, width, height, depth, 0, format, type, |
| 1950 | bufSize, pixels); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1951 | } |
| 1952 | |
| 1953 | bool ValidateCompressedTexSubImage3D(Context *context, |
| 1954 | GLenum target, |
| 1955 | GLint level, |
| 1956 | GLint xoffset, |
| 1957 | GLint yoffset, |
| 1958 | GLint zoffset, |
| 1959 | GLsizei width, |
| 1960 | GLsizei height, |
| 1961 | GLsizei depth, |
| 1962 | GLenum format, |
| 1963 | GLsizei imageSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 1964 | const void *data) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1965 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1966 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1967 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1968 | context->handleError(InvalidOperation()); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1969 | return false; |
| 1970 | } |
| 1971 | |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 1972 | const InternalFormat &formatInfo = GetSizedInternalFormatInfo(format); |
Geoff Lang | c5508d6 | 2017-02-10 14:58:38 -0500 | [diff] [blame] | 1973 | if (!formatInfo.compressed) |
| 1974 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1975 | context->handleError(InvalidEnum() << "Not a valid compressed texture format"); |
Geoff Lang | c5508d6 | 2017-02-10 14:58:38 -0500 | [diff] [blame] | 1976 | return false; |
| 1977 | } |
| 1978 | |
Jamie Madill | 513558d | 2016-06-02 13:04:11 -0400 | [diff] [blame] | 1979 | auto blockSizeOrErr = |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1980 | formatInfo.computeCompressedImageSize(GL_UNSIGNED_BYTE, gl::Extents(width, height, depth)); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1981 | if (blockSizeOrErr.isError()) |
| 1982 | { |
| 1983 | context->handleError(blockSizeOrErr.getError()); |
| 1984 | return false; |
| 1985 | } |
| 1986 | if (imageSize < 0 || static_cast<GLuint>(imageSize) != blockSizeOrErr.getResult()) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1987 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1988 | context->handleError(InvalidValue()); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1989 | return false; |
| 1990 | } |
| 1991 | |
| 1992 | if (!data) |
| 1993 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 1994 | context->handleError(InvalidValue()); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1995 | return false; |
| 1996 | } |
| 1997 | |
| 1998 | return ValidateES3TexImage3DParameters(context, target, level, GL_NONE, true, true, 0, 0, 0, |
Geoff Lang | 966c940 | 2017-04-18 12:38:27 -0400 | [diff] [blame] | 1999 | width, height, depth, 0, format, GL_NONE, -1, data); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 2000 | } |
Corentin Wallez | b293160 | 2017-04-11 15:58:57 -0400 | [diff] [blame] | 2001 | bool ValidateCompressedTexSubImage3DRobustANGLE(Context *context, |
| 2002 | GLenum target, |
| 2003 | GLint level, |
| 2004 | GLint xoffset, |
| 2005 | GLint yoffset, |
| 2006 | GLint zoffset, |
| 2007 | GLsizei width, |
| 2008 | GLsizei height, |
| 2009 | GLsizei depth, |
| 2010 | GLenum format, |
| 2011 | GLsizei imageSize, |
| 2012 | GLsizei dataSize, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 2013 | const void *data) |
Corentin Wallez | b293160 | 2017-04-11 15:58:57 -0400 | [diff] [blame] | 2014 | { |
| 2015 | if (!ValidateRobustCompressedTexImageBase(context, imageSize, dataSize)) |
| 2016 | { |
| 2017 | return false; |
| 2018 | } |
| 2019 | |
| 2020 | return ValidateCompressedTexSubImage3D(context, target, level, xoffset, yoffset, zoffset, width, |
| 2021 | height, depth, format, imageSize, data); |
| 2022 | } |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 2023 | |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2024 | bool ValidateGenQueries(Context *context, GLint n, GLuint *) |
| 2025 | { |
| 2026 | return ValidateGenOrDeleteES3(context, n); |
| 2027 | } |
| 2028 | |
| 2029 | bool ValidateDeleteQueries(Context *context, GLint n, const GLuint *) |
| 2030 | { |
| 2031 | return ValidateGenOrDeleteES3(context, n); |
| 2032 | } |
| 2033 | |
| 2034 | bool ValidateGenSamplers(Context *context, GLint count, GLuint *) |
| 2035 | { |
| 2036 | return ValidateGenOrDeleteCountES3(context, count); |
| 2037 | } |
| 2038 | |
| 2039 | bool ValidateDeleteSamplers(Context *context, GLint count, const GLuint *) |
| 2040 | { |
| 2041 | return ValidateGenOrDeleteCountES3(context, count); |
| 2042 | } |
| 2043 | |
| 2044 | bool ValidateGenTransformFeedbacks(Context *context, GLint n, GLuint *) |
| 2045 | { |
| 2046 | return ValidateGenOrDeleteES3(context, n); |
| 2047 | } |
| 2048 | |
| 2049 | bool ValidateDeleteTransformFeedbacks(Context *context, GLint n, const GLuint *ids) |
| 2050 | { |
| 2051 | if (!ValidateGenOrDeleteES3(context, n)) |
| 2052 | { |
| 2053 | return false; |
| 2054 | } |
| 2055 | for (GLint i = 0; i < n; ++i) |
| 2056 | { |
| 2057 | auto *transformFeedback = context->getTransformFeedback(ids[i]); |
| 2058 | if (transformFeedback != nullptr && transformFeedback->isActive()) |
| 2059 | { |
| 2060 | // ES 3.0.4 section 2.15.1 page 86 |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2061 | context->handleError(InvalidOperation() |
| 2062 | << "Attempt to delete active transform feedback."); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2063 | return false; |
| 2064 | } |
| 2065 | } |
| 2066 | return true; |
| 2067 | } |
| 2068 | |
| 2069 | bool ValidateGenVertexArrays(Context *context, GLint n, GLuint *) |
| 2070 | { |
| 2071 | return ValidateGenOrDeleteES3(context, n); |
| 2072 | } |
| 2073 | |
| 2074 | bool ValidateDeleteVertexArrays(Context *context, GLint n, const GLuint *) |
| 2075 | { |
| 2076 | return ValidateGenOrDeleteES3(context, n); |
| 2077 | } |
| 2078 | |
| 2079 | bool ValidateGenOrDeleteES3(Context *context, GLint n) |
| 2080 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2081 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2082 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2083 | context->handleError(InvalidOperation() << "Context does not support GLES3."); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2084 | return false; |
| 2085 | } |
| 2086 | return ValidateGenOrDelete(context, n); |
| 2087 | } |
| 2088 | |
| 2089 | bool ValidateGenOrDeleteCountES3(Context *context, GLint count) |
| 2090 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2091 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2092 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2093 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2094 | return false; |
| 2095 | } |
| 2096 | if (count < 0) |
| 2097 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2098 | context->handleError(InvalidValue() << "count < 0"); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2099 | return false; |
| 2100 | } |
| 2101 | return true; |
| 2102 | } |
| 2103 | |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2104 | bool ValidateBeginTransformFeedback(Context *context, GLenum primitiveMode) |
| 2105 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2106 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2107 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2108 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2109 | return false; |
| 2110 | } |
| 2111 | switch (primitiveMode) |
| 2112 | { |
| 2113 | case GL_TRIANGLES: |
| 2114 | case GL_LINES: |
| 2115 | case GL_POINTS: |
| 2116 | break; |
| 2117 | |
| 2118 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2119 | context->handleError(InvalidEnum() << "Invalid primitive mode."); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2120 | return false; |
| 2121 | } |
| 2122 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 2123 | TransformFeedback *transformFeedback = context->getGLState().getCurrentTransformFeedback(); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2124 | ASSERT(transformFeedback != nullptr); |
| 2125 | |
| 2126 | if (transformFeedback->isActive()) |
| 2127 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2128 | context->handleError(InvalidOperation() << "Transform feedback is already active."); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2129 | return false; |
| 2130 | } |
Geoff Lang | 79f7104 | 2017-08-14 16:43:43 -0400 | [diff] [blame] | 2131 | |
| 2132 | for (size_t i = 0; i < transformFeedback->getIndexedBufferCount(); i++) |
| 2133 | { |
| 2134 | const auto &buffer = transformFeedback->getIndexedBuffer(i); |
| 2135 | if (buffer.get() && buffer->isMapped()) |
| 2136 | { |
| 2137 | context->handleError(InvalidOperation() << "Transform feedback has a mapped buffer."); |
| 2138 | return false; |
| 2139 | } |
| 2140 | } |
| 2141 | |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2142 | return true; |
| 2143 | } |
| 2144 | |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 2145 | bool ValidateGetBufferPointerv(Context *context, GLenum target, GLenum pname, void **params) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2146 | { |
Geoff Lang | 496c02d | 2016-10-20 11:38:11 -0700 | [diff] [blame] | 2147 | return ValidateGetBufferPointervBase(context, target, pname, nullptr, params); |
| 2148 | } |
| 2149 | |
| 2150 | bool ValidateGetBufferPointervRobustANGLE(Context *context, |
| 2151 | GLenum target, |
| 2152 | GLenum pname, |
| 2153 | GLsizei bufSize, |
| 2154 | GLsizei *length, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 2155 | void **params) |
Geoff Lang | 496c02d | 2016-10-20 11:38:11 -0700 | [diff] [blame] | 2156 | { |
| 2157 | if (!ValidateRobustEntryPoint(context, bufSize)) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2158 | { |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2159 | return false; |
| 2160 | } |
| 2161 | |
Geoff Lang | 496c02d | 2016-10-20 11:38:11 -0700 | [diff] [blame] | 2162 | if (!ValidateGetBufferPointervBase(context, target, pname, length, params)) |
| 2163 | { |
| 2164 | return false; |
| 2165 | } |
| 2166 | |
| 2167 | if (!ValidateRobustBufferSize(context, bufSize, *length)) |
| 2168 | { |
| 2169 | return false; |
| 2170 | } |
| 2171 | |
| 2172 | return true; |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2173 | } |
| 2174 | |
| 2175 | bool ValidateUnmapBuffer(Context *context, GLenum target) |
| 2176 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2177 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2178 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2179 | context->handleError(InvalidOperation()); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2180 | return false; |
| 2181 | } |
| 2182 | |
| 2183 | return ValidateUnmapBufferBase(context, target); |
| 2184 | } |
| 2185 | |
| 2186 | bool ValidateMapBufferRange(Context *context, |
| 2187 | GLenum target, |
| 2188 | GLintptr offset, |
| 2189 | GLsizeiptr length, |
| 2190 | GLbitfield access) |
| 2191 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2192 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2193 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2194 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2195 | return false; |
| 2196 | } |
| 2197 | |
| 2198 | return ValidateMapBufferRangeBase(context, target, offset, length, access); |
| 2199 | } |
| 2200 | |
| 2201 | bool ValidateFlushMappedBufferRange(Context *context, |
| 2202 | GLenum target, |
| 2203 | GLintptr offset, |
| 2204 | GLsizeiptr length) |
| 2205 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2206 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2207 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2208 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2209 | return false; |
| 2210 | } |
| 2211 | |
| 2212 | return ValidateFlushMappedBufferRangeBase(context, target, offset, length); |
| 2213 | } |
| 2214 | |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2215 | bool ValidateIndexedStateQuery(ValidationContext *context, |
| 2216 | GLenum pname, |
| 2217 | GLuint index, |
| 2218 | GLsizei *length) |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2219 | { |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2220 | if (length) |
| 2221 | { |
| 2222 | *length = 0; |
| 2223 | } |
| 2224 | |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2225 | GLenum nativeType; |
| 2226 | unsigned int numParams; |
| 2227 | if (!context->getIndexedQueryParameterInfo(pname, &nativeType, &numParams)) |
| 2228 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2229 | context->handleError(InvalidEnum()); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2230 | return false; |
| 2231 | } |
| 2232 | |
| 2233 | const Caps &caps = context->getCaps(); |
| 2234 | switch (pname) |
| 2235 | { |
| 2236 | case GL_TRANSFORM_FEEDBACK_BUFFER_START: |
| 2237 | case GL_TRANSFORM_FEEDBACK_BUFFER_SIZE: |
| 2238 | case GL_TRANSFORM_FEEDBACK_BUFFER_BINDING: |
| 2239 | if (index >= caps.maxTransformFeedbackSeparateAttributes) |
| 2240 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2241 | context->handleError(InvalidValue()); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2242 | return false; |
| 2243 | } |
| 2244 | break; |
| 2245 | |
| 2246 | case GL_UNIFORM_BUFFER_START: |
| 2247 | case GL_UNIFORM_BUFFER_SIZE: |
| 2248 | case GL_UNIFORM_BUFFER_BINDING: |
| 2249 | if (index >= caps.maxUniformBufferBindings) |
| 2250 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2251 | context->handleError(InvalidValue()); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2252 | return false; |
| 2253 | } |
| 2254 | break; |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2255 | |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2256 | case GL_MAX_COMPUTE_WORK_GROUP_SIZE: |
| 2257 | case GL_MAX_COMPUTE_WORK_GROUP_COUNT: |
| 2258 | if (index >= 3u) |
| 2259 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2260 | context->handleError(InvalidValue()); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2261 | return false; |
| 2262 | } |
| 2263 | break; |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2264 | |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 2265 | case GL_ATOMIC_COUNTER_BUFFER_START: |
| 2266 | case GL_ATOMIC_COUNTER_BUFFER_SIZE: |
| 2267 | case GL_ATOMIC_COUNTER_BUFFER_BINDING: |
| 2268 | if (context->getClientVersion() < ES_3_1) |
| 2269 | { |
| 2270 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2271 | InvalidEnum() |
| 2272 | << "Atomic Counter buffers are not supported in this version of GL"); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 2273 | return false; |
| 2274 | } |
| 2275 | if (index >= caps.maxAtomicCounterBufferBindings) |
| 2276 | { |
| 2277 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2278 | InvalidValue() |
| 2279 | << "index is outside the valid range for GL_ATOMIC_COUNTER_BUFFER_BINDING"); |
Jiajia Qin | 6eafb04 | 2016-12-27 17:04:07 +0800 | [diff] [blame] | 2280 | return false; |
| 2281 | } |
| 2282 | break; |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2283 | |
Jiajia Qin | f546e7d | 2017-03-27 14:12:59 +0800 | [diff] [blame] | 2284 | case GL_SHADER_STORAGE_BUFFER_START: |
| 2285 | case GL_SHADER_STORAGE_BUFFER_SIZE: |
| 2286 | case GL_SHADER_STORAGE_BUFFER_BINDING: |
| 2287 | if (context->getClientVersion() < ES_3_1) |
| 2288 | { |
| 2289 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2290 | InvalidEnum() |
| 2291 | << "Shader storage buffers are not supported in this version of GL"); |
Jiajia Qin | f546e7d | 2017-03-27 14:12:59 +0800 | [diff] [blame] | 2292 | return false; |
| 2293 | } |
| 2294 | if (index >= caps.maxShaderStorageBufferBindings) |
| 2295 | { |
| 2296 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2297 | InvalidValue() |
| 2298 | << "index is outside the valid range for GL_SHADER_STORAGE_BUFFER_BINDING"); |
Jiajia Qin | f546e7d | 2017-03-27 14:12:59 +0800 | [diff] [blame] | 2299 | return false; |
| 2300 | } |
| 2301 | break; |
| 2302 | |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2303 | case GL_VERTEX_BINDING_BUFFER: |
| 2304 | case GL_VERTEX_BINDING_DIVISOR: |
| 2305 | case GL_VERTEX_BINDING_OFFSET: |
| 2306 | case GL_VERTEX_BINDING_STRIDE: |
| 2307 | if (context->getClientVersion() < ES_3_1) |
| 2308 | { |
| 2309 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2310 | InvalidEnum() |
| 2311 | << "Vertex Attrib Bindings are not supported in this version of GL"); |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2312 | return false; |
| 2313 | } |
| 2314 | if (index >= caps.maxVertexAttribBindings) |
| 2315 | { |
| 2316 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2317 | InvalidValue() |
| 2318 | << "bindingindex must be smaller than MAX_VERTEX_ATTRIB_BINDINGS."); |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2319 | return false; |
| 2320 | } |
| 2321 | break; |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2322 | default: |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2323 | context->handleError(InvalidEnum()); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2324 | return false; |
| 2325 | } |
| 2326 | |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2327 | if (length) |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2328 | { |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2329 | *length = 1; |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2330 | } |
| 2331 | |
| 2332 | return true; |
| 2333 | } |
| 2334 | |
| 2335 | bool ValidateGetIntegeri_v(ValidationContext *context, GLenum target, GLuint index, GLint *data) |
| 2336 | { |
Geoff Lang | eb66a6e | 2016-10-31 13:06:12 -0400 | [diff] [blame] | 2337 | if (context->getClientVersion() < ES_3_0) |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2338 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2339 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2340 | return false; |
| 2341 | } |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2342 | return ValidateIndexedStateQuery(context, target, index, nullptr); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2343 | } |
| 2344 | |
Geoff Lang | cf255ea | 2016-10-20 11:39:09 -0700 | [diff] [blame] | 2345 | bool ValidateGetIntegeri_vRobustANGLE(ValidationContext *context, |
| 2346 | GLenum target, |
| 2347 | GLuint index, |
| 2348 | GLsizei bufSize, |
| 2349 | GLsizei *length, |
| 2350 | GLint *data) |
| 2351 | { |
Geoff Lang | eb66a6e | 2016-10-31 13:06:12 -0400 | [diff] [blame] | 2352 | if (context->getClientVersion() < ES_3_0) |
Geoff Lang | cf255ea | 2016-10-20 11:39:09 -0700 | [diff] [blame] | 2353 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2354 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Geoff Lang | cf255ea | 2016-10-20 11:39:09 -0700 | [diff] [blame] | 2355 | return false; |
| 2356 | } |
| 2357 | |
| 2358 | if (!ValidateRobustEntryPoint(context, bufSize)) |
| 2359 | { |
| 2360 | return false; |
| 2361 | } |
| 2362 | |
| 2363 | if (!ValidateIndexedStateQuery(context, target, index, length)) |
| 2364 | { |
| 2365 | return false; |
| 2366 | } |
| 2367 | |
| 2368 | if (!ValidateRobustBufferSize(context, bufSize, *length)) |
| 2369 | { |
| 2370 | return false; |
| 2371 | } |
| 2372 | |
| 2373 | return true; |
| 2374 | } |
| 2375 | |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2376 | bool ValidateGetInteger64i_v(ValidationContext *context, GLenum target, GLuint index, GLint64 *data) |
| 2377 | { |
Geoff Lang | eb66a6e | 2016-10-31 13:06:12 -0400 | [diff] [blame] | 2378 | if (context->getClientVersion() < ES_3_0) |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2379 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2380 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2381 | return false; |
| 2382 | } |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2383 | return ValidateIndexedStateQuery(context, target, index, nullptr); |
| 2384 | } |
| 2385 | |
| 2386 | bool ValidateGetInteger64i_vRobustANGLE(ValidationContext *context, |
| 2387 | GLenum target, |
| 2388 | GLuint index, |
| 2389 | GLsizei bufSize, |
| 2390 | GLsizei *length, |
| 2391 | GLint64 *data) |
| 2392 | { |
Geoff Lang | eb66a6e | 2016-10-31 13:06:12 -0400 | [diff] [blame] | 2393 | if (context->getClientVersion() < ES_3_0) |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2394 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2395 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Geoff Lang | 2e43dbb | 2016-10-14 12:27:35 -0400 | [diff] [blame] | 2396 | return false; |
| 2397 | } |
| 2398 | |
| 2399 | if (!ValidateRobustEntryPoint(context, bufSize)) |
| 2400 | { |
| 2401 | return false; |
| 2402 | } |
| 2403 | |
| 2404 | if (!ValidateIndexedStateQuery(context, target, index, length)) |
| 2405 | { |
| 2406 | return false; |
| 2407 | } |
| 2408 | |
| 2409 | if (!ValidateRobustBufferSize(context, bufSize, *length)) |
| 2410 | { |
| 2411 | return false; |
| 2412 | } |
| 2413 | |
| 2414 | return true; |
Martin Radev | 66fb820 | 2016-07-28 11:45:20 +0300 | [diff] [blame] | 2415 | } |
| 2416 | |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2417 | bool ValidateCopyBufferSubData(ValidationContext *context, |
| 2418 | GLenum readTarget, |
| 2419 | GLenum writeTarget, |
| 2420 | GLintptr readOffset, |
| 2421 | GLintptr writeOffset, |
| 2422 | GLsizeiptr size) |
| 2423 | { |
| 2424 | if (context->getClientMajorVersion() < 3) |
| 2425 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2426 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2427 | return false; |
| 2428 | } |
| 2429 | |
| 2430 | if (!ValidBufferTarget(context, readTarget) || !ValidBufferTarget(context, writeTarget)) |
| 2431 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2432 | context->handleError(InvalidEnum() << "Invalid buffer target"); |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2433 | return false; |
| 2434 | } |
| 2435 | |
| 2436 | Buffer *readBuffer = context->getGLState().getTargetBuffer(readTarget); |
| 2437 | Buffer *writeBuffer = context->getGLState().getTargetBuffer(writeTarget); |
| 2438 | |
| 2439 | if (!readBuffer || !writeBuffer) |
| 2440 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2441 | context->handleError(InvalidOperation() << "No buffer bound to target"); |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2442 | return false; |
| 2443 | } |
| 2444 | |
| 2445 | // Verify that readBuffer and writeBuffer are not currently mapped |
| 2446 | if (readBuffer->isMapped() || writeBuffer->isMapped()) |
| 2447 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2448 | context->handleError(InvalidOperation() |
| 2449 | << "Cannot call CopyBufferSubData on a mapped buffer"); |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2450 | return false; |
| 2451 | } |
| 2452 | |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 2453 | CheckedNumeric<GLintptr> checkedReadOffset(readOffset); |
| 2454 | CheckedNumeric<GLintptr> checkedWriteOffset(writeOffset); |
| 2455 | CheckedNumeric<GLintptr> checkedSize(size); |
| 2456 | |
| 2457 | auto checkedReadSum = checkedReadOffset + checkedSize; |
| 2458 | auto checkedWriteSum = checkedWriteOffset + checkedSize; |
| 2459 | |
| 2460 | if (!checkedReadSum.IsValid() || !checkedWriteSum.IsValid() || |
| 2461 | !IsValueInRangeForNumericType<GLintptr>(readBuffer->getSize()) || |
| 2462 | !IsValueInRangeForNumericType<GLintptr>(writeBuffer->getSize())) |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2463 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2464 | context->handleError(InvalidValue() << "Integer overflow when validating copy offsets."); |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2465 | return false; |
| 2466 | } |
| 2467 | |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 2468 | if (readOffset < 0 || writeOffset < 0 || size < 0) |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2469 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2470 | context->handleError(InvalidValue() |
| 2471 | << "readOffset, writeOffset and size must all be non-negative"); |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2472 | return false; |
| 2473 | } |
| 2474 | |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 2475 | if (checkedReadSum.ValueOrDie() > readBuffer->getSize() || |
| 2476 | checkedWriteSum.ValueOrDie() > writeBuffer->getSize()) |
| 2477 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2478 | context->handleError(InvalidValue() << "Buffer offset overflow in CopyBufferSubData"); |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 2479 | return false; |
| 2480 | } |
| 2481 | |
| 2482 | if (readBuffer == writeBuffer) |
| 2483 | { |
| 2484 | auto checkedOffsetDiff = (checkedReadOffset - checkedWriteOffset).Abs(); |
| 2485 | if (!checkedOffsetDiff.IsValid()) |
| 2486 | { |
| 2487 | // This shold not be possible. |
| 2488 | UNREACHABLE(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2489 | context->handleError(InvalidValue() |
| 2490 | << "Integer overflow when validating same buffer copy."); |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 2491 | return false; |
| 2492 | } |
| 2493 | |
| 2494 | if (checkedOffsetDiff.ValueOrDie() < size) |
| 2495 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2496 | context->handleError(InvalidValue()); |
Jamie Madill | d2f0c74 | 2016-11-02 10:34:41 -0400 | [diff] [blame] | 2497 | return false; |
| 2498 | } |
| 2499 | } |
| 2500 | |
Jamie Madill | b0817d1 | 2016-11-01 15:48:31 -0400 | [diff] [blame] | 2501 | return true; |
| 2502 | } |
| 2503 | |
Geoff Lang | c339c4e | 2016-11-29 10:37:36 -0500 | [diff] [blame] | 2504 | bool ValidateGetStringi(Context *context, GLenum name, GLuint index) |
| 2505 | { |
| 2506 | if (context->getClientMajorVersion() < 3) |
| 2507 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2508 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Geoff Lang | c339c4e | 2016-11-29 10:37:36 -0500 | [diff] [blame] | 2509 | return false; |
| 2510 | } |
| 2511 | |
| 2512 | switch (name) |
| 2513 | { |
| 2514 | case GL_EXTENSIONS: |
| 2515 | if (index >= context->getExtensionStringCount()) |
| 2516 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2517 | context->handleError(InvalidValue() |
| 2518 | << "index must be less than the number of extension strings."); |
Geoff Lang | c339c4e | 2016-11-29 10:37:36 -0500 | [diff] [blame] | 2519 | return false; |
| 2520 | } |
| 2521 | break; |
| 2522 | |
| 2523 | case GL_REQUESTABLE_EXTENSIONS_ANGLE: |
| 2524 | if (!context->getExtensions().requestExtension) |
| 2525 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2526 | ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidName); |
Geoff Lang | c339c4e | 2016-11-29 10:37:36 -0500 | [diff] [blame] | 2527 | return false; |
| 2528 | } |
| 2529 | if (index >= context->getRequestableExtensionStringCount()) |
| 2530 | { |
| 2531 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2532 | InvalidValue() |
| 2533 | << "index must be less than the number of requestable extension strings."); |
Geoff Lang | c339c4e | 2016-11-29 10:37:36 -0500 | [diff] [blame] | 2534 | return false; |
| 2535 | } |
| 2536 | break; |
| 2537 | |
| 2538 | default: |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2539 | ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidName); |
Geoff Lang | c339c4e | 2016-11-29 10:37:36 -0500 | [diff] [blame] | 2540 | return false; |
| 2541 | } |
| 2542 | |
| 2543 | return true; |
| 2544 | } |
| 2545 | |
Jamie Madill | e8fb640 | 2017-02-14 17:56:40 -0500 | [diff] [blame] | 2546 | bool ValidateRenderbufferStorageMultisample(ValidationContext *context, |
| 2547 | GLenum target, |
| 2548 | GLsizei samples, |
| 2549 | GLenum internalformat, |
| 2550 | GLsizei width, |
| 2551 | GLsizei height) |
| 2552 | { |
| 2553 | if (context->getClientMajorVersion() < 3) |
| 2554 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2555 | context->handleError(InvalidOperation()); |
Jamie Madill | e8fb640 | 2017-02-14 17:56:40 -0500 | [diff] [blame] | 2556 | return false; |
| 2557 | } |
| 2558 | |
| 2559 | if (!ValidateRenderbufferStorageParametersBase(context, target, samples, internalformat, width, |
| 2560 | height)) |
| 2561 | { |
| 2562 | return false; |
| 2563 | } |
| 2564 | |
| 2565 | // The ES3 spec(section 4.4.2) states that the internal format must be sized and not an integer |
| 2566 | // format if samples is greater than zero. |
Geoff Lang | ca27139 | 2017-04-05 12:30:00 -0400 | [diff] [blame] | 2567 | const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalformat); |
Jamie Madill | e8fb640 | 2017-02-14 17:56:40 -0500 | [diff] [blame] | 2568 | if ((formatInfo.componentType == GL_UNSIGNED_INT || formatInfo.componentType == GL_INT) && |
| 2569 | samples > 0) |
| 2570 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2571 | context->handleError(InvalidOperation()); |
Jamie Madill | e8fb640 | 2017-02-14 17:56:40 -0500 | [diff] [blame] | 2572 | return false; |
| 2573 | } |
| 2574 | |
| 2575 | // The behavior is different than the ANGLE version, which would generate a GL_OUT_OF_MEMORY. |
| 2576 | const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat); |
| 2577 | if (static_cast<GLuint>(samples) > formatCaps.getMaxSamples()) |
| 2578 | { |
| 2579 | context->handleError( |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2580 | InvalidOperation() |
| 2581 | << "Samples must not be greater than maximum supported value for the format."); |
Jamie Madill | e8fb640 | 2017-02-14 17:56:40 -0500 | [diff] [blame] | 2582 | return false; |
| 2583 | } |
| 2584 | |
| 2585 | return true; |
| 2586 | } |
| 2587 | |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2588 | bool ValidateVertexAttribIPointer(ValidationContext *context, |
| 2589 | GLuint index, |
| 2590 | GLint size, |
| 2591 | GLenum type, |
| 2592 | GLsizei stride, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 2593 | const void *pointer) |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2594 | { |
| 2595 | if (context->getClientMajorVersion() < 3) |
| 2596 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2597 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2598 | return false; |
| 2599 | } |
| 2600 | |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2601 | if (!ValidateVertexFormatBase(context, index, size, type, true)) |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2602 | { |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2603 | return false; |
| 2604 | } |
| 2605 | |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2606 | if (stride < 0) |
| 2607 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2608 | ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStride); |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2609 | return false; |
| 2610 | } |
| 2611 | |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2612 | const Caps &caps = context->getCaps(); |
| 2613 | if (context->getClientVersion() >= ES_3_1) |
| 2614 | { |
| 2615 | if (stride > caps.maxVertexAttribStride) |
| 2616 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2617 | context->handleError(InvalidValue() |
| 2618 | << "stride cannot be greater than MAX_VERTEX_ATTRIB_STRIDE."); |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2619 | return false; |
| 2620 | } |
| 2621 | |
| 2622 | // [OpenGL ES 3.1] Section 10.3.1 page 245: |
| 2623 | // glVertexAttribBinding is part of the equivalent code of VertexAttribIPointer, so its |
| 2624 | // validation should be inherited. |
| 2625 | if (index >= caps.maxVertexAttribBindings) |
| 2626 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2627 | context->handleError(InvalidValue() |
| 2628 | << "index must be smaller than MAX_VERTEX_ATTRIB_BINDINGS."); |
Shao | 80957d9 | 2017-02-20 21:25:59 +0800 | [diff] [blame] | 2629 | return false; |
| 2630 | } |
| 2631 | } |
| 2632 | |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2633 | // [OpenGL ES 3.0.2] Section 2.8 page 24: |
| 2634 | // An INVALID_OPERATION error is generated when a non-zero vertex array object |
| 2635 | // is bound, zero is bound to the ARRAY_BUFFER buffer object binding point, |
| 2636 | // and the pointer argument is not NULL. |
| 2637 | if (context->getGLState().getVertexArrayId() != 0 && |
| 2638 | context->getGLState().getArrayBufferId() == 0 && pointer != nullptr) |
| 2639 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2640 | context |
| 2641 | ->handleError(InvalidOperation() |
| 2642 | << "Client data cannot be used with a non-default vertex array object."); |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2643 | return false; |
| 2644 | } |
| 2645 | |
Geoff Lang | 2d62ab7 | 2017-03-23 16:54:40 -0400 | [diff] [blame] | 2646 | if (context->getExtensions().webglCompatibility) |
| 2647 | { |
| 2648 | if (!ValidateWebGLVertexAttribPointer(context, type, false, stride, pointer, true)) |
| 2649 | { |
| 2650 | return false; |
| 2651 | } |
| 2652 | } |
| 2653 | |
Geoff Lang | aa086d6 | 2017-03-23 16:47:21 -0400 | [diff] [blame] | 2654 | return true; |
| 2655 | } |
| 2656 | |
Geoff Lang | 38f2cfb | 2017-04-11 15:23:08 -0400 | [diff] [blame] | 2657 | bool ValidateGetSynciv(Context *context, |
| 2658 | GLsync sync, |
| 2659 | GLenum pname, |
| 2660 | GLsizei bufSize, |
| 2661 | GLsizei *length, |
| 2662 | GLint *values) |
| 2663 | { |
| 2664 | if (context->getClientMajorVersion() < 3) |
| 2665 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2666 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
Geoff Lang | 38f2cfb | 2017-04-11 15:23:08 -0400 | [diff] [blame] | 2667 | return false; |
| 2668 | } |
| 2669 | |
| 2670 | if (bufSize < 0) |
| 2671 | { |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2672 | ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize); |
Geoff Lang | 38f2cfb | 2017-04-11 15:23:08 -0400 | [diff] [blame] | 2673 | return false; |
| 2674 | } |
| 2675 | |
Jamie Madill | 70b5bb0 | 2017-08-28 13:32:37 -0400 | [diff] [blame^] | 2676 | Sync *syncObject = context->getSync(sync); |
| 2677 | if (!syncObject) |
Geoff Lang | 38f2cfb | 2017-04-11 15:23:08 -0400 | [diff] [blame] | 2678 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2679 | context->handleError(InvalidValue() << "Invalid sync object."); |
Geoff Lang | 38f2cfb | 2017-04-11 15:23:08 -0400 | [diff] [blame] | 2680 | return false; |
| 2681 | } |
| 2682 | |
| 2683 | switch (pname) |
| 2684 | { |
| 2685 | case GL_OBJECT_TYPE: |
| 2686 | case GL_SYNC_CONDITION: |
| 2687 | case GL_SYNC_FLAGS: |
| 2688 | case GL_SYNC_STATUS: |
| 2689 | break; |
| 2690 | |
| 2691 | default: |
Brandon Jones | afa7515 | 2017-07-21 13:11:29 -0700 | [diff] [blame] | 2692 | ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname); |
Geoff Lang | 38f2cfb | 2017-04-11 15:23:08 -0400 | [diff] [blame] | 2693 | return false; |
| 2694 | } |
| 2695 | |
| 2696 | return true; |
| 2697 | } |
| 2698 | |
Jamie Madill | 9c9b40a | 2017-04-26 16:31:57 -0400 | [diff] [blame] | 2699 | bool ValidateDrawElementsInstanced(ValidationContext *context, |
| 2700 | GLenum mode, |
| 2701 | GLsizei count, |
| 2702 | GLenum type, |
Jamie Madill | 876429b | 2017-04-20 15:46:24 -0400 | [diff] [blame] | 2703 | const void *indices, |
Jamie Madill | 9c9b40a | 2017-04-26 16:31:57 -0400 | [diff] [blame] | 2704 | GLsizei instanceCount) |
| 2705 | { |
| 2706 | if (context->getClientMajorVersion() < 3) |
| 2707 | { |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 2708 | context->handleError(InvalidOperation() << "Requires a GLES 3.0 or higher context."); |
Jamie Madill | 9c9b40a | 2017-04-26 16:31:57 -0400 | [diff] [blame] | 2709 | return false; |
| 2710 | } |
| 2711 | |
| 2712 | return ValidateDrawElementsInstancedCommon(context, mode, count, type, indices, instanceCount); |
| 2713 | } |
| 2714 | |
Martin Radev | 137032d | 2017-07-13 10:11:12 +0300 | [diff] [blame] | 2715 | bool ValidateFramebufferTextureMultiviewLayeredANGLE(Context *context, |
| 2716 | GLenum target, |
| 2717 | GLenum attachment, |
| 2718 | GLuint texture, |
| 2719 | GLint level, |
| 2720 | GLint baseViewIndex, |
| 2721 | GLsizei numViews) |
| 2722 | { |
| 2723 | |
| 2724 | if (!ValidateFramebufferTextureMultiviewBaseANGLE(context, target, attachment, texture, level, |
| 2725 | numViews)) |
| 2726 | { |
| 2727 | return false; |
| 2728 | } |
| 2729 | |
| 2730 | if (baseViewIndex < 0) |
| 2731 | { |
| 2732 | context->handleError(InvalidValue() << "baseViewIndex cannot be less than 0."); |
| 2733 | return false; |
| 2734 | } |
| 2735 | |
| 2736 | if (texture != 0) |
| 2737 | { |
| 2738 | Texture *tex = context->getTexture(texture); |
| 2739 | ASSERT(tex); |
| 2740 | |
| 2741 | switch (tex->getTarget()) |
| 2742 | { |
| 2743 | case GL_TEXTURE_2D_ARRAY: |
| 2744 | { |
| 2745 | const Caps &caps = context->getCaps(); |
| 2746 | if (static_cast<GLuint>(baseViewIndex + numViews) > caps.maxArrayTextureLayers) |
| 2747 | { |
| 2748 | context->handleError(InvalidValue() << "baseViewIndex+numViews cannot be " |
| 2749 | "greater than " |
| 2750 | "GL_MAX_ARRAY_TEXTURE_LAYERS."); |
| 2751 | return false; |
| 2752 | } |
| 2753 | } |
| 2754 | break; |
| 2755 | default: |
| 2756 | context->handleError(InvalidOperation() |
| 2757 | << "Texture's target must be GL_TEXTURE_2D_ARRAY."); |
| 2758 | return false; |
| 2759 | } |
| 2760 | |
| 2761 | if (!ValidateFramebufferTextureMultiviewLevelAndFormat(context, tex, level)) |
| 2762 | { |
| 2763 | return false; |
| 2764 | } |
| 2765 | } |
| 2766 | |
| 2767 | return true; |
| 2768 | } |
| 2769 | |
| 2770 | bool ValidateFramebufferTextureMultiviewSideBySideANGLE(Context *context, |
| 2771 | GLenum target, |
| 2772 | GLenum attachment, |
| 2773 | GLuint texture, |
| 2774 | GLint level, |
| 2775 | GLsizei numViews, |
| 2776 | const GLint *viewportOffsets) |
| 2777 | { |
| 2778 | if (!ValidateFramebufferTextureMultiviewBaseANGLE(context, target, attachment, texture, level, |
| 2779 | numViews)) |
| 2780 | { |
| 2781 | return false; |
| 2782 | } |
| 2783 | |
| 2784 | const GLsizei numViewportOffsetValues = numViews * 2; |
| 2785 | for (GLsizei i = 0; i < numViewportOffsetValues; ++i) |
| 2786 | { |
| 2787 | if (viewportOffsets[i] < 0) |
| 2788 | { |
| 2789 | context->handleError(InvalidValue() |
| 2790 | << "viewportOffsets cannot contain negative values."); |
| 2791 | return false; |
| 2792 | } |
| 2793 | } |
| 2794 | |
| 2795 | if (texture != 0) |
| 2796 | { |
| 2797 | Texture *tex = context->getTexture(texture); |
| 2798 | ASSERT(tex); |
| 2799 | |
| 2800 | switch (tex->getTarget()) |
| 2801 | { |
| 2802 | case GL_TEXTURE_2D: |
| 2803 | break; |
| 2804 | default: |
| 2805 | context->handleError(InvalidOperation() |
| 2806 | << "Texture's target must be GL_TEXTURE_2D."); |
| 2807 | return false; |
| 2808 | } |
| 2809 | |
| 2810 | if (!ValidateFramebufferTextureMultiviewLevelAndFormat(context, tex, level)) |
| 2811 | { |
| 2812 | return false; |
| 2813 | } |
| 2814 | } |
| 2815 | |
| 2816 | return true; |
| 2817 | } |
| 2818 | |
Jamie Madill | ff325f1 | 2017-08-26 15:06:05 -0400 | [diff] [blame] | 2819 | bool ValidateUniform1ui(Context *context, GLint location, GLuint v0) |
| 2820 | { |
| 2821 | return ValidateUniformES3(context, GL_UNSIGNED_INT, location, 1); |
| 2822 | } |
| 2823 | |
| 2824 | bool ValidateUniform2ui(Context *context, GLint location, GLuint v0, GLuint v1) |
| 2825 | { |
| 2826 | return ValidateUniformES3(context, GL_UNSIGNED_INT_VEC2, location, 1); |
| 2827 | } |
| 2828 | |
| 2829 | bool ValidateUniform3ui(Context *context, GLint location, GLuint v0, GLuint v1, GLuint v2) |
| 2830 | { |
| 2831 | return ValidateUniformES3(context, GL_UNSIGNED_INT_VEC3, location, 1); |
| 2832 | } |
| 2833 | |
| 2834 | bool ValidateUniform4ui(Context *context, |
| 2835 | GLint location, |
| 2836 | GLuint v0, |
| 2837 | GLuint v1, |
| 2838 | GLuint v2, |
| 2839 | GLuint v3) |
| 2840 | { |
| 2841 | return ValidateUniformES3(context, GL_UNSIGNED_INT_VEC4, location, 1); |
| 2842 | } |
| 2843 | |
| 2844 | bool ValidateUniform1uiv(Context *context, GLint location, GLsizei count, const GLuint *value) |
| 2845 | { |
| 2846 | return ValidateUniformES3(context, GL_UNSIGNED_INT, location, count); |
| 2847 | } |
| 2848 | |
| 2849 | bool ValidateUniform2uiv(Context *context, GLint location, GLsizei count, const GLuint *value) |
| 2850 | { |
| 2851 | return ValidateUniformES3(context, GL_UNSIGNED_INT_VEC2, location, count); |
| 2852 | } |
| 2853 | |
| 2854 | bool ValidateUniform3uiv(Context *context, GLint location, GLsizei count, const GLuint *value) |
| 2855 | { |
| 2856 | return ValidateUniformES3(context, GL_UNSIGNED_INT_VEC3, location, count); |
| 2857 | } |
| 2858 | |
| 2859 | bool ValidateUniform4uiv(Context *context, GLint location, GLsizei count, const GLuint *value) |
| 2860 | { |
| 2861 | return ValidateUniformES3(context, GL_UNSIGNED_INT_VEC4, location, count); |
| 2862 | } |
| 2863 | |
Jamie Madill | f0e0449 | 2017-08-26 15:28:42 -0400 | [diff] [blame] | 2864 | bool ValidateIsQuery(Context *context, GLuint id) |
| 2865 | { |
| 2866 | if (context->getClientMajorVersion() < 3) |
| 2867 | { |
| 2868 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 2869 | return false; |
| 2870 | } |
| 2871 | |
| 2872 | return true; |
| 2873 | } |
| 2874 | |
Jamie Madill | c8c9581 | 2017-08-26 18:40:09 -0400 | [diff] [blame] | 2875 | bool ValidateUniformMatrix2x3fv(Context *context, |
| 2876 | GLint location, |
| 2877 | GLsizei count, |
| 2878 | GLboolean transpose, |
| 2879 | const GLfloat *value) |
| 2880 | { |
| 2881 | return ValidateUniformMatrixES3(context, GL_FLOAT_MAT2x3, location, count, transpose); |
| 2882 | } |
| 2883 | |
| 2884 | bool ValidateUniformMatrix3x2fv(Context *context, |
| 2885 | GLint location, |
| 2886 | GLsizei count, |
| 2887 | GLboolean transpose, |
| 2888 | const GLfloat *value) |
| 2889 | { |
| 2890 | return ValidateUniformMatrixES3(context, GL_FLOAT_MAT3x2, location, count, transpose); |
| 2891 | } |
| 2892 | |
| 2893 | bool ValidateUniformMatrix2x4fv(Context *context, |
| 2894 | GLint location, |
| 2895 | GLsizei count, |
| 2896 | GLboolean transpose, |
| 2897 | const GLfloat *value) |
| 2898 | { |
| 2899 | return ValidateUniformMatrixES3(context, GL_FLOAT_MAT2x4, location, count, transpose); |
| 2900 | } |
| 2901 | |
| 2902 | bool ValidateUniformMatrix4x2fv(Context *context, |
| 2903 | GLint location, |
| 2904 | GLsizei count, |
| 2905 | GLboolean transpose, |
| 2906 | const GLfloat *value) |
| 2907 | { |
| 2908 | return ValidateUniformMatrixES3(context, GL_FLOAT_MAT4x2, location, count, transpose); |
| 2909 | } |
| 2910 | |
| 2911 | bool ValidateUniformMatrix3x4fv(Context *context, |
| 2912 | GLint location, |
| 2913 | GLsizei count, |
| 2914 | GLboolean transpose, |
| 2915 | const GLfloat *value) |
| 2916 | { |
| 2917 | return ValidateUniformMatrixES3(context, GL_FLOAT_MAT3x4, location, count, transpose); |
| 2918 | } |
| 2919 | |
| 2920 | bool ValidateUniformMatrix4x3fv(Context *context, |
| 2921 | GLint location, |
| 2922 | GLsizei count, |
| 2923 | GLboolean transpose, |
| 2924 | const GLfloat *value) |
| 2925 | { |
| 2926 | return ValidateUniformMatrixES3(context, GL_FLOAT_MAT4x3, location, count, transpose); |
| 2927 | } |
| 2928 | |
Jamie Madill | f0dcb8b | 2017-08-26 19:05:13 -0400 | [diff] [blame] | 2929 | bool ValidateEndTransformFeedback(Context *context) |
| 2930 | { |
| 2931 | if (context->getClientMajorVersion() < 3) |
| 2932 | { |
| 2933 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 2934 | return false; |
| 2935 | } |
| 2936 | |
| 2937 | TransformFeedback *transformFeedback = context->getGLState().getCurrentTransformFeedback(); |
| 2938 | ASSERT(transformFeedback != nullptr); |
| 2939 | |
| 2940 | if (!transformFeedback->isActive()) |
| 2941 | { |
| 2942 | context->handleError(InvalidOperation()); |
| 2943 | return false; |
| 2944 | } |
| 2945 | |
| 2946 | return true; |
| 2947 | } |
| 2948 | |
| 2949 | bool ValidateTransformFeedbackVaryings(Context *context, |
| 2950 | GLuint program, |
| 2951 | GLsizei count, |
| 2952 | const GLchar *const *varyings, |
| 2953 | GLenum bufferMode) |
| 2954 | { |
| 2955 | if (context->getClientMajorVersion() < 3) |
| 2956 | { |
| 2957 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 2958 | return false; |
| 2959 | } |
| 2960 | |
| 2961 | if (count < 0) |
| 2962 | { |
| 2963 | ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount); |
| 2964 | return false; |
| 2965 | } |
| 2966 | |
| 2967 | switch (bufferMode) |
| 2968 | { |
| 2969 | case GL_INTERLEAVED_ATTRIBS: |
| 2970 | break; |
| 2971 | case GL_SEPARATE_ATTRIBS: |
| 2972 | { |
| 2973 | const Caps &caps = context->getCaps(); |
| 2974 | if (static_cast<GLuint>(count) > caps.maxTransformFeedbackSeparateAttributes) |
| 2975 | { |
| 2976 | context->handleError(InvalidValue()); |
| 2977 | return false; |
| 2978 | } |
| 2979 | break; |
| 2980 | } |
| 2981 | default: |
| 2982 | context->handleError(InvalidEnum()); |
| 2983 | return false; |
| 2984 | } |
| 2985 | |
| 2986 | Program *programObject = GetValidProgram(context, program); |
| 2987 | if (!programObject) |
| 2988 | { |
| 2989 | return false; |
| 2990 | } |
| 2991 | |
| 2992 | return true; |
| 2993 | } |
| 2994 | |
| 2995 | bool ValidateGetTransformFeedbackVarying(Context *context, |
| 2996 | GLuint program, |
| 2997 | GLuint index, |
| 2998 | GLsizei bufSize, |
| 2999 | GLsizei *length, |
| 3000 | GLsizei *size, |
| 3001 | GLenum *type, |
| 3002 | GLchar *name) |
| 3003 | { |
| 3004 | if (context->getClientMajorVersion() < 3) |
| 3005 | { |
| 3006 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3007 | return false; |
| 3008 | } |
| 3009 | |
| 3010 | if (bufSize < 0) |
| 3011 | { |
| 3012 | ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize); |
| 3013 | return false; |
| 3014 | } |
| 3015 | |
| 3016 | Program *programObject = GetValidProgram(context, program); |
| 3017 | if (!programObject) |
| 3018 | { |
| 3019 | return false; |
| 3020 | } |
| 3021 | |
| 3022 | if (index >= static_cast<GLuint>(programObject->getTransformFeedbackVaryingCount())) |
| 3023 | { |
| 3024 | context->handleError(InvalidValue()); |
| 3025 | return false; |
| 3026 | } |
| 3027 | |
| 3028 | return true; |
| 3029 | } |
| 3030 | |
| 3031 | bool ValidateBindTransformFeedback(Context *context, GLenum target, GLuint id) |
| 3032 | { |
| 3033 | if (context->getClientMajorVersion() < 3) |
| 3034 | { |
| 3035 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3036 | return false; |
| 3037 | } |
| 3038 | |
| 3039 | switch (target) |
| 3040 | { |
| 3041 | case GL_TRANSFORM_FEEDBACK: |
| 3042 | { |
| 3043 | // Cannot bind a transform feedback object if the current one is started and not |
| 3044 | // paused (3.0.2 pg 85 section 2.14.1) |
| 3045 | TransformFeedback *curTransformFeedback = |
| 3046 | context->getGLState().getCurrentTransformFeedback(); |
| 3047 | if (curTransformFeedback && curTransformFeedback->isActive() && |
| 3048 | !curTransformFeedback->isPaused()) |
| 3049 | { |
| 3050 | context->handleError(InvalidOperation()); |
| 3051 | return false; |
| 3052 | } |
| 3053 | |
| 3054 | // Cannot bind a transform feedback object that does not exist (3.0.2 pg 85 section |
| 3055 | // 2.14.1) |
| 3056 | if (!context->isTransformFeedbackGenerated(id)) |
| 3057 | { |
| 3058 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), TransformFeedbackDoesNotExist); |
| 3059 | return false; |
| 3060 | } |
| 3061 | } |
| 3062 | break; |
| 3063 | |
| 3064 | default: |
| 3065 | context->handleError(InvalidEnum()); |
| 3066 | return false; |
| 3067 | } |
| 3068 | |
| 3069 | return true; |
| 3070 | } |
| 3071 | |
| 3072 | bool ValidateIsTransformFeedback(Context *context, GLuint id) |
| 3073 | { |
| 3074 | if (context->getClientMajorVersion() < 3) |
| 3075 | { |
| 3076 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3077 | return false; |
| 3078 | } |
| 3079 | |
| 3080 | return true; |
| 3081 | } |
| 3082 | |
| 3083 | bool ValidatePauseTransformFeedback(Context *context) |
| 3084 | { |
| 3085 | if (context->getClientMajorVersion() < 3) |
| 3086 | { |
| 3087 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3088 | return false; |
| 3089 | } |
| 3090 | |
| 3091 | TransformFeedback *transformFeedback = context->getGLState().getCurrentTransformFeedback(); |
| 3092 | ASSERT(transformFeedback != nullptr); |
| 3093 | |
| 3094 | // Current transform feedback must be active and not paused in order to pause (3.0.2 pg 86) |
| 3095 | if (!transformFeedback->isActive() || transformFeedback->isPaused()) |
| 3096 | { |
| 3097 | context->handleError(InvalidOperation()); |
| 3098 | return false; |
| 3099 | } |
| 3100 | |
| 3101 | return true; |
| 3102 | } |
| 3103 | |
| 3104 | bool ValidateResumeTransformFeedback(Context *context) |
| 3105 | { |
| 3106 | if (context->getClientMajorVersion() < 3) |
| 3107 | { |
| 3108 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3109 | return false; |
| 3110 | } |
| 3111 | |
| 3112 | TransformFeedback *transformFeedback = context->getGLState().getCurrentTransformFeedback(); |
| 3113 | ASSERT(transformFeedback != nullptr); |
| 3114 | |
| 3115 | // Current transform feedback must be active and paused in order to resume (3.0.2 pg 86) |
| 3116 | if (!transformFeedback->isActive() || !transformFeedback->isPaused()) |
| 3117 | { |
| 3118 | context->handleError(InvalidOperation()); |
| 3119 | return false; |
| 3120 | } |
| 3121 | |
| 3122 | return true; |
| 3123 | } |
| 3124 | |
Jamie Madill | 12e957f | 2017-08-26 21:42:26 -0400 | [diff] [blame] | 3125 | bool ValidateVertexAttribI4i(Context *context, GLuint index, GLint x, GLint y, GLint z, GLint w) |
| 3126 | { |
| 3127 | if (context->getClientMajorVersion() < 3) |
| 3128 | { |
| 3129 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3130 | return false; |
| 3131 | } |
| 3132 | |
| 3133 | return ValidateVertexAttribIndex(context, index); |
| 3134 | } |
| 3135 | |
| 3136 | bool ValidateVertexAttribI4ui(Context *context, |
| 3137 | GLuint index, |
| 3138 | GLuint x, |
| 3139 | GLuint y, |
| 3140 | GLuint z, |
| 3141 | GLuint w) |
| 3142 | { |
| 3143 | if (context->getClientMajorVersion() < 3) |
| 3144 | { |
| 3145 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3146 | return false; |
| 3147 | } |
| 3148 | |
| 3149 | return ValidateVertexAttribIndex(context, index); |
| 3150 | } |
| 3151 | |
| 3152 | bool ValidateVertexAttribI4iv(Context *context, GLuint index, const GLint *v) |
| 3153 | { |
| 3154 | if (context->getClientMajorVersion() < 3) |
| 3155 | { |
| 3156 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3157 | return false; |
| 3158 | } |
| 3159 | |
| 3160 | return ValidateVertexAttribIndex(context, index); |
| 3161 | } |
| 3162 | |
| 3163 | bool ValidateVertexAttribI4uiv(Context *context, GLuint index, const GLuint *v) |
| 3164 | { |
| 3165 | if (context->getClientMajorVersion() < 3) |
| 3166 | { |
| 3167 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3168 | return false; |
| 3169 | } |
| 3170 | |
| 3171 | return ValidateVertexAttribIndex(context, index); |
| 3172 | } |
| 3173 | |
| 3174 | bool ValidateGetFragDataLocation(Context *context, GLuint program, const GLchar *name) |
| 3175 | { |
| 3176 | if (context->getClientMajorVersion() < 3) |
| 3177 | { |
| 3178 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3179 | return false; |
| 3180 | } |
| 3181 | |
| 3182 | Program *programObject = GetValidProgram(context, program); |
| 3183 | if (!programObject) |
| 3184 | { |
| 3185 | return false; |
| 3186 | } |
| 3187 | |
| 3188 | if (!programObject->isLinked()) |
| 3189 | { |
| 3190 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked); |
| 3191 | return false; |
| 3192 | } |
| 3193 | |
| 3194 | return true; |
| 3195 | } |
| 3196 | |
| 3197 | bool ValidateGetUniformIndices(Context *context, |
| 3198 | GLuint program, |
| 3199 | GLsizei uniformCount, |
| 3200 | const GLchar *const *uniformNames, |
| 3201 | GLuint *uniformIndices) |
| 3202 | { |
| 3203 | if (context->getClientMajorVersion() < 3) |
| 3204 | { |
| 3205 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3206 | return false; |
| 3207 | } |
| 3208 | |
| 3209 | if (uniformCount < 0) |
| 3210 | { |
| 3211 | context->handleError(InvalidValue()); |
| 3212 | return false; |
| 3213 | } |
| 3214 | |
| 3215 | Program *programObject = GetValidProgram(context, program); |
| 3216 | if (!programObject) |
| 3217 | { |
| 3218 | return false; |
| 3219 | } |
| 3220 | |
| 3221 | return true; |
| 3222 | } |
| 3223 | |
| 3224 | bool ValidateGetActiveUniformsiv(Context *context, |
| 3225 | GLuint program, |
| 3226 | GLsizei uniformCount, |
| 3227 | const GLuint *uniformIndices, |
| 3228 | GLenum pname, |
| 3229 | GLint *params) |
| 3230 | { |
| 3231 | if (context->getClientMajorVersion() < 3) |
| 3232 | { |
| 3233 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3234 | return false; |
| 3235 | } |
| 3236 | |
| 3237 | if (uniformCount < 0) |
| 3238 | { |
| 3239 | context->handleError(InvalidValue()); |
| 3240 | return false; |
| 3241 | } |
| 3242 | |
| 3243 | Program *programObject = GetValidProgram(context, program); |
| 3244 | if (!programObject) |
| 3245 | { |
| 3246 | return false; |
| 3247 | } |
| 3248 | |
| 3249 | switch (pname) |
| 3250 | { |
| 3251 | case GL_UNIFORM_TYPE: |
| 3252 | case GL_UNIFORM_SIZE: |
| 3253 | case GL_UNIFORM_NAME_LENGTH: |
| 3254 | case GL_UNIFORM_BLOCK_INDEX: |
| 3255 | case GL_UNIFORM_OFFSET: |
| 3256 | case GL_UNIFORM_ARRAY_STRIDE: |
| 3257 | case GL_UNIFORM_MATRIX_STRIDE: |
| 3258 | case GL_UNIFORM_IS_ROW_MAJOR: |
| 3259 | break; |
| 3260 | |
| 3261 | default: |
| 3262 | context->handleError(InvalidEnum()); |
| 3263 | return false; |
| 3264 | } |
| 3265 | |
| 3266 | if (uniformCount > programObject->getActiveUniformCount()) |
| 3267 | { |
| 3268 | context->handleError(InvalidValue()); |
| 3269 | return false; |
| 3270 | } |
| 3271 | |
| 3272 | for (int uniformId = 0; uniformId < uniformCount; uniformId++) |
| 3273 | { |
| 3274 | const GLuint index = uniformIndices[uniformId]; |
| 3275 | |
| 3276 | if (index >= static_cast<GLuint>(programObject->getActiveUniformCount())) |
| 3277 | { |
| 3278 | context->handleError(InvalidValue()); |
| 3279 | return false; |
| 3280 | } |
| 3281 | } |
| 3282 | |
| 3283 | return true; |
| 3284 | } |
| 3285 | |
| 3286 | bool ValidateGetUniformBlockIndex(Context *context, GLuint program, const GLchar *uniformBlockName) |
| 3287 | { |
| 3288 | if (context->getClientMajorVersion() < 3) |
| 3289 | { |
| 3290 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3291 | return false; |
| 3292 | } |
| 3293 | |
| 3294 | Program *programObject = GetValidProgram(context, program); |
| 3295 | if (!programObject) |
| 3296 | { |
| 3297 | return false; |
| 3298 | } |
| 3299 | |
| 3300 | return true; |
| 3301 | } |
| 3302 | |
| 3303 | bool ValidateGetActiveUniformBlockiv(Context *context, |
| 3304 | GLuint program, |
| 3305 | GLuint uniformBlockIndex, |
| 3306 | GLenum pname, |
| 3307 | GLint *params) |
| 3308 | { |
| 3309 | return ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, nullptr); |
| 3310 | } |
| 3311 | |
| 3312 | bool ValidateGetActiveUniformBlockName(Context *context, |
| 3313 | GLuint program, |
| 3314 | GLuint uniformBlockIndex, |
| 3315 | GLsizei bufSize, |
| 3316 | GLsizei *length, |
| 3317 | GLchar *uniformBlockName) |
| 3318 | { |
| 3319 | if (context->getClientMajorVersion() < 3) |
| 3320 | { |
| 3321 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3322 | return false; |
| 3323 | } |
| 3324 | |
| 3325 | Program *programObject = GetValidProgram(context, program); |
| 3326 | if (!programObject) |
| 3327 | { |
| 3328 | return false; |
| 3329 | } |
| 3330 | |
| 3331 | if (uniformBlockIndex >= programObject->getActiveUniformBlockCount()) |
| 3332 | { |
| 3333 | context->handleError(InvalidValue()); |
| 3334 | return false; |
| 3335 | } |
| 3336 | |
| 3337 | return true; |
| 3338 | } |
| 3339 | |
| 3340 | bool ValidateUniformBlockBinding(Context *context, |
| 3341 | GLuint program, |
| 3342 | GLuint uniformBlockIndex, |
| 3343 | GLuint uniformBlockBinding) |
| 3344 | { |
| 3345 | if (context->getClientMajorVersion() < 3) |
| 3346 | { |
| 3347 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3348 | return false; |
| 3349 | } |
| 3350 | |
| 3351 | if (uniformBlockBinding >= context->getCaps().maxUniformBufferBindings) |
| 3352 | { |
| 3353 | context->handleError(InvalidValue()); |
| 3354 | return false; |
| 3355 | } |
| 3356 | |
| 3357 | Program *programObject = GetValidProgram(context, program); |
| 3358 | if (!programObject) |
| 3359 | { |
| 3360 | return false; |
| 3361 | } |
| 3362 | |
| 3363 | // if never linked, there won't be any uniform blocks |
| 3364 | if (uniformBlockIndex >= programObject->getActiveUniformBlockCount()) |
| 3365 | { |
| 3366 | context->handleError(InvalidValue()); |
| 3367 | return false; |
| 3368 | } |
| 3369 | |
| 3370 | return true; |
| 3371 | } |
| 3372 | |
| 3373 | bool ValidateDrawArraysInstanced(Context *context, |
| 3374 | GLenum mode, |
| 3375 | GLint first, |
| 3376 | GLsizei count, |
| 3377 | GLsizei primcount) |
| 3378 | { |
| 3379 | if (context->getClientMajorVersion() < 3) |
| 3380 | { |
| 3381 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3382 | return false; |
| 3383 | } |
| 3384 | |
| 3385 | return ValidateDrawArraysInstancedBase(context, mode, first, count, primcount); |
| 3386 | } |
| 3387 | |
Jamie Madill | 7f0c5a4 | 2017-08-26 22:43:26 -0400 | [diff] [blame] | 3388 | bool ValidateFenceSync(Context *context, GLenum condition, GLbitfield flags) |
| 3389 | { |
| 3390 | if (context->getClientMajorVersion() < 3) |
| 3391 | { |
| 3392 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3393 | return false; |
| 3394 | } |
| 3395 | |
| 3396 | if (condition != GL_SYNC_GPU_COMMANDS_COMPLETE) |
| 3397 | { |
| 3398 | context->handleError(InvalidEnum()); |
| 3399 | return false; |
| 3400 | } |
| 3401 | |
| 3402 | if (flags != 0) |
| 3403 | { |
| 3404 | context->handleError(InvalidValue()); |
| 3405 | return false; |
| 3406 | } |
| 3407 | |
| 3408 | return true; |
| 3409 | } |
| 3410 | |
| 3411 | bool ValidateIsSync(Context *context, GLsync sync) |
| 3412 | { |
| 3413 | if (context->getClientMajorVersion() < 3) |
| 3414 | { |
| 3415 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3416 | return false; |
| 3417 | } |
| 3418 | |
| 3419 | return true; |
| 3420 | } |
| 3421 | |
| 3422 | bool ValidateDeleteSync(Context *context, GLsync sync) |
| 3423 | { |
| 3424 | if (context->getClientMajorVersion() < 3) |
| 3425 | { |
| 3426 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3427 | return false; |
| 3428 | } |
| 3429 | |
Jamie Madill | 70b5bb0 | 2017-08-28 13:32:37 -0400 | [diff] [blame^] | 3430 | if (sync != static_cast<GLsync>(0) && !context->getSync(sync)) |
Jamie Madill | 7f0c5a4 | 2017-08-26 22:43:26 -0400 | [diff] [blame] | 3431 | { |
| 3432 | context->handleError(InvalidValue()); |
| 3433 | return false; |
| 3434 | } |
| 3435 | |
| 3436 | return true; |
| 3437 | } |
| 3438 | |
| 3439 | bool ValidateClientWaitSync(Context *context, GLsync sync, GLbitfield flags, GLuint64 timeout) |
| 3440 | { |
| 3441 | if (context->getClientMajorVersion() < 3) |
| 3442 | { |
| 3443 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3444 | return false; |
| 3445 | } |
| 3446 | |
| 3447 | if ((flags & ~(GL_SYNC_FLUSH_COMMANDS_BIT)) != 0) |
| 3448 | { |
| 3449 | context->handleError(InvalidValue()); |
| 3450 | return false; |
| 3451 | } |
| 3452 | |
Jamie Madill | 70b5bb0 | 2017-08-28 13:32:37 -0400 | [diff] [blame^] | 3453 | Sync *clientWaitSync = context->getSync(sync); |
| 3454 | if (!clientWaitSync) |
Jamie Madill | 7f0c5a4 | 2017-08-26 22:43:26 -0400 | [diff] [blame] | 3455 | { |
| 3456 | context->handleError(InvalidValue()); |
| 3457 | return false; |
| 3458 | } |
| 3459 | |
| 3460 | return true; |
| 3461 | } |
| 3462 | |
| 3463 | bool ValidateWaitSync(Context *context, GLsync sync, GLbitfield flags, GLuint64 timeout) |
| 3464 | { |
| 3465 | if (context->getClientMajorVersion() < 3) |
| 3466 | { |
| 3467 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3468 | return false; |
| 3469 | } |
| 3470 | |
| 3471 | if (flags != 0) |
| 3472 | { |
| 3473 | context->handleError(InvalidValue()); |
| 3474 | return false; |
| 3475 | } |
| 3476 | |
| 3477 | if (timeout != GL_TIMEOUT_IGNORED) |
| 3478 | { |
| 3479 | context->handleError(InvalidValue()); |
| 3480 | return false; |
| 3481 | } |
| 3482 | |
Jamie Madill | 70b5bb0 | 2017-08-28 13:32:37 -0400 | [diff] [blame^] | 3483 | Sync *waitSync = context->getSync(sync); |
| 3484 | if (!waitSync) |
Jamie Madill | 7f0c5a4 | 2017-08-26 22:43:26 -0400 | [diff] [blame] | 3485 | { |
| 3486 | context->handleError(InvalidValue()); |
| 3487 | return false; |
| 3488 | } |
| 3489 | |
| 3490 | return true; |
| 3491 | } |
| 3492 | |
| 3493 | bool ValidateGetInteger64v(Context *context, GLenum pname, GLint64 *params) |
| 3494 | { |
| 3495 | if (context->getClientMajorVersion() < 3) |
| 3496 | { |
| 3497 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3498 | return false; |
| 3499 | } |
| 3500 | |
| 3501 | GLenum nativeType = GL_NONE; |
| 3502 | unsigned int numParams = 0; |
| 3503 | if (!ValidateStateQuery(context, pname, &nativeType, &numParams)) |
| 3504 | { |
| 3505 | return false; |
| 3506 | } |
| 3507 | |
| 3508 | return true; |
| 3509 | } |
| 3510 | |
Jamie Madill | 3ef140a | 2017-08-26 23:11:21 -0400 | [diff] [blame] | 3511 | bool ValidateIsSampler(Context *context, GLuint sampler) |
| 3512 | { |
| 3513 | if (context->getClientMajorVersion() < 3) |
| 3514 | { |
| 3515 | context->handleError(InvalidOperation()); |
| 3516 | return false; |
| 3517 | } |
| 3518 | |
| 3519 | return true; |
| 3520 | } |
| 3521 | |
| 3522 | bool ValidateBindSampler(Context *context, GLuint unit, GLuint sampler) |
| 3523 | { |
| 3524 | if (context->getClientMajorVersion() < 3) |
| 3525 | { |
| 3526 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3527 | return false; |
| 3528 | } |
| 3529 | |
| 3530 | if (sampler != 0 && !context->isSampler(sampler)) |
| 3531 | { |
| 3532 | context->handleError(InvalidOperation()); |
| 3533 | return false; |
| 3534 | } |
| 3535 | |
| 3536 | if (unit >= context->getCaps().maxCombinedTextureImageUnits) |
| 3537 | { |
| 3538 | context->handleError(InvalidValue()); |
| 3539 | return false; |
| 3540 | } |
| 3541 | |
| 3542 | return true; |
| 3543 | } |
| 3544 | |
| 3545 | bool ValidateVertexAttribDivisor(Context *context, GLuint index, GLuint divisor) |
| 3546 | { |
| 3547 | if (context->getClientMajorVersion() < 3) |
| 3548 | { |
| 3549 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3550 | return false; |
| 3551 | } |
| 3552 | |
| 3553 | return ValidateVertexAttribIndex(context, index); |
| 3554 | } |
| 3555 | |
| 3556 | bool ValidateTexStorage2D(Context *context, |
| 3557 | GLenum target, |
| 3558 | GLsizei levels, |
| 3559 | GLenum internalformat, |
| 3560 | GLsizei width, |
| 3561 | GLsizei height) |
| 3562 | { |
| 3563 | if (context->getClientMajorVersion() < 3) |
| 3564 | { |
| 3565 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3566 | return false; |
| 3567 | } |
| 3568 | |
| 3569 | if (!ValidateES3TexStorage2DParameters(context, target, levels, internalformat, width, height, |
| 3570 | 1)) |
| 3571 | { |
| 3572 | return false; |
| 3573 | } |
| 3574 | |
| 3575 | return true; |
| 3576 | } |
| 3577 | |
| 3578 | bool ValidateTexStorage3D(Context *context, |
| 3579 | GLenum target, |
| 3580 | GLsizei levels, |
| 3581 | GLenum internalformat, |
| 3582 | GLsizei width, |
| 3583 | GLsizei height, |
| 3584 | GLsizei depth) |
| 3585 | { |
| 3586 | if (context->getClientMajorVersion() < 3) |
| 3587 | { |
| 3588 | ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required); |
| 3589 | return false; |
| 3590 | } |
| 3591 | |
| 3592 | if (!ValidateES3TexStorage3DParameters(context, target, levels, internalformat, width, height, |
| 3593 | depth)) |
| 3594 | { |
| 3595 | return false; |
| 3596 | } |
| 3597 | |
| 3598 | return true; |
| 3599 | } |
| 3600 | |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 3601 | } // namespace gl |