Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 1 | // |
| 2 | // Copyright 2015 The ANGLE Project Authors. All rights reserved. |
| 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // VertexArrayGL.cpp: Implements the class methods for VertexArrayGL. |
| 8 | |
| 9 | #include "libANGLE/renderer/gl/VertexArrayGL.h" |
| 10 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 11 | #include "common/BitSetIterator.h" |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 12 | #include "common/debug.h" |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 13 | #include "common/mathutil.h" |
Geoff Lang | 831b195 | 2015-05-05 11:02:27 -0400 | [diff] [blame] | 14 | #include "common/utilities.h" |
Geoff Lang | 6ae6efc | 2015-03-09 14:42:35 -0400 | [diff] [blame] | 15 | #include "libANGLE/Buffer.h" |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 16 | #include "libANGLE/angletypes.h" |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 17 | #include "libANGLE/formatutils.h" |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 18 | #include "libANGLE/renderer/gl/BufferGL.h" |
| 19 | #include "libANGLE/renderer/gl/FunctionsGL.h" |
Geoff Lang | b2ebb5e | 2016-06-08 18:17:55 +0000 | [diff] [blame] | 20 | #include "libANGLE/renderer/gl/renderergl_utils.h" |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 21 | #include "libANGLE/renderer/gl/StateManagerGL.h" |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 22 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 23 | using namespace gl; |
| 24 | |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 25 | namespace rx |
| 26 | { |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 27 | namespace |
| 28 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 29 | // Warning: you should ensure binding really matches attrib.bindingIndex before using this function. |
| 30 | bool AttributeNeedsStreaming(const VertexAttribute &attrib, const VertexBinding &binding) |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 31 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 32 | return (attrib.enabled && binding.buffer.get() == nullptr); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 33 | } |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 34 | } // anonymous namespace |
| 35 | |
Jamie Madill | 3f57268 | 2016-04-26 13:41:36 -0400 | [diff] [blame] | 36 | VertexArrayGL::VertexArrayGL(const VertexArrayState &state, |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 37 | const FunctionsGL *functions, |
| 38 | StateManagerGL *stateManager) |
Jamie Madill | 3f57268 | 2016-04-26 13:41:36 -0400 | [diff] [blame] | 39 | : VertexArrayImpl(state), |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 40 | mFunctions(functions), |
| 41 | mStateManager(stateManager), |
| 42 | mVertexArrayID(0), |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 43 | mAppliedElementArrayBuffer(), |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 44 | mAppliedBindings(state.getMaxBindings()), |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 45 | mStreamingElementArrayBufferSize(0), |
| 46 | mStreamingElementArrayBuffer(0), |
| 47 | mStreamingArrayBufferSize(0), |
| 48 | mStreamingArrayBuffer(0) |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 49 | { |
| 50 | ASSERT(mFunctions); |
| 51 | ASSERT(mStateManager); |
| 52 | mFunctions->genVertexArrays(1, &mVertexArrayID); |
| 53 | |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 54 | // Set the cached vertex attribute array and vertex attribute binding array size |
| 55 | GLuint maxVertexAttribs = static_cast<GLuint>(state.getMaxAttribs()); |
| 56 | for (GLuint i = 0; i < maxVertexAttribs; i++) |
| 57 | { |
| 58 | mAppliedAttributes.emplace_back(i); |
| 59 | } |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 60 | } |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 61 | |
| 62 | VertexArrayGL::~VertexArrayGL() |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 63 | { |
Geoff Lang | 1eb708e | 2015-05-04 14:58:23 -0400 | [diff] [blame] | 64 | mStateManager->deleteVertexArray(mVertexArrayID); |
| 65 | mVertexArrayID = 0; |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 66 | |
Geoff Lang | 1eb708e | 2015-05-04 14:58:23 -0400 | [diff] [blame] | 67 | mStateManager->deleteBuffer(mStreamingElementArrayBuffer); |
| 68 | mStreamingElementArrayBufferSize = 0; |
| 69 | mStreamingElementArrayBuffer = 0; |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 70 | |
Geoff Lang | 1eb708e | 2015-05-04 14:58:23 -0400 | [diff] [blame] | 71 | mStateManager->deleteBuffer(mStreamingArrayBuffer); |
| 72 | mStreamingArrayBufferSize = 0; |
| 73 | mStreamingArrayBuffer = 0; |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 74 | |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 75 | mAppliedElementArrayBuffer.set(nullptr); |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 76 | for (auto &binding : mAppliedBindings) |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 77 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 78 | binding.buffer.set(nullptr); |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 79 | } |
| 80 | } |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 81 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 82 | gl::Error VertexArrayGL::syncDrawArraysState(const gl::AttributesMask &activeAttributesMask, |
| 83 | GLint first, |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 84 | GLsizei count, |
| 85 | GLsizei instanceCount) const |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 86 | { |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 87 | return syncDrawState(activeAttributesMask, first, count, GL_NONE, nullptr, instanceCount, false, |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 88 | nullptr); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 89 | } |
| 90 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 91 | gl::Error VertexArrayGL::syncDrawElementsState(const gl::AttributesMask &activeAttributesMask, |
| 92 | GLsizei count, |
| 93 | GLenum type, |
| 94 | const GLvoid *indices, |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 95 | GLsizei instanceCount, |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 96 | bool primitiveRestartEnabled, |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 97 | const GLvoid **outIndices) const |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 98 | { |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 99 | return syncDrawState(activeAttributesMask, 0, count, type, indices, instanceCount, |
| 100 | primitiveRestartEnabled, outIndices); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 101 | } |
| 102 | |
Jiajia Qin | d967122 | 2016-11-29 16:30:31 +0800 | [diff] [blame] | 103 | gl::Error VertexArrayGL::syncElementArrayState() const |
| 104 | { |
| 105 | gl::Buffer *elementArrayBuffer = mData.getElementArrayBuffer().get(); |
| 106 | ASSERT(elementArrayBuffer); |
| 107 | if (elementArrayBuffer != mAppliedElementArrayBuffer.get()) |
| 108 | { |
| 109 | const BufferGL *bufferGL = GetImplAs<BufferGL>(elementArrayBuffer); |
| 110 | mStateManager->bindBuffer(GL_ELEMENT_ARRAY_BUFFER, bufferGL->getBufferID()); |
| 111 | mAppliedElementArrayBuffer.set(elementArrayBuffer); |
| 112 | } |
| 113 | |
| 114 | return gl::NoError(); |
| 115 | } |
| 116 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 117 | gl::Error VertexArrayGL::syncDrawState(const gl::AttributesMask &activeAttributesMask, |
| 118 | GLint first, |
| 119 | GLsizei count, |
| 120 | GLenum type, |
| 121 | const GLvoid *indices, |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 122 | GLsizei instanceCount, |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 123 | bool primitiveRestartEnabled, |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 124 | const GLvoid **outIndices) const |
Geoff Lang | 6ae6efc | 2015-03-09 14:42:35 -0400 | [diff] [blame] | 125 | { |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 126 | mStateManager->bindVertexArray(mVertexArrayID, getAppliedElementArrayBufferID()); |
Geoff Lang | 6ae6efc | 2015-03-09 14:42:35 -0400 | [diff] [blame] | 127 | |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 128 | // Check if any attributes need to be streamed, determines if the index range needs to be computed |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 129 | bool attributesNeedStreaming = mAttributesNeedStreaming.any(); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 130 | |
| 131 | // Determine if an index buffer needs to be streamed and the range of vertices that need to be copied |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 132 | IndexRange indexRange; |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 133 | if (type != GL_NONE) |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 134 | { |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 135 | Error error = syncIndexData(count, type, indices, primitiveRestartEnabled, |
| 136 | attributesNeedStreaming, &indexRange, outIndices); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 137 | if (error.isError()) |
| 138 | { |
| 139 | return error; |
| 140 | } |
| 141 | } |
| 142 | else |
| 143 | { |
Corentin Wallez | 2c34a4b | 2015-08-25 16:26:02 -0400 | [diff] [blame] | 144 | // Not an indexed call, set the range to [first, first + count - 1] |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 145 | indexRange.start = first; |
Corentin Wallez | 2c34a4b | 2015-08-25 16:26:02 -0400 | [diff] [blame] | 146 | indexRange.end = first + count - 1; |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 147 | } |
| 148 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 149 | if (attributesNeedStreaming) |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 150 | { |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 151 | Error error = streamAttributes(activeAttributesMask, instanceCount, indexRange); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 152 | if (error.isError()) |
| 153 | { |
| 154 | return error; |
| 155 | } |
| 156 | } |
| 157 | |
He Yunchao | acd1898 | 2017-01-04 10:46:42 +0800 | [diff] [blame] | 158 | return NoError(); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 159 | } |
| 160 | |
Jiajia Qin | d967122 | 2016-11-29 16:30:31 +0800 | [diff] [blame] | 161 | gl::Error VertexArrayGL::syncIndexData(GLsizei count, |
| 162 | GLenum type, |
| 163 | const GLvoid *indices, |
| 164 | bool primitiveRestartEnabled, |
| 165 | bool attributesNeedStreaming, |
| 166 | IndexRange *outIndexRange, |
| 167 | const GLvoid **outIndices) const |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 168 | { |
| 169 | ASSERT(outIndices); |
| 170 | |
Jamie Madill | 8e34494 | 2015-07-09 14:22:07 -0400 | [diff] [blame] | 171 | gl::Buffer *elementArrayBuffer = mData.getElementArrayBuffer().get(); |
| 172 | |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 173 | // Need to check the range of indices if attributes need to be streamed |
Jamie Madill | 8e34494 | 2015-07-09 14:22:07 -0400 | [diff] [blame] | 174 | if (elementArrayBuffer != nullptr) |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 175 | { |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 176 | if (elementArrayBuffer != mAppliedElementArrayBuffer.get()) |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 177 | { |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 178 | const BufferGL *bufferGL = GetImplAs<BufferGL>(elementArrayBuffer); |
| 179 | mStateManager->bindBuffer(GL_ELEMENT_ARRAY_BUFFER, bufferGL->getBufferID()); |
| 180 | mAppliedElementArrayBuffer.set(elementArrayBuffer); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 181 | } |
| 182 | |
| 183 | // Only compute the index range if the attributes also need to be streamed |
| 184 | if (attributesNeedStreaming) |
| 185 | { |
| 186 | ptrdiff_t elementArrayBufferOffset = reinterpret_cast<ptrdiff_t>(indices); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 187 | Error error = mData.getElementArrayBuffer()->getIndexRange( |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 188 | type, elementArrayBufferOffset, count, primitiveRestartEnabled, outIndexRange); |
Geoff Lang | 520c4ae | 2015-05-05 13:12:36 -0400 | [diff] [blame] | 189 | if (error.isError()) |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 190 | { |
Geoff Lang | 520c4ae | 2015-05-05 13:12:36 -0400 | [diff] [blame] | 191 | return error; |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 192 | } |
| 193 | } |
| 194 | |
| 195 | // Indices serves as an offset into the index buffer in this case, use the same value for the draw call |
| 196 | *outIndices = indices; |
| 197 | } |
| 198 | else |
| 199 | { |
| 200 | // Need to stream the index buffer |
| 201 | // TODO: if GLES, nothing needs to be streamed |
| 202 | |
| 203 | // Only compute the index range if the attributes also need to be streamed |
| 204 | if (attributesNeedStreaming) |
| 205 | { |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 206 | *outIndexRange = ComputeIndexRange(type, indices, count, primitiveRestartEnabled); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 207 | } |
| 208 | |
| 209 | // Allocate the streaming element array buffer |
| 210 | if (mStreamingElementArrayBuffer == 0) |
| 211 | { |
| 212 | mFunctions->genBuffers(1, &mStreamingElementArrayBuffer); |
| 213 | mStreamingElementArrayBufferSize = 0; |
| 214 | } |
| 215 | |
| 216 | mStateManager->bindBuffer(GL_ELEMENT_ARRAY_BUFFER, mStreamingElementArrayBuffer); |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 217 | mAppliedElementArrayBuffer.set(nullptr); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 218 | |
| 219 | // Make sure the element array buffer is large enough |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 220 | const Type &indexTypeInfo = GetTypeInfo(type); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 221 | size_t requiredStreamingBufferSize = indexTypeInfo.bytes * count; |
| 222 | if (requiredStreamingBufferSize > mStreamingElementArrayBufferSize) |
| 223 | { |
| 224 | // Copy the indices in while resizing the buffer |
| 225 | mFunctions->bufferData(GL_ELEMENT_ARRAY_BUFFER, requiredStreamingBufferSize, indices, GL_DYNAMIC_DRAW); |
| 226 | mStreamingElementArrayBufferSize = requiredStreamingBufferSize; |
| 227 | } |
| 228 | else |
| 229 | { |
| 230 | // Put the indices at the beginning of the buffer |
| 231 | mFunctions->bufferSubData(GL_ELEMENT_ARRAY_BUFFER, 0, requiredStreamingBufferSize, indices); |
| 232 | } |
| 233 | |
| 234 | // Set the index offset for the draw call to zero since the supplied index pointer is to client data |
| 235 | *outIndices = nullptr; |
| 236 | } |
| 237 | |
He Yunchao | acd1898 | 2017-01-04 10:46:42 +0800 | [diff] [blame] | 238 | return NoError(); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 239 | } |
| 240 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 241 | void VertexArrayGL::computeStreamingAttributeSizes(const gl::AttributesMask &activeAttributesMask, |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 242 | GLsizei instanceCount, |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 243 | const gl::IndexRange &indexRange, |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 244 | size_t *outStreamingDataSize, |
| 245 | size_t *outMaxAttributeDataSize) const |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 246 | { |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 247 | *outStreamingDataSize = 0; |
| 248 | *outMaxAttributeDataSize = 0; |
| 249 | |
| 250 | ASSERT(mAttributesNeedStreaming.any()); |
| 251 | |
| 252 | const auto &attribs = mData.getVertexAttributes(); |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 253 | const auto &bindings = mData.getVertexBindings(); |
Corentin Wallez | ca311dd | 2015-12-07 15:07:48 -0500 | [diff] [blame] | 254 | for (auto idx : angle::IterateBitSet(mAttributesNeedStreaming & activeAttributesMask)) |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 255 | { |
| 256 | const auto &attrib = attribs[idx]; |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 257 | const auto &binding = bindings[attrib.bindingIndex]; |
| 258 | ASSERT(AttributeNeedsStreaming(attrib, binding)); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 259 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 260 | // If streaming is going to be required, compute the size of the required buffer |
| 261 | // and how much slack space at the beginning of the buffer will be required by determining |
| 262 | // the attribute with the largest data size. |
| 263 | size_t typeSize = ComputeVertexAttributeTypeSize(attrib); |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 264 | *outStreamingDataSize += typeSize * ComputeVertexBindingElementCount( |
| 265 | binding, indexRange.vertexCount(), instanceCount); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 266 | *outMaxAttributeDataSize = std::max(*outMaxAttributeDataSize, typeSize); |
| 267 | } |
| 268 | } |
| 269 | |
| 270 | gl::Error VertexArrayGL::streamAttributes(const gl::AttributesMask &activeAttributesMask, |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 271 | GLsizei instanceCount, |
Geoff Lang | 3edfe03 | 2015-09-04 16:38:24 -0400 | [diff] [blame] | 272 | const gl::IndexRange &indexRange) const |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 273 | { |
| 274 | // Sync the vertex attribute state and track what data needs to be streamed |
| 275 | size_t streamingDataSize = 0; |
| 276 | size_t maxAttributeDataSize = 0; |
| 277 | |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 278 | computeStreamingAttributeSizes(activeAttributesMask, instanceCount, indexRange, |
| 279 | &streamingDataSize, &maxAttributeDataSize); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 280 | |
| 281 | if (streamingDataSize == 0) |
| 282 | { |
He Yunchao | acd1898 | 2017-01-04 10:46:42 +0800 | [diff] [blame] | 283 | return gl::NoError(); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 284 | } |
| 285 | |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 286 | if (mStreamingArrayBuffer == 0) |
| 287 | { |
| 288 | mFunctions->genBuffers(1, &mStreamingArrayBuffer); |
| 289 | mStreamingArrayBufferSize = 0; |
| 290 | } |
| 291 | |
| 292 | // If first is greater than zero, a slack space needs to be left at the beginning of the buffer so that |
| 293 | // the same 'first' argument can be passed into the draw call. |
| 294 | const size_t bufferEmptySpace = maxAttributeDataSize * indexRange.start; |
| 295 | const size_t requiredBufferSize = streamingDataSize + bufferEmptySpace; |
| 296 | |
| 297 | mStateManager->bindBuffer(GL_ARRAY_BUFFER, mStreamingArrayBuffer); |
| 298 | if (requiredBufferSize > mStreamingArrayBufferSize) |
| 299 | { |
| 300 | mFunctions->bufferData(GL_ARRAY_BUFFER, requiredBufferSize, nullptr, GL_DYNAMIC_DRAW); |
| 301 | mStreamingArrayBufferSize = requiredBufferSize; |
| 302 | } |
| 303 | |
| 304 | // Unmapping a buffer can return GL_FALSE to indicate that the system has corrupted the data |
| 305 | // somehow (such as by a screen change), retry writing the data a few times and return OUT_OF_MEMORY |
| 306 | // if that fails. |
| 307 | GLboolean unmapResult = GL_FALSE; |
| 308 | size_t unmapRetryAttempts = 5; |
| 309 | while (unmapResult != GL_TRUE && --unmapRetryAttempts > 0) |
| 310 | { |
Geoff Lang | b2ebb5e | 2016-06-08 18:17:55 +0000 | [diff] [blame] | 311 | uint8_t *bufferPointer = MapBufferRangeWithFallback(mFunctions, GL_ARRAY_BUFFER, 0, |
| 312 | requiredBufferSize, GL_MAP_WRITE_BIT); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 313 | size_t curBufferOffset = bufferEmptySpace; |
| 314 | |
Jamie Madill | 8e34494 | 2015-07-09 14:22:07 -0400 | [diff] [blame] | 315 | const auto &attribs = mData.getVertexAttributes(); |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 316 | const auto &bindings = mData.getVertexBindings(); |
Corentin Wallez | ca311dd | 2015-12-07 15:07:48 -0500 | [diff] [blame] | 317 | for (auto idx : angle::IterateBitSet(mAttributesNeedStreaming & activeAttributesMask)) |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 318 | { |
Jamie Madill | 8e34494 | 2015-07-09 14:22:07 -0400 | [diff] [blame] | 319 | const auto &attrib = attribs[idx]; |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 320 | const auto &binding = bindings[attrib.bindingIndex]; |
| 321 | ASSERT(AttributeNeedsStreaming(attrib, binding)); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 322 | |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 323 | const size_t streamedVertexCount = |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 324 | ComputeVertexBindingElementCount(binding, indexRange.vertexCount(), instanceCount); |
Geoff Lang | 3cf12ce | 2015-08-27 14:40:48 -0400 | [diff] [blame] | 325 | |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 326 | const size_t sourceStride = ComputeVertexAttributeStride(attrib, binding); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 327 | const size_t destStride = ComputeVertexAttributeTypeSize(attrib); |
| 328 | |
Geoff Lang | 38a24a9 | 2017-02-15 13:53:06 -0500 | [diff] [blame] | 329 | // Vertices do not apply the 'start' offset when the divisor is non-zero even when doing |
| 330 | // a non-instanced draw call |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 331 | const size_t firstIndex = binding.divisor == 0 ? indexRange.start : 0; |
Geoff Lang | 38a24a9 | 2017-02-15 13:53:06 -0500 | [diff] [blame] | 332 | |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 333 | // Attributes using client memory ignore the VERTEX_ATTRIB_BINDING state. |
| 334 | // https://www.opengl.org/registry/specs/ARB/vertex_attrib_binding.txt |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 335 | const uint8_t *inputPointer = reinterpret_cast<const uint8_t *>(attrib.pointer); |
| 336 | |
| 337 | // Pack the data when copying it, user could have supplied a very large stride that |
| 338 | // would cause the buffer to be much larger than needed. |
| 339 | if (destStride == sourceStride) |
Jamie Madill | 8e34494 | 2015-07-09 14:22:07 -0400 | [diff] [blame] | 340 | { |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 341 | // Can copy in one go, the data is packed |
Geoff Lang | 38a24a9 | 2017-02-15 13:53:06 -0500 | [diff] [blame] | 342 | memcpy(bufferPointer + curBufferOffset, inputPointer + (sourceStride * firstIndex), |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 343 | destStride * streamedVertexCount); |
Jamie Madill | 6d51c70 | 2015-08-14 10:38:10 -0400 | [diff] [blame] | 344 | } |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 345 | else |
| 346 | { |
| 347 | // Copy each vertex individually |
Geoff Lang | 6b10ddb | 2015-09-02 15:55:10 -0400 | [diff] [blame] | 348 | for (size_t vertexIdx = 0; vertexIdx < streamedVertexCount; vertexIdx++) |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 349 | { |
Corentin Wallez | 4d5362d | 2015-08-25 11:25:14 -0400 | [diff] [blame] | 350 | uint8_t *out = bufferPointer + curBufferOffset + (destStride * vertexIdx); |
Geoff Lang | 38a24a9 | 2017-02-15 13:53:06 -0500 | [diff] [blame] | 351 | const uint8_t *in = inputPointer + sourceStride * (vertexIdx + firstIndex); |
Corentin Wallez | 4d5362d | 2015-08-25 11:25:14 -0400 | [diff] [blame] | 352 | memcpy(out, in, destStride); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 353 | } |
| 354 | } |
| 355 | |
| 356 | // Compute where the 0-index vertex would be. |
Geoff Lang | 38a24a9 | 2017-02-15 13:53:06 -0500 | [diff] [blame] | 357 | const size_t vertexStartOffset = curBufferOffset - (firstIndex * destStride); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 358 | |
Geoff Lang | 2b835a6 | 2015-09-10 15:58:44 -0400 | [diff] [blame] | 359 | if (attrib.pureInteger) |
| 360 | { |
| 361 | ASSERT(!attrib.normalized); |
| 362 | mFunctions->vertexAttribIPointer( |
Corentin Wallez | ca311dd | 2015-12-07 15:07:48 -0500 | [diff] [blame] | 363 | static_cast<GLuint>(idx), attrib.size, attrib.type, |
| 364 | static_cast<GLsizei>(destStride), |
Geoff Lang | 2b835a6 | 2015-09-10 15:58:44 -0400 | [diff] [blame] | 365 | reinterpret_cast<const GLvoid *>(vertexStartOffset)); |
| 366 | } |
| 367 | else |
| 368 | { |
| 369 | mFunctions->vertexAttribPointer( |
Corentin Wallez | ca311dd | 2015-12-07 15:07:48 -0500 | [diff] [blame] | 370 | static_cast<GLuint>(idx), attrib.size, attrib.type, attrib.normalized, |
Geoff Lang | 2b835a6 | 2015-09-10 15:58:44 -0400 | [diff] [blame] | 371 | static_cast<GLsizei>(destStride), |
| 372 | reinterpret_cast<const GLvoid *>(vertexStartOffset)); |
| 373 | } |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 374 | |
| 375 | curBufferOffset += destStride * streamedVertexCount; |
| 376 | |
| 377 | // Mark the applied attribute as dirty by setting an invalid size so that if it doesn't |
| 378 | // need to be streamed later, there is no chance that the caching will skip it. |
| 379 | mAppliedAttributes[idx].size = static_cast<GLuint>(-1); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 380 | } |
| 381 | |
| 382 | unmapResult = mFunctions->unmapBuffer(GL_ARRAY_BUFFER); |
| 383 | } |
| 384 | |
| 385 | if (unmapResult != GL_TRUE) |
| 386 | { |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 387 | return Error(GL_OUT_OF_MEMORY, "Failed to unmap the client data streaming buffer."); |
Geoff Lang | 7c82bc4 | 2015-03-09 16:18:08 -0400 | [diff] [blame] | 388 | } |
| 389 | |
He Yunchao | acd1898 | 2017-01-04 10:46:42 +0800 | [diff] [blame] | 390 | return NoError(); |
Geoff Lang | ba4c4a8 | 2015-02-24 12:38:46 -0500 | [diff] [blame] | 391 | } |
| 392 | |
| 393 | GLuint VertexArrayGL::getVertexArrayID() const |
| 394 | { |
| 395 | return mVertexArrayID; |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 396 | } |
| 397 | |
Geoff Lang | 294cad9 | 2015-05-26 15:11:23 -0400 | [diff] [blame] | 398 | GLuint VertexArrayGL::getAppliedElementArrayBufferID() const |
| 399 | { |
Jamie Madill | 77a90c2 | 2015-08-11 16:33:17 -0400 | [diff] [blame] | 400 | if (mAppliedElementArrayBuffer.get() == nullptr) |
| 401 | { |
| 402 | return mStreamingElementArrayBuffer; |
| 403 | } |
| 404 | |
| 405 | return GetImplAs<BufferGL>(mAppliedElementArrayBuffer.get())->getBufferID(); |
Geoff Lang | 294cad9 | 2015-05-26 15:11:23 -0400 | [diff] [blame] | 406 | } |
| 407 | |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 408 | void VertexArrayGL::updateNeedsStreaming(size_t attribIndex) |
| 409 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 410 | const auto &attrib = mData.getVertexAttribute(attribIndex); |
| 411 | const auto &binding = mData.getBindingFromAttribIndex(attribIndex); |
| 412 | mAttributesNeedStreaming.set(attribIndex, AttributeNeedsStreaming(attrib, binding)); |
Geoff Lang | f9a6f08 | 2015-01-22 13:32:49 -0500 | [diff] [blame] | 413 | } |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 414 | |
| 415 | void VertexArrayGL::updateAttribEnabled(size_t attribIndex) |
| 416 | { |
| 417 | const VertexAttribute &attrib = mData.getVertexAttribute(attribIndex); |
| 418 | if (mAppliedAttributes[attribIndex].enabled == attrib.enabled) |
| 419 | { |
| 420 | return; |
| 421 | } |
| 422 | |
| 423 | updateNeedsStreaming(attribIndex); |
| 424 | |
| 425 | mStateManager->bindVertexArray(mVertexArrayID, getAppliedElementArrayBufferID()); |
| 426 | if (attrib.enabled) |
| 427 | { |
| 428 | mFunctions->enableVertexAttribArray(static_cast<GLuint>(attribIndex)); |
| 429 | } |
| 430 | else |
| 431 | { |
| 432 | mFunctions->disableVertexAttribArray(static_cast<GLuint>(attribIndex)); |
| 433 | } |
| 434 | mAppliedAttributes[attribIndex].enabled = attrib.enabled; |
| 435 | } |
| 436 | |
| 437 | void VertexArrayGL::updateAttribPointer(size_t attribIndex) |
| 438 | { |
| 439 | const VertexAttribute &attrib = mData.getVertexAttribute(attribIndex); |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 440 | ASSERT(attribIndex == attrib.bindingIndex); |
| 441 | |
| 442 | GLuint bindingIndex = attrib.bindingIndex; |
| 443 | const VertexBinding &binding = mData.getVertexBinding(bindingIndex); |
| 444 | |
| 445 | if (mAppliedAttributes[attribIndex] == attrib && mAppliedBindings[bindingIndex] == binding) |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 446 | { |
| 447 | return; |
| 448 | } |
| 449 | |
| 450 | updateNeedsStreaming(attribIndex); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 451 | |
| 452 | // If we need to stream, defer the attribPointer to the draw call. |
| 453 | if (mAttributesNeedStreaming[attribIndex]) |
| 454 | { |
| 455 | return; |
| 456 | } |
| 457 | |
| 458 | mStateManager->bindVertexArray(mVertexArrayID, getAppliedElementArrayBufferID()); |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 459 | const Buffer *arrayBuffer = binding.buffer.get(); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 460 | if (arrayBuffer != nullptr) |
| 461 | { |
| 462 | const BufferGL *arrayBufferGL = GetImplAs<BufferGL>(arrayBuffer); |
| 463 | mStateManager->bindBuffer(GL_ARRAY_BUFFER, arrayBufferGL->getBufferID()); |
| 464 | } |
| 465 | else |
| 466 | { |
| 467 | mStateManager->bindBuffer(GL_ARRAY_BUFFER, 0); |
| 468 | } |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 469 | |
| 470 | mAppliedBindings[bindingIndex].buffer = binding.buffer; |
| 471 | |
| 472 | const GLvoid *inputPointer = nullptr; |
| 473 | if (arrayBuffer != nullptr) |
| 474 | { |
| 475 | inputPointer = static_cast<const GLvoid *>( |
| 476 | reinterpret_cast<const uint8_t *>(binding.offset + attrib.relativeOffset)); |
| 477 | } |
| 478 | else |
| 479 | { |
| 480 | // Attributes using client memory ignore the VERTEX_ATTRIB_BINDING state. |
| 481 | // https://www.opengl.org/registry/specs/ARB/vertex_attrib_binding |
| 482 | inputPointer = attrib.pointer; |
| 483 | } |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 484 | |
| 485 | if (attrib.pureInteger) |
| 486 | { |
| 487 | mFunctions->vertexAttribIPointer(static_cast<GLuint>(attribIndex), attrib.size, attrib.type, |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 488 | binding.stride, inputPointer); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 489 | } |
| 490 | else |
| 491 | { |
| 492 | mFunctions->vertexAttribPointer(static_cast<GLuint>(attribIndex), attrib.size, attrib.type, |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 493 | attrib.normalized, binding.stride, inputPointer); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 494 | } |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 495 | mAppliedAttributes[attribIndex].size = attrib.size; |
| 496 | mAppliedAttributes[attribIndex].type = attrib.type; |
| 497 | mAppliedAttributes[attribIndex].normalized = attrib.normalized; |
| 498 | mAppliedAttributes[attribIndex].pureInteger = attrib.pureInteger; |
| 499 | mAppliedAttributes[attribIndex].pointer = attrib.pointer; |
| 500 | mAppliedAttributes[attribIndex].relativeOffset = attrib.relativeOffset; |
| 501 | mAppliedAttributes[attribIndex].vertexAttribArrayStride = attrib.vertexAttribArrayStride; |
| 502 | |
| 503 | mAppliedBindings[bindingIndex].stride = binding.stride; |
| 504 | mAppliedBindings[bindingIndex].offset = binding.offset; |
| 505 | } |
| 506 | |
| 507 | void VertexArrayGL::updateAttribDivisor(size_t attribIndex) |
| 508 | { |
| 509 | ASSERT(attribIndex == mData.getBindingIndexFromAttribIndex(attribIndex)); |
| 510 | |
| 511 | const VertexBinding &binding = mData.getVertexBinding(attribIndex); |
| 512 | if (mAppliedBindings[attribIndex].divisor != binding.divisor) |
| 513 | { |
| 514 | mStateManager->bindVertexArray(mVertexArrayID, getAppliedElementArrayBufferID()); |
| 515 | mFunctions->vertexAttribDivisor(static_cast<GLuint>(attribIndex), binding.divisor); |
| 516 | |
| 517 | mAppliedBindings[attribIndex].divisor = binding.divisor; |
| 518 | } |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 519 | } |
| 520 | |
| 521 | void VertexArrayGL::syncState(const VertexArray::DirtyBits &dirtyBits) |
| 522 | { |
| 523 | for (unsigned long dirtyBit : angle::IterateBitSet(dirtyBits)) |
| 524 | { |
| 525 | if (dirtyBit == VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER) |
| 526 | { |
| 527 | // TODO(jmadill): Element array buffer bindings |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 528 | continue; |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 529 | } |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 530 | |
| 531 | size_t index = VertexArray::GetAttribIndex(dirtyBit); |
| 532 | if (dirtyBit >= VertexArray::DIRTY_BIT_ATTRIB_0_ENABLED && |
| 533 | dirtyBit < VertexArray::DIRTY_BIT_ATTRIB_MAX_ENABLED) |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 534 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 535 | updateAttribEnabled(index); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 536 | } |
| 537 | else if (dirtyBit >= VertexArray::DIRTY_BIT_ATTRIB_0_POINTER && |
| 538 | dirtyBit < VertexArray::DIRTY_BIT_ATTRIB_MAX_POINTER) |
| 539 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 540 | updateAttribPointer(index); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 541 | } |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 542 | else if (dirtyBit >= VertexArray::DIRTY_BIT_ATTRIB_0_FORMAT && |
| 543 | dirtyBit < VertexArray::DIRTY_BIT_BINDING_MAX_BUFFER) |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 544 | { |
Jiawei-Shao | 2597fb6 | 2016-12-09 16:38:02 +0800 | [diff] [blame] | 545 | // TODO(jiawei.shao@intel.com): Vertex Attrib Bindings |
| 546 | ASSERT(index == mData.getBindingIndexFromAttribIndex(index)); |
| 547 | } |
| 548 | else if (dirtyBit >= VertexArray::DIRTY_BIT_BINDING_0_DIVISOR && |
| 549 | dirtyBit < VertexArray::DIRTY_BIT_BINDING_MAX_DIVISOR) |
| 550 | { |
| 551 | updateAttribDivisor(index); |
Jamie Madill | 0b9e903 | 2015-08-17 11:51:52 +0000 | [diff] [blame] | 552 | } |
| 553 | else |
| 554 | UNREACHABLE(); |
| 555 | } |
| 556 | } |
| 557 | |
| 558 | } // rx |