blob: 20d0a205da48ad7ca7a0e34a61e26097f47218c8 [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES.h: Validation functions for generic OpenGL ES entry point parameters
8
Geoff Lang2b5420c2014-11-19 14:20:15 -05009#include "libANGLE/validationES.h"
10#include "libANGLE/validationES2.h"
11#include "libANGLE/validationES3.h"
12#include "libANGLE/Context.h"
13#include "libANGLE/Texture.h"
14#include "libANGLE/Framebuffer.h"
15#include "libANGLE/FramebufferAttachment.h"
16#include "libANGLE/formatutils.h"
17#include "libANGLE/Query.h"
Geoff Lang7dd2e102014-11-10 15:19:26 -050018#include "libANGLE/Program.h"
19#include "libANGLE/Uniform.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050020#include "libANGLE/TransformFeedback.h"
21#include "libANGLE/VertexArray.h"
22#include "libANGLE/renderer/BufferImpl.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040023
24#include "common/mathutil.h"
25#include "common/utilities.h"
26
Jamie Madill9ae396b2014-10-21 17:46:30 -040027// FIXME(jmadill): remove this when we support buffer data caching
Geoff Lang2b5420c2014-11-19 14:20:15 -050028#include "libANGLE/renderer/d3d/BufferD3D.h"
Jamie Madill9ae396b2014-10-21 17:46:30 -040029
Geoff Lange8ebe7f2013-08-05 15:03:13 -040030namespace gl
31{
32
Geoff Lang0550d032014-01-30 11:29:07 -050033bool ValidCap(const Context *context, GLenum cap)
34{
35 switch (cap)
36 {
37 case GL_CULL_FACE:
38 case GL_POLYGON_OFFSET_FILL:
39 case GL_SAMPLE_ALPHA_TO_COVERAGE:
40 case GL_SAMPLE_COVERAGE:
41 case GL_SCISSOR_TEST:
42 case GL_STENCIL_TEST:
43 case GL_DEPTH_TEST:
44 case GL_BLEND:
45 case GL_DITHER:
46 return true;
47 case GL_PRIMITIVE_RESTART_FIXED_INDEX:
48 case GL_RASTERIZER_DISCARD:
49 return (context->getClientVersion() >= 3);
50 default:
51 return false;
52 }
53}
54
Jamie Madill1fc7e2c2014-01-21 16:47:10 -050055bool ValidTextureTarget(const Context *context, GLenum target)
Jamie Madill35d15012013-10-07 10:46:37 -040056{
Jamie Madilld7460c72014-01-21 16:38:14 -050057 switch (target)
Jamie Madill35d15012013-10-07 10:46:37 -040058 {
Jamie Madilld7460c72014-01-21 16:38:14 -050059 case GL_TEXTURE_2D:
60 case GL_TEXTURE_CUBE_MAP:
61 return true;
Jamie Madill35d15012013-10-07 10:46:37 -040062
Jamie Madilld7460c72014-01-21 16:38:14 -050063 case GL_TEXTURE_3D:
64 case GL_TEXTURE_2D_ARRAY:
65 return (context->getClientVersion() >= 3);
66
67 default:
68 return false;
69 }
Jamie Madill35d15012013-10-07 10:46:37 -040070}
71
Shannon Woods4dfed832014-03-17 20:03:39 -040072// This function differs from ValidTextureTarget in that the target must be
73// usable as the destination of a 2D operation-- so a cube face is valid, but
74// GL_TEXTURE_CUBE_MAP is not.
Jamie Madill560a8d82014-05-21 13:06:20 -040075// Note: duplicate of IsInternalTextureTarget
Shannon Woods4dfed832014-03-17 20:03:39 -040076bool ValidTexture2DDestinationTarget(const Context *context, GLenum target)
77{
78 switch (target)
79 {
80 case GL_TEXTURE_2D:
81 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
82 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
83 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
84 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
85 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
86 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
87 return true;
88 case GL_TEXTURE_2D_ARRAY:
89 case GL_TEXTURE_3D:
90 return (context->getClientVersion() >= 3);
91 default:
92 return false;
93 }
94}
95
Jamie Madill1fc7e2c2014-01-21 16:47:10 -050096bool ValidFramebufferTarget(GLenum target)
97{
98 META_ASSERT(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER && GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER);
99
100 switch (target)
101 {
102 case GL_FRAMEBUFFER: return true;
103 case GL_READ_FRAMEBUFFER: return true;
104 case GL_DRAW_FRAMEBUFFER: return true;
105 default: return false;
106 }
107}
108
Jamie Madill8c96d582014-03-05 15:01:23 -0500109bool ValidBufferTarget(const Context *context, GLenum target)
110{
111 switch (target)
112 {
113 case GL_ARRAY_BUFFER:
114 case GL_ELEMENT_ARRAY_BUFFER:
115 return true;
116
Jamie Madill8c96d582014-03-05 15:01:23 -0500117 case GL_PIXEL_PACK_BUFFER:
118 case GL_PIXEL_UNPACK_BUFFER:
Geoff Langc0b9ef42014-07-02 10:02:37 -0400119 return context->getExtensions().pixelBufferObject;
Shannon Woods158c4382014-05-06 13:00:07 -0400120
Shannon Woodsb3801742014-03-27 14:59:19 -0400121 case GL_COPY_READ_BUFFER:
122 case GL_COPY_WRITE_BUFFER:
Jamie Madill8c96d582014-03-05 15:01:23 -0500123 case GL_TRANSFORM_FEEDBACK_BUFFER:
124 case GL_UNIFORM_BUFFER:
125 return (context->getClientVersion() >= 3);
126
127 default:
128 return false;
129 }
130}
131
Jamie Madill70656a62014-03-05 15:01:26 -0500132bool ValidBufferParameter(const Context *context, GLenum pname)
133{
134 switch (pname)
135 {
136 case GL_BUFFER_USAGE:
137 case GL_BUFFER_SIZE:
138 return true;
139
140 // GL_BUFFER_MAP_POINTER is a special case, and may only be
141 // queried with GetBufferPointerv
142 case GL_BUFFER_ACCESS_FLAGS:
143 case GL_BUFFER_MAPPED:
144 case GL_BUFFER_MAP_OFFSET:
145 case GL_BUFFER_MAP_LENGTH:
146 return (context->getClientVersion() >= 3);
147
148 default:
149 return false;
150 }
151}
152
Jamie Madill8c96d582014-03-05 15:01:23 -0500153bool ValidMipLevel(const Context *context, GLenum target, GLint level)
Geoff Langce635692013-09-24 13:56:32 -0400154{
Geoff Langaae65a42014-05-26 12:43:44 -0400155 size_t maxDimension = 0;
Geoff Langce635692013-09-24 13:56:32 -0400156 switch (target)
157 {
Geoff Langaae65a42014-05-26 12:43:44 -0400158 case GL_TEXTURE_2D: maxDimension = context->getCaps().max2DTextureSize; break;
Geoff Langce635692013-09-24 13:56:32 -0400159 case GL_TEXTURE_CUBE_MAP:
160 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
161 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
162 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
163 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
164 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
Geoff Langaae65a42014-05-26 12:43:44 -0400165 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: maxDimension = context->getCaps().maxCubeMapTextureSize; break;
166 case GL_TEXTURE_3D: maxDimension = context->getCaps().max3DTextureSize; break;
167 case GL_TEXTURE_2D_ARRAY: maxDimension = context->getCaps().max2DTextureSize; break;
Geoff Langce635692013-09-24 13:56:32 -0400168 default: UNREACHABLE();
169 }
170
Geoff Langaae65a42014-05-26 12:43:44 -0400171 return level <= gl::log2(maxDimension);
Geoff Langce635692013-09-24 13:56:32 -0400172}
173
Geoff Langb1196682014-07-23 13:47:29 -0400174bool ValidImageSize(const Context *context, GLenum target, GLint level,
Jamie Madill4fd75c12014-06-23 10:53:54 -0400175 GLsizei width, GLsizei height, GLsizei depth)
Geoff Langce635692013-09-24 13:56:32 -0400176{
177 if (level < 0 || width < 0 || height < 0 || depth < 0)
178 {
179 return false;
180 }
181
Geoff Langc0b9ef42014-07-02 10:02:37 -0400182 if (!context->getExtensions().textureNPOT &&
Jamie Madill4fd75c12014-06-23 10:53:54 -0400183 (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth))))
Geoff Langce635692013-09-24 13:56:32 -0400184 {
185 return false;
186 }
187
188 if (!ValidMipLevel(context, target, level))
189 {
190 return false;
191 }
192
193 return true;
194}
195
Geoff Langb1196682014-07-23 13:47:29 -0400196bool ValidCompressedImageSize(const Context *context, GLenum internalFormat, GLsizei width, GLsizei height)
Geoff Langd4f180b2013-09-24 13:57:44 -0400197{
Geoff Lang5d601382014-07-22 15:14:06 -0400198 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalFormat);
199 if (!formatInfo.compressed)
Geoff Langd4f180b2013-09-24 13:57:44 -0400200 {
201 return false;
202 }
203
Geoff Lang5d601382014-07-22 15:14:06 -0400204 if (width < 0 || (static_cast<GLuint>(width) > formatInfo.compressedBlockWidth && width % formatInfo.compressedBlockWidth != 0) ||
205 height < 0 || (static_cast<GLuint>(height) > formatInfo.compressedBlockHeight && height % formatInfo.compressedBlockHeight != 0))
Geoff Langd4f180b2013-09-24 13:57:44 -0400206 {
207 return false;
208 }
209
210 return true;
211}
212
Geoff Lang37dde692014-01-31 16:34:54 -0500213bool ValidQueryType(const Context *context, GLenum queryType)
214{
215 META_ASSERT(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT);
216 META_ASSERT(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT);
217
218 switch (queryType)
219 {
220 case GL_ANY_SAMPLES_PASSED:
221 case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
222 return true;
223 case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
224 return (context->getClientVersion() >= 3);
225 default:
226 return false;
227 }
228}
229
Geoff Langb1196682014-07-23 13:47:29 -0400230bool ValidProgram(Context *context, GLuint id)
Geoff Lang48dcae72014-02-05 16:28:24 -0500231{
232 // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will generate the
233 // error INVALID_VALUE if the provided name is not the name of either a shader or program object and
234 // INVALID_OPERATION if the provided name identifies an object that is not the expected type."
235
236 if (context->getProgram(id) != NULL)
237 {
238 return true;
239 }
240 else if (context->getShader(id) != NULL)
241 {
242 // ID is the wrong type
Geoff Langb1196682014-07-23 13:47:29 -0400243 context->recordError(Error(GL_INVALID_OPERATION));
244 return false;
Geoff Lang48dcae72014-02-05 16:28:24 -0500245 }
246 else
247 {
248 // No shader/program object has this ID
Geoff Langb1196682014-07-23 13:47:29 -0400249 context->recordError(Error(GL_INVALID_VALUE));
250 return false;
Geoff Lang48dcae72014-02-05 16:28:24 -0500251 }
252}
253
Geoff Langb1196682014-07-23 13:47:29 -0400254bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment)
Jamie Madillb4472272014-07-03 10:38:55 -0400255{
256 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
257 {
258 const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT);
259
Geoff Langaae65a42014-05-26 12:43:44 -0400260 if (colorAttachment >= context->getCaps().maxColorAttachments)
Jamie Madillb4472272014-07-03 10:38:55 -0400261 {
Geoff Langb1196682014-07-23 13:47:29 -0400262 context->recordError(Error(GL_INVALID_VALUE));
263 return false;
Jamie Madillb4472272014-07-03 10:38:55 -0400264 }
265 }
266 else
267 {
268 switch (attachment)
269 {
270 case GL_DEPTH_ATTACHMENT:
271 case GL_STENCIL_ATTACHMENT:
272 break;
273
274 case GL_DEPTH_STENCIL_ATTACHMENT:
275 if (context->getClientVersion() < 3)
276 {
Geoff Langb1196682014-07-23 13:47:29 -0400277 context->recordError(Error(GL_INVALID_ENUM));
278 return false;
Jamie Madillb4472272014-07-03 10:38:55 -0400279 }
280 break;
281
282 default:
Geoff Langb1196682014-07-23 13:47:29 -0400283 context->recordError(Error(GL_INVALID_ENUM));
284 return false;
Jamie Madillb4472272014-07-03 10:38:55 -0400285 }
286 }
287
288 return true;
289}
290
Corentin Walleze0902642014-11-04 12:32:15 -0800291bool ValidateRenderbufferStorageParametersBase(gl::Context *context, GLenum target, GLsizei samples,
292 GLenum internalformat, GLsizei width, GLsizei height)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400293{
294 switch (target)
295 {
296 case GL_RENDERBUFFER:
297 break;
298 default:
Geoff Langb1196682014-07-23 13:47:29 -0400299 context->recordError(Error(GL_INVALID_ENUM));
300 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400301 }
302
303 if (width < 0 || height < 0 || samples < 0)
304 {
Geoff Langb1196682014-07-23 13:47:29 -0400305 context->recordError(Error(GL_INVALID_VALUE));
306 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400307 }
308
Geoff Langd87878e2014-09-19 15:42:59 -0400309 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
310 if (!formatCaps.renderable)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400311 {
Geoff Langb1196682014-07-23 13:47:29 -0400312 context->recordError(Error(GL_INVALID_ENUM));
313 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400314 }
315
316 // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be
317 // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains
Corentin Walleze0902642014-11-04 12:32:15 -0800318 // only sized internal formats.
Geoff Langd87878e2014-09-19 15:42:59 -0400319 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat);
Geoff Lang5d601382014-07-22 15:14:06 -0400320 if (formatInfo.pixelBytes == 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400321 {
Geoff Langb1196682014-07-23 13:47:29 -0400322 context->recordError(Error(GL_INVALID_ENUM));
323 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400324 }
325
Geoff Langaae65a42014-05-26 12:43:44 -0400326 if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400327 {
Geoff Langb1196682014-07-23 13:47:29 -0400328 context->recordError(Error(GL_INVALID_VALUE));
329 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400330 }
331
Shannon Woods53a94a82014-06-24 15:20:36 -0400332 GLuint handle = context->getState().getRenderbufferId();
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400333 if (handle == 0)
334 {
Geoff Langb1196682014-07-23 13:47:29 -0400335 context->recordError(Error(GL_INVALID_OPERATION));
336 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400337 }
338
339 return true;
340}
341
Corentin Walleze0902642014-11-04 12:32:15 -0800342bool ValidateRenderbufferStorageParametersANGLE(gl::Context *context, GLenum target, GLsizei samples,
343 GLenum internalformat, GLsizei width, GLsizei height)
344{
345 ASSERT(context->getExtensions().framebufferMultisample);
346
347 // ANGLE_framebuffer_multisample states that the value of samples must be less than or equal
348 // to MAX_SAMPLES_ANGLE (Context::getExtensions().maxSamples) otherwise GL_INVALID_VALUE is
349 // generated.
350 if (static_cast<GLuint>(samples) > context->getExtensions().maxSamples)
351 {
352 context->recordError(Error(GL_INVALID_VALUE));
353 return false;
354 }
355
356 // ANGLE_framebuffer_multisample states GL_OUT_OF_MEMORY is generated on a failure to create
357 // the specified storage. This is different than ES 3.0 in which a sample number higher
358 // than the maximum sample number supported by this format generates a GL_INVALID_VALUE.
359 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
360 if (static_cast<GLuint>(samples) > formatCaps.getMaxSamples())
361 {
362 context->recordError(Error(GL_OUT_OF_MEMORY));
363 return false;
364 }
365
366 return ValidateRenderbufferStorageParametersBase(context, target, samples, internalformat, width, height);
367}
368
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500369bool ValidateFramebufferRenderbufferParameters(gl::Context *context, GLenum target, GLenum attachment,
370 GLenum renderbuffertarget, GLuint renderbuffer)
371{
Shannon Woods1da3cf62014-06-27 15:32:23 -0400372 if (!ValidFramebufferTarget(target))
373 {
Geoff Langb1196682014-07-23 13:47:29 -0400374 context->recordError(Error(GL_INVALID_ENUM));
375 return false;
Shannon Woods1da3cf62014-06-27 15:32:23 -0400376 }
377
Shannon Woods53a94a82014-06-24 15:20:36 -0400378 gl::Framebuffer *framebuffer = context->getState().getTargetFramebuffer(target);
379 GLuint framebufferHandle = context->getState().getTargetFramebuffer(target)->id();
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500380
381 if (!framebuffer || (framebufferHandle == 0 && renderbuffer != 0))
382 {
Geoff Langb1196682014-07-23 13:47:29 -0400383 context->recordError(Error(GL_INVALID_OPERATION));
384 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500385 }
386
Jamie Madillb4472272014-07-03 10:38:55 -0400387 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500388 {
Jamie Madillb4472272014-07-03 10:38:55 -0400389 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500390 }
391
Jamie Madillab9d82c2014-01-21 16:38:14 -0500392 // [OpenGL ES 2.0.25] Section 4.4.3 page 112
393 // [OpenGL ES 3.0.2] Section 4.4.2 page 201
394 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of
395 // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated.
396 if (renderbuffer != 0)
397 {
398 if (!context->getRenderbuffer(renderbuffer))
399 {
Geoff Langb1196682014-07-23 13:47:29 -0400400 context->recordError(Error(GL_INVALID_OPERATION));
401 return false;
Jamie Madillab9d82c2014-01-21 16:38:14 -0500402 }
403 }
404
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500405 return true;
406}
407
Jamie Madill3c7fa222014-06-05 13:08:51 -0400408static bool IsPartialBlit(gl::Context *context, gl::FramebufferAttachment *readBuffer, gl::FramebufferAttachment *writeBuffer,
Geoff Lang125deab2013-08-09 13:34:16 -0400409 GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1,
410 GLint dstX0, GLint dstY0, GLint dstX1, GLint dstY1)
411{
412 if (srcX0 != 0 || srcY0 != 0 || dstX0 != 0 || dstY0 != 0 ||
413 dstX1 != writeBuffer->getWidth() || dstY1 != writeBuffer->getHeight() ||
414 srcX1 != readBuffer->getWidth() || srcY1 != readBuffer->getHeight())
415 {
416 return true;
417 }
Shannon Woods53a94a82014-06-24 15:20:36 -0400418 else if (context->getState().isScissorTestEnabled())
Geoff Lang125deab2013-08-09 13:34:16 -0400419 {
Shannon Woods53a94a82014-06-24 15:20:36 -0400420 const Rectangle &scissor = context->getState().getScissor();
Geoff Lang125deab2013-08-09 13:34:16 -0400421
Shannon Woods53a94a82014-06-24 15:20:36 -0400422 return scissor.x > 0 || scissor.y > 0 ||
423 scissor.width < writeBuffer->getWidth() ||
424 scissor.height < writeBuffer->getHeight();
Geoff Lang125deab2013-08-09 13:34:16 -0400425 }
426 else
427 {
428 return false;
429 }
430}
431
Geoff Lang34dbb6f2013-08-05 15:05:47 -0400432bool ValidateBlitFramebufferParameters(gl::Context *context, GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1,
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400433 GLint dstX0, GLint dstY0, GLint dstX1, GLint dstY1, GLbitfield mask,
434 GLenum filter, bool fromAngleExtension)
435{
436 switch (filter)
437 {
438 case GL_NEAREST:
439 break;
440 case GL_LINEAR:
441 if (fromAngleExtension)
442 {
Geoff Langb1196682014-07-23 13:47:29 -0400443 context->recordError(Error(GL_INVALID_ENUM));
444 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400445 }
446 break;
447 default:
Geoff Langb1196682014-07-23 13:47:29 -0400448 context->recordError(Error(GL_INVALID_ENUM));
449 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400450 }
451
452 if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0)
453 {
Geoff Langb1196682014-07-23 13:47:29 -0400454 context->recordError(Error(GL_INVALID_VALUE));
455 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400456 }
457
458 if (mask == 0)
459 {
460 // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no
461 // buffers are copied.
462 return false;
463 }
464
465 if (fromAngleExtension && (srcX1 - srcX0 != dstX1 - dstX0 || srcY1 - srcY0 != dstY1 - dstY0))
466 {
467 ERR("Scaling and flipping in BlitFramebufferANGLE not supported by this implementation.");
Geoff Langb1196682014-07-23 13:47:29 -0400468 context->recordError(Error(GL_INVALID_OPERATION));
469 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400470 }
471
472 // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the
473 // color buffer, leaving only nearest being unfiltered from above
474 if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST)
475 {
Geoff Langb1196682014-07-23 13:47:29 -0400476 context->recordError(Error(GL_INVALID_OPERATION));
477 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400478 }
479
Shannon Woods53a94a82014-06-24 15:20:36 -0400480 if (context->getState().getReadFramebuffer()->id() == context->getState().getDrawFramebuffer()->id())
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400481 {
482 if (fromAngleExtension)
483 {
484 ERR("Blits with the same source and destination framebuffer are not supported by this "
485 "implementation.");
486 }
Geoff Langb1196682014-07-23 13:47:29 -0400487 context->recordError(Error(GL_INVALID_OPERATION));
488 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400489 }
490
Shannon Woods53a94a82014-06-24 15:20:36 -0400491 gl::Framebuffer *readFramebuffer = context->getState().getReadFramebuffer();
492 gl::Framebuffer *drawFramebuffer = context->getState().getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -0500493
494 if (!readFramebuffer || !drawFramebuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400495 {
Geoff Langb1196682014-07-23 13:47:29 -0400496 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
497 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400498 }
499
Geoff Lang748f74e2014-12-01 11:25:34 -0500500 if (!readFramebuffer->checkStatus(context->getData()))
Jamie Madill48faf802014-11-06 15:27:22 -0500501 {
502 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
503 return false;
504 }
505
Geoff Lang748f74e2014-12-01 11:25:34 -0500506 if (!drawFramebuffer->checkStatus(context->getData()))
Jamie Madill48faf802014-11-06 15:27:22 -0500507 {
508 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
509 return false;
510 }
511
512 if (drawFramebuffer->getSamples(context->getData()) != 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400513 {
Geoff Langb1196682014-07-23 13:47:29 -0400514 context->recordError(Error(GL_INVALID_OPERATION));
515 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400516 }
517
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400518 bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1;
519
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400520 if (mask & GL_COLOR_BUFFER_BIT)
521 {
Jamie Madill3c7fa222014-06-05 13:08:51 -0400522 gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer();
523 gl::FramebufferAttachment *drawColorBuffer = drawFramebuffer->getFirstColorbuffer();
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400524
525 if (readColorBuffer && drawColorBuffer)
526 {
Geoff Lang005df412013-10-16 14:12:50 -0400527 GLenum readInternalFormat = readColorBuffer->getActualFormat();
Geoff Lang5d601382014-07-22 15:14:06 -0400528 const InternalFormat &readFormatInfo = GetInternalFormatInfo(readInternalFormat);
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400529
530 for (unsigned int i = 0; i < gl::IMPLEMENTATION_MAX_DRAW_BUFFERS; i++)
531 {
532 if (drawFramebuffer->isEnabledColorAttachment(i))
533 {
Geoff Lang005df412013-10-16 14:12:50 -0400534 GLenum drawInternalFormat = drawFramebuffer->getColorbuffer(i)->getActualFormat();
Geoff Lang5d601382014-07-22 15:14:06 -0400535 const InternalFormat &drawFormatInfo = GetInternalFormatInfo(drawInternalFormat);
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400536
Geoff Langb2f3d052013-08-13 12:49:27 -0400537 // The GL ES 3.0.2 spec (pg 193) states that:
538 // 1) If the read buffer is fixed point format, the draw buffer must be as well
539 // 2) If the read buffer is an unsigned integer format, the draw buffer must be as well
540 // 3) If the read buffer is a signed integer format, the draw buffer must be as well
Geoff Lang5d601382014-07-22 15:14:06 -0400541 if ( (readFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || readFormatInfo.componentType == GL_SIGNED_NORMALIZED) &&
542 !(drawFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || drawFormatInfo.componentType == GL_SIGNED_NORMALIZED))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400543 {
Geoff Langb1196682014-07-23 13:47:29 -0400544 context->recordError(Error(GL_INVALID_OPERATION));
545 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400546 }
547
Geoff Lang5d601382014-07-22 15:14:06 -0400548 if (readFormatInfo.componentType == GL_UNSIGNED_INT && drawFormatInfo.componentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400549 {
Geoff Langb1196682014-07-23 13:47:29 -0400550 context->recordError(Error(GL_INVALID_OPERATION));
551 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400552 }
553
Geoff Lang5d601382014-07-22 15:14:06 -0400554 if (readFormatInfo.componentType == GL_INT && drawFormatInfo.componentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400555 {
Geoff Langb1196682014-07-23 13:47:29 -0400556 context->recordError(Error(GL_INVALID_OPERATION));
557 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400558 }
559
Geoff Langb2f3d052013-08-13 12:49:27 -0400560 if (readColorBuffer->getSamples() > 0 && (readInternalFormat != drawInternalFormat || !sameBounds))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400561 {
Geoff Langb1196682014-07-23 13:47:29 -0400562 context->recordError(Error(GL_INVALID_OPERATION));
563 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400564 }
565 }
566 }
567
Geoff Lang5d601382014-07-22 15:14:06 -0400568 if ((readFormatInfo.componentType == GL_INT || readFormatInfo.componentType == GL_UNSIGNED_INT) && filter == GL_LINEAR)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400569 {
Geoff Langb1196682014-07-23 13:47:29 -0400570 context->recordError(Error(GL_INVALID_OPERATION));
571 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400572 }
573
574 if (fromAngleExtension)
575 {
Geoff Lang6a1e6b92014-11-06 10:42:45 -0500576 FramebufferAttachment *readColorAttachment = readFramebuffer->getReadColorbuffer();
577 if (!readColorAttachment ||
578 (!(readColorAttachment->type() == GL_TEXTURE && readColorAttachment->getTextureImageIndex()->type == GL_TEXTURE_2D) &&
579 readColorAttachment->type() != GL_RENDERBUFFER &&
580 readColorAttachment->type() != GL_FRAMEBUFFER_DEFAULT))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400581 {
Geoff Langb1196682014-07-23 13:47:29 -0400582 context->recordError(Error(GL_INVALID_OPERATION));
583 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400584 }
585
586 for (unsigned int colorAttachment = 0; colorAttachment < gl::IMPLEMENTATION_MAX_DRAW_BUFFERS; colorAttachment++)
587 {
588 if (drawFramebuffer->isEnabledColorAttachment(colorAttachment))
589 {
Jamie Madille92a3542014-07-03 10:38:58 -0400590 FramebufferAttachment *attachment = drawFramebuffer->getColorbuffer(colorAttachment);
591 ASSERT(attachment);
592
Geoff Lang6a1e6b92014-11-06 10:42:45 -0500593 if (!(attachment->type() == GL_TEXTURE && attachment->getTextureImageIndex()->type == GL_TEXTURE_2D) &&
594 attachment->type() != GL_RENDERBUFFER &&
595 attachment->type() != GL_FRAMEBUFFER_DEFAULT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400596 {
Geoff Langb1196682014-07-23 13:47:29 -0400597 context->recordError(Error(GL_INVALID_OPERATION));
598 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400599 }
600
Jamie Madillf8f18f02014-10-02 10:44:17 -0400601 // Return an error if the destination formats do not match
602 if (attachment->getInternalFormat() != readColorBuffer->getInternalFormat())
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400603 {
Geoff Langb1196682014-07-23 13:47:29 -0400604 context->recordError(Error(GL_INVALID_OPERATION));
605 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400606 }
607 }
608 }
Jamie Madill48faf802014-11-06 15:27:22 -0500609
610 int readSamples = readFramebuffer->getSamples(context->getData());
611
612 if (readSamples != 0 && IsPartialBlit(context, readColorBuffer, drawColorBuffer,
613 srcX0, srcY0, srcX1, srcY1,
614 dstX0, dstY0, dstX1, dstY1))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400615 {
Geoff Langb1196682014-07-23 13:47:29 -0400616 context->recordError(Error(GL_INVALID_OPERATION));
617 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400618 }
619 }
620 }
621 }
622
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200623 GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT};
624 GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT};
625 for (size_t i = 0; i < 2; i++)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400626 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200627 if (mask & masks[i])
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400628 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200629 gl::FramebufferAttachment *readBuffer = readFramebuffer->getAttachment(attachments[i]);
630 gl::FramebufferAttachment *drawBuffer = drawFramebuffer->getAttachment(attachments[i]);
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400631
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200632 if (readBuffer && drawBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400633 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200634 if (readBuffer->getActualFormat() != drawBuffer->getActualFormat())
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400635 {
Geoff Langb1196682014-07-23 13:47:29 -0400636 context->recordError(Error(GL_INVALID_OPERATION));
637 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400638 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400639
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200640 if (readBuffer->getSamples() > 0 && !sameBounds)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400641 {
Geoff Langb1196682014-07-23 13:47:29 -0400642 context->recordError(Error(GL_INVALID_OPERATION));
643 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400644 }
Dongseong Hwang44b422c2014-12-09 15:42:01 +0200645
646 if (fromAngleExtension)
647 {
648 if (IsPartialBlit(context, readBuffer, drawBuffer,
649 srcX0, srcY0, srcX1, srcY1, dstX0, dstY0, dstX1, dstY1))
650 {
651 ERR("Only whole-buffer depth and stencil blits are supported by this implementation.");
652 context->recordError(Error(GL_INVALID_OPERATION)); // only whole-buffer copies are permitted
653 return false;
654 }
655
656 if (readBuffer->getSamples() != 0 || drawBuffer->getSamples() != 0)
657 {
658 context->recordError(Error(GL_INVALID_OPERATION));
659 return false;
660 }
661 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400662 }
663 }
664 }
665
666 return true;
667}
668
Geoff Langb1196682014-07-23 13:47:29 -0400669bool ValidateGetVertexAttribParameters(Context *context, GLenum pname)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400670{
671 switch (pname)
672 {
673 case GL_VERTEX_ATTRIB_ARRAY_ENABLED:
674 case GL_VERTEX_ATTRIB_ARRAY_SIZE:
675 case GL_VERTEX_ATTRIB_ARRAY_STRIDE:
676 case GL_VERTEX_ATTRIB_ARRAY_TYPE:
677 case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED:
678 case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:
679 case GL_CURRENT_VERTEX_ATTRIB:
680 return true;
681
682 case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:
683 // Don't verify ES3 context because GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE uses
684 // the same constant.
685 META_ASSERT(GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE);
686 return true;
687
688 case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
Geoff Langb1196682014-07-23 13:47:29 -0400689 if (context->getClientVersion() < 3)
690 {
691 context->recordError(Error(GL_INVALID_ENUM));
692 return false;
693 }
694 return true;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400695
696 default:
Geoff Langb1196682014-07-23 13:47:29 -0400697 context->recordError(Error(GL_INVALID_ENUM));
698 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400699 }
700}
701
Geoff Lang34dbb6f2013-08-05 15:05:47 -0400702bool ValidateTexParamParameters(gl::Context *context, GLenum pname, GLint param)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400703{
704 switch (pname)
705 {
706 case GL_TEXTURE_WRAP_R:
707 case GL_TEXTURE_SWIZZLE_R:
708 case GL_TEXTURE_SWIZZLE_G:
709 case GL_TEXTURE_SWIZZLE_B:
710 case GL_TEXTURE_SWIZZLE_A:
711 case GL_TEXTURE_BASE_LEVEL:
712 case GL_TEXTURE_MAX_LEVEL:
713 case GL_TEXTURE_COMPARE_MODE:
714 case GL_TEXTURE_COMPARE_FUNC:
715 case GL_TEXTURE_MIN_LOD:
716 case GL_TEXTURE_MAX_LOD:
717 if (context->getClientVersion() < 3)
718 {
Geoff Langb1196682014-07-23 13:47:29 -0400719 context->recordError(Error(GL_INVALID_ENUM));
720 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400721 }
722 break;
723
724 default: break;
725 }
726
727 switch (pname)
728 {
729 case GL_TEXTURE_WRAP_S:
730 case GL_TEXTURE_WRAP_T:
731 case GL_TEXTURE_WRAP_R:
732 switch (param)
733 {
734 case GL_REPEAT:
735 case GL_CLAMP_TO_EDGE:
736 case GL_MIRRORED_REPEAT:
737 return true;
738 default:
Geoff Langb1196682014-07-23 13:47:29 -0400739 context->recordError(Error(GL_INVALID_ENUM));
740 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400741 }
742
743 case GL_TEXTURE_MIN_FILTER:
744 switch (param)
745 {
746 case GL_NEAREST:
747 case GL_LINEAR:
748 case GL_NEAREST_MIPMAP_NEAREST:
749 case GL_LINEAR_MIPMAP_NEAREST:
750 case GL_NEAREST_MIPMAP_LINEAR:
751 case GL_LINEAR_MIPMAP_LINEAR:
752 return true;
753 default:
Geoff Langb1196682014-07-23 13:47:29 -0400754 context->recordError(Error(GL_INVALID_ENUM));
755 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400756 }
757 break;
758
759 case GL_TEXTURE_MAG_FILTER:
760 switch (param)
761 {
762 case GL_NEAREST:
763 case GL_LINEAR:
764 return true;
765 default:
Geoff Langb1196682014-07-23 13:47:29 -0400766 context->recordError(Error(GL_INVALID_ENUM));
767 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400768 }
769 break;
770
771 case GL_TEXTURE_USAGE_ANGLE:
772 switch (param)
773 {
774 case GL_NONE:
775 case GL_FRAMEBUFFER_ATTACHMENT_ANGLE:
776 return true;
777 default:
Geoff Langb1196682014-07-23 13:47:29 -0400778 context->recordError(Error(GL_INVALID_ENUM));
779 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400780 }
781 break;
782
783 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
Geoff Langc0b9ef42014-07-02 10:02:37 -0400784 if (!context->getExtensions().textureFilterAnisotropic)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400785 {
Geoff Langb1196682014-07-23 13:47:29 -0400786 context->recordError(Error(GL_INVALID_ENUM));
787 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400788 }
789
790 // we assume the parameter passed to this validation method is truncated, not rounded
791 if (param < 1)
792 {
Geoff Langb1196682014-07-23 13:47:29 -0400793 context->recordError(Error(GL_INVALID_VALUE));
794 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400795 }
796 return true;
797
798 case GL_TEXTURE_MIN_LOD:
799 case GL_TEXTURE_MAX_LOD:
800 // any value is permissible
801 return true;
802
803 case GL_TEXTURE_COMPARE_MODE:
Geoff Lang63b5f1f2013-09-23 14:52:14 -0400804 // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400805 switch (param)
806 {
807 case GL_NONE:
808 case GL_COMPARE_REF_TO_TEXTURE:
809 return true;
810 default:
Geoff Langb1196682014-07-23 13:47:29 -0400811 context->recordError(Error(GL_INVALID_ENUM));
812 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400813 }
814 break;
815
816 case GL_TEXTURE_COMPARE_FUNC:
Geoff Lang63b5f1f2013-09-23 14:52:14 -0400817 // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400818 switch (param)
819 {
820 case GL_LEQUAL:
821 case GL_GEQUAL:
822 case GL_LESS:
823 case GL_GREATER:
824 case GL_EQUAL:
825 case GL_NOTEQUAL:
826 case GL_ALWAYS:
827 case GL_NEVER:
828 return true;
829 default:
Geoff Langb1196682014-07-23 13:47:29 -0400830 context->recordError(Error(GL_INVALID_ENUM));
831 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400832 }
833 break;
834
835 case GL_TEXTURE_SWIZZLE_R:
836 case GL_TEXTURE_SWIZZLE_G:
837 case GL_TEXTURE_SWIZZLE_B:
838 case GL_TEXTURE_SWIZZLE_A:
Geoff Langbc90a482013-09-17 16:51:27 -0400839 switch (param)
840 {
841 case GL_RED:
842 case GL_GREEN:
843 case GL_BLUE:
844 case GL_ALPHA:
845 case GL_ZERO:
846 case GL_ONE:
847 return true;
848 default:
Geoff Langb1196682014-07-23 13:47:29 -0400849 context->recordError(Error(GL_INVALID_ENUM));
850 return false;
Geoff Langbc90a482013-09-17 16:51:27 -0400851 }
852 break;
853
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400854 case GL_TEXTURE_BASE_LEVEL:
855 case GL_TEXTURE_MAX_LEVEL:
Nicolas Capens8de68282014-04-04 11:10:27 -0400856 if (param < 0)
857 {
Geoff Langb1196682014-07-23 13:47:29 -0400858 context->recordError(Error(GL_INVALID_VALUE));
859 return false;
Nicolas Capens8de68282014-04-04 11:10:27 -0400860 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400861 return true;
862
863 default:
Geoff Langb1196682014-07-23 13:47:29 -0400864 context->recordError(Error(GL_INVALID_ENUM));
865 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400866 }
867}
868
Geoff Langb1196682014-07-23 13:47:29 -0400869bool ValidateSamplerObjectParameter(gl::Context *context, GLenum pname)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400870{
871 switch (pname)
872 {
873 case GL_TEXTURE_MIN_FILTER:
874 case GL_TEXTURE_MAG_FILTER:
875 case GL_TEXTURE_WRAP_S:
876 case GL_TEXTURE_WRAP_T:
877 case GL_TEXTURE_WRAP_R:
878 case GL_TEXTURE_MIN_LOD:
879 case GL_TEXTURE_MAX_LOD:
880 case GL_TEXTURE_COMPARE_MODE:
881 case GL_TEXTURE_COMPARE_FUNC:
882 return true;
883
884 default:
Geoff Langb1196682014-07-23 13:47:29 -0400885 context->recordError(Error(GL_INVALID_ENUM));
886 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400887 }
888}
889
Jamie Madill26e91952014-03-05 15:01:27 -0500890bool ValidateReadPixelsParameters(gl::Context *context, GLint x, GLint y, GLsizei width, GLsizei height,
891 GLenum format, GLenum type, GLsizei *bufSize, GLvoid *pixels)
892{
Shannon Woods53a94a82014-06-24 15:20:36 -0400893 gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer();
Jamie Madill893ab082014-05-16 16:56:10 -0400894 ASSERT(framebuffer);
Jamie Madill26e91952014-03-05 15:01:27 -0500895
Geoff Lang748f74e2014-12-01 11:25:34 -0500896 if (framebuffer->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill26e91952014-03-05 15:01:27 -0500897 {
Geoff Langb1196682014-07-23 13:47:29 -0400898 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
899 return false;
Jamie Madill26e91952014-03-05 15:01:27 -0500900 }
901
Jamie Madill48faf802014-11-06 15:27:22 -0500902 if (context->getState().getReadFramebuffer()->id() != 0 &&
903 framebuffer->getSamples(context->getData()) != 0)
Jamie Madill26e91952014-03-05 15:01:27 -0500904 {
Geoff Langb1196682014-07-23 13:47:29 -0400905 context->recordError(Error(GL_INVALID_OPERATION));
906 return false;
Jamie Madill26e91952014-03-05 15:01:27 -0500907 }
908
Jamie Madill893ab082014-05-16 16:56:10 -0400909 if (!framebuffer->getReadColorbuffer())
910 {
Geoff Langb1196682014-07-23 13:47:29 -0400911 context->recordError(Error(GL_INVALID_OPERATION));
912 return false;
Jamie Madill893ab082014-05-16 16:56:10 -0400913 }
914
Jamie Madill26e91952014-03-05 15:01:27 -0500915 GLenum currentInternalFormat, currentFormat, currentType;
Geoff Lange4a492b2014-06-19 14:14:41 -0400916 GLuint clientVersion = context->getClientVersion();
Jamie Madill26e91952014-03-05 15:01:27 -0500917
Jamie Madill893ab082014-05-16 16:56:10 -0400918 context->getCurrentReadFormatType(&currentInternalFormat, &currentFormat, &currentType);
Jamie Madill26e91952014-03-05 15:01:27 -0500919
Geoff Langbdc9b2f2014-04-16 14:41:54 -0400920 bool validReadFormat = (clientVersion < 3) ? ValidES2ReadFormatType(context, format, type) :
921 ValidES3ReadFormatType(context, currentInternalFormat, format, type);
Jamie Madill26e91952014-03-05 15:01:27 -0500922
923 if (!(currentFormat == format && currentType == type) && !validReadFormat)
924 {
Geoff Langb1196682014-07-23 13:47:29 -0400925 context->recordError(Error(GL_INVALID_OPERATION));
926 return false;
Jamie Madill26e91952014-03-05 15:01:27 -0500927 }
928
Geoff Lang5d601382014-07-22 15:14:06 -0400929 GLenum sizedInternalFormat = GetSizedInternalFormat(format, type);
930 const InternalFormat &sizedFormatInfo = GetInternalFormatInfo(sizedInternalFormat);
Jamie Madill26e91952014-03-05 15:01:27 -0500931
Geoff Lang5d601382014-07-22 15:14:06 -0400932 GLsizei outputPitch = sizedFormatInfo.computeRowPitch(type, width, context->getState().getPackAlignment());
Jamie Madill26e91952014-03-05 15:01:27 -0500933 // sized query sanity check
934 if (bufSize)
935 {
936 int requiredSize = outputPitch * height;
937 if (requiredSize > *bufSize)
938 {
Geoff Langb1196682014-07-23 13:47:29 -0400939 context->recordError(Error(GL_INVALID_OPERATION));
940 return false;
Jamie Madill26e91952014-03-05 15:01:27 -0500941 }
942 }
943
944 return true;
945}
946
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400947bool ValidateBeginQuery(gl::Context *context, GLenum target, GLuint id)
948{
949 if (!ValidQueryType(context, target))
950 {
Geoff Langb1196682014-07-23 13:47:29 -0400951 context->recordError(Error(GL_INVALID_ENUM));
952 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400953 }
954
955 if (id == 0)
956 {
Geoff Langb1196682014-07-23 13:47:29 -0400957 context->recordError(Error(GL_INVALID_OPERATION));
958 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400959 }
960
961 // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id>
962 // of zero, if the active query object name for <target> is non-zero (for the
963 // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if
964 // the active query for either target is non-zero), if <id> is the name of an
965 // existing query object whose type does not match <target>, or if <id> is the
966 // active query object name for any query type, the error INVALID_OPERATION is
967 // generated.
968
969 // Ensure no other queries are active
970 // NOTE: If other queries than occlusion are supported, we will need to check
971 // separately that:
972 // a) The query ID passed is not the current active query for any target/type
973 // b) There are no active queries for the requested target (and in the case
974 // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
975 // no query may be active for either if glBeginQuery targets either.
Shannon Woods53a94a82014-06-24 15:20:36 -0400976 if (context->getState().isQueryActive())
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400977 {
Geoff Langb1196682014-07-23 13:47:29 -0400978 context->recordError(Error(GL_INVALID_OPERATION));
979 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400980 }
981
982 Query *queryObject = context->getQuery(id, true, target);
983
984 // check that name was obtained with glGenQueries
985 if (!queryObject)
986 {
Geoff Langb1196682014-07-23 13:47:29 -0400987 context->recordError(Error(GL_INVALID_OPERATION));
988 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400989 }
990
991 // check for type mismatch
992 if (queryObject->getType() != target)
993 {
Geoff Langb1196682014-07-23 13:47:29 -0400994 context->recordError(Error(GL_INVALID_OPERATION));
995 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -0400996 }
997
998 return true;
999}
1000
Jamie Madill45c785d2014-05-13 14:09:34 -04001001bool ValidateEndQuery(gl::Context *context, GLenum target)
1002{
1003 if (!ValidQueryType(context, target))
1004 {
Geoff Langb1196682014-07-23 13:47:29 -04001005 context->recordError(Error(GL_INVALID_ENUM));
1006 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001007 }
1008
Shannon Woods53a94a82014-06-24 15:20:36 -04001009 const Query *queryObject = context->getState().getActiveQuery(target);
Jamie Madill45c785d2014-05-13 14:09:34 -04001010
1011 if (queryObject == NULL)
1012 {
Geoff Langb1196682014-07-23 13:47:29 -04001013 context->recordError(Error(GL_INVALID_OPERATION));
1014 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001015 }
1016
Jamie Madill45c785d2014-05-13 14:09:34 -04001017 return true;
1018}
1019
Jamie Madill36398922014-05-20 14:51:53 -04001020static bool ValidateUniformCommonBase(gl::Context *context, GLenum targetUniformType,
1021 GLint location, GLsizei count, LinkedUniform **uniformOut)
Jamie Madilld7c7bb22014-05-20 10:55:54 -04001022{
1023 if (count < 0)
1024 {
Geoff Langb1196682014-07-23 13:47:29 -04001025 context->recordError(Error(GL_INVALID_VALUE));
1026 return false;
Jamie Madilld7c7bb22014-05-20 10:55:54 -04001027 }
1028
Geoff Lang7dd2e102014-11-10 15:19:26 -05001029 gl::Program *program = context->getState().getProgram();
1030 if (!program)
Jamie Madilld7c7bb22014-05-20 10:55:54 -04001031 {
Geoff Langb1196682014-07-23 13:47:29 -04001032 context->recordError(Error(GL_INVALID_OPERATION));
1033 return false;
Jamie Madilld7c7bb22014-05-20 10:55:54 -04001034 }
1035
1036 if (location == -1)
1037 {
1038 // Silently ignore the uniform command
1039 return false;
1040 }
1041
Geoff Lang7dd2e102014-11-10 15:19:26 -05001042 if (!program->isValidUniformLocation(location))
Jamie Madill36398922014-05-20 14:51:53 -04001043 {
Geoff Langb1196682014-07-23 13:47:29 -04001044 context->recordError(Error(GL_INVALID_OPERATION));
1045 return false;
Jamie Madill36398922014-05-20 14:51:53 -04001046 }
1047
Geoff Lang7dd2e102014-11-10 15:19:26 -05001048 LinkedUniform *uniform = program->getUniformByLocation(location);
Jamie Madill36398922014-05-20 14:51:53 -04001049
1050 // attempting to write an array to a non-array uniform is an INVALID_OPERATION
1051 if (uniform->elementCount() == 1 && count > 1)
1052 {
Geoff Langb1196682014-07-23 13:47:29 -04001053 context->recordError(Error(GL_INVALID_OPERATION));
1054 return false;
Jamie Madill36398922014-05-20 14:51:53 -04001055 }
1056
1057 *uniformOut = uniform;
Jamie Madilld7c7bb22014-05-20 10:55:54 -04001058 return true;
1059}
1060
Jamie Madillaa981bd2014-05-20 10:55:55 -04001061bool ValidateUniform(gl::Context *context, GLenum uniformType, GLint location, GLsizei count)
1062{
1063 // Check for ES3 uniform entry points
Jamie Madillf2575982014-06-25 16:04:54 -04001064 if (VariableComponentType(uniformType) == GL_UNSIGNED_INT && context->getClientVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04001065 {
Geoff Langb1196682014-07-23 13:47:29 -04001066 context->recordError(Error(GL_INVALID_OPERATION));
1067 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04001068 }
1069
Jamie Madill36398922014-05-20 14:51:53 -04001070 LinkedUniform *uniform = NULL;
1071 if (!ValidateUniformCommonBase(context, uniformType, location, count, &uniform))
1072 {
1073 return false;
1074 }
1075
Jamie Madillf2575982014-06-25 16:04:54 -04001076 GLenum targetBoolType = VariableBoolVectorType(uniformType);
Geoff Lang2ec386b2014-12-03 14:44:38 -05001077 bool samplerUniformCheck = (IsSamplerType(uniform->type) && uniformType == GL_INT);
Jamie Madill36398922014-05-20 14:51:53 -04001078 if (!samplerUniformCheck && uniformType != uniform->type && targetBoolType != uniform->type)
1079 {
Geoff Langb1196682014-07-23 13:47:29 -04001080 context->recordError(Error(GL_INVALID_OPERATION));
1081 return false;
Jamie Madill36398922014-05-20 14:51:53 -04001082 }
1083
1084 return true;
Jamie Madillaa981bd2014-05-20 10:55:55 -04001085}
1086
1087bool ValidateUniformMatrix(gl::Context *context, GLenum matrixType, GLint location, GLsizei count,
1088 GLboolean transpose)
1089{
1090 // Check for ES3 uniform entry points
1091 int rows = VariableRowCount(matrixType);
1092 int cols = VariableColumnCount(matrixType);
1093 if (rows != cols && context->getClientVersion() < 3)
1094 {
Geoff Langb1196682014-07-23 13:47:29 -04001095 context->recordError(Error(GL_INVALID_OPERATION));
1096 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04001097 }
1098
1099 if (transpose != GL_FALSE && context->getClientVersion() < 3)
1100 {
Geoff Langb1196682014-07-23 13:47:29 -04001101 context->recordError(Error(GL_INVALID_VALUE));
1102 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04001103 }
1104
Jamie Madill36398922014-05-20 14:51:53 -04001105 LinkedUniform *uniform = NULL;
1106 if (!ValidateUniformCommonBase(context, matrixType, location, count, &uniform))
1107 {
1108 return false;
1109 }
1110
1111 if (uniform->type != matrixType)
1112 {
Geoff Langb1196682014-07-23 13:47:29 -04001113 context->recordError(Error(GL_INVALID_OPERATION));
1114 return false;
Jamie Madill36398922014-05-20 14:51:53 -04001115 }
1116
1117 return true;
Jamie Madillaa981bd2014-05-20 10:55:55 -04001118}
1119
Jamie Madill893ab082014-05-16 16:56:10 -04001120bool ValidateStateQuery(gl::Context *context, GLenum pname, GLenum *nativeType, unsigned int *numParams)
1121{
1122 if (!context->getQueryParameterInfo(pname, nativeType, numParams))
1123 {
Geoff Langb1196682014-07-23 13:47:29 -04001124 context->recordError(Error(GL_INVALID_ENUM));
1125 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04001126 }
1127
1128 if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15)
1129 {
1130 unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0);
1131
Geoff Langaae65a42014-05-26 12:43:44 -04001132 if (colorAttachment >= context->getCaps().maxDrawBuffers)
Jamie Madill893ab082014-05-16 16:56:10 -04001133 {
Geoff Langb1196682014-07-23 13:47:29 -04001134 context->recordError(Error(GL_INVALID_OPERATION));
1135 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04001136 }
1137 }
1138
1139 switch (pname)
1140 {
1141 case GL_TEXTURE_BINDING_2D:
1142 case GL_TEXTURE_BINDING_CUBE_MAP:
1143 case GL_TEXTURE_BINDING_3D:
1144 case GL_TEXTURE_BINDING_2D_ARRAY:
Geoff Lang3a61c322014-07-10 13:01:54 -04001145 if (context->getState().getActiveSampler() >= context->getCaps().maxCombinedTextureImageUnits)
Jamie Madill893ab082014-05-16 16:56:10 -04001146 {
Geoff Langb1196682014-07-23 13:47:29 -04001147 context->recordError(Error(GL_INVALID_OPERATION));
1148 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04001149 }
1150 break;
1151
1152 case GL_IMPLEMENTATION_COLOR_READ_TYPE:
1153 case GL_IMPLEMENTATION_COLOR_READ_FORMAT:
1154 {
Shannon Woods53a94a82014-06-24 15:20:36 -04001155 Framebuffer *framebuffer = context->getState().getReadFramebuffer();
Jamie Madill893ab082014-05-16 16:56:10 -04001156 ASSERT(framebuffer);
Geoff Lang748f74e2014-12-01 11:25:34 -05001157 if (framebuffer->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill893ab082014-05-16 16:56:10 -04001158 {
Geoff Langb1196682014-07-23 13:47:29 -04001159 context->recordError(Error(GL_INVALID_OPERATION));
1160 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04001161 }
1162
Jamie Madill3c7fa222014-06-05 13:08:51 -04001163 FramebufferAttachment *attachment = framebuffer->getReadColorbuffer();
1164 if (!attachment)
Jamie Madill893ab082014-05-16 16:56:10 -04001165 {
Geoff Langb1196682014-07-23 13:47:29 -04001166 context->recordError(Error(GL_INVALID_OPERATION));
1167 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04001168 }
1169 }
1170 break;
1171
1172 default:
1173 break;
1174 }
1175
1176 // pname is valid, but there are no parameters to return
1177 if (numParams == 0)
1178 {
1179 return false;
1180 }
1181
1182 return true;
1183}
1184
Jamie Madill560a8d82014-05-21 13:06:20 -04001185bool ValidateCopyTexImageParametersBase(gl::Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage,
1186 GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height,
1187 GLint border, GLenum *textureFormatOut)
1188{
1189
1190 if (!ValidTexture2DDestinationTarget(context, target))
1191 {
Geoff Langb1196682014-07-23 13:47:29 -04001192 context->recordError(Error(GL_INVALID_ENUM));
1193 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001194 }
1195
1196 if (level < 0 || xoffset < 0 || yoffset < 0 || zoffset < 0 || width < 0 || height < 0)
1197 {
Geoff Langb1196682014-07-23 13:47:29 -04001198 context->recordError(Error(GL_INVALID_VALUE));
1199 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001200 }
1201
1202 if (std::numeric_limits<GLsizei>::max() - xoffset < width || std::numeric_limits<GLsizei>::max() - yoffset < height)
1203 {
Geoff Langb1196682014-07-23 13:47:29 -04001204 context->recordError(Error(GL_INVALID_VALUE));
1205 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001206 }
1207
1208 if (border != 0)
1209 {
Geoff Langb1196682014-07-23 13:47:29 -04001210 context->recordError(Error(GL_INVALID_VALUE));
1211 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001212 }
1213
1214 if (!ValidMipLevel(context, target, level))
1215 {
Geoff Langb1196682014-07-23 13:47:29 -04001216 context->recordError(Error(GL_INVALID_VALUE));
1217 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001218 }
1219
Shannon Woods53a94a82014-06-24 15:20:36 -04001220 gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer();
Geoff Lang748f74e2014-12-01 11:25:34 -05001221 if (framebuffer->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill560a8d82014-05-21 13:06:20 -04001222 {
Geoff Langb1196682014-07-23 13:47:29 -04001223 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
1224 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001225 }
1226
Jamie Madill48faf802014-11-06 15:27:22 -05001227 if (context->getState().getReadFramebuffer()->id() != 0 && framebuffer->getSamples(context->getData()) != 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04001228 {
Geoff Langb1196682014-07-23 13:47:29 -04001229 context->recordError(Error(GL_INVALID_OPERATION));
1230 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001231 }
1232
Geoff Langaae65a42014-05-26 12:43:44 -04001233 const gl::Caps &caps = context->getCaps();
1234
Jamie Madill560a8d82014-05-21 13:06:20 -04001235 gl::Texture *texture = NULL;
1236 GLenum textureInternalFormat = GL_NONE;
Jamie Madill560a8d82014-05-21 13:06:20 -04001237 GLint textureLevelWidth = 0;
1238 GLint textureLevelHeight = 0;
1239 GLint textureLevelDepth = 0;
Geoff Langaae65a42014-05-26 12:43:44 -04001240 GLuint maxDimension = 0;
Jamie Madill560a8d82014-05-21 13:06:20 -04001241
1242 switch (target)
1243 {
1244 case GL_TEXTURE_2D:
1245 {
1246 gl::Texture2D *texture2d = context->getTexture2D();
1247 if (texture2d)
1248 {
1249 textureInternalFormat = texture2d->getInternalFormat(level);
Jamie Madill560a8d82014-05-21 13:06:20 -04001250 textureLevelWidth = texture2d->getWidth(level);
1251 textureLevelHeight = texture2d->getHeight(level);
1252 textureLevelDepth = 1;
1253 texture = texture2d;
Geoff Langaae65a42014-05-26 12:43:44 -04001254 maxDimension = caps.max2DTextureSize;
Jamie Madill560a8d82014-05-21 13:06:20 -04001255 }
1256 }
1257 break;
1258
1259 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1260 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1261 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1262 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1263 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1264 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1265 {
1266 gl::TextureCubeMap *textureCube = context->getTextureCubeMap();
1267 if (textureCube)
1268 {
1269 textureInternalFormat = textureCube->getInternalFormat(target, level);
Jamie Madill560a8d82014-05-21 13:06:20 -04001270 textureLevelWidth = textureCube->getWidth(target, level);
1271 textureLevelHeight = textureCube->getHeight(target, level);
1272 textureLevelDepth = 1;
1273 texture = textureCube;
Geoff Langaae65a42014-05-26 12:43:44 -04001274 maxDimension = caps.maxCubeMapTextureSize;
Jamie Madill560a8d82014-05-21 13:06:20 -04001275 }
1276 }
1277 break;
1278
1279 case GL_TEXTURE_2D_ARRAY:
1280 {
1281 gl::Texture2DArray *texture2dArray = context->getTexture2DArray();
1282 if (texture2dArray)
1283 {
1284 textureInternalFormat = texture2dArray->getInternalFormat(level);
Jamie Madill560a8d82014-05-21 13:06:20 -04001285 textureLevelWidth = texture2dArray->getWidth(level);
1286 textureLevelHeight = texture2dArray->getHeight(level);
1287 textureLevelDepth = texture2dArray->getLayers(level);
1288 texture = texture2dArray;
Geoff Langaae65a42014-05-26 12:43:44 -04001289 maxDimension = caps.max2DTextureSize;
Jamie Madill560a8d82014-05-21 13:06:20 -04001290 }
1291 }
1292 break;
1293
1294 case GL_TEXTURE_3D:
1295 {
1296 gl::Texture3D *texture3d = context->getTexture3D();
1297 if (texture3d)
1298 {
1299 textureInternalFormat = texture3d->getInternalFormat(level);
Jamie Madill560a8d82014-05-21 13:06:20 -04001300 textureLevelWidth = texture3d->getWidth(level);
1301 textureLevelHeight = texture3d->getHeight(level);
1302 textureLevelDepth = texture3d->getDepth(level);
1303 texture = texture3d;
Geoff Langaae65a42014-05-26 12:43:44 -04001304 maxDimension = caps.max3DTextureSize;
Jamie Madill560a8d82014-05-21 13:06:20 -04001305 }
1306 }
1307 break;
1308
1309 default:
Geoff Langb1196682014-07-23 13:47:29 -04001310 context->recordError(Error(GL_INVALID_ENUM));
1311 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001312 }
1313
1314 if (!texture)
1315 {
Geoff Langb1196682014-07-23 13:47:29 -04001316 context->recordError(Error(GL_INVALID_OPERATION));
1317 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001318 }
1319
1320 if (texture->isImmutable() && !isSubImage)
1321 {
Geoff Langb1196682014-07-23 13:47:29 -04001322 context->recordError(Error(GL_INVALID_OPERATION));
1323 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001324 }
1325
Geoff Lang5d601382014-07-22 15:14:06 -04001326 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat);
1327
1328 if (formatInfo.depthBits > 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04001329 {
Geoff Langb1196682014-07-23 13:47:29 -04001330 context->recordError(Error(GL_INVALID_OPERATION));
1331 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001332 }
1333
Geoff Lang5d601382014-07-22 15:14:06 -04001334 if (formatInfo.compressed)
Jamie Madill560a8d82014-05-21 13:06:20 -04001335 {
Geoff Lang5d601382014-07-22 15:14:06 -04001336 if (((width % formatInfo.compressedBlockWidth) != 0 && width != textureLevelWidth) ||
1337 ((height % formatInfo.compressedBlockHeight) != 0 && height != textureLevelHeight))
Jamie Madill560a8d82014-05-21 13:06:20 -04001338 {
Geoff Langb1196682014-07-23 13:47:29 -04001339 context->recordError(Error(GL_INVALID_OPERATION));
1340 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001341 }
1342 }
1343
1344 if (isSubImage)
1345 {
1346 if (xoffset + width > textureLevelWidth ||
1347 yoffset + height > textureLevelHeight ||
1348 zoffset >= textureLevelDepth)
1349 {
Geoff Langb1196682014-07-23 13:47:29 -04001350 context->recordError(Error(GL_INVALID_VALUE));
1351 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04001352 }
1353 }
Jamie Madill6f38f822014-06-06 17:12:20 -04001354 else
1355 {
1356 if (IsCubemapTextureTarget(target) && width != height)
1357 {
Geoff Langb1196682014-07-23 13:47:29 -04001358 context->recordError(Error(GL_INVALID_VALUE));
1359 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04001360 }
1361
Geoff Lang5d601382014-07-22 15:14:06 -04001362 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Jamie Madill6f38f822014-06-06 17:12:20 -04001363 {
Geoff Langb1196682014-07-23 13:47:29 -04001364 context->recordError(Error(GL_INVALID_ENUM));
1365 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04001366 }
1367
1368 int maxLevelDimension = (maxDimension >> level);
1369 if (static_cast<int>(width) > maxLevelDimension || static_cast<int>(height) > maxLevelDimension)
1370 {
Geoff Langb1196682014-07-23 13:47:29 -04001371 context->recordError(Error(GL_INVALID_VALUE));
1372 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04001373 }
1374 }
Jamie Madill560a8d82014-05-21 13:06:20 -04001375
1376 *textureFormatOut = textureInternalFormat;
1377 return true;
1378}
1379
Geoff Langb1196682014-07-23 13:47:29 -04001380static bool ValidateDrawBase(Context *context, GLenum mode, GLsizei count, GLsizei maxVertex, GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04001381{
Jamie Madill1aeb1312014-06-20 13:21:25 -04001382 switch (mode)
1383 {
1384 case GL_POINTS:
1385 case GL_LINES:
1386 case GL_LINE_LOOP:
1387 case GL_LINE_STRIP:
1388 case GL_TRIANGLES:
1389 case GL_TRIANGLE_STRIP:
1390 case GL_TRIANGLE_FAN:
1391 break;
1392 default:
Geoff Langb1196682014-07-23 13:47:29 -04001393 context->recordError(Error(GL_INVALID_ENUM));
1394 return false;
Jamie Madill1aeb1312014-06-20 13:21:25 -04001395 }
1396
Jamie Madill250d33f2014-06-06 17:09:03 -04001397 if (count < 0)
1398 {
Geoff Langb1196682014-07-23 13:47:29 -04001399 context->recordError(Error(GL_INVALID_VALUE));
1400 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001401 }
1402
Geoff Langb1196682014-07-23 13:47:29 -04001403 const State &state = context->getState();
1404
Jamie Madill250d33f2014-06-06 17:09:03 -04001405 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001406 if (state.hasMappedBuffer(GL_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04001407 {
Geoff Langb1196682014-07-23 13:47:29 -04001408 context->recordError(Error(GL_INVALID_OPERATION));
1409 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001410 }
1411
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001412 const gl::DepthStencilState &depthStencilState = state.getDepthStencilState();
Jamie Madillac528012014-06-20 13:21:23 -04001413 if (depthStencilState.stencilWritemask != depthStencilState.stencilBackWritemask ||
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001414 state.getStencilRef() != state.getStencilBackRef() ||
Jamie Madillac528012014-06-20 13:21:23 -04001415 depthStencilState.stencilMask != depthStencilState.stencilBackMask)
1416 {
1417 // Note: these separate values are not supported in WebGL, due to D3D's limitations.
1418 // See Section 6.10 of the WebGL 1.0 spec
1419 ERR("This ANGLE implementation does not support separate front/back stencil "
1420 "writemasks, reference values, or stencil mask values.");
Geoff Langb1196682014-07-23 13:47:29 -04001421 context->recordError(Error(GL_INVALID_OPERATION));
1422 return false;
Jamie Madillac528012014-06-20 13:21:23 -04001423 }
1424
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001425 const gl::Framebuffer *fbo = state.getDrawFramebuffer();
Geoff Lang748f74e2014-12-01 11:25:34 -05001426 if (!fbo || fbo->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04001427 {
Geoff Langb1196682014-07-23 13:47:29 -04001428 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
1429 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04001430 }
1431
Geoff Lang7dd2e102014-11-10 15:19:26 -05001432 gl::Program *program = state.getProgram();
1433 if (!program)
Jamie Madilld4cfa572014-07-08 10:00:32 -04001434 {
Geoff Langb1196682014-07-23 13:47:29 -04001435 context->recordError(Error(GL_INVALID_OPERATION));
1436 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04001437 }
1438
Geoff Lang7dd2e102014-11-10 15:19:26 -05001439 if (!program->validateSamplers(NULL, context->getCaps()))
Jamie Madilld4cfa572014-07-08 10:00:32 -04001440 {
Geoff Langb1196682014-07-23 13:47:29 -04001441 context->recordError(Error(GL_INVALID_OPERATION));
1442 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04001443 }
1444
Jamie Madill2b976812014-08-25 15:47:49 -04001445 // Buffer validations
1446 const VertexArray *vao = state.getVertexArray();
1447 for (int attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
1448 {
1449 const VertexAttribute &attrib = vao->getVertexAttribute(attributeIndex);
Geoff Lang7dd2e102014-11-10 15:19:26 -05001450 bool attribActive = (program->getSemanticIndex(attributeIndex) != -1);
Jamie Madill2b976812014-08-25 15:47:49 -04001451 if (attribActive && attrib.enabled)
1452 {
1453 gl::Buffer *buffer = attrib.buffer.get();
1454
1455 if (buffer)
1456 {
1457 GLint64 attribStride = static_cast<GLint64>(ComputeVertexAttributeStride(attrib));
1458 GLint64 maxVertexElement = 0;
1459
1460 if (attrib.divisor > 0)
1461 {
1462 maxVertexElement = static_cast<GLint64>(primcount) / static_cast<GLint64>(attrib.divisor);
1463 }
1464 else
1465 {
1466 maxVertexElement = static_cast<GLint64>(maxVertex);
1467 }
1468
1469 GLint64 attribDataSize = maxVertexElement * attribStride;
1470
1471 // [OpenGL ES 3.0.2] section 2.9.4 page 40:
1472 // We can return INVALID_OPERATION if our vertex attribute does not have
1473 // enough backing data.
1474 if (attribDataSize > buffer->getSize())
1475 {
Geoff Langb1196682014-07-23 13:47:29 -04001476 context->recordError(Error(GL_INVALID_OPERATION));
1477 return false;
Jamie Madill2b976812014-08-25 15:47:49 -04001478 }
1479 }
1480 else if (attrib.pointer == NULL)
1481 {
1482 // This is an application error that would normally result in a crash,
1483 // but we catch it and return an error
Geoff Langb1196682014-07-23 13:47:29 -04001484 context->recordError(Error(GL_INVALID_OPERATION, "An enabled vertex array has no buffer and no pointer."));
1485 return false;
Jamie Madill2b976812014-08-25 15:47:49 -04001486 }
1487 }
1488 }
1489
Jamie Madill250d33f2014-06-06 17:09:03 -04001490 // No-op if zero count
1491 return (count > 0);
1492}
1493
Geoff Langb1196682014-07-23 13:47:29 -04001494bool ValidateDrawArrays(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04001495{
Jamie Madillfd716582014-06-06 17:09:04 -04001496 if (first < 0)
Jamie Madill250d33f2014-06-06 17:09:03 -04001497 {
Geoff Langb1196682014-07-23 13:47:29 -04001498 context->recordError(Error(GL_INVALID_VALUE));
1499 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001500 }
1501
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001502 const State &state = context->getState();
1503 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
Jamie Madillfd716582014-06-06 17:09:04 -04001504 if (curTransformFeedback && curTransformFeedback->isStarted() && !curTransformFeedback->isPaused() &&
1505 curTransformFeedback->getDrawMode() != mode)
1506 {
1507 // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode
1508 // that does not match the current transform feedback object's draw mode (if transform feedback
1509 // is active), (3.0.2, section 2.14, pg 86)
Geoff Langb1196682014-07-23 13:47:29 -04001510 context->recordError(Error(GL_INVALID_OPERATION));
1511 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04001512 }
1513
Geoff Langb1196682014-07-23 13:47:29 -04001514 if (!ValidateDrawBase(context, mode, count, count, primcount))
Jamie Madillfd716582014-06-06 17:09:04 -04001515 {
1516 return false;
1517 }
1518
1519 return true;
1520}
1521
Geoff Langb1196682014-07-23 13:47:29 -04001522bool ValidateDrawArraysInstanced(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04001523{
1524 if (primcount < 0)
1525 {
Geoff Langb1196682014-07-23 13:47:29 -04001526 context->recordError(Error(GL_INVALID_VALUE));
1527 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04001528 }
1529
Jamie Madill2b976812014-08-25 15:47:49 -04001530 if (!ValidateDrawArrays(context, mode, first, count, primcount))
Jamie Madillfd716582014-06-06 17:09:04 -04001531 {
1532 return false;
1533 }
1534
1535 // No-op if zero primitive count
1536 return (primcount > 0);
1537}
1538
Geoff Lang87a93302014-09-16 13:29:43 -04001539static bool ValidateDrawInstancedANGLE(Context *context)
1540{
1541 // Verify there is at least one active attribute with a divisor of zero
1542 const gl::State& state = context->getState();
1543
Geoff Lang7dd2e102014-11-10 15:19:26 -05001544 gl::Program *program = state.getProgram();
Geoff Lang87a93302014-09-16 13:29:43 -04001545
1546 const VertexArray *vao = state.getVertexArray();
1547 for (int attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
1548 {
1549 const VertexAttribute &attrib = vao->getVertexAttribute(attributeIndex);
Geoff Lang7dd2e102014-11-10 15:19:26 -05001550 bool active = (program->getSemanticIndex(attributeIndex) != -1);
Geoff Lang87a93302014-09-16 13:29:43 -04001551 if (active && attrib.divisor == 0)
1552 {
1553 return true;
1554 }
1555 }
1556
1557 context->recordError(Error(GL_INVALID_OPERATION, "ANGLE_instanced_arrays requires that at least one active attribute"
1558 "has a divisor of zero."));
1559 return false;
1560}
1561
1562bool ValidateDrawArraysInstancedANGLE(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount)
1563{
1564 if (!ValidateDrawInstancedANGLE(context))
1565 {
1566 return false;
1567 }
1568
1569 return ValidateDrawArraysInstanced(context, mode, first, count, primcount);
1570}
1571
Geoff Langb1196682014-07-23 13:47:29 -04001572bool ValidateDrawElements(Context *context, GLenum mode, GLsizei count, GLenum type,
Jamie Madill2b976812014-08-25 15:47:49 -04001573 const GLvoid* indices, GLsizei primcount, rx::RangeUI *indexRangeOut)
Jamie Madillfd716582014-06-06 17:09:04 -04001574{
Jamie Madill250d33f2014-06-06 17:09:03 -04001575 switch (type)
1576 {
1577 case GL_UNSIGNED_BYTE:
1578 case GL_UNSIGNED_SHORT:
1579 break;
1580 case GL_UNSIGNED_INT:
Geoff Langc0b9ef42014-07-02 10:02:37 -04001581 if (!context->getExtensions().elementIndexUint)
Jamie Madill250d33f2014-06-06 17:09:03 -04001582 {
Geoff Langb1196682014-07-23 13:47:29 -04001583 context->recordError(Error(GL_INVALID_ENUM));
1584 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001585 }
1586 break;
1587 default:
Geoff Langb1196682014-07-23 13:47:29 -04001588 context->recordError(Error(GL_INVALID_ENUM));
1589 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001590 }
1591
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001592 const State &state = context->getState();
1593
1594 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
Jamie Madill250d33f2014-06-06 17:09:03 -04001595 if (curTransformFeedback && curTransformFeedback->isStarted() && !curTransformFeedback->isPaused())
1596 {
1597 // It is an invalid operation to call DrawElements, DrawRangeElements or DrawElementsInstanced
1598 // while transform feedback is active, (3.0.2, section 2.14, pg 86)
Geoff Langb1196682014-07-23 13:47:29 -04001599 context->recordError(Error(GL_INVALID_OPERATION));
1600 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001601 }
1602
1603 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04001604 if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04001605 {
Geoff Langb1196682014-07-23 13:47:29 -04001606 context->recordError(Error(GL_INVALID_OPERATION));
1607 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04001608 }
1609
Jamie Madill2b976812014-08-25 15:47:49 -04001610 const gl::VertexArray *vao = state.getVertexArray();
1611 const gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer();
1612 if (!indices && !elementArrayBuffer)
Jamie Madilld4cfa572014-07-08 10:00:32 -04001613 {
Geoff Langb1196682014-07-23 13:47:29 -04001614 context->recordError(Error(GL_INVALID_OPERATION));
1615 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04001616 }
1617
Jamie Madillae3000b2014-08-25 15:47:51 -04001618 if (elementArrayBuffer)
1619 {
1620 const gl::Type &typeInfo = gl::GetTypeInfo(type);
1621
1622 GLint64 offset = reinterpret_cast<GLint64>(indices);
1623 GLint64 byteCount = static_cast<GLint64>(typeInfo.bytes) * static_cast<GLint64>(count)+offset;
1624
1625 // check for integer overflows
1626 if (static_cast<GLuint>(count) > (std::numeric_limits<GLuint>::max() / typeInfo.bytes) ||
1627 byteCount > static_cast<GLint64>(std::numeric_limits<GLuint>::max()))
1628 {
Geoff Langb1196682014-07-23 13:47:29 -04001629 context->recordError(Error(GL_OUT_OF_MEMORY));
1630 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04001631 }
1632
1633 // Check for reading past the end of the bound buffer object
1634 if (byteCount > elementArrayBuffer->getSize())
1635 {
Geoff Langb1196682014-07-23 13:47:29 -04001636 context->recordError(Error(GL_INVALID_OPERATION));
1637 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04001638 }
1639 }
1640 else if (!indices)
1641 {
1642 // Catch this programming error here
Geoff Langb1196682014-07-23 13:47:29 -04001643 context->recordError(Error(GL_INVALID_OPERATION));
1644 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04001645 }
1646
Jamie Madill2b976812014-08-25 15:47:49 -04001647 // Use max index to validate if our vertex buffers are large enough for the pull.
1648 // TODO: offer fast path, with disabled index validation.
1649 // TODO: also disable index checking on back-ends that are robust to out-of-range accesses.
1650 if (elementArrayBuffer)
1651 {
Jacek Cabana5521de2014-10-01 17:23:46 +02001652 uintptr_t offset = reinterpret_cast<uintptr_t>(indices);
Jamie Madill2b976812014-08-25 15:47:49 -04001653 if (!elementArrayBuffer->getIndexRangeCache()->findRange(type, offset, count, indexRangeOut, NULL))
1654 {
Jamie Madill9ae396b2014-10-21 17:46:30 -04001655 // FIXME(jmadill): Use buffer data caching instead of the D3D back-end
1656 rx::BufferD3D *bufferD3D = rx::BufferD3D::makeBufferD3D(elementArrayBuffer->getImplementation());
Geoff Langc8d297a2014-09-19 11:09:08 -04001657 const uint8_t *dataPointer = NULL;
Jamie Madill9ae396b2014-10-21 17:46:30 -04001658 Error error = bufferD3D->getData(&dataPointer);
Geoff Langc8d297a2014-09-19 11:09:08 -04001659 if (error.isError())
1660 {
1661 context->recordError(error);
1662 return false;
1663 }
1664
1665 const uint8_t *offsetPointer = dataPointer + offset;
Jamie Madill2b976812014-08-25 15:47:49 -04001666 *indexRangeOut = rx::IndexRangeCache::ComputeRange(type, offsetPointer, count);
1667 }
1668 }
1669 else
1670 {
1671 *indexRangeOut = rx::IndexRangeCache::ComputeRange(type, indices, count);
1672 }
1673
Geoff Langb1196682014-07-23 13:47:29 -04001674 if (!ValidateDrawBase(context, mode, count, static_cast<GLsizei>(indexRangeOut->end), primcount))
Jamie Madillfd716582014-06-06 17:09:04 -04001675 {
1676 return false;
1677 }
1678
1679 return true;
1680}
1681
Geoff Langb1196682014-07-23 13:47:29 -04001682bool ValidateDrawElementsInstanced(Context *context,
Jamie Madill2b976812014-08-25 15:47:49 -04001683 GLenum mode, GLsizei count, GLenum type,
1684 const GLvoid *indices, GLsizei primcount,
1685 rx::RangeUI *indexRangeOut)
Jamie Madillfd716582014-06-06 17:09:04 -04001686{
1687 if (primcount < 0)
1688 {
Geoff Langb1196682014-07-23 13:47:29 -04001689 context->recordError(Error(GL_INVALID_VALUE));
1690 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04001691 }
1692
Jamie Madill2b976812014-08-25 15:47:49 -04001693 if (!ValidateDrawElements(context, mode, count, type, indices, primcount, indexRangeOut))
Jamie Madillfd716582014-06-06 17:09:04 -04001694 {
1695 return false;
1696 }
1697
1698 // No-op zero primitive count
1699 return (primcount > 0);
Jamie Madill250d33f2014-06-06 17:09:03 -04001700}
1701
Geoff Lang87a93302014-09-16 13:29:43 -04001702bool ValidateDrawElementsInstancedANGLE(Context *context, GLenum mode, GLsizei count, GLenum type,
1703 const GLvoid *indices, GLsizei primcount, rx::RangeUI *indexRangeOut)
1704{
1705 if (!ValidateDrawInstancedANGLE(context))
1706 {
1707 return false;
1708 }
1709
1710 return ValidateDrawElementsInstanced(context, mode, count, type, indices, primcount, indexRangeOut);
1711}
1712
Geoff Langb1196682014-07-23 13:47:29 -04001713bool ValidateFramebufferTextureBase(Context *context, GLenum target, GLenum attachment,
Jamie Madill55ec3b12014-07-03 10:38:57 -04001714 GLuint texture, GLint level)
Jamie Madill570f7c82014-07-03 10:38:54 -04001715{
Jamie Madill55ec3b12014-07-03 10:38:57 -04001716 if (!ValidFramebufferTarget(target))
1717 {
Geoff Langb1196682014-07-23 13:47:29 -04001718 context->recordError(Error(GL_INVALID_ENUM));
1719 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001720 }
1721
1722 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill570f7c82014-07-03 10:38:54 -04001723 {
1724 return false;
1725 }
1726
Jamie Madill55ec3b12014-07-03 10:38:57 -04001727 if (texture != 0)
1728 {
1729 gl::Texture *tex = context->getTexture(texture);
1730
1731 if (tex == NULL)
1732 {
Geoff Langb1196682014-07-23 13:47:29 -04001733 context->recordError(Error(GL_INVALID_OPERATION));
1734 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001735 }
1736
1737 if (level < 0)
1738 {
Geoff Langb1196682014-07-23 13:47:29 -04001739 context->recordError(Error(GL_INVALID_VALUE));
1740 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001741 }
1742 }
1743
Shannon Woods53a94a82014-06-24 15:20:36 -04001744 const gl::Framebuffer *framebuffer = context->getState().getTargetFramebuffer(target);
1745 GLuint framebufferHandle = context->getState().getTargetFramebuffer(target)->id();
Jamie Madill55ec3b12014-07-03 10:38:57 -04001746
1747 if (framebufferHandle == 0 || !framebuffer)
1748 {
Geoff Langb1196682014-07-23 13:47:29 -04001749 context->recordError(Error(GL_INVALID_OPERATION));
1750 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001751 }
1752
1753 return true;
1754}
1755
Geoff Langb1196682014-07-23 13:47:29 -04001756bool ValidateFramebufferTexture2D(Context *context, GLenum target, GLenum attachment,
Jamie Madill55ec3b12014-07-03 10:38:57 -04001757 GLenum textarget, GLuint texture, GLint level)
1758{
1759 // Attachments are required to be bound to level 0 in ES2
1760 if (context->getClientVersion() < 3 && level != 0)
1761 {
Geoff Langb1196682014-07-23 13:47:29 -04001762 context->recordError(Error(GL_INVALID_VALUE));
1763 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001764 }
1765
1766 if (!ValidateFramebufferTextureBase(context, target, attachment, texture, level))
Jamie Madill570f7c82014-07-03 10:38:54 -04001767 {
1768 return false;
1769 }
1770
Jamie Madill55ec3b12014-07-03 10:38:57 -04001771 if (texture != 0)
1772 {
1773 gl::Texture *tex = context->getTexture(texture);
1774 ASSERT(tex);
1775
Jamie Madill2a6564e2014-07-11 09:53:19 -04001776 const gl::Caps &caps = context->getCaps();
1777
Jamie Madill55ec3b12014-07-03 10:38:57 -04001778 switch (textarget)
1779 {
1780 case GL_TEXTURE_2D:
1781 {
Jamie Madill2a6564e2014-07-11 09:53:19 -04001782 if (level > gl::log2(caps.max2DTextureSize))
Jamie Madill55ec3b12014-07-03 10:38:57 -04001783 {
Geoff Langb1196682014-07-23 13:47:29 -04001784 context->recordError(Error(GL_INVALID_VALUE));
1785 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001786 }
1787 if (tex->getTarget() != GL_TEXTURE_2D)
1788 {
Geoff Langb1196682014-07-23 13:47:29 -04001789 context->recordError(Error(GL_INVALID_OPERATION));
1790 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001791 }
1792 gl::Texture2D *tex2d = static_cast<gl::Texture2D *>(tex);
1793 if (tex2d->isCompressed(level))
1794 {
Geoff Langb1196682014-07-23 13:47:29 -04001795 context->recordError(Error(GL_INVALID_OPERATION));
1796 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001797 }
1798 }
1799 break;
1800
1801 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1802 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1803 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1804 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1805 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1806 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1807 {
Jamie Madill2a6564e2014-07-11 09:53:19 -04001808 if (level > gl::log2(caps.maxCubeMapTextureSize))
Jamie Madill55ec3b12014-07-03 10:38:57 -04001809 {
Geoff Langb1196682014-07-23 13:47:29 -04001810 context->recordError(Error(GL_INVALID_VALUE));
1811 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001812 }
1813 if (tex->getTarget() != GL_TEXTURE_CUBE_MAP)
1814 {
Geoff Langb1196682014-07-23 13:47:29 -04001815 context->recordError(Error(GL_INVALID_OPERATION));
1816 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001817 }
1818 gl::TextureCubeMap *texcube = static_cast<gl::TextureCubeMap *>(tex);
1819 if (texcube->isCompressed(textarget, level))
1820 {
Geoff Langb1196682014-07-23 13:47:29 -04001821 context->recordError(Error(GL_INVALID_OPERATION));
1822 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001823 }
1824 }
1825 break;
1826
1827 default:
Geoff Langb1196682014-07-23 13:47:29 -04001828 context->recordError(Error(GL_INVALID_ENUM));
1829 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001830 }
1831 }
1832
Jamie Madill570f7c82014-07-03 10:38:54 -04001833 return true;
1834}
1835
Geoff Langb1196682014-07-23 13:47:29 -04001836bool ValidateGetUniformBase(Context *context, GLuint program, GLint location)
Jamie Madill0063c512014-08-25 15:47:53 -04001837{
1838 if (program == 0)
1839 {
Geoff Langb1196682014-07-23 13:47:29 -04001840 context->recordError(Error(GL_INVALID_VALUE));
1841 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04001842 }
1843
Shannon Woods4de4fd62014-11-07 16:22:02 -05001844 if (!ValidProgram(context, program))
1845 {
1846 return false;
1847 }
1848
Jamie Madill0063c512014-08-25 15:47:53 -04001849 gl::Program *programObject = context->getProgram(program);
1850
1851 if (!programObject || !programObject->isLinked())
1852 {
Geoff Langb1196682014-07-23 13:47:29 -04001853 context->recordError(Error(GL_INVALID_OPERATION));
1854 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04001855 }
1856
Geoff Lang7dd2e102014-11-10 15:19:26 -05001857 if (!programObject->isValidUniformLocation(location))
Jamie Madill549c7fd2014-08-25 15:47:56 -04001858 {
Geoff Langb1196682014-07-23 13:47:29 -04001859 context->recordError(Error(GL_INVALID_OPERATION));
1860 return false;
Jamie Madill549c7fd2014-08-25 15:47:56 -04001861 }
1862
Jamie Madill0063c512014-08-25 15:47:53 -04001863 return true;
1864}
1865
Geoff Langb1196682014-07-23 13:47:29 -04001866bool ValidateGetUniformfv(Context *context, GLuint program, GLint location, GLfloat* params)
Jamie Madill78f41802014-08-25 15:47:55 -04001867{
1868 return ValidateGetUniformBase(context, program, location);
1869}
1870
Geoff Langb1196682014-07-23 13:47:29 -04001871bool ValidateGetUniformiv(Context *context, GLuint program, GLint location, GLint* params)
Jamie Madill0063c512014-08-25 15:47:53 -04001872{
Jamie Madill78f41802014-08-25 15:47:55 -04001873 return ValidateGetUniformBase(context, program, location);
1874}
1875
Geoff Langb1196682014-07-23 13:47:29 -04001876static bool ValidateSizedGetUniform(Context *context, GLuint program, GLint location, GLsizei bufSize)
Jamie Madill78f41802014-08-25 15:47:55 -04001877{
1878 if (!ValidateGetUniformBase(context, program, location))
Jamie Madill0063c512014-08-25 15:47:53 -04001879 {
Jamie Madill78f41802014-08-25 15:47:55 -04001880 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04001881 }
1882
Jamie Madilla502c742014-08-28 17:19:13 -04001883 gl::Program *programObject = context->getProgram(program);
1884 ASSERT(programObject);
Jamie Madill0063c512014-08-25 15:47:53 -04001885
Jamie Madill78f41802014-08-25 15:47:55 -04001886 // sized queries -- ensure the provided buffer is large enough
Geoff Lang7dd2e102014-11-10 15:19:26 -05001887 LinkedUniform *uniform = programObject->getUniformByLocation(location);
Jamie Madill78f41802014-08-25 15:47:55 -04001888 size_t requiredBytes = VariableExternalSize(uniform->type);
1889 if (static_cast<size_t>(bufSize) < requiredBytes)
Jamie Madill0063c512014-08-25 15:47:53 -04001890 {
Geoff Langb1196682014-07-23 13:47:29 -04001891 context->recordError(Error(GL_INVALID_OPERATION));
1892 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04001893 }
1894
1895 return true;
1896}
1897
Geoff Langb1196682014-07-23 13:47:29 -04001898bool ValidateGetnUniformfvEXT(Context *context, GLuint program, GLint location, GLsizei bufSize, GLfloat* params)
Jamie Madill0063c512014-08-25 15:47:53 -04001899{
Jamie Madill78f41802014-08-25 15:47:55 -04001900 return ValidateSizedGetUniform(context, program, location, bufSize);
Jamie Madill0063c512014-08-25 15:47:53 -04001901}
1902
Geoff Langb1196682014-07-23 13:47:29 -04001903bool ValidateGetnUniformivEXT(Context *context, GLuint program, GLint location, GLsizei bufSize, GLint* params)
Jamie Madill0063c512014-08-25 15:47:53 -04001904{
Jamie Madill78f41802014-08-25 15:47:55 -04001905 return ValidateSizedGetUniform(context, program, location, bufSize);
Jamie Madill0063c512014-08-25 15:47:53 -04001906}
1907
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001908}