| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 2 | use crate::syntax::report::Errors; |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 3 | use crate::syntax::types::TrivialReason; |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 4 | use crate::syntax::{ |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame] | 5 | error, ident, Api, Enum, ExternFn, ExternType, Impl, Lang, Receiver, Ref, Signature, Slice, |
| 6 | Struct, Ty1, Type, Types, |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 7 | }; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 8 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 9 | use quote::{quote, ToTokens}; |
| 10 | use std::fmt::Display; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 11 | |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 12 | pub(crate) struct Check<'a> { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 13 | apis: &'a [Api], |
| 14 | types: &'a Types<'a>, |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 15 | errors: &'a mut Errors, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 16 | } |
| 17 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 18 | pub(crate) fn typecheck(cx: &mut Errors, apis: &[Api], types: &Types) { |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 19 | do_typecheck(&mut Check { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 20 | apis, |
| 21 | types, |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 22 | errors: cx, |
| 23 | }); |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 24 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 25 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 26 | fn do_typecheck(cx: &mut Check) { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 27 | ident::check_all(cx, cx.apis); |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 28 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 29 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 30 | match ty { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 31 | Type::Ident(ident) => check_type_ident(cx, &ident.rust), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 32 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 33 | Type::RustVec(ty) => check_type_rust_vec(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 34 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 35 | Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 36 | Type::Ref(ty) => check_type_ref(cx, ty), |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 37 | Type::Slice(ty) => check_type_slice(cx, ty), |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame] | 38 | Type::Fn(ty) => check_type_fn(cx, ty), |
| 39 | Type::Str(_) | Type::Void(_) | Type::SliceRefU8(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 40 | } |
| 41 | } |
| 42 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 43 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 44 | match api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 45 | Api::Struct(strct) => check_api_struct(cx, strct), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 46 | Api::Enum(enm) => check_api_enum(cx, enm), |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 47 | Api::CxxType(ety) | Api::RustType(ety) => check_api_type(cx, ety), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 48 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 49 | Api::Impl(imp) => check_api_impl(cx, imp), |
| David Tolnay | 5ecaea9 | 2020-11-14 23:25:42 -0800 | [diff] [blame] | 50 | Api::Include(_) | Api::TypeAlias(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 51 | } |
| 52 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 53 | } |
| 54 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 55 | impl Check<'_> { |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 56 | pub(crate) fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 57 | self.errors.error(sp, msg); |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 58 | } |
| 59 | } |
| 60 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 61 | fn check_type_ident(cx: &mut Check, ident: &Ident) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 62 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 63 | && !cx.types.structs.contains_key(ident) |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 64 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 65 | && !cx.types.cxx.contains(ident) |
| 66 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 67 | { |
| David Tolnay | dbc5377 | 2020-10-28 17:28:51 -0700 | [diff] [blame] | 68 | let msg = format!("unsupported type: {}", ident); |
| 69 | cx.error(ident, &msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 70 | } |
| 71 | } |
| 72 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 73 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 74 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 75 | if cx.types.cxx.contains(&ident.rust) |
| 76 | && !cx.types.structs.contains_key(&ident.rust) |
| 77 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 78 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 79 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 80 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 81 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 82 | if Atom::from(&ident.rust).is_none() { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 83 | return; |
| 84 | } |
| 85 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 86 | |
| 87 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 88 | } |
| 89 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 90 | fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) { |
| 91 | if let Type::Ident(ident) = &ty.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 92 | if cx.types.cxx.contains(&ident.rust) |
| 93 | && !cx.types.structs.contains_key(&ident.rust) |
| 94 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 95 | { |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 96 | cx.error(ty, "Rust Vec containing C++ type is not supported yet"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 97 | return; |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 98 | } |
| 99 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 100 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 101 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 33f56ad | 2020-08-27 17:06:35 -0700 | [diff] [blame] | 102 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 103 | | Some(RustString) => return, |
| 104 | Some(Bool) => { /* todo */ } |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 105 | Some(CxxString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 106 | } |
| 107 | } |
| 108 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 109 | cx.error(ty, "unsupported element type of Vec"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 110 | } |
| 111 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 112 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 113 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 114 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 115 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 116 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 117 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 118 | match Atom::from(&ident.rust) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 119 | None | Some(CxxString) => return, |
| 120 | _ => {} |
| 121 | } |
| David Tolnay | 4377a9e | 2020-04-24 15:20:26 -0700 | [diff] [blame] | 122 | } else if let Type::CxxVector(_) = &ptr.inner { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 123 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 124 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 125 | |
| 126 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 127 | } |
| 128 | |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 129 | fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 130 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 131 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 132 | cx.error( |
| 133 | ptr, |
| 134 | "C++ vector containing a Rust type is not supported yet", |
| 135 | ); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 136 | } |
| 137 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 138 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 139 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 47e239d | 2020-08-28 00:32:04 -0700 | [diff] [blame] | 140 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 141 | | Some(CxxString) => return, |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 142 | Some(Bool) | Some(RustString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 143 | } |
| 144 | } |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 145 | |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 146 | cx.error(ptr, "unsupported vector target type"); |
| 147 | } |
| 148 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 149 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 150 | if ty.mutable && !ty.pinned { |
| David Tolnay | db42cfd | 2020-11-15 15:31:40 -0800 | [diff] [blame] | 151 | if let Some(requires_pin) = match &ty.inner { |
| 152 | Type::Ident(ident) if ident.rust == CxxString || is_opaque_cxx(cx, &ident.rust) => { |
| 153 | Some(ident.rust.to_string()) |
| 154 | } |
| 155 | Type::CxxVector(_) => Some("CxxVector<...>".to_owned()), |
| 156 | _ => None, |
| 157 | } { |
| 158 | cx.error( |
| 159 | ty, |
| 160 | format!( |
| 161 | "mutable reference to C++ type requires a pin -- use Pin<&mut {}>", |
| 162 | requires_pin, |
| 163 | ), |
| 164 | ); |
| 165 | } |
| 166 | } |
| 167 | |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 168 | match ty.inner { |
| 169 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 776fd89 | 2020-04-28 13:38:21 -0700 | [diff] [blame] | 170 | Type::Ref(_) => { |
| 171 | cx.error(ty, "C++ does not allow references to references"); |
| 172 | return; |
| 173 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 174 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 175 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 176 | |
| 177 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 178 | } |
| 179 | |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 180 | fn check_type_slice(cx: &mut Check, ty: &Slice) { |
| 181 | cx.error(ty, "only &[u8] is supported so far, not other slice types"); |
| 182 | } |
| 183 | |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame] | 184 | fn check_type_fn(cx: &mut Check, ty: &Signature) { |
| 185 | if ty.throws { |
| 186 | cx.error(ty, "function pointer returning Result is not supported yet"); |
| 187 | } |
| 188 | } |
| 189 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 190 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 191 | let name = &strct.name; |
| 192 | check_reserved_name(cx, &name.rust); |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 193 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 194 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 195 | let span = span_for_struct_error(strct); |
| 196 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 197 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 198 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 199 | if cx.types.cxx.contains(&name.rust) { |
| 200 | if let Some(ety) = cx.types.untrusted.get(&name.rust) { |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 201 | let msg = "extern shared struct must be declared in an `unsafe extern` block"; |
| 202 | cx.error(ety, msg); |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 203 | } |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 204 | } |
| 205 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 206 | for field in &strct.fields { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 207 | if is_unsized(cx, &field.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 208 | let desc = describe(cx, &field.ty); |
| 209 | let msg = format!("using {} by value is not supported", desc); |
| 210 | cx.error(field, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 211 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 212 | if let Type::Fn(_) = field.ty { |
| 213 | cx.error( |
| 214 | field, |
| 215 | "function pointers in a struct field are not implemented yet", |
| 216 | ); |
| 217 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 218 | } |
| 219 | } |
| 220 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 221 | fn check_api_enum(cx: &mut Check, enm: &Enum) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 222 | check_reserved_name(cx, &enm.name.rust); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 223 | |
| 224 | if enm.variants.is_empty() { |
| 225 | let span = span_for_enum_error(enm); |
| 226 | cx.error(span, "enums without any variants are not supported"); |
| 227 | } |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 228 | } |
| 229 | |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 230 | fn check_api_type(cx: &mut Check, ety: &ExternType) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 231 | check_reserved_name(cx, &ety.name.rust); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 232 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 233 | if let Some(reason) = cx.types.required_trivial.get(&ety.name.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 234 | let what = match reason { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 235 | TrivialReason::StructField(strct) => format!("a field of `{}`", strct.name.rust), |
| 236 | TrivialReason::FunctionArgument(efn) => format!("an argument of `{}`", efn.name.rust), |
| 237 | TrivialReason::FunctionReturn(efn) => format!("a return value of `{}`", efn.name.rust), |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 238 | }; |
| 239 | let msg = format!( |
| 240 | "needs a cxx::ExternType impl in order to be used as {}", |
| 241 | what, |
| 242 | ); |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 243 | cx.error(ety, msg); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 244 | } |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 245 | } |
| 246 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 247 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 9938b64 | 2020-11-15 18:11:40 -0800 | [diff] [blame] | 248 | match efn.lang { |
| 249 | Lang::Cxx => { |
| 250 | if !efn.generics.params.is_empty() && !efn.trusted { |
| 251 | let ref span = span_for_generics_error(efn); |
| 252 | cx.error(span, "extern C++ function with lifetimes must be declared in `unsafe extern \"C++\"` block"); |
| 253 | } |
| 254 | } |
| 255 | Lang::Rust => { |
| 256 | if !efn.generics.params.is_empty() && efn.unsafety.is_none() { |
| 257 | let ref span = span_for_generics_error(efn); |
| 258 | let message = format!( |
| 259 | "must be `unsafe fn {}` in order to expose explicit lifetimes to C++", |
| 260 | efn.name.rust, |
| 261 | ); |
| 262 | cx.error(span, message); |
| 263 | } |
| 264 | } |
| 265 | } |
| 266 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 267 | if let Some(receiver) = &efn.receiver { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 268 | let ref span = span_for_receiver_error(receiver); |
| 269 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 270 | if receiver.ty.is_self() { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 271 | let mutability = match receiver.mutable { |
| 272 | true => "mut ", |
| 273 | false => "", |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 274 | }; |
| 275 | let msg = format!( |
| 276 | "unnamed receiver type is only allowed if the surrounding \ |
| 277 | extern block contains exactly one extern type; \ |
| 278 | use `self: &{mutability}TheType`", |
| 279 | mutability = mutability, |
| 280 | ); |
| 281 | cx.error(span, msg); |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 282 | } else if !cx.types.structs.contains_key(&receiver.ty.rust) |
| 283 | && !cx.types.cxx.contains(&receiver.ty.rust) |
| 284 | && !cx.types.rust.contains(&receiver.ty.rust) |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 285 | { |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 286 | cx.error(span, "unrecognized receiver type"); |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 287 | } else if receiver.mutable && !receiver.pinned && is_opaque_cxx(cx, &receiver.ty.rust) { |
| David Tolnay | 75aea9a | 2020-11-15 16:07:25 -0800 | [diff] [blame] | 288 | cx.error( |
| 289 | span, |
| 290 | format!( |
| 291 | "mutable reference to C++ type requires a pin -- use `self: Pin<&mut {}>`", |
| 292 | receiver.ty.rust, |
| 293 | ), |
| 294 | ); |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 295 | } |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 296 | } |
| 297 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 298 | for arg in &efn.args { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 299 | if is_unsized(cx, &arg.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 300 | let desc = describe(cx, &arg.ty); |
| 301 | let msg = format!("passing {} by value is not supported", desc); |
| 302 | cx.error(arg, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 303 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 304 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 305 | if efn.lang == Lang::Rust { |
| 306 | cx.error( |
| 307 | arg, |
| 308 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 309 | ); |
| 310 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 311 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 312 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 313 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 314 | if let Some(ty) = &efn.ret { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 315 | if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 316 | let desc = describe(cx, ty); |
| 317 | let msg = format!("returning {} by value is not supported", desc); |
| 318 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 319 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 320 | if let Type::Fn(_) = ty { |
| 321 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 322 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 323 | } |
| David Tolnay | 96a826b | 2020-05-04 00:17:12 -0700 | [diff] [blame] | 324 | |
| 325 | if efn.lang == Lang::Cxx { |
| 326 | check_mut_return_restriction(cx, efn); |
| 327 | } |
| 328 | |
| 329 | check_multiple_arg_lifetimes(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 330 | } |
| 331 | |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 332 | fn check_api_impl(cx: &mut Check, imp: &Impl) { |
| 333 | if let Type::UniquePtr(ty) | Type::CxxVector(ty) = &imp.ty { |
| 334 | if let Type::Ident(inner) = &ty.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 335 | if Atom::from(&inner.rust).is_none() { |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 336 | return; |
| 337 | } |
| 338 | } |
| 339 | } |
| 340 | |
| 341 | cx.error(imp, "unsupported Self type of explicit impl"); |
| 342 | } |
| 343 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 344 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 345 | match &efn.ret { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 346 | Some(Type::Ref(ty)) if ty.mutable => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 347 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 348 | } |
| 349 | |
| 350 | for arg in &efn.args { |
| 351 | if let Type::Ref(ty) = &arg.ty { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 352 | if ty.mutable { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 353 | return; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 354 | } |
| 355 | } |
| 356 | } |
| 357 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 358 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 359 | efn, |
| 360 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 361 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 362 | } |
| 363 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 364 | fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 556738d | 2020-11-15 13:58:44 -0800 | [diff] [blame] | 365 | if efn.lang == Lang::Cxx && efn.trusted { |
| 366 | return; |
| 367 | } |
| 368 | |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 369 | match &efn.ret { |
| 370 | Some(Type::Ref(_)) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 371 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 372 | } |
| 373 | |
| 374 | let mut reference_args = 0; |
| 375 | for arg in &efn.args { |
| 376 | if let Type::Ref(_) = &arg.ty { |
| 377 | reference_args += 1; |
| 378 | } |
| 379 | } |
| 380 | |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 381 | if efn.receiver.is_some() { |
| 382 | reference_args += 1; |
| 383 | } |
| 384 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 385 | if reference_args != 1 { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 386 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 387 | efn, |
| 388 | "functions that return a reference must take exactly one input reference", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 389 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 390 | } |
| 391 | } |
| 392 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 393 | fn check_reserved_name(cx: &mut Check, ident: &Ident) { |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 394 | if ident == "Box" |
| 395 | || ident == "UniquePtr" |
| 396 | || ident == "Vec" |
| 397 | || ident == "CxxVector" |
| 398 | || Atom::from(ident).is_some() |
| 399 | { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 400 | cx.error(ident, "reserved name"); |
| 401 | } |
| 402 | } |
| 403 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 404 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame^] | 405 | match ty { |
| 406 | Type::Ident(ident) => { |
| 407 | let ident = &ident.rust; |
| 408 | ident == CxxString || is_opaque_cxx(cx, ident) || cx.types.rust.contains(ident) |
| 409 | } |
| David Tolnay | e70303c | 2020-04-25 15:02:37 -0700 | [diff] [blame] | 410 | Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true, |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame^] | 411 | Type::RustBox(_) |
| 412 | | Type::RustVec(_) |
| 413 | | Type::UniquePtr(_) |
| 414 | | Type::Ref(_) |
| 415 | | Type::Str(_) |
| 416 | | Type::Fn(_) |
| 417 | | Type::SliceRefU8(_) => return false, |
| 418 | } |
| David Tolnay | db42cfd | 2020-11-15 15:31:40 -0800 | [diff] [blame] | 419 | } |
| 420 | |
| 421 | fn is_opaque_cxx(cx: &mut Check, ty: &Ident) -> bool { |
| 422 | cx.types.cxx.contains(ty) |
| 423 | && !cx.types.structs.contains_key(ty) |
| 424 | && !cx.types.enums.contains_key(ty) |
| 425 | && !(cx.types.aliases.contains_key(ty) && cx.types.required_trivial.contains_key(ty)) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 426 | } |
| 427 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 428 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 429 | let struct_token = strct.struct_token; |
| 430 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 431 | brace_token.set_span(strct.brace_token.span); |
| 432 | quote!(#struct_token #brace_token) |
| 433 | } |
| 434 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 435 | fn span_for_enum_error(enm: &Enum) -> TokenStream { |
| 436 | let enum_token = enm.enum_token; |
| 437 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 438 | brace_token.set_span(enm.brace_token.span); |
| 439 | quote!(#enum_token #brace_token) |
| 440 | } |
| 441 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 442 | fn span_for_receiver_error(receiver: &Receiver) -> TokenStream { |
| 443 | let ampersand = receiver.ampersand; |
| 444 | let lifetime = &receiver.lifetime; |
| 445 | let mutability = receiver.mutability; |
| 446 | if receiver.shorthand { |
| 447 | let var = receiver.var; |
| 448 | quote!(#ampersand #lifetime #mutability #var) |
| 449 | } else { |
| 450 | let ty = &receiver.ty; |
| 451 | quote!(#ampersand #lifetime #mutability #ty) |
| 452 | } |
| 453 | } |
| 454 | |
| David Tolnay | 9938b64 | 2020-11-15 18:11:40 -0800 | [diff] [blame] | 455 | fn span_for_generics_error(efn: &ExternFn) -> TokenStream { |
| 456 | let unsafety = efn.unsafety; |
| 457 | let fn_token = efn.fn_token; |
| 458 | let generics = &efn.generics; |
| 459 | quote!(#unsafety #fn_token #generics) |
| 460 | } |
| 461 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 462 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 463 | match ty { |
| 464 | Type::Ident(ident) => { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 465 | if cx.types.structs.contains_key(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 466 | "struct".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 467 | } else if cx.types.enums.contains_key(&ident.rust) { |
| David Tolnay | 5548372 | 2020-08-29 18:27:37 -0700 | [diff] [blame] | 468 | "enum".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 469 | } else if cx.types.aliases.contains_key(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 470 | "C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 471 | } else if cx.types.cxx.contains(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 472 | "opaque C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 473 | } else if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 474 | "opaque Rust type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 475 | } else if Atom::from(&ident.rust) == Some(CxxString) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 476 | "C++ string".to_owned() |
| 477 | } else { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 478 | ident.rust.to_string() |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 479 | } |
| 480 | } |
| 481 | Type::RustBox(_) => "Box".to_owned(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 482 | Type::RustVec(_) => "Vec".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 483 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| 484 | Type::Ref(_) => "reference".to_owned(), |
| 485 | Type::Str(_) => "&str".to_owned(), |
| David Tolnay | fa85fce | 2020-04-25 15:03:25 -0700 | [diff] [blame] | 486 | Type::CxxVector(_) => "C++ vector".to_owned(), |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 487 | Type::Slice(_) => "slice".to_owned(), |
| 488 | Type::SliceRefU8(_) => "&[u8]".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 489 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 490 | Type::Void(_) => "()".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 491 | } |
| 492 | } |