| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 2 | use crate::syntax::report::Errors; |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 3 | use crate::syntax::types::TrivialReason; |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 4 | use crate::syntax::{ |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame^] | 5 | error, ident, Api, Enum, ExternFn, ExternType, Impl, Lang, Receiver, Ref, Signature, Slice, |
| 6 | Struct, Ty1, Type, Types, |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 7 | }; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 8 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 9 | use quote::{quote, ToTokens}; |
| 10 | use std::fmt::Display; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 11 | |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 12 | pub(crate) struct Check<'a> { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 13 | apis: &'a [Api], |
| 14 | types: &'a Types<'a>, |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 15 | errors: &'a mut Errors, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 16 | } |
| 17 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 18 | pub(crate) fn typecheck(cx: &mut Errors, apis: &[Api], types: &Types) { |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 19 | do_typecheck(&mut Check { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 20 | apis, |
| 21 | types, |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 22 | errors: cx, |
| 23 | }); |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 24 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 25 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 26 | fn do_typecheck(cx: &mut Check) { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 27 | ident::check_all(cx, cx.apis); |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 28 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 29 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 30 | match ty { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 31 | Type::Ident(ident) => check_type_ident(cx, &ident.rust), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 32 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 33 | Type::RustVec(ty) => check_type_rust_vec(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 34 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 35 | Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 36 | Type::Ref(ty) => check_type_ref(cx, ty), |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 37 | Type::Slice(ty) => check_type_slice(cx, ty), |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame^] | 38 | Type::Fn(ty) => check_type_fn(cx, ty), |
| 39 | Type::Str(_) | Type::Void(_) | Type::SliceRefU8(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 40 | } |
| 41 | } |
| 42 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 43 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 44 | match api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 45 | Api::Struct(strct) => check_api_struct(cx, strct), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 46 | Api::Enum(enm) => check_api_enum(cx, enm), |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 47 | Api::CxxType(ety) | Api::RustType(ety) => check_api_type(cx, ety), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 48 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 49 | Api::Impl(imp) => check_api_impl(cx, imp), |
| David Tolnay | 5ecaea9 | 2020-11-14 23:25:42 -0800 | [diff] [blame] | 50 | Api::Include(_) | Api::TypeAlias(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 51 | } |
| 52 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 53 | } |
| 54 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 55 | impl Check<'_> { |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 56 | pub(crate) fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 57 | self.errors.error(sp, msg); |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 58 | } |
| 59 | } |
| 60 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 61 | fn check_type_ident(cx: &mut Check, ident: &Ident) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 62 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 63 | && !cx.types.structs.contains_key(ident) |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 64 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 65 | && !cx.types.cxx.contains(ident) |
| 66 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 67 | { |
| David Tolnay | dbc5377 | 2020-10-28 17:28:51 -0700 | [diff] [blame] | 68 | let msg = format!("unsupported type: {}", ident); |
| 69 | cx.error(ident, &msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 70 | } |
| 71 | } |
| 72 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 73 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 74 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 75 | if cx.types.cxx.contains(&ident.rust) |
| 76 | && !cx.types.structs.contains_key(&ident.rust) |
| 77 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 78 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 79 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 80 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 81 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 82 | if Atom::from(&ident.rust).is_none() { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 83 | return; |
| 84 | } |
| 85 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 86 | |
| 87 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 88 | } |
| 89 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 90 | fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) { |
| 91 | if let Type::Ident(ident) = &ty.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 92 | if cx.types.cxx.contains(&ident.rust) |
| 93 | && !cx.types.structs.contains_key(&ident.rust) |
| 94 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 95 | { |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 96 | cx.error(ty, "Rust Vec containing C++ type is not supported yet"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 97 | return; |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 98 | } |
| 99 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 100 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 101 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 33f56ad | 2020-08-27 17:06:35 -0700 | [diff] [blame] | 102 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 103 | | Some(RustString) => return, |
| 104 | Some(Bool) => { /* todo */ } |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 105 | Some(CxxString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 106 | } |
| 107 | } |
| 108 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 109 | cx.error(ty, "unsupported element type of Vec"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 110 | } |
| 111 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 112 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 113 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 114 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 115 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 116 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 117 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 118 | match Atom::from(&ident.rust) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 119 | None | Some(CxxString) => return, |
| 120 | _ => {} |
| 121 | } |
| David Tolnay | 4377a9e | 2020-04-24 15:20:26 -0700 | [diff] [blame] | 122 | } else if let Type::CxxVector(_) = &ptr.inner { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 123 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 124 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 125 | |
| 126 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 127 | } |
| 128 | |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 129 | fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 130 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 131 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 132 | cx.error( |
| 133 | ptr, |
| 134 | "C++ vector containing a Rust type is not supported yet", |
| 135 | ); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 136 | } |
| 137 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 138 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 139 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 47e239d | 2020-08-28 00:32:04 -0700 | [diff] [blame] | 140 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 141 | | Some(CxxString) => return, |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 142 | Some(Bool) | Some(RustString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 143 | } |
| 144 | } |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 145 | |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 146 | cx.error(ptr, "unsupported vector target type"); |
| 147 | } |
| 148 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 149 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 150 | if ty.lifetime.is_some() { |
| 151 | cx.error(ty, "references with explicit lifetimes are not supported"); |
| 152 | } |
| 153 | |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 154 | match ty.inner { |
| 155 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 776fd89 | 2020-04-28 13:38:21 -0700 | [diff] [blame] | 156 | Type::Ref(_) => { |
| 157 | cx.error(ty, "C++ does not allow references to references"); |
| 158 | return; |
| 159 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 160 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 161 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 162 | |
| 163 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 164 | } |
| 165 | |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 166 | fn check_type_slice(cx: &mut Check, ty: &Slice) { |
| 167 | cx.error(ty, "only &[u8] is supported so far, not other slice types"); |
| 168 | } |
| 169 | |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame^] | 170 | fn check_type_fn(cx: &mut Check, ty: &Signature) { |
| 171 | if ty.throws { |
| 172 | cx.error(ty, "function pointer returning Result is not supported yet"); |
| 173 | } |
| 174 | } |
| 175 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 176 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 177 | let name = &strct.name; |
| 178 | check_reserved_name(cx, &name.rust); |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 179 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 180 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 181 | let span = span_for_struct_error(strct); |
| 182 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 183 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 184 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 185 | if cx.types.cxx.contains(&name.rust) { |
| 186 | if let Some(ety) = cx.types.untrusted.get(&name.rust) { |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 187 | let msg = "extern shared struct must be declared in an `unsafe extern` block"; |
| 188 | cx.error(ety, msg); |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 189 | } |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 190 | } |
| 191 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 192 | for field in &strct.fields { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 193 | if is_unsized(cx, &field.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 194 | let desc = describe(cx, &field.ty); |
| 195 | let msg = format!("using {} by value is not supported", desc); |
| 196 | cx.error(field, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 197 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 198 | if let Type::Fn(_) = field.ty { |
| 199 | cx.error( |
| 200 | field, |
| 201 | "function pointers in a struct field are not implemented yet", |
| 202 | ); |
| 203 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 204 | } |
| 205 | } |
| 206 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 207 | fn check_api_enum(cx: &mut Check, enm: &Enum) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 208 | check_reserved_name(cx, &enm.name.rust); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 209 | |
| 210 | if enm.variants.is_empty() { |
| 211 | let span = span_for_enum_error(enm); |
| 212 | cx.error(span, "enums without any variants are not supported"); |
| 213 | } |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 214 | } |
| 215 | |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 216 | fn check_api_type(cx: &mut Check, ety: &ExternType) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 217 | check_reserved_name(cx, &ety.name.rust); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 218 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 219 | if let Some(reason) = cx.types.required_trivial.get(&ety.name.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 220 | let what = match reason { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 221 | TrivialReason::StructField(strct) => format!("a field of `{}`", strct.name.rust), |
| 222 | TrivialReason::FunctionArgument(efn) => format!("an argument of `{}`", efn.name.rust), |
| 223 | TrivialReason::FunctionReturn(efn) => format!("a return value of `{}`", efn.name.rust), |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 224 | }; |
| 225 | let msg = format!( |
| 226 | "needs a cxx::ExternType impl in order to be used as {}", |
| 227 | what, |
| 228 | ); |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 229 | cx.error(ety, msg); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 230 | } |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 231 | } |
| 232 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 233 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 234 | if let Some(receiver) = &efn.receiver { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 235 | let ref span = span_for_receiver_error(receiver); |
| 236 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 237 | if receiver.ty.is_self() { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 238 | let mutability = match receiver.mutability { |
| 239 | Some(_) => "mut ", |
| 240 | None => "", |
| 241 | }; |
| 242 | let msg = format!( |
| 243 | "unnamed receiver type is only allowed if the surrounding \ |
| 244 | extern block contains exactly one extern type; \ |
| 245 | use `self: &{mutability}TheType`", |
| 246 | mutability = mutability, |
| 247 | ); |
| 248 | cx.error(span, msg); |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 249 | } else if !cx.types.structs.contains_key(&receiver.ty.rust) |
| 250 | && !cx.types.cxx.contains(&receiver.ty.rust) |
| 251 | && !cx.types.rust.contains(&receiver.ty.rust) |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 252 | { |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 253 | cx.error(span, "unrecognized receiver type"); |
| 254 | } |
| 255 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 256 | if receiver.lifetime.is_some() { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 257 | cx.error(span, "references with explicit lifetimes are not supported"); |
| 258 | } |
| 259 | } |
| 260 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 261 | for arg in &efn.args { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 262 | if is_unsized(cx, &arg.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 263 | let desc = describe(cx, &arg.ty); |
| 264 | let msg = format!("passing {} by value is not supported", desc); |
| 265 | cx.error(arg, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 266 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 267 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 268 | if efn.lang == Lang::Rust { |
| 269 | cx.error( |
| 270 | arg, |
| 271 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 272 | ); |
| 273 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 274 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 275 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 276 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 277 | if let Some(ty) = &efn.ret { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 278 | if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 279 | let desc = describe(cx, ty); |
| 280 | let msg = format!("returning {} by value is not supported", desc); |
| 281 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 282 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 283 | if let Type::Fn(_) = ty { |
| 284 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 285 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 286 | } |
| David Tolnay | 96a826b | 2020-05-04 00:17:12 -0700 | [diff] [blame] | 287 | |
| 288 | if efn.lang == Lang::Cxx { |
| 289 | check_mut_return_restriction(cx, efn); |
| 290 | } |
| 291 | |
| 292 | check_multiple_arg_lifetimes(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 293 | } |
| 294 | |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 295 | fn check_api_impl(cx: &mut Check, imp: &Impl) { |
| 296 | if let Type::UniquePtr(ty) | Type::CxxVector(ty) = &imp.ty { |
| 297 | if let Type::Ident(inner) = &ty.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 298 | if Atom::from(&inner.rust).is_none() { |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 299 | return; |
| 300 | } |
| 301 | } |
| 302 | } |
| 303 | |
| 304 | cx.error(imp, "unsupported Self type of explicit impl"); |
| 305 | } |
| 306 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 307 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 308 | match &efn.ret { |
| 309 | Some(Type::Ref(ty)) if ty.mutability.is_some() => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 310 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 311 | } |
| 312 | |
| 313 | for arg in &efn.args { |
| 314 | if let Type::Ref(ty) = &arg.ty { |
| 315 | if ty.mutability.is_some() { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 316 | return; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 317 | } |
| 318 | } |
| 319 | } |
| 320 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 321 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 322 | efn, |
| 323 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 324 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 325 | } |
| 326 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 327 | fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 328 | match &efn.ret { |
| 329 | Some(Type::Ref(_)) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 330 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 331 | } |
| 332 | |
| 333 | let mut reference_args = 0; |
| 334 | for arg in &efn.args { |
| 335 | if let Type::Ref(_) = &arg.ty { |
| 336 | reference_args += 1; |
| 337 | } |
| 338 | } |
| 339 | |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 340 | if efn.receiver.is_some() { |
| 341 | reference_args += 1; |
| 342 | } |
| 343 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 344 | if reference_args != 1 { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 345 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 346 | efn, |
| 347 | "functions that return a reference must take exactly one input reference", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 348 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 349 | } |
| 350 | } |
| 351 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 352 | fn check_reserved_name(cx: &mut Check, ident: &Ident) { |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 353 | if ident == "Box" |
| 354 | || ident == "UniquePtr" |
| 355 | || ident == "Vec" |
| 356 | || ident == "CxxVector" |
| 357 | || Atom::from(ident).is_some() |
| 358 | { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 359 | cx.error(ident, "reserved name"); |
| 360 | } |
| 361 | } |
| 362 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 363 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 364 | let ident = match ty { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 365 | Type::Ident(ident) => &ident.rust, |
| David Tolnay | e70303c | 2020-04-25 15:02:37 -0700 | [diff] [blame] | 366 | Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 367 | _ => return false, |
| 368 | }; |
| David Tolnay | 8984995 | 2020-08-29 18:32:29 -0700 | [diff] [blame] | 369 | ident == CxxString |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 370 | || cx.types.cxx.contains(ident) |
| 371 | && !cx.types.structs.contains_key(ident) |
| 372 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 373 | && !(cx.types.aliases.contains_key(ident) |
| 374 | && cx.types.required_trivial.contains_key(ident)) |
| David Tolnay | 8984995 | 2020-08-29 18:32:29 -0700 | [diff] [blame] | 375 | || cx.types.rust.contains(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 376 | } |
| 377 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 378 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 379 | let struct_token = strct.struct_token; |
| 380 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 381 | brace_token.set_span(strct.brace_token.span); |
| 382 | quote!(#struct_token #brace_token) |
| 383 | } |
| 384 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 385 | fn span_for_enum_error(enm: &Enum) -> TokenStream { |
| 386 | let enum_token = enm.enum_token; |
| 387 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 388 | brace_token.set_span(enm.brace_token.span); |
| 389 | quote!(#enum_token #brace_token) |
| 390 | } |
| 391 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 392 | fn span_for_receiver_error(receiver: &Receiver) -> TokenStream { |
| 393 | let ampersand = receiver.ampersand; |
| 394 | let lifetime = &receiver.lifetime; |
| 395 | let mutability = receiver.mutability; |
| 396 | if receiver.shorthand { |
| 397 | let var = receiver.var; |
| 398 | quote!(#ampersand #lifetime #mutability #var) |
| 399 | } else { |
| 400 | let ty = &receiver.ty; |
| 401 | quote!(#ampersand #lifetime #mutability #ty) |
| 402 | } |
| 403 | } |
| 404 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 405 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 406 | match ty { |
| 407 | Type::Ident(ident) => { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 408 | if cx.types.structs.contains_key(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 409 | "struct".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 410 | } else if cx.types.enums.contains_key(&ident.rust) { |
| David Tolnay | 5548372 | 2020-08-29 18:27:37 -0700 | [diff] [blame] | 411 | "enum".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 412 | } else if cx.types.aliases.contains_key(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 413 | "C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 414 | } else if cx.types.cxx.contains(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 415 | "opaque C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 416 | } else if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 417 | "opaque Rust type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 418 | } else if Atom::from(&ident.rust) == Some(CxxString) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 419 | "C++ string".to_owned() |
| 420 | } else { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 421 | ident.rust.to_string() |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 422 | } |
| 423 | } |
| 424 | Type::RustBox(_) => "Box".to_owned(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 425 | Type::RustVec(_) => "Vec".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 426 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| 427 | Type::Ref(_) => "reference".to_owned(), |
| 428 | Type::Str(_) => "&str".to_owned(), |
| David Tolnay | fa85fce | 2020-04-25 15:03:25 -0700 | [diff] [blame] | 429 | Type::CxxVector(_) => "C++ vector".to_owned(), |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 430 | Type::Slice(_) => "slice".to_owned(), |
| 431 | Type::SliceRefU8(_) => "&[u8]".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 432 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 433 | Type::Void(_) => "()".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 434 | } |
| 435 | } |