| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 2 | use crate::syntax::report::Errors; |
| David Tolnay | b55bd63 | 2021-03-26 17:47:29 -0400 | [diff] [blame] | 3 | use crate::syntax::visit::{self, Visit}; |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 4 | use crate::syntax::{ |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 5 | error, ident, trivial, Api, Array, Enum, ExternFn, ExternType, Impl, Lang, Lifetimes, |
| 6 | NamedType, Ptr, Receiver, Ref, Signature, SliceRef, Struct, Trait, Ty1, Type, TypeAlias, Types, |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 7 | }; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 8 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 9 | use quote::{quote, ToTokens}; |
| 10 | use std::fmt::Display; |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 11 | use syn::{GenericParam, Generics, Lifetime}; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 12 | |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 13 | pub(crate) struct Check<'a> { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 14 | apis: &'a [Api], |
| 15 | types: &'a Types<'a>, |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 16 | errors: &'a mut Errors, |
| David Tolnay | c46b0fa | 2021-04-08 18:38:30 -0700 | [diff] [blame] | 17 | generator: Generator, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 18 | } |
| 19 | |
| David Tolnay | c46b0fa | 2021-04-08 18:38:30 -0700 | [diff] [blame] | 20 | pub(crate) enum Generator { |
| 21 | // cxx-build crate, cxxbridge cli, cxx-gen. |
| 22 | #[allow(dead_code)] |
| 23 | Build, |
| 24 | // cxxbridge-macro. This is relevant in that the macro output is going to |
| 25 | // get fed straight to rustc, so for errors that rustc already contains |
| 26 | // logic to catch (probably with a better diagnostic than what the proc |
| 27 | // macro API is able to produce), we avoid duplicating them in our own |
| 28 | // diagnostics. |
| 29 | #[allow(dead_code)] |
| 30 | Macro, |
| 31 | } |
| 32 | |
| 33 | pub(crate) fn typecheck(cx: &mut Errors, apis: &[Api], types: &Types, generator: Generator) { |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 34 | do_typecheck(&mut Check { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 35 | apis, |
| 36 | types, |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 37 | errors: cx, |
| David Tolnay | c46b0fa | 2021-04-08 18:38:30 -0700 | [diff] [blame] | 38 | generator, |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 39 | }); |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 40 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 41 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 42 | fn do_typecheck(cx: &mut Check) { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 43 | ident::check_all(cx, cx.apis); |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 44 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 45 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 46 | match ty { |
| David Tolnay | 679b15d | 2020-12-30 20:39:06 -0800 | [diff] [blame] | 47 | Type::Ident(ident) => check_type_ident(cx, ident), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 48 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 49 | Type::RustVec(ty) => check_type_rust_vec(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 50 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 51 | Type::SharedPtr(ptr) => check_type_shared_ptr(cx, ptr), |
| David Tolnay | 215e77f | 2020-12-28 17:09:48 -0800 | [diff] [blame] | 52 | Type::WeakPtr(ptr) => check_type_weak_ptr(cx, ptr), |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 53 | Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 54 | Type::Ref(ty) => check_type_ref(cx, ty), |
| Adrian Taylor | 38ae228 | 2021-01-23 10:20:32 -0800 | [diff] [blame] | 55 | Type::Ptr(ty) => check_type_ptr(cx, ty), |
| Xiangpeng Hao | 7876235 | 2020-11-12 10:24:18 +0800 | [diff] [blame] | 56 | Type::Array(array) => check_type_array(cx, array), |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame] | 57 | Type::Fn(ty) => check_type_fn(cx, ty), |
| David Tolnay | 69db814 | 2020-11-25 17:49:25 -0800 | [diff] [blame] | 58 | Type::SliceRef(ty) => check_type_slice_ref(cx, ty), |
| 59 | Type::Str(_) | Type::Void(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 60 | } |
| 61 | } |
| 62 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 63 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 64 | match api { |
| David Tolnay | b7eb65e | 2020-11-27 20:00:53 -0800 | [diff] [blame] | 65 | Api::Include(_) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 66 | Api::Struct(strct) => check_api_struct(cx, strct), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 67 | Api::Enum(enm) => check_api_enum(cx, enm), |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 68 | Api::CxxType(ety) | Api::RustType(ety) => check_api_type(cx, ety), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 69 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | b7eb65e | 2020-11-27 20:00:53 -0800 | [diff] [blame] | 70 | Api::TypeAlias(alias) => check_api_type_alias(cx, alias), |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 71 | Api::Impl(imp) => check_api_impl(cx, imp), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 72 | } |
| 73 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 74 | } |
| 75 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 76 | impl Check<'_> { |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 77 | pub(crate) fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 78 | self.errors.error(sp, msg); |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 79 | } |
| 80 | } |
| 81 | |
| David Tolnay | 77a5e75 | 2021-01-01 14:15:18 -0800 | [diff] [blame] | 82 | fn check_type_ident(cx: &mut Check, name: &NamedType) { |
| David Tolnay | 679b15d | 2020-12-30 20:39:06 -0800 | [diff] [blame] | 83 | let ident = &name.rust; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 84 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 85 | && !cx.types.structs.contains_key(ident) |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 86 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 87 | && !cx.types.cxx.contains(ident) |
| 88 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 89 | { |
| David Tolnay | dbc5377 | 2020-10-28 17:28:51 -0700 | [diff] [blame] | 90 | let msg = format!("unsupported type: {}", ident); |
| 91 | cx.error(ident, &msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 92 | } |
| 93 | } |
| 94 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 95 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 96 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 97 | if cx.types.cxx.contains(&ident.rust) |
| David Tolnay | 25ed783 | 2020-12-04 18:20:45 -0800 | [diff] [blame] | 98 | && !cx.types.aliases.contains_key(&ident.rust) |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 99 | && !cx.types.structs.contains_key(&ident.rust) |
| 100 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 101 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 102 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 103 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 104 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 105 | if Atom::from(&ident.rust).is_none() { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 106 | return; |
| 107 | } |
| 108 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 109 | |
| 110 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 111 | } |
| 112 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 113 | fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) { |
| David Tolnay | 2d1fcc2 | 2021-01-03 22:43:19 -0800 | [diff] [blame] | 114 | match &ty.inner { |
| 115 | Type::Ident(ident) => { |
| 116 | if cx.types.cxx.contains(&ident.rust) |
| 117 | && !cx.types.aliases.contains_key(&ident.rust) |
| 118 | && !cx.types.structs.contains_key(&ident.rust) |
| 119 | && !cx.types.enums.contains_key(&ident.rust) |
| 120 | { |
| 121 | cx.error(ty, "Rust Vec containing C++ type is not supported yet"); |
| 122 | return; |
| 123 | } |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 124 | |
| David Tolnay | 2d1fcc2 | 2021-01-03 22:43:19 -0800 | [diff] [blame] | 125 | match Atom::from(&ident.rust) { |
| 126 | None | Some(Char) | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) |
| 127 | | Some(I8) | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) |
| 128 | | Some(F64) | Some(RustString) => return, |
| 129 | Some(Bool) => { /* todo */ } |
| 130 | Some(CxxString) => {} |
| 131 | } |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 132 | } |
| David Tolnay | 2d1fcc2 | 2021-01-03 22:43:19 -0800 | [diff] [blame] | 133 | Type::Str(_) => return, |
| 134 | _ => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 135 | } |
| 136 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 137 | cx.error(ty, "unsupported element type of Vec"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 138 | } |
| 139 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 140 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 141 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 142 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 143 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 144 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 145 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 146 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 147 | match Atom::from(&ident.rust) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 148 | None | Some(CxxString) => return, |
| 149 | _ => {} |
| 150 | } |
| David Tolnay | 4377a9e | 2020-04-24 15:20:26 -0700 | [diff] [blame] | 151 | } else if let Type::CxxVector(_) = &ptr.inner { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 152 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 153 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 154 | |
| 155 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 156 | } |
| 157 | |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 158 | fn check_type_shared_ptr(cx: &mut Check, ptr: &Ty1) { |
| 159 | if let Type::Ident(ident) = &ptr.inner { |
| 160 | if cx.types.rust.contains(&ident.rust) { |
| 161 | cx.error(ptr, "shared_ptr of a Rust type is not supported yet"); |
| 162 | return; |
| 163 | } |
| 164 | |
| 165 | match Atom::from(&ident.rust) { |
| David Tolnay | cd1430c | 2020-12-28 17:17:14 -0800 | [diff] [blame] | 166 | None | Some(Bool) | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) |
| 167 | | Some(I8) | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) |
| 168 | | Some(F64) | Some(CxxString) => return, |
| 169 | Some(Char) | Some(RustString) => {} |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 170 | } |
| 171 | } else if let Type::CxxVector(_) = &ptr.inner { |
| 172 | cx.error(ptr, "std::shared_ptr<std::vector> is not supported yet"); |
| 173 | return; |
| 174 | } |
| 175 | |
| 176 | cx.error(ptr, "unsupported shared_ptr target type"); |
| 177 | } |
| 178 | |
| David Tolnay | 215e77f | 2020-12-28 17:09:48 -0800 | [diff] [blame] | 179 | fn check_type_weak_ptr(cx: &mut Check, ptr: &Ty1) { |
| 180 | if let Type::Ident(ident) = &ptr.inner { |
| 181 | if cx.types.rust.contains(&ident.rust) { |
| 182 | cx.error(ptr, "weak_ptr of a Rust type is not supported yet"); |
| 183 | return; |
| 184 | } |
| 185 | |
| 186 | match Atom::from(&ident.rust) { |
| 187 | None | Some(Bool) | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) |
| 188 | | Some(I8) | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) |
| 189 | | Some(F64) | Some(CxxString) => return, |
| 190 | Some(Char) | Some(RustString) => {} |
| 191 | } |
| 192 | } else if let Type::CxxVector(_) = &ptr.inner { |
| 193 | cx.error(ptr, "std::weak_ptr<std::vector> is not supported yet"); |
| 194 | return; |
| 195 | } |
| 196 | |
| 197 | cx.error(ptr, "unsupported weak_ptr target type"); |
| 198 | } |
| 199 | |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 200 | fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 201 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 202 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 203 | cx.error( |
| 204 | ptr, |
| 205 | "C++ vector containing a Rust type is not supported yet", |
| 206 | ); |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 207 | return; |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 208 | } |
| 209 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 210 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 211 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 47e239d | 2020-08-28 00:32:04 -0700 | [diff] [blame] | 212 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 213 | | Some(CxxString) => return, |
| David Tolnay | b3873dc | 2020-11-25 19:47:49 -0800 | [diff] [blame] | 214 | Some(Char) => { /* todo */ } |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 215 | Some(Bool) | Some(RustString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 216 | } |
| 217 | } |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 218 | |
| David Tolnay | 4a02461 | 2021-03-26 17:11:00 -0400 | [diff] [blame] | 219 | cx.error(ptr, "unsupported vector element type"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 220 | } |
| 221 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 222 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 223 | if ty.mutable && !ty.pinned { |
| David Tolnay | db42cfd | 2020-11-15 15:31:40 -0800 | [diff] [blame] | 224 | if let Some(requires_pin) = match &ty.inner { |
| 225 | Type::Ident(ident) if ident.rust == CxxString || is_opaque_cxx(cx, &ident.rust) => { |
| 226 | Some(ident.rust.to_string()) |
| 227 | } |
| 228 | Type::CxxVector(_) => Some("CxxVector<...>".to_owned()), |
| 229 | _ => None, |
| 230 | } { |
| 231 | cx.error( |
| 232 | ty, |
| 233 | format!( |
| David Tolnay | ee0ccbe | 2020-12-21 13:04:35 -0800 | [diff] [blame] | 234 | "mutable reference to C++ type requires a pin -- use Pin<&mut {}>", |
| David Tolnay | db42cfd | 2020-11-15 15:31:40 -0800 | [diff] [blame] | 235 | requires_pin, |
| 236 | ), |
| 237 | ); |
| 238 | } |
| 239 | } |
| 240 | |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 241 | match ty.inner { |
| David Tolnay | bd313d5 | 2021-03-22 17:15:09 -0700 | [diff] [blame] | 242 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 776fd89 | 2020-04-28 13:38:21 -0700 | [diff] [blame] | 243 | Type::Ref(_) => { |
| 244 | cx.error(ty, "C++ does not allow references to references"); |
| 245 | return; |
| 246 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 247 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 248 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 249 | |
| 250 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 251 | } |
| 252 | |
| Adrian Taylor | 38ae228 | 2021-01-23 10:20:32 -0800 | [diff] [blame] | 253 | fn check_type_ptr(cx: &mut Check, ty: &Ptr) { |
| David Tolnay | d91d2a8 | 2021-03-22 17:10:49 -0700 | [diff] [blame] | 254 | match ty.inner { |
| David Tolnay | bd313d5 | 2021-03-22 17:15:09 -0700 | [diff] [blame] | 255 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 2a2264c | 2021-03-22 17:13:22 -0700 | [diff] [blame] | 256 | Type::Ref(_) => { |
| 257 | cx.error(ty, "C++ does not allow pointer to reference as a type"); |
| 258 | return; |
| 259 | } |
| David Tolnay | d91d2a8 | 2021-03-22 17:10:49 -0700 | [diff] [blame] | 260 | _ => return, |
| David Tolnay | 7c3197e | 2021-03-22 14:25:14 -0700 | [diff] [blame] | 261 | } |
| Adrian Taylor | 38ae228 | 2021-01-23 10:20:32 -0800 | [diff] [blame] | 262 | |
| 263 | cx.error(ty, "unsupported pointer type"); |
| 264 | } |
| 265 | |
| David Tolnay | 69db814 | 2020-11-25 17:49:25 -0800 | [diff] [blame] | 266 | fn check_type_slice_ref(cx: &mut Check, ty: &SliceRef) { |
| David Tolnay | bf9d6e8 | 2021-01-02 23:08:22 -0800 | [diff] [blame] | 267 | let supported = !is_unsized(cx, &ty.inner) |
| 268 | || match &ty.inner { |
| 269 | Type::Ident(ident) => cx.types.rust.contains(&ident.rust), |
| 270 | _ => false, |
| 271 | }; |
| David Tolnay | 5515a9e | 2020-11-25 19:07:54 -0800 | [diff] [blame] | 272 | |
| 273 | if !supported { |
| 274 | let mutable = if ty.mutable { "mut " } else { "" }; |
| 275 | let mut msg = format!("unsupported &{}[T] element type", mutable); |
| 276 | if let Type::Ident(ident) = &ty.inner { |
| David Tolnay | 3adf3c8 | 2020-12-27 02:21:45 -0800 | [diff] [blame] | 277 | if is_opaque_cxx(cx, &ident.rust) { |
| David Tolnay | 5515a9e | 2020-11-25 19:07:54 -0800 | [diff] [blame] | 278 | msg += ": opaque C++ type is not supported yet"; |
| 279 | } |
| David Tolnay | 85ef67a | 2020-11-25 17:51:27 -0800 | [diff] [blame] | 280 | } |
| David Tolnay | 5515a9e | 2020-11-25 19:07:54 -0800 | [diff] [blame] | 281 | cx.error(ty, msg); |
| David Tolnay | 69db814 | 2020-11-25 17:49:25 -0800 | [diff] [blame] | 282 | } |
| 283 | } |
| 284 | |
| Xiangpeng Hao | 7876235 | 2020-11-12 10:24:18 +0800 | [diff] [blame] | 285 | fn check_type_array(cx: &mut Check, ty: &Array) { |
| David Tolnay | bf9d6e8 | 2021-01-02 23:08:22 -0800 | [diff] [blame] | 286 | let supported = !is_unsized(cx, &ty.inner); |
| David Tolnay | da2558e | 2020-11-25 17:15:23 -0800 | [diff] [blame] | 287 | |
| 288 | if !supported { |
| David Tolnay | c465829 | 2020-11-24 21:24:30 -0800 | [diff] [blame] | 289 | cx.error(ty, "unsupported array element type"); |
| David Tolnay | e8b1bb4 | 2020-11-24 20:37:37 -0800 | [diff] [blame] | 290 | } |
| Xiangpeng Hao | 7876235 | 2020-11-12 10:24:18 +0800 | [diff] [blame] | 291 | } |
| 292 | |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame] | 293 | fn check_type_fn(cx: &mut Check, ty: &Signature) { |
| 294 | if ty.throws { |
| 295 | cx.error(ty, "function pointer returning Result is not supported yet"); |
| 296 | } |
| David Tolnay | aba7ab1 | 2021-03-22 16:56:15 -0700 | [diff] [blame] | 297 | |
| 298 | for arg in &ty.args { |
| 299 | if let Type::Ptr(_) = arg.ty { |
| 300 | if ty.unsafety.is_none() { |
| 301 | cx.error( |
| 302 | arg, |
| 303 | "pointer argument requires that the function pointer be marked unsafe", |
| 304 | ); |
| 305 | } |
| 306 | } |
| 307 | } |
| David Tolnay | 1db70c4 | 2020-11-14 23:28:58 -0800 | [diff] [blame] | 308 | } |
| 309 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 310 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 311 | let name = &strct.name; |
| 312 | check_reserved_name(cx, &name.rust); |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 313 | check_lifetimes(cx, &strct.generics); |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 314 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 315 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 316 | let span = span_for_struct_error(strct); |
| 317 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 318 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 319 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 320 | if cx.types.cxx.contains(&name.rust) { |
| 321 | if let Some(ety) = cx.types.untrusted.get(&name.rust) { |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 322 | let msg = "extern shared struct must be declared in an `unsafe extern` block"; |
| 323 | cx.error(ety, msg); |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 324 | } |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 325 | } |
| 326 | |
| David Tolnay | 16e2620 | 2020-11-27 19:28:37 -0800 | [diff] [blame] | 327 | for derive in &strct.derives { |
| 328 | if derive.what == Trait::ExternType { |
| 329 | let msg = format!("derive({}) on shared struct is not supported", derive); |
| 330 | cx.error(derive, msg); |
| 331 | } |
| 332 | } |
| 333 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 334 | for field in &strct.fields { |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 335 | if let Type::Fn(_) = field.ty { |
| 336 | cx.error( |
| 337 | field, |
| 338 | "function pointers in a struct field are not implemented yet", |
| 339 | ); |
| David Tolnay | 817f09e | 2020-11-25 16:58:35 -0800 | [diff] [blame] | 340 | } else if is_unsized(cx, &field.ty) { |
| 341 | let desc = describe(cx, &field.ty); |
| 342 | let msg = format!("using {} by value is not supported", desc); |
| 343 | cx.error(field, msg); |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 344 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 345 | } |
| 346 | } |
| 347 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 348 | fn check_api_enum(cx: &mut Check, enm: &Enum) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 349 | check_reserved_name(cx, &enm.name.rust); |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 350 | check_lifetimes(cx, &enm.generics); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 351 | |
| David Tolnay | 58eee39 | 2020-11-20 20:37:58 -0800 | [diff] [blame] | 352 | if enm.variants.is_empty() && !enm.explicit_repr { |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 353 | let span = span_for_enum_error(enm); |
| David Tolnay | b4f4fac | 2020-11-22 00:26:02 -0800 | [diff] [blame] | 354 | cx.error( |
| 355 | span, |
| 356 | "explicit #[repr(...)] is required for enum without any variants", |
| 357 | ); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 358 | } |
| David Tolnay | a6a9e94 | 2020-11-27 17:22:35 -0800 | [diff] [blame] | 359 | |
| 360 | for derive in &enm.derives { |
| David Tolnay | 16e2620 | 2020-11-27 19:28:37 -0800 | [diff] [blame] | 361 | if derive.what == Trait::Default || derive.what == Trait::ExternType { |
| 362 | let msg = format!("derive({}) on shared enum is not supported", derive); |
| 363 | cx.error(derive, msg); |
| David Tolnay | a6a9e94 | 2020-11-27 17:22:35 -0800 | [diff] [blame] | 364 | } |
| 365 | } |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 366 | } |
| 367 | |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 368 | fn check_api_type(cx: &mut Check, ety: &ExternType) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 369 | check_reserved_name(cx, &ety.name.rust); |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 370 | check_lifetimes(cx, &ety.generics); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 371 | |
| David Tolnay | 16e2620 | 2020-11-27 19:28:37 -0800 | [diff] [blame] | 372 | for derive in &ety.derives { |
| 373 | if derive.what == Trait::ExternType && ety.lang == Lang::Rust { |
| 374 | continue; |
| 375 | } |
| 376 | let lang = match ety.lang { |
| 377 | Lang::Rust => "Rust", |
| 378 | Lang::Cxx => "C++", |
| 379 | }; |
| 380 | let msg = format!( |
| 381 | "derive({}) on opaque {} type is not supported yet", |
| 382 | derive, lang, |
| 383 | ); |
| 384 | cx.error(derive, msg); |
| 385 | } |
| 386 | |
| David Tolnay | b7eb65e | 2020-11-27 20:00:53 -0800 | [diff] [blame] | 387 | if !ety.bounds.is_empty() { |
| 388 | let bounds = &ety.bounds; |
| 389 | let span = quote!(#(#bounds)*); |
| 390 | cx.error(span, "extern type bounds are not implemented yet"); |
| 391 | } |
| 392 | |
| Adrian Taylor | f831a5a | 2020-12-07 16:49:19 -0800 | [diff] [blame] | 393 | if let Some(reasons) = cx.types.required_trivial.get(&ety.name.rust) { |
| David Tolnay | 5b1d863 | 2020-12-20 22:05:11 -0800 | [diff] [blame] | 394 | let msg = format!( |
| 395 | "needs a cxx::ExternType impl in order to be used as {}", |
| 396 | trivial::as_what(&ety.name, reasons), |
| 397 | ); |
| 398 | cx.error(ety, msg); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 399 | } |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 400 | } |
| 401 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 402 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 9938b64 | 2020-11-15 18:11:40 -0800 | [diff] [blame] | 403 | match efn.lang { |
| 404 | Lang::Cxx => { |
| 405 | if !efn.generics.params.is_empty() && !efn.trusted { |
| 406 | let ref span = span_for_generics_error(efn); |
| 407 | cx.error(span, "extern C++ function with lifetimes must be declared in `unsafe extern \"C++\"` block"); |
| 408 | } |
| 409 | } |
| 410 | Lang::Rust => { |
| 411 | if !efn.generics.params.is_empty() && efn.unsafety.is_none() { |
| 412 | let ref span = span_for_generics_error(efn); |
| 413 | let message = format!( |
| 414 | "must be `unsafe fn {}` in order to expose explicit lifetimes to C++", |
| 415 | efn.name.rust, |
| 416 | ); |
| 417 | cx.error(span, message); |
| 418 | } |
| 419 | } |
| 420 | } |
| 421 | |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 422 | check_generics(cx, &efn.sig.generics); |
| 423 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 424 | if let Some(receiver) = &efn.receiver { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 425 | let ref span = span_for_receiver_error(receiver); |
| 426 | |
| David Tolnay | 2d99b00 | 2020-12-21 14:34:35 -0800 | [diff] [blame] | 427 | if receiver.ty.rust == "Self" { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 428 | let mutability = match receiver.mutable { |
| 429 | true => "mut ", |
| 430 | false => "", |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 431 | }; |
| 432 | let msg = format!( |
| David Tolnay | 35f07db | 2021-02-07 13:38:00 -0800 | [diff] [blame] | 433 | "unnamed receiver type is only allowed if the surrounding extern block contains exactly one extern type; use `self: &{mutability}TheType`", |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 434 | mutability = mutability, |
| 435 | ); |
| 436 | cx.error(span, msg); |
| Fletcher Woodruff | 0ba1079 | 2021-01-20 14:09:04 -0700 | [diff] [blame] | 437 | } else if cx.types.enums.contains_key(&receiver.ty.rust) { |
| David Tolnay | d156084 | 2021-02-07 13:36:26 -0800 | [diff] [blame] | 438 | cx.error( |
| 439 | span, |
| 440 | "unsupported receiver type; C++ does not allow member functions on enums", |
| 441 | ); |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 442 | } else if !cx.types.structs.contains_key(&receiver.ty.rust) |
| 443 | && !cx.types.cxx.contains(&receiver.ty.rust) |
| 444 | && !cx.types.rust.contains(&receiver.ty.rust) |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 445 | { |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 446 | cx.error(span, "unrecognized receiver type"); |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 447 | } else if receiver.mutable && !receiver.pinned && is_opaque_cxx(cx, &receiver.ty.rust) { |
| David Tolnay | 75aea9a | 2020-11-15 16:07:25 -0800 | [diff] [blame] | 448 | cx.error( |
| 449 | span, |
| 450 | format!( |
| David Tolnay | ee0ccbe | 2020-12-21 13:04:35 -0800 | [diff] [blame] | 451 | "mutable reference to opaque C++ type requires a pin -- use `self: Pin<&mut {}>`", |
| David Tolnay | 75aea9a | 2020-11-15 16:07:25 -0800 | [diff] [blame] | 452 | receiver.ty.rust, |
| 453 | ), |
| 454 | ); |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 455 | } |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 456 | } |
| 457 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 458 | for arg in &efn.args { |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 459 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 460 | if efn.lang == Lang::Rust { |
| 461 | cx.error( |
| 462 | arg, |
| 463 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 464 | ); |
| 465 | } |
| David Tolnay | 2857796 | 2021-03-22 15:53:36 -0700 | [diff] [blame] | 466 | } else if let Type::Ptr(_) = arg.ty { |
| 467 | if efn.sig.unsafety.is_none() { |
| 468 | cx.error( |
| 469 | arg, |
| 470 | "pointer argument requires that the function be marked unsafe", |
| 471 | ); |
| 472 | } |
| David Tolnay | 817f09e | 2020-11-25 16:58:35 -0800 | [diff] [blame] | 473 | } else if is_unsized(cx, &arg.ty) { |
| 474 | let desc = describe(cx, &arg.ty); |
| 475 | let msg = format!("passing {} by value is not supported", desc); |
| 476 | cx.error(arg, msg); |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 477 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 478 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 479 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 480 | if let Some(ty) = &efn.ret { |
| David Tolnay | 817f09e | 2020-11-25 16:58:35 -0800 | [diff] [blame] | 481 | if let Type::Fn(_) = ty { |
| 482 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 483 | } else if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 484 | let desc = describe(cx, ty); |
| 485 | let msg = format!("returning {} by value is not supported", desc); |
| 486 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 487 | } |
| 488 | } |
| David Tolnay | 96a826b | 2020-05-04 00:17:12 -0700 | [diff] [blame] | 489 | |
| 490 | if efn.lang == Lang::Cxx { |
| 491 | check_mut_return_restriction(cx, efn); |
| 492 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 493 | } |
| 494 | |
| David Tolnay | b7eb65e | 2020-11-27 20:00:53 -0800 | [diff] [blame] | 495 | fn check_api_type_alias(cx: &mut Check, alias: &TypeAlias) { |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 496 | check_lifetimes(cx, &alias.generics); |
| 497 | |
| David Tolnay | b7eb65e | 2020-11-27 20:00:53 -0800 | [diff] [blame] | 498 | for derive in &alias.derives { |
| 499 | let msg = format!("derive({}) on extern type alias is not supported", derive); |
| 500 | cx.error(derive, msg); |
| 501 | } |
| 502 | } |
| 503 | |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 504 | fn check_api_impl(cx: &mut Check, imp: &Impl) { |
| David Tolnay | 028d3d2 | 2020-11-29 18:09:52 -0800 | [diff] [blame] | 505 | let ty = &imp.ty; |
| 506 | |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 507 | check_lifetimes(cx, &imp.impl_generics); |
| 508 | |
| David Tolnay | 028d3d2 | 2020-11-29 18:09:52 -0800 | [diff] [blame] | 509 | if let Some(negative) = imp.negative_token { |
| 510 | let span = quote!(#negative #ty); |
| 511 | cx.error(span, "negative impl is not supported yet"); |
| 512 | return; |
| 513 | } |
| 514 | |
| David Tolnay | f33bc24 | 2020-12-04 18:27:02 -0800 | [diff] [blame] | 515 | match ty { |
| 516 | Type::RustBox(ty) |
| 517 | | Type::RustVec(ty) |
| 518 | | Type::UniquePtr(ty) |
| 519 | | Type::SharedPtr(ty) |
| David Tolnay | 215e77f | 2020-12-28 17:09:48 -0800 | [diff] [blame] | 520 | | Type::WeakPtr(ty) |
| David Tolnay | f33bc24 | 2020-12-04 18:27:02 -0800 | [diff] [blame] | 521 | | Type::CxxVector(ty) => { |
| 522 | if let Type::Ident(inner) = &ty.inner { |
| 523 | if Atom::from(&inner.rust).is_none() { |
| 524 | return; |
| 525 | } |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 526 | } |
| 527 | } |
| David Tolnay | f33bc24 | 2020-12-04 18:27:02 -0800 | [diff] [blame] | 528 | _ => {} |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 529 | } |
| 530 | |
| 531 | cx.error(imp, "unsupported Self type of explicit impl"); |
| 532 | } |
| 533 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 534 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 04376c7 | 2021-03-26 17:08:48 -0400 | [diff] [blame] | 535 | if efn.sig.unsafety.is_some() { |
| 536 | // Unrestricted as long as the function is made unsafe-to-call. |
| 537 | return; |
| 538 | } |
| 539 | |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 540 | match &efn.ret { |
| David Tolnay | 9c4ac2e | 2020-11-15 21:14:03 -0800 | [diff] [blame] | 541 | Some(Type::Ref(ty)) if ty.mutable => {} |
| David Tolnay | 22cb288 | 2021-03-28 03:55:34 -0400 | [diff] [blame] | 542 | Some(Type::SliceRef(slice)) if slice.mutable => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 543 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 544 | } |
| 545 | |
| David Tolnay | b55bd63 | 2021-03-26 17:47:29 -0400 | [diff] [blame] | 546 | if let Some(receiver) = &efn.receiver { |
| 547 | if receiver.mutable { |
| 548 | return; |
| 549 | } |
| David Tolnay | 06ef96f | 2021-03-28 04:06:48 -0400 | [diff] [blame] | 550 | let resolve = match cx.types.try_resolve(&receiver.ty) { |
| 551 | Some(resolve) => resolve, |
| 552 | None => return, |
| 553 | }; |
| David Tolnay | b55bd63 | 2021-03-26 17:47:29 -0400 | [diff] [blame] | 554 | if !resolve.generics.lifetimes.is_empty() { |
| David Tolnay | a020d10 | 2020-12-16 15:08:20 -0800 | [diff] [blame] | 555 | return; |
| 556 | } |
| 557 | } |
| 558 | |
| David Tolnay | b55bd63 | 2021-03-26 17:47:29 -0400 | [diff] [blame] | 559 | struct FindLifetimeMut<'a> { |
| 560 | cx: &'a Check<'a>, |
| 561 | found: bool, |
| 562 | } |
| 563 | |
| 564 | impl<'t, 'a> Visit<'t> for FindLifetimeMut<'a> { |
| 565 | fn visit_type(&mut self, ty: &'t Type) { |
| 566 | self.found |= match ty { |
| 567 | Type::Ref(ty) => ty.mutable, |
| David Tolnay | ffd6f84 | 2021-03-28 04:14:12 -0400 | [diff] [blame] | 568 | Type::SliceRef(slice) => slice.mutable, |
| David Tolnay | 06ef96f | 2021-03-28 04:06:48 -0400 | [diff] [blame] | 569 | Type::Ident(ident) if Atom::from(&ident.rust).is_none() => { |
| 570 | match self.cx.types.try_resolve(ident) { |
| 571 | Some(resolve) => !resolve.generics.lifetimes.is_empty(), |
| 572 | None => true, |
| 573 | } |
| David Tolnay | b55bd63 | 2021-03-26 17:47:29 -0400 | [diff] [blame] | 574 | } |
| 575 | _ => false, |
| 576 | }; |
| 577 | visit::visit_type(self, ty); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 578 | } |
| 579 | } |
| 580 | |
| David Tolnay | b55bd63 | 2021-03-26 17:47:29 -0400 | [diff] [blame] | 581 | let mut visitor = FindLifetimeMut { cx, found: false }; |
| 582 | |
| 583 | for arg in &efn.args { |
| 584 | visitor.visit_type(&arg.ty); |
| 585 | } |
| 586 | |
| 587 | if visitor.found { |
| 588 | return; |
| 589 | } |
| 590 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 591 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 592 | efn, |
| 593 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 594 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 595 | } |
| 596 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 597 | fn check_reserved_name(cx: &mut Check, ident: &Ident) { |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 598 | if ident == "Box" |
| 599 | || ident == "UniquePtr" |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 600 | || ident == "SharedPtr" |
| David Tolnay | 215e77f | 2020-12-28 17:09:48 -0800 | [diff] [blame] | 601 | || ident == "WeakPtr" |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 602 | || ident == "Vec" |
| 603 | || ident == "CxxVector" |
| David Tolnay | 4de3481 | 2020-11-19 14:48:55 -0800 | [diff] [blame] | 604 | || ident == "str" |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 605 | || Atom::from(ident).is_some() |
| 606 | { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 607 | cx.error(ident, "reserved name"); |
| 608 | } |
| 609 | } |
| 610 | |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 611 | fn check_reserved_lifetime(cx: &mut Check, lifetime: &Lifetime) { |
| 612 | if lifetime.ident == "static" { |
| David Tolnay | c46b0fa | 2021-04-08 18:38:30 -0700 | [diff] [blame] | 613 | match cx.generator { |
| 614 | Generator::Macro => { /* rustc already reports this */ } |
| 615 | Generator::Build => { |
| 616 | cx.error(lifetime, error::RESERVED_LIFETIME); |
| 617 | } |
| 618 | } |
| David Tolnay | ef1b70d | 2021-04-08 18:20:29 -0700 | [diff] [blame] | 619 | } |
| 620 | } |
| 621 | |
| 622 | fn check_lifetimes(cx: &mut Check, generics: &Lifetimes) { |
| 623 | for lifetime in &generics.lifetimes { |
| 624 | check_reserved_lifetime(cx, lifetime); |
| 625 | } |
| 626 | } |
| 627 | |
| 628 | fn check_generics(cx: &mut Check, generics: &Generics) { |
| 629 | for generic_param in &generics.params { |
| 630 | if let GenericParam::Lifetime(def) = generic_param { |
| 631 | check_reserved_lifetime(cx, &def.lifetime); |
| 632 | } |
| 633 | } |
| 634 | } |
| 635 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 636 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame] | 637 | match ty { |
| 638 | Type::Ident(ident) => { |
| 639 | let ident = &ident.rust; |
| 640 | ident == CxxString || is_opaque_cxx(cx, ident) || cx.types.rust.contains(ident) |
| 641 | } |
| David Tolnay | 8f8d78d | 2020-11-24 20:29:49 -0800 | [diff] [blame] | 642 | Type::Array(array) => is_unsized(cx, &array.inner), |
| David Tolnay | e0dca7b | 2020-11-25 17:18:57 -0800 | [diff] [blame] | 643 | Type::CxxVector(_) | Type::Fn(_) | Type::Void(_) => true, |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame] | 644 | Type::RustBox(_) |
| 645 | | Type::RustVec(_) |
| 646 | | Type::UniquePtr(_) |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 647 | | Type::SharedPtr(_) |
| David Tolnay | 215e77f | 2020-12-28 17:09:48 -0800 | [diff] [blame] | 648 | | Type::WeakPtr(_) |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame] | 649 | | Type::Ref(_) |
| Adrian Taylor | 38ae228 | 2021-01-23 10:20:32 -0800 | [diff] [blame] | 650 | | Type::Ptr(_) |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame] | 651 | | Type::Str(_) |
| David Tolnay | 73b7264 | 2020-11-25 17:44:05 -0800 | [diff] [blame] | 652 | | Type::SliceRef(_) => false, |
| David Tolnay | 70e5bfb | 2020-11-19 14:45:33 -0800 | [diff] [blame] | 653 | } |
| David Tolnay | db42cfd | 2020-11-15 15:31:40 -0800 | [diff] [blame] | 654 | } |
| 655 | |
| 656 | fn is_opaque_cxx(cx: &mut Check, ty: &Ident) -> bool { |
| 657 | cx.types.cxx.contains(ty) |
| 658 | && !cx.types.structs.contains_key(ty) |
| 659 | && !cx.types.enums.contains_key(ty) |
| 660 | && !(cx.types.aliases.contains_key(ty) && cx.types.required_trivial.contains_key(ty)) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 661 | } |
| 662 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 663 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 664 | let struct_token = strct.struct_token; |
| 665 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 666 | brace_token.set_span(strct.brace_token.span); |
| 667 | quote!(#struct_token #brace_token) |
| 668 | } |
| 669 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 670 | fn span_for_enum_error(enm: &Enum) -> TokenStream { |
| 671 | let enum_token = enm.enum_token; |
| 672 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 673 | brace_token.set_span(enm.brace_token.span); |
| 674 | quote!(#enum_token #brace_token) |
| 675 | } |
| 676 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 677 | fn span_for_receiver_error(receiver: &Receiver) -> TokenStream { |
| 678 | let ampersand = receiver.ampersand; |
| 679 | let lifetime = &receiver.lifetime; |
| 680 | let mutability = receiver.mutability; |
| 681 | if receiver.shorthand { |
| 682 | let var = receiver.var; |
| 683 | quote!(#ampersand #lifetime #mutability #var) |
| 684 | } else { |
| 685 | let ty = &receiver.ty; |
| 686 | quote!(#ampersand #lifetime #mutability #ty) |
| 687 | } |
| 688 | } |
| 689 | |
| David Tolnay | 9938b64 | 2020-11-15 18:11:40 -0800 | [diff] [blame] | 690 | fn span_for_generics_error(efn: &ExternFn) -> TokenStream { |
| 691 | let unsafety = efn.unsafety; |
| 692 | let fn_token = efn.fn_token; |
| 693 | let generics = &efn.generics; |
| 694 | quote!(#unsafety #fn_token #generics) |
| 695 | } |
| 696 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 697 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 698 | match ty { |
| 699 | Type::Ident(ident) => { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 700 | if cx.types.structs.contains_key(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 701 | "struct".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 702 | } else if cx.types.enums.contains_key(&ident.rust) { |
| David Tolnay | 5548372 | 2020-08-29 18:27:37 -0700 | [diff] [blame] | 703 | "enum".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 704 | } else if cx.types.aliases.contains_key(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 705 | "C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 706 | } else if cx.types.cxx.contains(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 707 | "opaque C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 708 | } else if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 709 | "opaque Rust type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 710 | } else if Atom::from(&ident.rust) == Some(CxxString) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 711 | "C++ string".to_owned() |
| David Tolnay | b3873dc | 2020-11-25 19:47:49 -0800 | [diff] [blame] | 712 | } else if Atom::from(&ident.rust) == Some(Char) { |
| 713 | "C char".to_owned() |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 714 | } else { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 715 | ident.rust.to_string() |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 716 | } |
| 717 | } |
| 718 | Type::RustBox(_) => "Box".to_owned(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 719 | Type::RustVec(_) => "Vec".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 720 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| David Tolnay | b3b24a1 | 2020-12-01 15:27:43 -0800 | [diff] [blame] | 721 | Type::SharedPtr(_) => "shared_ptr".to_owned(), |
| David Tolnay | 215e77f | 2020-12-28 17:09:48 -0800 | [diff] [blame] | 722 | Type::WeakPtr(_) => "weak_ptr".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 723 | Type::Ref(_) => "reference".to_owned(), |
| Adrian Taylor | 38ae228 | 2021-01-23 10:20:32 -0800 | [diff] [blame] | 724 | Type::Ptr(_) => "raw pointer".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 725 | Type::Str(_) => "&str".to_owned(), |
| David Tolnay | fa85fce | 2020-04-25 15:03:25 -0700 | [diff] [blame] | 726 | Type::CxxVector(_) => "C++ vector".to_owned(), |
| David Tolnay | 5515a9e | 2020-11-25 19:07:54 -0800 | [diff] [blame] | 727 | Type::SliceRef(_) => "slice".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 728 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 729 | Type::Void(_) => "()".to_owned(), |
| Xiangpeng Hao | 7876235 | 2020-11-12 10:24:18 +0800 | [diff] [blame] | 730 | Type::Array(_) => "array".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 731 | } |
| 732 | } |