blob: 21185eb7a58a1739bff72ea66370937b27c5eecb [file] [log] [blame]
Brian Osman088913a2019-12-19 15:44:56 -05001/*
2 * Copyright 2019 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
Brian Osman62419612020-07-22 10:19:02 -04008#include "include/core/SkBitmap.h"
Brian Osmanf72dedd2020-01-08 13:19:58 -05009#include "include/core/SkCanvas.h"
Brian Osman92aac1e2020-08-05 16:48:58 -040010#include "include/core/SkColorFilter.h"
Brian Osman269b21c2020-08-06 12:15:53 -040011#include "include/core/SkData.h"
Brian Osmanf72dedd2020-01-08 13:19:58 -050012#include "include/core/SkPaint.h"
13#include "include/core/SkSurface.h"
Brian Osmanee426f22020-01-02 11:55:24 -050014#include "include/effects/SkRuntimeEffect.h"
Robert Phillips6d344c32020-07-06 10:56:46 -040015#include "include/gpu/GrDirectContext.h"
Brian Osmand9bde072020-04-15 14:18:13 -040016#include "src/core/SkTLazy.h"
Brian Osman62419612020-07-22 10:19:02 -040017#include "src/gpu/GrColor.h"
Brian Osman088913a2019-12-19 15:44:56 -050018#include "tests/Test.h"
19
Brian Osmanf72dedd2020-01-08 13:19:58 -050020#include <algorithm>
Brian Osman8e2ef022020-09-30 13:26:43 -040021#include <thread>
Brian Osmanf72dedd2020-01-08 13:19:58 -050022
Brian Osman5f6b41e2020-03-09 11:53:24 -040023DEF_TEST(SkRuntimeEffectInvalid, r) {
24 auto test = [r](const char* hdr, const char* body, const char* expected) {
Brian Osman767f4442020-08-13 16:59:48 -040025 SkString src = SkStringPrintf("%s half4 main(float2 p) { %s return half4(0); }",
Brian Osman5f6b41e2020-03-09 11:53:24 -040026 hdr, body);
Brian Osmanf72dedd2020-01-08 13:19:58 -050027 auto[effect, errorText] = SkRuntimeEffect::Make(src);
Brian Osman088913a2019-12-19 15:44:56 -050028 REPORTER_ASSERT(r, !effect);
29 REPORTER_ASSERT(r, errorText.contains(expected),
30 "Expected error message to contain \"%s\". Actual message: \"%s\"",
31 expected, errorText.c_str());
32 };
33
34 // Features that are only allowed in .fp files (key, in uniform, ctype, when, tracked).
35 // Ensure that these fail, and the error messages contain the relevant keyword.
Brian Osman5f6b41e2020-03-09 11:53:24 -040036 test("layout(key) in bool Input;", "", "key");
37 test("in uniform float Input;", "", "in uniform");
38 test("layout(ctype=SkRect) float4 Input;", "", "ctype");
39 test("in bool Flag; layout(when=Flag) uniform float Input;", "", "when");
40 test("layout(tracked) uniform float Input;", "", "tracked");
Brian Osman088913a2019-12-19 15:44:56 -050041
Brian Osman4cb5c5e2020-11-06 11:28:28 -050042 // Runtime SkSL supports a limited set of uniform types. No samplers, bool, or int, for example:
43 test("uniform sampler2D s;", "", "uniform");
Brian Osmana4b91692020-08-10 14:26:16 -040044 test("uniform bool b;", "", "uniform");
45 test("uniform int i;", "", "uniform");
Brian Osman088913a2019-12-19 15:44:56 -050046
Brian Osmana4b91692020-08-10 14:26:16 -040047 // 'in' variables aren't allowed at all:
48 test("in bool b;", "", "'in'");
49 test("in float f;", "", "'in'");
50 test("in float2 v;", "", "'in'");
51 test("in half3x3 m;", "", "'in'");
Brian Osman8783b782020-01-06 11:13:45 -050052
Brian Osmana4b91692020-08-10 14:26:16 -040053 // 'marker' is only permitted on float4x4 uniforms
Brian Osmane64ae862020-07-16 15:29:15 -040054 test("layout(marker=local_to_world) uniform float3x3 localToWorld;", "", "float4x4");
55
Brian Osman767f4442020-08-13 16:59:48 -040056 test("float missing();", "p.x = missing();", "undefined function");
Brian Osman182c92e2020-07-20 15:18:33 -040057
58 // Shouldn't be possible to create an SkRuntimeEffect without "main"
59 test("//", "", "main");
Brian Osman82329002020-07-21 09:39:27 -040060
61 // Various places that shaders (fragmentProcessors) should not be allowed
62 test("",
63 "shader child;",
64 "must be global");
Brian Osman91292e92020-11-04 15:40:50 -050065 test("uniform shader child; half4 helper(shader fp) { return sample(fp); }",
Brian Osman767f4442020-08-13 16:59:48 -040066 "half4 color = helper(child);",
Brian Osman82329002020-07-21 09:39:27 -040067 "parameter");
Brian Osman91292e92020-11-04 15:40:50 -050068 test("uniform shader child; shader get_child() { return child; }",
Brian Osman767f4442020-08-13 16:59:48 -040069 "half4 color = sample(get_child());",
Brian Osman82329002020-07-21 09:39:27 -040070 "return");
Brian Osman91292e92020-11-04 15:40:50 -050071 test("uniform shader child;",
Brian Osman767f4442020-08-13 16:59:48 -040072 "half4 color = sample(shader(child));",
Brian Osman82329002020-07-21 09:39:27 -040073 "construct");
Brian Osman91292e92020-11-04 15:40:50 -050074 test("uniform shader child1; uniform shader child2;",
Brian Osman767f4442020-08-13 16:59:48 -040075 "half4 color = sample(p.x > 10 ? child1 : child2);",
Brian Osman82329002020-07-21 09:39:27 -040076 "expression");
Brian Osmane12939f2020-08-12 11:36:56 -040077
78 // Errors that aren't caught until later in the compilation process (during optimize())
Brian Osman767f4442020-08-13 16:59:48 -040079 test("", "return half4(1);", "unreachable");
Brian Osmane12939f2020-08-12 11:36:56 -040080 test("half badFunc() { }", "", "without returning");
Brian Osman088913a2019-12-19 15:44:56 -050081}
Brian Osmanf72dedd2020-01-08 13:19:58 -050082
Brian Osman92aac1e2020-08-05 16:48:58 -040083DEF_TEST(SkRuntimeEffectInvalidColorFilters, r) {
84 auto test = [r](const char* sksl) {
85 auto [effect, errorText] = SkRuntimeEffect::Make(SkString(sksl));
86 REPORTER_ASSERT(r, effect);
Brian Osman269b21c2020-08-06 12:15:53 -040087
Brian Osmana4b91692020-08-10 14:26:16 -040088 sk_sp<SkData> uniforms = SkData::MakeUninitialized(effect->uniformSize());
Brian Osman269b21c2020-08-06 12:15:53 -040089
Brian Osmana4b91692020-08-10 14:26:16 -040090 REPORTER_ASSERT(r, effect->makeShader(uniforms, nullptr, 0, nullptr, false));
91 REPORTER_ASSERT(r, !effect->makeColorFilter(uniforms));
Brian Osman92aac1e2020-08-05 16:48:58 -040092 };
93
94 // Runtime effects that use sample coords or sk_FragCoord are valid shaders,
95 // but not valid color filters
Brian Osman767f4442020-08-13 16:59:48 -040096 test("half4 main(float2 p) { return half2(p).xy01; }");
97 test("half4 main(float2 p) { return half2(sk_FragCoord.xy).xy01; }");
Brian Osman269b21c2020-08-06 12:15:53 -040098
99 // We also can't use layout(marker), which would give the runtime color filter CTM information
100 test("layout(marker=ctm) uniform float4x4 ctm;"
Brian Osman767f4442020-08-13 16:59:48 -0400101 "half4 main(float2 p) { return half4(half(ctm[0][0]), 0, 0, 1); }");
Brian Osman92aac1e2020-08-05 16:48:58 -0400102}
103
Brian Osmanf72dedd2020-01-08 13:19:58 -0500104class TestEffect {
105public:
Brian Osman62419612020-07-22 10:19:02 -0400106 TestEffect(skiatest::Reporter* r, sk_sp<SkSurface> surface)
107 : fReporter(r), fSurface(std::move(surface)) {}
108
Brian Osman33316412020-11-06 10:42:51 -0500109 void build(const char* src) {
110 auto[effect, errorText] = SkRuntimeEffect::Make(SkString(src));
Brian Osmanf72dedd2020-01-08 13:19:58 -0500111 if (!effect) {
Brian Osman62419612020-07-22 10:19:02 -0400112 REPORT_FAILURE(fReporter, "effect",
Brian Osmanf72dedd2020-01-08 13:19:58 -0500113 SkStringPrintf("Effect didn't compile: %s", errorText.c_str()));
114 return;
115 }
Brian Osmand9bde072020-04-15 14:18:13 -0400116 fBuilder.init(std::move(effect));
Brian Osmanf72dedd2020-01-08 13:19:58 -0500117 }
118
Brian Osmana4b91692020-08-10 14:26:16 -0400119 SkRuntimeShaderBuilder::BuilderUniform uniform(const char* name) {
120 return fBuilder->uniform(name);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500121 }
Brian Osman62419612020-07-22 10:19:02 -0400122 SkRuntimeShaderBuilder::BuilderChild child(const char* name) {
123 return fBuilder->child(name);
124 }
Brian Osmanf72dedd2020-01-08 13:19:58 -0500125
Brian Osman62419612020-07-22 10:19:02 -0400126 using PreTestFn = std::function<void(SkCanvas*, SkPaint*)>;
127
128 void test(GrColor TL, GrColor TR, GrColor BL, GrColor BR,
129 PreTestFn preTestCallback = nullptr) {
Brian Osmand9bde072020-04-15 14:18:13 -0400130 auto shader = fBuilder->makeShader(nullptr, false);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500131 if (!shader) {
Brian Osman62419612020-07-22 10:19:02 -0400132 REPORT_FAILURE(fReporter, "shader", SkString("Effect didn't produce a shader"));
Brian Osmanf72dedd2020-01-08 13:19:58 -0500133 return;
134 }
135
Brian Osman62419612020-07-22 10:19:02 -0400136 SkCanvas* canvas = fSurface->getCanvas();
Brian Osmanf72dedd2020-01-08 13:19:58 -0500137 SkPaint paint;
138 paint.setShader(std::move(shader));
139 paint.setBlendMode(SkBlendMode::kSrc);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500140
Brian Osman62419612020-07-22 10:19:02 -0400141 canvas->save();
142 if (preTestCallback) {
143 preTestCallback(canvas, &paint);
144 }
145 canvas->drawPaint(paint);
146 canvas->restore();
147
148 GrColor actual[4];
149 SkImageInfo info = fSurface->imageInfo();
150 if (!fSurface->readPixels(info, actual, info.minRowBytes(), 0, 0)) {
151 REPORT_FAILURE(fReporter, "readPixels", SkString("readPixels failed"));
Brian Osmanf72dedd2020-01-08 13:19:58 -0500152 return;
153 }
154
Brian Osman62419612020-07-22 10:19:02 -0400155 GrColor expected[4] = {TL, TR, BL, BR};
John Stilesc1c3c6d2020-08-15 23:22:53 -0400156 if (0 != memcmp(actual, expected, sizeof(actual))) {
Brian Osman62419612020-07-22 10:19:02 -0400157 REPORT_FAILURE(fReporter, "Runtime effect didn't match expectations",
Brian Osmanf72dedd2020-01-08 13:19:58 -0500158 SkStringPrintf("\n"
159 "Expected: [ %08x %08x %08x %08x ]\n"
160 "Got : [ %08x %08x %08x %08x ]\n"
161 "SkSL:\n%s\n",
162 TL, TR, BL, BR, actual[0], actual[1], actual[2],
Brian Osmanb6bd0d22020-08-27 10:51:22 -0400163 actual[3], fBuilder->effect()->source().c_str()));
Brian Osmanf72dedd2020-01-08 13:19:58 -0500164 }
165 }
166
Brian Osman62419612020-07-22 10:19:02 -0400167 void test(GrColor expected, PreTestFn preTestCallback = nullptr) {
168 this->test(expected, expected, expected, expected, preTestCallback);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500169 }
170
171private:
Brian Osman62419612020-07-22 10:19:02 -0400172 skiatest::Reporter* fReporter;
173 sk_sp<SkSurface> fSurface;
Brian Osmand9bde072020-04-15 14:18:13 -0400174 SkTLazy<SkRuntimeShaderBuilder> fBuilder;
Brian Osmanf72dedd2020-01-08 13:19:58 -0500175};
176
Brian Osman62419612020-07-22 10:19:02 -0400177// Produces a 2x2 bitmap shader, with opaque colors:
178// [ Red, Green ]
179// [ Blue, White ]
180static sk_sp<SkShader> make_RGBW_shader() {
181 SkBitmap bmp;
182 bmp.allocPixels(SkImageInfo::Make(2, 2, kRGBA_8888_SkColorType, kPremul_SkAlphaType));
183 SkIRect topLeft = SkIRect::MakeWH(1, 1);
184 bmp.pixmap().erase(SK_ColorRED, topLeft);
185 bmp.pixmap().erase(SK_ColorGREEN, topLeft.makeOffset(1, 0));
186 bmp.pixmap().erase(SK_ColorBLUE, topLeft.makeOffset(0, 1));
187 bmp.pixmap().erase(SK_ColorWHITE, topLeft.makeOffset(1, 1));
188 return bmp.makeShader();
189}
190
Robert Phillipse94b4e12020-07-23 13:54:35 -0400191static void test_RuntimeEffect_Shaders(skiatest::Reporter* r, GrRecordingContext* rContext) {
Brian Osmanf72dedd2020-01-08 13:19:58 -0500192 SkImageInfo info = SkImageInfo::Make(2, 2, kRGBA_8888_SkColorType, kPremul_SkAlphaType);
Robert Phillipse94b4e12020-07-23 13:54:35 -0400193 sk_sp<SkSurface> surface = rContext
194 ? SkSurface::MakeRenderTarget(rContext, SkBudgeted::kNo, info)
195 : SkSurface::MakeRaster(info);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500196 REPORTER_ASSERT(r, surface);
Brian Osman62419612020-07-22 10:19:02 -0400197 TestEffect effect(r, surface);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500198
Brian Osman504032e2020-01-10 10:05:24 -0500199 using float4 = std::array<float, 4>;
200
Brian Osman62419612020-07-22 10:19:02 -0400201 // Local coords
Brian Osman33316412020-11-06 10:42:51 -0500202 effect.build("half4 main(float2 p) { return half4(half2(p - 0.5), 0, 1); }");
Brian Osman62419612020-07-22 10:19:02 -0400203 effect.test(0xFF000000, 0xFF0000FF, 0xFF00FF00, 0xFF00FFFF);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500204
Brian Osman62419612020-07-22 10:19:02 -0400205 // Use of a simple uniform. (Draw twice with two values to ensure it's updated).
Brian Osman33316412020-11-06 10:42:51 -0500206 effect.build("uniform float4 gColor; half4 main() { return half4(gColor); }");
Brian Osmana4b91692020-08-10 14:26:16 -0400207 effect.uniform("gColor") = float4{ 0.0f, 0.25f, 0.75f, 1.0f };
Brian Osman62419612020-07-22 10:19:02 -0400208 effect.test(0xFFBF4000);
Brian Osmana4b91692020-08-10 14:26:16 -0400209 effect.uniform("gColor") = float4{ 1.0f, 0.0f, 0.0f, 0.498f };
Brian Osman62419612020-07-22 10:19:02 -0400210 effect.test(0x7F00007F); // Tests that we clamp to valid premul
Michael Ludwig5e6b3cd2020-05-27 17:02:37 -0400211
Brian Osman62419612020-07-22 10:19:02 -0400212 // Test sk_FragCoord (device coords). Rotate the canvas to be sure we're seeing device coords.
213 // Since the surface is 2x2, we should see (0,0), (1,0), (0,1), (1,1). Multiply by 0.498 to
214 // make sure we're not saturating unexpectedly.
Brian Osman33316412020-11-06 10:42:51 -0500215 effect.build("half4 main() { return half4(0.498 * (half2(sk_FragCoord.xy) - 0.5), 0, 1); }");
Brian Osman62419612020-07-22 10:19:02 -0400216 effect.test(0xFF000000, 0xFF00007F, 0xFF007F00, 0xFF007F7F,
217 [](SkCanvas* canvas, SkPaint*) { canvas->rotate(45.0f); });
Michael Ludwig22534f22020-05-27 17:25:33 -0400218
Brian Osman0acb5b52020-09-02 13:45:47 -0400219 // Runtime effects should use relaxed precision rules by default
Brian Osman33316412020-11-06 10:42:51 -0500220 effect.build("half4 main(float2 p) { return float4(p - 0.5, 0, 1); }");
Brian Osman0acb5b52020-09-02 13:45:47 -0400221 effect.test(0xFF000000, 0xFF0000FF, 0xFF00FF00, 0xFF00FFFF);
222
Brian Osmanf1319c32020-10-13 09:34:23 -0400223 // ... and support GLSL type names
Brian Osman33316412020-11-06 10:42:51 -0500224 effect.build("half4 main(float2 p) { return vec4(p - 0.5, 0, 1); }");
225 effect.test(0xFF000000, 0xFF0000FF, 0xFF00FF00, 0xFF00FFFF);
226
227 // ... and support *returning* float4 (aka vec4), not just half4
228 effect.build("float4 main(float2 p) { return float4(p - 0.5, 0, 1); }");
229 effect.test(0xFF000000, 0xFF0000FF, 0xFF00FF00, 0xFF00FFFF);
230 effect.build("vec4 main(float2 p) { return float4(p - 0.5, 0, 1); }");
Brian Osmanf1319c32020-10-13 09:34:23 -0400231 effect.test(0xFF000000, 0xFF0000FF, 0xFF00FF00, 0xFF00FFFF);
232
Brian Osmanb5f0f522020-07-23 13:28:14 -0400233 //
234 // Sampling children
235 //
236
Brian Osman62419612020-07-22 10:19:02 -0400237 // Sampling a null child should return the paint color
Brian Osman33316412020-11-06 10:42:51 -0500238 effect.build("uniform shader child;"
239 "half4 main() { return sample(child); }");
Brian Osman62419612020-07-22 10:19:02 -0400240 effect.child("child") = nullptr;
241 effect.test(0xFF00FFFF,
242 [](SkCanvas*, SkPaint* paint) { paint->setColor4f({1.0f, 1.0f, 0.0f, 1.0f}); });
243
244 sk_sp<SkShader> rgbwShader = make_RGBW_shader();
245
246 // Sampling a simple child at our coordinates (implicitly)
Brian Osman33316412020-11-06 10:42:51 -0500247 effect.build("uniform shader child;"
248 "half4 main() { return sample(child); }");
Brian Osman62419612020-07-22 10:19:02 -0400249 effect.child("child") = rgbwShader;
250 effect.test(0xFF0000FF, 0xFF00FF00, 0xFFFF0000, 0xFFFFFFFF);
251
252 // Sampling with explicit coordinates (reflecting about the diagonal)
Brian Osman33316412020-11-06 10:42:51 -0500253 effect.build("uniform shader child;"
254 "half4 main(float2 p) { return sample(child, p.yx); }");
Brian Osman62419612020-07-22 10:19:02 -0400255 effect.child("child") = rgbwShader;
256 effect.test(0xFF0000FF, 0xFFFF0000, 0xFF00FF00, 0xFFFFFFFF);
257
258 // Sampling with a matrix (again, reflecting about the diagonal)
Brian Osman33316412020-11-06 10:42:51 -0500259 effect.build("uniform shader child;"
260 "half4 main() { return sample(child, float3x3(0, 1, 0, 1, 0, 0, 0, 0, 1)); }");
Brian Osman62419612020-07-22 10:19:02 -0400261 effect.child("child") = rgbwShader;
262 effect.test(0xFF0000FF, 0xFFFF0000, 0xFF00FF00, 0xFFFFFFFF);
Brian Osmanb5f0f522020-07-23 13:28:14 -0400263
Brian Osman91292e92020-11-04 15:40:50 -0500264 // Legacy behavior - shaders can be declared 'in' rather than 'uniform'
Brian Osman33316412020-11-06 10:42:51 -0500265 effect.build("in shader child;"
266 "half4 main() { return sample(child); }");
Brian Osman91292e92020-11-04 15:40:50 -0500267 effect.child("child") = rgbwShader;
268 effect.test(0xFF0000FF, 0xFF00FF00, 0xFFFF0000, 0xFFFFFFFF);
269
Brian Osmanb5f0f522020-07-23 13:28:14 -0400270 //
271 // Helper functions
272 //
273
274 // Test case for inlining in the pipeline-stage and fragment-shader passes (skbug.com/10526):
Brian Osman33316412020-11-06 10:42:51 -0500275 effect.build("float2 helper(float2 x) { return x + 1; }"
276 "half4 main(float2 p) { float2 v = helper(p); return half4(half2(v), 0, 1); }");
Brian Osmanb5f0f522020-07-23 13:28:14 -0400277 effect.test(0xFF00FFFF);
Brian Osmanf72dedd2020-01-08 13:19:58 -0500278}
279
280DEF_TEST(SkRuntimeEffectSimple, r) {
281 test_RuntimeEffect_Shaders(r, nullptr);
282}
283
284DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SkRuntimeEffectSimple_GPU, r, ctxInfo) {
Robert Phillips6d344c32020-07-06 10:56:46 -0400285 test_RuntimeEffect_Shaders(r, ctxInfo.directContext());
Brian Osmanf72dedd2020-01-08 13:19:58 -0500286}
Brian Osmanb6bd0d22020-08-27 10:51:22 -0400287
288DEF_TEST(SkRuntimeShaderBuilderReuse, r) {
289 const char* kSource = R"(
290 uniform half x;
291 half4 main() { return half4(x); }
292 )";
293
294 sk_sp<SkRuntimeEffect> effect = std::get<0>(SkRuntimeEffect::Make(SkString(kSource)));
295 REPORTER_ASSERT(r, effect);
296
297 // Test passes if this sequence doesn't assert. skbug.com/10667
298 SkRuntimeShaderBuilder b(std::move(effect));
299 b.uniform("x") = 0.0f;
300 auto shader_0 = b.makeShader(nullptr, false);
301
302 b.uniform("x") = 1.0f;
303 auto shader_1 = b.makeShader(nullptr, true);
304}
Brian Osman8e2ef022020-09-30 13:26:43 -0400305
306DEF_TEST(SkRuntimeEffectThreaded, r) {
307 // SkRuntimeEffect uses a single compiler instance, but it's mutex locked.
308 // This tests that we can safely use it from more than one thread, and also
309 // that programs don't refer to shared structures owned by the compiler.
310 // skbug.com/10589
311 static constexpr char kSource[] = "half4 main() { return sk_FragCoord.xyxy; }";
312
313 std::thread threads[16];
314 for (auto& thread : threads) {
315 thread = std::thread([r]() {
316 auto [effect, error] = SkRuntimeEffect::Make(SkString(kSource));
317 REPORTER_ASSERT(r, effect);
318 });
319 }
320
321 for (auto& thread : threads) {
322 thread.join();
323 }
324}