andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 1 | # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 2 | # |
| 3 | # Use of this source code is governed by a BSD-style license |
| 4 | # that can be found in the LICENSE file in the root of the source |
| 5 | # tree. An additional intellectual property rights grant can be found |
| 6 | # in the file PATENTS. All contributing project authors may |
| 7 | # be found in the AUTHORS file in the root of the source tree. |
niklase@google.com | da159d6 | 2011-05-30 11:51:34 +0000 | [diff] [blame] | 8 | |
kjellander | 7439f97 | 2016-12-05 22:47:46 -0800 | [diff] [blame] | 9 | import json |
kjellander@webrtc.org | aefe61a | 2014-12-08 13:00:30 +0000 | [diff] [blame] | 10 | import os |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 11 | import re |
ehmaldonado | 4fb9746 | 2017-01-30 05:27:22 -0800 | [diff] [blame] | 12 | import subprocess |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 13 | import sys |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 14 | |
| 15 | |
kjellander@webrtc.org | 0fcaf99 | 2015-11-26 15:24:52 +0100 | [diff] [blame] | 16 | # Directories that will be scanned by cpplint by the presubmit script. |
| 17 | CPPLINT_DIRS = [ |
oprypin | 803dc29 | 2017-02-01 01:55:59 -0800 | [diff] [blame] | 18 | 'webrtc/api', |
Fredrik Solenberg | ea07373 | 2015-12-01 11:26:34 +0100 | [diff] [blame] | 19 | 'webrtc/audio', |
| 20 | 'webrtc/call', |
jbauch | 0f2e939 | 2015-12-10 03:11:42 -0800 | [diff] [blame] | 21 | 'webrtc/common_video', |
jbauch | 70625e5 | 2015-12-09 14:18:14 -0800 | [diff] [blame] | 22 | 'webrtc/examples', |
aleloi | df9e4d9 | 2016-08-08 10:26:09 -0700 | [diff] [blame] | 23 | 'webrtc/modules/audio_mixer', |
jbauch | f91e6d0 | 2016-01-24 23:05:21 -0800 | [diff] [blame] | 24 | 'webrtc/modules/bitrate_controller', |
Stefan Holmer | 80e1207 | 2016-02-23 13:30:42 +0100 | [diff] [blame] | 25 | 'webrtc/modules/congestion_controller', |
jbauch | d2a2296 | 2016-02-08 23:18:25 -0800 | [diff] [blame] | 26 | 'webrtc/modules/pacing', |
terelius | 8f09f17 | 2015-12-15 00:51:54 -0800 | [diff] [blame] | 27 | 'webrtc/modules/remote_bitrate_estimator', |
danilchap | 377b5e6 | 2015-12-15 04:33:44 -0800 | [diff] [blame] | 28 | 'webrtc/modules/rtp_rtcp', |
philipel | 5908c71 | 2015-12-21 08:23:20 -0800 | [diff] [blame] | 29 | 'webrtc/modules/video_coding', |
mflodman | 88eeac4 | 2015-12-08 09:21:28 +0100 | [diff] [blame] | 30 | 'webrtc/modules/video_processing', |
jbauch | 0f2e939 | 2015-12-10 03:11:42 -0800 | [diff] [blame] | 31 | 'webrtc/tools', |
mflodman | d1590b2 | 2015-12-09 07:07:59 -0800 | [diff] [blame] | 32 | 'webrtc/video', |
kjellander@webrtc.org | 0fcaf99 | 2015-11-26 15:24:52 +0100 | [diff] [blame] | 33 | ] |
| 34 | |
jbauch | c4e3ead | 2016-02-19 00:25:55 -0800 | [diff] [blame] | 35 | # These filters will always be removed, even if the caller specifies a filter |
| 36 | # set, as they are problematic or broken in some way. |
| 37 | # |
| 38 | # Justifications for each filter: |
| 39 | # - build/c++11 : Rvalue ref checks are unreliable (false positives), |
| 40 | # include file and feature blacklists are |
| 41 | # google3-specific. |
kjellander | e5a87a5 | 2016-04-27 02:32:12 -0700 | [diff] [blame] | 42 | # - whitespace/operators: Same as above (doesn't seem sufficient to eliminate |
| 43 | # all move-related errors). |
jbauch | c4e3ead | 2016-02-19 00:25:55 -0800 | [diff] [blame] | 44 | BLACKLIST_LINT_FILTERS = [ |
| 45 | '-build/c++11', |
kjellander | e5a87a5 | 2016-04-27 02:32:12 -0700 | [diff] [blame] | 46 | '-whitespace/operators', |
jbauch | c4e3ead | 2016-02-19 00:25:55 -0800 | [diff] [blame] | 47 | ] |
| 48 | |
kjellander | fd59523 | 2015-12-04 02:44:09 -0800 | [diff] [blame] | 49 | # List of directories of "supported" native APIs. That means changes to headers |
| 50 | # will be done in a compatible way following this scheme: |
| 51 | # 1. Non-breaking changes are made. |
| 52 | # 2. The old APIs as marked as deprecated (with comments). |
| 53 | # 3. Deprecation is announced to discuss-webrtc@googlegroups.com and |
| 54 | # webrtc-users@google.com (internal list). |
| 55 | # 4. (later) The deprecated APIs are removed. |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 56 | NATIVE_API_DIRS = ( |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 57 | 'webrtc', |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 58 | 'webrtc/api', |
| 59 | 'webrtc/media', |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 60 | 'webrtc/modules/audio_device/include', |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 61 | 'webrtc/pc', |
| 62 | ) |
| 63 | # These directories should not be used but are maintained only to avoid breaking |
| 64 | # some legacy downstream code. |
| 65 | LEGACY_API_DIRS = ( |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 66 | 'webrtc/base', |
| 67 | 'webrtc/common_audio/include', |
| 68 | 'webrtc/modules/audio_coding/include', |
| 69 | 'webrtc/modules/audio_conference_mixer/include', |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 70 | 'webrtc/modules/audio_processing/include', |
| 71 | 'webrtc/modules/bitrate_controller/include', |
Stefan Holmer | 80e1207 | 2016-02-23 13:30:42 +0100 | [diff] [blame] | 72 | 'webrtc/modules/congestion_controller/include', |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 73 | 'webrtc/modules/include', |
| 74 | 'webrtc/modules/remote_bitrate_estimator/include', |
| 75 | 'webrtc/modules/rtp_rtcp/include', |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 76 | 'webrtc/modules/rtp_rtcp/source', |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 77 | 'webrtc/modules/utility/include', |
| 78 | 'webrtc/modules/video_coding/codecs/h264/include', |
| 79 | 'webrtc/modules/video_coding/codecs/i420/include', |
| 80 | 'webrtc/modules/video_coding/codecs/vp8/include', |
| 81 | 'webrtc/modules/video_coding/codecs/vp9/include', |
| 82 | 'webrtc/modules/video_coding/include', |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 83 | 'webrtc/system_wrappers/include', |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 84 | 'webrtc/voice_engine/include', |
| 85 | ) |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 86 | API_DIRS = NATIVE_API_DIRS[:] + LEGACY_API_DIRS[:] |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 87 | |
| 88 | |
ehmaldonado | 4fb9746 | 2017-01-30 05:27:22 -0800 | [diff] [blame] | 89 | def _RunCommand(command, cwd): |
| 90 | """Runs a command and returns the output from that command.""" |
| 91 | p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, |
| 92 | cwd=cwd) |
| 93 | stdout = p.stdout.read() |
| 94 | stderr = p.stderr.read() |
| 95 | p.wait() |
| 96 | p.stdout.close() |
| 97 | p.stderr.close() |
| 98 | return p.returncode, stdout, stderr |
| 99 | |
| 100 | |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 101 | def _VerifyNativeApiHeadersListIsValid(input_api, output_api): |
| 102 | """Ensures the list of native API header directories is up to date.""" |
| 103 | non_existing_paths = [] |
| 104 | native_api_full_paths = [ |
| 105 | input_api.os_path.join(input_api.PresubmitLocalPath(), |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 106 | *path.split('/')) for path in API_DIRS] |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 107 | for path in native_api_full_paths: |
| 108 | if not os.path.isdir(path): |
| 109 | non_existing_paths.append(path) |
| 110 | if non_existing_paths: |
| 111 | return [output_api.PresubmitError( |
| 112 | 'Directories to native API headers have changed which has made the ' |
| 113 | 'list in PRESUBMIT.py outdated.\nPlease update it to the current ' |
| 114 | 'location of our native APIs.', |
| 115 | non_existing_paths)] |
| 116 | return [] |
| 117 | |
kwiberg | eb13302 | 2016-04-07 07:41:48 -0700 | [diff] [blame] | 118 | api_change_msg = """ |
| 119 | You seem to be changing native API header files. Please make sure that you: |
oprypin | 375b9ac | 2017-02-13 04:13:23 -0800 | [diff] [blame^] | 120 | 1. Make compatible changes that don't break existing clients. Usually |
| 121 | this is done by keeping the existing method signatures unchanged. |
| 122 | 2. Mark the old stuff as deprecated (see RTC_DEPRECATED macro). |
kwiberg | eb13302 | 2016-04-07 07:41:48 -0700 | [diff] [blame] | 123 | 3. Create a timeline and plan for when the deprecated stuff will be |
| 124 | removed. (The amount of time we give users to change their code |
| 125 | should be informed by how much work it is for them. If they just |
| 126 | need to replace one name with another or something equally |
| 127 | simple, 1-2 weeks might be good; if they need to do serious work, |
| 128 | up to 3 months may be called for.) |
| 129 | 4. Update/inform existing downstream code owners to stop using the |
| 130 | deprecated stuff. (Send announcements to |
| 131 | discuss-webrtc@googlegroups.com and webrtc-users@google.com.) |
| 132 | 5. Remove the deprecated stuff, once the agreed-upon amount of time |
| 133 | has passed. |
| 134 | Related files: |
| 135 | """ |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 136 | |
| 137 | def _CheckNativeApiHeaderChanges(input_api, output_api): |
| 138 | """Checks to remind proper changing of native APIs.""" |
| 139 | files = [] |
| 140 | for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): |
| 141 | if f.LocalPath().endswith('.h'): |
kjellander | dd70547 | 2016-06-09 11:17:27 -0700 | [diff] [blame] | 142 | for path in API_DIRS: |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 143 | if os.path.dirname(f.LocalPath()) == path: |
| 144 | files.append(f) |
| 145 | |
| 146 | if files: |
kwiberg | eb13302 | 2016-04-07 07:41:48 -0700 | [diff] [blame] | 147 | return [output_api.PresubmitNotifyResult(api_change_msg, files)] |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 148 | return [] |
| 149 | |
kjellander@webrtc.org | 0fcaf99 | 2015-11-26 15:24:52 +0100 | [diff] [blame] | 150 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 151 | def _CheckNoIOStreamInHeaders(input_api, output_api): |
| 152 | """Checks to make sure no .h files include <iostream>.""" |
| 153 | files = [] |
| 154 | pattern = input_api.re.compile(r'^#include\s*<iostream>', |
| 155 | input_api.re.MULTILINE) |
| 156 | for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): |
| 157 | if not f.LocalPath().endswith('.h'): |
| 158 | continue |
| 159 | contents = input_api.ReadFile(f) |
| 160 | if pattern.search(contents): |
| 161 | files.append(f) |
| 162 | |
| 163 | if len(files): |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 164 | return [output_api.PresubmitError( |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 165 | 'Do not #include <iostream> in header files, since it inserts static ' + |
| 166 | 'initialization into every file including the header. Instead, ' + |
| 167 | '#include <ostream>. See http://crbug.com/94794', |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 168 | files)] |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 169 | return [] |
| 170 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 171 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 172 | def _CheckNoFRIEND_TEST(input_api, output_api): |
| 173 | """Make sure that gtest's FRIEND_TEST() macro is not used, the |
| 174 | FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be |
| 175 | used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes.""" |
| 176 | problems = [] |
| 177 | |
| 178 | file_filter = lambda f: f.LocalPath().endswith(('.cc', '.h')) |
| 179 | for f in input_api.AffectedFiles(file_filter=file_filter): |
| 180 | for line_num, line in f.ChangedContents(): |
| 181 | if 'FRIEND_TEST(' in line: |
| 182 | problems.append(' %s:%d' % (f.LocalPath(), line_num)) |
| 183 | |
| 184 | if not problems: |
| 185 | return [] |
| 186 | return [output_api.PresubmitPromptWarning('WebRTC\'s code should not use ' |
| 187 | 'gtest\'s FRIEND_TEST() macro. Include testsupport/gtest_prod_util.h and ' |
| 188 | 'use FRIEND_TEST_ALL_PREFIXES() instead.\n' + '\n'.join(problems))] |
| 189 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 190 | |
kjellander@webrtc.org | 0fcaf99 | 2015-11-26 15:24:52 +0100 | [diff] [blame] | 191 | def _IsLintWhitelisted(whitelist_dirs, file_path): |
| 192 | """ Checks if a file is whitelisted for lint check.""" |
| 193 | for path in whitelist_dirs: |
| 194 | if os.path.dirname(file_path).startswith(path): |
| 195 | return True |
| 196 | return False |
| 197 | |
| 198 | |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 199 | def _CheckApprovedFilesLintClean(input_api, output_api, |
| 200 | source_file_filter=None): |
| 201 | """Checks that all new or whitelisted .cc and .h files pass cpplint.py. |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 202 | This check is based on _CheckChangeLintsClean in |
| 203 | depot_tools/presubmit_canned_checks.py but has less filters and only checks |
| 204 | added files.""" |
| 205 | result = [] |
| 206 | |
| 207 | # Initialize cpplint. |
| 208 | import cpplint |
| 209 | # Access to a protected member _XX of a client class |
| 210 | # pylint: disable=W0212 |
| 211 | cpplint._cpplint_state.ResetErrorCounts() |
| 212 | |
jbauch | c4e3ead | 2016-02-19 00:25:55 -0800 | [diff] [blame] | 213 | lint_filters = cpplint._Filters() |
| 214 | lint_filters.extend(BLACKLIST_LINT_FILTERS) |
| 215 | cpplint._SetFilters(','.join(lint_filters)) |
| 216 | |
kjellander@webrtc.org | 0fcaf99 | 2015-11-26 15:24:52 +0100 | [diff] [blame] | 217 | # Create a platform independent whitelist for the CPPLINT_DIRS. |
| 218 | whitelist_dirs = [input_api.os_path.join(*path.split('/')) |
| 219 | for path in CPPLINT_DIRS] |
| 220 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 221 | # Use the strictest verbosity level for cpplint.py (level 1) which is the |
| 222 | # default when running cpplint.py from command line. |
| 223 | # To make it possible to work with not-yet-converted code, we're only applying |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 224 | # it to new (or moved/renamed) files and files listed in LINT_FOLDERS. |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 225 | verbosity_level = 1 |
| 226 | files = [] |
| 227 | for f in input_api.AffectedSourceFiles(source_file_filter): |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 228 | # Note that moved/renamed files also count as added. |
kjellander@webrtc.org | 0fcaf99 | 2015-11-26 15:24:52 +0100 | [diff] [blame] | 229 | if f.Action() == 'A' or _IsLintWhitelisted(whitelist_dirs, f.LocalPath()): |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 230 | files.append(f.AbsoluteLocalPath()) |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 231 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 232 | for file_name in files: |
| 233 | cpplint.ProcessFile(file_name, verbosity_level) |
| 234 | |
| 235 | if cpplint._cpplint_state.error_count > 0: |
| 236 | if input_api.is_committing: |
| 237 | # TODO(kjellander): Change back to PresubmitError below when we're |
| 238 | # confident with the lint settings. |
| 239 | res_type = output_api.PresubmitPromptWarning |
| 240 | else: |
| 241 | res_type = output_api.PresubmitPromptWarning |
| 242 | result = [res_type('Changelist failed cpplint.py check.')] |
| 243 | |
| 244 | return result |
| 245 | |
Henrik Kjellander | b4af3d6 | 2016-11-16 20:11:29 +0100 | [diff] [blame] | 246 | def _CheckNoSourcesAbove(input_api, gn_files, output_api): |
ehmaldonado | 5b1ba08 | 2016-09-02 05:51:08 -0700 | [diff] [blame] | 247 | # Disallow referencing source files with paths above the GN file location. |
| 248 | source_pattern = input_api.re.compile(r' +sources \+?= \[(.*?)\]', |
| 249 | re.MULTILINE | re.DOTALL) |
| 250 | file_pattern = input_api.re.compile(r'"((\.\./.*?)|(//.*?))"') |
| 251 | violating_gn_files = set() |
| 252 | violating_source_entries = [] |
| 253 | for gn_file in gn_files: |
| 254 | contents = input_api.ReadFile(gn_file) |
| 255 | for source_block_match in source_pattern.finditer(contents): |
| 256 | # Find all source list entries starting with ../ in the source block |
| 257 | # (exclude overrides entries). |
| 258 | for file_list_match in file_pattern.finditer(source_block_match.group(1)): |
| 259 | source_file = file_list_match.group(1) |
| 260 | if 'overrides/' not in source_file: |
| 261 | violating_source_entries.append(source_file) |
| 262 | violating_gn_files.add(gn_file) |
| 263 | if violating_gn_files: |
| 264 | return [output_api.PresubmitError( |
| 265 | 'Referencing source files above the directory of the GN file is not ' |
Henrik Kjellander | b4af3d6 | 2016-11-16 20:11:29 +0100 | [diff] [blame] | 266 | 'allowed. Please introduce new GN targets in the proper location ' |
| 267 | 'instead.\n' |
ehmaldonado | 5b1ba08 | 2016-09-02 05:51:08 -0700 | [diff] [blame] | 268 | 'Invalid source entries:\n' |
| 269 | '%s\n' |
| 270 | 'Violating GN files:' % '\n'.join(violating_source_entries), |
| 271 | items=violating_gn_files)] |
| 272 | return [] |
| 273 | |
kjellander | 7439f97 | 2016-12-05 22:47:46 -0800 | [diff] [blame] | 274 | def _CheckNoMixingCAndCCSources(input_api, gn_files, output_api): |
| 275 | # Disallow mixing .c and .cc source files in the same target. |
| 276 | source_pattern = input_api.re.compile(r' +sources \+?= \[(.*?)\]', |
| 277 | re.MULTILINE | re.DOTALL) |
| 278 | file_pattern = input_api.re.compile(r'"(.*)"') |
| 279 | violating_gn_files = dict() |
| 280 | for gn_file in gn_files: |
| 281 | contents = input_api.ReadFile(gn_file) |
| 282 | for source_block_match in source_pattern.finditer(contents): |
| 283 | c_files = [] |
| 284 | cc_files = [] |
| 285 | for file_list_match in file_pattern.finditer(source_block_match.group(1)): |
| 286 | source_file = file_list_match.group(1) |
| 287 | if source_file.endswith('.c'): |
| 288 | c_files.append(source_file) |
| 289 | if source_file.endswith('.cc'): |
| 290 | cc_files.append(source_file) |
| 291 | if c_files and cc_files: |
| 292 | violating_gn_files[gn_file.LocalPath()] = sorted(c_files + cc_files) |
| 293 | if violating_gn_files: |
| 294 | return [output_api.PresubmitError( |
| 295 | 'GN targets cannot mix .cc and .c source files. Please create a ' |
| 296 | 'separate target for each collection of sources.\n' |
| 297 | 'Mixed sources: \n' |
| 298 | '%s\n' |
| 299 | 'Violating GN files:' % json.dumps(violating_gn_files, indent=2), |
| 300 | items=violating_gn_files.keys())] |
| 301 | return [] |
| 302 | |
ehmaldonado | 4fb9746 | 2017-01-30 05:27:22 -0800 | [diff] [blame] | 303 | def _CheckNoPackageBoundaryViolations(input_api, gn_files, output_api): |
| 304 | cwd = input_api.PresubmitLocalPath() |
| 305 | script_path = os.path.join('tools-webrtc', 'check_package_boundaries.py') |
| 306 | webrtc_path = os.path.join('webrtc') |
| 307 | command = [sys.executable, script_path, webrtc_path] |
| 308 | command += [gn_file.LocalPath() for gn_file in gn_files] |
| 309 | returncode, _, stderr = _RunCommand(command, cwd) |
| 310 | if returncode: |
| 311 | return [output_api.PresubmitError( |
| 312 | 'There are package boundary violations in the following GN files:\n\n' |
| 313 | '%s' % stderr)] |
| 314 | return [] |
| 315 | |
ehmaldonado | 5b1ba08 | 2016-09-02 05:51:08 -0700 | [diff] [blame] | 316 | def _CheckGnChanges(input_api, output_api): |
| 317 | source_file_filter = lambda x: input_api.FilterSourceFile( |
| 318 | x, white_list=(r'.+\.(gn|gni)$',)) |
| 319 | |
| 320 | gn_files = [] |
| 321 | for f in input_api.AffectedSourceFiles(source_file_filter): |
| 322 | if f.LocalPath().startswith('webrtc'): |
| 323 | gn_files.append(f) |
| 324 | |
| 325 | result = [] |
| 326 | if gn_files: |
Henrik Kjellander | b4af3d6 | 2016-11-16 20:11:29 +0100 | [diff] [blame] | 327 | result.extend(_CheckNoSourcesAbove(input_api, gn_files, output_api)) |
kjellander | 7439f97 | 2016-12-05 22:47:46 -0800 | [diff] [blame] | 328 | result.extend(_CheckNoMixingCAndCCSources(input_api, gn_files, output_api)) |
ehmaldonado | 4fb9746 | 2017-01-30 05:27:22 -0800 | [diff] [blame] | 329 | result.extend(_CheckNoPackageBoundaryViolations( |
| 330 | input_api, gn_files, output_api)) |
ehmaldonado | 5b1ba08 | 2016-09-02 05:51:08 -0700 | [diff] [blame] | 331 | return result |
| 332 | |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 333 | def _CheckUnwantedDependencies(input_api, output_api): |
| 334 | """Runs checkdeps on #include statements added in this |
| 335 | change. Breaking - rules is an error, breaking ! rules is a |
| 336 | warning. |
| 337 | """ |
| 338 | # Copied from Chromium's src/PRESUBMIT.py. |
| 339 | |
| 340 | # We need to wait until we have an input_api object and use this |
| 341 | # roundabout construct to import checkdeps because this file is |
| 342 | # eval-ed and thus doesn't have __file__. |
| 343 | original_sys_path = sys.path |
| 344 | try: |
kjellander@webrtc.org | aefe61a | 2014-12-08 13:00:30 +0000 | [diff] [blame] | 345 | checkdeps_path = input_api.os_path.join(input_api.PresubmitLocalPath(), |
| 346 | 'buildtools', 'checkdeps') |
| 347 | if not os.path.exists(checkdeps_path): |
| 348 | return [output_api.PresubmitError( |
| 349 | 'Cannot find checkdeps at %s\nHave you run "gclient sync" to ' |
| 350 | 'download Chromium and setup the symlinks?' % checkdeps_path)] |
| 351 | sys.path.append(checkdeps_path) |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 352 | import checkdeps |
| 353 | from cpp_checker import CppChecker |
| 354 | from rules import Rule |
| 355 | finally: |
| 356 | # Restore sys.path to what it was before. |
| 357 | sys.path = original_sys_path |
| 358 | |
| 359 | added_includes = [] |
| 360 | for f in input_api.AffectedFiles(): |
| 361 | if not CppChecker.IsCppFile(f.LocalPath()): |
| 362 | continue |
| 363 | |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 364 | changed_lines = [line for _, line in f.ChangedContents()] |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 365 | added_includes.append([f.LocalPath(), changed_lines]) |
| 366 | |
| 367 | deps_checker = checkdeps.DepsChecker(input_api.PresubmitLocalPath()) |
| 368 | |
| 369 | error_descriptions = [] |
| 370 | warning_descriptions = [] |
| 371 | for path, rule_type, rule_description in deps_checker.CheckAddedCppIncludes( |
| 372 | added_includes): |
| 373 | description_with_path = '%s\n %s' % (path, rule_description) |
| 374 | if rule_type == Rule.DISALLOW: |
| 375 | error_descriptions.append(description_with_path) |
| 376 | else: |
| 377 | warning_descriptions.append(description_with_path) |
| 378 | |
| 379 | results = [] |
| 380 | if error_descriptions: |
| 381 | results.append(output_api.PresubmitError( |
| 382 | 'You added one or more #includes that violate checkdeps rules.', |
| 383 | error_descriptions)) |
| 384 | if warning_descriptions: |
| 385 | results.append(output_api.PresubmitPromptOrNotify( |
| 386 | 'You added one or more #includes of files that are temporarily\n' |
| 387 | 'allowed but being removed. Can you avoid introducing the\n' |
| 388 | '#include? See relevant DEPS file(s) for details and contacts.', |
| 389 | warning_descriptions)) |
| 390 | return results |
| 391 | |
kjellander | d1e26a9 | 2016-09-19 08:11:16 -0700 | [diff] [blame] | 392 | def _CheckChangeHasBugField(input_api, output_api): |
| 393 | """Requires that the changelist have a BUG= field. |
| 394 | |
| 395 | This check is stricter than the one in depot_tools/presubmit_canned_checks.py |
| 396 | since it fails the presubmit if the BUG= field is missing or doesn't contain |
| 397 | a bug reference. |
| 398 | """ |
| 399 | if input_api.change.BUG: |
| 400 | return [] |
| 401 | else: |
| 402 | return [output_api.PresubmitError( |
| 403 | 'The BUG=[bug number] field is mandatory. Please create a bug and ' |
| 404 | 'reference it using either of:\n' |
| 405 | ' * https://bugs.webrtc.org - reference it using BUG=webrtc:XXXX\n' |
| 406 | ' * https://crbug.com - reference it using BUG=chromium:XXXXXX')] |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 407 | |
kjellander | 569cf94 | 2016-02-11 05:02:59 -0800 | [diff] [blame] | 408 | def _CheckJSONParseErrors(input_api, output_api): |
| 409 | """Check that JSON files do not contain syntax errors.""" |
| 410 | |
| 411 | def FilterFile(affected_file): |
| 412 | return input_api.os_path.splitext(affected_file.LocalPath())[1] == '.json' |
| 413 | |
| 414 | def GetJSONParseError(input_api, filename): |
| 415 | try: |
| 416 | contents = input_api.ReadFile(filename) |
| 417 | input_api.json.loads(contents) |
| 418 | except ValueError as e: |
| 419 | return e |
| 420 | return None |
| 421 | |
| 422 | results = [] |
| 423 | for affected_file in input_api.AffectedFiles( |
| 424 | file_filter=FilterFile, include_deletes=False): |
| 425 | parse_error = GetJSONParseError(input_api, |
| 426 | affected_file.AbsoluteLocalPath()) |
| 427 | if parse_error: |
| 428 | results.append(output_api.PresubmitError('%s could not be parsed: %s' % |
| 429 | (affected_file.LocalPath(), parse_error))) |
| 430 | return results |
| 431 | |
| 432 | |
Henrik Kjellander | 8d3ad82 | 2015-05-26 19:52:05 +0200 | [diff] [blame] | 433 | def _RunPythonTests(input_api, output_api): |
| 434 | def join(*args): |
| 435 | return input_api.os_path.join(input_api.PresubmitLocalPath(), *args) |
| 436 | |
| 437 | test_directories = [ |
ehmaldonado | 4fb9746 | 2017-01-30 05:27:22 -0800 | [diff] [blame] | 438 | join('webrtc', 'tools', 'py_event_log_analyzer') |
| 439 | ] + [ |
| 440 | root for root, _, files in os.walk(join('tools-webrtc')) |
| 441 | if any(f.endswith('_test.py') for f in files) |
Henrik Kjellander | 8d3ad82 | 2015-05-26 19:52:05 +0200 | [diff] [blame] | 442 | ] |
| 443 | |
| 444 | tests = [] |
| 445 | for directory in test_directories: |
| 446 | tests.extend( |
| 447 | input_api.canned_checks.GetUnitTestsInDirectory( |
| 448 | input_api, |
| 449 | output_api, |
| 450 | directory, |
| 451 | whitelist=[r'.+_test\.py$'])) |
| 452 | return input_api.RunTests(tests, parallel=True) |
| 453 | |
| 454 | |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 455 | def _CommonChecks(input_api, output_api): |
| 456 | """Checks common to both upload and commit.""" |
niklase@google.com | da159d6 | 2011-05-30 11:51:34 +0000 | [diff] [blame] | 457 | results = [] |
tkchin | 42f580e | 2015-11-26 23:18:23 -0800 | [diff] [blame] | 458 | # Filter out files that are in objc or ios dirs from being cpplint-ed since |
| 459 | # they do not follow C++ lint rules. |
| 460 | black_list = input_api.DEFAULT_BLACK_LIST + ( |
| 461 | r".*\bobjc[\\\/].*", |
Kári Tristan Helgason | 3fa3517 | 2016-09-09 08:55:05 +0000 | [diff] [blame] | 462 | r".*objc\.[hcm]+$", |
hjon | 65ae2d8 | 2016-08-02 23:55:44 -0700 | [diff] [blame] | 463 | r"webrtc\/build\/ios\/SDK\/.*", |
tkchin | 42f580e | 2015-11-26 23:18:23 -0800 | [diff] [blame] | 464 | ) |
| 465 | source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list) |
| 466 | results.extend(_CheckApprovedFilesLintClean( |
| 467 | input_api, output_api, source_file_filter)) |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 468 | results.extend(input_api.canned_checks.RunPylint(input_api, output_api, |
kjellander@webrtc.org | 177567c | 2016-12-22 10:40:28 +0100 | [diff] [blame] | 469 | black_list=(r'^base[\\\/].*\.py$', |
Henrik Kjellander | 14771ac | 2015-06-02 13:10:04 +0200 | [diff] [blame] | 470 | r'^build[\\\/].*\.py$', |
| 471 | r'^buildtools[\\\/].*\.py$', |
Henrik Kjellander | 0779e8f | 2016-12-22 12:01:17 +0100 | [diff] [blame] | 472 | r'^ios[\\\/].*\.py$', |
Henrik Kjellander | 14771ac | 2015-06-02 13:10:04 +0200 | [diff] [blame] | 473 | r'^out.*[\\\/].*\.py$', |
| 474 | r'^testing[\\\/].*\.py$', |
| 475 | r'^third_party[\\\/].*\.py$', |
kjellander@webrtc.org | 177567c | 2016-12-22 10:40:28 +0100 | [diff] [blame] | 476 | r'^tools[\\\/].*\.py$', |
kjellander | afd5494 | 2016-12-17 12:21:39 -0800 | [diff] [blame] | 477 | # TODO(phoglund): should arguably be checked. |
Henrik Kjellander | b2d5577 | 2016-12-18 22:14:50 +0100 | [diff] [blame] | 478 | r'^tools-webrtc[\\\/]mb[\\\/].*\.py$', |
kjellander | afd5494 | 2016-12-17 12:21:39 -0800 | [diff] [blame] | 479 | r'^tools-webrtc[\\\/]valgrind[\\\/].*\.py$', |
Henrik Kjellander | 14771ac | 2015-06-02 13:10:04 +0200 | [diff] [blame] | 480 | r'^xcodebuild.*[\\\/].*\.py$',), |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 481 | disabled_warnings=['F0401', # Failed to import x |
| 482 | 'E0611', # No package y in x |
| 483 | 'W0232', # Class has no __init__ method |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 484 | ], |
| 485 | pylintrc='pylintrc')) |
kjellander | 569cf94 | 2016-02-11 05:02:59 -0800 | [diff] [blame] | 486 | |
nisse | 3d21e23 | 2016-09-02 03:07:06 -0700 | [diff] [blame] | 487 | # TODO(nisse): talk/ is no more, so make below checks simpler? |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 488 | # WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since |
| 489 | # we need to have different license checks in talk/ and webrtc/ directories. |
| 490 | # Instead, hand-picked checks are included below. |
Henrik Kjellander | 6322467 | 2015-09-08 08:03:56 +0200 | [diff] [blame] | 491 | |
tkchin | 3cd9a30 | 2016-06-08 12:40:28 -0700 | [diff] [blame] | 492 | # .m and .mm files are ObjC files. For simplicity we will consider .h files in |
| 493 | # ObjC subdirectories ObjC headers. |
| 494 | objc_filter_list = (r'.+\.m$', r'.+\.mm$', r'.+objc\/.+\.h$') |
Henrik Kjellander | b4af3d6 | 2016-11-16 20:11:29 +0100 | [diff] [blame] | 495 | # Skip long-lines check for DEPS and GN files. |
| 496 | build_file_filter_list = (r'.+\.gn$', r'.+\.gni$', 'DEPS') |
tkchin | 3cd9a30 | 2016-06-08 12:40:28 -0700 | [diff] [blame] | 497 | eighty_char_sources = lambda x: input_api.FilterSourceFile(x, |
| 498 | black_list=build_file_filter_list + objc_filter_list) |
| 499 | hundred_char_sources = lambda x: input_api.FilterSourceFile(x, |
| 500 | white_list=objc_filter_list) |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 501 | results.extend(input_api.canned_checks.CheckLongLines( |
tkchin | 3cd9a30 | 2016-06-08 12:40:28 -0700 | [diff] [blame] | 502 | input_api, output_api, maxlen=80, source_file_filter=eighty_char_sources)) |
| 503 | results.extend(input_api.canned_checks.CheckLongLines( |
| 504 | input_api, output_api, maxlen=100, |
| 505 | source_file_filter=hundred_char_sources)) |
| 506 | |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 507 | results.extend(input_api.canned_checks.CheckChangeHasNoTabs( |
| 508 | input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 509 | results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( |
| 510 | input_api, output_api)) |
kjellander | e5dc62a | 2016-12-14 00:16:21 -0800 | [diff] [blame] | 511 | results.extend(input_api.canned_checks.CheckAuthorizedAuthor( |
| 512 | input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 513 | results.extend(input_api.canned_checks.CheckChangeTodoHasOwner( |
| 514 | input_api, output_api)) |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 515 | results.extend(_CheckNativeApiHeaderChanges(input_api, output_api)) |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 516 | results.extend(_CheckNoIOStreamInHeaders(input_api, output_api)) |
| 517 | results.extend(_CheckNoFRIEND_TEST(input_api, output_api)) |
ehmaldonado | 5b1ba08 | 2016-09-02 05:51:08 -0700 | [diff] [blame] | 518 | results.extend(_CheckGnChanges(input_api, output_api)) |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 519 | results.extend(_CheckUnwantedDependencies(input_api, output_api)) |
kjellander | 569cf94 | 2016-02-11 05:02:59 -0800 | [diff] [blame] | 520 | results.extend(_CheckJSONParseErrors(input_api, output_api)) |
Henrik Kjellander | 8d3ad82 | 2015-05-26 19:52:05 +0200 | [diff] [blame] | 521 | results.extend(_RunPythonTests(input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 522 | return results |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 523 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 524 | |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 525 | def CheckChangeOnUpload(input_api, output_api): |
| 526 | results = [] |
| 527 | results.extend(_CommonChecks(input_api, output_api)) |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 528 | results.extend( |
| 529 | input_api.canned_checks.CheckGNFormatted(input_api, output_api)) |
niklase@google.com | da159d6 | 2011-05-30 11:51:34 +0000 | [diff] [blame] | 530 | return results |
| 531 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 532 | |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 533 | def CheckChangeOnCommit(input_api, output_api): |
niklase@google.com | 1198db9 | 2011-06-09 07:07:24 +0000 | [diff] [blame] | 534 | results = [] |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 535 | results.extend(_CommonChecks(input_api, output_api)) |
kjellander | 53047c9 | 2015-12-02 23:56:14 -0800 | [diff] [blame] | 536 | results.extend(_VerifyNativeApiHeadersListIsValid(input_api, output_api)) |
niklase@google.com | 1198db9 | 2011-06-09 07:07:24 +0000 | [diff] [blame] | 537 | results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 538 | results.extend(input_api.canned_checks.CheckChangeWasUploaded( |
| 539 | input_api, output_api)) |
| 540 | results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 541 | input_api, output_api)) |
kjellander | d1e26a9 | 2016-09-19 08:11:16 -0700 | [diff] [blame] | 542 | results.extend(_CheckChangeHasBugField(input_api, output_api)) |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 543 | results.extend(input_api.canned_checks.CheckChangeHasTestField( |
| 544 | input_api, output_api)) |
kjellander@webrtc.org | 12cb88c | 2014-02-13 11:53:43 +0000 | [diff] [blame] | 545 | results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 546 | input_api, output_api, |
| 547 | json_url='http://webrtc-status.appspot.com/current?format=json')) |
niklase@google.com | 1198db9 | 2011-06-09 07:07:24 +0000 | [diff] [blame] | 548 | return results |