Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <memory> |
| 12 | #include <vector> |
| 13 | |
Karl Wiberg | 918f50c | 2018-07-05 11:40:33 +0200 | [diff] [blame] | 14 | #include "absl/memory/memory.h" |
Karl Wiberg | 1b0eae3 | 2017-10-17 14:48:54 +0200 | [diff] [blame] | 15 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 16 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 17 | #include "api/jsep.h" |
| 18 | #include "api/mediastreaminterface.h" |
| 19 | #include "api/peerconnectioninterface.h" |
Anders Carlsson | 6753795 | 2018-05-03 11:28:29 +0200 | [diff] [blame] | 20 | #include "api/video_codecs/builtin_video_decoder_factory.h" |
| 21 | #include "api/video_codecs/builtin_video_encoder_factory.h" |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 22 | #include "pc/mediasession.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 23 | #include "pc/mediastream.h" |
| 24 | #include "pc/mediastreamtrack.h" |
| 25 | #include "pc/peerconnectionwrapper.h" |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 26 | #include "pc/sdputils.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 27 | #include "pc/test/fakeaudiocapturemodule.h" |
| 28 | #include "pc/test/mockpeerconnectionobservers.h" |
| 29 | #include "rtc_base/checks.h" |
| 30 | #include "rtc_base/gunit.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 31 | #include "rtc_base/refcountedobject.h" |
| 32 | #include "rtc_base/scoped_ref_ptr.h" |
| 33 | #include "rtc_base/thread.h" |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 34 | #include "system_wrappers/include/metrics_default.h" |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 35 | #include "test/gmock.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 36 | |
| 37 | // This file contains tests for RTP Media API-related behavior of |
| 38 | // |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api. |
| 39 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 40 | namespace webrtc { |
| 41 | |
| 42 | using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; |
| 43 | using ::testing::ElementsAre; |
| 44 | using ::testing::UnorderedElementsAre; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 45 | using ::testing::Values; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 46 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 47 | const uint32_t kDefaultTimeout = 10000u; |
| 48 | |
| 49 | template <typename MethodFunctor> |
| 50 | class OnSuccessObserver : public rtc::RefCountedObject< |
| 51 | webrtc::SetRemoteDescriptionObserverInterface> { |
| 52 | public: |
| 53 | explicit OnSuccessObserver(MethodFunctor on_success) |
| 54 | : on_success_(std::move(on_success)) {} |
| 55 | |
| 56 | // webrtc::SetRemoteDescriptionObserverInterface implementation. |
| 57 | void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override { |
| 58 | RTC_CHECK(error.ok()); |
| 59 | on_success_(); |
| 60 | } |
| 61 | |
| 62 | private: |
| 63 | MethodFunctor on_success_; |
| 64 | }; |
| 65 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 66 | class PeerConnectionRtpBaseTest : public testing::Test { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 67 | public: |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 68 | explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics) |
| 69 | : sdp_semantics_(sdp_semantics), |
| 70 | pc_factory_( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 71 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 72 | rtc::Thread::Current(), |
| 73 | rtc::Thread::Current(), |
| 74 | FakeAudioCaptureModule::Create(), |
| 75 | CreateBuiltinAudioEncoderFactory(), |
| 76 | CreateBuiltinAudioDecoderFactory(), |
Anders Carlsson | 6753795 | 2018-05-03 11:28:29 +0200 | [diff] [blame] | 77 | CreateBuiltinVideoEncoderFactory(), |
| 78 | CreateBuiltinVideoDecoderFactory(), |
| 79 | nullptr /* audio_mixer */, |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 80 | nullptr /* audio_processing */)) { |
| 81 | webrtc::metrics::Reset(); |
| 82 | } |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 83 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 84 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() { |
| 85 | return CreatePeerConnection(RTCConfiguration()); |
| 86 | } |
| 87 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 88 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() { |
| 89 | RTCConfiguration config; |
| 90 | config.sdp_semantics = SdpSemantics::kPlanB; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 91 | return CreatePeerConnectionInternal(config); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 92 | } |
| 93 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 94 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() { |
| 95 | RTCConfiguration config; |
| 96 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 97 | return CreatePeerConnectionInternal(config); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 98 | } |
| 99 | |
| 100 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection( |
| 101 | const RTCConfiguration& config) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 102 | RTCConfiguration modified_config = config; |
| 103 | modified_config.sdp_semantics = sdp_semantics_; |
| 104 | return CreatePeerConnectionInternal(modified_config); |
| 105 | } |
| 106 | |
| 107 | protected: |
| 108 | const SdpSemantics sdp_semantics_; |
| 109 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
| 110 | |
| 111 | private: |
| 112 | // Private so that tests don't accidentally bypass the SdpSemantics |
| 113 | // adjustment. |
| 114 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal( |
| 115 | const RTCConfiguration& config) { |
Karl Wiberg | 918f50c | 2018-07-05 11:40:33 +0200 | [diff] [blame] | 116 | auto observer = absl::make_unique<MockPeerConnectionObserver>(); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 117 | auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr, |
| 118 | observer.get()); |
Karl Wiberg | 918f50c | 2018-07-05 11:40:33 +0200 | [diff] [blame] | 119 | return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc, |
| 120 | std::move(observer)); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 121 | } |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 122 | }; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 123 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 124 | class PeerConnectionRtpTest |
| 125 | : public PeerConnectionRtpBaseTest, |
| 126 | public ::testing::WithParamInterface<SdpSemantics> { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 127 | protected: |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 128 | PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {} |
| 129 | }; |
| 130 | |
| 131 | class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest { |
| 132 | protected: |
| 133 | PeerConnectionRtpTestPlanB() |
| 134 | : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {} |
| 135 | }; |
| 136 | |
| 137 | class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest { |
| 138 | protected: |
| 139 | PeerConnectionRtpTestUnifiedPlan() |
| 140 | : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {} |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 141 | }; |
| 142 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 143 | // These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon |
| 144 | // setting the remote description. |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 145 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 146 | TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 147 | auto caller = CreatePeerConnection(); |
| 148 | auto callee = CreatePeerConnection(); |
| 149 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 150 | ASSERT_TRUE(caller->AddAudioTrack("audio_track")); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 151 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 152 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 153 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 154 | const auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 155 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 156 | |
| 157 | if (sdp_semantics_ == SdpSemantics::kPlanB) { |
| 158 | // Since we are not supporting the no stream case with Plan B, there should |
| 159 | // be a generated stream, even though we didn't set one with AddTrack. |
| 160 | ASSERT_EQ(1u, add_track_event.streams.size()); |
| 161 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 162 | } else { |
| 163 | EXPECT_EQ(0u, add_track_event.streams.size()); |
| 164 | } |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 165 | } |
| 166 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 167 | TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 168 | auto caller = CreatePeerConnection(); |
| 169 | auto callee = CreatePeerConnection(); |
| 170 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 171 | ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"})); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 172 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 173 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 174 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 175 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 176 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Seth Hampson | 13b8bad | 2018-03-13 16:05:28 -0700 | [diff] [blame] | 177 | EXPECT_EQ("audio_stream", add_track_event.streams[0]->id()); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 178 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 179 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 180 | } |
| 181 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 182 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 183 | auto caller = CreatePeerConnection(); |
| 184 | auto callee = CreatePeerConnection(); |
| 185 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 186 | auto sender = caller->AddAudioTrack("audio_track", {}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 187 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 188 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 189 | ASSERT_TRUE( |
| 190 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
| 191 | |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 192 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 193 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 194 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 195 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 196 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 197 | callee->observer()->remove_track_events_); |
| 198 | } |
| 199 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 200 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 201 | auto caller = CreatePeerConnection(); |
| 202 | auto callee = CreatePeerConnection(); |
| 203 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 204 | auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 205 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 206 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 207 | ASSERT_TRUE( |
| 208 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
| 209 | |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 210 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 211 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 212 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 213 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 214 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 215 | callee->observer()->remove_track_events_); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 216 | EXPECT_EQ(0u, callee->observer()->remote_streams()->count()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 217 | } |
| 218 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 219 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 220 | auto caller = CreatePeerConnection(); |
| 221 | auto callee = CreatePeerConnection(); |
| 222 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 223 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 224 | auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId}); |
| 225 | auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 226 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 227 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 228 | ASSERT_TRUE( |
| 229 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 230 | |
| 231 | // Remove "audio_track1". |
| 232 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 233 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 234 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 235 | EXPECT_EQ( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 236 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 237 | callee->observer()->add_track_events_[0].receiver}, |
| 238 | callee->observer()->remove_track_events_); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 239 | ASSERT_EQ(1u, callee->observer()->remote_streams()->count()); |
| 240 | ASSERT_TRUE( |
| 241 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 242 | |
| 243 | // Remove "audio_track2". |
| 244 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 245 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 246 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 247 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 248 | callee->observer()->remove_track_events_); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 249 | EXPECT_EQ(0u, callee->observer()->remote_streams()->count()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 250 | } |
| 251 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 252 | // Tests the edge case that if a stream ID changes for a given track that both |
| 253 | // OnRemoveTrack and OnAddTrack is fired. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 254 | TEST_F(PeerConnectionRtpTestPlanB, |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 255 | RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) { |
| 256 | auto caller = CreatePeerConnection(); |
| 257 | auto callee = CreatePeerConnection(); |
| 258 | |
| 259 | const char kStreamId1[] = "stream1"; |
| 260 | const char kStreamId2[] = "stream2"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 261 | caller->AddAudioTrack("audio_track1", {kStreamId1}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 262 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 263 | EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 264 | |
| 265 | // Change the stream ID of the sender in the session description. |
| 266 | auto offer = caller->CreateOfferAndSetAsLocal(); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 267 | auto* audio_desc = |
| 268 | cricket::GetFirstAudioContentDescription(offer->description()); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 269 | ASSERT_EQ(audio_desc->mutable_streams().size(), 1u); |
| 270 | audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2}); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 271 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 272 | |
| 273 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
| 274 | EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(), |
| 275 | kStreamId2); |
| 276 | ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u); |
| 277 | EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(), |
| 278 | kStreamId1); |
| 279 | } |
| 280 | |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 281 | // Tests that setting a remote description with sending transceivers will fire |
| 282 | // the OnTrack callback for each transceiver and setting a remote description |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 283 | // with receive only transceivers will not call OnTrack. One transceiver is |
| 284 | // created without any stream_ids, while the other is created with multiple |
| 285 | // stream_ids. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 286 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) { |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 287 | const std::string kStreamId1 = "video_stream1"; |
| 288 | const std::string kStreamId2 = "video_stream2"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 289 | auto caller = CreatePeerConnection(); |
| 290 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 291 | |
| 292 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 293 | RtpTransceiverInit video_transceiver_init; |
| 294 | video_transceiver_init.stream_ids = {kStreamId1, kStreamId2}; |
| 295 | auto video_transceiver = |
| 296 | caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 297 | |
| 298 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 299 | |
| 300 | ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 301 | ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 302 | EXPECT_EQ(audio_transceiver->mid(), |
| 303 | callee->pc()->GetTransceivers()[0]->mid()); |
| 304 | EXPECT_EQ(video_transceiver->mid(), |
| 305 | callee->pc()->GetTransceivers()[1]->mid()); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 306 | std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams = |
| 307 | callee->pc()->GetTransceivers()[0]->receiver()->streams(); |
| 308 | std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams = |
| 309 | callee->pc()->GetTransceivers()[1]->receiver()->streams(); |
| 310 | ASSERT_EQ(0u, audio_streams.size()); |
| 311 | ASSERT_EQ(2u, video_streams.size()); |
| 312 | EXPECT_EQ(kStreamId1, video_streams[0]->id()); |
| 313 | EXPECT_EQ(kStreamId2, video_streams[1]->id()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 314 | } |
| 315 | |
| 316 | // Test that doing additional offer/answer exchanges with no changes to tracks |
| 317 | // will cause no additional OnTrack calls after the tracks have been negotiated. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 318 | TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) { |
| 319 | auto caller = CreatePeerConnection(); |
| 320 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 321 | |
| 322 | caller->AddAudioTrack("audio"); |
| 323 | callee->AddAudioTrack("audio"); |
| 324 | |
| 325 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 326 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 327 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 328 | |
| 329 | // If caller reoffers with no changes expect no additional OnTrack calls. |
| 330 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 331 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 332 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 333 | |
| 334 | // Also if callee reoffers with no changes expect no additional OnTrack calls. |
| 335 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 336 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 337 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 338 | } |
| 339 | |
| 340 | // Test that OnTrack is called when the transceiver direction changes to send |
| 341 | // the track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 342 | TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) { |
| 343 | auto caller = CreatePeerConnection(); |
| 344 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 345 | |
| 346 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 347 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 348 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 349 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 350 | EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size()); |
| 351 | |
| 352 | transceiver->SetDirection(RtpTransceiverDirection::kSendOnly); |
| 353 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 354 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 355 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 356 | |
| 357 | // If the direction changes but it is still receiving on the remote side, then |
| 358 | // OnTrack should not be fired again. |
| 359 | transceiver->SetDirection(RtpTransceiverDirection::kSendRecv); |
| 360 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 361 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 362 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 363 | } |
| 364 | |
| 365 | // Test that OnTrack is called twice when a sendrecv call is started, the callee |
| 366 | // changes the direction to inactive, then changes it back to sendrecv. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 367 | TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) { |
| 368 | auto caller = CreatePeerConnection(); |
| 369 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 370 | |
| 371 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 372 | |
| 373 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 374 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 375 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 376 | |
| 377 | // Put the call on hold by no longer receiving the track. |
| 378 | callee->pc()->GetTransceivers()[0]->SetDirection( |
| 379 | RtpTransceiverDirection::kInactive); |
| 380 | |
| 381 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 382 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 383 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 384 | |
| 385 | // Resume the call by changing the direction to recvonly. This should call |
| 386 | // OnTrack again on the callee side. |
| 387 | callee->pc()->GetTransceivers()[0]->SetDirection( |
| 388 | RtpTransceiverDirection::kRecvOnly); |
| 389 | |
| 390 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 391 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 392 | EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 393 | } |
| 394 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 395 | // Test that setting a remote offer twice with no answer in the middle results |
| 396 | // in OnAddTrack being fired twice, once for each SetRemoteDescription. This |
| 397 | // happens since the RtpTransceiver's current_direction is only updated when |
| 398 | // setting the answer. |
| 399 | // TODO(bugs.webrtc.org/9236): This is spec-compliant but strange behavior. |
| 400 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 401 | ApplyTwoOffersWithNoAnswerResultsInTwoAddTrackEvents) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 402 | auto caller = CreatePeerConnection(); |
| 403 | auto callee = CreatePeerConnection(); |
| 404 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 405 | caller->AddAudioTrack("audio_track", {}); |
| 406 | |
| 407 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 408 | ASSERT_EQ(1u, callee->observer()->add_track_events_.size()); |
| 409 | |
| 410 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 411 | EXPECT_EQ(2u, callee->observer()->add_track_events_.size()); |
| 412 | } |
| 413 | |
| 414 | // Test that setting a remote offer twice with no answer in the middle and the |
| 415 | // track being removed between the two offers results in OnAddTrack being called |
| 416 | // once the first time and OnRemoveTrack never getting called. This happens |
| 417 | // since the RtpTransceiver's current_direction is only updated when setting the |
| 418 | // answer. |
| 419 | // TODO(bugs.webrtc.org/9236): This is spec-compliant but strange behavior. |
| 420 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 421 | ApplyTwoOffersWithNoAnswerAndTrackRemovedResultsInNoRemoveTrackEvents) { |
| 422 | auto caller = CreatePeerConnection(); |
| 423 | auto callee = CreatePeerConnection(); |
| 424 | |
| 425 | auto sender = caller->AddAudioTrack("audio_track", {}); |
| 426 | |
| 427 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 428 | ASSERT_EQ(1u, callee->observer()->add_track_events_.size()); |
| 429 | |
| 430 | caller->pc()->RemoveTrack(sender); |
| 431 | |
| 432 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 433 | EXPECT_EQ(1u, callee->observer()->add_track_events_.size()); |
| 434 | EXPECT_EQ(0u, callee->observer()->remove_track_events_.size()); |
| 435 | } |
| 436 | |
| 437 | // These tests examine the state of the peer connection as a result of |
| 438 | // performing SetRemoteDescription(). |
| 439 | |
| 440 | TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) { |
| 441 | auto caller = CreatePeerConnection(); |
| 442 | auto callee = CreatePeerConnection(); |
| 443 | |
| 444 | ASSERT_TRUE(caller->AddAudioTrack("audio_track", {})); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 445 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 446 | |
| 447 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 448 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 449 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 450 | |
| 451 | if (sdp_semantics_ == SdpSemantics::kPlanB) { |
| 452 | // Since we are not supporting the no stream case with Plan B, there should |
| 453 | // be a generated stream, even though we didn't set one with AddTrack. |
| 454 | ASSERT_EQ(1u, receiver_added->streams().size()); |
| 455 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 456 | } else { |
| 457 | EXPECT_EQ(0u, receiver_added->streams().size()); |
| 458 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 459 | } |
| 460 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 461 | TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 462 | auto caller = CreatePeerConnection(); |
| 463 | auto callee = CreatePeerConnection(); |
| 464 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 465 | ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"})); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 466 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 467 | |
| 468 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 469 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 470 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 471 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
Seth Hampson | 13b8bad | 2018-03-13 16:05:28 -0700 | [diff] [blame] | 472 | EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id()); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 473 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 474 | } |
| 475 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 476 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 477 | auto caller = CreatePeerConnection(); |
| 478 | auto callee = CreatePeerConnection(); |
| 479 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 480 | auto sender = caller->AddAudioTrack("audio_track", {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 481 | ASSERT_TRUE(sender); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 482 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 483 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 484 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 485 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 486 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 487 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 488 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 489 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 490 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 491 | // inactive. |
| 492 | ASSERT_EQ(1u, callee->pc()->GetReceivers().size()); |
| 493 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 494 | callee->pc()->GetTransceivers()[0]->current_direction()); |
| 495 | } else { |
| 496 | // With Plan B the receiver is removed. |
| 497 | ASSERT_EQ(0u, callee->pc()->GetReceivers().size()); |
| 498 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 499 | } |
| 500 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 501 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 502 | auto caller = CreatePeerConnection(); |
| 503 | auto callee = CreatePeerConnection(); |
| 504 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 505 | auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 506 | ASSERT_TRUE(sender); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 507 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 508 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 509 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 510 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 511 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 512 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 513 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 514 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 515 | // inactive. |
| 516 | EXPECT_EQ(1u, callee->pc()->GetReceivers().size()); |
| 517 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 518 | callee->pc()->GetTransceivers()[0]->current_direction()); |
| 519 | } else { |
| 520 | // With Plan B the receiver is removed. |
| 521 | EXPECT_EQ(0u, callee->pc()->GetReceivers().size()); |
| 522 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 523 | } |
| 524 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 525 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 526 | auto caller = CreatePeerConnection(); |
| 527 | auto callee = CreatePeerConnection(); |
| 528 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 529 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 530 | auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId}); |
| 531 | auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId}); |
| 532 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 533 | ASSERT_EQ(2u, callee->pc()->GetReceivers().size()); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 534 | |
| 535 | // Remove "audio_track1". |
| 536 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 537 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 538 | |
| 539 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 540 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 541 | // inactive. |
| 542 | ASSERT_EQ(2u, callee->pc()->GetReceivers().size()); |
| 543 | auto transceiver = callee->pc()->GetTransceivers()[0]; |
| 544 | EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id()); |
| 545 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 546 | transceiver->current_direction()); |
| 547 | } else { |
| 548 | // With Plan B the receiver is removed. |
| 549 | ASSERT_EQ(1u, callee->pc()->GetReceivers().size()); |
| 550 | EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id()); |
| 551 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 552 | |
| 553 | // Remove "audio_track2". |
| 554 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 555 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 556 | |
| 557 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 558 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 559 | // inactive. |
| 560 | ASSERT_EQ(2u, callee->pc()->GetReceivers().size()); |
| 561 | auto transceiver = callee->pc()->GetTransceivers()[1]; |
| 562 | EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id()); |
| 563 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 564 | transceiver->current_direction()); |
| 565 | } else { |
| 566 | // With Plan B the receiver is removed. |
| 567 | ASSERT_EQ(0u, callee->pc()->GetReceivers().size()); |
| 568 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 569 | } |
| 570 | |
Florent Castelli | abe301f | 2018-06-12 18:33:49 +0200 | [diff] [blame] | 571 | TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) { |
| 572 | auto caller = CreatePeerConnection(); |
| 573 | auto callee = CreatePeerConnection(); |
| 574 | auto sender = caller->AddAudioTrack("audio_track"); |
| 575 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 576 | |
| 577 | ASSERT_GT(caller->pc()->GetSenders().size(), 0u); |
| 578 | EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u); |
| 579 | |
| 580 | ASSERT_GT(callee->pc()->GetReceivers().size(), 0u); |
| 581 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 582 | EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u); |
| 583 | } |
| 584 | |
| 585 | TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) { |
| 586 | auto caller = CreatePeerConnection(); |
| 587 | auto callee = CreatePeerConnection(); |
| 588 | auto sender = caller->AddVideoTrack("video_track"); |
| 589 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 590 | |
| 591 | ASSERT_GT(caller->pc()->GetSenders().size(), 0u); |
| 592 | EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u); |
| 593 | |
| 594 | ASSERT_GT(callee->pc()->GetReceivers().size(), 0u); |
| 595 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 596 | EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u); |
| 597 | } |
| 598 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 599 | // Invokes SetRemoteDescription() twice in a row without synchronizing the two |
| 600 | // calls and examine the state of the peer connection inside the callbacks to |
| 601 | // ensure that the second call does not occur prematurely, contaminating the |
| 602 | // state of the peer connection of the first callback. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 603 | TEST_F(PeerConnectionRtpTestPlanB, |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 604 | StatesCorrelateWithSetRemoteDescriptionCall) { |
| 605 | auto caller = CreatePeerConnection(); |
| 606 | auto callee = CreatePeerConnection(); |
| 607 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 608 | // Create SDP for adding a track and for removing it. This will be used in the |
| 609 | // first and second SetRemoteDescription() calls. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 610 | auto sender = caller->AddAudioTrack("audio_track", {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 611 | auto srd1_sdp = caller->CreateOfferAndSetAsLocal(); |
| 612 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 613 | auto srd2_sdp = caller->CreateOfferAndSetAsLocal(); |
| 614 | |
| 615 | // In the first SetRemoteDescription() callback, check that we have a |
| 616 | // receiver for the track. |
| 617 | auto pc = callee->pc(); |
| 618 | bool srd1_callback_called = false; |
| 619 | auto srd1_callback = [&srd1_callback_called, &pc]() { |
| 620 | EXPECT_EQ(pc->GetReceivers().size(), 1u); |
| 621 | srd1_callback_called = true; |
| 622 | }; |
| 623 | |
| 624 | // In the second SetRemoteDescription() callback, check that the receiver has |
| 625 | // been removed. |
| 626 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 627 | // Instead, the transceiver owning the receiver will become inactive. |
| 628 | // https://crbug.com/webrtc/7600 |
| 629 | bool srd2_callback_called = false; |
| 630 | auto srd2_callback = [&srd2_callback_called, &pc]() { |
| 631 | EXPECT_TRUE(pc->GetReceivers().empty()); |
| 632 | srd2_callback_called = true; |
| 633 | }; |
| 634 | |
| 635 | // Invoke SetRemoteDescription() twice in a row without synchronizing the two |
| 636 | // calls. The callbacks verify that the two calls are synchronized, as in, the |
| 637 | // effects of the second SetRemoteDescription() call must not have happened by |
| 638 | // the time the first callback is invoked. If it has then the receiver that is |
| 639 | // added as a result of the first SetRemoteDescription() call will already |
| 640 | // have been removed as a result of the second SetRemoteDescription() call |
| 641 | // when the first callback is invoked. |
| 642 | callee->pc()->SetRemoteDescription( |
| 643 | std::move(srd1_sdp), |
| 644 | new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback)); |
| 645 | callee->pc()->SetRemoteDescription( |
| 646 | std::move(srd2_sdp), |
| 647 | new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback)); |
| 648 | EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout); |
| 649 | EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout); |
| 650 | } |
| 651 | |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 652 | // Tests that a remote track is created with the signaled MSIDs when they are |
| 653 | // communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc |
| 654 | // lines). |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 655 | TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) { |
| 656 | auto caller = CreatePeerConnection(); |
| 657 | auto callee = CreatePeerConnection(); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 658 | const char kStreamId1[] = "stream1"; |
| 659 | const char kStreamId2[] = "stream2"; |
| 660 | caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
| 661 | {kStreamId1, kStreamId2}); |
| 662 | |
| 663 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 664 | // Munge the offer to take out everything but the stream_ids. |
| 665 | auto contents = offer->description()->contents(); |
| 666 | ASSERT_TRUE(!contents.empty()); |
| 667 | ASSERT_TRUE(!contents[0].media_description()->streams().empty()); |
| 668 | std::vector<std::string> stream_ids = |
| 669 | contents[0].media_description()->streams()[0].stream_ids(); |
| 670 | contents[0].media_description()->mutable_streams().clear(); |
| 671 | cricket::StreamParams new_stream; |
| 672 | new_stream.set_stream_ids(stream_ids); |
| 673 | contents[0].media_description()->AddStream(new_stream); |
| 674 | |
| 675 | // Set the remote description and verify that the streams were added to the |
| 676 | // receiver correctly. |
| 677 | ASSERT_TRUE( |
| 678 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()))); |
| 679 | auto receivers = callee->pc()->GetReceivers(); |
| 680 | ASSERT_EQ(receivers.size(), 1u); |
| 681 | ASSERT_EQ(receivers[0]->streams().size(), 2u); |
| 682 | EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1); |
| 683 | EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2); |
| 684 | } |
| 685 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 686 | // Tests that with Unified Plan if the the stream id changes for a track when |
| 687 | // when setting a new remote description, that the media stream is updated |
| 688 | // appropriately for the receiver. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 689 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoteStreamIdChangesUpdatesReceiver) { |
| 690 | auto caller = CreatePeerConnection(); |
| 691 | auto callee = CreatePeerConnection(); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 692 | |
| 693 | const char kStreamId1[] = "stream1"; |
| 694 | const char kStreamId2[] = "stream2"; |
| 695 | caller->AddTrack(caller->CreateAudioTrack("audio_track1"), {kStreamId1}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 696 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 697 | EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 698 | |
| 699 | // Change the stream id of the sender in the session description. |
| 700 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 701 | auto contents = offer->description()->contents(); |
| 702 | ASSERT_EQ(contents.size(), 1u); |
| 703 | ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u); |
| 704 | contents[0].media_description()->mutable_streams()[0].set_stream_ids( |
| 705 | {kStreamId2}); |
| 706 | |
| 707 | // Set the remote description and verify that the stream was updated properly. |
| 708 | ASSERT_TRUE( |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 709 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()))); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 710 | auto receivers = callee->pc()->GetReceivers(); |
| 711 | ASSERT_EQ(receivers.size(), 1u); |
| 712 | ASSERT_EQ(receivers[0]->streams().size(), 1u); |
| 713 | EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2); |
| 714 | } |
| 715 | |
| 716 | // This tests a regression caught by a downstream client, that occured when |
| 717 | // applying a remote description with a SessionDescription object that |
| 718 | // contained StreamParams that didn't have ids. Although there were multiple |
| 719 | // remote audio senders, FindSenderInfo didn't find them as unique, because |
| 720 | // it looked up by StreamParam.id, which none had. This meant only one |
| 721 | // AudioRtpReceiver was created, as opposed to one for each remote sender. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 722 | TEST_F(PeerConnectionRtpTestPlanB, |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 723 | MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) { |
| 724 | auto caller = CreatePeerConnection(); |
| 725 | auto callee = CreatePeerConnection(); |
| 726 | |
| 727 | const char kStreamId1[] = "stream1"; |
| 728 | const char kStreamId2[] = "stream2"; |
| 729 | caller->AddAudioTrack("audio_track1", {kStreamId1}); |
| 730 | caller->AddAudioTrack("audio_track2", {kStreamId2}); |
| 731 | |
| 732 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 733 | auto mutable_streams = |
| 734 | cricket::GetFirstAudioContentDescription(offer->description()) |
| 735 | ->mutable_streams(); |
| 736 | ASSERT_EQ(mutable_streams.size(), 2u); |
| 737 | // Clear the IDs in the StreamParams. |
| 738 | mutable_streams[0].id.clear(); |
| 739 | mutable_streams[1].id.clear(); |
| 740 | ASSERT_TRUE( |
| 741 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()))); |
| 742 | |
| 743 | auto receivers = callee->pc()->GetReceivers(); |
| 744 | ASSERT_EQ(receivers.size(), 2u); |
| 745 | ASSERT_EQ(receivers[0]->streams().size(), 1u); |
| 746 | EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id()); |
| 747 | ASSERT_EQ(receivers[1]->streams().size(), 1u); |
| 748 | EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id()); |
| 749 | } |
| 750 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 751 | // Tests for the legacy SetRemoteDescription() function signature. |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 752 | |
| 753 | // Sanity test making sure the callback is invoked. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 754 | TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 755 | auto caller = CreatePeerConnection(); |
| 756 | auto callee = CreatePeerConnection(); |
| 757 | |
| 758 | std::string error; |
| 759 | ASSERT_TRUE( |
| 760 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error)); |
| 761 | } |
| 762 | |
| 763 | // Verifies legacy behavior: The observer is not called if if the peer |
| 764 | // connection is destroyed because the asynchronous callback is executed in the |
| 765 | // peer connection's message handler. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 766 | TEST_P(PeerConnectionRtpTest, |
| 767 | LegacyObserverNotCalledIfPeerConnectionDereferenced) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 768 | auto caller = CreatePeerConnection(); |
| 769 | auto callee = CreatePeerConnection(); |
| 770 | |
| 771 | rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer = |
| 772 | new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>(); |
| 773 | |
| 774 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 775 | callee->pc()->SetRemoteDescription(observer, offer.release()); |
| 776 | callee = nullptr; |
| 777 | rtc::Thread::Current()->ProcessMessages(0); |
| 778 | EXPECT_FALSE(observer->called()); |
| 779 | } |
| 780 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 781 | // RtpTransceiver Tests. |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 782 | |
| 783 | // Test that by default there are no transceivers with Unified Plan. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 784 | TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) { |
| 785 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 786 | EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre()); |
| 787 | } |
| 788 | |
| 789 | // Test that a transceiver created with the audio kind has the correct initial |
| 790 | // properties. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 791 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 792 | AddTransceiverHasCorrectInitProperties) { |
| 793 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 794 | |
| 795 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Danil Chapovalov | 66cadcc | 2018-06-19 16:47:43 +0200 | [diff] [blame] | 796 | EXPECT_EQ(absl::nullopt, transceiver->mid()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 797 | EXPECT_FALSE(transceiver->stopped()); |
| 798 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
Danil Chapovalov | 66cadcc | 2018-06-19 16:47:43 +0200 | [diff] [blame] | 799 | EXPECT_EQ(absl::nullopt, transceiver->current_direction()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 800 | } |
| 801 | |
| 802 | // Test that adding a transceiver with the audio kind creates an audio sender |
| 803 | // and audio receiver with the receiver having a live audio track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 804 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 805 | AddAudioTransceiverCreatesAudioSenderAndReceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 806 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 807 | |
| 808 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 809 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 810 | |
| 811 | ASSERT_TRUE(transceiver->sender()); |
| 812 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type()); |
| 813 | |
| 814 | ASSERT_TRUE(transceiver->receiver()); |
| 815 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type()); |
| 816 | |
| 817 | auto track = transceiver->receiver()->track(); |
| 818 | ASSERT_TRUE(track); |
| 819 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind()); |
| 820 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 821 | } |
| 822 | |
| 823 | // Test that adding a transceiver with the video kind creates an video sender |
| 824 | // and video receiver with the receiver having a live video track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 825 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 826 | AddAudioTransceiverCreatesVideoSenderAndReceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 827 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 828 | |
| 829 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 830 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 831 | |
| 832 | ASSERT_TRUE(transceiver->sender()); |
| 833 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type()); |
| 834 | |
| 835 | ASSERT_TRUE(transceiver->receiver()); |
| 836 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type()); |
| 837 | |
| 838 | auto track = transceiver->receiver()->track(); |
| 839 | ASSERT_TRUE(track); |
| 840 | EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind()); |
| 841 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 842 | } |
| 843 | |
| 844 | // Test that after a call to AddTransceiver, the transceiver shows in |
| 845 | // GetTransceivers(), the transceiver's sender shows in GetSenders(), and the |
| 846 | // transceiver's receiver shows in GetReceivers(). |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 847 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) { |
| 848 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 849 | |
| 850 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 851 | EXPECT_EQ( |
| 852 | std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver}, |
| 853 | caller->pc()->GetTransceivers()); |
| 854 | EXPECT_EQ( |
| 855 | std::vector<rtc::scoped_refptr<RtpSenderInterface>>{ |
| 856 | transceiver->sender()}, |
| 857 | caller->pc()->GetSenders()); |
| 858 | EXPECT_EQ( |
| 859 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
| 860 | transceiver->receiver()}, |
| 861 | caller->pc()->GetReceivers()); |
| 862 | } |
| 863 | |
| 864 | // Test that the direction passed in through the AddTransceiver init parameter |
| 865 | // is set in the returned transceiver. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 866 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 867 | AddTransceiverWithDirectionIsReflected) { |
| 868 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 869 | |
| 870 | RtpTransceiverInit init; |
| 871 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 872 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 873 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 874 | } |
| 875 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 876 | // Test that calling AddTransceiver with a track creates a transceiver which has |
| 877 | // its sender's track set to the passed-in track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 878 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 879 | AddTransceiverWithTrackCreatesSenderWithTrack) { |
| 880 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 881 | |
| 882 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 883 | auto transceiver = caller->AddTransceiver(audio_track); |
| 884 | |
| 885 | auto sender = transceiver->sender(); |
| 886 | ASSERT_TRUE(sender->track()); |
| 887 | EXPECT_EQ(audio_track, sender->track()); |
| 888 | |
| 889 | auto receiver = transceiver->receiver(); |
| 890 | ASSERT_TRUE(receiver->track()); |
| 891 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind()); |
| 892 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, |
| 893 | receiver->track()->state()); |
| 894 | } |
| 895 | |
| 896 | // Test that calling AddTransceiver twice with the same track creates distinct |
| 897 | // transceivers, senders with the same track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 898 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 899 | AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 900 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 901 | |
| 902 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 903 | |
| 904 | auto transceiver1 = caller->AddTransceiver(audio_track); |
| 905 | auto transceiver2 = caller->AddTransceiver(audio_track); |
| 906 | |
| 907 | EXPECT_NE(transceiver1, transceiver2); |
| 908 | |
| 909 | auto sender1 = transceiver1->sender(); |
| 910 | auto sender2 = transceiver2->sender(); |
| 911 | EXPECT_NE(sender1, sender2); |
| 912 | EXPECT_EQ(audio_track, sender1->track()); |
| 913 | EXPECT_EQ(audio_track, sender2->track()); |
| 914 | |
| 915 | EXPECT_THAT(caller->pc()->GetTransceivers(), |
| 916 | UnorderedElementsAre(transceiver1, transceiver2)); |
| 917 | EXPECT_THAT(caller->pc()->GetSenders(), |
| 918 | UnorderedElementsAre(sender1, sender2)); |
| 919 | } |
| 920 | |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 921 | // RtpTransceiver error handling tests. |
| 922 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 923 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 924 | AddTransceiverWithInvalidKindReturnsError) { |
| 925 | auto caller = CreatePeerConnection(); |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 926 | |
| 927 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA); |
| 928 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
| 929 | } |
| 930 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 931 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 932 | CanClosePeerConnectionWithoutCrashing) { |
| 933 | auto caller = CreatePeerConnection(); |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 934 | |
| 935 | caller->pc()->Close(); |
| 936 | } |
| 937 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 938 | // Unified Plan AddTrack tests. |
| 939 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 940 | // Test that adding an audio track creates a new audio RtpSender with the given |
| 941 | // track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 942 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) { |
| 943 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 944 | |
| 945 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 946 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 947 | ASSERT_TRUE(sender); |
| 948 | |
| 949 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type()); |
| 950 | EXPECT_EQ(audio_track, sender->track()); |
| 951 | } |
| 952 | |
| 953 | // Test that adding a video track creates a new video RtpSender with the given |
| 954 | // track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 955 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) { |
| 956 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 957 | |
| 958 | auto video_track = caller->CreateVideoTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 959 | auto sender = caller->AddTrack(video_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 960 | ASSERT_TRUE(sender); |
| 961 | |
| 962 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type()); |
| 963 | EXPECT_EQ(video_track, sender->track()); |
| 964 | } |
| 965 | |
| 966 | // Test that adding a track to a new PeerConnection creates an RtpTransceiver |
| 967 | // with the sender that AddTrack returns and in the sendrecv direction. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 968 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) { |
| 969 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 970 | |
| 971 | auto sender = caller->AddAudioTrack("a"); |
| 972 | ASSERT_TRUE(sender); |
| 973 | |
| 974 | auto transceivers = caller->pc()->GetTransceivers(); |
| 975 | ASSERT_EQ(1u, transceivers.size()); |
| 976 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 977 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction()); |
| 978 | } |
| 979 | |
| 980 | // Test that if a transceiver of the same type but no track had been added to |
| 981 | // the PeerConnection and later a call to AddTrack is made, the resulting sender |
| 982 | // is the transceiver's sender and the sender's track is the newly-added track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 983 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) { |
| 984 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 985 | |
| 986 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 987 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 988 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 989 | ASSERT_TRUE(sender); |
| 990 | |
| 991 | auto transceivers = caller->pc()->GetTransceivers(); |
| 992 | ASSERT_EQ(1u, transceivers.size()); |
| 993 | EXPECT_EQ(transceiver, transceivers[0]); |
| 994 | EXPECT_EQ(sender, transceiver->sender()); |
| 995 | EXPECT_EQ(audio_track, sender->track()); |
| 996 | } |
| 997 | |
| 998 | // Test that adding two tracks to a new PeerConnection creates two |
| 999 | // RtpTransceivers in the same order. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1000 | TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) { |
| 1001 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1002 | |
| 1003 | auto sender1 = caller->AddAudioTrack("a"); |
| 1004 | auto sender2 = caller->AddVideoTrack("v"); |
| 1005 | ASSERT_TRUE(sender2); |
| 1006 | |
| 1007 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1008 | ASSERT_EQ(2u, transceivers.size()); |
| 1009 | EXPECT_EQ(sender1, transceivers[0]->sender()); |
| 1010 | EXPECT_EQ(sender2, transceivers[1]->sender()); |
| 1011 | } |
| 1012 | |
| 1013 | // Test that if there are multiple transceivers with no sending track then a |
| 1014 | // later call to AddTrack will use the one of the same type as the newly-added |
| 1015 | // track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1016 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) { |
| 1017 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1018 | |
| 1019 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1020 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 1021 | auto sender = caller->AddVideoTrack("v"); |
| 1022 | |
| 1023 | ASSERT_EQ(2u, caller->pc()->GetTransceivers().size()); |
| 1024 | EXPECT_NE(sender, audio_transceiver->sender()); |
| 1025 | EXPECT_EQ(sender, video_transceiver->sender()); |
| 1026 | } |
| 1027 | |
| 1028 | // Test that if the only transceivers that do not have a sending track have a |
| 1029 | // different type from the added track, then AddTrack will create a new |
| 1030 | // transceiver for the track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1031 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1032 | AddTrackDoesNotReuseTransceiverOfWrongType) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1033 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1034 | |
| 1035 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1036 | auto sender = caller->AddVideoTrack("v"); |
| 1037 | |
| 1038 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1039 | ASSERT_EQ(2u, transceivers.size()); |
| 1040 | EXPECT_NE(sender, transceivers[0]->sender()); |
| 1041 | EXPECT_EQ(sender, transceivers[1]->sender()); |
| 1042 | } |
| 1043 | |
| 1044 | // Test that the first available transceiver is reused by AddTrack when multiple |
| 1045 | // are available. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1046 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1047 | AddTrackReusesFirstMatchingTransceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1048 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1049 | |
| 1050 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1051 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1052 | auto sender = caller->AddAudioTrack("a"); |
| 1053 | |
| 1054 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1055 | ASSERT_EQ(2u, transceivers.size()); |
| 1056 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 1057 | EXPECT_NE(sender, transceivers[1]->sender()); |
| 1058 | } |
| 1059 | |
| 1060 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 1061 | // direction from inactive to sendonly. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1062 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1063 | AddTrackChangesDirectionFromInactiveToSendOnly) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1064 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1065 | |
| 1066 | RtpTransceiverInit init; |
| 1067 | init.direction = RtpTransceiverDirection::kInactive; |
| 1068 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 1069 | |
| 1070 | caller->observer()->clear_negotiation_needed(); |
| 1071 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 1072 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1073 | |
| 1074 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 1075 | } |
| 1076 | |
| 1077 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 1078 | // direction from recvonly to sendrecv. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1079 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1080 | AddTrackChangesDirectionFromRecvOnlyToSendRecv) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1081 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1082 | |
| 1083 | RtpTransceiverInit init; |
| 1084 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 1085 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 1086 | |
| 1087 | caller->observer()->clear_negotiation_needed(); |
| 1088 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 1089 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1090 | |
| 1091 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 1092 | } |
| 1093 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1094 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) { |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 1095 | const std::string kTrackId = "audio_track"; |
| 1096 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1097 | auto caller = CreatePeerConnection(); |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 1098 | |
| 1099 | auto audio_track = caller->CreateAudioTrack(kTrackId); |
| 1100 | auto sender = caller->AddTrack(audio_track); |
| 1101 | |
| 1102 | EXPECT_EQ(kTrackId, sender->id()); |
| 1103 | } |
| 1104 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1105 | // Unified Plan AddTrack error handling. |
| 1106 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1107 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) { |
| 1108 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1109 | |
| 1110 | auto audio_track = caller->CreateAudioTrack("a"); |
| 1111 | caller->pc()->Close(); |
| 1112 | |
| 1113 | caller->observer()->clear_negotiation_needed(); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1114 | auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>()); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1115 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1116 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1117 | } |
| 1118 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1119 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) { |
| 1120 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1121 | |
| 1122 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1123 | ASSERT_TRUE(caller->AddTrack(audio_track)); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1124 | |
| 1125 | caller->observer()->clear_negotiation_needed(); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1126 | auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>()); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1127 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1128 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1129 | } |
| 1130 | |
| 1131 | // Unified Plan RemoveTrack tests. |
| 1132 | |
| 1133 | // Test that calling RemoveTrack on a sender with a previously-added track |
| 1134 | // clears the sender's track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1135 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) { |
| 1136 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1137 | |
| 1138 | auto sender = caller->AddAudioTrack("a"); |
| 1139 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1140 | |
| 1141 | EXPECT_FALSE(sender->track()); |
| 1142 | } |
| 1143 | |
| 1144 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 1145 | // in the sendrecv direction changes the transceiver's direction to recvonly. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1146 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1147 | RemoveTrackChangesDirectionFromSendRecvToRecvOnly) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1148 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1149 | |
| 1150 | RtpTransceiverInit init; |
| 1151 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 1152 | auto transceiver = |
| 1153 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 1154 | |
| 1155 | caller->observer()->clear_negotiation_needed(); |
| 1156 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 1157 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1158 | |
| 1159 | EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction()); |
| 1160 | EXPECT_TRUE(caller->observer()->renegotiation_needed_); |
| 1161 | } |
| 1162 | |
| 1163 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 1164 | // in the sendonly direction changes the transceiver's direction to inactive. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1165 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1166 | RemoveTrackChangesDirectionFromSendOnlyToInactive) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1167 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1168 | |
| 1169 | RtpTransceiverInit init; |
| 1170 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 1171 | auto transceiver = |
| 1172 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 1173 | |
| 1174 | caller->observer()->clear_negotiation_needed(); |
| 1175 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 1176 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1177 | |
| 1178 | EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction()); |
| 1179 | } |
| 1180 | |
| 1181 | // Test that calling RemoveTrack with a sender that has a null track results in |
| 1182 | // no change in state. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1183 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) { |
| 1184 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1185 | |
| 1186 | auto sender = caller->AddAudioTrack("a"); |
| 1187 | auto transceiver = caller->pc()->GetTransceivers()[0]; |
| 1188 | ASSERT_TRUE(sender->SetTrack(nullptr)); |
| 1189 | |
| 1190 | caller->observer()->clear_negotiation_needed(); |
| 1191 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1192 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1193 | |
| 1194 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 1195 | } |
| 1196 | |
| 1197 | // Unified Plan RemoveTrack error handling. |
| 1198 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1199 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) { |
| 1200 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1201 | |
| 1202 | auto sender = caller->AddAudioTrack("a"); |
| 1203 | caller->pc()->Close(); |
| 1204 | |
| 1205 | caller->observer()->clear_negotiation_needed(); |
| 1206 | EXPECT_FALSE(caller->pc()->RemoveTrack(sender)); |
| 1207 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1208 | } |
| 1209 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1210 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1211 | RemoveTrackNoErrorIfTrackAlreadyRemoved) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1212 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1213 | |
| 1214 | auto sender = caller->AddAudioTrack("a"); |
| 1215 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1216 | |
| 1217 | caller->observer()->clear_negotiation_needed(); |
| 1218 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1219 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1220 | } |
| 1221 | |
Steve Anton | 60b6c1d | 2018-06-13 11:32:27 -0700 | [diff] [blame] | 1222 | // Test that setting offers that add/remove/add a track repeatedly without |
| 1223 | // setting the appropriate answer in between works. |
| 1224 | // These are regression tests for bugs.webrtc.org/9401 |
| 1225 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) { |
| 1226 | auto caller = CreatePeerConnection(); |
| 1227 | |
| 1228 | auto sender1 = caller->AddAudioTrack("audio1"); |
| 1229 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1230 | |
| 1231 | caller->pc()->RemoveTrack(sender1); |
| 1232 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1233 | |
| 1234 | // This will re-use the transceiver created by the first AddTrack. |
| 1235 | auto sender2 = caller->AddAudioTrack("audio2"); |
| 1236 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1237 | |
| 1238 | EXPECT_EQ(1u, caller->pc()->GetTransceivers().size()); |
| 1239 | EXPECT_EQ(sender1, sender2); |
| 1240 | } |
| 1241 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) { |
| 1242 | auto caller = CreatePeerConnection(); |
| 1243 | |
| 1244 | auto sender1 = caller->AddVideoTrack("video1"); |
| 1245 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1246 | |
| 1247 | caller->pc()->RemoveTrack(sender1); |
| 1248 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1249 | |
| 1250 | // This will re-use the transceiver created by the first AddTrack. |
| 1251 | auto sender2 = caller->AddVideoTrack("video2"); |
| 1252 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1253 | |
| 1254 | EXPECT_EQ(1u, caller->pc()->GetTransceivers().size()); |
| 1255 | EXPECT_EQ(sender1, sender2); |
| 1256 | } |
| 1257 | |
Steve Anton | 0756373 | 2018-06-26 11:13:50 -0700 | [diff] [blame] | 1258 | // Test that CreateOffer succeeds if two tracks with the same label are added. |
| 1259 | TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) { |
| 1260 | auto caller = CreatePeerConnection(); |
| 1261 | |
| 1262 | auto audio_sender = caller->AddAudioTrack("track", {}); |
| 1263 | auto video_sender = caller->AddVideoTrack("track", {}); |
| 1264 | |
| 1265 | EXPECT_TRUE(caller->CreateOffer()); |
| 1266 | |
| 1267 | EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id()); |
| 1268 | EXPECT_NE(audio_sender->id(), video_sender->id()); |
| 1269 | } |
| 1270 | |
| 1271 | // Test that CreateAnswer succeeds if two tracks with the same label are added. |
| 1272 | TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) { |
| 1273 | auto caller = CreatePeerConnection(); |
| 1274 | auto callee = CreatePeerConnection(); |
| 1275 | |
| 1276 | RtpTransceiverInit recvonly; |
| 1277 | recvonly.direction = RtpTransceiverDirection::kRecvOnly; |
| 1278 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly); |
| 1279 | caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly); |
| 1280 | |
| 1281 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1282 | |
| 1283 | auto audio_sender = callee->AddAudioTrack("track", {}); |
| 1284 | auto video_sender = callee->AddVideoTrack("track", {}); |
| 1285 | |
| 1286 | EXPECT_TRUE(callee->CreateAnswer()); |
| 1287 | |
| 1288 | EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id()); |
| 1289 | EXPECT_NE(audio_sender->id(), video_sender->id()); |
| 1290 | } |
| 1291 | |
| 1292 | // Test that calling AddTrack, RemoveTrack and AddTrack again creates a second |
| 1293 | // m= section with a random sender id (different from the first, now rejected, |
| 1294 | // m= section). |
| 1295 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1296 | AddRemoveAddTrackGeneratesNewSenderId) { |
| 1297 | auto caller = CreatePeerConnection(); |
| 1298 | auto callee = CreatePeerConnection(); |
| 1299 | |
| 1300 | auto track = caller->CreateVideoTrack("video"); |
| 1301 | auto sender1 = caller->AddTrack(track); |
| 1302 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1303 | |
| 1304 | caller->pc()->RemoveTrack(sender1); |
| 1305 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1306 | |
| 1307 | auto sender2 = caller->AddTrack(track); |
| 1308 | |
| 1309 | EXPECT_NE(sender1, sender2); |
| 1310 | EXPECT_NE(sender1->id(), sender2->id()); |
| 1311 | std::string sender2_id = sender2->id(); |
| 1312 | |
| 1313 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1314 | |
| 1315 | // The sender's ID should not change after negotiation. |
| 1316 | EXPECT_EQ(sender2_id, sender2->id()); |
| 1317 | } |
| 1318 | |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1319 | // Test that OnRenegotiationNeeded is fired if SetDirection is called on an |
| 1320 | // active RtpTransceiver with a new direction. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1321 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1322 | RenegotiationNeededAfterTransceiverSetDirection) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1323 | auto caller = CreatePeerConnection(); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1324 | |
| 1325 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1326 | |
| 1327 | caller->observer()->clear_negotiation_needed(); |
| 1328 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 1329 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1330 | } |
| 1331 | |
| 1332 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on an |
| 1333 | // active RtpTransceiver with current direction. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1334 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1335 | NoRenegotiationNeededAfterTransceiverSetSameDirection) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1336 | auto caller = CreatePeerConnection(); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1337 | |
| 1338 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1339 | |
| 1340 | caller->observer()->clear_negotiation_needed(); |
| 1341 | transceiver->SetDirection(transceiver->direction()); |
| 1342 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1343 | } |
| 1344 | |
| 1345 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on a |
| 1346 | // stopped RtpTransceiver. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1347 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1348 | NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1349 | auto caller = CreatePeerConnection(); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1350 | |
| 1351 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1352 | transceiver->Stop(); |
| 1353 | |
| 1354 | caller->observer()->clear_negotiation_needed(); |
| 1355 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 1356 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1357 | } |
| 1358 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1359 | // Test MSID signaling between Unified Plan and Plan B endpoints. There are two |
| 1360 | // options for this kind of signaling: media section based (a=msid) and ssrc |
| 1361 | // based (a=ssrc MSID). While JSEP only specifies media section MSID signaling, |
| 1362 | // we want to ensure compatibility with older Plan B endpoints that might expect |
| 1363 | // ssrc based MSID signaling. Thus we test here that Unified Plan offers both |
| 1364 | // types but answers with the same type as the offer. |
| 1365 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1366 | class PeerConnectionMsidSignalingTest |
| 1367 | : public PeerConnectionRtpTestUnifiedPlan {}; |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1368 | |
| 1369 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) { |
| 1370 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1371 | caller->AddAudioTrack("caller_audio"); |
| 1372 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1373 | callee->AddAudioTrack("callee_audio"); |
| 1374 | |
| 1375 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1376 | |
| 1377 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1378 | auto* offer = callee->pc()->remote_description(); |
| 1379 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1380 | cricket::kMsidSignalingSsrcAttribute), |
| 1381 | offer->description()->msid_signaling()); |
| 1382 | |
| 1383 | // Answer should have had only a=msid lines. |
| 1384 | auto* answer = caller->pc()->remote_description(); |
| 1385 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1386 | answer->description()->msid_signaling()); |
Harald Alvestrand | 5dbb586 | 2018-02-13 23:48:00 +0100 | [diff] [blame] | 1387 | // Check that this is counted correctly |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 1388 | EXPECT_EQ(2, webrtc::metrics::NumSamples( |
| 1389 | "WebRTC.PeerConnection.SdpSemanticNegotiated")); |
| 1390 | EXPECT_EQ(2, webrtc::metrics::NumEvents( |
| 1391 | "WebRTC.PeerConnection.SdpSemanticNegotiated", |
| 1392 | kSdpSemanticNegotiatedUnifiedPlan)); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1393 | } |
| 1394 | |
| 1395 | TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) { |
| 1396 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1397 | caller->AddAudioTrack("caller_audio"); |
| 1398 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1399 | callee->AddAudioTrack("callee_audio"); |
| 1400 | |
| 1401 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1402 | |
| 1403 | // Offer should have only a=ssrc MSID lines. |
| 1404 | auto* offer = callee->pc()->remote_description(); |
| 1405 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1406 | offer->description()->msid_signaling()); |
| 1407 | |
| 1408 | // Answer should have only a=ssrc MSID lines to match the offer. |
| 1409 | auto* answer = caller->pc()->remote_description(); |
| 1410 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1411 | answer->description()->msid_signaling()); |
| 1412 | } |
| 1413 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 1414 | // This tests that a Plan B endpoint appropriately sets the remote description |
| 1415 | // from a Unified Plan offer. When the Unified Plan offer contains a=msid lines |
| 1416 | // that signal no stream ids or multiple stream ids we expect that the Plan B |
| 1417 | // endpoint always has exactly one media stream per track. |
| 1418 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) { |
| 1419 | const std::string kStreamId1 = "audio_stream_1"; |
| 1420 | const std::string kStreamId2 = "audio_stream_2"; |
| 1421 | |
| 1422 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1423 | caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2}); |
| 1424 | caller->AddVideoTrack("caller_video", {}); |
| 1425 | auto callee = CreatePeerConnectionWithPlanB(); |
| 1426 | callee->AddAudioTrack("callee_audio"); |
| 1427 | caller->AddVideoTrack("callee_video"); |
| 1428 | |
| 1429 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1430 | |
| 1431 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1432 | auto* offer = callee->pc()->remote_description(); |
| 1433 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1434 | cricket::kMsidSignalingSsrcAttribute), |
| 1435 | offer->description()->msid_signaling()); |
| 1436 | |
| 1437 | // Callee should always have 1 stream for all of it's receivers. |
| 1438 | const auto& track_events = callee->observer()->add_track_events_; |
| 1439 | ASSERT_EQ(2u, track_events.size()); |
| 1440 | ASSERT_EQ(1u, track_events[0].streams.size()); |
| 1441 | EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id()); |
| 1442 | ASSERT_EQ(1u, track_events[1].streams.size()); |
| 1443 | // This autogenerated a stream id for the empty one signalled. |
| 1444 | EXPECT_FALSE(track_events[1].streams[0]->id().empty()); |
| 1445 | } |
| 1446 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1447 | TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) { |
| 1448 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1449 | caller->AddAudioTrack("caller_audio"); |
| 1450 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1451 | callee->AddAudioTrack("callee_audio"); |
| 1452 | |
| 1453 | auto offer = caller->CreateOffer(); |
| 1454 | // Simulate a pure Unified Plan offerer by setting the MSID signaling to media |
| 1455 | // section only. |
| 1456 | offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection); |
| 1457 | |
| 1458 | ASSERT_TRUE( |
| 1459 | caller->SetLocalDescription(CloneSessionDescription(offer.get()))); |
| 1460 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
| 1461 | |
| 1462 | // Answer should have only a=msid to match the offer. |
| 1463 | auto answer = callee->CreateAnswer(); |
| 1464 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1465 | answer->description()->msid_signaling()); |
| 1466 | } |
| 1467 | |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1468 | // Test that the correct UMA metrics are reported for simple/complex SDP. |
| 1469 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1470 | class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {}; |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1471 | |
| 1472 | #ifdef HAVE_SCTP |
| 1473 | TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) { |
| 1474 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1475 | caller->CreateDataChannel("dc"); |
| 1476 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1477 | |
| 1478 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 1479 | // Note that only the callee does ReportSdpFormatReceived. |
| 1480 | EXPECT_EQ(1, webrtc::metrics::NumSamples( |
| 1481 | "WebRTC.PeerConnection.SdpFormatReceived")); |
| 1482 | EXPECT_EQ( |
| 1483 | 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived", |
| 1484 | kSdpFormatReceivedNoTracks)); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1485 | } |
| 1486 | #endif // HAVE_SCTP |
| 1487 | |
| 1488 | TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) { |
| 1489 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1490 | caller->AddAudioTrack("audio"); |
| 1491 | caller->AddVideoTrack("video"); |
| 1492 | auto callee = CreatePeerConnectionWithPlanB(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1493 | |
| 1494 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 1495 | // Note that only the callee does ReportSdpFormatReceived. |
| 1496 | EXPECT_EQ(1, webrtc::metrics::NumSamples( |
| 1497 | "WebRTC.PeerConnection.SdpFormatReceived")); |
| 1498 | EXPECT_EQ( |
| 1499 | 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived", |
| 1500 | kSdpFormatReceivedSimple)); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1501 | } |
| 1502 | |
| 1503 | TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) { |
| 1504 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1505 | caller->AddVideoTrack("video"); // Video only. |
| 1506 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1507 | |
| 1508 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1509 | |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 1510 | EXPECT_EQ(1, webrtc::metrics::NumSamples( |
| 1511 | "WebRTC.PeerConnection.SdpFormatReceived")); |
| 1512 | EXPECT_EQ( |
| 1513 | 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived", |
| 1514 | kSdpFormatReceivedSimple)); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1515 | } |
| 1516 | |
| 1517 | TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) { |
| 1518 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1519 | caller->AddAudioTrack("audio1"); |
| 1520 | caller->AddAudioTrack("audio2"); |
| 1521 | caller->AddVideoTrack("video"); |
| 1522 | auto callee = CreatePeerConnectionWithPlanB(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1523 | |
| 1524 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 1525 | // Note that only the callee does ReportSdpFormatReceived. |
| 1526 | EXPECT_EQ(1, webrtc::metrics::NumSamples( |
| 1527 | "WebRTC.PeerConnection.SdpFormatReceived")); |
| 1528 | EXPECT_EQ( |
| 1529 | 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived", |
| 1530 | kSdpFormatReceivedComplexUnifiedPlan)); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1531 | } |
| 1532 | |
| 1533 | TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) { |
| 1534 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1535 | caller->AddVideoTrack("video1"); |
| 1536 | caller->AddVideoTrack("video2"); |
| 1537 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1538 | |
Steve Anton | ba42e99 | 2018-04-09 14:10:01 -0700 | [diff] [blame] | 1539 | // This fails since Unified Plan cannot set a session description with |
| 1540 | // multiple "Plan B tracks" in the same media section. But we still expect the |
| 1541 | // SDP Format to be recorded. |
| 1542 | ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame^] | 1543 | // Note that only the callee does ReportSdpFormatReceived. |
| 1544 | EXPECT_EQ(1, webrtc::metrics::NumSamples( |
| 1545 | "WebRTC.PeerConnection.SdpFormatReceived")); |
| 1546 | EXPECT_EQ( |
| 1547 | 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived", |
| 1548 | kSdpFormatReceivedComplexPlanB)); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1549 | } |
| 1550 | |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1551 | // Sender setups in a call. |
| 1552 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1553 | TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) { |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1554 | auto caller = CreatePeerConnection(); |
| 1555 | auto callee = CreatePeerConnection(); |
| 1556 | |
| 1557 | auto track = caller->CreateAudioTrack("audio_track"); |
| 1558 | auto sender1 = caller->AddTrack(track); |
| 1559 | ASSERT_TRUE(sender1); |
| 1560 | // We need to temporarily reset the track for the subsequent AddTrack() to |
| 1561 | // succeed. |
| 1562 | EXPECT_TRUE(sender1->SetTrack(nullptr)); |
| 1563 | auto sender2 = caller->AddTrack(track); |
| 1564 | EXPECT_TRUE(sender2); |
| 1565 | EXPECT_TRUE(sender1->SetTrack(track)); |
| 1566 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1567 | if (sdp_semantics_ == SdpSemantics::kPlanB) { |
| 1568 | // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should |
| 1569 | // return true, and doing |callee->SetRemoteDescription()| should work. |
| 1570 | EXPECT_FALSE(caller->CreateOfferAndSetAsLocal()); |
| 1571 | } else { |
| 1572 | EXPECT_TRUE(caller->CreateOfferAndSetAsLocal()); |
| 1573 | } |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1574 | } |
| 1575 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1576 | INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest, |
| 1577 | PeerConnectionRtpTest, |
| 1578 | Values(SdpSemantics::kPlanB, |
| 1579 | SdpSemantics::kUnifiedPlan)); |
| 1580 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1581 | } // namespace webrtc |