blob: 093b85e5ed4cd4cb39d22c9f9a311fa7cc86c4d3 [file] [log] [blame]
Fyodor Kupolov74876572015-02-23 17:14:45 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License
15 */
16
17package com.android.server.pm;
18
Patrick Baumannfc2851e2018-11-13 15:23:22 -080019import static android.content.pm.ApplicationInfo.HIDDEN_API_ENFORCEMENT_DISABLED;
20
21import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE;
22import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE;
23import static com.android.server.pm.Installer.DEXOPT_ENABLE_HIDDEN_API_CHECKS;
24import static com.android.server.pm.Installer.DEXOPT_FORCE;
25import static com.android.server.pm.Installer.DEXOPT_GENERATE_APP_IMAGE;
26import static com.android.server.pm.Installer.DEXOPT_GENERATE_COMPACT_DEX;
27import static com.android.server.pm.Installer.DEXOPT_IDLE_BACKGROUND_JOB;
28import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED;
29import static com.android.server.pm.Installer.DEXOPT_PUBLIC;
30import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX;
31import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE;
32import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE;
33import static com.android.server.pm.InstructionSets.getAppDexInstructionSets;
34import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets;
35import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT;
36import static com.android.server.pm.PackageManagerServiceCompilerMapping.getReasonName;
37
38import static dalvik.system.DexFile.getSafeModeCompilerFilter;
39import static dalvik.system.DexFile.isProfileGuidedCompilerFilter;
40
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080041import android.annotation.Nullable;
Fyodor Kupolova627c092015-05-05 18:44:39 -070042import android.content.Context;
Fyodor Kupolov74876572015-02-23 17:14:45 -080043import android.content.pm.ApplicationInfo;
44import android.content.pm.PackageParser;
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +000045import android.content.pm.SharedLibraryInfo;
Calin Juravle6ae39fc2018-01-19 20:32:47 -080046import android.content.pm.dex.ArtManager;
Calin Juravlecc651942018-02-01 17:20:51 +000047import android.content.pm.dex.DexMetadataHelper;
Calin Juravleadbadd52017-03-28 18:19:15 -070048import android.os.FileUtils;
Fyodor Kupolova627c092015-05-05 18:44:39 -070049import android.os.PowerManager;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070050import android.os.SystemClock;
Nicolas Geoffray20a894e2017-09-08 13:01:40 +010051import android.os.SystemProperties;
Fyodor Kupolov74876572015-02-23 17:14:45 -080052import android.os.UserHandle;
Fyodor Kupolova627c092015-05-05 18:44:39 -070053import android.os.WorkSource;
Fyodor Kupolov74876572015-02-23 17:14:45 -080054import android.util.Log;
55import android.util.Slog;
56
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080057import com.android.internal.annotations.GuardedBy;
Narayan Kamath88eea9e2016-05-02 14:44:31 +010058import com.android.internal.util.IndentingPrintWriter;
Jeff Sharkey740f5232016-12-09 14:31:26 -070059import com.android.server.pm.Installer.InstallerException;
Calin Juravle0610dd12018-07-20 15:51:17 -070060import com.android.server.pm.dex.ArtManagerService;
Victor Hsieh785d6182018-04-19 14:26:28 -070061import com.android.server.pm.dex.DexManager;
Calin Juravle1d0e83d2017-07-17 15:12:01 -070062import com.android.server.pm.dex.DexoptOptions;
Calin Juravle19da1cf2017-07-12 18:52:49 -070063import com.android.server.pm.dex.DexoptUtils;
Calin Juravlef1ff36f2017-07-22 12:33:41 -070064import com.android.server.pm.dex.PackageDexUsage;
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -070065
Patrick Baumannfc2851e2018-11-13 15:23:22 -080066import dalvik.system.DexFile;
67
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080068import java.io.File;
Fyodor Kupolov74876572015-02-23 17:14:45 -080069import java.io.IOException;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080070import java.util.ArrayList;
Calin Juravle4c2b9552017-08-10 17:23:00 -070071import java.util.Arrays;
Fyodor Kupolov74876572015-02-23 17:14:45 -080072import java.util.List;
Calin Juravle41a57a62017-08-06 19:20:19 -070073import java.util.Map;
Fyodor Kupolov74876572015-02-23 17:14:45 -080074
Fyodor Kupolov74876572015-02-23 17:14:45 -080075/**
76 * Helper class for running dexopt command on packages.
77 */
Calin Juravlec22c30e2017-01-16 19:18:48 -080078public class PackageDexOptimizer {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080079 private static final String TAG = "PackageManager.DexOptimizer";
80 static final String OAT_DIR_NAME = "oat";
81 // TODO b/19550105 Remove error codes and use exceptions
Calin Juravlec22c30e2017-01-16 19:18:48 -080082 public static final int DEX_OPT_SKIPPED = 0;
83 public static final int DEX_OPT_PERFORMED = 1;
84 public static final int DEX_OPT_FAILED = -1;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070085 // One minute over PM WATCHDOG_TIMEOUT
86 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60;
Fyodor Kupolov74876572015-02-23 17:14:45 -080087
Calin Juravleaae35762017-02-14 17:53:13 -080088 /** Special library name that skips shared libraries check during compilation. */
89 public static final String SKIP_SHARED_LIBRARY_CHECK = "&";
90
Fyodor Kupolov28f28552017-05-02 12:11:02 -070091 @GuardedBy("mInstallLock")
Andreas Gampea8908752015-11-10 08:58:14 -080092 private final Installer mInstaller;
93 private final Object mInstallLock;
Fyodor Kupolov74876572015-02-23 17:14:45 -080094
Fyodor Kupolov28f28552017-05-02 12:11:02 -070095 @GuardedBy("mInstallLock")
Fyodor Kupolova627c092015-05-05 18:44:39 -070096 private final PowerManager.WakeLock mDexoptWakeLock;
97 private volatile boolean mSystemReady;
98
Andreas Gampea8908752015-11-10 08:58:14 -080099 PackageDexOptimizer(Installer installer, Object installLock, Context context,
100 String wakeLockTag) {
101 this.mInstaller = installer;
102 this.mInstallLock = installLock;
103
104 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE);
105 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag);
106 }
107
108 protected PackageDexOptimizer(PackageDexOptimizer from) {
109 this.mInstaller = from.mInstaller;
110 this.mInstallLock = from.mInstallLock;
111 this.mDexoptWakeLock = from.mDexoptWakeLock;
112 this.mSystemReady = from.mSystemReady;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800113 }
114
Calin Juravledb4a79a2015-12-23 18:55:08 +0200115 static boolean canOptimizePackage(PackageParser.Package pkg) {
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100116 // We do not dexopt a package with no code.
117 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) {
118 return false;
119 }
120
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100121 return true;
Calin Juravledb4a79a2015-12-23 18:55:08 +0200122 }
123
Fyodor Kupolov74876572015-02-23 17:14:45 -0800124 /**
125 * Performs dexopt on all code paths and libraries of the specified package for specified
126 * instruction sets.
127 *
Andreas Gampea8908752015-11-10 08:58:14 -0800128 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are
129 * synchronized on {@link #mInstallLock}.
Fyodor Kupolov74876572015-02-23 17:14:45 -0800130 */
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +0000131 int performDexOpt(PackageParser.Package pkg, List<SharedLibraryInfo> sharedLibraries,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700132 String[] instructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700133 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800134 if (pkg.applicationInfo.uid == -1) {
135 throw new IllegalArgumentException("Dexopt for " + pkg.packageName
136 + " has invalid uid.");
137 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800138 if (!canOptimizePackage(pkg)) {
139 return DEX_OPT_SKIPPED;
140 }
Andreas Gampea8908752015-11-10 08:58:14 -0800141 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700142 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700143 try {
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700144 return performDexOptLI(pkg, sharedLibraries, instructionSets,
Calin Juravle3b74c412017-08-03 19:48:37 -0700145 packageStats, packageUseInfo, options);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700146 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700147 releaseWakeLockLI(acquireTime);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700148 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800149 }
150 }
151
Andreas Gampea8908752015-11-10 08:58:14 -0800152 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800153 * Performs dexopt on all code paths of the given package.
154 * It assumes the install lock is held.
155 */
156 @GuardedBy("mInstallLock")
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +0000157 private int performDexOptLI(PackageParser.Package pkg,
158 List<SharedLibraryInfo> sharedLibraries,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700159 String[] targetInstructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700160 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800161 final String[] instructionSets = targetInstructionSets != null ?
162 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo);
163 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
Jeff Hao5def5e52017-04-19 14:42:16 -0700164 final List<String> paths = pkg.getAllCodePaths();
Jeff Sharkeya73e1652017-11-15 19:07:14 -0700165
166 int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid);
167 if (sharedGid == -1) {
168 Slog.wtf(TAG, "Well this is awkward; package " + pkg.applicationInfo.name + " had UID "
169 + pkg.applicationInfo.uid, new Throwable());
170 sharedGid = android.os.Process.NOBODY_UID;
171 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800172
Calin Juravle19da1cf2017-07-12 18:52:49 -0700173 // Get the class loader context dependencies.
174 // For each code path in the package, this array contains the class loader context that
175 // needs to be passed to dexopt in order to ensure correct optimizations.
Calin Juravleda098152017-09-01 17:30:01 -0700176 boolean[] pathsWithCode = new boolean[paths.size()];
177 pathsWithCode[0] = (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) != 0;
178 for (int i = 1; i < paths.size(); i++) {
179 pathsWithCode[i] = (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) != 0;
180 }
Calin Juravle19da1cf2017-07-12 18:52:49 -0700181 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts(
Calin Juravleda098152017-09-01 17:30:01 -0700182 pkg.applicationInfo, sharedLibraries, pathsWithCode);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800183
Calin Juravle4c2b9552017-08-10 17:23:00 -0700184 // Sanity check that we do not call dexopt with inconsistent data.
185 if (paths.size() != classLoaderContexts.length) {
186 String[] splitCodePaths = pkg.applicationInfo.getSplitCodePaths();
187 throw new IllegalStateException("Inconsistent information "
188 + "between PackageParser.Package and its ApplicationInfo. "
189 + "pkg.getAllCodePaths=" + paths
190 + " pkg.applicationInfo.getBaseCodePath=" + pkg.applicationInfo.getBaseCodePath()
191 + " pkg.applicationInfo.getSplitCodePaths="
192 + (splitCodePaths == null ? "null" : Arrays.toString(splitCodePaths)));
193 }
194
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800195 int result = DEX_OPT_SKIPPED;
Jeff Hao5def5e52017-04-19 14:42:16 -0700196 for (int i = 0; i < paths.size(); i++) {
197 // Skip paths that have no code.
Calin Juravleda098152017-09-01 17:30:01 -0700198 if (!pathsWithCode[i]) {
Jeff Hao5def5e52017-04-19 14:42:16 -0700199 continue;
200 }
Calin Juravleda098152017-09-01 17:30:01 -0700201 if (classLoaderContexts[i] == null) {
202 throw new IllegalStateException("Inconsistent information in the "
203 + "package structure. A split is marked to contain code "
204 + "but has no dependency listed. Index=" + i + " path=" + paths.get(i));
205 }
206
Jeff Hao5def5e52017-04-19 14:42:16 -0700207 // Append shared libraries with split dependencies for this split.
208 String path = paths.get(i);
Calin Juravleb6f844d2017-07-17 15:23:21 -0700209 if (options.getSplitName() != null) {
210 // We are asked to compile only a specific split. Check that the current path is
211 // what we are looking for.
212 if (!options.getSplitName().equals(new File(path).getName())) {
213 continue;
214 }
215 }
216
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800217 String profileName = ArtManager.getProfileName(i == 0 ? null : pkg.splitNames[i - 1]);
218
Calin Juravlecc651942018-02-01 17:20:51 +0000219 String dexMetadataPath = null;
220 if (options.isDexoptInstallWithDexMetadata()) {
221 File dexMetadataFile = DexMetadataHelper.findDexMetadataForFile(new File(path));
222 dexMetadataPath = dexMetadataFile == null
223 ? null : dexMetadataFile.getAbsolutePath();
224 }
225
Calin Juravle3b74c412017-08-03 19:48:37 -0700226 final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary()
Calin Juravle52a452c2017-08-04 01:42:17 -0700227 || packageUseInfo.isUsedByOtherApps(path);
Calin Juravle3b74c412017-08-03 19:48:37 -0700228 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo,
229 options.getCompilerFilter(), isUsedByOtherApps);
230 final boolean profileUpdated = options.isCheckForProfileUpdates() &&
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800231 isProfileUpdated(pkg, sharedGid, profileName, compilerFilter);
Calin Juravle3b74c412017-08-03 19:48:37 -0700232
233 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct
234 // flags.
Andreas Gampec041c332017-11-01 17:05:53 -0700235 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options);
Calin Juravle3b74c412017-08-03 19:48:37 -0700236
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800237 for (String dexCodeIsa : dexCodeInstructionSets) {
Calin Juravle19da1cf2017-07-12 18:52:49 -0700238 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter,
239 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800240 packageStats, options.isDowngrade(), profileName, dexMetadataPath,
241 options.getCompilationReason());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800242 // The end result is:
243 // - FAILED if any path failed,
244 // - PERFORMED if at least one path needed compilation,
245 // - SKIPPED when all paths are up to date
246 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) {
247 result = newResult;
248 }
249 }
250 }
251 return result;
252 }
253
254 /**
255 * Performs dexopt on the {@code path} belonging to the package {@code pkg}.
256 *
257 * @return
258 * DEX_OPT_FAILED if there was any exception during dexopt
259 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
260 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed.
261 */
262 @GuardedBy("mInstallLock")
263 private int dexOptPath(PackageParser.Package pkg, String path, String isa,
Calin Juravle576e6c02017-09-12 00:58:33 -0700264 String compilerFilter, boolean profileUpdated, String classLoaderContext,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800265 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800266 String profileName, String dexMetadataPath, int compilationReason) {
Calin Juravle576e6c02017-09-12 00:58:33 -0700267 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext,
268 profileUpdated, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800269 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) {
270 return DEX_OPT_SKIPPED;
271 }
272
273 // TODO(calin): there's no need to try to create the oat dir over and over again,
274 // especially since it involve an extra installd call. We should create
275 // if (if supported) on the fly during the dexopt call.
276 String oatDir = createOatDirIfSupported(pkg, isa);
277
278 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path
279 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa
280 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
Calin Juravle576e6c02017-09-12 00:58:33 -0700281 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir
282 + " classLoaderContext=" + classLoaderContext);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800283
284 try {
285 long startTime = System.currentTimeMillis();
286
Shubham Ajmera246dccf2017-05-24 17:46:36 -0700287 // TODO: Consider adding 2 different APIs for primary and secondary dexopt.
288 // installd only uses downgrade flag for secondary dex files and ignores it for
289 // primary dex files.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800290 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags,
Calin Juravle576e6c02017-09-12 00:58:33 -0700291 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800292 false /* downgrade*/, pkg.applicationInfo.targetSdkVersion,
Calin Juravle0610dd12018-07-20 15:51:17 -0700293 profileName, dexMetadataPath,
294 getAugmentedReasonName(compilationReason, dexMetadataPath != null));
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800295
296 if (packageStats != null) {
297 long endTime = System.currentTimeMillis();
298 packageStats.setCompileTime(path, (int)(endTime - startTime));
299 }
300 return DEX_OPT_PERFORMED;
301 } catch (InstallerException e) {
302 Slog.w(TAG, "Failed to dexopt", e);
303 return DEX_OPT_FAILED;
304 }
305 }
306
Calin Juravle0610dd12018-07-20 15:51:17 -0700307 private String getAugmentedReasonName(int compilationReason, boolean useDexMetadata) {
308 String annotation = useDexMetadata
309 ? ArtManagerService.DEXOPT_REASON_WITH_DEX_METADATA_ANNOTATION : "";
310 return getReasonName(compilationReason) + annotation;
311 }
312
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800313 /**
Calin Juravlec22c30e2017-01-16 19:18:48 -0800314 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}.
315 *
316 * @return
317 * DEX_OPT_FAILED if there was any exception during dexopt
318 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
319 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file
320 * didn't need an update. That's because at the moment we don't get more than success/failure
321 * from installd.
322 *
323 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than
324 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though
325 * that seems wasteful.
326 */
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700327 public int dexOptSecondaryDexPath(ApplicationInfo info, String path,
328 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800329 if (info.uid == -1) {
330 throw new IllegalArgumentException("Dexopt for path " + path + " has invalid uid.");
331 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800332 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700333 final long acquireTime = acquireWakeLockLI(info.uid);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800334 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700335 return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800336 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700337 releaseWakeLockLI(acquireTime);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800338 }
339 }
340 }
341
342 @GuardedBy("mInstallLock")
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700343 private long acquireWakeLockLI(final int uid) {
344 // During boot the system doesn't need to instantiate and obtain a wake lock.
345 // PowerManager might not be ready, but that doesn't mean that we can't proceed with
346 // dexopt.
347 if (!mSystemReady) {
348 return -1;
349 }
350 mDexoptWakeLock.setWorkSource(new WorkSource(uid));
351 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS);
352 return SystemClock.elapsedRealtime();
353 }
354
355 @GuardedBy("mInstallLock")
356 private void releaseWakeLockLI(final long acquireTime) {
357 if (acquireTime < 0) {
358 return;
359 }
360 try {
361 if (mDexoptWakeLock.isHeld()) {
362 mDexoptWakeLock.release();
363 }
364 final long duration = SystemClock.elapsedRealtime() - acquireTime;
365 if (duration >= WAKELOCK_TIMEOUT_MS) {
366 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag()
367 + " time out. Operation took " + duration + " ms. Thread: "
368 + Thread.currentThread().getName());
369 }
370 } catch (Exception e) {
371 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e);
372 }
373 }
374
375 @GuardedBy("mInstallLock")
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700376 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path,
377 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
378 if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) {
379 // We are asked to optimize only the dex files used by other apps and this is not
380 // on of them: skip it.
381 return DEX_OPT_SKIPPED;
382 }
383
384 String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(),
385 dexUseInfo.isUsedByOtherApps());
Calin Juravleefb1c942017-04-04 20:31:44 -0700386 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags.
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100387 // Secondary dex files are currently not compiled at boot.
Andreas Gampec041c332017-11-01 17:05:53 -0700388 int dexoptFlags = getDexFlags(info, compilerFilter, options) | DEXOPT_SECONDARY_DEX;
Calin Juravlec22c30e2017-01-16 19:18:48 -0800389 // Check the app storage and add the appropriate flags.
Calin Juravleadbadd52017-03-28 18:19:15 -0700390 if (info.deviceProtectedDataDir != null &&
391 FileUtils.contains(info.deviceProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800392 dexoptFlags |= DEXOPT_STORAGE_DE;
Calin Juravleadbadd52017-03-28 18:19:15 -0700393 } else if (info.credentialProtectedDataDir != null &&
394 FileUtils.contains(info.credentialProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800395 dexoptFlags |= DEXOPT_STORAGE_CE;
396 } else {
397 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName);
398 return DEX_OPT_FAILED;
399 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800400 Log.d(TAG, "Running dexopt on: " + path
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700401 + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas()
Calin Juravlec22c30e2017-01-16 19:18:48 -0800402 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
403 + " target-filter=" + compilerFilter);
404
Calin Juravle27f92622017-10-04 10:53:09 -0700405 // TODO(calin): b/64530081 b/66984396. Use SKIP_SHARED_LIBRARY_CHECK for the context
406 // (instead of dexUseInfo.getClassLoaderContext()) in order to compile secondary dex files
407 // in isolation (and avoid to extract/verify the main apk if it's in the class path).
408 // Note this trades correctness for performance since the resulting slow down is
409 // unacceptable in some cases until b/64530081 is fixed.
410 String classLoaderContext = SKIP_SHARED_LIBRARY_CHECK;
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800411 int reason = options.getCompilationReason();
Calin Juravlec22c30e2017-01-16 19:18:48 -0800412 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700413 for (String isa : dexUseInfo.getLoaderIsas()) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800414 // Reuse the same dexopt path as for the primary apks. We don't need all the
415 // arguments as some (dexopNeeded and oatDir) will be computed by installd because
416 // system server cannot read untrusted app content.
417 // TODO(calin): maybe add a separate call.
418 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0,
419 /*oatDir*/ null, dexoptFlags,
Nick Kralevich005f9592018-08-14 11:11:02 -0700420 compilerFilter, info.volumeUuid, classLoaderContext, info.seInfo,
Calin Juravlecc651942018-02-01 17:20:51 +0000421 options.isDowngrade(), info.targetSdkVersion, /*profileName*/ null,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800422 /*dexMetadataPath*/ null, getReasonName(reason));
Calin Juravlec22c30e2017-01-16 19:18:48 -0800423 }
424
425 return DEX_OPT_PERFORMED;
426 } catch (InstallerException e) {
427 Slog.w(TAG, "Failed to dexopt", e);
428 return DEX_OPT_FAILED;
429 }
430 }
431
432 /**
Andreas Gampea8908752015-11-10 08:58:14 -0800433 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to
434 * optimize or not (and in what way).
435 */
436 protected int adjustDexoptNeeded(int dexoptNeeded) {
437 return dexoptNeeded;
438 }
439
440 /**
441 * Adjust the given dexopt flags that will be passed to the installer.
442 */
443 protected int adjustDexoptFlags(int dexoptFlags) {
444 return dexoptFlags;
445 }
446
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100447 /**
448 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}.
449 */
Calin Juravle41a57a62017-08-06 19:20:19 -0700450 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg,
451 PackageDexUsage.PackageUseInfo useInfo) {
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100452 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo);
453 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
454
455 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly();
456
Calin Juravle41a57a62017-08-06 19:20:19 -0700457 for (String path : paths) {
458 pw.println("path: " + path);
459 pw.increaseIndent();
460
461 for (String isa : dexCodeInstructionSets) {
Calin Juravle41a57a62017-08-06 19:20:19 -0700462 try {
Calin Juravle7fc0f632018-03-30 12:38:59 -0700463 DexFile.OptimizationInfo info = DexFile.getDexFileOptimizationInfo(path, isa);
464 pw.println(isa + ": [status=" + info.getStatus()
465 +"] [reason=" + info.getReason() + "]");
Calin Juravle41a57a62017-08-06 19:20:19 -0700466 } catch (IOException ioe) {
Calin Juravleab49fc42018-03-28 19:00:18 -0700467 pw.println(isa + ": [Exception]: " + ioe.getMessage());
Calin Juravle41a57a62017-08-06 19:20:19 -0700468 }
Calin Juravle41a57a62017-08-06 19:20:19 -0700469 }
470
471 if (useInfo.isUsedByOtherApps(path)) {
Calin Juravle94837e32017-09-26 13:23:00 -0700472 pw.println("used by other apps: " + useInfo.getLoadingPackages(path));
Calin Juravle41a57a62017-08-06 19:20:19 -0700473 }
474
475 Map<String, PackageDexUsage.DexUseInfo> dexUseInfoMap = useInfo.getDexUseInfoMap();
476
477 if (!dexUseInfoMap.isEmpty()) {
478 pw.println("known secondary dex files:");
479 pw.increaseIndent();
480 for (Map.Entry<String, PackageDexUsage.DexUseInfo> e : dexUseInfoMap.entrySet()) {
481 String dex = e.getKey();
482 PackageDexUsage.DexUseInfo dexUseInfo = e.getValue();
483 pw.println(dex);
484 pw.increaseIndent();
Calin Juravlecf722222017-09-18 17:40:48 -0700485 // TODO(calin): get the status of the oat file (needs installd call)
Calin Juravle41a57a62017-08-06 19:20:19 -0700486 pw.println("class loader context: " + dexUseInfo.getClassLoaderContext());
487 if (dexUseInfo.isUsedByOtherApps()) {
Calin Juravle94837e32017-09-26 13:23:00 -0700488 pw.println("used by other apps: " + dexUseInfo.getLoadingPackages());
Calin Juravle41a57a62017-08-06 19:20:19 -0700489 }
490 pw.decreaseIndent();
491 }
492 pw.decreaseIndent();
493 }
494 pw.decreaseIndent();
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100495 }
496 }
497
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800498 /**
499 * Returns the compiler filter that should be used to optimize the package code.
500 * The target filter will be updated if the package code is used by other apps
501 * or if it has the safe mode flag set.
502 */
Calin Juravlec22c30e2017-01-16 19:18:48 -0800503 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter,
504 boolean isUsedByOtherApps) {
505 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800506 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0;
Victor Hsieh785d6182018-04-19 14:26:28 -0700507 // When a priv app is configured to run out of box, only verify it.
508 if (info.isPrivilegedApp() && DexManager.isPackageSelectedToRunOob(info.packageName)) {
509 return "verify";
Nicolas Geoffray11d21a292018-01-24 14:07:14 +0000510 }
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700511 if (vmSafeMode) {
Nicolas Geoffrayd093b202017-05-03 13:11:58 +0100512 return getSafeModeCompilerFilter(targetCompilerFilter);
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700513 }
514
Calin Juravlec22c30e2017-01-16 19:18:48 -0800515 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) {
Calin Juravlef53201f2017-09-15 11:09:29 -0700516 // If the dex files is used by other apps, apply the shared filter.
517 return PackageManagerServiceCompilerMapping.getCompilerFilterForReason(
518 PackageManagerService.REASON_SHARED);
Andreas Gampebdd30d82016-03-20 11:32:11 -0700519 }
520
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800521 return targetCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800522 }
523
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800524 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800525 * Computes the dex flags that needs to be pass to installd for the given package and compiler
526 * filter.
527 */
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100528 private int getDexFlags(PackageParser.Package pkg, String compilerFilter,
Andreas Gampec041c332017-11-01 17:05:53 -0700529 DexoptOptions options) {
530 return getDexFlags(pkg.applicationInfo, compilerFilter, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800531 }
532
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700533 private boolean isAppImageEnabled() {
534 return SystemProperties.get("dalvik.vm.appimageformat", "").length() > 0;
535 }
536
Andreas Gampec041c332017-11-01 17:05:53 -0700537 private int getDexFlags(ApplicationInfo info, String compilerFilter, DexoptOptions options) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800538 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800539 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
Calin Juravleff3e4a12018-02-01 17:23:13 +0000540 // Profile guide compiled oat files should not be public unles they are based
541 // on profiles from dex metadata archives.
542 // The flag isDexoptInstallWithDexMetadata applies only on installs when we know that
543 // the user does not have an existing profile.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800544 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter);
Patrick Baumannfc2851e2018-11-13 15:23:22 -0800545 boolean isPublic = !isProfileGuidedFilter || options.isDexoptInstallWithDexMetadata();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800546 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0;
David Brazdilf7e31c02018-02-13 17:04:26 +0000547 // Some apps are executed with restrictions on hidden API usage. If this app is one
548 // of them, pass a flag to dexopt to enable the same restrictions during compilation.
Mathew Inwoode3299532018-02-22 13:19:53 +0000549 // TODO we should pass the actual flag value to dexopt, rather than assuming blacklist
David Brazdil06ae4b82018-11-02 18:01:45 +0000550 int hiddenApiFlag = info.getHiddenApiEnforcementPolicy() == HIDDEN_API_ENFORCEMENT_DISABLED
Mathew Inwoode3299532018-02-22 13:19:53 +0000551 ? 0
552 : DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartiera6d43e42018-03-08 13:11:40 -0800553 // Avoid generating CompactDex for modes that are latency critical.
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800554 final int compilationReason = options.getCompilationReason();
555 boolean generateCompactDex = true;
556 switch (compilationReason) {
557 case PackageManagerService.REASON_FIRST_BOOT:
558 case PackageManagerService.REASON_BOOT:
559 case PackageManagerService.REASON_INSTALL:
560 generateCompactDex = false;
561 }
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700562 // Use app images only if it is enabled and we are compiling
563 // profile-guided (so the app image doesn't conservatively contain all classes).
564 // If the app didn't request for the splits to be loaded in isolation or if it does not
565 // declare inter-split dependencies, then all the splits will be loaded in the base
566 // apk class loader (in the order of their definition, otherwise disable app images
567 // because they are unsupported for multiple class loaders. b/7269679
568 boolean generateAppImage = isProfileGuidedFilter && (info.splitDependencies == null ||
569 !info.requestsIsolatedSplitLoading()) && isAppImageEnabled();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800570 int dexFlags =
571 (isPublic ? DEXOPT_PUBLIC : 0)
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800572 | (debuggable ? DEXOPT_DEBUGGABLE : 0)
573 | profileFlag
Andreas Gampec041c332017-11-01 17:05:53 -0700574 | (options.isBootComplete() ? DEXOPT_BOOTCOMPLETE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000575 | (options.isDexoptIdleBackgroundJob() ? DEXOPT_IDLE_BACKGROUND_JOB : 0)
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800576 | (generateCompactDex ? DEXOPT_GENERATE_COMPACT_DEX : 0)
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700577 | (generateAppImage ? DEXOPT_GENERATE_APP_IMAGE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000578 | hiddenApiFlag;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800579 return adjustDexoptFlags(dexFlags);
580 }
581
582 /**
583 * Assesses if there's a need to perform dexopt on {@code path} for the given
584 * configuration (isa, compiler filter, profile).
585 */
586 private int getDexoptNeeded(String path, String isa, String compilerFilter,
Calin Juravle576e6c02017-09-12 00:58:33 -0700587 String classLoaderContext, boolean newProfile, boolean downgrade) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800588 int dexoptNeeded;
589 try {
Calin Juravle576e6c02017-09-12 00:58:33 -0700590 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext,
591 newProfile, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800592 } catch (IOException ioe) {
593 Slog.w(TAG, "IOException reading apk: " + path, ioe);
594 return DEX_OPT_FAILED;
595 }
596 return adjustDexoptNeeded(dexoptNeeded);
597 }
598
599 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800600 * Checks if there is an update on the profile information of the {@code pkg}.
601 * If the compiler filter is not profile guided the method returns false.
602 *
603 * Note that this is a "destructive" operation with side effects. Under the hood the
604 * current profile and the reference profile will be merged and subsequent calls
605 * may return a different result.
606 */
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800607 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String profileName,
608 String compilerFilter) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800609 // Check if we are allowed to merge and if the compiler filter is profile guided.
610 if (!isProfileGuidedCompilerFilter(compilerFilter)) {
611 return false;
612 }
613 // Merge profiles. It returns whether or not there was an updated in the profile info.
614 try {
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800615 return mInstaller.mergeProfiles(uid, pkg.packageName, profileName);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800616 } catch (InstallerException e) {
617 Slog.w(TAG, "Failed to merge profiles", e);
618 }
619 return false;
620 }
621
622 /**
623 * Creates oat dir for the specified package if needed and supported.
624 * In certain cases oat directory
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800625 * <strong>cannot</strong> be created:
626 * <ul>
627 * <li>{@code pkg} is a system app, which is not updated.</li>
628 * <li>Package location is not a directory, i.e. monolithic install.</li>
629 * </ul>
630 *
Richard Uhler7b08b352015-03-25 16:25:57 -0700631 * @return Absolute path to the oat directory or null, if oat directory
632 * cannot be created.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800633 */
634 @Nullable
Todd Kennedy27c24fb2015-09-17 16:49:25 -0700635 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) {
Fyodor Kupolovebcac162015-09-09 15:56:45 -0700636 if (!pkg.canHaveOatDir()) {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800637 return null;
638 }
639 File codePath = new File(pkg.codePath);
640 if (codePath.isDirectory()) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800641 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for
642 // cluster packages). It seems that the logic for the folder creation is
643 // split between installd and here.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800644 File oatDir = getOatDir(codePath);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700645 try {
Andreas Gampea8908752015-11-10 08:58:14 -0800646 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700647 } catch (InstallerException e) {
648 Slog.w(TAG, "Failed to create oat dir", e);
649 return null;
650 }
Richard Uhler7b08b352015-03-25 16:25:57 -0700651 return oatDir.getAbsolutePath();
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800652 }
653 return null;
654 }
655
656 static File getOatDir(File codePath) {
657 return new File(codePath, OAT_DIR_NAME);
658 }
659
Fyodor Kupolova627c092015-05-05 18:44:39 -0700660 void systemReady() {
661 mSystemReady = true;
662 }
Andreas Gampea8908752015-11-10 08:58:14 -0800663
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800664 private String printDexoptFlags(int flags) {
665 ArrayList<String> flagsList = new ArrayList<>();
666
667 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) {
668 flagsList.add("boot_complete");
669 }
670 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) {
671 flagsList.add("debuggable");
672 }
673 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) {
674 flagsList.add("profile_guided");
675 }
676 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) {
677 flagsList.add("public");
678 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800679 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) {
680 flagsList.add("secondary");
681 }
682 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) {
683 flagsList.add("force");
684 }
685 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) {
686 flagsList.add("storage_ce");
687 }
688 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) {
689 flagsList.add("storage_de");
690 }
David Sehr2118ec42017-10-25 14:28:29 -0700691 if ((flags & DEXOPT_IDLE_BACKGROUND_JOB) == DEXOPT_IDLE_BACKGROUND_JOB) {
692 flagsList.add("idle_background_job");
693 }
David Brazdilf7e31c02018-02-13 17:04:26 +0000694 if ((flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) == DEXOPT_ENABLE_HIDDEN_API_CHECKS) {
695 flagsList.add("enable_hidden_api_checks");
David Brazdil464ed3d2018-01-18 15:25:18 +0000696 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800697
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800698 return String.join(",", flagsList);
699 }
700
Andreas Gampea8908752015-11-10 08:58:14 -0800701 /**
702 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a
703 * dexopt path.
704 */
705 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer {
706
707 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock,
708 Context context, String wakeLockTag) {
709 super(installer, installLock, context, wakeLockTag);
710 }
711
712 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) {
713 super(from);
714 }
715
716 @Override
Andreas Gampea8908752015-11-10 08:58:14 -0800717 protected int adjustDexoptNeeded(int dexoptNeeded) {
Nicolas Geoffray96d12a92017-05-03 11:51:53 +0100718 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) {
719 // Ensure compilation by pretending a compiler filter change on the
720 // apk/odex location (the reason for the '-'. A positive value means
721 // the 'oat' location).
722 return -DexFile.DEX2OAT_FOR_FILTER;
723 }
724 return dexoptNeeded;
Andreas Gampea8908752015-11-10 08:58:14 -0800725 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800726
727 @Override
728 protected int adjustDexoptFlags(int flags) {
729 // Add DEXOPT_FORCE flag to signal installd that it should force compilation
730 // and discard dexoptanalyzer result.
731 return flags | DEXOPT_FORCE;
732 }
Andreas Gampea8908752015-11-10 08:58:14 -0800733 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800734}