blob: dcc931df938026e9fbe71692d0be08b5bb8704fc [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jiyong Parkd4e73c82019-07-24 21:39:15 +090079const char kExpectedJavaParcelableOutputContests[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090096 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
97 @Override
98 public Rect createFromParcel(android.os.Parcel _aidl_source) {
99 Rect _aidl_out = new Rect();
100 _aidl_out.readFromParcel(_aidl_source);
101 return _aidl_out;
102 }
103 @Override
104 public Rect[] newArray(int _aidl_size) {
105 return new Rect[_aidl_size];
106 }
107 };
108 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
109 {
110 int _aidl_start_pos = _aidl_parcel.dataPosition();
111 _aidl_parcel.writeInt(0);
112 _aidl_parcel.writeInt(x);
113 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900114 if ((fd!=null)) {
115 _aidl_parcel.writeInt(1);
116 fd.writeToParcel(_aidl_parcel, 0);
117 }
118 else {
119 _aidl_parcel.writeInt(0);
120 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900121 int _aidl_end_pos = _aidl_parcel.dataPosition();
122 _aidl_parcel.setDataPosition(_aidl_start_pos);
123 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
124 _aidl_parcel.setDataPosition(_aidl_end_pos);
125 }
126 public final void readFromParcel(android.os.Parcel _aidl_parcel)
127 {
128 int _aidl_start_pos = _aidl_parcel.dataPosition();
129 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900130 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900131 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900132 x = _aidl_parcel.readInt();
133 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
134 y = _aidl_parcel.readInt();
135 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900136 if ((0!=_aidl_parcel.readInt())) {
137 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
138 }
139 else {
140 fd = null;
141 }
142 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900143 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900144 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
145 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
146 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900147 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
148 }
149 }
150 @Override public int describeContents()
151 {
Jeongik Cha372a8c82018-12-12 16:31:11 +0900152 return 0;
153 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900154}
155)";
156
Devin Moore2f2077a2020-08-28 11:27:53 -0700157// clang-format off
158const char kExpectedCppHeaderOutput[] =
159 R"(#pragma once
160
161#include <binder/IBinder.h>
162#include <binder/IInterface.h>
163#include <binder/Status.h>
164#include <optional>
165#include <utils/String16.h>
166#include <utils/StrongPointer.h>
167#include <vector>
168
169class IFoo : public ::android::IInterface {
170public:
171 DECLARE_META_INTERFACE(Foo)
172 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
173}; // class IFoo
174class IFooDefault : public IFoo {
175public:
176 ::android::IBinder* onAsBinder() override {
177 return nullptr;
178 }
179 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
180 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
181 }
182}; // class IFooDefault
183)";
184// clang-format on
185
Christopher Wileyf8136192016-04-12 14:19:35 -0700186} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700189 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900190 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
191 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700192 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700193 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900194 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700195 args.emplace_back("aidl");
196 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700197 for (const string& s : additional_arguments) {
198 args.emplace_back(s);
199 }
200 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900201 args.emplace_back("--preprocessed=" + f);
202 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700203 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900204 args.emplace_back("--include=" + i);
205 }
206 args.emplace_back(path);
207 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900208 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900209 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700210 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900211 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900212
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700213 if (error != nullptr) {
214 *error = actual_error;
215 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900216
217 if (actual_error != AidlError::OK) {
218 return nullptr;
219 }
220
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900221 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900222 EXPECT_EQ(1ul, defined_types.size());
223
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900224 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700225 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700226
Devin Moore7b8d5c92020-03-17 14:14:08 -0700227 Options::Language GetLanguage() { return GetParam(); }
228
Christopher Wiley0522cd52015-10-28 15:39:44 -0700229 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800230 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900232 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700233};
234
Devin Moore7b8d5c92020-03-17 14:14:08 -0700235// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
236// tests with each of the supported languages as a parameter.
237INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
238 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700239 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700240 [](const testing::TestParamInfo<Options::Language>& info) {
241 return Options::LanguageToString(info.param);
242 });
243
244TEST_P(AidlTest, AcceptMissingPackage) {
245 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700246}
247
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248TEST_P(AidlTest, EndsInSingleLineComment) {
249 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700250}
251
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000252TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
253 const string expected_stderr =
254 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
255 const std::string file_contents = "package a; interface IBar {}";
256 CaptureStderr();
257 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
258 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
259}
260
261TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
262 const string expected_stderr =
263 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
264 const std::string file_contents = "package a; interface Bar {}";
265 CaptureStderr();
266 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
267 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
268}
269
270TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
271 const string expected_stderr =
272 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
273 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
274 CaptureStderr();
275 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
276 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
277}
278
279TEST_P(AidlTest, EnumRequiresCorrectPath) {
280 const string expected_stderr =
281 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
282 const std::string file_contents = "package a; enum Bar { A, }";
283 CaptureStderr();
284 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
285 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
286}
287
Devin Moore7b8d5c92020-03-17 14:14:08 -0700288TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900289 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700290 io_delegate_.SetFileContents("bar/IBar.aidl",
291 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700292 const string path = "foo/IFoo.aidl";
293 const string contents =
294 "package foo;\n"
295 "import bar.IBar;\n"
296 "interface IFoo { void f(in IBar[] input); }";
297 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
298 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700299 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700300 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700301}
302
Devin Moore7b8d5c92020-03-17 14:14:08 -0700303TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700304 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900306}
Devin Moore097a3ab2020-03-11 16:08:44 -0700307
Jiyong Park40782d02020-07-24 19:17:43 +0900308TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700309 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
310 const string expected_ibinder_stderr =
311 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
312 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700313 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900315}
316
Jiyong Park40782d02020-07-24 19:17:43 +0900317TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700318 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
319 const string expected_stderr =
320 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 CaptureStderr();
322 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900324}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325
Jiyong Park40782d02020-07-24 19:17:43 +0900326TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900328 const string expected_stderr =
329 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700330 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700331 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700333}
334
Devin Moore7b8d5c92020-03-17 14:14:08 -0700335TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
337 const string expected_stderr =
338 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
339 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700340 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700342}
343
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700345 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
346 const string expected_stderr =
347 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
348 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700349 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800351}
352
Devin Moore2f2077a2020-08-28 11:27:53 -0700353TEST_P(AidlTest, AcceptNullableList) {
354 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
355 const string expected_stderr = "";
356 CaptureStderr();
357 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
359}
360
Devin Moore7b8d5c92020-03-17 14:14:08 -0700361TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700362 const string method = "package a; interface IFoo { void f(int a, int a); }";
363 const string expected_stderr =
364 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
365 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700366 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700367 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700368}
369
Jeongik Cha13066da2020-08-06 15:43:19 +0900370TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
371 const string method = "package a; parcelable Foo { int a; String a; }";
372 const string expected_stderr =
373 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
374 CaptureStderr();
375 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
376 EXPECT_EQ(expected_stderr, GetCapturedStderr());
377}
378
Devin Moore7b8d5c92020-03-17 14:14:08 -0700379TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700380 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
381 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
382 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700383 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700384 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
389 const string method = "package a; @nullable interface IFoo { int f(); }";
390 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800391 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900392 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700393 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700394 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700395 EXPECT_EQ(expected_stderr, GetCapturedStderr());
396 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800397}
398
Devin Moore7b8d5c92020-03-17 14:14:08 -0700399TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700400 AidlError error;
401 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
402 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800403 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900404 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700405 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700407 EXPECT_EQ(expected_stderr, GetCapturedStderr());
408 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 AidlError error;
413 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
414 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000415 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900416 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900417 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700418 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000419 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700420 EXPECT_EQ(expected_stderr, GetCapturedStderr());
421 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800422}
423
Devin Moore7b8d5c92020-03-17 14:14:08 -0700424TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700425 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000426 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700427 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000428 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900429 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700430 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700431 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000432 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700433 EXPECT_EQ(expected_stderr, GetCapturedStderr());
434 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800435}
436
Jiyong Park40782d02020-07-24 19:17:43 +0900437TEST_P(AidlTest, ParsesNonNullableAnnotation) {
438 auto parse_result =
439 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
440 ASSERT_NE(nullptr, parse_result);
441 const AidlInterface* interface = parse_result->AsInterface();
442 ASSERT_NE(nullptr, interface);
443 ASSERT_FALSE(interface->GetMethods().empty());
444 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
445}
446
Devin Moore7b8d5c92020-03-17 14:14:08 -0700447TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900448 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
449 typenames_, GetLanguage());
450 ASSERT_NE(nullptr, parse_result);
451 const AidlInterface* interface = parse_result->AsInterface();
452 ASSERT_NE(nullptr, interface);
453 ASSERT_FALSE(interface->GetMethods().empty());
454 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
455}
456
457TEST_P(AidlTest, ParsesNonUtf8Annotations) {
458 auto parse_result =
459 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
460 ASSERT_NE(nullptr, parse_result);
461 const AidlInterface* interface = parse_result->AsInterface();
462 ASSERT_NE(nullptr, interface);
463 ASSERT_FALSE(interface->GetMethods().empty());
464 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800465}
466
Devin Moore7b8d5c92020-03-17 14:14:08 -0700467TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900468 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
469 typenames_, GetLanguage());
470 ASSERT_NE(nullptr, parse_result);
471 const AidlInterface* interface = parse_result->AsInterface();
472 ASSERT_NE(nullptr, interface);
473 ASSERT_FALSE(interface->GetMethods().empty());
474 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800475}
476
Devin Moore7b8d5c92020-03-17 14:14:08 -0700477TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700479 const string expected_stderr =
480 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
481 "\"vintf\"'\n"
482 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
483 "--structured\n";
484 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700485 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700486 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700487 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700488 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700489}
490
Devin Moore7b8d5c92020-03-17 14:14:08 -0700491TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700492 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700493 const string expected_stderr =
494 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
495 "--structured\n";
496 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700497 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700498 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700499 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700500 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700501}
502
Devin Moore7b8d5c92020-03-17 14:14:08 -0700503TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700504 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700505 const string expected_stderr =
506 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
507 "\"vintf\"'\n";
508 CaptureStderr();
509 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700513}
514
Devin Moore7b8d5c92020-03-17 14:14:08 -0700515TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700516 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700517 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
518 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700519 ASSERT_EQ(AidlError::OK, error);
520 ASSERT_NE(nullptr, parse_result);
521 const AidlInterface* interface = parse_result->AsInterface();
522 ASSERT_NE(nullptr, interface);
523 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700524}
525
Jeongik Cha64783ed2019-06-07 18:30:54 +0900526TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
527 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900528 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
529 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900530 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700531 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900532 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900533 "a/Foo.aidl",
534 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900535
536 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900537 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900539 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700540 "Parcelable must be defined in AIDL directly.\n";
541 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900542 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700544
545 CaptureStderr();
546 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
547 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900548}
549
Jiyong Park43113fb2020-07-20 16:26:19 +0900550TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
551 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
552 @JavaDebug parcelable IFoo { int a; float b; })");
553 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
554 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
555
556 string java_out;
557 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
558 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
559
560 // Other backends shouldn't be bothered
561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
562 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
563
564 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
565 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
566}
567
568TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
569 {
570 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
571 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
572 CaptureStderr();
573 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
574 const std::string expected_stderr =
575 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900576 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
577 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900578 EXPECT_EQ(expected_stderr, GetCapturedStderr());
579 }
580
581 {
582 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
583 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
584 CaptureStderr();
585 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
586 const std::string expected_stderr =
587 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
588 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
589 EXPECT_EQ(expected_stderr, GetCapturedStderr());
590 }
591}
592
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900593TEST_P(AidlTest, ParseDescriptorAnnotation) {
594 AidlError error;
595 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
596 typenames_, GetLanguage(), &error, {"--structured"});
597 ASSERT_EQ(AidlError::OK, error);
598 ASSERT_NE(nullptr, parse_result);
599 const AidlInterface* interface = parse_result->AsInterface();
600 ASSERT_NE(nullptr, interface);
601 ASSERT_EQ("IBar", interface->GetDescriptor());
602}
603
Jiyong Park40782d02020-07-24 19:17:43 +0900604TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700605 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700606 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900607}
608
609TEST_P(AidlTest, AcceptsOnewayInterface) {
610 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700611 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700612}
Christopher Wileyef140932015-11-03 09:29:19 -0800613
Devin Moore7b8d5c92020-03-17 14:14:08 -0700614TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700615 const string oneway_method =
616 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700617 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100618}
619
Steven Moreland65297cc2020-04-20 20:17:36 -0700620TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
621 const string oneway_method =
622 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
623 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
624 ASSERT_NE(nullptr, defined);
625 const AidlInterface* iface = defined->AsInterface();
626 ASSERT_NE(nullptr, iface);
627
628 const auto& methods = iface->GetMethods();
629 ASSERT_EQ(1u, methods.size());
630 const auto& method = methods[0];
631 const AidlTypeSpecifier& ret_type = method->GetType();
632
633 // TODO(b/151102494): these annotations should be on the method
634 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
635 ASSERT_TRUE(ret_type.IsHide());
636}
637
Devin Moore7b8d5c92020-03-17 14:14:08 -0700638TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100639 string foo_interface =
640 "package a; /* foo */ interface IFoo {"
641 " /* i */ int i();"
642 " /* j */ @nullable String j();"
643 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
644
Devin Moore7b8d5c92020-03-17 14:14:08 -0700645 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100646 EXPECT_NE(nullptr, parse_result);
647 EXPECT_EQ("/* foo */", parse_result->GetComments());
648
649 const AidlInterface* interface = parse_result->AsInterface();
650 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
651 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
652 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
653}
654
Jooyung Han1a551d32020-10-05 15:37:26 +0900655TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
656 io_delegate_.SetFileContents("p/cpp_header.aidl",
657 R"(package p;
658 parcelable cpp_header cpp_header "bar/header";)");
659 import_paths_.emplace("");
660 const string input_path = "p/IFoo.aidl";
661 const string input = R"(package p;
662 import p.cpp_header;
663 interface IFoo {
664 // get bar
665 cpp_header get();
666 })";
667
668 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
669 EXPECT_NE(nullptr, parse_result);
670 const AidlInterface* interface = parse_result->AsInterface();
671 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
672}
673
Christopher Wileyef140932015-11-03 09:29:19 -0800674TEST_F(AidlTest, ParsesPreprocessedFile) {
675 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
676 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700677 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900678 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700679 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
680 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800681}
682
683TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
684 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
685 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900686
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700687 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900688 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700689 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
690 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800691}
692
Devin Moore7b8d5c92020-03-17 14:14:08 -0700693TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800694 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
695 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
696 "interface IBar {}");
697 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900698 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900699 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700700 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800701 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900702
Christopher Wiley41544372015-11-03 14:52:29 -0800703 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700704 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
705 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800706 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700707 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900708 ambiguous_type.Resolve(typenames_);
709 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800710}
711
Jiyong Park8f6ec462020-01-19 20:52:47 +0900712// Special case of PreferImportToPreprocessed. Imported type should be preferred
713// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700714TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900715 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
716 io_delegate_.SetFileContents("one/IBar.aidl",
717 "package one; "
718 "interface IBar {}");
719 preprocessed_files_.push_back("preprocessed");
720 import_paths_.emplace("");
721 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700722 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900723 EXPECT_NE(nullptr, parse_result);
724
725 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700726 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
727 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900728 // But if we request just "IBar" we should get our imported one.
729 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
730 ambiguous_type.Resolve(typenames_);
731 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
732}
733
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800734TEST_F(AidlTest, WritePreprocessedFile) {
735 io_delegate_.SetFileContents("p/Outer.aidl",
736 "package p; parcelable Outer.Inner;");
737 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
738 "interface IBar {}");
739
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900740 vector<string> args {
741 "aidl",
742 "--preprocess",
743 "preprocessed",
744 "p/Outer.aidl",
745 "one/IBar.aidl"};
746 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800747 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
748
749 string output;
750 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
751 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
752}
753
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900754TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100755 io_delegate_.SetFileContents(
756 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800757 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100758 "parcelable Rect {\n"
759 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800760 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100761 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800762 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100763 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100764 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
765 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100766 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900767 " ParcelFileDescriptor fd;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100768 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900769
770 vector<string> args{"aidl", "Rect.aidl"};
771 Options options = Options::From(args);
772 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
773
774 string output;
775 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900776 EXPECT_EQ(kExpectedJavaParcelableOutputContests, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900777}
778
Devin Moore2f2077a2020-08-28 11:27:53 -0700779TEST_F(AidlTest, CppHeaderIncludes) {
780 io_delegate_.SetFileContents("IFoo.aidl",
781 "interface IFoo {\n"
782 " @nullable List<String> foo();\n"
783 "}");
784
785 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
786 Options options = Options::From(args);
787 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
788 std::vector<std::string> empty;
789 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
790 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
791 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
792
793 // Make sure the optional and String16.h includes are added
794 string output;
795 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
796 EXPECT_EQ(kExpectedCppHeaderOutput, output);
797}
798
Devin Moore7b8d5c92020-03-17 14:14:08 -0700799TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700800 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800801 io_delegate_.SetFileContents("p/Outer.aidl",
802 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900803 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700804 CaptureStderr();
805 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
806 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700807 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700808 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800809}
810
Devin Moore7b8d5c92020-03-17 14:14:08 -0700811TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800812 io_delegate_.SetFileContents("preprocessed",
813 "parcelable p.Outer.Inner;");
814 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900815 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700816 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800817 // TODO(wiley): This should actually return nullptr because we require
818 // the outer class name. However, for legacy reasons,
819 // this behavior must be maintained. b/17415692
820 EXPECT_NE(nullptr, parse_result);
821}
822
Christopher Wiley632801d2015-11-05 14:15:49 -0800823TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700824 const string expected_foo_stderr =
825 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
826 "Declared parcelables should be in their own file and/or cannot be used with --structured "
827 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700828 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
829
Christopher Wiley632801d2015-11-05 14:15:49 -0800830 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700831 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700832 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900833 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700834 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900835
Steven Morelande2c64b42018-09-18 15:06:37 -0700836 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900837 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700838 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900839 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700840 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700841
Devin Moore097a3ab2020-03-11 16:08:44 -0700842 const string expected_bar_stderr =
843 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
844 "Declared parcelables should be in their own file and/or cannot be used with --structured "
845 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700846 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
847
Jiyong Parkda8c6932019-08-12 19:56:08 +0900848 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700849 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700850 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900851 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700852 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700853 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700854 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700855 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700856 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800857}
858
Devin Moore7b8d5c92020-03-17 14:14:08 -0700859TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700860 const string expected_stderr =
861 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
862 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700863 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
864 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700865 AidlError error;
866 CaptureStderr();
867 EXPECT_EQ(
868 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700869 Parse("p/IFoo.aidl",
870 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700871 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700872 EXPECT_EQ(expected_stderr, GetCapturedStderr());
873 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700874}
875
Devin Moore7b8d5c92020-03-17 14:14:08 -0700876TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 AidlError error;
878 const string expected_stderr =
879 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
880 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900881 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
882 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700883 interface IFoo {
884 const String DUPLICATED = "d";
885 const int DUPLICATED = 1;
886 }
887 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700888 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700889 EXPECT_EQ(expected_stderr, GetCapturedStderr());
890 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700891}
892
Devin Moore7b8d5c92020-03-17 14:14:08 -0700893TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700894 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700895 const string expected_stderr =
896 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700897 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700898 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
899 R"(package p;
900 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700901 parcelable IBar {}
902 parcelable StructuredParcelable {}
903 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900904 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700905 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700906 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700907 // Parse success is important for clear error handling even if the cases aren't
908 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700909 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700910}
911
Devin Moore7b8d5c92020-03-17 14:14:08 -0700912TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700913 AidlError error;
914 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
915 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700916 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 EXPECT_EQ(expected_stderr, GetCapturedStderr());
918 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700919}
920
Steven Morelandf9e922f2020-07-08 21:15:27 +0000921TEST_P(AidlTest, FailOnEmptyListWithComma) {
922 AidlError error;
923 const string expected_stderr =
924 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
925 CaptureStderr();
926 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
927 typenames_, GetLanguage(), &error));
928 EXPECT_EQ(expected_stderr, GetCapturedStderr());
929 EXPECT_EQ(AidlError::PARSE_ERROR, error);
930}
931
Devin Moore7b8d5c92020-03-17 14:14:08 -0700932TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700933 AidlError error;
934 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700935 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900937 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
938 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700939 interface IFoo {
940 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
941 }
942 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700944 EXPECT_EQ(expected_stderr, GetCapturedStderr());
945 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700946}
947
Jiyong Park18132182020-06-08 20:24:40 +0900948TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
949 AidlError error;
950 const string expected_stderr =
951 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
952 "cpp_header (which can also be used as an identifier)\n";
953 CaptureStderr();
954 // Notice the trailing dot(.) in the name, which isn't a correct name
955 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
956 GetLanguage(), &error));
957 EXPECT_EQ(expected_stderr, GetCapturedStderr());
958 EXPECT_EQ(AidlError::PARSE_ERROR, error);
959}
960
961TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
962 AidlError error;
963 const string expected_stderr =
964 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
965 "cpp_header (which can also be used as an identifier)\n";
966 CaptureStderr();
967 // Notice the trailing dot(.) in the package name
968 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
969 GetLanguage(), &error));
970 EXPECT_EQ(expected_stderr, GetCapturedStderr());
971 EXPECT_EQ(AidlError::PARSE_ERROR, error);
972}
973
Devin Moore7b8d5c92020-03-17 14:14:08 -0700974TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700975 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700976 auto parse_result = Parse("p/IFoo.aidl",
977 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700978 interface IFoo {
979 const int POSITIVE_HEX_VALUE = 0xf5;
980 }
981 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700982 typenames_, GetLanguage(), &error);
983 EXPECT_NE(nullptr, parse_result);
984 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700985 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700986 const auto& cpp_constants = interface->GetConstantDeclarations();
987 EXPECT_EQ((size_t)1, cpp_constants.size());
988 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700989 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700990 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700991}
992
Devin Moore7b8d5c92020-03-17 14:14:08 -0700993TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700994 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700995 auto parse_result = Parse("p/IFoo.aidl",
996 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700997 interface IFoo {
998 const int NEGATIVE_HEX_VALUE = 0xffffffff;
999 }
1000 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 typenames_, GetLanguage(), &error);
1002 ASSERT_NE(nullptr, parse_result);
1003 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001004 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001005 const auto& cpp_constants = interface->GetConstantDeclarations();
1006 EXPECT_EQ((size_t)1, cpp_constants.size());
1007 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001008 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001009 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001010}
1011
Devin Moore7b8d5c92020-03-17 14:14:08 -07001012TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001013 io_delegate_.SetFileContents(
1014 "p/Outer.aidl",
1015 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001016 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001017 const string input_path = "p/IFoo.aidl";
1018 const string input = "package p; import p.Outer; interface IFoo"
1019 " { Outer.Inner get(); }";
1020
Devin Moore7b8d5c92020-03-17 14:14:08 -07001021 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1022 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001023
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001024 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001025 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001026 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1027 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001028}
1029
Devin Moore7b8d5c92020-03-17 14:14:08 -07001030TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001031 io_delegate_.SetFileContents(
1032 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001033 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001034 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001035 const string input_path = "p/IFoo.aidl";
1036 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001037 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1038 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001039 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001040 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1041 native_type.Resolve(typenames_);
1042
1043 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1044 // C++ understands C++ specific stuff
1045 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1046 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001047 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001048 EXPECT_EQ(1u, headers.size());
1049 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001050}
1051
Christopher Wileyf8136192016-04-12 14:19:35 -07001052TEST_F(AidlTest, WritesCorrectDependencyFile) {
1053 // While the in tree build system always gives us an output file name,
1054 // other android tools take advantage of our ability to infer the intended
1055 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001056 vector<string> args = {
1057 "aidl",
1058 "-d dep/file/path",
1059 "-o place/for/output",
1060 "p/IFoo.aidl"};
1061 Options options = Options::From(args);
1062 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001063 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001064 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001065 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001066 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1067}
1068
Dan Willemsen93298ee2016-11-10 23:55:55 -08001069TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1070 // While the in tree build system always gives us an output file name,
1071 // other android tools take advantage of our ability to infer the intended
1072 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001073 vector<string> args = {
1074 "aidl",
1075 "-d dep/file/path",
1076 "--ninja",
1077 "-o place/for/output",
1078 "p/IFoo.aidl"};
1079 Options options = Options::From(args);
1080 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001081 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001082 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001083 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001084 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1085}
1086
Jiyong Parkdf202122019-09-30 20:48:35 +09001087TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001088 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1089 // this by calling aidl with every .aidl file it finds, then parsing the
1090 // generated dependency files. Those that reference .java output files are
1091 // for interfaces and those that do not are parcelables. However, for both
1092 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001093 vector<string> args = {
1094 "aidl",
1095 "-o place/for/output",
1096 "-d dep/file/path",
1097 "p/Foo.aidl"};
1098 Options options = Options::From(args);
1099 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001100 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001101 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001102 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001103 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1104}
1105
1106TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1107 vector<string> args = {
1108 "aidl",
1109 "--structured",
1110 "-o place/for/output",
1111 "-d dep/file/path",
1112 "p/Foo.aidl"};
1113 Options options = Options::From(args);
1114 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1115 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1116 string actual_dep_file_contents;
1117 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1118 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001119}
1120
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001121TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1122 vector<string> args = {
1123 "aidl",
1124 "--lang=java",
1125 "-o place/for/output",
1126 "p/Foo.aidl"};
1127 Options options = Options::From(args);
1128 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1129 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1130 string output_file_contents;
1131 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1132}
1133
Jeongik Cha08ca2182019-11-21 14:01:13 +09001134// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001136 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001137 "package a; interface IFoo {\n"
1138 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001139 string expected_stderr;
1140 switch (GetLanguage()) {
1141 case Options::Language::CPP:
1142 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001143 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001144 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1145 "String and IBinder.\n";
1146 break;
1147 case Options::Language::JAVA:
1148 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001149 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001150 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1151 "String, IBinder, and ParcelFileDescriptor.\n";
1152 break;
1153 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001154 case Options::Language::RUST:
1155 expected_stderr =
1156 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1157 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001158 default:
1159 AIDL_FATAL(AIDL_LOCATION_HERE)
1160 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1161 }
1162 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001163 AidlTypenames tn1;
1164 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001165 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001166
1167 string primitive_parcelable =
1168 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001169 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001171 AidlTypenames tn2;
1172 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001173 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001174}
1175
Devin Moore21b26772020-08-26 16:37:56 -07001176TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001177 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001178 const string list_array_parcelable =
1179 "package a; parcelable Foo {\n"
1180 " List[] lists; }";
1181 CaptureStderr();
1182 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1183 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1184}
1185
Jiyong Parkf8d53612020-05-04 14:06:13 +09001186TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1187 AidlError error;
1188 string expected_stderr =
1189 "ERROR: a/IFoo.aidl:2.7-11: "
1190 "Encountered an untyped List or Map. The use of untyped List/Map is "
1191 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1192 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1193 if (GetLanguage() != Options::Language::JAVA) {
1194 expected_stderr =
1195 "ERROR: a/IFoo.aidl:2.1-7: "
1196 "Currently, only the Java backend supports non-generic List.\n";
1197 }
1198
1199 const string primitive_interface =
1200 "package a; interface IFoo {\n"
1201 " List foo(); }";
1202 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001203 AidlTypenames tn1;
1204 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001205 {"--structured"}));
1206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001207
1208 string primitive_parcelable =
1209 "package a; parcelable IFoo {\n"
1210 " List foo;}";
1211 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001212 AidlTypenames tn2;
1213 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001214 {"--structured"}));
1215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1216}
1217
Jeongik Cha225519b2020-08-29 01:55:32 +09001218TEST_P(AidlTest, ExtensionTest) {
1219 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001220 string extendable_parcelable =
1221 "package a; parcelable Data {\n"
1222 " ParcelableHolder extension;\n"
1223 " ParcelableHolder extension2;\n"
1224 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001225 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1226 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1227 EXPECT_EQ(
1228 "ERROR: a/Data.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1229 "yet.\n",
1230 GetCapturedStderr());
1231 } else {
1232 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1233 EXPECT_EQ("", GetCapturedStderr());
1234 }
1235}
1236TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1237 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001238 string parcelableholder_return_interface =
1239 "package a; interface IFoo {\n"
1240 " ParcelableHolder foo();\n"
1241 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001242 EXPECT_EQ(nullptr,
1243 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001244
Jeongik Cha225519b2020-08-29 01:55:32 +09001245 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1246 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001247 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001248 "ERROR: a/IFoo.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1249 "yet.\n",
1250 GetCapturedStderr());
1251 return;
1252 }
1253 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1254 GetCapturedStderr());
1255}
1256
1257TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1258 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001259 string extendable_parcelable_arg_interface =
1260 "package a; interface IFoo {\n"
1261 " void foo(in ParcelableHolder ph);\n"
1262 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001263 EXPECT_EQ(nullptr,
1264 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1265
1266 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1267 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001268 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001269 "ERROR: a/IFoo.aidl:2.14-31: The NDK and Rust backend does not support ParcelableHolder "
1270 "yet.\n",
1271 GetCapturedStderr());
1272 return;
1273 }
1274 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1275 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001276}
1277
Jiyong Park02da7422018-07-16 16:00:26 +09001278TEST_F(AidlTest, ApiDump) {
1279 io_delegate_.SetFileContents(
1280 "foo/bar/IFoo.aidl",
1281 "package foo.bar;\n"
1282 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001283 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001284 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001285 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001286 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1287 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1288 " IFoo foo3(IFoo foo);\n"
1289 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001290 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001291 " const int A = 1;\n"
1292 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001293 "}\n");
1294 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1295 "package foo.bar;\n"
1296 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001297 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001298 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001299 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001300 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001301 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001302 " int y;\n"
1303 " IFoo foo;\n"
1304 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001305 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001306 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001307 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001308 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001309 "}\n");
1310 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001311 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1312 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001313 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001314 bool result = dump_api(options, io_delegate_);
1315 ASSERT_TRUE(result);
1316 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001317 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001318 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001319/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001320interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001321 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001322 int foo(out int[] a, String b, boolean c, inout List<String> d);
1323 int foo2(@utf8InCpp String x, inout List<String> y);
1324 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1325 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001326 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001327 const int A = 1;
1328 const String STR = "Hello";
1329}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001330)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001331
Jiyong Parke59c3682018-09-11 23:10:25 +09001332 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001333 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001334/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001335parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001336 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001337 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001338 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001339 int y;
1340 foo.bar.IFoo foo;
1341 List<foo.bar.IFoo> a;
1342 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001343 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001344 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001345}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001346)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001347}
1348
Jiyong Parked65bf42018-08-28 15:43:27 +09001349TEST_F(AidlTest, ApiDumpWithManualIds) {
1350 io_delegate_.SetFileContents(
1351 "foo/bar/IFoo.aidl",
1352 "package foo.bar;\n"
1353 "interface IFoo {\n"
1354 " int foo() = 1;\n"
1355 " int bar() = 2;\n"
1356 " int baz() = 10;\n"
1357 "}\n");
1358
Jiyong Parke59c3682018-09-11 23:10:25 +09001359 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001360 Options options = Options::From(args);
1361 bool result = dump_api(options, io_delegate_);
1362 ASSERT_TRUE(result);
1363 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001364 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001365 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001366interface IFoo {
1367 int foo() = 1;
1368 int bar() = 2;
1369 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001370}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001371)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001372}
1373
1374TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001375 const string expected_stderr =
1376 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1377 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001378 io_delegate_.SetFileContents(
1379 "foo/bar/IFoo.aidl",
1380 "package foo.bar;\n"
1381 "interface IFoo {\n"
1382 " int foo() = 1;\n"
1383 " int bar();\n"
1384 " int baz() = 10;\n"
1385 "}\n");
1386
Jiyong Parke59c3682018-09-11 23:10:25 +09001387 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001388 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001389 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001390 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001392}
1393
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001394TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001395 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001396 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1397 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001398 const string expected_map_stderr =
1399 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001400 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1401 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001402 "package p; interface IFoo {"
1403 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001404 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001405 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001406 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001407
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001408 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001409 "package p; interface IFoo {"
1410 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001411 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001412 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001413 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001414}
1415
Jeongik Chae48d9942020-01-02 17:39:00 +09001416TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001417 const string expected_stderr =
1418 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001419 Options options = Options::From("aidl -I p p/IFoo.aidl");
1420 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1421
1422 io_delegate_.SetFileContents("p/IFoo.aidl",
1423 "package p; interface IFoo {"
1424 "Map<String, Bar> foo();}");
1425 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1426
1427 io_delegate_.SetFileContents("p/IFoo.aidl",
1428 "package p; interface IFoo {"
1429 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001430 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001431 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001432 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001433
1434 io_delegate_.SetFileContents("p/IFoo.aidl",
1435 "package p; interface IFoo {"
1436 "Map<String, String> foo();}");
1437 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1438
1439 io_delegate_.SetFileContents("p/IFoo.aidl",
1440 "package p; interface IFoo {"
1441 "Map<String, ParcelFileDescriptor> foo();}");
1442 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1443}
1444
Jeongik Chadf76dc72019-11-28 00:08:47 +09001445TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001446 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001447 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1448 io_delegate_.SetFileContents(options.InputFiles().front(),
1449 "package p; interface IFoo {"
1450 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001451 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001452 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001454}
1455
1456TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1457 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1458 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001459 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001460 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001461 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1462 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001463
1464 Options options = Options::From("aidl -I p p/IFoo.aidl");
1465 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1466 io_delegate_.SetFileContents("p/IFoo.aidl",
1467 "package p; interface IFoo {"
1468 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001469 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001470 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001471 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001472 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001473 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001474 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001475 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1476 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001477 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1478 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1479 io_delegate_.SetFileContents("p/IFoo.aidl",
1480 "package p; interface IFoo {"
1481 "Bar<String, ParcelFileDescriptor> foo();}");
1482 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001483
1484 io_delegate_.SetFileContents("p/IFoo.aidl",
1485 "package p; interface IFoo {"
1486 "Bar<int, long> foo();}");
1487
1488 io_delegate_.SetFileContents("p/IFoo.aidl",
1489 "package p; interface IFoo {"
1490 "Bar<int[], long[]> foo();}");
1491
1492 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001493}
1494
Jeongik Cha0e426012019-07-29 15:57:02 +09001495TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1496 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001497 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1498 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001499 for (const auto& rawOption : rawOptions) {
1500 string expected_stderr =
1501 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001502 Options options = Options::From(rawOption);
1503 io_delegate_.SetFileContents(options.InputFiles().front(),
1504 "package foo.bar;\n"
1505 "interface IFoo1 { int foo(); }\n"
1506 "interface IFoo2 { int foo(); }\n"
1507 "parcelable Data1 { int a; int b;}\n"
1508 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001509 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001510 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001512
Jeongik Cha0e426012019-07-29 15:57:02 +09001513 io_delegate_.SetFileContents(options.InputFiles().front(),
1514 "package foo.bar;\n"
1515 "interface IFoo1 { int foo(); }\n"
1516 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001517 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001518 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001519 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001520
Devin Moore5de18ed2020-04-02 13:52:29 -07001521 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001522 io_delegate_.SetFileContents(options.InputFiles().front(),
1523 "package foo.bar;\n"
1524 "parcelable Data1 { int a; int b;}\n"
1525 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001526 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001527 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001528 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001529 }
1530}
1531
Devin Moorebdba2a82020-03-31 15:19:02 -07001532TEST_P(AidlTest, FailParseOnEmptyFile) {
1533 const string contents = "";
1534 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1535 CaptureStderr();
1536 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1537 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1538}
1539
Jiyong Parkb034bf02018-07-30 17:44:33 +09001540TEST_F(AidlTest, MultipleInputFiles) {
1541 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001542 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001543
1544 io_delegate_.SetFileContents(options.InputFiles().at(0),
1545 "package foo.bar;\n"
1546 "import foo.bar.Data;\n"
1547 "interface IFoo { Data getData(); }\n");
1548
1549 io_delegate_.SetFileContents(options.InputFiles().at(1),
1550 "package foo.bar;\n"
1551 "import foo.bar.IFoo;\n"
1552 "parcelable Data { IFoo foo; }\n");
1553
1554 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1555
1556 string content;
1557 for (const auto file : {
1558 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1559 content.clear();
1560 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1561 EXPECT_FALSE(content.empty());
1562 }
1563}
1564
1565TEST_F(AidlTest, MultipleInputFilesCpp) {
1566 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001567 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001568
1569 io_delegate_.SetFileContents(options.InputFiles().at(0),
1570 "package foo.bar;\n"
1571 "import foo.bar.Data;\n"
1572 "interface IFoo { Data getData(); }\n");
1573
1574 io_delegate_.SetFileContents(options.InputFiles().at(1),
1575 "package foo.bar;\n"
1576 "import foo.bar.IFoo;\n"
1577 "parcelable Data { IFoo foo; }\n");
1578
1579 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1580
1581 string content;
1582 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001583 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001584 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1585 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1586 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1587 content.clear();
1588 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1589 EXPECT_FALSE(content.empty());
1590 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001591}
1592
Andrei Homescub62afd92020-05-11 19:24:59 -07001593TEST_F(AidlTest, MultipleInputFilesRust) {
1594 Options options =
1595 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1596
1597 io_delegate_.SetFileContents(options.InputFiles().at(0),
1598 "package foo.bar;\n"
1599 "import foo.bar.Data;\n"
1600 "interface IFoo { Data getData(); }\n");
1601
1602 io_delegate_.SetFileContents(options.InputFiles().at(1),
1603 "package foo.bar;\n"
1604 "import foo.bar.IFoo;\n"
1605 "parcelable Data { IFoo foo; }\n");
1606
1607 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1608
1609 string content;
1610 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1611 content.clear();
1612 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1613 EXPECT_FALSE(content.empty());
1614 }
1615}
1616
Devin Moore097a3ab2020-03-11 16:08:44 -07001617TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1618 const string expected_stderr =
1619 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001620 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1621 // int getInterfaceVersion() is one of the meta transactions
1622 io_delegate_.SetFileContents(options.InputFiles().front(),
1623 "package p; interface IFoo {"
1624 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001625 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001626 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001627 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1628}
Jiyong Park309668e2018-07-28 16:55:44 +09001629
Devin Moore097a3ab2020-03-11 16:08:44 -07001630TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1631 // boolean getInterfaceVersion() is not a meta transaction, but should be
1632 // prevented because return type is not part of a method signature
1633 const string expected_stderr =
1634 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1635 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001636 io_delegate_.SetFileContents(options.InputFiles().front(),
1637 "package p; interface IFoo {"
1638 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001639 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001640 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001641 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1642}
Jiyong Park309668e2018-07-28 16:55:44 +09001643
Devin Moore097a3ab2020-03-11 16:08:44 -07001644TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001645 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001646 const string expected_stderr =
1647 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1648 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001649 io_delegate_.SetFileContents(options.InputFiles().front(),
1650 "package p; interface IFoo {"
1651 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001652 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001653 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001654 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001655
1656 // this is not a meta interface method as it differs type arguments
1657 io_delegate_.SetFileContents(options.InputFiles().front(),
1658 "package p; interface IFoo {"
1659 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001660 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001661}
1662
Daniel Norman85aed542019-08-21 12:01:14 -07001663TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001664 Options options = Options::From("aidl --checkapi old new");
1665 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1666 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1667 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1668 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1669
1670 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1671}
1672
Jiyong Park3656c3c2018-08-01 20:02:01 +09001673TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001674 Options options = Options::From("aidl --checkapi old new");
1675 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1676 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001677
1678 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1679}
1680
Daniel Norman85aed542019-08-21 12:01:14 -07001681class AidlTestCompatibleChanges : public AidlTest {
1682 protected:
1683 Options options_ = Options::From("aidl --checkapi old new");
1684};
1685
1686TEST_F(AidlTestCompatibleChanges, NewType) {
1687 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1688 "package p;"
1689 "interface IFoo {"
1690 " void foo(int a);"
1691 "}");
1692 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1693 "package p;"
1694 "interface IFoo {"
1695 " void foo(int a);"
1696 "}");
1697 io_delegate_.SetFileContents("new/p/IBar.aidl",
1698 "package p;"
1699 "interface IBar {"
1700 " void bar();"
1701 "}");
1702 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1703}
1704
1705TEST_F(AidlTestCompatibleChanges, NewMethod) {
1706 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1707 "package p;"
1708 "interface IFoo {"
1709 " void foo(int a);"
1710 "}");
1711 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1712 "package p;"
1713 "interface IFoo {"
1714 " void foo(int a);"
1715 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001716 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001717 "}");
1718 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1719}
1720
1721TEST_F(AidlTestCompatibleChanges, NewField) {
1722 io_delegate_.SetFileContents("old/p/Data.aidl",
1723 "package p;"
1724 "parcelable Data {"
1725 " int foo;"
1726 "}");
1727 io_delegate_.SetFileContents("new/p/Data.aidl",
1728 "package p;"
1729 "parcelable Data {"
1730 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001731 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001732 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001733 "}");
1734 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1735}
1736
1737TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1738 io_delegate_.SetFileContents("old/p/Enum.aidl",
1739 "package p;"
1740 "enum Enum {"
1741 " FOO = 1,"
1742 "}");
1743 io_delegate_.SetFileContents("new/p/Enum.aidl",
1744 "package p;"
1745 "enum Enum {"
1746 " FOO = 1,"
1747 " BAR = 2,"
1748 "}");
1749 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1750}
1751
1752TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1753 io_delegate_.SetFileContents("old/p/Enum.aidl",
1754 "package p;"
1755 "enum Enum {"
1756 " FOO = 1,"
1757 " BAR = 2,"
1758 "}");
1759 io_delegate_.SetFileContents("new/p/Enum.aidl",
1760 "package p;"
1761 "enum Enum {"
1762 " BAR = 2,"
1763 " FOO = 1,"
1764 "}");
1765 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1766}
1767
1768TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001769 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1770 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001771 "interface IFoo {"
1772 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001773 "}");
1774 io_delegate_.SetFileContents("old/p/Data.aidl",
1775 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001776 "parcelable Data {"
1777 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001778 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001779 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1780 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001781 "interface IFoo {"
1782 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001783 "}");
1784 io_delegate_.SetFileContents("new/p/Data.aidl",
1785 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001786 "parcelable Data {"
1787 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001788 "}");
1789 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1790 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001791 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001792 " void foo(int a);"
1793 "}");
1794 io_delegate_.SetFileContents("new/q/Data.aidl",
1795 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001796 "parcelable Data {"
1797 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001798 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001799 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1800}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001801
Daniel Norman85aed542019-08-21 12:01:14 -07001802TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1803 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1804 "package p;"
1805 "interface IFoo {"
1806 " void foo(int a);"
1807 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001808 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1809 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001810 "interface IFoo {"
1811 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001812 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001813 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1814}
Jiyong Parke59c3682018-09-11 23:10:25 +09001815
Daniel Norman85aed542019-08-21 12:01:14 -07001816TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001817 io_delegate_.SetFileContents("old/p/I.aidl",
1818 "package p; interface I {"
1819 "const int A = 1; }");
1820 io_delegate_.SetFileContents("new/p/I.aidl",
1821 "package p ; interface I {"
1822 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001823 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1824}
Jiyong Parka428d212018-08-29 22:26:30 +09001825
Daniel Norman85aed542019-08-21 12:01:14 -07001826TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001827 io_delegate_.SetFileContents("old/p/I.aidl",
1828 "package p; interface I {"
1829 "const int A = 1; const int B = 2;}");
1830 io_delegate_.SetFileContents("new/p/I.aidl",
1831 "package p ; interface I {"
1832 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001833 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001834}
1835
Daniel Norman85aed542019-08-21 12:01:14 -07001836class AidlTestIncompatibleChanges : public AidlTest {
1837 protected:
1838 Options options_ = Options::From("aidl --checkapi old new");
1839};
1840
1841TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001842 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001843 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1844 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001845 "interface IFoo {"
1846 " void foo(in String[] str);"
1847 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001848 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001849 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001850 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001851 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001852}
1853
1854TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001855 const string expected_stderr =
1856 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001857 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1858 "package p;"
1859 "interface IFoo {"
1860 " void foo(in String[] str);"
1861 " void bar(@utf8InCpp String str);"
1862 "}");
1863 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1864 "package p;"
1865 "interface IFoo {"
1866 " void foo(in String[] str);"
1867 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001868 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001869 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001870 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001871}
1872
Jiyong Parkf8d53612020-05-04 14:06:13 +09001873TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1874 const string expected_stderr =
1875 "ERROR: new/p/IFoo.aidl:1.61-65: "
1876 "Encountered an untyped List or Map. The use of untyped List/Map is "
1877 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1878 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1879 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1880 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1881 "package p;"
1882 "interface IFoo {"
1883 " void foo(in String[] str);"
1884 "}");
1885 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1886 "package p;"
1887 "interface IFoo {"
1888 " void foo(in String[] str);"
1889 " void bar(in List arg);"
1890 "}");
1891 CaptureStderr();
1892 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1893 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1894}
1895
1896TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1897 const string expected_stderr =
1898 "ERROR: new/p/Data.aidl:1.54-59: "
1899 "Encountered an untyped List or Map. The use of untyped List/Map is "
1900 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1901 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1902 "ERROR: new/p/Data.aidl: Failed to read.\n";
1903 io_delegate_.SetFileContents("old/p/Data.aidl",
1904 "package p;"
1905 "parcelable Data {"
1906 " int foo;"
1907 "}");
1908 io_delegate_.SetFileContents("new/p/Data.aidl",
1909 "package p;"
1910 "parcelable Data {"
1911 " int foo;"
1912 " @nullable List list;"
1913 "}");
1914 CaptureStderr();
1915 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1916 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1917}
1918
Daniel Norman85aed542019-08-21 12:01:14 -07001919TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001920 const string expected_stderr =
1921 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001922 io_delegate_.SetFileContents("old/p/Data.aidl",
1923 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001924 "parcelable Data {"
1925 " int foo;"
1926 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001927 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001928 io_delegate_.SetFileContents("new/p/Data.aidl",
1929 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001930 "parcelable Data {"
1931 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001932 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001933 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001934 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001935 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001936}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001937
Daniel Norman85aed542019-08-21 12:01:14 -07001938TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001939 const string expected_stderr =
1940 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001941 io_delegate_.SetFileContents("old/p/Enum.aidl",
1942 "package p;"
1943 "enum Enum {"
1944 " FOO = 1,"
1945 " BAR = 2,"
1946 "}");
1947 io_delegate_.SetFileContents("new/p/Enum.aidl",
1948 "package p;"
1949 "enum Enum {"
1950 " BAR = 2,"
1951 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001952 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001953 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001955}
1956
1957TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001958 const string expected_stderr =
1959 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001960 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1961 "package p;"
1962 "interface IFoo {"
1963 " void foo(in String[] str);"
1964 " void bar(@utf8InCpp String str);"
1965 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001966 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1967 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001968 "interface IFoo {"
1969 " void foo(in String[] str);"
1970 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001971 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001972 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001973 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001975}
1976
Daniel Norman85aed542019-08-21 12:01:14 -07001977TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001978 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001979 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1980 "package p;"
1981 "interface IFoo {"
1982 " void foo(in String[] str);"
1983 " void bar(@utf8InCpp String str);"
1984 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001985 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
1986 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001987 "interface IFoo2 {"
1988 " void foo(in String[] str);"
1989 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001990 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001991 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001992 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001994}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001995
Daniel Norman85aed542019-08-21 12:01:14 -07001996TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001997 const string expected_stderr =
1998 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001999 io_delegate_.SetFileContents("old/p/Enum.aidl",
2000 "package p;"
2001 "enum Enum {"
2002 " FOO = 1,"
2003 " BAR = 2,"
2004 "}");
2005 io_delegate_.SetFileContents("new/p/Enum.aidl",
2006 "package p;"
2007 "enum Enum {"
2008 " FOO = 3,"
2009 " BAR = 2,"
2010 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002011 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002012 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002014}
2015
2016TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002017 const string expected_stderr =
2018 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2019 "from 0 to 1.\n"
2020 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2021 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002022 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2023 "package p;"
2024 "interface IFoo {"
2025 " void foo(in String[] str);"
2026 " void bar(@utf8InCpp String str);"
2027 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002028 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2029 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002030 "interface IFoo {"
2031 " void bar(@utf8InCpp String str);"
2032 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002033 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002034 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002035 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002037}
2038
2039TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002040 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002041 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2042 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002043 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002044 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002045 "parcelable Data {"
2046 " int foo;"
2047 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002048 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002049 io_delegate_.SetFileContents("new/p/Data.aidl",
2050 "package p;"
2051 "parcelable Data {"
2052 " int bar;"
2053 " int foo;"
2054 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002055 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002056 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002057 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002058}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002059
Daniel Norman85aed542019-08-21 12:01:14 -07002060TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002061 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002062 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002063 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002064 "interface IFoo {"
2065 " void foo(in String[] str);"
2066 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002067 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002068 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2069 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002070 "interface IFoo {"
2071 " void foo(out String[] str);"
2072 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002073 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002074 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002075 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002077}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002078
Daniel Norman85aed542019-08-21 12:01:14 -07002079TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002080 const string expected_stderr =
2081 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002082 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2083 "package p;"
2084 "interface IFoo {"
2085 " void foo(in String[] str);"
2086 " void bar(@utf8InCpp String str);"
2087 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002088 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2089 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002090 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002091 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002092 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002093 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002094 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002095 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002096 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002097}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002098
Daniel Norman85aed542019-08-21 12:01:14 -07002099TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002100 const string expected_stderr =
2101 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002102 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2103 "package p;"
2104 "interface IFoo {"
2105 " void foo(in String[] str);"
2106 " void bar(@utf8InCpp String str);"
2107 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002108 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2109 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002110 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002111 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002112 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002113 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002114 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002115 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002117}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002118
Devin Mooredb7ac512020-08-07 11:17:36 -07002119TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2120 const string expected_stderr =
2121 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2122 io_delegate_.SetFileContents("old/p/Foo.aidl",
2123 "package p;"
2124 "parcelable Foo {"
2125 " int A;"
2126 "}");
2127 io_delegate_.SetFileContents("new/p/Foo.aidl",
2128 "package p;"
2129 "@JavaOnlyStableParcelable parcelable Foo {"
2130 " int A;"
2131 "}");
2132 CaptureStderr();
2133 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2134 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2135}
2136
2137TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2138 const string expected_stderr =
2139 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2140 io_delegate_.SetFileContents("old/p/Foo.aidl",
2141 "package p;"
2142 "@JavaOnlyStableParcelable parcelable Foo {"
2143 " int A;"
2144 "}");
2145 io_delegate_.SetFileContents("new/p/Foo.aidl",
2146 "package p;"
2147 "parcelable Foo {"
2148 " int A;"
2149 "}");
2150 CaptureStderr();
2151 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2153}
2154
Daniel Norman85aed542019-08-21 12:01:14 -07002155TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002156 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002157 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2158 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002159 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002160 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002161 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002162 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002163}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002164
Daniel Norman85aed542019-08-21 12:01:14 -07002165TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002166 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002167 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2168 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002170 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002171 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002172}
Jiyong Parka428d212018-08-29 22:26:30 +09002173
Daniel Norman85aed542019-08-21 12:01:14 -07002174TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002175 const string expected_stderr =
2176 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002177 io_delegate_.SetFileContents("old/p/I.aidl",
2178 "package p; interface I {"
2179 "const int A = 1; const int B = 2;}");
2180 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002181 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002182 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002183 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002184}
Jiyong Parka428d212018-08-29 22:26:30 +09002185
Daniel Norman85aed542019-08-21 12:01:14 -07002186TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002187 const string expected_stderr =
2188 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002189 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2190 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002191 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002192 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002194}
2195
Devin Moorec7e47a32020-08-07 10:55:25 -07002196TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2197 const string expected_stderr =
2198 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2199 "This is an incompatible change for FixedSize types.\n";
2200 io_delegate_.SetFileContents("old/p/Foo.aidl",
2201 "package p; @FixedSize parcelable Foo { int A = 1; }");
2202 io_delegate_.SetFileContents("new/p/Foo.aidl",
2203 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2204 CaptureStderr();
2205 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2207}
2208
2209TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2210 const string expected_stderr =
2211 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2212 io_delegate_.SetFileContents("old/p/Foo.aidl",
2213 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2214 io_delegate_.SetFileContents("new/p/Foo.aidl",
2215 "package p; @FixedSize parcelable Foo { int A = 1; }");
2216 CaptureStderr();
2217 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2218 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2219}
2220
2221TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2222 const string expected_stderr =
2223 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2224 "a.\n"
2225 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2226 "b.\n"
2227 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2228 "c.\n"
2229 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2230 "d.\n"
2231 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2232 "e.\n"
2233 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2234 "f.\n";
2235
2236 io_delegate_.SetFileContents("Foo.aidl",
2237 "@FixedSize parcelable Foo { "
2238 " int[] a;"
2239 " Bar b;"
2240 " String c;"
2241 " ParcelFileDescriptor d;"
2242 " IBinder e;"
2243 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002244 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002245 "}");
2246 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2247 Options options =
2248 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2249
2250 CaptureStderr();
2251 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2252 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2253}
2254
2255TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2256 const string expected_stderr = "";
2257
2258 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2259 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2260 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2261 Options options =
2262 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2263
2264 CaptureStderr();
2265 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2266 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2267}
2268
Jiyong Park8c380532018-08-30 14:55:26 +09002269TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002270 const string expected_stderr =
2271 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2272 "dir1/q/IBar.aidl\n"
2273 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002274 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002275 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2276 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2277 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2278 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2279
Devin Moore097a3ab2020-03-11 16:08:44 -07002280 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002281 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002282 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002283}
2284
Jiyong Parked65bf42018-08-28 15:43:27 +09002285TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002286 const string expected_stderr =
2287 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2288 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002289 Options options = Options::From("aidl --checkapi old new");
2290 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2291 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002292
2293 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2294
Jiyong Parke59c3682018-09-11 23:10:25 +09002295 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002296 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002297 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002298 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002299}
2300
Jiyong Parke05195e2018-10-08 18:24:23 +09002301TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2302 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2303 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002304 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002305
2306 // use without import
2307 io_delegate_.SetFileContents("p/IFoo.aidl",
2308 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2309 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2310 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002311 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002312
Devin Moore7b8d5c92020-03-17 14:14:08 -07002313 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002314 io_delegate_.SetFileContents(
2315 "p/IFoo.aidl",
2316 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2317 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2318 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002319 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002320
2321 // use with import (as before)
2322 io_delegate_.SetFileContents("p/IFoo.aidl",
2323 "package p;"
2324 "import android.os.ParcelFileDescriptor;"
2325 "interface IFoo{"
2326 " void foo(in ParcelFileDescriptor fd);"
2327 "}");
2328 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2329 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002330 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002331}
Jiyong Parked65bf42018-08-28 15:43:27 +09002332
Jiyong Park3633b722019-04-11 15:38:26 +09002333TEST_F(AidlTest, ManualIds) {
2334 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2335 io_delegate_.SetFileContents("IFoo.aidl",
2336 "interface IFoo {\n"
2337 " void foo() = 0;\n"
2338 " void bar() = 1;\n"
2339 "}");
2340 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2341}
2342
2343TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2344 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2345 io_delegate_.SetFileContents("IFoo.aidl",
2346 "interface IFoo {\n"
2347 " void foo() = 0;\n"
2348 " void bar() = 1;\n"
2349 "}");
2350 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2351}
2352
2353TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002354 const string expected_stderr =
2355 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002356 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2357 io_delegate_.SetFileContents("IFoo.aidl",
2358 "interface IFoo {\n"
2359 " void foo() = 3;\n"
2360 " void bar() = 3;\n"
2361 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002363 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002365}
2366
2367TEST_F(AidlTest, FailOnOutOfRangeIds) {
2368 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 const string expected_stderr =
2370 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2371 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002372 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2373 io_delegate_.SetFileContents("IFoo.aidl",
2374 "interface IFoo {\n"
2375 " void foo() = 3;\n"
2376 " void bar() = 16777115;\n"
2377 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002378 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002379 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002381}
2382
2383TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002384 const string expected_stderr =
2385 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002386 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2387 io_delegate_.SetFileContents("IFoo.aidl",
2388 "interface IFoo {\n"
2389 " void foo() = 3;\n"
2390 " void bar();\n"
2391 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002392 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002393 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002394 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002395}
2396
Jiyong Parkc6816252019-07-08 08:12:28 +09002397TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2398 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2399 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2400 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2401 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2402}
2403
2404TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002405 const string expected_stderr =
2406 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2407 "dir/IBar.aidl\n"
2408 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002409 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002410
Jiyong Parkc6816252019-07-08 08:12:28 +09002411 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2412 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2413 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2414 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002415 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002416 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002418}
2419
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002420TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2421 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2422 "package a.b;\n"
2423 "import a.b.IBar;\n"
2424 "import a.b.IQux;\n"
2425 "interface IFoo { IQux foo(); }\n");
2426 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2427 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2428
2429 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2430 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2431
2432 string output;
2433 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2434 // IBar was imported but wasn't used. include is not expected.
2435 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2436 // IBar was imported and used. include is expected.
2437 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2438}
2439
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002440TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002441 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002442 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002443 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2444 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002445 interface IFoo {
2446 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002447 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002448 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002449 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002450 // JavaPassthrough should work with other types as well (e.g. enum)
2451 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2452 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2453 @JavaPassthrough(annotation="@com.android.AliceTwo")
2454 @Backing(type="byte")
2455 enum MyEnum {
2456 a, b, c
2457 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002458
Jooyung Han4cde01d2020-10-13 11:10:47 +09002459 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002460 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2461
2462 string java_out;
2463 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002464 // type-decl-level annotations with newline at the end
2465 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2466 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2467 // member-decl-level annotations with newline at the end
2468 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2469 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2470 // inline annotations with space at the end
2471 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002472
Jooyung Han4cde01d2020-10-13 11:10:47 +09002473 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2474 // type-decl-level annotations with newline at the end
2475 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2476 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2477
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002478 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002479 Options cpp_options =
2480 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002481 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2482
Jooyung Han4cde01d2020-10-13 11:10:47 +09002483 Options ndk_options =
2484 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002485 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002486
Jooyung Han4cde01d2020-10-13 11:10:47 +09002487 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002488 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002489}
2490
Andrei Homescue61feb52020-08-18 15:44:24 -07002491TEST_F(AidlTest, ParseRustDerive) {
2492 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2493 @RustDerive(Clone=true, Copy=false)
2494 parcelable Foo {
2495 int a;
2496 })");
2497
2498 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2499 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2500
2501 string rust_out;
2502 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2503 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2504
2505 // Other backends shouldn't be bothered
2506 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2507 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2508
2509 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2510 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2511
2512 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2513 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2514}
2515
Jiyong Park56f73d72019-06-11 12:20:28 +09002516class AidlOutputPathTest : public AidlTest {
2517 protected:
2518 void SetUp() override {
2519 AidlTest::SetUp();
2520 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2521 }
2522
2523 void Test(const Options& options, const std::string expected_output_path) {
2524 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2525 // check the existence
2526 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2527 }
2528};
2529
2530TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2531 // <out_dir> / <package_name> / <type_name>.java
2532 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2533}
2534
2535TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2536 // when output file is explicitly set, it is always respected. -o option is
2537 // ignored.
2538 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2539}
2540
2541TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2542 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2543}
2544
2545TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2546 // output is the same as the input file except for the suffix
2547 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2548}
2549
Devin Moore7b8d5c92020-03-17 14:14:08 -07002550TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002551 AidlError error;
2552 const string expected_stderr =
2553 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2554 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002555 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2556 R"(package p;
2557 interface IFoo {
2558 const int int32_max_oob = 2147483650;
2559 }
2560 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002561 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002562 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2563 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002564}
2565
Devin Moore7b8d5c92020-03-17 14:14:08 -07002566TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 AidlError error;
2568 const string expected_stderr =
2569 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2570 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002571 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2572 R"(package p;
2573 interface IFoo {
2574 const int int32_min_oob = -2147483650;
2575 }
2576 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002577 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002578 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2579 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002580}
2581
Devin Moore7b8d5c92020-03-17 14:14:08 -07002582TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002583 AidlError error;
2584 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002585 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002586 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002587 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2588 R"(package p;
2589 interface IFoo {
2590 const long int64_max_oob = 21474836509999999999999999;
2591 }
2592 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002593 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002594 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2595 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002596}
2597
Devin Moore7b8d5c92020-03-17 14:14:08 -07002598TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002599 AidlError error;
2600 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002601 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002602 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002603 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2604 R"(package p;
2605 interface IFoo {
2606 const long int64_min_oob = -21474836509999999999999999;
2607 }
2608 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002609 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002610 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2611 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002612}
2613
Devin Moore7b8d5c92020-03-17 14:14:08 -07002614TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002615 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002616 const string expected_stderr =
2617 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2618 "literal: byte\n"
2619 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2620 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002621 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2622 R"(package p;
2623 @Backing(type="byte")
2624 enum TestEnum {
2625 FOO = 127,
2626 BAR,
2627 }
2628 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002629 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002630 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002631 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002632}
2633
Devin Mooredecaf292020-04-30 09:16:40 -07002634TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2635 AidlError error;
2636 const string expected_stderr =
2637 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2638 "be one of: type\n"
2639 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2640 "be one of: type\n";
2641 CaptureStderr();
2642 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2643 R"(package p;
2644 @Backing(foo="byte")
2645 enum TestEnum {
2646 FOO = 1,
2647 BAR,
2648 }
2649 )",
2650 typenames_, GetLanguage(), &error));
2651 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2652 EXPECT_EQ(AidlError::BAD_TYPE, error);
2653}
2654
Jeongik Chad0a10272020-08-06 16:33:36 +09002655TEST_P(AidlTest, SupportJavaOnlyImmutableAnnotation) {
2656 io_delegate_.SetFileContents("Foo.aidl",
2657 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2658 "Map<String, Baz> d; Bar[] e; }");
2659 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2660 io_delegate_.SetFileContents("Baz.aidl",
2661 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002662 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2663 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2664}
2665
Jeongik Chad0a10272020-08-06 16:33:36 +09002666TEST_P(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
2667 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002668 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2669 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2670 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2671}
2672
2673TEST_P(AidlTest, ImmtuableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002674 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002675 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2676 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2678}
2679
2680TEST_P(AidlTest, ImmtuableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002681 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002682 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2683 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2684 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2685}
2686
Jeongik Cha91180252020-07-31 15:43:11 +09002687TEST_P(AidlTest, ImmtuableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002688 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002689 Options options = Options::From("aidl --lang=java Foo.aidl");
2690 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002691 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002692 "capitalizing the first letter\n";
2693 CaptureStderr();
2694 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2695 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2696}
Devin Moore53fc99c2020-08-12 08:07:52 -07002697
Jooyung Han1f14ab32020-10-14 13:48:29 +09002698const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2699
2700#include <a/ByteEnum.h>
2701#include <binder/Parcel.h>
2702#include <binder/Status.h>
2703#include <cstdint>
2704#include <utility>
2705#include <variant>
2706#include <vector>
2707
2708namespace a {
2709
2710class Foo : public ::android::Parcelable {
2711public:
2712 inline bool operator!=([[maybe_unused]] const Foo& rhs) const {
2713 return _value!=rhs._value;
2714 }
2715 inline bool operator<([[maybe_unused]] const Foo& rhs) const {
2716 return _value<rhs._value;
2717 }
2718 inline bool operator<=([[maybe_unused]] const Foo& rhs) const {
2719 return _value<=rhs._value;
2720 }
2721 inline bool operator==([[maybe_unused]] const Foo& rhs) const {
2722 return _value==rhs._value;
2723 }
2724 inline bool operator>([[maybe_unused]] const Foo& rhs) const {
2725 return _value>rhs._value;
2726 }
2727 inline bool operator>=([[maybe_unused]] const Foo& rhs) const {
2728 return _value>=rhs._value;
2729 }
2730 enum Tag : int32_t {
2731 // int[] ns
2732 ns = 0,
2733 // a.ByteEnum e
2734 e,
2735 };
2736 template<typename _Tp>
2737 static constexpr bool not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
2738
2739 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
2740 Foo(const Foo& other) = default;
2741 Foo(Foo&& other) = default;
2742 Foo& operator=(const Foo&) = default;
2743 Foo& operator=(Foo&&) = default;
2744
2745 template <typename T, std::enable_if_t<not_self<T>, int> = 0>
2746 constexpr Foo(T&& arg)
2747 : _value(std::forward<T>(arg)) {}
2748 template <typename... T>
2749 constexpr explicit Foo(T&&... args)
2750 : _value(std::forward<T>(args)...) {}
2751 template <Tag tag, typename... T>
2752 static Foo make(T&&... args) {
2753 return Foo(std::in_place_index<tag>, std::forward<T>(args)...);
2754 }
2755 template <Tag tag, typename T, typename... U>
2756 static Foo make(std::initializer_list<T> il, U&&... args) {
2757 return Foo(std::in_place_index<tag>, std::move(il), std::forward<U>(args)...);
2758 }
2759
2760 Tag getTag() const {
2761 return (Tag)_value.index();
2762 }
2763
2764 template <Tag tag>
2765 const auto& get() const {
2766 if (getTag() != tag) { abort(); }
2767 return std::get<tag>(_value);
2768 }
2769
2770 template <Tag tag>
2771 auto& get() {
2772 if (getTag() != tag) { abort(); }
2773 return std::get<tag>(_value);
2774 }
2775
2776 template <Tag tag, typename... T>
2777 void set(T&&... args) {
2778 _value.emplace<tag>(std::forward<T>(args)...);
2779 }
2780
2781 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2782 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2783 static const std::string& getParcelableDescriptor() {
2784 static const std::string DESCIPTOR = "a.Foo";
2785 return DESCIPTOR;
2786 }
2787private:
2788 std::variant<::std::vector<int32_t>,::a::ByteEnum> _value;
2789}; // class Foo
2790
2791} // namespace a
2792)";
2793
2794const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2795
2796namespace a {
2797
2798::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2799 ::android::status_t _aidl_ret_status;
2800 int32_t _aidl_tag;
2801 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2802 switch (_aidl_tag) {
2803 case ns: {
2804 ::std::vector<int32_t> _aidl_value;
2805 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2806 set<ns>(std::move(_aidl_value));
2807 return ::android::OK; }
2808 case e: {
2809 ::a::ByteEnum _aidl_value;
2810 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2811 set<e>(std::move(_aidl_value));
2812 return ::android::OK; }
2813 }
2814 return ::android::BAD_VALUE;
2815}
2816
2817::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2818 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2819 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2820 switch (getTag()) {
2821 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2822 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
2823 }
2824 abort();
2825}
2826
2827} // namespace a
2828)";
2829
2830const char kUnionExampleExpectedOutputJava[] = R"(/*
2831 * This file is auto-generated. DO NOT MODIFY.
2832 */
2833package a;
2834
2835
2836public final class Foo implements android.os.Parcelable {
2837 // tags union fields
2838 public final static int ns = 0; // int[]
2839 public final static int e = 1; // a.ByteEnum
2840
2841 private int _tag;
2842 private Object _value;
2843
2844 public Foo() {
2845 int[] value = {42};
2846 _set(ns, value);
2847 }
2848 private Foo(android.os.Parcel _aidl_parcel) {
2849 readFromParcel(_aidl_parcel);
2850 }
2851 private Foo(int tag, Object value) {
2852 _set(tag, value);
2853 }
2854
2855 public int getTag() {
2856 return _tag;
2857 }
2858
2859 // int[] ns
2860
2861 public static Foo ns(int[] _value) {
2862 return new Foo(ns, _value);
2863 }
2864 public int[] getNs() {
2865 _assertTag(ns);
2866 return (int[]) _value;
2867 }
2868 public void setNs(int[] _value) {
2869 _set(ns, _value);
2870 }
2871
2872 // a.ByteEnum e
2873
2874 public static Foo e(byte _value) {
2875 return new Foo(e, _value);
2876 }
2877 public byte getE() {
2878 _assertTag(e);
2879 return (byte) _value;
2880 }
2881 public void setE(byte _value) {
2882 _set(e, _value);
2883 }
2884
2885 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
2886 @Override
2887 public Foo createFromParcel(android.os.Parcel _aidl_source) {
2888 return new Union(_aidl_source);
2889 }
2890 @Override
2891 public Foo[] newArray(int _aidl_size) {
2892 return new Foo[_aidl_size];
2893 }
2894 };
2895 @Override
2896 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
2897 _aidl_parcel.writeInt(_tag);
2898 switch (_tag) {
2899 case ns:
2900 _aidl_parcel.writeIntArray(getNs());
2901 break;
2902 case e:
2903 _aidl_parcel.writeByte(getE());
2904 break;
2905 }
2906 }
2907 public void readFromParcel(android.os.Parcel _aidl_parcel) {
2908 int _aidl_tag;
2909 _aidl_tag = _aidl_parcel.readInt();
2910 switch (_aidl_tag) {
2911 case ns: {
2912 int[] _aidl_value;
2913 _aidl_value = _aidl_parcel.createIntArray();
2914 _set(_aidl_tag, _aidl_value);
2915 return; }
2916 case e: {
2917 byte _aidl_value;
2918 _aidl_value = _aidl_parcel.readByte();
2919 _set(_aidl_tag, _aidl_value);
2920 return; }
2921 }
2922 throw new RuntimeException("union: out of range: " + _aidl_tag);
2923 }
2924 @Override
2925 public int describeContents() {
2926 return 0;
2927 }
2928
2929 private void _assertTag(int tag) {
2930 if (getTag() != tag) {
2931 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(tag) + " is available.");
2932 }
2933 }
2934 private String _tagString(int _tag) {
2935 switch (_tag) {
2936 case ns: return "ns";
2937 case e: return "e";
2938 }
2939 throw new IllegalStateException("unknown field: " + _tag);
2940 }
2941 private void _set(int tag, Object value) {
2942 this._tag = tag;
2943 this._value = value;
2944 }
2945}
2946)";
2947
2948TEST_F(AidlTest, UnionExample) {
2949 io_delegate_.SetFileContents("a/Foo.aidl", R"(
2950package a;
2951import a.ByteEnum;
2952union Foo {
2953 int[] ns = {42};
2954 ByteEnum e;
2955}
2956)");
2957 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
2958package a;
2959@Backing(type="byte")
2960enum ByteEnum {
2961 a, b, c
2962}
2963)");
2964
2965 auto EXPECT_COMPILE_OUTPUT = [&](string lang, auto output) {
2966 auto opts = Options::From("aidl a/Foo.aidl -I . --out=out --header_out=out --lang=" + lang);
2967 CaptureStderr();
2968 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
2969 auto err = GetCapturedStderr();
2970 EXPECT_EQ(0, ret) << err;
2971 for (const auto& [path, expected] : output) {
2972 string actual;
2973 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
2974 EXPECT_EQ(expected, actual);
2975 }
2976 };
2977
2978 EXPECT_COMPILE_OUTPUT(
2979 "cpp", map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
2980 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
2981 EXPECT_COMPILE_OUTPUT("java",
2982 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
2983 // TODO(b/170784707) NDK
2984 // TODO(b/170689477) Rust
2985}
2986
Jooyung Hanfe89f122020-10-14 03:49:18 +09002987TEST_P(AidlTest, UnionRejectsEmptyDecl) {
2988 const string method = "package a; union Foo {}";
2989 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
2990 CaptureStderr();
2991 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
2992 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
2993}
2994
2995TEST_P(AidlTest, UnionRejectsParcelableHolder) {
2996 const string method = "package a; union Foo { ParcelableHolder x; }";
2997 const string expected_stderr =
2998 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
2999 CaptureStderr();
3000 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3001 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3002}
3003
Devin Moore53fc99c2020-08-12 08:07:52 -07003004TEST_P(AidlTest, GenericStructuredParcelable) {
3005 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3006 Options options =
3007 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3008 const string expected_stderr = "";
3009 CaptureStderr();
3010 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3011 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3012}
3013
3014TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3015 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3016 Options options =
3017 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3018 const string expected_stderr =
3019 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3020 CaptureStderr();
3021 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3022 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3023}
3024
3025TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3026 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3027 Options options =
3028 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3029 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3030 CaptureStderr();
3031 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3032 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3033}
3034
Christopher Wiley90be4e32015-10-20 14:55:25 -07003035} // namespace aidl
3036} // namespace android