blob: 02ebb5ef294681473a8a4592ccba602c4b195944 [file] [log] [blame]
Chris Lattnera65e2f72010-01-05 05:57:49 +00001//===- InstCombineLoadStoreAlloca.cpp -------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visit functions for load, store and alloca.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Yaxun Liuba01ed02017-02-10 21:46:07 +000015#include "llvm/ADT/MapVector.h"
NAKAMURA Takumiec6b1fc2015-12-15 09:37:31 +000016#include "llvm/ADT/SmallString.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000017#include "llvm/ADT/Statistic.h"
Dan Gohman826bdf82010-05-28 16:19:17 +000018#include "llvm/Analysis/Loads.h"
David Blaikie31b98d22018-06-04 21:23:21 +000019#include "llvm/Transforms/Utils/Local.h"
Peter Collingbourneecdd58f2016-10-21 19:59:26 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Vedant Kumar238533e2018-11-19 19:55:02 +000022#include "llvm/IR/DebugInfoMetadata.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Yaxun Liuba01ed02017-02-10 21:46:07 +000024#include "llvm/IR/LLVMContext.h"
Charles Davis33d1dc02015-02-25 05:10:25 +000025#include "llvm/IR/MDBuilder.h"
Alexey Bataevec95c6c2017-12-08 15:32:10 +000026#include "llvm/IR/PatternMatch.h"
Chris Lattnera65e2f72010-01-05 05:57:49 +000027#include "llvm/Transforms/Utils/BasicBlockUtils.h"
Chris Lattnera65e2f72010-01-05 05:57:49 +000028using namespace llvm;
Alexey Bataevec95c6c2017-12-08 15:32:10 +000029using namespace PatternMatch;
Chris Lattnera65e2f72010-01-05 05:57:49 +000030
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Chandler Carruthc908ca12012-08-21 08:39:44 +000033STATISTIC(NumDeadStore, "Number of dead stores eliminated");
34STATISTIC(NumGlobalCopies, "Number of allocas copied from constant global");
35
36/// pointsToConstantGlobal - Return true if V (possibly indirectly) points to
37/// some part of a constant global variable. This intentionally only accepts
38/// constant expressions because we can't rewrite arbitrary instructions.
39static bool pointsToConstantGlobal(Value *V) {
40 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(V))
41 return GV->isConstant();
Matt Arsenault607281772014-04-24 00:01:09 +000042
43 if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) {
Chandler Carruthc908ca12012-08-21 08:39:44 +000044 if (CE->getOpcode() == Instruction::BitCast ||
Matt Arsenault607281772014-04-24 00:01:09 +000045 CE->getOpcode() == Instruction::AddrSpaceCast ||
Chandler Carruthc908ca12012-08-21 08:39:44 +000046 CE->getOpcode() == Instruction::GetElementPtr)
47 return pointsToConstantGlobal(CE->getOperand(0));
Matt Arsenault607281772014-04-24 00:01:09 +000048 }
Chandler Carruthc908ca12012-08-21 08:39:44 +000049 return false;
50}
51
52/// isOnlyCopiedFromConstantGlobal - Recursively walk the uses of a (derived)
53/// pointer to an alloca. Ignore any reads of the pointer, return false if we
54/// see any stores or other unknown uses. If we see pointer arithmetic, keep
55/// track of whether it moves the pointer (with IsOffset) but otherwise traverse
56/// the uses. If we see a memcpy/memmove that targets an unoffseted pointer to
57/// the alloca, and if the source pointer is a pointer to a constant global, we
58/// can optimize this.
59static bool
60isOnlyCopiedFromConstantGlobal(Value *V, MemTransferInst *&TheCopy,
Reid Kleckner813dab22014-07-01 21:36:20 +000061 SmallVectorImpl<Instruction *> &ToDelete) {
Chandler Carruthc908ca12012-08-21 08:39:44 +000062 // We track lifetime intrinsics as we encounter them. If we decide to go
63 // ahead and replace the value with the global, this lets the caller quickly
64 // eliminate the markers.
65
Reid Kleckner813dab22014-07-01 21:36:20 +000066 SmallVector<std::pair<Value *, bool>, 35> ValuesToInspect;
David Majnemer0a16c222016-08-11 21:15:00 +000067 ValuesToInspect.emplace_back(V, false);
Reid Kleckner813dab22014-07-01 21:36:20 +000068 while (!ValuesToInspect.empty()) {
69 auto ValuePair = ValuesToInspect.pop_back_val();
70 const bool IsOffset = ValuePair.second;
71 for (auto &U : ValuePair.first->uses()) {
David Majnemer0a16c222016-08-11 21:15:00 +000072 auto *I = cast<Instruction>(U.getUser());
Chandler Carruthc908ca12012-08-21 08:39:44 +000073
David Majnemer0a16c222016-08-11 21:15:00 +000074 if (auto *LI = dyn_cast<LoadInst>(I)) {
Reid Kleckner813dab22014-07-01 21:36:20 +000075 // Ignore non-volatile loads, they are always ok.
76 if (!LI->isSimple()) return false;
Chandler Carruthc908ca12012-08-21 08:39:44 +000077 continue;
78 }
Reid Kleckner813dab22014-07-01 21:36:20 +000079
80 if (isa<BitCastInst>(I) || isa<AddrSpaceCastInst>(I)) {
81 // If uses of the bitcast are ok, we are ok.
David Majnemer0a16c222016-08-11 21:15:00 +000082 ValuesToInspect.emplace_back(I, IsOffset);
Reid Kleckner813dab22014-07-01 21:36:20 +000083 continue;
84 }
David Majnemer0a16c222016-08-11 21:15:00 +000085 if (auto *GEP = dyn_cast<GetElementPtrInst>(I)) {
Reid Kleckner813dab22014-07-01 21:36:20 +000086 // If the GEP has all zero indices, it doesn't offset the pointer. If it
87 // doesn't, it does.
David Majnemer0a16c222016-08-11 21:15:00 +000088 ValuesToInspect.emplace_back(I, IsOffset || !GEP->hasAllZeroIndices());
Reid Kleckner813dab22014-07-01 21:36:20 +000089 continue;
90 }
91
Benjamin Kramer3a09ef62015-04-10 14:50:08 +000092 if (auto CS = CallSite(I)) {
Reid Kleckner813dab22014-07-01 21:36:20 +000093 // If this is the function being called then we treat it like a load and
94 // ignore it.
95 if (CS.isCallee(&U))
96 continue;
97
David Majnemer02f47872015-12-23 09:58:41 +000098 unsigned DataOpNo = CS.getDataOperandNo(&U);
99 bool IsArgOperand = CS.isArgOperand(&U);
100
Reid Kleckner813dab22014-07-01 21:36:20 +0000101 // Inalloca arguments are clobbered by the call.
David Majnemer02f47872015-12-23 09:58:41 +0000102 if (IsArgOperand && CS.isInAllocaArgument(DataOpNo))
Reid Kleckner813dab22014-07-01 21:36:20 +0000103 return false;
104
105 // If this is a readonly/readnone call site, then we know it is just a
106 // load (but one that potentially returns the value itself), so we can
107 // ignore it if we know that the value isn't captured.
108 if (CS.onlyReadsMemory() &&
David Majnemer02f47872015-12-23 09:58:41 +0000109 (CS.getInstruction()->use_empty() || CS.doesNotCapture(DataOpNo)))
Reid Kleckner813dab22014-07-01 21:36:20 +0000110 continue;
111
112 // If this is being passed as a byval argument, the caller is making a
113 // copy, so it is only a read of the alloca.
David Majnemer02f47872015-12-23 09:58:41 +0000114 if (IsArgOperand && CS.isByValArgument(DataOpNo))
Reid Kleckner813dab22014-07-01 21:36:20 +0000115 continue;
116 }
117
118 // Lifetime intrinsics can be handled by the caller.
119 if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) {
120 if (II->getIntrinsicID() == Intrinsic::lifetime_start ||
121 II->getIntrinsicID() == Intrinsic::lifetime_end) {
122 assert(II->use_empty() && "Lifetime markers have no result to use!");
123 ToDelete.push_back(II);
124 continue;
125 }
126 }
127
128 // If this is isn't our memcpy/memmove, reject it as something we can't
129 // handle.
130 MemTransferInst *MI = dyn_cast<MemTransferInst>(I);
131 if (!MI)
132 return false;
133
134 // If the transfer is using the alloca as a source of the transfer, then
135 // ignore it since it is a load (unless the transfer is volatile).
136 if (U.getOperandNo() == 1) {
137 if (MI->isVolatile()) return false;
138 continue;
139 }
140
141 // If we already have seen a copy, reject the second one.
142 if (TheCopy) return false;
143
144 // If the pointer has been offset from the start of the alloca, we can't
145 // safely handle this.
146 if (IsOffset) return false;
147
148 // If the memintrinsic isn't using the alloca as the dest, reject it.
149 if (U.getOperandNo() != 0) return false;
150
151 // If the source of the memcpy/move is not a constant global, reject it.
152 if (!pointsToConstantGlobal(MI->getSource()))
153 return false;
154
155 // Otherwise, the transform is safe. Remember the copy instruction.
156 TheCopy = MI;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000157 }
Chandler Carruthc908ca12012-08-21 08:39:44 +0000158 }
159 return true;
160}
161
162/// isOnlyCopiedFromConstantGlobal - Return true if the specified alloca is only
163/// modified by a copy from a constant global. If we can prove this, we can
164/// replace any uses of the alloca with uses of the global directly.
165static MemTransferInst *
166isOnlyCopiedFromConstantGlobal(AllocaInst *AI,
167 SmallVectorImpl<Instruction *> &ToDelete) {
Craig Topperf40110f2014-04-25 05:29:35 +0000168 MemTransferInst *TheCopy = nullptr;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000169 if (isOnlyCopiedFromConstantGlobal(AI, TheCopy, ToDelete))
170 return TheCopy;
Craig Topperf40110f2014-04-25 05:29:35 +0000171 return nullptr;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000172}
173
Vitaly Bukadf19ad42017-06-24 01:35:19 +0000174/// Returns true if V is dereferenceable for size of alloca.
175static bool isDereferenceableForAllocaSize(const Value *V, const AllocaInst *AI,
176 const DataLayout &DL) {
177 if (AI->isArrayAllocation())
178 return false;
179 uint64_t AllocaSize = DL.getTypeStoreSize(AI->getAllocatedType());
180 if (!AllocaSize)
181 return false;
182 return isDereferenceableAndAlignedPointer(V, AI->getAlignment(),
183 APInt(64, AllocaSize), DL);
184}
185
Duncan P. N. Exon Smithc6820ec2015-03-13 19:22:03 +0000186static Instruction *simplifyAllocaArraySize(InstCombiner &IC, AllocaInst &AI) {
Duncan P. N. Exon Smith720762e2015-03-13 19:30:44 +0000187 // Check for array size of 1 (scalar allocation).
Duncan P. N. Exon Smithbe95b4a2015-03-13 19:42:09 +0000188 if (!AI.isArrayAllocation()) {
189 // i32 1 is the canonical array size for scalar allocations.
190 if (AI.getArraySize()->getType()->isIntegerTy(32))
191 return nullptr;
192
193 // Canonicalize it.
Craig Topperbb4069e2017-07-07 23:16:26 +0000194 Value *V = IC.Builder.getInt32(1);
Duncan P. N. Exon Smithbe95b4a2015-03-13 19:42:09 +0000195 AI.setOperand(0, V);
196 return &AI;
197 }
Duncan P. N. Exon Smith720762e2015-03-13 19:30:44 +0000198
Chris Lattnera65e2f72010-01-05 05:57:49 +0000199 // Convert: alloca Ty, C - where C is a constant != 1 into: alloca [C x Ty], 1
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000200 if (const ConstantInt *C = dyn_cast<ConstantInt>(AI.getArraySize())) {
Simon Pilgrim82edf8d2018-08-13 16:50:20 +0000201 if (C->getValue().getActiveBits() <= 64) {
202 Type *NewTy = ArrayType::get(AI.getAllocatedType(), C->getZExtValue());
203 AllocaInst *New = IC.Builder.CreateAlloca(NewTy, nullptr, AI.getName());
204 New->setAlignment(AI.getAlignment());
Chris Lattnera65e2f72010-01-05 05:57:49 +0000205
Simon Pilgrim82edf8d2018-08-13 16:50:20 +0000206 // Scan to the end of the allocation instructions, to skip over a block of
207 // allocas if possible...also skip interleaved debug info
208 //
209 BasicBlock::iterator It(New);
210 while (isa<AllocaInst>(*It) || isa<DbgInfoIntrinsic>(*It))
211 ++It;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000212
Simon Pilgrim82edf8d2018-08-13 16:50:20 +0000213 // Now that I is pointing to the first non-allocation-inst in the block,
214 // insert our getelementptr instruction...
215 //
216 Type *IdxTy = IC.getDataLayout().getIntPtrType(AI.getType());
217 Value *NullIdx = Constant::getNullValue(IdxTy);
218 Value *Idx[2] = {NullIdx, NullIdx};
219 Instruction *GEP =
220 GetElementPtrInst::CreateInBounds(New, Idx, New->getName() + ".sub");
221 IC.InsertNewInstBefore(GEP, *It);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000222
Simon Pilgrim82edf8d2018-08-13 16:50:20 +0000223 // Now make everything use the getelementptr instead of the original
224 // allocation.
225 return IC.replaceInstUsesWith(AI, GEP);
226 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000227 }
228
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000229 if (isa<UndefValue>(AI.getArraySize()))
Sanjay Patel4b198802016-02-01 22:23:39 +0000230 return IC.replaceInstUsesWith(AI, Constant::getNullValue(AI.getType()));
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000231
Duncan P. N. Exon Smith07ff9b02015-03-13 19:34:55 +0000232 // Ensure that the alloca array size argument has type intptr_t, so that
233 // any casting is exposed early.
234 Type *IntPtrTy = IC.getDataLayout().getIntPtrType(AI.getType());
235 if (AI.getArraySize()->getType() != IntPtrTy) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000236 Value *V = IC.Builder.CreateIntCast(AI.getArraySize(), IntPtrTy, false);
Duncan P. N. Exon Smith07ff9b02015-03-13 19:34:55 +0000237 AI.setOperand(0, V);
238 return &AI;
239 }
240
Duncan P. N. Exon Smithc6820ec2015-03-13 19:22:03 +0000241 return nullptr;
242}
243
Benjamin Kramer03ab8a32017-02-10 22:26:35 +0000244namespace {
Yaxun Liuba01ed02017-02-10 21:46:07 +0000245// If I and V are pointers in different address space, it is not allowed to
246// use replaceAllUsesWith since I and V have different types. A
247// non-target-specific transformation should not use addrspacecast on V since
248// the two address space may be disjoint depending on target.
249//
250// This class chases down uses of the old pointer until reaching the load
251// instructions, then replaces the old pointer in the load instructions with
252// the new pointer. If during the chasing it sees bitcast or GEP, it will
253// create new bitcast or GEP with the new pointer and use them in the load
254// instruction.
255class PointerReplacer {
256public:
257 PointerReplacer(InstCombiner &IC) : IC(IC) {}
258 void replacePointer(Instruction &I, Value *V);
259
260private:
261 void findLoadAndReplace(Instruction &I);
262 void replace(Instruction *I);
263 Value *getReplacement(Value *I);
264
265 SmallVector<Instruction *, 4> Path;
266 MapVector<Value *, Value *> WorkMap;
267 InstCombiner &IC;
268};
Benjamin Kramer03ab8a32017-02-10 22:26:35 +0000269} // end anonymous namespace
Yaxun Liuba01ed02017-02-10 21:46:07 +0000270
271void PointerReplacer::findLoadAndReplace(Instruction &I) {
272 for (auto U : I.users()) {
273 auto *Inst = dyn_cast<Instruction>(&*U);
274 if (!Inst)
275 return;
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000276 LLVM_DEBUG(dbgs() << "Found pointer user: " << *U << '\n');
Yaxun Liuba01ed02017-02-10 21:46:07 +0000277 if (isa<LoadInst>(Inst)) {
278 for (auto P : Path)
279 replace(P);
280 replace(Inst);
281 } else if (isa<GetElementPtrInst>(Inst) || isa<BitCastInst>(Inst)) {
282 Path.push_back(Inst);
283 findLoadAndReplace(*Inst);
284 Path.pop_back();
285 } else {
286 return;
287 }
288 }
289}
290
291Value *PointerReplacer::getReplacement(Value *V) {
292 auto Loc = WorkMap.find(V);
293 if (Loc != WorkMap.end())
294 return Loc->second;
295 return nullptr;
296}
297
298void PointerReplacer::replace(Instruction *I) {
299 if (getReplacement(I))
300 return;
301
302 if (auto *LT = dyn_cast<LoadInst>(I)) {
303 auto *V = getReplacement(LT->getPointerOperand());
304 assert(V && "Operand not replaced");
305 auto *NewI = new LoadInst(V);
306 NewI->takeName(LT);
307 IC.InsertNewInstWith(NewI, *LT);
308 IC.replaceInstUsesWith(*LT, NewI);
309 WorkMap[LT] = NewI;
310 } else if (auto *GEP = dyn_cast<GetElementPtrInst>(I)) {
311 auto *V = getReplacement(GEP->getPointerOperand());
312 assert(V && "Operand not replaced");
313 SmallVector<Value *, 8> Indices;
314 Indices.append(GEP->idx_begin(), GEP->idx_end());
315 auto *NewI = GetElementPtrInst::Create(
316 V->getType()->getPointerElementType(), V, Indices);
317 IC.InsertNewInstWith(NewI, *GEP);
318 NewI->takeName(GEP);
319 WorkMap[GEP] = NewI;
320 } else if (auto *BC = dyn_cast<BitCastInst>(I)) {
321 auto *V = getReplacement(BC->getOperand(0));
322 assert(V && "Operand not replaced");
323 auto *NewT = PointerType::get(BC->getType()->getPointerElementType(),
324 V->getType()->getPointerAddressSpace());
325 auto *NewI = new BitCastInst(V, NewT);
326 IC.InsertNewInstWith(NewI, *BC);
327 NewI->takeName(BC);
Yaxun Liue6d1ce52017-02-24 20:27:25 +0000328 WorkMap[BC] = NewI;
Yaxun Liuba01ed02017-02-10 21:46:07 +0000329 } else {
330 llvm_unreachable("should never reach here");
331 }
332}
333
334void PointerReplacer::replacePointer(Instruction &I, Value *V) {
Benjamin Kramer684c87b2017-02-10 22:04:17 +0000335#ifndef NDEBUG
Yaxun Liuba01ed02017-02-10 21:46:07 +0000336 auto *PT = cast<PointerType>(I.getType());
337 auto *NT = cast<PointerType>(V->getType());
338 assert(PT != NT && PT->getElementType() == NT->getElementType() &&
339 "Invalid usage");
Benjamin Kramer684c87b2017-02-10 22:04:17 +0000340#endif
Yaxun Liuba01ed02017-02-10 21:46:07 +0000341 WorkMap[&I] = V;
342 findLoadAndReplace(I);
343}
344
Duncan P. N. Exon Smithc6820ec2015-03-13 19:22:03 +0000345Instruction *InstCombiner::visitAllocaInst(AllocaInst &AI) {
346 if (auto *I = simplifyAllocaArraySize(*this, AI))
347 return I;
348
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000349 if (AI.getAllocatedType()->isSized()) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000350 // If the alignment is 0 (unspecified), assign it the preferred alignment.
351 if (AI.getAlignment() == 0)
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000352 AI.setAlignment(DL.getPrefTypeAlignment(AI.getAllocatedType()));
Duncan Sands8bc764a2012-06-26 13:39:21 +0000353
354 // Move all alloca's of zero byte objects to the entry block and merge them
355 // together. Note that we only do this for alloca's, because malloc should
356 // allocate and return a unique pointer, even for a zero byte allocation.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000357 if (DL.getTypeAllocSize(AI.getAllocatedType()) == 0) {
Duncan Sands8bc764a2012-06-26 13:39:21 +0000358 // For a zero sized alloca there is no point in doing an array allocation.
359 // This is helpful if the array size is a complicated expression not used
360 // elsewhere.
361 if (AI.isArrayAllocation()) {
362 AI.setOperand(0, ConstantInt::get(AI.getArraySize()->getType(), 1));
363 return &AI;
364 }
365
366 // Get the first instruction in the entry block.
367 BasicBlock &EntryBlock = AI.getParent()->getParent()->getEntryBlock();
368 Instruction *FirstInst = EntryBlock.getFirstNonPHIOrDbg();
369 if (FirstInst != &AI) {
370 // If the entry block doesn't start with a zero-size alloca then move
371 // this one to the start of the entry block. There is no problem with
372 // dominance as the array size was forced to a constant earlier already.
373 AllocaInst *EntryAI = dyn_cast<AllocaInst>(FirstInst);
374 if (!EntryAI || !EntryAI->getAllocatedType()->isSized() ||
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000375 DL.getTypeAllocSize(EntryAI->getAllocatedType()) != 0) {
Duncan Sands8bc764a2012-06-26 13:39:21 +0000376 AI.moveBefore(FirstInst);
377 return &AI;
378 }
379
Richard Osborneb68053e2012-09-18 09:31:44 +0000380 // If the alignment of the entry block alloca is 0 (unspecified),
381 // assign it the preferred alignment.
382 if (EntryAI->getAlignment() == 0)
383 EntryAI->setAlignment(
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000384 DL.getPrefTypeAlignment(EntryAI->getAllocatedType()));
Duncan Sands8bc764a2012-06-26 13:39:21 +0000385 // Replace this zero-sized alloca with the one at the start of the entry
386 // block after ensuring that the address will be aligned enough for both
387 // types.
Richard Osborneb68053e2012-09-18 09:31:44 +0000388 unsigned MaxAlign = std::max(EntryAI->getAlignment(),
389 AI.getAlignment());
Duncan Sands8bc764a2012-06-26 13:39:21 +0000390 EntryAI->setAlignment(MaxAlign);
391 if (AI.getType() != EntryAI->getType())
392 return new BitCastInst(EntryAI, AI.getType());
Sanjay Patel4b198802016-02-01 22:23:39 +0000393 return replaceInstUsesWith(AI, EntryAI);
Duncan Sands8bc764a2012-06-26 13:39:21 +0000394 }
395 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000396 }
397
Eli Friedmanb14873c2012-11-26 23:04:53 +0000398 if (AI.getAlignment()) {
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000399 // Check to see if this allocation is only modified by a memcpy/memmove from
400 // a constant global whose alignment is equal to or exceeds that of the
401 // allocation. If this is the case, we can change all users to use
402 // the constant global instead. This is commonly produced by the CFE by
403 // constructs like "void foo() { int A[] = {1,2,3,4,5,6,7,8,9...}; }" if 'A'
404 // is only subsequently read.
405 SmallVector<Instruction *, 4> ToDelete;
406 if (MemTransferInst *Copy = isOnlyCopiedFromConstantGlobal(&AI, ToDelete)) {
Chandler Carruth66b31302015-01-04 12:03:27 +0000407 unsigned SourceAlign = getOrEnforceKnownAlignment(
Daniel Jasperaec2fa32016-12-19 08:22:17 +0000408 Copy->getSource(), AI.getAlignment(), DL, &AI, &AC, &DT);
Vitaly Bukadf19ad42017-06-24 01:35:19 +0000409 if (AI.getAlignment() <= SourceAlign &&
410 isDereferenceableForAllocaSize(Copy->getSource(), &AI, DL)) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000411 LLVM_DEBUG(dbgs() << "Found alloca equal to global: " << AI << '\n');
412 LLVM_DEBUG(dbgs() << " memcpy = " << *Copy << '\n');
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000413 for (unsigned i = 0, e = ToDelete.size(); i != e; ++i)
Sanjay Patel4b198802016-02-01 22:23:39 +0000414 eraseInstFromFunction(*ToDelete[i]);
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000415 Constant *TheSrc = cast<Constant>(Copy->getSource());
Yaxun Liuba01ed02017-02-10 21:46:07 +0000416 auto *SrcTy = TheSrc->getType();
417 auto *DestTy = PointerType::get(AI.getType()->getPointerElementType(),
418 SrcTy->getPointerAddressSpace());
419 Constant *Cast =
420 ConstantExpr::getPointerBitCastOrAddrSpaceCast(TheSrc, DestTy);
421 if (AI.getType()->getPointerAddressSpace() ==
422 SrcTy->getPointerAddressSpace()) {
423 Instruction *NewI = replaceInstUsesWith(AI, Cast);
424 eraseInstFromFunction(*Copy);
425 ++NumGlobalCopies;
426 return NewI;
427 } else {
428 PointerReplacer PtrReplacer(*this);
429 PtrReplacer.replacePointer(AI, Cast);
430 ++NumGlobalCopies;
431 }
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000432 }
Chandler Carruthc908ca12012-08-21 08:39:44 +0000433 }
434 }
435
Nuno Lopes95cc4f32012-07-09 18:38:20 +0000436 // At last, use the generic allocation site handler to aggressively remove
437 // unused allocas.
438 return visitAllocSite(AI);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000439}
440
Philip Reames89e92d22016-12-01 20:17:06 +0000441// Are we allowed to form a atomic load or store of this type?
442static bool isSupportedAtomicType(Type *Ty) {
Vedant Kumarb3091da2018-07-06 20:17:42 +0000443 return Ty->isIntOrPtrTy() || Ty->isFloatingPointTy();
Philip Reames89e92d22016-12-01 20:17:06 +0000444}
445
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000446/// Helper to combine a load to a new type.
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000447///
448/// This just does the work of combining a load to a new type. It handles
449/// metadata, etc., and returns the new instruction. The \c NewTy should be the
450/// loaded *value* type. This will convert it to a pointer, cast the operand to
451/// that pointer type, load it, etc.
452///
453/// Note that this will create all of the instructions with whatever insert
454/// point the \c InstCombiner currently is using.
Mehdi Amini2668a482015-05-07 05:52:40 +0000455static LoadInst *combineLoadToNewType(InstCombiner &IC, LoadInst &LI, Type *NewTy,
456 const Twine &Suffix = "") {
Philip Reames89e92d22016-12-01 20:17:06 +0000457 assert((!LI.isAtomic() || isSupportedAtomicType(NewTy)) &&
458 "can't fold an atomic load to requested type");
Alexey Bataev7c9ad0d2018-05-21 17:46:34 +0000459
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000460 Value *Ptr = LI.getPointerOperand();
461 unsigned AS = LI.getPointerAddressSpace();
Duncan P. N. Exon Smithde36e802014-11-11 21:30:22 +0000462 SmallVector<std::pair<unsigned, MDNode *>, 8> MD;
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000463 LI.getAllMetadata(MD);
464
Alexey Bataev7c9ad0d2018-05-21 17:46:34 +0000465 Value *NewPtr = nullptr;
466 if (!(match(Ptr, m_BitCast(m_Value(NewPtr))) &&
467 NewPtr->getType()->getPointerElementType() == NewTy &&
468 NewPtr->getType()->getPointerAddressSpace() == AS))
469 NewPtr = IC.Builder.CreateBitCast(Ptr, NewTy->getPointerTo(AS));
470
Craig Topperbb4069e2017-07-07 23:16:26 +0000471 LoadInst *NewLoad = IC.Builder.CreateAlignedLoad(
Alexey Bataev7c9ad0d2018-05-21 17:46:34 +0000472 NewPtr, LI.getAlignment(), LI.isVolatile(), LI.getName() + Suffix);
Konstantin Zhuravlyovbb80d3e2017-07-11 22:23:00 +0000473 NewLoad->setAtomic(LI.getOrdering(), LI.getSyncScopeID());
Charles Davis33d1dc02015-02-25 05:10:25 +0000474 MDBuilder MDB(NewLoad->getContext());
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000475 for (const auto &MDPair : MD) {
476 unsigned ID = MDPair.first;
Duncan P. N. Exon Smithde36e802014-11-11 21:30:22 +0000477 MDNode *N = MDPair.second;
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000478 // Note, essentially every kind of metadata should be preserved here! This
479 // routine is supposed to clone a load instruction changing *only its type*.
480 // The only metadata it makes sense to drop is metadata which is invalidated
481 // when the pointer type changes. This should essentially never be the case
482 // in LLVM, but we explicitly switch over only known metadata to be
483 // conservatively correct. If you are adding metadata to LLVM which pertains
484 // to loads, you almost certainly want to add it here.
485 switch (ID) {
486 case LLVMContext::MD_dbg:
487 case LLVMContext::MD_tbaa:
488 case LLVMContext::MD_prof:
489 case LLVMContext::MD_fpmath:
490 case LLVMContext::MD_tbaa_struct:
491 case LLVMContext::MD_invariant_load:
492 case LLVMContext::MD_alias_scope:
493 case LLVMContext::MD_noalias:
Philip Reames5a3f5f72014-10-21 00:13:20 +0000494 case LLVMContext::MD_nontemporal:
495 case LLVMContext::MD_mem_parallel_loop_access:
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000496 // All of these directly apply.
497 NewLoad->setMetadata(ID, N);
498 break;
499
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000500 case LLVMContext::MD_nonnull:
Chandler Carruth2abb65a2017-06-26 03:31:31 +0000501 copyNonnullMetadata(LI, N, *NewLoad);
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000502 break;
Artur Pilipenko5c5011d2015-11-02 17:53:51 +0000503 case LLVMContext::MD_align:
504 case LLVMContext::MD_dereferenceable:
505 case LLVMContext::MD_dereferenceable_or_null:
506 // These only directly apply if the new type is also a pointer.
507 if (NewTy->isPointerTy())
508 NewLoad->setMetadata(ID, N);
509 break;
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000510 case LLVMContext::MD_range:
Chandler Carruth2abb65a2017-06-26 03:31:31 +0000511 copyRangeMetadata(IC.getDataLayout(), LI, N, *NewLoad);
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000512 break;
513 }
514 }
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000515 return NewLoad;
516}
517
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000518/// Combine a store to a new type.
Chandler Carruthfa11d832015-01-22 03:34:54 +0000519///
520/// Returns the newly created store instruction.
521static StoreInst *combineStoreToNewValue(InstCombiner &IC, StoreInst &SI, Value *V) {
Philip Reames89e92d22016-12-01 20:17:06 +0000522 assert((!SI.isAtomic() || isSupportedAtomicType(V->getType())) &&
523 "can't fold an atomic store of requested type");
Fangrui Songf78650a2018-07-30 19:41:25 +0000524
Chandler Carruthfa11d832015-01-22 03:34:54 +0000525 Value *Ptr = SI.getPointerOperand();
526 unsigned AS = SI.getPointerAddressSpace();
527 SmallVector<std::pair<unsigned, MDNode *>, 8> MD;
528 SI.getAllMetadata(MD);
529
Craig Topperbb4069e2017-07-07 23:16:26 +0000530 StoreInst *NewStore = IC.Builder.CreateAlignedStore(
531 V, IC.Builder.CreateBitCast(Ptr, V->getType()->getPointerTo(AS)),
Philip Reames6f4d0082016-05-06 22:17:01 +0000532 SI.getAlignment(), SI.isVolatile());
Konstantin Zhuravlyovbb80d3e2017-07-11 22:23:00 +0000533 NewStore->setAtomic(SI.getOrdering(), SI.getSyncScopeID());
Chandler Carruthfa11d832015-01-22 03:34:54 +0000534 for (const auto &MDPair : MD) {
535 unsigned ID = MDPair.first;
536 MDNode *N = MDPair.second;
537 // Note, essentially every kind of metadata should be preserved here! This
538 // routine is supposed to clone a store instruction changing *only its
539 // type*. The only metadata it makes sense to drop is metadata which is
540 // invalidated when the pointer type changes. This should essentially
541 // never be the case in LLVM, but we explicitly switch over only known
542 // metadata to be conservatively correct. If you are adding metadata to
543 // LLVM which pertains to stores, you almost certainly want to add it
544 // here.
545 switch (ID) {
546 case LLVMContext::MD_dbg:
547 case LLVMContext::MD_tbaa:
548 case LLVMContext::MD_prof:
549 case LLVMContext::MD_fpmath:
550 case LLVMContext::MD_tbaa_struct:
551 case LLVMContext::MD_alias_scope:
552 case LLVMContext::MD_noalias:
553 case LLVMContext::MD_nontemporal:
554 case LLVMContext::MD_mem_parallel_loop_access:
Chandler Carruthfa11d832015-01-22 03:34:54 +0000555 // All of these directly apply.
556 NewStore->setMetadata(ID, N);
557 break;
558
559 case LLVMContext::MD_invariant_load:
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000560 case LLVMContext::MD_nonnull:
Chandler Carruthfa11d832015-01-22 03:34:54 +0000561 case LLVMContext::MD_range:
Artur Pilipenko5c5011d2015-11-02 17:53:51 +0000562 case LLVMContext::MD_align:
563 case LLVMContext::MD_dereferenceable:
564 case LLVMContext::MD_dereferenceable_or_null:
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000565 // These don't apply for stores.
Chandler Carruthfa11d832015-01-22 03:34:54 +0000566 break;
567 }
568 }
569
570 return NewStore;
571}
572
Alexey Bataevec95c6c2017-12-08 15:32:10 +0000573/// Returns true if instruction represent minmax pattern like:
574/// select ((cmp load V1, load V2), V1, V2).
575static bool isMinMaxWithLoads(Value *V) {
576 assert(V->getType()->isPointerTy() && "Expected pointer type.");
577 // Ignore possible ty* to ixx* bitcast.
578 V = peekThroughBitcast(V);
579 // Check that select is select ((cmp load V1, load V2), V1, V2) - minmax
580 // pattern.
581 CmpInst::Predicate Pred;
582 Instruction *L1;
583 Instruction *L2;
584 Value *LHS;
585 Value *RHS;
586 if (!match(V, m_Select(m_Cmp(Pred, m_Instruction(L1), m_Instruction(L2)),
587 m_Value(LHS), m_Value(RHS))))
588 return false;
589 return (match(L1, m_Load(m_Specific(LHS))) &&
590 match(L2, m_Load(m_Specific(RHS)))) ||
591 (match(L1, m_Load(m_Specific(RHS))) &&
592 match(L2, m_Load(m_Specific(LHS))));
593}
594
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000595/// Combine loads to match the type of their uses' value after looking
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000596/// through intervening bitcasts.
597///
598/// The core idea here is that if the result of a load is used in an operation,
599/// we should load the type most conducive to that operation. For example, when
600/// loading an integer and converting that immediately to a pointer, we should
601/// instead directly load a pointer.
602///
603/// However, this routine must never change the width of a load or the number of
604/// loads as that would introduce a semantic change. This combine is expected to
605/// be a semantic no-op which just allows loads to more closely model the types
606/// of their consuming operations.
607///
608/// Currently, we also refuse to change the precise type used for an atomic load
609/// or a volatile load. This is debatable, and might be reasonable to change
610/// later. However, it is risky in case some backend or other part of LLVM is
611/// relying on the exact type loaded to select appropriate atomic operations.
612static Instruction *combineLoadToOperationType(InstCombiner &IC, LoadInst &LI) {
Philip Reames6f4d0082016-05-06 22:17:01 +0000613 // FIXME: We could probably with some care handle both volatile and ordered
614 // atomic loads here but it isn't clear that this is important.
615 if (!LI.isUnordered())
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000616 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000617
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000618 if (LI.use_empty())
619 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000620
Arnold Schwaighofer5d335552016-09-10 18:14:57 +0000621 // swifterror values can't be bitcasted.
622 if (LI.getPointerOperand()->isSwiftError())
623 return nullptr;
624
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000625 Type *Ty = LI.getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000626 const DataLayout &DL = IC.getDataLayout();
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000627
628 // Try to canonicalize loads which are only ever stored to operate over
629 // integers instead of any other type. We only do this when the loaded type
630 // is sized and has a size exactly the same as its store size and the store
631 // size is a legal integer type.
Alexey Bataevec95c6c2017-12-08 15:32:10 +0000632 // Do not perform canonicalization if minmax pattern is found (to avoid
633 // infinite loop).
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000634 if (!Ty->isIntegerTy() && Ty->isSized() &&
635 DL.isLegalInteger(DL.getTypeStoreSizeInBits(Ty)) &&
Sanjoy Dasba04d3a2016-08-06 02:58:48 +0000636 DL.getTypeStoreSizeInBits(Ty) == DL.getTypeSizeInBits(Ty) &&
Alexey Bataevec95c6c2017-12-08 15:32:10 +0000637 !DL.isNonIntegralPointerType(Ty) &&
638 !isMinMaxWithLoads(
639 peekThroughBitcast(LI.getPointerOperand(), /*OneUseOnly=*/true))) {
David Majnemer0a16c222016-08-11 21:15:00 +0000640 if (all_of(LI.users(), [&LI](User *U) {
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000641 auto *SI = dyn_cast<StoreInst>(U);
Arnold Schwaighoferc3685632017-01-31 17:53:49 +0000642 return SI && SI->getPointerOperand() != &LI &&
643 !SI->getPointerOperand()->isSwiftError();
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000644 })) {
645 LoadInst *NewLoad = combineLoadToNewType(
646 IC, LI,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000647 Type::getIntNTy(LI.getContext(), DL.getTypeStoreSizeInBits(Ty)));
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000648 // Replace all the stores with stores of the newly loaded value.
649 for (auto UI = LI.user_begin(), UE = LI.user_end(); UI != UE;) {
650 auto *SI = cast<StoreInst>(*UI++);
Craig Topperbb4069e2017-07-07 23:16:26 +0000651 IC.Builder.SetInsertPoint(SI);
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000652 combineStoreToNewValue(IC, *SI, NewLoad);
Sanjay Patel4b198802016-02-01 22:23:39 +0000653 IC.eraseInstFromFunction(*SI);
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000654 }
655 assert(LI.use_empty() && "Failed to remove all users of the load!");
656 // Return the old load so the combiner can delete it safely.
657 return &LI;
658 }
659 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000660
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000661 // Fold away bit casts of the loaded value by loading the desired type.
Quentin Colombet490cfbe2016-02-11 22:30:41 +0000662 // We can do this for BitCastInsts as well as casts from and to pointer types,
663 // as long as those are noops (i.e., the source or dest type have the same
664 // bitwidth as the target's pointers).
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000665 if (LI.hasOneUse())
Philip Reames89e92d22016-12-01 20:17:06 +0000666 if (auto* CI = dyn_cast<CastInst>(LI.user_back()))
667 if (CI->isNoopCast(DL))
668 if (!LI.isAtomic() || isSupportedAtomicType(CI->getDestTy())) {
669 LoadInst *NewLoad = combineLoadToNewType(IC, LI, CI->getDestTy());
670 CI->replaceAllUsesWith(NewLoad);
671 IC.eraseInstFromFunction(*CI);
672 return &LI;
673 }
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000674
Chandler Carrutha7f247e2014-12-09 19:21:16 +0000675 // FIXME: We should also canonicalize loads of vectors when their elements are
676 // cast to other types.
Craig Topperf40110f2014-04-25 05:29:35 +0000677 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000678}
679
Mehdi Amini2668a482015-05-07 05:52:40 +0000680static Instruction *unpackLoadToAggregate(InstCombiner &IC, LoadInst &LI) {
681 // FIXME: We could probably with some care handle both volatile and atomic
682 // stores here but it isn't clear that this is important.
683 if (!LI.isSimple())
684 return nullptr;
685
686 Type *T = LI.getType();
687 if (!T->isAggregateType())
688 return nullptr;
689
Benjamin Kramerc1263532016-03-11 10:20:56 +0000690 StringRef Name = LI.getName();
Bruce Mitchenere9ffb452015-09-12 01:17:08 +0000691 assert(LI.getAlignment() && "Alignment must be set at this point");
Mehdi Amini2668a482015-05-07 05:52:40 +0000692
693 if (auto *ST = dyn_cast<StructType>(T)) {
694 // If the struct only have one element, we unpack.
Amaury Sechet61a7d622016-02-17 19:21:28 +0000695 auto NumElements = ST->getNumElements();
696 if (NumElements == 1) {
Mehdi Amini2668a482015-05-07 05:52:40 +0000697 LoadInst *NewLoad = combineLoadToNewType(IC, LI, ST->getTypeAtIndex(0U),
698 ".unpack");
Keno Fischera236dae2017-06-28 23:36:40 +0000699 AAMDNodes AAMD;
700 LI.getAAMetadata(AAMD);
701 NewLoad->setAAMetadata(AAMD);
Craig Topperbb4069e2017-07-07 23:16:26 +0000702 return IC.replaceInstUsesWith(LI, IC.Builder.CreateInsertValue(
Amaury Sechet61a7d622016-02-17 19:21:28 +0000703 UndefValue::get(T), NewLoad, 0, Name));
Mehdi Amini2668a482015-05-07 05:52:40 +0000704 }
Mehdi Amini1c131b32015-12-15 01:44:07 +0000705
706 // We don't want to break loads with padding here as we'd loose
707 // the knowledge that padding exists for the rest of the pipeline.
708 const DataLayout &DL = IC.getDataLayout();
709 auto *SL = DL.getStructLayout(ST);
710 if (SL->hasPadding())
711 return nullptr;
712
Amaury Sechet61a7d622016-02-17 19:21:28 +0000713 auto Align = LI.getAlignment();
714 if (!Align)
715 Align = DL.getABITypeAlignment(ST);
716
Mehdi Amini1c131b32015-12-15 01:44:07 +0000717 auto *Addr = LI.getPointerOperand();
Amaury Sechet61a7d622016-02-17 19:21:28 +0000718 auto *IdxType = Type::getInt32Ty(T->getContext());
Mehdi Amini1c131b32015-12-15 01:44:07 +0000719 auto *Zero = ConstantInt::get(IdxType, 0);
Amaury Sechet61a7d622016-02-17 19:21:28 +0000720
721 Value *V = UndefValue::get(T);
722 for (unsigned i = 0; i < NumElements; i++) {
Mehdi Amini1c131b32015-12-15 01:44:07 +0000723 Value *Indices[2] = {
724 Zero,
725 ConstantInt::get(IdxType, i),
726 };
Craig Topperbb4069e2017-07-07 23:16:26 +0000727 auto *Ptr = IC.Builder.CreateInBoundsGEP(ST, Addr, makeArrayRef(Indices),
728 Name + ".elt");
Amaury Sechet61a7d622016-02-17 19:21:28 +0000729 auto EltAlign = MinAlign(Align, SL->getElementOffset(i));
Craig Topperbb4069e2017-07-07 23:16:26 +0000730 auto *L = IC.Builder.CreateAlignedLoad(Ptr, EltAlign, Name + ".unpack");
Keno Fischera236dae2017-06-28 23:36:40 +0000731 // Propagate AA metadata. It'll still be valid on the narrowed load.
732 AAMDNodes AAMD;
733 LI.getAAMetadata(AAMD);
734 L->setAAMetadata(AAMD);
Craig Topperbb4069e2017-07-07 23:16:26 +0000735 V = IC.Builder.CreateInsertValue(V, L, i);
Mehdi Amini1c131b32015-12-15 01:44:07 +0000736 }
737
738 V->setName(Name);
Sanjay Patel4b198802016-02-01 22:23:39 +0000739 return IC.replaceInstUsesWith(LI, V);
Mehdi Amini2668a482015-05-07 05:52:40 +0000740 }
741
David Majnemer58fb0382015-05-11 05:04:22 +0000742 if (auto *AT = dyn_cast<ArrayType>(T)) {
Amaury Sechet7cd3fe72016-03-02 21:28:30 +0000743 auto *ET = AT->getElementType();
744 auto NumElements = AT->getNumElements();
745 if (NumElements == 1) {
746 LoadInst *NewLoad = combineLoadToNewType(IC, LI, ET, ".unpack");
Keno Fischera236dae2017-06-28 23:36:40 +0000747 AAMDNodes AAMD;
748 LI.getAAMetadata(AAMD);
749 NewLoad->setAAMetadata(AAMD);
Craig Topperbb4069e2017-07-07 23:16:26 +0000750 return IC.replaceInstUsesWith(LI, IC.Builder.CreateInsertValue(
Amaury Sechet7cd3fe72016-03-02 21:28:30 +0000751 UndefValue::get(T), NewLoad, 0, Name));
David Majnemer58fb0382015-05-11 05:04:22 +0000752 }
Amaury Sechet7cd3fe72016-03-02 21:28:30 +0000753
Davide Italianoda114122016-10-07 20:57:42 +0000754 // Bail out if the array is too large. Ideally we would like to optimize
755 // arrays of arbitrary size but this has a terrible impact on compile time.
756 // The threshold here is chosen arbitrarily, maybe needs a little bit of
757 // tuning.
Davide Italiano2133bf52017-02-07 17:56:50 +0000758 if (NumElements > IC.MaxArraySizeForCombine)
Davide Italianoda114122016-10-07 20:57:42 +0000759 return nullptr;
760
Amaury Sechet7cd3fe72016-03-02 21:28:30 +0000761 const DataLayout &DL = IC.getDataLayout();
762 auto EltSize = DL.getTypeAllocSize(ET);
763 auto Align = LI.getAlignment();
764 if (!Align)
765 Align = DL.getABITypeAlignment(T);
766
Amaury Sechet7cd3fe72016-03-02 21:28:30 +0000767 auto *Addr = LI.getPointerOperand();
768 auto *IdxType = Type::getInt64Ty(T->getContext());
769 auto *Zero = ConstantInt::get(IdxType, 0);
770
771 Value *V = UndefValue::get(T);
772 uint64_t Offset = 0;
773 for (uint64_t i = 0; i < NumElements; i++) {
774 Value *Indices[2] = {
775 Zero,
776 ConstantInt::get(IdxType, i),
777 };
Craig Topperbb4069e2017-07-07 23:16:26 +0000778 auto *Ptr = IC.Builder.CreateInBoundsGEP(AT, Addr, makeArrayRef(Indices),
779 Name + ".elt");
780 auto *L = IC.Builder.CreateAlignedLoad(Ptr, MinAlign(Align, Offset),
781 Name + ".unpack");
Keno Fischera236dae2017-06-28 23:36:40 +0000782 AAMDNodes AAMD;
783 LI.getAAMetadata(AAMD);
784 L->setAAMetadata(AAMD);
Craig Topperbb4069e2017-07-07 23:16:26 +0000785 V = IC.Builder.CreateInsertValue(V, L, i);
Amaury Sechet7cd3fe72016-03-02 21:28:30 +0000786 Offset += EltSize;
787 }
788
789 V->setName(Name);
790 return IC.replaceInstUsesWith(LI, V);
David Majnemer58fb0382015-05-11 05:04:22 +0000791 }
792
Mehdi Amini2668a482015-05-07 05:52:40 +0000793 return nullptr;
794}
795
Hal Finkel847e05f2015-02-20 03:05:53 +0000796// If we can determine that all possible objects pointed to by the provided
797// pointer value are, not only dereferenceable, but also definitively less than
798// or equal to the provided maximum size, then return true. Otherwise, return
799// false (constant global values and allocas fall into this category).
800//
801// FIXME: This should probably live in ValueTracking (or similar).
802static bool isObjectSizeLessThanOrEq(Value *V, uint64_t MaxSize,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000803 const DataLayout &DL) {
Hal Finkel847e05f2015-02-20 03:05:53 +0000804 SmallPtrSet<Value *, 4> Visited;
805 SmallVector<Value *, 4> Worklist(1, V);
806
807 do {
808 Value *P = Worklist.pop_back_val();
809 P = P->stripPointerCasts();
810
811 if (!Visited.insert(P).second)
812 continue;
813
814 if (SelectInst *SI = dyn_cast<SelectInst>(P)) {
815 Worklist.push_back(SI->getTrueValue());
816 Worklist.push_back(SI->getFalseValue());
817 continue;
818 }
819
820 if (PHINode *PN = dyn_cast<PHINode>(P)) {
Pete Cooper833f34d2015-05-12 20:05:31 +0000821 for (Value *IncValue : PN->incoming_values())
822 Worklist.push_back(IncValue);
Hal Finkel847e05f2015-02-20 03:05:53 +0000823 continue;
824 }
825
826 if (GlobalAlias *GA = dyn_cast<GlobalAlias>(P)) {
Sanjoy Das99042472016-04-17 04:30:43 +0000827 if (GA->isInterposable())
Hal Finkel847e05f2015-02-20 03:05:53 +0000828 return false;
829 Worklist.push_back(GA->getAliasee());
830 continue;
831 }
832
833 // If we know how big this object is, and it is less than MaxSize, continue
834 // searching. Otherwise, return false.
835 if (AllocaInst *AI = dyn_cast<AllocaInst>(P)) {
836 if (!AI->getAllocatedType()->isSized())
837 return false;
838
839 ConstantInt *CS = dyn_cast<ConstantInt>(AI->getArraySize());
840 if (!CS)
841 return false;
842
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000843 uint64_t TypeSize = DL.getTypeAllocSize(AI->getAllocatedType());
Hal Finkel847e05f2015-02-20 03:05:53 +0000844 // Make sure that, even if the multiplication below would wrap as an
845 // uint64_t, we still do the right thing.
846 if ((CS->getValue().zextOrSelf(128)*APInt(128, TypeSize)).ugt(MaxSize))
847 return false;
848 continue;
849 }
850
851 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(P)) {
852 if (!GV->hasDefinitiveInitializer() || !GV->isConstant())
853 return false;
854
Manuel Jacob5f6eaac2016-01-16 20:30:46 +0000855 uint64_t InitSize = DL.getTypeAllocSize(GV->getValueType());
Hal Finkel847e05f2015-02-20 03:05:53 +0000856 if (InitSize > MaxSize)
857 return false;
858 continue;
859 }
860
861 return false;
862 } while (!Worklist.empty());
863
864 return true;
865}
866
867// If we're indexing into an object of a known size, and the outer index is
868// not a constant, but having any value but zero would lead to undefined
869// behavior, replace it with zero.
870//
871// For example, if we have:
872// @f.a = private unnamed_addr constant [1 x i32] [i32 12], align 4
873// ...
874// %arrayidx = getelementptr inbounds [1 x i32]* @f.a, i64 0, i64 %x
875// ... = load i32* %arrayidx, align 4
876// Then we know that we can replace %x in the GEP with i64 0.
877//
878// FIXME: We could fold any GEP index to zero that would cause UB if it were
879// not zero. Currently, we only handle the first such index. Also, we could
880// also search through non-zero constant indices if we kept track of the
881// offsets those indices implied.
882static bool canReplaceGEPIdxWithZero(InstCombiner &IC, GetElementPtrInst *GEPI,
883 Instruction *MemI, unsigned &Idx) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000884 if (GEPI->getNumOperands() < 2)
Hal Finkel847e05f2015-02-20 03:05:53 +0000885 return false;
886
887 // Find the first non-zero index of a GEP. If all indices are zero, return
888 // one past the last index.
889 auto FirstNZIdx = [](const GetElementPtrInst *GEPI) {
890 unsigned I = 1;
891 for (unsigned IE = GEPI->getNumOperands(); I != IE; ++I) {
892 Value *V = GEPI->getOperand(I);
893 if (const ConstantInt *CI = dyn_cast<ConstantInt>(V))
894 if (CI->isZero())
895 continue;
896
897 break;
898 }
899
900 return I;
901 };
902
903 // Skip through initial 'zero' indices, and find the corresponding pointer
904 // type. See if the next index is not a constant.
905 Idx = FirstNZIdx(GEPI);
906 if (Idx == GEPI->getNumOperands())
907 return false;
908 if (isa<Constant>(GEPI->getOperand(Idx)))
909 return false;
910
911 SmallVector<Value *, 4> Ops(GEPI->idx_begin(), GEPI->idx_begin() + Idx);
Eduard Burtescu19eb0312016-01-19 17:28:00 +0000912 Type *AllocTy =
913 GetElementPtrInst::getIndexedType(GEPI->getSourceElementType(), Ops);
Hal Finkel847e05f2015-02-20 03:05:53 +0000914 if (!AllocTy || !AllocTy->isSized())
915 return false;
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000916 const DataLayout &DL = IC.getDataLayout();
917 uint64_t TyAllocSize = DL.getTypeAllocSize(AllocTy);
Hal Finkel847e05f2015-02-20 03:05:53 +0000918
919 // If there are more indices after the one we might replace with a zero, make
920 // sure they're all non-negative. If any of them are negative, the overall
921 // address being computed might be before the base address determined by the
922 // first non-zero index.
923 auto IsAllNonNegative = [&]() {
924 for (unsigned i = Idx+1, e = GEPI->getNumOperands(); i != e; ++i) {
Craig Topper1a36b7d2017-05-15 06:39:41 +0000925 KnownBits Known = IC.computeKnownBits(GEPI->getOperand(i), 0, MemI);
926 if (Known.isNonNegative())
Hal Finkel847e05f2015-02-20 03:05:53 +0000927 continue;
928 return false;
929 }
930
931 return true;
932 };
933
934 // FIXME: If the GEP is not inbounds, and there are extra indices after the
935 // one we'll replace, those could cause the address computation to wrap
936 // (rendering the IsAllNonNegative() check below insufficient). We can do
Bruce Mitchenere9ffb452015-09-12 01:17:08 +0000937 // better, ignoring zero indices (and other indices we can prove small
Hal Finkel847e05f2015-02-20 03:05:53 +0000938 // enough not to wrap).
939 if (Idx+1 != GEPI->getNumOperands() && !GEPI->isInBounds())
940 return false;
941
942 // Note that isObjectSizeLessThanOrEq will return true only if the pointer is
943 // also known to be dereferenceable.
944 return isObjectSizeLessThanOrEq(GEPI->getOperand(0), TyAllocSize, DL) &&
945 IsAllNonNegative();
946}
947
948// If we're indexing into an object with a variable index for the memory
949// access, but the object has only one element, we can assume that the index
950// will always be zero. If we replace the GEP, return it.
951template <typename T>
952static Instruction *replaceGEPIdxWithZero(InstCombiner &IC, Value *Ptr,
953 T &MemI) {
954 if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(Ptr)) {
955 unsigned Idx;
956 if (canReplaceGEPIdxWithZero(IC, GEPI, &MemI, Idx)) {
957 Instruction *NewGEPI = GEPI->clone();
958 NewGEPI->setOperand(Idx,
959 ConstantInt::get(GEPI->getOperand(Idx)->getType(), 0));
960 NewGEPI->insertBefore(GEPI);
961 MemI.setOperand(MemI.getPointerOperandIndex(), NewGEPI);
962 return NewGEPI;
963 }
964 }
965
966 return nullptr;
967}
968
Anna Thomas2dd98352017-12-12 14:12:33 +0000969static bool canSimplifyNullStoreOrGEP(StoreInst &SI) {
Manoj Gupta77eeac32018-07-09 22:27:23 +0000970 if (NullPointerIsDefined(SI.getFunction(), SI.getPointerAddressSpace()))
Anna Thomas2dd98352017-12-12 14:12:33 +0000971 return false;
972
973 auto *Ptr = SI.getPointerOperand();
974 if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(Ptr))
975 Ptr = GEPI->getOperand(0);
Manoj Gupta77eeac32018-07-09 22:27:23 +0000976 return (isa<ConstantPointerNull>(Ptr) &&
977 !NullPointerIsDefined(SI.getFunction(), SI.getPointerAddressSpace()));
Anna Thomas2dd98352017-12-12 14:12:33 +0000978}
979
Davide Italianoffcb4df2017-04-19 17:26:57 +0000980static bool canSimplifyNullLoadOrGEP(LoadInst &LI, Value *Op) {
981 if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(Op)) {
982 const Value *GEPI0 = GEPI->getOperand(0);
Manoj Gupta77eeac32018-07-09 22:27:23 +0000983 if (isa<ConstantPointerNull>(GEPI0) &&
984 !NullPointerIsDefined(LI.getFunction(), GEPI->getPointerAddressSpace()))
Davide Italianoffcb4df2017-04-19 17:26:57 +0000985 return true;
986 }
987 if (isa<UndefValue>(Op) ||
Manoj Gupta77eeac32018-07-09 22:27:23 +0000988 (isa<ConstantPointerNull>(Op) &&
989 !NullPointerIsDefined(LI.getFunction(), LI.getPointerAddressSpace())))
Davide Italianoffcb4df2017-04-19 17:26:57 +0000990 return true;
991 return false;
992}
993
Chris Lattnera65e2f72010-01-05 05:57:49 +0000994Instruction *InstCombiner::visitLoadInst(LoadInst &LI) {
995 Value *Op = LI.getOperand(0);
996
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000997 // Try to canonicalize the loaded type.
998 if (Instruction *Res = combineLoadToOperationType(*this, LI))
999 return Res;
1000
Chris Lattnera65e2f72010-01-05 05:57:49 +00001001 // Attempt to improve the alignment.
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001002 unsigned KnownAlign = getOrEnforceKnownAlignment(
Daniel Jasperaec2fa32016-12-19 08:22:17 +00001003 Op, DL.getPrefTypeAlignment(LI.getType()), DL, &LI, &AC, &DT);
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001004 unsigned LoadAlign = LI.getAlignment();
1005 unsigned EffectiveLoadAlign =
1006 LoadAlign != 0 ? LoadAlign : DL.getABITypeAlignment(LI.getType());
Dan Gohman36196602010-08-03 18:20:32 +00001007
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001008 if (KnownAlign > EffectiveLoadAlign)
1009 LI.setAlignment(KnownAlign);
1010 else if (LoadAlign == 0)
1011 LI.setAlignment(EffectiveLoadAlign);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001012
Hal Finkel847e05f2015-02-20 03:05:53 +00001013 // Replace GEP indices if possible.
1014 if (Instruction *NewGEPI = replaceGEPIdxWithZero(*this, Op, LI)) {
1015 Worklist.Add(NewGEPI);
1016 return &LI;
1017 }
1018
Mehdi Amini2668a482015-05-07 05:52:40 +00001019 if (Instruction *Res = unpackLoadToAggregate(*this, LI))
1020 return Res;
1021
Chris Lattnera65e2f72010-01-05 05:57:49 +00001022 // Do really simple store-to-load forwarding and load CSE, to catch cases
Duncan Sands75b5d272011-02-15 09:23:02 +00001023 // where there are several consecutive memory accesses to the same location,
Chris Lattnera65e2f72010-01-05 05:57:49 +00001024 // separated by a few arithmetic operations.
Duncan P. N. Exon Smith9f8aaf22015-10-13 16:59:33 +00001025 BasicBlock::iterator BBI(LI);
Eli Friedmanbd254a62016-06-16 02:33:42 +00001026 bool IsLoadCSE = false;
Sanjay Patelb38ad88e2017-01-02 23:25:28 +00001027 if (Value *AvailableVal = FindAvailableLoadedValue(
1028 &LI, LI.getParent(), BBI, DefMaxInstsToScan, AA, &IsLoadCSE)) {
1029 if (IsLoadCSE)
Florian Hahn406f1ff2018-08-24 11:40:04 +00001030 combineMetadataForCSE(cast<LoadInst>(AvailableVal), &LI, false);
Bjorn Steinbrinka91fd092015-07-10 06:55:44 +00001031
Sanjay Patel4b198802016-02-01 22:23:39 +00001032 return replaceInstUsesWith(
Craig Topperbb4069e2017-07-07 23:16:26 +00001033 LI, Builder.CreateBitOrPointerCast(AvailableVal, LI.getType(),
1034 LI.getName() + ".cast"));
Bjorn Steinbrinka91fd092015-07-10 06:55:44 +00001035 }
Chris Lattnera65e2f72010-01-05 05:57:49 +00001036
Philip Reames3ac07182016-04-21 17:45:05 +00001037 // None of the following transforms are legal for volatile/ordered atomic
1038 // loads. Most of them do apply for unordered atomics.
1039 if (!LI.isUnordered()) return nullptr;
Philip Reamesac550902016-04-21 17:03:33 +00001040
Chris Lattnera65e2f72010-01-05 05:57:49 +00001041 // load(gep null, ...) -> unreachable
Chris Lattnera65e2f72010-01-05 05:57:49 +00001042 // load null/undef -> unreachable
Davide Italianoffcb4df2017-04-19 17:26:57 +00001043 // TODO: Consider a target hook for valid address spaces for this xforms.
1044 if (canSimplifyNullLoadOrGEP(LI, Op)) {
1045 // Insert a new store to null instruction before the load to indicate
1046 // that this code is not reachable. We do this instead of inserting
1047 // an unreachable instruction directly because we cannot modify the
1048 // CFG.
Weiming Zhao984f1dc2017-07-19 01:27:24 +00001049 StoreInst *SI = new StoreInst(UndefValue::get(LI.getType()),
1050 Constant::getNullValue(Op->getType()), &LI);
1051 SI->setDebugLoc(LI.getDebugLoc());
Sanjay Patel4b198802016-02-01 22:23:39 +00001052 return replaceInstUsesWith(LI, UndefValue::get(LI.getType()));
Chris Lattnera65e2f72010-01-05 05:57:49 +00001053 }
1054
Chris Lattnera65e2f72010-01-05 05:57:49 +00001055 if (Op->hasOneUse()) {
1056 // Change select and PHI nodes to select values instead of addresses: this
1057 // helps alias analysis out a lot, allows many others simplifications, and
1058 // exposes redundancy in the code.
1059 //
1060 // Note that we cannot do the transformation unless we know that the
1061 // introduced loads cannot trap! Something like this is valid as long as
1062 // the condition is always false: load (select bool %C, int* null, int* %G),
1063 // but it would not be valid if we transformed it to load from null
1064 // unconditionally.
1065 //
1066 if (SelectInst *SI = dyn_cast<SelectInst>(Op)) {
1067 // load (select (Cond, &V1, &V2)) --> select(Cond, load &V1, load &V2).
Bob Wilson56600a12010-01-30 04:42:39 +00001068 unsigned Align = LI.getAlignment();
Artur Pilipenko9bb6bea2016-04-27 11:00:48 +00001069 if (isSafeToLoadUnconditionally(SI->getOperand(1), Align, DL, SI) &&
1070 isSafeToLoadUnconditionally(SI->getOperand(2), Align, DL, SI)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001071 LoadInst *V1 = Builder.CreateLoad(SI->getOperand(1),
1072 SI->getOperand(1)->getName()+".val");
1073 LoadInst *V2 = Builder.CreateLoad(SI->getOperand(2),
1074 SI->getOperand(2)->getName()+".val");
Philip Reamesa98c7ea2016-04-21 17:59:40 +00001075 assert(LI.isUnordered() && "implied by above");
Bob Wilson56600a12010-01-30 04:42:39 +00001076 V1->setAlignment(Align);
Konstantin Zhuravlyovbb80d3e2017-07-11 22:23:00 +00001077 V1->setAtomic(LI.getOrdering(), LI.getSyncScopeID());
Bob Wilson56600a12010-01-30 04:42:39 +00001078 V2->setAlignment(Align);
Konstantin Zhuravlyovbb80d3e2017-07-11 22:23:00 +00001079 V2->setAtomic(LI.getOrdering(), LI.getSyncScopeID());
Chris Lattnera65e2f72010-01-05 05:57:49 +00001080 return SelectInst::Create(SI->getCondition(), V1, V2);
1081 }
1082
1083 // load (select (cond, null, P)) -> load P
Larisse Voufo532bf712015-09-18 19:14:35 +00001084 if (isa<ConstantPointerNull>(SI->getOperand(1)) &&
Manoj Gupta77eeac32018-07-09 22:27:23 +00001085 !NullPointerIsDefined(SI->getFunction(),
1086 LI.getPointerAddressSpace())) {
Philip Reames5ad26c32014-12-29 22:46:21 +00001087 LI.setOperand(0, SI->getOperand(2));
1088 return &LI;
1089 }
Chris Lattnera65e2f72010-01-05 05:57:49 +00001090
1091 // load (select (cond, P, null)) -> load P
Philip Reames5ad26c32014-12-29 22:46:21 +00001092 if (isa<ConstantPointerNull>(SI->getOperand(2)) &&
Manoj Gupta77eeac32018-07-09 22:27:23 +00001093 !NullPointerIsDefined(SI->getFunction(),
1094 LI.getPointerAddressSpace())) {
Philip Reames5ad26c32014-12-29 22:46:21 +00001095 LI.setOperand(0, SI->getOperand(1));
1096 return &LI;
1097 }
Chris Lattnera65e2f72010-01-05 05:57:49 +00001098 }
1099 }
Craig Topperf40110f2014-04-25 05:29:35 +00001100 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001101}
1102
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00001103/// Look for extractelement/insertvalue sequence that acts like a bitcast.
Arch D. Robisonbe0490a2016-04-25 22:22:39 +00001104///
1105/// \returns underlying value that was "cast", or nullptr otherwise.
1106///
1107/// For example, if we have:
1108///
1109/// %E0 = extractelement <2 x double> %U, i32 0
1110/// %V0 = insertvalue [2 x double] undef, double %E0, 0
1111/// %E1 = extractelement <2 x double> %U, i32 1
1112/// %V1 = insertvalue [2 x double] %V0, double %E1, 1
1113///
1114/// and the layout of a <2 x double> is isomorphic to a [2 x double],
1115/// then %V1 can be safely approximated by a conceptual "bitcast" of %U.
1116/// Note that %U may contain non-undef values where %V1 has undef.
1117static Value *likeBitCastFromVector(InstCombiner &IC, Value *V) {
1118 Value *U = nullptr;
1119 while (auto *IV = dyn_cast<InsertValueInst>(V)) {
1120 auto *E = dyn_cast<ExtractElementInst>(IV->getInsertedValueOperand());
1121 if (!E)
1122 return nullptr;
1123 auto *W = E->getVectorOperand();
1124 if (!U)
1125 U = W;
1126 else if (U != W)
1127 return nullptr;
1128 auto *CI = dyn_cast<ConstantInt>(E->getIndexOperand());
1129 if (!CI || IV->getNumIndices() != 1 || CI->getZExtValue() != *IV->idx_begin())
1130 return nullptr;
1131 V = IV->getAggregateOperand();
1132 }
1133 if (!isa<UndefValue>(V) ||!U)
1134 return nullptr;
1135
1136 auto *UT = cast<VectorType>(U->getType());
1137 auto *VT = V->getType();
1138 // Check that types UT and VT are bitwise isomorphic.
1139 const auto &DL = IC.getDataLayout();
1140 if (DL.getTypeStoreSizeInBits(UT) != DL.getTypeStoreSizeInBits(VT)) {
1141 return nullptr;
1142 }
1143 if (auto *AT = dyn_cast<ArrayType>(VT)) {
1144 if (AT->getNumElements() != UT->getNumElements())
1145 return nullptr;
1146 } else {
1147 auto *ST = cast<StructType>(VT);
1148 if (ST->getNumElements() != UT->getNumElements())
1149 return nullptr;
1150 for (const auto *EltT : ST->elements()) {
1151 if (EltT != UT->getElementType())
1152 return nullptr;
1153 }
1154 }
1155 return U;
1156}
1157
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00001158/// Combine stores to match the type of value being stored.
Chandler Carruth816d26f2014-11-25 10:09:51 +00001159///
1160/// The core idea here is that the memory does not have any intrinsic type and
1161/// where we can we should match the type of a store to the type of value being
1162/// stored.
1163///
1164/// However, this routine must never change the width of a store or the number of
1165/// stores as that would introduce a semantic change. This combine is expected to
1166/// be a semantic no-op which just allows stores to more closely model the types
1167/// of their incoming values.
1168///
1169/// Currently, we also refuse to change the precise type used for an atomic or
1170/// volatile store. This is debatable, and might be reasonable to change later.
1171/// However, it is risky in case some backend or other part of LLVM is relying
1172/// on the exact type stored to select appropriate atomic operations.
1173///
1174/// \returns true if the store was successfully combined away. This indicates
1175/// the caller must erase the store instruction. We have to let the caller erase
Bruce Mitchenere9ffb452015-09-12 01:17:08 +00001176/// the store instruction as otherwise there is no way to signal whether it was
Chandler Carruth816d26f2014-11-25 10:09:51 +00001177/// combined or not: IC.EraseInstFromFunction returns a null pointer.
1178static bool combineStoreToValueType(InstCombiner &IC, StoreInst &SI) {
Philip Reames6f4d0082016-05-06 22:17:01 +00001179 // FIXME: We could probably with some care handle both volatile and ordered
1180 // atomic stores here but it isn't clear that this is important.
1181 if (!SI.isUnordered())
Chandler Carruth816d26f2014-11-25 10:09:51 +00001182 return false;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001183
Arnold Schwaighofer5d335552016-09-10 18:14:57 +00001184 // swifterror values can't be bitcasted.
1185 if (SI.getPointerOperand()->isSwiftError())
1186 return false;
1187
Chandler Carruth816d26f2014-11-25 10:09:51 +00001188 Value *V = SI.getValueOperand();
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001189
Chandler Carruth816d26f2014-11-25 10:09:51 +00001190 // Fold away bit casts of the stored value by storing the original type.
1191 if (auto *BC = dyn_cast<BitCastInst>(V)) {
Chandler Carrutha7f247e2014-12-09 19:21:16 +00001192 V = BC->getOperand(0);
Philip Reames89e92d22016-12-01 20:17:06 +00001193 if (!SI.isAtomic() || isSupportedAtomicType(V->getType())) {
1194 combineStoreToNewValue(IC, SI, V);
1195 return true;
1196 }
Chris Lattnera65e2f72010-01-05 05:57:49 +00001197 }
1198
Philip Reames89e92d22016-12-01 20:17:06 +00001199 if (Value *U = likeBitCastFromVector(IC, V))
1200 if (!SI.isAtomic() || isSupportedAtomicType(U->getType())) {
1201 combineStoreToNewValue(IC, SI, U);
1202 return true;
1203 }
Arch D. Robisonbe0490a2016-04-25 22:22:39 +00001204
JF Bastienc22d2992016-04-21 19:53:39 +00001205 // FIXME: We should also canonicalize stores of vectors when their elements
1206 // are cast to other types.
Chandler Carruth816d26f2014-11-25 10:09:51 +00001207 return false;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001208}
1209
Mehdi Aminib344ac92015-03-14 22:19:33 +00001210static bool unpackStoreToAggregate(InstCombiner &IC, StoreInst &SI) {
1211 // FIXME: We could probably with some care handle both volatile and atomic
1212 // stores here but it isn't clear that this is important.
1213 if (!SI.isSimple())
1214 return false;
1215
1216 Value *V = SI.getValueOperand();
1217 Type *T = V->getType();
1218
1219 if (!T->isAggregateType())
1220 return false;
1221
Mehdi Amini2668a482015-05-07 05:52:40 +00001222 if (auto *ST = dyn_cast<StructType>(T)) {
Mehdi Aminib344ac92015-03-14 22:19:33 +00001223 // If the struct only have one element, we unpack.
Mehdi Amini1c131b32015-12-15 01:44:07 +00001224 unsigned Count = ST->getNumElements();
1225 if (Count == 1) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001226 V = IC.Builder.CreateExtractValue(V, 0);
Mehdi Aminib344ac92015-03-14 22:19:33 +00001227 combineStoreToNewValue(IC, SI, V);
1228 return true;
1229 }
Mehdi Amini1c131b32015-12-15 01:44:07 +00001230
1231 // We don't want to break loads with padding here as we'd loose
1232 // the knowledge that padding exists for the rest of the pipeline.
1233 const DataLayout &DL = IC.getDataLayout();
1234 auto *SL = DL.getStructLayout(ST);
1235 if (SL->hasPadding())
1236 return false;
1237
Amaury Sechet61a7d622016-02-17 19:21:28 +00001238 auto Align = SI.getAlignment();
1239 if (!Align)
1240 Align = DL.getABITypeAlignment(ST);
1241
NAKAMURA Takumiec6b1fc2015-12-15 09:37:31 +00001242 SmallString<16> EltName = V->getName();
1243 EltName += ".elt";
Mehdi Amini1c131b32015-12-15 01:44:07 +00001244 auto *Addr = SI.getPointerOperand();
NAKAMURA Takumiec6b1fc2015-12-15 09:37:31 +00001245 SmallString<16> AddrName = Addr->getName();
1246 AddrName += ".repack";
Amaury Sechet61a7d622016-02-17 19:21:28 +00001247
Mehdi Amini1c131b32015-12-15 01:44:07 +00001248 auto *IdxType = Type::getInt32Ty(ST->getContext());
1249 auto *Zero = ConstantInt::get(IdxType, 0);
1250 for (unsigned i = 0; i < Count; i++) {
1251 Value *Indices[2] = {
1252 Zero,
1253 ConstantInt::get(IdxType, i),
1254 };
Craig Topperbb4069e2017-07-07 23:16:26 +00001255 auto *Ptr = IC.Builder.CreateInBoundsGEP(ST, Addr, makeArrayRef(Indices),
1256 AddrName);
1257 auto *Val = IC.Builder.CreateExtractValue(V, i, EltName);
Amaury Sechet61a7d622016-02-17 19:21:28 +00001258 auto EltAlign = MinAlign(Align, SL->getElementOffset(i));
Craig Topperbb4069e2017-07-07 23:16:26 +00001259 llvm::Instruction *NS = IC.Builder.CreateAlignedStore(Val, Ptr, EltAlign);
Keno Fischera236dae2017-06-28 23:36:40 +00001260 AAMDNodes AAMD;
1261 SI.getAAMetadata(AAMD);
1262 NS->setAAMetadata(AAMD);
Mehdi Amini1c131b32015-12-15 01:44:07 +00001263 }
1264
1265 return true;
Mehdi Aminib344ac92015-03-14 22:19:33 +00001266 }
1267
David Majnemer75364602015-05-11 05:04:27 +00001268 if (auto *AT = dyn_cast<ArrayType>(T)) {
1269 // If the array only have one element, we unpack.
Amaury Sechet3b8b2ea2016-03-02 22:36:45 +00001270 auto NumElements = AT->getNumElements();
1271 if (NumElements == 1) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001272 V = IC.Builder.CreateExtractValue(V, 0);
David Majnemer75364602015-05-11 05:04:27 +00001273 combineStoreToNewValue(IC, SI, V);
1274 return true;
1275 }
Amaury Sechet3b8b2ea2016-03-02 22:36:45 +00001276
Davide Italianof6988d22016-10-07 21:53:09 +00001277 // Bail out if the array is too large. Ideally we would like to optimize
1278 // arrays of arbitrary size but this has a terrible impact on compile time.
1279 // The threshold here is chosen arbitrarily, maybe needs a little bit of
1280 // tuning.
Davide Italiano2133bf52017-02-07 17:56:50 +00001281 if (NumElements > IC.MaxArraySizeForCombine)
Davide Italianof6988d22016-10-07 21:53:09 +00001282 return false;
1283
Amaury Sechet3b8b2ea2016-03-02 22:36:45 +00001284 const DataLayout &DL = IC.getDataLayout();
1285 auto EltSize = DL.getTypeAllocSize(AT->getElementType());
1286 auto Align = SI.getAlignment();
1287 if (!Align)
1288 Align = DL.getABITypeAlignment(T);
1289
1290 SmallString<16> EltName = V->getName();
1291 EltName += ".elt";
1292 auto *Addr = SI.getPointerOperand();
1293 SmallString<16> AddrName = Addr->getName();
1294 AddrName += ".repack";
1295
1296 auto *IdxType = Type::getInt64Ty(T->getContext());
1297 auto *Zero = ConstantInt::get(IdxType, 0);
1298
1299 uint64_t Offset = 0;
1300 for (uint64_t i = 0; i < NumElements; i++) {
1301 Value *Indices[2] = {
1302 Zero,
1303 ConstantInt::get(IdxType, i),
1304 };
Craig Topperbb4069e2017-07-07 23:16:26 +00001305 auto *Ptr = IC.Builder.CreateInBoundsGEP(AT, Addr, makeArrayRef(Indices),
1306 AddrName);
1307 auto *Val = IC.Builder.CreateExtractValue(V, i, EltName);
Amaury Sechet3b8b2ea2016-03-02 22:36:45 +00001308 auto EltAlign = MinAlign(Align, Offset);
Craig Topperbb4069e2017-07-07 23:16:26 +00001309 Instruction *NS = IC.Builder.CreateAlignedStore(Val, Ptr, EltAlign);
Keno Fischera236dae2017-06-28 23:36:40 +00001310 AAMDNodes AAMD;
1311 SI.getAAMetadata(AAMD);
1312 NS->setAAMetadata(AAMD);
Amaury Sechet3b8b2ea2016-03-02 22:36:45 +00001313 Offset += EltSize;
1314 }
1315
1316 return true;
David Majnemer75364602015-05-11 05:04:27 +00001317 }
1318
Mehdi Aminib344ac92015-03-14 22:19:33 +00001319 return false;
1320}
1321
Chris Lattnera65e2f72010-01-05 05:57:49 +00001322/// equivalentAddressValues - Test if A and B will obviously have the same
1323/// value. This includes recognizing that %t0 and %t1 will have the same
1324/// value in code like this:
1325/// %t0 = getelementptr \@a, 0, 3
1326/// store i32 0, i32* %t0
1327/// %t1 = getelementptr \@a, 0, 3
1328/// %t2 = load i32* %t1
1329///
1330static bool equivalentAddressValues(Value *A, Value *B) {
1331 // Test if the values are trivially equivalent.
1332 if (A == B) return true;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001333
Chris Lattnera65e2f72010-01-05 05:57:49 +00001334 // Test if the values come form identical arithmetic instructions.
1335 // This uses isIdenticalToWhenDefined instead of isIdenticalTo because
1336 // its only used to compare two uses within the same basic block, which
1337 // means that they'll always either have the same value or one of them
1338 // will have an undefined value.
1339 if (isa<BinaryOperator>(A) ||
1340 isa<CastInst>(A) ||
1341 isa<PHINode>(A) ||
1342 isa<GetElementPtrInst>(A))
1343 if (Instruction *BI = dyn_cast<Instruction>(B))
1344 if (cast<Instruction>(A)->isIdenticalToWhenDefined(BI))
1345 return true;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001346
Chris Lattnera65e2f72010-01-05 05:57:49 +00001347 // Otherwise they may not be equivalent.
1348 return false;
1349}
1350
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001351/// Converts store (bitcast (load (bitcast (select ...)))) to
1352/// store (load (select ...)), where select is minmax:
1353/// select ((cmp load V1, load V2), V1, V2).
Alexey Bataev83c15b12017-12-12 20:28:46 +00001354static bool removeBitcastsFromLoadStoreOnMinMax(InstCombiner &IC,
1355 StoreInst &SI) {
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001356 // bitcast?
Alexey Bataev83c15b12017-12-12 20:28:46 +00001357 if (!match(SI.getPointerOperand(), m_BitCast(m_Value())))
Alexey Bataevfa0a76d2017-12-12 19:12:34 +00001358 return false;
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001359 // load? integer?
1360 Value *LoadAddr;
1361 if (!match(SI.getValueOperand(), m_Load(m_BitCast(m_Value(LoadAddr)))))
Alexey Bataevfa0a76d2017-12-12 19:12:34 +00001362 return false;
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001363 auto *LI = cast<LoadInst>(SI.getValueOperand());
1364 if (!LI->getType()->isIntegerTy())
Alexey Bataevfa0a76d2017-12-12 19:12:34 +00001365 return false;
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001366 if (!isMinMaxWithLoads(LoadAddr))
Alexey Bataevfa0a76d2017-12-12 19:12:34 +00001367 return false;
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001368
Alexey Bataev83c15b12017-12-12 20:28:46 +00001369 if (!all_of(LI->users(), [LI, LoadAddr](User *U) {
1370 auto *SI = dyn_cast<StoreInst>(U);
1371 return SI && SI->getPointerOperand() != LI &&
1372 peekThroughBitcast(SI->getPointerOperand()) != LoadAddr &&
1373 !SI->getPointerOperand()->isSwiftError();
1374 }))
1375 return false;
1376
1377 IC.Builder.SetInsertPoint(LI);
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001378 LoadInst *NewLI = combineLoadToNewType(
1379 IC, *LI, LoadAddr->getType()->getPointerElementType());
Alexey Bataev83c15b12017-12-12 20:28:46 +00001380 // Replace all the stores with stores of the newly loaded value.
1381 for (auto *UI : LI->users()) {
1382 auto *USI = cast<StoreInst>(UI);
1383 IC.Builder.SetInsertPoint(USI);
1384 combineStoreToNewValue(IC, *USI, NewLI);
1385 }
1386 IC.replaceInstUsesWith(*LI, UndefValue::get(LI->getType()));
1387 IC.eraseInstFromFunction(*LI);
Alexey Bataevfa0a76d2017-12-12 19:12:34 +00001388 return true;
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001389}
1390
Chris Lattnera65e2f72010-01-05 05:57:49 +00001391Instruction *InstCombiner::visitStoreInst(StoreInst &SI) {
1392 Value *Val = SI.getOperand(0);
1393 Value *Ptr = SI.getOperand(1);
1394
Chandler Carruth816d26f2014-11-25 10:09:51 +00001395 // Try to canonicalize the stored type.
1396 if (combineStoreToValueType(*this, SI))
Sanjay Patel4b198802016-02-01 22:23:39 +00001397 return eraseInstFromFunction(SI);
Chandler Carruth816d26f2014-11-25 10:09:51 +00001398
Chris Lattnera65e2f72010-01-05 05:57:49 +00001399 // Attempt to improve the alignment.
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001400 unsigned KnownAlign = getOrEnforceKnownAlignment(
Daniel Jasperaec2fa32016-12-19 08:22:17 +00001401 Ptr, DL.getPrefTypeAlignment(Val->getType()), DL, &SI, &AC, &DT);
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001402 unsigned StoreAlign = SI.getAlignment();
1403 unsigned EffectiveStoreAlign =
1404 StoreAlign != 0 ? StoreAlign : DL.getABITypeAlignment(Val->getType());
Dan Gohman36196602010-08-03 18:20:32 +00001405
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001406 if (KnownAlign > EffectiveStoreAlign)
1407 SI.setAlignment(KnownAlign);
1408 else if (StoreAlign == 0)
1409 SI.setAlignment(EffectiveStoreAlign);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001410
Mehdi Aminib344ac92015-03-14 22:19:33 +00001411 // Try to canonicalize the stored type.
1412 if (unpackStoreToAggregate(*this, SI))
Sanjay Patel4b198802016-02-01 22:23:39 +00001413 return eraseInstFromFunction(SI);
Mehdi Aminib344ac92015-03-14 22:19:33 +00001414
Alexey Bataevfa0a76d2017-12-12 19:12:34 +00001415 if (removeBitcastsFromLoadStoreOnMinMax(*this, SI))
1416 return eraseInstFromFunction(SI);
Alexey Bataevec95c6c2017-12-08 15:32:10 +00001417
Hal Finkel847e05f2015-02-20 03:05:53 +00001418 // Replace GEP indices if possible.
1419 if (Instruction *NewGEPI = replaceGEPIdxWithZero(*this, Ptr, SI)) {
1420 Worklist.Add(NewGEPI);
1421 return &SI;
1422 }
1423
Philip Reamesd7a6cc82015-12-17 22:19:27 +00001424 // Don't hack volatile/ordered stores.
1425 // FIXME: Some bits are legal for ordered atomic stores; needs refactoring.
1426 if (!SI.isUnordered()) return nullptr;
Eli Friedman8bc586e2011-08-15 22:09:40 +00001427
1428 // If the RHS is an alloca with a single use, zapify the store, making the
1429 // alloca dead.
1430 if (Ptr->hasOneUse()) {
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001431 if (isa<AllocaInst>(Ptr))
Sanjay Patel4b198802016-02-01 22:23:39 +00001432 return eraseInstFromFunction(SI);
Eli Friedman8bc586e2011-08-15 22:09:40 +00001433 if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Ptr)) {
1434 if (isa<AllocaInst>(GEP->getOperand(0))) {
1435 if (GEP->getOperand(0)->hasOneUse())
Sanjay Patel4b198802016-02-01 22:23:39 +00001436 return eraseInstFromFunction(SI);
Eli Friedman8bc586e2011-08-15 22:09:40 +00001437 }
1438 }
1439 }
1440
Chris Lattnera65e2f72010-01-05 05:57:49 +00001441 // Do really simple DSE, to catch cases where there are several consecutive
1442 // stores to the same location, separated by a few arithmetic operations. This
1443 // situation often occurs with bitfield accesses.
Duncan P. N. Exon Smith9f8aaf22015-10-13 16:59:33 +00001444 BasicBlock::iterator BBI(SI);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001445 for (unsigned ScanInsts = 6; BBI != SI.getParent()->begin() && ScanInsts;
1446 --ScanInsts) {
1447 --BBI;
Victor Hernandez5f8c8c02010-01-22 19:05:05 +00001448 // Don't count debug info directives, lest they affect codegen,
1449 // and we skip pointer-to-pointer bitcasts, which are NOPs.
1450 if (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +00001451 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy())) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001452 ScanInsts++;
1453 continue;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001454 }
1455
Chris Lattnera65e2f72010-01-05 05:57:49 +00001456 if (StoreInst *PrevSI = dyn_cast<StoreInst>(BBI)) {
1457 // Prev store isn't volatile, and stores to the same location?
Philip Reamesd7a6cc82015-12-17 22:19:27 +00001458 if (PrevSI->isUnordered() && equivalentAddressValues(PrevSI->getOperand(1),
Eli Friedman8bc586e2011-08-15 22:09:40 +00001459 SI.getOperand(1))) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001460 ++NumDeadStore;
1461 ++BBI;
Sanjay Patel4b198802016-02-01 22:23:39 +00001462 eraseInstFromFunction(*PrevSI);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001463 continue;
1464 }
1465 break;
1466 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001467
Chris Lattnera65e2f72010-01-05 05:57:49 +00001468 // If this is a load, we have to stop. However, if the loaded value is from
1469 // the pointer we're loading and is producing the pointer we're storing,
1470 // then *this* store is dead (X = load P; store X -> P).
1471 if (LoadInst *LI = dyn_cast<LoadInst>(BBI)) {
Philip Reamesd7a6cc82015-12-17 22:19:27 +00001472 if (LI == Val && equivalentAddressValues(LI->getOperand(0), Ptr)) {
1473 assert(SI.isUnordered() && "can't eliminate ordering operation");
Sanjay Patel4b198802016-02-01 22:23:39 +00001474 return eraseInstFromFunction(SI);
Philip Reamesd7a6cc82015-12-17 22:19:27 +00001475 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001476
Chris Lattnera65e2f72010-01-05 05:57:49 +00001477 // Otherwise, this is a load from some other location. Stores before it
1478 // may not be dead.
1479 break;
1480 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001481
Sanjoy Das679bc322017-01-17 05:45:09 +00001482 // Don't skip over loads, throws or things that can modify memory.
1483 if (BBI->mayWriteToMemory() || BBI->mayReadFromMemory() || BBI->mayThrow())
Chris Lattnera65e2f72010-01-05 05:57:49 +00001484 break;
1485 }
Chris Lattnera65e2f72010-01-05 05:57:49 +00001486
1487 // store X, null -> turns into 'unreachable' in SimplifyCFG
Anna Thomas2dd98352017-12-12 14:12:33 +00001488 // store X, GEP(null, Y) -> turns into 'unreachable' in SimplifyCFG
1489 if (canSimplifyNullStoreOrGEP(SI)) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001490 if (!isa<UndefValue>(Val)) {
1491 SI.setOperand(0, UndefValue::get(Val->getType()));
1492 if (Instruction *U = dyn_cast<Instruction>(Val))
1493 Worklist.Add(U); // Dropped a use.
1494 }
Craig Topperf40110f2014-04-25 05:29:35 +00001495 return nullptr; // Do not modify these!
Chris Lattnera65e2f72010-01-05 05:57:49 +00001496 }
1497
1498 // store undef, Ptr -> noop
1499 if (isa<UndefValue>(Val))
Sanjay Patel4b198802016-02-01 22:23:39 +00001500 return eraseInstFromFunction(SI);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001501
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001502 // If this store is the second-to-last instruction in the basic block
1503 // (excluding debug info and bitcasts of pointers) and if the block ends with
1504 // an unconditional branch, try to move the store to the successor block.
Duncan P. N. Exon Smith9f8aaf22015-10-13 16:59:33 +00001505 BBI = SI.getIterator();
Chris Lattnera65e2f72010-01-05 05:57:49 +00001506 do {
1507 ++BBI;
Victor Hernandez5f8c8c02010-01-22 19:05:05 +00001508 } while (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +00001509 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy()));
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001510
Chris Lattnera65e2f72010-01-05 05:57:49 +00001511 if (BranchInst *BI = dyn_cast<BranchInst>(BBI))
1512 if (BI->isUnconditional())
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001513 mergeStoreIntoSuccessor(SI);
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001514
Craig Topperf40110f2014-04-25 05:29:35 +00001515 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001516}
1517
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001518/// Try to transform:
Chris Lattnera65e2f72010-01-05 05:57:49 +00001519/// if () { *P = v1; } else { *P = v2 }
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001520/// or:
Chris Lattnera65e2f72010-01-05 05:57:49 +00001521/// *P = v1; if () { *P = v2; }
1522/// into a phi node with a store in the successor.
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001523bool InstCombiner::mergeStoreIntoSuccessor(StoreInst &SI) {
Philip Reames5f0e3692016-04-22 20:53:32 +00001524 assert(SI.isUnordered() &&
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001525 "This code has not been audited for volatile or ordered store case.");
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00001526
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001527 // Check if the successor block has exactly 2 incoming edges.
Chris Lattnera65e2f72010-01-05 05:57:49 +00001528 BasicBlock *StoreBB = SI.getParent();
Chris Lattnera65e2f72010-01-05 05:57:49 +00001529 BasicBlock *DestBB = StoreBB->getTerminator()->getSuccessor(0);
Vedant Kumar4de31bb2018-11-19 19:54:27 +00001530 if (!DestBB->hasNPredecessors(2))
Chris Lattnera65e2f72010-01-05 05:57:49 +00001531 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001532
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001533 // Capture the other block (the block that doesn't contain our store).
1534 pred_iterator PredIter = pred_begin(DestBB);
1535 if (*PredIter == StoreBB)
1536 ++PredIter;
1537 BasicBlock *OtherBB = *PredIter;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001538
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001539 // Bail out if all of the relevant blocks aren't distinct. This can happen,
1540 // for example, if SI is in an infinite loop.
Chris Lattnera65e2f72010-01-05 05:57:49 +00001541 if (StoreBB == DestBB || OtherBB == DestBB)
1542 return false;
1543
1544 // Verify that the other block ends in a branch and is not otherwise empty.
Duncan P. N. Exon Smith9f8aaf22015-10-13 16:59:33 +00001545 BasicBlock::iterator BBI(OtherBB->getTerminator());
Chris Lattnera65e2f72010-01-05 05:57:49 +00001546 BranchInst *OtherBr = dyn_cast<BranchInst>(BBI);
1547 if (!OtherBr || BBI == OtherBB->begin())
1548 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001549
Chris Lattnera65e2f72010-01-05 05:57:49 +00001550 // If the other block ends in an unconditional branch, check for the 'if then
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001551 // else' case. There is an instruction before the branch.
Craig Topperf40110f2014-04-25 05:29:35 +00001552 StoreInst *OtherStore = nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001553 if (OtherBr->isUnconditional()) {
1554 --BBI;
1555 // Skip over debugging info.
Victor Hernandez5f8c8c02010-01-22 19:05:05 +00001556 while (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +00001557 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy())) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001558 if (BBI==OtherBB->begin())
1559 return false;
1560 --BBI;
1561 }
Eli Friedman8bc586e2011-08-15 22:09:40 +00001562 // If this isn't a store, isn't a store to the same location, or is not the
1563 // right kind of store, bail out.
Chris Lattnera65e2f72010-01-05 05:57:49 +00001564 OtherStore = dyn_cast<StoreInst>(BBI);
1565 if (!OtherStore || OtherStore->getOperand(1) != SI.getOperand(1) ||
Eli Friedman8bc586e2011-08-15 22:09:40 +00001566 !SI.isSameOperationAs(OtherStore))
Chris Lattnera65e2f72010-01-05 05:57:49 +00001567 return false;
1568 } else {
1569 // Otherwise, the other block ended with a conditional branch. If one of the
1570 // destinations is StoreBB, then we have the if/then case.
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001571 if (OtherBr->getSuccessor(0) != StoreBB &&
Chris Lattnera65e2f72010-01-05 05:57:49 +00001572 OtherBr->getSuccessor(1) != StoreBB)
1573 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001574
Chris Lattnera65e2f72010-01-05 05:57:49 +00001575 // Okay, we know that OtherBr now goes to Dest and StoreBB, so this is an
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001576 // if/then triangle. See if there is a store to the same ptr as SI that
Chris Lattnera65e2f72010-01-05 05:57:49 +00001577 // lives in OtherBB.
1578 for (;; --BBI) {
1579 // Check to see if we find the matching store.
1580 if ((OtherStore = dyn_cast<StoreInst>(BBI))) {
1581 if (OtherStore->getOperand(1) != SI.getOperand(1) ||
Eli Friedman8bc586e2011-08-15 22:09:40 +00001582 !SI.isSameOperationAs(OtherStore))
Chris Lattnera65e2f72010-01-05 05:57:49 +00001583 return false;
1584 break;
1585 }
1586 // If we find something that may be using or overwriting the stored
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001587 // value, or if we run out of instructions, we can't do the transform.
Sanjoy Das679bc322017-01-17 05:45:09 +00001588 if (BBI->mayReadFromMemory() || BBI->mayThrow() ||
1589 BBI->mayWriteToMemory() || BBI == OtherBB->begin())
Chris Lattnera65e2f72010-01-05 05:57:49 +00001590 return false;
1591 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001592
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001593 // In order to eliminate the store in OtherBr, we have to make sure nothing
1594 // reads or overwrites the stored value in StoreBB.
Chris Lattnera65e2f72010-01-05 05:57:49 +00001595 for (BasicBlock::iterator I = StoreBB->begin(); &*I != &SI; ++I) {
1596 // FIXME: This should really be AA driven.
Sanjoy Das679bc322017-01-17 05:45:09 +00001597 if (I->mayReadFromMemory() || I->mayThrow() || I->mayWriteToMemory())
Chris Lattnera65e2f72010-01-05 05:57:49 +00001598 return false;
1599 }
1600 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001601
Chris Lattnera65e2f72010-01-05 05:57:49 +00001602 // Insert a PHI node now if we need it.
1603 Value *MergedVal = OtherStore->getOperand(0);
Vedant Kumar238533e2018-11-19 19:55:02 +00001604 // The debug locations of the original instructions might differ. Merge them.
1605 DebugLoc MergedLoc = DILocation::getMergedLocation(SI.getDebugLoc(),
1606 OtherStore->getDebugLoc());
Chris Lattnera65e2f72010-01-05 05:57:49 +00001607 if (MergedVal != SI.getOperand(0)) {
Jay Foad52131342011-03-30 11:28:46 +00001608 PHINode *PN = PHINode::Create(MergedVal->getType(), 2, "storemerge");
Chris Lattnera65e2f72010-01-05 05:57:49 +00001609 PN->addIncoming(SI.getOperand(0), SI.getParent());
1610 PN->addIncoming(OtherStore->getOperand(0), OtherBB);
1611 MergedVal = InsertNewInstBefore(PN, DestBB->front());
Vedant Kumar238533e2018-11-19 19:55:02 +00001612 PN->setDebugLoc(MergedLoc);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001613 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001614
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001615 // Advance to a place where it is safe to insert the new store and insert it.
Bill Wendling8ddfc092011-08-16 20:45:24 +00001616 BBI = DestBB->getFirstInsertionPt();
Eli Friedman35211c62011-05-27 00:19:40 +00001617 StoreInst *NewSI = new StoreInst(MergedVal, SI.getOperand(1),
Sanjay Patel4a12aa92018-11-10 20:29:25 +00001618 SI.isVolatile(), SI.getAlignment(),
1619 SI.getOrdering(), SI.getSyncScopeID());
Eli Friedman35211c62011-05-27 00:19:40 +00001620 InsertNewInstBefore(NewSI, *BBI);
Vedant Kumar238533e2018-11-19 19:55:02 +00001621 NewSI->setDebugLoc(MergedLoc);
Eli Friedman35211c62011-05-27 00:19:40 +00001622
Hal Finkelcc39b672014-07-24 12:16:19 +00001623 // If the two stores had AA tags, merge them.
1624 AAMDNodes AATags;
1625 SI.getAAMetadata(AATags);
1626 if (AATags) {
1627 OtherStore->getAAMetadata(AATags, /* Merge = */ true);
1628 NewSI->setAAMetadata(AATags);
1629 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001630
Chris Lattnera65e2f72010-01-05 05:57:49 +00001631 // Nuke the old stores.
Sanjay Patel4b198802016-02-01 22:23:39 +00001632 eraseInstFromFunction(SI);
1633 eraseInstFromFunction(*OtherStore);
Chris Lattnera65e2f72010-01-05 05:57:49 +00001634 return true;
1635}