John Thompson | d977c1e | 2013-03-27 18:34:38 +0000 | [diff] [blame] | 1 | //===- extra/modularize/Modularize.cpp - Check modularized headers --------===// |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file implements a tool that checks whether a set of headers provides |
| 11 | // the consistent definitions required to use modules. For example, it detects |
| 12 | // whether the same entity (say, a NULL macro or size_t typedef) is defined in |
| 13 | // multiple headers or whether a header produces different definitions under |
| 14 | // different circumstances. These conditions cause modules built from the |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 15 | // headers to behave poorly, and should be fixed before introducing a module |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 16 | // map. |
| 17 | // |
| 18 | // Modularize takes as argument a file name for a file containing the |
| 19 | // newline-separated list of headers to check with respect to each other. |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 20 | // Lines beginning with '#' and empty lines are ignored. |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 21 | // Header file names followed by a colon and other space-separated |
| 22 | // file names will include those extra files as dependencies. |
| 23 | // The file names can be relative or full paths, but must be on the |
| 24 | // same line. |
| 25 | // |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 26 | // Modularize also accepts regular front-end arguments. |
| 27 | // |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 28 | // Usage: modularize [-prefix (optional header path prefix)] |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 29 | // (include-files_list) [(front-end-options) ...] |
| 30 | // |
John Thompson | a44f85a | 2013-04-15 22:32:28 +0000 | [diff] [blame] | 31 | // Note that unless a "-prefix (header path)" option is specified, |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 32 | // non-absolute file paths in the header list file will be relative |
| 33 | // to the header list file directory. Use -prefix to specify a different |
| 34 | // directory. |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 35 | // |
John Thompson | fd8ca38 | 2013-03-27 19:31:22 +0000 | [diff] [blame] | 36 | // Note that by default, the underlying Clang front end assumes .h files |
| 37 | // contain C source. If your .h files in the file list contain C++ source, |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 38 | // you should append the following to your command lines: -x c++ |
John Thompson | fd8ca38 | 2013-03-27 19:31:22 +0000 | [diff] [blame] | 39 | // |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 40 | // Modularize will do normal parsing, reporting normal errors and warnings, |
| 41 | // but will also report special error messages like the following: |
| 42 | // |
John Thompson | 7c6e79f3 | 2013-07-29 19:07:00 +0000 | [diff] [blame] | 43 | // error: '(symbol)' defined at multiple locations: |
| 44 | // (file):(row):(column) |
| 45 | // (file):(row):(column) |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 46 | // |
John Thompson | dc11827 | 2013-07-29 21:59:41 +0000 | [diff] [blame] | 47 | // error: header '(file)' has different contents depending on how it was |
John Thompson | 7c6e79f3 | 2013-07-29 19:07:00 +0000 | [diff] [blame] | 48 | // included |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 49 | // |
| 50 | // The latter might be followed by messages like the following: |
| 51 | // |
John Thompson | 7c6e79f3 | 2013-07-29 19:07:00 +0000 | [diff] [blame] | 52 | // note: '(symbol)' in (file) at (row):(column) not always provided |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 53 | // |
John Thompson | 7c6e79f3 | 2013-07-29 19:07:00 +0000 | [diff] [blame] | 54 | // Checks will also be performed for macro expansions, defined(macro) |
| 55 | // expressions, and preprocessor conditional directives that evaluate |
| 56 | // inconsistently, and can produce error messages like the following: |
| 57 | // |
Nico Weber | 8e20be2 | 2013-08-12 11:43:36 +0000 | [diff] [blame] | 58 | // (...)/SubHeader.h:11:5: |
| 59 | // #if SYMBOL == 1 |
| 60 | // ^ |
| 61 | // error: Macro instance 'SYMBOL' has different values in this header, |
| 62 | // depending on how it was included. |
| 63 | // 'SYMBOL' expanded to: '1' with respect to these inclusion paths: |
| 64 | // (...)/Header1.h |
| 65 | // (...)/SubHeader.h |
| 66 | // (...)/SubHeader.h:3:9: |
| 67 | // #define SYMBOL 1 |
| 68 | // ^ |
| 69 | // Macro defined here. |
| 70 | // 'SYMBOL' expanded to: '2' with respect to these inclusion paths: |
| 71 | // (...)/Header2.h |
| 72 | // (...)/SubHeader.h |
| 73 | // (...)/SubHeader.h:7:9: |
| 74 | // #define SYMBOL 2 |
| 75 | // ^ |
| 76 | // Macro defined here. |
| 77 | // |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 78 | // Checks will also be performed for '#include' directives that are |
| 79 | // nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks, |
| 80 | // and can produce error message like the following: |
| 81 | // |
| 82 | // IncludeInExtern.h:2:3 |
| 83 | // #include "Empty.h" |
| 84 | // ^ |
| 85 | // error: Include directive within extern "C" {}. |
| 86 | // IncludeInExtern.h:1:1 |
| 87 | // extern "C" { |
| 88 | // ^ |
| 89 | // The "extern "C" {}" block is here. |
| 90 | // |
John Thompson | 4fa9c2c | 2013-08-09 00:19:03 +0000 | [diff] [blame] | 91 | // See PreprocessorTracker.cpp for additional details. |
John Thompson | cc2e291 | 2013-09-03 18:44:11 +0000 | [diff] [blame] | 92 | // |
John Thompson | 5d9862f | 2015-02-10 14:45:30 +0000 | [diff] [blame^] | 93 | // Modularize also has an option ("-module-map-path=module.modulemap") that will |
| 94 | // skip the checks, and instead act as a module.modulemap generation assistant, |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 95 | // generating a module map file based on the header list. An optional |
| 96 | // "-root-module=(rootName)" argument can specify a root module to be |
John Thompson | 5d9862f | 2015-02-10 14:45:30 +0000 | [diff] [blame^] | 97 | // created in the generated module.modulemap file. Note that you will likely |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 98 | // need to edit this file to suit the needs of your headers. |
| 99 | // |
John Thompson | 5d9862f | 2015-02-10 14:45:30 +0000 | [diff] [blame^] | 100 | // An example command line for generating a module.modulemap file: |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 101 | // |
John Thompson | 5d9862f | 2015-02-10 14:45:30 +0000 | [diff] [blame^] | 102 | // modularize -module-map-path=module.modulemap -root-module=myroot \ |
| 103 | // headerlist.txt |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 104 | // |
| 105 | // Note that if the headers in the header list have partial paths, sub-modules |
| 106 | // will be created for the subdirectires involved, assuming that the |
| 107 | // subdirectories contain headers to be grouped into a module, but still with |
| 108 | // individual modules for the headers in the subdirectory. |
| 109 | // |
| 110 | // See the ModuleAssistant.cpp file comments for additional details about the |
| 111 | // implementation of the assistant mode. |
| 112 | // |
John Thompson | 7475180 | 2013-09-03 18:48:43 +0000 | [diff] [blame] | 113 | // Future directions: |
| 114 | // |
| 115 | // Basically, we want to add new checks for whatever we can check with respect |
| 116 | // to checking headers for module'ability. |
| 117 | // |
| 118 | // Some ideas: |
| 119 | // |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 120 | // 1. Omit duplicate "not always provided" messages |
John Thompson | 53a9d2d | 2013-09-04 18:29:36 +0000 | [diff] [blame] | 121 | // |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 122 | // 2. Add options to disable any of the checks, in case |
John Thompson | 7475180 | 2013-09-03 18:48:43 +0000 | [diff] [blame] | 123 | // there is some problem with them, or the messages get too verbose. |
| 124 | // |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 125 | // 3. Try to figure out the preprocessor conditional directives that |
John Thompson | 7475180 | 2013-09-03 18:48:43 +0000 | [diff] [blame] | 126 | // contribute to problems and tie them to the inconsistent definitions. |
| 127 | // |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 128 | // 4. There are some legitimate uses of preprocessor macros that |
Bob Wilson | f5999bd | 2013-09-04 16:48:28 +0000 | [diff] [blame] | 129 | // modularize will flag as errors, such as repeatedly #include'ing |
| 130 | // a file and using interleaving defined/undefined macros |
| 131 | // to change declarations in the included file. Is there a way |
| 132 | // to address this? Maybe have modularize accept a list of macros |
| 133 | // to ignore. Otherwise you can just exclude the file, after checking |
| 134 | // for legitimate errors. |
| 135 | // |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 136 | // 5. What else? |
John Thompson | ce601e2 | 2013-03-14 01:41:29 +0000 | [diff] [blame] | 137 | // |
| 138 | // General clean-up and refactoring: |
| 139 | // |
| 140 | // 1. The Location class seems to be something that we might |
| 141 | // want to design to be applicable to a wider range of tools, and stick it |
| 142 | // somewhere into Tooling/ in mainline |
| 143 | // |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 144 | //===----------------------------------------------------------------------===// |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 145 | |
Chandler Carruth | 85e6e87 | 2014-01-07 20:05:01 +0000 | [diff] [blame] | 146 | #include "Modularize.h" |
| 147 | #include "PreprocessorTracker.h" |
Chandler Carruth | f7e45c0 | 2014-01-07 22:15:39 +0000 | [diff] [blame] | 148 | #include "clang/AST/ASTConsumer.h" |
John Thompson | d977c1e | 2013-03-27 18:34:38 +0000 | [diff] [blame] | 149 | #include "clang/AST/ASTContext.h" |
| 150 | #include "clang/AST/RecursiveASTVisitor.h" |
| 151 | #include "clang/Basic/SourceManager.h" |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 152 | #include "clang/Driver/Options.h" |
John Thompson | d977c1e | 2013-03-27 18:34:38 +0000 | [diff] [blame] | 153 | #include "clang/Frontend/CompilerInstance.h" |
| 154 | #include "clang/Frontend/FrontendActions.h" |
| 155 | #include "clang/Lex/Preprocessor.h" |
| 156 | #include "clang/Tooling/CompilationDatabase.h" |
| 157 | #include "clang/Tooling/Tooling.h" |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 158 | #include "llvm/Option/Arg.h" |
| 159 | #include "llvm/Option/ArgList.h" |
| 160 | #include "llvm/Option/OptTable.h" |
| 161 | #include "llvm/Option/Option.h" |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 162 | #include "llvm/Support/CommandLine.h" |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 163 | #include "llvm/Support/FileSystem.h" |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 164 | #include "llvm/Support/MemoryBuffer.h" |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 165 | #include "llvm/Support/Path.h" |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 166 | #include <algorithm> |
John Thompson | d977c1e | 2013-03-27 18:34:38 +0000 | [diff] [blame] | 167 | #include <fstream> |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 168 | #include <iterator> |
John Thompson | d977c1e | 2013-03-27 18:34:38 +0000 | [diff] [blame] | 169 | #include <string> |
| 170 | #include <vector> |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 171 | |
Bob Wilson | f5999bd | 2013-09-04 16:48:28 +0000 | [diff] [blame] | 172 | using namespace clang; |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 173 | using namespace clang::driver; |
| 174 | using namespace clang::driver::options; |
| 175 | using namespace clang::tooling; |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 176 | using namespace llvm; |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 177 | using namespace llvm::opt; |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 178 | using namespace Modularize; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 179 | |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 180 | // Option to specify a file name for a list of header files to check. |
John Thompson | b809dfc | 2013-07-19 14:19:31 +0000 | [diff] [blame] | 181 | cl::opt<std::string> |
| 182 | ListFileName(cl::Positional, |
| 183 | cl::desc("<name of file containing list of headers to check>")); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 184 | |
| 185 | // Collect all other arguments, which will be passed to the front end. |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 186 | cl::list<std::string> |
John Thompson | b809dfc | 2013-07-19 14:19:31 +0000 | [diff] [blame] | 187 | CC1Arguments(cl::ConsumeAfter, |
| 188 | cl::desc("<arguments to be passed to front end>...")); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 189 | |
| 190 | // Option to specify a prefix to be prepended to the header names. |
| 191 | cl::opt<std::string> HeaderPrefix( |
| 192 | "prefix", cl::init(""), |
| 193 | cl::desc( |
| 194 | "Prepend header file paths with this prefix." |
| 195 | " If not specified," |
| 196 | " the files are considered to be relative to the header list file.")); |
| 197 | |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 198 | // Option for assistant mode, telling modularize to output a module map |
| 199 | // based on the headers list, and where to put it. |
| 200 | cl::opt<std::string> ModuleMapPath( |
| 201 | "module-map-path", cl::init(""), |
| 202 | cl::desc("Turn on module map output and specify output path or file name." |
| 203 | " If no path is specified and if prefix option is specified," |
| 204 | " use prefix for file path.")); |
| 205 | |
| 206 | // Option for assistant mode, telling modularize to output a module map |
| 207 | // based on the headers list, and where to put it. |
| 208 | cl::opt<std::string> |
| 209 | RootModule("root-module", cl::init(""), |
| 210 | cl::desc("Specify the name of the root module.")); |
| 211 | |
| 212 | // Save the program name for error messages. |
| 213 | const char *Argv0; |
| 214 | // Save the command line for comments. |
| 215 | std::string CommandLine; |
Bob Wilson | f5999bd | 2013-09-04 16:48:28 +0000 | [diff] [blame] | 216 | |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 217 | // Read the header list file and collect the header file names and |
| 218 | // optional dependencies. |
Rafael Espindola | c7f0d23 | 2014-06-12 22:08:48 +0000 | [diff] [blame] | 219 | std::error_code |
| 220 | getHeaderFileNames(SmallVectorImpl<std::string> &HeaderFileNames, |
| 221 | DependencyMap &Dependencies, StringRef ListFileName, |
| 222 | StringRef HeaderPrefix) { |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 223 | // By default, use the path component of the list file name. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 224 | SmallString<256> HeaderDirectory(ListFileName); |
| 225 | sys::path::remove_filename(HeaderDirectory); |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 226 | SmallString<256> CurrentDirectory; |
| 227 | sys::fs::current_path(CurrentDirectory); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 228 | |
| 229 | // Get the prefix if we have one. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 230 | if (HeaderPrefix.size() != 0) |
| 231 | HeaderDirectory = HeaderPrefix; |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 232 | |
| 233 | // Read the header list file into a buffer. |
Rafael Espindola | 43f0aa6 | 2014-07-06 17:43:19 +0000 | [diff] [blame] | 234 | ErrorOr<std::unique_ptr<MemoryBuffer>> listBuffer = |
| 235 | MemoryBuffer::getFile(ListFileName); |
| 236 | if (std::error_code EC = listBuffer.getError()) |
| 237 | return EC; |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 238 | |
| 239 | // Parse the header list into strings. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 240 | SmallVector<StringRef, 32> Strings; |
Rafael Espindola | 43f0aa6 | 2014-07-06 17:43:19 +0000 | [diff] [blame] | 241 | listBuffer.get()->getBuffer().split(Strings, "\n", -1, false); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 242 | |
| 243 | // Collect the header file names from the string list. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 244 | for (SmallVectorImpl<StringRef>::iterator I = Strings.begin(), |
| 245 | E = Strings.end(); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 246 | I != E; ++I) { |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 247 | StringRef Line = I->trim(); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 248 | // Ignore comments and empty lines. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 249 | if (Line.empty() || (Line[0] == '#')) |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 250 | continue; |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 251 | std::pair<StringRef, StringRef> TargetAndDependents = Line.split(':'); |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 252 | SmallString<256> HeaderFileName; |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 253 | // Prepend header file name prefix if it's not absolute. |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 254 | if (sys::path::is_absolute(TargetAndDependents.first)) |
| 255 | llvm::sys::path::native(TargetAndDependents.first, HeaderFileName); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 256 | else { |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 257 | if (HeaderDirectory.size() != 0) |
| 258 | HeaderFileName = HeaderDirectory; |
| 259 | else |
| 260 | HeaderFileName = CurrentDirectory; |
| 261 | sys::path::append(HeaderFileName, TargetAndDependents.first); |
Benjamin Kramer | 3353a10 | 2013-09-11 10:45:25 +0000 | [diff] [blame] | 262 | sys::path::native(HeaderFileName); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 263 | } |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 264 | // Handle optional dependencies. |
| 265 | DependentsVector Dependents; |
| 266 | SmallVector<StringRef, 4> DependentsList; |
| 267 | TargetAndDependents.second.split(DependentsList, " ", -1, false); |
| 268 | int Count = DependentsList.size(); |
| 269 | for (int Index = 0; Index < Count; ++Index) { |
| 270 | SmallString<256> Dependent; |
| 271 | if (sys::path::is_absolute(DependentsList[Index])) |
| 272 | Dependent = DependentsList[Index]; |
| 273 | else { |
| 274 | if (HeaderDirectory.size() != 0) |
| 275 | Dependent = HeaderDirectory; |
| 276 | else |
| 277 | Dependent = CurrentDirectory; |
| 278 | sys::path::append(Dependent, DependentsList[Index]); |
| 279 | } |
Benjamin Kramer | 3353a10 | 2013-09-11 10:45:25 +0000 | [diff] [blame] | 280 | sys::path::native(Dependent); |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 281 | Dependents.push_back(Dependent.str()); |
| 282 | } |
| 283 | // Save the resulting header file path and dependencies. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 284 | HeaderFileNames.push_back(HeaderFileName.str()); |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 285 | Dependencies[HeaderFileName.str()] = Dependents; |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 286 | } |
| 287 | |
Rafael Espindola | c7f0d23 | 2014-06-12 22:08:48 +0000 | [diff] [blame] | 288 | return std::error_code(); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 289 | } |
| 290 | |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 291 | // Helper function for finding the input file in an arguments list. |
| 292 | std::string findInputFile(const CommandLineArguments &CLArgs) { |
Ahmed Charles | 6a2dc5c | 2014-03-09 09:24:40 +0000 | [diff] [blame] | 293 | std::unique_ptr<OptTable> Opts(createDriverOptTable()); |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 294 | const unsigned IncludedFlagsBitmask = options::CC1Option; |
| 295 | unsigned MissingArgIndex, MissingArgCount; |
| 296 | SmallVector<const char *, 256> Argv; |
| 297 | for (CommandLineArguments::const_iterator I = CLArgs.begin(), |
| 298 | E = CLArgs.end(); |
| 299 | I != E; ++I) |
| 300 | Argv.push_back(I->c_str()); |
Ahmed Charles | 6a2dc5c | 2014-03-09 09:24:40 +0000 | [diff] [blame] | 301 | std::unique_ptr<InputArgList> Args( |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 302 | Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex, |
| 303 | MissingArgCount, IncludedFlagsBitmask)); |
| 304 | std::vector<std::string> Inputs = Args->getAllArgValues(OPT_INPUT); |
| 305 | return Inputs.back(); |
| 306 | } |
| 307 | |
Alexander Kornienko | d365731 | 2014-12-03 17:53:03 +0000 | [diff] [blame] | 308 | // This arguments adjuster inserts "-include (file)" arguments for header |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 309 | // dependencies. |
Alexander Kornienko | d365731 | 2014-12-03 17:53:03 +0000 | [diff] [blame] | 310 | ArgumentsAdjuster getAddDependenciesAdjuster(DependencyMap &Dependencies) { |
| 311 | return [&Dependencies](const CommandLineArguments &Args) { |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 312 | std::string InputFile = findInputFile(Args); |
| 313 | DependentsVector &FileDependents = Dependencies[InputFile]; |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 314 | CommandLineArguments NewArgs(Args); |
Alexander Kornienko | d365731 | 2014-12-03 17:53:03 +0000 | [diff] [blame] | 315 | if (int Count = FileDependents.size()) { |
| 316 | for (int Index = 0; Index < Count; ++Index) { |
| 317 | NewArgs.push_back("-include"); |
| 318 | std::string File(std::string("\"") + FileDependents[Index] + |
| 319 | std::string("\"")); |
| 320 | NewArgs.push_back(FileDependents[Index]); |
| 321 | } |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 322 | } |
| 323 | return NewArgs; |
Alexander Kornienko | d365731 | 2014-12-03 17:53:03 +0000 | [diff] [blame] | 324 | }; |
| 325 | } |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 326 | |
John Thompson | ce601e2 | 2013-03-14 01:41:29 +0000 | [diff] [blame] | 327 | // FIXME: The Location class seems to be something that we might |
| 328 | // want to design to be applicable to a wider range of tools, and stick it |
| 329 | // somewhere into Tooling/ in mainline |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 330 | struct Location { |
| 331 | const FileEntry *File; |
| 332 | unsigned Line, Column; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 333 | |
| 334 | Location() : File(), Line(), Column() {} |
| 335 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 336 | Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() { |
| 337 | Loc = SM.getExpansionLoc(Loc); |
| 338 | if (Loc.isInvalid()) |
| 339 | return; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 340 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 341 | std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc); |
| 342 | File = SM.getFileEntryForID(Decomposed.first); |
| 343 | if (!File) |
| 344 | return; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 345 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 346 | Line = SM.getLineNumber(Decomposed.first, Decomposed.second); |
| 347 | Column = SM.getColumnNumber(Decomposed.first, Decomposed.second); |
| 348 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 349 | |
Craig Topper | f61be9c | 2014-06-09 02:03:06 +0000 | [diff] [blame] | 350 | operator bool() const { return File != nullptr; } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 351 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 352 | friend bool operator==(const Location &X, const Location &Y) { |
| 353 | return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column; |
| 354 | } |
| 355 | |
| 356 | friend bool operator!=(const Location &X, const Location &Y) { |
| 357 | return !(X == Y); |
| 358 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 359 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 360 | friend bool operator<(const Location &X, const Location &Y) { |
| 361 | if (X.File != Y.File) |
| 362 | return X.File < Y.File; |
| 363 | if (X.Line != Y.Line) |
| 364 | return X.Line < Y.Line; |
| 365 | return X.Column < Y.Column; |
| 366 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 367 | friend bool operator>(const Location &X, const Location &Y) { return Y < X; } |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 368 | friend bool operator<=(const Location &X, const Location &Y) { |
| 369 | return !(Y < X); |
| 370 | } |
| 371 | friend bool operator>=(const Location &X, const Location &Y) { |
| 372 | return !(X < Y); |
| 373 | } |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 374 | }; |
| 375 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 376 | struct Entry { |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 377 | enum EntryKind { |
| 378 | EK_Tag, |
| 379 | EK_Value, |
| 380 | EK_Macro, |
| 381 | |
| 382 | EK_NumberOfKinds |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 383 | } Kind; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 384 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 385 | Location Loc; |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 386 | |
| 387 | StringRef getKindName() { return getKindName(Kind); } |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 388 | static StringRef getKindName(EntryKind kind); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 389 | }; |
| 390 | |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 391 | // Return a string representing the given kind. |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 392 | StringRef Entry::getKindName(Entry::EntryKind kind) { |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 393 | switch (kind) { |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 394 | case EK_Tag: |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 395 | return "tag"; |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 396 | case EK_Value: |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 397 | return "value"; |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 398 | case EK_Macro: |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 399 | return "macro"; |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 400 | case EK_NumberOfKinds: |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 401 | break; |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 402 | } |
David Blaikie | c66c07d | 2013-03-28 02:30:37 +0000 | [diff] [blame] | 403 | llvm_unreachable("invalid Entry kind"); |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 404 | } |
| 405 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 406 | struct HeaderEntry { |
| 407 | std::string Name; |
| 408 | Location Loc; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 409 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 410 | friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) { |
| 411 | return X.Loc == Y.Loc && X.Name == Y.Name; |
| 412 | } |
| 413 | friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) { |
| 414 | return !(X == Y); |
| 415 | } |
| 416 | friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) { |
| 417 | return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name); |
| 418 | } |
| 419 | friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) { |
| 420 | return Y < X; |
| 421 | } |
| 422 | friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) { |
| 423 | return !(Y < X); |
| 424 | } |
| 425 | friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) { |
| 426 | return !(X < Y); |
| 427 | } |
| 428 | }; |
| 429 | |
| 430 | typedef std::vector<HeaderEntry> HeaderContents; |
| 431 | |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 432 | class EntityMap : public StringMap<SmallVector<Entry, 2> > { |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 433 | public: |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 434 | DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches; |
| 435 | |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 436 | void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) { |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 437 | // Record this entity in its header. |
| 438 | HeaderEntry HE = { Name, Loc }; |
| 439 | CurHeaderContents[Loc.File].push_back(HE); |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 440 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 441 | // Check whether we've seen this entry before. |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 442 | SmallVector<Entry, 2> &Entries = (*this)[Name]; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 443 | for (unsigned I = 0, N = Entries.size(); I != N; ++I) { |
| 444 | if (Entries[I].Kind == Kind && Entries[I].Loc == Loc) |
| 445 | return; |
| 446 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 447 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 448 | // We have not seen this entry before; record it. |
| 449 | Entry E = { Kind, Loc }; |
| 450 | Entries.push_back(E); |
| 451 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 452 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 453 | void mergeCurHeaderContents() { |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 454 | for (DenseMap<const FileEntry *, HeaderContents>::iterator |
| 455 | H = CurHeaderContents.begin(), |
| 456 | HEnd = CurHeaderContents.end(); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 457 | H != HEnd; ++H) { |
| 458 | // Sort contents. |
| 459 | std::sort(H->second.begin(), H->second.end()); |
| 460 | |
| 461 | // Check whether we've seen this header before. |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 462 | DenseMap<const FileEntry *, HeaderContents>::iterator KnownH = |
| 463 | AllHeaderContents.find(H->first); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 464 | if (KnownH == AllHeaderContents.end()) { |
| 465 | // We haven't seen this header before; record its contents. |
| 466 | AllHeaderContents.insert(*H); |
| 467 | continue; |
| 468 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 469 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 470 | // If the header contents are the same, we're done. |
| 471 | if (H->second == KnownH->second) |
| 472 | continue; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 473 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 474 | // Determine what changed. |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 475 | std::set_symmetric_difference( |
| 476 | H->second.begin(), H->second.end(), KnownH->second.begin(), |
| 477 | KnownH->second.end(), |
| 478 | std::back_inserter(HeaderContentMismatches[H->first])); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 479 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 480 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 481 | CurHeaderContents.clear(); |
| 482 | } |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 483 | |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 484 | private: |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 485 | DenseMap<const FileEntry *, HeaderContents> CurHeaderContents; |
| 486 | DenseMap<const FileEntry *, HeaderContents> AllHeaderContents; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 487 | }; |
| 488 | |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 489 | class CollectEntitiesVisitor |
| 490 | : public RecursiveASTVisitor<CollectEntitiesVisitor> { |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 491 | public: |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 492 | CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities, |
| 493 | Preprocessor &PP, PreprocessorTracker &PPTracker, |
| 494 | int &HadErrors) |
| 495 | : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker), |
| 496 | HadErrors(HadErrors) {} |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 497 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 498 | bool TraverseStmt(Stmt *S) { return true; } |
| 499 | bool TraverseType(QualType T) { return true; } |
| 500 | bool TraverseTypeLoc(TypeLoc TL) { return true; } |
| 501 | bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 502 | bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) { |
| 503 | return true; |
| 504 | } |
| 505 | bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) { |
| 506 | return true; |
| 507 | } |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 508 | bool TraverseTemplateName(TemplateName Template) { return true; } |
| 509 | bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 510 | bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) { |
| 511 | return true; |
| 512 | } |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 513 | bool TraverseTemplateArguments(const TemplateArgument *Args, |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 514 | unsigned NumArgs) { |
| 515 | return true; |
| 516 | } |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 517 | bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; } |
Benjamin Kramer | 281f9d0 | 2014-05-10 16:32:07 +0000 | [diff] [blame] | 518 | bool TraverseLambdaCapture(LambdaCapture C) { return true; } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 519 | |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 520 | // Check 'extern "*" {}' block for #include directives. |
| 521 | bool VisitLinkageSpecDecl(LinkageSpecDecl *D) { |
| 522 | // Bail if not a block. |
| 523 | if (!D->hasBraces()) |
| 524 | return true; |
| 525 | SourceRange BlockRange = D->getSourceRange(); |
| 526 | const char *LinkageLabel; |
| 527 | switch (D->getLanguage()) { |
| 528 | case LinkageSpecDecl::lang_c: |
| 529 | LinkageLabel = "extern \"C\" {}"; |
| 530 | break; |
| 531 | case LinkageSpecDecl::lang_cxx: |
| 532 | LinkageLabel = "extern \"C++\" {}"; |
| 533 | break; |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 534 | } |
| 535 | if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel, |
| 536 | errs())) |
| 537 | HadErrors = 1; |
| 538 | return true; |
| 539 | } |
| 540 | |
| 541 | // Check 'namespace (name) {}' block for #include directives. |
| 542 | bool VisitNamespaceDecl(const NamespaceDecl *D) { |
| 543 | SourceRange BlockRange = D->getSourceRange(); |
| 544 | std::string Label("namespace "); |
| 545 | Label += D->getName(); |
| 546 | Label += " {}"; |
| 547 | if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(), |
| 548 | errs())) |
| 549 | HadErrors = 1; |
| 550 | return true; |
| 551 | } |
| 552 | |
| 553 | // Collect definition entities. |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 554 | bool VisitNamedDecl(NamedDecl *ND) { |
| 555 | // We only care about file-context variables. |
| 556 | if (!ND->getDeclContext()->isFileContext()) |
| 557 | return true; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 558 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 559 | // Skip declarations that tend to be properly multiply-declared. |
| 560 | if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) || |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 561 | isa<NamespaceAliasDecl>(ND) || |
| 562 | isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) || |
John Thompson | 8e01c06 | 2013-08-26 15:17:23 +0000 | [diff] [blame] | 563 | isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) || |
John Thompson | cc2e291 | 2013-09-03 18:44:11 +0000 | [diff] [blame] | 564 | isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) || |
| 565 | isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) || |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 566 | (isa<TagDecl>(ND) && |
| 567 | !cast<TagDecl>(ND)->isThisDeclarationADefinition())) |
| 568 | return true; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 569 | |
John Thompson | 8e01c06 | 2013-08-26 15:17:23 +0000 | [diff] [blame] | 570 | // Skip anonymous declarations. |
| 571 | if (!ND->getDeclName()) |
| 572 | return true; |
| 573 | |
| 574 | // Get the qualified name. |
John Thompson | cc2e291 | 2013-09-03 18:44:11 +0000 | [diff] [blame] | 575 | std::string Name; |
| 576 | llvm::raw_string_ostream OS(Name); |
| 577 | ND->printQualifiedName(OS); |
| 578 | OS.flush(); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 579 | if (Name.empty()) |
| 580 | return true; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 581 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 582 | Location Loc(SM, ND->getLocation()); |
| 583 | if (!Loc) |
| 584 | return true; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 585 | |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 586 | Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 587 | return true; |
| 588 | } |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 589 | |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 590 | private: |
| 591 | SourceManager &SM; |
| 592 | EntityMap &Entities; |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 593 | Preprocessor &PP; |
| 594 | PreprocessorTracker &PPTracker; |
| 595 | int &HadErrors; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 596 | }; |
| 597 | |
| 598 | class CollectEntitiesConsumer : public ASTConsumer { |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 599 | public: |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 600 | CollectEntitiesConsumer(EntityMap &Entities, |
| 601 | PreprocessorTracker &preprocessorTracker, |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 602 | Preprocessor &PP, StringRef InFile, int &HadErrors) |
| 603 | : Entities(Entities), PPTracker(preprocessorTracker), PP(PP), |
| 604 | HadErrors(HadErrors) { |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 605 | PPTracker.handlePreprocessorEntry(PP, InFile); |
| 606 | } |
| 607 | |
| 608 | ~CollectEntitiesConsumer() { PPTracker.handlePreprocessorExit(); } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 609 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 610 | virtual void HandleTranslationUnit(ASTContext &Ctx) { |
| 611 | SourceManager &SM = Ctx.getSourceManager(); |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 612 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 613 | // Collect declared entities. |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 614 | CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors) |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 615 | .TraverseDecl(Ctx.getTranslationUnitDecl()); |
| 616 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 617 | // Collect macro definitions. |
| 618 | for (Preprocessor::macro_iterator M = PP.macro_begin(), |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 619 | MEnd = PP.macro_end(); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 620 | M != MEnd; ++M) { |
| 621 | Location Loc(SM, M->second->getLocation()); |
| 622 | if (!Loc) |
| 623 | continue; |
| 624 | |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 625 | Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 626 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 627 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 628 | // Merge header contents. |
| 629 | Entities.mergeCurHeaderContents(); |
| 630 | } |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 631 | |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 632 | private: |
| 633 | EntityMap &Entities; |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 634 | PreprocessorTracker &PPTracker; |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 635 | Preprocessor &PP; |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 636 | int &HadErrors; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 637 | }; |
| 638 | |
| 639 | class CollectEntitiesAction : public SyntaxOnlyAction { |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 640 | public: |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 641 | CollectEntitiesAction(EntityMap &Entities, |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 642 | PreprocessorTracker &preprocessorTracker, |
| 643 | int &HadErrors) |
| 644 | : Entities(Entities), PPTracker(preprocessorTracker), |
| 645 | HadErrors(HadErrors) {} |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 646 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 647 | protected: |
David Blaikie | 680c4c8 | 2014-08-10 19:56:59 +0000 | [diff] [blame] | 648 | std::unique_ptr<clang::ASTConsumer> |
| 649 | CreateASTConsumer(CompilerInstance &CI, StringRef InFile) override { |
| 650 | return llvm::make_unique<CollectEntitiesConsumer>( |
| 651 | Entities, PPTracker, CI.getPreprocessor(), InFile, HadErrors); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 652 | } |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 653 | |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 654 | private: |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 655 | EntityMap &Entities; |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 656 | PreprocessorTracker &PPTracker; |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 657 | int &HadErrors; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 658 | }; |
| 659 | |
| 660 | class ModularizeFrontendActionFactory : public FrontendActionFactory { |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 661 | public: |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 662 | ModularizeFrontendActionFactory(EntityMap &Entities, |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 663 | PreprocessorTracker &preprocessorTracker, |
| 664 | int &HadErrors) |
| 665 | : Entities(Entities), PPTracker(preprocessorTracker), |
| 666 | HadErrors(HadErrors) {} |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 667 | |
| 668 | virtual CollectEntitiesAction *create() { |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 669 | return new CollectEntitiesAction(Entities, PPTracker, HadErrors); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 670 | } |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 671 | |
John Thompson | 1f67ccb | 2013-03-12 18:51:47 +0000 | [diff] [blame] | 672 | private: |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 673 | EntityMap &Entities; |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 674 | PreprocessorTracker &PPTracker; |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 675 | int &HadErrors; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 676 | }; |
| 677 | |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 678 | int main(int Argc, const char **Argv) { |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 679 | |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 680 | // Save program name for error messages. |
| 681 | Argv0 = Argv[0]; |
| 682 | |
John Thompson | 5d9862f | 2015-02-10 14:45:30 +0000 | [diff] [blame^] | 683 | // Save program arguments for use in module.modulemap comment. |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 684 | CommandLine = sys::path::stem(sys::path::filename(Argv0)); |
| 685 | for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) { |
| 686 | CommandLine.append(" "); |
| 687 | CommandLine.append(Argv[ArgIndex]); |
| 688 | } |
| 689 | |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 690 | // This causes options to be parsed. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 691 | cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n"); |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 692 | |
| 693 | // No go if we have no header list file. |
| 694 | if (ListFileName.size() == 0) { |
| 695 | cl::PrintHelpMessage(); |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 696 | return 1; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 697 | } |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 698 | |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 699 | // Get header file names and dependencies. |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 700 | SmallVector<std::string, 32> Headers; |
John Thompson | 7d0213c | 2013-09-04 20:46:24 +0000 | [diff] [blame] | 701 | DependencyMap Dependencies; |
Rafael Espindola | c7f0d23 | 2014-06-12 22:08:48 +0000 | [diff] [blame] | 702 | if (std::error_code EC = getHeaderFileNames(Headers, Dependencies, |
| 703 | ListFileName, HeaderPrefix)) { |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 704 | errs() << Argv[0] << ": error: Unable to get header list '" << ListFileName |
| 705 | << "': " << EC.message() << '\n'; |
John Thompson | ea6c8db | 2013-03-27 21:23:21 +0000 | [diff] [blame] | 706 | return 1; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 707 | } |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 708 | |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 709 | // If we are in assistant mode, output the module map and quit. |
John Thompson | e744d2b | 2013-12-10 02:26:44 +0000 | [diff] [blame] | 710 | if (ModuleMapPath.length() != 0) { |
John Thompson | 5ab4f11 | 2013-10-15 13:52:33 +0000 | [diff] [blame] | 711 | if (!createModuleMap(ModuleMapPath, Headers, Dependencies, HeaderPrefix, |
| 712 | RootModule)) |
| 713 | return 1; // Failed. |
| 714 | return 0; // Success - Skip checks in assistant mode. |
| 715 | } |
| 716 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 717 | // Create the compilation database. |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 718 | SmallString<256> PathBuf; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 719 | sys::fs::current_path(PathBuf); |
Ahmed Charles | 6a2dc5c | 2014-03-09 09:24:40 +0000 | [diff] [blame] | 720 | std::unique_ptr<CompilationDatabase> Compilations; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 721 | Compilations.reset( |
| 722 | new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments)); |
John Thompson | a2de108 | 2013-03-26 01:17:48 +0000 | [diff] [blame] | 723 | |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 724 | // Create preprocessor tracker, to watch for macro and conditional problems. |
Ahmed Charles | 6a2dc5c | 2014-03-09 09:24:40 +0000 | [diff] [blame] | 725 | std::unique_ptr<PreprocessorTracker> PPTracker(PreprocessorTracker::create()); |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 726 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 727 | // Parse all of the headers, detecting duplicates. |
| 728 | EntityMap Entities; |
| 729 | ClangTool Tool(*Compilations, Headers); |
Alexander Kornienko | d365731 | 2014-12-03 17:53:03 +0000 | [diff] [blame] | 730 | Tool.appendArgumentsAdjuster(getAddDependenciesAdjuster(Dependencies)); |
John Thompson | 7408392 | 2013-09-18 18:19:43 +0000 | [diff] [blame] | 731 | int HadErrors = 0; |
Benjamin Kramer | 6e91424 | 2014-07-24 10:23:33 +0000 | [diff] [blame] | 732 | ModularizeFrontendActionFactory Factory(Entities, *PPTracker, HadErrors); |
| 733 | HadErrors |= Tool.run(&Factory); |
John Thompson | ce601e2 | 2013-03-14 01:41:29 +0000 | [diff] [blame] | 734 | |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 735 | // Create a place to save duplicate entity locations, separate bins per kind. |
| 736 | typedef SmallVector<Location, 8> LocationArray; |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 737 | typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray; |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 738 | EntryBinArray EntryBins; |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 739 | int KindIndex; |
| 740 | for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) { |
| 741 | LocationArray Array; |
| 742 | EntryBins.push_back(Array); |
Michael Gottesman | 4b24921 | 2013-03-28 06:07:15 +0000 | [diff] [blame] | 743 | } |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 744 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 745 | // Check for the same entity being defined in multiple places. |
| 746 | for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end(); |
| 747 | E != EEnd; ++E) { |
Alp Toker | 9a5134e | 2013-12-01 05:08:12 +0000 | [diff] [blame] | 748 | // If only one occurrence, exit early. |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 749 | if (E->second.size() == 1) |
| 750 | continue; |
| 751 | // Clear entity locations. |
| 752 | for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end(); |
| 753 | CI != CE; ++CI) { |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 754 | CI->clear(); |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 755 | } |
| 756 | // Walk the entities of a single name, collecting the locations, |
| 757 | // separated into separate bins. |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 758 | for (unsigned I = 0, N = E->second.size(); I != N; ++I) { |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 759 | EntryBins[E->second[I].Kind].push_back(E->second[I].Loc); |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 760 | } |
| 761 | // Report any duplicate entity definition errors. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 762 | int KindIndex = 0; |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 763 | for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end(); |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 764 | DI != DE; ++DI, ++KindIndex) { |
| 765 | int ECount = DI->size(); |
John Thompson | abe79d9 | 2013-12-04 20:41:30 +0000 | [diff] [blame] | 766 | // If only 1 occurrence of this entity, skip it, as we only report duplicates. |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 767 | if (ECount <= 1) |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 768 | continue; |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 769 | LocationArray::iterator FI = DI->begin(); |
John Thompson | bb0a3b0 | 2013-08-09 13:52:09 +0000 | [diff] [blame] | 770 | StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex); |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 771 | errs() << "error: " << kindName << " '" << E->first() |
| 772 | << "' defined at multiple locations:\n"; |
John Thompson | 52d9886 | 2013-03-28 18:38:43 +0000 | [diff] [blame] | 773 | for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) { |
John Thompson | 4e4d9b3 | 2013-03-28 01:20:19 +0000 | [diff] [blame] | 774 | errs() << " " << FI->File->getName() << ":" << FI->Line << ":" |
| 775 | << FI->Column << "\n"; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 776 | } |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 777 | HadErrors = 1; |
| 778 | } |
| 779 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 780 | |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 781 | // Complain about macro instance in header files that differ based on how |
| 782 | // they are included. |
| 783 | if (PPTracker->reportInconsistentMacros(errs())) |
| 784 | HadErrors = 1; |
| 785 | |
| 786 | // Complain about preprocessor conditional directives in header files that |
| 787 | // differ based on how they are included. |
| 788 | if (PPTracker->reportInconsistentConditionals(errs())) |
| 789 | HadErrors = 1; |
| 790 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 791 | // Complain about any headers that have contents that differ based on how |
| 792 | // they are included. |
John Thompson | ce601e2 | 2013-03-14 01:41:29 +0000 | [diff] [blame] | 793 | // FIXME: Could we provide information about which preprocessor conditionals |
| 794 | // are involved? |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 795 | for (DenseMap<const FileEntry *, HeaderContents>::iterator |
| 796 | H = Entities.HeaderContentMismatches.begin(), |
| 797 | HEnd = Entities.HeaderContentMismatches.end(); |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 798 | H != HEnd; ++H) { |
| 799 | if (H->second.empty()) { |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 800 | errs() << "internal error: phantom header content mismatch\n"; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 801 | continue; |
| 802 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 803 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 804 | HadErrors = 1; |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 805 | errs() << "error: header '" << H->first->getName() |
John Thompson | 94faa4d | 2013-07-26 23:56:42 +0000 | [diff] [blame] | 806 | << "' has different contents depending on how it was included.\n"; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 807 | for (unsigned I = 0, N = H->second.size(); I != N; ++I) { |
John Thompson | 161381e | 2013-06-27 18:52:23 +0000 | [diff] [blame] | 808 | errs() << "note: '" << H->second[I].Name << "' in " |
| 809 | << H->second[I].Loc.File->getName() << " at " |
| 810 | << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column |
| 811 | << " not always provided\n"; |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 812 | } |
| 813 | } |
John Thompson | f5db45b | 2013-03-27 01:02:46 +0000 | [diff] [blame] | 814 | |
John Thompson | 4f8ba65 | 2013-03-12 02:07:30 +0000 | [diff] [blame] | 815 | return HadErrors; |
| 816 | } |