blob: 04611dadde66143eb22ad8fc4feae5b72fe1641e [file] [log] [blame]
Ted Kremenek918fe842010-03-20 21:06:02 +00001//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Ted Kremenek918fe842010-03-20 21:06:02 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file defines analysis_warnings::[Policy,Executor].
10// Together they are used by Sema to issue warnings based on inexpensive
11// static analysis algorithms in libAnalysis.
12//
13//===----------------------------------------------------------------------===//
14
Douglas Gregorc3a6ade2010-08-12 20:07:10 +000015#include "clang/Sema/AnalysisBasedWarnings.h"
John McCall28a0cf72010-08-25 07:42:41 +000016#include "clang/AST/DeclCXX.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000017#include "clang/AST/DeclObjC.h"
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +000018#include "clang/AST/EvaluatedExprVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000019#include "clang/AST/ExprCXX.h"
20#include "clang/AST/ExprObjC.h"
Jordan Rose76831c62012-10-11 16:10:19 +000021#include "clang/AST/ParentMap.h"
Richard Smith84837d52012-05-03 18:27:39 +000022#include "clang/AST/RecursiveASTVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000023#include "clang/AST/StmtCXX.h"
24#include "clang/AST/StmtObjC.h"
25#include "clang/AST/StmtVisitor.h"
26#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
DeLesley Hutchins48a31762013-08-12 21:20:55 +000027#include "clang/Analysis/Analyses/Consumed.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000028#include "clang/Analysis/Analyses/ReachableCode.h"
29#include "clang/Analysis/Analyses/ThreadSafety.h"
30#include "clang/Analysis/Analyses/UninitializedValues.h"
George Karpenkov50657f62017-09-06 21:45:03 +000031#include "clang/Analysis/AnalysisDeclContext.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000032#include "clang/Analysis/CFG.h"
Ted Kremenek3427fac2011-02-23 01:52:04 +000033#include "clang/Analysis/CFGStmtMap.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000034#include "clang/Basic/SourceLocation.h"
35#include "clang/Basic/SourceManager.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000036#include "clang/Lex/Preprocessor.h"
37#include "clang/Sema/ScopeInfo.h"
38#include "clang/Sema/SemaInternal.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000039#include "llvm/ADT/BitVector.h"
Enea Zaffanella2f40be72013-02-15 20:09:55 +000040#include "llvm/ADT/MapVector.h"
Dmitri Gribenko6743e042012-09-29 11:40:46 +000041#include "llvm/ADT/SmallString.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000042#include "llvm/ADT/SmallVector.h"
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +000043#include "llvm/ADT/StringRef.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000044#include "llvm/Support/Casting.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000045#include <algorithm>
Chandler Carruth3a022472012-12-04 09:13:33 +000046#include <deque>
Richard Smith84837d52012-05-03 18:27:39 +000047#include <iterator>
Ted Kremenek918fe842010-03-20 21:06:02 +000048
49using namespace clang;
50
51//===----------------------------------------------------------------------===//
52// Unreachable code analysis.
53//===----------------------------------------------------------------------===//
54
55namespace {
56 class UnreachableCodeHandler : public reachable_code::Callback {
57 Sema &S;
Alex Lorenz569ad732017-01-12 10:48:03 +000058 SourceRange PreviousSilenceableCondVal;
59
Ted Kremenek918fe842010-03-20 21:06:02 +000060 public:
61 UnreachableCodeHandler(Sema &s) : S(s) {}
62
Ted Kremenek1a8641c2014-03-15 01:26:32 +000063 void HandleUnreachable(reachable_code::UnreachableKind UK,
Ted Kremenekec3bbf42014-03-29 00:35:20 +000064 SourceLocation L,
65 SourceRange SilenceableCondVal,
66 SourceRange R1,
Craig Toppere14c0f82014-03-12 04:55:44 +000067 SourceRange R2) override {
Alex Lorenz569ad732017-01-12 10:48:03 +000068 // Avoid reporting multiple unreachable code diagnostics that are
69 // triggered by the same conditional value.
70 if (PreviousSilenceableCondVal.isValid() &&
71 SilenceableCondVal.isValid() &&
72 PreviousSilenceableCondVal == SilenceableCondVal)
73 return;
74 PreviousSilenceableCondVal = SilenceableCondVal;
75
Ted Kremenek1a8641c2014-03-15 01:26:32 +000076 unsigned diag = diag::warn_unreachable;
77 switch (UK) {
78 case reachable_code::UK_Break:
79 diag = diag::warn_unreachable_break;
80 break;
Ted Kremenekf3c93bb2014-03-20 06:07:30 +000081 case reachable_code::UK_Return:
Ted Kremenekad8753c2014-03-15 05:47:06 +000082 diag = diag::warn_unreachable_return;
Ted Kremenek1a8641c2014-03-15 01:26:32 +000083 break;
Ted Kremenek14210372014-03-21 06:02:36 +000084 case reachable_code::UK_Loop_Increment:
85 diag = diag::warn_unreachable_loop_increment;
86 break;
Ted Kremenek1a8641c2014-03-15 01:26:32 +000087 case reachable_code::UK_Other:
88 break;
89 }
90
91 S.Diag(L, diag) << R1 << R2;
Fangrui Song6907ce22018-07-30 19:24:48 +000092
Ted Kremenekec3bbf42014-03-29 00:35:20 +000093 SourceLocation Open = SilenceableCondVal.getBegin();
94 if (Open.isValid()) {
Alp Tokerb6cc5922014-05-03 03:45:55 +000095 SourceLocation Close = SilenceableCondVal.getEnd();
96 Close = S.getLocForEndOfToken(Close);
Ted Kremenekec3bbf42014-03-29 00:35:20 +000097 if (Close.isValid()) {
98 S.Diag(Open, diag::note_unreachable_silence)
99 << FixItHint::CreateInsertion(Open, "/* DISABLES CODE */ (")
100 << FixItHint::CreateInsertion(Close, ")");
101 }
102 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000103 }
104 };
Hans Wennborgdcfba332015-10-06 23:40:43 +0000105} // anonymous namespace
Ted Kremenek918fe842010-03-20 21:06:02 +0000106
107/// CheckUnreachable - Check for unreachable code.
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000108static void CheckUnreachable(Sema &S, AnalysisDeclContext &AC) {
Ted Kremenekc1b28752014-02-25 22:35:37 +0000109 // As a heuristic prune all diagnostics not in the main file. Currently
110 // the majority of warnings in headers are false positives. These
111 // are largely caused by configuration state, e.g. preprocessor
112 // defined code, etc.
113 //
114 // Note that this is also a performance optimization. Analyzing
115 // headers many times can be expensive.
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000116 if (!S.getSourceManager().isInMainFile(AC.getDecl()->getBeginLoc()))
Ted Kremenekc1b28752014-02-25 22:35:37 +0000117 return;
118
Ted Kremenek918fe842010-03-20 21:06:02 +0000119 UnreachableCodeHandler UC(S);
Ted Kremenek2dd810a2014-03-09 08:13:49 +0000120 reachable_code::FindUnreachableCode(AC, S.getPreprocessor(), UC);
Ted Kremenek918fe842010-03-20 21:06:02 +0000121}
122
Benjamin Kramer3a002252015-02-16 16:53:12 +0000123namespace {
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000124/// Warn on logical operator errors in CFGBuilder
Richard Trieuf935b562014-04-05 05:17:01 +0000125class LogicalErrorHandler : public CFGCallback {
126 Sema &S;
127
128public:
129 LogicalErrorHandler(Sema &S) : CFGCallback(), S(S) {}
130
131 static bool HasMacroID(const Expr *E) {
132 if (E->getExprLoc().isMacroID())
133 return true;
134
135 // Recurse to children.
Benjamin Kramer642f1732015-07-02 21:03:14 +0000136 for (const Stmt *SubStmt : E->children())
137 if (const Expr *SubExpr = dyn_cast_or_null<Expr>(SubStmt))
138 if (HasMacroID(SubExpr))
139 return true;
Richard Trieuf935b562014-04-05 05:17:01 +0000140
141 return false;
142 }
143
Alexander Kornienko34eb2072015-04-11 02:00:23 +0000144 void compareAlwaysTrue(const BinaryOperator *B, bool isAlwaysTrue) override {
Richard Trieuf935b562014-04-05 05:17:01 +0000145 if (HasMacroID(B))
146 return;
147
148 SourceRange DiagRange = B->getSourceRange();
149 S.Diag(B->getExprLoc(), diag::warn_tautological_overlap_comparison)
150 << DiagRange << isAlwaysTrue;
151 }
Jordan Rose7afd71e2014-05-20 17:31:11 +0000152
Alexander Kornienko34eb2072015-04-11 02:00:23 +0000153 void compareBitwiseEquality(const BinaryOperator *B,
154 bool isAlwaysTrue) override {
Jordan Rose7afd71e2014-05-20 17:31:11 +0000155 if (HasMacroID(B))
156 return;
157
158 SourceRange DiagRange = B->getSourceRange();
159 S.Diag(B->getExprLoc(), diag::warn_comparison_bitwise_always)
160 << DiagRange << isAlwaysTrue;
161 }
Richard Trieu8b0d14a2019-10-19 00:57:23 +0000162
163 void compareBitwiseOr(const BinaryOperator *B) override {
164 if (HasMacroID(B))
165 return;
166
167 SourceRange DiagRange = B->getSourceRange();
168 S.Diag(B->getExprLoc(), diag::warn_comparison_bitwise_or) << DiagRange;
169 }
170
171 static bool hasActiveDiagnostics(DiagnosticsEngine &Diags,
172 SourceLocation Loc) {
173 return !Diags.isIgnored(diag::warn_tautological_overlap_comparison, Loc) ||
174 !Diags.isIgnored(diag::warn_comparison_bitwise_or, Loc);
175 }
Richard Trieuf935b562014-04-05 05:17:01 +0000176};
Hans Wennborgdcfba332015-10-06 23:40:43 +0000177} // anonymous namespace
Richard Trieuf935b562014-04-05 05:17:01 +0000178
Ted Kremenek918fe842010-03-20 21:06:02 +0000179//===----------------------------------------------------------------------===//
Richard Trieu2f024f42013-12-21 02:33:43 +0000180// Check for infinite self-recursion in functions
181//===----------------------------------------------------------------------===//
182
Richard Trieu6995de92015-08-21 03:43:09 +0000183// Returns true if the function is called anywhere within the CFGBlock.
184// For member functions, the additional condition of being call from the
185// this pointer is required.
Duncan P. N. Exon Smithf0eafc72015-07-23 20:11:47 +0000186static bool hasRecursiveCallInPath(const FunctionDecl *FD, CFGBlock &Block) {
Richard Trieu6995de92015-08-21 03:43:09 +0000187 // Process all the Stmt's in this block to find any calls to FD.
Duncan P. N. Exon Smithf0eafc72015-07-23 20:11:47 +0000188 for (const auto &B : Block) {
189 if (B.getKind() != CFGElement::Statement)
190 continue;
191
192 const CallExpr *CE = dyn_cast<CallExpr>(B.getAs<CFGStmt>()->getStmt());
193 if (!CE || !CE->getCalleeDecl() ||
194 CE->getCalleeDecl()->getCanonicalDecl() != FD)
195 continue;
196
197 // Skip function calls which are qualified with a templated class.
198 if (const DeclRefExpr *DRE =
199 dyn_cast<DeclRefExpr>(CE->getCallee()->IgnoreParenImpCasts())) {
200 if (NestedNameSpecifier *NNS = DRE->getQualifier()) {
201 if (NNS->getKind() == NestedNameSpecifier::TypeSpec &&
202 isa<TemplateSpecializationType>(NNS->getAsType())) {
203 continue;
204 }
205 }
206 }
207
208 const CXXMemberCallExpr *MCE = dyn_cast<CXXMemberCallExpr>(CE);
209 if (!MCE || isa<CXXThisExpr>(MCE->getImplicitObjectArgument()) ||
210 !MCE->getMethodDecl()->isVirtual())
211 return true;
212 }
213 return false;
214}
215
Robert Widmann97608442018-03-22 03:16:23 +0000216// Returns true if every path from the entry block passes through a call to FD.
Richard Trieu6995de92015-08-21 03:43:09 +0000217static bool checkForRecursiveFunctionCall(const FunctionDecl *FD, CFG *cfg) {
Robert Widmann97608442018-03-22 03:16:23 +0000218 llvm::SmallPtrSet<CFGBlock *, 16> Visited;
219 llvm::SmallVector<CFGBlock *, 16> WorkList;
220 // Keep track of whether we found at least one recursive path.
221 bool foundRecursion = false;
Richard Trieu6995de92015-08-21 03:43:09 +0000222
223 const unsigned ExitID = cfg->getExit().getBlockID();
224
Robert Widmann97608442018-03-22 03:16:23 +0000225 // Seed the work list with the entry block.
226 WorkList.push_back(&cfg->getEntry());
Richard Trieu6995de92015-08-21 03:43:09 +0000227
Robert Widmann97608442018-03-22 03:16:23 +0000228 while (!WorkList.empty()) {
229 CFGBlock *Block = WorkList.pop_back_val();
Richard Trieu2f024f42013-12-21 02:33:43 +0000230
Robert Widmann97608442018-03-22 03:16:23 +0000231 for (auto I = Block->succ_begin(), E = Block->succ_end(); I != E; ++I) {
232 if (CFGBlock *SuccBlock = *I) {
233 if (!Visited.insert(SuccBlock).second)
234 continue;
Richard Trieu2f024f42013-12-21 02:33:43 +0000235
Robert Widmann97608442018-03-22 03:16:23 +0000236 // Found a path to the exit node without a recursive call.
237 if (ExitID == SuccBlock->getBlockID())
238 return false;
Duncan P. N. Exon Smithdccc30a2015-07-23 20:15:50 +0000239
Robert Widmann97608442018-03-22 03:16:23 +0000240 // If the successor block contains a recursive call, end analysis there.
241 if (hasRecursiveCallInPath(FD, *SuccBlock)) {
242 foundRecursion = true;
243 continue;
Richard Trieu6995de92015-08-21 03:43:09 +0000244 }
Richard Trieu6995de92015-08-21 03:43:09 +0000245
Robert Widmann97608442018-03-22 03:16:23 +0000246 WorkList.push_back(SuccBlock);
247 }
248 }
249 }
250 return foundRecursion;
Richard Trieu2f024f42013-12-21 02:33:43 +0000251}
252
253static void checkRecursiveFunction(Sema &S, const FunctionDecl *FD,
Richard Trieu6995de92015-08-21 03:43:09 +0000254 const Stmt *Body, AnalysisDeclContext &AC) {
Richard Trieu2f024f42013-12-21 02:33:43 +0000255 FD = FD->getCanonicalDecl();
256
257 // Only run on non-templated functions and non-templated members of
258 // templated classes.
259 if (FD->getTemplatedKind() != FunctionDecl::TK_NonTemplate &&
260 FD->getTemplatedKind() != FunctionDecl::TK_MemberSpecialization)
261 return;
262
263 CFG *cfg = AC.getCFG();
Craig Topperc3ec1492014-05-26 06:22:03 +0000264 if (!cfg) return;
Richard Trieu2f024f42013-12-21 02:33:43 +0000265
Robert Widmann04306d622019-02-13 22:22:23 +0000266 // If the exit block is unreachable, skip processing the function.
267 if (cfg->getExit().pred_empty())
268 return;
269
Richard Trieu6995de92015-08-21 03:43:09 +0000270 // Emit diagnostic if a recursive function call is detected for all paths.
271 if (checkForRecursiveFunctionCall(FD, cfg))
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000272 S.Diag(Body->getBeginLoc(), diag::warn_infinite_recursive_function);
Richard Trieu2f024f42013-12-21 02:33:43 +0000273}
274
275//===----------------------------------------------------------------------===//
Erich Keane89fe9c22017-06-23 20:22:19 +0000276// Check for throw in a non-throwing function.
277//===----------------------------------------------------------------------===//
Erich Keane89fe9c22017-06-23 20:22:19 +0000278
Richard Smith08482102018-02-20 02:32:30 +0000279/// Determine whether an exception thrown by E, unwinding from ThrowBlock,
280/// can reach ExitBlock.
281static bool throwEscapes(Sema &S, const CXXThrowExpr *E, CFGBlock &ThrowBlock,
282 CFG *Body) {
Erich Keane89fe9c22017-06-23 20:22:19 +0000283 SmallVector<CFGBlock *, 16> Stack;
Richard Smith08482102018-02-20 02:32:30 +0000284 llvm::BitVector Queued(Body->getNumBlockIDs());
Erich Keane89fe9c22017-06-23 20:22:19 +0000285
Richard Smith08482102018-02-20 02:32:30 +0000286 Stack.push_back(&ThrowBlock);
287 Queued[ThrowBlock.getBlockID()] = true;
288
289 while (!Stack.empty()) {
290 CFGBlock &UnwindBlock = *Stack.back();
291 Stack.pop_back();
292
293 for (auto &Succ : UnwindBlock.succs()) {
294 if (!Succ.isReachable() || Queued[Succ->getBlockID()])
Erich Keane89fe9c22017-06-23 20:22:19 +0000295 continue;
296
Richard Smith08482102018-02-20 02:32:30 +0000297 if (Succ->getBlockID() == Body->getExit().getBlockID())
298 return true;
Erich Keane89fe9c22017-06-23 20:22:19 +0000299
Richard Smith08482102018-02-20 02:32:30 +0000300 if (auto *Catch =
301 dyn_cast_or_null<CXXCatchStmt>(Succ->getLabel())) {
302 QualType Caught = Catch->getCaughtType();
303 if (Caught.isNull() || // catch (...) catches everything
304 !E->getSubExpr() || // throw; is considered cuaght by any handler
305 S.handlerCanCatch(Caught, E->getSubExpr()->getType()))
306 // Exception doesn't escape via this path.
307 break;
308 } else {
309 Stack.push_back(Succ);
310 Queued[Succ->getBlockID()] = true;
Erich Keane89fe9c22017-06-23 20:22:19 +0000311 }
Richard Smith08482102018-02-20 02:32:30 +0000312 }
Erich Keane89fe9c22017-06-23 20:22:19 +0000313 }
Richard Smith08482102018-02-20 02:32:30 +0000314
315 return false;
316}
317
318static void visitReachableThrows(
319 CFG *BodyCFG,
320 llvm::function_ref<void(const CXXThrowExpr *, CFGBlock &)> Visit) {
321 llvm::BitVector Reachable(BodyCFG->getNumBlockIDs());
322 clang::reachable_code::ScanReachableFromBlock(&BodyCFG->getEntry(), Reachable);
323 for (CFGBlock *B : *BodyCFG) {
324 if (!Reachable[B->getBlockID()])
325 continue;
326 for (CFGElement &E : *B) {
327 Optional<CFGStmt> S = E.getAs<CFGStmt>();
328 if (!S)
329 continue;
330 if (auto *Throw = dyn_cast<CXXThrowExpr>(S->getStmt()))
331 Visit(Throw, *B);
332 }
333 }
Erich Keane89fe9c22017-06-23 20:22:19 +0000334}
335
336static void EmitDiagForCXXThrowInNonThrowingFunc(Sema &S, SourceLocation OpLoc,
337 const FunctionDecl *FD) {
Erich Keane7538b352017-07-05 16:43:45 +0000338 if (!S.getSourceManager().isInSystemHeader(OpLoc) &&
339 FD->getTypeSourceInfo()) {
Erich Keane89fe9c22017-06-23 20:22:19 +0000340 S.Diag(OpLoc, diag::warn_throw_in_noexcept_func) << FD;
341 if (S.getLangOpts().CPlusPlus11 &&
342 (isa<CXXDestructorDecl>(FD) ||
343 FD->getDeclName().getCXXOverloadedOperator() == OO_Delete ||
Erich Keane7538b352017-07-05 16:43:45 +0000344 FD->getDeclName().getCXXOverloadedOperator() == OO_Array_Delete)) {
345 if (const auto *Ty = FD->getTypeSourceInfo()->getType()->
346 getAs<FunctionProtoType>())
347 S.Diag(FD->getLocation(), diag::note_throw_in_dtor)
348 << !isa<CXXDestructorDecl>(FD) << !Ty->hasExceptionSpec()
349 << FD->getExceptionSpecSourceRange();
Fangrui Song6907ce22018-07-30 19:24:48 +0000350 } else
Erich Keane7538b352017-07-05 16:43:45 +0000351 S.Diag(FD->getLocation(), diag::note_throw_in_function)
352 << FD->getExceptionSpecSourceRange();
Erich Keane89fe9c22017-06-23 20:22:19 +0000353 }
354}
355
356static void checkThrowInNonThrowingFunc(Sema &S, const FunctionDecl *FD,
357 AnalysisDeclContext &AC) {
358 CFG *BodyCFG = AC.getCFG();
359 if (!BodyCFG)
360 return;
361 if (BodyCFG->getExit().pred_empty())
362 return;
Richard Smith08482102018-02-20 02:32:30 +0000363 visitReachableThrows(BodyCFG, [&](const CXXThrowExpr *Throw, CFGBlock &Block) {
364 if (throwEscapes(S, Throw, Block, BodyCFG))
365 EmitDiagForCXXThrowInNonThrowingFunc(S, Throw->getThrowLoc(), FD);
366 });
Erich Keane89fe9c22017-06-23 20:22:19 +0000367}
368
369static bool isNoexcept(const FunctionDecl *FD) {
370 const auto *FPT = FD->getType()->castAs<FunctionProtoType>();
Richard Smitheaf11ad2018-05-03 03:58:32 +0000371 if (FPT->isNothrow() || FD->hasAttr<NoThrowAttr>())
Erich Keane89fe9c22017-06-23 20:22:19 +0000372 return true;
373 return false;
374}
375
376//===----------------------------------------------------------------------===//
Ted Kremenek918fe842010-03-20 21:06:02 +0000377// Check for missing return value.
378//===----------------------------------------------------------------------===//
379
John McCall5c6ec8c2010-05-16 09:34:11 +0000380enum ControlFlowKind {
381 UnknownFallThrough,
382 NeverFallThrough,
383 MaybeFallThrough,
384 AlwaysFallThrough,
385 NeverFallThroughOrReturn
386};
Ted Kremenek918fe842010-03-20 21:06:02 +0000387
388/// CheckFallThrough - Check that we don't fall off the end of a
389/// Statement that should return a value.
390///
Sylvestre Ledru33b5baf2012-09-27 10:16:10 +0000391/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
392/// MaybeFallThrough iff we might or might not fall off the end,
393/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
394/// return. We assume NeverFallThrough iff we never fall off the end of the
Ted Kremenek918fe842010-03-20 21:06:02 +0000395/// statement but we may return. We assume that functions not marked noreturn
396/// will return.
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000397static ControlFlowKind CheckFallThrough(AnalysisDeclContext &AC) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000398 CFG *cfg = AC.getCFG();
Craig Topperc3ec1492014-05-26 06:22:03 +0000399 if (!cfg) return UnknownFallThrough;
Ted Kremenek918fe842010-03-20 21:06:02 +0000400
401 // The CFG leaves in dead things, and we don't want the dead code paths to
402 // confuse us, so we mark all live things first.
Ted Kremenek918fe842010-03-20 21:06:02 +0000403 llvm::BitVector live(cfg->getNumBlockIDs());
Ted Kremenekbd913712011-08-23 23:05:11 +0000404 unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
Ted Kremenek918fe842010-03-20 21:06:02 +0000405 live);
406
407 bool AddEHEdges = AC.getAddEHEdges();
408 if (!AddEHEdges && count != cfg->getNumBlockIDs())
409 // When there are things remaining dead, and we didn't add EH edges
410 // from CallExprs to the catch clauses, we have to go back and
411 // mark them as live.
Aaron Ballmane5195222014-05-15 20:50:47 +0000412 for (const auto *B : *cfg) {
413 if (!live[B->getBlockID()]) {
414 if (B->pred_begin() == B->pred_end()) {
Artem Dergachev4e530322019-05-24 01:34:22 +0000415 const Stmt *Term = B->getTerminatorStmt();
416 if (Term && isa<CXXTryStmt>(Term))
Ted Kremenek918fe842010-03-20 21:06:02 +0000417 // When not adding EH edges from calls, catch clauses
418 // can otherwise seem dead. Avoid noting them as dead.
Aaron Ballmane5195222014-05-15 20:50:47 +0000419 count += reachable_code::ScanReachableFromBlock(B, live);
Ted Kremenek918fe842010-03-20 21:06:02 +0000420 continue;
421 }
422 }
423 }
424
425 // Now we know what is live, we check the live precessors of the exit block
426 // and look for fall through paths, being careful to ignore normal returns,
427 // and exceptional paths.
428 bool HasLiveReturn = false;
429 bool HasFakeEdge = false;
430 bool HasPlainEdge = false;
431 bool HasAbnormalEdge = false;
Ted Kremenek50205742010-09-09 00:06:07 +0000432
433 // Ignore default cases that aren't likely to be reachable because all
434 // enums in a switch(X) have explicit case statements.
435 CFGBlock::FilterOptions FO;
436 FO.IgnoreDefaultsWithCoveredEnums = 1;
437
Fangrui Song99337e22018-07-20 08:19:20 +0000438 for (CFGBlock::filtered_pred_iterator I =
439 cfg->getExit().filtered_pred_start_end(FO);
440 I.hasMore(); ++I) {
441 const CFGBlock &B = **I;
Ted Kremenek918fe842010-03-20 21:06:02 +0000442 if (!live[B.getBlockID()])
443 continue;
Ted Kremenek5d068492011-01-26 04:49:52 +0000444
Chandler Carruth03faf782011-09-13 09:53:58 +0000445 // Skip blocks which contain an element marked as no-return. They don't
446 // represent actually viable edges into the exit block, so mark them as
447 // abnormal.
448 if (B.hasNoReturnElement()) {
449 HasAbnormalEdge = true;
450 continue;
451 }
452
Ted Kremenek5d068492011-01-26 04:49:52 +0000453 // Destructors can appear after the 'return' in the CFG. This is
454 // normal. We need to look pass the destructors for the return
455 // statement (if it exists).
456 CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
Ted Kremeneke06a55c2011-03-02 20:32:29 +0000457
Chandler Carruth03faf782011-09-13 09:53:58 +0000458 for ( ; ri != re ; ++ri)
David Blaikie2a01f5d2013-02-21 20:58:29 +0000459 if (ri->getAs<CFGStmt>())
Ted Kremenek5d068492011-01-26 04:49:52 +0000460 break;
Chandler Carruth03faf782011-09-13 09:53:58 +0000461
Ted Kremenek5d068492011-01-26 04:49:52 +0000462 // No more CFGElements in the block?
463 if (ri == re) {
Artem Dergachev4e530322019-05-24 01:34:22 +0000464 const Stmt *Term = B.getTerminatorStmt();
465 if (Term && isa<CXXTryStmt>(Term)) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000466 HasAbnormalEdge = true;
467 continue;
468 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000469 // A labeled empty statement, or the entry block...
470 HasPlainEdge = true;
471 continue;
472 }
Ted Kremenekebe62602011-01-25 22:50:47 +0000473
David Blaikie2a01f5d2013-02-21 20:58:29 +0000474 CFGStmt CS = ri->castAs<CFGStmt>();
Ted Kremenekadfb4452011-08-23 23:05:04 +0000475 const Stmt *S = CS.getStmt();
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000476 if (isa<ReturnStmt>(S) || isa<CoreturnStmt>(S)) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000477 HasLiveReturn = true;
478 continue;
479 }
480 if (isa<ObjCAtThrowStmt>(S)) {
481 HasFakeEdge = true;
482 continue;
483 }
484 if (isa<CXXThrowExpr>(S)) {
485 HasFakeEdge = true;
486 continue;
487 }
Chad Rosier32503022012-06-11 20:47:18 +0000488 if (isa<MSAsmStmt>(S)) {
489 // TODO: Verify this is correct.
490 HasFakeEdge = true;
491 HasLiveReturn = true;
492 continue;
493 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000494 if (isa<CXXTryStmt>(S)) {
495 HasAbnormalEdge = true;
496 continue;
497 }
Chandler Carruth03faf782011-09-13 09:53:58 +0000498 if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
499 == B.succ_end()) {
500 HasAbnormalEdge = true;
501 continue;
Ted Kremenek918fe842010-03-20 21:06:02 +0000502 }
Chandler Carruth03faf782011-09-13 09:53:58 +0000503
504 HasPlainEdge = true;
Ted Kremenek918fe842010-03-20 21:06:02 +0000505 }
506 if (!HasPlainEdge) {
507 if (HasLiveReturn)
508 return NeverFallThrough;
509 return NeverFallThroughOrReturn;
510 }
511 if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
512 return MaybeFallThrough;
513 // This says AlwaysFallThrough for calls to functions that are not marked
514 // noreturn, that don't return. If people would like this warning to be more
515 // accurate, such functions should be marked as noreturn.
516 return AlwaysFallThrough;
517}
518
Dan Gohman28ade552010-07-26 21:25:24 +0000519namespace {
520
Ted Kremenek918fe842010-03-20 21:06:02 +0000521struct CheckFallThroughDiagnostics {
522 unsigned diag_MaybeFallThrough_HasNoReturn;
523 unsigned diag_MaybeFallThrough_ReturnsNonVoid;
524 unsigned diag_AlwaysFallThrough_HasNoReturn;
525 unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
526 unsigned diag_NeverFallThroughOrReturn;
Eric Fiselier709d1b32016-10-27 07:30:31 +0000527 enum { Function, Block, Lambda, Coroutine } funMode;
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000528 SourceLocation FuncLoc;
Ted Kremenek0b405322010-03-23 00:13:23 +0000529
Douglas Gregor24f27692010-04-16 23:28:44 +0000530 static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000531 CheckFallThroughDiagnostics D;
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000532 D.FuncLoc = Func->getLocation();
Ted Kremenek918fe842010-03-20 21:06:02 +0000533 D.diag_MaybeFallThrough_HasNoReturn =
534 diag::warn_falloff_noreturn_function;
535 D.diag_MaybeFallThrough_ReturnsNonVoid =
536 diag::warn_maybe_falloff_nonvoid_function;
537 D.diag_AlwaysFallThrough_HasNoReturn =
538 diag::warn_falloff_noreturn_function;
539 D.diag_AlwaysFallThrough_ReturnsNonVoid =
540 diag::warn_falloff_nonvoid_function;
Douglas Gregor24f27692010-04-16 23:28:44 +0000541
542 // Don't suggest that virtual functions be marked "noreturn", since they
543 // might be overridden by non-noreturn functions.
544 bool isVirtualMethod = false;
545 if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
546 isVirtualMethod = Method->isVirtual();
Fangrui Song6907ce22018-07-30 19:24:48 +0000547
Douglas Gregor0de57202011-10-10 18:15:57 +0000548 // Don't suggest that template instantiations be marked "noreturn"
549 bool isTemplateInstantiation = false;
Ted Kremenek85825ae2011-12-01 00:59:17 +0000550 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(Func))
551 isTemplateInstantiation = Function->isTemplateInstantiation();
Fangrui Song6907ce22018-07-30 19:24:48 +0000552
Douglas Gregor0de57202011-10-10 18:15:57 +0000553 if (!isVirtualMethod && !isTemplateInstantiation)
Douglas Gregor24f27692010-04-16 23:28:44 +0000554 D.diag_NeverFallThroughOrReturn =
555 diag::warn_suggest_noreturn_function;
556 else
557 D.diag_NeverFallThroughOrReturn = 0;
Fangrui Song6907ce22018-07-30 19:24:48 +0000558
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000559 D.funMode = Function;
Ted Kremenek918fe842010-03-20 21:06:02 +0000560 return D;
561 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000562
Eric Fiselier709d1b32016-10-27 07:30:31 +0000563 static CheckFallThroughDiagnostics MakeForCoroutine(const Decl *Func) {
564 CheckFallThroughDiagnostics D;
565 D.FuncLoc = Func->getLocation();
566 D.diag_MaybeFallThrough_HasNoReturn = 0;
567 D.diag_MaybeFallThrough_ReturnsNonVoid =
568 diag::warn_maybe_falloff_nonvoid_coroutine;
569 D.diag_AlwaysFallThrough_HasNoReturn = 0;
570 D.diag_AlwaysFallThrough_ReturnsNonVoid =
571 diag::warn_falloff_nonvoid_coroutine;
572 D.funMode = Coroutine;
573 return D;
574 }
575
Ted Kremenek918fe842010-03-20 21:06:02 +0000576 static CheckFallThroughDiagnostics MakeForBlock() {
577 CheckFallThroughDiagnostics D;
578 D.diag_MaybeFallThrough_HasNoReturn =
579 diag::err_noreturn_block_has_return_expr;
580 D.diag_MaybeFallThrough_ReturnsNonVoid =
581 diag::err_maybe_falloff_nonvoid_block;
582 D.diag_AlwaysFallThrough_HasNoReturn =
583 diag::err_noreturn_block_has_return_expr;
584 D.diag_AlwaysFallThrough_ReturnsNonVoid =
585 diag::err_falloff_nonvoid_block;
Fariborz Jahanian5ce22792014-04-03 23:06:35 +0000586 D.diag_NeverFallThroughOrReturn = 0;
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000587 D.funMode = Block;
588 return D;
589 }
590
591 static CheckFallThroughDiagnostics MakeForLambda() {
592 CheckFallThroughDiagnostics D;
593 D.diag_MaybeFallThrough_HasNoReturn =
594 diag::err_noreturn_lambda_has_return_expr;
595 D.diag_MaybeFallThrough_ReturnsNonVoid =
596 diag::warn_maybe_falloff_nonvoid_lambda;
597 D.diag_AlwaysFallThrough_HasNoReturn =
598 diag::err_noreturn_lambda_has_return_expr;
599 D.diag_AlwaysFallThrough_ReturnsNonVoid =
600 diag::warn_falloff_nonvoid_lambda;
601 D.diag_NeverFallThroughOrReturn = 0;
602 D.funMode = Lambda;
Ted Kremenek918fe842010-03-20 21:06:02 +0000603 return D;
604 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000605
David Blaikie9c902b52011-09-25 23:23:43 +0000606 bool checkDiagnostics(DiagnosticsEngine &D, bool ReturnsVoid,
Ted Kremenek918fe842010-03-20 21:06:02 +0000607 bool HasNoReturn) const {
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000608 if (funMode == Function) {
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000609 return (ReturnsVoid ||
Alp Tokerd4a3f0e2014-06-15 23:30:39 +0000610 D.isIgnored(diag::warn_maybe_falloff_nonvoid_function,
611 FuncLoc)) &&
612 (!HasNoReturn ||
613 D.isIgnored(diag::warn_noreturn_function_has_return_expr,
614 FuncLoc)) &&
615 (!ReturnsVoid ||
616 D.isIgnored(diag::warn_suggest_noreturn_block, FuncLoc));
Ted Kremenek918fe842010-03-20 21:06:02 +0000617 }
Eric Fiselier709d1b32016-10-27 07:30:31 +0000618 if (funMode == Coroutine) {
619 return (ReturnsVoid ||
620 D.isIgnored(diag::warn_maybe_falloff_nonvoid_function, FuncLoc) ||
621 D.isIgnored(diag::warn_maybe_falloff_nonvoid_coroutine,
622 FuncLoc)) &&
623 (!HasNoReturn);
624 }
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000625 // For blocks / lambdas.
Fariborz Jahanian5ce22792014-04-03 23:06:35 +0000626 return ReturnsVoid && !HasNoReturn;
Ted Kremenek918fe842010-03-20 21:06:02 +0000627 }
628};
629
Hans Wennborgdcfba332015-10-06 23:40:43 +0000630} // anonymous namespace
Dan Gohman28ade552010-07-26 21:25:24 +0000631
Reid Kleckner87a31802018-03-12 21:43:02 +0000632/// CheckFallThroughForBody - Check that we don't fall off the end of a
Ted Kremenek918fe842010-03-20 21:06:02 +0000633/// function that should return a value. Check that we don't fall off the end
634/// of a noreturn function. We assume that functions and blocks not marked
635/// noreturn will return.
636static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
Richard Smith2fdd95c2019-05-31 00:45:09 +0000637 QualType BlockType,
Reid Kleckner87a31802018-03-12 21:43:02 +0000638 const CheckFallThroughDiagnostics &CD,
639 AnalysisDeclContext &AC,
640 sema::FunctionScopeInfo *FSI) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000641
642 bool ReturnsVoid = false;
643 bool HasNoReturn = false;
Reid Kleckner87a31802018-03-12 21:43:02 +0000644 bool IsCoroutine = FSI->isCoroutine();
Ted Kremenek918fe842010-03-20 21:06:02 +0000645
Eric Fiselier709d1b32016-10-27 07:30:31 +0000646 if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
647 if (const auto *CBody = dyn_cast<CoroutineBodyStmt>(Body))
648 ReturnsVoid = CBody->getFallthroughHandler() != nullptr;
649 else
650 ReturnsVoid = FD->getReturnType()->isVoidType();
Richard Smith10876ef2013-01-17 01:30:42 +0000651 HasNoReturn = FD->isNoReturn();
Ted Kremenek918fe842010-03-20 21:06:02 +0000652 }
Eric Fiselier709d1b32016-10-27 07:30:31 +0000653 else if (const auto *MD = dyn_cast<ObjCMethodDecl>(D)) {
Alp Toker314cc812014-01-25 16:55:45 +0000654 ReturnsVoid = MD->getReturnType()->isVoidType();
Ted Kremenek918fe842010-03-20 21:06:02 +0000655 HasNoReturn = MD->hasAttr<NoReturnAttr>();
656 }
657 else if (isa<BlockDecl>(D)) {
Ted Kremenek0b405322010-03-23 00:13:23 +0000658 if (const FunctionType *FT =
Richard Smith2fdd95c2019-05-31 00:45:09 +0000659 BlockType->getPointeeType()->getAs<FunctionType>()) {
Alp Toker314cc812014-01-25 16:55:45 +0000660 if (FT->getReturnType()->isVoidType())
Ted Kremenek918fe842010-03-20 21:06:02 +0000661 ReturnsVoid = true;
662 if (FT->getNoReturnAttr())
663 HasNoReturn = true;
664 }
665 }
666
David Blaikie9c902b52011-09-25 23:23:43 +0000667 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenek918fe842010-03-20 21:06:02 +0000668
669 // Short circuit for compilation speed.
670 if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
671 return;
Stephen Kelly1c301dc2018-08-09 21:09:38 +0000672 SourceLocation LBrace = Body->getBeginLoc(), RBrace = Body->getEndLoc();
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000673 auto EmitDiag = [&](SourceLocation Loc, unsigned DiagID) {
674 if (IsCoroutine)
Reid Kleckner87a31802018-03-12 21:43:02 +0000675 S.Diag(Loc, DiagID) << FSI->CoroutinePromise->getType();
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000676 else
677 S.Diag(Loc, DiagID);
678 };
Erich Keane3efe0022018-07-20 14:13:28 +0000679
680 // cpu_dispatch functions permit empty function bodies for ICC compatibility.
681 if (D->getAsFunction() && D->getAsFunction()->isCPUDispatchMultiVersion())
682 return;
683
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000684 // Either in a function body compound statement, or a function-try-block.
685 switch (CheckFallThrough(AC)) {
686 case UnknownFallThrough:
687 break;
John McCall5c6ec8c2010-05-16 09:34:11 +0000688
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000689 case MaybeFallThrough:
690 if (HasNoReturn)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000691 EmitDiag(RBrace, CD.diag_MaybeFallThrough_HasNoReturn);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000692 else if (!ReturnsVoid)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000693 EmitDiag(RBrace, CD.diag_MaybeFallThrough_ReturnsNonVoid);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000694 break;
695 case AlwaysFallThrough:
696 if (HasNoReturn)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000697 EmitDiag(RBrace, CD.diag_AlwaysFallThrough_HasNoReturn);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000698 else if (!ReturnsVoid)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000699 EmitDiag(RBrace, CD.diag_AlwaysFallThrough_ReturnsNonVoid);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000700 break;
701 case NeverFallThroughOrReturn:
702 if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn) {
703 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
704 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn) << 0 << FD;
705 } else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
706 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn) << 1 << MD;
707 } else {
708 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn);
Chandler Carruthc841b6e2011-08-31 09:01:53 +0000709 }
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000710 }
711 break;
712 case NeverFallThrough:
713 break;
Ted Kremenek918fe842010-03-20 21:06:02 +0000714 }
715}
716
717//===----------------------------------------------------------------------===//
Ted Kremenekb749a6d2011-01-15 02:58:47 +0000718// -Wuninitialized
719//===----------------------------------------------------------------------===//
720
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000721namespace {
Chandler Carruth4e021822011-04-05 06:48:00 +0000722/// ContainsReference - A visitor class to search for references to
723/// a particular declaration (the needle) within any evaluated component of an
724/// expression (recursively).
Scott Douglass503fc392015-06-10 13:53:15 +0000725class ContainsReference : public ConstEvaluatedExprVisitor<ContainsReference> {
Chandler Carruth4e021822011-04-05 06:48:00 +0000726 bool FoundReference;
727 const DeclRefExpr *Needle;
728
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000729public:
Scott Douglass503fc392015-06-10 13:53:15 +0000730 typedef ConstEvaluatedExprVisitor<ContainsReference> Inherited;
Chandler Carruth4e021822011-04-05 06:48:00 +0000731
Scott Douglass503fc392015-06-10 13:53:15 +0000732 ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
733 : Inherited(Context), FoundReference(false), Needle(Needle) {}
734
735 void VisitExpr(const Expr *E) {
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000736 // Stop evaluating if we already have a reference.
Chandler Carruth4e021822011-04-05 06:48:00 +0000737 if (FoundReference)
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000738 return;
Chandler Carruth4e021822011-04-05 06:48:00 +0000739
Scott Douglass503fc392015-06-10 13:53:15 +0000740 Inherited::VisitExpr(E);
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000741 }
Chandler Carruth4e021822011-04-05 06:48:00 +0000742
Scott Douglass503fc392015-06-10 13:53:15 +0000743 void VisitDeclRefExpr(const DeclRefExpr *E) {
Chandler Carruth4e021822011-04-05 06:48:00 +0000744 if (E == Needle)
745 FoundReference = true;
746 else
Scott Douglass503fc392015-06-10 13:53:15 +0000747 Inherited::VisitDeclRefExpr(E);
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000748 }
Chandler Carruth4e021822011-04-05 06:48:00 +0000749
750 bool doesContainReference() const { return FoundReference; }
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000751};
Hans Wennborgdcfba332015-10-06 23:40:43 +0000752} // anonymous namespace
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000753
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000754static bool SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000755 QualType VariableTy = VD->getType().getCanonicalType();
756 if (VariableTy->isBlockPointerType() &&
757 !VD->hasAttr<BlocksAttr>()) {
Nico Weber3c68ee92014-07-08 23:46:20 +0000758 S.Diag(VD->getLocation(), diag::note_block_var_fixit_add_initialization)
759 << VD->getDeclName()
760 << FixItHint::CreateInsertion(VD->getLocation(), "__block ");
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000761 return true;
762 }
Richard Smithf7ec86a2013-09-20 00:27:40 +0000763
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000764 // Don't issue a fixit if there is already an initializer.
765 if (VD->getInit())
766 return false;
Richard Trieu2cdcf822012-05-03 01:09:59 +0000767
768 // Don't suggest a fixit inside macros.
Stephen Kelly1c301dc2018-08-09 21:09:38 +0000769 if (VD->getEndLoc().isMacroID())
Richard Trieu2cdcf822012-05-03 01:09:59 +0000770 return false;
771
Stephen Kelly1c301dc2018-08-09 21:09:38 +0000772 SourceLocation Loc = S.getLocForEndOfToken(VD->getEndLoc());
Richard Smithf7ec86a2013-09-20 00:27:40 +0000773
774 // Suggest possible initialization (if any).
775 std::string Init = S.getFixItZeroInitializerForType(VariableTy, Loc);
776 if (Init.empty())
777 return false;
778
Richard Smith8d06f422012-01-12 23:53:29 +0000779 S.Diag(Loc, diag::note_var_fixit_add_initialization) << VD->getDeclName()
780 << FixItHint::CreateInsertion(Loc, Init);
781 return true;
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000782}
783
Richard Smith1bb8edb82012-05-26 06:20:46 +0000784/// Create a fixit to remove an if-like statement, on the assumption that its
785/// condition is CondVal.
786static void CreateIfFixit(Sema &S, const Stmt *If, const Stmt *Then,
787 const Stmt *Else, bool CondVal,
788 FixItHint &Fixit1, FixItHint &Fixit2) {
789 if (CondVal) {
790 // If condition is always true, remove all but the 'then'.
791 Fixit1 = FixItHint::CreateRemoval(
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000792 CharSourceRange::getCharRange(If->getBeginLoc(), Then->getBeginLoc()));
Richard Smith1bb8edb82012-05-26 06:20:46 +0000793 if (Else) {
Stephen Kelly1c301dc2018-08-09 21:09:38 +0000794 SourceLocation ElseKwLoc = S.getLocForEndOfToken(Then->getEndLoc());
795 Fixit2 =
796 FixItHint::CreateRemoval(SourceRange(ElseKwLoc, Else->getEndLoc()));
Richard Smith1bb8edb82012-05-26 06:20:46 +0000797 }
798 } else {
799 // If condition is always false, remove all but the 'else'.
800 if (Else)
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000801 Fixit1 = FixItHint::CreateRemoval(CharSourceRange::getCharRange(
802 If->getBeginLoc(), Else->getBeginLoc()));
Richard Smith1bb8edb82012-05-26 06:20:46 +0000803 else
804 Fixit1 = FixItHint::CreateRemoval(If->getSourceRange());
805 }
806}
807
808/// DiagUninitUse -- Helper function to produce a diagnostic for an
809/// uninitialized use of a variable.
810static void DiagUninitUse(Sema &S, const VarDecl *VD, const UninitUse &Use,
811 bool IsCapturedByBlock) {
812 bool Diagnosed = false;
813
Richard Smithba8071e2013-09-12 18:49:10 +0000814 switch (Use.getKind()) {
815 case UninitUse::Always:
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000816 S.Diag(Use.getUser()->getBeginLoc(), diag::warn_uninit_var)
Richard Smithba8071e2013-09-12 18:49:10 +0000817 << VD->getDeclName() << IsCapturedByBlock
818 << Use.getUser()->getSourceRange();
819 return;
820
821 case UninitUse::AfterDecl:
822 case UninitUse::AfterCall:
823 S.Diag(VD->getLocation(), diag::warn_sometimes_uninit_var)
824 << VD->getDeclName() << IsCapturedByBlock
825 << (Use.getKind() == UninitUse::AfterDecl ? 4 : 5)
826 << const_cast<DeclContext*>(VD->getLexicalDeclContext())
827 << VD->getSourceRange();
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000828 S.Diag(Use.getUser()->getBeginLoc(), diag::note_uninit_var_use)
829 << IsCapturedByBlock << Use.getUser()->getSourceRange();
Richard Smithba8071e2013-09-12 18:49:10 +0000830 return;
831
832 case UninitUse::Maybe:
833 case UninitUse::Sometimes:
834 // Carry on to report sometimes-uninitialized branches, if possible,
835 // or a 'may be used uninitialized' diagnostic otherwise.
836 break;
837 }
838
Richard Smith1bb8edb82012-05-26 06:20:46 +0000839 // Diagnose each branch which leads to a sometimes-uninitialized use.
Richard Smith4323bf82012-05-25 02:17:09 +0000840 for (UninitUse::branch_iterator I = Use.branch_begin(), E = Use.branch_end();
841 I != E; ++I) {
Richard Smith1bb8edb82012-05-26 06:20:46 +0000842 assert(Use.getKind() == UninitUse::Sometimes);
843
844 const Expr *User = Use.getUser();
Richard Smith4323bf82012-05-25 02:17:09 +0000845 const Stmt *Term = I->Terminator;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000846
847 // Information used when building the diagnostic.
Richard Smith4323bf82012-05-25 02:17:09 +0000848 unsigned DiagKind;
David Blaikie1d202a62012-10-08 01:11:04 +0000849 StringRef Str;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000850 SourceRange Range;
851
Stefanus Du Toitb3318502013-03-01 21:41:22 +0000852 // FixIts to suppress the diagnostic by removing the dead condition.
Richard Smith1bb8edb82012-05-26 06:20:46 +0000853 // For all binary terminators, branch 0 is taken if the condition is true,
854 // and branch 1 is taken if the condition is false.
855 int RemoveDiagKind = -1;
856 const char *FixitStr =
857 S.getLangOpts().CPlusPlus ? (I->Output ? "true" : "false")
858 : (I->Output ? "1" : "0");
859 FixItHint Fixit1, Fixit2;
860
Richard Smithba8071e2013-09-12 18:49:10 +0000861 switch (Term ? Term->getStmtClass() : Stmt::DeclStmtClass) {
Richard Smith4323bf82012-05-25 02:17:09 +0000862 default:
Richard Smith1bb8edb82012-05-26 06:20:46 +0000863 // Don't know how to report this. Just fall back to 'may be used
Richard Smithba8071e2013-09-12 18:49:10 +0000864 // uninitialized'. FIXME: Can this happen?
Richard Smith4323bf82012-05-25 02:17:09 +0000865 continue;
866
867 // "condition is true / condition is false".
Richard Smith1bb8edb82012-05-26 06:20:46 +0000868 case Stmt::IfStmtClass: {
869 const IfStmt *IS = cast<IfStmt>(Term);
Richard Smith4323bf82012-05-25 02:17:09 +0000870 DiagKind = 0;
871 Str = "if";
Richard Smith1bb8edb82012-05-26 06:20:46 +0000872 Range = IS->getCond()->getSourceRange();
873 RemoveDiagKind = 0;
874 CreateIfFixit(S, IS, IS->getThen(), IS->getElse(),
875 I->Output, Fixit1, Fixit2);
Richard Smith4323bf82012-05-25 02:17:09 +0000876 break;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000877 }
878 case Stmt::ConditionalOperatorClass: {
879 const ConditionalOperator *CO = cast<ConditionalOperator>(Term);
Richard Smith4323bf82012-05-25 02:17:09 +0000880 DiagKind = 0;
881 Str = "?:";
Richard Smith1bb8edb82012-05-26 06:20:46 +0000882 Range = CO->getCond()->getSourceRange();
883 RemoveDiagKind = 0;
884 CreateIfFixit(S, CO, CO->getTrueExpr(), CO->getFalseExpr(),
885 I->Output, Fixit1, Fixit2);
Richard Smith4323bf82012-05-25 02:17:09 +0000886 break;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000887 }
Richard Smith4323bf82012-05-25 02:17:09 +0000888 case Stmt::BinaryOperatorClass: {
889 const BinaryOperator *BO = cast<BinaryOperator>(Term);
890 if (!BO->isLogicalOp())
891 continue;
892 DiagKind = 0;
893 Str = BO->getOpcodeStr();
894 Range = BO->getLHS()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000895 RemoveDiagKind = 0;
896 if ((BO->getOpcode() == BO_LAnd && I->Output) ||
897 (BO->getOpcode() == BO_LOr && !I->Output))
898 // true && y -> y, false || y -> y.
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000899 Fixit1 = FixItHint::CreateRemoval(
900 SourceRange(BO->getBeginLoc(), BO->getOperatorLoc()));
Richard Smith1bb8edb82012-05-26 06:20:46 +0000901 else
902 // false && y -> false, true || y -> true.
903 Fixit1 = FixItHint::CreateReplacement(BO->getSourceRange(), FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000904 break;
905 }
906
907 // "loop is entered / loop is exited".
908 case Stmt::WhileStmtClass:
909 DiagKind = 1;
910 Str = "while";
911 Range = cast<WhileStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000912 RemoveDiagKind = 1;
913 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000914 break;
915 case Stmt::ForStmtClass:
916 DiagKind = 1;
917 Str = "for";
918 Range = cast<ForStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000919 RemoveDiagKind = 1;
920 if (I->Output)
921 Fixit1 = FixItHint::CreateRemoval(Range);
922 else
923 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000924 break;
Richard Smithba8071e2013-09-12 18:49:10 +0000925 case Stmt::CXXForRangeStmtClass:
926 if (I->Output == 1) {
927 // The use occurs if a range-based for loop's body never executes.
928 // That may be impossible, and there's no syntactic fix for this,
929 // so treat it as a 'may be uninitialized' case.
930 continue;
931 }
932 DiagKind = 1;
933 Str = "for";
934 Range = cast<CXXForRangeStmt>(Term)->getRangeInit()->getSourceRange();
935 break;
Richard Smith4323bf82012-05-25 02:17:09 +0000936
937 // "condition is true / loop is exited".
938 case Stmt::DoStmtClass:
939 DiagKind = 2;
940 Str = "do";
941 Range = cast<DoStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000942 RemoveDiagKind = 1;
943 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000944 break;
945
946 // "switch case is taken".
947 case Stmt::CaseStmtClass:
948 DiagKind = 3;
949 Str = "case";
950 Range = cast<CaseStmt>(Term)->getLHS()->getSourceRange();
951 break;
952 case Stmt::DefaultStmtClass:
953 DiagKind = 3;
954 Str = "default";
955 Range = cast<DefaultStmt>(Term)->getDefaultLoc();
956 break;
957 }
958
Richard Smith1bb8edb82012-05-26 06:20:46 +0000959 S.Diag(Range.getBegin(), diag::warn_sometimes_uninit_var)
960 << VD->getDeclName() << IsCapturedByBlock << DiagKind
961 << Str << I->Output << Range;
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000962 S.Diag(User->getBeginLoc(), diag::note_uninit_var_use)
963 << IsCapturedByBlock << User->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000964 if (RemoveDiagKind != -1)
965 S.Diag(Fixit1.RemoveRange.getBegin(), diag::note_uninit_fixit_remove_cond)
966 << RemoveDiagKind << Str << I->Output << Fixit1 << Fixit2;
967
968 Diagnosed = true;
Richard Smith4323bf82012-05-25 02:17:09 +0000969 }
Richard Smith1bb8edb82012-05-26 06:20:46 +0000970
971 if (!Diagnosed)
Stephen Kellyf2ceec42018-08-09 21:08:08 +0000972 S.Diag(Use.getUser()->getBeginLoc(), diag::warn_maybe_uninit_var)
Richard Smith1bb8edb82012-05-26 06:20:46 +0000973 << VD->getDeclName() << IsCapturedByBlock
974 << Use.getUser()->getSourceRange();
Richard Smith4323bf82012-05-25 02:17:09 +0000975}
976
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000977/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
978/// uninitialized variable. This manages the different forms of diagnostic
979/// emitted for particular types of uses. Returns true if the use was diagnosed
Richard Smith4323bf82012-05-25 02:17:09 +0000980/// as a warning. If a particular use is one we omit warnings for, returns
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000981/// false.
982static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
Richard Smith4323bf82012-05-25 02:17:09 +0000983 const UninitUse &Use,
Ted Kremenek596fa162011-10-13 18:50:06 +0000984 bool alwaysReportSelfInit = false) {
Richard Smith4323bf82012-05-25 02:17:09 +0000985 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Use.getUser())) {
Richard Trieu43a2fc72012-05-09 21:08:22 +0000986 // Inspect the initializer of the variable declaration which is
987 // being referenced prior to its initialization. We emit
988 // specialized diagnostics for self-initialization, and we
989 // specifically avoid warning about self references which take the
990 // form of:
991 //
992 // int x = x;
993 //
994 // This is used to indicate to GCC that 'x' is intentionally left
995 // uninitialized. Proven code paths which access 'x' in
996 // an uninitialized state after this will still warn.
997 if (const Expr *Initializer = VD->getInit()) {
998 if (!alwaysReportSelfInit && DRE == Initializer->IgnoreParenImpCasts())
999 return false;
Chandler Carruth895904da2011-04-05 18:18:05 +00001000
Richard Trieu43a2fc72012-05-09 21:08:22 +00001001 ContainsReference CR(S.Context, DRE);
Scott Douglass503fc392015-06-10 13:53:15 +00001002 CR.Visit(Initializer);
Richard Trieu43a2fc72012-05-09 21:08:22 +00001003 if (CR.doesContainReference()) {
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001004 S.Diag(DRE->getBeginLoc(), diag::warn_uninit_self_reference_in_init)
1005 << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
Richard Trieu43a2fc72012-05-09 21:08:22 +00001006 return true;
Chandler Carruth895904da2011-04-05 18:18:05 +00001007 }
Chandler Carruth895904da2011-04-05 18:18:05 +00001008 }
Richard Trieu43a2fc72012-05-09 21:08:22 +00001009
Richard Smith1bb8edb82012-05-26 06:20:46 +00001010 DiagUninitUse(S, VD, Use, false);
Chandler Carruth895904da2011-04-05 18:18:05 +00001011 } else {
Richard Smith4323bf82012-05-25 02:17:09 +00001012 const BlockExpr *BE = cast<BlockExpr>(Use.getUser());
Richard Smith1bb8edb82012-05-26 06:20:46 +00001013 if (VD->getType()->isBlockPointerType() && !VD->hasAttr<BlocksAttr>())
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001014 S.Diag(BE->getBeginLoc(),
Richard Smith1bb8edb82012-05-26 06:20:46 +00001015 diag::warn_uninit_byref_blockvar_captured_by_block)
Akira Hatanaka53796d92019-04-23 23:52:02 +00001016 << VD->getDeclName()
1017 << VD->getType().getQualifiers().hasObjCLifetime();
Richard Smith1bb8edb82012-05-26 06:20:46 +00001018 else
1019 DiagUninitUse(S, VD, Use, true);
Chandler Carruth895904da2011-04-05 18:18:05 +00001020 }
1021
1022 // Report where the variable was declared when the use wasn't within
David Blaikiee5f9a9e2011-09-10 05:35:08 +00001023 // the initializer of that declaration & we didn't already suggest
1024 // an initialization fixit.
Richard Trieu43a2fc72012-05-09 21:08:22 +00001025 if (!SuggestInitializationFixit(S, VD))
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001026 S.Diag(VD->getBeginLoc(), diag::note_var_declared_here)
1027 << VD->getDeclName();
Chandler Carruth895904da2011-04-05 18:18:05 +00001028
Chandler Carruthdd8f0d02011-04-05 18:27:05 +00001029 return true;
Chandler Carruth7a037202011-04-05 18:18:08 +00001030}
1031
Richard Smith84837d52012-05-03 18:27:39 +00001032namespace {
1033 class FallthroughMapper : public RecursiveASTVisitor<FallthroughMapper> {
1034 public:
1035 FallthroughMapper(Sema &S)
1036 : FoundSwitchStatements(false),
1037 S(S) {
1038 }
1039
1040 bool foundSwitchStatements() const { return FoundSwitchStatements; }
1041
1042 void markFallthroughVisited(const AttributedStmt *Stmt) {
1043 bool Found = FallthroughStmts.erase(Stmt);
1044 assert(Found);
Kaelyn Uhrain29a8eeb2012-05-03 19:46:38 +00001045 (void)Found;
Richard Smith84837d52012-05-03 18:27:39 +00001046 }
1047
1048 typedef llvm::SmallPtrSet<const AttributedStmt*, 8> AttrStmts;
1049
1050 const AttrStmts &getFallthroughStmts() const {
1051 return FallthroughStmts;
1052 }
1053
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001054 void fillReachableBlocks(CFG *Cfg) {
1055 assert(ReachableBlocks.empty() && "ReachableBlocks already filled");
1056 std::deque<const CFGBlock *> BlockQueue;
1057
1058 ReachableBlocks.insert(&Cfg->getEntry());
1059 BlockQueue.push_back(&Cfg->getEntry());
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001060 // Mark all case blocks reachable to avoid problems with switching on
1061 // constants, covered enums, etc.
1062 // These blocks can contain fall-through annotations, and we don't want to
1063 // issue a warn_fallthrough_attr_unreachable for them.
Aaron Ballmane5195222014-05-15 20:50:47 +00001064 for (const auto *B : *Cfg) {
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001065 const Stmt *L = B->getLabel();
David Blaikie82e95a32014-11-19 07:49:47 +00001066 if (L && isa<SwitchCase>(L) && ReachableBlocks.insert(B).second)
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001067 BlockQueue.push_back(B);
1068 }
1069
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001070 while (!BlockQueue.empty()) {
1071 const CFGBlock *P = BlockQueue.front();
1072 BlockQueue.pop_front();
1073 for (CFGBlock::const_succ_iterator I = P->succ_begin(),
1074 E = P->succ_end();
1075 I != E; ++I) {
David Blaikie82e95a32014-11-19 07:49:47 +00001076 if (*I && ReachableBlocks.insert(*I).second)
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001077 BlockQueue.push_back(*I);
1078 }
1079 }
1080 }
1081
Richard Smith7532d372017-03-22 01:49:19 +00001082 bool checkFallThroughIntoBlock(const CFGBlock &B, int &AnnotatedCnt,
1083 bool IsTemplateInstantiation) {
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001084 assert(!ReachableBlocks.empty() && "ReachableBlocks empty");
1085
Richard Smith84837d52012-05-03 18:27:39 +00001086 int UnannotatedCnt = 0;
1087 AnnotatedCnt = 0;
1088
Aaron Ballmane5195222014-05-15 20:50:47 +00001089 std::deque<const CFGBlock*> BlockQueue(B.pred_begin(), B.pred_end());
Richard Smith84837d52012-05-03 18:27:39 +00001090 while (!BlockQueue.empty()) {
1091 const CFGBlock *P = BlockQueue.front();
1092 BlockQueue.pop_front();
Nick Lewyckycdf11082014-02-27 02:43:25 +00001093 if (!P) continue;
Richard Smith84837d52012-05-03 18:27:39 +00001094
Artem Dergachev4e530322019-05-24 01:34:22 +00001095 const Stmt *Term = P->getTerminatorStmt();
Richard Smith84837d52012-05-03 18:27:39 +00001096 if (Term && isa<SwitchStmt>(Term))
1097 continue; // Switch statement, good.
1098
1099 const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(P->getLabel());
1100 if (SW && SW->getSubStmt() == B.getLabel() && P->begin() == P->end())
1101 continue; // Previous case label has no statements, good.
1102
Alexander Kornienko09f15f32013-01-25 20:44:56 +00001103 const LabelStmt *L = dyn_cast_or_null<LabelStmt>(P->getLabel());
1104 if (L && L->getSubStmt() == B.getLabel() && P->begin() == P->end())
1105 continue; // Case label is preceded with a normal label, good.
1106
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001107 if (!ReachableBlocks.count(P)) {
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001108 for (CFGBlock::const_reverse_iterator ElemIt = P->rbegin(),
1109 ElemEnd = P->rend();
1110 ElemIt != ElemEnd; ++ElemIt) {
David Blaikie00be69a2013-02-23 00:29:34 +00001111 if (Optional<CFGStmt> CS = ElemIt->getAs<CFGStmt>()) {
1112 if (const AttributedStmt *AS = asFallThroughAttr(CS->getStmt())) {
Richard Smith7532d372017-03-22 01:49:19 +00001113 // Don't issue a warning for an unreachable fallthrough
1114 // attribute in template instantiations as it may not be
1115 // unreachable in all instantiations of the template.
1116 if (!IsTemplateInstantiation)
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001117 S.Diag(AS->getBeginLoc(),
Richard Smith7532d372017-03-22 01:49:19 +00001118 diag::warn_fallthrough_attr_unreachable);
Richard Smith84837d52012-05-03 18:27:39 +00001119 markFallthroughVisited(AS);
1120 ++AnnotatedCnt;
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001121 break;
Richard Smith84837d52012-05-03 18:27:39 +00001122 }
1123 // Don't care about other unreachable statements.
1124 }
1125 }
1126 // If there are no unreachable statements, this may be a special
1127 // case in CFG:
1128 // case X: {
1129 // A a; // A has a destructor.
1130 // break;
1131 // }
1132 // // <<<< This place is represented by a 'hanging' CFG block.
1133 // case Y:
1134 continue;
1135 }
1136
1137 const Stmt *LastStmt = getLastStmt(*P);
1138 if (const AttributedStmt *AS = asFallThroughAttr(LastStmt)) {
1139 markFallthroughVisited(AS);
1140 ++AnnotatedCnt;
1141 continue; // Fallthrough annotation, good.
1142 }
1143
1144 if (!LastStmt) { // This block contains no executable statements.
1145 // Traverse its predecessors.
1146 std::copy(P->pred_begin(), P->pred_end(),
1147 std::back_inserter(BlockQueue));
1148 continue;
1149 }
1150
1151 ++UnannotatedCnt;
1152 }
1153 return !!UnannotatedCnt;
1154 }
1155
1156 // RecursiveASTVisitor setup.
1157 bool shouldWalkTypesOfTypeLocs() const { return false; }
1158
1159 bool VisitAttributedStmt(AttributedStmt *S) {
1160 if (asFallThroughAttr(S))
1161 FallthroughStmts.insert(S);
1162 return true;
1163 }
1164
1165 bool VisitSwitchStmt(SwitchStmt *S) {
1166 FoundSwitchStatements = true;
1167 return true;
1168 }
1169
Alexander Kornienkoa9c809f2013-04-02 15:20:32 +00001170 // We don't want to traverse local type declarations. We analyze their
1171 // methods separately.
1172 bool TraverseDecl(Decl *D) { return true; }
1173
Alexander Kornienkobf911642014-06-24 15:28:21 +00001174 // We analyze lambda bodies separately. Skip them here.
Sam McCalle60151c2019-01-14 10:31:42 +00001175 bool TraverseLambdaExpr(LambdaExpr *LE) {
1176 // Traverse the captures, but not the body.
Mark de Wever3ec61282019-12-17 21:54:32 +01001177 for (const auto C : zip(LE->captures(), LE->capture_inits()))
Sam McCalle60151c2019-01-14 10:31:42 +00001178 TraverseLambdaCapture(LE, &std::get<0>(C), std::get<1>(C));
1179 return true;
1180 }
Alexander Kornienkobf911642014-06-24 15:28:21 +00001181
Richard Smith84837d52012-05-03 18:27:39 +00001182 private:
1183
1184 static const AttributedStmt *asFallThroughAttr(const Stmt *S) {
1185 if (const AttributedStmt *AS = dyn_cast_or_null<AttributedStmt>(S)) {
1186 if (hasSpecificAttr<FallThroughAttr>(AS->getAttrs()))
1187 return AS;
1188 }
Craig Topperc3ec1492014-05-26 06:22:03 +00001189 return nullptr;
Richard Smith84837d52012-05-03 18:27:39 +00001190 }
1191
1192 static const Stmt *getLastStmt(const CFGBlock &B) {
Artem Dergachev4e530322019-05-24 01:34:22 +00001193 if (const Stmt *Term = B.getTerminatorStmt())
Richard Smith84837d52012-05-03 18:27:39 +00001194 return Term;
1195 for (CFGBlock::const_reverse_iterator ElemIt = B.rbegin(),
1196 ElemEnd = B.rend();
1197 ElemIt != ElemEnd; ++ElemIt) {
David Blaikie00be69a2013-02-23 00:29:34 +00001198 if (Optional<CFGStmt> CS = ElemIt->getAs<CFGStmt>())
1199 return CS->getStmt();
Richard Smith84837d52012-05-03 18:27:39 +00001200 }
1201 // Workaround to detect a statement thrown out by CFGBuilder:
1202 // case X: {} case Y:
1203 // case X: ; case Y:
1204 if (const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(B.getLabel()))
1205 if (!isa<SwitchCase>(SW->getSubStmt()))
1206 return SW->getSubStmt();
1207
Craig Topperc3ec1492014-05-26 06:22:03 +00001208 return nullptr;
Richard Smith84837d52012-05-03 18:27:39 +00001209 }
1210
1211 bool FoundSwitchStatements;
1212 AttrStmts FallthroughStmts;
1213 Sema &S;
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001214 llvm::SmallPtrSet<const CFGBlock *, 16> ReachableBlocks;
Richard Smith84837d52012-05-03 18:27:39 +00001215 };
Hans Wennborgdcfba332015-10-06 23:40:43 +00001216} // anonymous namespace
Richard Smith84837d52012-05-03 18:27:39 +00001217
Richard Smith4f902c72016-03-08 00:32:55 +00001218static StringRef getFallthroughAttrSpelling(Preprocessor &PP,
1219 SourceLocation Loc) {
1220 TokenValue FallthroughTokens[] = {
1221 tok::l_square, tok::l_square,
1222 PP.getIdentifierInfo("fallthrough"),
1223 tok::r_square, tok::r_square
1224 };
1225
1226 TokenValue ClangFallthroughTokens[] = {
1227 tok::l_square, tok::l_square, PP.getIdentifierInfo("clang"),
1228 tok::coloncolon, PP.getIdentifierInfo("fallthrough"),
1229 tok::r_square, tok::r_square
1230 };
1231
Nathan Huckleberry1e0affb2019-08-20 17:16:49 +00001232 bool PreferClangAttr = !PP.getLangOpts().CPlusPlus17 && !PP.getLangOpts().C2x;
Richard Smith4f902c72016-03-08 00:32:55 +00001233
1234 StringRef MacroName;
1235 if (PreferClangAttr)
1236 MacroName = PP.getLastMacroWithSpelling(Loc, ClangFallthroughTokens);
1237 if (MacroName.empty())
1238 MacroName = PP.getLastMacroWithSpelling(Loc, FallthroughTokens);
1239 if (MacroName.empty() && !PreferClangAttr)
1240 MacroName = PP.getLastMacroWithSpelling(Loc, ClangFallthroughTokens);
Nathan Huckleberry1e0affb2019-08-20 17:16:49 +00001241 if (MacroName.empty()) {
1242 if (!PreferClangAttr)
1243 MacroName = "[[fallthrough]]";
1244 else if (PP.getLangOpts().CPlusPlus)
1245 MacroName = "[[clang::fallthrough]]";
1246 else
1247 MacroName = "__attribute__((fallthrough))";
1248 }
Richard Smith4f902c72016-03-08 00:32:55 +00001249 return MacroName;
1250}
1251
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001252static void DiagnoseSwitchLabelsFallthrough(Sema &S, AnalysisDeclContext &AC,
Alexis Hunt2178f142012-06-15 21:22:05 +00001253 bool PerFunction) {
Richard Smith84837d52012-05-03 18:27:39 +00001254 FallthroughMapper FM(S);
1255 FM.TraverseStmt(AC.getBody());
1256
1257 if (!FM.foundSwitchStatements())
1258 return;
1259
Alexis Hunt2178f142012-06-15 21:22:05 +00001260 if (PerFunction && FM.getFallthroughStmts().empty())
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001261 return;
1262
Richard Smith84837d52012-05-03 18:27:39 +00001263 CFG *Cfg = AC.getCFG();
1264
1265 if (!Cfg)
1266 return;
1267
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001268 FM.fillReachableBlocks(Cfg);
Richard Smith84837d52012-05-03 18:27:39 +00001269
Pete Cooper57d3f142015-07-30 17:22:52 +00001270 for (const CFGBlock *B : llvm::reverse(*Cfg)) {
Alexander Kornienko55488792013-01-25 15:49:34 +00001271 const Stmt *Label = B->getLabel();
Richard Smith84837d52012-05-03 18:27:39 +00001272
1273 if (!Label || !isa<SwitchCase>(Label))
1274 continue;
1275
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001276 int AnnotatedCnt;
1277
Richard Smith7532d372017-03-22 01:49:19 +00001278 bool IsTemplateInstantiation = false;
1279 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(AC.getDecl()))
1280 IsTemplateInstantiation = Function->isTemplateInstantiation();
1281 if (!FM.checkFallThroughIntoBlock(*B, AnnotatedCnt,
1282 IsTemplateInstantiation))
Richard Smith84837d52012-05-03 18:27:39 +00001283 continue;
1284
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001285 S.Diag(Label->getBeginLoc(),
1286 PerFunction ? diag::warn_unannotated_fallthrough_per_function
1287 : diag::warn_unannotated_fallthrough);
Richard Smith84837d52012-05-03 18:27:39 +00001288
1289 if (!AnnotatedCnt) {
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001290 SourceLocation L = Label->getBeginLoc();
Richard Smith84837d52012-05-03 18:27:39 +00001291 if (L.isMacroID())
1292 continue;
Nathan Huckleberry1e0affb2019-08-20 17:16:49 +00001293
1294 const Stmt *Term = B->getTerminatorStmt();
1295 // Skip empty cases.
1296 while (B->empty() && !Term && B->succ_size() == 1) {
1297 B = *B->succ_begin();
1298 Term = B->getTerminatorStmt();
Richard Smith84837d52012-05-03 18:27:39 +00001299 }
Nathan Huckleberry1e0affb2019-08-20 17:16:49 +00001300 if (!(B->empty() && Term && isa<BreakStmt>(Term))) {
1301 Preprocessor &PP = S.getPreprocessor();
1302 StringRef AnnotationSpelling = getFallthroughAttrSpelling(PP, L);
1303 SmallString<64> TextToInsert(AnnotationSpelling);
1304 TextToInsert += "; ";
1305 S.Diag(L, diag::note_insert_fallthrough_fixit)
1306 << AnnotationSpelling
1307 << FixItHint::CreateInsertion(L, TextToInsert);
1308 }
1309 S.Diag(L, diag::note_insert_break_fixit)
1310 << FixItHint::CreateInsertion(L, "break; ");
Richard Smith84837d52012-05-03 18:27:39 +00001311 }
1312 }
1313
Aaron Ballmane5195222014-05-15 20:50:47 +00001314 for (const auto *F : FM.getFallthroughStmts())
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001315 S.Diag(F->getBeginLoc(), diag::err_fallthrough_attr_invalid_placement);
Richard Smith84837d52012-05-03 18:27:39 +00001316}
1317
Jordan Rose25c0ea82012-10-29 17:46:47 +00001318static bool isInLoop(const ASTContext &Ctx, const ParentMap &PM,
1319 const Stmt *S) {
Jordan Rose76831c62012-10-11 16:10:19 +00001320 assert(S);
1321
1322 do {
1323 switch (S->getStmtClass()) {
Jordan Rose76831c62012-10-11 16:10:19 +00001324 case Stmt::ForStmtClass:
1325 case Stmt::WhileStmtClass:
1326 case Stmt::CXXForRangeStmtClass:
1327 case Stmt::ObjCForCollectionStmtClass:
1328 return true;
Jordan Rose25c0ea82012-10-29 17:46:47 +00001329 case Stmt::DoStmtClass: {
Fangrui Song407659a2018-11-30 23:41:18 +00001330 Expr::EvalResult Result;
1331 if (!cast<DoStmt>(S)->getCond()->EvaluateAsInt(Result, Ctx))
Jordan Rose25c0ea82012-10-29 17:46:47 +00001332 return true;
Fangrui Song407659a2018-11-30 23:41:18 +00001333 return Result.Val.getInt().getBoolValue();
Jordan Rose25c0ea82012-10-29 17:46:47 +00001334 }
Jordan Rose76831c62012-10-11 16:10:19 +00001335 default:
1336 break;
1337 }
1338 } while ((S = PM.getParent(S)));
1339
1340 return false;
1341}
1342
Jordan Rosed3934582012-09-28 22:21:30 +00001343static void diagnoseRepeatedUseOfWeak(Sema &S,
1344 const sema::FunctionScopeInfo *CurFn,
Jordan Rose76831c62012-10-11 16:10:19 +00001345 const Decl *D,
1346 const ParentMap &PM) {
Jordan Rosed3934582012-09-28 22:21:30 +00001347 typedef sema::FunctionScopeInfo::WeakObjectProfileTy WeakObjectProfileTy;
1348 typedef sema::FunctionScopeInfo::WeakObjectUseMap WeakObjectUseMap;
1349 typedef sema::FunctionScopeInfo::WeakUseVector WeakUseVector;
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001350 typedef std::pair<const Stmt *, WeakObjectUseMap::const_iterator>
1351 StmtUsesPair;
Jordan Rosed3934582012-09-28 22:21:30 +00001352
Jordan Rose25c0ea82012-10-29 17:46:47 +00001353 ASTContext &Ctx = S.getASTContext();
1354
Jordan Rosed3934582012-09-28 22:21:30 +00001355 const WeakObjectUseMap &WeakMap = CurFn->getWeakObjectUses();
1356
1357 // Extract all weak objects that are referenced more than once.
1358 SmallVector<StmtUsesPair, 8> UsesByStmt;
1359 for (WeakObjectUseMap::const_iterator I = WeakMap.begin(), E = WeakMap.end();
1360 I != E; ++I) {
1361 const WeakUseVector &Uses = I->second;
Jordan Rosed3934582012-09-28 22:21:30 +00001362
1363 // Find the first read of the weak object.
1364 WeakUseVector::const_iterator UI = Uses.begin(), UE = Uses.end();
1365 for ( ; UI != UE; ++UI) {
1366 if (UI->isUnsafe())
1367 break;
1368 }
1369
1370 // If there were only writes to this object, don't warn.
1371 if (UI == UE)
1372 continue;
1373
Jordan Rose76831c62012-10-11 16:10:19 +00001374 // If there was only one read, followed by any number of writes, and the
Jordan Rose25c0ea82012-10-29 17:46:47 +00001375 // read is not within a loop, don't warn. Additionally, don't warn in a
1376 // loop if the base object is a local variable -- local variables are often
1377 // changed in loops.
Jordan Rose76831c62012-10-11 16:10:19 +00001378 if (UI == Uses.begin()) {
1379 WeakUseVector::const_iterator UI2 = UI;
1380 for (++UI2; UI2 != UE; ++UI2)
1381 if (UI2->isUnsafe())
1382 break;
1383
Jordan Rose25c0ea82012-10-29 17:46:47 +00001384 if (UI2 == UE) {
1385 if (!isInLoop(Ctx, PM, UI->getUseExpr()))
Jordan Rose76831c62012-10-11 16:10:19 +00001386 continue;
Jordan Rose25c0ea82012-10-29 17:46:47 +00001387
1388 const WeakObjectProfileTy &Profile = I->first;
1389 if (!Profile.isExactProfile())
1390 continue;
1391
1392 const NamedDecl *Base = Profile.getBase();
1393 if (!Base)
1394 Base = Profile.getProperty();
1395 assert(Base && "A profile always has a base or property.");
1396
1397 if (const VarDecl *BaseVar = dyn_cast<VarDecl>(Base))
1398 if (BaseVar->hasLocalStorage() && !isa<ParmVarDecl>(Base))
1399 continue;
1400 }
Jordan Rose76831c62012-10-11 16:10:19 +00001401 }
1402
Jordan Rosed3934582012-09-28 22:21:30 +00001403 UsesByStmt.push_back(StmtUsesPair(UI->getUseExpr(), I));
1404 }
1405
1406 if (UsesByStmt.empty())
1407 return;
1408
1409 // Sort by first use so that we emit the warnings in a deterministic order.
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001410 SourceManager &SM = S.getSourceManager();
Fangrui Song55fab262018-09-26 22:16:28 +00001411 llvm::sort(UsesByStmt,
Mandeep Singh Grangc205d8c2018-03-27 16:50:00 +00001412 [&SM](const StmtUsesPair &LHS, const StmtUsesPair &RHS) {
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001413 return SM.isBeforeInTranslationUnit(LHS.first->getBeginLoc(),
1414 RHS.first->getBeginLoc());
1415 });
Jordan Rosed3934582012-09-28 22:21:30 +00001416
1417 // Classify the current code body for better warning text.
1418 // This enum should stay in sync with the cases in
1419 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
1420 // FIXME: Should we use a common classification enum and the same set of
1421 // possibilities all throughout Sema?
1422 enum {
1423 Function,
1424 Method,
1425 Block,
1426 Lambda
1427 } FunctionKind;
1428
1429 if (isa<sema::BlockScopeInfo>(CurFn))
1430 FunctionKind = Block;
1431 else if (isa<sema::LambdaScopeInfo>(CurFn))
1432 FunctionKind = Lambda;
1433 else if (isa<ObjCMethodDecl>(D))
1434 FunctionKind = Method;
1435 else
1436 FunctionKind = Function;
1437
1438 // Iterate through the sorted problems and emit warnings for each.
Aaron Ballmane5195222014-05-15 20:50:47 +00001439 for (const auto &P : UsesByStmt) {
1440 const Stmt *FirstRead = P.first;
1441 const WeakObjectProfileTy &Key = P.second->first;
1442 const WeakUseVector &Uses = P.second->second;
Jordan Rosed3934582012-09-28 22:21:30 +00001443
Jordan Rose657b5f42012-09-28 22:21:35 +00001444 // For complicated expressions like 'a.b.c' and 'x.b.c', WeakObjectProfileTy
1445 // may not contain enough information to determine that these are different
1446 // properties. We can only be 100% sure of a repeated use in certain cases,
1447 // and we adjust the diagnostic kind accordingly so that the less certain
1448 // case can be turned off if it is too noisy.
Jordan Rosed3934582012-09-28 22:21:30 +00001449 unsigned DiagKind;
1450 if (Key.isExactProfile())
1451 DiagKind = diag::warn_arc_repeated_use_of_weak;
1452 else
1453 DiagKind = diag::warn_arc_possible_repeated_use_of_weak;
1454
Jordan Rose657b5f42012-09-28 22:21:35 +00001455 // Classify the weak object being accessed for better warning text.
1456 // This enum should stay in sync with the cases in
1457 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
1458 enum {
1459 Variable,
1460 Property,
1461 ImplicitProperty,
1462 Ivar
1463 } ObjectKind;
1464
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001465 const NamedDecl *KeyProp = Key.getProperty();
1466 if (isa<VarDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001467 ObjectKind = Variable;
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001468 else if (isa<ObjCPropertyDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001469 ObjectKind = Property;
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001470 else if (isa<ObjCMethodDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001471 ObjectKind = ImplicitProperty;
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001472 else if (isa<ObjCIvarDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001473 ObjectKind = Ivar;
1474 else
1475 llvm_unreachable("Unexpected weak object kind!");
1476
Bob Wilsonf4f54e32016-05-25 05:41:57 +00001477 // Do not warn about IBOutlet weak property receivers being set to null
1478 // since they are typically only used from the main thread.
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001479 if (const ObjCPropertyDecl *Prop = dyn_cast<ObjCPropertyDecl>(KeyProp))
Bob Wilsonf4f54e32016-05-25 05:41:57 +00001480 if (Prop->hasAttr<IBOutletAttr>())
1481 continue;
1482
Jordan Rosed3934582012-09-28 22:21:30 +00001483 // Show the first time the object was read.
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001484 S.Diag(FirstRead->getBeginLoc(), DiagKind)
1485 << int(ObjectKind) << KeyProp << int(FunctionKind)
1486 << FirstRead->getSourceRange();
Jordan Rosed3934582012-09-28 22:21:30 +00001487
1488 // Print all the other accesses as notes.
Aaron Ballmane5195222014-05-15 20:50:47 +00001489 for (const auto &Use : Uses) {
1490 if (Use.getUseExpr() == FirstRead)
Jordan Rosed3934582012-09-28 22:21:30 +00001491 continue;
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001492 S.Diag(Use.getUseExpr()->getBeginLoc(),
Jordan Rosed3934582012-09-28 22:21:30 +00001493 diag::note_arc_weak_also_accessed_here)
Aaron Ballmane5195222014-05-15 20:50:47 +00001494 << Use.getUseExpr()->getSourceRange();
Jordan Rosed3934582012-09-28 22:21:30 +00001495 }
1496 }
1497}
1498
Jordan Rosed3934582012-09-28 22:21:30 +00001499namespace {
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001500class UninitValsDiagReporter : public UninitVariablesHandler {
1501 Sema &S;
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001502 typedef SmallVector<UninitUse, 2> UsesVec;
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001503 typedef llvm::PointerIntPair<UsesVec *, 1, bool> MappedType;
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001504 // Prefer using MapVector to DenseMap, so that iteration order will be
1505 // the same as insertion order. This is needed to obtain a deterministic
1506 // order of diagnostics when calling flushDiagnostics().
1507 typedef llvm::MapVector<const VarDecl *, MappedType> UsesMap;
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001508 UsesMap uses;
Fangrui Song6907ce22018-07-30 19:24:48 +00001509
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001510public:
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001511 UninitValsDiagReporter(Sema &S) : S(S) {}
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001512 ~UninitValsDiagReporter() override { flushDiagnostics(); }
Ted Kremenek596fa162011-10-13 18:50:06 +00001513
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001514 MappedType &getUses(const VarDecl *vd) {
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001515 MappedType &V = uses[vd];
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001516 if (!V.getPointer())
1517 V.setPointer(new UsesVec());
Ted Kremenek596fa162011-10-13 18:50:06 +00001518 return V;
1519 }
Craig Toppere14c0f82014-03-12 04:55:44 +00001520
1521 void handleUseOfUninitVariable(const VarDecl *vd,
1522 const UninitUse &use) override {
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001523 getUses(vd).getPointer()->push_back(use);
Ted Kremenek596fa162011-10-13 18:50:06 +00001524 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001525
Craig Toppere14c0f82014-03-12 04:55:44 +00001526 void handleSelfInit(const VarDecl *vd) override {
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001527 getUses(vd).setInt(true);
Ted Kremenek39fa0562011-01-21 19:41:41 +00001528 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001529
Ted Kremenek39fa0562011-01-21 19:41:41 +00001530 void flushDiagnostics() {
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001531 for (const auto &P : uses) {
Aaron Ballmane5195222014-05-15 20:50:47 +00001532 const VarDecl *vd = P.first;
1533 const MappedType &V = P.second;
Ted Kremenekb3dbe282011-02-02 23:35:53 +00001534
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001535 UsesVec *vec = V.getPointer();
1536 bool hasSelfInit = V.getInt();
Ted Kremenek596fa162011-10-13 18:50:06 +00001537
Fangrui Song6907ce22018-07-30 19:24:48 +00001538 // Specially handle the case where we have uses of an uninitialized
Ted Kremenek596fa162011-10-13 18:50:06 +00001539 // variable, but the root cause is an idiomatic self-init. We want
1540 // to report the diagnostic at the self-init since that is the root cause.
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001541 if (!vec->empty() && hasSelfInit && hasAlwaysUninitializedUse(vec))
Richard Smith4323bf82012-05-25 02:17:09 +00001542 DiagnoseUninitializedUse(S, vd,
1543 UninitUse(vd->getInit()->IgnoreParenCasts(),
1544 /* isAlwaysUninit */ true),
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001545 /* alwaysReportSelfInit */ true);
Ted Kremenek596fa162011-10-13 18:50:06 +00001546 else {
1547 // Sort the uses by their SourceLocations. While not strictly
1548 // guaranteed to produce them in line/column order, this will provide
1549 // a stable ordering.
Mandeep Singh Grangc205d8c2018-03-27 16:50:00 +00001550 llvm::sort(vec->begin(), vec->end(),
1551 [](const UninitUse &a, const UninitUse &b) {
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001552 // Prefer a more confident report over a less confident one.
1553 if (a.getKind() != b.getKind())
1554 return a.getKind() > b.getKind();
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001555 return a.getUser()->getBeginLoc() < b.getUser()->getBeginLoc();
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001556 });
1557
Aaron Ballmane5195222014-05-15 20:50:47 +00001558 for (const auto &U : *vec) {
Richard Smith4323bf82012-05-25 02:17:09 +00001559 // If we have self-init, downgrade all uses to 'may be uninitialized'.
Aaron Ballmane5195222014-05-15 20:50:47 +00001560 UninitUse Use = hasSelfInit ? UninitUse(U.getUser(), false) : U;
Richard Smith4323bf82012-05-25 02:17:09 +00001561
1562 if (DiagnoseUninitializedUse(S, vd, Use))
Ted Kremenek596fa162011-10-13 18:50:06 +00001563 // Skip further diagnostics for this variable. We try to warn only
1564 // on the first point at which a variable is used uninitialized.
1565 break;
1566 }
Chandler Carruth7a037202011-04-05 18:18:08 +00001567 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001568
Ted Kremenek596fa162011-10-13 18:50:06 +00001569 // Release the uses vector.
Ted Kremenek39fa0562011-01-21 19:41:41 +00001570 delete vec;
1571 }
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001572
1573 uses.clear();
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001574 }
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001575
1576private:
1577 static bool hasAlwaysUninitializedUse(const UsesVec* vec) {
Aaron Ballmane5195222014-05-15 20:50:47 +00001578 return std::any_of(vec->begin(), vec->end(), [](const UninitUse &U) {
1579 return U.getKind() == UninitUse::Always ||
1580 U.getKind() == UninitUse::AfterCall ||
1581 U.getKind() == UninitUse::AfterDecl;
1582 });
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001583 }
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001584};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001585} // anonymous namespace
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001586
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001587namespace clang {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001588namespace {
Dmitri Gribenkof8579502013-01-12 19:30:44 +00001589typedef SmallVector<PartialDiagnosticAt, 1> OptionalNotes;
Richard Smith92286672012-02-03 04:45:26 +00001590typedef std::pair<PartialDiagnosticAt, OptionalNotes> DelayedDiag;
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001591typedef std::list<DelayedDiag> DiagList;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001592
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001593struct SortDiagBySourceLocation {
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001594 SourceManager &SM;
1595 SortDiagBySourceLocation(SourceManager &SM) : SM(SM) {}
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001596
1597 bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
1598 // Although this call will be slow, this is only called when outputting
1599 // multiple warnings.
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001600 return SM.isBeforeInTranslationUnit(left.first.first, right.first.first);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001601 }
1602};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001603} // anonymous namespace
1604} // namespace clang
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001605
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001606//===----------------------------------------------------------------------===//
1607// -Wthread-safety
1608//===----------------------------------------------------------------------===//
1609namespace clang {
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001610namespace threadSafety {
Benjamin Kramer539803c2015-03-19 14:23:45 +00001611namespace {
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001612class ThreadSafetyReporter : public clang::threadSafety::ThreadSafetyHandler {
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001613 Sema &S;
1614 DiagList Warnings;
Richard Smith92286672012-02-03 04:45:26 +00001615 SourceLocation FunLocation, FunEndLocation;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001616
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001617 const FunctionDecl *CurrentFunction;
1618 bool Verbose;
1619
Aaron Ballman71291bc2014-08-15 12:38:17 +00001620 OptionalNotes getNotes() const {
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001621 if (Verbose && CurrentFunction) {
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001622 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getBeginLoc(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001623 S.PDiag(diag::note_thread_warning_in_fun)
Richard Trieub4025802018-03-28 04:16:13 +00001624 << CurrentFunction);
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001625 return OptionalNotes(1, FNote);
1626 }
Aaron Ballman71291bc2014-08-15 12:38:17 +00001627 return OptionalNotes();
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001628 }
1629
Aaron Ballman71291bc2014-08-15 12:38:17 +00001630 OptionalNotes getNotes(const PartialDiagnosticAt &Note) const {
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001631 OptionalNotes ONS(1, Note);
1632 if (Verbose && CurrentFunction) {
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001633 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getBeginLoc(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001634 S.PDiag(diag::note_thread_warning_in_fun)
Richard Trieub4025802018-03-28 04:16:13 +00001635 << CurrentFunction);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001636 ONS.push_back(std::move(FNote));
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001637 }
1638 return ONS;
1639 }
1640
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001641 OptionalNotes getNotes(const PartialDiagnosticAt &Note1,
1642 const PartialDiagnosticAt &Note2) const {
1643 OptionalNotes ONS;
1644 ONS.push_back(Note1);
1645 ONS.push_back(Note2);
1646 if (Verbose && CurrentFunction) {
Stephen Kellyf2ceec42018-08-09 21:08:08 +00001647 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getBeginLoc(),
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001648 S.PDiag(diag::note_thread_warning_in_fun)
Richard Trieub4025802018-03-28 04:16:13 +00001649 << CurrentFunction);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001650 ONS.push_back(std::move(FNote));
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001651 }
1652 return ONS;
1653 }
1654
Aaron Puchertad4d52a2019-03-18 23:26:54 +00001655 OptionalNotes makeLockedHereNote(SourceLocation LocLocked, StringRef Kind) {
1656 return LocLocked.isValid()
1657 ? getNotes(PartialDiagnosticAt(
1658 LocLocked, S.PDiag(diag::note_locked_here) << Kind))
1659 : getNotes();
1660 }
1661
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001662 public:
Richard Smith92286672012-02-03 04:45:26 +00001663 ThreadSafetyReporter(Sema &S, SourceLocation FL, SourceLocation FEL)
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001664 : S(S), FunLocation(FL), FunEndLocation(FEL),
1665 CurrentFunction(nullptr), Verbose(false) {}
1666
1667 void setVerbose(bool b) { Verbose = b; }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001668
Adrian Prantl9fc8faf2018-05-09 01:00:01 +00001669 /// Emit all buffered diagnostics in order of sourcelocation.
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001670 /// We need to output diagnostics produced while iterating through
1671 /// the lockset in deterministic order, so this function orders diagnostics
1672 /// and outputs them.
1673 void emitDiagnostics() {
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001674 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Aaron Ballmane5195222014-05-15 20:50:47 +00001675 for (const auto &Diag : Warnings) {
1676 S.Diag(Diag.first.first, Diag.first.second);
1677 for (const auto &Note : Diag.second)
1678 S.Diag(Note.first, Note.second);
Richard Smith92286672012-02-03 04:45:26 +00001679 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001680 }
1681
Aaron Ballmane0449042014-04-01 21:43:23 +00001682 void handleInvalidLockExp(StringRef Kind, SourceLocation Loc) override {
1683 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_cannot_resolve_lock)
1684 << Loc);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001685 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowskiff2f3f82011-09-09 16:21:55 +00001686 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001687
Aaron Ballmane0449042014-04-01 21:43:23 +00001688 void handleUnmatchedUnlock(StringRef Kind, Name LockName,
1689 SourceLocation Loc) override {
Aaron Puchertffa1d6a2019-01-29 22:11:42 +00001690 if (Loc.isInvalid())
1691 Loc = FunLocation;
1692 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_unlock_but_no_lock)
1693 << Kind << LockName);
1694 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001695 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001696
Aaron Ballmane0449042014-04-01 21:43:23 +00001697 void handleIncorrectUnlockKind(StringRef Kind, Name LockName,
1698 LockKind Expected, LockKind Received,
Aaron Puchertad4d52a2019-03-18 23:26:54 +00001699 SourceLocation LocLocked,
Aaron Puchertdc087de2019-03-19 00:14:46 +00001700 SourceLocation LocUnlock) override {
1701 if (LocUnlock.isInvalid())
1702 LocUnlock = FunLocation;
1703 PartialDiagnosticAt Warning(
1704 LocUnlock, S.PDiag(diag::warn_unlock_kind_mismatch)
1705 << Kind << LockName << Received << Expected);
Aaron Puchertad4d52a2019-03-18 23:26:54 +00001706 Warnings.emplace_back(std::move(Warning),
1707 makeLockedHereNote(LocLocked, Kind));
Aaron Ballmandf115d92014-03-21 14:48:48 +00001708 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001709
Aaron Puchertffa1d6a2019-01-29 22:11:42 +00001710 void handleDoubleLock(StringRef Kind, Name LockName, SourceLocation LocLocked,
Aaron Puchertdc087de2019-03-19 00:14:46 +00001711 SourceLocation LocDoubleLock) override {
1712 if (LocDoubleLock.isInvalid())
1713 LocDoubleLock = FunLocation;
1714 PartialDiagnosticAt Warning(LocDoubleLock, S.PDiag(diag::warn_double_lock)
1715 << Kind << LockName);
Aaron Puchertad4d52a2019-03-18 23:26:54 +00001716 Warnings.emplace_back(std::move(Warning),
1717 makeLockedHereNote(LocLocked, Kind));
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001718 }
1719
Aaron Ballmane0449042014-04-01 21:43:23 +00001720 void handleMutexHeldEndOfScope(StringRef Kind, Name LockName,
1721 SourceLocation LocLocked,
Richard Smith92286672012-02-03 04:45:26 +00001722 SourceLocation LocEndOfScope,
Craig Toppere14c0f82014-03-12 04:55:44 +00001723 LockErrorKind LEK) override {
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001724 unsigned DiagID = 0;
1725 switch (LEK) {
1726 case LEK_LockedSomePredecessors:
Richard Smith92286672012-02-03 04:45:26 +00001727 DiagID = diag::warn_lock_some_predecessors;
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001728 break;
1729 case LEK_LockedSomeLoopIterations:
1730 DiagID = diag::warn_expecting_lock_held_on_loop;
1731 break;
1732 case LEK_LockedAtEndOfFunction:
1733 DiagID = diag::warn_no_unlock;
1734 break;
DeLesley Hutchins6e6dbb72012-07-02 22:16:54 +00001735 case LEK_NotLockedAtEndOfFunction:
1736 DiagID = diag::warn_expecting_locked;
1737 break;
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001738 }
Richard Smith92286672012-02-03 04:45:26 +00001739 if (LocEndOfScope.isInvalid())
1740 LocEndOfScope = FunEndLocation;
1741
Aaron Ballmane0449042014-04-01 21:43:23 +00001742 PartialDiagnosticAt Warning(LocEndOfScope, S.PDiag(DiagID) << Kind
1743 << LockName);
Aaron Puchertad4d52a2019-03-18 23:26:54 +00001744 Warnings.emplace_back(std::move(Warning),
1745 makeLockedHereNote(LocLocked, Kind));
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001746 }
1747
Aaron Ballmane0449042014-04-01 21:43:23 +00001748 void handleExclusiveAndShared(StringRef Kind, Name LockName,
1749 SourceLocation Loc1,
Craig Toppere14c0f82014-03-12 04:55:44 +00001750 SourceLocation Loc2) override {
Aaron Ballmane0449042014-04-01 21:43:23 +00001751 PartialDiagnosticAt Warning(Loc1,
1752 S.PDiag(diag::warn_lock_exclusive_and_shared)
1753 << Kind << LockName);
1754 PartialDiagnosticAt Note(Loc2, S.PDiag(diag::note_lock_exclusive_and_shared)
1755 << Kind << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001756 Warnings.emplace_back(std::move(Warning), getNotes(Note));
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001757 }
1758
Aaron Ballmane0449042014-04-01 21:43:23 +00001759 void handleNoMutexHeld(StringRef Kind, const NamedDecl *D,
1760 ProtectedOperationKind POK, AccessKind AK,
1761 SourceLocation Loc) override {
1762 assert((POK == POK_VarAccess || POK == POK_VarDereference) &&
1763 "Only works for variables");
Caitlin Sadowskie50d8c32011-09-14 20:09:09 +00001764 unsigned DiagID = POK == POK_VarAccess?
1765 diag::warn_variable_requires_any_lock:
1766 diag::warn_var_deref_requires_any_lock;
Richard Smith92286672012-02-03 04:45:26 +00001767 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
Richard Trieub4025802018-03-28 04:16:13 +00001768 << D << getLockKindFromAccessKind(AK));
Benjamin Kramer3204b152015-05-29 19:42:19 +00001769 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001770 }
1771
Aaron Ballmane0449042014-04-01 21:43:23 +00001772 void handleMutexNotHeld(StringRef Kind, const NamedDecl *D,
1773 ProtectedOperationKind POK, Name LockName,
1774 LockKind LK, SourceLocation Loc,
Craig Toppere14c0f82014-03-12 04:55:44 +00001775 Name *PossibleMatch) override {
Caitlin Sadowski427f42e2011-09-13 18:01:58 +00001776 unsigned DiagID = 0;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001777 if (PossibleMatch) {
1778 switch (POK) {
1779 case POK_VarAccess:
1780 DiagID = diag::warn_variable_requires_lock_precise;
1781 break;
1782 case POK_VarDereference:
1783 DiagID = diag::warn_var_deref_requires_lock_precise;
1784 break;
1785 case POK_FunctionCall:
1786 DiagID = diag::warn_fun_requires_lock_precise;
1787 break;
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001788 case POK_PassByRef:
1789 DiagID = diag::warn_guarded_pass_by_reference;
1790 break;
1791 case POK_PtPassByRef:
1792 DiagID = diag::warn_pt_guarded_pass_by_reference;
1793 break;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001794 }
Aaron Ballmane0449042014-04-01 21:43:23 +00001795 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind
Richard Trieub4025802018-03-28 04:16:13 +00001796 << D
Aaron Ballmane0449042014-04-01 21:43:23 +00001797 << LockName << LK);
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001798 PartialDiagnosticAt Note(Loc, S.PDiag(diag::note_found_mutex_near_match)
Aaron Ballmane0449042014-04-01 21:43:23 +00001799 << *PossibleMatch);
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001800 if (Verbose && POK == POK_VarAccess) {
1801 PartialDiagnosticAt VNote(D->getLocation(),
1802 S.PDiag(diag::note_guarded_by_declared_here)
1803 << D->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001804 Warnings.emplace_back(std::move(Warning), getNotes(Note, VNote));
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001805 } else
Benjamin Kramer3204b152015-05-29 19:42:19 +00001806 Warnings.emplace_back(std::move(Warning), getNotes(Note));
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001807 } else {
1808 switch (POK) {
1809 case POK_VarAccess:
1810 DiagID = diag::warn_variable_requires_lock;
1811 break;
1812 case POK_VarDereference:
1813 DiagID = diag::warn_var_deref_requires_lock;
1814 break;
1815 case POK_FunctionCall:
1816 DiagID = diag::warn_fun_requires_lock;
1817 break;
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001818 case POK_PassByRef:
1819 DiagID = diag::warn_guarded_pass_by_reference;
1820 break;
1821 case POK_PtPassByRef:
1822 DiagID = diag::warn_pt_guarded_pass_by_reference;
1823 break;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001824 }
Aaron Ballmane0449042014-04-01 21:43:23 +00001825 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind
Richard Trieub4025802018-03-28 04:16:13 +00001826 << D
Aaron Ballmane0449042014-04-01 21:43:23 +00001827 << LockName << LK);
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001828 if (Verbose && POK == POK_VarAccess) {
1829 PartialDiagnosticAt Note(D->getLocation(),
Richard Trieub4025802018-03-28 04:16:13 +00001830 S.PDiag(diag::note_guarded_by_declared_here));
Benjamin Kramer3204b152015-05-29 19:42:19 +00001831 Warnings.emplace_back(std::move(Warning), getNotes(Note));
Aaron Ballman71291bc2014-08-15 12:38:17 +00001832 } else
Benjamin Kramer3204b152015-05-29 19:42:19 +00001833 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001834 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001835 }
1836
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001837 void handleNegativeNotHeld(StringRef Kind, Name LockName, Name Neg,
1838 SourceLocation Loc) override {
DeLesley Hutchins3efd0492014-08-04 22:13:06 +00001839 PartialDiagnosticAt Warning(Loc,
1840 S.PDiag(diag::warn_acquire_requires_negative_cap)
1841 << Kind << LockName << Neg);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001842 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchins3efd0492014-08-04 22:13:06 +00001843 }
1844
Aaron Ballmane0449042014-04-01 21:43:23 +00001845 void handleFunExcludesLock(StringRef Kind, Name FunName, Name LockName,
Craig Toppere14c0f82014-03-12 04:55:44 +00001846 SourceLocation Loc) override {
Aaron Ballmane0449042014-04-01 21:43:23 +00001847 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_fun_excludes_mutex)
1848 << Kind << FunName << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001849 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001850 }
1851
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001852 void handleLockAcquiredBefore(StringRef Kind, Name L1Name, Name L2Name,
1853 SourceLocation Loc) override {
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001854 PartialDiagnosticAt Warning(Loc,
1855 S.PDiag(diag::warn_acquired_before) << Kind << L1Name << L2Name);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001856 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001857 }
1858
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001859 void handleBeforeAfterCycle(Name L1Name, SourceLocation Loc) override {
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001860 PartialDiagnosticAt Warning(Loc,
1861 S.PDiag(diag::warn_acquired_before_after_cycle) << L1Name);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001862 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001863 }
1864
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001865 void enterFunction(const FunctionDecl* FD) override {
1866 CurrentFunction = FD;
1867 }
1868
1869 void leaveFunction(const FunctionDecl* FD) override {
Hans Wennborgdcfba332015-10-06 23:40:43 +00001870 CurrentFunction = nullptr;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001871 }
1872};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001873} // anonymous namespace
Benjamin Kramer539803c2015-03-19 14:23:45 +00001874} // namespace threadSafety
1875} // namespace clang
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001876
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001877//===----------------------------------------------------------------------===//
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001878// -Wconsumed
1879//===----------------------------------------------------------------------===//
1880
1881namespace clang {
1882namespace consumed {
1883namespace {
1884class ConsumedWarningsHandler : public ConsumedWarningsHandlerBase {
Fangrui Song6907ce22018-07-30 19:24:48 +00001885
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001886 Sema &S;
1887 DiagList Warnings;
Fangrui Song6907ce22018-07-30 19:24:48 +00001888
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001889public:
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001890
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001891 ConsumedWarningsHandler(Sema &S) : S(S) {}
Craig Toppere14c0f82014-03-12 04:55:44 +00001892
1893 void emitDiagnostics() override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001894 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Aaron Ballmane5195222014-05-15 20:50:47 +00001895 for (const auto &Diag : Warnings) {
1896 S.Diag(Diag.first.first, Diag.first.second);
1897 for (const auto &Note : Diag.second)
1898 S.Diag(Note.first, Note.second);
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001899 }
1900 }
Craig Toppere14c0f82014-03-12 04:55:44 +00001901
1902 void warnLoopStateMismatch(SourceLocation Loc,
1903 StringRef VariableName) override {
DeLesley Hutchins3277a612013-10-09 18:30:24 +00001904 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_loop_state_mismatch) <<
1905 VariableName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001906
1907 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins3277a612013-10-09 18:30:24 +00001908 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001909
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001910 void warnParamReturnTypestateMismatch(SourceLocation Loc,
1911 StringRef VariableName,
1912 StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001913 StringRef ObservedState) override {
Fangrui Song6907ce22018-07-30 19:24:48 +00001914
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001915 PartialDiagnosticAt Warning(Loc, S.PDiag(
1916 diag::warn_param_return_typestate_mismatch) << VariableName <<
1917 ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001918
1919 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001920 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001921
DeLesley Hutchins69391772013-10-17 23:23:53 +00001922 void warnParamTypestateMismatch(SourceLocation Loc, StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001923 StringRef ObservedState) override {
Fangrui Song6907ce22018-07-30 19:24:48 +00001924
DeLesley Hutchins69391772013-10-17 23:23:53 +00001925 PartialDiagnosticAt Warning(Loc, S.PDiag(
1926 diag::warn_param_typestate_mismatch) << ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001927
1928 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins69391772013-10-17 23:23:53 +00001929 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001930
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001931 void warnReturnTypestateForUnconsumableType(SourceLocation Loc,
Craig Toppere14c0f82014-03-12 04:55:44 +00001932 StringRef TypeName) override {
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001933 PartialDiagnosticAt Warning(Loc, S.PDiag(
1934 diag::warn_return_typestate_for_unconsumable_type) << TypeName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001935
1936 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001937 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001938
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001939 void warnReturnTypestateMismatch(SourceLocation Loc, StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001940 StringRef ObservedState) override {
Fangrui Song6907ce22018-07-30 19:24:48 +00001941
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001942 PartialDiagnosticAt Warning(Loc, S.PDiag(
1943 diag::warn_return_typestate_mismatch) << ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001944
1945 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001946 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001947
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001948 void warnUseOfTempInInvalidState(StringRef MethodName, StringRef State,
Craig Toppere14c0f82014-03-12 04:55:44 +00001949 SourceLocation Loc) override {
Fangrui Song6907ce22018-07-30 19:24:48 +00001950
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001951 PartialDiagnosticAt Warning(Loc, S.PDiag(
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001952 diag::warn_use_of_temp_in_invalid_state) << MethodName << State);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001953
1954 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001955 }
Fangrui Song6907ce22018-07-30 19:24:48 +00001956
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001957 void warnUseInInvalidState(StringRef MethodName, StringRef VariableName,
Craig Toppere14c0f82014-03-12 04:55:44 +00001958 StringRef State, SourceLocation Loc) override {
Fangrui Song6907ce22018-07-30 19:24:48 +00001959
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001960 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_use_in_invalid_state) <<
1961 MethodName << VariableName << State);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001962
1963 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001964 }
1965};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001966} // anonymous namespace
1967} // namespace consumed
1968} // namespace clang
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001969
1970//===----------------------------------------------------------------------===//
Ted Kremenek918fe842010-03-20 21:06:02 +00001971// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
1972// warnings on a function, method, or block.
1973//===----------------------------------------------------------------------===//
1974
Ted Kremenek0b405322010-03-23 00:13:23 +00001975clang::sema::AnalysisBasedWarnings::Policy::Policy() {
1976 enableCheckFallThrough = 1;
1977 enableCheckUnreachable = 0;
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00001978 enableThreadSafetyAnalysis = 0;
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001979 enableConsumedAnalysis = 0;
Ted Kremenek0b405322010-03-23 00:13:23 +00001980}
1981
Ted Kremenekad8753c2014-03-15 05:47:06 +00001982static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001983 return (unsigned)!D.isIgnored(diag, SourceLocation());
Ted Kremenekad8753c2014-03-15 05:47:06 +00001984}
1985
Chandler Carruthb4836ea2011-07-06 16:21:37 +00001986clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
1987 : S(s),
1988 NumFunctionsAnalyzed(0),
Benjamin Kramer581f48f2011-07-08 20:38:53 +00001989 NumFunctionsWithBadCFGs(0),
Chandler Carruthb4836ea2011-07-06 16:21:37 +00001990 NumCFGBlocks(0),
Benjamin Kramer581f48f2011-07-08 20:38:53 +00001991 MaxCFGBlocksPerFunction(0),
1992 NumUninitAnalysisFunctions(0),
1993 NumUninitAnalysisVariables(0),
1994 MaxUninitAnalysisVariablesPerFunction(0),
1995 NumUninitAnalysisBlockVisits(0),
1996 MaxUninitAnalysisBlockVisitsPerFunction(0) {
Ted Kremenekad8753c2014-03-15 05:47:06 +00001997
1998 using namespace diag;
David Blaikie9c902b52011-09-25 23:23:43 +00001999 DiagnosticsEngine &D = S.getDiagnostics();
Ted Kremenekad8753c2014-03-15 05:47:06 +00002000
2001 DefaultPolicy.enableCheckUnreachable =
2002 isEnabled(D, warn_unreachable) ||
2003 isEnabled(D, warn_unreachable_break) ||
Ted Kremenek14210372014-03-21 06:02:36 +00002004 isEnabled(D, warn_unreachable_return) ||
2005 isEnabled(D, warn_unreachable_loop_increment);
Ted Kremenekad8753c2014-03-15 05:47:06 +00002006
2007 DefaultPolicy.enableThreadSafetyAnalysis =
2008 isEnabled(D, warn_double_lock);
2009
2010 DefaultPolicy.enableConsumedAnalysis =
2011 isEnabled(D, warn_use_in_invalid_state);
Ted Kremenek918fe842010-03-20 21:06:02 +00002012}
2013
Aaron Ballmane5195222014-05-15 20:50:47 +00002014static void flushDiagnostics(Sema &S, const sema::FunctionScopeInfo *fscope) {
2015 for (const auto &D : fscope->PossiblyUnreachableDiags)
Ted Kremenek3427fac2011-02-23 01:52:04 +00002016 S.Diag(D.Loc, D.PD);
Ted Kremenek3427fac2011-02-23 01:52:04 +00002017}
2018
Ted Kremenek0b405322010-03-23 00:13:23 +00002019void clang::sema::
2020AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
Ted Kremenekcc7f1f82011-02-23 01:51:53 +00002021 sema::FunctionScopeInfo *fscope,
Richard Smith2fdd95c2019-05-31 00:45:09 +00002022 const Decl *D, QualType BlockType) {
Ted Kremenekb45ebee2010-03-20 21:11:09 +00002023
Ted Kremenek918fe842010-03-20 21:06:02 +00002024 // We avoid doing analysis-based warnings when there are errors for
2025 // two reasons:
2026 // (1) The CFGs often can't be constructed (if the body is invalid), so
2027 // don't bother trying.
2028 // (2) The code already has problems; running the analysis just takes more
2029 // time.
David Blaikie9c902b52011-09-25 23:23:43 +00002030 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenekb8021922010-04-30 21:49:25 +00002031
Olivier Goffart270ced22017-11-23 08:15:22 +00002032 // Do not do any analysis if we are going to just ignore them.
2033 if (Diags.getIgnoreAllWarnings() ||
2034 (Diags.getSuppressSystemWarnings() &&
2035 S.SourceMgr.isInSystemHeader(D->getLocation())))
Ted Kremenek0b405322010-03-23 00:13:23 +00002036 return;
2037
John McCall1d570a72010-08-25 05:56:39 +00002038 // For code in dependent contexts, we'll do this at instantiation time.
David Blaikie0f2ae782012-01-24 04:51:48 +00002039 if (cast<DeclContext>(D)->isDependentContext())
2040 return;
Ted Kremenek918fe842010-03-20 21:06:02 +00002041
Argyrios Kyrtzidis70ec1c72016-07-13 20:35:26 +00002042 if (Diags.hasUncompilableErrorOccurred()) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00002043 // Flush out any possibly unreachable diagnostics.
2044 flushDiagnostics(S, fscope);
2045 return;
2046 }
Fangrui Song6907ce22018-07-30 19:24:48 +00002047
Ted Kremenek918fe842010-03-20 21:06:02 +00002048 const Stmt *Body = D->getBody();
2049 assert(Body);
2050
Ted Kremenekb3a38a92013-10-14 19:11:25 +00002051 // Construct the analysis context with the specified CFG build options.
Craig Topperc3ec1492014-05-26 06:22:03 +00002052 AnalysisDeclContext AC(/* AnalysisDeclContextManager */ nullptr, D);
Ted Kremenek189ecec2011-07-21 05:22:47 +00002053
Ted Kremenek918fe842010-03-20 21:06:02 +00002054 // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
Benjamin Kramer60509af2013-09-09 14:48:42 +00002055 // explosion for destructors that can result and the compile time hit.
Ted Kremenek189ecec2011-07-21 05:22:47 +00002056 AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
2057 AC.getCFGBuildOptions().AddEHEdges = false;
2058 AC.getCFGBuildOptions().AddInitializers = true;
2059 AC.getCFGBuildOptions().AddImplicitDtors = true;
Jordan Rose91f78402012-09-05 23:11:06 +00002060 AC.getCFGBuildOptions().AddTemporaryDtors = true;
Jordan Rosec9176072014-01-13 17:59:19 +00002061 AC.getCFGBuildOptions().AddCXXNewAllocator = false;
Enrico Pertosofaed8012015-06-03 10:12:40 +00002062 AC.getCFGBuildOptions().AddCXXDefaultInitExprInCtors = true;
Jordan Rose91f78402012-09-05 23:11:06 +00002063
Ted Kremenek9e100ea2011-07-19 14:18:48 +00002064 // Force that certain expressions appear as CFGElements in the CFG. This
2065 // is used to speed up various analyses.
2066 // FIXME: This isn't the right factoring. This is here for initial
2067 // prototyping, but we need a way for analyses to say what expressions they
2068 // expect to always be CFGElements and then fill in the BuildOptions
2069 // appropriately. This is essentially a layering violation.
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002070 if (P.enableCheckUnreachable || P.enableThreadSafetyAnalysis ||
2071 P.enableConsumedAnalysis) {
DeLesley Hutchinsf7faa6a2011-12-08 20:23:06 +00002072 // Unreachable code analysis and thread safety require a linearized CFG.
Ted Kremenekbd913712011-08-23 23:05:11 +00002073 AC.getCFGBuildOptions().setAllAlwaysAdd();
2074 }
2075 else {
2076 AC.getCFGBuildOptions()
2077 .setAlwaysAdd(Stmt::BinaryOperatorClass)
Richard Smithb21dd022012-07-17 01:27:33 +00002078 .setAlwaysAdd(Stmt::CompoundAssignOperatorClass)
Ted Kremenekbd913712011-08-23 23:05:11 +00002079 .setAlwaysAdd(Stmt::BlockExprClass)
2080 .setAlwaysAdd(Stmt::CStyleCastExprClass)
2081 .setAlwaysAdd(Stmt::DeclRefExprClass)
2082 .setAlwaysAdd(Stmt::ImplicitCastExprClass)
Richard Smith84837d52012-05-03 18:27:39 +00002083 .setAlwaysAdd(Stmt::UnaryOperatorClass)
2084 .setAlwaysAdd(Stmt::AttributedStmtClass);
Ted Kremenekbd913712011-08-23 23:05:11 +00002085 }
Ted Kremenek918fe842010-03-20 21:06:02 +00002086
Richard Trieu8b0d14a2019-10-19 00:57:23 +00002087 // Install the logical handler.
George Burgess IVb65955e2018-08-05 01:37:07 +00002088 llvm::Optional<LogicalErrorHandler> LEH;
Richard Trieu8b0d14a2019-10-19 00:57:23 +00002089 if (LogicalErrorHandler::hasActiveDiagnostics(Diags, D->getBeginLoc())) {
George Burgess IVb65955e2018-08-05 01:37:07 +00002090 LEH.emplace(S);
2091 AC.getCFGBuildOptions().Observer = &*LEH;
Richard Trieuf935b562014-04-05 05:17:01 +00002092 }
Ted Kremenekb3a38a92013-10-14 19:11:25 +00002093
Ted Kremenek3427fac2011-02-23 01:52:04 +00002094 // Emit delayed diagnostics.
David Blaikie0f2ae782012-01-24 04:51:48 +00002095 if (!fscope->PossiblyUnreachableDiags.empty()) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00002096 bool analyzed = false;
Ted Kremeneka099c592011-03-10 03:50:34 +00002097
2098 // Register the expressions with the CFGBuilder.
Aaron Ballmane5195222014-05-15 20:50:47 +00002099 for (const auto &D : fscope->PossiblyUnreachableDiags) {
Richard Smith7d02ca42019-05-06 04:14:01 +00002100 for (const Stmt *S : D.Stmts)
2101 AC.registerForcedBlockExpression(S);
Ted Kremeneka099c592011-03-10 03:50:34 +00002102 }
2103
2104 if (AC.getCFG()) {
2105 analyzed = true;
Aaron Ballmane5195222014-05-15 20:50:47 +00002106 for (const auto &D : fscope->PossiblyUnreachableDiags) {
Richard Smith7d02ca42019-05-06 04:14:01 +00002107 bool AllReachable = true;
2108 for (const Stmt *S : D.Stmts) {
2109 const CFGBlock *block = AC.getBlockForRegisteredExpression(S);
Eli Friedmane0afc982012-01-21 01:01:51 +00002110 CFGReverseBlockReachabilityAnalysis *cra =
2111 AC.getCFGReachablityAnalysis();
2112 // FIXME: We should be able to assert that block is non-null, but
2113 // the CFG analysis can skip potentially-evaluated expressions in
2114 // edge cases; see test/Sema/vla-2.c.
2115 if (block && cra) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00002116 // Can this block be reached from the entrance?
Richard Smith7d02ca42019-05-06 04:14:01 +00002117 if (!cra->isReachable(&AC.getCFG()->getEntry(), block)) {
2118 AllReachable = false;
2119 break;
2120 }
Ted Kremenek3427fac2011-02-23 01:52:04 +00002121 }
Richard Smith7d02ca42019-05-06 04:14:01 +00002122 // If we cannot map to a basic block, assume the statement is
2123 // reachable.
Ted Kremenek3427fac2011-02-23 01:52:04 +00002124 }
Richard Smith7d02ca42019-05-06 04:14:01 +00002125
2126 if (AllReachable)
Ted Kremeneka099c592011-03-10 03:50:34 +00002127 S.Diag(D.Loc, D.PD);
Ted Kremenek3427fac2011-02-23 01:52:04 +00002128 }
Ted Kremeneka099c592011-03-10 03:50:34 +00002129 }
Ted Kremenek3427fac2011-02-23 01:52:04 +00002130
2131 if (!analyzed)
2132 flushDiagnostics(S, fscope);
2133 }
Fangrui Song6907ce22018-07-30 19:24:48 +00002134
Ted Kremenek918fe842010-03-20 21:06:02 +00002135 // Warning: check missing 'return'
David Blaikie0f2ae782012-01-24 04:51:48 +00002136 if (P.enableCheckFallThrough) {
Ted Kremenek918fe842010-03-20 21:06:02 +00002137 const CheckFallThroughDiagnostics &CD =
Eric Fiselier709d1b32016-10-27 07:30:31 +00002138 (isa<BlockDecl>(D)
2139 ? CheckFallThroughDiagnostics::MakeForBlock()
2140 : (isa<CXXMethodDecl>(D) &&
2141 cast<CXXMethodDecl>(D)->getOverloadedOperator() == OO_Call &&
2142 cast<CXXMethodDecl>(D)->getParent()->isLambda())
2143 ? CheckFallThroughDiagnostics::MakeForLambda()
Eric Fiselierda8f9b52017-05-25 02:16:53 +00002144 : (fscope->isCoroutine()
Eric Fiselier709d1b32016-10-27 07:30:31 +00002145 ? CheckFallThroughDiagnostics::MakeForCoroutine(D)
2146 : CheckFallThroughDiagnostics::MakeForFunction(D)));
Richard Smith2fdd95c2019-05-31 00:45:09 +00002147 CheckFallThroughForBody(S, D, Body, BlockType, CD, AC, fscope);
Ted Kremenek918fe842010-03-20 21:06:02 +00002148 }
2149
2150 // Warning: check for unreachable code
Ted Kremenek7f770032011-11-30 21:22:09 +00002151 if (P.enableCheckUnreachable) {
2152 // Only check for unreachable code on non-template instantiations.
2153 // Different template instantiations can effectively change the control-flow
2154 // and it is very difficult to prove that a snippet of code in a template
2155 // is unreachable for all instantiations.
Ted Kremenek85825ae2011-12-01 00:59:17 +00002156 bool isTemplateInstantiation = false;
2157 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(D))
2158 isTemplateInstantiation = Function->isTemplateInstantiation();
2159 if (!isTemplateInstantiation)
Ted Kremenek7f770032011-11-30 21:22:09 +00002160 CheckUnreachable(S, AC);
2161 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00002162
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00002163 // Check for thread safety violations
David Blaikie0f2ae782012-01-24 04:51:48 +00002164 if (P.enableThreadSafetyAnalysis) {
DeLesley Hutchinsc2090512011-10-21 18:10:14 +00002165 SourceLocation FL = AC.getDecl()->getLocation();
Stephen Kelly1c301dc2018-08-09 21:09:38 +00002166 SourceLocation FEL = AC.getDecl()->getEndLoc();
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00002167 threadSafety::ThreadSafetyReporter Reporter(S, FL, FEL);
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002168 if (!Diags.isIgnored(diag::warn_thread_safety_beta, D->getBeginLoc()))
DeLesley Hutchins8edae132012-12-05 00:06:15 +00002169 Reporter.setIssueBetaWarnings(true);
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002170 if (!Diags.isIgnored(diag::warn_thread_safety_verbose, D->getBeginLoc()))
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00002171 Reporter.setVerbose(true);
DeLesley Hutchins8edae132012-12-05 00:06:15 +00002172
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00002173 threadSafety::runThreadSafetyAnalysis(AC, Reporter,
2174 &S.ThreadSafetyDeclCache);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00002175 Reporter.emitDiagnostics();
2176 }
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00002177
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002178 // Check for violations of consumed properties.
2179 if (P.enableConsumedAnalysis) {
2180 consumed::ConsumedWarningsHandler WarningHandler(S);
Reid Klecknere846dea2013-08-12 23:49:39 +00002181 consumed::ConsumedAnalyzer Analyzer(WarningHandler);
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002182 Analyzer.run(AC);
2183 }
2184
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002185 if (!Diags.isIgnored(diag::warn_uninit_var, D->getBeginLoc()) ||
2186 !Diags.isIgnored(diag::warn_sometimes_uninit_var, D->getBeginLoc()) ||
2187 !Diags.isIgnored(diag::warn_maybe_uninit_var, D->getBeginLoc())) {
Ted Kremenek2551fbe2011-03-17 05:29:57 +00002188 if (CFG *cfg = AC.getCFG()) {
Ted Kremenekb63931e2011-01-18 21:18:58 +00002189 UninitValsDiagReporter reporter(S);
Fariborz Jahanian8809a9d2011-07-16 18:31:33 +00002190 UninitVariablesAnalysisStats stats;
Benjamin Kramere492cb42011-07-16 20:13:06 +00002191 std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
Ted Kremenekbcf848f2011-01-25 19:13:48 +00002192 runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002193 reporter, stats);
2194
2195 if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
2196 ++NumUninitAnalysisFunctions;
2197 NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
2198 NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
2199 MaxUninitAnalysisVariablesPerFunction =
2200 std::max(MaxUninitAnalysisVariablesPerFunction,
2201 stats.NumVariablesAnalyzed);
2202 MaxUninitAnalysisBlockVisitsPerFunction =
2203 std::max(MaxUninitAnalysisBlockVisitsPerFunction,
2204 stats.NumBlockVisits);
2205 }
Ted Kremenekb749a6d2011-01-15 02:58:47 +00002206 }
2207 }
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002208
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00002209 bool FallThroughDiagFull =
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002210 !Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getBeginLoc());
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002211 bool FallThroughDiagPerFunction = !Diags.isIgnored(
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002212 diag::warn_unannotated_fallthrough_per_function, D->getBeginLoc());
Richard Smith4f902c72016-03-08 00:32:55 +00002213 if (FallThroughDiagFull || FallThroughDiagPerFunction ||
2214 fscope->HasFallthroughStmt) {
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00002215 DiagnoseSwitchLabelsFallthrough(S, AC, !FallThroughDiagFull);
Richard Smith84837d52012-05-03 18:27:39 +00002216 }
2217
John McCall460ce582015-10-22 18:38:17 +00002218 if (S.getLangOpts().ObjCWeak &&
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002219 !Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, D->getBeginLoc()))
Jordan Rose76831c62012-10-11 16:10:19 +00002220 diagnoseRepeatedUseOfWeak(S, fscope, D, AC.getParentMap());
Jordan Rosed3934582012-09-28 22:21:30 +00002221
Richard Trieu2f024f42013-12-21 02:33:43 +00002222
2223 // Check for infinite self-recursion in functions
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002224 if (!Diags.isIgnored(diag::warn_infinite_recursive_function,
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002225 D->getBeginLoc())) {
Richard Trieu2f024f42013-12-21 02:33:43 +00002226 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
2227 checkRecursiveFunction(S, FD, Body, AC);
2228 }
2229 }
2230
Erich Keane89fe9c22017-06-23 20:22:19 +00002231 // Check for throw out of non-throwing function.
Stephen Kellyf2ceec42018-08-09 21:08:08 +00002232 if (!Diags.isIgnored(diag::warn_throw_in_noexcept_func, D->getBeginLoc()))
Erich Keane89fe9c22017-06-23 20:22:19 +00002233 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D))
2234 if (S.getLangOpts().CPlusPlus && isNoexcept(FD))
2235 checkThrowInNonThrowingFunc(S, FD, AC);
2236
Richard Trieue9fa2662014-04-15 00:57:50 +00002237 // If none of the previous checks caused a CFG build, trigger one here
Richard Trieu8b0d14a2019-10-19 00:57:23 +00002238 // for the logical error handler.
2239 if (LogicalErrorHandler::hasActiveDiagnostics(Diags, D->getBeginLoc())) {
Richard Trieue9fa2662014-04-15 00:57:50 +00002240 AC.getCFG();
2241 }
2242
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002243 // Collect statistics about the CFG if it was built.
2244 if (S.CollectStats && AC.isCFGBuilt()) {
2245 ++NumFunctionsAnalyzed;
2246 if (CFG *cfg = AC.getCFG()) {
2247 // If we successfully built a CFG for this context, record some more
2248 // detail information about it.
Chandler Carruth50020d92011-07-06 22:21:45 +00002249 NumCFGBlocks += cfg->getNumBlockIDs();
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002250 MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
Chandler Carruth50020d92011-07-06 22:21:45 +00002251 cfg->getNumBlockIDs());
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002252 } else {
2253 ++NumFunctionsWithBadCFGs;
2254 }
2255 }
2256}
2257
2258void clang::sema::AnalysisBasedWarnings::PrintStats() const {
2259 llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
2260
2261 unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
2262 unsigned AvgCFGBlocksPerFunction =
2263 !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
2264 llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
2265 << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
2266 << " " << NumCFGBlocks << " CFG blocks built.\n"
2267 << " " << AvgCFGBlocksPerFunction
2268 << " average CFG blocks per function.\n"
2269 << " " << MaxCFGBlocksPerFunction
2270 << " max CFG blocks per function.\n";
2271
2272 unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
2273 : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
2274 unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
2275 : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
2276 llvm::errs() << NumUninitAnalysisFunctions
2277 << " functions analyzed for uninitialiazed variables\n"
2278 << " " << NumUninitAnalysisVariables << " variables analyzed.\n"
2279 << " " << AvgUninitVariablesPerFunction
2280 << " average variables per function.\n"
2281 << " " << MaxUninitAnalysisVariablesPerFunction
2282 << " max variables per function.\n"
2283 << " " << NumUninitAnalysisBlockVisits << " block visits.\n"
2284 << " " << AvgUninitBlockVisitsPerFunction
2285 << " average block visits per function.\n"
2286 << " " << MaxUninitAnalysisBlockVisitsPerFunction
2287 << " max block visits per function.\n";
Ted Kremenek918fe842010-03-20 21:06:02 +00002288}