blob: d632aae4f71e6bc556e9c8091dd859b51f7da7df [file] [log] [blame]
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +00001//===- unittest/Format/FormatTestJS.cpp - Formatting unit tests for JS ----===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000010#include "FormatTestUtils.h"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000011#include "clang/Format/Format.h"
12#include "llvm/Support/Debug.h"
13#include "gtest/gtest.h"
14
Chandler Carruth10346662014-04-22 03:17:02 +000015#define DEBUG_TYPE "format-test"
16
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000017namespace clang {
18namespace format {
19
20class FormatTestJS : public ::testing::Test {
21protected:
22 static std::string format(llvm::StringRef Code, unsigned Offset,
23 unsigned Length, const FormatStyle &Style) {
24 DEBUG(llvm::errs() << "---\n");
25 DEBUG(llvm::errs() << Code << "\n\n");
26 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
Krasimir Georgievbcda54b2017-04-21 14:35:20 +000027 FormattingAttemptStatus Status;
Daniel Jasper56691b82015-06-11 13:29:20 +000028 tooling::Replacements Replaces =
Krasimir Georgievbcda54b2017-04-21 14:35:20 +000029 reformat(Style, Code, Ranges, "<stdin>", &Status);
30 EXPECT_TRUE(Status.FormatComplete);
Eric Liu4f8d9942016-07-11 13:53:12 +000031 auto Result = applyAllReplacements(Code, Replaces);
32 EXPECT_TRUE(static_cast<bool>(Result));
33 DEBUG(llvm::errs() << "\n" << *Result << "\n\n");
34 return *Result;
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000035 }
36
Daniel Jasper069e5f42014-05-20 11:14:57 +000037 static std::string format(
38 llvm::StringRef Code,
39 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000040 return format(Code, 0, Code.size(), Style);
41 }
42
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000043 static FormatStyle getGoogleJSStyleWithColumns(unsigned ColumnLimit) {
Nico Weber514ecc82014-02-02 20:50:45 +000044 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000045 Style.ColumnLimit = ColumnLimit;
46 return Style;
47 }
48
Nico Weber514ecc82014-02-02 20:50:45 +000049 static void verifyFormat(
50 llvm::StringRef Code,
51 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +000052 std::string Result = format(test::messUp(Code), Style);
53 EXPECT_EQ(Code.str(), Result) << "Formatted:\n" << Result;
54 }
55
56 static void verifyFormat(
57 llvm::StringRef Expected,
58 llvm::StringRef Code,
59 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
60 std::string Result = format(Code, Style);
61 EXPECT_EQ(Expected.str(), Result) << "Formatted:\n" << Result;
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000062 }
63};
64
Daniel Jaspere77f19c2016-05-29 22:07:22 +000065TEST_F(FormatTestJS, BlockComments) {
66 verifyFormat("/* aaaaaaaaaaaaa */ aaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
67 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
68}
69
Krasimir Georgiev22d7e6b2017-07-20 22:29:39 +000070TEST_F(FormatTestJS, JSDocComments) {
71 // Break the first line of a multiline jsdoc comment.
72 EXPECT_EQ("/**\n"
73 " * jsdoc line 1\n"
74 " * jsdoc line 2\n"
75 " */",
76 format("/** jsdoc line 1\n"
77 " * jsdoc line 2\n"
78 " */",
79 getGoogleJSStyleWithColumns(20)));
80 // Both break after '/**' and break the line itself.
81 EXPECT_EQ("/**\n"
82 " * jsdoc line long\n"
83 " * long jsdoc line 2\n"
84 " */",
85 format("/** jsdoc line long long\n"
86 " * jsdoc line 2\n"
87 " */",
88 getGoogleJSStyleWithColumns(20)));
89 // Break a short first line if the ending '*/' is on a newline.
90 EXPECT_EQ("/**\n"
91 " * jsdoc line 1\n"
92 " */",
93 format("/** jsdoc line 1\n"
94 " */", getGoogleJSStyleWithColumns(20)));
95 // Don't break the first line of a short single line jsdoc comment.
96 EXPECT_EQ("/** jsdoc line 1 */",
97 format("/** jsdoc line 1 */", getGoogleJSStyleWithColumns(20)));
98 // Don't break the first line of a single line jsdoc comment if it just fits
99 // the column limit.
100 EXPECT_EQ("/** jsdoc line 12 */",
101 format("/** jsdoc line 12 */", getGoogleJSStyleWithColumns(20)));
102 // Don't break after '/**' and before '*/' if there is no space between
103 // '/**' and the content.
104 EXPECT_EQ(
105 "/*** nonjsdoc long\n"
106 " * line */",
107 format("/*** nonjsdoc long line */", getGoogleJSStyleWithColumns(20)));
108 EXPECT_EQ(
109 "/**strange long long\n"
110 " * line */",
111 format("/**strange long long line */", getGoogleJSStyleWithColumns(20)));
112 // Break the first line of a single line jsdoc comment if it just exceeds the
113 // column limit.
114 EXPECT_EQ("/**\n"
115 " * jsdoc line 123\n"
116 " */",
117 format("/** jsdoc line 123 */", getGoogleJSStyleWithColumns(20)));
118 // Break also if the leading indent of the first line is more than 1 column.
119 EXPECT_EQ("/**\n"
120 " * jsdoc line 123\n"
121 " */",
122 format("/** jsdoc line 123 */", getGoogleJSStyleWithColumns(20)));
123 // Break also if the leading indent of the first line is more than 1 column.
124 EXPECT_EQ("/**\n"
125 " * jsdoc line 123\n"
126 " */",
127 format("/** jsdoc line 123 */", getGoogleJSStyleWithColumns(20)));
128 // Break after the content of the last line.
129 EXPECT_EQ("/**\n"
130 " * line 1\n"
131 " * line 2\n"
132 " */",
133 format("/**\n"
134 " * line 1\n"
135 " * line 2 */",
136 getGoogleJSStyleWithColumns(20)));
137 // Break both the content and after the content of the last line.
138 EXPECT_EQ("/**\n"
139 " * line 1\n"
140 " * line long long\n"
141 " * long\n"
142 " */",
143 format("/**\n"
144 " * line 1\n"
145 " * line long long long */",
146 getGoogleJSStyleWithColumns(20)));
147
148 // The comment block gets indented.
149 EXPECT_EQ("function f() {\n"
150 " /**\n"
151 " * comment about\n"
152 " * x\n"
153 " */\n"
154 " var x = 1;\n"
155 "}",
156 format("function f() {\n"
157 "/** comment about x */\n"
158 "var x = 1;\n"
159 "}",
160 getGoogleJSStyleWithColumns(20)));
Krasimir Georgiev3b865342017-08-09 09:42:32 +0000161
162 // Don't break the first line of a single line short jsdoc comment pragma.
163 EXPECT_EQ("/** @returns j */",
164 format("/** @returns j */",
165 getGoogleJSStyleWithColumns(20)));
166
167 // Break a single line long jsdoc comment pragma.
168 EXPECT_EQ("/**\n"
169 " * @returns {string} jsdoc line 12\n"
170 " */",
171 format("/** @returns {string} jsdoc line 12 */",
172 getGoogleJSStyleWithColumns(20)));
173
174 EXPECT_EQ("/**\n"
175 " * @returns {string} jsdoc line 12\n"
176 " */",
177 format("/** @returns {string} jsdoc line 12 */",
178 getGoogleJSStyleWithColumns(20)));
179
180 EXPECT_EQ("/**\n"
181 " * @returns {string} jsdoc line 12\n"
182 " */",
183 format("/** @returns {string} jsdoc line 12*/",
184 getGoogleJSStyleWithColumns(20)));
185
186 // Fix a multiline jsdoc comment ending in a comment pragma.
187 EXPECT_EQ("/**\n"
188 " * line 1\n"
189 " * line 2\n"
190 " * @returns {string} jsdoc line 12\n"
191 " */",
192 format("/** line 1\n"
193 " * line 2\n"
194 " * @returns {string} jsdoc line 12 */",
195 getGoogleJSStyleWithColumns(20)));
196
197 EXPECT_EQ("/**\n"
198 " * line 1\n"
199 " * line 2\n"
200 " *\n"
201 " * @returns j\n"
202 " */",
203 format("/** line 1\n"
204 " * line 2\n"
205 " *\n"
206 " * @returns j */",
207 getGoogleJSStyleWithColumns(20)));
Krasimir Georgiev22d7e6b2017-07-20 22:29:39 +0000208}
209
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000210TEST_F(FormatTestJS, UnderstandsJavaScriptOperators) {
211 verifyFormat("a == = b;");
212 verifyFormat("a != = b;");
213
214 verifyFormat("a === b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000215 verifyFormat("aaaaaaa ===\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000216 verifyFormat("a !== b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000217 verifyFormat("aaaaaaa !==\n b;", getGoogleJSStyleWithColumns(10));
218 verifyFormat("if (a + b + c +\n"
219 " d !==\n"
220 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000221 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +0000222 getGoogleJSStyleWithColumns(20));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000223
224 verifyFormat("a >> >= b;");
225
226 verifyFormat("a >>> b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000227 verifyFormat("aaaaaaa >>>\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000228 verifyFormat("a >>>= b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000229 verifyFormat("aaaaaaa >>>=\n b;", getGoogleJSStyleWithColumns(10));
230 verifyFormat("if (a + b + c +\n"
231 " d >>>\n"
232 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000233 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +0000234 getGoogleJSStyleWithColumns(20));
Daniel Jaspere551bb72014-11-05 17:22:31 +0000235 verifyFormat("var x = aaaaaaaaaa ?\n"
Daniel Jasper41a2bf72015-12-21 13:52:19 +0000236 " bbbbbb :\n"
237 " ccc;",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +0000238 getGoogleJSStyleWithColumns(20));
Daniel Jasper78214392014-05-19 07:27:02 +0000239
240 verifyFormat("var b = a.map((x) => x + 1);");
Daniel Jasper3549ea12014-09-19 10:48:15 +0000241 verifyFormat("return ('aaa') in bbbb;");
Daniel Jasper1ce41112016-02-01 11:20:47 +0000242 verifyFormat("var x = aaaaaaaaaaaaaaaaaaaaaaaaa() in\n"
243 " aaaa.aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
244 FormatStyle Style = getGoogleJSStyleWithColumns(80);
245 Style.AlignOperands = true;
246 verifyFormat("var x = aaaaaaaaaaaaaaaaaaaaaaaaa() in\n"
247 " aaaa.aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
248 Style);
249 Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All;
250 verifyFormat("var x = aaaaaaaaaaaaaaaaaaaaaaaaa()\n"
251 " in aaaa.aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
252 Style);
Daniel Jasper08051992015-05-26 07:18:56 +0000253
254 // ES6 spread operator.
255 verifyFormat("someFunction(...a);");
256 verifyFormat("var x = [1, ...a, 2];");
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000257}
258
Daniel Jasper3a038de2014-09-05 08:53:45 +0000259TEST_F(FormatTestJS, UnderstandsAmpAmp) {
260 verifyFormat("e && e.SomeFunction();");
261}
262
Daniel Jasper4db69bd2014-09-04 18:23:42 +0000263TEST_F(FormatTestJS, LiteralOperatorsCanBeKeywords) {
264 verifyFormat("not.and.or.not_eq = 1;");
265}
266
Daniel Jasperba52fcb2015-09-28 14:29:45 +0000267TEST_F(FormatTestJS, ReservedWords) {
268 // JavaScript reserved words (aka keywords) are only illegal when used as
269 // Identifiers, but are legal as IdentifierNames.
270 verifyFormat("x.class.struct = 1;");
271 verifyFormat("x.case = 1;");
272 verifyFormat("x.interface = 1;");
Daniel Jasper997cf2f2016-05-20 06:16:01 +0000273 verifyFormat("x.for = 1;");
Martin Probst83e02202017-08-14 16:08:16 +0000274 verifyFormat("x.of();");
Martin Probstc4a3d082017-04-05 10:56:07 +0000275 verifyFormat("of(null);");
276 verifyFormat("import {of} from 'x';");
Martin Probst83e02202017-08-14 16:08:16 +0000277 verifyFormat("x.in();");
278 verifyFormat("x.let();");
279 verifyFormat("x.var();");
280 verifyFormat("x.for();");
281 verifyFormat("x.as();");
282 verifyFormat("x.instanceof();");
283 verifyFormat("x.switch();");
284 verifyFormat("x.case();");
285 verifyFormat("x.delete();");
286 verifyFormat("x.throw();");
287 verifyFormat("x.throws();");
288 verifyFormat("x.if();");
Daniel Jasperba52fcb2015-09-28 14:29:45 +0000289 verifyFormat("x = {\n"
290 " a: 12,\n"
291 " interface: 1,\n"
292 " switch: 1,\n"
293 "};");
Daniel Jasper09840ef2015-11-20 15:58:50 +0000294 verifyFormat("var struct = 2;");
295 verifyFormat("var union = 2;");
Martin Probst1e8261e2016-04-19 18:18:59 +0000296 verifyFormat("var interface = 2;");
297 verifyFormat("interface = 2;");
298 verifyFormat("x = interface instanceof y;");
Martin Probstf785fd92017-08-04 17:07:15 +0000299 verifyFormat("interface Test {\n"
300 " x: string;\n"
301 " switch: string;\n"
302 " case: string;\n"
303 " default: string;\n"
304 "}\n");
Daniel Jasperba52fcb2015-09-28 14:29:45 +0000305}
306
Martin Probst4210d2f2016-09-22 07:18:00 +0000307TEST_F(FormatTestJS, ReservedWordsMethods) {
308 verifyFormat(
309 "class X {\n"
310 " delete() {\n"
311 " x();\n"
312 " }\n"
313 " interface() {\n"
314 " x();\n"
315 " }\n"
316 " let() {\n"
317 " x();\n"
318 " }\n"
319 "}\n");
320}
321
Martin Probst22e00f02017-08-01 17:22:15 +0000322TEST_F(FormatTestJS, ReservedWordsParenthesized) {
323 // All of these are statements using the keyword, not function calls.
324 verifyFormat("throw (x + y);\n"
325 "await (await x).y;\n"
Martin Probst9926abb2017-08-01 17:42:16 +0000326 "typeof (x) === 'string';\n"
Martin Probst22e00f02017-08-01 17:22:15 +0000327 "void (0);\n"
328 "delete (x.y);\n"
329 "return (x);\n");
330}
331
Daniel Jasper72a1b6a2015-12-22 15:47:56 +0000332TEST_F(FormatTestJS, CppKeywords) {
333 // Make sure we don't mess stuff up because of C++ keywords.
334 verifyFormat("return operator && (aa);");
Daniel Jasper72b33572017-03-31 12:04:37 +0000335 // .. or QT ones.
336 verifyFormat("slots: Slot[];");
Daniel Jasper72a1b6a2015-12-22 15:47:56 +0000337}
338
Daniel Jasper0dd52912014-05-19 07:37:07 +0000339TEST_F(FormatTestJS, ES6DestructuringAssignment) {
340 verifyFormat("var [a, b, c] = [1, 2, 3];");
Daniel Jasper5dbcd3b2016-05-19 07:18:07 +0000341 verifyFormat("const [a, b, c] = [1, 2, 3];");
Daniel Jasper9f642f72015-09-28 14:28:08 +0000342 verifyFormat("let [a, b, c] = [1, 2, 3];");
Daniel Jasper60948b12015-03-15 13:55:54 +0000343 verifyFormat("var {a, b} = {a: 1, b: 2};");
Daniel Jasper9f642f72015-09-28 14:28:08 +0000344 verifyFormat("let {a, b} = {a: 1, b: 2};");
Daniel Jasper0dd52912014-05-19 07:37:07 +0000345}
346
Daniel Jasper17062ff2014-06-10 14:44:02 +0000347TEST_F(FormatTestJS, ContainerLiterals) {
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000348 verifyFormat("var x = {\n"
349 " y: function(a) {\n"
350 " return a;\n"
351 " }\n"
352 "};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000353 verifyFormat("return {\n"
354 " link: function() {\n"
355 " f(); //\n"
356 " }\n"
357 "};");
358 verifyFormat("return {\n"
359 " a: a,\n"
360 " link: function() {\n"
361 " f(); //\n"
362 " }\n"
363 "};");
364 verifyFormat("return {\n"
365 " a: a,\n"
Daniel Jasper90ebc982014-09-05 09:27:38 +0000366 " link: function() {\n"
367 " f(); //\n"
368 " },\n"
369 " link: function() {\n"
370 " f(); //\n"
371 " }\n"
Daniel Jasper17062ff2014-06-10 14:44:02 +0000372 "};");
Daniel Jasper94e11d02014-09-04 14:58:30 +0000373 verifyFormat("var stuff = {\n"
374 " // comment for update\n"
375 " update: false,\n"
376 " // comment for modules\n"
377 " modules: false,\n"
378 " // comment for tasks\n"
379 " tasks: false\n"
380 "};");
Daniel Jasper97bfb7b2014-09-05 08:29:31 +0000381 verifyFormat("return {\n"
382 " 'finish':\n"
383 " //\n"
384 " a\n"
385 "};");
Daniel Jasper40874322014-11-27 15:24:48 +0000386 verifyFormat("var obj = {\n"
387 " fooooooooo: function(x) {\n"
388 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
389 " }\n"
390 "};");
Daniel Jasper60948b12015-03-15 13:55:54 +0000391 // Simple object literal, as opposed to enum style below.
392 verifyFormat("var obj = {a: 123};");
393 // Enum style top level assignment.
394 verifyFormat("X = {\n a: 123\n};");
395 verifyFormat("X.Y = {\n a: 123\n};");
Daniel Jasper11ca2632015-06-10 09:21:09 +0000396 // But only on the top level, otherwise its a plain object literal assignment.
397 verifyFormat("function x() {\n"
398 " y = {z: 1};\n"
399 "}");
Daniel Jasper60948b12015-03-15 13:55:54 +0000400 verifyFormat("x = foo && {a: 123};");
Manuel Klimek79e06082015-05-21 12:23:34 +0000401
402 // Arrow functions in object literals.
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000403 verifyFormat("var x = {\n"
404 " y: (a) => {\n"
405 " return a;\n"
406 " }\n"
407 "};");
Manuel Klimek79e06082015-05-21 12:23:34 +0000408 verifyFormat("var x = {y: (a) => a};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000409
Martin Probst8e3eba02017-02-07 16:33:13 +0000410 // Methods in object literals.
411 verifyFormat("var x = {\n"
412 " y(a: string): number {\n"
413 " return a;\n"
414 " }\n"
415 "};");
416 verifyFormat("var x = {\n"
417 " y(a: string) {\n"
418 " return a;\n"
419 " }\n"
420 "};");
421
Daniel Jasper8c42d442015-05-29 06:19:49 +0000422 // Computed keys.
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000423 verifyFormat("var x = {[a]: 1, b: 2, [c]: 3};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000424 verifyFormat("var x = {\n"
425 " [a]: 1,\n"
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000426 " b: 2,\n"
427 " [c]: 3,\n"
Daniel Jasper8c42d442015-05-29 06:19:49 +0000428 "};");
Daniel Jasper9f4c9d42016-02-07 22:17:13 +0000429
430 // Object literals can leave out labels.
431 verifyFormat("f({a}, () => {\n"
432 " g(); //\n"
433 "});");
Daniel Jasperb18425b2016-03-01 04:19:47 +0000434
435 // Keys can be quoted.
436 verifyFormat("var x = {\n"
437 " a: a,\n"
438 " b: b,\n"
439 " 'c': c,\n"
440 "};");
Daniel Jaspere98e5812016-11-29 09:40:36 +0000441
442 // Dict literals can skip the label names.
443 verifyFormat("var x = {\n"
444 " aaa,\n"
445 " aaa,\n"
446 " aaa,\n"
447 "};");
Daniel Jasper893b8ad2017-03-01 19:47:28 +0000448 verifyFormat("return {\n"
449 " a,\n"
450 " b: 'b',\n"
451 " c,\n"
452 "};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000453}
454
Daniel Jasperf46dec82015-03-31 14:34:15 +0000455TEST_F(FormatTestJS, MethodsInObjectLiterals) {
456 verifyFormat("var o = {\n"
457 " value: 'test',\n"
458 " get value() { // getter\n"
459 " return this.value;\n"
460 " }\n"
461 "};");
462 verifyFormat("var o = {\n"
463 " value: 'test',\n"
464 " set value(val) { // setter\n"
465 " this.value = val;\n"
466 " }\n"
467 "};");
468 verifyFormat("var o = {\n"
469 " value: 'test',\n"
470 " someMethod(val) { // method\n"
471 " doSomething(this.value + val);\n"
472 " }\n"
473 "};");
Daniel Jasper739ec532015-04-04 07:56:55 +0000474 verifyFormat("var o = {\n"
475 " someMethod(val) { // method\n"
476 " doSomething(this.value + val);\n"
477 " },\n"
478 " someOtherMethod(val) { // method\n"
479 " doSomething(this.value + val);\n"
480 " }\n"
481 "};");
Daniel Jasperf46dec82015-03-31 14:34:15 +0000482}
483
Martin Probst19c7de02017-04-26 12:34:15 +0000484TEST_F(FormatTestJS, GettersSettersVisibilityKeywords) {
485 // Don't break after "protected"
486 verifyFormat("class X {\n"
487 " protected get getter():\n"
488 " number {\n"
489 " return 1;\n"
490 " }\n"
491 "}",
492 getGoogleJSStyleWithColumns(12));
493 // Don't break after "get"
494 verifyFormat("class X {\n"
495 " protected get someReallyLongGetterName():\n"
496 " number {\n"
497 " return 1;\n"
498 " }\n"
499 "}",
500 getGoogleJSStyleWithColumns(40));
501}
502
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000503TEST_F(FormatTestJS, SpacesInContainerLiterals) {
504 verifyFormat("var arr = [1, 2, 3];");
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000505 verifyFormat("f({a: 1, b: 2, c: 3});");
Nico Weber514ecc82014-02-02 20:50:45 +0000506
Daniel Jasper2a958322014-05-21 13:26:58 +0000507 verifyFormat("var object_literal_with_long_name = {\n"
508 " a: 'aaaaaaaaaaaaaaaaaa',\n"
509 " b: 'bbbbbbbbbbbbbbbbbb'\n"
510 "};");
511
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000512 verifyFormat("f({a: 1, b: 2, c: 3});",
Nico Weber514ecc82014-02-02 20:50:45 +0000513 getChromiumStyle(FormatStyle::LK_JavaScript));
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000514 verifyFormat("f({'a': [{}]});");
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000515}
516
Daniel Jasperabd1f572016-03-02 22:44:03 +0000517TEST_F(FormatTestJS, SingleQuotedStrings) {
Daniel Jasper86fee2f2014-01-31 12:49:42 +0000518 verifyFormat("this.function('', true);");
519}
520
Daniel Jasper4a39c842014-05-06 13:54:10 +0000521TEST_F(FormatTestJS, GoogScopes) {
522 verifyFormat("goog.scope(function() {\n"
523 "var x = a.b;\n"
524 "var y = c.d;\n"
525 "}); // goog.scope");
Daniel Jasper02c7bca2015-03-30 09:56:50 +0000526 verifyFormat("goog.scope(function() {\n"
527 "// test\n"
528 "var x = 0;\n"
529 "// test\n"
530 "});");
Daniel Jasper4a39c842014-05-06 13:54:10 +0000531}
532
Martin Probst101ec892017-05-09 20:04:09 +0000533TEST_F(FormatTestJS, IIFEs) {
534 // Internal calling parens; no semi.
535 verifyFormat("(function() {\n"
536 "var a = 1;\n"
537 "}())");
538 // External calling parens; no semi.
539 verifyFormat("(function() {\n"
540 "var b = 2;\n"
541 "})()");
542 // Internal calling parens; with semi.
543 verifyFormat("(function() {\n"
544 "var c = 3;\n"
545 "}());");
546 // External calling parens; with semi.
547 verifyFormat("(function() {\n"
548 "var d = 4;\n"
549 "})();");
550}
551
Daniel Jasper616de8642014-11-23 16:46:28 +0000552TEST_F(FormatTestJS, GoogModules) {
553 verifyFormat("goog.module('this.is.really.absurdly.long');",
554 getGoogleJSStyleWithColumns(40));
555 verifyFormat("goog.require('this.is.really.absurdly.long');",
556 getGoogleJSStyleWithColumns(40));
557 verifyFormat("goog.provide('this.is.really.absurdly.long');",
558 getGoogleJSStyleWithColumns(40));
559 verifyFormat("var long = goog.require('this.is.really.absurdly.long');",
560 getGoogleJSStyleWithColumns(40));
Daniel Jasperb488a742015-10-29 19:05:20 +0000561 verifyFormat("goog.setTestOnly('this.is.really.absurdly.long');",
562 getGoogleJSStyleWithColumns(40));
Daniel Jasper02cbeb22016-02-22 15:06:53 +0000563 verifyFormat("goog.forwardDeclare('this.is.really.absurdly.long');",
564 getGoogleJSStyleWithColumns(40));
Daniel Jasper53c38f42014-11-27 14:46:03 +0000565
566 // These should be wrapped normally.
567 verifyFormat(
568 "var MyLongClassName =\n"
569 " goog.module.get('my.long.module.name.followedBy.MyLongClassName');");
Daniel Jasper616de8642014-11-23 16:46:28 +0000570}
571
Martin Probstece8c0c2016-06-13 16:41:28 +0000572TEST_F(FormatTestJS, FormatsNamespaces) {
573 verifyFormat("namespace Foo {\n"
574 " export let x = 1;\n"
575 "}\n");
576 verifyFormat("declare namespace Foo {\n"
577 " export let x: number;\n"
578 "}\n");
579}
580
Martin Probst72fd75a2016-11-10 16:20:58 +0000581TEST_F(FormatTestJS, NamespacesMayNotWrap) {
582 verifyFormat("declare namespace foobarbaz {\n"
583 "}\n", getGoogleJSStyleWithColumns(18));
584 verifyFormat("declare module foobarbaz {\n"
585 "}\n", getGoogleJSStyleWithColumns(15));
586 verifyFormat("namespace foobarbaz {\n"
587 "}\n", getGoogleJSStyleWithColumns(10));
588 verifyFormat("module foobarbaz {\n"
589 "}\n", getGoogleJSStyleWithColumns(7));
590}
591
592TEST_F(FormatTestJS, AmbientDeclarations) {
593 FormatStyle NineCols = getGoogleJSStyleWithColumns(9);
594 verifyFormat(
595 "declare class\n"
596 " X {}",
597 NineCols);
598 verifyFormat(
599 "declare function\n"
600 "x();", // TODO(martinprobst): should ideally be indented.
601 NineCols);
Martin Probstaf16c502017-01-04 13:36:43 +0000602 verifyFormat("declare function foo();\n"
603 "let x = 1;\n");
604 verifyFormat("declare function foo(): string;\n"
605 "let x = 1;\n");
606 verifyFormat("declare function foo(): {x: number};\n"
607 "let x = 1;\n");
608 verifyFormat("declare class X {}\n"
609 "let x = 1;\n");
610 verifyFormat("declare interface Y {}\n"
611 "let x = 1;\n");
Martin Probst72fd75a2016-11-10 16:20:58 +0000612 verifyFormat(
613 "declare enum X {\n"
614 "}",
615 NineCols);
616 verifyFormat(
617 "declare let\n"
618 " x: number;",
619 NineCols);
620}
621
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000622TEST_F(FormatTestJS, FormatsFreestandingFunctions) {
623 verifyFormat("function outer1(a, b) {\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000624 " function inner1(a, b) {\n"
625 " return a;\n"
626 " }\n"
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000627 " inner1(a, b);\n"
628 "}\n"
629 "function outer2(a, b) {\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000630 " function inner2(a, b) {\n"
631 " return a;\n"
632 " }\n"
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000633 " inner2(a, b);\n"
634 "}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000635 verifyFormat("function f() {}");
Martin Probstb7fb2672017-05-10 13:53:29 +0000636 verifyFormat("function aFunction() {}\n"
637 "(function f() {\n"
638 " var x = 1;\n"
639 "}());\n");
Martin Probst95ed8e72017-05-31 09:29:40 +0000640 verifyFormat("function aFunction() {}\n"
641 "{\n"
Martin Probstb7fb2672017-05-10 13:53:29 +0000642 " let x = 1;\n"
643 " console.log(x);\n"
644 "}\n");
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000645}
646
Martin Probst5f8445b2016-04-24 22:05:09 +0000647TEST_F(FormatTestJS, GeneratorFunctions) {
648 verifyFormat("function* f() {\n"
649 " let x = 1;\n"
650 " yield x;\n"
651 " yield* something();\n"
Daniel Jaspereb886632016-10-31 13:18:25 +0000652 " yield [1, 2];\n"
653 " yield {a: 1};\n"
Martin Probst5f8445b2016-04-24 22:05:09 +0000654 "}");
655 verifyFormat("function*\n"
656 " f() {\n"
657 "}",
658 getGoogleJSStyleWithColumns(8));
659 verifyFormat("export function* f() {\n"
660 " yield 1;\n"
661 "}\n");
662 verifyFormat("class X {\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000663 " * generatorMethod() {\n"
664 " yield x;\n"
665 " }\n"
Martin Probst5f8445b2016-04-24 22:05:09 +0000666 "}");
Daniel Jasper71e50af2016-11-01 06:22:59 +0000667 verifyFormat("var x = {\n"
668 " a: function*() {\n"
669 " //\n"
670 " }\n"
671 "}\n");
Martin Probst5f8445b2016-04-24 22:05:09 +0000672}
673
674TEST_F(FormatTestJS, AsyncFunctions) {
675 verifyFormat("async function f() {\n"
676 " let x = 1;\n"
677 " return fetch(x);\n"
678 "}");
Martin Probst973ff792017-04-27 13:07:24 +0000679 verifyFormat("async function f() {\n"
680 " return 1;\n"
681 "}\n"
682 "\n"
683 "function a() {\n"
684 " return 1;\n"
685 "}\n",
686 " async function f() {\n"
687 " return 1;\n"
688 "}\n"
689 "\n"
690 " function a() {\n"
691 " return 1;\n"
692 "} \n");
Martin Probst5f8445b2016-04-24 22:05:09 +0000693 verifyFormat("async function* f() {\n"
694 " yield fetch(x);\n"
695 "}");
696 verifyFormat("export async function f() {\n"
697 " return fetch(x);\n"
698 "}");
Martin Probst20371c32017-02-27 11:15:53 +0000699 verifyFormat("let x = async () => f();");
Martin Probst973ff792017-04-27 13:07:24 +0000700 verifyFormat("let x = async function() {\n"
701 " f();\n"
702 "};");
Martin Probst20371c32017-02-27 11:15:53 +0000703 verifyFormat("let x = async();");
Martin Probst5f8445b2016-04-24 22:05:09 +0000704 verifyFormat("class X {\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000705 " async asyncMethod() {\n"
706 " return fetch(1);\n"
707 " }\n"
Martin Probst5f8445b2016-04-24 22:05:09 +0000708 "}");
Martin Probst409697e2016-05-29 14:41:07 +0000709 verifyFormat("function initialize() {\n"
710 " // Comment.\n"
711 " return async.then();\n"
712 "}\n");
Martin Probsta050f412017-05-18 21:19:29 +0000713 verifyFormat("for await (const x of y) {\n"
Martin Probstbd49e322017-05-15 19:33:20 +0000714 " console.log(x);\n"
715 "}\n");
716 verifyFormat("function asyncLoop() {\n"
Martin Probsta050f412017-05-18 21:19:29 +0000717 " for await (const x of y) {\n"
Martin Probstbd49e322017-05-15 19:33:20 +0000718 " console.log(x);\n"
719 " }\n"
720 "}\n");
Martin Probst5f8445b2016-04-24 22:05:09 +0000721}
722
Martin Probst2c1cdae2017-05-15 11:15:29 +0000723TEST_F(FormatTestJS, FunctionParametersTrailingComma) {
724 verifyFormat("function trailingComma(\n"
725 " p1,\n"
726 " p2,\n"
727 " p3,\n"
728 ") {\n"
729 " a; //\n"
730 "}\n",
731 "function trailingComma(p1, p2, p3,) {\n"
732 " a; //\n"
733 "}\n");
734 verifyFormat("trailingComma(\n"
735 " p1,\n"
736 " p2,\n"
737 " p3,\n"
738 ");\n",
739 "trailingComma(p1, p2, p3,);\n");
740 verifyFormat("trailingComma(\n"
741 " p1 // hello\n"
742 ");\n",
743 "trailingComma(p1 // hello\n"
744 ");\n");
745}
746
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000747TEST_F(FormatTestJS, ArrayLiterals) {
Daniel Jaspere6fcf7d2015-06-17 13:08:06 +0000748 verifyFormat("var aaaaa: List<SomeThing> =\n"
749 " [new SomeThingAAAAAAAAAAAA(), new SomeThingBBBBBBBBB()];");
Daniel Jasperd492b5e2015-06-02 21:57:51 +0000750 verifyFormat("return [\n"
Daniel Jasper50780ce2016-01-13 16:41:34 +0000751 " aaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
Daniel Jasperd492b5e2015-06-02 21:57:51 +0000752 " ccccccccccccccccccccccccccc\n"
753 "];");
Daniel Jasper7bec87c2016-01-07 18:11:54 +0000754 verifyFormat("return [\n"
755 " aaaa().bbbbbbbb('A'),\n"
756 " aaaa().bbbbbbbb('B'),\n"
757 " aaaa().bbbbbbbb('C'),\n"
758 "];");
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000759 verifyFormat("var someVariable = SomeFunction([\n"
Daniel Jasper50780ce2016-01-13 16:41:34 +0000760 " aaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
Daniel Jasper5ce80de2015-06-02 13:56:43 +0000761 " ccccccccccccccccccccccccccc\n"
762 "]);");
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000763 verifyFormat("var someVariable = SomeFunction([\n"
Daniel Jasper40432ce2015-06-02 15:04:29 +0000764 " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n"
Daniel Jasper199d0c92015-06-02 15:14:21 +0000765 "]);",
766 getGoogleJSStyleWithColumns(51));
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000767 verifyFormat("var someVariable = SomeFunction(aaaa, [\n"
Daniel Jasper50780ce2016-01-13 16:41:34 +0000768 " aaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
Daniel Jasper4284e362015-06-02 14:20:08 +0000769 " ccccccccccccccccccccccccccc\n"
770 "]);");
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000771 verifyFormat("var someVariable = SomeFunction(\n"
772 " aaaa,\n"
773 " [\n"
Daniel Jasper50780ce2016-01-13 16:41:34 +0000774 " aaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
775 " cccccccccccccccccccccccccc\n"
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000776 " ],\n"
777 " aaaa);");
Daniel Jasperebcb71f2016-01-04 13:11:41 +0000778 verifyFormat("var aaaa = aaaaa || // wrap\n"
779 " [];");
Daniel Jasper1feab0f2015-06-02 15:31:37 +0000780
781 verifyFormat("someFunction([], {a: a});");
Daniel Jasper51c868e2017-01-30 07:08:40 +0000782
783 verifyFormat("var string = [\n"
784 " 'aaaaaa',\n"
785 " 'bbbbbb',\n"
786 "].join('+');");
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000787}
788
Daniel Jaspere2deb592015-12-22 15:48:15 +0000789TEST_F(FormatTestJS, ColumnLayoutForArrayLiterals) {
790 verifyFormat("var array = [\n"
791 " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n"
792 " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n"
793 "];");
794 verifyFormat("var array = someFunction([\n"
795 " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n"
796 " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n"
797 "]);");
798}
799
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000800TEST_F(FormatTestJS, FunctionLiterals) {
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000801 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
802 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline;
Daniel Jasper3f69ba12014-09-05 08:42:27 +0000803 verifyFormat("doFoo(function() {});");
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000804 verifyFormat("doFoo(function() { return 1; });", Style);
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000805 verifyFormat("var func = function() {\n"
806 " return 1;\n"
807 "};");
Daniel Jaspered3f3952015-06-18 12:32:59 +0000808 verifyFormat("var func = //\n"
809 " function() {\n"
810 " return 1;\n"
811 "};");
Daniel Jasperc03e16a2014-05-08 09:25:39 +0000812 verifyFormat("return {\n"
813 " body: {\n"
814 " setAttribute: function(key, val) { this[key] = val; },\n"
815 " getAttribute: function(key) { return this[key]; },\n"
816 " style: {direction: ''}\n"
817 " }\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000818 "};",
819 Style);
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000820 verifyFormat("abc = xyz ? function() {\n"
821 " return 1;\n"
822 "} : function() {\n"
823 " return -1;\n"
824 "};");
Daniel Jasperb16b9692014-05-21 12:51:23 +0000825
826 verifyFormat("var closure = goog.bind(\n"
827 " function() { // comment\n"
828 " foo();\n"
829 " bar();\n"
830 " },\n"
Joerg Sonnenbergere9987a12017-01-05 17:59:44 +0000831 " this, arg1IsReallyLongAndNeedsLineBreaks,\n"
832 " arg3IsReallyLongAndNeedsLineBreaks);");
Daniel Jasperb16b9692014-05-21 12:51:23 +0000833 verifyFormat("var closure = goog.bind(function() { // comment\n"
834 " foo();\n"
835 " bar();\n"
836 "}, this);");
Daniel Jasper58cb2ed2014-06-06 13:49:04 +0000837 verifyFormat("return {\n"
838 " a: 'E',\n"
839 " b: function() {\n"
840 " return function() {\n"
841 " f(); //\n"
842 " };\n"
843 " }\n"
844 "};");
Daniel Jasper41368e92014-11-27 15:37:42 +0000845 verifyFormat("{\n"
846 " var someVariable = function(x) {\n"
847 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
848 " };\n"
849 "}");
Daniel Jasper7325aee2015-05-08 08:38:52 +0000850 verifyFormat("someLooooooooongFunction(\n"
851 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
852 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
853 " function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n"
854 " // code\n"
855 " });");
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000856
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000857 verifyFormat("return {\n"
858 " a: function SomeFunction() {\n"
859 " // ...\n"
860 " return 1;\n"
861 " }\n"
862 "};");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000863 verifyFormat("this.someObject.doSomething(aaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
864 " .then(goog.bind(function(aaaaaaaaaaa) {\n"
865 " someFunction();\n"
866 " someFunction();\n"
867 " }, this), aaaaaaaaaaaaaaaaa);");
868
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000869 verifyFormat("someFunction(goog.bind(function() {\n"
870 " doSomething();\n"
871 " doSomething();\n"
872 "}, this), goog.bind(function() {\n"
873 " doSomething();\n"
874 " doSomething();\n"
875 "}, this));");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000876
Daniel Jasper51c868e2017-01-30 07:08:40 +0000877 verifyFormat("SomeFunction(function() {\n"
878 " foo();\n"
879 " bar();\n"
880 "}.bind(this));");
881
Martin Probstb2f06ea2017-05-29 07:50:52 +0000882 verifyFormat("SomeFunction((function() {\n"
883 " foo();\n"
884 " bar();\n"
885 " }).bind(this));");
886
Daniel Jasper1699eca2015-06-01 09:56:32 +0000887 // FIXME: This is bad, we should be wrapping before "function() {".
888 verifyFormat("someFunction(function() {\n"
889 " doSomething(); // break\n"
890 "})\n"
891 " .doSomethingElse(\n"
892 " // break\n"
Martin Probst2c1cdae2017-05-15 11:15:29 +0000893 " );");
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000894
895 Style.ColumnLimit = 33;
896 verifyFormat("f({a: function() { return 1; }});", Style);
897 Style.ColumnLimit = 32;
898 verifyFormat("f({\n"
899 " a: function() { return 1; }\n"
900 "});",
901 Style);
902
Daniel Jasper79dffb42014-05-07 09:48:30 +0000903}
904
Martin Probstcde98152017-08-01 17:35:57 +0000905TEST_F(FormatTestJS, DontWrapEmptyLiterals) {
906 verifyFormat("(aaaaaaaaaaaaaaaaaaaaa.getData as jasmine.Spy)\n"
907 " .and.returnValue(Observable.of([]));");
908 verifyFormat("(aaaaaaaaaaaaaaaaaaaaa.getData as jasmine.Spy)\n"
909 " .and.returnValue(Observable.of({}));");
910 verifyFormat("(aaaaaaaaaaaaaaaaaaaaa.getData as jasmine.Spy)\n"
911 " .and.returnValue(Observable.of(()));");
912}
913
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000914TEST_F(FormatTestJS, InliningFunctionLiterals) {
915 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
916 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline;
917 verifyFormat("var func = function() {\n"
918 " return 1;\n"
919 "};",
920 Style);
921 verifyFormat("var func = doSomething(function() { return 1; });", Style);
922 verifyFormat("var outer = function() {\n"
923 " var inner = function() { return 1; }\n"
924 "};",
925 Style);
926 verifyFormat("function outer1(a, b) {\n"
927 " function inner1(a, b) { return a; }\n"
928 "}",
929 Style);
930
931 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All;
932 verifyFormat("var func = function() { return 1; };", Style);
933 verifyFormat("var func = doSomething(function() { return 1; });", Style);
934 verifyFormat(
935 "var outer = function() { var inner = function() { return 1; } };",
936 Style);
937 verifyFormat("function outer1(a, b) {\n"
938 " function inner1(a, b) { return a; }\n"
939 "}",
940 Style);
941
942 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;
943 verifyFormat("var func = function() {\n"
944 " return 1;\n"
945 "};",
946 Style);
947 verifyFormat("var func = doSomething(function() {\n"
948 " return 1;\n"
949 "});",
950 Style);
951 verifyFormat("var outer = function() {\n"
952 " var inner = function() {\n"
953 " return 1;\n"
954 " }\n"
955 "};",
956 Style);
957 verifyFormat("function outer1(a, b) {\n"
958 " function inner1(a, b) {\n"
959 " return a;\n"
960 " }\n"
961 "}",
962 Style);
Daniel Jasper71e57452015-11-20 16:44:28 +0000963
964 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Empty;
965 verifyFormat("var func = function() {\n"
966 " return 1;\n"
967 "};",
968 Style);
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000969}
970
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000971TEST_F(FormatTestJS, MultipleFunctionLiterals) {
Daniel Jasper28d8a5a2016-09-07 23:01:13 +0000972 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
973 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All;
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000974 verifyFormat("promise.then(\n"
975 " function success() {\n"
976 " doFoo();\n"
977 " doBar();\n"
978 " },\n"
979 " function error() {\n"
980 " doFoo();\n"
981 " doBaz();\n"
982 " },\n"
983 " []);\n");
984 verifyFormat("promise.then(\n"
985 " function success() {\n"
986 " doFoo();\n"
987 " doBar();\n"
988 " },\n"
989 " [],\n"
990 " function error() {\n"
991 " doFoo();\n"
992 " doBaz();\n"
993 " });\n");
Daniel Jasper6501f7e2015-10-27 12:38:37 +0000994 verifyFormat("promise.then(\n"
995 " [],\n"
996 " function success() {\n"
997 " doFoo();\n"
998 " doBar();\n"
999 " },\n"
1000 " function error() {\n"
1001 " doFoo();\n"
1002 " doBaz();\n"
1003 " });\n");
Daniel Jasper1779d432014-09-29 07:54:54 +00001004
1005 verifyFormat("getSomeLongPromise()\n"
1006 " .then(function(value) { body(); })\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +00001007 " .thenCatch(function(error) {\n"
1008 " body();\n"
1009 " body();\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +00001010 " });",
1011 Style);
Daniel Jasper1779d432014-09-29 07:54:54 +00001012 verifyFormat("getSomeLongPromise()\n"
1013 " .then(function(value) {\n"
1014 " body();\n"
1015 " body();\n"
1016 " })\n"
1017 " .thenCatch(function(error) {\n"
1018 " body();\n"
1019 " body();\n"
1020 " });");
Daniel Jasper11a0ac62014-12-12 09:40:58 +00001021
Daniel Jasperacf67e32015-04-07 08:20:35 +00001022 verifyFormat("getSomeLongPromise()\n"
1023 " .then(function(value) { body(); })\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +00001024 " .thenCatch(function(error) { body(); });",
1025 Style);
Daniel Jasper28024562016-01-11 11:00:58 +00001026
1027 verifyFormat("return [aaaaaaaaaaaaaaaaaaaaaa]\n"
1028 " .aaaaaaa(function() {\n"
1029 " //\n"
1030 " })\n"
1031 " .bbbbbb();");
Daniel Jasper114a2bc2014-06-03 12:02:45 +00001032}
1033
Manuel Klimek79e06082015-05-21 12:23:34 +00001034TEST_F(FormatTestJS, ArrowFunctions) {
1035 verifyFormat("var x = (a) => {\n"
1036 " return a;\n"
1037 "};");
1038 verifyFormat("var x = (a) => {\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +00001039 " function y() {\n"
1040 " return 42;\n"
1041 " }\n"
Manuel Klimek79e06082015-05-21 12:23:34 +00001042 " return a;\n"
1043 "};");
1044 verifyFormat("var x = (a: type): {some: type} => {\n"
1045 " return a;\n"
1046 "};");
1047 verifyFormat("var x = (a) => a;");
Daniel Jaspere497bed2015-06-02 22:06:07 +00001048 verifyFormat("return () => [];");
Daniel Jasper3c306e82015-06-03 17:08:40 +00001049 verifyFormat("var aaaaaaaaaaaaaaaaaaaa = {\n"
1050 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:\n"
1051 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1052 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) =>\n"
Daniel Jasper3b0f3042015-06-05 08:25:37 +00001053 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasper3c306e82015-06-03 17:08:40 +00001054 "};");
Daniel Jasper6501f7e2015-10-27 12:38:37 +00001055 verifyFormat("var a = a.aaaaaaa(\n"
1056 " (a: a) => aaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) &&\n"
Daniel Jasper41a2bf72015-12-21 13:52:19 +00001057 " aaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbb));");
Daniel Jasper6501f7e2015-10-27 12:38:37 +00001058 verifyFormat("var a = a.aaaaaaa(\n"
1059 " (a: a) => aaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) ?\n"
Daniel Jasper41a2bf72015-12-21 13:52:19 +00001060 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb) :\n"
1061 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb));");
Daniel Jasper1699eca2015-06-01 09:56:32 +00001062
1063 // FIXME: This is bad, we should be wrapping before "() => {".
1064 verifyFormat("someFunction(() => {\n"
1065 " doSomething(); // break\n"
1066 "})\n"
1067 " .doSomethingElse(\n"
1068 " // break\n"
Martin Probst2c1cdae2017-05-15 11:15:29 +00001069 " );");
Martin Probstec363262017-08-01 17:19:32 +00001070 verifyFormat("const f = (x: string|null): string|null => {\n"
1071 " return x;\n"
1072 "}\n");
Manuel Klimek79e06082015-05-21 12:23:34 +00001073}
1074
Daniel Jasper166c19b2014-05-06 14:12:21 +00001075TEST_F(FormatTestJS, ReturnStatements) {
Daniel Jasper67f8ad22014-09-30 17:57:06 +00001076 verifyFormat("function() {\n"
1077 " return [hello, world];\n"
1078 "}");
Daniel Jasper166c19b2014-05-06 14:12:21 +00001079}
1080
Daniel Jasperf95b1f42015-11-20 16:18:42 +00001081TEST_F(FormatTestJS, ForLoops) {
1082 verifyFormat("for (var i in [2, 3]) {\n"
1083 "}");
Daniel Jasperb7fda112016-02-11 13:24:15 +00001084 verifyFormat("for (var i of [2, 3]) {\n"
1085 "}");
Daniel Jasperacffeb82016-03-05 18:34:26 +00001086 verifyFormat("for (let {a, b} of x) {\n"
1087 "}");
1088 verifyFormat("for (let {a, b} in x) {\n"
1089 "}");
Daniel Jasperf95b1f42015-11-20 16:18:42 +00001090}
1091
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001092TEST_F(FormatTestJS, WrapRespectsAutomaticSemicolonInsertion) {
Daniel Jasper4c0bf702015-06-12 04:58:27 +00001093 // The following statements must not wrap, as otherwise the program meaning
1094 // would change due to automatic semicolon insertion.
1095 // See http://www.ecma-international.org/ecma-262/5.1/#sec-7.9.1.
1096 verifyFormat("return aaaaa;", getGoogleJSStyleWithColumns(10));
Martin Probst56ff7aa2016-09-06 18:39:30 +00001097 verifyFormat("return /* hello! */ aaaaa;", getGoogleJSStyleWithColumns(10));
Daniel Jasper4c0bf702015-06-12 04:58:27 +00001098 verifyFormat("continue aaaaa;", getGoogleJSStyleWithColumns(10));
Martin Probst56ff7aa2016-09-06 18:39:30 +00001099 verifyFormat("continue /* hello! */ aaaaa;", getGoogleJSStyleWithColumns(10));
Daniel Jasper4c0bf702015-06-12 04:58:27 +00001100 verifyFormat("break aaaaa;", getGoogleJSStyleWithColumns(10));
1101 verifyFormat("throw aaaaa;", getGoogleJSStyleWithColumns(10));
1102 verifyFormat("aaaaaaaaa++;", getGoogleJSStyleWithColumns(10));
1103 verifyFormat("aaaaaaaaa--;", getGoogleJSStyleWithColumns(10));
Daniel Jasper11a87652016-01-14 05:37:52 +00001104 verifyFormat("return [\n"
1105 " aaa\n"
1106 "];",
1107 getGoogleJSStyleWithColumns(12));
Martin Probsta81dd0b2017-07-07 13:17:10 +00001108 verifyFormat("class X {\n"
1109 " readonly ratherLongField =\n"
1110 " 1;\n"
1111 "}",
1112 "class X {\n"
1113 " readonly ratherLongField = 1;\n"
1114 "}",
1115 getGoogleJSStyleWithColumns(20));
Martin Probst0a19d432017-08-09 15:19:16 +00001116 verifyFormat("const x = (5 + 9)\n"
1117 "const y = 3\n",
1118 "const x = ( 5 + 9)\n"
1119 "const y = 3\n");
Daniel Jasper4c0bf702015-06-12 04:58:27 +00001120}
1121
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001122TEST_F(FormatTestJS, AutomaticSemicolonInsertionHeuristic) {
1123 verifyFormat("a\n"
1124 "b;",
1125 " a \n"
1126 " b ;");
1127 verifyFormat("a()\n"
1128 "b;",
1129 " a ()\n"
1130 " b ;");
1131 verifyFormat("a[b]\n"
1132 "c;",
1133 "a [b]\n"
1134 "c ;");
1135 verifyFormat("1\n"
1136 "a;",
1137 "1 \n"
1138 "a ;");
1139 verifyFormat("a\n"
1140 "1;",
1141 "a \n"
1142 "1 ;");
1143 verifyFormat("a\n"
1144 "'x';",
1145 "a \n"
1146 " 'x';");
1147 verifyFormat("a++\n"
1148 "b;",
1149 "a ++\n"
1150 "b ;");
1151 verifyFormat("a\n"
1152 "!b && c;",
1153 "a \n"
1154 " ! b && c;");
1155 verifyFormat("a\n"
1156 "if (1) f();",
1157 " a\n"
1158 " if (1) f();");
1159 verifyFormat("a\n"
1160 "class X {}",
1161 " a\n"
1162 " class X {}");
1163 verifyFormat("var a", "var\n"
1164 "a");
1165 verifyFormat("x instanceof String", "x\n"
1166 "instanceof\n"
1167 "String");
Martin Probstbbffeac2016-04-11 07:35:57 +00001168 verifyFormat("function f(@Foo bar) {}", "function f(@Foo\n"
1169 " bar) {}");
Martin Probstb9316ff2016-09-18 17:21:52 +00001170 verifyFormat("a = true\n"
1171 "return 1",
1172 "a = true\n"
1173 " return 1");
1174 verifyFormat("a = 's'\n"
1175 "return 1",
1176 "a = 's'\n"
1177 " return 1");
1178 verifyFormat("a = null\n"
1179 "return 1",
1180 "a = null\n"
1181 " return 1");
Martin Probste6b5b342017-01-16 09:52:40 +00001182 // Below "class Y {}" should ideally be on its own line.
Martin Probstd40bca42017-01-09 08:56:36 +00001183 verifyFormat(
Martin Probstfd18ec52017-01-09 09:00:58 +00001184 "x = {\n"
1185 " a: 1\n"
Martin Probste6b5b342017-01-16 09:52:40 +00001186 "} class Y {}",
Martin Probstd40bca42017-01-09 08:56:36 +00001187 " x = {a : 1}\n"
1188 " class Y { }");
Martin Probste6b5b342017-01-16 09:52:40 +00001189 verifyFormat(
1190 "if (x) {\n"
1191 "}\n"
1192 "return 1",
1193 "if (x) {}\n"
1194 " return 1");
1195 verifyFormat(
1196 "if (x) {\n"
1197 "}\n"
1198 "class X {}",
1199 "if (x) {}\n"
1200 " class X {}");
Martin Probstd40bca42017-01-09 08:56:36 +00001201}
1202
1203TEST_F(FormatTestJS, ImportExportASI) {
1204 verifyFormat(
1205 "import {x} from 'y'\n"
1206 "export function z() {}",
1207 "import {x} from 'y'\n"
1208 " export function z() {}");
Martin Probste6b5b342017-01-16 09:52:40 +00001209 // Below "class Y {}" should ideally be on its own line.
Martin Probstd40bca42017-01-09 08:56:36 +00001210 verifyFormat(
Martin Probste6b5b342017-01-16 09:52:40 +00001211 "export {x} class Y {}",
Martin Probstd40bca42017-01-09 08:56:36 +00001212 " export {x}\n"
1213 " class Y {\n}");
Martin Probste6b5b342017-01-16 09:52:40 +00001214 verifyFormat(
1215 "if (x) {\n"
1216 "}\n"
1217 "export class Y {}",
1218 "if ( x ) { }\n"
1219 " export class Y {}");
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001220}
1221
Manuel Klimek79e06082015-05-21 12:23:34 +00001222TEST_F(FormatTestJS, ClosureStyleCasts) {
Daniel Jasper484033b2014-05-06 14:41:29 +00001223 verifyFormat("var x = /** @type {foo} */ (bar);");
1224}
1225
Daniel Jasper04a71a42014-05-08 11:58:24 +00001226TEST_F(FormatTestJS, TryCatch) {
1227 verifyFormat("try {\n"
1228 " f();\n"
1229 "} catch (e) {\n"
1230 " g();\n"
1231 "} finally {\n"
1232 " h();\n"
1233 "}");
Daniel Jasper8f2e94c2014-09-04 15:03:34 +00001234
1235 // But, of course, "catch" is a perfectly fine function name in JavaScript.
1236 verifyFormat("someObject.catch();");
Daniel Jasper79121232014-11-27 14:55:17 +00001237 verifyFormat("someObject.new();");
Daniel Jasper04a71a42014-05-08 11:58:24 +00001238}
1239
Daniel Jasper49802ef2014-05-22 09:10:04 +00001240TEST_F(FormatTestJS, StringLiteralConcatenation) {
1241 verifyFormat("var literal = 'hello ' +\n"
Daniel Jasper41a2bf72015-12-21 13:52:19 +00001242 " 'world';");
Daniel Jasper49802ef2014-05-22 09:10:04 +00001243}
1244
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001245TEST_F(FormatTestJS, RegexLiteralClassification) {
1246 // Regex literals.
1247 verifyFormat("var regex = /abc/;");
1248 verifyFormat("f(/abc/);");
1249 verifyFormat("f(abc, /abc/);");
1250 verifyFormat("some_map[/abc/];");
1251 verifyFormat("var x = a ? /abc/ : /abc/;");
1252 verifyFormat("for (var i = 0; /abc/.test(s[i]); i++) {\n}");
1253 verifyFormat("var x = !/abc/.test(y);");
Martin Probst16282992017-02-07 14:08:03 +00001254 verifyFormat("var x = foo()! / 10;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001255 verifyFormat("var x = a && /abc/.test(y);");
1256 verifyFormat("var x = a || /abc/.test(y);");
1257 verifyFormat("var x = a + /abc/.search(y);");
Daniel Jasperc553ae12015-07-02 13:20:45 +00001258 verifyFormat("/abc/.search(y);");
Daniel Jasperf7405c12014-05-08 07:45:18 +00001259 verifyFormat("var regexs = {/abc/, /abc/};");
1260 verifyFormat("return /abc/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001261
1262 // Not regex literals.
1263 verifyFormat("var a = a / 2 + b / 3;");
Daniel Jasper265309e2015-10-18 07:02:28 +00001264 verifyFormat("var a = a++ / 2;");
1265 // Prefix unary can operate on regex literals, not that it makes sense.
1266 verifyFormat("var a = ++/a/;");
1267
1268 // This is a known issue, regular expressions are incorrectly detected if
1269 // directly following a closing parenthesis.
1270 verifyFormat("if (foo) / bar /.exec(baz);");
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001271}
1272
1273TEST_F(FormatTestJS, RegexLiteralSpecialCharacters) {
Daniel Jasper69694b02015-05-08 07:55:13 +00001274 verifyFormat("var regex = /=/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001275 verifyFormat("var regex = /a*/;");
1276 verifyFormat("var regex = /a+/;");
1277 verifyFormat("var regex = /a?/;");
1278 verifyFormat("var regex = /.a./;");
1279 verifyFormat("var regex = /a\\*/;");
1280 verifyFormat("var regex = /^a$/;");
1281 verifyFormat("var regex = /\\/a/;");
1282 verifyFormat("var regex = /(?:x)/;");
1283 verifyFormat("var regex = /x(?=y)/;");
1284 verifyFormat("var regex = /x(?!y)/;");
1285 verifyFormat("var regex = /x|y/;");
1286 verifyFormat("var regex = /a{2}/;");
1287 verifyFormat("var regex = /a{1,3}/;");
Daniel Jasper8d0e2232015-10-12 03:13:48 +00001288
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001289 verifyFormat("var regex = /[abc]/;");
1290 verifyFormat("var regex = /[^abc]/;");
1291 verifyFormat("var regex = /[\\b]/;");
Daniel Jasper8d0e2232015-10-12 03:13:48 +00001292 verifyFormat("var regex = /[/]/;");
1293 verifyFormat("var regex = /[\\/]/;");
1294 verifyFormat("var regex = /\\[/;");
1295 verifyFormat("var regex = /\\\\[/]/;");
Daniel Jasper265309e2015-10-18 07:02:28 +00001296 verifyFormat("var regex = /}[\"]/;");
1297 verifyFormat("var regex = /}[/\"]/;");
1298 verifyFormat("var regex = /}[\"/]/;");
Daniel Jasper8d0e2232015-10-12 03:13:48 +00001299
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001300 verifyFormat("var regex = /\\b/;");
1301 verifyFormat("var regex = /\\B/;");
1302 verifyFormat("var regex = /\\d/;");
1303 verifyFormat("var regex = /\\D/;");
1304 verifyFormat("var regex = /\\f/;");
1305 verifyFormat("var regex = /\\n/;");
1306 verifyFormat("var regex = /\\r/;");
1307 verifyFormat("var regex = /\\s/;");
1308 verifyFormat("var regex = /\\S/;");
1309 verifyFormat("var regex = /\\t/;");
1310 verifyFormat("var regex = /\\v/;");
1311 verifyFormat("var regex = /\\w/;");
1312 verifyFormat("var regex = /\\W/;");
1313 verifyFormat("var regex = /a(a)\\1/;");
1314 verifyFormat("var regex = /\\0/;");
Daniel Jasperfb4333b2014-05-12 11:29:50 +00001315 verifyFormat("var regex = /\\\\/g;");
1316 verifyFormat("var regex = /\\a\\\\/g;");
1317 verifyFormat("var regex = /\a\\//g;");
Daniel Jasper23376252014-09-09 14:37:39 +00001318 verifyFormat("var regex = /a\\//;\n"
1319 "var x = 0;");
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001320 verifyFormat("var regex = /'/g;", "var regex = /'/g ;");
1321 verifyFormat("var regex = /'/g; //'", "var regex = /'/g ; //'");
1322 verifyFormat("var regex = /\\/*/;\n"
1323 "var x = 0;",
1324 "var regex = /\\/*/;\n"
1325 "var x=0;");
1326 verifyFormat("var x = /a\\//;", "var x = /a\\// \n;");
Daniel Jasper6b8d26c2015-06-24 16:01:02 +00001327 verifyFormat("var regex = /\"/;", getGoogleJSStyleWithColumns(16));
1328 verifyFormat("var regex =\n"
1329 " /\"/;",
1330 getGoogleJSStyleWithColumns(15));
Daniel Jasperf7372152015-07-02 14:14:04 +00001331 verifyFormat("var regex = //\n"
1332 " /a/;");
Daniel Jasperf1446202015-07-02 15:00:44 +00001333 verifyFormat("var regexs = [\n"
1334 " /d/, //\n"
1335 " /aa/, //\n"
1336 "];");
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001337}
1338
1339TEST_F(FormatTestJS, RegexLiteralModifiers) {
1340 verifyFormat("var regex = /abc/g;");
1341 verifyFormat("var regex = /abc/i;");
1342 verifyFormat("var regex = /abc/m;");
1343 verifyFormat("var regex = /abc/y;");
1344}
1345
1346TEST_F(FormatTestJS, RegexLiteralLength) {
1347 verifyFormat("var regex = /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
1348 getGoogleJSStyleWithColumns(60));
1349 verifyFormat("var regex =\n"
1350 " /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
1351 getGoogleJSStyleWithColumns(60));
Daniel Jasper0580ff02014-12-17 09:11:08 +00001352 verifyFormat("var regex = /\\xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
1353 getGoogleJSStyleWithColumns(50));
Daniel Jasperf9ae3122014-05-08 07:01:45 +00001354}
1355
1356TEST_F(FormatTestJS, RegexLiteralExamples) {
1357 verifyFormat("var regex = search.match(/(?:\?|&)times=([^?&]+)/i);");
1358}
1359
Martin Probstfa37b182017-01-27 09:09:11 +00001360TEST_F(FormatTestJS, IgnoresMpegTS) {
1361 std::string MpegTS(200, ' ');
1362 MpegTS.replace(0, strlen("nearlyLooks + like + ts + code; "),
1363 "nearlyLooks + like + ts + code; ");
1364 MpegTS[0] = 0x47;
1365 MpegTS[188] = 0x47;
1366 verifyFormat(MpegTS, MpegTS);
1367}
1368
Daniel Jasperb10bdff2015-02-18 17:09:53 +00001369TEST_F(FormatTestJS, TypeAnnotations) {
1370 verifyFormat("var x: string;");
Daniel Jasperb9a49902016-01-09 15:56:28 +00001371 verifyFormat("var x: {a: string; b: number;} = {};");
Daniel Jasperb10bdff2015-02-18 17:09:53 +00001372 verifyFormat("function x(): string {\n return 'x';\n}");
Manuel Klimek79e06082015-05-21 12:23:34 +00001373 verifyFormat("function x(): {x: string} {\n return {x: 'x'};\n}");
Daniel Jasperb10bdff2015-02-18 17:09:53 +00001374 verifyFormat("function x(y: string): string {\n return 'x';\n}");
1375 verifyFormat("for (var y: string in x) {\n x();\n}");
Daniel Jasperb7fda112016-02-11 13:24:15 +00001376 verifyFormat("for (var y: string of x) {\n x();\n}");
Daniel Jasperb9a49902016-01-09 15:56:28 +00001377 verifyFormat("function x(y: {a?: number;} = {}): number {\n"
1378 " return 12;\n"
1379 "}");
Daniel Jasperb10bdff2015-02-18 17:09:53 +00001380 verifyFormat("((a: string, b: number): string => a + b);");
1381 verifyFormat("var x: (y: number) => string;");
1382 verifyFormat("var x: P<string, (a: number) => string>;");
Daniel Jasper28d8a5a2016-09-07 23:01:13 +00001383 verifyFormat("var x = {\n"
1384 " y: function(): z {\n"
1385 " return 1;\n"
1386 " }\n"
1387 "};");
1388 verifyFormat("var x = {\n"
1389 " y: function(): {a: number} {\n"
1390 " return 1;\n"
1391 " }\n"
1392 "};");
Daniel Jasperf412e262016-01-08 10:51:24 +00001393 verifyFormat("function someFunc(args: string[]):\n"
1394 " {longReturnValue: string[]} {}",
1395 getGoogleJSStyleWithColumns(60));
Daniel Jasper3d934d32017-02-20 12:43:41 +00001396 verifyFormat(
1397 "var someValue = (v as aaaaaaaaaaaaaaaaaaaa<T>[])\n"
1398 " .someFunction(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperb10bdff2015-02-18 17:09:53 +00001399}
1400
Daniel Jasper91b1d1a2016-03-21 17:57:31 +00001401TEST_F(FormatTestJS, UnionIntersectionTypes) {
1402 verifyFormat("let x: A|B = A | B;");
1403 verifyFormat("let x: A&B|C = A & B;");
1404 verifyFormat("let x: Foo<A|B> = new Foo<A|B>();");
1405 verifyFormat("function(x: A|B): C&D {}");
1406 verifyFormat("function(x: A|B = A | B): C&D {}");
Martin Probst2ec23242016-06-09 22:49:04 +00001407 verifyFormat("function x(path: number|string) {}");
1408 verifyFormat("function x(): string|number {}");
Martin Probst1b7f9802016-06-23 19:52:32 +00001409 verifyFormat("type Foo = Bar|Baz;");
1410 verifyFormat("type Foo = Bar<X>|Baz;");
1411 verifyFormat("type Foo = (Bar<X>|Baz);");
1412 verifyFormat("let x: Bar|Baz;");
1413 verifyFormat("let x: Bar<X>|Baz;");
1414 verifyFormat("let x: (Foo|Bar)[];");
Martin Probstd96a0522017-06-07 12:53:22 +00001415 verifyFormat("type X = {\n"
1416 " a: Foo|Bar;\n"
1417 "};");
1418 verifyFormat("export type X = {\n"
1419 " a: Foo|Bar;\n"
1420 "};");
Daniel Jasper91b1d1a2016-03-21 17:57:31 +00001421}
1422
Martin Probst0fb46bb2017-08-08 15:00:58 +00001423TEST_F(FormatTestJS, UnionIntersectionTypesInObjectType) {
1424 verifyFormat("let x: {x: number|null} = {x: number | null};");
1425 verifyFormat("let nested: {x: {y: number|null}};");
1426 verifyFormat("let mixed: {x: [number|null, {w: number}]};");
1427 verifyFormat("class X {\n"
1428 " contructor(x: {\n"
1429 " a: a|null,\n"
1430 " b: b|null,\n"
1431 " }) {}\n"
1432 "}");
1433}
1434
Daniel Jasper83709082015-02-18 17:14:05 +00001435TEST_F(FormatTestJS, ClassDeclarations) {
1436 verifyFormat("class C {\n x: string = 12;\n}");
1437 verifyFormat("class C {\n x(): string => 12;\n}");
1438 verifyFormat("class C {\n ['x' + 2]: string = 12;\n}");
Martin Probst95ed8e72017-05-31 09:29:40 +00001439 verifyFormat("class C {\n"
1440 " foo() {}\n"
1441 " [bar]() {}\n"
1442 "}\n");
Daniel Jasper83709082015-02-18 17:14:05 +00001443 verifyFormat("class C {\n private x: string = 12;\n}");
1444 verifyFormat("class C {\n private static x: string = 12;\n}");
Daniel Jasper28d8a5a2016-09-07 23:01:13 +00001445 verifyFormat("class C {\n static x(): string {\n return 'asd';\n }\n}");
Daniel Jasper83709082015-02-18 17:14:05 +00001446 verifyFormat("class C extends P implements I {}");
Daniel Jasper6a5d38d2015-04-13 14:56:54 +00001447 verifyFormat("class C extends p.P implements i.I {}");
Martin Probst1027fb82017-02-07 14:05:30 +00001448 verifyFormat(
1449 "x(class {\n"
1450 " a(): A {}\n"
1451 "});");
Daniel Jasperb9a52812015-07-10 13:39:26 +00001452 verifyFormat("class Test {\n"
1453 " aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa: aaaaaaaaaaaaaaaaaaaa):\n"
1454 " aaaaaaaaaaaaaaaaaaaaaa {}\n"
1455 "}");
Daniel Jasperd5ec65b2016-01-08 07:06:07 +00001456 verifyFormat("foo = class Name {\n"
1457 " constructor() {}\n"
1458 "};");
1459 verifyFormat("foo = class {\n"
1460 " constructor() {}\n"
1461 "};");
Daniel Jasperb9a49902016-01-09 15:56:28 +00001462 verifyFormat("class C {\n"
1463 " x: {y: Z;} = {};\n"
1464 " private y: {y: Z;} = {};\n"
1465 "}");
Daniel Jasper81dbb562015-06-03 08:43:18 +00001466
1467 // ':' is not a type declaration here.
1468 verifyFormat("class X {\n"
1469 " subs = {\n"
1470 " 'b': {\n"
1471 " 'c': 1,\n"
1472 " },\n"
1473 " };\n"
1474 "}");
Daniel Jasper64650082016-06-14 11:28:02 +00001475 verifyFormat("@Component({\n"
1476 " moduleId: module.id,\n"
1477 "})\n"
1478 "class SessionListComponent implements OnDestroy, OnInit {\n"
1479 "}");
Daniel Jasper83709082015-02-18 17:14:05 +00001480}
1481
Daniel Jasper29647492015-05-05 08:12:50 +00001482TEST_F(FormatTestJS, InterfaceDeclarations) {
1483 verifyFormat("interface I {\n"
1484 " x: string;\n"
Daniel Jasper6f5a1932015-12-29 08:54:23 +00001485 " enum: string[];\n"
Daniel Jasper87379302016-02-03 05:33:44 +00001486 " enum?: string[];\n"
Daniel Jasper259188b2015-06-12 04:56:34 +00001487 "}\n"
1488 "var y;");
Daniel Jasper5c235c02015-07-06 14:26:04 +00001489 // Ensure that state is reset after parsing the interface.
1490 verifyFormat("interface a {}\n"
1491 "export function b() {}\n"
1492 "var x;");
Daniel Jasperb542f9f2015-12-22 15:48:35 +00001493
1494 // Arrays of object type literals.
1495 verifyFormat("interface I {\n"
1496 " o: {}[];\n"
1497 "}");
Daniel Jasper29647492015-05-05 08:12:50 +00001498}
1499
Martin Probstcb870c52017-08-01 15:46:10 +00001500TEST_F(FormatTestJS, ObjectTypesInExtendsImplements) {
1501 verifyFormat("class C extends {} {}");
1502 verifyFormat("class C implements {bar: number} {}");
1503 // Somewhat odd, but probably closest to reasonable formatting?
1504 verifyFormat("class C implements {\n"
1505 " bar: number,\n"
1506 " baz: string,\n"
1507 "} {}");
1508 verifyFormat("class C<P extends {}> {}");
1509}
1510
Daniel Jasper90cf3802015-06-17 09:44:02 +00001511TEST_F(FormatTestJS, EnumDeclarations) {
1512 verifyFormat("enum Foo {\n"
Daniel Jasper9f4ec152015-06-17 09:44:07 +00001513 " A = 1,\n"
1514 " B\n"
1515 "}");
1516 verifyFormat("export /* somecomment*/ enum Foo {\n"
1517 " A = 1,\n"
1518 " B\n"
1519 "}");
1520 verifyFormat("enum Foo {\n"
Daniel Jasper90cf3802015-06-17 09:44:02 +00001521 " A = 1, // comment\n"
1522 " B\n"
1523 "}\n"
1524 "var x = 1;");
Martin Probstdb51cc52017-08-01 17:12:15 +00001525 verifyFormat("const enum Foo {\n"
1526 " A = 1,\n"
1527 " B\n"
1528 "}");
1529 verifyFormat("export const enum Foo {\n"
1530 " A = 1,\n"
1531 " B\n"
1532 "}");
Daniel Jasper90cf3802015-06-17 09:44:02 +00001533}
1534
Daniel Jasper3c42dba2015-02-18 17:17:15 +00001535TEST_F(FormatTestJS, MetadataAnnotations) {
1536 verifyFormat("@A\nclass C {\n}");
1537 verifyFormat("@A({arg: 'value'})\nclass C {\n}");
1538 verifyFormat("@A\n@B\nclass C {\n}");
1539 verifyFormat("class C {\n @A x: string;\n}");
1540 verifyFormat("class C {\n"
1541 " @A\n"
1542 " private x(): string {\n"
1543 " return 'y';\n"
1544 " }\n"
1545 "}");
Martin Probst716a5332016-04-11 09:17:57 +00001546 verifyFormat("class C {\n"
1547 " private x(@A x: string) {}\n"
1548 "}");
Daniel Jasper6fa9ec72015-02-19 16:03:16 +00001549 verifyFormat("class X {}\n"
1550 "class Y {}");
Martin Probstad063912017-04-26 12:36:49 +00001551 verifyFormat("class X {\n"
1552 " @property() private isReply = false;\n"
1553 "}\n");
Daniel Jasper3c42dba2015-02-18 17:17:15 +00001554}
1555
Martin Probst805c6162016-04-19 14:59:16 +00001556TEST_F(FormatTestJS, TypeAliases) {
1557 verifyFormat("type X = number;\n"
1558 "class C {}");
1559 verifyFormat("type X<Y> = Z<Y>;");
1560 verifyFormat("type X = {\n"
1561 " y: number\n"
1562 "};\n"
1563 "class C {}");
Martin Probst325ff7c2017-08-14 16:09:08 +00001564 verifyFormat("export type X = {\n"
1565 " a: string,\n"
1566 " b?: string,\n"
1567 "};\n");
Martin Probst805c6162016-04-19 14:59:16 +00001568}
1569
Martin Probstb98ab892017-03-13 07:10:18 +00001570TEST_F(FormatTestJS, TypeInterfaceLineWrapping) {
1571 const FormatStyle &Style = getGoogleJSStyleWithColumns(20);
1572 verifyFormat("type LongTypeIsReallyUnreasonablyLong =\n"
1573 " string;\n",
1574 "type LongTypeIsReallyUnreasonablyLong = string;\n",
1575 Style);
1576 verifyFormat(
1577 "interface AbstractStrategyFactoryProvider {\n"
1578 " a: number\n"
1579 "}\n",
1580 "interface AbstractStrategyFactoryProvider { a: number }\n",
1581 Style);
1582}
1583
Daniel Jasper354aa512015-02-19 16:07:32 +00001584TEST_F(FormatTestJS, Modules) {
1585 verifyFormat("import SomeThing from 'some/module.js';");
1586 verifyFormat("import {X, Y} from 'some/module.js';");
Daniel Jasperefc1a832016-01-07 08:53:35 +00001587 verifyFormat("import a, {X, Y} from 'some/module.js';");
Daniel Jasper8fc7a1e2016-03-22 14:32:20 +00001588 verifyFormat("import {X, Y,} from 'some/module.js';");
Daniel Jasper354aa512015-02-19 16:07:32 +00001589 verifyFormat("import {X as myLocalX, Y as myLocalY} from 'some/module.js';");
Martin Probst48622092016-06-01 15:22:47 +00001590 // Ensure Automatic Semicolon Insertion does not break on "as\n".
1591 verifyFormat("import {X as myX} from 'm';", "import {X as\n"
1592 " myX} from 'm';");
Daniel Jasper354aa512015-02-19 16:07:32 +00001593 verifyFormat("import * as lib from 'some/module.js';");
Daniel Jasper60948b12015-03-15 13:55:54 +00001594 verifyFormat("var x = {import: 1};\nx.import = 2;");
Daniel Jasperfca735c2015-02-19 16:14:18 +00001595
1596 verifyFormat("export function fn() {\n"
1597 " return 'fn';\n"
1598 "}");
Daniel Jasper20580fd2015-06-11 13:31:45 +00001599 verifyFormat("export function A() {}\n"
1600 "export default function B() {}\n"
1601 "export function C() {}");
Martin Probst053f1aa2016-04-19 14:55:37 +00001602 verifyFormat("export default () => {\n"
1603 " let x = 1;\n"
1604 " return x;\n"
1605 "}");
Daniel Jasper354aa512015-02-19 16:07:32 +00001606 verifyFormat("export const x = 12;");
1607 verifyFormat("export default class X {}");
Daniel Jasperfca735c2015-02-19 16:14:18 +00001608 verifyFormat("export {X, Y} from 'some/module.js';");
Daniel Jasper8fc7a1e2016-03-22 14:32:20 +00001609 verifyFormat("export {X, Y,} from 'some/module.js';");
1610 verifyFormat("export {SomeVeryLongExport as X, "
1611 "SomeOtherVeryLongExport as Y} from 'some/module.js';");
1612 // export without 'from' is wrapped.
1613 verifyFormat("export let someRatherLongVariableName =\n"
1614 " someSurprisinglyLongVariable + someOtherRatherLongVar;");
1615 // ... but not if from is just an identifier.
Daniel Jasperfca735c2015-02-19 16:14:18 +00001616 verifyFormat("export {\n"
Daniel Jasper8fc7a1e2016-03-22 14:32:20 +00001617 " from as from,\n"
Martin Probstdce8e412016-06-22 14:35:14 +00001618 " someSurprisinglyLongVariable as\n"
1619 " from\n"
Daniel Jasper8fc7a1e2016-03-22 14:32:20 +00001620 "};",
1621 getGoogleJSStyleWithColumns(20));
Daniel Jasperfca735c2015-02-19 16:14:18 +00001622 verifyFormat("export class C {\n"
1623 " x: number;\n"
1624 " y: string;\n"
1625 "}");
1626 verifyFormat("export class X { y: number; }");
Daniel Jasper8620d4c2016-01-12 06:24:38 +00001627 verifyFormat("export abstract class X { y: number; }");
Daniel Jasperfca735c2015-02-19 16:14:18 +00001628 verifyFormat("export default class X { y: number }");
1629 verifyFormat("export default function() {\n return 1;\n}");
1630 verifyFormat("export var x = 12;");
Daniel Jasper910807d2015-06-12 04:52:02 +00001631 verifyFormat("class C {}\n"
1632 "export function f() {}\n"
1633 "var v;");
Daniel Jasperfca735c2015-02-19 16:14:18 +00001634 verifyFormat("export var x: number = 12;");
1635 verifyFormat("export const y = {\n"
1636 " a: 1,\n"
1637 " b: 2\n"
1638 "};");
Daniel Jasper216c9cd2015-06-12 05:08:18 +00001639 verifyFormat("export enum Foo {\n"
1640 " BAR,\n"
1641 " // adsdasd\n"
1642 " BAZ\n"
1643 "}");
Daniel Jasperb14f6672016-01-04 15:51:56 +00001644 verifyFormat("export default [\n"
1645 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1646 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n"
1647 "];");
1648 verifyFormat("export default [];");
Daniel Jasper5e271462016-01-04 16:10:36 +00001649 verifyFormat("export default () => {};");
Daniel Jasperf55e4182016-01-11 22:57:40 +00001650 verifyFormat("export interface Foo { foo: number; }\n"
1651 "export class Bar {\n"
Daniel Jasper28d8a5a2016-09-07 23:01:13 +00001652 " blah(): string {\n"
1653 " return this.blah;\n"
1654 " };\n"
Daniel Jasperf55e4182016-01-11 22:57:40 +00001655 "}");
Daniel Jasper354aa512015-02-19 16:07:32 +00001656}
1657
Martin Probst0cd74ee2016-06-13 16:39:50 +00001658TEST_F(FormatTestJS, ImportWrapping) {
1659 verifyFormat("import {VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying,"
1660 " VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying"
1661 "} from 'some/module.js';");
1662 FormatStyle Style = getGoogleJSStyleWithColumns(80);
1663 Style.JavaScriptWrapImports = true;
1664 verifyFormat("import {\n"
1665 " VeryLongImportsAreAnnoying,\n"
1666 " VeryLongImportsAreAnnoying,\n"
1667 " VeryLongImportsAreAnnoying,\n"
1668 "} from 'some/module.js';",
1669 Style);
1670 verifyFormat("import {\n"
1671 " A,\n"
1672 " A,\n"
1673 "} from 'some/module.js';",
1674 Style);
1675 verifyFormat("export {\n"
1676 " A,\n"
1677 " A,\n"
1678 "} from 'some/module.js';",
1679 Style);
Martin Probst93008f02017-07-18 14:00:19 +00001680 Style.ColumnLimit = 40;
1681 // Using this version of verifyFormat because test::messUp hides the issue.
1682 verifyFormat("import {\n"
1683 " A,\n"
1684 "} from\n"
1685 " 'some/path/longer/than/column/limit/module.js';",
1686 " import { \n"
1687 " A, \n"
1688 " } from\n"
1689 " 'some/path/longer/than/column/limit/module.js' ; ",
1690 Style);
Martin Probst0cd74ee2016-06-13 16:39:50 +00001691}
1692
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001693TEST_F(FormatTestJS, TemplateStrings) {
1694 // Keeps any whitespace/indentation within the template string.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001695 verifyFormat("var x = `hello\n"
Martin Probst6181da42016-08-25 10:13:21 +00001696 " ${name}\n"
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001697 " !`;",
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001698 "var x = `hello\n"
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001699 " ${ name }\n"
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001700 " !`;");
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001701
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001702 verifyFormat("var x =\n"
1703 " `hello ${world}` >= some();",
1704 getGoogleJSStyleWithColumns(34)); // Barely doesn't fit.
1705 verifyFormat("var x = `hello ${world}` >= some();",
Daniel Jasper553a5b02015-07-02 13:08:28 +00001706 getGoogleJSStyleWithColumns(35)); // Barely fits.
Martin Probste71b4cb2016-05-17 06:29:29 +00001707 verifyFormat("var x = `hellö ${wörld}` >= söme();",
1708 getGoogleJSStyleWithColumns(35)); // Fits due to UTF-8.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001709 verifyFormat("var x = `hello\n"
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001710 " ${world}` >=\n"
Daniel Jasper41a2bf72015-12-21 13:52:19 +00001711 " some();",
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001712 "var x =\n"
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001713 " `hello\n"
1714 " ${world}` >= some();",
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001715 getGoogleJSStyleWithColumns(21)); // Barely doesn't fit.
1716 verifyFormat("var x = `hello\n"
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001717 " ${world}` >= some();",
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001718 "var x =\n"
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001719 " `hello\n"
1720 " ${world}` >= some();",
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001721 getGoogleJSStyleWithColumns(22)); // Barely fits.
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001722
Daniel Jasper553a5b02015-07-02 13:08:28 +00001723 verifyFormat("var x =\n"
1724 " `h`;",
1725 getGoogleJSStyleWithColumns(11));
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001726 verifyFormat("var x =\n `multi\n line`;", "var x = `multi\n line`;",
1727 getGoogleJSStyleWithColumns(13));
Daniel Jasper553a5b02015-07-02 13:08:28 +00001728 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1729 " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`);");
Martin Probste71b4cb2016-05-17 06:29:29 +00001730 // Repro for an obscure width-miscounting issue with template strings.
1731 verifyFormat(
1732 "someLongVariable =\n"
1733 " "
1734 "`${logPrefix[11]}/${logPrefix[12]}/${logPrefix[13]}${logPrefix[14]}`;",
1735 "someLongVariable = "
1736 "`${logPrefix[11]}/${logPrefix[12]}/${logPrefix[13]}${logPrefix[14]}`;");
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001737
Daniel Jasperf69b9222015-05-02 08:05:38 +00001738 // Make sure template strings get a proper ColumnWidth assigned, even if they
1739 // are first token in line.
1740 verifyFormat(
1741 "var a = aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
Daniel Jasper41a2bf72015-12-21 13:52:19 +00001742 " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`;");
Daniel Jasperf69b9222015-05-02 08:05:38 +00001743
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001744 // Two template strings.
1745 verifyFormat("var x = `hello` == `hello`;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +00001746
1747 // Comments in template strings.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001748 verifyFormat("var x = `//a`;\n"
Daniel Jasper0d6ac272015-04-16 08:20:51 +00001749 "var y;",
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001750 "var x =\n `//a`;\n"
1751 "var y ;");
1752 verifyFormat("var x = `/*a`;\n"
1753 "var y;",
1754 "var x =\n `/*a`;\n"
1755 "var y;");
Daniel Jasper2ebb0c52015-06-14 07:16:57 +00001756 // Unterminated string literals in a template string.
1757 verifyFormat("var x = `'`; // comment with matching quote '\n"
1758 "var y;");
1759 verifyFormat("var x = `\"`; // comment with matching quote \"\n"
1760 "var y;");
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001761 verifyFormat("it(`'aaaaaaaaaaaaaaa `, aaaaaaaaa);",
1762 "it(`'aaaaaaaaaaaaaaa `, aaaaaaaaa) ;",
1763 getGoogleJSStyleWithColumns(40));
Daniel Jasper0d6ac272015-04-16 08:20:51 +00001764 // Backticks in a comment - not a template string.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001765 verifyFormat("var x = 1 // `/*a`;\n"
1766 " ;",
1767 "var x =\n 1 // `/*a`;\n"
1768 " ;");
1769 verifyFormat("/* ` */ var x = 1; /* ` */", "/* ` */ var x\n= 1; /* ` */");
Daniel Jasper0d6ac272015-04-16 08:20:51 +00001770 // Comment spans multiple template strings.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001771 verifyFormat("var x = `/*a`;\n"
1772 "var y = ` */ `;",
1773 "var x =\n `/*a`;\n"
1774 "var y =\n ` */ `;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +00001775 // Escaped backtick.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001776 verifyFormat("var x = ` \\` a`;\n"
1777 "var y;",
1778 "var x = ` \\` a`;\n"
1779 "var y;");
Martin Probst6181da42016-08-25 10:13:21 +00001780 // Escaped dollar.
1781 verifyFormat("var x = ` \\${foo}`;\n");
Daniel Jasperf2019292017-01-31 12:07:35 +00001782
1783 // The token stream can contain two string_literals in sequence, but that
1784 // doesn't mean that they are implicitly concatenated in JavaScript.
1785 verifyFormat("var f = `aaaa ${a ? 'a' : 'b'}`;");
Daniel Jasper24de6fb2017-01-31 13:03:07 +00001786
1787 // Ensure that scopes are appropriately set around evaluated expressions in
1788 // template strings.
1789 verifyFormat("var f = `aaaaaaaaaaaaa:${aaaaaaa.aaaaa} aaaaaaaa\n"
1790 " aaaaaaaaaaaaa:${aaaaaaa.aaaaa} aaaaaaaa`;",
1791 "var f = `aaaaaaaaaaaaa:${aaaaaaa. aaaaa} aaaaaaaa\n"
1792 " aaaaaaaaaaaaa:${ aaaaaaa. aaaaa} aaaaaaaa`;");
Daniel Jasperc06f6da2017-02-03 14:32:38 +00001793 verifyFormat("var x = someFunction(`${})`) //\n"
1794 " .oooooooooooooooooon();");
Daniel Jasper98e0b122017-02-20 14:51:16 +00001795 verifyFormat("var x = someFunction(`${aaaa}${\n"
Martin Probstc10d97f2017-08-29 08:30:07 +00001796 " aaaaa( //\n"
1797 " aaaaa)})`);");
Martin Probst6181da42016-08-25 10:13:21 +00001798}
1799
Daniel Jasper3f119412017-01-31 14:39:33 +00001800TEST_F(FormatTestJS, TemplateStringMultiLineExpression) {
Daniel Jasper98e0b122017-02-20 14:51:16 +00001801 verifyFormat("var f = `aaaaaaaaaaaaaaaaaa: ${\n"
Martin Probstc10d97f2017-08-29 08:30:07 +00001802 " aaaaa + //\n"
1803 " bbbb}`;",
Daniel Jasper3f119412017-01-31 14:39:33 +00001804 "var f = `aaaaaaaaaaaaaaaaaa: ${aaaaa + //\n"
1805 " bbbb}`;");
Daniel Jasper3f119412017-01-31 14:39:33 +00001806 verifyFormat("var f = `\n"
Daniel Jasper98e0b122017-02-20 14:51:16 +00001807 " aaaaaaaaaaaaaaaaaa: ${\n"
Martin Probstc10d97f2017-08-29 08:30:07 +00001808 " aaaaa + //\n"
1809 " bbbb}`;",
Daniel Jasper3f119412017-01-31 14:39:33 +00001810 "var f = `\n"
1811 " aaaaaaaaaaaaaaaaaa: ${ aaaaa + //\n"
1812 " bbbb }`;");
1813 verifyFormat("var f = `\n"
Daniel Jasper98e0b122017-02-20 14:51:16 +00001814 " aaaaaaaaaaaaaaaaaa: ${\n"
Martin Probstc10d97f2017-08-29 08:30:07 +00001815 " someFunction(\n"
1816 " aaaaa + //\n"
1817 " bbbb)}`;",
Daniel Jasper3f119412017-01-31 14:39:33 +00001818 "var f = `\n"
Daniel Jasper98e0b122017-02-20 14:51:16 +00001819 " aaaaaaaaaaaaaaaaaa: ${someFunction (\n"
Daniel Jasper3f119412017-01-31 14:39:33 +00001820 " aaaaa + //\n"
1821 " bbbb)}`;");
Daniel Jasper98e0b122017-02-20 14:51:16 +00001822
1823 // It might be preferable to wrap before "someFunction".
Daniel Jasper3f119412017-01-31 14:39:33 +00001824 verifyFormat("var f = `\n"
Daniel Jasper98e0b122017-02-20 14:51:16 +00001825 " aaaaaaaaaaaaaaaaaa: ${someFunction({\n"
Martin Probstc10d97f2017-08-29 08:30:07 +00001826 " aaaa: aaaaa,\n"
1827 " bbbb: bbbbb,\n"
1828 "})}`;",
Daniel Jasper3f119412017-01-31 14:39:33 +00001829 "var f = `\n"
Daniel Jasper98e0b122017-02-20 14:51:16 +00001830 " aaaaaaaaaaaaaaaaaa: ${someFunction ({\n"
Daniel Jasper3f119412017-01-31 14:39:33 +00001831 " aaaa: aaaaa,\n"
1832 " bbbb: bbbbb,\n"
1833 " })}`;");
1834}
1835
Martin Probst717f6dc2016-10-21 05:11:38 +00001836TEST_F(FormatTestJS, TemplateStringASI) {
1837 verifyFormat("var x = `hello${world}`;", "var x = `hello${\n"
1838 " world\n"
1839 "}`;");
1840}
1841
Martin Probst6181da42016-08-25 10:13:21 +00001842TEST_F(FormatTestJS, NestedTemplateStrings) {
1843 verifyFormat(
1844 "var x = `<ul>${xs.map(x => `<li>${x}</li>`).join('\\n')}</ul>`;");
1845 verifyFormat("var x = `he${({text: 'll'}.text)}o`;");
Daniel Jasper58209dd2016-09-17 07:20:36 +00001846
1847 // Crashed at some point.
1848 verifyFormat("}");
Martin Probst6181da42016-08-25 10:13:21 +00001849}
1850
1851TEST_F(FormatTestJS, TaggedTemplateStrings) {
1852 verifyFormat("var x = html`<ul>`;");
Martin Probst37a7f912017-07-04 15:30:21 +00001853 verifyFormat("yield `hello`;");
Daniel Jaspera0ef4f32015-02-20 13:47:38 +00001854}
1855
Martin Probst805c6162016-04-19 14:59:16 +00001856TEST_F(FormatTestJS, CastSyntax) {
1857 verifyFormat("var x = <type>foo;");
1858 verifyFormat("var x = foo as type;");
Martin Probstdce8e412016-06-22 14:35:14 +00001859 verifyFormat("let x = (a + b) as\n"
1860 " LongTypeIsLong;",
1861 getGoogleJSStyleWithColumns(20));
Daniel Jasper887a3992016-06-14 13:54:38 +00001862 verifyFormat("foo = <Bar[]>[\n"
1863 " 1, //\n"
1864 " 2\n"
1865 "];");
Martin Probste1e12a72016-08-19 14:35:01 +00001866 verifyFormat("var x = [{x: 1} as type];");
Martin Probsted87d782016-08-22 14:23:30 +00001867 verifyFormat("x = x as [a, b];");
1868 verifyFormat("x = x as {a: string};");
1869 verifyFormat("x = x as (string);");
Martin Probst34ecf422016-09-06 18:55:34 +00001870 verifyFormat("x = x! as (string);");
Daniel Jasper01b87832017-03-01 19:26:12 +00001871 verifyFormat("var x = something.someFunction() as\n"
1872 " something;",
1873 getGoogleJSStyleWithColumns(40));
Martin Probst805c6162016-04-19 14:59:16 +00001874}
Daniel Jasperbc46b932015-03-15 13:59:51 +00001875
1876TEST_F(FormatTestJS, TypeArguments) {
1877 verifyFormat("class X<Y> {}");
1878 verifyFormat("new X<Y>();");
1879 verifyFormat("foo<Y>(a);");
1880 verifyFormat("var x: X<Y>[];");
1881 verifyFormat("class C extends D<E> implements F<G>, H<I> {}");
Daniel Jasper20580fd2015-06-11 13:31:45 +00001882 verifyFormat("function f(a: List<any> = null) {}");
1883 verifyFormat("function f(): List<any> {}");
Daniel Jasper5a3de1d2015-07-03 10:37:23 +00001884 verifyFormat("function aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa():\n"
1885 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb {}");
Daniel Jasper6501f7e2015-10-27 12:38:37 +00001886 verifyFormat("function aaaaaaaaaa(\n"
1887 " aaaaaaaaaaaaaaaa: aaaaaaaaaaaaaaaaaaa,\n"
1888 " aaaaaaaaaaaaaaaa: aaaaaaaaaaaaaaaaaaa):\n"
Daniel Jasperb2328b12015-07-06 14:07:51 +00001889 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa {}");
Daniel Jasperbc46b932015-03-15 13:59:51 +00001890}
1891
Daniel Jasper779c66f2015-12-30 08:00:58 +00001892TEST_F(FormatTestJS, UserDefinedTypeGuards) {
1893 verifyFormat(
1894 "function foo(check: Object):\n"
1895 " check is {foo: string, bar: string, baz: string, foobar: string} {\n"
1896 " return 'bar' in check;\n"
1897 "}\n");
1898}
1899
Daniel Jaspera74f5072015-04-13 15:01:40 +00001900TEST_F(FormatTestJS, OptionalTypes) {
Daniel Jasper20580fd2015-06-11 13:31:45 +00001901 verifyFormat("function x(a?: b, c?, d?) {}");
Daniel Jaspera74f5072015-04-13 15:01:40 +00001902 verifyFormat("class X {\n"
1903 " y?: z;\n"
1904 " z?;\n"
1905 "}");
Daniel Jasper9326f912015-05-05 08:40:32 +00001906 verifyFormat("interface X {\n"
1907 " y?(): z;\n"
1908 "}");
Daniel Jasper3e0dcc22015-05-27 05:37:40 +00001909 verifyFormat("constructor({aa}: {\n"
1910 " aa?: string,\n"
1911 " aaaaaaaa?: string,\n"
1912 " aaaaaaaaaaaaaaa?: boolean,\n"
1913 " aaaaaa?: List<string>\n"
Daniel Jasper20580fd2015-06-11 13:31:45 +00001914 "}) {}");
Daniel Jaspera74f5072015-04-13 15:01:40 +00001915}
1916
Daniel Jasperd9309772015-04-13 15:03:30 +00001917TEST_F(FormatTestJS, IndexSignature) {
1918 verifyFormat("var x: {[k: string]: v};");
1919}
1920
Daniel Jasper6501f7e2015-10-27 12:38:37 +00001921TEST_F(FormatTestJS, WrapAfterParen) {
1922 verifyFormat("xxxxxxxxxxx(\n"
1923 " aaa, aaa);",
1924 getGoogleJSStyleWithColumns(20));
1925 verifyFormat("xxxxxxxxxxx(\n"
1926 " aaa, aaa, aaa,\n"
1927 " aaa, aaa, aaa);",
1928 getGoogleJSStyleWithColumns(20));
1929 verifyFormat("xxxxxxxxxxx(\n"
1930 " aaaaaaaaaaaaaaaaaaaaaaaa,\n"
1931 " function(x) {\n"
1932 " y(); //\n"
1933 " });",
1934 getGoogleJSStyleWithColumns(40));
1935 verifyFormat("while (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n"
1936 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1937}
1938
Daniel Jasperd196abb2016-01-08 08:14:58 +00001939TEST_F(FormatTestJS, JSDocAnnotations) {
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00001940 verifyFormat("/**\n"
1941 " * @export {this.is.a.long.path.to.a.Type}\n"
1942 " */",
1943 "/**\n"
1944 " * @export {this.is.a.long.path.to.a.Type}\n"
1945 " */",
1946 getGoogleJSStyleWithColumns(20));
Martin Probstbb46a7d2017-02-28 11:08:24 +00001947 verifyFormat("/**\n"
1948 " * @mods {this.is.a.long.path.to.a.Type}\n"
1949 " */",
1950 "/**\n"
1951 " * @mods {this.is.a.long.path.to.a.Type}\n"
1952 " */",
1953 getGoogleJSStyleWithColumns(20));
1954 verifyFormat("/**\n"
1955 " * @param {this.is.a.long.path.to.a.Type}\n"
1956 " */",
1957 "/**\n"
1958 " * @param {this.is.a.long.path.to.a.Type}\n"
1959 " */",
1960 getGoogleJSStyleWithColumns(20));
Martin Probstb4cdb652017-03-13 09:39:23 +00001961 verifyFormat("/**\n"
1962 " * @see http://very/very/long/url/is/long\n"
1963 " */",
1964 "/**\n"
1965 " * @see http://very/very/long/url/is/long\n"
1966 " */",
1967 getGoogleJSStyleWithColumns(20));
Martin Probstbb46a7d2017-02-28 11:08:24 +00001968 verifyFormat(
1969 "/**\n"
1970 " * @param This is a\n"
1971 " * long comment but\n"
1972 " * no type\n"
1973 " */",
1974 "/**\n"
1975 " * @param This is a long comment but no type\n"
1976 " */",
1977 getGoogleJSStyleWithColumns(20));
Krasimir Georgiev17725d82017-03-08 08:55:12 +00001978 // Don't break @param line, but reindent it and reflow unrelated lines.
1979 verifyFormat("{\n"
1980 " /**\n"
1981 " * long long long\n"
1982 " * long\n"
1983 " * @param {this.is.a.long.path.to.a.Type} a\n"
1984 " * long long long\n"
1985 " * long long\n"
1986 " */\n"
1987 " function f(a) {}\n"
1988 "}",
1989 "{\n"
1990 "/**\n"
1991 " * long long long long\n"
1992 " * @param {this.is.a.long.path.to.a.Type} a\n"
1993 " * long long long long\n"
1994 " * long\n"
1995 " */\n"
1996 " function f(a) {}\n"
1997 "}",
1998 getGoogleJSStyleWithColumns(20));
Daniel Jasperd196abb2016-01-08 08:14:58 +00001999}
2000
Daniel Jasperabd1f572016-03-02 22:44:03 +00002001TEST_F(FormatTestJS, RequoteStringsSingle) {
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00002002 verifyFormat("var x = 'foo';", "var x = \"foo\";");
2003 verifyFormat("var x = 'fo\\'o\\'';", "var x = \"fo'o'\";");
2004 verifyFormat("var x = 'fo\\'o\\'';", "var x = \"fo\\'o'\";");
2005 verifyFormat(
2006 "var x =\n"
2007 " 'foo\\'';",
2008 // Code below is 15 chars wide, doesn't fit into the line with the
2009 // \ escape added.
2010 "var x = \"foo'\";", getGoogleJSStyleWithColumns(15));
Daniel Jasperabd1f572016-03-02 22:44:03 +00002011 // Removes no-longer needed \ escape from ".
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00002012 verifyFormat("var x = 'fo\"o';", "var x = \"fo\\\"o\";");
Daniel Jasperabd1f572016-03-02 22:44:03 +00002013 // Code below fits into 15 chars *after* removing the \ escape.
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00002014 verifyFormat("var x = 'fo\"o';", "var x = \"fo\\\"o\";",
2015 getGoogleJSStyleWithColumns(15));
Martin Probsta1669792016-05-12 11:20:32 +00002016 verifyFormat("// clang-format off\n"
2017 "let x = \"double\";\n"
2018 "// clang-format on\n"
2019 "let x = 'single';\n",
2020 "// clang-format off\n"
2021 "let x = \"double\";\n"
2022 "// clang-format on\n"
2023 "let x = \"single\";\n");
Daniel Jasperabd1f572016-03-02 22:44:03 +00002024}
2025
Martin Probsta9855af2016-09-02 14:29:48 +00002026TEST_F(FormatTestJS, RequoteAndIndent) {
2027 verifyFormat("let x = someVeryLongFunctionThatGoesOnAndOn(\n"
2028 " 'double quoted string that needs wrapping');",
2029 "let x = someVeryLongFunctionThatGoesOnAndOn("
2030 "\"double quoted string that needs wrapping\");");
Daniel Jasper496c1992016-09-07 22:48:53 +00002031
2032 verifyFormat("let x =\n"
2033 " 'foo\\'oo';\n"
2034 "let x =\n"
2035 " 'foo\\'oo';",
2036 "let x=\"foo'oo\";\n"
2037 "let x=\"foo'oo\";",
2038 getGoogleJSStyleWithColumns(15));
Martin Probsta9855af2016-09-02 14:29:48 +00002039}
2040
Daniel Jasperabd1f572016-03-02 22:44:03 +00002041TEST_F(FormatTestJS, RequoteStringsDouble) {
2042 FormatStyle DoubleQuotes = getGoogleStyle(FormatStyle::LK_JavaScript);
2043 DoubleQuotes.JavaScriptQuotes = FormatStyle::JSQS_Double;
2044 verifyFormat("var x = \"foo\";", DoubleQuotes);
Daniel Jasper1dcbbcfc2016-03-14 19:21:36 +00002045 verifyFormat("var x = \"foo\";", "var x = 'foo';", DoubleQuotes);
2046 verifyFormat("var x = \"fo'o\";", "var x = 'fo\\'o';", DoubleQuotes);
Daniel Jasperabd1f572016-03-02 22:44:03 +00002047}
2048
2049TEST_F(FormatTestJS, RequoteStringsLeave) {
2050 FormatStyle LeaveQuotes = getGoogleStyle(FormatStyle::LK_JavaScript);
2051 LeaveQuotes.JavaScriptQuotes = FormatStyle::JSQS_Leave;
2052 verifyFormat("var x = \"foo\";", LeaveQuotes);
2053 verifyFormat("var x = 'foo';", LeaveQuotes);
2054}
2055
Martin Probst7ea9b6d2016-05-29 14:41:36 +00002056TEST_F(FormatTestJS, SupportShebangLines) {
2057 verifyFormat("#!/usr/bin/env node\n"
2058 "var x = hello();",
2059 "#!/usr/bin/env node\n"
2060 "var x = hello();");
2061}
2062
Martin Probst0eb40cf2016-06-13 00:49:54 +00002063TEST_F(FormatTestJS, NonNullAssertionOperator) {
2064 verifyFormat("let x = foo!.bar();\n");
2065 verifyFormat("let x = foo ? bar! : baz;\n");
2066 verifyFormat("let x = !foo;\n");
2067 verifyFormat("let x = foo[0]!;\n");
2068 verifyFormat("let x = (foo)!;\n");
Martin Probstab60acb2017-05-22 14:58:26 +00002069 verifyFormat("let x = x(foo!);\n");
2070 verifyFormat(
2071 "a.aaaaaa(a.a!).then(\n"
2072 " x => x(x));\n",
2073 getGoogleJSStyleWithColumns(20));
Daniel Jasper8315ea12016-11-09 14:12:55 +00002074 verifyFormat("let x = foo! - 1;\n");
Martin Probst0eb40cf2016-06-13 00:49:54 +00002075 verifyFormat("let x = {foo: 1}!;\n");
Martin Probst22b8d2692017-03-13 09:14:23 +00002076 verifyFormat(
2077 "let x = hello.foo()!\n"
2078 " .foo()!\n"
2079 " .foo()!\n"
2080 " .foo()!;\n",
2081 getGoogleJSStyleWithColumns(20));
Martin Probst79f9c5f2017-05-12 13:00:33 +00002082 verifyFormat("let x = namespace!;\n");
Martin Probst82b3d902017-05-15 08:15:53 +00002083 verifyFormat("return !!x;\n");
Martin Probst0eb40cf2016-06-13 00:49:54 +00002084}
2085
Martin Probst31d6da72016-06-23 21:51:49 +00002086TEST_F(FormatTestJS, Conditional) {
2087 verifyFormat("y = x ? 1 : 2;");
Daniel Jasperd9d8da22016-07-12 15:45:53 +00002088 verifyFormat("x ? 1 : 2;");
Martin Probst31d6da72016-06-23 21:51:49 +00002089 verifyFormat("class Foo {\n"
2090 " field = true ? 1 : 2;\n"
2091 " method(a = true ? 1 : 2) {}\n"
2092 "}");
2093}
2094
Martin Probstfbbe75b2016-09-18 17:33:51 +00002095TEST_F(FormatTestJS, ImportComments) {
2096 verifyFormat("import {x} from 'x'; // from some location",
2097 getGoogleJSStyleWithColumns(25));
2098 verifyFormat("// taze: x from 'location'", getGoogleJSStyleWithColumns(10));
Martin Probst2083f312017-05-09 12:45:48 +00002099 verifyFormat("/// <reference path=\"some/location\" />", getGoogleJSStyleWithColumns(10));
Martin Probstfbbe75b2016-09-18 17:33:51 +00002100}
Martin Probst4ef03702017-05-04 15:04:04 +00002101
2102TEST_F(FormatTestJS, Exponentiation) {
2103 verifyFormat("squared = x ** 2;");
2104 verifyFormat("squared **= 2;");
2105}
2106
Martin Probst38423272017-06-06 12:38:29 +00002107TEST_F(FormatTestJS, NestedLiterals) {
2108 FormatStyle FourSpaces = getGoogleJSStyleWithColumns(15);
2109 FourSpaces.IndentWidth = 4;
2110 verifyFormat("var l = [\n"
2111 " [\n"
2112 " 1,\n"
2113 " ],\n"
2114 "];", FourSpaces);
2115 verifyFormat("var l = [\n"
2116 " {\n"
2117 " 1: 1,\n"
2118 " },\n"
2119 "];", FourSpaces);
2120 verifyFormat("someFunction(\n"
2121 " p1,\n"
2122 " [\n"
2123 " 1,\n"
2124 " ],\n"
2125 ");", FourSpaces);
2126 verifyFormat("someFunction(\n"
2127 " p1,\n"
2128 " {\n"
2129 " 1: 1,\n"
2130 " },\n"
2131 ");", FourSpaces);
2132 verifyFormat("var o = {\n"
2133 " 1: 1,\n"
2134 " 2: {\n"
2135 " 3: 3,\n"
2136 " },\n"
2137 "};", FourSpaces);
2138 verifyFormat("var o = {\n"
2139 " 1: 1,\n"
2140 " 2: [\n"
2141 " 3,\n"
2142 " ],\n"
2143 "};", FourSpaces);
2144}
2145
Martin Probst64d31ed2017-08-08 14:52:42 +00002146TEST_F(FormatTestJS, BackslashesInComments) {
2147 verifyFormat("// hello \\\n"
2148 "if (x) foo();\n",
2149 "// hello \\\n"
2150 " if ( x) \n"
2151 " foo();\n");
2152 verifyFormat("/* ignore \\\n"
2153 " */\n"
2154 "if (x) foo();\n",
2155 "/* ignore \\\n"
2156 " */\n"
2157 " if ( x) foo();\n");
2158 verifyFormat("// st \\ art\\\n"
2159 "// comment"
2160 "// continue \\\n"
2161 "formatMe();\n",
2162 "// st \\ art\\\n"
2163 "// comment"
2164 "// continue \\\n"
2165 "formatMe( );\n");
2166}
2167
Alexander Kornienkoab9db512015-06-22 23:07:51 +00002168} // end namespace tooling
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +00002169} // end namespace clang