blob: d3c62c4922fcc9ad9ad1e51c19976f237e73aea3 [file] [log] [blame]
Jamie Madillfa05f602015-05-07 13:47:11 -04001//
2// Copyright 2015 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
Jamie Madill1fbc59f2016-02-24 15:25:51 -05006// Framebuffer tests:
7// Various tests related for Frambuffers.
8//
Jamie Madillfa05f602015-05-07 13:47:11 -04009
Jonah Ryan-Davisbeb0eb22019-06-14 15:10:33 -040010#include "platform/FeaturesD3D.h"
Corentin Wallezd3970de2015-05-14 11:07:48 -040011#include "test_utils/ANGLETest.h"
JiangYizhou461d9a32017-01-04 16:37:26 +080012#include "test_utils/gl_raii.h"
Geoff Langb6a673a2014-06-05 14:19:16 -040013
Jamie Madillfa05f602015-05-07 13:47:11 -040014using namespace angle;
Austin Kinross18b931d2014-09-29 12:58:31 -070015
Geoff Lang857c09d2017-05-16 15:55:04 -040016namespace
17{
18
19void ExpectFramebufferCompleteOrUnsupported(GLenum binding)
20{
21 GLenum status = glCheckFramebufferStatus(binding);
22 EXPECT_TRUE(status == GL_FRAMEBUFFER_COMPLETE || status == GL_FRAMEBUFFER_UNSUPPORTED);
23}
24
25} // anonymous namespace
26
Geoff Langb6a673a2014-06-05 14:19:16 -040027class FramebufferFormatsTest : public ANGLETest
28{
Jamie Madillfa05f602015-05-07 13:47:11 -040029 protected:
Jamie Madill3215b202015-12-15 16:41:39 -050030 FramebufferFormatsTest() : mFramebuffer(0), mTexture(0), mRenderbuffer(0), mProgram(0)
Geoff Langb6a673a2014-06-05 14:19:16 -040031 {
32 setWindowWidth(128);
33 setWindowHeight(128);
34 setConfigRedBits(8);
35 setConfigGreenBits(8);
36 setConfigBlueBits(8);
37 setConfigAlphaBits(8);
38 }
39
40 void checkBitCount(GLuint fbo, GLenum channel, GLint minBits)
41 {
42 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
43
44 GLint bits = 0;
45 glGetIntegerv(channel, &bits);
46
47 if (minBits == 0)
48 {
49 EXPECT_EQ(minBits, bits);
50 }
51 else
52 {
53 EXPECT_GE(bits, minBits);
54 }
55 }
56
Jamie Madill1fbc59f2016-02-24 15:25:51 -050057 void testBitCounts(GLuint fbo,
58 GLint minRedBits,
59 GLint minGreenBits,
60 GLint minBlueBits,
61 GLint minAlphaBits,
62 GLint minDepthBits,
63 GLint minStencilBits)
Geoff Langb6a673a2014-06-05 14:19:16 -040064 {
65 checkBitCount(fbo, GL_RED_BITS, minRedBits);
66 checkBitCount(fbo, GL_GREEN_BITS, minGreenBits);
67 checkBitCount(fbo, GL_BLUE_BITS, minBlueBits);
68 checkBitCount(fbo, GL_ALPHA_BITS, minAlphaBits);
69 checkBitCount(fbo, GL_DEPTH_BITS, minDepthBits);
70 checkBitCount(fbo, GL_STENCIL_BITS, minStencilBits);
71 }
72
Jamie Madill1fbc59f2016-02-24 15:25:51 -050073 void testTextureFormat(GLenum internalFormat,
74 GLint minRedBits,
75 GLint minGreenBits,
76 GLint minBlueBits,
Geoff Langb6a673a2014-06-05 14:19:16 -040077 GLint minAlphaBits)
78 {
Jamie Madill3215b202015-12-15 16:41:39 -050079 glGenTextures(1, &mTexture);
80 glBindTexture(GL_TEXTURE_2D, mTexture);
Geoff Langc4e93662017-05-01 10:45:59 -040081
82 if (getClientMajorVersion() >= 3)
83 {
84 glTexStorage2D(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
85 }
86 else
87 {
88 glTexStorage2DEXT(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
89 }
Geoff Langb6a673a2014-06-05 14:19:16 -040090
Jamie Madill3215b202015-12-15 16:41:39 -050091 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, mTexture, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040092
Jamie Madill3215b202015-12-15 16:41:39 -050093 testBitCounts(mFramebuffer, minRedBits, minGreenBits, minBlueBits, minAlphaBits, 0, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040094 }
95
Jamie Madill1fbc59f2016-02-24 15:25:51 -050096 void testRenderbufferMultisampleFormat(int minESVersion,
97 GLenum attachmentType,
98 GLenum internalFormat)
Corentin Walleze0902642014-11-04 12:32:15 -080099 {
Martin Radev1be913c2016-07-11 17:59:16 +0300100 int clientVersion = getClientMajorVersion();
Jamie Madillfa05f602015-05-07 13:47:11 -0400101 if (clientVersion < minESVersion)
Corentin Walleze0902642014-11-04 12:32:15 -0800102 {
103 return;
104 }
105
106 // Check that multisample is supported with at least two samples (minimum required is 1)
107 bool supports2Samples = false;
108
Jamie Madillfa05f602015-05-07 13:47:11 -0400109 if (clientVersion == 2)
Corentin Walleze0902642014-11-04 12:32:15 -0800110 {
Jamie Madillb8149072019-04-30 16:14:44 -0400111 if (IsGLExtensionEnabled("ANGLE_framebuffer_multisample"))
Corentin Walleze0902642014-11-04 12:32:15 -0800112 {
113 int maxSamples;
114 glGetIntegerv(GL_MAX_SAMPLES_ANGLE, &maxSamples);
115 supports2Samples = maxSamples >= 2;
116 }
117 }
118 else
119 {
Jamie Madillfa05f602015-05-07 13:47:11 -0400120 assert(clientVersion >= 3);
Corentin Walleze0902642014-11-04 12:32:15 -0800121 int maxSamples;
122 glGetIntegerv(GL_MAX_SAMPLES, &maxSamples);
123 supports2Samples = maxSamples >= 2;
124 }
125
126 if (!supports2Samples)
127 {
128 return;
129 }
130
Jamie Madill3215b202015-12-15 16:41:39 -0500131 glGenRenderbuffers(1, &mRenderbuffer);
132 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800133
134 EXPECT_GL_NO_ERROR();
135 glRenderbufferStorageMultisampleANGLE(GL_RENDERBUFFER, 2, internalFormat, 128, 128);
136 EXPECT_GL_NO_ERROR();
Jamie Madill3215b202015-12-15 16:41:39 -0500137 glFramebufferRenderbuffer(GL_FRAMEBUFFER, attachmentType, GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800138 EXPECT_GL_NO_ERROR();
Corentin Walleze0902642014-11-04 12:32:15 -0800139 }
140
Olli Etuahobc21e182016-02-23 16:04:57 +0200141 void testZeroHeightRenderbuffer()
142 {
143 glGenRenderbuffers(1, &mRenderbuffer);
144 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
145 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 0);
146 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
147 mRenderbuffer);
148 EXPECT_GL_NO_ERROR();
149 }
150
Jamie Madill5cbaa3f2019-05-07 15:49:22 -0400151 void testSetUp() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400152 {
Jamie Madill3215b202015-12-15 16:41:39 -0500153 glGenFramebuffers(1, &mFramebuffer);
154 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
Geoff Langb6a673a2014-06-05 14:19:16 -0400155 }
156
Jamie Madill5cbaa3f2019-05-07 15:49:22 -0400157 void testTearDown() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400158 {
Jamie Madill3215b202015-12-15 16:41:39 -0500159 if (mTexture != 0)
160 {
161 glDeleteTextures(1, &mTexture);
162 mTexture = 0;
163 }
164
165 if (mRenderbuffer != 0)
166 {
167 glDeleteRenderbuffers(1, &mRenderbuffer);
168 mRenderbuffer = 0;
169 }
170
171 if (mFramebuffer != 0)
172 {
173 glDeleteFramebuffers(1, &mFramebuffer);
174 mFramebuffer = 0;
175 }
176
177 if (mProgram != 0)
178 {
179 glDeleteProgram(mProgram);
180 mProgram = 0;
181 }
Geoff Langb6a673a2014-06-05 14:19:16 -0400182 }
Jamie Madill3215b202015-12-15 16:41:39 -0500183
184 GLuint mFramebuffer;
185 GLuint mTexture;
186 GLuint mRenderbuffer;
187 GLuint mProgram;
Geoff Langb6a673a2014-06-05 14:19:16 -0400188};
189
Jamie Madillfa05f602015-05-07 13:47:11 -0400190TEST_P(FramebufferFormatsTest, RGBA4)
Geoff Langb6a673a2014-06-05 14:19:16 -0400191{
Jamie Madillb8149072019-04-30 16:14:44 -0400192 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
193 !IsGLExtensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400194
Geoff Langb6a673a2014-06-05 14:19:16 -0400195 testTextureFormat(GL_RGBA4, 4, 4, 4, 4);
196}
197
Jamie Madillfa05f602015-05-07 13:47:11 -0400198TEST_P(FramebufferFormatsTest, RGB565)
Geoff Langb6a673a2014-06-05 14:19:16 -0400199{
Jamie Madillb8149072019-04-30 16:14:44 -0400200 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
201 !IsGLExtensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400202
Geoff Langb6a673a2014-06-05 14:19:16 -0400203 testTextureFormat(GL_RGB565, 5, 6, 5, 0);
204}
205
Jamie Madillfa05f602015-05-07 13:47:11 -0400206TEST_P(FramebufferFormatsTest, RGB8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400207{
Jamie Madillb8149072019-04-30 16:14:44 -0400208 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
209 (!IsGLExtensionEnabled("GL_OES_rgb8_rgba8") ||
210 !IsGLExtensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400211
Geoff Langb6a673a2014-06-05 14:19:16 -0400212 testTextureFormat(GL_RGB8_OES, 8, 8, 8, 0);
213}
214
Jamie Madillfa05f602015-05-07 13:47:11 -0400215TEST_P(FramebufferFormatsTest, BGRA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400216{
Yunchao He9550c602018-02-13 14:47:05 +0800217 ANGLE_SKIP_TEST_IF(
Jamie Madillb8149072019-04-30 16:14:44 -0400218 !IsGLExtensionEnabled("GL_EXT_texture_format_BGRA8888") ||
219 (getClientMajorVersion() < 3 && !IsGLExtensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400220
Geoff Langb6a673a2014-06-05 14:19:16 -0400221 testTextureFormat(GL_BGRA8_EXT, 8, 8, 8, 8);
222}
223
Jamie Madillfa05f602015-05-07 13:47:11 -0400224TEST_P(FramebufferFormatsTest, RGBA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400225{
Jamie Madillb8149072019-04-30 16:14:44 -0400226 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
227 (!IsGLExtensionEnabled("GL_OES_rgb8_rgba8") ||
228 !IsGLExtensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400229
Geoff Langb6a673a2014-06-05 14:19:16 -0400230 testTextureFormat(GL_RGBA8_OES, 8, 8, 8, 8);
231}
232
Jamie Madillfa05f602015-05-07 13:47:11 -0400233TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH16)
Corentin Walleze0902642014-11-04 12:32:15 -0800234{
235 testRenderbufferMultisampleFormat(2, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT16);
236}
237
Jamie Madillfa05f602015-05-07 13:47:11 -0400238TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24)
Corentin Walleze0902642014-11-04 12:32:15 -0800239{
240 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT24);
241}
242
Jamie Madillfa05f602015-05-07 13:47:11 -0400243TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F)
Corentin Walleze0902642014-11-04 12:32:15 -0800244{
Yunchao He9550c602018-02-13 14:47:05 +0800245 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400246
Corentin Walleze0902642014-11-04 12:32:15 -0800247 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT32F);
248}
249
Jamie Madillfa05f602015-05-07 13:47:11 -0400250TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800251{
252 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH24_STENCIL8);
253}
254
Jamie Madillfa05f602015-05-07 13:47:11 -0400255TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800256{
Yunchao He9550c602018-02-13 14:47:05 +0800257 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400258
Corentin Walleze0902642014-11-04 12:32:15 -0800259 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH32F_STENCIL8);
260}
261
Jamie Madillfa05f602015-05-07 13:47:11 -0400262TEST_P(FramebufferFormatsTest, RenderbufferMultisample_STENCIL_INDEX8)
Corentin Walleze0902642014-11-04 12:32:15 -0800263{
Geoff Langf34d1db2015-05-20 14:10:46 -0400264 // TODO(geofflang): Figure out how to support GLSTENCIL_INDEX8 on desktop GL
Yunchao He9550c602018-02-13 14:47:05 +0800265 ANGLE_SKIP_TEST_IF(IsDesktopOpenGL());
Geoff Langf34d1db2015-05-20 14:10:46 -0400266
Corentin Walleze0902642014-11-04 12:32:15 -0800267 testRenderbufferMultisampleFormat(2, GL_STENCIL_ATTACHMENT, GL_STENCIL_INDEX8);
268}
Jamie Madillfa05f602015-05-07 13:47:11 -0400269
Jamie Madill3215b202015-12-15 16:41:39 -0500270// Test that binding an incomplete cube map is rejected by ANGLE.
271TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
272{
Michael Spangd8506c72019-01-29 15:35:09 -0500273 // http://anglebug.com/3145
274 ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
275
Jamie Madill3215b202015-12-15 16:41:39 -0500276 // First make a complete CubeMap.
277 glGenTextures(1, &mTexture);
278 glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);
279 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
280 nullptr);
281 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
282 nullptr);
283 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
284 nullptr);
285 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
286 nullptr);
287 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
288 nullptr);
289 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
290 nullptr);
291 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
292 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
293
294 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
295 mTexture, 0);
296
297 // Verify the framebuffer is complete.
298 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
299
300 // Make the CubeMap cube-incomplete.
301 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 16, 16, 0, GL_RGBA, GL_UNSIGNED_BYTE,
302 nullptr);
303
304 // Verify the framebuffer is incomplete.
305 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
306 glCheckFramebufferStatus(GL_FRAMEBUFFER));
307
Jamie Madilld84b6732018-09-06 15:54:35 -0400308 ASSERT_GL_NO_ERROR();
309
Jamie Madill3215b202015-12-15 16:41:39 -0500310 // Verify drawing with the incomplete framebuffer produces a GL error
Olli Etuaho5804dc82018-04-13 14:11:46 +0300311 mProgram = CompileProgram(essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
Jamie Madill3215b202015-12-15 16:41:39 -0500312 ASSERT_NE(0u, mProgram);
Olli Etuaho5804dc82018-04-13 14:11:46 +0300313 drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
Jamie Madill3215b202015-12-15 16:41:39 -0500314 ASSERT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
315}
316
Olli Etuahobc21e182016-02-23 16:04:57 +0200317// Test that a renderbuffer with zero height but nonzero width is handled without crashes/asserts.
318TEST_P(FramebufferFormatsTest, ZeroHeightRenderbuffer)
319{
Yunchao He9550c602018-02-13 14:47:05 +0800320 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Olli Etuahobc21e182016-02-23 16:04:57 +0200321
322 testZeroHeightRenderbuffer();
323}
324
Geoff Lang9bf86f02018-07-26 11:46:34 -0400325// Test to cover a bug where the read framebuffer affects the completeness of the draw framebuffer.
326TEST_P(FramebufferFormatsTest, ReadDrawCompleteness)
327{
328 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
329
330 GLTexture incompleteTexture;
331 glBindTexture(GL_TEXTURE_2D, incompleteTexture);
332
333 GLFramebuffer incompleteFBO;
334 glBindFramebuffer(GL_FRAMEBUFFER, incompleteFBO);
335 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, incompleteTexture,
336 0);
337 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
338 glCheckFramebufferStatus(GL_FRAMEBUFFER));
339
340 GLTexture completeTexture;
341 glBindTexture(GL_TEXTURE_2D, completeTexture);
342 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, getWindowWidth(), getWindowHeight());
343
344 GLFramebuffer completeFBO;
345 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, completeFBO);
346 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,
347 completeTexture, 0);
348
349 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
350 glCheckFramebufferStatus(GL_READ_FRAMEBUFFER));
351 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_DRAW_FRAMEBUFFER));
352
353 ASSERT_GL_NO_ERROR();
354
355 // Simple draw program.
356 ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
357
358 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
359 EXPECT_GL_NO_ERROR();
360
361 glBindFramebuffer(GL_READ_FRAMEBUFFER, completeFBO);
362 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
363}
364
Corentin Wallez57e6d502016-12-09 14:46:39 -0500365class FramebufferTest_ES3 : public ANGLETest
Jamie Madillb980c562018-11-27 11:34:27 -0500366{};
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500367
368// Covers invalidating an incomplete framebuffer. This should be a no-op, but should not error.
Corentin Wallez57e6d502016-12-09 14:46:39 -0500369TEST_P(FramebufferTest_ES3, InvalidateIncomplete)
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500370{
Geoff Lang857c09d2017-05-16 15:55:04 -0400371 GLFramebuffer framebuffer;
372 GLRenderbuffer renderbuffer;
373
374 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
375 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
376 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, renderbuffer);
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500377 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
378 glCheckFramebufferStatus(GL_FRAMEBUFFER));
379
380 std::vector<GLenum> attachments;
381 attachments.push_back(GL_COLOR_ATTACHMENT0);
382
383 glInvalidateFramebuffer(GL_FRAMEBUFFER, 1, attachments.data());
384 EXPECT_GL_NO_ERROR();
385}
386
Corentin Wallez57e6d502016-12-09 14:46:39 -0500387// Test that the framebuffer state tracking robustly handles a depth-only attachment being set
388// as a depth-stencil attachment. It is equivalent to detaching the depth-stencil attachment.
389TEST_P(FramebufferTest_ES3, DepthOnlyAsDepthStencil)
390{
Geoff Lang857c09d2017-05-16 15:55:04 -0400391 GLFramebuffer framebuffer;
392 GLRenderbuffer renderbuffer;
393
394 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
395 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500396 glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, 4, 4);
397
398 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_RENDERBUFFER,
Geoff Lang857c09d2017-05-16 15:55:04 -0400399 renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500400 EXPECT_GLENUM_NE(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
401}
402
Geoff Lang857c09d2017-05-16 15:55:04 -0400403// Test that the framebuffer correctly returns that it is not complete if invalid texture mip levels
404// are bound
405TEST_P(FramebufferTest_ES3, TextureAttachmentMipLevels)
406{
407 GLFramebuffer framebuffer;
408 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
409
410 GLTexture texture;
411 glBindTexture(GL_TEXTURE_2D, texture);
412
413 // Create a complete mip chain in mips 1 to 3
414 glTexImage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
415 glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
416 glTexImage2D(GL_TEXTURE_2D, 3, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
417
418 // Create another complete mip chain in mips 4 to 5
419 glTexImage2D(GL_TEXTURE_2D, 4, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
420 glTexImage2D(GL_TEXTURE_2D, 5, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
421
422 // Create a non-complete mip chain in mip 6
423 glTexImage2D(GL_TEXTURE_2D, 6, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
424
425 // Incomplete, mipLevel != baseLevel and texture is not mip complete
426 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
427 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
428 glCheckFramebufferStatus(GL_FRAMEBUFFER));
429
430 // Complete, mipLevel == baseLevel
431 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 1);
432 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
433
434 // Complete, mipLevel != baseLevel but texture is now mip complete
435 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 2);
436 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
437 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 3);
438 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
439
440 // Incomplete, attached level below the base level
441 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 2);
442 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
443 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
444 glCheckFramebufferStatus(GL_FRAMEBUFFER));
445
446 // Incomplete, attached level is beyond effective max level
447 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 4);
448 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
449 glCheckFramebufferStatus(GL_FRAMEBUFFER));
450
451 // Complete, mipLevel == baseLevel
452 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 4);
453 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
454
455 // Complete, mipLevel != baseLevel but texture is now mip complete
456 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 5);
457 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
458
459 // Complete, mipLevel == baseLevel
460 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 6);
461 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 6);
462 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
463}
464
Shahbaz Youssefidbb18b52020-06-05 15:23:17 -0400465TEST_P(FramebufferTest_ES3, TextureAttachmentMipLevelsReadBack)
466{
Kenneth Russell0bd0a912020-06-12 15:24:55 -0700467#if defined(ADDRESS_SANITIZER)
468 // http://anglebug.com/4737
469 ANGLE_SKIP_TEST_IF(IsOSX());
470#endif
471
Shahbaz Youssefidbb18b52020-06-05 15:23:17 -0400472 GLFramebuffer framebuffer;
473 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
474
475 GLTexture texture;
476 glBindTexture(GL_TEXTURE_2D, texture);
477
478 const std::array<GLColor, 2 * 2> mip0Data = {GLColor::red, GLColor::red, GLColor::red,
479 GLColor::red};
480 const std::array<GLColor, 1 * 1> mip1Data = {GLColor::green};
481
482 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, mip0Data.data());
483 glTexImage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, mip1Data.data());
484
485 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 1);
486 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
487 EXPECT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
488
489 glClearColor(0, 0, 1.0f, 1.0f);
490 glClear(GL_COLOR_BUFFER_BIT);
491 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::blue);
492}
493
Martin Radevd178aa42017-07-13 14:03:22 +0300494// Test that passing an attachment COLOR_ATTACHMENTm where m is equal to MAX_COLOR_ATTACHMENTS
495// generates an INVALID_OPERATION.
496// OpenGL ES Version 3.0.5 (November 3, 2016), 4.4.2.4 Attaching Texture Images to a Framebuffer, p.
497// 208
498TEST_P(FramebufferTest_ES3, ColorAttachmentIndexOutOfBounds)
499{
500 GLFramebuffer framebuffer;
501 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
502
503 GLint maxColorAttachments = 0;
504 glGetIntegerv(GL_MAX_COLOR_ATTACHMENTS, &maxColorAttachments);
505 GLenum attachment = static_cast<GLenum>(maxColorAttachments + GL_COLOR_ATTACHMENT0);
506
507 GLTexture texture;
508 glBindTexture(GL_TEXTURE_2D, texture.get());
509 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA32F, 1, 1);
510 glFramebufferTexture2D(GL_FRAMEBUFFER, attachment, GL_TEXTURE_2D, texture.get(), 0);
511 EXPECT_GL_ERROR(GL_INVALID_OPERATION);
512}
513
Jamie Madilla0016b72017-07-14 14:30:46 -0400514// Check that depth-only attachments report the correct number of samples.
515TEST_P(FramebufferTest_ES3, MultisampleDepthOnly)
516{
517 GLRenderbuffer renderbuffer;
518 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
519 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_DEPTH_COMPONENT24, 32, 32);
520
521 GLFramebuffer framebuffer;
522 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
523 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, renderbuffer);
524 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
525 EXPECT_GL_NO_ERROR();
526
527 GLint samples = 0;
528 glGetIntegerv(GL_SAMPLES, &samples);
529 EXPECT_GL_NO_ERROR();
530 EXPECT_GE(samples, 2);
531}
532
Jeff Gilbert8f8edd62017-10-31 14:26:30 -0700533// Check that we only compare width and height of attachments, not depth.
534TEST_P(FramebufferTest_ES3, AttachmentWith3DLayers)
535{
536 GLTexture texA;
537 glBindTexture(GL_TEXTURE_2D, texA);
538 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
539
540 GLTexture texB;
541 glBindTexture(GL_TEXTURE_3D, texB);
542 glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, 4, 4, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
543
544 GLFramebuffer framebuffer;
545 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
546 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texA, 0);
547 glFramebufferTextureLayer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, texB, 0, 0);
548 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
549 EXPECT_GL_NO_ERROR();
550}
551
Olli Etuahodbce1f82018-09-19 15:32:17 +0300552// Test that clearing the stencil buffer when the framebuffer only has a color attachment does not
553// crash.
554TEST_P(FramebufferTest_ES3, ClearNonexistentStencil)
555{
556 GLRenderbuffer rbo;
557 glBindRenderbuffer(GL_RENDERBUFFER, rbo);
558 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 1);
559
560 GLFramebuffer fbo;
561 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
562 glFramebufferRenderbuffer(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, rbo);
563
564 GLint clearValue = 0;
565 glClearBufferiv(GL_STENCIL, 0, &clearValue);
566
567 // There's no error specified for clearing nonexistent buffers, it's simply a no-op.
568 EXPECT_GL_NO_ERROR();
569}
570
571// Test that clearing the depth buffer when the framebuffer only has a color attachment does not
572// crash.
573TEST_P(FramebufferTest_ES3, ClearNonexistentDepth)
574{
575 GLRenderbuffer rbo;
576 glBindRenderbuffer(GL_RENDERBUFFER, rbo);
577 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 1);
578
579 GLFramebuffer fbo;
580 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
581 glFramebufferRenderbuffer(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, rbo);
582
583 GLfloat clearValue = 0.0f;
584 glClearBufferfv(GL_DEPTH, 0, &clearValue);
585
586 // There's no error specified for clearing nonexistent buffers, it's simply a no-op.
587 EXPECT_GL_NO_ERROR();
588}
589
590// Test that clearing a nonexistent color attachment does not crash.
591TEST_P(FramebufferTest_ES3, ClearNonexistentColor)
592{
593 GLRenderbuffer rbo;
594 glBindRenderbuffer(GL_RENDERBUFFER, rbo);
595 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 1);
596
597 GLFramebuffer fbo;
598 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
599 glFramebufferRenderbuffer(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, rbo);
600
601 std::vector<GLfloat> clearValue = {{0.0f, 1.0f, 0.0f, 1.0f}};
602 glClearBufferfv(GL_COLOR, 1, clearValue.data());
603
604 // There's no error specified for clearing nonexistent buffers, it's simply a no-op.
605 EXPECT_GL_NO_ERROR();
606}
607
608// Test that clearing the depth and stencil buffers when the framebuffer only has a color attachment
609// does not crash.
610TEST_P(FramebufferTest_ES3, ClearNonexistentDepthStencil)
611{
612 GLRenderbuffer rbo;
613 glBindRenderbuffer(GL_RENDERBUFFER, rbo);
614 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 1);
615
616 GLFramebuffer fbo;
617 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
618 glFramebufferRenderbuffer(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, rbo);
619
620 glClearBufferfi(GL_DEPTH_STENCIL, 0, 0.0f, 0);
621
622 // There's no error specified for clearing nonexistent buffers, it's simply a no-op.
623 EXPECT_GL_NO_ERROR();
624}
625
Olli Etuaho4ebd8f32018-09-20 11:12:46 +0300626// Test that clearing a color attachment that has been deleted doesn't crash.
627TEST_P(FramebufferTest_ES3, ClearDeletedAttachment)
628{
629 // An INVALID_FRAMEBUFFER_OPERATION error was seen in this test on Mac, not sure where it might
630 // be originating from. http://anglebug.com/2834
631 ANGLE_SKIP_TEST_IF(IsOSX() && IsOpenGL());
632
633 GLFramebuffer fbo;
634 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
635
636 // There used to be a bug where some draw buffer state used to remain set even after the
637 // attachment was detached via deletion. That's why we create, attach and delete this RBO here.
638 GLuint rbo = 0u;
639 glGenRenderbuffers(1, &rbo);
640 glBindRenderbuffer(GL_RENDERBUFFER, rbo);
641 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, rbo);
642 glDeleteRenderbuffers(1, &rbo);
643
644 // There needs to be at least one color attachment to prevent early out from the clear calls.
645 GLRenderbuffer rbo2;
646 glBindRenderbuffer(GL_RENDERBUFFER, rbo2);
647 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 1);
648 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER, rbo2);
649
650 ASSERT_GL_NO_ERROR();
651
652 // There's no error specified for clearing nonexistent buffers, it's simply a no-op, so we
653 // expect no GL errors below.
654 std::array<GLfloat, 4> floatClearValue = {0.0f, 0.0f, 0.0f, 0.0f};
655 glClearBufferfv(GL_COLOR, 0, floatClearValue.data());
656 EXPECT_GL_NO_ERROR();
657 std::array<GLuint, 4> uintClearValue = {0u, 0u, 0u, 0u};
658 glClearBufferuiv(GL_COLOR, 0, uintClearValue.data());
659 EXPECT_GL_NO_ERROR();
660 std::array<GLint, 4> intClearValue = {0, 0, 0, 0};
661 glClearBufferiv(GL_COLOR, 0, intClearValue.data());
662 EXPECT_GL_NO_ERROR();
663}
664
Tim Van Pattene600ac22019-10-04 14:31:57 -0600665// Test that resizing the color attachment is handled correctly.
666TEST_P(FramebufferTest_ES3, ResizeColorAttachmentSmallToLarge)
667{
668 GLFramebuffer fbo;
669 GLTexture smallTexture;
670 GLTexture largeTexture;
671
672 ANGLE_GL_PROGRAM(greenProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
673 ANGLE_GL_PROGRAM(blueProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Blue());
674
675 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
676
677 // Bind the small texture
678 glBindTexture(GL_TEXTURE_2D, smallTexture);
679 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth() / 2, getWindowHeight() / 2, 0, GL_RGBA,
680 GL_UNSIGNED_BYTE, nullptr);
681 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
682 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
683 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, smallTexture, 0);
684 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
685
686 // Draw to FBO backed by the small texture
687 glUseProgram(greenProgram);
688 drawQuad(greenProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
689 ASSERT_GL_NO_ERROR();
690 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
691 EXPECT_PIXEL_COLOR_EQ((getWindowWidth() / 2) - 1, (getWindowHeight() / 2) - 1, GLColor::green);
692
693 // Change the attachment to the larger texture that fills the window
694 glBindTexture(GL_TEXTURE_2D, largeTexture);
695 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth(), getWindowHeight(), 0, GL_RGBA,
696 GL_UNSIGNED_BYTE, nullptr);
697 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
698 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
699 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, largeTexture, 0);
700 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
701
702 // Draw to FBO backed by the large texture
703 glUseProgram(blueProgram);
704 drawQuad(blueProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
705 ASSERT_GL_NO_ERROR();
706 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::blue);
707 EXPECT_PIXEL_COLOR_EQ(getWindowWidth() - 1, getWindowHeight() - 1, GLColor::blue);
708}
709
710// Test that resizing the color attachment is handled correctly.
711TEST_P(FramebufferTest_ES3, ResizeColorAttachmentLargeToSmall)
712{
713 GLFramebuffer fbo;
714 GLTexture smallTexture;
715 GLTexture largeTexture;
716
717 ANGLE_GL_PROGRAM(greenProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
718 ANGLE_GL_PROGRAM(blueProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Blue());
719
720 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
721
722 // Bind the large texture
723 glBindTexture(GL_TEXTURE_2D, largeTexture);
724 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth(), getWindowHeight(), 0, GL_RGBA,
725 GL_UNSIGNED_BYTE, nullptr);
726 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
727 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
728 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, largeTexture, 0);
729 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
730
731 // Draw to FBO backed by the large texture
732 glUseProgram(blueProgram);
733 drawQuad(blueProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
734 ASSERT_GL_NO_ERROR();
735 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::blue);
736 EXPECT_PIXEL_COLOR_EQ(getWindowWidth() - 1, getWindowHeight() - 1, GLColor::blue);
737
738 // Change the attachment to the smaller texture
739 glBindTexture(GL_TEXTURE_2D, smallTexture);
740 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth() / 2, getWindowHeight() / 2, 0, GL_RGBA,
741 GL_UNSIGNED_BYTE, nullptr);
742 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
743 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
744 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, smallTexture, 0);
745 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
746
747 // Draw to FBO backed by the small texture
748 glUseProgram(greenProgram);
749 drawQuad(greenProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
750 ASSERT_GL_NO_ERROR();
751 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
752 EXPECT_PIXEL_COLOR_EQ((getWindowWidth() / 2) - 1, (getWindowHeight() / 2) - 1, GLColor::green);
753}
754
755// Test that resizing the texture is handled correctly.
756TEST_P(FramebufferTest_ES3, ResizeTextureLargeToSmall)
757{
758 GLFramebuffer fbo;
759 GLTexture texture;
760
761 ANGLE_GL_PROGRAM(greenProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
762 ANGLE_GL_PROGRAM(blueProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Blue());
763
764 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
765
766 // Allocate a large texture
767 glBindTexture(GL_TEXTURE_2D, texture);
768 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth(), getWindowHeight(), 0, GL_RGBA,
769 GL_UNSIGNED_BYTE, nullptr);
770 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
771 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
772 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
773 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
774
775 // Draw to FBO backed by the large texture
776 glUseProgram(blueProgram);
777 drawQuad(blueProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
778 ASSERT_GL_NO_ERROR();
779 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::blue);
780 EXPECT_PIXEL_COLOR_EQ(getWindowWidth() - 1, getWindowHeight() - 1, GLColor::blue);
781
782 // Shrink the texture
783 glBindTexture(GL_TEXTURE_2D, texture);
784 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth() / 2, getWindowHeight() / 2, 0, GL_RGBA,
785 GL_UNSIGNED_BYTE, nullptr);
786 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
787 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
788 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
789 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
790
791 // Draw to FBO backed by the small texture
792 glUseProgram(greenProgram);
793 drawQuad(greenProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
794 ASSERT_GL_NO_ERROR();
795 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
796 EXPECT_PIXEL_COLOR_EQ((getWindowWidth() / 2) - 1, (getWindowHeight() / 2) - 1, GLColor::green);
797}
798
799// Test that resizing the texture is handled correctly.
800TEST_P(FramebufferTest_ES3, ResizeTextureSmallToLarge)
801{
802 GLFramebuffer fbo;
803 GLTexture texture;
804
805 ANGLE_GL_PROGRAM(greenProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
806 ANGLE_GL_PROGRAM(blueProgram, essl1_shaders::vs::Simple(), essl1_shaders::fs::Blue());
807
808 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
809
810 // Allocate a small texture
811 glBindTexture(GL_TEXTURE_2D, texture);
812 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth() / 2, getWindowHeight() / 2, 0, GL_RGBA,
813 GL_UNSIGNED_BYTE, nullptr);
814 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
815 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
816 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
817 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
818
819 // Draw to FBO backed by the large texture
820 glUseProgram(blueProgram);
821 drawQuad(blueProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
822 ASSERT_GL_NO_ERROR();
823 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::blue);
824 EXPECT_PIXEL_COLOR_EQ((getWindowWidth() / 2) - 1, (getWindowHeight() / 2) - 1, GLColor::blue);
825
826 // Grow the texture
827 glBindTexture(GL_TEXTURE_2D, texture);
828 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth(), getWindowHeight(), 0, GL_RGBA,
829 GL_UNSIGNED_BYTE, nullptr);
830 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
831 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
832 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
833 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
834
835 // Draw to FBO backed by the small texture
836 glUseProgram(greenProgram);
837 drawQuad(greenProgram.get(), std::string(essl1_shaders::PositionAttrib()), 0.0f);
838 ASSERT_GL_NO_ERROR();
839 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
840 EXPECT_PIXEL_COLOR_EQ(getWindowWidth() - 1, getWindowHeight() - 1, GLColor::green);
841}
842
Shahbaz Youssefie28883d2020-01-25 23:25:43 -0500843// Test that fewer outputs than framebuffer attachments doesn't crash. This causes a Vulkan
844// validation warning, but should not be fatal.
845TEST_P(FramebufferTest_ES3, FewerShaderOutputsThanAttachments)
846{
847 constexpr char kFS[] = R"(#version 300 es
848precision highp float;
849
850layout(location = 0) out vec4 color0;
851layout(location = 1) out vec4 color1;
852layout(location = 2) out vec4 color2;
853
854void main()
855{
856 color0 = vec4(1.0, 0.0, 0.0, 1.0);
857 color1 = vec4(0.0, 1.0, 0.0, 1.0);
858 color2 = vec4(0.0, 0.0, 1.0, 1.0);
859}
860)";
861
862 ANGLE_GL_PROGRAM(program, essl3_shaders::vs::Simple(), kFS);
863
864 constexpr GLint kDrawBufferCount = 4;
865
866 GLint maxDrawBuffers;
867 glGetIntegerv(GL_MAX_DRAW_BUFFERS, &maxDrawBuffers);
868 ASSERT_GE(maxDrawBuffers, kDrawBufferCount);
869
870 GLTexture textures[kDrawBufferCount];
871
872 for (GLint texIndex = 0; texIndex < kDrawBufferCount; ++texIndex)
873 {
874 glBindTexture(GL_TEXTURE_2D, textures[texIndex]);
875 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, getWindowWidth(), getWindowHeight(), 0, GL_RGBA,
876 GL_UNSIGNED_BYTE, nullptr);
877 }
878
879 GLenum allBufs[kDrawBufferCount] = {GL_COLOR_ATTACHMENT0, GL_COLOR_ATTACHMENT1,
880 GL_COLOR_ATTACHMENT2, GL_COLOR_ATTACHMENT3};
881
882 GLFramebuffer fbo;
883 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo);
884
885 // Enable all draw buffers.
886 for (GLint texIndex = 0; texIndex < kDrawBufferCount; ++texIndex)
887 {
888 glBindTexture(GL_TEXTURE_2D, textures[texIndex]);
889 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + texIndex, GL_TEXTURE_2D,
890 textures[texIndex], 0);
891 }
892 glDrawBuffers(kDrawBufferCount, allBufs);
893
894 // Draw with simple program.
895 drawQuad(program, essl3_shaders::PositionAttrib(), 0.5f, 1.0f, true);
896 ASSERT_GL_NO_ERROR();
897}
JiangYizhou461d9a32017-01-04 16:37:26 +0800898
899class FramebufferTest_ES31 : public ANGLETest
900{
JiangYizhou511937d2017-08-03 15:41:29 +0800901 protected:
902 void validateSamplePass(GLuint &query, GLuint &passedCount, GLint width, GLint height)
903 {
904 glUniform2i(0, width - 1, height - 1);
905 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
906 glDrawArrays(GL_TRIANGLES, 0, 6);
907 glEndQuery(GL_ANY_SAMPLES_PASSED);
908 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
909 EXPECT_GT(static_cast<GLint>(passedCount), 0);
910
911 glUniform2i(0, width - 1, height);
912 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
913 glDrawArrays(GL_TRIANGLES, 0, 6);
914 glEndQuery(GL_ANY_SAMPLES_PASSED);
915 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
916 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
917
918 glUniform2i(0, width, height - 1);
919 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
920 glDrawArrays(GL_TRIANGLES, 0, 6);
921 glEndQuery(GL_ANY_SAMPLES_PASSED);
922 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
923 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
924 }
JiangYizhou461d9a32017-01-04 16:37:26 +0800925};
926
927// Test that without attachment, if either the value of FRAMEBUFFER_DEFAULT_WIDTH or
928// FRAMEBUFFER_DEFAULT_HEIGHT parameters is zero, the framebuffer is incomplete.
929TEST_P(FramebufferTest_ES31, IncompleteMissingAttachmentDefaultParam)
930{
Tim Van Patten626a7282019-07-08 15:11:59 -0600931 // anglebug.com/3565
932 ANGLE_SKIP_TEST_IF(IsVulkan());
933
JiangYizhou461d9a32017-01-04 16:37:26 +0800934 GLFramebuffer mFramebuffer;
935 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
936
937 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
938 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
939 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
940
941 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
942 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
943 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
944 glCheckFramebufferStatus(GL_FRAMEBUFFER));
945
946 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
947 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
948 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
949 glCheckFramebufferStatus(GL_FRAMEBUFFER));
950
951 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
952 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
953 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
954 glCheckFramebufferStatus(GL_FRAMEBUFFER));
955
956 ASSERT_GL_NO_ERROR();
957}
958
959// Test that the sample count of a mix of texture and renderbuffer should be same.
960TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountMix)
961{
Tim Van Patten626a7282019-07-08 15:11:59 -0600962 // anglebug.com/3565
963 ANGLE_SKIP_TEST_IF(IsVulkan());
964
JiangYizhou461d9a32017-01-04 16:37:26 +0800965 GLFramebuffer mFramebuffer;
966 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
967
Ian Elliott5f857832019-12-04 15:30:50 -0700968 // Lookup the supported number of sample counts (rely on fact that ANGLE uses the same set of
969 // sample counts for textures and renderbuffers)
970 GLint numSampleCounts = 0;
971 std::vector<GLint> sampleCounts;
972 GLsizei queryBufferSize = 1;
973 glGetInternalformativ(GL_TEXTURE_2D_MULTISAMPLE, GL_RGBA8, GL_NUM_SAMPLE_COUNTS,
974 queryBufferSize, &numSampleCounts);
975 ANGLE_SKIP_TEST_IF((numSampleCounts < 2));
976 sampleCounts.resize(numSampleCounts);
977 queryBufferSize = numSampleCounts;
978 glGetInternalformativ(GL_TEXTURE_2D_MULTISAMPLE, GL_RGBA8, GL_SAMPLES, queryBufferSize,
979 sampleCounts.data());
980
JiangYizhou461d9a32017-01-04 16:37:26 +0800981 GLTexture mTexture;
982 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
Ian Elliott5f857832019-12-04 15:30:50 -0700983 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, sampleCounts[0], GL_RGBA8, 1, 1, true);
JiangYizhou461d9a32017-01-04 16:37:26 +0800984
985 GLRenderbuffer mRenderbuffer;
986 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
Ian Elliott5f857832019-12-04 15:30:50 -0700987 glRenderbufferStorageMultisample(GL_RENDERBUFFER, sampleCounts[1], GL_RGBA8, 1, 1);
JiangYizhou461d9a32017-01-04 16:37:26 +0800988 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
989 mTexture.get(), 0);
990 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
991 mRenderbuffer.get());
992 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
993 glCheckFramebufferStatus(GL_FRAMEBUFFER));
994
995 ASSERT_GL_NO_ERROR();
996}
997
998// Test that the sample count of texture attachments should be same.
999TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountTex)
1000{
Tim Van Patten626a7282019-07-08 15:11:59 -06001001 // anglebug.com/3565
1002 ANGLE_SKIP_TEST_IF(IsVulkan());
1003
JiangYizhou461d9a32017-01-04 16:37:26 +08001004 GLFramebuffer mFramebuffer;
1005 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
1006
Ian Elliott5f857832019-12-04 15:30:50 -07001007 // Lookup the supported number of sample counts
1008 GLint numSampleCounts = 0;
1009 std::vector<GLint> sampleCounts;
1010 GLsizei queryBufferSize = 1;
1011 glGetInternalformativ(GL_TEXTURE_2D_MULTISAMPLE, GL_RGBA8, GL_NUM_SAMPLE_COUNTS,
1012 queryBufferSize, &numSampleCounts);
1013 ANGLE_SKIP_TEST_IF((numSampleCounts < 2));
1014 sampleCounts.resize(numSampleCounts);
1015 queryBufferSize = numSampleCounts;
1016 glGetInternalformativ(GL_TEXTURE_2D_MULTISAMPLE, GL_RGBA8, GL_SAMPLES, queryBufferSize,
1017 sampleCounts.data());
1018
JiangYizhou461d9a32017-01-04 16:37:26 +08001019 GLTexture mTextures[2];
1020 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
Ian Elliott5f857832019-12-04 15:30:50 -07001021 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, sampleCounts[0], GL_RGBA8, 1, 1, true);
JiangYizhou461d9a32017-01-04 16:37:26 +08001022 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
Ian Elliott5f857832019-12-04 15:30:50 -07001023 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, sampleCounts[1], GL_RGBA8, 1, 1, true);
JiangYizhou461d9a32017-01-04 16:37:26 +08001024 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
1025 mTextures[0].get(), 0);
1026 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
1027 mTextures[1].get(), 0);
1028 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
1029 glCheckFramebufferStatus(GL_FRAMEBUFFER));
1030
1031 ASSERT_GL_NO_ERROR();
1032}
1033
1034// Test that if the attached images are a mix of renderbuffers and textures, the value of
1035// TEXTURE_FIXED_SAMPLE_LOCATIONS must be TRUE for all attached textures.
1036TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsMix)
1037{
Tim Van Patten626a7282019-07-08 15:11:59 -06001038 // anglebug.com/3565
1039 ANGLE_SKIP_TEST_IF(IsVulkan());
1040
JiangYizhou461d9a32017-01-04 16:37:26 +08001041 GLFramebuffer mFramebuffer;
1042 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
1043
1044 GLTexture mTexture;
1045 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
1046 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
1047
1048 GLRenderbuffer mRenderbuffer;
1049 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
1050 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 1, GL_RGBA8, 1, 1);
1051 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
1052 mTexture.get(), 0);
1053 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
1054 mRenderbuffer.get());
1055 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
1056 glCheckFramebufferStatus(GL_FRAMEBUFFER));
1057
1058 ASSERT_GL_NO_ERROR();
1059}
1060
1061// Test that the value of TEXTURE_FIXED_SAMPLE_LOCATIONS is the same for all attached textures.
1062TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsTex)
1063{
Tim Van Patten626a7282019-07-08 15:11:59 -06001064 // anglebug.com/3565
1065 ANGLE_SKIP_TEST_IF(IsVulkan());
1066
JiangYizhou461d9a32017-01-04 16:37:26 +08001067 GLFramebuffer mFramebuffer;
1068 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
1069
1070 GLTexture mTextures[2];
1071 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
1072 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
1073 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
1074 mTextures[0].get(), 0);
1075 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
1076 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGB8, 1, 1, true);
1077 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
1078 mTextures[1].get(), 0);
1079 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
1080 glCheckFramebufferStatus(GL_FRAMEBUFFER));
1081
1082 ASSERT_GL_NO_ERROR();
1083}
1084
JiangYizhou511937d2017-08-03 15:41:29 +08001085// If there are no attachments, rendering will be limited to a rectangle having a lower left of
1086// (0, 0) and an upper right of(width, height), where width and height are the framebuffer
1087// object's default width and height.
JiangYizhou3db40722017-08-28 17:59:13 +08001088TEST_P(FramebufferTest_ES31, RenderingLimitToDefaultFBOSizeWithNoAttachments)
JiangYizhou511937d2017-08-03 15:41:29 +08001089{
Yuly Novikov98f9f532017-11-15 19:16:19 -05001090 // anglebug.com/2253
1091 ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
Tim Van Patten626a7282019-07-08 15:11:59 -06001092 // Occlusion query reports fragments outside the render area are still rendered
1093 ANGLE_SKIP_TEST_IF(IsAndroid() || (IsWindows() && (IsIntel() || IsAMD())));
Yuly Novikov98f9f532017-11-15 19:16:19 -05001094
Jamie Madill35cd7332018-12-02 12:03:33 -05001095 constexpr char kVS1[] = R"(#version 310 es
1096in layout(location = 0) highp vec2 a_position;
1097void main()
1098{
1099 gl_Position = vec4(a_position, 0.0, 1.0);
1100})";
JiangYizhou511937d2017-08-03 15:41:29 +08001101
Jamie Madill35cd7332018-12-02 12:03:33 -05001102 constexpr char kFS1[] = R"(#version 310 es
1103uniform layout(location = 0) highp ivec2 u_expectedSize;
Shahbaz Youssefi190d9a82019-11-29 09:57:40 -05001104out layout(location = 3) mediump vec4 f_color;
Jamie Madill35cd7332018-12-02 12:03:33 -05001105void main()
1106{
1107 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
1108 f_color = vec4(1.0, 0.5, 0.25, 1.0);
1109})";
JiangYizhou511937d2017-08-03 15:41:29 +08001110
Jamie Madill35cd7332018-12-02 12:03:33 -05001111 constexpr char kVS2[] = R"(#version 310 es
1112in layout(location = 0) highp vec2 a_position;
1113void main()
1114{
1115 gl_Position = vec4(a_position, 0.0, 1.0);
1116})";
JiangYizhou10d41392017-12-18 18:13:36 +08001117
Jamie Madill35cd7332018-12-02 12:03:33 -05001118 constexpr char kFS2[] = R"(#version 310 es
1119uniform layout(location = 0) highp ivec2 u_expectedSize;
1120out layout(location = 2) mediump vec4 f_color;
1121void main()
1122{
1123 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
1124 f_color = vec4(1.0, 0.5, 0.25, 1.0);
1125})";
JiangYizhou10d41392017-12-18 18:13:36 +08001126
Jamie Madill35cd7332018-12-02 12:03:33 -05001127 GLuint program1 = CompileProgram(kVS1, kFS1);
JiangYizhou10d41392017-12-18 18:13:36 +08001128 ASSERT_NE(program1, 0u);
1129
Jamie Madill35cd7332018-12-02 12:03:33 -05001130 GLuint program2 = CompileProgram(kVS2, kFS2);
JiangYizhou10d41392017-12-18 18:13:36 +08001131 ASSERT_NE(program2, 0u);
1132
1133 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +08001134
1135 GLFramebuffer mFramebuffer;
1136 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, mFramebuffer);
1137 GLuint defaultWidth = 1;
1138 GLuint defaultHeight = 1;
1139
1140 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, defaultWidth);
1141 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, defaultHeight);
1142 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
1143
1144 const float data[] = {
1145 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f,
1146 };
1147
1148 GLuint vertexArray = 0;
1149 GLuint vertexBuffer = 0;
1150 GLuint query = 0;
1151 GLuint passedCount = 0;
1152
1153 glGenQueries(1, &query);
1154 glGenVertexArrays(1, &vertexArray);
1155 glBindVertexArray(vertexArray);
1156
1157 glGenBuffers(1, &vertexBuffer);
1158 glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
1159 glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);
1160
1161 glEnableVertexAttribArray(0);
1162 glVertexAttribPointer(0, 2, GL_FLOAT, false, 0, 0);
JiangYizhou38d92b52017-09-13 13:47:52 +08001163 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou511937d2017-08-03 15:41:29 +08001164
1165 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
1166
JiangYizhou10d41392017-12-18 18:13:36 +08001167 glUseProgram(program2);
1168 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
1169
1170 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +08001171 // If fbo has attachments, the rendering size should be the same as its attachment.
1172 GLTexture mTexture;
1173 GLuint width = 2;
1174 GLuint height = 2;
1175 glBindTexture(GL_TEXTURE_2D, mTexture.get());
1176 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, width, height);
JiangYizhou38d92b52017-09-13 13:47:52 +08001177
Shahbaz Youssefi190d9a82019-11-29 09:57:40 -05001178 const GLenum bufs[] = {GL_NONE, GL_NONE, GL_NONE, GL_COLOR_ATTACHMENT3};
JiangYizhou38d92b52017-09-13 13:47:52 +08001179
Shahbaz Youssefi190d9a82019-11-29 09:57:40 -05001180 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT3, GL_TEXTURE_2D, mTexture.get(),
JiangYizhou511937d2017-08-03 15:41:29 +08001181 0);
1182 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
Shahbaz Youssefi190d9a82019-11-29 09:57:40 -05001183 glDrawBuffers(4, bufs);
JiangYizhou511937d2017-08-03 15:41:29 +08001184
1185 validateSamplePass(query, passedCount, width, height);
1186
1187 // If fbo's attachment has been removed, the rendering size should be the same as framebuffer
1188 // default size.
Shahbaz Youssefi190d9a82019-11-29 09:57:40 -05001189 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT3, 0, 0, 0);
JiangYizhou511937d2017-08-03 15:41:29 +08001190 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
1191
1192 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
1193
1194 glDisableVertexAttribArray(0);
1195 glBindBuffer(GL_ARRAY_BUFFER, 0);
1196 glBindVertexArray(0);
1197 glDeleteBuffers(1, &vertexBuffer);
1198 glDeleteVertexArrays(1, &vertexArray);
1199
1200 ASSERT_GL_NO_ERROR();
1201}
1202
Brandon Jones9fc87332017-12-13 15:46:52 -08001203class AddDummyTextureNoRenderTargetTest : public ANGLETest
1204{
1205 public:
1206 AddDummyTextureNoRenderTargetTest()
1207 {
1208 setWindowWidth(512);
1209 setWindowHeight(512);
1210 setConfigRedBits(8);
1211 setConfigGreenBits(8);
1212 setConfigBlueBits(8);
1213 setConfigAlphaBits(8);
1214 }
1215
Jonah Ryan-Daviseee67c62019-06-18 13:00:43 -04001216 void overrideWorkaroundsD3D(FeaturesD3D *features) override
Brandon Jones9fc87332017-12-13 15:46:52 -08001217 {
Jonah Ryan-Davisbeb0eb22019-06-14 15:10:33 -04001218 features->overrideFeatures({"add_dummy_texture_no_render_target"}, true);
Brandon Jones9fc87332017-12-13 15:46:52 -08001219 }
1220};
1221
1222// Test to verify workaround succeeds when no program outputs exist http://anglebug.com/2283
1223TEST_P(AddDummyTextureNoRenderTargetTest, NoProgramOutputWorkaround)
1224{
Jamie Madill35cd7332018-12-02 12:03:33 -05001225 constexpr char kVS[] = "void main() {}";
1226 constexpr char kFS[] = "void main() {}";
Brandon Jones9fc87332017-12-13 15:46:52 -08001227
Jamie Madill35cd7332018-12-02 12:03:33 -05001228 ANGLE_GL_PROGRAM(drawProgram, kVS, kFS);
Brandon Jones9fc87332017-12-13 15:46:52 -08001229
1230 glUseProgram(drawProgram);
1231
1232 glDrawArrays(GL_TRIANGLES, 0, 6);
1233
1234 ASSERT_GL_NO_ERROR();
1235}
1236
Jamie Madill4fb3c282020-03-19 19:10:45 -04001237// Covers a bug in ANGLE's Vulkan back-end framebuffer cache which ignored depth/stencil after
1238// calls to DrawBuffers.
1239TEST_P(FramebufferTest_ES3, AttachmentStateChange)
1240{
1241 constexpr GLuint kSize = 2;
1242
1243 ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
1244
1245 GLTexture colorTexture;
1246 glBindTexture(GL_TEXTURE_2D, colorTexture);
1247 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, kSize, kSize, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
1248
1249 GLFramebuffer fbo;
1250 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
1251 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, colorTexture, 0);
1252
1253 ASSERT_GL_NO_ERROR();
1254 ASSERT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
1255
1256 // First draw without a depth buffer.
1257 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f);
1258
1259 GLRenderbuffer depthBuffer;
1260 glBindRenderbuffer(GL_RENDERBUFFER, depthBuffer);
1261 glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT24, kSize, kSize);
1262
1263 // Bind just a renderbuffer and draw.
1264 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, depthBuffer);
1265
1266 ASSERT_GL_NO_ERROR();
1267 ASSERT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
1268
1269 glDrawBuffers(0, nullptr);
1270 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f);
1271
1272 // Re-enable color buffer and draw one final time. This previously triggered a crash.
1273 GLenum drawBuffs = {GL_COLOR_ATTACHMENT0};
1274 glDrawBuffers(1, &drawBuffs);
1275
1276 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f);
1277 ASSERT_GL_NO_ERROR();
1278 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
1279}
1280
Jamie Madilld03b15b2020-03-26 17:22:18 -04001281// Tests that we can support a feedback loop between a depth textures and the depth buffer.
1282// Does not totally mirror the case used in Manhattan. The Manhattan case seems to handle
1283// "clear" specially instead of rendering to depth in the same RP.
1284TEST_P(FramebufferTest_ES3, DepthFeedbackLoopSupported)
1285{
1286 // Feedback loops not supported on D3D11 and may not ever be.
1287 ANGLE_SKIP_TEST_IF(IsD3D11());
1288
1289 // Also this particular test doesn't work on Android despite similar support in Manhattan.
1290 ANGLE_SKIP_TEST_IF(IsAndroid() && IsOpenGLES());
1291
1292 constexpr GLuint kSize = 2;
1293 glViewport(0, 0, kSize, kSize);
1294
1295 constexpr char kFS[] = R"(precision mediump float;
1296varying vec2 v_texCoord;
1297uniform sampler2D depth;
1298void main()
1299{
1300 if (abs(texture2D(depth, v_texCoord).x - 0.5) < 0.1)
1301 {
1302 gl_FragColor = vec4(0, 1, 0, 1);
1303 }
1304 else
1305 {
1306 gl_FragColor = vec4(1, 0, 0, 1);
1307 }
1308})";
1309
1310 ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Texture2D(), kFS);
1311
1312 GLFramebuffer framebuffer;
1313 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
1314
1315 GLTexture colorTexture;
1316 glBindTexture(GL_TEXTURE_2D, colorTexture);
1317 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, kSize, kSize, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
1318
1319 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
1320 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
1321 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, colorTexture, 0);
1322
1323 GLTexture depthTexture;
1324 glBindTexture(GL_TEXTURE_2D, depthTexture);
1325 glTexImage2D(GL_TEXTURE_2D, 0, GL_DEPTH_COMPONENT24, kSize, kSize, 0, GL_DEPTH_COMPONENT,
1326 GL_UNSIGNED_INT, nullptr);
1327 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
1328 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
1329 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, depthTexture, 0);
1330
1331 ASSERT_GL_NO_ERROR();
1332 ASSERT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
1333
1334 // Clear depth to 0.5.
1335 glClearDepthf(0.5f);
1336 glClear(GL_DEPTH_BUFFER_BIT);
1337
1338 // Disable the depth mask. Although this does not remove the feedback loop as defined by the
1339 // spec it mimics what gfxbench does in its rendering tests.
1340 glDepthMask(false);
1341
1342 // Verify we can sample the depth texture and get 0.5.
1343 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5);
1344
1345 ASSERT_GL_NO_ERROR();
1346 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
1347}
1348
Jamie Madilldd00f162020-04-02 14:04:44 -04001349// Covers a bug in ANGLE's Vulkan back-end. Our VkFramebuffer cache would in some cases forget to
1350// check the draw states when computing a cache key.
1351TEST_P(FramebufferTest_ES3, DisabledAttachmentRedefinition)
1352{
1353 constexpr GLuint kSize = 2;
1354
1355 // Make a Framebuffer with two attachments with one enabled and one disabled.
1356 GLTexture texA, texB;
1357 glBindTexture(GL_TEXTURE_2D, texA);
1358 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, kSize, kSize, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
1359 glBindTexture(GL_TEXTURE_2D, texB);
1360 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, kSize, kSize, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
1361
1362 GLFramebuffer fbo;
1363 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
1364 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texA, 0);
1365 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D, texB, 0);
1366
1367 // Mask out the second texture.
1368 constexpr GLenum kOneDrawBuf = GL_COLOR_ATTACHMENT0;
1369 glDrawBuffers(1, &kOneDrawBuf);
1370
1371 ASSERT_GL_NO_ERROR();
1372 ASSERT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
1373
1374 // Set up a very simple shader.
1375 ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
1376 glViewport(0, 0, kSize, kSize);
1377
1378 // Draw
1379 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
1380 ASSERT_GL_NO_ERROR();
1381 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
1382
1383 // Update the masked out attachment and draw again.
1384 std::vector<GLColor> redPixels(kSize * kSize, GLColor::red);
1385 glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, kSize, kSize, GL_RGBA, GL_UNSIGNED_BYTE,
1386 redPixels.data());
1387
1388 // Draw
1389 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
1390 ASSERT_GL_NO_ERROR();
1391 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
1392
1393 glReadBuffer(GL_COLOR_ATTACHMENT1);
1394 ASSERT_GL_NO_ERROR();
1395 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
1396}
1397
Jamie Madillc9c4e4e2020-04-02 10:29:52 -04001398class FramebufferTest : public ANGLETest
1399{};
1400
1401template <typename T>
1402void FillTexture2D(GLuint texture,
1403 GLsizei width,
1404 GLsizei height,
1405 const T &onePixelData,
1406 GLint level,
1407 GLint internalFormat,
1408 GLenum format,
1409 GLenum type)
1410{
1411 std::vector<T> allPixelsData(width * height, onePixelData);
1412
1413 glBindTexture(GL_TEXTURE_2D, texture);
1414 glTexImage2D(GL_TEXTURE_2D, level, internalFormat, width, height, 0, format, type,
1415 allPixelsData.data());
1416 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
1417 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
1418 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
1419 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
1420}
1421
1422// Multi-context uses of textures should not cause rendering feedback loops.
1423TEST_P(FramebufferTest, MultiContextNoRenderingFeedbackLoops)
1424{
1425 constexpr char kTextureVS[] =
1426 R"(attribute vec4 a_position;
1427varying vec2 v_texCoord;
1428void main() {
1429 gl_Position = a_position;
1430 v_texCoord = (a_position.xy * 0.5) + 0.5;
1431})";
1432
1433 constexpr char kTextureFS[] =
1434 R"(precision mediump float;
1435varying vec2 v_texCoord;
1436uniform sampler2D u_texture;
1437void main() {
1438 gl_FragColor = texture2D(u_texture, v_texCoord).rgba;
1439})";
1440
1441 ANGLE_GL_PROGRAM(textureProgram, kTextureVS, kTextureFS);
1442
1443 glUseProgram(textureProgram.get());
1444 GLint uniformLoc = glGetUniformLocation(textureProgram.get(), "u_texture");
1445 ASSERT_NE(-1, uniformLoc);
1446 glUniform1i(uniformLoc, 0);
1447
1448 GLTexture texture;
1449 FillTexture2D(texture.get(), 1, 1, GLColor::red, 0, GL_RGBA, GL_RGBA, GL_UNSIGNED_BYTE);
1450 glBindTexture(GL_TEXTURE_2D, texture.get());
1451 // Note that _texture_ is still bound to GL_TEXTURE_2D in this context at this point.
1452
1453 EGLWindow *window = getEGLWindow();
1454 EGLDisplay display = window->getDisplay();
1455 EGLConfig config = window->getConfig();
1456 EGLSurface surface = window->getSurface();
1457 EGLint contextAttributes[] = {
1458 EGL_CONTEXT_MAJOR_VERSION_KHR,
1459 GetParam().majorVersion,
1460 EGL_CONTEXT_MINOR_VERSION_KHR,
1461 GetParam().minorVersion,
1462 EGL_NONE,
1463 };
1464 EGLContext context1 = eglGetCurrentContext();
1465 // Create context2, sharing resources with context1.
1466 EGLContext context2 = eglCreateContext(display, config, context1, contextAttributes);
1467 ASSERT_NE(context2, EGL_NO_CONTEXT);
1468 eglMakeCurrent(display, surface, surface, context2);
1469
1470 constexpr char kVS[] =
1471 R"(attribute vec4 a_position;
1472void main() {
1473 gl_Position = a_position;
1474})";
1475
1476 constexpr char kFS[] =
1477 R"(precision mediump float;
1478void main() {
1479 gl_FragColor = vec4(0.0, 1.0, 0.0, 1.0);
1480})";
1481
1482 ANGLE_GL_PROGRAM(program, kVS, kFS);
1483 glUseProgram(program.get());
1484
1485 ASSERT_GL_NO_ERROR();
1486
1487 // Render to the texture in context2.
1488 GLFramebuffer framebuffer;
1489 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
1490 // Texture is still a valid name in context2.
1491 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture.get(), 0);
1492 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
1493 // There is no rendering feedback loop at this point.
1494
1495 glDisable(GL_BLEND);
1496 glDisable(GL_DEPTH_TEST);
1497 ASSERT_GL_NO_ERROR();
1498
1499 // If draw is no-op'ed, texture will not be filled appropriately.
1500 drawQuad(program.get(), "a_position", 0.5f, 1.0f, true);
1501 ASSERT_GL_NO_ERROR();
1502 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
1503
1504 // Make context1 current again.
1505 eglMakeCurrent(display, surface, surface, context1);
1506
1507 // Render texture to screen.
1508 drawQuad(textureProgram.get(), "a_position", 0.5f, 1.0f, true);
1509 ASSERT_GL_NO_ERROR();
1510 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
1511
1512 eglDestroyContext(display, context2);
1513}
1514
Jamie Madill2a0c3592020-03-31 15:36:45 -04001515// Ensure cube-incomplete attachments cause incomplete Framebuffers.
1516TEST_P(FramebufferTest, IncompleteCubeMap)
1517{
1518 constexpr GLuint kSize = 2;
1519
1520 GLTexture srcTex;
1521 glBindTexture(GL_TEXTURE_CUBE_MAP, srcTex);
1522 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, kSize, kSize, 0, GL_RGBA,
1523 GL_UNSIGNED_BYTE, nullptr);
1524
1525 GLFramebuffer fbo;
1526 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
1527 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
1528 srcTex, 0);
1529
1530 ASSERT_GL_NO_ERROR();
1531 ASSERT_GLENUM_EQ(glCheckFramebufferStatus(GL_FRAMEBUFFER),
1532 GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT);
1533}
1534
Tobin Ehlis1a01b4b2019-11-11 16:41:07 -07001535ANGLE_INSTANTIATE_TEST_ES2(AddDummyTextureNoRenderTargetTest);
Jamie Madillc9c4e4e2020-04-02 10:29:52 -04001536ANGLE_INSTANTIATE_TEST_ES2(FramebufferTest);
Shahbaz Youssefie28883d2020-01-25 23:25:43 -05001537ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(FramebufferFormatsTest);
1538ANGLE_INSTANTIATE_TEST_ES3(FramebufferTest_ES3);
1539ANGLE_INSTANTIATE_TEST_ES31(FramebufferTest_ES31);