blob: 3a5a1ef0067cbbdde48fa05660aff64ca6621f8b [file] [log] [blame]
Jamie Madillfa05f602015-05-07 13:47:11 -04001//
2// Copyright 2015 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
Jamie Madill1fbc59f2016-02-24 15:25:51 -05006// Framebuffer tests:
7// Various tests related for Frambuffers.
8//
Jamie Madillfa05f602015-05-07 13:47:11 -04009
Brandon Jones9fc87332017-12-13 15:46:52 -080010#include "platform/WorkaroundsD3D.h"
Corentin Wallezd3970de2015-05-14 11:07:48 -040011#include "test_utils/ANGLETest.h"
JiangYizhou461d9a32017-01-04 16:37:26 +080012#include "test_utils/gl_raii.h"
Geoff Langb6a673a2014-06-05 14:19:16 -040013
Jamie Madillfa05f602015-05-07 13:47:11 -040014using namespace angle;
Austin Kinross18b931d2014-09-29 12:58:31 -070015
Geoff Lang857c09d2017-05-16 15:55:04 -040016namespace
17{
18
19void ExpectFramebufferCompleteOrUnsupported(GLenum binding)
20{
21 GLenum status = glCheckFramebufferStatus(binding);
22 EXPECT_TRUE(status == GL_FRAMEBUFFER_COMPLETE || status == GL_FRAMEBUFFER_UNSUPPORTED);
23}
24
25} // anonymous namespace
26
Geoff Langb6a673a2014-06-05 14:19:16 -040027class FramebufferFormatsTest : public ANGLETest
28{
Jamie Madillfa05f602015-05-07 13:47:11 -040029 protected:
Jamie Madill3215b202015-12-15 16:41:39 -050030 FramebufferFormatsTest() : mFramebuffer(0), mTexture(0), mRenderbuffer(0), mProgram(0)
Geoff Langb6a673a2014-06-05 14:19:16 -040031 {
32 setWindowWidth(128);
33 setWindowHeight(128);
34 setConfigRedBits(8);
35 setConfigGreenBits(8);
36 setConfigBlueBits(8);
37 setConfigAlphaBits(8);
38 }
39
40 void checkBitCount(GLuint fbo, GLenum channel, GLint minBits)
41 {
42 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
43
44 GLint bits = 0;
45 glGetIntegerv(channel, &bits);
46
47 if (minBits == 0)
48 {
49 EXPECT_EQ(minBits, bits);
50 }
51 else
52 {
53 EXPECT_GE(bits, minBits);
54 }
55 }
56
Jamie Madill1fbc59f2016-02-24 15:25:51 -050057 void testBitCounts(GLuint fbo,
58 GLint minRedBits,
59 GLint minGreenBits,
60 GLint minBlueBits,
61 GLint minAlphaBits,
62 GLint minDepthBits,
63 GLint minStencilBits)
Geoff Langb6a673a2014-06-05 14:19:16 -040064 {
65 checkBitCount(fbo, GL_RED_BITS, minRedBits);
66 checkBitCount(fbo, GL_GREEN_BITS, minGreenBits);
67 checkBitCount(fbo, GL_BLUE_BITS, minBlueBits);
68 checkBitCount(fbo, GL_ALPHA_BITS, minAlphaBits);
69 checkBitCount(fbo, GL_DEPTH_BITS, minDepthBits);
70 checkBitCount(fbo, GL_STENCIL_BITS, minStencilBits);
71 }
72
Jamie Madill1fbc59f2016-02-24 15:25:51 -050073 void testTextureFormat(GLenum internalFormat,
74 GLint minRedBits,
75 GLint minGreenBits,
76 GLint minBlueBits,
Geoff Langb6a673a2014-06-05 14:19:16 -040077 GLint minAlphaBits)
78 {
Jamie Madill3215b202015-12-15 16:41:39 -050079 glGenTextures(1, &mTexture);
80 glBindTexture(GL_TEXTURE_2D, mTexture);
Geoff Langc4e93662017-05-01 10:45:59 -040081
82 if (getClientMajorVersion() >= 3)
83 {
84 glTexStorage2D(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
85 }
86 else
87 {
88 glTexStorage2DEXT(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
89 }
Geoff Langb6a673a2014-06-05 14:19:16 -040090
Jamie Madill3215b202015-12-15 16:41:39 -050091 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, mTexture, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040092
Jamie Madill3215b202015-12-15 16:41:39 -050093 testBitCounts(mFramebuffer, minRedBits, minGreenBits, minBlueBits, minAlphaBits, 0, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040094 }
95
Jamie Madill1fbc59f2016-02-24 15:25:51 -050096 void testRenderbufferMultisampleFormat(int minESVersion,
97 GLenum attachmentType,
98 GLenum internalFormat)
Corentin Walleze0902642014-11-04 12:32:15 -080099 {
Martin Radev1be913c2016-07-11 17:59:16 +0300100 int clientVersion = getClientMajorVersion();
Jamie Madillfa05f602015-05-07 13:47:11 -0400101 if (clientVersion < minESVersion)
Corentin Walleze0902642014-11-04 12:32:15 -0800102 {
103 return;
104 }
105
106 // Check that multisample is supported with at least two samples (minimum required is 1)
107 bool supports2Samples = false;
108
Jamie Madillfa05f602015-05-07 13:47:11 -0400109 if (clientVersion == 2)
Corentin Walleze0902642014-11-04 12:32:15 -0800110 {
111 if (extensionEnabled("ANGLE_framebuffer_multisample"))
112 {
113 int maxSamples;
114 glGetIntegerv(GL_MAX_SAMPLES_ANGLE, &maxSamples);
115 supports2Samples = maxSamples >= 2;
116 }
117 }
118 else
119 {
Jamie Madillfa05f602015-05-07 13:47:11 -0400120 assert(clientVersion >= 3);
Corentin Walleze0902642014-11-04 12:32:15 -0800121 int maxSamples;
122 glGetIntegerv(GL_MAX_SAMPLES, &maxSamples);
123 supports2Samples = maxSamples >= 2;
124 }
125
126 if (!supports2Samples)
127 {
128 return;
129 }
130
Jamie Madill3215b202015-12-15 16:41:39 -0500131 glGenRenderbuffers(1, &mRenderbuffer);
132 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800133
134 EXPECT_GL_NO_ERROR();
135 glRenderbufferStorageMultisampleANGLE(GL_RENDERBUFFER, 2, internalFormat, 128, 128);
136 EXPECT_GL_NO_ERROR();
Jamie Madill3215b202015-12-15 16:41:39 -0500137 glFramebufferRenderbuffer(GL_FRAMEBUFFER, attachmentType, GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800138 EXPECT_GL_NO_ERROR();
Corentin Walleze0902642014-11-04 12:32:15 -0800139 }
140
Olli Etuahobc21e182016-02-23 16:04:57 +0200141 void testZeroHeightRenderbuffer()
142 {
143 glGenRenderbuffers(1, &mRenderbuffer);
144 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
145 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 0);
146 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
147 mRenderbuffer);
148 EXPECT_GL_NO_ERROR();
149 }
150
Jamie Madill3215b202015-12-15 16:41:39 -0500151 void SetUp() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400152 {
153 ANGLETest::SetUp();
Jamie Madill3215b202015-12-15 16:41:39 -0500154
155 glGenFramebuffers(1, &mFramebuffer);
156 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
Geoff Langb6a673a2014-06-05 14:19:16 -0400157 }
158
Jamie Madill3215b202015-12-15 16:41:39 -0500159 void TearDown() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400160 {
161 ANGLETest::TearDown();
Jamie Madill3215b202015-12-15 16:41:39 -0500162
163 if (mTexture != 0)
164 {
165 glDeleteTextures(1, &mTexture);
166 mTexture = 0;
167 }
168
169 if (mRenderbuffer != 0)
170 {
171 glDeleteRenderbuffers(1, &mRenderbuffer);
172 mRenderbuffer = 0;
173 }
174
175 if (mFramebuffer != 0)
176 {
177 glDeleteFramebuffers(1, &mFramebuffer);
178 mFramebuffer = 0;
179 }
180
181 if (mProgram != 0)
182 {
183 glDeleteProgram(mProgram);
184 mProgram = 0;
185 }
Geoff Langb6a673a2014-06-05 14:19:16 -0400186 }
Jamie Madill3215b202015-12-15 16:41:39 -0500187
188 GLuint mFramebuffer;
189 GLuint mTexture;
190 GLuint mRenderbuffer;
191 GLuint mProgram;
Geoff Langb6a673a2014-06-05 14:19:16 -0400192};
193
Jamie Madillfa05f602015-05-07 13:47:11 -0400194TEST_P(FramebufferFormatsTest, RGBA4)
Geoff Langb6a673a2014-06-05 14:19:16 -0400195{
Yunchao He9550c602018-02-13 14:47:05 +0800196 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400197
Geoff Langb6a673a2014-06-05 14:19:16 -0400198 testTextureFormat(GL_RGBA4, 4, 4, 4, 4);
199}
200
Jamie Madillfa05f602015-05-07 13:47:11 -0400201TEST_P(FramebufferFormatsTest, RGB565)
Geoff Langb6a673a2014-06-05 14:19:16 -0400202{
Yunchao He9550c602018-02-13 14:47:05 +0800203 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400204
Geoff Langb6a673a2014-06-05 14:19:16 -0400205 testTextureFormat(GL_RGB565, 5, 6, 5, 0);
206}
207
Jamie Madillfa05f602015-05-07 13:47:11 -0400208TEST_P(FramebufferFormatsTest, RGB8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400209{
Yunchao He9550c602018-02-13 14:47:05 +0800210 ANGLE_SKIP_TEST_IF(
211 getClientMajorVersion() < 3 &&
212 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400213
Geoff Langb6a673a2014-06-05 14:19:16 -0400214 testTextureFormat(GL_RGB8_OES, 8, 8, 8, 0);
215}
216
Jamie Madillfa05f602015-05-07 13:47:11 -0400217TEST_P(FramebufferFormatsTest, BGRA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400218{
Yunchao He9550c602018-02-13 14:47:05 +0800219 ANGLE_SKIP_TEST_IF(
220 !extensionEnabled("GL_EXT_texture_format_BGRA8888") ||
221 (getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400222
Geoff Langb6a673a2014-06-05 14:19:16 -0400223 testTextureFormat(GL_BGRA8_EXT, 8, 8, 8, 8);
224}
225
Jamie Madillfa05f602015-05-07 13:47:11 -0400226TEST_P(FramebufferFormatsTest, RGBA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400227{
Yunchao He9550c602018-02-13 14:47:05 +0800228 ANGLE_SKIP_TEST_IF(
229 getClientMajorVersion() < 3 &&
230 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400231
Geoff Langb6a673a2014-06-05 14:19:16 -0400232 testTextureFormat(GL_RGBA8_OES, 8, 8, 8, 8);
233}
234
Jamie Madillfa05f602015-05-07 13:47:11 -0400235TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH16)
Corentin Walleze0902642014-11-04 12:32:15 -0800236{
237 testRenderbufferMultisampleFormat(2, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT16);
238}
239
Jamie Madillfa05f602015-05-07 13:47:11 -0400240TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24)
Corentin Walleze0902642014-11-04 12:32:15 -0800241{
242 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT24);
243}
244
Jamie Madillfa05f602015-05-07 13:47:11 -0400245TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F)
Corentin Walleze0902642014-11-04 12:32:15 -0800246{
Yunchao He9550c602018-02-13 14:47:05 +0800247 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400248
Corentin Walleze0902642014-11-04 12:32:15 -0800249 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT32F);
250}
251
Jamie Madillfa05f602015-05-07 13:47:11 -0400252TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800253{
254 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH24_STENCIL8);
255}
256
Jamie Madillfa05f602015-05-07 13:47:11 -0400257TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800258{
Yunchao He9550c602018-02-13 14:47:05 +0800259 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400260
Corentin Walleze0902642014-11-04 12:32:15 -0800261 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH32F_STENCIL8);
262}
263
Jamie Madillfa05f602015-05-07 13:47:11 -0400264TEST_P(FramebufferFormatsTest, RenderbufferMultisample_STENCIL_INDEX8)
Corentin Walleze0902642014-11-04 12:32:15 -0800265{
Geoff Langf34d1db2015-05-20 14:10:46 -0400266 // TODO(geofflang): Figure out how to support GLSTENCIL_INDEX8 on desktop GL
Yunchao He9550c602018-02-13 14:47:05 +0800267 ANGLE_SKIP_TEST_IF(IsDesktopOpenGL());
Geoff Langf34d1db2015-05-20 14:10:46 -0400268
Corentin Walleze0902642014-11-04 12:32:15 -0800269 testRenderbufferMultisampleFormat(2, GL_STENCIL_ATTACHMENT, GL_STENCIL_INDEX8);
270}
Jamie Madillfa05f602015-05-07 13:47:11 -0400271
Jamie Madill3215b202015-12-15 16:41:39 -0500272// Test that binding an incomplete cube map is rejected by ANGLE.
273TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
274{
Luc Ferronfa7503c2018-05-08 11:25:06 -0400275 // TODO(jmadill): Handle cube textures. http://anglebug.com/2470
276 ANGLE_SKIP_TEST_IF(IsVulkan());
277
Jamie Madill3215b202015-12-15 16:41:39 -0500278 // First make a complete CubeMap.
279 glGenTextures(1, &mTexture);
280 glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);
281 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
282 nullptr);
283 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
284 nullptr);
285 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
286 nullptr);
287 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
288 nullptr);
289 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
290 nullptr);
291 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
292 nullptr);
293 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
294 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
295
296 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
297 mTexture, 0);
298
299 // Verify the framebuffer is complete.
300 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
301
302 // Make the CubeMap cube-incomplete.
303 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 16, 16, 0, GL_RGBA, GL_UNSIGNED_BYTE,
304 nullptr);
305
306 // Verify the framebuffer is incomplete.
307 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
308 glCheckFramebufferStatus(GL_FRAMEBUFFER));
309
Jamie Madilld84b6732018-09-06 15:54:35 -0400310 ASSERT_GL_NO_ERROR();
311
Jamie Madill3215b202015-12-15 16:41:39 -0500312 // Verify drawing with the incomplete framebuffer produces a GL error
Olli Etuaho5804dc82018-04-13 14:11:46 +0300313 mProgram = CompileProgram(essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
Jamie Madill3215b202015-12-15 16:41:39 -0500314 ASSERT_NE(0u, mProgram);
Olli Etuaho5804dc82018-04-13 14:11:46 +0300315 drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
Jamie Madill3215b202015-12-15 16:41:39 -0500316 ASSERT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
317}
318
Olli Etuahobc21e182016-02-23 16:04:57 +0200319// Test that a renderbuffer with zero height but nonzero width is handled without crashes/asserts.
320TEST_P(FramebufferFormatsTest, ZeroHeightRenderbuffer)
321{
Yunchao He9550c602018-02-13 14:47:05 +0800322 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Olli Etuahobc21e182016-02-23 16:04:57 +0200323
324 testZeroHeightRenderbuffer();
325}
326
Geoff Lang9bf86f02018-07-26 11:46:34 -0400327// Test to cover a bug where the read framebuffer affects the completeness of the draw framebuffer.
328TEST_P(FramebufferFormatsTest, ReadDrawCompleteness)
329{
330 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
331
332 GLTexture incompleteTexture;
333 glBindTexture(GL_TEXTURE_2D, incompleteTexture);
334
335 GLFramebuffer incompleteFBO;
336 glBindFramebuffer(GL_FRAMEBUFFER, incompleteFBO);
337 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, incompleteTexture,
338 0);
339 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
340 glCheckFramebufferStatus(GL_FRAMEBUFFER));
341
342 GLTexture completeTexture;
343 glBindTexture(GL_TEXTURE_2D, completeTexture);
344 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, getWindowWidth(), getWindowHeight());
345
346 GLFramebuffer completeFBO;
347 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, completeFBO);
348 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,
349 completeTexture, 0);
350
351 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
352 glCheckFramebufferStatus(GL_READ_FRAMEBUFFER));
353 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_DRAW_FRAMEBUFFER));
354
355 ASSERT_GL_NO_ERROR();
356
357 // Simple draw program.
358 ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
359
360 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
361 EXPECT_GL_NO_ERROR();
362
363 glBindFramebuffer(GL_READ_FRAMEBUFFER, completeFBO);
364 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
365}
366
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500367// Use this to select which configurations (e.g. which renderer, which GLES major version) these
368// tests should be run against.
Geoff Lange0cc2a42016-01-20 10:58:17 -0500369ANGLE_INSTANTIATE_TEST(FramebufferFormatsTest,
Luc Ferronfa7503c2018-05-08 11:25:06 -0400370 ES2_VULKAN(),
Geoff Lange0cc2a42016-01-20 10:58:17 -0500371 ES2_D3D9(),
372 ES2_D3D11(),
373 ES3_D3D11(),
374 ES2_OPENGL(),
375 ES3_OPENGL(),
376 ES2_OPENGLES(),
377 ES3_OPENGLES());
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500378
Corentin Wallez57e6d502016-12-09 14:46:39 -0500379class FramebufferTest_ES3 : public ANGLETest
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500380{
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500381};
382
383// Covers invalidating an incomplete framebuffer. This should be a no-op, but should not error.
Corentin Wallez57e6d502016-12-09 14:46:39 -0500384TEST_P(FramebufferTest_ES3, InvalidateIncomplete)
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500385{
Geoff Lang857c09d2017-05-16 15:55:04 -0400386 GLFramebuffer framebuffer;
387 GLRenderbuffer renderbuffer;
388
389 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
390 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
391 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, renderbuffer);
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500392 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
393 glCheckFramebufferStatus(GL_FRAMEBUFFER));
394
395 std::vector<GLenum> attachments;
396 attachments.push_back(GL_COLOR_ATTACHMENT0);
397
398 glInvalidateFramebuffer(GL_FRAMEBUFFER, 1, attachments.data());
399 EXPECT_GL_NO_ERROR();
400}
401
Corentin Wallez57e6d502016-12-09 14:46:39 -0500402// Test that the framebuffer state tracking robustly handles a depth-only attachment being set
403// as a depth-stencil attachment. It is equivalent to detaching the depth-stencil attachment.
404TEST_P(FramebufferTest_ES3, DepthOnlyAsDepthStencil)
405{
Geoff Lang857c09d2017-05-16 15:55:04 -0400406 GLFramebuffer framebuffer;
407 GLRenderbuffer renderbuffer;
408
409 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
410 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500411 glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, 4, 4);
412
413 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_RENDERBUFFER,
Geoff Lang857c09d2017-05-16 15:55:04 -0400414 renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500415 EXPECT_GLENUM_NE(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
416}
417
Geoff Lang857c09d2017-05-16 15:55:04 -0400418// Test that the framebuffer correctly returns that it is not complete if invalid texture mip levels
419// are bound
420TEST_P(FramebufferTest_ES3, TextureAttachmentMipLevels)
421{
422 GLFramebuffer framebuffer;
423 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
424
425 GLTexture texture;
426 glBindTexture(GL_TEXTURE_2D, texture);
427
428 // Create a complete mip chain in mips 1 to 3
429 glTexImage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
430 glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
431 glTexImage2D(GL_TEXTURE_2D, 3, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
432
433 // Create another complete mip chain in mips 4 to 5
434 glTexImage2D(GL_TEXTURE_2D, 4, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
435 glTexImage2D(GL_TEXTURE_2D, 5, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
436
437 // Create a non-complete mip chain in mip 6
438 glTexImage2D(GL_TEXTURE_2D, 6, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
439
440 // Incomplete, mipLevel != baseLevel and texture is not mip complete
441 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
442 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
443 glCheckFramebufferStatus(GL_FRAMEBUFFER));
444
445 // Complete, mipLevel == baseLevel
446 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 1);
447 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
448
449 // Complete, mipLevel != baseLevel but texture is now mip complete
450 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 2);
451 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
452 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 3);
453 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
454
455 // Incomplete, attached level below the base level
456 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 2);
457 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
458 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
459 glCheckFramebufferStatus(GL_FRAMEBUFFER));
460
461 // Incomplete, attached level is beyond effective max level
462 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 4);
463 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
464 glCheckFramebufferStatus(GL_FRAMEBUFFER));
465
466 // Complete, mipLevel == baseLevel
467 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 4);
468 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
469
470 // Complete, mipLevel != baseLevel but texture is now mip complete
471 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 5);
472 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
473
474 // Complete, mipLevel == baseLevel
475 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 6);
476 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 6);
477 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
478}
479
Martin Radevd178aa42017-07-13 14:03:22 +0300480// Test that passing an attachment COLOR_ATTACHMENTm where m is equal to MAX_COLOR_ATTACHMENTS
481// generates an INVALID_OPERATION.
482// OpenGL ES Version 3.0.5 (November 3, 2016), 4.4.2.4 Attaching Texture Images to a Framebuffer, p.
483// 208
484TEST_P(FramebufferTest_ES3, ColorAttachmentIndexOutOfBounds)
485{
486 GLFramebuffer framebuffer;
487 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
488
489 GLint maxColorAttachments = 0;
490 glGetIntegerv(GL_MAX_COLOR_ATTACHMENTS, &maxColorAttachments);
491 GLenum attachment = static_cast<GLenum>(maxColorAttachments + GL_COLOR_ATTACHMENT0);
492
493 GLTexture texture;
494 glBindTexture(GL_TEXTURE_2D, texture.get());
495 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA32F, 1, 1);
496 glFramebufferTexture2D(GL_FRAMEBUFFER, attachment, GL_TEXTURE_2D, texture.get(), 0);
497 EXPECT_GL_ERROR(GL_INVALID_OPERATION);
498}
499
Jamie Madilla0016b72017-07-14 14:30:46 -0400500// Check that depth-only attachments report the correct number of samples.
501TEST_P(FramebufferTest_ES3, MultisampleDepthOnly)
502{
503 GLRenderbuffer renderbuffer;
504 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
505 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_DEPTH_COMPONENT24, 32, 32);
506
507 GLFramebuffer framebuffer;
508 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
509 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, renderbuffer);
510 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
511 EXPECT_GL_NO_ERROR();
512
513 GLint samples = 0;
514 glGetIntegerv(GL_SAMPLES, &samples);
515 EXPECT_GL_NO_ERROR();
516 EXPECT_GE(samples, 2);
517}
518
Jeff Gilbert8f8edd62017-10-31 14:26:30 -0700519// Check that we only compare width and height of attachments, not depth.
520TEST_P(FramebufferTest_ES3, AttachmentWith3DLayers)
521{
522 GLTexture texA;
523 glBindTexture(GL_TEXTURE_2D, texA);
524 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
525
526 GLTexture texB;
527 glBindTexture(GL_TEXTURE_3D, texB);
528 glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, 4, 4, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
529
530 GLFramebuffer framebuffer;
531 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
532 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texA, 0);
533 glFramebufferTextureLayer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, texB, 0, 0);
534 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
535 EXPECT_GL_NO_ERROR();
536}
537
Corentin Wallez57e6d502016-12-09 14:46:39 -0500538ANGLE_INSTANTIATE_TEST(FramebufferTest_ES3, ES3_D3D11(), ES3_OPENGL(), ES3_OPENGLES());
JiangYizhou461d9a32017-01-04 16:37:26 +0800539
540class FramebufferTest_ES31 : public ANGLETest
541{
JiangYizhou511937d2017-08-03 15:41:29 +0800542 protected:
543 void validateSamplePass(GLuint &query, GLuint &passedCount, GLint width, GLint height)
544 {
545 glUniform2i(0, width - 1, height - 1);
546 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
547 glDrawArrays(GL_TRIANGLES, 0, 6);
548 glEndQuery(GL_ANY_SAMPLES_PASSED);
549 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
550 EXPECT_GT(static_cast<GLint>(passedCount), 0);
551
552 glUniform2i(0, width - 1, height);
553 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
554 glDrawArrays(GL_TRIANGLES, 0, 6);
555 glEndQuery(GL_ANY_SAMPLES_PASSED);
556 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
557 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
558
559 glUniform2i(0, width, height - 1);
560 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
561 glDrawArrays(GL_TRIANGLES, 0, 6);
562 glEndQuery(GL_ANY_SAMPLES_PASSED);
563 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
564 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
565 }
JiangYizhou461d9a32017-01-04 16:37:26 +0800566};
567
568// Test that without attachment, if either the value of FRAMEBUFFER_DEFAULT_WIDTH or
569// FRAMEBUFFER_DEFAULT_HEIGHT parameters is zero, the framebuffer is incomplete.
570TEST_P(FramebufferTest_ES31, IncompleteMissingAttachmentDefaultParam)
571{
572 GLFramebuffer mFramebuffer;
573 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
574
575 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
576 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
577 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
578
579 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
580 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
581 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
582 glCheckFramebufferStatus(GL_FRAMEBUFFER));
583
584 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
585 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
586 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
587 glCheckFramebufferStatus(GL_FRAMEBUFFER));
588
589 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
590 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
591 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
592 glCheckFramebufferStatus(GL_FRAMEBUFFER));
593
594 ASSERT_GL_NO_ERROR();
595}
596
597// Test that the sample count of a mix of texture and renderbuffer should be same.
598TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountMix)
599{
600 GLFramebuffer mFramebuffer;
601 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
602
603 GLTexture mTexture;
604 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
605 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
606
607 GLRenderbuffer mRenderbuffer;
608 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
609 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_RGBA8, 1, 1);
610 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
611 mTexture.get(), 0);
612 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
613 mRenderbuffer.get());
614 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
615 glCheckFramebufferStatus(GL_FRAMEBUFFER));
616
617 ASSERT_GL_NO_ERROR();
618}
619
620// Test that the sample count of texture attachments should be same.
621TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountTex)
622{
623 GLFramebuffer mFramebuffer;
624 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
625
626 GLTexture mTextures[2];
627 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
628 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
629 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
630 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 2, GL_RGBA8, 1, 1, true);
631 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
632 mTextures[0].get(), 0);
633 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
634 mTextures[1].get(), 0);
635 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
636 glCheckFramebufferStatus(GL_FRAMEBUFFER));
637
638 ASSERT_GL_NO_ERROR();
639}
640
641// Test that if the attached images are a mix of renderbuffers and textures, the value of
642// TEXTURE_FIXED_SAMPLE_LOCATIONS must be TRUE for all attached textures.
643TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsMix)
644{
645 GLFramebuffer mFramebuffer;
646 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
647
648 GLTexture mTexture;
649 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
650 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
651
652 GLRenderbuffer mRenderbuffer;
653 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
654 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 1, GL_RGBA8, 1, 1);
655 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
656 mTexture.get(), 0);
657 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
658 mRenderbuffer.get());
659 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
660 glCheckFramebufferStatus(GL_FRAMEBUFFER));
661
662 ASSERT_GL_NO_ERROR();
663}
664
665// Test that the value of TEXTURE_FIXED_SAMPLE_LOCATIONS is the same for all attached textures.
666TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsTex)
667{
668 GLFramebuffer mFramebuffer;
669 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
670
671 GLTexture mTextures[2];
672 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
673 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
674 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
675 mTextures[0].get(), 0);
676 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
677 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGB8, 1, 1, true);
678 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
679 mTextures[1].get(), 0);
680 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
681 glCheckFramebufferStatus(GL_FRAMEBUFFER));
682
683 ASSERT_GL_NO_ERROR();
684}
685
JiangYizhou511937d2017-08-03 15:41:29 +0800686// If there are no attachments, rendering will be limited to a rectangle having a lower left of
687// (0, 0) and an upper right of(width, height), where width and height are the framebuffer
688// object's default width and height.
JiangYizhou3db40722017-08-28 17:59:13 +0800689TEST_P(FramebufferTest_ES31, RenderingLimitToDefaultFBOSizeWithNoAttachments)
JiangYizhou511937d2017-08-03 15:41:29 +0800690{
Yuly Novikov98f9f532017-11-15 19:16:19 -0500691 // anglebug.com/2253
692 ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
693
JiangYizhou10d41392017-12-18 18:13:36 +0800694 const std::string &vertexShader1 =
695 R"(#version 310 es
696 in layout(location = 0) highp vec2 a_position;
697 void main()
698 {
699 gl_Position = vec4(a_position, 0.0, 1.0);
700 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800701
JiangYizhou10d41392017-12-18 18:13:36 +0800702 const std::string &fragShader1 =
703 R"(#version 310 es
704 uniform layout(location = 0) highp ivec2 u_expectedSize;
705 out layout(location = 5) mediump vec4 f_color;
706 void main()
707 {
708 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
709 f_color = vec4(1.0, 0.5, 0.25, 1.0);
710 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800711
JiangYizhou10d41392017-12-18 18:13:36 +0800712 const std::string &vertexShader2 =
713 R"(#version 310 es
714 in layout(location = 0) highp vec2 a_position;
715 void main()
716 {
717 gl_Position = vec4(a_position, 0.0, 1.0);
718 })";
719
720 const std::string &fragShader2 =
721 R"(#version 310 es
722 uniform layout(location = 0) highp ivec2 u_expectedSize;
723 out layout(location = 2) mediump vec4 f_color;
724 void main()
725 {
726 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
727 f_color = vec4(1.0, 0.5, 0.25, 1.0);
728 })";
729
730 GLuint program1 = CompileProgram(vertexShader1, fragShader1);
731 ASSERT_NE(program1, 0u);
732
733 GLuint program2 = CompileProgram(vertexShader2, fragShader2);
734 ASSERT_NE(program2, 0u);
735
736 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800737
738 GLFramebuffer mFramebuffer;
739 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, mFramebuffer);
740 GLuint defaultWidth = 1;
741 GLuint defaultHeight = 1;
742
743 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, defaultWidth);
744 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, defaultHeight);
745 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
746
747 const float data[] = {
748 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f,
749 };
750
751 GLuint vertexArray = 0;
752 GLuint vertexBuffer = 0;
753 GLuint query = 0;
754 GLuint passedCount = 0;
755
756 glGenQueries(1, &query);
757 glGenVertexArrays(1, &vertexArray);
758 glBindVertexArray(vertexArray);
759
760 glGenBuffers(1, &vertexBuffer);
761 glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
762 glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);
763
764 glEnableVertexAttribArray(0);
765 glVertexAttribPointer(0, 2, GL_FLOAT, false, 0, 0);
JiangYizhou38d92b52017-09-13 13:47:52 +0800766 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou511937d2017-08-03 15:41:29 +0800767
768 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
769
JiangYizhou10d41392017-12-18 18:13:36 +0800770 glUseProgram(program2);
771 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
772
773 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800774 // If fbo has attachments, the rendering size should be the same as its attachment.
775 GLTexture mTexture;
776 GLuint width = 2;
777 GLuint height = 2;
778 glBindTexture(GL_TEXTURE_2D, mTexture.get());
779 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, width, height);
JiangYizhou38d92b52017-09-13 13:47:52 +0800780
781 const GLenum bufs[] = {GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_COLOR_ATTACHMENT5};
782
783 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, GL_TEXTURE_2D, mTexture.get(),
JiangYizhou511937d2017-08-03 15:41:29 +0800784 0);
785 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou38d92b52017-09-13 13:47:52 +0800786 glDrawBuffers(6, bufs);
JiangYizhou511937d2017-08-03 15:41:29 +0800787
788 validateSamplePass(query, passedCount, width, height);
789
790 // If fbo's attachment has been removed, the rendering size should be the same as framebuffer
791 // default size.
JiangYizhou38d92b52017-09-13 13:47:52 +0800792 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, 0, 0, 0);
JiangYizhou511937d2017-08-03 15:41:29 +0800793 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
794
795 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
796
797 glDisableVertexAttribArray(0);
798 glBindBuffer(GL_ARRAY_BUFFER, 0);
799 glBindVertexArray(0);
800 glDeleteBuffers(1, &vertexBuffer);
801 glDeleteVertexArrays(1, &vertexArray);
802
803 ASSERT_GL_NO_ERROR();
804}
805
806ANGLE_INSTANTIATE_TEST(FramebufferTest_ES31, ES31_D3D11(), ES31_OPENGL(), ES31_OPENGLES());
Brandon Jones9fc87332017-12-13 15:46:52 -0800807
808class AddDummyTextureNoRenderTargetTest : public ANGLETest
809{
810 public:
811 AddDummyTextureNoRenderTargetTest()
812 {
813 setWindowWidth(512);
814 setWindowHeight(512);
815 setConfigRedBits(8);
816 setConfigGreenBits(8);
817 setConfigBlueBits(8);
818 setConfigAlphaBits(8);
819 }
820
821 void overrideWorkaroundsD3D(WorkaroundsD3D *workarounds) override
822 {
823 workarounds->addDummyTextureNoRenderTarget = true;
824 }
825};
826
827// Test to verify workaround succeeds when no program outputs exist http://anglebug.com/2283
828TEST_P(AddDummyTextureNoRenderTargetTest, NoProgramOutputWorkaround)
829{
830 const std::string &vShader = "void main() {}";
831 const std::string &fShader = "void main() {}";
832
833 ANGLE_GL_PROGRAM(drawProgram, vShader, fShader);
834
835 glUseProgram(drawProgram);
836
837 glDrawArrays(GL_TRIANGLES, 0, 6);
838
839 ASSERT_GL_NO_ERROR();
840}
841
842ANGLE_INSTANTIATE_TEST(AddDummyTextureNoRenderTargetTest, ES2_D3D11());