Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES2.cpp: Validation functions for OpenGL ES 2.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES2.h" |
| 10 | #include "libANGLE/validationES.h" |
| 11 | #include "libANGLE/Context.h" |
| 12 | #include "libANGLE/Texture.h" |
| 13 | #include "libANGLE/Framebuffer.h" |
| 14 | #include "libANGLE/Renderbuffer.h" |
| 15 | #include "libANGLE/formatutils.h" |
| 16 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 17 | |
| 18 | #include "common/mathutil.h" |
| 19 | #include "common/utilities.h" |
| 20 | |
| 21 | namespace gl |
| 22 | { |
| 23 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 24 | bool ValidateES2TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, |
| 26 | GLint border, GLenum format, GLenum type, const GLvoid *pixels) |
| 27 | { |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 28 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 29 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 30 | context->recordError(Error(GL_INVALID_ENUM)); |
| 31 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 32 | } |
| 33 | |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 34 | if (!ValidImageSize(context, target, level, width, height, 1)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 35 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 36 | context->recordError(Error(GL_INVALID_VALUE)); |
| 37 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 38 | } |
| 39 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 40 | if (level < 0 || xoffset < 0 || |
| 41 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 42 | std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 43 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 44 | context->recordError(Error(GL_INVALID_VALUE)); |
| 45 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 46 | } |
| 47 | |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 48 | if (!isSubImage && !isCompressed && internalformat != format) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 49 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 50 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 51 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 52 | } |
| 53 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 54 | const gl::Caps &caps = context->getCaps(); |
| 55 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 56 | if (target == GL_TEXTURE_2D) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 57 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 58 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 59 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 60 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 61 | context->recordError(Error(GL_INVALID_VALUE)); |
| 62 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 63 | } |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 64 | } |
| 65 | else if (IsCubemapTextureTarget(target)) |
| 66 | { |
| 67 | if (!isSubImage && width != height) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 68 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 69 | context->recordError(Error(GL_INVALID_VALUE)); |
| 70 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 71 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 72 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 73 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level) || |
| 74 | static_cast<GLuint>(height) > (caps.maxCubeMapTextureSize >> level)) |
| 75 | { |
| 76 | context->recordError(Error(GL_INVALID_VALUE)); |
| 77 | return false; |
| 78 | } |
| 79 | } |
| 80 | else |
| 81 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 82 | context->recordError(Error(GL_INVALID_ENUM)); |
| 83 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 84 | } |
| 85 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 86 | gl::Texture *texture = context->getTargetTexture(IsCubemapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 87 | if (!texture) |
| 88 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 89 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 90 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 91 | } |
| 92 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 93 | if (isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 94 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 95 | if (format != GL_NONE) |
| 96 | { |
| 97 | if (gl::GetFormatTypeInfo(format, type).internalFormat != texture->getInternalFormat(target, level)) |
| 98 | { |
| 99 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 100 | return false; |
| 101 | } |
| 102 | } |
| 103 | |
| 104 | if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) || |
| 105 | static_cast<size_t>(yoffset + height) > texture->getHeight(target, level)) |
| 106 | { |
| 107 | context->recordError(Error(GL_INVALID_VALUE)); |
| 108 | return false; |
| 109 | } |
| 110 | } |
| 111 | else |
| 112 | { |
| 113 | if (texture->isImmutable()) |
| 114 | { |
| 115 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 116 | return false; |
| 117 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 118 | } |
| 119 | |
| 120 | // Verify zero border |
| 121 | if (border != 0) |
| 122 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 123 | context->recordError(Error(GL_INVALID_VALUE)); |
| 124 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 125 | } |
| 126 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame^] | 127 | GLenum actualInternalFormat = isSubImage ? texture->getInternalFormat(target, level) : internalformat; |
| 128 | const InternalFormat &actualFormatInfo = GetInternalFormatInfo(actualInternalFormat); |
| 129 | |
| 130 | if (isCompressed != actualFormatInfo.compressed) |
| 131 | { |
| 132 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 133 | return false; |
| 134 | } |
| 135 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 136 | if (isCompressed) |
| 137 | { |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 138 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
| 139 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 140 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 141 | return false; |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 142 | } |
| 143 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 144 | switch (actualInternalFormat) |
| 145 | { |
| 146 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 147 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 148 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 149 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 150 | context->recordError(Error(GL_INVALID_ENUM)); |
| 151 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 152 | } |
| 153 | break; |
| 154 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 155 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 156 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 157 | context->recordError(Error(GL_INVALID_ENUM)); |
| 158 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 159 | } |
| 160 | break; |
| 161 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 162 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 163 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 164 | context->recordError(Error(GL_INVALID_ENUM)); |
| 165 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 166 | } |
| 167 | break; |
| 168 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 169 | context->recordError(Error(GL_INVALID_ENUM)); |
| 170 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 171 | } |
| 172 | } |
| 173 | else |
| 174 | { |
| 175 | // validate <type> by itself (used as secondary key below) |
| 176 | switch (type) |
| 177 | { |
| 178 | case GL_UNSIGNED_BYTE: |
| 179 | case GL_UNSIGNED_SHORT_5_6_5: |
| 180 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 181 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 182 | case GL_UNSIGNED_SHORT: |
| 183 | case GL_UNSIGNED_INT: |
| 184 | case GL_UNSIGNED_INT_24_8_OES: |
| 185 | case GL_HALF_FLOAT_OES: |
| 186 | case GL_FLOAT: |
| 187 | break; |
| 188 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 189 | context->recordError(Error(GL_INVALID_ENUM)); |
| 190 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 191 | } |
| 192 | |
| 193 | // validate <format> + <type> combinations |
| 194 | // - invalid <format> -> sets INVALID_ENUM |
| 195 | // - invalid <format>+<type> combination -> sets INVALID_OPERATION |
| 196 | switch (format) |
| 197 | { |
| 198 | case GL_ALPHA: |
| 199 | case GL_LUMINANCE: |
| 200 | case GL_LUMINANCE_ALPHA: |
| 201 | switch (type) |
| 202 | { |
| 203 | case GL_UNSIGNED_BYTE: |
| 204 | case GL_FLOAT: |
| 205 | case GL_HALF_FLOAT_OES: |
| 206 | break; |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 207 | default: |
| 208 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 209 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 210 | } |
| 211 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 212 | case GL_RED: |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 213 | case GL_RG: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 214 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 215 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 216 | context->recordError(Error(GL_INVALID_ENUM)); |
| 217 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 218 | } |
| 219 | switch (type) |
| 220 | { |
| 221 | case GL_UNSIGNED_BYTE: |
| 222 | case GL_FLOAT: |
| 223 | case GL_HALF_FLOAT_OES: |
| 224 | break; |
| 225 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 226 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 227 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 228 | } |
| 229 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 230 | case GL_RGB: |
| 231 | switch (type) |
| 232 | { |
| 233 | case GL_UNSIGNED_BYTE: |
| 234 | case GL_UNSIGNED_SHORT_5_6_5: |
| 235 | case GL_FLOAT: |
| 236 | case GL_HALF_FLOAT_OES: |
| 237 | break; |
| 238 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 239 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 240 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 241 | } |
| 242 | break; |
| 243 | case GL_RGBA: |
| 244 | switch (type) |
| 245 | { |
| 246 | case GL_UNSIGNED_BYTE: |
| 247 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 248 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 249 | case GL_FLOAT: |
| 250 | case GL_HALF_FLOAT_OES: |
| 251 | break; |
| 252 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 253 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 254 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 255 | } |
| 256 | break; |
| 257 | case GL_BGRA_EXT: |
| 258 | switch (type) |
| 259 | { |
| 260 | case GL_UNSIGNED_BYTE: |
| 261 | break; |
| 262 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 263 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 264 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 265 | } |
| 266 | break; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 267 | case GL_SRGB_EXT: |
| 268 | case GL_SRGB_ALPHA_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 269 | if (!context->getExtensions().sRGB) |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 270 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 271 | context->recordError(Error(GL_INVALID_ENUM)); |
| 272 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 273 | } |
| 274 | switch (type) |
| 275 | { |
| 276 | case GL_UNSIGNED_BYTE: |
| 277 | break; |
| 278 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 279 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 280 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 281 | } |
| 282 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 283 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: // error cases for compressed textures are handled below |
| 284 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 285 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 286 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
| 287 | break; |
| 288 | case GL_DEPTH_COMPONENT: |
| 289 | switch (type) |
| 290 | { |
| 291 | case GL_UNSIGNED_SHORT: |
| 292 | case GL_UNSIGNED_INT: |
| 293 | break; |
| 294 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 295 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 296 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 297 | } |
| 298 | break; |
| 299 | case GL_DEPTH_STENCIL_OES: |
| 300 | switch (type) |
| 301 | { |
| 302 | case GL_UNSIGNED_INT_24_8_OES: |
| 303 | break; |
| 304 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 305 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 306 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 307 | } |
| 308 | break; |
| 309 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 310 | context->recordError(Error(GL_INVALID_ENUM)); |
| 311 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 312 | } |
| 313 | |
| 314 | switch (format) |
| 315 | { |
| 316 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 317 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 318 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 319 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 320 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 321 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 322 | } |
| 323 | else |
| 324 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 325 | context->recordError(Error(GL_INVALID_ENUM)); |
| 326 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 327 | } |
| 328 | break; |
| 329 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 330 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 331 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 332 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 333 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 334 | } |
| 335 | else |
| 336 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 337 | context->recordError(Error(GL_INVALID_ENUM)); |
| 338 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 339 | } |
| 340 | break; |
| 341 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 342 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 343 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 344 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 345 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 346 | } |
| 347 | else |
| 348 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 349 | context->recordError(Error(GL_INVALID_ENUM)); |
| 350 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 351 | } |
| 352 | break; |
| 353 | case GL_DEPTH_COMPONENT: |
| 354 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 355 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 356 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 357 | context->recordError(Error(GL_INVALID_VALUE)); |
| 358 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 359 | } |
| 360 | if (target != GL_TEXTURE_2D) |
| 361 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 362 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 363 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 364 | } |
| 365 | // OES_depth_texture supports loading depth data and multiple levels, |
| 366 | // but ANGLE_depth_texture does not |
| 367 | if (pixels != NULL || level != 0) |
| 368 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 369 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 370 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 371 | } |
| 372 | break; |
| 373 | default: |
| 374 | break; |
| 375 | } |
| 376 | |
| 377 | if (type == GL_FLOAT) |
| 378 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 379 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 380 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 381 | context->recordError(Error(GL_INVALID_ENUM)); |
| 382 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 383 | } |
| 384 | } |
| 385 | else if (type == GL_HALF_FLOAT_OES) |
| 386 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 387 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 388 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 389 | context->recordError(Error(GL_INVALID_ENUM)); |
| 390 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 391 | } |
| 392 | } |
| 393 | } |
| 394 | |
| 395 | return true; |
| 396 | } |
| 397 | |
| 398 | |
| 399 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 400 | bool ValidateES2CopyTexImageParameters(Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 401 | GLint xoffset, GLint yoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 402 | GLint border) |
| 403 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 404 | GLenum textureInternalFormat = GL_NONE; |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 405 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 406 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 407 | xoffset, yoffset, 0, x, y, width, height, border, &textureInternalFormat)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 408 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 409 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 410 | } |
| 411 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 412 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 413 | GLenum colorbufferFormat = framebuffer->getReadColorbuffer()->getInternalFormat(); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 414 | GLenum textureFormat = gl::GetInternalFormatInfo(textureInternalFormat).format; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 415 | |
| 416 | // [OpenGL ES 2.0.24] table 3.9 |
| 417 | if (isSubImage) |
| 418 | { |
| 419 | switch (textureFormat) |
| 420 | { |
| 421 | case GL_ALPHA: |
| 422 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 423 | colorbufferFormat != GL_RGBA4 && |
| 424 | colorbufferFormat != GL_RGB5_A1 && |
| 425 | colorbufferFormat != GL_RGBA8_OES) |
| 426 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 427 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 428 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 429 | } |
| 430 | break; |
| 431 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 432 | if (colorbufferFormat != GL_R8_EXT && |
| 433 | colorbufferFormat != GL_RG8_EXT && |
| 434 | colorbufferFormat != GL_RGB565 && |
| 435 | colorbufferFormat != GL_RGB8_OES && |
| 436 | colorbufferFormat != GL_RGBA4 && |
| 437 | colorbufferFormat != GL_RGB5_A1 && |
| 438 | colorbufferFormat != GL_RGBA8_OES) |
| 439 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 440 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 441 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 442 | } |
| 443 | break; |
| 444 | case GL_RED_EXT: |
| 445 | if (colorbufferFormat != GL_R8_EXT && |
| 446 | colorbufferFormat != GL_RG8_EXT && |
| 447 | colorbufferFormat != GL_RGB565 && |
| 448 | colorbufferFormat != GL_RGB8_OES && |
| 449 | colorbufferFormat != GL_RGBA4 && |
| 450 | colorbufferFormat != GL_RGB5_A1 && |
| 451 | colorbufferFormat != GL_RGBA8_OES) |
| 452 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 453 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 454 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 455 | } |
| 456 | break; |
| 457 | case GL_RG_EXT: |
| 458 | if (colorbufferFormat != GL_RG8_EXT && |
| 459 | colorbufferFormat != GL_RGB565 && |
| 460 | colorbufferFormat != GL_RGB8_OES && |
| 461 | colorbufferFormat != GL_RGBA4 && |
| 462 | colorbufferFormat != GL_RGB5_A1 && |
| 463 | colorbufferFormat != GL_RGBA8_OES) |
| 464 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 465 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 466 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 467 | } |
| 468 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 469 | case GL_RGB: |
| 470 | if (colorbufferFormat != GL_RGB565 && |
| 471 | colorbufferFormat != GL_RGB8_OES && |
| 472 | colorbufferFormat != GL_RGBA4 && |
| 473 | colorbufferFormat != GL_RGB5_A1 && |
| 474 | colorbufferFormat != GL_RGBA8_OES) |
| 475 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 476 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 477 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 478 | } |
| 479 | break; |
| 480 | case GL_LUMINANCE_ALPHA: |
| 481 | case GL_RGBA: |
| 482 | if (colorbufferFormat != GL_RGBA4 && |
| 483 | colorbufferFormat != GL_RGB5_A1 && |
| 484 | colorbufferFormat != GL_RGBA8_OES) |
| 485 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 486 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 487 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 488 | } |
| 489 | break; |
| 490 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 491 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 492 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 493 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 494 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 495 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 496 | case GL_DEPTH_COMPONENT: |
| 497 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 498 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 499 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 500 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 501 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 502 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 503 | } |
| 504 | } |
| 505 | else |
| 506 | { |
| 507 | switch (internalformat) |
| 508 | { |
| 509 | case GL_ALPHA: |
| 510 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 511 | colorbufferFormat != GL_RGBA4 && |
| 512 | colorbufferFormat != GL_RGB5_A1 && |
| 513 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 514 | colorbufferFormat != GL_RGBA8_OES && |
| 515 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 516 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 517 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 518 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 519 | } |
| 520 | break; |
| 521 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 522 | if (colorbufferFormat != GL_R8_EXT && |
| 523 | colorbufferFormat != GL_RG8_EXT && |
| 524 | colorbufferFormat != GL_RGB565 && |
| 525 | colorbufferFormat != GL_RGB8_OES && |
| 526 | colorbufferFormat != GL_RGBA4 && |
| 527 | colorbufferFormat != GL_RGB5_A1 && |
| 528 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 529 | colorbufferFormat != GL_RGBA8_OES && |
| 530 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 531 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 532 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 533 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 534 | } |
| 535 | break; |
| 536 | case GL_RED_EXT: |
| 537 | if (colorbufferFormat != GL_R8_EXT && |
| 538 | colorbufferFormat != GL_RG8_EXT && |
| 539 | colorbufferFormat != GL_RGB565 && |
| 540 | colorbufferFormat != GL_RGB8_OES && |
| 541 | colorbufferFormat != GL_RGBA4 && |
| 542 | colorbufferFormat != GL_RGB5_A1 && |
| 543 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 544 | colorbufferFormat != GL_RGBA8_OES && |
| 545 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 546 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 547 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 548 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 549 | } |
| 550 | break; |
| 551 | case GL_RG_EXT: |
| 552 | if (colorbufferFormat != GL_RG8_EXT && |
| 553 | colorbufferFormat != GL_RGB565 && |
| 554 | colorbufferFormat != GL_RGB8_OES && |
| 555 | colorbufferFormat != GL_RGBA4 && |
| 556 | colorbufferFormat != GL_RGB5_A1 && |
| 557 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 558 | colorbufferFormat != GL_RGBA8_OES && |
| 559 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 560 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 561 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 562 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 563 | } |
| 564 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 565 | case GL_RGB: |
| 566 | if (colorbufferFormat != GL_RGB565 && |
| 567 | colorbufferFormat != GL_RGB8_OES && |
| 568 | colorbufferFormat != GL_RGBA4 && |
| 569 | colorbufferFormat != GL_RGB5_A1 && |
| 570 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 571 | colorbufferFormat != GL_RGBA8_OES && |
| 572 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 573 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 574 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 575 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 576 | } |
| 577 | break; |
| 578 | case GL_LUMINANCE_ALPHA: |
| 579 | case GL_RGBA: |
| 580 | if (colorbufferFormat != GL_RGBA4 && |
| 581 | colorbufferFormat != GL_RGB5_A1 && |
| 582 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 583 | colorbufferFormat != GL_RGBA8_OES && |
| 584 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 585 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 586 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 587 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 588 | } |
| 589 | break; |
| 590 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 591 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 592 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 593 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 594 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 595 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 596 | } |
| 597 | else |
| 598 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 599 | context->recordError(Error(GL_INVALID_ENUM)); |
| 600 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 601 | } |
| 602 | break; |
| 603 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 604 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 605 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 606 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 607 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 608 | } |
| 609 | else |
| 610 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 611 | context->recordError(Error(GL_INVALID_ENUM)); |
| 612 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 613 | } |
| 614 | break; |
| 615 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 616 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 617 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 618 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 619 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 620 | } |
| 621 | else |
| 622 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 623 | context->recordError(Error(GL_INVALID_ENUM)); |
| 624 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 625 | } |
| 626 | break; |
| 627 | case GL_DEPTH_COMPONENT: |
| 628 | case GL_DEPTH_COMPONENT16: |
| 629 | case GL_DEPTH_COMPONENT32_OES: |
| 630 | case GL_DEPTH_STENCIL_OES: |
| 631 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 632 | if (context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 633 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 634 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 635 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 636 | } |
| 637 | else |
| 638 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 639 | context->recordError(Error(GL_INVALID_ENUM)); |
| 640 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 641 | } |
| 642 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 643 | context->recordError(Error(GL_INVALID_ENUM)); |
| 644 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 645 | } |
| 646 | } |
| 647 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 648 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 649 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 650 | } |
| 651 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 652 | bool ValidateES2TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 653 | GLsizei width, GLsizei height) |
| 654 | { |
| 655 | if (target != GL_TEXTURE_2D && target != GL_TEXTURE_CUBE_MAP) |
| 656 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 657 | context->recordError(Error(GL_INVALID_ENUM)); |
| 658 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 659 | } |
| 660 | |
| 661 | if (width < 1 || height < 1 || levels < 1) |
| 662 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 663 | context->recordError(Error(GL_INVALID_VALUE)); |
| 664 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 665 | } |
| 666 | |
| 667 | if (target == GL_TEXTURE_CUBE_MAP && width != height) |
| 668 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 669 | context->recordError(Error(GL_INVALID_VALUE)); |
| 670 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 671 | } |
| 672 | |
| 673 | if (levels != 1 && levels != gl::log2(std::max(width, height)) + 1) |
| 674 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 675 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 676 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 677 | } |
| 678 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 679 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 680 | if (formatInfo.format == GL_NONE || formatInfo.type == GL_NONE) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 681 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 682 | context->recordError(Error(GL_INVALID_ENUM)); |
| 683 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 684 | } |
| 685 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 686 | const gl::Caps &caps = context->getCaps(); |
| 687 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 688 | switch (target) |
| 689 | { |
| 690 | case GL_TEXTURE_2D: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 691 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 692 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 693 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 694 | context->recordError(Error(GL_INVALID_VALUE)); |
| 695 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 696 | } |
| 697 | break; |
| 698 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 699 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize || |
| 700 | static_cast<GLuint>(height) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 701 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 702 | context->recordError(Error(GL_INVALID_VALUE)); |
| 703 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 704 | } |
| 705 | break; |
| 706 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 707 | context->recordError(Error(GL_INVALID_ENUM)); |
| 708 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 709 | } |
| 710 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 711 | if (levels != 1 && !context->getExtensions().textureNPOT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 712 | { |
| 713 | if (!gl::isPow2(width) || !gl::isPow2(height)) |
| 714 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 715 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 716 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 717 | } |
| 718 | } |
| 719 | |
| 720 | switch (internalformat) |
| 721 | { |
| 722 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 723 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 724 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 725 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 726 | context->recordError(Error(GL_INVALID_ENUM)); |
| 727 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 728 | } |
| 729 | break; |
| 730 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 731 | if (!context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 732 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 733 | context->recordError(Error(GL_INVALID_ENUM)); |
| 734 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 735 | } |
| 736 | break; |
| 737 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 738 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 739 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 740 | context->recordError(Error(GL_INVALID_ENUM)); |
| 741 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 742 | } |
| 743 | break; |
| 744 | case GL_RGBA32F_EXT: |
| 745 | case GL_RGB32F_EXT: |
| 746 | case GL_ALPHA32F_EXT: |
| 747 | case GL_LUMINANCE32F_EXT: |
| 748 | case GL_LUMINANCE_ALPHA32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 749 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 750 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 751 | context->recordError(Error(GL_INVALID_ENUM)); |
| 752 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 753 | } |
| 754 | break; |
| 755 | case GL_RGBA16F_EXT: |
| 756 | case GL_RGB16F_EXT: |
| 757 | case GL_ALPHA16F_EXT: |
| 758 | case GL_LUMINANCE16F_EXT: |
| 759 | case GL_LUMINANCE_ALPHA16F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 760 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 761 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 762 | context->recordError(Error(GL_INVALID_ENUM)); |
| 763 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 764 | } |
| 765 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 766 | case GL_R8_EXT: |
| 767 | case GL_RG8_EXT: |
| 768 | case GL_R16F_EXT: |
| 769 | case GL_RG16F_EXT: |
| 770 | case GL_R32F_EXT: |
| 771 | case GL_RG32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 772 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 773 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 774 | context->recordError(Error(GL_INVALID_ENUM)); |
| 775 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 776 | } |
| 777 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 778 | case GL_DEPTH_COMPONENT16: |
| 779 | case GL_DEPTH_COMPONENT32_OES: |
| 780 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 781 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 782 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 783 | context->recordError(Error(GL_INVALID_ENUM)); |
| 784 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 785 | } |
| 786 | if (target != GL_TEXTURE_2D) |
| 787 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 788 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 789 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 790 | } |
| 791 | // ANGLE_depth_texture only supports 1-level textures |
| 792 | if (levels != 1) |
| 793 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 794 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 795 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 796 | } |
| 797 | break; |
| 798 | default: |
| 799 | break; |
| 800 | } |
| 801 | |
| 802 | gl::Texture *texture = NULL; |
| 803 | switch(target) |
| 804 | { |
| 805 | case GL_TEXTURE_2D: |
| 806 | texture = context->getTexture2D(); |
| 807 | break; |
| 808 | case GL_TEXTURE_CUBE_MAP: |
| 809 | texture = context->getTextureCubeMap(); |
| 810 | break; |
| 811 | default: |
| 812 | UNREACHABLE(); |
| 813 | } |
| 814 | |
| 815 | if (!texture || texture->id() == 0) |
| 816 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 817 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 818 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 819 | } |
| 820 | |
| 821 | if (texture->isImmutable()) |
| 822 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 823 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 824 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 825 | } |
| 826 | |
| 827 | return true; |
| 828 | } |
| 829 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 830 | // check for combinations of format and type that are valid for ReadPixels |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 831 | bool ValidES2ReadFormatType(Context *context, GLenum format, GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 832 | { |
| 833 | switch (format) |
| 834 | { |
| 835 | case GL_RGBA: |
| 836 | switch (type) |
| 837 | { |
| 838 | case GL_UNSIGNED_BYTE: |
| 839 | break; |
| 840 | default: |
| 841 | return false; |
| 842 | } |
| 843 | break; |
| 844 | case GL_BGRA_EXT: |
| 845 | switch (type) |
| 846 | { |
| 847 | case GL_UNSIGNED_BYTE: |
| 848 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 849 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 850 | break; |
| 851 | default: |
| 852 | return false; |
| 853 | } |
| 854 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 855 | case GL_RG_EXT: |
| 856 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 857 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 858 | { |
| 859 | return false; |
| 860 | } |
| 861 | switch (type) |
| 862 | { |
| 863 | case GL_UNSIGNED_BYTE: |
| 864 | break; |
| 865 | default: |
| 866 | return false; |
| 867 | } |
| 868 | break; |
| 869 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 870 | default: |
| 871 | return false; |
| 872 | } |
| 873 | return true; |
| 874 | } |
| 875 | |
| 876 | } |