daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 12 | #include "common/mathutil.h" |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 13 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 14 | #include "compiler/translator/Cache.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 15 | #include "compiler/translator/ValidateGlobalInitializer.h" |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 16 | #include "compiler/translator/ValidateSwitch.h" |
| 17 | #include "compiler/translator/glslang.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 18 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 19 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 20 | namespace sh |
| 21 | { |
| 22 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 23 | /////////////////////////////////////////////////////////////////////// |
| 24 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 25 | // Sub- vector and matrix fields |
| 26 | // |
| 27 | //////////////////////////////////////////////////////////////////////// |
| 28 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 29 | namespace |
| 30 | { |
| 31 | |
| 32 | const int kWebGLMaxStructNesting = 4; |
| 33 | |
| 34 | bool ContainsSampler(const TType &type) |
| 35 | { |
| 36 | if (IsSampler(type.getBasicType())) |
| 37 | return true; |
| 38 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 39 | if (type.getBasicType() == EbtStruct) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 40 | { |
| 41 | const TFieldList &fields = type.getStruct()->fields(); |
| 42 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 43 | { |
| 44 | if (ContainsSampler(*fields[i]->type())) |
| 45 | return true; |
| 46 | } |
| 47 | } |
| 48 | |
| 49 | return false; |
| 50 | } |
| 51 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 52 | // Get a token from an image argument to use as an error message token. |
| 53 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 54 | { |
| 55 | ASSERT(IsImage(imageNode->getBasicType())); |
| 56 | while (imageNode->getAsBinaryNode() && |
| 57 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 58 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 59 | { |
| 60 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 61 | } |
| 62 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 63 | if (imageSymbol) |
| 64 | { |
| 65 | return imageSymbol->getSymbol().c_str(); |
| 66 | } |
| 67 | return "image"; |
| 68 | } |
| 69 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 70 | bool CanSetDefaultPrecisionOnType(const TPublicType &type) |
| 71 | { |
| 72 | if (!SupportsPrecision(type.getBasicType())) |
| 73 | { |
| 74 | return false; |
| 75 | } |
| 76 | if (type.getBasicType() == EbtUInt) |
| 77 | { |
| 78 | // ESSL 3.00.4 section 4.5.4 |
| 79 | return false; |
| 80 | } |
| 81 | if (type.isAggregate()) |
| 82 | { |
| 83 | // Not allowed to set for aggregate types |
| 84 | return false; |
| 85 | } |
| 86 | return true; |
| 87 | } |
| 88 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 89 | } // namespace |
| 90 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 91 | // This tracks each binding point's current default offset for inheritance of subsequent |
| 92 | // variables using the same binding, and keeps offsets unique and non overlapping. |
| 93 | // See GLSL ES 3.1, section 4.4.6. |
| 94 | class TParseContext::AtomicCounterBindingState |
| 95 | { |
| 96 | public: |
| 97 | AtomicCounterBindingState() : mDefaultOffset(0) {} |
| 98 | // Inserts a new span and returns -1 if overlapping, else returns the starting offset of |
| 99 | // newly inserted span. |
| 100 | int insertSpan(int start, size_t length) |
| 101 | { |
| 102 | gl::RangeI newSpan(start, start + static_cast<int>(length)); |
| 103 | for (const auto &span : mSpans) |
| 104 | { |
| 105 | if (newSpan.intersects(span)) |
| 106 | { |
| 107 | return -1; |
| 108 | } |
| 109 | } |
| 110 | mSpans.push_back(newSpan); |
| 111 | mDefaultOffset = newSpan.high(); |
| 112 | return start; |
| 113 | } |
| 114 | // Inserts a new span starting from the default offset. |
| 115 | int appendSpan(size_t length) { return insertSpan(mDefaultOffset, length); } |
| 116 | void setDefaultOffset(int offset) { mDefaultOffset = offset; } |
| 117 | |
| 118 | private: |
| 119 | int mDefaultOffset; |
| 120 | std::vector<gl::RangeI> mSpans; |
| 121 | }; |
| 122 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 123 | TParseContext::TParseContext(TSymbolTable &symt, |
| 124 | TExtensionBehavior &ext, |
| 125 | sh::GLenum type, |
| 126 | ShShaderSpec spec, |
| 127 | ShCompileOptions options, |
| 128 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 129 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 130 | const ShBuiltInResources &resources) |
| 131 | : intermediate(), |
| 132 | symbolTable(symt), |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 133 | mDeferredNonEmptyDeclarationErrorCheck(false), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 134 | mShaderType(type), |
| 135 | mShaderSpec(spec), |
| 136 | mCompileOptions(options), |
| 137 | mShaderVersion(100), |
| 138 | mTreeRoot(nullptr), |
| 139 | mLoopNestingLevel(0), |
| 140 | mStructNestingLevel(0), |
| 141 | mSwitchNestingLevel(0), |
| 142 | mCurrentFunctionType(nullptr), |
| 143 | mFunctionReturnsValue(false), |
| 144 | mChecksPrecisionErrors(checksPrecErrors), |
| 145 | mFragmentPrecisionHighOnESSL1(false), |
| 146 | mDefaultMatrixPacking(EmpColumnMajor), |
| 147 | mDefaultBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 148 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 149 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 150 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 151 | mShaderVersion, |
| 152 | mShaderType, |
| 153 | resources.WEBGL_debug_shader_precision == 1), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 154 | mPreprocessor(mDiagnostics, &mDirectiveHandler, pp::PreprocessorSettings()), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 155 | mScanner(nullptr), |
| 156 | mUsesFragData(false), |
| 157 | mUsesFragColor(false), |
| 158 | mUsesSecondaryOutputs(false), |
| 159 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 160 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 161 | mMultiviewAvailable(resources.OVR_multiview == 1), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 162 | mComputeShaderLocalSizeDeclared(false), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 163 | mNumViews(-1), |
| 164 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 165 | mMaxImageUnits(resources.MaxImageUnits), |
| 166 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 167 | mMaxUniformLocations(resources.MaxUniformLocations), |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 168 | mMaxUniformBufferBindings(resources.MaxUniformBufferBindings), |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 169 | mMaxAtomicCounterBindings(resources.MaxAtomicCounterBindings), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 170 | mDeclaringFunction(false) |
| 171 | { |
| 172 | mComputeShaderLocalSize.fill(-1); |
| 173 | } |
| 174 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 175 | TParseContext::~TParseContext() |
| 176 | { |
| 177 | } |
| 178 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 179 | // |
| 180 | // Look at a '.' field selector string and change it into offsets |
| 181 | // for a vector. |
| 182 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 183 | bool TParseContext::parseVectorFields(const TString &compString, |
| 184 | int vecSize, |
| 185 | TVectorFields &fields, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 186 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 187 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 188 | fields.num = (int)compString.size(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 189 | if (fields.num > 4) |
| 190 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 191 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 192 | return false; |
| 193 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 194 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 195 | enum |
| 196 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 197 | exyzw, |
| 198 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 199 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 200 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 201 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 202 | for (int i = 0; i < fields.num; ++i) |
| 203 | { |
| 204 | switch (compString[i]) |
| 205 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 206 | case 'x': |
| 207 | fields.offsets[i] = 0; |
| 208 | fieldSet[i] = exyzw; |
| 209 | break; |
| 210 | case 'r': |
| 211 | fields.offsets[i] = 0; |
| 212 | fieldSet[i] = ergba; |
| 213 | break; |
| 214 | case 's': |
| 215 | fields.offsets[i] = 0; |
| 216 | fieldSet[i] = estpq; |
| 217 | break; |
| 218 | case 'y': |
| 219 | fields.offsets[i] = 1; |
| 220 | fieldSet[i] = exyzw; |
| 221 | break; |
| 222 | case 'g': |
| 223 | fields.offsets[i] = 1; |
| 224 | fieldSet[i] = ergba; |
| 225 | break; |
| 226 | case 't': |
| 227 | fields.offsets[i] = 1; |
| 228 | fieldSet[i] = estpq; |
| 229 | break; |
| 230 | case 'z': |
| 231 | fields.offsets[i] = 2; |
| 232 | fieldSet[i] = exyzw; |
| 233 | break; |
| 234 | case 'b': |
| 235 | fields.offsets[i] = 2; |
| 236 | fieldSet[i] = ergba; |
| 237 | break; |
| 238 | case 'p': |
| 239 | fields.offsets[i] = 2; |
| 240 | fieldSet[i] = estpq; |
| 241 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 242 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 243 | case 'w': |
| 244 | fields.offsets[i] = 3; |
| 245 | fieldSet[i] = exyzw; |
| 246 | break; |
| 247 | case 'a': |
| 248 | fields.offsets[i] = 3; |
| 249 | fieldSet[i] = ergba; |
| 250 | break; |
| 251 | case 'q': |
| 252 | fields.offsets[i] = 3; |
| 253 | fieldSet[i] = estpq; |
| 254 | break; |
| 255 | default: |
| 256 | error(line, "illegal vector field selection", compString.c_str()); |
| 257 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 258 | } |
| 259 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 260 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 261 | for (int i = 0; i < fields.num; ++i) |
| 262 | { |
| 263 | if (fields.offsets[i] >= vecSize) |
| 264 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 265 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 266 | return false; |
| 267 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 268 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 269 | if (i > 0) |
| 270 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 271 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 272 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 273 | error(line, "illegal - vector component fields not from the same set", |
| 274 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 275 | return false; |
| 276 | } |
| 277 | } |
| 278 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 279 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 280 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 281 | } |
| 282 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 283 | /////////////////////////////////////////////////////////////////////// |
| 284 | // |
| 285 | // Errors |
| 286 | // |
| 287 | //////////////////////////////////////////////////////////////////////// |
| 288 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 289 | // |
| 290 | // Used by flex/bison to output all syntax and parsing errors. |
| 291 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 292 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 293 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 294 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 295 | } |
| 296 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 297 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 298 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 299 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 300 | } |
| 301 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 302 | void TParseContext::outOfRangeError(bool isError, |
| 303 | const TSourceLoc &loc, |
| 304 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 305 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 306 | { |
| 307 | if (isError) |
| 308 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 309 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 310 | } |
| 311 | else |
| 312 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 313 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 314 | } |
| 315 | } |
| 316 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 317 | // |
| 318 | // Same error message for all places assignments don't work. |
| 319 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 320 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 321 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 322 | std::stringstream reasonStream; |
| 323 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 324 | std::string reason = reasonStream.str(); |
| 325 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 326 | } |
| 327 | |
| 328 | // |
| 329 | // Same error message for all places unary operations don't work. |
| 330 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 331 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 332 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 333 | std::stringstream reasonStream; |
| 334 | reasonStream << "wrong operand type - no operation '" << op |
| 335 | << "' exists that takes an operand of type " << operand |
| 336 | << " (or there is no acceptable conversion)"; |
| 337 | std::string reason = reasonStream.str(); |
| 338 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 339 | } |
| 340 | |
| 341 | // |
| 342 | // Same error message for all binary operations don't work. |
| 343 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 344 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 345 | const char *op, |
| 346 | TString left, |
| 347 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 348 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 349 | std::stringstream reasonStream; |
| 350 | reasonStream << "wrong operand types - no operation '" << op |
| 351 | << "' exists that takes a left-hand operand of type '" << left |
| 352 | << "' and a right operand of type '" << right |
| 353 | << "' (or there is no acceptable conversion)"; |
| 354 | std::string reason = reasonStream.str(); |
| 355 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 356 | } |
| 357 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 358 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 359 | TPrecision precision, |
| 360 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 361 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 362 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 363 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 364 | |
| 365 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 366 | { |
| 367 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 368 | } |
| 369 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 370 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 371 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 372 | switch (type) |
| 373 | { |
| 374 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 375 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 376 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 377 | case EbtInt: |
| 378 | case EbtUInt: |
| 379 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 380 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 381 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 382 | default: |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 383 | if (IsOpaqueType(type)) |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 384 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 385 | error(line, "No precision specified", getBasicString(type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 386 | return; |
| 387 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 388 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 389 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 390 | } |
| 391 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 392 | // Both test and if necessary, spit out an error, to see if the node is really |
| 393 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 394 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 395 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 396 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 397 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 398 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 399 | |
| 400 | if (swizzleNode) |
| 401 | { |
| 402 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 403 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 404 | { |
| 405 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 406 | return false; |
| 407 | } |
| 408 | return ok; |
| 409 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 410 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 411 | if (binaryNode) |
| 412 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 413 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 414 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 415 | case EOpIndexDirect: |
| 416 | case EOpIndexIndirect: |
| 417 | case EOpIndexDirectStruct: |
| 418 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 419 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 420 | default: |
| 421 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 422 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 423 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 424 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 425 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 426 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 427 | std::string message; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 428 | switch (node->getQualifier()) |
| 429 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 430 | case EvqConst: |
| 431 | message = "can't modify a const"; |
| 432 | break; |
| 433 | case EvqConstReadOnly: |
| 434 | message = "can't modify a const"; |
| 435 | break; |
| 436 | case EvqAttribute: |
| 437 | message = "can't modify an attribute"; |
| 438 | break; |
| 439 | case EvqFragmentIn: |
| 440 | message = "can't modify an input"; |
| 441 | break; |
| 442 | case EvqVertexIn: |
| 443 | message = "can't modify an input"; |
| 444 | break; |
| 445 | case EvqUniform: |
| 446 | message = "can't modify a uniform"; |
| 447 | break; |
| 448 | case EvqVaryingIn: |
| 449 | message = "can't modify a varying"; |
| 450 | break; |
| 451 | case EvqFragCoord: |
| 452 | message = "can't modify gl_FragCoord"; |
| 453 | break; |
| 454 | case EvqFrontFacing: |
| 455 | message = "can't modify gl_FrontFacing"; |
| 456 | break; |
| 457 | case EvqPointCoord: |
| 458 | message = "can't modify gl_PointCoord"; |
| 459 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 460 | case EvqNumWorkGroups: |
| 461 | message = "can't modify gl_NumWorkGroups"; |
| 462 | break; |
| 463 | case EvqWorkGroupSize: |
| 464 | message = "can't modify gl_WorkGroupSize"; |
| 465 | break; |
| 466 | case EvqWorkGroupID: |
| 467 | message = "can't modify gl_WorkGroupID"; |
| 468 | break; |
| 469 | case EvqLocalInvocationID: |
| 470 | message = "can't modify gl_LocalInvocationID"; |
| 471 | break; |
| 472 | case EvqGlobalInvocationID: |
| 473 | message = "can't modify gl_GlobalInvocationID"; |
| 474 | break; |
| 475 | case EvqLocalInvocationIndex: |
| 476 | message = "can't modify gl_LocalInvocationIndex"; |
| 477 | break; |
Olli Etuaho | 7142f6c | 2017-05-05 17:07:26 +0300 | [diff] [blame] | 478 | case EvqViewIDOVR: |
| 479 | message = "can't modify gl_ViewID_OVR"; |
| 480 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 481 | case EvqComputeIn: |
| 482 | message = "can't modify work group size variable"; |
| 483 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 484 | default: |
| 485 | // |
| 486 | // Type that can't be written to? |
| 487 | // |
| 488 | if (node->getBasicType() == EbtVoid) |
| 489 | { |
| 490 | message = "can't modify void"; |
| 491 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 492 | if (IsOpaqueType(node->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 493 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 494 | message = "can't modify a variable with type "; |
| 495 | message += getBasicString(node->getBasicType()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 496 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 497 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 498 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 499 | if (message.empty() && binaryNode == 0 && symNode == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 500 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 501 | error(line, "l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 502 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 503 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 504 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 505 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 506 | // |
| 507 | // Everything else is okay, no error. |
| 508 | // |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 509 | if (message.empty()) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 510 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 511 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 512 | // |
| 513 | // If we get here, we have an error and a message. |
| 514 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 515 | if (symNode) |
| 516 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 517 | const char *symbol = symNode->getSymbol().c_str(); |
| 518 | std::stringstream reasonStream; |
| 519 | reasonStream << "l-value required (" << message << " \"" << symbol << "\")"; |
| 520 | std::string reason = reasonStream.str(); |
| 521 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 522 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 523 | else |
| 524 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 525 | std::stringstream reasonStream; |
| 526 | reasonStream << "l-value required (" << message << ")"; |
| 527 | std::string reason = reasonStream.str(); |
| 528 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 529 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 530 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 531 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 532 | } |
| 533 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 534 | // Both test, and if necessary spit out an error, to see if the node is really |
| 535 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 536 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 537 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 538 | if (node->getQualifier() != EvqConst) |
| 539 | { |
| 540 | error(node->getLine(), "constant expression required", ""); |
| 541 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 542 | } |
| 543 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 544 | // Both test, and if necessary spit out an error, to see if the node is really |
| 545 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 546 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 547 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 548 | if (!node->isScalarInt()) |
| 549 | { |
| 550 | error(node->getLine(), "integer expression required", token); |
| 551 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 552 | } |
| 553 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 554 | // Both test, and if necessary spit out an error, to see if we are currently |
| 555 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 556 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 557 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 558 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 559 | { |
| 560 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 561 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 562 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 563 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 564 | } |
| 565 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 566 | // For now, keep it simple: if it starts "gl_", it's reserved, independent |
| 567 | // of scope. Except, if the symbol table is at the built-in push-level, |
| 568 | // which is when we are parsing built-ins. |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 569 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a |
| 570 | // webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 571 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 572 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 573 | static const char *reservedErrMsg = "reserved built-in name"; |
| 574 | if (!symbolTable.atBuiltInLevel()) |
| 575 | { |
| 576 | if (identifier.compare(0, 3, "gl_") == 0) |
| 577 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 578 | error(line, reservedErrMsg, "gl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 579 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 580 | } |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 581 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 582 | { |
| 583 | if (identifier.compare(0, 6, "webgl_") == 0) |
| 584 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 585 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 586 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 587 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 588 | if (identifier.compare(0, 7, "_webgl_") == 0) |
| 589 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 590 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 591 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 592 | } |
| 593 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 594 | if (identifier.find("__") != TString::npos) |
| 595 | { |
| 596 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 597 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 598 | "possible future keywords", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 599 | identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 600 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 601 | } |
| 602 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 603 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 604 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 605 | } |
| 606 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 607 | // Make sure the argument types are correct for constructing a specific type. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 608 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 609 | const TIntermSequence *arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 610 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 611 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 612 | if (arguments->empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 613 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 614 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 615 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 616 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 617 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 618 | for (TIntermNode *arg : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 619 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 620 | const TIntermTyped *argTyped = arg->getAsTyped(); |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 621 | ASSERT(argTyped != nullptr); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 622 | if (type.getBasicType() != EbtStruct && IsOpaqueType(argTyped->getBasicType())) |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 623 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 624 | std::string reason("cannot convert a variable with type "); |
| 625 | reason += getBasicString(argTyped->getBasicType()); |
| 626 | error(line, reason.c_str(), "constructor"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 627 | return false; |
| 628 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 629 | if (argTyped->getBasicType() == EbtVoid) |
| 630 | { |
| 631 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 632 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 633 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 634 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 635 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 636 | if (type.isArray()) |
| 637 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 638 | // The size of an unsized constructor should already have been determined. |
| 639 | ASSERT(!type.isUnsizedArray()); |
| 640 | if (static_cast<size_t>(type.getArraySize()) != arguments->size()) |
| 641 | { |
| 642 | error(line, "array constructor needs one argument per array element", "constructor"); |
| 643 | return false; |
| 644 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 645 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 646 | // the array. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 647 | for (TIntermNode *const &argNode : *arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 648 | { |
| 649 | const TType &argType = argNode->getAsTyped()->getType(); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 650 | if (argType.isArray()) |
| 651 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 652 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 653 | return false; |
| 654 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 655 | if (!argType.sameElementType(type)) |
| 656 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 657 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 658 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 659 | } |
| 660 | } |
| 661 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 662 | else if (type.getBasicType() == EbtStruct) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 663 | { |
| 664 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 665 | if (fields.size() != arguments->size()) |
| 666 | { |
| 667 | error(line, |
| 668 | "Number of constructor parameters does not match the number of structure fields", |
| 669 | "constructor"); |
| 670 | return false; |
| 671 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 672 | |
| 673 | for (size_t i = 0; i < fields.size(); i++) |
| 674 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 675 | if (i >= arguments->size() || |
| 676 | (*arguments)[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 677 | { |
| 678 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 679 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 680 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 681 | } |
| 682 | } |
| 683 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 684 | else |
| 685 | { |
| 686 | // We're constructing a scalar, vector, or matrix. |
| 687 | |
| 688 | // Note: It's okay to have too many components available, but not okay to have unused |
| 689 | // arguments. 'full' will go to true when enough args have been seen. If we loop again, |
| 690 | // there is an extra argument, so 'overFull' will become true. |
| 691 | |
| 692 | size_t size = 0; |
| 693 | bool full = false; |
| 694 | bool overFull = false; |
| 695 | bool matrixArg = false; |
| 696 | for (TIntermNode *arg : *arguments) |
| 697 | { |
| 698 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 699 | ASSERT(argTyped != nullptr); |
| 700 | |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 701 | if (argTyped->getBasicType() == EbtStruct) |
| 702 | { |
| 703 | error(line, "a struct cannot be used as a constructor argument for this type", |
| 704 | "constructor"); |
| 705 | return false; |
| 706 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 707 | if (argTyped->getType().isArray()) |
| 708 | { |
| 709 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 710 | return false; |
| 711 | } |
| 712 | if (argTyped->getType().isMatrix()) |
| 713 | { |
| 714 | matrixArg = true; |
| 715 | } |
| 716 | |
| 717 | size += argTyped->getType().getObjectSize(); |
| 718 | if (full) |
| 719 | { |
| 720 | overFull = true; |
| 721 | } |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 722 | if (size >= type.getObjectSize()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 723 | { |
| 724 | full = true; |
| 725 | } |
| 726 | } |
| 727 | |
| 728 | if (type.isMatrix() && matrixArg) |
| 729 | { |
| 730 | if (arguments->size() != 1) |
| 731 | { |
| 732 | error(line, "constructing matrix from matrix can only take one argument", |
| 733 | "constructor"); |
| 734 | return false; |
| 735 | } |
| 736 | } |
| 737 | else |
| 738 | { |
| 739 | if (size != 1 && size < type.getObjectSize()) |
| 740 | { |
| 741 | error(line, "not enough data provided for construction", "constructor"); |
| 742 | return false; |
| 743 | } |
| 744 | if (overFull) |
| 745 | { |
| 746 | error(line, "too many arguments", "constructor"); |
| 747 | return false; |
| 748 | } |
| 749 | } |
| 750 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 751 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 752 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 753 | } |
| 754 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 755 | // This function checks to see if a void variable has been declared and raise an error message for |
| 756 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 757 | // |
| 758 | // returns true in case of an error |
| 759 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 760 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 761 | const TString &identifier, |
| 762 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 763 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 764 | if (type == EbtVoid) |
| 765 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 766 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 767 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 768 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 769 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 770 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 771 | } |
| 772 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 773 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 774 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 775 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 776 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 777 | if (type->getBasicType() != EbtBool || type->isArray() || type->isMatrix() || type->isVector()) |
| 778 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 779 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 780 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 781 | } |
| 782 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 783 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 784 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 785 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 786 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 787 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 788 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 789 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 790 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 791 | } |
| 792 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 793 | bool TParseContext::checkIsNotOpaqueType(const TSourceLoc &line, |
| 794 | const TTypeSpecifierNonArray &pType, |
| 795 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 796 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 797 | if (pType.type == EbtStruct) |
| 798 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 799 | if (ContainsSampler(*pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 800 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 801 | std::stringstream reasonStream; |
| 802 | reasonStream << reason << " (structure contains a sampler)"; |
| 803 | std::string reasonStr = reasonStream.str(); |
| 804 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 805 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 806 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 807 | // only samplers need to be checked from structs, since other opaque types can't be struct |
| 808 | // members. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 809 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 810 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 811 | else if (IsOpaqueType(pType.type)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 812 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 813 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 814 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 815 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 816 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 817 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 818 | } |
| 819 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 820 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 821 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 822 | { |
| 823 | if (pType.layoutQualifier.location != -1) |
| 824 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 825 | error(line, "location must only be specified for a single input or output variable", |
| 826 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 827 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 828 | } |
| 829 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 830 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 831 | const TLayoutQualifier &layoutQualifier) |
| 832 | { |
| 833 | if (layoutQualifier.location != -1) |
| 834 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 835 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 836 | if (mShaderVersion >= 310) |
| 837 | { |
| 838 | errorMsg = |
| 839 | "invalid layout qualifier: only valid on program inputs, outputs, and uniforms"; |
| 840 | } |
| 841 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 842 | } |
| 843 | } |
| 844 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 845 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 846 | TQualifier qualifier, |
| 847 | const TType &type) |
| 848 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 849 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 850 | if (IsOpaqueType(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 851 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 852 | error(line, "opaque types cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 853 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 854 | } |
| 855 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 856 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 857 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 858 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 859 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 860 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 861 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 862 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 863 | // fold as array size. |
| 864 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 865 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 866 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 867 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 868 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 869 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 870 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 871 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 872 | if (constant->getBasicType() == EbtUInt) |
| 873 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 874 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 875 | } |
| 876 | else |
| 877 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 878 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 879 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 880 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 881 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 882 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 883 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 884 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 885 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 886 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 887 | } |
| 888 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 889 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 890 | { |
| 891 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 892 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 893 | } |
| 894 | |
| 895 | // The size of arrays is restricted here to prevent issues further down the |
| 896 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 897 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 898 | const unsigned int sizeLimit = 65536; |
| 899 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 900 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 901 | { |
| 902 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 903 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 904 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 905 | |
| 906 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 907 | } |
| 908 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 909 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 910 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 911 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 912 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 913 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 914 | (elementQualifier.qualifier == EvqVertexIn) || |
| 915 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 916 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 917 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 918 | TType(elementQualifier).getQualifierString()); |
| 919 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 920 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 921 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 922 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 923 | } |
| 924 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 925 | // See if this element type can be formed into an array. |
| 926 | bool TParseContext::checkIsValidTypeForArray(const TSourceLoc &line, const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 927 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 928 | // |
| 929 | // Can the type be an array? |
| 930 | // |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 931 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 932 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 933 | error(line, "cannot declare arrays of arrays", |
| 934 | TType(elementType).getCompleteString().c_str()); |
| 935 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 936 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 937 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 938 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 939 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 940 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 941 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 942 | { |
| 943 | error(line, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 944 | TType(elementType).getCompleteString().c_str()); |
| 945 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 946 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 947 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 948 | return true; |
| 949 | } |
| 950 | |
| 951 | // Check if this qualified element type can be formed into an array. |
| 952 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 953 | const TPublicType &elementType) |
| 954 | { |
| 955 | if (checkIsValidTypeForArray(indexLocation, elementType)) |
| 956 | { |
| 957 | return checkIsValidQualifierForArray(indexLocation, elementType); |
| 958 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 959 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 960 | } |
| 961 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 962 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 963 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 964 | const TString &identifier, |
| 965 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 966 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 967 | ASSERT(type != nullptr); |
| 968 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 969 | { |
| 970 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 971 | type->qualifier = EvqTemporary; |
| 972 | |
| 973 | // Generate informative error messages for ESSL1. |
| 974 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 975 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 976 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 977 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 978 | "structures containing arrays may not be declared constant since they cannot be " |
| 979 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 980 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 981 | } |
| 982 | else |
| 983 | { |
| 984 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 985 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 986 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 987 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 988 | if (type->isUnsizedArray()) |
| 989 | { |
| 990 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 991 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 992 | } |
| 993 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 994 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 995 | // and update the symbol table. |
| 996 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 997 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 998 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 999 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 1000 | const TString &identifier, |
| 1001 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1002 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1003 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1004 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1005 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1006 | checkBindingIsValid(line, type); |
| 1007 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1008 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1009 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1010 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 1011 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 1012 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1013 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 1014 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1015 | if (static_cast<int>(type.getArraySize()) == maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1016 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1017 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1018 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1019 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1020 | } |
| 1021 | } |
| 1022 | else |
| 1023 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1024 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 1025 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1026 | return false; |
| 1027 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1028 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1029 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1030 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1031 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1032 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1033 | (*variable) = new TVariable(&identifier, type); |
| 1034 | if (!symbolTable.declare(*variable)) |
| 1035 | { |
| 1036 | error(line, "redefinition", identifier.c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 1037 | *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1038 | return false; |
| 1039 | } |
| 1040 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1041 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1042 | return false; |
| 1043 | |
| 1044 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1045 | } |
| 1046 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1047 | void TParseContext::checkIsParameterQualifierValid( |
| 1048 | const TSourceLoc &line, |
| 1049 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1050 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1051 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 1052 | // The only parameter qualifiers a parameter can have are in, out, inout or const. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1053 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1054 | |
| 1055 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1056 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1057 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1058 | } |
| 1059 | |
| 1060 | if (!IsImage(type->getBasicType())) |
| 1061 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1062 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1063 | } |
| 1064 | else |
| 1065 | { |
| 1066 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1067 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1068 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1069 | type->setQualifier(typeQualifier.qualifier); |
| 1070 | |
| 1071 | if (typeQualifier.precision != EbpUndefined) |
| 1072 | { |
| 1073 | type->setPrecision(typeQualifier.precision); |
| 1074 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1075 | } |
| 1076 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1077 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1078 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1079 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1080 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1081 | if (iter == extBehavior.end()) |
| 1082 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1083 | error(line, "extension is not supported", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1084 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1085 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 1086 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1087 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 1088 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1089 | // TODO(oetuaho@nvidia.com): This is slightly hacky. Might be better if symbols could be |
| 1090 | // associated with more than one extension. |
| 1091 | if (extension == "GL_OVR_multiview") |
| 1092 | { |
| 1093 | return checkCanUseExtension(line, "GL_OVR_multiview2"); |
| 1094 | } |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1095 | error(line, "extension is disabled", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1096 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1097 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1098 | if (iter->second == EBhWarn) |
| 1099 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1100 | warning(line, "extension is being used", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1101 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1102 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1103 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1104 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1105 | } |
| 1106 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1107 | // ESSL 3.00.6 section 4.8 Empty Declarations: "The combinations of qualifiers that cause |
| 1108 | // compile-time or link-time errors are the same whether or not the declaration is empty". |
| 1109 | // This function implements all the checks that are done on qualifiers regardless of if the |
| 1110 | // declaration is empty. |
| 1111 | void TParseContext::declarationQualifierErrorCheck(const sh::TQualifier qualifier, |
| 1112 | const sh::TLayoutQualifier &layoutQualifier, |
| 1113 | const TSourceLoc &location) |
| 1114 | { |
| 1115 | if (qualifier == EvqShared && !layoutQualifier.isEmpty()) |
| 1116 | { |
| 1117 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1118 | } |
| 1119 | |
| 1120 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1121 | { |
| 1122 | error(location, "layout qualifier only valid for interface blocks", |
| 1123 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
| 1124 | return; |
| 1125 | } |
| 1126 | |
| 1127 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1128 | { |
| 1129 | error(location, "layout qualifier only valid for interface blocks", |
| 1130 | getBlockStorageString(layoutQualifier.blockStorage)); |
| 1131 | return; |
| 1132 | } |
| 1133 | |
| 1134 | if (qualifier == EvqFragmentOut) |
| 1135 | { |
| 1136 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1137 | { |
| 1138 | error(location, "invalid layout qualifier combination", "yuv"); |
| 1139 | return; |
| 1140 | } |
| 1141 | } |
| 1142 | else |
| 1143 | { |
| 1144 | checkYuvIsNotSpecified(location, layoutQualifier.yuv); |
| 1145 | } |
| 1146 | |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 1147 | // If multiview extension is enabled, "in" qualifier is allowed in the vertex shader in previous |
| 1148 | // parsing steps. So it needs to be checked here. |
| 1149 | if (isMultiviewExtensionEnabled() && mShaderVersion < 300 && qualifier == EvqVertexIn) |
| 1150 | { |
| 1151 | error(location, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 1152 | } |
| 1153 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1154 | bool canHaveLocation = qualifier == EvqVertexIn || qualifier == EvqFragmentOut; |
| 1155 | if (mShaderVersion >= 310 && qualifier == EvqUniform) |
| 1156 | { |
| 1157 | canHaveLocation = true; |
| 1158 | // We're not checking whether the uniform location is in range here since that depends on |
| 1159 | // the type of the variable. |
| 1160 | // The type can only be fully determined for non-empty declarations. |
| 1161 | } |
| 1162 | if (!canHaveLocation) |
| 1163 | { |
| 1164 | checkLocationIsNotSpecified(location, layoutQualifier); |
| 1165 | } |
| 1166 | } |
| 1167 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1168 | void TParseContext::atomicCounterQualifierErrorCheck(const TPublicType &publicType, |
| 1169 | const TSourceLoc &location) |
| 1170 | { |
| 1171 | if (publicType.precision != EbpHigh) |
| 1172 | { |
| 1173 | error(location, "Can only be highp", "atomic counter"); |
| 1174 | } |
| 1175 | // dEQP enforces compile error if location is specified. See uniform_location.test. |
| 1176 | if (publicType.layoutQualifier.location != -1) |
| 1177 | { |
| 1178 | error(location, "location must not be set for atomic_uint", "layout"); |
| 1179 | } |
| 1180 | if (publicType.layoutQualifier.binding == -1) |
| 1181 | { |
| 1182 | error(location, "no binding specified", "atomic counter"); |
| 1183 | } |
| 1184 | } |
| 1185 | |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1186 | void TParseContext::emptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1187 | const TSourceLoc &location) |
| 1188 | { |
| 1189 | if (publicType.isUnsizedArray()) |
| 1190 | { |
| 1191 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1192 | // error. It is assumed that this applies to empty declarations as well. |
| 1193 | error(location, "empty array declaration needs to specify a size", ""); |
| 1194 | } |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1195 | } |
| 1196 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1197 | // These checks are done for all declarations that are non-empty. They're done for non-empty |
| 1198 | // declarations starting a declarator list, and declarators that follow an empty declaration. |
| 1199 | void TParseContext::nonEmptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1200 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1201 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1202 | switch (publicType.qualifier) |
| 1203 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1204 | case EvqVaryingIn: |
| 1205 | case EvqVaryingOut: |
| 1206 | case EvqAttribute: |
| 1207 | case EvqVertexIn: |
| 1208 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1209 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1210 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1211 | { |
| 1212 | error(identifierLocation, "cannot be used with a structure", |
| 1213 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1214 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1215 | } |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1216 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1217 | default: |
| 1218 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1219 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1220 | std::string reason(getBasicString(publicType.getBasicType())); |
| 1221 | reason += "s must be uniform"; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1222 | if (publicType.qualifier != EvqUniform && |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1223 | !checkIsNotOpaqueType(identifierLocation, publicType.typeSpecifierNonArray, reason.c_str())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1224 | { |
| 1225 | return; |
| 1226 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1227 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1228 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1229 | publicType.qualifier != EvqConst) && |
| 1230 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1231 | { |
| 1232 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1233 | getQualifierString(publicType.qualifier)); |
| 1234 | return; |
| 1235 | } |
| 1236 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1237 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1238 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1239 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1240 | // But invalid shaders may still reach here with an unsized array declaration. |
| 1241 | if (!publicType.isUnsizedArray()) |
| 1242 | { |
| 1243 | TType type(publicType); |
| 1244 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1245 | publicType.layoutQualifier); |
| 1246 | } |
| 1247 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1248 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1249 | // check for layout qualifier issues |
| 1250 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1251 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1252 | if (IsImage(publicType.getBasicType())) |
| 1253 | { |
| 1254 | |
| 1255 | switch (layoutQualifier.imageInternalFormat) |
| 1256 | { |
| 1257 | case EiifRGBA32F: |
| 1258 | case EiifRGBA16F: |
| 1259 | case EiifR32F: |
| 1260 | case EiifRGBA8: |
| 1261 | case EiifRGBA8_SNORM: |
| 1262 | if (!IsFloatImage(publicType.getBasicType())) |
| 1263 | { |
| 1264 | error(identifierLocation, |
| 1265 | "internal image format requires a floating image type", |
| 1266 | getBasicString(publicType.getBasicType())); |
| 1267 | return; |
| 1268 | } |
| 1269 | break; |
| 1270 | case EiifRGBA32I: |
| 1271 | case EiifRGBA16I: |
| 1272 | case EiifRGBA8I: |
| 1273 | case EiifR32I: |
| 1274 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1275 | { |
| 1276 | error(identifierLocation, |
| 1277 | "internal image format requires an integer image type", |
| 1278 | getBasicString(publicType.getBasicType())); |
| 1279 | return; |
| 1280 | } |
| 1281 | break; |
| 1282 | case EiifRGBA32UI: |
| 1283 | case EiifRGBA16UI: |
| 1284 | case EiifRGBA8UI: |
| 1285 | case EiifR32UI: |
| 1286 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1287 | { |
| 1288 | error(identifierLocation, |
| 1289 | "internal image format requires an unsigned image type", |
| 1290 | getBasicString(publicType.getBasicType())); |
| 1291 | return; |
| 1292 | } |
| 1293 | break; |
| 1294 | case EiifUnspecified: |
| 1295 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1296 | return; |
| 1297 | default: |
| 1298 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1299 | return; |
| 1300 | } |
| 1301 | |
| 1302 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1303 | switch (layoutQualifier.imageInternalFormat) |
| 1304 | { |
| 1305 | case EiifR32F: |
| 1306 | case EiifR32I: |
| 1307 | case EiifR32UI: |
| 1308 | break; |
| 1309 | default: |
| 1310 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1311 | { |
| 1312 | error(identifierLocation, "layout qualifier", |
| 1313 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1314 | "image variables must be qualified readonly and/or writeonly"); |
| 1315 | return; |
| 1316 | } |
| 1317 | break; |
| 1318 | } |
| 1319 | } |
| 1320 | else |
| 1321 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1322 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1323 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1324 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1325 | |
| 1326 | if (IsAtomicCounter(publicType.getBasicType())) |
| 1327 | { |
| 1328 | atomicCounterQualifierErrorCheck(publicType, identifierLocation); |
| 1329 | } |
| 1330 | else |
| 1331 | { |
| 1332 | checkOffsetIsNotSpecified(identifierLocation, layoutQualifier.offset); |
| 1333 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1334 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1335 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1336 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1337 | { |
| 1338 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
| 1339 | int arraySize = type.isArray() ? type.getArraySize() : 1; |
| 1340 | if (IsImage(type.getBasicType())) |
| 1341 | { |
| 1342 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1343 | } |
| 1344 | else if (IsSampler(type.getBasicType())) |
| 1345 | { |
| 1346 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1347 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1348 | else if (IsAtomicCounter(type.getBasicType())) |
| 1349 | { |
| 1350 | checkAtomicCounterBindingIsValid(identifierLocation, layoutQualifier.binding); |
| 1351 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1352 | else |
| 1353 | { |
| 1354 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1355 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1356 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1357 | } |
| 1358 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1359 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1360 | const TString &layoutQualifierName, |
| 1361 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1362 | { |
| 1363 | |
| 1364 | if (mShaderVersion < versionRequired) |
| 1365 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1366 | error(location, "invalid layout qualifier: not supported", layoutQualifierName.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1367 | } |
| 1368 | } |
| 1369 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1370 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1371 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1372 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1373 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1374 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1375 | { |
| 1376 | if (localSize[i] != -1) |
| 1377 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1378 | error(location, |
| 1379 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1380 | "global layout declaration", |
| 1381 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1382 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1383 | } |
| 1384 | } |
| 1385 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1386 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1387 | } |
| 1388 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1389 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1390 | TLayoutImageInternalFormat internalFormat) |
| 1391 | { |
| 1392 | if (internalFormat != EiifUnspecified) |
| 1393 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1394 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1395 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1396 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1397 | } |
| 1398 | |
| 1399 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1400 | { |
| 1401 | if (binding != -1) |
| 1402 | { |
| 1403 | error(location, |
| 1404 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1405 | "binding"); |
| 1406 | } |
| 1407 | } |
| 1408 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1409 | void TParseContext::checkOffsetIsNotSpecified(const TSourceLoc &location, int offset) |
| 1410 | { |
| 1411 | if (offset != -1) |
| 1412 | { |
| 1413 | error(location, "invalid layout qualifier: only valid when used with atomic counters", |
| 1414 | "offset"); |
| 1415 | } |
| 1416 | } |
| 1417 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1418 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, int binding, int arraySize) |
| 1419 | { |
| 1420 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1421 | if (binding >= 0 && binding + arraySize > mMaxImageUnits) |
| 1422 | { |
| 1423 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1424 | } |
| 1425 | } |
| 1426 | |
| 1427 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1428 | int binding, |
| 1429 | int arraySize) |
| 1430 | { |
| 1431 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1432 | if (binding >= 0 && binding + arraySize > mMaxCombinedTextureImageUnits) |
| 1433 | { |
| 1434 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1435 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1436 | } |
| 1437 | |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1438 | void TParseContext::checkBlockBindingIsValid(const TSourceLoc &location, int binding, int arraySize) |
| 1439 | { |
| 1440 | int size = (arraySize == 0 ? 1 : arraySize); |
| 1441 | if (binding + size > mMaxUniformBufferBindings) |
| 1442 | { |
| 1443 | error(location, "interface block binding greater than MAX_UNIFORM_BUFFER_BINDINGS", |
| 1444 | "binding"); |
| 1445 | } |
| 1446 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1447 | void TParseContext::checkAtomicCounterBindingIsValid(const TSourceLoc &location, int binding) |
| 1448 | { |
| 1449 | if (binding >= mMaxAtomicCounterBindings) |
| 1450 | { |
| 1451 | error(location, "atomic counter binding greater than gl_MaxAtomicCounterBindings", |
| 1452 | "binding"); |
| 1453 | } |
| 1454 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1455 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1456 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1457 | int objectLocationCount, |
| 1458 | const TLayoutQualifier &layoutQualifier) |
| 1459 | { |
| 1460 | int loc = layoutQualifier.location; |
| 1461 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1462 | { |
| 1463 | error(location, "Uniform location out of range", "location"); |
| 1464 | } |
| 1465 | } |
| 1466 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1467 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1468 | { |
| 1469 | if (yuv != false) |
| 1470 | { |
| 1471 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1472 | } |
| 1473 | } |
| 1474 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1475 | void TParseContext::functionCallLValueErrorCheck(const TFunction *fnCandidate, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1476 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1477 | { |
| 1478 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1479 | { |
| 1480 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
| 1481 | if (qual == EvqOut || qual == EvqInOut) |
| 1482 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1483 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1484 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1485 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1486 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1487 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 1488 | fnCall->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1489 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1490 | } |
| 1491 | } |
| 1492 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1493 | } |
| 1494 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1495 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1496 | const TQualifier qualifier, |
| 1497 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1498 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1499 | if (!invariant) |
| 1500 | return; |
| 1501 | |
| 1502 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1503 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1504 | // input variables in the fragment shader can be also qualified as invariant |
| 1505 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1506 | { |
| 1507 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1508 | } |
| 1509 | } |
| 1510 | else |
| 1511 | { |
| 1512 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1513 | { |
| 1514 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1515 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1516 | } |
| 1517 | } |
| 1518 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1519 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1520 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1521 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1522 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1523 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1524 | } |
| 1525 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1526 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1527 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1528 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1529 | } |
| 1530 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1531 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1532 | const char *extName, |
| 1533 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1534 | { |
| 1535 | pp::SourceLocation srcLoc; |
| 1536 | srcLoc.file = loc.first_file; |
| 1537 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1538 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1539 | } |
| 1540 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1541 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1542 | const char *name, |
| 1543 | const char *value, |
| 1544 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1545 | { |
| 1546 | pp::SourceLocation srcLoc; |
| 1547 | srcLoc.file = loc.first_file; |
| 1548 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1549 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1550 | } |
| 1551 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1552 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1553 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1554 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1555 | for (size_t i = 0u; i < result.size(); ++i) |
| 1556 | { |
| 1557 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1558 | { |
| 1559 | result[i] = 1; |
| 1560 | } |
| 1561 | else |
| 1562 | { |
| 1563 | result[i] = mComputeShaderLocalSize[i]; |
| 1564 | } |
| 1565 | } |
| 1566 | return result; |
| 1567 | } |
| 1568 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1569 | ///////////////////////////////////////////////////////////////////////////////// |
| 1570 | // |
| 1571 | // Non-Errors. |
| 1572 | // |
| 1573 | ///////////////////////////////////////////////////////////////////////////////// |
| 1574 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1575 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1576 | const TString *name, |
| 1577 | const TSymbol *symbol) |
| 1578 | { |
Yunchao He | d7297bf | 2017-04-19 15:27:10 +0800 | [diff] [blame] | 1579 | const TVariable *variable = nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1580 | |
| 1581 | if (!symbol) |
| 1582 | { |
| 1583 | error(location, "undeclared identifier", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1584 | } |
| 1585 | else if (!symbol->isVariable()) |
| 1586 | { |
| 1587 | error(location, "variable expected", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1588 | } |
| 1589 | else |
| 1590 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1591 | variable = static_cast<const TVariable *>(symbol); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1592 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1593 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1594 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1595 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1596 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1597 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1598 | |
| 1599 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1600 | TQualifier qualifier = variable->getType().getQualifier(); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1601 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1602 | { |
| 1603 | mUsesFragData = true; |
| 1604 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1605 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1606 | { |
| 1607 | mUsesFragColor = true; |
| 1608 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1609 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1610 | { |
| 1611 | mUsesSecondaryOutputs = true; |
| 1612 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1613 | |
| 1614 | // This validation is not quite correct - it's only an error to write to |
| 1615 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1616 | // be rewarded for reading from undefined varaibles, return an error |
| 1617 | // if they are both referenced, rather than assigned. |
| 1618 | if (mUsesFragData && mUsesFragColor) |
| 1619 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1620 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1621 | if (mUsesSecondaryOutputs) |
| 1622 | { |
| 1623 | errorMessage = |
| 1624 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1625 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1626 | } |
| 1627 | error(location, errorMessage, name->c_str()); |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1628 | } |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 1629 | |
| 1630 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1631 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1632 | qualifier == EvqWorkGroupSize) |
| 1633 | { |
| 1634 | error(location, |
| 1635 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1636 | "gl_WorkGroupSize"); |
| 1637 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1638 | } |
| 1639 | |
| 1640 | if (!variable) |
| 1641 | { |
| 1642 | TType type(EbtFloat, EbpUndefined); |
| 1643 | TVariable *fakeVariable = new TVariable(name, type); |
| 1644 | symbolTable.declare(fakeVariable); |
| 1645 | variable = fakeVariable; |
| 1646 | } |
| 1647 | |
| 1648 | return variable; |
| 1649 | } |
| 1650 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1651 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1652 | const TString *name, |
| 1653 | const TSymbol *symbol) |
| 1654 | { |
| 1655 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1656 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1657 | if (variable->getType().getQualifier() == EvqViewIDOVR && IsWebGLBasedSpec(mShaderSpec) && |
| 1658 | mShaderType == GL_FRAGMENT_SHADER && !isExtensionEnabled("GL_OVR_multiview2")) |
| 1659 | { |
| 1660 | // WEBGL_multiview spec |
| 1661 | error(location, "Need to enable OVR_multiview2 to use gl_ViewID_OVR in fragment shader", |
| 1662 | "gl_ViewID_OVR"); |
| 1663 | } |
| 1664 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1665 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1666 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1667 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1668 | return intermediate.addConstantUnion(constArray, variable->getType(), location); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1669 | } |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1670 | else if (variable->getType().getQualifier() == EvqWorkGroupSize && |
| 1671 | mComputeShaderLocalSizeDeclared) |
| 1672 | { |
| 1673 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1674 | // needs to be added to the AST as a constant and not as a symbol. |
| 1675 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1676 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1677 | for (size_t i = 0; i < 3; ++i) |
| 1678 | { |
| 1679 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1680 | } |
| 1681 | |
| 1682 | ASSERT(variable->getType().getBasicType() == EbtUInt); |
| 1683 | ASSERT(variable->getType().getObjectSize() == 3); |
| 1684 | |
| 1685 | TType type(variable->getType()); |
| 1686 | type.setQualifier(EvqConst); |
| 1687 | return intermediate.addConstantUnion(constArray, type, location); |
| 1688 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1689 | else |
| 1690 | { |
| 1691 | return intermediate.addSymbol(variable->getUniqueId(), variable->getName(), |
| 1692 | variable->getType(), location); |
| 1693 | } |
| 1694 | } |
| 1695 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1696 | // Initializers show up in several places in the grammar. Have one set of |
| 1697 | // code to handle them here. |
| 1698 | // |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1699 | // Returns true on success. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1700 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1701 | const TString &identifier, |
| 1702 | const TPublicType &pType, |
| 1703 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1704 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1705 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1706 | ASSERT(initNode != nullptr); |
| 1707 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1708 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1709 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1710 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1711 | if (type.isUnsizedArray()) |
| 1712 | { |
Olli Etuaho | 02bd82c | 2016-11-03 10:29:43 +0000 | [diff] [blame] | 1713 | // We have not checked yet whether the initializer actually is an array or not. |
| 1714 | if (initializer->isArray()) |
| 1715 | { |
| 1716 | type.setArraySize(initializer->getArraySize()); |
| 1717 | } |
| 1718 | else |
| 1719 | { |
| 1720 | // Having a non-array initializer for an unsized array will result in an error later, |
| 1721 | // so we don't generate an error message here. |
| 1722 | type.setArraySize(1u); |
| 1723 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1724 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1725 | if (!declareVariable(line, identifier, type, &variable)) |
| 1726 | { |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1727 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1728 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1729 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1730 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1731 | if (symbolTable.atGlobalLevel() && |
| 1732 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1733 | { |
| 1734 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1735 | // we want to steer developers towards only using constant expressions. |
| 1736 | error(line, "global variable initializers must be constant expressions", "="); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1737 | return false; |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1738 | } |
| 1739 | if (globalInitWarning) |
| 1740 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1741 | warning( |
| 1742 | line, |
| 1743 | "global variable initializers should be constant expressions " |
| 1744 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1745 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1746 | } |
| 1747 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1748 | // |
| 1749 | // identifier must be of type constant, a global, or a temporary |
| 1750 | // |
| 1751 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1752 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1753 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1754 | error(line, " cannot initialize this type of qualifier ", |
| 1755 | variable->getType().getQualifierString()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1756 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1757 | } |
| 1758 | // |
| 1759 | // test for and propagate constant |
| 1760 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1761 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1762 | if (qualifier == EvqConst) |
| 1763 | { |
| 1764 | if (qualifier != initializer->getType().getQualifier()) |
| 1765 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1766 | std::stringstream reasonStream; |
| 1767 | reasonStream << "assigning non-constant to '" << variable->getType().getCompleteString() |
| 1768 | << "'"; |
| 1769 | std::string reason = reasonStream.str(); |
| 1770 | error(line, reason.c_str(), "="); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1771 | variable->getType().setQualifier(EvqTemporary); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1772 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1773 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1774 | if (type != initializer->getType()) |
| 1775 | { |
| 1776 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1777 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1778 | variable->getType().setQualifier(EvqTemporary); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1779 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1780 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1781 | |
| 1782 | // Save the constant folded value to the variable if possible. For example array |
| 1783 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1784 | // in the shader is avoided. |
| 1785 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1786 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1787 | if (initializer->getAsConstantUnion()) |
| 1788 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1789 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1790 | ASSERT(*initNode == nullptr); |
| 1791 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1792 | } |
| 1793 | else if (initializer->getAsSymbolNode()) |
| 1794 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1795 | const TSymbol *symbol = |
| 1796 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1797 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1798 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1799 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1800 | if (constArray) |
| 1801 | { |
| 1802 | variable->shareConstPointer(constArray); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1803 | ASSERT(*initNode == nullptr); |
| 1804 | return true; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1805 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1806 | } |
| 1807 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1808 | |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1809 | TIntermSymbol *intermSymbol = intermediate.addSymbol( |
| 1810 | variable->getUniqueId(), variable->getName(), variable->getType(), line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1811 | *initNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1812 | if (*initNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1813 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1814 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1815 | return false; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1816 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1817 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1818 | return true; |
| 1819 | } |
| 1820 | |
| 1821 | TIntermNode *TParseContext::addConditionInitializer(const TPublicType &pType, |
| 1822 | const TString &identifier, |
| 1823 | TIntermTyped *initializer, |
| 1824 | const TSourceLoc &loc) |
| 1825 | { |
| 1826 | checkIsScalarBool(loc, pType); |
| 1827 | TIntermBinary *initNode = nullptr; |
| 1828 | if (executeInitializer(loc, identifier, pType, initializer, &initNode)) |
| 1829 | { |
| 1830 | // The initializer is valid. The init condition needs to have a node - either the |
| 1831 | // initializer node, or a constant node in case the initialized variable is const and won't |
| 1832 | // be recorded in the AST. |
| 1833 | if (initNode == nullptr) |
| 1834 | { |
| 1835 | return initializer; |
| 1836 | } |
| 1837 | else |
| 1838 | { |
| 1839 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1840 | declaration->appendDeclarator(initNode); |
| 1841 | return declaration; |
| 1842 | } |
| 1843 | } |
| 1844 | return nullptr; |
| 1845 | } |
| 1846 | |
| 1847 | TIntermNode *TParseContext::addLoop(TLoopType type, |
| 1848 | TIntermNode *init, |
| 1849 | TIntermNode *cond, |
| 1850 | TIntermTyped *expr, |
| 1851 | TIntermNode *body, |
| 1852 | const TSourceLoc &line) |
| 1853 | { |
| 1854 | TIntermNode *node = nullptr; |
| 1855 | TIntermTyped *typedCond = nullptr; |
| 1856 | if (cond) |
| 1857 | { |
| 1858 | typedCond = cond->getAsTyped(); |
| 1859 | } |
| 1860 | if (cond == nullptr || typedCond) |
| 1861 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 1862 | if (type == ELoopDoWhile) |
| 1863 | { |
| 1864 | checkIsScalarBool(line, typedCond); |
| 1865 | } |
| 1866 | // In the case of other loops, it was checked before that the condition is a scalar boolean. |
| 1867 | ASSERT(mDiagnostics->numErrors() > 0 || typedCond == nullptr || |
| 1868 | (typedCond->getBasicType() == EbtBool && !typedCond->isArray() && |
| 1869 | !typedCond->isVector())); |
| 1870 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1871 | node = new TIntermLoop(type, init, typedCond, expr, TIntermediate::EnsureBlock(body)); |
| 1872 | node->setLine(line); |
| 1873 | return node; |
| 1874 | } |
| 1875 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 1876 | ASSERT(type != ELoopDoWhile); |
| 1877 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1878 | TIntermDeclaration *declaration = cond->getAsDeclarationNode(); |
| 1879 | ASSERT(declaration); |
| 1880 | TIntermBinary *declarator = declaration->getSequence()->front()->getAsBinaryNode(); |
| 1881 | ASSERT(declarator->getLeft()->getAsSymbolNode()); |
| 1882 | |
| 1883 | // The condition is a declaration. In the AST representation we don't support declarations as |
| 1884 | // loop conditions. Wrap the loop to a block that declares the condition variable and contains |
| 1885 | // the loop. |
| 1886 | TIntermBlock *block = new TIntermBlock(); |
| 1887 | |
| 1888 | TIntermDeclaration *declareCondition = new TIntermDeclaration(); |
| 1889 | declareCondition->appendDeclarator(declarator->getLeft()->deepCopy()); |
| 1890 | block->appendStatement(declareCondition); |
| 1891 | |
| 1892 | TIntermBinary *conditionInit = new TIntermBinary(EOpAssign, declarator->getLeft()->deepCopy(), |
| 1893 | declarator->getRight()->deepCopy()); |
| 1894 | TIntermLoop *loop = |
| 1895 | new TIntermLoop(type, init, conditionInit, expr, TIntermediate::EnsureBlock(body)); |
| 1896 | block->appendStatement(loop); |
| 1897 | loop->setLine(line); |
| 1898 | block->setLine(line); |
| 1899 | return block; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1900 | } |
| 1901 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 1902 | TIntermNode *TParseContext::addIfElse(TIntermTyped *cond, |
| 1903 | TIntermNodePair code, |
| 1904 | const TSourceLoc &loc) |
| 1905 | { |
| 1906 | checkIsScalarBool(loc, cond); |
| 1907 | |
| 1908 | // For compile time constant conditions, prune the code now. |
| 1909 | if (cond->getAsConstantUnion()) |
| 1910 | { |
| 1911 | if (cond->getAsConstantUnion()->getBConst(0) == true) |
| 1912 | { |
| 1913 | return TIntermediate::EnsureBlock(code.node1); |
| 1914 | } |
| 1915 | else |
| 1916 | { |
| 1917 | return TIntermediate::EnsureBlock(code.node2); |
| 1918 | } |
| 1919 | } |
| 1920 | |
| 1921 | TIntermIfElse *node = new TIntermIfElse(cond, TIntermediate::EnsureBlock(code.node1), |
| 1922 | TIntermediate::EnsureBlock(code.node2)); |
| 1923 | node->setLine(loc); |
| 1924 | |
| 1925 | return node; |
| 1926 | } |
| 1927 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 1928 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 1929 | { |
| 1930 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 1931 | typeSpecifier->getBasicType()); |
| 1932 | |
| 1933 | if (mShaderVersion < 300 && typeSpecifier->array) |
| 1934 | { |
| 1935 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 1936 | typeSpecifier->clearArrayness(); |
| 1937 | } |
| 1938 | } |
| 1939 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1940 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1941 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1942 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1943 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1944 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1945 | TPublicType returnType = typeSpecifier; |
| 1946 | returnType.qualifier = typeQualifier.qualifier; |
| 1947 | returnType.invariant = typeQualifier.invariant; |
| 1948 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1949 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1950 | returnType.precision = typeSpecifier.precision; |
| 1951 | |
| 1952 | if (typeQualifier.precision != EbpUndefined) |
| 1953 | { |
| 1954 | returnType.precision = typeQualifier.precision; |
| 1955 | } |
| 1956 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1957 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 1958 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1959 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1960 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 1961 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1962 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1963 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1964 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1965 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1966 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1967 | if (typeSpecifier.array) |
| 1968 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1969 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1970 | returnType.clearArrayness(); |
| 1971 | } |
| 1972 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1973 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1974 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1975 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1976 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1977 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1978 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1979 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1980 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1981 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1982 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1983 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1984 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1985 | } |
| 1986 | } |
| 1987 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1988 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1989 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1990 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1991 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1992 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1993 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 1994 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1995 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1996 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 1997 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1998 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1999 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2000 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2001 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2002 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2003 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2004 | } |
| 2005 | |
| 2006 | return returnType; |
| 2007 | } |
| 2008 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2009 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 2010 | const TPublicType &type, |
| 2011 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2012 | { |
| 2013 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2014 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2015 | { |
| 2016 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2017 | } |
| 2018 | |
| 2019 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 2020 | switch (qualifier) |
| 2021 | { |
| 2022 | case EvqVertexIn: |
| 2023 | // ESSL 3.00 section 4.3.4 |
| 2024 | if (type.array) |
| 2025 | { |
| 2026 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2027 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2028 | // Vertex inputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2029 | return; |
| 2030 | case EvqFragmentOut: |
| 2031 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2032 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2033 | { |
| 2034 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2035 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2036 | // Fragment outputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2037 | return; |
| 2038 | default: |
| 2039 | break; |
| 2040 | } |
| 2041 | |
| 2042 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 2043 | // restrictions. |
| 2044 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2045 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 2046 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2047 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 2048 | { |
| 2049 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 2050 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2051 | } |
| 2052 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2053 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2054 | { |
| 2055 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 2056 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 2057 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 2058 | if (type.array) |
| 2059 | { |
| 2060 | error(qualifierLocation, "cannot be an array of structures", |
| 2061 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2062 | } |
| 2063 | if (type.isStructureContainingArrays()) |
| 2064 | { |
| 2065 | error(qualifierLocation, "cannot be a structure containing an array", |
| 2066 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2067 | } |
| 2068 | if (type.isStructureContainingType(EbtStruct)) |
| 2069 | { |
| 2070 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 2071 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2072 | } |
| 2073 | if (type.isStructureContainingType(EbtBool)) |
| 2074 | { |
| 2075 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 2076 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2077 | } |
| 2078 | } |
| 2079 | } |
| 2080 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2081 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 2082 | { |
| 2083 | if (qualifier.getType() == QtStorage) |
| 2084 | { |
| 2085 | const TStorageQualifierWrapper &storageQualifier = |
| 2086 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 2087 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 2088 | !symbolTable.atGlobalLevel()) |
| 2089 | { |
| 2090 | error(storageQualifier.getLine(), |
| 2091 | "Local variables can only use the const storage qualifier.", |
| 2092 | storageQualifier.getQualifierString().c_str()); |
| 2093 | } |
| 2094 | } |
| 2095 | } |
| 2096 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2097 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2098 | const TSourceLoc &location) |
| 2099 | { |
| 2100 | if (memoryQualifier.readonly) |
| 2101 | { |
| 2102 | error(location, "Only allowed with images.", "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2103 | } |
| 2104 | if (memoryQualifier.writeonly) |
| 2105 | { |
| 2106 | error(location, "Only allowed with images.", "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2107 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2108 | if (memoryQualifier.coherent) |
| 2109 | { |
| 2110 | error(location, "Only allowed with images.", "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2111 | } |
| 2112 | if (memoryQualifier.restrictQualifier) |
| 2113 | { |
| 2114 | error(location, "Only allowed with images.", "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2115 | } |
| 2116 | if (memoryQualifier.volatileQualifier) |
| 2117 | { |
| 2118 | error(location, "Only allowed with images.", "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2119 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2120 | } |
| 2121 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2122 | // Make sure there is no offset overlapping, and store the newly assigned offset to "type" in |
| 2123 | // intermediate tree. |
| 2124 | void TParseContext::checkAtomicCounterOffsetIsNotOverlapped(TPublicType &publicType, |
| 2125 | size_t size, |
| 2126 | bool forceAppend, |
| 2127 | const TSourceLoc &loc, |
| 2128 | TType &type) |
| 2129 | { |
| 2130 | auto &bindingState = mAtomicCounterBindingStates[publicType.layoutQualifier.binding]; |
| 2131 | int offset; |
| 2132 | if (publicType.layoutQualifier.offset == -1 || forceAppend) |
| 2133 | { |
| 2134 | offset = bindingState.appendSpan(size); |
| 2135 | } |
| 2136 | else |
| 2137 | { |
| 2138 | offset = bindingState.insertSpan(publicType.layoutQualifier.offset, size); |
| 2139 | } |
| 2140 | if (offset == -1) |
| 2141 | { |
| 2142 | error(loc, "Offset overlapping", "atomic counter"); |
| 2143 | return; |
| 2144 | } |
| 2145 | TLayoutQualifier qualifier = type.getLayoutQualifier(); |
| 2146 | qualifier.offset = offset; |
| 2147 | type.setLayoutQualifier(qualifier); |
| 2148 | } |
| 2149 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2150 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 2151 | TPublicType &publicType, |
| 2152 | const TSourceLoc &identifierOrTypeLocation, |
| 2153 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2154 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2155 | TType type(publicType); |
| 2156 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 2157 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 2158 | { |
| 2159 | TQualifier qualifier = type.getQualifier(); |
| 2160 | |
| 2161 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 2162 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 2163 | // affected variable declarations: |
| 2164 | // |
| 2165 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 2166 | // elsewhere, in TranslatorGLSL.) |
| 2167 | // |
| 2168 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 2169 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 2170 | // the way this is currently implemented we have to enable this compiler option before |
| 2171 | // parsing the shader and determining the shading language version it uses. If this were |
| 2172 | // implemented as a post-pass, the workaround could be more targeted. |
| 2173 | // |
| 2174 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 2175 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 2176 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 2177 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 2178 | { |
| 2179 | type.setInvariant(true); |
| 2180 | } |
| 2181 | } |
| 2182 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2183 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2184 | identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2185 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2186 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2187 | mDeferredNonEmptyDeclarationErrorCheck = emptyDeclaration; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2188 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2189 | TIntermSymbol *symbol = nullptr; |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2190 | if (emptyDeclaration) |
| 2191 | { |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 2192 | emptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2193 | // In most cases we don't need to create a symbol node for an empty declaration. |
| 2194 | // But if the empty declaration is declaring a struct type, the symbol node will store that. |
| 2195 | if (type.getBasicType() == EbtStruct) |
| 2196 | { |
| 2197 | symbol = intermediate.addSymbol(0, "", type, identifierOrTypeLocation); |
| 2198 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2199 | else if (IsAtomicCounter(publicType.getBasicType())) |
| 2200 | { |
| 2201 | setAtomicCounterBindingDefaultOffset(publicType, identifierOrTypeLocation); |
| 2202 | } |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2203 | } |
| 2204 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2205 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2206 | nonEmptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2207 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2208 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2209 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2210 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2211 | { |
| 2212 | |
| 2213 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterSize, false, |
| 2214 | identifierOrTypeLocation, type); |
| 2215 | } |
| 2216 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2217 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2218 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2219 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2220 | if (variable) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2221 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2222 | symbol = intermediate.addSymbol(variable->getUniqueId(), identifier, type, |
| 2223 | identifierOrTypeLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2224 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2225 | } |
| 2226 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2227 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2228 | declaration->setLine(identifierOrTypeLocation); |
| 2229 | if (symbol) |
| 2230 | { |
| 2231 | declaration->appendDeclarator(symbol); |
| 2232 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2233 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2234 | } |
| 2235 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2236 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 2237 | const TSourceLoc &identifierLocation, |
| 2238 | const TString &identifier, |
| 2239 | const TSourceLoc &indexLocation, |
| 2240 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2241 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2242 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2243 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2244 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2245 | identifierLocation); |
| 2246 | |
| 2247 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2248 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2249 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2250 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2251 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2252 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2253 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2254 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2255 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2256 | // Make the type an array even if size check failed. |
| 2257 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2258 | arrayType.setArraySize(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2259 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2260 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2261 | { |
| 2262 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterArrayStride * size, false, |
| 2263 | identifierLocation, arrayType); |
| 2264 | } |
| 2265 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2266 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2267 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2268 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2269 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2270 | declaration->setLine(identifierLocation); |
| 2271 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2272 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2273 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2274 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2275 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2276 | declaration->appendDeclarator(symbol); |
| 2277 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2278 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2279 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2280 | } |
| 2281 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2282 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2283 | const TSourceLoc &identifierLocation, |
| 2284 | const TString &identifier, |
| 2285 | const TSourceLoc &initLocation, |
| 2286 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2287 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2288 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2289 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2290 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2291 | identifierLocation); |
| 2292 | |
| 2293 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2294 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2295 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2296 | declaration->setLine(identifierLocation); |
| 2297 | |
| 2298 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2299 | if (executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2300 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2301 | if (initNode) |
| 2302 | { |
| 2303 | declaration->appendDeclarator(initNode); |
| 2304 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2305 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2306 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2307 | } |
| 2308 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2309 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2310 | TPublicType &publicType, |
| 2311 | const TSourceLoc &identifierLocation, |
| 2312 | const TString &identifier, |
| 2313 | const TSourceLoc &indexLocation, |
| 2314 | TIntermTyped *indexExpression, |
| 2315 | const TSourceLoc &initLocation, |
| 2316 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2317 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2318 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2319 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2320 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2321 | identifierLocation); |
| 2322 | |
| 2323 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2324 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2325 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2326 | |
| 2327 | TPublicType arrayType(publicType); |
| 2328 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2329 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2330 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2331 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2332 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2333 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2334 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2335 | } |
| 2336 | // Make the type an array even if size check failed. |
| 2337 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2338 | arrayType.setArraySize(size); |
| 2339 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2340 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2341 | declaration->setLine(identifierLocation); |
| 2342 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2343 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2344 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2345 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2346 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2347 | if (initNode) |
| 2348 | { |
| 2349 | declaration->appendDeclarator(initNode); |
| 2350 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2351 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2352 | |
| 2353 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2354 | } |
| 2355 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2356 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2357 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2358 | const TSourceLoc &identifierLoc, |
| 2359 | const TString *identifier, |
| 2360 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2361 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2362 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2363 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2364 | if (!typeQualifier.invariant) |
| 2365 | { |
| 2366 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 2367 | return nullptr; |
| 2368 | } |
| 2369 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2370 | { |
| 2371 | return nullptr; |
| 2372 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2373 | if (!symbol) |
| 2374 | { |
| 2375 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2376 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2377 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2378 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2379 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2380 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2381 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2382 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2383 | if (typeQualifier.precision != EbpUndefined) |
| 2384 | { |
| 2385 | error(identifierLoc, "invariant declaration specifies precision", |
| 2386 | getPrecisionString(typeQualifier.precision)); |
| 2387 | } |
| 2388 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2389 | { |
| 2390 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2391 | } |
| 2392 | |
| 2393 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
| 2394 | ASSERT(variable); |
| 2395 | const TType &type = variable->getType(); |
| 2396 | |
| 2397 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2398 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2399 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2400 | |
| 2401 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 2402 | |
| 2403 | TIntermSymbol *intermSymbol = |
| 2404 | intermediate.addSymbol(variable->getUniqueId(), *identifier, type, identifierLoc); |
| 2405 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2406 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2407 | } |
| 2408 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2409 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2410 | const TSourceLoc &identifierLocation, |
| 2411 | const TString &identifier, |
| 2412 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2413 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2414 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2415 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2416 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2417 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2418 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2419 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2420 | } |
| 2421 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2422 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2423 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2424 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2425 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2426 | TVariable *variable = nullptr; |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2427 | TType type(publicType); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2428 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2429 | { |
| 2430 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterSize, true, |
| 2431 | identifierLocation, type); |
| 2432 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2433 | declareVariable(identifierLocation, identifier, type, &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2434 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2435 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierLocation); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2436 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2437 | { |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2438 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2439 | declarationOut->appendDeclarator(symbol); |
| 2440 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2441 | } |
| 2442 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2443 | void TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 2444 | const TSourceLoc &identifierLocation, |
| 2445 | const TString &identifier, |
| 2446 | const TSourceLoc &arrayLocation, |
| 2447 | TIntermTyped *indexExpression, |
| 2448 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2449 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2450 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2451 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2452 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2453 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2454 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2455 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2456 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2457 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2458 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2459 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2460 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2461 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2462 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2463 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2464 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2465 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 693c9aa | 2015-04-07 17:50:36 +0300 | [diff] [blame] | 2466 | arrayType.setArraySize(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2467 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2468 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2469 | { |
| 2470 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterArrayStride * size, |
| 2471 | true, identifierLocation, arrayType); |
| 2472 | } |
| 2473 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2474 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2475 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2476 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2477 | TIntermSymbol *symbol = |
| 2478 | intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2479 | if (variable && symbol) |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2480 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2481 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2482 | declarationOut->appendDeclarator(symbol); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2483 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2484 | } |
| 2485 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2486 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2487 | const TSourceLoc &identifierLocation, |
| 2488 | const TString &identifier, |
| 2489 | const TSourceLoc &initLocation, |
| 2490 | TIntermTyped *initializer, |
| 2491 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2492 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2493 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2494 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2495 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2496 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2497 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2498 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2499 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2500 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2501 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2502 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2503 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2504 | if (executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2505 | { |
| 2506 | // |
| 2507 | // build the intermediate representation |
| 2508 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2509 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2510 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2511 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2512 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2513 | } |
| 2514 | } |
| 2515 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2516 | void TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
| 2517 | const TSourceLoc &identifierLocation, |
| 2518 | const TString &identifier, |
| 2519 | const TSourceLoc &indexLocation, |
| 2520 | TIntermTyped *indexExpression, |
| 2521 | const TSourceLoc &initLocation, |
| 2522 | TIntermTyped *initializer, |
| 2523 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2524 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2525 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2526 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2527 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2528 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2529 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2530 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2531 | } |
| 2532 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2533 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2534 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2535 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2536 | |
| 2537 | TPublicType arrayType(publicType); |
| 2538 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2539 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2540 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2541 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2542 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2543 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2544 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2545 | } |
| 2546 | // Make the type an array even if size check failed. |
| 2547 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2548 | arrayType.setArraySize(size); |
| 2549 | |
| 2550 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2551 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2552 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2553 | { |
| 2554 | if (initNode) |
| 2555 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2556 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2557 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2558 | } |
| 2559 | } |
| 2560 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2561 | void TParseContext::setAtomicCounterBindingDefaultOffset(const TPublicType &publicType, |
| 2562 | const TSourceLoc &location) |
| 2563 | { |
| 2564 | const TLayoutQualifier &layoutQualifier = publicType.layoutQualifier; |
| 2565 | checkAtomicCounterBindingIsValid(location, layoutQualifier.binding); |
| 2566 | if (layoutQualifier.binding == -1 || layoutQualifier.offset == -1) |
| 2567 | { |
| 2568 | error(location, "Requires both binding and offset", "layout"); |
| 2569 | return; |
| 2570 | } |
| 2571 | mAtomicCounterBindingStates[layoutQualifier.binding].setDefaultOffset(layoutQualifier.offset); |
| 2572 | } |
| 2573 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 2574 | void TParseContext::parseDefaultPrecisionQualifier(const TPrecision precision, |
| 2575 | const TPublicType &type, |
| 2576 | const TSourceLoc &loc) |
| 2577 | { |
| 2578 | if ((precision == EbpHigh) && (getShaderType() == GL_FRAGMENT_SHADER) && |
| 2579 | !getFragmentPrecisionHigh()) |
| 2580 | { |
| 2581 | error(loc, "precision is not supported in fragment shader", "highp"); |
| 2582 | } |
| 2583 | |
| 2584 | if (!CanSetDefaultPrecisionOnType(type)) |
| 2585 | { |
| 2586 | error(loc, "illegal type argument for default precision qualifier", |
| 2587 | getBasicString(type.getBasicType())); |
| 2588 | return; |
| 2589 | } |
| 2590 | symbolTable.setDefaultPrecision(type.getBasicType(), precision); |
| 2591 | } |
| 2592 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2593 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2594 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2595 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2596 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2597 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2598 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2599 | typeQualifier.line); |
| 2600 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2601 | // It should never be the case, but some strange parser errors can send us here. |
| 2602 | if (layoutQualifier.isEmpty()) |
| 2603 | { |
| 2604 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2605 | return; |
| 2606 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2607 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2608 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2609 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2610 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2611 | return; |
| 2612 | } |
| 2613 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2614 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 2615 | |
| 2616 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2617 | |
| 2618 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2619 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2620 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 2621 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2622 | checkOffsetIsNotSpecified(typeQualifier.line, layoutQualifier.offset); |
| 2623 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2624 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2625 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2626 | if (mComputeShaderLocalSizeDeclared && |
| 2627 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 2628 | { |
| 2629 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 2630 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2631 | return; |
| 2632 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2633 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2634 | if (mShaderVersion < 310) |
| 2635 | { |
| 2636 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2637 | return; |
| 2638 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2639 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2640 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2641 | { |
| 2642 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2643 | return; |
| 2644 | } |
| 2645 | |
| 2646 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 2647 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 2648 | |
| 2649 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 2650 | maxComputeWorkGroupSize->getConstPointer(); |
| 2651 | |
| 2652 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 2653 | { |
| 2654 | if (layoutQualifier.localSize[i] != -1) |
| 2655 | { |
| 2656 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 2657 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 2658 | if (mComputeShaderLocalSize[i] < 1 || |
| 2659 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 2660 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2661 | std::stringstream reasonStream; |
| 2662 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 2663 | << maxComputeWorkGroupSizeValue; |
| 2664 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2665 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2666 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2667 | return; |
| 2668 | } |
| 2669 | } |
| 2670 | } |
| 2671 | |
| 2672 | mComputeShaderLocalSizeDeclared = true; |
| 2673 | } |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 2674 | else if (isMultiviewExtensionEnabled() && typeQualifier.qualifier == EvqVertexIn) |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2675 | { |
| 2676 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 2677 | // specification. |
| 2678 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 2679 | { |
| 2680 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 2681 | "layout"); |
| 2682 | return; |
| 2683 | } |
| 2684 | |
| 2685 | if (layoutQualifier.numViews == -1) |
| 2686 | { |
| 2687 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 2688 | return; |
| 2689 | } |
| 2690 | |
| 2691 | if (layoutQualifier.numViews > mMaxNumViews) |
| 2692 | { |
| 2693 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 2694 | "layout"); |
| 2695 | return; |
| 2696 | } |
| 2697 | |
| 2698 | mNumViews = layoutQualifier.numViews; |
| 2699 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2700 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2701 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2702 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2703 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2704 | return; |
| 2705 | } |
| 2706 | |
| 2707 | if (typeQualifier.qualifier != EvqUniform) |
| 2708 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2709 | error(typeQualifier.line, "invalid qualifier: global layout must be uniform", |
| 2710 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2711 | return; |
| 2712 | } |
| 2713 | |
| 2714 | if (mShaderVersion < 300) |
| 2715 | { |
| 2716 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 2717 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2718 | return; |
| 2719 | } |
| 2720 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2721 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2722 | |
| 2723 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 2724 | { |
| 2725 | mDefaultMatrixPacking = layoutQualifier.matrixPacking; |
| 2726 | } |
| 2727 | |
| 2728 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 2729 | { |
| 2730 | mDefaultBlockStorage = layoutQualifier.blockStorage; |
| 2731 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2732 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2733 | } |
| 2734 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2735 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 2736 | const TFunction &function, |
| 2737 | const TSourceLoc &location, |
| 2738 | bool insertParametersToSymbolTable) |
| 2739 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 2740 | TIntermFunctionPrototype *prototype = |
| 2741 | new TIntermFunctionPrototype(function.getReturnType(), TSymbolUniqueId(function)); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2742 | // TODO(oetuaho@nvidia.com): Instead of converting the function information here, the node could |
| 2743 | // point to the data that already exists in the symbol table. |
| 2744 | prototype->getFunctionSymbolInfo()->setFromFunction(function); |
| 2745 | prototype->setLine(location); |
| 2746 | |
| 2747 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 2748 | { |
| 2749 | const TConstParameter ¶m = function.getParam(i); |
| 2750 | |
| 2751 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 2752 | // be used for unused args). |
| 2753 | if (param.name != nullptr) |
| 2754 | { |
| 2755 | TVariable *variable = new TVariable(param.name, *param.type); |
| 2756 | |
| 2757 | // Insert the parameter in the symbol table. |
| 2758 | if (insertParametersToSymbolTable && !symbolTable.declare(variable)) |
| 2759 | { |
| 2760 | error(location, "redefinition", variable->getName().c_str()); |
| 2761 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2762 | continue; |
| 2763 | } |
| 2764 | TIntermSymbol *symbol = intermediate.addSymbol( |
| 2765 | variable->getUniqueId(), variable->getName(), variable->getType(), location); |
| 2766 | prototype->appendParameter(symbol); |
| 2767 | } |
| 2768 | else |
| 2769 | { |
| 2770 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2771 | } |
| 2772 | } |
| 2773 | return prototype; |
| 2774 | } |
| 2775 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 2776 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 2777 | const TFunction &parsedFunction, |
| 2778 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2779 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2780 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 2781 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 2782 | // function is declared multiple times. |
| 2783 | TFunction *function = static_cast<TFunction *>( |
| 2784 | symbolTable.find(parsedFunction.getMangledName(), getShaderVersion())); |
| 2785 | if (function->hasPrototypeDeclaration() && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2786 | { |
| 2787 | // ESSL 1.00.17 section 4.2.7. |
| 2788 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 2789 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2790 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2791 | function->setHasPrototypeDeclaration(); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2792 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2793 | TIntermFunctionPrototype *prototype = |
| 2794 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2795 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2796 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2797 | |
| 2798 | if (!symbolTable.atGlobalLevel()) |
| 2799 | { |
| 2800 | // ESSL 3.00.4 section 4.2.4. |
| 2801 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2802 | } |
| 2803 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2804 | return prototype; |
| 2805 | } |
| 2806 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2807 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2808 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2809 | TIntermBlock *functionBody, |
| 2810 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2811 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2812 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2813 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 2814 | { |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2815 | error(location, "function does not return a value:", |
| 2816 | functionPrototype->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2817 | } |
| 2818 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2819 | if (functionBody == nullptr) |
| 2820 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2821 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2822 | functionBody->setLine(location); |
| 2823 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2824 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2825 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2826 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2827 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2828 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2829 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2830 | } |
| 2831 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2832 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
| 2833 | TFunction **function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2834 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2835 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2836 | ASSERT(function); |
| 2837 | ASSERT(*function); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2838 | const TSymbol *builtIn = |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2839 | symbolTable.findBuiltIn((*function)->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2840 | |
| 2841 | if (builtIn) |
| 2842 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2843 | error(location, "built-in functions cannot be redefined", (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2844 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2845 | else |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2846 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2847 | TFunction *prevDec = static_cast<TFunction *>( |
| 2848 | symbolTable.find((*function)->getMangledName(), getShaderVersion())); |
| 2849 | |
| 2850 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function as it |
| 2851 | // would have just been put in the symbol table. Otherwise, we're looking up an earlier |
| 2852 | // occurance. |
| 2853 | if (*function != prevDec) |
| 2854 | { |
| 2855 | // Swap the parameters of the previous declaration to the parameters of the function |
| 2856 | // definition (parameter names may differ). |
| 2857 | prevDec->swapParameters(**function); |
| 2858 | |
| 2859 | // The function definition will share the same symbol as any previous declaration. |
| 2860 | *function = prevDec; |
| 2861 | } |
| 2862 | |
| 2863 | if ((*function)->isDefined()) |
| 2864 | { |
| 2865 | error(location, "function already has a body", (*function)->getName().c_str()); |
| 2866 | } |
| 2867 | |
| 2868 | (*function)->setDefined(); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2869 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2870 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2871 | // Remember the return type for later checking for return statements. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2872 | mCurrentFunctionType = &((*function)->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2873 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2874 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2875 | *prototypeOut = createPrototypeNodeFromFunction(**function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2876 | setLoopNestingLevel(0); |
| 2877 | } |
| 2878 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2879 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2880 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2881 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2882 | // We don't know at this point whether this is a function definition or a prototype. |
| 2883 | // The definition production code will check for redefinitions. |
| 2884 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2885 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2886 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 2887 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2888 | // |
| 2889 | TFunction *prevDec = |
| 2890 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2891 | |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2892 | if (getShaderVersion() >= 300 && |
| 2893 | symbolTable.hasUnmangledBuiltInForShaderVersion(function->getName().c_str(), |
| 2894 | getShaderVersion())) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2895 | { |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2896 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as functions. |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2897 | // Therefore overloading or redefining builtin functions is an error. |
| 2898 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 2899 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2900 | } |
| 2901 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2902 | { |
| 2903 | if (prevDec->getReturnType() != function->getReturnType()) |
| 2904 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2905 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2906 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2907 | } |
| 2908 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 2909 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2910 | if (prevDec->getParam(i).type->getQualifier() != |
| 2911 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2912 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2913 | error(location, |
| 2914 | "function must have the same parameter qualifiers in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2915 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2916 | } |
| 2917 | } |
| 2918 | } |
| 2919 | |
| 2920 | // |
| 2921 | // Check for previously declared variables using the same name. |
| 2922 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2923 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2924 | if (prevSym) |
| 2925 | { |
| 2926 | if (!prevSym->isFunction()) |
| 2927 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2928 | error(location, "redefinition of a function", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2929 | } |
| 2930 | } |
| 2931 | else |
| 2932 | { |
| 2933 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2934 | symbolTable.getOuterLevel()->insertUnmangled(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2935 | } |
| 2936 | |
| 2937 | // We're at the inner scope level of the function's arguments and body statement. |
| 2938 | // Add the function prototype to the surrounding scope instead. |
| 2939 | symbolTable.getOuterLevel()->insert(function); |
| 2940 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 2941 | // Raise error message if main function takes any parameters or return anything other than void |
| 2942 | if (function->getName() == "main") |
| 2943 | { |
| 2944 | if (function->getParamCount() > 0) |
| 2945 | { |
| 2946 | error(location, "function cannot take any parameter(s)", "main"); |
| 2947 | } |
| 2948 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 2949 | { |
| 2950 | error(location, "main function cannot return a value", |
| 2951 | function->getReturnType().getBasicString()); |
| 2952 | } |
| 2953 | } |
| 2954 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2955 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2956 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 2957 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2958 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 2959 | // |
| 2960 | return function; |
| 2961 | } |
| 2962 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2963 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 2964 | const TString *name, |
| 2965 | const TSourceLoc &location) |
| 2966 | { |
| 2967 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 2968 | { |
| 2969 | error(location, "no qualifiers allowed for function return", |
| 2970 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2971 | } |
| 2972 | if (!type.layoutQualifier.isEmpty()) |
| 2973 | { |
| 2974 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2975 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2976 | // make sure an opaque type is not involved as well... |
| 2977 | std::string reason(getBasicString(type.getBasicType())); |
| 2978 | reason += "s can't be function return values"; |
| 2979 | checkIsNotOpaqueType(location, type.typeSpecifierNonArray, reason.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2980 | if (mShaderVersion < 300) |
| 2981 | { |
| 2982 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 2983 | // return values in ESSL 1.00. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2984 | ASSERT(type.arraySize == 0 || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2985 | |
| 2986 | if (type.isStructureContainingArrays()) |
| 2987 | { |
| 2988 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 2989 | error(location, "structures containing arrays can't be function return values", |
| 2990 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2991 | } |
| 2992 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2993 | |
| 2994 | // Add the function as a prototype after parsing it (we do not support recursion) |
| 2995 | return new TFunction(name, new TType(type)); |
| 2996 | } |
| 2997 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 2998 | TFunction *TParseContext::addNonConstructorFunc(const TString *name, const TSourceLoc &loc) |
| 2999 | { |
| 3000 | checkIsNotReserved(loc, *name); |
| 3001 | const TType *returnType = TCache::getType(EbtVoid, EbpUndefined); |
| 3002 | return new TFunction(name, returnType); |
| 3003 | } |
| 3004 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3005 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicType) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3006 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 3007 | if (mShaderVersion < 300 && publicType.array) |
| 3008 | { |
| 3009 | error(publicType.getLine(), "array constructor supported in GLSL ES 3.00 and above only", |
| 3010 | "[]"); |
| 3011 | } |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3012 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3013 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3014 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 3015 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3016 | } |
| 3017 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3018 | TType *type = new TType(publicType); |
| 3019 | if (!type->canBeConstructed()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3020 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3021 | error(publicType.getLine(), "cannot construct this type", |
| 3022 | getBasicString(publicType.getBasicType())); |
| 3023 | type->setBasicType(EbtFloat); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3024 | } |
| 3025 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3026 | return new TFunction(nullptr, type, EOpConstruct); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3027 | } |
| 3028 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 3029 | TParameter TParseContext::parseParameterDeclarator(const TPublicType &publicType, |
| 3030 | const TString *name, |
| 3031 | const TSourceLoc &nameLoc) |
| 3032 | { |
| 3033 | if (publicType.getBasicType() == EbtVoid) |
| 3034 | { |
| 3035 | error(nameLoc, "illegal use of type 'void'", name->c_str()); |
| 3036 | } |
| 3037 | checkIsNotReserved(nameLoc, *name); |
| 3038 | TType *type = new TType(publicType); |
| 3039 | TParameter param = {name, type}; |
| 3040 | return param; |
| 3041 | } |
| 3042 | |
| 3043 | TParameter TParseContext::parseParameterArrayDeclarator(const TString *identifier, |
| 3044 | const TSourceLoc &identifierLoc, |
| 3045 | TIntermTyped *arraySize, |
| 3046 | const TSourceLoc &arrayLoc, |
| 3047 | TPublicType *type) |
| 3048 | { |
| 3049 | checkIsValidTypeForArray(arrayLoc, *type); |
| 3050 | unsigned int size = checkIsValidArraySize(arrayLoc, arraySize); |
| 3051 | type->setArraySize(size); |
| 3052 | return parseParameterDeclarator(*type, identifier, identifierLoc); |
| 3053 | } |
| 3054 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3055 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 3056 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3057 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3058 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3059 | // |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3060 | TIntermTyped *TParseContext::addConstructor(TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 3061 | TType type, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3062 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3063 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3064 | if (type.isUnsizedArray()) |
| 3065 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3066 | if (arguments->empty()) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3067 | { |
| 3068 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 3069 | type.setArraySize(1u); |
| 3070 | return TIntermTyped::CreateZero(type); |
| 3071 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3072 | type.setArraySize(static_cast<unsigned int>(arguments->size())); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3073 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3074 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3075 | if (!checkConstructorArguments(line, arguments, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3076 | { |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 3077 | return TIntermTyped::CreateZero(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3078 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3079 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3080 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3081 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3082 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3083 | TIntermTyped *constConstructor = |
| 3084 | intermediate.foldAggregateBuiltIn(constructorNode, mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3085 | if (constConstructor) |
| 3086 | { |
| 3087 | return constConstructor; |
| 3088 | } |
| 3089 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3090 | return constructorNode; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3091 | } |
| 3092 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3093 | // |
| 3094 | // Interface/uniform blocks |
| 3095 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3096 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3097 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3098 | const TSourceLoc &nameLine, |
| 3099 | const TString &blockName, |
| 3100 | TFieldList *fieldList, |
| 3101 | const TString *instanceName, |
| 3102 | const TSourceLoc &instanceLine, |
| 3103 | TIntermTyped *arrayIndex, |
| 3104 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3105 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3106 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3107 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3108 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3109 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3110 | if (typeQualifier.qualifier != EvqUniform) |
| 3111 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3112 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform", |
| 3113 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3114 | } |
| 3115 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3116 | if (typeQualifier.invariant) |
| 3117 | { |
| 3118 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 3119 | } |
| 3120 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3121 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 3122 | |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3123 | // add array index |
| 3124 | unsigned int arraySize = 0; |
| 3125 | if (arrayIndex != nullptr) |
| 3126 | { |
| 3127 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
| 3128 | } |
| 3129 | |
| 3130 | if (mShaderVersion < 310) |
| 3131 | { |
| 3132 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
| 3133 | } |
| 3134 | else |
| 3135 | { |
| 3136 | checkBlockBindingIsValid(typeQualifier.line, typeQualifier.layoutQualifier.binding, |
| 3137 | arraySize); |
| 3138 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3139 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3140 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 3141 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3142 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3143 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3144 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3145 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 3146 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3147 | blockLayoutQualifier.matrixPacking = mDefaultMatrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3148 | } |
| 3149 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3150 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 3151 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3152 | blockLayoutQualifier.blockStorage = mDefaultBlockStorage; |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3153 | } |
| 3154 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3155 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3156 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3157 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 3158 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3159 | TSymbol *blockNameSymbol = new TInterfaceBlockName(&blockName); |
| 3160 | if (!symbolTable.declare(blockNameSymbol)) |
| 3161 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3162 | error(nameLine, "redefinition of an interface block name", blockName.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3163 | } |
| 3164 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3165 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3166 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3167 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3168 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3169 | TType *fieldType = field->type(); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3170 | if (IsOpaqueType(fieldType->getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3171 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3172 | std::string reason("unsupported type - "); |
| 3173 | reason += fieldType->getBasicString(); |
| 3174 | reason += " types are not allowed in interface blocks"; |
| 3175 | error(field->line(), reason.c_str(), fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3176 | } |
| 3177 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3178 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3179 | switch (qualifier) |
| 3180 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3181 | case EvqGlobal: |
| 3182 | case EvqUniform: |
| 3183 | break; |
| 3184 | default: |
| 3185 | error(field->line(), "invalid qualifier on interface block member", |
| 3186 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3187 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3188 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3189 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3190 | if (fieldType->isInvariant()) |
| 3191 | { |
| 3192 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 3193 | } |
| 3194 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3195 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3196 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3197 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3198 | checkBindingIsNotSpecified(field->line(), fieldLayoutQualifier.binding); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3199 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3200 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3201 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3202 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 3203 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3204 | } |
| 3205 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3206 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3207 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3208 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3209 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 3210 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3211 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3212 | warning(field->line(), |
| 3213 | "extraneous layout qualifier: only has an effect on matrix types", |
| 3214 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3215 | } |
| 3216 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3217 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3218 | } |
| 3219 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3220 | TInterfaceBlock *interfaceBlock = |
| 3221 | new TInterfaceBlock(&blockName, fieldList, instanceName, arraySize, blockLayoutQualifier); |
| 3222 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier, |
| 3223 | arraySize); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3224 | |
| 3225 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3226 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3227 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3228 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3229 | { |
| 3230 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3231 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3232 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3233 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3234 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3235 | |
| 3236 | // set parent pointer of the field variable |
| 3237 | fieldType->setInterfaceBlock(interfaceBlock); |
| 3238 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3239 | TVariable *fieldVariable = new TVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3240 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 3241 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3242 | if (!symbolTable.declare(fieldVariable)) |
| 3243 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3244 | error(field->line(), "redefinition of an interface block member name", |
| 3245 | field->name().c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3246 | } |
| 3247 | } |
| 3248 | } |
| 3249 | else |
| 3250 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3251 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 3252 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3253 | // add a symbol for this interface block |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3254 | TVariable *instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3255 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3256 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3257 | if (!symbolTable.declare(instanceTypeDef)) |
| 3258 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3259 | error(instanceLine, "redefinition of an interface block instance name", |
| 3260 | instanceName->c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3261 | } |
| 3262 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3263 | symbolId = instanceTypeDef->getUniqueId(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3264 | symbolName = instanceTypeDef->getName(); |
| 3265 | } |
| 3266 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3267 | TIntermSymbol *blockSymbol = |
| 3268 | intermediate.addSymbol(symbolId, symbolName, interfaceBlockType, typeQualifier.line); |
| 3269 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 3270 | declaration->appendDeclarator(blockSymbol); |
| 3271 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3272 | |
| 3273 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3274 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3275 | } |
| 3276 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 3277 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3278 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3279 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3280 | |
| 3281 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3282 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3283 | if (mStructNestingLevel > 1) |
| 3284 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3285 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3286 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3287 | } |
| 3288 | |
| 3289 | void TParseContext::exitStructDeclaration() |
| 3290 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3291 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3292 | } |
| 3293 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3294 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3295 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3296 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3297 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3298 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3299 | } |
| 3300 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3301 | if (field.type()->getBasicType() != EbtStruct) |
| 3302 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3303 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3304 | } |
| 3305 | |
| 3306 | // We're already inside a structure definition at this point, so add |
| 3307 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3308 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 3309 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3310 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3311 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 3312 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3313 | std::string reason = reasonStream.str(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3314 | error(line, reason.c_str(), field.name().c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3315 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3316 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3317 | } |
| 3318 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3319 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3320 | // Parse an array index expression |
| 3321 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3322 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 3323 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3324 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3325 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3326 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 3327 | { |
| 3328 | if (baseExpression->getAsSymbolNode()) |
| 3329 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3330 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 3331 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3332 | } |
| 3333 | else |
| 3334 | { |
| 3335 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 3336 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3337 | |
| 3338 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 3339 | unionArray->setFConst(0.0f); |
| 3340 | return intermediate.addConstantUnion(unionArray, TType(EbtFloat, EbpHigh, EvqConst), |
| 3341 | location); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3342 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 3343 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 3344 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 3345 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3346 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 3347 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 3348 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 3349 | // index is a constant expression. |
| 3350 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 3351 | { |
| 3352 | if (baseExpression->isInterfaceBlock()) |
| 3353 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3354 | error(location, |
| 3355 | "array indexes for interface blocks arrays must be constant integral expressions", |
| 3356 | "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3357 | } |
| 3358 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 3359 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3360 | error(location, |
| 3361 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3362 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3363 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3364 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3365 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3366 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3367 | } |
| 3368 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3369 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3370 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3371 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3372 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3373 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3374 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3375 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3376 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3377 | int index = indexConstantUnion->getIConst(0); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3378 | |
| 3379 | int safeIndex = -1; |
| 3380 | |
| 3381 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3382 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3383 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3384 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3385 | if (mShaderSpec == SH_WEBGL2_SPEC) |
| 3386 | { |
| 3387 | // Error has been already generated if index is not const. |
| 3388 | if (indexExpression->getQualifier() == EvqConst) |
| 3389 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3390 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3391 | } |
| 3392 | safeIndex = 0; |
| 3393 | } |
| 3394 | else if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
| 3395 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3396 | outOfRangeError(outOfRangeIndexIsError, location, |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3397 | "array index for gl_FragData must be zero when " |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3398 | "GL_EXT_draw_buffers is disabled", |
| 3399 | "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3400 | safeIndex = 0; |
| 3401 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3402 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3403 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 3404 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3405 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3406 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3407 | baseExpression->getArraySize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3408 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3409 | } |
| 3410 | } |
| 3411 | else if (baseExpression->isMatrix()) |
| 3412 | { |
| 3413 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3414 | baseExpression->getType().getCols(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3415 | "matrix field selection out of range"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3416 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3417 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3418 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3419 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3420 | baseExpression->getType().getNominalSize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3421 | "vector field selection out of range"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3422 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3423 | |
| 3424 | ASSERT(safeIndex >= 0); |
| 3425 | // Data of constant unions can't be changed, because it may be shared with other |
| 3426 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 3427 | // sanitized object. |
| 3428 | if (safeIndex != index) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3429 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3430 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 3431 | safeConstantUnion->setIConst(safeIndex); |
| 3432 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3433 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3434 | |
| 3435 | return intermediate.addIndex(EOpIndexDirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3436 | mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3437 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3438 | else |
| 3439 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3440 | return intermediate.addIndex(EOpIndexIndirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3441 | mDiagnostics); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3442 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3443 | } |
| 3444 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3445 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 3446 | const TSourceLoc &location, |
| 3447 | int index, |
| 3448 | int arraySize, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3449 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3450 | { |
| 3451 | if (index >= arraySize || index < 0) |
| 3452 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3453 | std::stringstream reasonStream; |
| 3454 | reasonStream << reason << " '" << index << "'"; |
| 3455 | std::string token = reasonStream.str(); |
| 3456 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3457 | if (index < 0) |
| 3458 | { |
| 3459 | return 0; |
| 3460 | } |
| 3461 | else |
| 3462 | { |
| 3463 | return arraySize - 1; |
| 3464 | } |
| 3465 | } |
| 3466 | return index; |
| 3467 | } |
| 3468 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3469 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 3470 | const TSourceLoc &dotLocation, |
| 3471 | const TString &fieldString, |
| 3472 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3473 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3474 | if (baseExpression->isArray()) |
| 3475 | { |
| 3476 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3477 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3478 | } |
| 3479 | |
| 3480 | if (baseExpression->isVector()) |
| 3481 | { |
| 3482 | TVectorFields fields; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3483 | if (!parseVectorFields(fieldString, baseExpression->getNominalSize(), fields, |
| 3484 | fieldLocation)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3485 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3486 | fields.num = 1; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3487 | fields.offsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3488 | } |
| 3489 | |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 3490 | return TIntermediate::AddSwizzle(baseExpression, fields, dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3491 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3492 | else if (baseExpression->getBasicType() == EbtStruct) |
| 3493 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3494 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3495 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3496 | { |
| 3497 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3498 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3499 | } |
| 3500 | else |
| 3501 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3502 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3503 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3504 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3505 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3506 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3507 | { |
| 3508 | fieldFound = true; |
| 3509 | break; |
| 3510 | } |
| 3511 | } |
| 3512 | if (fieldFound) |
| 3513 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3514 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3515 | index->setLine(fieldLocation); |
| 3516 | return intermediate.addIndex(EOpIndexDirectStruct, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3517 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3518 | } |
| 3519 | else |
| 3520 | { |
| 3521 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3522 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3523 | } |
| 3524 | } |
| 3525 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3526 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3527 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3528 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3529 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3530 | { |
| 3531 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3532 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3533 | } |
| 3534 | else |
| 3535 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3536 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3537 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3538 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3539 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3540 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3541 | { |
| 3542 | fieldFound = true; |
| 3543 | break; |
| 3544 | } |
| 3545 | } |
| 3546 | if (fieldFound) |
| 3547 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3548 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3549 | index->setLine(fieldLocation); |
| 3550 | return intermediate.addIndex(EOpIndexDirectInterfaceBlock, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3551 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3552 | } |
| 3553 | else |
| 3554 | { |
| 3555 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3556 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3557 | } |
| 3558 | } |
| 3559 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3560 | else |
| 3561 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3562 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3563 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3564 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3565 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3566 | } |
| 3567 | else |
| 3568 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3569 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3570 | " field selection requires structure, vector, or interface block on left hand " |
| 3571 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3572 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3573 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3574 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3575 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3576 | } |
| 3577 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3578 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3579 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3580 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3581 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3582 | |
| 3583 | if (qualifierType == "shared") |
| 3584 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3585 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3586 | { |
| 3587 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 3588 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3589 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3590 | } |
| 3591 | else if (qualifierType == "packed") |
| 3592 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3593 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3594 | { |
| 3595 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 3596 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3597 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3598 | } |
| 3599 | else if (qualifierType == "std140") |
| 3600 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3601 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3602 | } |
| 3603 | else if (qualifierType == "row_major") |
| 3604 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3605 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3606 | } |
| 3607 | else if (qualifierType == "column_major") |
| 3608 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3609 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3610 | } |
| 3611 | else if (qualifierType == "location") |
| 3612 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3613 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
| 3614 | qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3615 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3616 | else if (qualifierType == "yuv" && isExtensionEnabled("GL_EXT_YUV_target") && |
| 3617 | mShaderType == GL_FRAGMENT_SHADER) |
| 3618 | { |
| 3619 | qualifier.yuv = true; |
| 3620 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3621 | else if (qualifierType == "rgba32f") |
| 3622 | { |
| 3623 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3624 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 3625 | } |
| 3626 | else if (qualifierType == "rgba16f") |
| 3627 | { |
| 3628 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3629 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 3630 | } |
| 3631 | else if (qualifierType == "r32f") |
| 3632 | { |
| 3633 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3634 | qualifier.imageInternalFormat = EiifR32F; |
| 3635 | } |
| 3636 | else if (qualifierType == "rgba8") |
| 3637 | { |
| 3638 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3639 | qualifier.imageInternalFormat = EiifRGBA8; |
| 3640 | } |
| 3641 | else if (qualifierType == "rgba8_snorm") |
| 3642 | { |
| 3643 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3644 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 3645 | } |
| 3646 | else if (qualifierType == "rgba32i") |
| 3647 | { |
| 3648 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3649 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 3650 | } |
| 3651 | else if (qualifierType == "rgba16i") |
| 3652 | { |
| 3653 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3654 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 3655 | } |
| 3656 | else if (qualifierType == "rgba8i") |
| 3657 | { |
| 3658 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3659 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 3660 | } |
| 3661 | else if (qualifierType == "r32i") |
| 3662 | { |
| 3663 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3664 | qualifier.imageInternalFormat = EiifR32I; |
| 3665 | } |
| 3666 | else if (qualifierType == "rgba32ui") |
| 3667 | { |
| 3668 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3669 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 3670 | } |
| 3671 | else if (qualifierType == "rgba16ui") |
| 3672 | { |
| 3673 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3674 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 3675 | } |
| 3676 | else if (qualifierType == "rgba8ui") |
| 3677 | { |
| 3678 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3679 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 3680 | } |
| 3681 | else if (qualifierType == "r32ui") |
| 3682 | { |
| 3683 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3684 | qualifier.imageInternalFormat = EiifR32UI; |
| 3685 | } |
| 3686 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3687 | else |
| 3688 | { |
| 3689 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3690 | } |
| 3691 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3692 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3693 | } |
| 3694 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3695 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 3696 | const TSourceLoc &qualifierTypeLine, |
| 3697 | int intValue, |
| 3698 | const TSourceLoc &intValueLine, |
| 3699 | const std::string &intValueString, |
| 3700 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3701 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3702 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3703 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3704 | if (intValue < 1) |
| 3705 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3706 | std::stringstream reasonStream; |
| 3707 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 3708 | std::string reason = reasonStream.str(); |
| 3709 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3710 | } |
| 3711 | (*localSize)[index] = intValue; |
| 3712 | } |
| 3713 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3714 | void TParseContext::parseNumViews(int intValue, |
| 3715 | const TSourceLoc &intValueLine, |
| 3716 | const std::string &intValueString, |
| 3717 | int *numViews) |
| 3718 | { |
| 3719 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 3720 | // specification. |
| 3721 | if (intValue < 1) |
| 3722 | { |
| 3723 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 3724 | } |
| 3725 | *numViews = intValue; |
| 3726 | } |
| 3727 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3728 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3729 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3730 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3731 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3732 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3733 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3734 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3735 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3736 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3737 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3738 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 3739 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3740 | if (intValue < 0) |
| 3741 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3742 | error(intValueLine, "out of range: location must be non-negative", |
| 3743 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3744 | } |
| 3745 | else |
| 3746 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3747 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 3748 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3749 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3750 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3751 | else if (qualifierType == "binding") |
| 3752 | { |
| 3753 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3754 | if (intValue < 0) |
| 3755 | { |
| 3756 | error(intValueLine, "out of range: binding must be non-negative", |
| 3757 | intValueString.c_str()); |
| 3758 | } |
| 3759 | else |
| 3760 | { |
| 3761 | qualifier.binding = intValue; |
| 3762 | } |
| 3763 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 3764 | else if (qualifierType == "offset") |
| 3765 | { |
| 3766 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3767 | if (intValue < 0) |
| 3768 | { |
| 3769 | error(intValueLine, "out of range: offset must be non-negative", |
| 3770 | intValueString.c_str()); |
| 3771 | } |
| 3772 | else |
| 3773 | { |
| 3774 | qualifier.offset = intValue; |
| 3775 | } |
| 3776 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3777 | else if (qualifierType == "local_size_x") |
| 3778 | { |
| 3779 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 3780 | &qualifier.localSize); |
| 3781 | } |
| 3782 | else if (qualifierType == "local_size_y") |
| 3783 | { |
| 3784 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 3785 | &qualifier.localSize); |
| 3786 | } |
| 3787 | else if (qualifierType == "local_size_z") |
| 3788 | { |
| 3789 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 3790 | &qualifier.localSize); |
| 3791 | } |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 3792 | else if (qualifierType == "num_views" && isMultiviewExtensionEnabled() && |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3793 | mShaderType == GL_VERTEX_SHADER) |
| 3794 | { |
| 3795 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 3796 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3797 | else |
| 3798 | { |
| 3799 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3800 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3801 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3802 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3803 | } |
| 3804 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 3805 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 3806 | { |
| 3807 | return new TTypeQualifierBuilder( |
| 3808 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 3809 | mShaderVersion); |
| 3810 | } |
| 3811 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 3812 | TStorageQualifierWrapper *TParseContext::parseGlobalStorageQualifier(TQualifier qualifier, |
| 3813 | const TSourceLoc &loc) |
| 3814 | { |
| 3815 | checkIsAtGlobalLevel(loc, getQualifierString(qualifier)); |
| 3816 | return new TStorageQualifierWrapper(qualifier, loc); |
| 3817 | } |
| 3818 | |
| 3819 | TStorageQualifierWrapper *TParseContext::parseVaryingQualifier(const TSourceLoc &loc) |
| 3820 | { |
| 3821 | if (getShaderType() == GL_VERTEX_SHADER) |
| 3822 | { |
| 3823 | return parseGlobalStorageQualifier(EvqVaryingOut, loc); |
| 3824 | } |
| 3825 | return parseGlobalStorageQualifier(EvqVaryingIn, loc); |
| 3826 | } |
| 3827 | |
| 3828 | TStorageQualifierWrapper *TParseContext::parseInQualifier(const TSourceLoc &loc) |
| 3829 | { |
| 3830 | if (declaringFunction()) |
| 3831 | { |
| 3832 | return new TStorageQualifierWrapper(EvqIn, loc); |
| 3833 | } |
| 3834 | if (getShaderType() == GL_FRAGMENT_SHADER) |
| 3835 | { |
| 3836 | if (mShaderVersion < 300) |
| 3837 | { |
| 3838 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 3839 | } |
| 3840 | return new TStorageQualifierWrapper(EvqFragmentIn, loc); |
| 3841 | } |
| 3842 | if (getShaderType() == GL_VERTEX_SHADER) |
| 3843 | { |
| 3844 | if (mShaderVersion < 300 && !isMultiviewExtensionEnabled()) |
| 3845 | { |
| 3846 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 3847 | } |
| 3848 | return new TStorageQualifierWrapper(EvqVertexIn, loc); |
| 3849 | } |
| 3850 | return new TStorageQualifierWrapper(EvqComputeIn, loc); |
| 3851 | } |
| 3852 | |
| 3853 | TStorageQualifierWrapper *TParseContext::parseOutQualifier(const TSourceLoc &loc) |
| 3854 | { |
| 3855 | if (declaringFunction()) |
| 3856 | { |
| 3857 | return new TStorageQualifierWrapper(EvqOut, loc); |
| 3858 | } |
| 3859 | if (mShaderVersion < 300) |
| 3860 | { |
| 3861 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 3862 | } |
| 3863 | if (getShaderType() != GL_VERTEX_SHADER && getShaderType() != GL_FRAGMENT_SHADER) |
| 3864 | { |
| 3865 | error(loc, "storage qualifier supported in vertex and fragment shaders only", "out"); |
| 3866 | } |
| 3867 | if (getShaderType() == GL_VERTEX_SHADER) |
| 3868 | { |
| 3869 | return new TStorageQualifierWrapper(EvqVertexOut, loc); |
| 3870 | } |
| 3871 | return new TStorageQualifierWrapper(EvqFragmentOut, loc); |
| 3872 | } |
| 3873 | |
| 3874 | TStorageQualifierWrapper *TParseContext::parseInOutQualifier(const TSourceLoc &loc) |
| 3875 | { |
| 3876 | if (!declaringFunction()) |
| 3877 | { |
| 3878 | error(loc, "invalid qualifier: can be only used with function parameters", "inout"); |
| 3879 | } |
| 3880 | return new TStorageQualifierWrapper(EvqInOut, loc); |
| 3881 | } |
| 3882 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3883 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3884 | TLayoutQualifier rightQualifier, |
| 3885 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3886 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3887 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3888 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3889 | } |
| 3890 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 3891 | TField *TParseContext::parseStructDeclarator(TString *identifier, const TSourceLoc &loc) |
| 3892 | { |
| 3893 | checkIsNotReserved(loc, *identifier); |
| 3894 | TType *type = new TType(EbtVoid, EbpUndefined); |
| 3895 | return new TField(type, identifier, loc); |
| 3896 | } |
| 3897 | |
| 3898 | TField *TParseContext::parseStructArrayDeclarator(TString *identifier, |
| 3899 | const TSourceLoc &loc, |
| 3900 | TIntermTyped *arraySize, |
| 3901 | const TSourceLoc &arraySizeLoc) |
| 3902 | { |
| 3903 | checkIsNotReserved(loc, *identifier); |
| 3904 | |
| 3905 | TType *type = new TType(EbtVoid, EbpUndefined); |
| 3906 | unsigned int size = checkIsValidArraySize(arraySizeLoc, arraySize); |
| 3907 | type->setArraySize(size); |
| 3908 | |
| 3909 | return new TField(type, identifier, loc); |
| 3910 | } |
| 3911 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3912 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 3913 | const TFieldList *newlyAddedFields, |
| 3914 | const TSourceLoc &location) |
| 3915 | { |
| 3916 | for (TField *field : *newlyAddedFields) |
| 3917 | { |
| 3918 | for (TField *oldField : *processedFields) |
| 3919 | { |
| 3920 | if (oldField->name() == field->name()) |
| 3921 | { |
| 3922 | error(location, "duplicate field name in structure", field->name().c_str()); |
| 3923 | } |
| 3924 | } |
| 3925 | processedFields->push_back(field); |
| 3926 | } |
| 3927 | return processedFields; |
| 3928 | } |
| 3929 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3930 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 3931 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3932 | TPublicType *typeSpecifier, |
| 3933 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3934 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3935 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3936 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3937 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 3938 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3939 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3940 | typeSpecifier->invariant = typeQualifier.invariant; |
| 3941 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3942 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3943 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3944 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3945 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3946 | } |
| 3947 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3948 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
| 3949 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3950 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3951 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 3952 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3953 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3954 | checkIsNonVoid(typeSpecifier.getLine(), (*fieldList)[0]->name(), typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3955 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3956 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3957 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3958 | for (unsigned int i = 0; i < fieldList->size(); ++i) |
| 3959 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3960 | // |
| 3961 | // Careful not to replace already known aspects of type, like array-ness |
| 3962 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3963 | TType *type = (*fieldList)[i]->type(); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3964 | type->setBasicType(typeSpecifier.getBasicType()); |
| 3965 | type->setPrimarySize(typeSpecifier.getPrimarySize()); |
| 3966 | type->setSecondarySize(typeSpecifier.getSecondarySize()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3967 | type->setPrecision(typeSpecifier.precision); |
| 3968 | type->setQualifier(typeSpecifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3969 | type->setLayoutQualifier(typeSpecifier.layoutQualifier); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3970 | type->setMemoryQualifier(typeSpecifier.memoryQualifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3971 | type->setInvariant(typeSpecifier.invariant); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3972 | |
| 3973 | // don't allow arrays of arrays |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3974 | if (type->isArray()) |
| 3975 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3976 | checkIsValidTypeForArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3977 | } |
| 3978 | if (typeSpecifier.array) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3979 | type->setArraySize(static_cast<unsigned int>(typeSpecifier.arraySize)); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3980 | if (typeSpecifier.getUserDef()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3981 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3982 | type->setStruct(typeSpecifier.getUserDef()->getStruct()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3983 | } |
| 3984 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3985 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*fieldList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3986 | } |
| 3987 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3988 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3989 | } |
| 3990 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3991 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 3992 | const TSourceLoc &nameLine, |
| 3993 | const TString *structName, |
| 3994 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3995 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3996 | TStructure *structure = new TStructure(structName, fieldList); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3997 | TType *structureType = new TType(structure); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3998 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3999 | // Store a bool in the struct if we're at global scope, to allow us to |
| 4000 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4001 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 4002 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4003 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4004 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4005 | checkIsNotReserved(nameLine, *structName); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4006 | TVariable *userTypeDef = new TVariable(structName, *structureType, true); |
| 4007 | if (!symbolTable.declare(userTypeDef)) |
| 4008 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4009 | error(nameLine, "redefinition of a struct", structName->c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4010 | } |
| 4011 | } |
| 4012 | |
| 4013 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4014 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4015 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4016 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4017 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4018 | switch (qualifier) |
| 4019 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4020 | case EvqGlobal: |
| 4021 | case EvqTemporary: |
| 4022 | break; |
| 4023 | default: |
| 4024 | error(field.line(), "invalid qualifier on struct member", |
| 4025 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4026 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4027 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4028 | if (field.type()->isInvariant()) |
| 4029 | { |
| 4030 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 4031 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4032 | // ESSL 3.10 section 4.1.8 -- atomic_uint or images are not allowed as structure member. |
| 4033 | if (IsImage(field.type()->getBasicType()) || IsAtomicCounter(field.type()->getBasicType())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4034 | { |
| 4035 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 4036 | } |
| 4037 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4038 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 4039 | |
| 4040 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4041 | |
| 4042 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4043 | } |
| 4044 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4045 | TTypeSpecifierNonArray typeSpecifierNonArray; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4046 | typeSpecifierNonArray.initializeStruct(structureType, true, structLine); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4047 | exitStructDeclaration(); |
| 4048 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4049 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4050 | } |
| 4051 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4052 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 4053 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4054 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4055 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4056 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4057 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4058 | init->isVector()) |
| 4059 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4060 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 4061 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4062 | return nullptr; |
| 4063 | } |
| 4064 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4065 | if (statementList) |
| 4066 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4067 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4068 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4069 | return nullptr; |
| 4070 | } |
| 4071 | } |
| 4072 | |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4073 | TIntermSwitch *node = intermediate.addSwitch(init, statementList, loc); |
| 4074 | if (node == nullptr) |
| 4075 | { |
| 4076 | error(loc, "erroneous switch statement", "switch"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4077 | return nullptr; |
| 4078 | } |
| 4079 | return node; |
| 4080 | } |
| 4081 | |
| 4082 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 4083 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4084 | if (mSwitchNestingLevel == 0) |
| 4085 | { |
| 4086 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4087 | return nullptr; |
| 4088 | } |
| 4089 | if (condition == nullptr) |
| 4090 | { |
| 4091 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4092 | return nullptr; |
| 4093 | } |
| 4094 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4095 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4096 | { |
| 4097 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4098 | } |
| 4099 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4100 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 4101 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 4102 | // fold in case labels. |
| 4103 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4104 | { |
| 4105 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4106 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4107 | TIntermCase *node = intermediate.addCase(condition, loc); |
| 4108 | if (node == nullptr) |
| 4109 | { |
| 4110 | error(loc, "erroneous case statement", "case"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4111 | return nullptr; |
| 4112 | } |
| 4113 | return node; |
| 4114 | } |
| 4115 | |
| 4116 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 4117 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4118 | if (mSwitchNestingLevel == 0) |
| 4119 | { |
| 4120 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4121 | return nullptr; |
| 4122 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4123 | TIntermCase *node = intermediate.addCase(nullptr, loc); |
| 4124 | if (node == nullptr) |
| 4125 | { |
| 4126 | error(loc, "erroneous default statement", "default"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4127 | return nullptr; |
| 4128 | } |
| 4129 | return node; |
| 4130 | } |
| 4131 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4132 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 4133 | TIntermTyped *child, |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4134 | const TSourceLoc &loc) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4135 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4136 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4137 | |
| 4138 | switch (op) |
| 4139 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4140 | case EOpLogicalNot: |
| 4141 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 4142 | child->isVector()) |
| 4143 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4144 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4145 | return nullptr; |
| 4146 | } |
| 4147 | break; |
| 4148 | case EOpBitwiseNot: |
| 4149 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 4150 | child->isMatrix() || child->isArray()) |
| 4151 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4152 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4153 | return nullptr; |
| 4154 | } |
| 4155 | break; |
| 4156 | case EOpPostIncrement: |
| 4157 | case EOpPreIncrement: |
| 4158 | case EOpPostDecrement: |
| 4159 | case EOpPreDecrement: |
| 4160 | case EOpNegative: |
| 4161 | case EOpPositive: |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4162 | if (child->getBasicType() == EbtStruct || child->isInterfaceBlock() || |
| 4163 | child->getBasicType() == EbtBool || child->isArray() || |
| 4164 | IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4165 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4166 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4167 | return nullptr; |
| 4168 | } |
| 4169 | // Operators for built-ins are already type checked against their prototype. |
| 4170 | default: |
| 4171 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4172 | } |
| 4173 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4174 | TIntermUnary *node = new TIntermUnary(op, child); |
| 4175 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4176 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4177 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4178 | if (foldedNode) |
| 4179 | return foldedNode; |
| 4180 | |
| 4181 | return node; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4182 | } |
| 4183 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4184 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 4185 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4186 | ASSERT(op != EOpNull); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4187 | TIntermTyped *node = createUnaryMath(op, child, loc); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4188 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4189 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4190 | return child; |
| 4191 | } |
| 4192 | return node; |
| 4193 | } |
| 4194 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4195 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 4196 | TIntermTyped *child, |
| 4197 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4198 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4199 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4200 | return addUnaryMath(op, child, loc); |
| 4201 | } |
| 4202 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4203 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 4204 | TIntermTyped *left, |
| 4205 | TIntermTyped *right, |
| 4206 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4207 | { |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 4208 | // Check opaque types are not allowed to be operands in expressions other than array indexing |
| 4209 | // and structure member selection. |
| 4210 | if (IsOpaqueType(left->getBasicType()) || IsOpaqueType(right->getBasicType())) |
| 4211 | { |
| 4212 | switch (op) |
| 4213 | { |
| 4214 | case EOpIndexDirect: |
| 4215 | case EOpIndexIndirect: |
| 4216 | break; |
| 4217 | case EOpIndexDirectStruct: |
| 4218 | UNREACHABLE(); |
| 4219 | |
| 4220 | default: |
| 4221 | error(loc, "Invalid operation for variables with an opaque type", |
| 4222 | GetOperatorString(op)); |
| 4223 | return false; |
| 4224 | } |
| 4225 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 4226 | |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4227 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 4228 | { |
| 4229 | switch (op) |
| 4230 | { |
| 4231 | case EOpIndexDirectStruct: |
| 4232 | ASSERT(left->getType().getStruct()); |
| 4233 | break; |
| 4234 | case EOpEqual: |
| 4235 | case EOpNotEqual: |
| 4236 | case EOpAssign: |
| 4237 | case EOpInitialize: |
| 4238 | if (left->getType() != right->getType()) |
| 4239 | { |
| 4240 | return false; |
| 4241 | } |
| 4242 | break; |
| 4243 | default: |
| 4244 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 4245 | return false; |
| 4246 | } |
| 4247 | } |
| 4248 | |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4249 | if (left->isInterfaceBlock() || right->isInterfaceBlock()) |
| 4250 | { |
| 4251 | switch (op) |
| 4252 | { |
| 4253 | case EOpIndexDirectInterfaceBlock: |
| 4254 | ASSERT(left->getType().getInterfaceBlock()); |
| 4255 | break; |
| 4256 | default: |
| 4257 | error(loc, "Invalid operation for interface blocks", GetOperatorString(op)); |
| 4258 | return false; |
| 4259 | } |
| 4260 | } |
| 4261 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4262 | if (left->isArray() || right->isArray()) |
| 4263 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4264 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 4265 | { |
| 4266 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 4267 | return false; |
| 4268 | } |
| 4269 | |
| 4270 | if (left->isArray() != right->isArray()) |
| 4271 | { |
| 4272 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 4273 | return false; |
| 4274 | } |
| 4275 | |
| 4276 | switch (op) |
| 4277 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4278 | case EOpEqual: |
| 4279 | case EOpNotEqual: |
| 4280 | case EOpAssign: |
| 4281 | case EOpInitialize: |
| 4282 | break; |
| 4283 | default: |
| 4284 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 4285 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 4286 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 4287 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 4288 | if (left->getArraySize() != right->getArraySize()) |
| 4289 | { |
| 4290 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 4291 | return false; |
| 4292 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4293 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4294 | |
| 4295 | // Check ops which require integer / ivec parameters |
| 4296 | bool isBitShift = false; |
| 4297 | switch (op) |
| 4298 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4299 | case EOpBitShiftLeft: |
| 4300 | case EOpBitShiftRight: |
| 4301 | case EOpBitShiftLeftAssign: |
| 4302 | case EOpBitShiftRightAssign: |
| 4303 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 4304 | // check that the basic type is an integer type. |
| 4305 | isBitShift = true; |
| 4306 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 4307 | { |
| 4308 | return false; |
| 4309 | } |
| 4310 | break; |
| 4311 | case EOpBitwiseAnd: |
| 4312 | case EOpBitwiseXor: |
| 4313 | case EOpBitwiseOr: |
| 4314 | case EOpBitwiseAndAssign: |
| 4315 | case EOpBitwiseXorAssign: |
| 4316 | case EOpBitwiseOrAssign: |
| 4317 | // It is enough to check the type of only one operand, since later it |
| 4318 | // is checked that the operand types match. |
| 4319 | if (!IsInteger(left->getBasicType())) |
| 4320 | { |
| 4321 | return false; |
| 4322 | } |
| 4323 | break; |
| 4324 | default: |
| 4325 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4326 | } |
| 4327 | |
| 4328 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 4329 | // So the basic type should usually match. |
| 4330 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 4331 | { |
| 4332 | return false; |
| 4333 | } |
| 4334 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 4335 | // Check that: |
| 4336 | // 1. Type sizes match exactly on ops that require that. |
| 4337 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 4338 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4339 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4340 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4341 | case EOpAssign: |
| 4342 | case EOpInitialize: |
| 4343 | case EOpEqual: |
| 4344 | case EOpNotEqual: |
| 4345 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 4346 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 4347 | { |
| 4348 | error(loc, "undefined operation for structs containing arrays", |
| 4349 | GetOperatorString(op)); |
| 4350 | return false; |
| 4351 | } |
| 4352 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 4353 | // we interpret the spec so that this extends to structs containing samplers, |
| 4354 | // similarly to ESSL 1.00 spec. |
| 4355 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 4356 | left->getType().isStructureContainingSamplers()) |
| 4357 | { |
| 4358 | error(loc, "undefined operation for structs containing samplers", |
| 4359 | GetOperatorString(op)); |
| 4360 | return false; |
| 4361 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4362 | |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 4363 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 4364 | (left->getSecondarySize() != right->getSecondarySize())) |
| 4365 | { |
| 4366 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 4367 | return false; |
| 4368 | } |
| 4369 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4370 | case EOpLessThan: |
| 4371 | case EOpGreaterThan: |
| 4372 | case EOpLessThanEqual: |
| 4373 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 4374 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4375 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 4376 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4377 | return false; |
| 4378 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 4379 | break; |
| 4380 | case EOpAdd: |
| 4381 | case EOpSub: |
| 4382 | case EOpDiv: |
| 4383 | case EOpIMod: |
| 4384 | case EOpBitShiftLeft: |
| 4385 | case EOpBitShiftRight: |
| 4386 | case EOpBitwiseAnd: |
| 4387 | case EOpBitwiseXor: |
| 4388 | case EOpBitwiseOr: |
| 4389 | case EOpAddAssign: |
| 4390 | case EOpSubAssign: |
| 4391 | case EOpDivAssign: |
| 4392 | case EOpIModAssign: |
| 4393 | case EOpBitShiftLeftAssign: |
| 4394 | case EOpBitShiftRightAssign: |
| 4395 | case EOpBitwiseAndAssign: |
| 4396 | case EOpBitwiseXorAssign: |
| 4397 | case EOpBitwiseOrAssign: |
| 4398 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 4399 | { |
| 4400 | return false; |
| 4401 | } |
| 4402 | |
| 4403 | // Are the sizes compatible? |
| 4404 | if (left->getNominalSize() != right->getNominalSize() || |
| 4405 | left->getSecondarySize() != right->getSecondarySize()) |
| 4406 | { |
| 4407 | // If the nominal sizes of operands do not match: |
| 4408 | // One of them must be a scalar. |
| 4409 | if (!left->isScalar() && !right->isScalar()) |
| 4410 | return false; |
| 4411 | |
| 4412 | // In the case of compound assignment other than multiply-assign, |
| 4413 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 4414 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 4415 | // vector either. |
| 4416 | if (!right->isScalar() && |
| 4417 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 4418 | return false; |
| 4419 | } |
| 4420 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4421 | default: |
| 4422 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4423 | } |
| 4424 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4425 | return true; |
| 4426 | } |
| 4427 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4428 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 4429 | const TType &left, |
| 4430 | const TType &right) |
| 4431 | { |
| 4432 | switch (op) |
| 4433 | { |
| 4434 | case EOpMul: |
| 4435 | case EOpMulAssign: |
| 4436 | return left.getNominalSize() == right.getNominalSize() && |
| 4437 | left.getSecondarySize() == right.getSecondarySize(); |
| 4438 | case EOpVectorTimesScalar: |
| 4439 | return true; |
| 4440 | case EOpVectorTimesScalarAssign: |
| 4441 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 4442 | return left.isVector() && !right.isVector(); |
| 4443 | case EOpVectorTimesMatrix: |
| 4444 | return left.getNominalSize() == right.getRows(); |
| 4445 | case EOpVectorTimesMatrixAssign: |
| 4446 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 4447 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 4448 | left.getNominalSize() == right.getCols(); |
| 4449 | case EOpMatrixTimesVector: |
| 4450 | return left.getCols() == right.getNominalSize(); |
| 4451 | case EOpMatrixTimesScalar: |
| 4452 | return true; |
| 4453 | case EOpMatrixTimesScalarAssign: |
| 4454 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 4455 | return !right.isVector(); |
| 4456 | case EOpMatrixTimesMatrix: |
| 4457 | return left.getCols() == right.getRows(); |
| 4458 | case EOpMatrixTimesMatrixAssign: |
| 4459 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 4460 | // We need to check two things: |
| 4461 | // 1. The matrix multiplication step is valid. |
| 4462 | // 2. The result will have the same number of columns as the lvalue. |
| 4463 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 4464 | |
| 4465 | default: |
| 4466 | UNREACHABLE(); |
| 4467 | return false; |
| 4468 | } |
| 4469 | } |
| 4470 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4471 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 4472 | TIntermTyped *left, |
| 4473 | TIntermTyped *right, |
| 4474 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4475 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4476 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4477 | return nullptr; |
| 4478 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4479 | switch (op) |
| 4480 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4481 | case EOpEqual: |
| 4482 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4483 | case EOpLessThan: |
| 4484 | case EOpGreaterThan: |
| 4485 | case EOpLessThanEqual: |
| 4486 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4487 | break; |
| 4488 | case EOpLogicalOr: |
| 4489 | case EOpLogicalXor: |
| 4490 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4491 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4492 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4493 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4494 | { |
| 4495 | return nullptr; |
| 4496 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4497 | // Basic types matching should have been already checked. |
| 4498 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4499 | break; |
| 4500 | case EOpAdd: |
| 4501 | case EOpSub: |
| 4502 | case EOpDiv: |
| 4503 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4504 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4505 | !right->getType().getStruct()); |
| 4506 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4507 | { |
| 4508 | return nullptr; |
| 4509 | } |
| 4510 | break; |
| 4511 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4512 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4513 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4514 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4515 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4516 | { |
| 4517 | return nullptr; |
| 4518 | } |
| 4519 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4520 | default: |
| 4521 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4522 | } |
| 4523 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4524 | if (op == EOpMul) |
| 4525 | { |
| 4526 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 4527 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4528 | { |
| 4529 | return nullptr; |
| 4530 | } |
| 4531 | } |
| 4532 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4533 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4534 | node->setLine(loc); |
| 4535 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4536 | // See if we can fold constants. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4537 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4538 | if (foldedNode) |
| 4539 | return foldedNode; |
| 4540 | |
| 4541 | return node; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4542 | } |
| 4543 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4544 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 4545 | TIntermTyped *left, |
| 4546 | TIntermTyped *right, |
| 4547 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4548 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4549 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4550 | if (node == 0) |
| 4551 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4552 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4553 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4554 | return left; |
| 4555 | } |
| 4556 | return node; |
| 4557 | } |
| 4558 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4559 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 4560 | TIntermTyped *left, |
| 4561 | TIntermTyped *right, |
| 4562 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4563 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4564 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4565 | if (node == 0) |
| 4566 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4567 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4568 | right->getCompleteString()); |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 4569 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4570 | unionArray->setBConst(false); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4571 | return intermediate.addConstantUnion(unionArray, TType(EbtBool, EbpUndefined, EvqConst), |
| 4572 | loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4573 | } |
| 4574 | return node; |
| 4575 | } |
| 4576 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 4577 | TIntermBinary *TParseContext::createAssign(TOperator op, |
| 4578 | TIntermTyped *left, |
| 4579 | TIntermTyped *right, |
| 4580 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4581 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4582 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4583 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4584 | if (op == EOpMulAssign) |
| 4585 | { |
| 4586 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 4587 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4588 | { |
| 4589 | return nullptr; |
| 4590 | } |
| 4591 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4592 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4593 | node->setLine(loc); |
| 4594 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4595 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4596 | } |
| 4597 | return nullptr; |
| 4598 | } |
| 4599 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4600 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 4601 | TIntermTyped *left, |
| 4602 | TIntermTyped *right, |
| 4603 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4604 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4605 | checkCanBeLValue(loc, "assign", left); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4606 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 4607 | if (node == nullptr) |
| 4608 | { |
| 4609 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4610 | return left; |
| 4611 | } |
| 4612 | return node; |
| 4613 | } |
| 4614 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4615 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 4616 | TIntermTyped *right, |
| 4617 | const TSourceLoc &loc) |
| 4618 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4619 | // WebGL2 section 5.26, the following results in an error: |
| 4620 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4621 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 4622 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 4623 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 4624 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4625 | { |
| 4626 | error(loc, |
| 4627 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 4628 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4629 | } |
| 4630 | |
Olli Etuaho | 4db7ded | 2016-10-13 12:23:11 +0100 | [diff] [blame] | 4631 | return TIntermediate::AddComma(left, right, loc, mShaderVersion); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4632 | } |
| 4633 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4634 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 4635 | { |
| 4636 | switch (op) |
| 4637 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4638 | case EOpContinue: |
| 4639 | if (mLoopNestingLevel <= 0) |
| 4640 | { |
| 4641 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4642 | } |
| 4643 | break; |
| 4644 | case EOpBreak: |
| 4645 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 4646 | { |
| 4647 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4648 | } |
| 4649 | break; |
| 4650 | case EOpReturn: |
| 4651 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 4652 | { |
| 4653 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4654 | } |
| 4655 | break; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4656 | case EOpKill: |
| 4657 | if (mShaderType != GL_FRAGMENT_SHADER) |
| 4658 | { |
| 4659 | error(loc, "discard supported in fragment shaders only", "discard"); |
| 4660 | } |
| 4661 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4662 | default: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4663 | UNREACHABLE(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4664 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4665 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4666 | return addBranch(op, nullptr, loc); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4667 | } |
| 4668 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4669 | TIntermBranch *TParseContext::addBranch(TOperator op, |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4670 | TIntermTyped *expression, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4671 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4672 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4673 | if (expression != nullptr) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4674 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4675 | ASSERT(op == EOpReturn); |
| 4676 | mFunctionReturnsValue = true; |
| 4677 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
| 4678 | { |
| 4679 | error(loc, "void function cannot return a value", "return"); |
| 4680 | } |
| 4681 | else if (*mCurrentFunctionType != expression->getType()) |
| 4682 | { |
| 4683 | error(loc, "function return is not matching type:", "return"); |
| 4684 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4685 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame^] | 4686 | TIntermBranch *node = new TIntermBranch(op, expression); |
| 4687 | node->setLine(loc); |
| 4688 | return node; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4689 | } |
| 4690 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4691 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 4692 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4693 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4694 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4695 | TIntermNode *offset = nullptr; |
| 4696 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4697 | if (name == "texelFetchOffset" || name == "textureLodOffset" || |
| 4698 | name == "textureProjLodOffset" || name == "textureGradOffset" || |
| 4699 | name == "textureProjGradOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4700 | { |
| 4701 | offset = arguments->back(); |
| 4702 | } |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4703 | else if (name == "textureOffset" || name == "textureProjOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4704 | { |
| 4705 | // A bias parameter might follow the offset parameter. |
| 4706 | ASSERT(arguments->size() >= 3); |
| 4707 | offset = (*arguments)[2]; |
| 4708 | } |
| 4709 | if (offset != nullptr) |
| 4710 | { |
| 4711 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 4712 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 4713 | { |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4714 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4715 | name.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4716 | } |
| 4717 | else |
| 4718 | { |
| 4719 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 4720 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 4721 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 4722 | for (size_t i = 0u; i < size; ++i) |
| 4723 | { |
| 4724 | int offsetValue = values[i].getIConst(); |
| 4725 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 4726 | { |
| 4727 | std::stringstream tokenStream; |
| 4728 | tokenStream << offsetValue; |
| 4729 | std::string token = tokenStream.str(); |
| 4730 | error(offset->getLine(), "Texture offset value out of valid range", |
| 4731 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4732 | } |
| 4733 | } |
| 4734 | } |
| 4735 | } |
| 4736 | } |
| 4737 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4738 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 4739 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 4740 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4741 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4742 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
| 4743 | |
| 4744 | if (name.compare(0, 5, "image") == 0) |
| 4745 | { |
| 4746 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4747 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4748 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4749 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4750 | |
| 4751 | if (name.compare(5, 5, "Store") == 0) |
| 4752 | { |
| 4753 | if (memoryQualifier.readonly) |
| 4754 | { |
| 4755 | error(imageNode->getLine(), |
| 4756 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4757 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4758 | } |
| 4759 | } |
| 4760 | else if (name.compare(5, 4, "Load") == 0) |
| 4761 | { |
| 4762 | if (memoryQualifier.writeonly) |
| 4763 | { |
| 4764 | error(imageNode->getLine(), |
| 4765 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4766 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4767 | } |
| 4768 | } |
| 4769 | } |
| 4770 | } |
| 4771 | |
| 4772 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 4773 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 4774 | const TFunction *functionDefinition, |
| 4775 | const TIntermAggregate *functionCall) |
| 4776 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4777 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4778 | |
| 4779 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 4780 | |
| 4781 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 4782 | |
| 4783 | for (size_t i = 0; i < arguments.size(); ++i) |
| 4784 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4785 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 4786 | const TType &functionArgumentType = typedArgument->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4787 | const TType &functionParameterType = *functionDefinition->getParam(i).type; |
| 4788 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 4789 | |
| 4790 | if (IsImage(functionArgumentType.getBasicType())) |
| 4791 | { |
| 4792 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 4793 | functionArgumentType.getMemoryQualifier(); |
| 4794 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 4795 | functionParameterType.getMemoryQualifier(); |
| 4796 | if (functionArgumentMemoryQualifier.readonly && |
| 4797 | !functionParameterMemoryQualifier.readonly) |
| 4798 | { |
| 4799 | error(functionCall->getLine(), |
| 4800 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4801 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4802 | } |
| 4803 | |
| 4804 | if (functionArgumentMemoryQualifier.writeonly && |
| 4805 | !functionParameterMemoryQualifier.writeonly) |
| 4806 | { |
| 4807 | error(functionCall->getLine(), |
| 4808 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4809 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4810 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4811 | |
| 4812 | if (functionArgumentMemoryQualifier.coherent && |
| 4813 | !functionParameterMemoryQualifier.coherent) |
| 4814 | { |
| 4815 | error(functionCall->getLine(), |
| 4816 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4817 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4818 | } |
| 4819 | |
| 4820 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 4821 | !functionParameterMemoryQualifier.volatileQualifier) |
| 4822 | { |
| 4823 | error(functionCall->getLine(), |
| 4824 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4825 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4826 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4827 | } |
| 4828 | } |
| 4829 | } |
| 4830 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4831 | TIntermSequence *TParseContext::createEmptyArgumentsList() |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4832 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4833 | return new TIntermSequence(); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4834 | } |
| 4835 | |
| 4836 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4837 | TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4838 | TIntermNode *thisNode, |
| 4839 | const TSourceLoc &loc) |
| 4840 | { |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4841 | if (thisNode != nullptr) |
| 4842 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4843 | return addMethod(fnCall, arguments, thisNode, loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4844 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4845 | |
| 4846 | TOperator op = fnCall->getBuiltInOp(); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 4847 | if (op == EOpConstruct) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4848 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 4849 | return addConstructor(arguments, fnCall->getReturnType(), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4850 | } |
| 4851 | else |
| 4852 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 4853 | ASSERT(op == EOpNull); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4854 | return addNonConstructorFunctionCall(fnCall, arguments, loc); |
| 4855 | } |
| 4856 | } |
| 4857 | |
| 4858 | TIntermTyped *TParseContext::addMethod(TFunction *fnCall, |
| 4859 | TIntermSequence *arguments, |
| 4860 | TIntermNode *thisNode, |
| 4861 | const TSourceLoc &loc) |
| 4862 | { |
| 4863 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 4864 | int arraySize = 0; |
| 4865 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 4866 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 4867 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 4868 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
| 4869 | // So accessing fnCall->getName() below is safe. |
| 4870 | if (fnCall->getName() != "length") |
| 4871 | { |
| 4872 | error(loc, "invalid method", fnCall->getName().c_str()); |
| 4873 | } |
| 4874 | else if (!arguments->empty()) |
| 4875 | { |
| 4876 | error(loc, "method takes no parameters", "length"); |
| 4877 | } |
| 4878 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 4879 | { |
| 4880 | error(loc, "length can only be called on arrays", "length"); |
| 4881 | } |
| 4882 | else |
| 4883 | { |
| 4884 | arraySize = typedThis->getArraySize(); |
| 4885 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4886 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4887 | // This code path can be hit with expressions like these: |
| 4888 | // (a = b).length() |
| 4889 | // (func()).length() |
| 4890 | // (int[3](0, 1, 2)).length() |
| 4891 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 4892 | // expression. |
| 4893 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 4894 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 4895 | // length method applied". |
| 4896 | error(loc, "length can only be called on array names, not on array expressions", |
| 4897 | "length"); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4898 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4899 | } |
| 4900 | unionArray->setIConst(arraySize); |
| 4901 | return intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), loc); |
| 4902 | } |
| 4903 | |
| 4904 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunction *fnCall, |
| 4905 | TIntermSequence *arguments, |
| 4906 | const TSourceLoc &loc) |
| 4907 | { |
| 4908 | // First find by unmangled name to check whether the function name has been |
| 4909 | // hidden by a variable name or struct typename. |
| 4910 | // If a function is found, check for one with a matching argument list. |
| 4911 | bool builtIn; |
| 4912 | const TSymbol *symbol = symbolTable.find(fnCall->getName(), mShaderVersion, &builtIn); |
| 4913 | if (symbol != nullptr && !symbol->isFunction()) |
| 4914 | { |
| 4915 | error(loc, "function name expected", fnCall->getName().c_str()); |
| 4916 | } |
| 4917 | else |
| 4918 | { |
| 4919 | symbol = symbolTable.find(TFunction::GetMangledNameFromCall(fnCall->getName(), *arguments), |
| 4920 | mShaderVersion, &builtIn); |
| 4921 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4922 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4923 | error(loc, "no matching overloaded function found", fnCall->getName().c_str()); |
| 4924 | } |
| 4925 | else |
| 4926 | { |
| 4927 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4928 | // |
| 4929 | // A declared function. |
| 4930 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 4931 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4932 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4933 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4934 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4935 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4936 | if (builtIn && op != EOpNull) |
| 4937 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4938 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4939 | if (fnCandidate->getParamCount() == 1) |
| 4940 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4941 | // Treat it like a built-in unary operator. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4942 | TIntermNode *unaryParamNode = arguments->front(); |
| 4943 | TIntermTyped *callNode = createUnaryMath(op, unaryParamNode->getAsTyped(), loc); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4944 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4945 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4946 | } |
| 4947 | else |
| 4948 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4949 | TIntermAggregate *callNode = |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4950 | TIntermAggregate::Create(fnCandidate->getReturnType(), op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4951 | callNode->setLine(loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4952 | |
| 4953 | // Some built-in functions have out parameters too. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4954 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4955 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4956 | // See if we can constant fold a built-in. Note that this may be possible even |
| 4957 | // if it is not const-qualified. |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4958 | TIntermTyped *foldedNode = |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4959 | intermediate.foldAggregateBuiltIn(callNode, mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4960 | if (foldedNode) |
| 4961 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4962 | return foldedNode; |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4963 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4964 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4965 | } |
| 4966 | } |
| 4967 | else |
| 4968 | { |
| 4969 | // This is a real function call |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4970 | TIntermAggregate *callNode = nullptr; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4971 | |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4972 | // If builtIn == false, the function is user defined - could be an overloaded |
| 4973 | // built-in as well. |
| 4974 | // if builtIn == true, it's a builtIn function with no op associated with it. |
| 4975 | // This needs to happen after the function info including name is set. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4976 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4977 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4978 | callNode = TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4979 | checkTextureOffsetConst(callNode); |
| 4980 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4981 | } |
| 4982 | else |
| 4983 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4984 | callNode = TIntermAggregate::CreateFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4985 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4986 | } |
| 4987 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4988 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4989 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4990 | callNode->setLine(loc); |
| 4991 | |
| 4992 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4993 | } |
| 4994 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4995 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4996 | |
| 4997 | // Error message was already written. Put on a dummy node for error recovery. |
| 4998 | return TIntermTyped::CreateZero(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4999 | } |
| 5000 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5001 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5002 | TIntermTyped *trueExpression, |
| 5003 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5004 | const TSourceLoc &loc) |
| 5005 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 5006 | checkIsScalarBool(loc, cond); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5007 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5008 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5009 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5010 | binaryOpError(loc, "?:", trueExpression->getCompleteString(), |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5011 | falseExpression->getCompleteString()); |
| 5012 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5013 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5014 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 5015 | { |
| 5016 | // ESSL 1.00 section 4.1.7 |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5017 | // ESSL 3.00.6 section 4.1.7 |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5018 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 5019 | // Note that structs containing opaque types don't need to be checked as structs are |
| 5020 | // forbidden below. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5021 | error(loc, "ternary operator is not allowed for opaque types", "?:"); |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5022 | return falseExpression; |
| 5023 | } |
| 5024 | |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5025 | // ESSL 1.00.17 sections 5.2 and 5.7: |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5026 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5027 | // ESSL 3.00.6 section 5.7: |
| 5028 | // Ternary operator support is optional for arrays. No certainty that it works across all |
| 5029 | // devices with struct either, so we err on the side of caution here. TODO (oetuaho@nvidia.com): |
| 5030 | // Would be nice to make the spec and implementation agree completely here. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5031 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5032 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5033 | error(loc, "ternary operator is not allowed for structures or arrays", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5034 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5035 | } |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5036 | if (trueExpression->getBasicType() == EbtInterfaceBlock) |
| 5037 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5038 | error(loc, "ternary operator is not allowed for interface blocks", "?:"); |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5039 | return falseExpression; |
| 5040 | } |
| 5041 | |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5042 | // WebGL2 section 5.26, the following results in an error: |
| 5043 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5044 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5045 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5046 | error(loc, "ternary operator is not allowed for void", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5047 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5048 | } |
| 5049 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5050 | return TIntermediate::AddTernarySelection(cond, trueExpression, falseExpression, loc); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5051 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5052 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 5053 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5054 | // Parse an array of strings using yyparse. |
| 5055 | // |
| 5056 | // Returns 0 for success. |
| 5057 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5058 | int PaParseStrings(size_t count, |
| 5059 | const char *const string[], |
| 5060 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 5061 | TParseContext *context) |
| 5062 | { |
Yunchao He | 4f28544 | 2017-04-21 12:15:49 +0800 | [diff] [blame] | 5063 | if ((count == 0) || (string == nullptr)) |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5064 | return 1; |
| 5065 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5066 | if (glslang_initialize(context)) |
| 5067 | return 1; |
| 5068 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 5069 | int error = glslang_scan(count, string, length, context); |
| 5070 | if (!error) |
| 5071 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5072 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 5073 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 5074 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 5075 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5076 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 5077 | |
| 5078 | } // namespace sh |