blob: e16a9ce00bcbe54d4e1c5c908ab9563ffd7a2c26 [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
14#include "src/sksl/SkSLAnalysis.h"
15#include "src/sksl/ir/SkSLBinaryExpression.h"
16#include "src/sksl/ir/SkSLBoolLiteral.h"
17#include "src/sksl/ir/SkSLBreakStatement.h"
18#include "src/sksl/ir/SkSLConstructor.h"
19#include "src/sksl/ir/SkSLContinueStatement.h"
20#include "src/sksl/ir/SkSLDiscardStatement.h"
21#include "src/sksl/ir/SkSLDoStatement.h"
22#include "src/sksl/ir/SkSLEnum.h"
23#include "src/sksl/ir/SkSLExpressionStatement.h"
24#include "src/sksl/ir/SkSLExternalFunctionCall.h"
25#include "src/sksl/ir/SkSLExternalValueReference.h"
26#include "src/sksl/ir/SkSLField.h"
27#include "src/sksl/ir/SkSLFieldAccess.h"
28#include "src/sksl/ir/SkSLFloatLiteral.h"
29#include "src/sksl/ir/SkSLForStatement.h"
30#include "src/sksl/ir/SkSLFunctionCall.h"
31#include "src/sksl/ir/SkSLFunctionDeclaration.h"
32#include "src/sksl/ir/SkSLFunctionDefinition.h"
33#include "src/sksl/ir/SkSLFunctionReference.h"
34#include "src/sksl/ir/SkSLIfStatement.h"
35#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040036#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040037#include "src/sksl/ir/SkSLIntLiteral.h"
38#include "src/sksl/ir/SkSLInterfaceBlock.h"
39#include "src/sksl/ir/SkSLLayout.h"
40#include "src/sksl/ir/SkSLNop.h"
41#include "src/sksl/ir/SkSLNullLiteral.h"
42#include "src/sksl/ir/SkSLPostfixExpression.h"
43#include "src/sksl/ir/SkSLPrefixExpression.h"
44#include "src/sksl/ir/SkSLReturnStatement.h"
45#include "src/sksl/ir/SkSLSetting.h"
46#include "src/sksl/ir/SkSLSwitchCase.h"
47#include "src/sksl/ir/SkSLSwitchStatement.h"
48#include "src/sksl/ir/SkSLSwizzle.h"
49#include "src/sksl/ir/SkSLTernaryExpression.h"
50#include "src/sksl/ir/SkSLUnresolvedFunction.h"
51#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040052#include "src/sksl/ir/SkSLVariable.h"
53#include "src/sksl/ir/SkSLVariableReference.h"
54#include "src/sksl/ir/SkSLWhileStatement.h"
55
56namespace SkSL {
57namespace {
58
John Stiles44dff4f2020-09-21 12:28:01 -040059static bool contains_returns_above_limit(const FunctionDefinition& funcDef, int limit) {
60 class CountReturnsWithLimit : public ProgramVisitor {
John Stiles44e96be2020-08-31 13:16:04 -040061 public:
John Stiles44dff4f2020-09-21 12:28:01 -040062 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
John Stiles44e96be2020-08-31 13:16:04 -040063 this->visitProgramElement(funcDef);
64 }
65
66 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040067 switch (stmt.kind()) {
68 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040069 ++fNumReturns;
John Stiles44dff4f2020-09-21 12:28:01 -040070 return (fNumReturns > fLimit) || INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040071
72 default:
John Stiles93442622020-09-11 12:11:27 -040073 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040074 }
75 }
76
77 int fNumReturns = 0;
John Stiles44dff4f2020-09-21 12:28:01 -040078 int fLimit = 0;
John Stiles44e96be2020-08-31 13:16:04 -040079 using INHERITED = ProgramVisitor;
80 };
81
John Stiles44dff4f2020-09-21 12:28:01 -040082 return CountReturnsWithLimit{funcDef, limit}.fNumReturns > limit;
John Stiles44e96be2020-08-31 13:16:04 -040083}
84
85static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
86 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
87 public:
88 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
89 this->visitProgramElement(funcDef);
90 }
91
92 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040093 switch (stmt.kind()) {
94 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040095 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040096 const auto& block = stmt.as<Block>();
97 return block.children().size() &&
98 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -040099 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400100 case Statement::Kind::kSwitch:
101 case Statement::Kind::kWhile:
102 case Statement::Kind::kDo:
103 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -0400104 // Don't introspect switches or loop structures at all.
105 return false;
106
Ethan Nicholase6592142020-09-08 10:22:09 -0400107 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -0400108 ++fNumReturns;
109 [[fallthrough]];
110
111 default:
John Stiles93442622020-09-11 12:11:27 -0400112 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400113 }
114 }
115
116 int fNumReturns = 0;
117 using INHERITED = ProgramVisitor;
118 };
119
120 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
121}
122
123static int count_returns_in_breakable_constructs(const FunctionDefinition& funcDef) {
124 class CountReturnsInBreakableConstructs : public ProgramVisitor {
125 public:
126 CountReturnsInBreakableConstructs(const FunctionDefinition& funcDef) {
127 this->visitProgramElement(funcDef);
128 }
129
130 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -0400131 switch (stmt.kind()) {
132 case Statement::Kind::kSwitch:
133 case Statement::Kind::kWhile:
134 case Statement::Kind::kDo:
135 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400136 ++fInsideBreakableConstruct;
John Stiles93442622020-09-11 12:11:27 -0400137 bool result = INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400138 --fInsideBreakableConstruct;
139 return result;
140 }
141
Ethan Nicholase6592142020-09-08 10:22:09 -0400142 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -0400143 fNumReturns += (fInsideBreakableConstruct > 0) ? 1 : 0;
144 [[fallthrough]];
145
146 default:
John Stiles93442622020-09-11 12:11:27 -0400147 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400148 }
149 }
150
151 int fNumReturns = 0;
152 int fInsideBreakableConstruct = 0;
153 using INHERITED = ProgramVisitor;
154 };
155
156 return CountReturnsInBreakableConstructs{funcDef}.fNumReturns;
157}
158
159static bool has_early_return(const FunctionDefinition& funcDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400160 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
John Stiles44dff4f2020-09-21 12:28:01 -0400161 return contains_returns_above_limit(funcDef, returnsAtEndOfControlFlow);
John Stiles44e96be2020-08-31 13:16:04 -0400162}
163
John Stiles991b09d2020-09-10 13:33:40 -0400164static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
165 class ContainsRecursiveCall : public ProgramVisitor {
166 public:
167 bool visit(const FunctionDeclaration& funcDecl) {
168 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400169 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
170 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400171 }
172
173 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400174 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400175 return true;
176 }
177 return INHERITED::visitExpression(expr);
178 }
179
180 bool visitStatement(const Statement& stmt) override {
181 if (stmt.is<InlineMarker>() && stmt.as<InlineMarker>().fFuncDecl->matches(*fFuncDecl)) {
182 return true;
183 }
184 return INHERITED::visitStatement(stmt);
185 }
186
187 const FunctionDeclaration* fFuncDecl;
188 using INHERITED = ProgramVisitor;
189 };
190
191 return ContainsRecursiveCall{}.visit(funcDecl);
192}
193
John Stiles44e96be2020-08-31 13:16:04 -0400194static const Type* copy_if_needed(const Type* src, SymbolTable& symbolTable) {
Ethan Nicholase6592142020-09-08 10:22:09 -0400195 if (src->typeKind() == Type::TypeKind::kArray) {
Ethan Nicholase2c49992020-10-05 11:49:11 -0400196 return symbolTable.takeOwnershipOfSymbol(std::make_unique<Type>(src->name(),
197 src->typeKind(),
198 src->componentType(),
199 src->columns()));
John Stiles44e96be2020-08-31 13:16:04 -0400200 }
201 return src;
202}
203
John Stiles6d696082020-10-01 10:18:54 -0400204static std::unique_ptr<Statement>* find_parent_statement(
205 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400206 SkASSERT(!stmtStack.empty());
207
208 // Walk the statement stack from back to front, ignoring the last element (which is the
209 // enclosing statement).
210 auto iter = stmtStack.rbegin();
211 ++iter;
212
213 // Anything counts as a parent statement other than a scopeless Block.
214 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400215 std::unique_ptr<Statement>* stmt = *iter;
216 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400217 return stmt;
218 }
219 }
220
221 // There wasn't any parent statement to be found.
222 return nullptr;
223}
224
John Stilese41b4ee2020-09-28 12:28:16 -0400225std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
226 VariableReference::RefKind refKind) {
227 std::unique_ptr<Expression> clone = expr.clone();
John Stiles70b82422020-09-30 10:55:12 -0400228 class SetRefKindInExpression : public ProgramWriter {
John Stilese41b4ee2020-09-28 12:28:16 -0400229 public:
230 SetRefKindInExpression(VariableReference::RefKind refKind) : fRefKind(refKind) {}
John Stiles70b82422020-09-30 10:55:12 -0400231 bool visitExpression(Expression& expr) override {
John Stilese41b4ee2020-09-28 12:28:16 -0400232 if (expr.is<VariableReference>()) {
John Stiles70b82422020-09-30 10:55:12 -0400233 expr.as<VariableReference>().setRefKind(fRefKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400234 }
235 return INHERITED::visitExpression(expr);
236 }
237
238 private:
239 VariableReference::RefKind fRefKind;
240
John Stiles70b82422020-09-30 10:55:12 -0400241 using INHERITED = ProgramWriter;
John Stilese41b4ee2020-09-28 12:28:16 -0400242 };
243
244 SetRefKindInExpression{refKind}.visitExpression(*clone);
245 return clone;
246}
247
John Stiles44733aa2020-09-29 17:42:23 -0400248bool is_trivial_argument(const Expression& argument) {
249 return argument.is<VariableReference>() ||
250 (argument.is<Swizzle>() && is_trivial_argument(*argument.as<Swizzle>().fBase)) ||
251 (argument.is<FieldAccess>() && is_trivial_argument(*argument.as<FieldAccess>().fBase)) ||
John Stiles80ccdbd2020-09-30 11:58:16 -0400252 (argument.is<Constructor>() &&
253 argument.as<Constructor>().arguments().size() == 1 &&
254 is_trivial_argument(*argument.as<Constructor>().arguments().front())) ||
John Stiles44733aa2020-09-29 17:42:23 -0400255 (argument.is<IndexExpression>() &&
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400256 argument.as<IndexExpression>().index()->is<IntLiteral>() &&
257 is_trivial_argument(*argument.as<IndexExpression>().base()));
John Stiles44733aa2020-09-29 17:42:23 -0400258}
259
John Stiles44e96be2020-08-31 13:16:04 -0400260} // namespace
261
John Stilesb61ee902020-09-21 12:26:59 -0400262void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
263 // No changes necessary if this statement isn't actually a block.
264 if (!inlinedBody || !inlinedBody->is<Block>()) {
265 return;
266 }
267
268 // No changes necessary if the parent statement doesn't require a scope.
269 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
270 parentStmt->is<DoStatement>() || parentStmt->is<WhileStatement>())) {
271 return;
272 }
273
274 Block& block = inlinedBody->as<Block>();
275
276 // The inliner will create inlined function bodies as a Block containing multiple statements,
277 // but no scope. Normally, this is fine, but if this block is used as the statement for a
278 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
279 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
280 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
281 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
282 // absorbing the following statement into our loop--so we also add a scope to these.
283 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400284 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400285 // We found an explicit scope; all is well.
286 return;
287 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400288 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400289 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
290 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400291 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400292 return;
293 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400294 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400295 // This block has exactly one thing inside, and it's not another block. No need to scope
296 // it.
297 return;
298 }
299 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400300 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400301 }
302}
303
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400304void Inliner::reset(const Context* context, ModifiersPool* modifiers,
305 const Program::Settings* settings) {
306 fContext = context;
307 fModifiers = modifiers;
308 fSettings = settings;
John Stiles44e96be2020-08-31 13:16:04 -0400309 fInlineVarCounter = 0;
310}
311
John Stilesc75abb82020-09-14 18:24:12 -0400312String Inliner::uniqueNameForInlineVar(const String& baseName, SymbolTable* symbolTable) {
313 // If the base name starts with an underscore, like "_coords", we can't append another
314 // underscore, because OpenGL disallows two consecutive underscores anywhere in the string. But
315 // in the general case, using the underscore as a splitter reads nicely enough that it's worth
316 // putting in this special case.
317 const char* splitter = baseName.startsWith("_") ? "" : "_";
318
319 // Append a unique numeric prefix to avoid name overlap. Check the symbol table to make sure
320 // we're not reusing an existing name. (Note that within a single compilation pass, this check
321 // isn't fully comprehensive, as code isn't always generated in top-to-bottom order.)
322 String uniqueName;
323 for (;;) {
324 uniqueName = String::printf("_%d%s%s", fInlineVarCounter++, splitter, baseName.c_str());
325 StringFragment frag{uniqueName.data(), uniqueName.length()};
326 if ((*symbolTable)[frag] == nullptr) {
327 break;
328 }
329 }
330
331 return uniqueName;
332}
333
John Stiles44e96be2020-08-31 13:16:04 -0400334std::unique_ptr<Expression> Inliner::inlineExpression(int offset,
335 VariableRewriteMap* varMap,
336 const Expression& expression) {
337 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
338 if (e) {
339 return this->inlineExpression(offset, varMap, *e);
340 }
341 return nullptr;
342 };
343 auto argList = [&](const std::vector<std::unique_ptr<Expression>>& originalArgs)
344 -> std::vector<std::unique_ptr<Expression>> {
345 std::vector<std::unique_ptr<Expression>> args;
346 args.reserve(originalArgs.size());
347 for (const std::unique_ptr<Expression>& arg : originalArgs) {
348 args.push_back(expr(arg));
349 }
350 return args;
351 };
352
Ethan Nicholase6592142020-09-08 10:22:09 -0400353 switch (expression.kind()) {
354 case Expression::Kind::kBinary: {
John Stiles44e96be2020-08-31 13:16:04 -0400355 const BinaryExpression& b = expression.as<BinaryExpression>();
356 return std::make_unique<BinaryExpression>(offset,
Ethan Nicholasc8d9c8e2020-09-22 15:05:37 -0400357 expr(b.leftPointer()),
358 b.getOperator(),
359 expr(b.rightPointer()),
Ethan Nicholas30d30222020-09-11 12:27:26 -0400360 &b.type());
John Stiles44e96be2020-08-31 13:16:04 -0400361 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400362 case Expression::Kind::kBoolLiteral:
363 case Expression::Kind::kIntLiteral:
364 case Expression::Kind::kFloatLiteral:
365 case Expression::Kind::kNullLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400366 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400367 case Expression::Kind::kConstructor: {
John Stiles44e96be2020-08-31 13:16:04 -0400368 const Constructor& constructor = expression.as<Constructor>();
Ethan Nicholas30d30222020-09-11 12:27:26 -0400369 return std::make_unique<Constructor>(offset, &constructor.type(),
Ethan Nicholasf70f0442020-09-29 12:41:35 -0400370 argList(constructor.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400371 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400372 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400373 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas30d30222020-09-11 12:27:26 -0400374 return std::make_unique<ExternalFunctionCall>(offset, &externalCall.type(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400375 externalCall.function(),
376 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400377 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400378 case Expression::Kind::kExternalValue:
John Stiles44e96be2020-08-31 13:16:04 -0400379 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400380 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400381 const FieldAccess& f = expression.as<FieldAccess>();
382 return std::make_unique<FieldAccess>(expr(f.fBase), f.fFieldIndex, f.fOwnerKind);
383 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400384 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400385 const FunctionCall& funcCall = expression.as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400386 return std::make_unique<FunctionCall>(offset, &funcCall.type(), &funcCall.function(),
387 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400388 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400389 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400390 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400391 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400392 const IndexExpression& idx = expression.as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400393 return std::make_unique<IndexExpression>(*fContext, expr(idx.base()),
394 expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400395 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400396 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400397 const PrefixExpression& p = expression.as<PrefixExpression>();
398 return std::make_unique<PrefixExpression>(p.fOperator, expr(p.fOperand));
399 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400400 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400401 const PostfixExpression& p = expression.as<PostfixExpression>();
402 return std::make_unique<PostfixExpression>(expr(p.fOperand), p.fOperator);
403 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400404 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400405 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400406 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400407 const Swizzle& s = expression.as<Swizzle>();
408 return std::make_unique<Swizzle>(*fContext, expr(s.fBase), s.fComponents);
409 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400410 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400411 const TernaryExpression& t = expression.as<TernaryExpression>();
Ethan Nicholasdd218162020-10-08 05:48:01 -0400412 return std::make_unique<TernaryExpression>(offset, expr(t.test()),
413 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400414 }
Brian Osman83ba9302020-09-11 13:33:46 -0400415 case Expression::Kind::kTypeReference:
416 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400417 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400418 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400419 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400420 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400421 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400422 }
423 return v.clone();
424 }
425 default:
426 SkASSERT(false);
427 return nullptr;
428 }
429}
430
431std::unique_ptr<Statement> Inliner::inlineStatement(int offset,
432 VariableRewriteMap* varMap,
433 SymbolTable* symbolTableForStatement,
John Stilese41b4ee2020-09-28 12:28:16 -0400434 const Expression* resultExpr,
John Stiles44e96be2020-08-31 13:16:04 -0400435 bool haveEarlyReturns,
Brian Osman3887a012020-09-30 13:22:27 -0400436 const Statement& statement,
437 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400438 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
439 if (s) {
John Stilesa5f3c312020-09-22 12:05:16 -0400440 return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr,
Brian Osman3887a012020-09-30 13:22:27 -0400441 haveEarlyReturns, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400442 }
443 return nullptr;
444 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400445 auto blockStmts = [&](const Block& block) {
446 std::vector<std::unique_ptr<Statement>> result;
447 for (const std::unique_ptr<Statement>& child : block.children()) {
448 result.push_back(stmt(child));
449 }
450 return result;
451 };
John Stiles44e96be2020-08-31 13:16:04 -0400452 auto stmts = [&](const std::vector<std::unique_ptr<Statement>>& ss) {
453 std::vector<std::unique_ptr<Statement>> result;
454 for (const auto& s : ss) {
455 result.push_back(stmt(s));
456 }
457 return result;
458 };
459 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
460 if (e) {
461 return this->inlineExpression(offset, varMap, *e);
462 }
463 return nullptr;
464 };
Ethan Nicholase6592142020-09-08 10:22:09 -0400465 switch (statement.kind()) {
466 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400467 const Block& b = statement.as<Block>();
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400468 return std::make_unique<Block>(offset, blockStmts(b), b.symbolTable(), b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400469 }
470
Ethan Nicholase6592142020-09-08 10:22:09 -0400471 case Statement::Kind::kBreak:
472 case Statement::Kind::kContinue:
473 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400474 return statement.clone();
475
Ethan Nicholase6592142020-09-08 10:22:09 -0400476 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400477 const DoStatement& d = statement.as<DoStatement>();
Ethan Nicholas1fd61162020-09-28 13:14:19 -0400478 return std::make_unique<DoStatement>(offset, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400479 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400480 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400481 const ExpressionStatement& e = statement.as<ExpressionStatement>();
Ethan Nicholasd503a5a2020-09-30 09:29:55 -0400482 return std::make_unique<ExpressionStatement>(expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400483 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400484 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400485 const ForStatement& f = statement.as<ForStatement>();
486 // need to ensure initializer is evaluated first so that we've already remapped its
487 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400488 std::unique_ptr<Statement> initializer = stmt(f.initializer());
489 return std::make_unique<ForStatement>(offset, std::move(initializer), expr(f.test()),
490 expr(f.next()), stmt(f.statement()), f.symbols());
John Stiles44e96be2020-08-31 13:16:04 -0400491 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400492 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400493 const IfStatement& i = statement.as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400494 return std::make_unique<IfStatement>(offset, i.isStatic(), expr(i.test()),
495 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400496 }
John Stiles98c1f822020-09-09 14:18:53 -0400497 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400498 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400499 return statement.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400500 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400501 const ReturnStatement& r = statement.as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400502 if (r.expression()) {
John Stilese41b4ee2020-09-28 12:28:16 -0400503 SkASSERT(resultExpr);
John Stilesa5f3c312020-09-22 12:05:16 -0400504 auto assignment =
505 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
506 offset,
John Stilese41b4ee2020-09-28 12:28:16 -0400507 clone_with_ref_kind(*resultExpr, VariableReference::kWrite_RefKind),
John Stilesa5f3c312020-09-22 12:05:16 -0400508 Token::Kind::TK_EQ,
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400509 expr(r.expression()),
John Stilese41b4ee2020-09-28 12:28:16 -0400510 &resultExpr->type()));
John Stiles44e96be2020-08-31 13:16:04 -0400511 if (haveEarlyReturns) {
512 std::vector<std::unique_ptr<Statement>> block;
513 block.push_back(std::move(assignment));
514 block.emplace_back(new BreakStatement(offset));
515 return std::make_unique<Block>(offset, std::move(block), /*symbols=*/nullptr,
516 /*isScope=*/true);
517 } else {
518 return std::move(assignment);
519 }
520 } else {
521 if (haveEarlyReturns) {
522 return std::make_unique<BreakStatement>(offset);
523 } else {
524 return std::make_unique<Nop>();
525 }
526 }
527 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400528 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400529 const SwitchStatement& ss = statement.as<SwitchStatement>();
530 std::vector<std::unique_ptr<SwitchCase>> cases;
531 for (const auto& sc : ss.fCases) {
532 cases.emplace_back(new SwitchCase(offset, expr(sc->fValue),
533 stmts(sc->fStatements)));
534 }
535 return std::make_unique<SwitchStatement>(offset, ss.fIsStatic, expr(ss.fValue),
536 std::move(cases), ss.fSymbols);
537 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400538 case Statement::Kind::kVarDeclaration: {
John Stiles44e96be2020-08-31 13:16:04 -0400539 const VarDeclaration& decl = statement.as<VarDeclaration>();
540 std::vector<std::unique_ptr<Expression>> sizes;
541 for (const auto& size : decl.fSizes) {
542 sizes.push_back(expr(size));
543 }
544 std::unique_ptr<Expression> initialValue = expr(decl.fValue);
545 const Variable* old = decl.fVar;
John Stilesc75abb82020-09-14 18:24:12 -0400546 // We assign unique names to inlined variables--scopes hide most of the problems in this
547 // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique
548 // names are important.
549 auto name = std::make_unique<String>(
Ethan Nicholase2c49992020-10-05 11:49:11 -0400550 this->uniqueNameForInlineVar(String(old->name()), symbolTableForStatement));
John Stiles44e96be2020-08-31 13:16:04 -0400551 const String* namePtr = symbolTableForStatement->takeOwnershipOfString(std::move(name));
Brian Osmanc0213602020-10-06 14:43:32 -0400552 const Type* baseTypePtr = copy_if_needed(&decl.fBaseType, *symbolTableForStatement);
Ethan Nicholas30d30222020-09-11 12:27:26 -0400553 const Type* typePtr = copy_if_needed(&old->type(), *symbolTableForStatement);
John Stiles44e96be2020-08-31 13:16:04 -0400554 const Variable* clone = symbolTableForStatement->takeOwnershipOfSymbol(
555 std::make_unique<Variable>(offset,
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400556 old->modifiersHandle(),
John Stiles44e96be2020-08-31 13:16:04 -0400557 namePtr->c_str(),
Ethan Nicholas30d30222020-09-11 12:27:26 -0400558 typePtr,
Brian Osman3887a012020-09-30 13:22:27 -0400559 isBuiltinCode,
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400560 old->storage(),
John Stiles44e96be2020-08-31 13:16:04 -0400561 initialValue.get()));
John Stilese41b4ee2020-09-28 12:28:16 -0400562 (*varMap)[old] = std::make_unique<VariableReference>(offset, clone);
Brian Osmanc0213602020-10-06 14:43:32 -0400563 return std::make_unique<VarDeclaration>(clone, baseTypePtr, std::move(sizes),
John Stiles44e96be2020-08-31 13:16:04 -0400564 std::move(initialValue));
565 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400566 case Statement::Kind::kWhile: {
John Stiles44e96be2020-08-31 13:16:04 -0400567 const WhileStatement& w = statement.as<WhileStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400568 return std::make_unique<WhileStatement>(offset, expr(w.test()), stmt(w.statement()));
John Stiles44e96be2020-08-31 13:16:04 -0400569 }
570 default:
571 SkASSERT(false);
572 return nullptr;
573 }
574}
575
John Stiles6eadf132020-09-08 10:16:10 -0400576Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
Brian Osman3887a012020-09-30 13:22:27 -0400577 SymbolTable* symbolTableForCall,
578 const FunctionDeclaration* caller) {
John Stiles44e96be2020-08-31 13:16:04 -0400579 // Inlining is more complicated here than in a typical compiler, because we have to have a
580 // high-level IR and can't just drop statements into the middle of an expression or even use
581 // gotos.
582 //
583 // Since we can't insert statements into an expression, we run the inline function as extra
584 // statements before the statement we're currently processing, relying on a lack of execution
585 // order guarantees. Since we can't use gotos (which are normally used to replace return
586 // statements), we wrap the whole function in a loop and use break statements to jump to the
587 // end.
588 SkASSERT(fSettings);
589 SkASSERT(fContext);
590 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400591 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400592
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400593 std::vector<std::unique_ptr<Expression>>& arguments = call->arguments();
John Stiles6eadf132020-09-08 10:16:10 -0400594 const int offset = call->fOffset;
Ethan Nicholased84b732020-10-08 11:45:44 -0400595 const FunctionDefinition& function = *call->function().definition();
John Stiles6eadf132020-09-08 10:16:10 -0400596 const bool hasEarlyReturn = has_early_return(function);
597
John Stiles44e96be2020-08-31 13:16:04 -0400598 InlinedCall inlinedCall;
John Stiles6eadf132020-09-08 10:16:10 -0400599 inlinedCall.fInlinedBody = std::make_unique<Block>(offset,
600 std::vector<std::unique_ptr<Statement>>{},
601 /*symbols=*/nullptr,
602 /*isScope=*/false);
John Stiles98c1f822020-09-09 14:18:53 -0400603
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400604 Block& inlinedBody = *inlinedCall.fInlinedBody;
605 inlinedBody.children().reserve(1 + // Inline marker
606 1 + // Result variable
607 arguments.size() + // Function arguments (passing in)
John Stilese41b4ee2020-09-28 12:28:16 -0400608 arguments.size() + // Function arguments (copy out-params back)
609 1); // Inlined code (Block or do-while loop)
John Stiles98c1f822020-09-09 14:18:53 -0400610
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400611 inlinedBody.children().push_back(std::make_unique<InlineMarker>(call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400612
John Stilese41b4ee2020-09-28 12:28:16 -0400613 auto makeInlineVar =
614 [&](const String& baseName, const Type* type, Modifiers modifiers,
615 std::unique_ptr<Expression>* initialValue) -> std::unique_ptr<Expression> {
John Stilesa003e812020-09-11 09:43:49 -0400616 // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so
617 // replace them if they ever appear here. If this happens, we likely forgot to coerce a type
618 // somewhere during compilation.
619 if (type == fContext->fFloatLiteral_Type.get()) {
John Stilesd2be5c52020-09-11 14:58:06 -0400620 SkDEBUGFAIL("found a $floatLiteral type while inlining");
John Stilesa003e812020-09-11 09:43:49 -0400621 type = fContext->fFloat_Type.get();
622 } else if (type == fContext->fIntLiteral_Type.get()) {
John Stilesd2be5c52020-09-11 14:58:06 -0400623 SkDEBUGFAIL("found an $intLiteral type while inlining");
John Stilesa003e812020-09-11 09:43:49 -0400624 type = fContext->fInt_Type.get();
625 }
626
John Stilesc75abb82020-09-14 18:24:12 -0400627 // Provide our new variable with a unique name, and add it to our symbol table.
628 String uniqueName = this->uniqueNameForInlineVar(baseName, symbolTableForCall);
John Stilescf936f92020-08-31 17:18:45 -0400629 const String* namePtr = symbolTableForCall->takeOwnershipOfString(
630 std::make_unique<String>(std::move(uniqueName)));
John Stiles44e96be2020-08-31 13:16:04 -0400631 StringFragment nameFrag{namePtr->c_str(), namePtr->length()};
632
633 // Add our new variable to the symbol table.
John Stilesb8cc6652020-10-08 09:12:07 -0400634 const Variable* variableSymbol = symbolTableForCall->add(std::make_unique<Variable>(
635 /*offset=*/-1, fModifiers->handle(Modifiers()),
Ethan Nicholased84b732020-10-08 11:45:44 -0400636 nameFrag, type, caller->isBuiltin(),
John Stilesb8cc6652020-10-08 09:12:07 -0400637 Variable::kLocal_Storage, initialValue->get()));
John Stiles44e96be2020-08-31 13:16:04 -0400638
639 // Prepare the variable declaration (taking extra care with `out` params to not clobber any
640 // initial value).
Brian Osmanc0213602020-10-06 14:43:32 -0400641 std::unique_ptr<Statement> variable;
John Stiles44e96be2020-08-31 13:16:04 -0400642 if (initialValue && (modifiers.fFlags & Modifiers::kOut_Flag)) {
Brian Osmanc0213602020-10-06 14:43:32 -0400643 variable = std::make_unique<VarDeclaration>(
644 variableSymbol, type, /*sizes=*/std::vector<std::unique_ptr<Expression>>{},
645 (*initialValue)->clone());
John Stiles44e96be2020-08-31 13:16:04 -0400646 } else {
Brian Osmanc0213602020-10-06 14:43:32 -0400647 variable = std::make_unique<VarDeclaration>(
648 variableSymbol, type, /*sizes=*/std::vector<std::unique_ptr<Expression>>{},
649 std::move(*initialValue));
John Stiles44e96be2020-08-31 13:16:04 -0400650 }
651
652 // Add the new variable-declaration statement to our block of extra statements.
Brian Osmanc0213602020-10-06 14:43:32 -0400653 inlinedBody.children().push_back(std::move(variable));
John Stiles44e96be2020-08-31 13:16:04 -0400654
John Stilese41b4ee2020-09-28 12:28:16 -0400655 return std::make_unique<VariableReference>(offset, variableSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400656 };
657
658 // Create a variable to hold the result in the extra statements (excepting void).
John Stilese41b4ee2020-09-28 12:28:16 -0400659 std::unique_ptr<Expression> resultExpr;
Ethan Nicholased84b732020-10-08 11:45:44 -0400660 if (function.fDeclaration.returnType() != *fContext->fVoid_Type) {
John Stiles44e96be2020-08-31 13:16:04 -0400661 std::unique_ptr<Expression> noInitialValue;
Ethan Nicholase2c49992020-10-05 11:49:11 -0400662 resultExpr = makeInlineVar(String(function.fDeclaration.name()),
Ethan Nicholased84b732020-10-08 11:45:44 -0400663 &function.fDeclaration.returnType(),
John Stilese41b4ee2020-09-28 12:28:16 -0400664 Modifiers{}, &noInitialValue);
665 }
John Stiles44e96be2020-08-31 13:16:04 -0400666
667 // Create variables in the extra statements to hold the arguments, and assign the arguments to
668 // them.
669 VariableRewriteMap varMap;
John Stilese41b4ee2020-09-28 12:28:16 -0400670 std::vector<int> argsToCopyBack;
John Stiles44e96be2020-08-31 13:16:04 -0400671 for (int i = 0; i < (int) arguments.size(); ++i) {
Ethan Nicholased84b732020-10-08 11:45:44 -0400672 const Variable* param = function.fDeclaration.parameters()[i];
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400673 bool isOutParam = param->modifiers().fFlags & Modifiers::kOut_Flag;
John Stiles44e96be2020-08-31 13:16:04 -0400674
John Stiles44733aa2020-09-29 17:42:23 -0400675 // If this argument can be inlined trivially (e.g. a swizzle, or a constant array index)...
676 if (is_trivial_argument(*arguments[i])) {
John Stilese41b4ee2020-09-28 12:28:16 -0400677 // ... and it's an `out` param, or it isn't written to within the inline function...
678 if (isOutParam || !Analysis::StatementWritesToVariable(*function.fBody, *param)) {
John Stilesf201af82020-09-29 16:57:55 -0400679 // ... we don't need to copy it at all! We can just use the existing expression.
680 varMap[param] = arguments[i]->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400681 continue;
682 }
683 }
684
John Stilese41b4ee2020-09-28 12:28:16 -0400685 if (isOutParam) {
686 argsToCopyBack.push_back(i);
687 }
688
Ethan Nicholase2c49992020-10-05 11:49:11 -0400689 varMap[param] = makeInlineVar(String(param->name()), &arguments[i]->type(),
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400690 param->modifiers(), &arguments[i]);
John Stiles44e96be2020-08-31 13:16:04 -0400691 }
692
693 const Block& body = function.fBody->as<Block>();
John Stiles44e96be2020-08-31 13:16:04 -0400694 auto inlineBlock = std::make_unique<Block>(offset, std::vector<std::unique_ptr<Statement>>{});
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400695 inlineBlock->children().reserve(body.children().size());
696 for (const std::unique_ptr<Statement>& stmt : body.children()) {
Brian Osman3887a012020-09-30 13:22:27 -0400697 inlineBlock->children().push_back(this->inlineStatement(offset, &varMap, symbolTableForCall,
698 resultExpr.get(), hasEarlyReturn,
Ethan Nicholased84b732020-10-08 11:45:44 -0400699 *stmt, caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400700 }
701 if (hasEarlyReturn) {
702 // Since we output to backends that don't have a goto statement (which would normally be
703 // used to perform an early return), we fake it by wrapping the function in a
704 // do { } while (false); and then use break statements to jump to the end in order to
705 // emulate a goto.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400706 inlinedBody.children().push_back(std::make_unique<DoStatement>(
John Stiles44e96be2020-08-31 13:16:04 -0400707 /*offset=*/-1,
708 std::move(inlineBlock),
709 std::make_unique<BoolLiteral>(*fContext, offset, /*value=*/false)));
710 } else {
John Stiles6eadf132020-09-08 10:16:10 -0400711 // No early returns, so we can just dump the code in. We still need to keep the block so we
712 // don't get name conflicts with locals.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400713 inlinedBody.children().push_back(std::move(inlineBlock));
John Stiles44e96be2020-08-31 13:16:04 -0400714 }
715
John Stilese41b4ee2020-09-28 12:28:16 -0400716 // Copy back the values of `out` parameters into their real destinations.
717 for (int i : argsToCopyBack) {
Ethan Nicholased84b732020-10-08 11:45:44 -0400718 const Variable* p = function.fDeclaration.parameters()[i];
John Stilese41b4ee2020-09-28 12:28:16 -0400719 SkASSERT(varMap.find(p) != varMap.end());
720 inlinedBody.children().push_back(
721 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
722 offset,
723 clone_with_ref_kind(*arguments[i], VariableReference::kWrite_RefKind),
724 Token::Kind::TK_EQ,
725 std::move(varMap[p]),
726 &arguments[i]->type())));
John Stiles44e96be2020-08-31 13:16:04 -0400727 }
728
John Stilese41b4ee2020-09-28 12:28:16 -0400729 if (resultExpr != nullptr) {
730 // Return our result variable as our replacement expression.
Ethan Nicholas78686922020-10-08 06:46:27 -0400731 SkASSERT(resultExpr->as<VariableReference>().refKind() == VariableReference::kRead_RefKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400732 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles44e96be2020-08-31 13:16:04 -0400733 } else {
734 // It's a void function, so it doesn't actually result in anything, but we have to return
735 // something non-null as a standin.
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400736 inlinedCall.fReplacementExpr = std::make_unique<BoolLiteral>(*fContext,
737 offset,
John Stiles44e96be2020-08-31 13:16:04 -0400738 /*value=*/false);
739 }
740
John Stiles44e96be2020-08-31 13:16:04 -0400741 return inlinedCall;
742}
743
John Stiles2d7973a2020-10-02 15:01:03 -0400744bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400745 SkASSERT(fSettings);
746
John Stiles2d7973a2020-10-02 15:01:03 -0400747 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400748 // Can't inline something if we don't actually have its definition.
749 return false;
750 }
John Stiles2d7973a2020-10-02 15:01:03 -0400751
John Stiles44e96be2020-08-31 13:16:04 -0400752 if (!fSettings->fCaps || !fSettings->fCaps->canUseDoLoops()) {
753 // We don't have do-while loops. We use do-while loops to simulate early returns, so we
754 // can't inline functions that have an early return.
John Stiles2d7973a2020-10-02 15:01:03 -0400755 bool hasEarlyReturn = has_early_return(*functionDef);
John Stiles44e96be2020-08-31 13:16:04 -0400756
757 // If we didn't detect an early return, there shouldn't be any returns in breakable
758 // constructs either.
John Stiles2d7973a2020-10-02 15:01:03 -0400759 SkASSERT(hasEarlyReturn || count_returns_in_breakable_constructs(*functionDef) == 0);
John Stiles44e96be2020-08-31 13:16:04 -0400760 return !hasEarlyReturn;
761 }
762 // We have do-while loops, but we don't have any mechanism to simulate early returns within a
763 // breakable construct (switch/for/do/while), so we can't inline if there's a return inside one.
John Stiles2d7973a2020-10-02 15:01:03 -0400764 bool hasReturnInBreakableConstruct = (count_returns_in_breakable_constructs(*functionDef) > 0);
John Stiles44e96be2020-08-31 13:16:04 -0400765
766 // If we detected returns in breakable constructs, we should also detect an early return.
John Stiles2d7973a2020-10-02 15:01:03 -0400767 SkASSERT(!hasReturnInBreakableConstruct || has_early_return(*functionDef));
John Stiles44e96be2020-08-31 13:16:04 -0400768 return !hasReturnInBreakableConstruct;
769}
770
John Stiles2d7973a2020-10-02 15:01:03 -0400771// A candidate function for inlining, containing everything that `inlineCall` needs.
772struct InlineCandidate {
773 SymbolTable* fSymbols; // the SymbolTable of the candidate
774 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
775 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
776 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
777 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
778 bool fIsLargeFunction; // does candidate exceed the inline threshold?
779};
John Stiles93442622020-09-11 12:11:27 -0400780
John Stiles2d7973a2020-10-02 15:01:03 -0400781struct InlineCandidateList {
782 std::vector<InlineCandidate> fCandidates;
783};
784
785class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400786public:
787 // A list of all the inlining candidates we found during analysis.
788 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400789
John Stiles70957c82020-10-02 16:42:10 -0400790 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
791 // the enclosing-statement stack.
792 std::vector<SymbolTable*> fSymbolTableStack;
793 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
794 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
795 // inliner might replace a statement with a block containing the statement.
796 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
797 // The function that we're currently processing (i.e. inlining into).
798 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400799
John Stiles70957c82020-10-02 16:42:10 -0400800 void visit(Program& program, InlineCandidateList* candidateList) {
801 fCandidateList = candidateList;
802 fSymbolTableStack.push_back(program.fSymbols.get());
John Stiles93442622020-09-11 12:11:27 -0400803
Brian Osman1179fcf2020-10-08 16:04:40 -0400804 for (const auto& pe : program.elements()) {
805 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400806 }
807
John Stiles70957c82020-10-02 16:42:10 -0400808 fSymbolTableStack.pop_back();
809 fCandidateList = nullptr;
810 }
811
812 void visitProgramElement(ProgramElement* pe) {
813 switch (pe->kind()) {
814 case ProgramElement::Kind::kFunction: {
815 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
816 fEnclosingFunction = &funcDef;
817 this->visitStatement(&funcDef.fBody);
818 break;
John Stiles93442622020-09-11 12:11:27 -0400819 }
John Stiles70957c82020-10-02 16:42:10 -0400820 default:
821 // The inliner can't operate outside of a function's scope.
822 break;
823 }
824 }
825
826 void visitStatement(std::unique_ptr<Statement>* stmt,
827 bool isViableAsEnclosingStatement = true) {
828 if (!*stmt) {
829 return;
John Stiles93442622020-09-11 12:11:27 -0400830 }
831
John Stiles70957c82020-10-02 16:42:10 -0400832 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
833 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400834
John Stiles70957c82020-10-02 16:42:10 -0400835 if (isViableAsEnclosingStatement) {
836 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400837 }
838
John Stiles70957c82020-10-02 16:42:10 -0400839 switch ((*stmt)->kind()) {
840 case Statement::Kind::kBreak:
841 case Statement::Kind::kContinue:
842 case Statement::Kind::kDiscard:
843 case Statement::Kind::kInlineMarker:
844 case Statement::Kind::kNop:
845 break;
846
847 case Statement::Kind::kBlock: {
848 Block& block = (*stmt)->as<Block>();
849 if (block.symbolTable()) {
850 fSymbolTableStack.push_back(block.symbolTable().get());
851 }
852
853 for (std::unique_ptr<Statement>& stmt : block.children()) {
854 this->visitStatement(&stmt);
855 }
856 break;
John Stiles93442622020-09-11 12:11:27 -0400857 }
John Stiles70957c82020-10-02 16:42:10 -0400858 case Statement::Kind::kDo: {
859 DoStatement& doStmt = (*stmt)->as<DoStatement>();
860 // The loop body is a candidate for inlining.
861 this->visitStatement(&doStmt.statement());
862 // The inliner isn't smart enough to inline the test-expression for a do-while
863 // loop at this time. There are two limitations:
864 // - We would need to insert the inlined-body block at the very end of the do-
865 // statement's inner fStatement. We don't support that today, but it's doable.
866 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
867 // would skip over the inlined block that evaluates the test expression. There
868 // isn't a good fix for this--any workaround would be more complex than the cost
869 // of a function call. However, loops that don't use `continue` would still be
870 // viable candidates for inlining.
871 break;
John Stiles93442622020-09-11 12:11:27 -0400872 }
John Stiles70957c82020-10-02 16:42:10 -0400873 case Statement::Kind::kExpression: {
874 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
875 this->visitExpression(&expr.expression());
876 break;
877 }
878 case Statement::Kind::kFor: {
879 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400880 if (forStmt.symbols()) {
881 fSymbolTableStack.push_back(forStmt.symbols().get());
John Stiles70957c82020-10-02 16:42:10 -0400882 }
883
884 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400885 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400886 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400887 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400888
889 // The inliner isn't smart enough to inline the test- or increment-expressions
890 // of a for loop loop at this time. There are a handful of limitations:
891 // - We would need to insert the test-expression block at the very beginning of the
892 // for-loop's inner fStatement, and the increment-expression block at the very
893 // end. We don't support that today, but it's doable.
894 // - The for-loop's built-in test-expression would need to be dropped entirely,
895 // and the loop would be halted via a break statement at the end of the inlined
896 // test-expression. This is again something we don't support today, but it could
897 // be implemented.
898 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
899 // that would skip over the inlined block that evaluates the increment expression.
900 // There isn't a good fix for this--any workaround would be more complex than the
901 // cost of a function call. However, loops that don't use `continue` would still
902 // be viable candidates for increment-expression inlining.
903 break;
904 }
905 case Statement::Kind::kIf: {
906 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400907 this->visitExpression(&ifStmt.test());
908 this->visitStatement(&ifStmt.ifTrue());
909 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -0400910 break;
911 }
912 case Statement::Kind::kReturn: {
913 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400914 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -0400915 break;
916 }
917 case Statement::Kind::kSwitch: {
918 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
919 if (switchStmt.fSymbols) {
920 fSymbolTableStack.push_back(switchStmt.fSymbols.get());
921 }
922
923 this->visitExpression(&switchStmt.fValue);
924 for (std::unique_ptr<SwitchCase>& switchCase : switchStmt.fCases) {
925 // The switch-case's fValue cannot be a FunctionCall; skip it.
926 for (std::unique_ptr<Statement>& caseBlock : switchCase->fStatements) {
927 this->visitStatement(&caseBlock);
928 }
929 }
930 break;
931 }
932 case Statement::Kind::kVarDeclaration: {
933 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
934 // Don't need to scan the declaration's sizes; those are always IntLiterals.
935 this->visitExpression(&varDeclStmt.fValue);
936 break;
937 }
John Stiles70957c82020-10-02 16:42:10 -0400938 case Statement::Kind::kWhile: {
939 WhileStatement& whileStmt = (*stmt)->as<WhileStatement>();
940 // The loop body is a candidate for inlining.
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400941 this->visitStatement(&whileStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400942 // The inliner isn't smart enough to inline the test-expression for a while loop at
943 // this time. There are two limitations:
944 // - We would need to insert the inlined-body block at the very beginning of the
945 // while loop's inner fStatement. We don't support that today, but it's doable.
946 // - The while-loop's built-in test-expression would need to be replaced with a
947 // `true` BoolLiteral, and the loop would be halted via a break statement at the
948 // end of the inlined test-expression. This is again something we don't support
949 // today, but it could be implemented.
950 break;
951 }
952 default:
953 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -0400954 }
955
John Stiles70957c82020-10-02 16:42:10 -0400956 // Pop our symbol and enclosing-statement stacks.
957 fSymbolTableStack.resize(oldSymbolStackSize);
958 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
959 }
960
961 void visitExpression(std::unique_ptr<Expression>* expr) {
962 if (!*expr) {
963 return;
John Stiles93442622020-09-11 12:11:27 -0400964 }
John Stiles70957c82020-10-02 16:42:10 -0400965
966 switch ((*expr)->kind()) {
967 case Expression::Kind::kBoolLiteral:
968 case Expression::Kind::kDefined:
969 case Expression::Kind::kExternalValue:
970 case Expression::Kind::kFieldAccess:
971 case Expression::Kind::kFloatLiteral:
972 case Expression::Kind::kFunctionReference:
973 case Expression::Kind::kIntLiteral:
974 case Expression::Kind::kNullLiteral:
975 case Expression::Kind::kSetting:
976 case Expression::Kind::kTypeReference:
977 case Expression::Kind::kVariableReference:
978 // Nothing to scan here.
979 break;
980
981 case Expression::Kind::kBinary: {
982 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
983 this->visitExpression(&binaryExpr.leftPointer());
984
985 // Logical-and and logical-or binary expressions do not inline the right side,
986 // because that would invalidate short-circuiting. That is, when evaluating
987 // expressions like these:
988 // (false && x()) // always false
989 // (true || y()) // always true
990 // It is illegal for side-effects from x() or y() to occur. The simplest way to
991 // enforce that rule is to avoid inlining the right side entirely. However, it is
992 // safe for other types of binary expression to inline both sides.
993 Token::Kind op = binaryExpr.getOperator();
994 bool shortCircuitable = (op == Token::Kind::TK_LOGICALAND ||
995 op == Token::Kind::TK_LOGICALOR);
996 if (!shortCircuitable) {
997 this->visitExpression(&binaryExpr.rightPointer());
998 }
999 break;
1000 }
1001 case Expression::Kind::kConstructor: {
1002 Constructor& constructorExpr = (*expr)->as<Constructor>();
1003 for (std::unique_ptr<Expression>& arg : constructorExpr.arguments()) {
1004 this->visitExpression(&arg);
1005 }
1006 break;
1007 }
1008 case Expression::Kind::kExternalFunctionCall: {
1009 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
1010 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
1011 this->visitExpression(&arg);
1012 }
1013 break;
1014 }
1015 case Expression::Kind::kFunctionCall: {
1016 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001017 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -04001018 this->visitExpression(&arg);
1019 }
1020 this->addInlineCandidate(expr);
1021 break;
1022 }
1023 case Expression::Kind::kIndex:{
1024 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001025 this->visitExpression(&indexExpr.base());
1026 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -04001027 break;
1028 }
1029 case Expression::Kind::kPostfix: {
1030 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
1031 this->visitExpression(&postfixExpr.fOperand);
1032 break;
1033 }
1034 case Expression::Kind::kPrefix: {
1035 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
1036 this->visitExpression(&prefixExpr.fOperand);
1037 break;
1038 }
1039 case Expression::Kind::kSwizzle: {
1040 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
1041 this->visitExpression(&swizzleExpr.fBase);
1042 break;
1043 }
1044 case Expression::Kind::kTernary: {
1045 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1046 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001047 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001048 // The true- and false-expressions cannot be inlined, because we are only allowed to
1049 // evaluate one side.
1050 break;
1051 }
1052 default:
1053 SkUNREACHABLE;
1054 }
1055 }
1056
1057 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1058 fCandidateList->fCandidates.push_back(
1059 InlineCandidate{fSymbolTableStack.back(),
1060 find_parent_statement(fEnclosingStmtStack),
1061 fEnclosingStmtStack.back(),
1062 candidate,
1063 fEnclosingFunction,
1064 /*isLargeFunction=*/false});
1065 }
John Stiles2d7973a2020-10-02 15:01:03 -04001066};
John Stiles93442622020-09-11 12:11:27 -04001067
John Stiles2d7973a2020-10-02 15:01:03 -04001068bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001069 const FunctionDeclaration& funcDecl =
1070 (*candidate.fCandidateExpr)->as<FunctionCall>().function();
John Stiles915a38c2020-09-14 09:38:13 -04001071
John Stiles2d7973a2020-10-02 15:01:03 -04001072 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
1073 if (wasInserted) {
1074 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
Ethan Nicholased84b732020-10-08 11:45:44 -04001075 iter->second = this->isSafeToInline(funcDecl.definition()) &&
John Stiles2d7973a2020-10-02 15:01:03 -04001076 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001077 }
1078
John Stiles2d7973a2020-10-02 15:01:03 -04001079 return iter->second;
1080}
1081
1082bool Inliner::isLargeFunction(const FunctionDefinition* functionDef) {
1083 return Analysis::NodeCountExceeds(*functionDef, fSettings->fInlineThreshold);
1084}
1085
1086bool Inliner::isLargeFunction(const InlineCandidate& candidate, LargeFunctionCache* cache) {
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001087 const FunctionDeclaration& funcDecl =
1088 (*candidate.fCandidateExpr)->as<FunctionCall>().function();
John Stiles2d7973a2020-10-02 15:01:03 -04001089
1090 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
1091 if (wasInserted) {
Ethan Nicholased84b732020-10-08 11:45:44 -04001092 iter->second = this->isLargeFunction(funcDecl.definition());
John Stiles2d7973a2020-10-02 15:01:03 -04001093 }
1094
1095 return iter->second;
1096}
1097
1098void Inliner::buildCandidateList(Program& program, InlineCandidateList* candidateList) {
1099 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1100 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1101 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1102 // `const T&`.
1103 InlineCandidateAnalyzer analyzer;
1104 analyzer.visit(program, candidateList);
1105
1106 // Remove candidates that are not safe to inline.
1107 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
1108 InlinabilityCache cache;
1109 candidates.erase(std::remove_if(candidates.begin(),
1110 candidates.end(),
1111 [&](const InlineCandidate& candidate) {
1112 return !this->candidateCanBeInlined(candidate, &cache);
1113 }),
1114 candidates.end());
1115
1116 // Determine whether each candidate function exceeds our inlining size threshold or not. These
1117 // can still be valid candidates if they are only called one time, so we don't remove them from
1118 // the candidate list, but they will not be inlined if they're called more than once.
1119 LargeFunctionCache largeFunctionCache;
1120 for (InlineCandidate& candidate : candidates) {
1121 candidate.fIsLargeFunction = this->isLargeFunction(candidate, &largeFunctionCache);
1122 }
1123}
1124
1125bool Inliner::analyze(Program& program) {
1126 InlineCandidateList candidateList;
1127 this->buildCandidateList(program, &candidateList);
1128
John Stiles915a38c2020-09-14 09:38:13 -04001129 // Inline the candidates where we've determined that it's safe to do so.
1130 std::unordered_set<const std::unique_ptr<Statement>*> enclosingStmtSet;
1131 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001132 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001133 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001134 const FunctionDeclaration* funcDecl = &funcCall.function();
John Stiles915a38c2020-09-14 09:38:13 -04001135
John Stiles2d7973a2020-10-02 15:01:03 -04001136 // If the function is large, not marked `inline`, and is called more than once, it's a bad
1137 // idea to inline it.
1138 if (candidate.fIsLargeFunction &&
Ethan Nicholased84b732020-10-08 11:45:44 -04001139 !(funcDecl->modifiers().fFlags & Modifiers::kInline_Flag) &&
1140 funcDecl->callCount() > 1) {
John Stiles915a38c2020-09-14 09:38:13 -04001141 continue;
1142 }
1143
1144 // Inlining two expressions using the same enclosing statement in the same inlining pass
1145 // does not work properly. If this happens, skip it; we'll get it in the next pass.
1146 auto [unusedIter, inserted] = enclosingStmtSet.insert(candidate.fEnclosingStmt);
1147 if (!inserted) {
1148 continue;
1149 }
1150
1151 // Convert the function call to its inlined equivalent.
Brian Osman3887a012020-09-30 13:22:27 -04001152 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols,
1153 &candidate.fEnclosingFunction->fDeclaration);
John Stiles915a38c2020-09-14 09:38:13 -04001154 if (inlinedCall.fInlinedBody) {
1155 // Ensure that the inlined body has a scope if it needs one.
John Stiles6d696082020-10-01 10:18:54 -04001156 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
John Stiles915a38c2020-09-14 09:38:13 -04001157
1158 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1159 // function, then replace the enclosing statement with that Block.
1160 // Before:
1161 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1162 // fEnclosingStmt = stmt4
1163 // After:
1164 // fInlinedBody = null
1165 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -04001166 inlinedCall.fInlinedBody->children().push_back(std::move(*candidate.fEnclosingStmt));
John Stiles915a38c2020-09-14 09:38:13 -04001167 *candidate.fEnclosingStmt = std::move(inlinedCall.fInlinedBody);
1168 }
1169
1170 // Replace the candidate function call with our replacement expression.
1171 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1172 madeChanges = true;
1173
1174 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1175 // remain valid.
1176 }
1177
1178 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001179}
1180
John Stiles44e96be2020-08-31 13:16:04 -04001181} // namespace SkSL