junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2013 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
tfarina@chromium.org | 4ee16bf | 2014-01-10 22:08:27 +0000 | [diff] [blame] | 7 | |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 8 | #include "include/core/SkCanvas.h" |
| 9 | #include "include/core/SkData.h" |
| 10 | #include "include/core/SkOverdrawCanvas.h" |
| 11 | #include "include/core/SkPath.h" |
| 12 | #include "include/core/SkRRect.h" |
| 13 | #include "include/core/SkRegion.h" |
| 14 | #include "include/core/SkSurface.h" |
| 15 | #include "include/gpu/GrBackendSurface.h" |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 16 | #include "include/gpu/GrDirectContext.h" |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 17 | #include "src/core/SkAutoPixmapStorage.h" |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 18 | #include "src/core/SkCanvasPriv.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 19 | #include "src/core/SkDevice.h" |
| 20 | #include "src/core/SkUtils.h" |
Adlai Holler | a069304 | 2020-10-14 11:23:11 -0400 | [diff] [blame] | 21 | #include "src/gpu/GrDirectContextPriv.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 22 | #include "src/gpu/GrGpu.h" |
| 23 | #include "src/gpu/GrGpuResourcePriv.h" |
Brian Salomon | f2ebdd9 | 2019-09-30 12:15:30 -0400 | [diff] [blame] | 24 | #include "src/gpu/GrImageInfo.h" |
Stephen White | fdba6c8 | 2020-05-26 17:00:32 -0400 | [diff] [blame] | 25 | #include "src/gpu/GrRenderTarget.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 26 | #include "src/gpu/GrResourceProvider.h" |
Brian Salomon | eebe735 | 2020-12-09 16:37:04 -0500 | [diff] [blame] | 27 | #include "src/gpu/GrSurfaceDrawContext.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 28 | #include "src/gpu/SkGpuDevice.h" |
| 29 | #include "src/image/SkImage_Base.h" |
| 30 | #include "src/image/SkImage_Gpu.h" |
| 31 | #include "src/image/SkSurface_Gpu.h" |
| 32 | #include "tests/Test.h" |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 33 | #include "tools/ToolUtils.h" |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 34 | #include "tools/gpu/BackendSurfaceFactory.h" |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 35 | #include "tools/gpu/ManagedBackendTexture.h" |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 36 | |
Hal Canary | 8a00144 | 2018-09-19 11:31:27 -0400 | [diff] [blame] | 37 | #include <functional> |
| 38 | #include <initializer_list> |
| 39 | #include <vector> |
| 40 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 41 | static void release_direct_surface_storage(void* pixels, void* context) { |
reed | 982542d | 2014-06-27 06:48:14 -0700 | [diff] [blame] | 42 | SkASSERT(pixels == context); |
| 43 | sk_free(pixels); |
| 44 | } |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 45 | static sk_sp<SkSurface> create_surface(SkAlphaType at = kPremul_SkAlphaType, |
| 46 | SkImageInfo* requestedInfo = nullptr) { |
bsalomon | 74f681d | 2015-06-23 14:38:48 -0700 | [diff] [blame] | 47 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 48 | if (requestedInfo) { |
| 49 | *requestedInfo = info; |
| 50 | } |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 51 | return SkSurface::MakeRaster(info); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 52 | } |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 53 | static sk_sp<SkSurface> create_direct_surface(SkAlphaType at = kPremul_SkAlphaType, |
| 54 | SkImageInfo* requestedInfo = nullptr) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 55 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
| 56 | if (requestedInfo) { |
| 57 | *requestedInfo = info; |
| 58 | } |
| 59 | const size_t rowBytes = info.minRowBytes(); |
Mike Reed | f0ffb89 | 2017-10-03 14:47:21 -0400 | [diff] [blame] | 60 | void* storage = sk_malloc_throw(info.computeByteSize(rowBytes)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 61 | return SkSurface::MakeRasterDirectReleaseProc(info, storage, rowBytes, |
| 62 | release_direct_surface_storage, |
| 63 | storage); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 64 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 65 | static sk_sp<SkSurface> create_gpu_surface(GrRecordingContext* rContext, |
| 66 | SkAlphaType at = kPremul_SkAlphaType, |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 67 | SkImageInfo* requestedInfo = nullptr) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 68 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
| 69 | if (requestedInfo) { |
| 70 | *requestedInfo = info; |
| 71 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 72 | return SkSurface::MakeRenderTarget(rContext, SkBudgeted::kNo, info); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 73 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 74 | static sk_sp<SkSurface> create_gpu_scratch_surface(GrRecordingContext* rContext, |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 75 | SkAlphaType at = kPremul_SkAlphaType, |
| 76 | SkImageInfo* requestedInfo = nullptr) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 77 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
| 78 | if (requestedInfo) { |
| 79 | *requestedInfo = info; |
| 80 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 81 | return SkSurface::MakeRenderTarget(rContext, SkBudgeted::kYes, info); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 82 | } |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 83 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 84 | DEF_TEST(SurfaceEmpty, reporter) { |
reed | b2497c2 | 2014-12-31 12:31:43 -0800 | [diff] [blame] | 85 | const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 86 | REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRaster(info)); |
| 87 | REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRasterDirect(info, nullptr, 0)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 88 | |
reed | b2497c2 | 2014-12-31 12:31:43 -0800 | [diff] [blame] | 89 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 90 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceEmpty_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 91 | const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType); |
| 92 | REPORTER_ASSERT(reporter, nullptr == |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 93 | SkSurface::MakeRenderTarget(ctxInfo.directContext(), SkBudgeted::kNo, info)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 94 | } |
reed | b2497c2 | 2014-12-31 12:31:43 -0800 | [diff] [blame] | 95 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 96 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(GrContext_colorTypeSupportedAsSurface, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 97 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 98 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 99 | for (int ct = 0; ct < kLastEnum_SkColorType; ++ct) { |
| 100 | static constexpr int kSize = 10; |
| 101 | |
| 102 | SkColorType colorType = static_cast<SkColorType>(ct); |
| 103 | auto info = SkImageInfo::Make(kSize, kSize, colorType, kOpaque_SkAlphaType, nullptr); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 104 | |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 105 | { |
| 106 | bool can = context->colorTypeSupportedAsSurface(colorType); |
| 107 | auto surf = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, info, 1, nullptr); |
| 108 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, can: %d, surf: %d", |
| 109 | colorType, can, SkToBool(surf)); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 110 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 111 | surf = sk_gpu_test::MakeBackendTextureSurface(context, |
| 112 | {kSize, kSize}, |
| 113 | kTopLeft_GrSurfaceOrigin, |
| 114 | /*sample cnt*/ 1, |
| 115 | colorType); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 116 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, can: %d, surf: %d", |
| 117 | colorType, can, SkToBool(surf)); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 118 | } |
| 119 | |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 120 | // The MSAA test only makes sense if the colorType is renderable to begin with. |
| 121 | if (context->colorTypeSupportedAsSurface(colorType)) { |
| 122 | static constexpr int kSampleCnt = 2; |
| 123 | |
| 124 | bool can = context->maxSurfaceSampleCountForColorType(colorType) >= kSampleCnt; |
| 125 | auto surf = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, info, kSampleCnt, |
| 126 | nullptr); |
| 127 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, can: %d, surf: %d", |
| 128 | colorType, can, SkToBool(surf)); |
| 129 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 130 | surf = sk_gpu_test::MakeBackendTextureSurface( |
| 131 | context, {kSize, kSize}, kTopLeft_GrSurfaceOrigin, kSampleCnt, colorType); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 132 | REPORTER_ASSERT(reporter, can == SkToBool(surf), |
| 133 | "colorTypeSupportedAsSurface:%d, surf:%d, ct:%d", can, SkToBool(surf), |
| 134 | colorType); |
| 135 | // Ensure that the sample count stored on the resulting SkSurface is a valid value. |
| 136 | if (surf) { |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 137 | auto sdc = SkCanvasPriv::TopDeviceSurfaceDrawContext(surf->getCanvas()); |
| 138 | int storedCnt = sdc->numSamples(); |
| 139 | GrBackendFormat format = sdc->asSurfaceProxy()->backendFormat(); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 140 | int allowedCnt = |
| 141 | context->priv().caps()->getRenderTargetSampleCount(storedCnt, format); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 142 | REPORTER_ASSERT(reporter, storedCnt == allowedCnt, |
| 143 | "Should store an allowed sample count (%d vs %d)", allowedCnt, |
| 144 | storedCnt); |
| 145 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 146 | } |
| 147 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 148 | for (int sampleCnt : {1, 2}) { |
Brian Salomon | f9b0042 | 2020-10-08 16:00:14 -0400 | [diff] [blame] | 149 | auto surf = sk_gpu_test::MakeBackendRenderTargetSurface(context, |
| 150 | {16, 16}, |
| 151 | kTopLeft_GrSurfaceOrigin, |
| 152 | sampleCnt, |
| 153 | colorType); |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 154 | bool can = context->colorTypeSupportedAsSurface(colorType) && |
| 155 | context->maxSurfaceSampleCountForColorType(colorType) >= sampleCnt; |
| 156 | if (!surf && can && colorType == kBGRA_8888_SkColorType && sampleCnt > 1 && |
| 157 | context->backend() == GrBackendApi::kOpenGL) { |
| 158 | // This is an execeptional case. On iOS GLES we support MSAA BGRA for internally- |
| 159 | // created render targets by using a MSAA RGBA8 renderbuffer that resolves to a |
| 160 | // BGRA8 texture. However, the GL_APPLE_texture_format_BGRA8888 extension does not |
| 161 | // allow creation of BGRA8 renderbuffers and we don't support multisampled textures. |
| 162 | // So this is expected to fail. As of 10/5/2020 it actually seems to work to create |
| 163 | // a MSAA BGRA8 renderbuffer (at least in the simulator) but we don't want to rely |
| 164 | // on this undocumented behavior. |
| 165 | continue; |
| 166 | } |
| 167 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, sc: %d, can: %d, surf: %d", |
| 168 | colorType, sampleCnt, can, SkToBool(surf)); |
| 169 | if (surf) { |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 170 | auto sdc = SkCanvasPriv::TopDeviceSurfaceDrawContext(surf->getCanvas()); |
| 171 | auto backendFormat = sdc->asSurfaceProxy()->backendFormat(); |
| 172 | int storedCnt = sdc->numSamples(); |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 173 | int allowedCnt = context->priv().caps()->getRenderTargetSampleCount(storedCnt, |
| 174 | backendFormat); |
| 175 | REPORTER_ASSERT(reporter, storedCnt == allowedCnt, |
| 176 | "Should store an allowed sample count (%d vs %d)", allowedCnt, |
| 177 | storedCnt); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 178 | } |
Brian Salomon | 93348dd | 2018-08-29 12:56:23 -0400 | [diff] [blame] | 179 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 180 | } |
| 181 | } |
| 182 | |
| 183 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(GrContext_maxSurfaceSamplesForColorType, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 184 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 185 | |
| 186 | static constexpr int kSize = 10; |
| 187 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 188 | for (int ct = 0; ct < kLastEnum_SkColorType; ++ct) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 189 | |
| 190 | SkColorType colorType = static_cast<SkColorType>(ct); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 191 | int maxSampleCnt = context->maxSurfaceSampleCountForColorType(colorType); |
| 192 | if (!maxSampleCnt) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 193 | continue; |
| 194 | } |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 195 | if (!context->colorTypeSupportedAsSurface(colorType)) { |
| 196 | continue; |
| 197 | } |
| 198 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 199 | auto info = SkImageInfo::Make(kSize, kSize, colorType, kOpaque_SkAlphaType, nullptr); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 200 | auto surf = sk_gpu_test::MakeBackendTextureSurface( |
| 201 | context, info, kTopLeft_GrSurfaceOrigin, maxSampleCnt); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 202 | if (!surf) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 203 | ERRORF(reporter, "Could not make surface of color type %d.", colorType); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 204 | continue; |
| 205 | } |
| 206 | int sampleCnt = ((SkSurface_Gpu*)(surf.get())) |
| 207 | ->getDevice() |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 208 | ->surfaceDrawContext() |
Chris Dalton | 6ce447a | 2019-06-23 18:07:38 -0600 | [diff] [blame] | 209 | ->numSamples(); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 210 | REPORTER_ASSERT(reporter, sampleCnt == maxSampleCnt, "Exected: %d, actual: %d", |
| 211 | maxSampleCnt, sampleCnt); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 212 | } |
| 213 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 214 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 215 | static void test_canvas_peek(skiatest::Reporter* reporter, |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 216 | sk_sp<SkSurface>& surface, |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 217 | const SkImageInfo& requestInfo, |
| 218 | bool expectPeekSuccess) { |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 219 | const SkColor color = SK_ColorRED; |
| 220 | const SkPMColor pmcolor = SkPreMultiplyColor(color); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 221 | surface->getCanvas()->clear(color); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 222 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 223 | SkPixmap pmap; |
| 224 | bool success = surface->getCanvas()->peekPixels(&pmap); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 225 | REPORTER_ASSERT(reporter, expectPeekSuccess == success); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 226 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 227 | SkPixmap pmap2; |
| 228 | const void* addr2 = surface->peekPixels(&pmap2) ? pmap2.addr() : nullptr; |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 229 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 230 | if (success) { |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 231 | REPORTER_ASSERT(reporter, requestInfo == pmap.info()); |
| 232 | REPORTER_ASSERT(reporter, requestInfo.minRowBytes() <= pmap.rowBytes()); |
| 233 | REPORTER_ASSERT(reporter, pmcolor == *pmap.addr32()); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 234 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 235 | REPORTER_ASSERT(reporter, pmap.addr() == pmap2.addr()); |
| 236 | REPORTER_ASSERT(reporter, pmap.info() == pmap2.info()); |
| 237 | REPORTER_ASSERT(reporter, pmap.rowBytes() == pmap2.rowBytes()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 238 | } else { |
| 239 | REPORTER_ASSERT(reporter, nullptr == addr2); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 240 | } |
| 241 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 242 | DEF_TEST(SurfaceCanvasPeek, reporter) { |
| 243 | for (auto& surface_func : { &create_surface, &create_direct_surface }) { |
| 244 | SkImageInfo requestInfo; |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 245 | auto surface(surface_func(kPremul_SkAlphaType, &requestInfo)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 246 | test_canvas_peek(reporter, surface, requestInfo, true); |
| 247 | } |
| 248 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 249 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCanvasPeek_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 250 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
| 251 | SkImageInfo requestInfo; |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 252 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, &requestInfo)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 253 | test_canvas_peek(reporter, surface, requestInfo, false); |
| 254 | } |
| 255 | } |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 256 | |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 257 | static void test_snapshot_alphatype(skiatest::Reporter* reporter, const sk_sp<SkSurface>& surface, |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 258 | SkAlphaType expectedAlphaType) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 259 | REPORTER_ASSERT(reporter, surface); |
| 260 | if (surface) { |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 261 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 262 | REPORTER_ASSERT(reporter, image); |
| 263 | if (image) { |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 264 | REPORTER_ASSERT(reporter, image->alphaType() == expectedAlphaType); |
reed | 41e010c | 2015-06-09 12:16:53 -0700 | [diff] [blame] | 265 | } |
| 266 | } |
| 267 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 268 | DEF_TEST(SurfaceSnapshotAlphaType, reporter) { |
| 269 | for (auto& surface_func : { &create_surface, &create_direct_surface }) { |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 270 | for (auto& at: { kOpaque_SkAlphaType, kPremul_SkAlphaType, kUnpremul_SkAlphaType }) { |
| 271 | auto surface(surface_func(at, nullptr)); |
| 272 | test_snapshot_alphatype(reporter, surface, at); |
bsalomon | 74f681d | 2015-06-23 14:38:48 -0700 | [diff] [blame] | 273 | } |
| 274 | } |
| 275 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 276 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceSnapshotAlphaType_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 277 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 278 | // GPU doesn't support creating unpremul surfaces, so only test opaque + premul |
| 279 | for (auto& at : { kOpaque_SkAlphaType, kPremul_SkAlphaType }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 280 | auto surface(surface_func(ctxInfo.directContext(), at, nullptr)); |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 281 | test_snapshot_alphatype(reporter, surface, at); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 282 | } |
| 283 | } |
| 284 | } |
bsalomon | 74f681d | 2015-06-23 14:38:48 -0700 | [diff] [blame] | 285 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 286 | static void test_backend_texture_access_copy_on_write( |
| 287 | skiatest::Reporter* reporter, SkSurface* surface, SkSurface::BackendHandleAccess access) { |
| 288 | GrBackendTexture tex1 = surface->getBackendTexture(access); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 289 | sk_sp<SkImage> snap1(surface->makeImageSnapshot()); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 290 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 291 | GrBackendTexture tex2 = surface->getBackendTexture(access); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 292 | sk_sp<SkImage> snap2(surface->makeImageSnapshot()); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 293 | |
| 294 | // If the access mode triggers CoW, then the backend objects should reflect it. |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 295 | REPORTER_ASSERT(reporter, GrBackendTexture::TestingOnly_Equals(tex1, tex2) == (snap1 == snap2)); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 296 | } |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 297 | |
| 298 | static void test_backend_rendertarget_access_copy_on_write( |
| 299 | skiatest::Reporter* reporter, SkSurface* surface, SkSurface::BackendHandleAccess access) { |
| 300 | GrBackendRenderTarget rt1 = surface->getBackendRenderTarget(access); |
| 301 | sk_sp<SkImage> snap1(surface->makeImageSnapshot()); |
| 302 | |
| 303 | GrBackendRenderTarget rt2 = surface->getBackendRenderTarget(access); |
| 304 | sk_sp<SkImage> snap2(surface->makeImageSnapshot()); |
| 305 | |
| 306 | // If the access mode triggers CoW, then the backend objects should reflect it. |
| 307 | REPORTER_ASSERT(reporter, GrBackendRenderTarget::TestingOnly_Equals(rt1, rt2) == |
| 308 | (snap1 == snap2)); |
| 309 | } |
| 310 | |
| 311 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendSurfaceAccessCopyOnWrite_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 312 | const SkSurface::BackendHandleAccess accessModes[] = { |
| 313 | SkSurface::kFlushRead_BackendHandleAccess, |
| 314 | SkSurface::kFlushWrite_BackendHandleAccess, |
| 315 | SkSurface::kDiscardWrite_BackendHandleAccess, |
| 316 | }; |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 317 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 318 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 319 | for (auto& accessMode : accessModes) { |
| 320 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 321 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 322 | test_backend_texture_access_copy_on_write(reporter, surface.get(), accessMode); |
| 323 | } |
| 324 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 325 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 326 | test_backend_rendertarget_access_copy_on_write(reporter, surface.get(), accessMode); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 327 | } |
| 328 | } |
| 329 | } |
| 330 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 331 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 332 | template<typename Type, Type(SkSurface::*func)(SkSurface::BackendHandleAccess)> |
| 333 | static void test_backend_unique_id(skiatest::Reporter* reporter, SkSurface* surface) { |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 334 | sk_sp<SkImage> image0(surface->makeImageSnapshot()); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 335 | |
| 336 | Type obj = (surface->*func)(SkSurface::kFlushRead_BackendHandleAccess); |
| 337 | REPORTER_ASSERT(reporter, obj.isValid()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 338 | sk_sp<SkImage> image1(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 339 | // just read access should not affect the snapshot |
| 340 | REPORTER_ASSERT(reporter, image0->uniqueID() == image1->uniqueID()); |
| 341 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 342 | obj = (surface->*func)(SkSurface::kFlushWrite_BackendHandleAccess); |
| 343 | REPORTER_ASSERT(reporter, obj.isValid()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 344 | sk_sp<SkImage> image2(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 345 | // expect a new image, since we claimed we would write |
| 346 | REPORTER_ASSERT(reporter, image0->uniqueID() != image2->uniqueID()); |
| 347 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 348 | obj = (surface->*func)(SkSurface::kDiscardWrite_BackendHandleAccess); |
| 349 | REPORTER_ASSERT(reporter, obj.isValid()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 350 | sk_sp<SkImage> image3(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 351 | // expect a new(er) image, since we claimed we would write |
| 352 | REPORTER_ASSERT(reporter, image0->uniqueID() != image3->uniqueID()); |
| 353 | REPORTER_ASSERT(reporter, image2->uniqueID() != image3->uniqueID()); |
| 354 | } |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 355 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 356 | // No CPU test. |
bsalomon | 68d9134 | 2016-04-12 09:59:58 -0700 | [diff] [blame] | 357 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendHandleAccessIDs_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 358 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 359 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 360 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 361 | test_backend_unique_id<GrBackendTexture, &SkSurface::getBackendTexture>(reporter, |
| 362 | surface.get()); |
| 363 | } |
| 364 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 365 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 366 | test_backend_unique_id<GrBackendRenderTarget, &SkSurface::getBackendRenderTarget>( |
| 367 | reporter, surface.get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 368 | } |
| 369 | } |
| 370 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 371 | |
| 372 | // Verify that the right canvas commands trigger a copy on write. |
| 373 | static void test_copy_on_write(skiatest::Reporter* reporter, SkSurface* surface) { |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 374 | SkCanvas* canvas = surface->getCanvas(); |
| 375 | |
| 376 | const SkRect testRect = |
| 377 | SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0), |
| 378 | SkIntToScalar(4), SkIntToScalar(5)); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 379 | SkPath testPath; |
| 380 | testPath.addRect(SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0), |
| 381 | SkIntToScalar(2), SkIntToScalar(1))); |
| 382 | |
| 383 | const SkIRect testIRect = SkIRect::MakeXYWH(0, 0, 2, 1); |
| 384 | |
| 385 | SkRegion testRegion; |
| 386 | testRegion.setRect(testIRect); |
| 387 | |
| 388 | |
| 389 | const SkColor testColor = 0x01020304; |
| 390 | const SkPaint testPaint; |
| 391 | const SkPoint testPoints[3] = { |
| 392 | {SkIntToScalar(0), SkIntToScalar(0)}, |
| 393 | {SkIntToScalar(2), SkIntToScalar(1)}, |
| 394 | {SkIntToScalar(0), SkIntToScalar(2)} |
| 395 | }; |
| 396 | const size_t testPointCount = 3; |
| 397 | |
| 398 | SkBitmap testBitmap; |
mike@reedtribe.org | deee496 | 2014-02-13 14:41:43 +0000 | [diff] [blame] | 399 | testBitmap.allocN32Pixels(10, 10); |
robertphillips@google.com | d1ce77d | 2013-10-09 12:51:09 +0000 | [diff] [blame] | 400 | testBitmap.eraseColor(0); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 401 | |
| 402 | SkRRect testRRect; |
| 403 | testRRect.setRectXY(testRect, SK_Scalar1, SK_Scalar1); |
| 404 | |
| 405 | SkString testText("Hello World"); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 406 | |
| 407 | #define EXPECT_COPY_ON_WRITE(command) \ |
| 408 | { \ |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 409 | sk_sp<SkImage> imageBefore = surface->makeImageSnapshot(); \ |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 410 | sk_sp<SkImage> aur_before(imageBefore); /*NOLINT*/ \ |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 411 | canvas-> command ; \ |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 412 | sk_sp<SkImage> imageAfter = surface->makeImageSnapshot(); \ |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 413 | sk_sp<SkImage> aur_after(imageAfter); /*NOLINT*/ \ |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 414 | REPORTER_ASSERT(reporter, imageBefore != imageAfter); \ |
| 415 | } |
| 416 | |
| 417 | EXPECT_COPY_ON_WRITE(clear(testColor)) |
| 418 | EXPECT_COPY_ON_WRITE(drawPaint(testPaint)) |
| 419 | EXPECT_COPY_ON_WRITE(drawPoints(SkCanvas::kPoints_PointMode, testPointCount, testPoints, \ |
| 420 | testPaint)) |
| 421 | EXPECT_COPY_ON_WRITE(drawOval(testRect, testPaint)) |
| 422 | EXPECT_COPY_ON_WRITE(drawRect(testRect, testPaint)) |
| 423 | EXPECT_COPY_ON_WRITE(drawRRect(testRRect, testPaint)) |
| 424 | EXPECT_COPY_ON_WRITE(drawPath(testPath, testPaint)) |
| 425 | EXPECT_COPY_ON_WRITE(drawBitmap(testBitmap, 0, 0)) |
reed | e47829b | 2015-08-06 10:02:53 -0700 | [diff] [blame] | 426 | EXPECT_COPY_ON_WRITE(drawBitmapRect(testBitmap, testRect, nullptr)) |
Hal Canary | 89a644b | 2019-01-07 09:36:09 -0500 | [diff] [blame] | 427 | EXPECT_COPY_ON_WRITE(drawString(testText, 0, 1, SkFont(), testPaint)) |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 428 | } |
| 429 | DEF_TEST(SurfaceCopyOnWrite, reporter) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 430 | test_copy_on_write(reporter, create_surface().get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 431 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 432 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCopyOnWrite_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 433 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 434 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 435 | test_copy_on_write(reporter, surface.get()); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 436 | } |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 437 | } |
| 438 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 439 | static void test_writable_after_snapshot_release(skiatest::Reporter* reporter, |
| 440 | SkSurface* surface) { |
junov@chromium.org | af05835 | 2013-04-03 15:03:26 +0000 | [diff] [blame] | 441 | // This test succeeds by not triggering an assertion. |
| 442 | // The test verifies that the surface remains writable (usable) after |
| 443 | // acquiring and releasing a snapshot without triggering a copy on write. |
junov@chromium.org | af05835 | 2013-04-03 15:03:26 +0000 | [diff] [blame] | 444 | SkCanvas* canvas = surface->getCanvas(); |
| 445 | canvas->clear(1); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 446 | surface->makeImageSnapshot(); // Create and destroy SkImage |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 447 | canvas->clear(2); // Must not assert internally |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 448 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 449 | DEF_TEST(SurfaceWriteableAfterSnapshotRelease, reporter) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 450 | test_writable_after_snapshot_release(reporter, create_surface().get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 451 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 452 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceWriteableAfterSnapshotRelease_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 453 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 454 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 455 | test_writable_after_snapshot_release(reporter, surface.get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 456 | } |
| 457 | } |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 458 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 459 | static void test_crbug263329(skiatest::Reporter* reporter, |
| 460 | SkSurface* surface1, |
| 461 | SkSurface* surface2) { |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 462 | // This is a regression test for crbug.com/263329 |
| 463 | // Bug was caused by onCopyOnWrite releasing the old surface texture |
| 464 | // back to the scratch texture pool even though the texture is used |
| 465 | // by and active SkImage_Gpu. |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 466 | SkCanvas* canvas1 = surface1->getCanvas(); |
| 467 | SkCanvas* canvas2 = surface2->getCanvas(); |
| 468 | canvas1->clear(1); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 469 | sk_sp<SkImage> image1(surface1->makeImageSnapshot()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 470 | // Trigger copy on write, new backing is a scratch texture |
| 471 | canvas1->clear(2); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 472 | sk_sp<SkImage> image2(surface1->makeImageSnapshot()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 473 | // Trigger copy on write, old backing should not be returned to scratch |
| 474 | // pool because it is held by image2 |
| 475 | canvas1->clear(3); |
| 476 | |
| 477 | canvas2->clear(4); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 478 | sk_sp<SkImage> image3(surface2->makeImageSnapshot()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 479 | // Trigger copy on write on surface2. The new backing store should not |
| 480 | // be recycling a texture that is held by an existing image. |
| 481 | canvas2->clear(5); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 482 | sk_sp<SkImage> image4(surface2->makeImageSnapshot()); |
Greg Daniel | 7c90211 | 2020-03-06 13:07:10 -0500 | [diff] [blame] | 483 | |
| 484 | SkImage_GpuBase* gpuImage1 = static_cast<SkImage_GpuBase*>(as_IB(image1)); |
| 485 | SkImage_GpuBase* gpuImage2 = static_cast<SkImage_GpuBase*>(as_IB(image2)); |
| 486 | SkImage_GpuBase* gpuImage3 = static_cast<SkImage_GpuBase*>(as_IB(image3)); |
| 487 | SkImage_GpuBase* gpuImage4 = static_cast<SkImage_GpuBase*>(as_IB(image4)); |
| 488 | |
| 489 | REPORTER_ASSERT(reporter, gpuImage4->getTexture() != gpuImage3->getTexture()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 490 | // The following assertion checks crbug.com/263329 |
Greg Daniel | 7c90211 | 2020-03-06 13:07:10 -0500 | [diff] [blame] | 491 | REPORTER_ASSERT(reporter, gpuImage4->getTexture() != gpuImage2->getTexture()); |
| 492 | REPORTER_ASSERT(reporter, gpuImage4->getTexture() != gpuImage1->getTexture()); |
| 493 | REPORTER_ASSERT(reporter, gpuImage3->getTexture() != gpuImage2->getTexture()); |
| 494 | REPORTER_ASSERT(reporter, gpuImage3->getTexture() != gpuImage1->getTexture()); |
| 495 | REPORTER_ASSERT(reporter, gpuImage2->getTexture() != gpuImage1->getTexture()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 496 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 497 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCRBug263329_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 498 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 499 | auto surface1(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
| 500 | auto surface2(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 501 | test_crbug263329(reporter, surface1.get(), surface2.get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 502 | } |
| 503 | } |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 504 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 505 | DEF_TEST(SurfaceGetTexture, reporter) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 506 | auto surface(create_surface()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 507 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 508 | REPORTER_ASSERT(reporter, !as_IB(image)->isTextureBacked()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 509 | surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 510 | REPORTER_ASSERT(reporter, !as_IB(image)->isTextureBacked()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 511 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 512 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfacepeekTexture_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 513 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 514 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 515 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 516 | |
| 517 | REPORTER_ASSERT(reporter, as_IB(image)->isTextureBacked()); |
Robert Phillips | c550995 | 2018-04-04 15:54:55 -0400 | [diff] [blame] | 518 | GrBackendTexture backendTex = image->getBackendTexture(false); |
| 519 | REPORTER_ASSERT(reporter, backendTex.isValid()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 520 | surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 521 | REPORTER_ASSERT(reporter, as_IB(image)->isTextureBacked()); |
Robert Phillips | c550995 | 2018-04-04 15:54:55 -0400 | [diff] [blame] | 522 | GrBackendTexture backendTex2 = image->getBackendTexture(false); |
| 523 | REPORTER_ASSERT(reporter, GrBackendTexture::TestingOnly_Equals(backendTex, backendTex2)); |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 524 | } |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 525 | } |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 526 | |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 527 | static SkBudgeted is_budgeted(const sk_sp<SkSurface>& surf) { |
| 528 | SkSurface_Gpu* gsurf = (SkSurface_Gpu*)surf.get(); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 529 | |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 530 | GrRenderTargetProxy* proxy = gsurf->getDevice()->surfaceDrawContext()->asRenderTargetProxy(); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 531 | return proxy->isBudgeted(); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 532 | } |
| 533 | |
bsalomon | 5ec26ae | 2016-02-25 08:33:02 -0800 | [diff] [blame] | 534 | static SkBudgeted is_budgeted(SkImage* image) { |
Robert Phillips | 0ae6faa | 2017-03-21 16:22:00 -0400 | [diff] [blame] | 535 | return ((SkImage_Gpu*)image)->peekProxy()->isBudgeted(); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 536 | } |
| 537 | |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 538 | static SkBudgeted is_budgeted(const sk_sp<SkImage> image) { |
| 539 | return is_budgeted(image.get()); |
| 540 | } |
| 541 | |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 542 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBudget, reporter, ctxInfo) { |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 543 | SkImageInfo info = SkImageInfo::MakeN32Premul(8,8); |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 544 | for (auto budgeted : { SkBudgeted::kNo, SkBudgeted::kYes }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 545 | auto surface(SkSurface::MakeRenderTarget(ctxInfo.directContext(), budgeted, info)); |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 546 | SkASSERT(surface); |
| 547 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface)); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 548 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 549 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 550 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 551 | // Initially the image shares a texture with the surface, and the |
| 552 | // the budgets should always match. |
| 553 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface)); |
| 554 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(image)); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 555 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 556 | // Now trigger copy-on-write |
| 557 | surface->getCanvas()->clear(SK_ColorBLUE); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 558 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 559 | // They don't share a texture anymore but the budgets should still match. |
| 560 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface)); |
| 561 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(image)); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 562 | } |
| 563 | } |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 564 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 565 | static void test_no_canvas1(skiatest::Reporter* reporter, |
| 566 | SkSurface* surface, |
| 567 | SkSurface::ContentChangeMode mode) { |
| 568 | // Test passes by not asserting |
| 569 | surface->notifyContentWillChange(mode); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 570 | } |
| 571 | static void test_no_canvas2(skiatest::Reporter* reporter, |
| 572 | SkSurface* surface, |
| 573 | SkSurface::ContentChangeMode mode) { |
junov@chromium.org | acea3ef | 2013-04-16 19:41:09 +0000 | [diff] [blame] | 574 | // Verifies the robustness of SkSurface for handling use cases where calls |
| 575 | // are made before a canvas is created. |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 576 | sk_sp<SkImage> image1 = surface->makeImageSnapshot(); |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 577 | sk_sp<SkImage> aur_image1(image1); // NOLINT(performance-unnecessary-copy-initialization) |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 578 | surface->notifyContentWillChange(mode); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 579 | sk_sp<SkImage> image2 = surface->makeImageSnapshot(); |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 580 | sk_sp<SkImage> aur_image2(image2); // NOLINT(performance-unnecessary-copy-initialization) |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 581 | REPORTER_ASSERT(reporter, image1 != image2); |
junov@chromium.org | acea3ef | 2013-04-16 19:41:09 +0000 | [diff] [blame] | 582 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 583 | DEF_TEST(SurfaceNoCanvas, reporter) { |
| 584 | SkSurface::ContentChangeMode modes[] = |
| 585 | { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode}; |
| 586 | for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) { |
| 587 | for (auto& mode : modes) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 588 | test_func(reporter, create_surface().get(), mode); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 589 | } |
| 590 | } |
| 591 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 592 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceNoCanvas_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 593 | SkSurface::ContentChangeMode modes[] = |
| 594 | { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode}; |
| 595 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
| 596 | for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) { |
| 597 | for (auto& mode : modes) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 598 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 599 | test_func(reporter, surface.get(), mode); |
bsalomon | e904c09 | 2014-07-17 10:50:59 -0700 | [diff] [blame] | 600 | } |
robertphillips@google.com | 3bddb38 | 2013-11-12 13:51:03 +0000 | [diff] [blame] | 601 | } |
junov@chromium.org | af05835 | 2013-04-03 15:03:26 +0000 | [diff] [blame] | 602 | } |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 603 | } |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 604 | |
| 605 | static void check_rowbytes_remain_consistent(SkSurface* surface, skiatest::Reporter* reporter) { |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 606 | SkPixmap surfacePM; |
| 607 | REPORTER_ASSERT(reporter, surface->peekPixels(&surfacePM)); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 608 | |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 609 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 610 | SkPixmap pm; |
| 611 | REPORTER_ASSERT(reporter, image->peekPixels(&pm)); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 612 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 613 | REPORTER_ASSERT(reporter, surfacePM.rowBytes() == pm.rowBytes()); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 614 | |
| 615 | // trigger a copy-on-write |
| 616 | surface->getCanvas()->drawPaint(SkPaint()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 617 | sk_sp<SkImage> image2(surface->makeImageSnapshot()); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 618 | REPORTER_ASSERT(reporter, image->uniqueID() != image2->uniqueID()); |
| 619 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 620 | SkPixmap pm2; |
| 621 | REPORTER_ASSERT(reporter, image2->peekPixels(&pm2)); |
| 622 | REPORTER_ASSERT(reporter, pm2.rowBytes() == pm.rowBytes()); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 623 | } |
| 624 | |
| 625 | DEF_TEST(surface_rowbytes, reporter) { |
| 626 | const SkImageInfo info = SkImageInfo::MakeN32Premul(100, 100); |
| 627 | |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 628 | auto surf0(SkSurface::MakeRaster(info)); |
| 629 | check_rowbytes_remain_consistent(surf0.get(), reporter); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 630 | |
| 631 | // specify a larger rowbytes |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 632 | auto surf1(SkSurface::MakeRaster(info, 500, nullptr)); |
| 633 | check_rowbytes_remain_consistent(surf1.get(), reporter); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 634 | |
| 635 | // Try some illegal rowByte values |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 636 | auto s = SkSurface::MakeRaster(info, 396, nullptr); // needs to be at least 400 |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 637 | REPORTER_ASSERT(reporter, nullptr == s); |
Mike Reed | f0ffb89 | 2017-10-03 14:47:21 -0400 | [diff] [blame] | 638 | s = SkSurface::MakeRaster(info, std::numeric_limits<size_t>::max(), nullptr); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 639 | REPORTER_ASSERT(reporter, nullptr == s); |
| 640 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 641 | |
fmalita | 03912f1 | 2016-07-06 06:22:06 -0700 | [diff] [blame] | 642 | DEF_TEST(surface_raster_zeroinitialized, reporter) { |
| 643 | sk_sp<SkSurface> s(SkSurface::MakeRasterN32Premul(100, 100)); |
| 644 | SkPixmap pixmap; |
| 645 | REPORTER_ASSERT(reporter, s->peekPixels(&pixmap)); |
| 646 | |
| 647 | for (int i = 0; i < pixmap.info().width(); ++i) { |
| 648 | for (int j = 0; j < pixmap.info().height(); ++j) { |
| 649 | REPORTER_ASSERT(reporter, *pixmap.addr32(i, j) == 0); |
| 650 | } |
| 651 | } |
| 652 | } |
| 653 | |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 654 | static sk_sp<SkSurface> create_gpu_surface_backend_texture(GrDirectContext* dContext, |
| 655 | int sampleCnt, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 656 | const SkColor4f& color) { |
Michael Ludwig | 72ab346 | 2018-12-10 12:43:36 -0500 | [diff] [blame] | 657 | // On Pixel and Pixel2XL's with Adreno 530 and 540s, setting width and height to 10s reliably |
| 658 | // triggers what appears to be a driver race condition where the 10x10 surface from the |
| 659 | // OverdrawSurface_gpu test is reused(?) for this surface created by the SurfacePartialDraw_gpu |
| 660 | // test. |
| 661 | // |
| 662 | // Immediately after creation of this surface, readback shows the correct initial solid color. |
| 663 | // However, sometime before content is rendered into the upper half of the surface, the driver |
| 664 | // presumably cleans up the OverdrawSurface_gpu's memory which corrupts this color buffer. The |
| 665 | // top half of the surface is fine after the partially-covering rectangle is drawn, but the |
| 666 | // untouched bottom half contains random pixel values that trigger asserts in the |
| 667 | // SurfacePartialDraw_gpu test for no longer matching the initial color. Running the |
| 668 | // SurfacePartialDraw_gpu test without the OverdrawSurface_gpu test completes successfully. |
| 669 | // |
| 670 | // Requesting a much larger backend texture size seems to prevent it from reusing the same |
| 671 | // memory and avoids the issue. |
| 672 | #if defined(SK_BUILD_FOR_SKQP) |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 673 | const int kWidth = 10; |
| 674 | const int kHeight = 10; |
Michael Ludwig | 72ab346 | 2018-12-10 12:43:36 -0500 | [diff] [blame] | 675 | #else |
| 676 | const int kWidth = 100; |
| 677 | const int kHeight = 100; |
| 678 | #endif |
| 679 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 680 | auto surf = sk_gpu_test::MakeBackendTextureSurface(dContext, |
| 681 | {kWidth, kHeight}, |
| 682 | kTopLeft_GrSurfaceOrigin, |
| 683 | sampleCnt, |
| 684 | kRGBA_8888_SkColorType); |
| 685 | if (!surf) { |
Robert Phillips | d21b2a5 | 2017-12-12 13:01:25 -0500 | [diff] [blame] | 686 | return nullptr; |
| 687 | } |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 688 | surf->getCanvas()->clear(color); |
| 689 | return surf; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 690 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 691 | |
Stephen White | fdba6c8 | 2020-05-26 17:00:32 -0400 | [diff] [blame] | 692 | static bool supports_readpixels(const GrCaps* caps, SkSurface* surface) { |
| 693 | auto surfaceGpu = static_cast<SkSurface_Gpu*>(surface); |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 694 | GrSurfaceDrawContext* context = surfaceGpu->getDevice()->surfaceDrawContext(); |
Stephen White | fdba6c8 | 2020-05-26 17:00:32 -0400 | [diff] [blame] | 695 | GrRenderTarget* rt = context->accessRenderTarget(); |
| 696 | if (!rt) { |
| 697 | return false; |
| 698 | } |
| 699 | return caps->surfaceSupportsReadPixels(rt) == GrCaps::SurfaceReadPixelsSupport::kSupported; |
| 700 | } |
| 701 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 702 | static sk_sp<SkSurface> create_gpu_surface_backend_render_target(GrDirectContext* dContext, |
| 703 | int sampleCnt, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 704 | const SkColor4f& color) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 705 | const int kWidth = 10; |
| 706 | const int kHeight = 10; |
Greg Daniel | 7ef28f3 | 2017-04-20 16:41:55 +0000 | [diff] [blame] | 707 | |
Brian Salomon | f9b0042 | 2020-10-08 16:00:14 -0400 | [diff] [blame] | 708 | auto surf = sk_gpu_test::MakeBackendRenderTargetSurface(dContext, |
| 709 | {kWidth, kHeight}, |
| 710 | kTopLeft_GrSurfaceOrigin, |
| 711 | sampleCnt, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 712 | kRGBA_8888_SkColorType); |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 713 | if (!surf) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 714 | return nullptr; |
| 715 | } |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 716 | surf->getCanvas()->clear(color); |
| 717 | return surf; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 718 | } |
| 719 | |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 720 | static void test_surface_context_clear(skiatest::Reporter* reporter, |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 721 | GrDirectContext* dContext, |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 722 | GrSurfaceContext* surfaceContext, uint32_t expectedValue) { |
| 723 | int w = surfaceContext->width(); |
| 724 | int h = surfaceContext->height(); |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 725 | |
| 726 | SkImageInfo ii = SkImageInfo::Make(w, h, kRGBA_8888_SkColorType, kPremul_SkAlphaType); |
| 727 | |
| 728 | SkAutoPixmapStorage readback; |
| 729 | readback.alloc(ii); |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 730 | |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 731 | readback.erase(~expectedValue); |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 732 | surfaceContext->readPixels(dContext, readback.info(), readback.writable_addr(), |
| 733 | readback.rowBytes(), {0, 0}); |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 734 | for (int y = 0; y < h; ++y) { |
| 735 | for (int x = 0; x < w; ++x) { |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 736 | uint32_t pixel = readback.addr32()[y * w + x]; |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 737 | if (pixel != expectedValue) { |
| 738 | SkString msg; |
| 739 | if (expectedValue) { |
| 740 | msg = "SkSurface should have left render target unmodified"; |
| 741 | } else { |
| 742 | msg = "SkSurface should have cleared the render target"; |
| 743 | } |
| 744 | ERRORF(reporter, |
| 745 | "%s but read 0x%08x (instead of 0x%08x) at %x,%d", msg.c_str(), pixel, |
| 746 | expectedValue, x, y); |
| 747 | return; |
| 748 | } |
| 749 | } |
| 750 | } |
| 751 | } |
| 752 | |
bsalomon | 758586c | 2016-04-06 14:02:39 -0700 | [diff] [blame] | 753 | DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceClear_Gpu, reporter, ctxInfo) { |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 754 | auto dContext = ctxInfo.directContext(); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 755 | // Snaps an image from a surface and then makes a GrSurfaceContext from the image's texture. |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 756 | auto makeImageSurfaceContext = [dContext](SkSurface* surface) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 757 | sk_sp<SkImage> i(surface->makeImageSnapshot()); |
| 758 | SkImage_Gpu* gpuImage = (SkImage_Gpu*)as_IB(i); |
Brian Salomon | 14f99fc | 2020-12-07 12:19:47 -0500 | [diff] [blame] | 759 | return GrSurfaceContext::Make(dContext, |
| 760 | *gpuImage->view(dContext), |
| 761 | i->imageInfo().colorInfo()); |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 762 | }; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 763 | |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 764 | // Test that non-wrapped RTs are created clear. |
| 765 | for (auto& surface_func : {&create_gpu_surface, &create_gpu_scratch_surface}) { |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 766 | auto surface = surface_func(dContext, kPremul_SkAlphaType, nullptr); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 767 | if (!surface) { |
| 768 | ERRORF(reporter, "Could not create GPU SkSurface."); |
| 769 | return; |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 770 | } |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 771 | auto sdc = SkCanvasPriv::TopDeviceSurfaceDrawContext(surface->getCanvas()); |
| 772 | if (!sdc) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 773 | ERRORF(reporter, "Could access surface context of GPU SkSurface."); |
| 774 | return; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 775 | } |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 776 | test_surface_context_clear(reporter, dContext, sdc, 0x0); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 777 | auto imageSurfaceCtx = makeImageSurfaceContext(surface.get()); |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 778 | test_surface_context_clear(reporter, dContext, imageSurfaceCtx.get(), 0x0); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 779 | } |
| 780 | |
| 781 | // Wrapped RTs are *not* supposed to clear (to allow client to partially update a surface). |
| 782 | const SkColor4f kOrigColor{.67f, .67f, .67f, 1}; |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 783 | for (auto& surfaceFunc : |
| 784 | {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_render_target}) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 785 | auto surface = surfaceFunc(dContext, 1, kOrigColor); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 786 | if (!surface) { |
| 787 | ERRORF(reporter, "Could not create GPU SkSurface."); |
| 788 | return; |
| 789 | } |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 790 | auto sdc = SkCanvasPriv::TopDeviceSurfaceDrawContext(surface->getCanvas()); |
| 791 | if (!sdc) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 792 | ERRORF(reporter, "Could access surface context of GPU SkSurface."); |
| 793 | return; |
| 794 | } |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 795 | test_surface_context_clear(reporter, dContext, sdc, kOrigColor.toSkColor()); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 796 | auto imageSurfaceCtx = makeImageSurfaceContext(surface.get()); |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 797 | test_surface_context_clear(reporter, dContext, imageSurfaceCtx.get(), |
| 798 | kOrigColor.toSkColor()); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 799 | } |
| 800 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 801 | |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 802 | static void test_surface_draw_partially( |
Robert Phillips | 6694440 | 2019-09-30 13:21:25 -0400 | [diff] [blame] | 803 | skiatest::Reporter* reporter, sk_sp<SkSurface> surface, SkColor origColor) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 804 | const int kW = surface->width(); |
| 805 | const int kH = surface->height(); |
| 806 | SkPaint paint; |
| 807 | const SkColor kRectColor = ~origColor | 0xFF000000; |
| 808 | paint.setColor(kRectColor); |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 809 | surface->getCanvas()->drawRect(SkRect::MakeIWH(kW, kH/2), paint); |
| 810 | |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 811 | // Read back RGBA to avoid format conversions that may not be supported on all platforms. |
| 812 | SkImageInfo readInfo = SkImageInfo::Make(kW, kH, kRGBA_8888_SkColorType, kPremul_SkAlphaType); |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 813 | |
| 814 | SkAutoPixmapStorage readback; |
| 815 | readback.alloc(readInfo); |
| 816 | |
| 817 | readback.erase(~origColor); |
Stephen White | dbb3e1d | 2020-05-13 17:55:18 -0400 | [diff] [blame] | 818 | REPORTER_ASSERT(reporter, surface->readPixels(readback.info(), readback.writable_addr(), |
| 819 | readback.rowBytes(), 0, 0)); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 820 | bool stop = false; |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 821 | |
Robert Phillips | 6694440 | 2019-09-30 13:21:25 -0400 | [diff] [blame] | 822 | SkPMColor origColorPM = SkPackARGB_as_RGBA(SkColorGetA(origColor), |
| 823 | SkColorGetR(origColor), |
| 824 | SkColorGetG(origColor), |
| 825 | SkColorGetB(origColor)); |
| 826 | SkPMColor rectColorPM = SkPackARGB_as_RGBA(SkColorGetA(kRectColor), |
| 827 | SkColorGetR(kRectColor), |
| 828 | SkColorGetG(kRectColor), |
| 829 | SkColorGetB(kRectColor)); |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 830 | |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 831 | for (int y = 0; y < kH/2 && !stop; ++y) { |
| 832 | for (int x = 0; x < kW && !stop; ++x) { |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 833 | REPORTER_ASSERT(reporter, rectColorPM == readback.addr32()[x + y * kW]); |
| 834 | if (rectColorPM != readback.addr32()[x + y * kW]) { |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 835 | SkDebugf("--- got [%x] expected [%x], x = %d, y = %d\n", |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 836 | readback.addr32()[x + y * kW], rectColorPM, x, y); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 837 | stop = true; |
| 838 | } |
| 839 | } |
| 840 | } |
| 841 | stop = false; |
| 842 | for (int y = kH/2; y < kH && !stop; ++y) { |
| 843 | for (int x = 0; x < kW && !stop; ++x) { |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 844 | REPORTER_ASSERT(reporter, origColorPM == readback.addr32()[x + y * kW]); |
| 845 | if (origColorPM != readback.addr32()[x + y * kW]) { |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 846 | SkDebugf("--- got [%x] expected [%x], x = %d, y = %d\n", |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 847 | readback.addr32()[x + y * kW], origColorPM, x, y); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 848 | stop = true; |
| 849 | } |
| 850 | } |
| 851 | } |
| 852 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 853 | |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 854 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfacePartialDraw_Gpu, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 855 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 856 | |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 857 | static const SkColor4f kOrigColor { 0.667f, 0.733f, 0.8f, 1 }; |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 858 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 859 | for (auto& surfaceFunc : |
| 860 | {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_render_target}) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 861 | // Validate that we can draw to the canvas and that the original texture color is |
| 862 | // preserved in pixels that aren't rendered to via the surface. |
| 863 | // This works only for non-multisampled case. |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 864 | auto surface = surfaceFunc(context, 1, kOrigColor); |
| 865 | if (surface && supports_readpixels(context->priv().caps(), surface.get())) { |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 866 | test_surface_draw_partially(reporter, surface, kOrigColor.toSkColor()); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 867 | } |
| 868 | } |
| 869 | } |
| 870 | |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 871 | struct ReleaseChecker { |
| 872 | ReleaseChecker() : fReleaseCount(0) {} |
| 873 | int fReleaseCount; |
| 874 | static void Release(void* self) { |
| 875 | static_cast<ReleaseChecker*>(self)->fReleaseCount++; |
| 876 | } |
| 877 | }; |
| 878 | |
| 879 | |
| 880 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceWrappedWithRelease_Gpu, reporter, ctxInfo) { |
| 881 | const int kWidth = 10; |
| 882 | const int kHeight = 10; |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 883 | |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 884 | auto ctx = ctxInfo.directContext(); |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 885 | GrGpu* gpu = ctx->priv().getGpu(); |
| 886 | |
| 887 | for (bool useTexture : {false, true}) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 888 | sk_sp<sk_gpu_test::ManagedBackendTexture> mbet; |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 889 | GrBackendRenderTarget backendRT; |
| 890 | sk_sp<SkSurface> surface; |
| 891 | |
| 892 | ReleaseChecker releaseChecker; |
| 893 | GrSurfaceOrigin texOrigin = kBottomLeft_GrSurfaceOrigin; |
| 894 | |
| 895 | if (useTexture) { |
Robert Phillips | ee5fd13 | 2019-05-07 13:29:22 -0400 | [diff] [blame] | 896 | SkImageInfo ii = SkImageInfo::Make(kWidth, kHeight, SkColorType::kRGBA_8888_SkColorType, |
| 897 | kPremul_SkAlphaType); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 898 | mbet = sk_gpu_test::ManagedBackendTexture::MakeFromInfo(ctx, ii, GrMipMapped::kNo, |
| 899 | GrRenderable::kYes); |
| 900 | if (!mbet) { |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 901 | continue; |
| 902 | } |
| 903 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 904 | surface = SkSurface::MakeFromBackendTexture( |
| 905 | ctx, |
| 906 | mbet->texture(), |
| 907 | texOrigin, |
| 908 | /*sample count*/ 1, |
| 909 | kRGBA_8888_SkColorType, |
| 910 | /*color space*/ nullptr, |
| 911 | /*surface props*/ nullptr, |
| 912 | sk_gpu_test::ManagedBackendTexture::ReleaseProc, |
| 913 | mbet->releaseContext(ReleaseChecker::Release, &releaseChecker)); |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 914 | } else { |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 915 | backendRT = gpu->createTestingOnlyBackendRenderTarget({kWidth, kHeight}, |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 916 | GrColorType::kRGBA_8888); |
| 917 | if (!backendRT.isValid()) { |
| 918 | continue; |
| 919 | } |
| 920 | surface = SkSurface::MakeFromBackendRenderTarget(ctx, backendRT, texOrigin, |
| 921 | kRGBA_8888_SkColorType, |
| 922 | nullptr, nullptr, |
| 923 | ReleaseChecker::Release, |
| 924 | &releaseChecker); |
| 925 | } |
| 926 | if (!surface) { |
| 927 | ERRORF(reporter, "Failed to create surface"); |
| 928 | continue; |
| 929 | } |
| 930 | |
| 931 | surface->getCanvas()->clear(SK_ColorRED); |
Greg Daniel | ce9f016 | 2020-06-30 13:42:46 -0400 | [diff] [blame] | 932 | surface->flush(); |
Greg Daniel | 0a2464f | 2020-05-14 15:45:44 -0400 | [diff] [blame] | 933 | ctx->submit(true); |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 934 | |
| 935 | // Now exercise the release proc |
| 936 | REPORTER_ASSERT(reporter, 0 == releaseChecker.fReleaseCount); |
| 937 | surface.reset(nullptr); // force a release of the surface |
| 938 | REPORTER_ASSERT(reporter, 1 == releaseChecker.fReleaseCount); |
| 939 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 940 | if (!useTexture) { |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 941 | gpu->deleteTestingOnlyBackendRenderTarget(backendRT); |
| 942 | } |
| 943 | } |
| 944 | } |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 945 | |
| 946 | DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceAttachStencil_Gpu, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 947 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 948 | const GrCaps* caps = context->priv().caps(); |
| 949 | |
| 950 | if (caps->avoidStencilBuffers()) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 951 | return; |
| 952 | } |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 953 | |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 954 | static const SkColor4f kOrigColor { 0.667f, 0.733f, 0.8f, 1 }; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 955 | |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 956 | auto resourceProvider = context->priv().resourceProvider(); |
Robert Phillips | 6be756b | 2018-01-16 15:07:54 -0500 | [diff] [blame] | 957 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 958 | for (auto& surfaceFunc : |
| 959 | {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_render_target}) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 960 | for (int sampleCnt : {1, 4, 8}) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 961 | auto surface = surfaceFunc(context, sampleCnt, kOrigColor); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 962 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 963 | if (!surface && sampleCnt > 1) { |
Robert Phillips | d21b2a5 | 2017-12-12 13:01:25 -0500 | [diff] [blame] | 964 | // Certain platforms don't support MSAA, skip these. |
| 965 | continue; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 966 | } |
| 967 | |
| 968 | // Validate that we can attach a stencil buffer to an SkSurface created by either of |
| 969 | // our surface functions. |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame^] | 970 | auto sdc = SkCanvasPriv::TopDeviceSurfaceDrawContext(surface->getCanvas()); |
| 971 | GrRenderTarget* rt = sdc->accessRenderTarget(); |
Chris Dalton | effee20 | 2019-07-01 22:28:03 -0600 | [diff] [blame] | 972 | REPORTER_ASSERT(reporter, resourceProvider->attachStencilAttachment(rt, sampleCnt)); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 973 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 974 | } |
| 975 | } |
brianosman | 0e22eb8 | 2016-08-30 07:07:59 -0700 | [diff] [blame] | 976 | |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 977 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(ReplaceSurfaceBackendTexture, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 978 | auto context = ctxInfo.directContext(); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 979 | |
| 980 | for (int sampleCnt : {1, 2}) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 981 | auto ii = SkImageInfo::Make(10, 10, kRGBA_8888_SkColorType, kPremul_SkAlphaType, nullptr); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 982 | auto mbet1 = sk_gpu_test::ManagedBackendTexture::MakeFromInfo( |
| 983 | context, ii, GrMipmapped::kNo, GrRenderable::kYes); |
| 984 | if (!mbet1) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 985 | continue; |
| 986 | } |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 987 | auto mbet2 = sk_gpu_test::ManagedBackendTexture::MakeFromInfo( |
| 988 | context, ii, GrMipmapped::kNo, GrRenderable::kYes); |
| 989 | if (!mbet2) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 990 | ERRORF(reporter, "Expected to be able to make second texture"); |
| 991 | continue; |
| 992 | } |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 993 | auto ii2 = ii.makeWH(8, 8); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 994 | auto mbet3 = sk_gpu_test::ManagedBackendTexture::MakeFromInfo( |
| 995 | context, ii2, GrMipmapped::kNo, GrRenderable::kYes); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 996 | GrBackendTexture backendTexture3; |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 997 | if (!mbet3) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 998 | ERRORF(reporter, "Couldn't create different sized texture."); |
| 999 | continue; |
| 1000 | } |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1001 | |
| 1002 | auto surf = SkSurface::MakeFromBackendTexture( |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1003 | context, mbet1->texture(), kTopLeft_GrSurfaceOrigin, sampleCnt, |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1004 | kRGBA_8888_SkColorType, ii.refColorSpace(), nullptr); |
| 1005 | if (!surf) { |
| 1006 | continue; |
| 1007 | } |
| 1008 | surf->getCanvas()->clear(SK_ColorBLUE); |
| 1009 | // Change matrix, layer, and clip state before swapping out the backing texture. |
| 1010 | surf->getCanvas()->translate(5, 5); |
| 1011 | surf->getCanvas()->saveLayer(nullptr, nullptr); |
| 1012 | surf->getCanvas()->clipRect(SkRect::MakeXYWH(0, 0, 1, 1)); |
| 1013 | // switch origin while we're at it. |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1014 | bool replaced = surf->replaceBackendTexture(mbet2->texture(), kBottomLeft_GrSurfaceOrigin); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1015 | REPORTER_ASSERT(reporter, replaced); |
| 1016 | SkPaint paint; |
| 1017 | paint.setColor(SK_ColorRED); |
| 1018 | surf->getCanvas()->drawRect(SkRect::MakeWH(5, 5), paint); |
| 1019 | surf->getCanvas()->restore(); |
| 1020 | |
| 1021 | // Check that the replacement texture got the right color values. |
| 1022 | SkAutoPixmapStorage pm; |
| 1023 | pm.alloc(ii); |
| 1024 | bool bad = !surf->readPixels(pm, 0, 0); |
| 1025 | REPORTER_ASSERT(reporter, !bad, "Could not read surface."); |
| 1026 | for (int y = 0; y < ii.height() && !bad; ++y) { |
| 1027 | for (int x = 0; x < ii.width() && !bad; ++x) { |
| 1028 | auto expected = (x == 5 && y == 5) ? 0xFF0000FF : 0xFFFF0000; |
| 1029 | auto found = *pm.addr32(x, y); |
| 1030 | if (found != expected) { |
| 1031 | bad = true; |
| 1032 | ERRORF(reporter, "Expected color 0x%08x, found color 0x%08x at %d, %d.", |
| 1033 | expected, found, x, y); |
| 1034 | } |
| 1035 | } |
| 1036 | } |
| 1037 | // The original texture should still be all blue. |
| 1038 | surf = SkSurface::MakeFromBackendTexture( |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1039 | context, mbet1->texture(), kBottomLeft_GrSurfaceOrigin, sampleCnt, |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1040 | kRGBA_8888_SkColorType, ii.refColorSpace(), nullptr); |
| 1041 | if (!surf) { |
| 1042 | ERRORF(reporter, "Could not create second surface."); |
| 1043 | continue; |
| 1044 | } |
| 1045 | bad = !surf->readPixels(pm, 0, 0); |
| 1046 | REPORTER_ASSERT(reporter, !bad, "Could not read second surface."); |
| 1047 | for (int y = 0; y < ii.height() && !bad; ++y) { |
| 1048 | for (int x = 0; x < ii.width() && !bad; ++x) { |
| 1049 | auto expected = 0xFFFF0000; |
| 1050 | auto found = *pm.addr32(x, y); |
| 1051 | if (found != expected) { |
| 1052 | bad = true; |
| 1053 | ERRORF(reporter, "Expected color 0x%08x, found color 0x%08x at %d, %d.", |
| 1054 | expected, found, x, y); |
| 1055 | } |
| 1056 | } |
| 1057 | } |
| 1058 | |
| 1059 | // Can't replace with the same texture |
| 1060 | REPORTER_ASSERT(reporter, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1061 | !surf->replaceBackendTexture(mbet1->texture(), kTopLeft_GrSurfaceOrigin)); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1062 | // Can't replace with invalid texture |
| 1063 | REPORTER_ASSERT(reporter, !surf->replaceBackendTexture({}, kTopLeft_GrSurfaceOrigin)); |
| 1064 | // Can't replace with different size texture. |
| 1065 | REPORTER_ASSERT(reporter, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1066 | !surf->replaceBackendTexture(mbet3->texture(), kTopLeft_GrSurfaceOrigin)); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1067 | // Can't replace texture of non-wrapped SkSurface. |
| 1068 | surf = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, ii, sampleCnt, nullptr); |
| 1069 | REPORTER_ASSERT(reporter, surf); |
| 1070 | if (surf) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1071 | REPORTER_ASSERT(reporter, !surf->replaceBackendTexture(mbet1->texture(), |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1072 | kTopLeft_GrSurfaceOrigin)); |
| 1073 | } |
| 1074 | } |
| 1075 | } |
| 1076 | |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1077 | static void test_overdraw_surface(skiatest::Reporter* r, SkSurface* surface) { |
Matt Sarett | e11b614 | 2016-11-28 18:28:07 -0500 | [diff] [blame] | 1078 | SkOverdrawCanvas canvas(surface->getCanvas()); |
| 1079 | canvas.drawPaint(SkPaint()); |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1080 | sk_sp<SkImage> image = surface->makeImageSnapshot(); |
| 1081 | |
| 1082 | SkBitmap bitmap; |
Cary Clark | 4f5a79c | 2018-02-07 15:51:00 -0500 | [diff] [blame] | 1083 | image->asLegacyBitmap(&bitmap); |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1084 | for (int y = 0; y < 10; y++) { |
| 1085 | for (int x = 0; x < 10; x++) { |
| 1086 | REPORTER_ASSERT(r, 1 == SkGetPackedA32(*bitmap.getAddr32(x, y))); |
| 1087 | } |
| 1088 | } |
| 1089 | } |
| 1090 | |
| 1091 | DEF_TEST(OverdrawSurface_Raster, r) { |
| 1092 | sk_sp<SkSurface> surface = create_surface(); |
| 1093 | test_overdraw_surface(r, surface.get()); |
| 1094 | } |
| 1095 | |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1096 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(OverdrawSurface_Gpu, r, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 1097 | auto context = ctxInfo.directContext(); |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1098 | sk_sp<SkSurface> surface = create_gpu_surface(context); |
| 1099 | test_overdraw_surface(r, surface.get()); |
| 1100 | } |
Mike Reed | 44d04bd | 2017-06-28 19:57:21 -0400 | [diff] [blame] | 1101 | |
| 1102 | DEF_TEST(Surface_null, r) { |
| 1103 | REPORTER_ASSERT(r, SkSurface::MakeNull(0, 0) == nullptr); |
| 1104 | |
| 1105 | const int w = 37; |
| 1106 | const int h = 1000; |
| 1107 | auto surf = SkSurface::MakeNull(w, h); |
| 1108 | auto canvas = surf->getCanvas(); |
| 1109 | |
| 1110 | canvas->drawPaint(SkPaint()); // should not crash, but don't expect anything to draw |
| 1111 | REPORTER_ASSERT(r, surf->makeImageSnapshot() == nullptr); |
| 1112 | } |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1113 | |
| 1114 | // assert: if a given imageinfo is valid for a surface, then it must be valid for an image |
| 1115 | // (so the snapshot can succeed) |
| 1116 | DEF_TEST(surface_image_unity, reporter) { |
| 1117 | auto do_test = [reporter](const SkImageInfo& info) { |
| 1118 | size_t rowBytes = info.minRowBytes(); |
| 1119 | auto surf = SkSurface::MakeRaster(info, rowBytes, nullptr); |
| 1120 | if (surf) { |
| 1121 | auto img = surf->makeImageSnapshot(); |
| 1122 | if (!img && false) { // change to true to document the differences |
| 1123 | SkDebugf("image failed: [%08X %08X] %14s %s\n", |
Mike Klein | ea3f014 | 2019-03-20 11:12:10 -0500 | [diff] [blame] | 1124 | info.width(), |
| 1125 | info.height(), |
| 1126 | ToolUtils::colortype_name(info.colorType()), |
| 1127 | ToolUtils::alphatype_name(info.alphaType())); |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1128 | return; |
| 1129 | } |
| 1130 | REPORTER_ASSERT(reporter, img != nullptr); |
| 1131 | |
| 1132 | char dummyPixel = 0; // just need a valid address (not a valid size) |
| 1133 | SkPixmap pmap = { info, &dummyPixel, rowBytes }; |
| 1134 | img = SkImage::MakeFromRaster(pmap, nullptr, nullptr); |
| 1135 | REPORTER_ASSERT(reporter, img != nullptr); |
| 1136 | } |
| 1137 | }; |
| 1138 | |
Mike Klein | e978ca2 | 2018-10-29 11:29:58 -0400 | [diff] [blame] | 1139 | const int32_t sizes[] = { -1, 0, 1, 1 << 18 }; |
Mike Klein | 30dc8f9 | 2018-02-16 10:08:10 -0500 | [diff] [blame] | 1140 | for (int cti = 0; cti <= kLastEnum_SkColorType; ++cti) { |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1141 | SkColorType ct = static_cast<SkColorType>(cti); |
Mike Klein | 30dc8f9 | 2018-02-16 10:08:10 -0500 | [diff] [blame] | 1142 | for (int ati = 0; ati <= kLastEnum_SkAlphaType; ++ati) { |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1143 | SkAlphaType at = static_cast<SkAlphaType>(ati); |
| 1144 | for (int32_t size : sizes) { |
| 1145 | do_test(SkImageInfo::Make(1, size, ct, at)); |
| 1146 | do_test(SkImageInfo::Make(size, 1, ct, at)); |
| 1147 | } |
| 1148 | } |
| 1149 | } |
| 1150 | } |