blob: 580137db1630cba5d62e1fa468c9b2f4c32c3c8a [file] [log] [blame]
Fyodor Kupolov74876572015-02-23 17:14:45 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License
15 */
16
17package com.android.server.pm;
18
Patrick Baumannfc2851e2018-11-13 15:23:22 -080019import static android.content.pm.ApplicationInfo.HIDDEN_API_ENFORCEMENT_DISABLED;
20
21import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE;
22import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE;
23import static com.android.server.pm.Installer.DEXOPT_ENABLE_HIDDEN_API_CHECKS;
24import static com.android.server.pm.Installer.DEXOPT_FORCE;
25import static com.android.server.pm.Installer.DEXOPT_GENERATE_APP_IMAGE;
26import static com.android.server.pm.Installer.DEXOPT_GENERATE_COMPACT_DEX;
27import static com.android.server.pm.Installer.DEXOPT_IDLE_BACKGROUND_JOB;
28import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED;
29import static com.android.server.pm.Installer.DEXOPT_PUBLIC;
30import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX;
31import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE;
32import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE;
33import static com.android.server.pm.InstructionSets.getAppDexInstructionSets;
34import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets;
35import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT;
36import static com.android.server.pm.PackageManagerServiceCompilerMapping.getReasonName;
37
38import static dalvik.system.DexFile.getSafeModeCompilerFilter;
39import static dalvik.system.DexFile.isProfileGuidedCompilerFilter;
40
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080041import android.annotation.Nullable;
Fyodor Kupolova627c092015-05-05 18:44:39 -070042import android.content.Context;
Fyodor Kupolov74876572015-02-23 17:14:45 -080043import android.content.pm.ApplicationInfo;
44import android.content.pm.PackageParser;
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +000045import android.content.pm.SharedLibraryInfo;
Calin Juravle6ae39fc2018-01-19 20:32:47 -080046import android.content.pm.dex.ArtManager;
Calin Juravlecc651942018-02-01 17:20:51 +000047import android.content.pm.dex.DexMetadataHelper;
Calin Juravleadbadd52017-03-28 18:19:15 -070048import android.os.FileUtils;
Fyodor Kupolova627c092015-05-05 18:44:39 -070049import android.os.PowerManager;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070050import android.os.SystemClock;
Nicolas Geoffray20a894e2017-09-08 13:01:40 +010051import android.os.SystemProperties;
Fyodor Kupolov74876572015-02-23 17:14:45 -080052import android.os.UserHandle;
Fyodor Kupolova627c092015-05-05 18:44:39 -070053import android.os.WorkSource;
Fyodor Kupolov74876572015-02-23 17:14:45 -080054import android.util.Log;
55import android.util.Slog;
56
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080057import com.android.internal.annotations.GuardedBy;
Narayan Kamath88eea9e2016-05-02 14:44:31 +010058import com.android.internal.util.IndentingPrintWriter;
Jeff Sharkey740f5232016-12-09 14:31:26 -070059import com.android.server.pm.Installer.InstallerException;
Calin Juravle0610dd12018-07-20 15:51:17 -070060import com.android.server.pm.dex.ArtManagerService;
Victor Hsieh785d6182018-04-19 14:26:28 -070061import com.android.server.pm.dex.DexManager;
Calin Juravle1d0e83d2017-07-17 15:12:01 -070062import com.android.server.pm.dex.DexoptOptions;
Calin Juravle19da1cf2017-07-12 18:52:49 -070063import com.android.server.pm.dex.DexoptUtils;
Calin Juravlef1ff36f2017-07-22 12:33:41 -070064import com.android.server.pm.dex.PackageDexUsage;
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -070065
Patrick Baumannfc2851e2018-11-13 15:23:22 -080066import dalvik.system.DexFile;
67
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080068import java.io.File;
Fyodor Kupolov74876572015-02-23 17:14:45 -080069import java.io.IOException;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080070import java.util.ArrayList;
Calin Juravle4c2b9552017-08-10 17:23:00 -070071import java.util.Arrays;
Fyodor Kupolov74876572015-02-23 17:14:45 -080072import java.util.List;
Calin Juravle41a57a62017-08-06 19:20:19 -070073import java.util.Map;
Fyodor Kupolov74876572015-02-23 17:14:45 -080074
Fyodor Kupolov74876572015-02-23 17:14:45 -080075/**
76 * Helper class for running dexopt command on packages.
77 */
Calin Juravlec22c30e2017-01-16 19:18:48 -080078public class PackageDexOptimizer {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080079 private static final String TAG = "PackageManager.DexOptimizer";
80 static final String OAT_DIR_NAME = "oat";
81 // TODO b/19550105 Remove error codes and use exceptions
Calin Juravlec22c30e2017-01-16 19:18:48 -080082 public static final int DEX_OPT_SKIPPED = 0;
83 public static final int DEX_OPT_PERFORMED = 1;
84 public static final int DEX_OPT_FAILED = -1;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070085 // One minute over PM WATCHDOG_TIMEOUT
86 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60;
Fyodor Kupolov74876572015-02-23 17:14:45 -080087
Fyodor Kupolov28f28552017-05-02 12:11:02 -070088 @GuardedBy("mInstallLock")
Andreas Gampea8908752015-11-10 08:58:14 -080089 private final Installer mInstaller;
90 private final Object mInstallLock;
Fyodor Kupolov74876572015-02-23 17:14:45 -080091
Fyodor Kupolov28f28552017-05-02 12:11:02 -070092 @GuardedBy("mInstallLock")
Fyodor Kupolova627c092015-05-05 18:44:39 -070093 private final PowerManager.WakeLock mDexoptWakeLock;
94 private volatile boolean mSystemReady;
95
Andreas Gampea8908752015-11-10 08:58:14 -080096 PackageDexOptimizer(Installer installer, Object installLock, Context context,
97 String wakeLockTag) {
98 this.mInstaller = installer;
99 this.mInstallLock = installLock;
100
101 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE);
102 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag);
103 }
104
105 protected PackageDexOptimizer(PackageDexOptimizer from) {
106 this.mInstaller = from.mInstaller;
107 this.mInstallLock = from.mInstallLock;
108 this.mDexoptWakeLock = from.mDexoptWakeLock;
109 this.mSystemReady = from.mSystemReady;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800110 }
111
Calin Juravledb4a79a2015-12-23 18:55:08 +0200112 static boolean canOptimizePackage(PackageParser.Package pkg) {
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100113 // We do not dexopt a package with no code.
114 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) {
115 return false;
116 }
117
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100118 return true;
Calin Juravledb4a79a2015-12-23 18:55:08 +0200119 }
120
Fyodor Kupolov74876572015-02-23 17:14:45 -0800121 /**
122 * Performs dexopt on all code paths and libraries of the specified package for specified
123 * instruction sets.
124 *
Andreas Gampea8908752015-11-10 08:58:14 -0800125 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are
126 * synchronized on {@link #mInstallLock}.
Fyodor Kupolov74876572015-02-23 17:14:45 -0800127 */
Nicolas Geoffray1158b872019-02-26 21:40:59 +0000128 int performDexOpt(PackageParser.Package pkg,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700129 String[] instructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700130 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800131 if (pkg.applicationInfo.uid == -1) {
132 throw new IllegalArgumentException("Dexopt for " + pkg.packageName
133 + " has invalid uid.");
134 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800135 if (!canOptimizePackage(pkg)) {
136 return DEX_OPT_SKIPPED;
137 }
Andreas Gampea8908752015-11-10 08:58:14 -0800138 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700139 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700140 try {
Nicolas Geoffray1158b872019-02-26 21:40:59 +0000141 return performDexOptLI(pkg, instructionSets,
Calin Juravle3b74c412017-08-03 19:48:37 -0700142 packageStats, packageUseInfo, options);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700143 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700144 releaseWakeLockLI(acquireTime);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700145 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800146 }
147 }
148
Andreas Gampea8908752015-11-10 08:58:14 -0800149 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800150 * Performs dexopt on all code paths of the given package.
151 * It assumes the install lock is held.
152 */
153 @GuardedBy("mInstallLock")
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +0000154 private int performDexOptLI(PackageParser.Package pkg,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700155 String[] targetInstructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700156 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Nicolas Geoffray1158b872019-02-26 21:40:59 +0000157 final List<SharedLibraryInfo> sharedLibraries = pkg.usesLibraryInfos;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800158 final String[] instructionSets = targetInstructionSets != null ?
159 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo);
160 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
Jeff Hao5def5e52017-04-19 14:42:16 -0700161 final List<String> paths = pkg.getAllCodePaths();
Jeff Sharkeya73e1652017-11-15 19:07:14 -0700162
163 int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid);
164 if (sharedGid == -1) {
165 Slog.wtf(TAG, "Well this is awkward; package " + pkg.applicationInfo.name + " had UID "
166 + pkg.applicationInfo.uid, new Throwable());
167 sharedGid = android.os.Process.NOBODY_UID;
168 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800169
Calin Juravle19da1cf2017-07-12 18:52:49 -0700170 // Get the class loader context dependencies.
171 // For each code path in the package, this array contains the class loader context that
172 // needs to be passed to dexopt in order to ensure correct optimizations.
Calin Juravleda098152017-09-01 17:30:01 -0700173 boolean[] pathsWithCode = new boolean[paths.size()];
174 pathsWithCode[0] = (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) != 0;
175 for (int i = 1; i < paths.size(); i++) {
176 pathsWithCode[i] = (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) != 0;
177 }
Calin Juravle19da1cf2017-07-12 18:52:49 -0700178 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts(
Calin Juravleda098152017-09-01 17:30:01 -0700179 pkg.applicationInfo, sharedLibraries, pathsWithCode);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800180
Calin Juravle4c2b9552017-08-10 17:23:00 -0700181 // Sanity check that we do not call dexopt with inconsistent data.
182 if (paths.size() != classLoaderContexts.length) {
183 String[] splitCodePaths = pkg.applicationInfo.getSplitCodePaths();
184 throw new IllegalStateException("Inconsistent information "
185 + "between PackageParser.Package and its ApplicationInfo. "
186 + "pkg.getAllCodePaths=" + paths
187 + " pkg.applicationInfo.getBaseCodePath=" + pkg.applicationInfo.getBaseCodePath()
188 + " pkg.applicationInfo.getSplitCodePaths="
189 + (splitCodePaths == null ? "null" : Arrays.toString(splitCodePaths)));
190 }
191
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800192 int result = DEX_OPT_SKIPPED;
Jeff Hao5def5e52017-04-19 14:42:16 -0700193 for (int i = 0; i < paths.size(); i++) {
194 // Skip paths that have no code.
Calin Juravleda098152017-09-01 17:30:01 -0700195 if (!pathsWithCode[i]) {
Jeff Hao5def5e52017-04-19 14:42:16 -0700196 continue;
197 }
Calin Juravleda098152017-09-01 17:30:01 -0700198 if (classLoaderContexts[i] == null) {
199 throw new IllegalStateException("Inconsistent information in the "
200 + "package structure. A split is marked to contain code "
201 + "but has no dependency listed. Index=" + i + " path=" + paths.get(i));
202 }
203
Jeff Hao5def5e52017-04-19 14:42:16 -0700204 // Append shared libraries with split dependencies for this split.
205 String path = paths.get(i);
Calin Juravleb6f844d2017-07-17 15:23:21 -0700206 if (options.getSplitName() != null) {
207 // We are asked to compile only a specific split. Check that the current path is
208 // what we are looking for.
209 if (!options.getSplitName().equals(new File(path).getName())) {
210 continue;
211 }
212 }
213
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800214 String profileName = ArtManager.getProfileName(i == 0 ? null : pkg.splitNames[i - 1]);
215
Calin Juravlecc651942018-02-01 17:20:51 +0000216 String dexMetadataPath = null;
217 if (options.isDexoptInstallWithDexMetadata()) {
218 File dexMetadataFile = DexMetadataHelper.findDexMetadataForFile(new File(path));
219 dexMetadataPath = dexMetadataFile == null
220 ? null : dexMetadataFile.getAbsolutePath();
221 }
222
Calin Juravle3b74c412017-08-03 19:48:37 -0700223 final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary()
Calin Juravle52a452c2017-08-04 01:42:17 -0700224 || packageUseInfo.isUsedByOtherApps(path);
Calin Juravle3b74c412017-08-03 19:48:37 -0700225 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo,
226 options.getCompilerFilter(), isUsedByOtherApps);
227 final boolean profileUpdated = options.isCheckForProfileUpdates() &&
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800228 isProfileUpdated(pkg, sharedGid, profileName, compilerFilter);
Calin Juravle3b74c412017-08-03 19:48:37 -0700229
230 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct
231 // flags.
Andreas Gampec041c332017-11-01 17:05:53 -0700232 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options);
Calin Juravle3b74c412017-08-03 19:48:37 -0700233
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800234 for (String dexCodeIsa : dexCodeInstructionSets) {
Calin Juravle19da1cf2017-07-12 18:52:49 -0700235 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter,
236 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800237 packageStats, options.isDowngrade(), profileName, dexMetadataPath,
238 options.getCompilationReason());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800239 // The end result is:
240 // - FAILED if any path failed,
241 // - PERFORMED if at least one path needed compilation,
242 // - SKIPPED when all paths are up to date
243 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) {
244 result = newResult;
245 }
246 }
247 }
248 return result;
249 }
250
251 /**
252 * Performs dexopt on the {@code path} belonging to the package {@code pkg}.
253 *
254 * @return
255 * DEX_OPT_FAILED if there was any exception during dexopt
256 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
257 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed.
258 */
259 @GuardedBy("mInstallLock")
260 private int dexOptPath(PackageParser.Package pkg, String path, String isa,
Calin Juravle576e6c02017-09-12 00:58:33 -0700261 String compilerFilter, boolean profileUpdated, String classLoaderContext,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800262 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800263 String profileName, String dexMetadataPath, int compilationReason) {
Calin Juravle576e6c02017-09-12 00:58:33 -0700264 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext,
265 profileUpdated, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800266 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) {
267 return DEX_OPT_SKIPPED;
268 }
269
270 // TODO(calin): there's no need to try to create the oat dir over and over again,
271 // especially since it involve an extra installd call. We should create
272 // if (if supported) on the fly during the dexopt call.
273 String oatDir = createOatDirIfSupported(pkg, isa);
274
275 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path
276 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa
277 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
Calin Juravle576e6c02017-09-12 00:58:33 -0700278 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir
279 + " classLoaderContext=" + classLoaderContext);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800280
281 try {
282 long startTime = System.currentTimeMillis();
283
Shubham Ajmera246dccf2017-05-24 17:46:36 -0700284 // TODO: Consider adding 2 different APIs for primary and secondary dexopt.
285 // installd only uses downgrade flag for secondary dex files and ignores it for
286 // primary dex files.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800287 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags,
Calin Juravle576e6c02017-09-12 00:58:33 -0700288 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800289 false /* downgrade*/, pkg.applicationInfo.targetSdkVersion,
Calin Juravle0610dd12018-07-20 15:51:17 -0700290 profileName, dexMetadataPath,
291 getAugmentedReasonName(compilationReason, dexMetadataPath != null));
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800292
293 if (packageStats != null) {
294 long endTime = System.currentTimeMillis();
295 packageStats.setCompileTime(path, (int)(endTime - startTime));
296 }
297 return DEX_OPT_PERFORMED;
298 } catch (InstallerException e) {
299 Slog.w(TAG, "Failed to dexopt", e);
300 return DEX_OPT_FAILED;
301 }
302 }
303
Calin Juravle0610dd12018-07-20 15:51:17 -0700304 private String getAugmentedReasonName(int compilationReason, boolean useDexMetadata) {
305 String annotation = useDexMetadata
306 ? ArtManagerService.DEXOPT_REASON_WITH_DEX_METADATA_ANNOTATION : "";
307 return getReasonName(compilationReason) + annotation;
308 }
309
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800310 /**
Calin Juravlec22c30e2017-01-16 19:18:48 -0800311 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}.
312 *
313 * @return
314 * DEX_OPT_FAILED if there was any exception during dexopt
315 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
316 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file
317 * didn't need an update. That's because at the moment we don't get more than success/failure
318 * from installd.
319 *
320 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than
321 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though
322 * that seems wasteful.
323 */
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700324 public int dexOptSecondaryDexPath(ApplicationInfo info, String path,
325 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800326 if (info.uid == -1) {
327 throw new IllegalArgumentException("Dexopt for path " + path + " has invalid uid.");
328 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800329 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700330 final long acquireTime = acquireWakeLockLI(info.uid);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800331 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700332 return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800333 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700334 releaseWakeLockLI(acquireTime);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800335 }
336 }
337 }
338
339 @GuardedBy("mInstallLock")
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700340 private long acquireWakeLockLI(final int uid) {
341 // During boot the system doesn't need to instantiate and obtain a wake lock.
342 // PowerManager might not be ready, but that doesn't mean that we can't proceed with
343 // dexopt.
344 if (!mSystemReady) {
345 return -1;
346 }
347 mDexoptWakeLock.setWorkSource(new WorkSource(uid));
348 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS);
349 return SystemClock.elapsedRealtime();
350 }
351
352 @GuardedBy("mInstallLock")
353 private void releaseWakeLockLI(final long acquireTime) {
354 if (acquireTime < 0) {
355 return;
356 }
357 try {
358 if (mDexoptWakeLock.isHeld()) {
359 mDexoptWakeLock.release();
360 }
361 final long duration = SystemClock.elapsedRealtime() - acquireTime;
362 if (duration >= WAKELOCK_TIMEOUT_MS) {
363 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag()
364 + " time out. Operation took " + duration + " ms. Thread: "
365 + Thread.currentThread().getName());
366 }
367 } catch (Exception e) {
368 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e);
369 }
370 }
371
372 @GuardedBy("mInstallLock")
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700373 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path,
374 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
375 if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) {
376 // We are asked to optimize only the dex files used by other apps and this is not
377 // on of them: skip it.
378 return DEX_OPT_SKIPPED;
379 }
380
381 String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(),
382 dexUseInfo.isUsedByOtherApps());
Calin Juravleefb1c942017-04-04 20:31:44 -0700383 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags.
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100384 // Secondary dex files are currently not compiled at boot.
Andreas Gampec041c332017-11-01 17:05:53 -0700385 int dexoptFlags = getDexFlags(info, compilerFilter, options) | DEXOPT_SECONDARY_DEX;
Calin Juravlec22c30e2017-01-16 19:18:48 -0800386 // Check the app storage and add the appropriate flags.
Calin Juravleadbadd52017-03-28 18:19:15 -0700387 if (info.deviceProtectedDataDir != null &&
388 FileUtils.contains(info.deviceProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800389 dexoptFlags |= DEXOPT_STORAGE_DE;
Calin Juravleadbadd52017-03-28 18:19:15 -0700390 } else if (info.credentialProtectedDataDir != null &&
391 FileUtils.contains(info.credentialProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800392 dexoptFlags |= DEXOPT_STORAGE_CE;
393 } else {
394 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName);
395 return DEX_OPT_FAILED;
396 }
Nicolas Geoffray03dba3b2018-12-20 09:47:00 +0000397 String classLoaderContext = null;
David Brazdil22217f62018-12-18 13:43:55 +0000398 if (dexUseInfo.isUnknownClassLoaderContext() || dexUseInfo.isVariableClassLoaderContext()) {
Nicolas Geoffray03dba3b2018-12-20 09:47:00 +0000399 // If we have an unknown (not yet set), or a variable class loader chain. Just extract
400 // the dex file.
401 compilerFilter = "extract";
David Brazdil22217f62018-12-18 13:43:55 +0000402 } else {
403 classLoaderContext = dexUseInfo.getClassLoaderContext();
404 }
405
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800406 int reason = options.getCompilationReason();
Nicolas Geoffray03dba3b2018-12-20 09:47:00 +0000407 Log.d(TAG, "Running dexopt on: " + path
408 + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas()
409 + " reason=" + getReasonName(reason)
410 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
411 + " target-filter=" + compilerFilter
412 + " class-loader-context=" + classLoaderContext);
413
Calin Juravlec22c30e2017-01-16 19:18:48 -0800414 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700415 for (String isa : dexUseInfo.getLoaderIsas()) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800416 // Reuse the same dexopt path as for the primary apks. We don't need all the
417 // arguments as some (dexopNeeded and oatDir) will be computed by installd because
418 // system server cannot read untrusted app content.
419 // TODO(calin): maybe add a separate call.
420 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0,
421 /*oatDir*/ null, dexoptFlags,
Nick Kralevich005f9592018-08-14 11:11:02 -0700422 compilerFilter, info.volumeUuid, classLoaderContext, info.seInfo,
Calin Juravlecc651942018-02-01 17:20:51 +0000423 options.isDowngrade(), info.targetSdkVersion, /*profileName*/ null,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800424 /*dexMetadataPath*/ null, getReasonName(reason));
Calin Juravlec22c30e2017-01-16 19:18:48 -0800425 }
426
427 return DEX_OPT_PERFORMED;
428 } catch (InstallerException e) {
429 Slog.w(TAG, "Failed to dexopt", e);
430 return DEX_OPT_FAILED;
431 }
432 }
433
434 /**
Andreas Gampea8908752015-11-10 08:58:14 -0800435 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to
436 * optimize or not (and in what way).
437 */
438 protected int adjustDexoptNeeded(int dexoptNeeded) {
439 return dexoptNeeded;
440 }
441
442 /**
443 * Adjust the given dexopt flags that will be passed to the installer.
444 */
445 protected int adjustDexoptFlags(int dexoptFlags) {
446 return dexoptFlags;
447 }
448
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100449 /**
450 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}.
451 */
Calin Juravle41a57a62017-08-06 19:20:19 -0700452 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg,
453 PackageDexUsage.PackageUseInfo useInfo) {
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100454 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo);
455 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
456
457 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly();
458
Calin Juravle41a57a62017-08-06 19:20:19 -0700459 for (String path : paths) {
460 pw.println("path: " + path);
461 pw.increaseIndent();
462
463 for (String isa : dexCodeInstructionSets) {
Calin Juravle41a57a62017-08-06 19:20:19 -0700464 try {
Calin Juravle7fc0f632018-03-30 12:38:59 -0700465 DexFile.OptimizationInfo info = DexFile.getDexFileOptimizationInfo(path, isa);
466 pw.println(isa + ": [status=" + info.getStatus()
467 +"] [reason=" + info.getReason() + "]");
Calin Juravle41a57a62017-08-06 19:20:19 -0700468 } catch (IOException ioe) {
Calin Juravleab49fc42018-03-28 19:00:18 -0700469 pw.println(isa + ": [Exception]: " + ioe.getMessage());
Calin Juravle41a57a62017-08-06 19:20:19 -0700470 }
Calin Juravle41a57a62017-08-06 19:20:19 -0700471 }
472
473 if (useInfo.isUsedByOtherApps(path)) {
Calin Juravle94837e32017-09-26 13:23:00 -0700474 pw.println("used by other apps: " + useInfo.getLoadingPackages(path));
Calin Juravle41a57a62017-08-06 19:20:19 -0700475 }
476
477 Map<String, PackageDexUsage.DexUseInfo> dexUseInfoMap = useInfo.getDexUseInfoMap();
478
479 if (!dexUseInfoMap.isEmpty()) {
480 pw.println("known secondary dex files:");
481 pw.increaseIndent();
482 for (Map.Entry<String, PackageDexUsage.DexUseInfo> e : dexUseInfoMap.entrySet()) {
483 String dex = e.getKey();
484 PackageDexUsage.DexUseInfo dexUseInfo = e.getValue();
485 pw.println(dex);
486 pw.increaseIndent();
Calin Juravlecf722222017-09-18 17:40:48 -0700487 // TODO(calin): get the status of the oat file (needs installd call)
Calin Juravle41a57a62017-08-06 19:20:19 -0700488 pw.println("class loader context: " + dexUseInfo.getClassLoaderContext());
489 if (dexUseInfo.isUsedByOtherApps()) {
Calin Juravle94837e32017-09-26 13:23:00 -0700490 pw.println("used by other apps: " + dexUseInfo.getLoadingPackages());
Calin Juravle41a57a62017-08-06 19:20:19 -0700491 }
492 pw.decreaseIndent();
493 }
494 pw.decreaseIndent();
495 }
496 pw.decreaseIndent();
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100497 }
498 }
499
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800500 /**
501 * Returns the compiler filter that should be used to optimize the package code.
502 * The target filter will be updated if the package code is used by other apps
503 * or if it has the safe mode flag set.
504 */
Calin Juravlec22c30e2017-01-16 19:18:48 -0800505 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter,
506 boolean isUsedByOtherApps) {
507 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800508 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0;
Victor Hsiehf12af2f2019-01-03 10:11:03 -0800509 // When an app or priv app is configured to run out of box, only verify it.
Victor Hsiehfa9df0b2019-01-29 12:48:36 -0800510 if (info.isEmbeddedDexUsed()
Victor Hsiehf12af2f2019-01-03 10:11:03 -0800511 || (info.isPrivilegedApp()
512 && DexManager.isPackageSelectedToRunOob(info.packageName))) {
Victor Hsieh785d6182018-04-19 14:26:28 -0700513 return "verify";
Nicolas Geoffray11d21a292018-01-24 14:07:14 +0000514 }
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700515 if (vmSafeMode) {
Nicolas Geoffrayd093b202017-05-03 13:11:58 +0100516 return getSafeModeCompilerFilter(targetCompilerFilter);
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700517 }
518
Calin Juravlec22c30e2017-01-16 19:18:48 -0800519 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) {
Calin Juravlef53201f2017-09-15 11:09:29 -0700520 // If the dex files is used by other apps, apply the shared filter.
521 return PackageManagerServiceCompilerMapping.getCompilerFilterForReason(
522 PackageManagerService.REASON_SHARED);
Andreas Gampebdd30d82016-03-20 11:32:11 -0700523 }
524
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800525 return targetCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800526 }
527
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800528 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800529 * Computes the dex flags that needs to be pass to installd for the given package and compiler
530 * filter.
531 */
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100532 private int getDexFlags(PackageParser.Package pkg, String compilerFilter,
Andreas Gampec041c332017-11-01 17:05:53 -0700533 DexoptOptions options) {
534 return getDexFlags(pkg.applicationInfo, compilerFilter, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800535 }
536
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700537 private boolean isAppImageEnabled() {
538 return SystemProperties.get("dalvik.vm.appimageformat", "").length() > 0;
539 }
540
Andreas Gampec041c332017-11-01 17:05:53 -0700541 private int getDexFlags(ApplicationInfo info, String compilerFilter, DexoptOptions options) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800542 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800543 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
Calin Juravleff3e4a12018-02-01 17:23:13 +0000544 // Profile guide compiled oat files should not be public unles they are based
545 // on profiles from dex metadata archives.
546 // The flag isDexoptInstallWithDexMetadata applies only on installs when we know that
547 // the user does not have an existing profile.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800548 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter);
Patrick Baumannfc2851e2018-11-13 15:23:22 -0800549 boolean isPublic = !isProfileGuidedFilter || options.isDexoptInstallWithDexMetadata();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800550 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0;
David Brazdilf7e31c02018-02-13 17:04:26 +0000551 // Some apps are executed with restrictions on hidden API usage. If this app is one
552 // of them, pass a flag to dexopt to enable the same restrictions during compilation.
Mathew Inwoode3299532018-02-22 13:19:53 +0000553 // TODO we should pass the actual flag value to dexopt, rather than assuming blacklist
David Brazdil06ae4b82018-11-02 18:01:45 +0000554 int hiddenApiFlag = info.getHiddenApiEnforcementPolicy() == HIDDEN_API_ENFORCEMENT_DISABLED
Mathew Inwoode3299532018-02-22 13:19:53 +0000555 ? 0
556 : DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartiera6d43e42018-03-08 13:11:40 -0800557 // Avoid generating CompactDex for modes that are latency critical.
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800558 final int compilationReason = options.getCompilationReason();
559 boolean generateCompactDex = true;
560 switch (compilationReason) {
561 case PackageManagerService.REASON_FIRST_BOOT:
562 case PackageManagerService.REASON_BOOT:
563 case PackageManagerService.REASON_INSTALL:
564 generateCompactDex = false;
565 }
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700566 // Use app images only if it is enabled and we are compiling
567 // profile-guided (so the app image doesn't conservatively contain all classes).
568 // If the app didn't request for the splits to be loaded in isolation or if it does not
569 // declare inter-split dependencies, then all the splits will be loaded in the base
570 // apk class loader (in the order of their definition, otherwise disable app images
571 // because they are unsupported for multiple class loaders. b/7269679
572 boolean generateAppImage = isProfileGuidedFilter && (info.splitDependencies == null ||
573 !info.requestsIsolatedSplitLoading()) && isAppImageEnabled();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800574 int dexFlags =
575 (isPublic ? DEXOPT_PUBLIC : 0)
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800576 | (debuggable ? DEXOPT_DEBUGGABLE : 0)
577 | profileFlag
Andreas Gampec041c332017-11-01 17:05:53 -0700578 | (options.isBootComplete() ? DEXOPT_BOOTCOMPLETE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000579 | (options.isDexoptIdleBackgroundJob() ? DEXOPT_IDLE_BACKGROUND_JOB : 0)
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800580 | (generateCompactDex ? DEXOPT_GENERATE_COMPACT_DEX : 0)
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700581 | (generateAppImage ? DEXOPT_GENERATE_APP_IMAGE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000582 | hiddenApiFlag;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800583 return adjustDexoptFlags(dexFlags);
584 }
585
586 /**
587 * Assesses if there's a need to perform dexopt on {@code path} for the given
588 * configuration (isa, compiler filter, profile).
589 */
590 private int getDexoptNeeded(String path, String isa, String compilerFilter,
Calin Juravle576e6c02017-09-12 00:58:33 -0700591 String classLoaderContext, boolean newProfile, boolean downgrade) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800592 int dexoptNeeded;
593 try {
Calin Juravle576e6c02017-09-12 00:58:33 -0700594 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext,
595 newProfile, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800596 } catch (IOException ioe) {
597 Slog.w(TAG, "IOException reading apk: " + path, ioe);
598 return DEX_OPT_FAILED;
599 }
600 return adjustDexoptNeeded(dexoptNeeded);
601 }
602
603 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800604 * Checks if there is an update on the profile information of the {@code pkg}.
605 * If the compiler filter is not profile guided the method returns false.
606 *
607 * Note that this is a "destructive" operation with side effects. Under the hood the
608 * current profile and the reference profile will be merged and subsequent calls
609 * may return a different result.
610 */
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800611 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String profileName,
612 String compilerFilter) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800613 // Check if we are allowed to merge and if the compiler filter is profile guided.
614 if (!isProfileGuidedCompilerFilter(compilerFilter)) {
615 return false;
616 }
617 // Merge profiles. It returns whether or not there was an updated in the profile info.
618 try {
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800619 return mInstaller.mergeProfiles(uid, pkg.packageName, profileName);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800620 } catch (InstallerException e) {
621 Slog.w(TAG, "Failed to merge profiles", e);
622 }
623 return false;
624 }
625
626 /**
627 * Creates oat dir for the specified package if needed and supported.
628 * In certain cases oat directory
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800629 * <strong>cannot</strong> be created:
630 * <ul>
631 * <li>{@code pkg} is a system app, which is not updated.</li>
632 * <li>Package location is not a directory, i.e. monolithic install.</li>
633 * </ul>
634 *
Richard Uhler7b08b352015-03-25 16:25:57 -0700635 * @return Absolute path to the oat directory or null, if oat directory
636 * cannot be created.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800637 */
638 @Nullable
Todd Kennedy27c24fb2015-09-17 16:49:25 -0700639 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) {
Fyodor Kupolovebcac162015-09-09 15:56:45 -0700640 if (!pkg.canHaveOatDir()) {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800641 return null;
642 }
643 File codePath = new File(pkg.codePath);
644 if (codePath.isDirectory()) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800645 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for
646 // cluster packages). It seems that the logic for the folder creation is
647 // split between installd and here.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800648 File oatDir = getOatDir(codePath);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700649 try {
Andreas Gampea8908752015-11-10 08:58:14 -0800650 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700651 } catch (InstallerException e) {
652 Slog.w(TAG, "Failed to create oat dir", e);
653 return null;
654 }
Richard Uhler7b08b352015-03-25 16:25:57 -0700655 return oatDir.getAbsolutePath();
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800656 }
657 return null;
658 }
659
660 static File getOatDir(File codePath) {
661 return new File(codePath, OAT_DIR_NAME);
662 }
663
Fyodor Kupolova627c092015-05-05 18:44:39 -0700664 void systemReady() {
665 mSystemReady = true;
666 }
Andreas Gampea8908752015-11-10 08:58:14 -0800667
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800668 private String printDexoptFlags(int flags) {
669 ArrayList<String> flagsList = new ArrayList<>();
670
671 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) {
672 flagsList.add("boot_complete");
673 }
674 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) {
675 flagsList.add("debuggable");
676 }
677 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) {
678 flagsList.add("profile_guided");
679 }
680 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) {
681 flagsList.add("public");
682 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800683 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) {
684 flagsList.add("secondary");
685 }
686 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) {
687 flagsList.add("force");
688 }
689 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) {
690 flagsList.add("storage_ce");
691 }
692 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) {
693 flagsList.add("storage_de");
694 }
David Sehr2118ec42017-10-25 14:28:29 -0700695 if ((flags & DEXOPT_IDLE_BACKGROUND_JOB) == DEXOPT_IDLE_BACKGROUND_JOB) {
696 flagsList.add("idle_background_job");
697 }
David Brazdilf7e31c02018-02-13 17:04:26 +0000698 if ((flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) == DEXOPT_ENABLE_HIDDEN_API_CHECKS) {
699 flagsList.add("enable_hidden_api_checks");
David Brazdil464ed3d2018-01-18 15:25:18 +0000700 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800701
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800702 return String.join(",", flagsList);
703 }
704
Andreas Gampea8908752015-11-10 08:58:14 -0800705 /**
706 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a
707 * dexopt path.
708 */
709 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer {
710
711 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock,
712 Context context, String wakeLockTag) {
713 super(installer, installLock, context, wakeLockTag);
714 }
715
716 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) {
717 super(from);
718 }
719
720 @Override
Andreas Gampea8908752015-11-10 08:58:14 -0800721 protected int adjustDexoptNeeded(int dexoptNeeded) {
Nicolas Geoffray96d12a92017-05-03 11:51:53 +0100722 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) {
723 // Ensure compilation by pretending a compiler filter change on the
724 // apk/odex location (the reason for the '-'. A positive value means
725 // the 'oat' location).
726 return -DexFile.DEX2OAT_FOR_FILTER;
727 }
728 return dexoptNeeded;
Andreas Gampea8908752015-11-10 08:58:14 -0800729 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800730
731 @Override
732 protected int adjustDexoptFlags(int flags) {
733 // Add DEXOPT_FORCE flag to signal installd that it should force compilation
734 // and discard dexoptanalyzer result.
735 return flags | DEXOPT_FORCE;
736 }
Andreas Gampea8908752015-11-10 08:58:14 -0800737 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800738}