blob: 16356ae4e614f51a62d4a30f4095241c576d053e [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900123 int _aidl_end_pos = _aidl_parcel.dataPosition();
124 _aidl_parcel.setDataPosition(_aidl_start_pos);
125 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
126 _aidl_parcel.setDataPosition(_aidl_end_pos);
127 }
128 public final void readFromParcel(android.os.Parcel _aidl_parcel)
129 {
130 int _aidl_start_pos = _aidl_parcel.dataPosition();
131 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900132 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900133 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900134 x = _aidl_parcel.readInt();
135 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
136 y = _aidl_parcel.readInt();
137 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900138 if ((0!=_aidl_parcel.readInt())) {
139 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
140 }
141 else {
142 fd = null;
143 }
144 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hand2fa0232020-10-19 02:51:41 +0900145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900146 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900147 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
148 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
149 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900150 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
151 }
152 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900153 @Override
154 public int describeContents() {
155 int _mask = 0;
156 if (fd != null) _mask |= fd.describeContents();
157 if (fds != null) for (ParcelFileDescriptor _v0: fds) if (_v0 != null) _mask |= _v0.describeContents();
158 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900159 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900160}
161)";
162
Devin Moore2f2077a2020-08-28 11:27:53 -0700163// clang-format off
164const char kExpectedCppHeaderOutput[] =
165 R"(#pragma once
166
167#include <binder/IBinder.h>
168#include <binder/IInterface.h>
169#include <binder/Status.h>
170#include <optional>
171#include <utils/String16.h>
172#include <utils/StrongPointer.h>
173#include <vector>
174
175class IFoo : public ::android::IInterface {
176public:
177 DECLARE_META_INTERFACE(Foo)
178 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
179}; // class IFoo
180class IFooDefault : public IFoo {
181public:
182 ::android::IBinder* onAsBinder() override {
183 return nullptr;
184 }
185 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
186 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
187 }
188}; // class IFooDefault
189)";
190// clang-format on
191
Christopher Wileyf8136192016-04-12 14:19:35 -0700192} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700193
Devin Moore7b8d5c92020-03-17 14:14:08 -0700194class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700195 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900196 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
197 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700198 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700199 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900200 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201 args.emplace_back("aidl");
202 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700203 for (const string& s : additional_arguments) {
204 args.emplace_back(s);
205 }
206 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900207 args.emplace_back("--preprocessed=" + f);
208 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700209 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900210 args.emplace_back("--include=" + i);
211 }
212 args.emplace_back(path);
213 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900214 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900215 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700216 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900217 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900218
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700219 if (error != nullptr) {
220 *error = actual_error;
221 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900222
223 if (actual_error != AidlError::OK) {
224 return nullptr;
225 }
226
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900227 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900228 EXPECT_EQ(1ul, defined_types.size());
229
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900230 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700231 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700232
Devin Moore7b8d5c92020-03-17 14:14:08 -0700233 Options::Language GetLanguage() { return GetParam(); }
234
Christopher Wiley0522cd52015-10-28 15:39:44 -0700235 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800236 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900237 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900238 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700239};
240
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
242// tests with each of the supported languages as a parameter.
243INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
244 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700245 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700246 [](const testing::TestParamInfo<Options::Language>& info) {
247 return Options::LanguageToString(info.param);
248 });
249
250TEST_P(AidlTest, AcceptMissingPackage) {
251 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700252}
253
Devin Moore7b8d5c92020-03-17 14:14:08 -0700254TEST_P(AidlTest, EndsInSingleLineComment) {
255 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700256}
257
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000258TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
259 const string expected_stderr =
260 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
261 const std::string file_contents = "package a; interface IBar {}";
262 CaptureStderr();
263 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
264 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
265}
266
267TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
268 const string expected_stderr =
269 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
270 const std::string file_contents = "package a; interface Bar {}";
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
274}
275
276TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
277 const string expected_stderr =
278 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
279 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
283}
284
285TEST_P(AidlTest, EnumRequiresCorrectPath) {
286 const string expected_stderr =
287 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
288 const std::string file_contents = "package a; enum Bar { A, }";
289 CaptureStderr();
290 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
291 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
292}
293
Devin Moore7b8d5c92020-03-17 14:14:08 -0700294TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900295 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700296 io_delegate_.SetFileContents("bar/IBar.aidl",
297 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700298 const string path = "foo/IFoo.aidl";
299 const string contents =
300 "package foo;\n"
301 "import bar.IBar;\n"
302 "interface IFoo { void f(in IBar[] input); }";
303 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700306 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700307}
308
Devin Moore7b8d5c92020-03-17 14:14:08 -0700309TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700310 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900312}
Devin Moore097a3ab2020-03-11 16:08:44 -0700313
Jiyong Park40782d02020-07-24 19:17:43 +0900314TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
316 const string expected_ibinder_stderr =
317 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
318 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900321}
322
Jiyong Park40782d02020-07-24 19:17:43 +0900323TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700324 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
325 const string expected_stderr =
326 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 CaptureStderr();
328 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900330}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700331
Jiyong Park40782d02020-07-24 19:17:43 +0900332TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700333 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900334 const string expected_stderr =
335 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700339}
340
Devin Moore7b8d5c92020-03-17 14:14:08 -0700341TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
343 const string expected_stderr =
344 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
345 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700348}
349
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
352 const string expected_stderr =
353 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800357}
358
Devin Moore2f2077a2020-08-28 11:27:53 -0700359TEST_P(AidlTest, AcceptNullableList) {
360 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
361 const string expected_stderr = "";
362 CaptureStderr();
363 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string method = "package a; interface IFoo { void f(int a, int a); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700374}
375
Jeongik Cha13066da2020-08-06 15:43:19 +0900376TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
377 const string method = "package a; parcelable Foo { int a; String a; }";
378 const string expected_stderr =
379 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
380 CaptureStderr();
381 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
387 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100391}
392
Devin Moore7b8d5c92020-03-17 14:14:08 -0700393TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700394 AidlError error;
395 const string method = "package a; @nullable interface IFoo { int f(); }";
396 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800397 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900398 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700399 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700400 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700401 EXPECT_EQ(expected_stderr, GetCapturedStderr());
402 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800403}
404
Devin Moore7b8d5c92020-03-17 14:14:08 -0700405TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700406 AidlError error;
407 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
408 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800409 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900410 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700411 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
414 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800415}
416
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700418 AidlError error;
419 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
420 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000421 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900422 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900423 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700424 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000425 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
427 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800428}
429
Devin Moore7b8d5c92020-03-17 14:14:08 -0700430TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700431 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000432 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000434 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900435 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700436 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700437 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000438 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
440 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800441}
442
Jiyong Park40782d02020-07-24 19:17:43 +0900443TEST_P(AidlTest, ParsesNonNullableAnnotation) {
444 auto parse_result =
445 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
446 ASSERT_NE(nullptr, parse_result);
447 const AidlInterface* interface = parse_result->AsInterface();
448 ASSERT_NE(nullptr, interface);
449 ASSERT_FALSE(interface->GetMethods().empty());
450 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
451}
452
Devin Moore7b8d5c92020-03-17 14:14:08 -0700453TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900454 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
455 typenames_, GetLanguage());
456 ASSERT_NE(nullptr, parse_result);
457 const AidlInterface* interface = parse_result->AsInterface();
458 ASSERT_NE(nullptr, interface);
459 ASSERT_FALSE(interface->GetMethods().empty());
460 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
461}
462
463TEST_P(AidlTest, ParsesNonUtf8Annotations) {
464 auto parse_result =
465 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
466 ASSERT_NE(nullptr, parse_result);
467 const AidlInterface* interface = parse_result->AsInterface();
468 ASSERT_NE(nullptr, interface);
469 ASSERT_FALSE(interface->GetMethods().empty());
470 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800471}
472
Devin Moore7b8d5c92020-03-17 14:14:08 -0700473TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900474 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
475 typenames_, GetLanguage());
476 ASSERT_NE(nullptr, parse_result);
477 const AidlInterface* interface = parse_result->AsInterface();
478 ASSERT_NE(nullptr, interface);
479 ASSERT_FALSE(interface->GetMethods().empty());
480 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800481}
482
Devin Moore7b8d5c92020-03-17 14:14:08 -0700483TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700484 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700485 const string expected_stderr =
486 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
487 "\"vintf\"'\n"
488 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
489 "--structured\n";
490 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700491 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700492 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700493 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700494 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700495}
496
Devin Moore7b8d5c92020-03-17 14:14:08 -0700497TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700498 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700499 const string expected_stderr =
500 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
501 "--structured\n";
502 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700503 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700504 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700505 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700506 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700507}
508
Devin Moore7b8d5c92020-03-17 14:14:08 -0700509TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700511 const string expected_stderr =
512 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
513 "\"vintf\"'\n";
514 CaptureStderr();
515 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700516 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700517 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700518 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700519}
520
Devin Moore7b8d5c92020-03-17 14:14:08 -0700521TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700523 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
524 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 ASSERT_EQ(AidlError::OK, error);
526 ASSERT_NE(nullptr, parse_result);
527 const AidlInterface* interface = parse_result->AsInterface();
528 ASSERT_NE(nullptr, interface);
529 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700530}
531
Jeongik Cha64783ed2019-06-07 18:30:54 +0900532TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
533 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900534 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
535 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900536 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700537 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900538 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900539 "a/Foo.aidl",
540 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900541
542 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900543 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900545 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700546 "Parcelable must be defined in AIDL directly.\n";
547 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900548 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700550
551 CaptureStderr();
552 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
553 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900554}
555
Jiyong Park43113fb2020-07-20 16:26:19 +0900556TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
557 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
558 @JavaDebug parcelable IFoo { int a; float b; })");
559 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
560 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
561
562 string java_out;
563 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
564 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
565
566 // Other backends shouldn't be bothered
567 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
568 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
569
570 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
571 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
572}
573
574TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
575 {
576 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
577 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
580 const std::string expected_stderr =
581 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900582 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
583 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900584 EXPECT_EQ(expected_stderr, GetCapturedStderr());
585 }
586
587 {
588 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
589 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
590 CaptureStderr();
591 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
592 const std::string expected_stderr =
593 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
594 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
595 EXPECT_EQ(expected_stderr, GetCapturedStderr());
596 }
597}
598
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900599TEST_P(AidlTest, ParseDescriptorAnnotation) {
600 AidlError error;
601 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
602 typenames_, GetLanguage(), &error, {"--structured"});
603 ASSERT_EQ(AidlError::OK, error);
604 ASSERT_NE(nullptr, parse_result);
605 const AidlInterface* interface = parse_result->AsInterface();
606 ASSERT_NE(nullptr, interface);
607 ASSERT_EQ("IBar", interface->GetDescriptor());
608}
609
Jiyong Park40782d02020-07-24 19:17:43 +0900610TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700611 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700612 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900613}
614
615TEST_P(AidlTest, AcceptsOnewayInterface) {
616 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700617 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700618}
Christopher Wileyef140932015-11-03 09:29:19 -0800619
Devin Moore7b8d5c92020-03-17 14:14:08 -0700620TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700621 const string oneway_method =
622 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700623 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100624}
625
Steven Moreland65297cc2020-04-20 20:17:36 -0700626TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
627 const string oneway_method =
628 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
629 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
630 ASSERT_NE(nullptr, defined);
631 const AidlInterface* iface = defined->AsInterface();
632 ASSERT_NE(nullptr, iface);
633
634 const auto& methods = iface->GetMethods();
635 ASSERT_EQ(1u, methods.size());
636 const auto& method = methods[0];
637 const AidlTypeSpecifier& ret_type = method->GetType();
638
639 // TODO(b/151102494): these annotations should be on the method
640 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
641 ASSERT_TRUE(ret_type.IsHide());
642}
643
Devin Moore7b8d5c92020-03-17 14:14:08 -0700644TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100645 string foo_interface =
646 "package a; /* foo */ interface IFoo {"
647 " /* i */ int i();"
648 " /* j */ @nullable String j();"
649 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
650
Devin Moore7b8d5c92020-03-17 14:14:08 -0700651 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100652 EXPECT_NE(nullptr, parse_result);
653 EXPECT_EQ("/* foo */", parse_result->GetComments());
654
655 const AidlInterface* interface = parse_result->AsInterface();
656 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
657 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
658 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
659}
660
Jooyung Han1a551d32020-10-05 15:37:26 +0900661TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
662 io_delegate_.SetFileContents("p/cpp_header.aidl",
663 R"(package p;
664 parcelable cpp_header cpp_header "bar/header";)");
665 import_paths_.emplace("");
666 const string input_path = "p/IFoo.aidl";
667 const string input = R"(package p;
668 import p.cpp_header;
669 interface IFoo {
670 // get bar
671 cpp_header get();
672 })";
673
674 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
675 EXPECT_NE(nullptr, parse_result);
676 const AidlInterface* interface = parse_result->AsInterface();
677 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
678}
679
Christopher Wileyef140932015-11-03 09:29:19 -0800680TEST_F(AidlTest, ParsesPreprocessedFile) {
681 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
682 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700683 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900684 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700685 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
686 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800687}
688
689TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
690 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
691 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900692
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700693 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900694 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700695 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
696 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800697}
698
Devin Moore7b8d5c92020-03-17 14:14:08 -0700699TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800700 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
701 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
702 "interface IBar {}");
703 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900704 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900705 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700706 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800707 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900708
Christopher Wiley41544372015-11-03 14:52:29 -0800709 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700710 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
711 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800712 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700713 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900714 ambiguous_type.Resolve(typenames_);
715 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800716}
717
Jiyong Park8f6ec462020-01-19 20:52:47 +0900718// Special case of PreferImportToPreprocessed. Imported type should be preferred
719// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700720TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900721 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
722 io_delegate_.SetFileContents("one/IBar.aidl",
723 "package one; "
724 "interface IBar {}");
725 preprocessed_files_.push_back("preprocessed");
726 import_paths_.emplace("");
727 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700728 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900729 EXPECT_NE(nullptr, parse_result);
730
731 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700732 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
733 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900734 // But if we request just "IBar" we should get our imported one.
735 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
736 ambiguous_type.Resolve(typenames_);
737 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
738}
739
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800740TEST_F(AidlTest, WritePreprocessedFile) {
741 io_delegate_.SetFileContents("p/Outer.aidl",
742 "package p; parcelable Outer.Inner;");
743 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
744 "interface IBar {}");
745
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900746 vector<string> args {
747 "aidl",
748 "--preprocess",
749 "preprocessed",
750 "p/Outer.aidl",
751 "one/IBar.aidl"};
752 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800753 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
754
755 string output;
756 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
757 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
758}
759
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900760TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100761 io_delegate_.SetFileContents(
762 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800763 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100764 "parcelable Rect {\n"
765 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800766 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100767 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800768 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100769 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100770 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
771 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100772 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900773 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900774 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100775 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900776
777 vector<string> args{"aidl", "Rect.aidl"};
778 Options options = Options::From(args);
779 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
780
781 string output;
782 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900783 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900784}
785
Devin Moore2f2077a2020-08-28 11:27:53 -0700786TEST_F(AidlTest, CppHeaderIncludes) {
787 io_delegate_.SetFileContents("IFoo.aidl",
788 "interface IFoo {\n"
789 " @nullable List<String> foo();\n"
790 "}");
791
792 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
793 Options options = Options::From(args);
794 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
795 std::vector<std::string> empty;
796 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
797 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
798 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
799
800 // Make sure the optional and String16.h includes are added
801 string output;
802 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
803 EXPECT_EQ(kExpectedCppHeaderOutput, output);
804}
805
Devin Moore7b8d5c92020-03-17 14:14:08 -0700806TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700807 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800808 io_delegate_.SetFileContents("p/Outer.aidl",
809 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900810 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700811 CaptureStderr();
812 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
813 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700814 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700815 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800816}
817
Devin Moore7b8d5c92020-03-17 14:14:08 -0700818TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800819 io_delegate_.SetFileContents("preprocessed",
820 "parcelable p.Outer.Inner;");
821 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900822 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700823 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800824 // TODO(wiley): This should actually return nullptr because we require
825 // the outer class name. However, for legacy reasons,
826 // this behavior must be maintained. b/17415692
827 EXPECT_NE(nullptr, parse_result);
828}
829
Christopher Wiley632801d2015-11-05 14:15:49 -0800830TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700831 const string expected_foo_stderr =
832 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
833 "Declared parcelables should be in their own file and/or cannot be used with --structured "
834 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700835 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
836
Christopher Wiley632801d2015-11-05 14:15:49 -0800837 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700838 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700839 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900840 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700841 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900842
Steven Morelande2c64b42018-09-18 15:06:37 -0700843 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900844 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700845 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900846 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700847 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700848
Devin Moore097a3ab2020-03-11 16:08:44 -0700849 const string expected_bar_stderr =
850 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
851 "Declared parcelables should be in their own file and/or cannot be used with --structured "
852 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700853 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
854
Jiyong Parkda8c6932019-08-12 19:56:08 +0900855 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700856 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700857 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900858 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700859 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700860 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700861 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700862 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700863 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800864}
865
Devin Moore7b8d5c92020-03-17 14:14:08 -0700866TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700867 const string expected_stderr =
868 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
869 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700870 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
871 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700872 AidlError error;
873 CaptureStderr();
874 EXPECT_EQ(
875 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700876 Parse("p/IFoo.aidl",
877 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700878 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
880 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700881}
882
Devin Moore7b8d5c92020-03-17 14:14:08 -0700883TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700884 AidlError error;
885 const string expected_stderr =
886 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
887 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900888 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
889 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700890 interface IFoo {
891 const String DUPLICATED = "d";
892 const int DUPLICATED = 1;
893 }
894 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700895 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700896 EXPECT_EQ(expected_stderr, GetCapturedStderr());
897 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700898}
899
Devin Moore7b8d5c92020-03-17 14:14:08 -0700900TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700902 const string expected_stderr =
903 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700904 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700905 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
906 R"(package p;
907 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700908 parcelable IBar {}
909 parcelable StructuredParcelable {}
910 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900911 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700912 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700913 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700914 // Parse success is important for clear error handling even if the cases aren't
915 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700916 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700917}
918
Devin Moore7b8d5c92020-03-17 14:14:08 -0700919TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700920 AidlError error;
921 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
922 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700923 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700924 EXPECT_EQ(expected_stderr, GetCapturedStderr());
925 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700926}
927
Steven Morelandf9e922f2020-07-08 21:15:27 +0000928TEST_P(AidlTest, FailOnEmptyListWithComma) {
929 AidlError error;
930 const string expected_stderr =
931 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
932 CaptureStderr();
933 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
934 typenames_, GetLanguage(), &error));
935 EXPECT_EQ(expected_stderr, GetCapturedStderr());
936 EXPECT_EQ(AidlError::PARSE_ERROR, error);
937}
938
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 AidlError error;
941 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700942 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700943 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900944 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
945 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700946 interface IFoo {
947 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
948 }
949 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700950 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
952 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700953}
954
Jiyong Park18132182020-06-08 20:24:40 +0900955TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
956 AidlError error;
957 const string expected_stderr =
958 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
959 "cpp_header (which can also be used as an identifier)\n";
960 CaptureStderr();
961 // Notice the trailing dot(.) in the name, which isn't a correct name
962 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
963 GetLanguage(), &error));
964 EXPECT_EQ(expected_stderr, GetCapturedStderr());
965 EXPECT_EQ(AidlError::PARSE_ERROR, error);
966}
967
968TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
969 AidlError error;
970 const string expected_stderr =
971 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
972 "cpp_header (which can also be used as an identifier)\n";
973 CaptureStderr();
974 // Notice the trailing dot(.) in the package name
975 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
976 GetLanguage(), &error));
977 EXPECT_EQ(expected_stderr, GetCapturedStderr());
978 EXPECT_EQ(AidlError::PARSE_ERROR, error);
979}
980
Devin Moore7b8d5c92020-03-17 14:14:08 -0700981TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700983 auto parse_result = Parse("p/IFoo.aidl",
984 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700985 interface IFoo {
986 const int POSITIVE_HEX_VALUE = 0xf5;
987 }
988 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700989 typenames_, GetLanguage(), &error);
990 EXPECT_NE(nullptr, parse_result);
991 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700992 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700993 const auto& cpp_constants = interface->GetConstantDeclarations();
994 EXPECT_EQ((size_t)1, cpp_constants.size());
995 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700996 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700997 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700998}
999
Devin Moore7b8d5c92020-03-17 14:14:08 -07001000TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001001 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001002 auto parse_result = Parse("p/IFoo.aidl",
1003 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001004 interface IFoo {
1005 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1006 }
1007 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008 typenames_, GetLanguage(), &error);
1009 ASSERT_NE(nullptr, parse_result);
1010 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001011 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001012 const auto& cpp_constants = interface->GetConstantDeclarations();
1013 EXPECT_EQ((size_t)1, cpp_constants.size());
1014 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001015 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001016 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001017}
1018
Devin Moore7b8d5c92020-03-17 14:14:08 -07001019TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001020 io_delegate_.SetFileContents(
1021 "p/Outer.aidl",
1022 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001023 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001024 const string input_path = "p/IFoo.aidl";
1025 const string input = "package p; import p.Outer; interface IFoo"
1026 " { Outer.Inner get(); }";
1027
Devin Moore7b8d5c92020-03-17 14:14:08 -07001028 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1029 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001030
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001031 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001032 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001033 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1034 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001035}
1036
Devin Moore7b8d5c92020-03-17 14:14:08 -07001037TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001038 io_delegate_.SetFileContents(
1039 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001040 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001041 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001042 const string input_path = "p/IFoo.aidl";
1043 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001044 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1045 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001046 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001047 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1048 native_type.Resolve(typenames_);
1049
1050 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1051 // C++ understands C++ specific stuff
1052 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1053 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001054 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001055 EXPECT_EQ(1u, headers.size());
1056 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001057}
1058
Christopher Wileyf8136192016-04-12 14:19:35 -07001059TEST_F(AidlTest, WritesCorrectDependencyFile) {
1060 // While the in tree build system always gives us an output file name,
1061 // other android tools take advantage of our ability to infer the intended
1062 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001063 vector<string> args = {
1064 "aidl",
1065 "-d dep/file/path",
1066 "-o place/for/output",
1067 "p/IFoo.aidl"};
1068 Options options = Options::From(args);
1069 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001070 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001071 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001072 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001073 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1074}
1075
Dan Willemsen93298ee2016-11-10 23:55:55 -08001076TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1077 // While the in tree build system always gives us an output file name,
1078 // other android tools take advantage of our ability to infer the intended
1079 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001080 vector<string> args = {
1081 "aidl",
1082 "-d dep/file/path",
1083 "--ninja",
1084 "-o place/for/output",
1085 "p/IFoo.aidl"};
1086 Options options = Options::From(args);
1087 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001088 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001089 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001090 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001091 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1092}
1093
Jiyong Parkdf202122019-09-30 20:48:35 +09001094TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001095 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1096 // this by calling aidl with every .aidl file it finds, then parsing the
1097 // generated dependency files. Those that reference .java output files are
1098 // for interfaces and those that do not are parcelables. However, for both
1099 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001100 vector<string> args = {
1101 "aidl",
1102 "-o place/for/output",
1103 "-d dep/file/path",
1104 "p/Foo.aidl"};
1105 Options options = Options::From(args);
1106 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001107 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001108 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001109 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001110 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1111}
1112
1113TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1114 vector<string> args = {
1115 "aidl",
1116 "--structured",
1117 "-o place/for/output",
1118 "-d dep/file/path",
1119 "p/Foo.aidl"};
1120 Options options = Options::From(args);
1121 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1122 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1123 string actual_dep_file_contents;
1124 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1125 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001126}
1127
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001128TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1129 vector<string> args = {
1130 "aidl",
1131 "--lang=java",
1132 "-o place/for/output",
1133 "p/Foo.aidl"};
1134 Options options = Options::From(args);
1135 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1136 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1137 string output_file_contents;
1138 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1139}
1140
Jeongik Cha08ca2182019-11-21 14:01:13 +09001141// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001142TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001143 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001144 "package a; interface IFoo {\n"
1145 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001146 string expected_stderr;
1147 switch (GetLanguage()) {
1148 case Options::Language::CPP:
1149 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001150 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001151 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1152 "String and IBinder.\n";
1153 break;
1154 case Options::Language::JAVA:
1155 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001156 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001157 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1158 "String, IBinder, and ParcelFileDescriptor.\n";
1159 break;
1160 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001161 case Options::Language::RUST:
1162 expected_stderr =
1163 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1164 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001165 default:
1166 AIDL_FATAL(AIDL_LOCATION_HERE)
1167 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1168 }
1169 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001170 AidlTypenames tn1;
1171 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001172 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001173
1174 string primitive_parcelable =
1175 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001176 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001177 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001178 AidlTypenames tn2;
1179 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001180 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001181}
1182
Devin Moore21b26772020-08-26 16:37:56 -07001183TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001184 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001185 const string list_array_parcelable =
1186 "package a; parcelable Foo {\n"
1187 " List[] lists; }";
1188 CaptureStderr();
1189 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1191}
1192
Jiyong Parkf8d53612020-05-04 14:06:13 +09001193TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1194 AidlError error;
1195 string expected_stderr =
1196 "ERROR: a/IFoo.aidl:2.7-11: "
1197 "Encountered an untyped List or Map. The use of untyped List/Map is "
1198 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1199 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1200 if (GetLanguage() != Options::Language::JAVA) {
1201 expected_stderr =
1202 "ERROR: a/IFoo.aidl:2.1-7: "
1203 "Currently, only the Java backend supports non-generic List.\n";
1204 }
1205
1206 const string primitive_interface =
1207 "package a; interface IFoo {\n"
1208 " List foo(); }";
1209 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001210 AidlTypenames tn1;
1211 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001212 {"--structured"}));
1213 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001214
1215 string primitive_parcelable =
1216 "package a; parcelable IFoo {\n"
1217 " List foo;}";
1218 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001219 AidlTypenames tn2;
1220 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001221 {"--structured"}));
1222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1223}
1224
Jeongik Cha225519b2020-08-29 01:55:32 +09001225TEST_P(AidlTest, ExtensionTest) {
1226 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001227 string extendable_parcelable =
1228 "package a; parcelable Data {\n"
1229 " ParcelableHolder extension;\n"
1230 " ParcelableHolder extension2;\n"
1231 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001232 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1233 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1234 EXPECT_EQ(
1235 "ERROR: a/Data.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1236 "yet.\n",
1237 GetCapturedStderr());
1238 } else {
1239 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1240 EXPECT_EQ("", GetCapturedStderr());
1241 }
1242}
1243TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1244 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001245 string parcelableholder_return_interface =
1246 "package a; interface IFoo {\n"
1247 " ParcelableHolder foo();\n"
1248 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001249 EXPECT_EQ(nullptr,
1250 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001251
Jeongik Cha225519b2020-08-29 01:55:32 +09001252 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1253 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001254 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001255 "ERROR: a/IFoo.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1256 "yet.\n",
1257 GetCapturedStderr());
1258 return;
1259 }
1260 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1261 GetCapturedStderr());
1262}
1263
1264TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1265 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001266 string extendable_parcelable_arg_interface =
1267 "package a; interface IFoo {\n"
1268 " void foo(in ParcelableHolder ph);\n"
1269 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001270 EXPECT_EQ(nullptr,
1271 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1272
1273 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1274 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001275 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001276 "ERROR: a/IFoo.aidl:2.14-31: The NDK and Rust backend does not support ParcelableHolder "
1277 "yet.\n",
1278 GetCapturedStderr());
1279 return;
1280 }
1281 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1282 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001283}
1284
Jiyong Park02da7422018-07-16 16:00:26 +09001285TEST_F(AidlTest, ApiDump) {
1286 io_delegate_.SetFileContents(
1287 "foo/bar/IFoo.aidl",
1288 "package foo.bar;\n"
1289 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001290 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001291 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001292 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001293 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1294 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1295 " IFoo foo3(IFoo foo);\n"
1296 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001297 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001298 " const int A = 1;\n"
1299 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001300 "}\n");
1301 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1302 "package foo.bar;\n"
1303 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001304 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001305 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001306 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001307 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001308 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001309 " int y;\n"
1310 " IFoo foo;\n"
1311 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001312 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001313 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001314 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001315 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001316 "}\n");
1317 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001318 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1319 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001320 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001321 bool result = dump_api(options, io_delegate_);
1322 ASSERT_TRUE(result);
1323 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001324 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001325 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001326/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001327interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001328 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001329 int foo(out int[] a, String b, boolean c, inout List<String> d);
1330 int foo2(@utf8InCpp String x, inout List<String> y);
1331 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1332 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001333 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001334 const int A = 1;
1335 const String STR = "Hello";
1336}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001337)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001338
Jiyong Parke59c3682018-09-11 23:10:25 +09001339 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001340 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001341/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001342parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001343 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001344 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001345 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001346 int y;
1347 foo.bar.IFoo foo;
1348 List<foo.bar.IFoo> a;
1349 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001350 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001351 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001352}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001353)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001354}
1355
Jiyong Parked65bf42018-08-28 15:43:27 +09001356TEST_F(AidlTest, ApiDumpWithManualIds) {
1357 io_delegate_.SetFileContents(
1358 "foo/bar/IFoo.aidl",
1359 "package foo.bar;\n"
1360 "interface IFoo {\n"
1361 " int foo() = 1;\n"
1362 " int bar() = 2;\n"
1363 " int baz() = 10;\n"
1364 "}\n");
1365
Jiyong Parke59c3682018-09-11 23:10:25 +09001366 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001367 Options options = Options::From(args);
1368 bool result = dump_api(options, io_delegate_);
1369 ASSERT_TRUE(result);
1370 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001371 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001372 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001373interface IFoo {
1374 int foo() = 1;
1375 int bar() = 2;
1376 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001377}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001378)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001379}
1380
1381TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 const string expected_stderr =
1383 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1384 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001385 io_delegate_.SetFileContents(
1386 "foo/bar/IFoo.aidl",
1387 "package foo.bar;\n"
1388 "interface IFoo {\n"
1389 " int foo() = 1;\n"
1390 " int bar();\n"
1391 " int baz() = 10;\n"
1392 "}\n");
1393
Jiyong Parke59c3682018-09-11 23:10:25 +09001394 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001395 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001396 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001397 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001399}
1400
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001401TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001402 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001403 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1404 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001405 const string expected_map_stderr =
1406 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001407 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1408 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001409 "package p; interface IFoo {"
1410 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001411 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001412 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001413 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001414
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001415 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001416 "package p; interface IFoo {"
1417 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001418 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001419 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001420 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001421}
1422
Jeongik Chae48d9942020-01-02 17:39:00 +09001423TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001424 const string expected_stderr =
1425 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001426 Options options = Options::From("aidl -I p p/IFoo.aidl");
1427 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1428
1429 io_delegate_.SetFileContents("p/IFoo.aidl",
1430 "package p; interface IFoo {"
1431 "Map<String, Bar> foo();}");
1432 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1433
1434 io_delegate_.SetFileContents("p/IFoo.aidl",
1435 "package p; interface IFoo {"
1436 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001437 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001438 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001440
1441 io_delegate_.SetFileContents("p/IFoo.aidl",
1442 "package p; interface IFoo {"
1443 "Map<String, String> foo();}");
1444 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1445
1446 io_delegate_.SetFileContents("p/IFoo.aidl",
1447 "package p; interface IFoo {"
1448 "Map<String, ParcelFileDescriptor> foo();}");
1449 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1450}
1451
Jeongik Chadf76dc72019-11-28 00:08:47 +09001452TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001453 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001454 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1455 io_delegate_.SetFileContents(options.InputFiles().front(),
1456 "package p; interface IFoo {"
1457 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001458 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001459 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001460 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001461}
1462
1463TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1464 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1465 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001466 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001467 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001468 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1469 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001470
1471 Options options = Options::From("aidl -I p p/IFoo.aidl");
1472 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1473 io_delegate_.SetFileContents("p/IFoo.aidl",
1474 "package p; interface IFoo {"
1475 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001476 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001477 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001478 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001479 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001480 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001481 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001482 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1483 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001484 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1485 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1486 io_delegate_.SetFileContents("p/IFoo.aidl",
1487 "package p; interface IFoo {"
1488 "Bar<String, ParcelFileDescriptor> foo();}");
1489 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001490
1491 io_delegate_.SetFileContents("p/IFoo.aidl",
1492 "package p; interface IFoo {"
1493 "Bar<int, long> foo();}");
1494
1495 io_delegate_.SetFileContents("p/IFoo.aidl",
1496 "package p; interface IFoo {"
1497 "Bar<int[], long[]> foo();}");
1498
1499 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001500}
1501
Jeongik Cha0e426012019-07-29 15:57:02 +09001502TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1503 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001504 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1505 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001506 for (const auto& rawOption : rawOptions) {
1507 string expected_stderr =
1508 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001509 Options options = Options::From(rawOption);
1510 io_delegate_.SetFileContents(options.InputFiles().front(),
1511 "package foo.bar;\n"
1512 "interface IFoo1 { int foo(); }\n"
1513 "interface IFoo2 { int foo(); }\n"
1514 "parcelable Data1 { int a; int b;}\n"
1515 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001516 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001517 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001518 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001519
Jeongik Cha0e426012019-07-29 15:57:02 +09001520 io_delegate_.SetFileContents(options.InputFiles().front(),
1521 "package foo.bar;\n"
1522 "interface IFoo1 { int foo(); }\n"
1523 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001524 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001525 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001526 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001527
Devin Moore5de18ed2020-04-02 13:52:29 -07001528 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001529 io_delegate_.SetFileContents(options.InputFiles().front(),
1530 "package foo.bar;\n"
1531 "parcelable Data1 { int a; int b;}\n"
1532 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001533 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001534 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001535 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001536 }
1537}
1538
Devin Moorebdba2a82020-03-31 15:19:02 -07001539TEST_P(AidlTest, FailParseOnEmptyFile) {
1540 const string contents = "";
1541 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1542 CaptureStderr();
1543 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1545}
1546
Jiyong Parkb034bf02018-07-30 17:44:33 +09001547TEST_F(AidlTest, MultipleInputFiles) {
1548 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001549 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001550
1551 io_delegate_.SetFileContents(options.InputFiles().at(0),
1552 "package foo.bar;\n"
1553 "import foo.bar.Data;\n"
1554 "interface IFoo { Data getData(); }\n");
1555
1556 io_delegate_.SetFileContents(options.InputFiles().at(1),
1557 "package foo.bar;\n"
1558 "import foo.bar.IFoo;\n"
1559 "parcelable Data { IFoo foo; }\n");
1560
1561 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1562
1563 string content;
1564 for (const auto file : {
1565 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1566 content.clear();
1567 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1568 EXPECT_FALSE(content.empty());
1569 }
1570}
1571
1572TEST_F(AidlTest, MultipleInputFilesCpp) {
1573 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001574 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001575
1576 io_delegate_.SetFileContents(options.InputFiles().at(0),
1577 "package foo.bar;\n"
1578 "import foo.bar.Data;\n"
1579 "interface IFoo { Data getData(); }\n");
1580
1581 io_delegate_.SetFileContents(options.InputFiles().at(1),
1582 "package foo.bar;\n"
1583 "import foo.bar.IFoo;\n"
1584 "parcelable Data { IFoo foo; }\n");
1585
1586 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1587
1588 string content;
1589 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001590 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001591 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1592 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1593 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1594 content.clear();
1595 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1596 EXPECT_FALSE(content.empty());
1597 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001598}
1599
Andrei Homescub62afd92020-05-11 19:24:59 -07001600TEST_F(AidlTest, MultipleInputFilesRust) {
1601 Options options =
1602 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1603
1604 io_delegate_.SetFileContents(options.InputFiles().at(0),
1605 "package foo.bar;\n"
1606 "import foo.bar.Data;\n"
1607 "interface IFoo { Data getData(); }\n");
1608
1609 io_delegate_.SetFileContents(options.InputFiles().at(1),
1610 "package foo.bar;\n"
1611 "import foo.bar.IFoo;\n"
1612 "parcelable Data { IFoo foo; }\n");
1613
1614 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1615
1616 string content;
1617 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1618 content.clear();
1619 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1620 EXPECT_FALSE(content.empty());
1621 }
1622}
1623
Devin Moore097a3ab2020-03-11 16:08:44 -07001624TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1625 const string expected_stderr =
1626 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001627 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1628 // int getInterfaceVersion() is one of the meta transactions
1629 io_delegate_.SetFileContents(options.InputFiles().front(),
1630 "package p; interface IFoo {"
1631 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001632 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001633 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001634 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1635}
Jiyong Park309668e2018-07-28 16:55:44 +09001636
Devin Moore097a3ab2020-03-11 16:08:44 -07001637TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1638 // boolean getInterfaceVersion() is not a meta transaction, but should be
1639 // prevented because return type is not part of a method signature
1640 const string expected_stderr =
1641 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1642 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001643 io_delegate_.SetFileContents(options.InputFiles().front(),
1644 "package p; interface IFoo {"
1645 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001646 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001647 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001648 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1649}
Jiyong Park309668e2018-07-28 16:55:44 +09001650
Devin Moore097a3ab2020-03-11 16:08:44 -07001651TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001652 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001653 const string expected_stderr =
1654 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1655 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001656 io_delegate_.SetFileContents(options.InputFiles().front(),
1657 "package p; interface IFoo {"
1658 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001659 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001660 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001662
1663 // this is not a meta interface method as it differs type arguments
1664 io_delegate_.SetFileContents(options.InputFiles().front(),
1665 "package p; interface IFoo {"
1666 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001667 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001668}
1669
Daniel Norman85aed542019-08-21 12:01:14 -07001670TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001671 Options options = Options::From("aidl --checkapi old new");
1672 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1673 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1674 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1675 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1676
1677 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1678}
1679
Jiyong Park3656c3c2018-08-01 20:02:01 +09001680TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001681 Options options = Options::From("aidl --checkapi old new");
1682 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1683 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001684
1685 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1686}
1687
Daniel Norman85aed542019-08-21 12:01:14 -07001688class AidlTestCompatibleChanges : public AidlTest {
1689 protected:
1690 Options options_ = Options::From("aidl --checkapi old new");
1691};
1692
1693TEST_F(AidlTestCompatibleChanges, NewType) {
1694 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1695 "package p;"
1696 "interface IFoo {"
1697 " void foo(int a);"
1698 "}");
1699 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1700 "package p;"
1701 "interface IFoo {"
1702 " void foo(int a);"
1703 "}");
1704 io_delegate_.SetFileContents("new/p/IBar.aidl",
1705 "package p;"
1706 "interface IBar {"
1707 " void bar();"
1708 "}");
1709 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1710}
1711
1712TEST_F(AidlTestCompatibleChanges, NewMethod) {
1713 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1714 "package p;"
1715 "interface IFoo {"
1716 " void foo(int a);"
1717 "}");
1718 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1719 "package p;"
1720 "interface IFoo {"
1721 " void foo(int a);"
1722 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001723 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001724 "}");
1725 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1726}
1727
1728TEST_F(AidlTestCompatibleChanges, NewField) {
1729 io_delegate_.SetFileContents("old/p/Data.aidl",
1730 "package p;"
1731 "parcelable Data {"
1732 " int foo;"
1733 "}");
1734 io_delegate_.SetFileContents("new/p/Data.aidl",
1735 "package p;"
1736 "parcelable Data {"
1737 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001738 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001739 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001740 "}");
1741 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1742}
1743
1744TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1745 io_delegate_.SetFileContents("old/p/Enum.aidl",
1746 "package p;"
1747 "enum Enum {"
1748 " FOO = 1,"
1749 "}");
1750 io_delegate_.SetFileContents("new/p/Enum.aidl",
1751 "package p;"
1752 "enum Enum {"
1753 " FOO = 1,"
1754 " BAR = 2,"
1755 "}");
1756 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1757}
1758
1759TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1760 io_delegate_.SetFileContents("old/p/Enum.aidl",
1761 "package p;"
1762 "enum Enum {"
1763 " FOO = 1,"
1764 " BAR = 2,"
1765 "}");
1766 io_delegate_.SetFileContents("new/p/Enum.aidl",
1767 "package p;"
1768 "enum Enum {"
1769 " BAR = 2,"
1770 " FOO = 1,"
1771 "}");
1772 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1773}
1774
1775TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001776 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1777 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001778 "interface IFoo {"
1779 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001780 "}");
1781 io_delegate_.SetFileContents("old/p/Data.aidl",
1782 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001783 "parcelable Data {"
1784 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001785 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001786 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1787 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001788 "interface IFoo {"
1789 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001790 "}");
1791 io_delegate_.SetFileContents("new/p/Data.aidl",
1792 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001793 "parcelable Data {"
1794 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001795 "}");
1796 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1797 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001798 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001799 " void foo(int a);"
1800 "}");
1801 io_delegate_.SetFileContents("new/q/Data.aidl",
1802 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001803 "parcelable Data {"
1804 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001805 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001806 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1807}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001808
Daniel Norman85aed542019-08-21 12:01:14 -07001809TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1810 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1811 "package p;"
1812 "interface IFoo {"
1813 " void foo(int a);"
1814 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001815 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1816 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001817 "interface IFoo {"
1818 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001819 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001820 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1821}
Jiyong Parke59c3682018-09-11 23:10:25 +09001822
Daniel Norman85aed542019-08-21 12:01:14 -07001823TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001824 io_delegate_.SetFileContents("old/p/I.aidl",
1825 "package p; interface I {"
1826 "const int A = 1; }");
1827 io_delegate_.SetFileContents("new/p/I.aidl",
1828 "package p ; interface I {"
1829 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001830 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1831}
Jiyong Parka428d212018-08-29 22:26:30 +09001832
Daniel Norman85aed542019-08-21 12:01:14 -07001833TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001834 io_delegate_.SetFileContents("old/p/I.aidl",
1835 "package p; interface I {"
1836 "const int A = 1; const int B = 2;}");
1837 io_delegate_.SetFileContents("new/p/I.aidl",
1838 "package p ; interface I {"
1839 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001840 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001841}
1842
Daniel Norman85aed542019-08-21 12:01:14 -07001843class AidlTestIncompatibleChanges : public AidlTest {
1844 protected:
1845 Options options_ = Options::From("aidl --checkapi old new");
1846};
1847
1848TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001849 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001850 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1851 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001852 "interface IFoo {"
1853 " void foo(in String[] str);"
1854 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001855 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001856 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001857 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001858 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001859}
1860
1861TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001862 const string expected_stderr =
1863 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001864 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1865 "package p;"
1866 "interface IFoo {"
1867 " void foo(in String[] str);"
1868 " void bar(@utf8InCpp String str);"
1869 "}");
1870 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1871 "package p;"
1872 "interface IFoo {"
1873 " void foo(in String[] str);"
1874 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001875 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001876 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001878}
1879
Jiyong Parkf8d53612020-05-04 14:06:13 +09001880TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1881 const string expected_stderr =
1882 "ERROR: new/p/IFoo.aidl:1.61-65: "
1883 "Encountered an untyped List or Map. The use of untyped List/Map is "
1884 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1885 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1886 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1887 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1888 "package p;"
1889 "interface IFoo {"
1890 " void foo(in String[] str);"
1891 "}");
1892 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1893 "package p;"
1894 "interface IFoo {"
1895 " void foo(in String[] str);"
1896 " void bar(in List arg);"
1897 "}");
1898 CaptureStderr();
1899 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1900 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1901}
1902
1903TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1904 const string expected_stderr =
1905 "ERROR: new/p/Data.aidl:1.54-59: "
1906 "Encountered an untyped List or Map. The use of untyped List/Map is "
1907 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1908 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1909 "ERROR: new/p/Data.aidl: Failed to read.\n";
1910 io_delegate_.SetFileContents("old/p/Data.aidl",
1911 "package p;"
1912 "parcelable Data {"
1913 " int foo;"
1914 "}");
1915 io_delegate_.SetFileContents("new/p/Data.aidl",
1916 "package p;"
1917 "parcelable Data {"
1918 " int foo;"
1919 " @nullable List list;"
1920 "}");
1921 CaptureStderr();
1922 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1923 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1924}
1925
Daniel Norman85aed542019-08-21 12:01:14 -07001926TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001927 const string expected_stderr =
1928 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001929 io_delegate_.SetFileContents("old/p/Data.aidl",
1930 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001931 "parcelable Data {"
1932 " int foo;"
1933 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001934 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001935 io_delegate_.SetFileContents("new/p/Data.aidl",
1936 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001937 "parcelable Data {"
1938 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001939 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001940 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001941 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001942 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001943}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001944
Daniel Norman85aed542019-08-21 12:01:14 -07001945TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001946 const string expected_stderr =
1947 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001948 io_delegate_.SetFileContents("old/p/Enum.aidl",
1949 "package p;"
1950 "enum Enum {"
1951 " FOO = 1,"
1952 " BAR = 2,"
1953 "}");
1954 io_delegate_.SetFileContents("new/p/Enum.aidl",
1955 "package p;"
1956 "enum Enum {"
1957 " BAR = 2,"
1958 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001959 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001960 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001961 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001962}
1963
1964TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001965 const string expected_stderr =
1966 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001967 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1968 "package p;"
1969 "interface IFoo {"
1970 " void foo(in String[] str);"
1971 " void bar(@utf8InCpp String str);"
1972 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001973 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1974 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001975 "interface IFoo {"
1976 " void foo(in String[] str);"
1977 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001978 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001979 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001980 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001981 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001982}
1983
Daniel Norman85aed542019-08-21 12:01:14 -07001984TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001985 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001986 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1987 "package p;"
1988 "interface IFoo {"
1989 " void foo(in String[] str);"
1990 " void bar(@utf8InCpp String str);"
1991 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001992 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
1993 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001994 "interface IFoo2 {"
1995 " void foo(in String[] str);"
1996 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001997 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001998 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001999 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002000 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002001}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002002
Daniel Norman85aed542019-08-21 12:01:14 -07002003TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002004 const string expected_stderr =
2005 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002006 io_delegate_.SetFileContents("old/p/Enum.aidl",
2007 "package p;"
2008 "enum Enum {"
2009 " FOO = 1,"
2010 " BAR = 2,"
2011 "}");
2012 io_delegate_.SetFileContents("new/p/Enum.aidl",
2013 "package p;"
2014 "enum Enum {"
2015 " FOO = 3,"
2016 " BAR = 2,"
2017 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002018 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002019 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002021}
2022
2023TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002024 const string expected_stderr =
2025 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2026 "from 0 to 1.\n"
2027 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2028 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002029 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2030 "package p;"
2031 "interface IFoo {"
2032 " void foo(in String[] str);"
2033 " void bar(@utf8InCpp String str);"
2034 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002035 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2036 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002037 "interface IFoo {"
2038 " void bar(@utf8InCpp String str);"
2039 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002040 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002041 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002042 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002043 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002044}
2045
2046TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002047 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002048 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2049 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002050 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002051 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002052 "parcelable Data {"
2053 " int foo;"
2054 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002055 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002056 io_delegate_.SetFileContents("new/p/Data.aidl",
2057 "package p;"
2058 "parcelable Data {"
2059 " int bar;"
2060 " int foo;"
2061 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002062 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002063 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002064 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002065}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002066
Daniel Norman85aed542019-08-21 12:01:14 -07002067TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002068 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002069 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002070 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002071 "interface IFoo {"
2072 " void foo(in String[] str);"
2073 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002074 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002075 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2076 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002077 "interface IFoo {"
2078 " void foo(out String[] str);"
2079 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002080 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002081 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002082 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002083 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002084}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002085
Daniel Norman85aed542019-08-21 12:01:14 -07002086TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002087 const string expected_stderr =
2088 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002089 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2090 "package p;"
2091 "interface IFoo {"
2092 " void foo(in String[] str);"
2093 " void bar(@utf8InCpp String str);"
2094 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002095 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2096 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002097 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002098 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002099 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002100 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002101 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002102 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002103 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002104}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002105
Daniel Norman85aed542019-08-21 12:01:14 -07002106TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002107 const string expected_stderr =
2108 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002109 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2110 "package p;"
2111 "interface IFoo {"
2112 " void foo(in String[] str);"
2113 " void bar(@utf8InCpp String str);"
2114 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002115 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2116 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002117 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002118 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002119 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002120 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002121 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002122 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002123 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002124}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002125
Devin Mooredb7ac512020-08-07 11:17:36 -07002126TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2127 const string expected_stderr =
2128 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2129 io_delegate_.SetFileContents("old/p/Foo.aidl",
2130 "package p;"
2131 "parcelable Foo {"
2132 " int A;"
2133 "}");
2134 io_delegate_.SetFileContents("new/p/Foo.aidl",
2135 "package p;"
2136 "@JavaOnlyStableParcelable parcelable Foo {"
2137 " int A;"
2138 "}");
2139 CaptureStderr();
2140 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2141 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2142}
2143
2144TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2145 const string expected_stderr =
2146 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2147 io_delegate_.SetFileContents("old/p/Foo.aidl",
2148 "package p;"
2149 "@JavaOnlyStableParcelable parcelable Foo {"
2150 " int A;"
2151 "}");
2152 io_delegate_.SetFileContents("new/p/Foo.aidl",
2153 "package p;"
2154 "parcelable Foo {"
2155 " int A;"
2156 "}");
2157 CaptureStderr();
2158 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2159 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2160}
2161
Daniel Norman85aed542019-08-21 12:01:14 -07002162TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002163 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002164 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2165 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002166 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002167 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002168 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002170}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002171
Daniel Norman85aed542019-08-21 12:01:14 -07002172TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002173 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002174 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2175 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002176 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002177 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002178 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002179}
Jiyong Parka428d212018-08-29 22:26:30 +09002180
Daniel Norman85aed542019-08-21 12:01:14 -07002181TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002182 const string expected_stderr =
2183 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002184 io_delegate_.SetFileContents("old/p/I.aidl",
2185 "package p; interface I {"
2186 "const int A = 1; const int B = 2;}");
2187 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002188 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002189 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002191}
Jiyong Parka428d212018-08-29 22:26:30 +09002192
Daniel Norman85aed542019-08-21 12:01:14 -07002193TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002194 const string expected_stderr =
2195 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002196 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2197 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002198 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002199 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002201}
2202
Devin Moorec7e47a32020-08-07 10:55:25 -07002203TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2204 const string expected_stderr =
2205 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2206 "This is an incompatible change for FixedSize types.\n";
2207 io_delegate_.SetFileContents("old/p/Foo.aidl",
2208 "package p; @FixedSize parcelable Foo { int A = 1; }");
2209 io_delegate_.SetFileContents("new/p/Foo.aidl",
2210 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2211 CaptureStderr();
2212 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2213 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2214}
2215
2216TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2217 const string expected_stderr =
2218 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2219 io_delegate_.SetFileContents("old/p/Foo.aidl",
2220 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2221 io_delegate_.SetFileContents("new/p/Foo.aidl",
2222 "package p; @FixedSize parcelable Foo { int A = 1; }");
2223 CaptureStderr();
2224 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2225 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2226}
2227
2228TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2229 const string expected_stderr =
2230 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2231 "a.\n"
2232 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2233 "b.\n"
2234 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2235 "c.\n"
2236 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2237 "d.\n"
2238 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2239 "e.\n"
2240 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2241 "f.\n";
2242
2243 io_delegate_.SetFileContents("Foo.aidl",
2244 "@FixedSize parcelable Foo { "
2245 " int[] a;"
2246 " Bar b;"
2247 " String c;"
2248 " ParcelFileDescriptor d;"
2249 " IBinder e;"
2250 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002251 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002252 "}");
2253 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2254 Options options =
2255 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2256
2257 CaptureStderr();
2258 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2260}
2261
2262TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2263 const string expected_stderr = "";
2264
2265 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2266 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2267 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2268 Options options =
2269 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2270
2271 CaptureStderr();
2272 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2274}
2275
Jiyong Park8c380532018-08-30 14:55:26 +09002276TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002277 const string expected_stderr =
2278 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2279 "dir1/q/IBar.aidl\n"
2280 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002281 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002282 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2283 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2284 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2285 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2286
Devin Moore097a3ab2020-03-11 16:08:44 -07002287 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002288 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002290}
2291
Jiyong Parked65bf42018-08-28 15:43:27 +09002292TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002293 const string expected_stderr =
2294 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2295 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002296 Options options = Options::From("aidl --checkapi old new");
2297 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2298 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002299
2300 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2301
Jiyong Parke59c3682018-09-11 23:10:25 +09002302 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002304 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002305 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002306}
2307
Jiyong Parke05195e2018-10-08 18:24:23 +09002308TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2309 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2310 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002311 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002312
2313 // use without import
2314 io_delegate_.SetFileContents("p/IFoo.aidl",
2315 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2316 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2317 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002318 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002319
Devin Moore7b8d5c92020-03-17 14:14:08 -07002320 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002321 io_delegate_.SetFileContents(
2322 "p/IFoo.aidl",
2323 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2324 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2325 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002326 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002327
2328 // use with import (as before)
2329 io_delegate_.SetFileContents("p/IFoo.aidl",
2330 "package p;"
2331 "import android.os.ParcelFileDescriptor;"
2332 "interface IFoo{"
2333 " void foo(in ParcelFileDescriptor fd);"
2334 "}");
2335 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2336 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002337 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002338}
Jiyong Parked65bf42018-08-28 15:43:27 +09002339
Jiyong Park3633b722019-04-11 15:38:26 +09002340TEST_F(AidlTest, ManualIds) {
2341 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2342 io_delegate_.SetFileContents("IFoo.aidl",
2343 "interface IFoo {\n"
2344 " void foo() = 0;\n"
2345 " void bar() = 1;\n"
2346 "}");
2347 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2348}
2349
2350TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2351 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2352 io_delegate_.SetFileContents("IFoo.aidl",
2353 "interface IFoo {\n"
2354 " void foo() = 0;\n"
2355 " void bar() = 1;\n"
2356 "}");
2357 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2358}
2359
2360TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002361 const string expected_stderr =
2362 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002363 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2364 io_delegate_.SetFileContents("IFoo.aidl",
2365 "interface IFoo {\n"
2366 " void foo() = 3;\n"
2367 " void bar() = 3;\n"
2368 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002370 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002371 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002372}
2373
2374TEST_F(AidlTest, FailOnOutOfRangeIds) {
2375 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002376 const string expected_stderr =
2377 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2378 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002379 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2380 io_delegate_.SetFileContents("IFoo.aidl",
2381 "interface IFoo {\n"
2382 " void foo() = 3;\n"
2383 " void bar() = 16777115;\n"
2384 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002385 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002386 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002388}
2389
2390TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002391 const string expected_stderr =
2392 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002393 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2394 io_delegate_.SetFileContents("IFoo.aidl",
2395 "interface IFoo {\n"
2396 " void foo() = 3;\n"
2397 " void bar();\n"
2398 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002399 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002400 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002401 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002402}
2403
Jiyong Parkc6816252019-07-08 08:12:28 +09002404TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2405 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2406 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2407 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2408 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2409}
2410
2411TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002412 const string expected_stderr =
2413 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2414 "dir/IBar.aidl\n"
2415 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002416 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002417
Jiyong Parkc6816252019-07-08 08:12:28 +09002418 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2419 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2420 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2421 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002422 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002423 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002425}
2426
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002427TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2428 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2429 "package a.b;\n"
2430 "import a.b.IBar;\n"
2431 "import a.b.IQux;\n"
2432 "interface IFoo { IQux foo(); }\n");
2433 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2434 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2435
2436 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2437 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2438
2439 string output;
2440 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2441 // IBar was imported but wasn't used. include is not expected.
2442 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2443 // IBar was imported and used. include is expected.
2444 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2445}
2446
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002447TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002448 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002449 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002450 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2451 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002452 interface IFoo {
2453 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002454 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002455 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002456 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002457 // JavaPassthrough should work with other types as well (e.g. enum)
2458 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2459 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2460 @JavaPassthrough(annotation="@com.android.AliceTwo")
2461 @Backing(type="byte")
2462 enum MyEnum {
2463 a, b, c
2464 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002465
Jooyung Han4cde01d2020-10-13 11:10:47 +09002466 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002467 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2468
2469 string java_out;
2470 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002471 // type-decl-level annotations with newline at the end
2472 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2473 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2474 // member-decl-level annotations with newline at the end
2475 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2476 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2477 // inline annotations with space at the end
2478 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002479
Jooyung Han4cde01d2020-10-13 11:10:47 +09002480 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2481 // type-decl-level annotations with newline at the end
2482 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2483 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2484
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002485 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002486 Options cpp_options =
2487 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002488 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2489
Jooyung Han4cde01d2020-10-13 11:10:47 +09002490 Options ndk_options =
2491 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002492 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002493
Jooyung Han4cde01d2020-10-13 11:10:47 +09002494 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002495 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002496}
2497
Andrei Homescue61feb52020-08-18 15:44:24 -07002498TEST_F(AidlTest, ParseRustDerive) {
2499 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2500 @RustDerive(Clone=true, Copy=false)
2501 parcelable Foo {
2502 int a;
2503 })");
2504
2505 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2506 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2507
2508 string rust_out;
2509 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2510 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2511
2512 // Other backends shouldn't be bothered
2513 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2514 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2515
2516 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2517 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2518
2519 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2520 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2521}
2522
Jiyong Park56f73d72019-06-11 12:20:28 +09002523class AidlOutputPathTest : public AidlTest {
2524 protected:
2525 void SetUp() override {
2526 AidlTest::SetUp();
2527 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2528 }
2529
2530 void Test(const Options& options, const std::string expected_output_path) {
2531 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2532 // check the existence
2533 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2534 }
2535};
2536
2537TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2538 // <out_dir> / <package_name> / <type_name>.java
2539 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2540}
2541
2542TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2543 // when output file is explicitly set, it is always respected. -o option is
2544 // ignored.
2545 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2546}
2547
2548TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2549 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2550}
2551
2552TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2553 // output is the same as the input file except for the suffix
2554 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2555}
2556
Devin Moore7b8d5c92020-03-17 14:14:08 -07002557TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002558 AidlError error;
2559 const string expected_stderr =
2560 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2561 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002562 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2563 R"(package p;
2564 interface IFoo {
2565 const int int32_max_oob = 2147483650;
2566 }
2567 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002568 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002569 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2570 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002571}
2572
Devin Moore7b8d5c92020-03-17 14:14:08 -07002573TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002574 AidlError error;
2575 const string expected_stderr =
2576 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2577 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002578 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2579 R"(package p;
2580 interface IFoo {
2581 const int int32_min_oob = -2147483650;
2582 }
2583 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002584 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002585 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2586 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002587}
2588
Devin Moore7b8d5c92020-03-17 14:14:08 -07002589TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 AidlError error;
2591 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002592 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002593 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002594 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2595 R"(package p;
2596 interface IFoo {
2597 const long int64_max_oob = 21474836509999999999999999;
2598 }
2599 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002600 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002601 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2602 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002603}
2604
Devin Moore7b8d5c92020-03-17 14:14:08 -07002605TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002606 AidlError error;
2607 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002608 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002609 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002610 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2611 R"(package p;
2612 interface IFoo {
2613 const long int64_min_oob = -21474836509999999999999999;
2614 }
2615 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002616 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002617 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2618 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002619}
2620
Devin Moore7b8d5c92020-03-17 14:14:08 -07002621TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002622 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002623 const string expected_stderr =
2624 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2625 "literal: byte\n"
2626 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2627 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002628 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2629 R"(package p;
2630 @Backing(type="byte")
2631 enum TestEnum {
2632 FOO = 127,
2633 BAR,
2634 }
2635 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002636 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002637 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002638 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002639}
2640
Devin Mooredecaf292020-04-30 09:16:40 -07002641TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2642 AidlError error;
2643 const string expected_stderr =
2644 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2645 "be one of: type\n"
2646 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2647 "be one of: type\n";
2648 CaptureStderr();
2649 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2650 R"(package p;
2651 @Backing(foo="byte")
2652 enum TestEnum {
2653 FOO = 1,
2654 BAR,
2655 }
2656 )",
2657 typenames_, GetLanguage(), &error));
2658 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2659 EXPECT_EQ(AidlError::BAD_TYPE, error);
2660}
2661
Jeongik Chad0a10272020-08-06 16:33:36 +09002662TEST_P(AidlTest, SupportJavaOnlyImmutableAnnotation) {
2663 io_delegate_.SetFileContents("Foo.aidl",
2664 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2665 "Map<String, Baz> d; Bar[] e; }");
2666 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2667 io_delegate_.SetFileContents("Baz.aidl",
2668 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002669 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2670 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2671}
2672
Jeongik Chad0a10272020-08-06 16:33:36 +09002673TEST_P(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
2674 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002675 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2676 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2678}
2679
2680TEST_P(AidlTest, ImmtuableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002681 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002682 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2683 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2684 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2685}
2686
2687TEST_P(AidlTest, ImmtuableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002688 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002689 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2690 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2691 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2692}
2693
Jeongik Cha91180252020-07-31 15:43:11 +09002694TEST_P(AidlTest, ImmtuableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002695 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002696 Options options = Options::From("aidl --lang=java Foo.aidl");
2697 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002698 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002699 "capitalizing the first letter\n";
2700 CaptureStderr();
2701 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2702 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2703}
Devin Moore53fc99c2020-08-12 08:07:52 -07002704
Jooyung Han1f14ab32020-10-14 13:48:29 +09002705const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2706
2707#include <a/ByteEnum.h>
2708#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002709#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002710#include <binder/Status.h>
2711#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002712#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002713#include <utility>
2714#include <variant>
2715#include <vector>
2716
2717namespace a {
2718
2719class Foo : public ::android::Parcelable {
2720public:
Jooyung Han97945de2020-10-15 16:41:38 +09002721 inline bool operator!=(const Foo& rhs) const {
2722 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002723 }
Jooyung Han97945de2020-10-15 16:41:38 +09002724 inline bool operator<(const Foo& rhs) const {
2725 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002726 }
Jooyung Han97945de2020-10-15 16:41:38 +09002727 inline bool operator<=(const Foo& rhs) const {
2728 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002729 }
Jooyung Han97945de2020-10-15 16:41:38 +09002730 inline bool operator==(const Foo& rhs) const {
2731 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002732 }
Jooyung Han97945de2020-10-15 16:41:38 +09002733 inline bool operator>(const Foo& rhs) const {
2734 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002735 }
Jooyung Han97945de2020-10-15 16:41:38 +09002736 inline bool operator>=(const Foo& rhs) const {
2737 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002738 }
Jooyung Han97945de2020-10-15 16:41:38 +09002739
Jooyung Han1f14ab32020-10-14 13:48:29 +09002740 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002741 ns = 0, // int[] ns;
2742 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002743 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002744 };
Jooyung Han97945de2020-10-15 16:41:38 +09002745
Jooyung Han1f14ab32020-10-14 13:48:29 +09002746 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002747 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002748
2749 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002750 Foo(const Foo&) = default;
2751 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002752 Foo& operator=(const Foo&) = default;
2753 Foo& operator=(Foo&&) = default;
2754
Jooyung Han97945de2020-10-15 16:41:38 +09002755 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2756 constexpr Foo(_Tp&& _arg)
2757 : _value(std::forward<_Tp>(_arg)) {}
2758
2759 template <typename... _Tp>
2760 constexpr explicit Foo(_Tp&&... _args)
2761 : _value(std::forward<_Tp>(_args)...) {}
2762
2763 template <Tag _tag, typename... _Tp>
2764 static Foo make(_Tp&&... _args) {
2765 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002766 }
Jooyung Han97945de2020-10-15 16:41:38 +09002767
2768 template <Tag _tag, typename _Tp, typename... _Up>
2769 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2770 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002771 }
2772
2773 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002774 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002775 }
2776
Jooyung Han97945de2020-10-15 16:41:38 +09002777 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002778 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002779 if (getTag() != _tag) { abort(); }
2780 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002781 }
2782
Jooyung Han97945de2020-10-15 16:41:38 +09002783 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002784 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002785 if (getTag() != _tag) { abort(); }
2786 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002787 }
2788
Jooyung Han97945de2020-10-15 16:41:38 +09002789 template <Tag _tag, typename... _Tp>
2790 void set(_Tp&&... _args) {
2791 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002792 }
2793
2794 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2795 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2796 static const std::string& getParcelableDescriptor() {
2797 static const std::string DESCIPTOR = "a.Foo";
2798 return DESCIPTOR;
2799 }
2800private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002801 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002802}; // class Foo
2803
2804} // namespace a
2805)";
2806
2807const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2808
2809namespace a {
2810
2811::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2812 ::android::status_t _aidl_ret_status;
2813 int32_t _aidl_tag;
2814 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2815 switch (_aidl_tag) {
2816 case ns: {
2817 ::std::vector<int32_t> _aidl_value;
2818 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2819 set<ns>(std::move(_aidl_value));
2820 return ::android::OK; }
2821 case e: {
2822 ::a::ByteEnum _aidl_value;
2823 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2824 set<e>(std::move(_aidl_value));
2825 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002826 case pfd: {
2827 ::android::os::ParcelFileDescriptor _aidl_value;
2828 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2829 set<pfd>(std::move(_aidl_value));
2830 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09002831 }
2832 return ::android::BAD_VALUE;
2833}
2834
2835::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2836 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2837 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2838 switch (getTag()) {
2839 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2840 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002841 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002842 }
2843 abort();
2844}
2845
2846} // namespace a
2847)";
2848
Jooyung Han6beac042020-10-17 21:59:43 +09002849const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
2850#include <android/binder_interface_utils.h>
2851#include <android/binder_parcelable_utils.h>
2852
2853#include <type_traits>
2854#include <utility>
2855#include <variant>
2856#include <cstdint>
2857#include <memory>
2858#include <optional>
2859#include <string>
2860#include <vector>
2861#ifdef BINDER_STABILITY_SUPPORT
2862#include <android/binder_stability.h>
2863#endif // BINDER_STABILITY_SUPPORT
2864#include <aidl/a/ByteEnum.h>
2865namespace aidl {
2866namespace a {
2867class Foo {
2868public:
2869 typedef std::false_type fixed_size;
2870 static const char* descriptor;
2871
2872 enum Tag : int32_t {
2873 ns = 0, // int[] ns;
2874 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002875 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09002876 };
2877
2878 template<typename _Tp>
2879 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
2880
2881 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
2882 Foo(const Foo&) = default;
2883 Foo(Foo&&) = default;
2884 Foo& operator=(const Foo&) = default;
2885 Foo& operator=(Foo&&) = default;
2886
2887 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2888 constexpr Foo(_Tp&& _arg)
2889 : _value(std::forward<_Tp>(_arg)) {}
2890
2891 template <typename... _Tp>
2892 constexpr explicit Foo(_Tp&&... _args)
2893 : _value(std::forward<_Tp>(_args)...) {}
2894
2895 template <Tag _tag, typename... _Tp>
2896 static Foo make(_Tp&&... _args) {
2897 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
2898 }
2899
2900 template <Tag _tag, typename _Tp, typename... _Up>
2901 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2902 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
2903 }
2904
2905 Tag getTag() const {
2906 return static_cast<Tag>(_value.index());
2907 }
2908
2909 template <Tag _tag>
2910 const auto& get() const {
2911 if (getTag() != _tag) { abort(); }
2912 return std::get<_tag>(_value);
2913 }
2914
2915 template <Tag _tag>
2916 auto& get() {
2917 if (getTag() != _tag) { abort(); }
2918 return std::get<_tag>(_value);
2919 }
2920
2921 template <Tag _tag, typename... _Tp>
2922 void set(_Tp&&... _args) {
2923 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
2924 }
2925
2926 binder_status_t readFromParcel(const AParcel* _parcel);
2927 binder_status_t writeToParcel(AParcel* _parcel) const;
2928 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
2929private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002930 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09002931};
2932} // namespace a
2933} // namespace aidl
2934)";
2935
2936const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
2937
2938#include <android/binder_parcel_utils.h>
2939
2940namespace aidl {
2941namespace a {
2942const char* Foo::descriptor = "a.Foo";
2943
2944binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
2945 binder_status_t _aidl_ret_status;
2946 int32_t _aidl_tag;
2947 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
2948 switch (_aidl_tag) {
2949 case ns: {
2950 std::vector<int32_t> _aidl_value;
2951 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
2952 set<ns>(std::move(_aidl_value));
2953 return STATUS_OK; }
2954 case e: {
2955 ::aidl::a::ByteEnum _aidl_value;
2956 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
2957 set<e>(std::move(_aidl_value));
2958 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002959 case pfd: {
2960 ::ndk::ScopedFileDescriptor _aidl_value;
2961 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
2962 set<pfd>(std::move(_aidl_value));
2963 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09002964 }
2965 return STATUS_BAD_VALUE;
2966}
2967binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
2968 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
2969 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
2970 switch (getTag()) {
2971 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
2972 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002973 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09002974 }
2975 abort();
2976}
2977
2978} // namespace a
2979} // namespace aidl
2980)";
2981
Jooyung Han1f14ab32020-10-14 13:48:29 +09002982const char kUnionExampleExpectedOutputJava[] = R"(/*
2983 * This file is auto-generated. DO NOT MODIFY.
2984 */
2985package a;
2986
2987
2988public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09002989 // tags for union fields
2990 public final static int ns = 0; // int[] ns;
2991 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002992 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002993
2994 private int _tag;
2995 private Object _value;
2996
2997 public Foo() {
2998 int[] value = {42};
2999 _set(ns, value);
3000 }
Jooyung Han97945de2020-10-15 16:41:38 +09003001
Jooyung Han1f14ab32020-10-14 13:48:29 +09003002 private Foo(android.os.Parcel _aidl_parcel) {
3003 readFromParcel(_aidl_parcel);
3004 }
Jooyung Han97945de2020-10-15 16:41:38 +09003005
Jooyung Han1f14ab32020-10-14 13:48:29 +09003006 private Foo(int tag, Object value) {
3007 _set(tag, value);
3008 }
3009
3010 public int getTag() {
3011 return _tag;
3012 }
3013
Jooyung Han97945de2020-10-15 16:41:38 +09003014 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003015
3016 public static Foo ns(int[] _value) {
3017 return new Foo(ns, _value);
3018 }
Jooyung Han97945de2020-10-15 16:41:38 +09003019
Jooyung Han1f14ab32020-10-14 13:48:29 +09003020 public int[] getNs() {
3021 _assertTag(ns);
3022 return (int[]) _value;
3023 }
Jooyung Han97945de2020-10-15 16:41:38 +09003024
Jooyung Han1f14ab32020-10-14 13:48:29 +09003025 public void setNs(int[] _value) {
3026 _set(ns, _value);
3027 }
3028
Jooyung Han97945de2020-10-15 16:41:38 +09003029 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003030
3031 public static Foo e(byte _value) {
3032 return new Foo(e, _value);
3033 }
Jooyung Han97945de2020-10-15 16:41:38 +09003034
Jooyung Han1f14ab32020-10-14 13:48:29 +09003035 public byte getE() {
3036 _assertTag(e);
3037 return (byte) _value;
3038 }
Jooyung Han97945de2020-10-15 16:41:38 +09003039
Jooyung Han1f14ab32020-10-14 13:48:29 +09003040 public void setE(byte _value) {
3041 _set(e, _value);
3042 }
3043
Jooyung Hand2fa0232020-10-19 02:51:41 +09003044 // ParcelFileDescriptor pfd;
3045
3046 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3047 return new Foo(pfd, _value);
3048 }
3049
3050 public android.os.ParcelFileDescriptor getPfd() {
3051 _assertTag(pfd);
3052 return (android.os.ParcelFileDescriptor) _value;
3053 }
3054
3055 public void setPfd(android.os.ParcelFileDescriptor _value) {
3056 _set(pfd, _value);
3057 }
3058
Jooyung Han1f14ab32020-10-14 13:48:29 +09003059 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3060 @Override
3061 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003062 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003063 }
3064 @Override
3065 public Foo[] newArray(int _aidl_size) {
3066 return new Foo[_aidl_size];
3067 }
3068 };
Jooyung Han97945de2020-10-15 16:41:38 +09003069
Jooyung Han1f14ab32020-10-14 13:48:29 +09003070 @Override
3071 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3072 _aidl_parcel.writeInt(_tag);
3073 switch (_tag) {
3074 case ns:
3075 _aidl_parcel.writeIntArray(getNs());
3076 break;
3077 case e:
3078 _aidl_parcel.writeByte(getE());
3079 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003080 case pfd:
3081 if ((getPfd()!=null)) {
3082 _aidl_parcel.writeInt(1);
3083 getPfd().writeToParcel(_aidl_parcel, 0);
3084 }
3085 else {
3086 _aidl_parcel.writeInt(0);
3087 }
3088 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003089 }
3090 }
Jooyung Han97945de2020-10-15 16:41:38 +09003091
Jooyung Han1f14ab32020-10-14 13:48:29 +09003092 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3093 int _aidl_tag;
3094 _aidl_tag = _aidl_parcel.readInt();
3095 switch (_aidl_tag) {
3096 case ns: {
3097 int[] _aidl_value;
3098 _aidl_value = _aidl_parcel.createIntArray();
3099 _set(_aidl_tag, _aidl_value);
3100 return; }
3101 case e: {
3102 byte _aidl_value;
3103 _aidl_value = _aidl_parcel.readByte();
3104 _set(_aidl_tag, _aidl_value);
3105 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003106 case pfd: {
3107 android.os.ParcelFileDescriptor _aidl_value;
3108 if ((0!=_aidl_parcel.readInt())) {
3109 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3110 }
3111 else {
3112 _aidl_value = null;
3113 }
3114 _set(_aidl_tag, _aidl_value);
3115 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003116 }
3117 throw new RuntimeException("union: out of range: " + _aidl_tag);
3118 }
Jooyung Han97945de2020-10-15 16:41:38 +09003119
Jooyung Han1f14ab32020-10-14 13:48:29 +09003120 @Override
3121 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003122 int _mask = 0;
3123 switch (getTag()) {
3124 case pfd:
3125 if (getPfd() != null) _mask |= getPfd().describeContents();
3126 break;
3127 }
3128 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003129 }
3130
3131 private void _assertTag(int tag) {
3132 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003133 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003134 }
3135 }
Jooyung Han97945de2020-10-15 16:41:38 +09003136
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137 private String _tagString(int _tag) {
3138 switch (_tag) {
3139 case ns: return "ns";
3140 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003141 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003142 }
3143 throw new IllegalStateException("unknown field: " + _tag);
3144 }
Jooyung Han97945de2020-10-15 16:41:38 +09003145
Jooyung Han1f14ab32020-10-14 13:48:29 +09003146 private void _set(int tag, Object value) {
3147 this._tag = tag;
3148 this._value = value;
3149 }
3150}
3151)";
3152
Jooyung Han97945de2020-10-15 16:41:38 +09003153struct AidlUnionTest : ::testing::Test {
3154 void SetUp() override {
3155 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003156package a;
3157import a.ByteEnum;
3158union Foo {
3159 int[] ns = {42};
3160 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003161 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003162}
3163)");
Jooyung Han97945de2020-10-15 16:41:38 +09003164 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003165package a;
3166@Backing(type="byte")
3167enum ByteEnum {
3168 a, b, c
3169}
3170)");
Jooyung Han97945de2020-10-15 16:41:38 +09003171 }
3172 FakeIoDelegate io_delegate_;
3173 void Compile(string lang) {
3174 string command = "aidl --structured -I. -o out --lang=" + lang;
3175 if (lang == "cpp" || lang == "ndk") {
3176 command += " -h out";
3177 }
3178 command += " a/Foo.aidl";
3179 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003180 CaptureStderr();
3181 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3182 auto err = GetCapturedStderr();
3183 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003184 }
3185 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3186 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187 string actual;
3188 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3189 EXPECT_EQ(expected, actual);
3190 }
Jooyung Han97945de2020-10-15 16:41:38 +09003191 }
3192};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003193
Jooyung Han97945de2020-10-15 16:41:38 +09003194TEST_F(AidlUnionTest, Example_Cpp) {
3195 Compile("cpp");
3196 EXPECT_COMPILE_OUTPUTS(
3197 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3198 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3199}
3200
Jooyung Han6beac042020-10-17 21:59:43 +09003201TEST_F(AidlUnionTest, Example_Ndk) {
3202 Compile("ndk");
3203 EXPECT_COMPILE_OUTPUTS(
3204 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3205 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3206}
3207
Jooyung Han97945de2020-10-15 16:41:38 +09003208TEST_F(AidlUnionTest, Example_Java) {
3209 Compile("java");
3210 EXPECT_COMPILE_OUTPUTS(
3211 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003212 // TODO(b/170689477) Rust
3213}
3214
Jooyung Hanfe89f122020-10-14 03:49:18 +09003215TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3216 const string method = "package a; union Foo {}";
3217 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3218 CaptureStderr();
3219 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3220 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3221}
3222
3223TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3224 const string method = "package a; union Foo { ParcelableHolder x; }";
3225 const string expected_stderr =
3226 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3227 CaptureStderr();
3228 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3229 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3230}
3231
Devin Moore53fc99c2020-08-12 08:07:52 -07003232TEST_P(AidlTest, GenericStructuredParcelable) {
3233 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3234 Options options =
3235 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3236 const string expected_stderr = "";
3237 CaptureStderr();
3238 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3240}
3241
Jooyung Han14004ed2020-10-16 03:49:57 +09003242struct GenericAidlTest : ::testing::Test {
3243 FakeIoDelegate io_delegate_;
3244 void Compile(string cmd) {
3245 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3246 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3247 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3248 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3249
3250 Options options = Options::From(cmd);
3251 CaptureStderr();
3252 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3253 EXPECT_EQ("", GetCapturedStderr());
3254 }
3255};
3256
3257TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3258 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3259 string code;
3260 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3261 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3262 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3263 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3264}
3265
3266TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3267 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3268 string code;
3269 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3270 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3271 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3272 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3273}
3274
Devin Moore53fc99c2020-08-12 08:07:52 -07003275TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3276 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3277 Options options =
3278 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3279 const string expected_stderr =
3280 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3281 CaptureStderr();
3282 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3284}
3285
3286TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3287 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3288 Options options =
3289 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3290 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3291 CaptureStderr();
3292 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3293 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3294}
3295
Christopher Wiley90be4e32015-10-20 14:55:25 -07003296} // namespace aidl
3297} // namespace android