blob: 19a37c1814036239d4bd4dc8cd4dab2eb65e979f [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
20#include "llvm/Analysis/MemoryBuiltins.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000021#include "llvm/Analysis/TargetLibraryInfo.h"
22#include "llvm/Analysis/VectorUtils.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000023#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000025#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000026#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000027#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000029#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000030
Chris Lattner2188e402010-01-04 07:37:31 +000031using namespace llvm;
32using namespace PatternMatch;
33
Chandler Carruth964daaa2014-04-22 02:55:47 +000034#define DEBUG_TYPE "instcombine"
35
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000036// How many times is a select replaced by one of its operands?
37STATISTIC(NumSel, "Number of select opts");
38
Chris Lattner98457102011-02-10 05:23:05 +000039
Sanjay Pateld93c4c02016-09-15 18:22:25 +000040static ConstantInt *extractElement(Constant *V, Constant *Idx) {
Chris Lattner2188e402010-01-04 07:37:31 +000041 return cast<ConstantInt>(ConstantExpr::getExtractElement(V, Idx));
42}
43
Sanjay Pateld93c4c02016-09-15 18:22:25 +000044static bool hasAddOverflow(ConstantInt *Result,
Chris Lattner2188e402010-01-04 07:37:31 +000045 ConstantInt *In1, ConstantInt *In2,
46 bool IsSigned) {
Chris Lattnerb1a15122011-07-15 06:08:15 +000047 if (!IsSigned)
Chris Lattner2188e402010-01-04 07:37:31 +000048 return Result->getValue().ult(In1->getValue());
Chris Lattnerb1a15122011-07-15 06:08:15 +000049
50 if (In2->isNegative())
51 return Result->getValue().sgt(In1->getValue());
52 return Result->getValue().slt(In1->getValue());
Chris Lattner2188e402010-01-04 07:37:31 +000053}
54
Sanjay Patel5f0217f2016-06-05 16:46:18 +000055/// Compute Result = In1+In2, returning true if the result overflowed for this
56/// type.
Sanjay Pateld93c4c02016-09-15 18:22:25 +000057static bool addWithOverflow(Constant *&Result, Constant *In1,
Chris Lattner2188e402010-01-04 07:37:31 +000058 Constant *In2, bool IsSigned = false) {
59 Result = ConstantExpr::getAdd(In1, In2);
60
Chris Lattner229907c2011-07-18 04:54:35 +000061 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) {
Chris Lattner2188e402010-01-04 07:37:31 +000062 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) {
63 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i);
Sanjay Pateld93c4c02016-09-15 18:22:25 +000064 if (hasAddOverflow(extractElement(Result, Idx),
65 extractElement(In1, Idx),
66 extractElement(In2, Idx),
Chris Lattner2188e402010-01-04 07:37:31 +000067 IsSigned))
68 return true;
69 }
70 return false;
71 }
72
Sanjay Pateld93c4c02016-09-15 18:22:25 +000073 return hasAddOverflow(cast<ConstantInt>(Result),
Chris Lattner2188e402010-01-04 07:37:31 +000074 cast<ConstantInt>(In1), cast<ConstantInt>(In2),
75 IsSigned);
76}
77
Sanjay Pateld93c4c02016-09-15 18:22:25 +000078static bool hasSubOverflow(ConstantInt *Result,
Chris Lattner2188e402010-01-04 07:37:31 +000079 ConstantInt *In1, ConstantInt *In2,
80 bool IsSigned) {
Chris Lattnerb1a15122011-07-15 06:08:15 +000081 if (!IsSigned)
Chris Lattner2188e402010-01-04 07:37:31 +000082 return Result->getValue().ugt(In1->getValue());
Jim Grosbach129c52a2011-09-30 18:09:53 +000083
Chris Lattnerb1a15122011-07-15 06:08:15 +000084 if (In2->isNegative())
85 return Result->getValue().slt(In1->getValue());
86
87 return Result->getValue().sgt(In1->getValue());
Chris Lattner2188e402010-01-04 07:37:31 +000088}
89
Sanjay Patel5f0217f2016-06-05 16:46:18 +000090/// Compute Result = In1-In2, returning true if the result overflowed for this
91/// type.
Sanjay Pateld93c4c02016-09-15 18:22:25 +000092static bool subWithOverflow(Constant *&Result, Constant *In1,
Chris Lattner2188e402010-01-04 07:37:31 +000093 Constant *In2, bool IsSigned = false) {
94 Result = ConstantExpr::getSub(In1, In2);
95
Chris Lattner229907c2011-07-18 04:54:35 +000096 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) {
Chris Lattner2188e402010-01-04 07:37:31 +000097 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) {
98 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i);
Sanjay Pateld93c4c02016-09-15 18:22:25 +000099 if (hasSubOverflow(extractElement(Result, Idx),
100 extractElement(In1, Idx),
101 extractElement(In2, Idx),
Chris Lattner2188e402010-01-04 07:37:31 +0000102 IsSigned))
103 return true;
104 }
105 return false;
106 }
107
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000108 return hasSubOverflow(cast<ConstantInt>(Result),
Chris Lattner2188e402010-01-04 07:37:31 +0000109 cast<ConstantInt>(In1), cast<ConstantInt>(In2),
110 IsSigned);
111}
112
Balaram Makam569eaec2016-05-04 21:32:14 +0000113/// Given an icmp instruction, return true if any use of this comparison is a
114/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +0000115static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +0000116 for (auto *U : I.users())
117 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +0000118 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +0000119 return false;
120}
121
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000122/// Given an exploded icmp instruction, return true if the comparison only
123/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
124/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +0000125static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000126 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +0000128 case ICmpInst::ICMP_SLT: // True if LHS s< 0
129 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +0000130 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000131 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
132 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000133 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000134 case ICmpInst::ICMP_SGT: // True if LHS s> -1
135 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +0000136 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000137 case ICmpInst::ICMP_UGT:
138 // True if LHS u> RHS and RHS == high-bit-mask - 1
139 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000140 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +0000142 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
143 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +0000144 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 default:
146 return false;
147 }
148}
149
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000150/// Returns true if the exploded icmp can be expressed as a signed comparison
151/// to zero and updates the predicate accordingly.
152/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000153/// TODO: Refactor with decomposeBitTestICmp()?
154static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000155 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000156 return false;
157
Craig Topper73ba1c82017-06-07 07:40:37 +0000158 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000159 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000160
Craig Topper73ba1c82017-06-07 07:40:37 +0000161 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000162 if (Pred == ICmpInst::ICMP_SLT) {
163 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000164 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000165 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000166 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167 if (Pred == ICmpInst::ICMP_SGT) {
168 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000169 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000170 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000171 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000172
173 return false;
174}
175
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000176/// Given a signed integer type and a set of known zero and one bits, compute
177/// the maximum and minimum values that could have the specified known zero and
178/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000179/// TODO: Move to method on KnownBits struct?
180static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000181 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000182 assert(Known.getBitWidth() == Min.getBitWidth() &&
183 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000184 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000185 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000186
187 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
188 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000189 Min = Known.One;
190 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000191
Chris Lattner2188e402010-01-04 07:37:31 +0000192 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000193 Min.setSignBit();
194 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000195 }
196}
197
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000198/// Given an unsigned integer type and a set of known zero and one bits, compute
199/// the maximum and minimum values that could have the specified known zero and
200/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000201/// TODO: Move to method on KnownBits struct?
202static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000203 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000204 assert(Known.getBitWidth() == Min.getBitWidth() &&
205 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000206 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000207 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner2188e402010-01-04 07:37:31 +0000209 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000210 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000211 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000212 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000213}
214
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000215/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000216/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000217/// where GV is a global variable with a constant initializer. Try to simplify
218/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000219/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
220///
221/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000222/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000223Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
224 GlobalVariable *GV,
225 CmpInst &ICI,
226 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000227 Constant *Init = GV->getInitializer();
228 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000229 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000230
Chris Lattnerfe741762012-01-31 02:55:06 +0000231 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000232 // Don't blow up on huge arrays.
233 if (ArrayElementCount > MaxArraySizeForCombine)
234 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 // There are many forms of this optimization we can handle, for now, just do
237 // the simple index into a single-dimensional array.
238 //
239 // Require: GEP GV, 0, i {{, constant indices}}
240 if (GEP->getNumOperands() < 3 ||
241 !isa<ConstantInt>(GEP->getOperand(1)) ||
242 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
243 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000244 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000245
246 // Check that indices after the variable are constants and in-range for the
247 // type they index. Collect the indices. This is typically for arrays of
248 // structs.
249 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000250
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000252 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
253 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000257 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner229907c2011-07-18 04:54:35 +0000259 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000260 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000261 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000262 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000263 EltTy = ATy->getElementType();
264 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000265 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000266 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000267
Chris Lattner2188e402010-01-04 07:37:31 +0000268 LaterIndices.push_back(IdxVal);
269 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000270
Chris Lattner2188e402010-01-04 07:37:31 +0000271 enum { Overdefined = -3, Undefined = -2 };
272
273 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000274
Chris Lattner2188e402010-01-04 07:37:31 +0000275 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
276 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
277 // and 87 is the second (and last) index. FirstTrueElement is -2 when
278 // undefined, otherwise set to the first true element. SecondTrueElement is
279 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
280 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
281
282 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
283 // form "i != 47 & i != 87". Same state transitions as for true elements.
284 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000285
Chris Lattner2188e402010-01-04 07:37:31 +0000286 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
287 /// define a state machine that triggers for ranges of values that the index
288 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
289 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
290 /// index in the range (inclusive). We use -2 for undefined here because we
291 /// use relative comparisons and don't want 0-1 to match -1.
292 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000293
Chris Lattner2188e402010-01-04 07:37:31 +0000294 // MagicBitvector - This is a magic bitvector where we set a bit if the
295 // comparison is true for element 'i'. If there are 64 elements or less in
296 // the array, this will fully represent all the comparison results.
297 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000298
Chris Lattner2188e402010-01-04 07:37:31 +0000299 // Scan the array and see if one of our patterns matches.
300 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000301 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
302 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000303 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000304
Chris Lattner2188e402010-01-04 07:37:31 +0000305 // If this is indexing an array of structures, get the structure element.
306 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000307 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000308
Chris Lattner2188e402010-01-04 07:37:31 +0000309 // If the element is masked, handle it.
310 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000311
Chris Lattner2188e402010-01-04 07:37:31 +0000312 // Find out if the comparison would be true or false for the i'th element.
313 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000314 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000315 // If the result is undef for this element, ignore it.
316 if (isa<UndefValue>(C)) {
317 // Extend range state machines to cover this element in case there is an
318 // undef in the middle of the range.
319 if (TrueRangeEnd == (int)i-1)
320 TrueRangeEnd = i;
321 if (FalseRangeEnd == (int)i-1)
322 FalseRangeEnd = i;
323 continue;
324 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If we can't compute the result for any of the elements, we have to give
327 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000328 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000329
Chris Lattner2188e402010-01-04 07:37:31 +0000330 // Otherwise, we know if the comparison is true or false for this element,
331 // update our state machines.
332 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000333
Chris Lattner2188e402010-01-04 07:37:31 +0000334 // State machine for single/double/range index comparison.
335 if (IsTrueForElt) {
336 // Update the TrueElement state machine.
337 if (FirstTrueElement == Undefined)
338 FirstTrueElement = TrueRangeEnd = i; // First true element.
339 else {
340 // Update double-compare state machine.
341 if (SecondTrueElement == Undefined)
342 SecondTrueElement = i;
343 else
344 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000345
Chris Lattner2188e402010-01-04 07:37:31 +0000346 // Update range state machine.
347 if (TrueRangeEnd == (int)i-1)
348 TrueRangeEnd = i;
349 else
350 TrueRangeEnd = Overdefined;
351 }
352 } else {
353 // Update the FalseElement state machine.
354 if (FirstFalseElement == Undefined)
355 FirstFalseElement = FalseRangeEnd = i; // First false element.
356 else {
357 // Update double-compare state machine.
358 if (SecondFalseElement == Undefined)
359 SecondFalseElement = i;
360 else
361 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000362
Chris Lattner2188e402010-01-04 07:37:31 +0000363 // Update range state machine.
364 if (FalseRangeEnd == (int)i-1)
365 FalseRangeEnd = i;
366 else
367 FalseRangeEnd = Overdefined;
368 }
369 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000370
Chris Lattner2188e402010-01-04 07:37:31 +0000371 // If this element is in range, update our magic bitvector.
372 if (i < 64 && IsTrueForElt)
373 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 // If all of our states become overdefined, bail out early. Since the
376 // predicate is expensive, only check it every 8 elements. This is only
377 // really useful for really huge arrays.
378 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
379 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
380 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000381 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000382 }
383
384 // Now that we've scanned the entire array, emit our new comparison(s). We
385 // order the state machines in complexity of the generated code.
386 Value *Idx = GEP->getOperand(2);
387
Matt Arsenault5aeae182013-08-19 21:40:31 +0000388 // If the index is larger than the pointer size of the target, truncate the
389 // index down like the GEP would do implicitly. We don't have to do this for
390 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000391 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000392 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000393 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
394 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000395 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000396 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000397
Chris Lattner2188e402010-01-04 07:37:31 +0000398 // If the comparison is only true for one or two elements, emit direct
399 // comparisons.
400 if (SecondTrueElement != Overdefined) {
401 // None true -> false.
402 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000403 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000406
Chris Lattner2188e402010-01-04 07:37:31 +0000407 // True for one element -> 'i == 47'.
408 if (SecondTrueElement == Undefined)
409 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000410
Chris Lattner2188e402010-01-04 07:37:31 +0000411 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000412 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000414 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000415 return BinaryOperator::CreateOr(C1, C2);
416 }
417
418 // If the comparison is only false for one or two elements, emit direct
419 // comparisons.
420 if (SecondFalseElement != Overdefined) {
421 // None false -> true.
422 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000423 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000424
Chris Lattner2188e402010-01-04 07:37:31 +0000425 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
426
427 // False for one element -> 'i != 47'.
428 if (SecondFalseElement == Undefined)
429 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000430
Chris Lattner2188e402010-01-04 07:37:31 +0000431 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000432 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000433 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000434 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000435 return BinaryOperator::CreateAnd(C1, C2);
436 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000437
Chris Lattner2188e402010-01-04 07:37:31 +0000438 // If the comparison can be replaced with a range comparison for the elements
439 // where it is true, emit the range check.
440 if (TrueRangeEnd != Overdefined) {
441 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000442
Chris Lattner2188e402010-01-04 07:37:31 +0000443 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
444 if (FirstTrueElement) {
445 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000446 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000447 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000448
Chris Lattner2188e402010-01-04 07:37:31 +0000449 Value *End = ConstantInt::get(Idx->getType(),
450 TrueRangeEnd-FirstTrueElement+1);
451 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
452 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453
Chris Lattner2188e402010-01-04 07:37:31 +0000454 // False range check.
455 if (FalseRangeEnd != Overdefined) {
456 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
457 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
458 if (FirstFalseElement) {
459 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000460 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000461 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000462
Chris Lattner2188e402010-01-04 07:37:31 +0000463 Value *End = ConstantInt::get(Idx->getType(),
464 FalseRangeEnd-FirstFalseElement);
465 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
466 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000467
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000468 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // of this load, replace it with computation that does:
470 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000471 {
Craig Topperf40110f2014-04-25 05:29:35 +0000472 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000473
474 // Look for an appropriate type:
475 // - The type of Idx if the magic fits
476 // - The smallest fitting legal type if we have a DataLayout
477 // - Default to i32
478 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
479 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000480 else
481 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000482
Craig Topperf40110f2014-04-25 05:29:35 +0000483 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000484 Value *V = Builder.CreateIntCast(Idx, Ty, false);
485 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
486 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000487 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
488 }
Chris Lattner2188e402010-01-04 07:37:31 +0000489 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Craig Topperf40110f2014-04-25 05:29:35 +0000491 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000492}
493
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000494/// Return a value that can be used to compare the *offset* implied by a GEP to
495/// zero. For example, if we have &A[i], we want to return 'i' for
496/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
497/// are involved. The above expression would also be legal to codegen as
498/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
499/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000500/// to generate the first by knowing that pointer arithmetic doesn't overflow.
501///
502/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000503///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000504static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000505 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000506 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Check to see if this gep only has a single variable index. If so, and if
509 // any constant indices are a multiple of its scale, then we can compute this
510 // in terms of the scale of the variable index. For example, if the GEP
511 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
512 // because the expression will cross zero at the same point.
513 unsigned i, e = GEP->getNumOperands();
514 int64_t Offset = 0;
515 for (i = 1; i != e; ++i, ++GTI) {
516 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
517 // Compute the aggregate offset of constant indices.
518 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000519
Chris Lattner2188e402010-01-04 07:37:31 +0000520 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000521 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000522 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000523 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000524 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000525 Offset += Size*CI->getSExtValue();
526 }
527 } else {
528 // Found our variable index.
529 break;
530 }
531 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000532
Chris Lattner2188e402010-01-04 07:37:31 +0000533 // If there are no variable indices, we must have a constant offset, just
534 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000535 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000536
Chris Lattner2188e402010-01-04 07:37:31 +0000537 Value *VariableIdx = GEP->getOperand(i);
538 // Determine the scale factor of the variable element. For example, this is
539 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000540 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000541
Chris Lattner2188e402010-01-04 07:37:31 +0000542 // Verify that there are no other variable indices. If so, emit the hard way.
543 for (++i, ++GTI; i != e; ++i, ++GTI) {
544 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000545 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000546
Chris Lattner2188e402010-01-04 07:37:31 +0000547 // Compute the aggregate offset of constant indices.
548 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000549
Chris Lattner2188e402010-01-04 07:37:31 +0000550 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000551 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000552 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000553 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000554 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000555 Offset += Size*CI->getSExtValue();
556 }
557 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000558
Chris Lattner2188e402010-01-04 07:37:31 +0000559 // Okay, we know we have a single variable index, which must be a
560 // pointer/array/vector index. If there is no offset, life is simple, return
561 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000562 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000563 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000564 if (Offset == 0) {
565 // Cast to intptrty in case a truncation occurs. If an extension is needed,
566 // we don't need to bother extending: the extension won't affect where the
567 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000568 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000569 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000570 }
Chris Lattner2188e402010-01-04 07:37:31 +0000571 return VariableIdx;
572 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000573
Chris Lattner2188e402010-01-04 07:37:31 +0000574 // Otherwise, there is an index. The computation we will do will be modulo
575 // the pointer size, so get it.
576 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000577
Chris Lattner2188e402010-01-04 07:37:31 +0000578 Offset &= PtrSizeMask;
579 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000580
Chris Lattner2188e402010-01-04 07:37:31 +0000581 // To do this transformation, any constant index must be a multiple of the
582 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
583 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
584 // multiple of the variable scale.
585 int64_t NewOffs = Offset / (int64_t)VariableScale;
586 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000587 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000588
Chris Lattner2188e402010-01-04 07:37:31 +0000589 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000590 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000591 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000592 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000593 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000594 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000595}
596
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000597/// Returns true if we can rewrite Start as a GEP with pointer Base
598/// and some integer offset. The nodes that need to be re-written
599/// for this transformation will be added to Explored.
600static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
601 const DataLayout &DL,
602 SetVector<Value *> &Explored) {
603 SmallVector<Value *, 16> WorkList(1, Start);
604 Explored.insert(Base);
605
606 // The following traversal gives us an order which can be used
607 // when doing the final transformation. Since in the final
608 // transformation we create the PHI replacement instructions first,
609 // we don't have to get them in any particular order.
610 //
611 // However, for other instructions we will have to traverse the
612 // operands of an instruction first, which means that we have to
613 // do a post-order traversal.
614 while (!WorkList.empty()) {
615 SetVector<PHINode *> PHIs;
616
617 while (!WorkList.empty()) {
618 if (Explored.size() >= 100)
619 return false;
620
621 Value *V = WorkList.back();
622
623 if (Explored.count(V) != 0) {
624 WorkList.pop_back();
625 continue;
626 }
627
628 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000629 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000630 // We've found some value that we can't explore which is different from
631 // the base. Therefore we can't do this transformation.
632 return false;
633
634 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
635 auto *CI = dyn_cast<CastInst>(V);
636 if (!CI->isNoopCast(DL))
637 return false;
638
639 if (Explored.count(CI->getOperand(0)) == 0)
640 WorkList.push_back(CI->getOperand(0));
641 }
642
643 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
644 // We're limiting the GEP to having one index. This will preserve
645 // the original pointer type. We could handle more cases in the
646 // future.
647 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
648 GEP->getType() != Start->getType())
649 return false;
650
651 if (Explored.count(GEP->getOperand(0)) == 0)
652 WorkList.push_back(GEP->getOperand(0));
653 }
654
655 if (WorkList.back() == V) {
656 WorkList.pop_back();
657 // We've finished visiting this node, mark it as such.
658 Explored.insert(V);
659 }
660
661 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000662 // We cannot transform PHIs on unsplittable basic blocks.
663 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
664 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000665 Explored.insert(PN);
666 PHIs.insert(PN);
667 }
668 }
669
670 // Explore the PHI nodes further.
671 for (auto *PN : PHIs)
672 for (Value *Op : PN->incoming_values())
673 if (Explored.count(Op) == 0)
674 WorkList.push_back(Op);
675 }
676
677 // Make sure that we can do this. Since we can't insert GEPs in a basic
678 // block before a PHI node, we can't easily do this transformation if
679 // we have PHI node users of transformed instructions.
680 for (Value *Val : Explored) {
681 for (Value *Use : Val->uses()) {
682
683 auto *PHI = dyn_cast<PHINode>(Use);
684 auto *Inst = dyn_cast<Instruction>(Val);
685
686 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
687 Explored.count(PHI) == 0)
688 continue;
689
690 if (PHI->getParent() == Inst->getParent())
691 return false;
692 }
693 }
694 return true;
695}
696
697// Sets the appropriate insert point on Builder where we can add
698// a replacement Instruction for V (if that is possible).
699static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
700 bool Before = true) {
701 if (auto *PHI = dyn_cast<PHINode>(V)) {
702 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
703 return;
704 }
705 if (auto *I = dyn_cast<Instruction>(V)) {
706 if (!Before)
707 I = &*std::next(I->getIterator());
708 Builder.SetInsertPoint(I);
709 return;
710 }
711 if (auto *A = dyn_cast<Argument>(V)) {
712 // Set the insertion point in the entry block.
713 BasicBlock &Entry = A->getParent()->getEntryBlock();
714 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
715 return;
716 }
717 // Otherwise, this is a constant and we don't need to set a new
718 // insertion point.
719 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
720}
721
722/// Returns a re-written value of Start as an indexed GEP using Base as a
723/// pointer.
724static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
725 const DataLayout &DL,
726 SetVector<Value *> &Explored) {
727 // Perform all the substitutions. This is a bit tricky because we can
728 // have cycles in our use-def chains.
729 // 1. Create the PHI nodes without any incoming values.
730 // 2. Create all the other values.
731 // 3. Add the edges for the PHI nodes.
732 // 4. Emit GEPs to get the original pointers.
733 // 5. Remove the original instructions.
734 Type *IndexType = IntegerType::get(
735 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType()));
736
737 DenseMap<Value *, Value *> NewInsts;
738 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
739
740 // Create the new PHI nodes, without adding any incoming values.
741 for (Value *Val : Explored) {
742 if (Val == Base)
743 continue;
744 // Create empty phi nodes. This avoids cyclic dependencies when creating
745 // the remaining instructions.
746 if (auto *PHI = dyn_cast<PHINode>(Val))
747 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
748 PHI->getName() + ".idx", PHI);
749 }
750 IRBuilder<> Builder(Base->getContext());
751
752 // Create all the other instructions.
753 for (Value *Val : Explored) {
754
755 if (NewInsts.find(Val) != NewInsts.end())
756 continue;
757
758 if (auto *CI = dyn_cast<CastInst>(Val)) {
759 NewInsts[CI] = NewInsts[CI->getOperand(0)];
760 continue;
761 }
762 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
763 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
764 : GEP->getOperand(1);
765 setInsertionPoint(Builder, GEP);
766 // Indices might need to be sign extended. GEPs will magically do
767 // this, but we need to do it ourselves here.
768 if (Index->getType()->getScalarSizeInBits() !=
769 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
770 Index = Builder.CreateSExtOrTrunc(
771 Index, NewInsts[GEP->getOperand(0)]->getType(),
772 GEP->getOperand(0)->getName() + ".sext");
773 }
774
775 auto *Op = NewInsts[GEP->getOperand(0)];
776 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero())
777 NewInsts[GEP] = Index;
778 else
779 NewInsts[GEP] = Builder.CreateNSWAdd(
780 Op, Index, GEP->getOperand(0)->getName() + ".add");
781 continue;
782 }
783 if (isa<PHINode>(Val))
784 continue;
785
786 llvm_unreachable("Unexpected instruction type");
787 }
788
789 // Add the incoming values to the PHI nodes.
790 for (Value *Val : Explored) {
791 if (Val == Base)
792 continue;
793 // All the instructions have been created, we can now add edges to the
794 // phi nodes.
795 if (auto *PHI = dyn_cast<PHINode>(Val)) {
796 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
797 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
798 Value *NewIncoming = PHI->getIncomingValue(I);
799
800 if (NewInsts.find(NewIncoming) != NewInsts.end())
801 NewIncoming = NewInsts[NewIncoming];
802
803 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
804 }
805 }
806 }
807
808 for (Value *Val : Explored) {
809 if (Val == Base)
810 continue;
811
812 // Depending on the type, for external users we have to emit
813 // a GEP or a GEP + ptrtoint.
814 setInsertionPoint(Builder, Val, false);
815
816 // If required, create an inttoptr instruction for Base.
817 Value *NewBase = Base;
818 if (!Base->getType()->isPointerTy())
819 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
820 Start->getName() + "to.ptr");
821
822 Value *GEP = Builder.CreateInBoundsGEP(
823 Start->getType()->getPointerElementType(), NewBase,
824 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
825
826 if (!Val->getType()->isPointerTy()) {
827 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
828 Val->getName() + ".conv");
829 GEP = Cast;
830 }
831 Val->replaceAllUsesWith(GEP);
832 }
833
834 return NewInsts[Start];
835}
836
837/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
838/// the input Value as a constant indexed GEP. Returns a pair containing
839/// the GEPs Pointer and Index.
840static std::pair<Value *, Value *>
841getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
842 Type *IndexType = IntegerType::get(V->getContext(),
843 DL.getPointerTypeSizeInBits(V->getType()));
844
845 Constant *Index = ConstantInt::getNullValue(IndexType);
846 while (true) {
847 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
848 // We accept only inbouds GEPs here to exclude the possibility of
849 // overflow.
850 if (!GEP->isInBounds())
851 break;
852 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
853 GEP->getType() == V->getType()) {
854 V = GEP->getOperand(0);
855 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
856 Index = ConstantExpr::getAdd(
857 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
858 continue;
859 }
860 break;
861 }
862 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
863 if (!CI->isNoopCast(DL))
864 break;
865 V = CI->getOperand(0);
866 continue;
867 }
868 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
869 if (!CI->isNoopCast(DL))
870 break;
871 V = CI->getOperand(0);
872 continue;
873 }
874 break;
875 }
876 return {V, Index};
877}
878
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000879/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
880/// We can look through PHIs, GEPs and casts in order to determine a common base
881/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000882static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
883 ICmpInst::Predicate Cond,
884 const DataLayout &DL) {
885 if (!GEPLHS->hasAllConstantIndices())
886 return nullptr;
887
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000888 // Make sure the pointers have the same type.
889 if (GEPLHS->getType() != RHS->getType())
890 return nullptr;
891
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000892 Value *PtrBase, *Index;
893 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
894
895 // The set of nodes that will take part in this transformation.
896 SetVector<Value *> Nodes;
897
898 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
899 return nullptr;
900
901 // We know we can re-write this as
902 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
903 // Since we've only looked through inbouds GEPs we know that we
904 // can't have overflow on either side. We can therefore re-write
905 // this as:
906 // OFFSET1 cmp OFFSET2
907 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
908
909 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
910 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
911 // offset. Since Index is the offset of LHS to the base pointer, we will now
912 // compare the offsets instead of comparing the pointers.
913 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
914}
915
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000916/// Fold comparisons between a GEP instruction and something else. At this point
917/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000918Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000919 ICmpInst::Predicate Cond,
920 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000921 // Don't transform signed compares of GEPs into index compares. Even if the
922 // GEP is inbounds, the final add of the base pointer can have signed overflow
923 // and would change the result of the icmp.
924 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000925 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000926 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000927 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000928
Matt Arsenault44f60d02014-06-09 19:20:29 +0000929 // Look through bitcasts and addrspacecasts. We do not however want to remove
930 // 0 GEPs.
931 if (!isa<GetElementPtrInst>(RHS))
932 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000933
934 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000935 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000936 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
937 // This transformation (ignoring the base and scales) is valid because we
938 // know pointers can't overflow since the gep is inbounds. See if we can
939 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000940 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000941
Chris Lattner2188e402010-01-04 07:37:31 +0000942 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000943 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000944 Offset = EmitGEPOffset(GEPLHS);
945 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
946 Constant::getNullValue(Offset->getType()));
947 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
948 // If the base pointers are different, but the indices are the same, just
949 // compare the base pointer.
950 if (PtrBase != GEPRHS->getOperand(0)) {
951 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
952 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
953 GEPRHS->getOperand(0)->getType();
954 if (IndicesTheSame)
955 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
956 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
957 IndicesTheSame = false;
958 break;
959 }
960
961 // If all indices are the same, just compare the base pointers.
962 if (IndicesTheSame)
David Majnemer5953d372013-06-29 10:28:04 +0000963 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000964
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000965 // If we're comparing GEPs with two base pointers that only differ in type
966 // and both GEPs have only constant indices or just one use, then fold
967 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000968 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000969 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
970 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
971 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000972 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000973 Value *LOffset = EmitGEPOffset(GEPLHS);
974 Value *ROffset = EmitGEPOffset(GEPRHS);
975
976 // If we looked through an addrspacecast between different sized address
977 // spaces, the LHS and RHS pointers are different sized
978 // integers. Truncate to the smaller one.
979 Type *LHSIndexTy = LOffset->getType();
980 Type *RHSIndexTy = ROffset->getType();
981 if (LHSIndexTy != RHSIndexTy) {
982 if (LHSIndexTy->getPrimitiveSizeInBits() <
983 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000984 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000985 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000986 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000987 }
988
Craig Topperbb4069e2017-07-07 23:16:26 +0000989 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
990 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000991 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000992 }
993
Chris Lattner2188e402010-01-04 07:37:31 +0000994 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000995 // different. Try convert this to an indexed compare by looking through
996 // PHIs/casts.
997 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000998 }
999
1000 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +00001001 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +00001002 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +00001003 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +00001004
1005 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +00001006 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +00001007 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +00001008
Stuart Hastings66a82b92011-05-14 05:55:10 +00001009 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +00001010 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
1011 // If the GEPs only differ by one index, compare it.
1012 unsigned NumDifferences = 0; // Keep track of # differences.
1013 unsigned DiffOperand = 0; // The operand that differs.
1014 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
1015 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
1016 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
1017 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
1018 // Irreconcilable differences.
1019 NumDifferences = 2;
1020 break;
1021 } else {
1022 if (NumDifferences++) break;
1023 DiffOperand = i;
1024 }
1025 }
1026
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001027 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001028 return replaceInstUsesWith(I, // No comparison is needed here.
Craig Topperbb4069e2017-07-07 23:16:26 +00001029 Builder.getInt1(ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001030
Stuart Hastings66a82b92011-05-14 05:55:10 +00001031 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001032 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1033 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1034 // Make sure we do a signed comparison here.
1035 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1036 }
1037 }
1038
1039 // Only lower this if the icmp is the only user of the GEP or if we expect
1040 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001041 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001042 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1043 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1044 Value *L = EmitGEPOffset(GEPLHS);
1045 Value *R = EmitGEPOffset(GEPRHS);
1046 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1047 }
1048 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001049
1050 // Try convert this to an indexed compare by looking through PHIs/casts as a
1051 // last resort.
1052 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001053}
1054
Pete Cooper980a9352016-08-12 17:13:28 +00001055Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1056 const AllocaInst *Alloca,
1057 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001058 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1059
1060 // It would be tempting to fold away comparisons between allocas and any
1061 // pointer not based on that alloca (e.g. an argument). However, even
1062 // though such pointers cannot alias, they can still compare equal.
1063 //
1064 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1065 // doesn't escape we can argue that it's impossible to guess its value, and we
1066 // can therefore act as if any such guesses are wrong.
1067 //
1068 // The code below checks that the alloca doesn't escape, and that it's only
1069 // used in a comparison once (the current instruction). The
1070 // single-comparison-use condition ensures that we're trivially folding all
1071 // comparisons against the alloca consistently, and avoids the risk of
1072 // erroneously folding a comparison of the pointer with itself.
1073
1074 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1075
Pete Cooper980a9352016-08-12 17:13:28 +00001076 SmallVector<const Use *, 32> Worklist;
1077 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001078 if (Worklist.size() >= MaxIter)
1079 return nullptr;
1080 Worklist.push_back(&U);
1081 }
1082
1083 unsigned NumCmps = 0;
1084 while (!Worklist.empty()) {
1085 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001086 const Use *U = Worklist.pop_back_val();
1087 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001088 --MaxIter;
1089
1090 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1091 isa<SelectInst>(V)) {
1092 // Track the uses.
1093 } else if (isa<LoadInst>(V)) {
1094 // Loading from the pointer doesn't escape it.
1095 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001096 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001097 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1098 if (SI->getValueOperand() == U->get())
1099 return nullptr;
1100 continue;
1101 } else if (isa<ICmpInst>(V)) {
1102 if (NumCmps++)
1103 return nullptr; // Found more than one cmp.
1104 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001105 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001106 switch (Intrin->getIntrinsicID()) {
1107 // These intrinsics don't escape or compare the pointer. Memset is safe
1108 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1109 // we don't allow stores, so src cannot point to V.
1110 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001111 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1112 continue;
1113 default:
1114 return nullptr;
1115 }
1116 } else {
1117 return nullptr;
1118 }
Pete Cooper980a9352016-08-12 17:13:28 +00001119 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001120 if (Worklist.size() >= MaxIter)
1121 return nullptr;
1122 Worklist.push_back(&U);
1123 }
1124 }
1125
1126 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001127 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001128 ICI,
1129 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1130}
1131
Sanjay Patel5f0217f2016-06-05 16:46:18 +00001132/// Fold "icmp pred (X+CI), X".
Sanjay Patel43395062016-07-21 18:07:40 +00001133Instruction *InstCombiner::foldICmpAddOpConst(Instruction &ICI,
1134 Value *X, ConstantInt *CI,
1135 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001136 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001137 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001138 // operators.
Jim Grosbach129c52a2011-09-30 18:09:53 +00001139
Chris Lattner8c92b572010-01-08 17:48:19 +00001140 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001141 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1142 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1143 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00001144 Value *R =
Chris Lattner8c92b572010-01-08 17:48:19 +00001145 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI);
Chris Lattner2188e402010-01-04 07:37:31 +00001146 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1147 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001148
Chris Lattner2188e402010-01-04 07:37:31 +00001149 // (X+1) >u X --> X <u (0-1) --> X != 255
1150 // (X+2) >u X --> X <u (0-2) --> X <u 254
1151 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001152 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Chris Lattner2188e402010-01-04 07:37:31 +00001153 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001154
Chris Lattner2188e402010-01-04 07:37:31 +00001155 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits();
1156 ConstantInt *SMax = ConstantInt::get(X->getContext(),
1157 APInt::getSignedMaxValue(BitWidth));
1158
1159 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1160 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1161 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1162 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1163 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1164 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001165 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Chris Lattner2188e402010-01-04 07:37:31 +00001166 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001167
Chris Lattner2188e402010-01-04 07:37:31 +00001168 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1169 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1170 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1171 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1172 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1173 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001174
Chris Lattner2188e402010-01-04 07:37:31 +00001175 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbb4069e2017-07-07 23:16:26 +00001176 Constant *C = Builder.getInt(CI->getValue() - 1);
Chris Lattner2188e402010-01-04 07:37:31 +00001177 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C));
1178}
1179
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001180/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1181/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1182/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1183Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1184 const APInt &AP1,
1185 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001186 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1187
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001188 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1189 if (I.getPredicate() == I.ICMP_NE)
1190 Pred = CmpInst::getInversePredicate(Pred);
1191 return new ICmpInst(Pred, LHS, RHS);
1192 };
1193
David Majnemer2abb8182014-10-25 07:13:13 +00001194 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001195 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001196 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001197
1198 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001199 if (IsAShr) {
1200 if (AP2.isAllOnesValue())
1201 return nullptr;
1202 if (AP2.isNegative() != AP1.isNegative())
1203 return nullptr;
1204 if (AP2.sgt(AP1))
1205 return nullptr;
1206 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001207
David Majnemerd2056022014-10-21 19:51:55 +00001208 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001209 // 'A' must be large enough to shift out the highest set bit.
1210 return getICmp(I.ICMP_UGT, A,
1211 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001212
David Majnemerd2056022014-10-21 19:51:55 +00001213 if (AP1 == AP2)
1214 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001215
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001216 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001217 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001218 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001219 else
David Majnemere5977eb2015-09-19 00:48:26 +00001220 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001221
David Majnemerd2056022014-10-21 19:51:55 +00001222 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001223 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1224 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001225 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001226 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1227 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001228 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001229 } else if (AP1 == AP2.lshr(Shift)) {
1230 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1231 }
David Majnemerd2056022014-10-21 19:51:55 +00001232 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001233
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001234 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001235 // FIXME: This should always be handled by InstSimplify?
1236 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1237 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001238}
Chris Lattner2188e402010-01-04 07:37:31 +00001239
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001240/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1241/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1242Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1243 const APInt &AP1,
1244 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001245 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1246
David Majnemer59939ac2014-10-19 08:23:08 +00001247 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1248 if (I.getPredicate() == I.ICMP_NE)
1249 Pred = CmpInst::getInversePredicate(Pred);
1250 return new ICmpInst(Pred, LHS, RHS);
1251 };
1252
David Majnemer2abb8182014-10-25 07:13:13 +00001253 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001254 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001255 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001256
1257 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1258
1259 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001260 return getICmp(
1261 I.ICMP_UGE, A,
1262 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001263
1264 if (AP1 == AP2)
1265 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1266
1267 // Get the distance between the lowest bits that are set.
1268 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1269
1270 if (Shift > 0 && AP2.shl(Shift) == AP1)
1271 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1272
1273 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001274 // FIXME: This should always be handled by InstSimplify?
1275 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1276 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001277}
1278
Sanjay Patel06b127a2016-09-15 14:37:50 +00001279/// The caller has matched a pattern of the form:
1280/// I = icmp ugt (add (add A, B), CI2), CI1
1281/// If this is of the form:
1282/// sum = a + b
1283/// if (sum+128 >u 255)
1284/// Then replace it with llvm.sadd.with.overflow.i8.
1285///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001286static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001287 ConstantInt *CI2, ConstantInt *CI1,
1288 InstCombiner &IC) {
1289 // The transformation we're trying to do here is to transform this into an
1290 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1291 // with a narrower add, and discard the add-with-constant that is part of the
1292 // range check (if we can't eliminate it, this isn't profitable).
1293
1294 // In order to eliminate the add-with-constant, the compare can be its only
1295 // use.
1296 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1297 if (!AddWithCst->hasOneUse())
1298 return nullptr;
1299
1300 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1301 if (!CI2->getValue().isPowerOf2())
1302 return nullptr;
1303 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1304 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1305 return nullptr;
1306
1307 // The width of the new add formed is 1 more than the bias.
1308 ++NewWidth;
1309
1310 // Check to see that CI1 is an all-ones value with NewWidth bits.
1311 if (CI1->getBitWidth() == NewWidth ||
1312 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1313 return nullptr;
1314
1315 // This is only really a signed overflow check if the inputs have been
1316 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1317 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1318 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1319 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1320 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1321 return nullptr;
1322
1323 // In order to replace the original add with a narrower
1324 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1325 // and truncates that discard the high bits of the add. Verify that this is
1326 // the case.
1327 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1328 for (User *U : OrigAdd->users()) {
1329 if (U == AddWithCst)
1330 continue;
1331
1332 // Only accept truncates for now. We would really like a nice recursive
1333 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1334 // chain to see which bits of a value are actually demanded. If the
1335 // original add had another add which was then immediately truncated, we
1336 // could still do the transformation.
1337 TruncInst *TI = dyn_cast<TruncInst>(U);
1338 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1339 return nullptr;
1340 }
1341
1342 // If the pattern matches, truncate the inputs to the narrower type and
1343 // use the sadd_with_overflow intrinsic to efficiently compute both the
1344 // result and the overflow bit.
1345 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1346 Value *F = Intrinsic::getDeclaration(I.getModule(),
1347 Intrinsic::sadd_with_overflow, NewType);
1348
Craig Topperbb4069e2017-07-07 23:16:26 +00001349 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001350
1351 // Put the new code above the original add, in case there are any uses of the
1352 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001353 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001354
Craig Topperbb4069e2017-07-07 23:16:26 +00001355 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1356 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1357 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1358 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1359 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001360
1361 // The inner add was the result of the narrow add, zero extended to the
1362 // wider type. Replace it with the result computed by the intrinsic.
1363 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1364
1365 // The original icmp gets replaced with the overflow value.
1366 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1367}
1368
1369// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001370Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1371 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001372 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001373
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001374 const APInt *C;
1375 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001376 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001377
Sanjay Patel97459832016-09-15 15:11:12 +00001378 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001379
Sanjay Patel97459832016-09-15 15:11:12 +00001380 // Match the following pattern, which is a common idiom when writing
1381 // overflow-safe integer arithmetic functions. The source performs an addition
1382 // in wider type and explicitly checks for overflow using comparisons against
1383 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1384 //
1385 // TODO: This could probably be generalized to handle other overflow-safe
1386 // operations if we worked out the formulas to compute the appropriate magic
1387 // constants.
1388 //
1389 // sum = a + b
1390 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1391 {
1392 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1393 if (Pred == ICmpInst::ICMP_UGT &&
1394 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001395 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001396 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001397 return Res;
1398 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001399
Sanjay Patel97459832016-09-15 15:11:12 +00001400 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
Craig Topper73ba1c82017-06-07 07:40:37 +00001401 if (C->isNullValue() && Pred == ICmpInst::ICMP_SGT) {
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001402 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1403 if (SPR.Flavor == SPF_SMIN) {
Craig Topperd45185f2017-05-26 18:23:57 +00001404 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001405 return new ICmpInst(Pred, B, Cmp.getOperand(1));
Craig Topperd45185f2017-05-26 18:23:57 +00001406 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001407 return new ICmpInst(Pred, A, Cmp.getOperand(1));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001408 }
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001409 }
1410
1411 // FIXME: Use m_APInt to allow folds for splat constants.
1412 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1413 if (!CI)
1414 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001415
Sanjay Patel97459832016-09-15 15:11:12 +00001416 // Canonicalize icmp instructions based on dominating conditions.
1417 BasicBlock *Parent = Cmp.getParent();
1418 BasicBlock *Dom = Parent->getSinglePredecessor();
1419 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1420 ICmpInst::Predicate Pred2;
1421 BasicBlock *TrueBB, *FalseBB;
1422 ConstantInt *CI2;
1423 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1424 TrueBB, FalseBB)) &&
1425 TrueBB != FalseBB) {
1426 ConstantRange CR =
1427 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1428 ConstantRange DominatingCR =
1429 (Parent == TrueBB)
1430 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1431 : ConstantRange::makeExactICmpRegion(
1432 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1433 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1434 ConstantRange Difference = DominatingCR.difference(CR);
1435 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001436 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001437 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001438 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001439
Sanjay Patel97459832016-09-15 15:11:12 +00001440 // If this is a normal comparison, it demands all bits. If it is a sign
1441 // bit comparison, it only demands the sign bit.
1442 bool UnusedBit;
1443 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1444
1445 // Canonicalizing a sign bit comparison that gets used in a branch,
1446 // pessimizes codegen by generating branch on zero instruction instead
1447 // of a test and branch. So we avoid canonicalizing in such situations
1448 // because test and branch instruction has better branch displacement
1449 // than compare and branch instruction.
Eric Christophera95aac32017-06-30 01:57:48 +00001450 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1451 return nullptr;
1452
1453 if (auto *AI = Intersection.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001454 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI));
Eric Christophera95aac32017-06-30 01:57:48 +00001455 if (auto *AD = Difference.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001456 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001457 }
1458
1459 return nullptr;
1460}
1461
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001462/// Fold icmp (trunc X, Y), C.
1463Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001464 TruncInst *Trunc,
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001465 const APInt *C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001466 ICmpInst::Predicate Pred = Cmp.getPredicate();
1467 Value *X = Trunc->getOperand(0);
Craig Topper73ba1c82017-06-07 07:40:37 +00001468 if (C->isOneValue() && C->getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001469 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1470 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001471 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001472 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1473 ConstantInt::get(V->getType(), 1));
1474 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001475
1476 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001477 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1478 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001479 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1480 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001481 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001482
1483 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001484 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001485 // Pull in the high bits from known-ones set.
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001486 APInt NewRHS = C->zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001487 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001488 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001489 }
1490 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001491
Sanjay Patela3f4f082016-08-16 17:54:36 +00001492 return nullptr;
1493}
1494
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001495/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001496Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1497 BinaryOperator *Xor,
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001498 const APInt *C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001499 Value *X = Xor->getOperand(0);
1500 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001501 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001502 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001503 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001504
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001505 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1506 // fold the xor.
1507 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00001508 if ((Pred == ICmpInst::ICMP_SLT && C->isNullValue()) ||
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001509 (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001510
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001511 // If the sign bit of the XorCst is not set, there is no change to
1512 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001513 if (!XorC->isNegative()) {
1514 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001515 Worklist.Add(Xor);
1516 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001517 }
1518
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001519 // Was the old condition true if the operand is positive?
1520 bool isTrueIfPositive = Pred == ICmpInst::ICMP_SGT;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001521
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001522 // If so, the new one isn't.
1523 isTrueIfPositive ^= true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001524
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001525 Constant *CmpConstant = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001526 if (isTrueIfPositive)
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001527 return new ICmpInst(ICmpInst::ICMP_SGT, X, SubOne(CmpConstant));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001528 else
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001529 return new ICmpInst(ICmpInst::ICMP_SLT, X, AddOne(CmpConstant));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001530 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001531
1532 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001533 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1534 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001535 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1536 : Cmp.getSignedPredicate();
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001537 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001538 }
1539
Craig Topperbcfd2d12017-04-20 16:56:25 +00001540 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001541 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1542 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1543 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001544 Pred = Cmp.getSwappedPredicate(Pred);
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001545 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001546 }
1547 }
1548
1549 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C)
1550 // iff -C is a power of 2
Sanjay Pateldaffec912016-08-17 19:45:18 +00001551 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~(*C) && (*C + 1).isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001552 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001553
1554 // (icmp ult (xor X, C), -C) -> (icmp uge X, C)
1555 // iff -C is a power of 2
Sanjay Pateldaffec912016-08-17 19:45:18 +00001556 if (Pred == ICmpInst::ICMP_ULT && *XorC == -(*C) && C->isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001557 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001558
Sanjay Patela3f4f082016-08-16 17:54:36 +00001559 return nullptr;
1560}
1561
Sanjay Patel14e0e182016-08-26 18:28:46 +00001562/// Fold icmp (and (sh X, Y), C2), C1.
1563Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Sanjay Patel9b40f982016-09-07 22:33:03 +00001564 const APInt *C1, const APInt *C2) {
1565 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1566 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001567 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001568
Sanjay Patelda9c5622016-08-26 17:15:22 +00001569 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1570 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1571 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001572 // This seemingly simple opportunity to fold away a shift turns out to be
1573 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001574 unsigned ShiftOpcode = Shift->getOpcode();
1575 bool IsShl = ShiftOpcode == Instruction::Shl;
1576 const APInt *C3;
1577 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001578 bool CanFold = false;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001579 if (ShiftOpcode == Instruction::AShr) {
1580 // There may be some constraints that make this possible, but nothing
1581 // simple has been discovered yet.
1582 CanFold = false;
1583 } else if (ShiftOpcode == Instruction::Shl) {
1584 // For a left shift, we can fold if the comparison is not signed. We can
1585 // also fold a signed comparison if the mask value and comparison value
1586 // are not negative. These constraints may not be obvious, but we can
1587 // prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001588 if (!Cmp.isSigned() || (!C2->isNegative() && !C1->isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001589 CanFold = true;
1590 } else if (ShiftOpcode == Instruction::LShr) {
1591 // For a logical right shift, we can fold if the comparison is not signed.
1592 // We can also fold a signed comparison if the shifted mask value and the
1593 // shifted comparison value are not negative. These constraints may not be
1594 // obvious, but we can prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001595 if (!Cmp.isSigned() ||
1596 (!C2->shl(*C3).isNegative() && !C1->shl(*C3).isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001597 CanFold = true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001598 }
1599
Sanjay Patelda9c5622016-08-26 17:15:22 +00001600 if (CanFold) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001601 APInt NewCst = IsShl ? C1->lshr(*C3) : C1->shl(*C3);
1602 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001603 // Check to see if we are shifting out any of the bits being compared.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001604 if (SameAsC1 != *C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001605 // If we shifted bits out, the fold is not going to work out. As a
1606 // special case, check to see if this means that the result is always
1607 // true or false now.
1608 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001609 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001610 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001611 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001612 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001613 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
1614 APInt NewAndCst = IsShl ? C2->lshr(*C3) : C2->shl(*C3);
1615 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001616 And->setOperand(0, Shift->getOperand(0));
1617 Worklist.Add(Shift); // Shift is dead.
1618 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001619 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001620 }
1621 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001622
Sanjay Patelda9c5622016-08-26 17:15:22 +00001623 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1624 // preferable because it allows the C2 << Y expression to be hoisted out of a
1625 // loop if Y is invariant and X is not.
Craig Topper73ba1c82017-06-07 07:40:37 +00001626 if (Shift->hasOneUse() && C1->isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001627 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1628 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001629 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001630 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1631 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001632
Sanjay Patelda9c5622016-08-26 17:15:22 +00001633 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001634 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001635 Cmp.setOperand(0, NewAnd);
1636 return &Cmp;
1637 }
1638
Sanjay Patel14e0e182016-08-26 18:28:46 +00001639 return nullptr;
1640}
1641
1642/// Fold icmp (and X, C2), C1.
1643Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1644 BinaryOperator *And,
1645 const APInt *C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001646 const APInt *C2;
1647 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001648 return nullptr;
1649
1650 if (!And->hasOneUse() || !And->getOperand(0)->hasOneUse())
1651 return nullptr;
1652
Sanjay Patel6b490972016-09-04 14:32:15 +00001653 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1654 // the input width without changing the value produced, eliminate the cast:
1655 //
1656 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1657 //
1658 // We can do this transformation if the constants do not have their sign bits
1659 // set or if it is an equality comparison. Extending a relational comparison
1660 // when we're checking the sign bit would not work.
1661 Value *W;
1662 if (match(And->getOperand(0), m_Trunc(m_Value(W))) &&
1663 (Cmp.isEquality() || (!C1->isNegative() && !C2->isNegative()))) {
1664 // TODO: Is this a good transform for vectors? Wider types may reduce
1665 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001666 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001667 if (!Cmp.getType()->isVectorTy()) {
1668 Type *WideType = W->getType();
1669 unsigned WideScalarBits = WideType->getScalarSizeInBits();
1670 Constant *ZextC1 = ConstantInt::get(WideType, C1->zext(WideScalarBits));
1671 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001672 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001673 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001674 }
1675 }
1676
Sanjay Patel9b40f982016-09-07 22:33:03 +00001677 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001678 return I;
1679
Sanjay Patelda9c5622016-08-26 17:15:22 +00001680 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001681 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001682 //
1683 // iff pred isn't signed
Craig Topper73ba1c82017-06-07 07:40:37 +00001684 if (!Cmp.isSigned() && C1->isNullValue() &&
1685 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001686 Constant *One = cast<Constant>(And->getOperand(1));
1687 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001688 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001689 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1690 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1691 unsigned UsesRemoved = 0;
1692 if (And->hasOneUse())
1693 ++UsesRemoved;
1694 if (Or->hasOneUse())
1695 ++UsesRemoved;
1696 if (LShr->hasOneUse())
1697 ++UsesRemoved;
1698
1699 // Compute A & ((1 << B) | 1)
1700 Value *NewOr = nullptr;
1701 if (auto *C = dyn_cast<Constant>(B)) {
1702 if (UsesRemoved >= 1)
1703 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1704 } else {
1705 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001706 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1707 /*HasNUW=*/true),
1708 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001709 }
1710 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001711 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001712 Cmp.setOperand(0, NewAnd);
1713 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001714 }
1715 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001716 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001717
Sanjay Pateldef931e2016-09-07 20:50:44 +00001718 // (X & C2) > C1 --> (X & C2) != 0, if any bit set in (X & C2) will produce a
1719 // result greater than C1.
1720 unsigned NumTZ = C2->countTrailingZeros();
1721 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && NumTZ < C2->getBitWidth() &&
1722 APInt::getOneBitSet(C2->getBitWidth(), NumTZ).ugt(*C1)) {
1723 Constant *Zero = Constant::getNullValue(And->getType());
1724 return new ICmpInst(ICmpInst::ICMP_NE, And, Zero);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001725 }
1726
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001727 return nullptr;
1728}
1729
1730/// Fold icmp (and X, Y), C.
1731Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1732 BinaryOperator *And,
1733 const APInt *C) {
1734 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1735 return I;
1736
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001737 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001738
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001739 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1740 Value *X = And->getOperand(0);
1741 Value *Y = And->getOperand(1);
1742 if (auto *LI = dyn_cast<LoadInst>(X))
1743 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1744 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001745 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001746 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1747 ConstantInt *C2 = cast<ConstantInt>(Y);
1748 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001749 return Res;
1750 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001751
1752 if (!Cmp.isEquality())
1753 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001754
1755 // X & -C == -C -> X > u ~C
1756 // X & -C != -C -> X <= u ~C
1757 // iff C is a power of 2
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001758 if (Cmp.getOperand(1) == Y && (-(*C)).isPowerOf2()) {
1759 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1760 : CmpInst::ICMP_ULE;
1761 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1762 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001763
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001764 // (X & C2) == 0 -> (trunc X) >= 0
1765 // (X & C2) != 0 -> (trunc X) < 0
1766 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1767 const APInt *C2;
Craig Topper73ba1c82017-06-07 07:40:37 +00001768 if (And->hasOneUse() && C->isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001769 int32_t ExactLogBase2 = C2->exactLogBase2();
1770 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1771 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1772 if (And->getType()->isVectorTy())
1773 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001774 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001775 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1776 : CmpInst::ICMP_SLT;
1777 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001778 }
1779 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001780
Sanjay Patela3f4f082016-08-16 17:54:36 +00001781 return nullptr;
1782}
1783
Sanjay Patel943e92e2016-08-17 16:30:43 +00001784/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001785Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Sanjay Patel943e92e2016-08-17 16:30:43 +00001786 const APInt *C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001787 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00001788 if (C->isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001789 // icmp slt signum(V) 1 --> icmp slt V, 1
1790 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001791 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001792 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1793 ConstantInt::get(V->getType(), 1));
1794 }
1795
Sanjay Patel50c82c42017-04-05 17:57:05 +00001796 // X | C == C --> X <=u C
1797 // X | C != C --> X >u C
1798 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1799 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
1800 (*C + 1).isPowerOf2()) {
1801 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1802 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1803 }
1804
Craig Topper73ba1c82017-06-07 07:40:37 +00001805 if (!Cmp.isEquality() || !C->isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001806 return nullptr;
1807
1808 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001809 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001810 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1811 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001812 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001813 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001814 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001815 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001816 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1817 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1818 }
1819
1820 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1821 // a shorter form that has more potential to be folded even further.
1822 Value *X1, *X2, *X3, *X4;
1823 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1824 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1825 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1826 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1827 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1828 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1829 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1830 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001831 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001832
Sanjay Patela3f4f082016-08-16 17:54:36 +00001833 return nullptr;
1834}
1835
Sanjay Patel63478072016-08-18 15:44:44 +00001836/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001837Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1838 BinaryOperator *Mul,
Sanjay Patel63478072016-08-18 15:44:44 +00001839 const APInt *C) {
1840 const APInt *MulC;
1841 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001842 return nullptr;
1843
Sanjay Patel63478072016-08-18 15:44:44 +00001844 // If this is a test of the sign bit and the multiply is sign-preserving with
1845 // a constant operand, use the multiply LHS operand instead.
1846 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patelc9196c42016-08-22 21:24:29 +00001847 if (isSignTest(Pred, *C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001848 if (MulC->isNegative())
1849 Pred = ICmpInst::getSwappedPredicate(Pred);
1850 return new ICmpInst(Pred, Mul->getOperand(0),
1851 Constant::getNullValue(Mul->getType()));
1852 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001853
1854 return nullptr;
1855}
1856
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001857/// Fold icmp (shl 1, Y), C.
1858static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
1859 const APInt *C) {
1860 Value *Y;
1861 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1862 return nullptr;
1863
1864 Type *ShiftType = Shl->getType();
1865 uint32_t TypeBits = C->getBitWidth();
1866 bool CIsPowerOf2 = C->isPowerOf2();
1867 ICmpInst::Predicate Pred = Cmp.getPredicate();
1868 if (Cmp.isUnsigned()) {
1869 // (1 << Y) pred C -> Y pred Log2(C)
1870 if (!CIsPowerOf2) {
1871 // (1 << Y) < 30 -> Y <= 4
1872 // (1 << Y) <= 30 -> Y <= 4
1873 // (1 << Y) >= 30 -> Y > 4
1874 // (1 << Y) > 30 -> Y > 4
1875 if (Pred == ICmpInst::ICMP_ULT)
1876 Pred = ICmpInst::ICMP_ULE;
1877 else if (Pred == ICmpInst::ICMP_UGE)
1878 Pred = ICmpInst::ICMP_UGT;
1879 }
1880
1881 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1882 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
1883 unsigned CLog2 = C->logBase2();
1884 if (CLog2 == TypeBits - 1) {
1885 if (Pred == ICmpInst::ICMP_UGE)
1886 Pred = ICmpInst::ICMP_EQ;
1887 else if (Pred == ICmpInst::ICMP_ULT)
1888 Pred = ICmpInst::ICMP_NE;
1889 }
1890 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1891 } else if (Cmp.isSigned()) {
1892 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
1893 if (C->isAllOnesValue()) {
1894 // (1 << Y) <= -1 -> Y == 31
1895 if (Pred == ICmpInst::ICMP_SLE)
1896 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1897
1898 // (1 << Y) > -1 -> Y != 31
1899 if (Pred == ICmpInst::ICMP_SGT)
1900 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1901 } else if (!(*C)) {
1902 // (1 << Y) < 0 -> Y == 31
1903 // (1 << Y) <= 0 -> Y == 31
1904 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1905 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1906
1907 // (1 << Y) >= 0 -> Y != 31
1908 // (1 << Y) > 0 -> Y != 31
1909 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1910 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1911 }
1912 } else if (Cmp.isEquality() && CIsPowerOf2) {
1913 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C->logBase2()));
1914 }
1915
1916 return nullptr;
1917}
1918
Sanjay Patel38b75062016-08-19 17:20:37 +00001919/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001920Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1921 BinaryOperator *Shl,
Sanjay Patel38b75062016-08-19 17:20:37 +00001922 const APInt *C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001923 const APInt *ShiftVal;
1924 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
1925 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), *C, *ShiftVal);
1926
Sanjay Patelfa7de602016-08-19 22:33:26 +00001927 const APInt *ShiftAmt;
1928 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001929 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001930
Sanjay Patel38b75062016-08-19 17:20:37 +00001931 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001932 // shifts. When the shift is visited, it will be simplified.
Sanjay Patel38b75062016-08-19 17:20:37 +00001933 unsigned TypeBits = C->getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001934 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001935 return nullptr;
1936
Sanjay Patele38e79c2016-08-19 17:34:05 +00001937 ICmpInst::Predicate Pred = Cmp.getPredicate();
1938 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001939 Type *ShType = Shl->getType();
1940
Sanjay Patel291c3d82017-01-19 16:12:10 +00001941 // NSW guarantees that we are only shifting out sign bits from the high bits,
1942 // so we can ASHR the compare constant without needing a mask and eliminate
1943 // the shift.
1944 if (Shl->hasNoSignedWrap()) {
1945 if (Pred == ICmpInst::ICMP_SGT) {
1946 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
1947 APInt ShiftedC = C->ashr(*ShiftAmt);
1948 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1949 }
1950 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1951 // This is the same code as the SGT case, but assert the pre-condition
1952 // that is needed for this to work with equality predicates.
1953 assert(C->ashr(*ShiftAmt).shl(*ShiftAmt) == *C &&
1954 "Compare known true or false was not folded");
1955 APInt ShiftedC = C->ashr(*ShiftAmt);
1956 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1957 }
1958 if (Pred == ICmpInst::ICMP_SLT) {
1959 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1960 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1961 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1962 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
1963 assert(!C->isMinSignedValue() && "Unexpected icmp slt");
1964 APInt ShiftedC = (*C - 1).ashr(*ShiftAmt) + 1;
1965 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1966 }
1967 // If this is a signed comparison to 0 and the shift is sign preserving,
1968 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1969 // do that if we're sure to not continue on in this function.
1970 if (isSignTest(Pred, *C))
1971 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1972 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001973
Sanjay Patel291c3d82017-01-19 16:12:10 +00001974 // NUW guarantees that we are only shifting out zero bits from the high bits,
1975 // so we can LSHR the compare constant without needing a mask and eliminate
1976 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001977 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001978 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001979 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
1980 APInt ShiftedC = C->lshr(*ShiftAmt);
1981 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1982 }
Sanjay Patelae23d652017-01-18 21:16:12 +00001983 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1984 // This is the same code as the UGT case, but assert the pre-condition
1985 // that is needed for this to work with equality predicates.
1986 assert(C->lshr(*ShiftAmt).shl(*ShiftAmt) == *C &&
1987 "Compare known true or false was not folded");
1988 APInt ShiftedC = C->lshr(*ShiftAmt);
1989 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1990 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001991 if (Pred == ICmpInst::ICMP_ULT) {
1992 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1993 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1994 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1995 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
1996 assert(C->ugt(0) && "ult 0 should have been eliminated");
1997 APInt ShiftedC = (*C - 1).lshr(*ShiftAmt) + 1;
1998 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1999 }
2000 }
2001
Sanjay Patel291c3d82017-01-19 16:12:10 +00002002 if (Cmp.isEquality() && Shl->hasOneUse()) {
2003 // Strength-reduce the shift into an 'and'.
2004 Constant *Mask = ConstantInt::get(
2005 ShType,
2006 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002007 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patel14715b32017-01-17 21:25:16 +00002008 Constant *LShrC = ConstantInt::get(ShType, C->lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002009 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002010 }
2011
Sanjay Patela3f4f082016-08-16 17:54:36 +00002012 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2013 bool TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +00002014 if (Shl->hasOneUse() && isSignBitCheck(Pred, *C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002015 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002016 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002017 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002018 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002019 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002020 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002021 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002022 }
2023
Sanjay Patel643d21a2016-08-21 17:10:07 +00002024 // Transform (icmp pred iM (shl iM %v, N), C)
2025 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2026 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002027 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002028 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002029 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002030 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Sanjay Patelf3dda132016-10-25 20:11:47 +00002031 if (Shl->hasOneUse() && Amt != 0 && C->countTrailingZeros() >= Amt &&
2032 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002033 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002034 if (ShType->isVectorTy())
2035 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002036 Constant *NewC =
2037 ConstantInt::get(TruncTy, C->ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002038 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002039 }
2040
2041 return nullptr;
2042}
2043
Sanjay Patela3920492016-08-22 20:45:06 +00002044/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002045Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2046 BinaryOperator *Shr,
2047 const APInt *C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002048 // An exact shr only shifts out zero bits, so:
2049 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002050 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002051 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002052 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
2053 C->isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002054 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002055
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002056 const APInt *ShiftVal;
2057 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
2058 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), *C, *ShiftVal);
2059
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002060 const APInt *ShiftAmt;
2061 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002062 return nullptr;
2063
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002064 // Check that the shift amount is in range. If not, don't perform undefined
2065 // shifts. When the shift is visited it will be simplified.
2066 unsigned TypeBits = C->getBitWidth();
2067 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002068 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2069 return nullptr;
2070
Sanjay Pateld64e9882016-08-23 22:05:55 +00002071 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002072 if (!Cmp.isEquality()) {
2073 // If we have an unsigned comparison and an ashr, we can't simplify this.
2074 // Similarly for signed comparisons with lshr.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002075 if (Cmp.isSigned() != IsAShr)
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002076 return nullptr;
2077
2078 // Otherwise, all lshr and most exact ashr's are equivalent to a udiv/sdiv
2079 // by a power of 2. Since we already have logic to simplify these,
2080 // transform to div and then simplify the resultant comparison.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002081 if (IsAShr && (!Shr->isExact() || ShAmtVal == TypeBits - 1))
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002082 return nullptr;
2083
2084 // Revisit the shift (to delete it).
2085 Worklist.Add(Shr);
2086
2087 Constant *DivCst = ConstantInt::get(
2088 Shr->getType(), APInt::getOneBitSet(TypeBits, ShAmtVal));
2089
Craig Topperbb4069e2017-07-07 23:16:26 +00002090 Value *Tmp = IsAShr ? Builder.CreateSDiv(X, DivCst, "", Shr->isExact())
2091 : Builder.CreateUDiv(X, DivCst, "", Shr->isExact());
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002092
2093 Cmp.setOperand(0, Tmp);
2094
2095 // If the builder folded the binop, just return it.
2096 BinaryOperator *TheDiv = dyn_cast<BinaryOperator>(Tmp);
2097 if (!TheDiv)
2098 return &Cmp;
2099
2100 // Otherwise, fold this div/compare.
2101 assert(TheDiv->getOpcode() == Instruction::SDiv ||
2102 TheDiv->getOpcode() == Instruction::UDiv);
2103
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002104 Instruction *Res = foldICmpDivConstant(Cmp, TheDiv, C);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002105 assert(Res && "This div/cst should have folded!");
Sanjay Patela3920492016-08-22 20:45:06 +00002106 return Res;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002107 }
2108
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002109 // Handle equality comparisons of shift-by-constant.
2110
Sanjay Patel8e297742016-08-24 13:55:55 +00002111 // If the comparison constant changes with the shift, the comparison cannot
2112 // succeed (bits of the comparison constant cannot match the shifted value).
2113 // This should be known by InstSimplify and already be folded to true/false.
2114 assert(((IsAShr && C->shl(ShAmtVal).ashr(ShAmtVal) == *C) ||
2115 (!IsAShr && C->shl(ShAmtVal).lshr(ShAmtVal) == *C)) &&
2116 "Expected icmp+shr simplify did not occur.");
2117
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002118 // Check if the bits shifted out are known to be zero. If so, we can compare
2119 // against the unshifted value:
2120 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002121 Constant *ShiftedCmpRHS = ConstantInt::get(Shr->getType(), *C << ShAmtVal);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002122 if (Shr->hasOneUse()) {
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002123 if (Shr->isExact())
2124 return new ICmpInst(Pred, X, ShiftedCmpRHS);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002125
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002126 // Otherwise strength reduce the shift into an 'and'.
2127 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
2128 Constant *Mask = ConstantInt::get(Shr->getType(), Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002129 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002130 return new ICmpInst(Pred, And, ShiftedCmpRHS);
2131 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002132
2133 return nullptr;
2134}
2135
Sanjay Patel12a41052016-08-18 17:37:26 +00002136/// Fold icmp (udiv X, Y), C.
2137Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002138 BinaryOperator *UDiv,
Sanjay Patel12a41052016-08-18 17:37:26 +00002139 const APInt *C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002140 const APInt *C2;
2141 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2142 return nullptr;
2143
Craig Topper29c282e2017-06-07 07:40:29 +00002144 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002145
2146 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2147 Value *Y = UDiv->getOperand(1);
2148 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
2149 assert(!C->isMaxValue() &&
2150 "icmp ugt X, UINT_MAX should have been simplified already.");
2151 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
2152 ConstantInt::get(Y->getType(), C2->udiv(*C + 1)));
2153 }
2154
2155 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2156 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper29c282e2017-06-07 07:40:29 +00002157 assert(*C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002158 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
2159 ConstantInt::get(Y->getType(), C2->udiv(*C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002160 }
2161
2162 return nullptr;
2163}
2164
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002165/// Fold icmp ({su}div X, Y), C.
2166Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2167 BinaryOperator *Div,
2168 const APInt *C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002169 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002170 // Fold this div into the comparison, producing a range check.
2171 // Determine, based on the divide type, what the range is being
2172 // checked. If there is an overflow on the low or high side, remember
2173 // it, otherwise compute the range [low, hi) bounding the new value.
2174 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002175 const APInt *C2;
2176 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002177 return nullptr;
2178
Sanjay Patel16554142016-08-24 23:03:36 +00002179 // FIXME: If the operand types don't match the type of the divide
2180 // then don't attempt this transform. The code below doesn't have the
2181 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002182 // vice versa). This is because (x /s C2) <s C produces different
2183 // results than (x /s C2) <u C or (x /u C2) <s C or even
2184 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002185 // work. :( The if statement below tests that condition and bails
2186 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002187 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2188 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002189 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002190
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002191 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2192 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2193 // division-by-constant cases should be present, we can not assert that they
2194 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002195 if (C2->isNullValue() || C2->isOneValue() ||
2196 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002197 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002198
Sanjay Patel541aef42016-08-31 21:57:21 +00002199 // TODO: We could do all of the computations below using APInt.
2200 Constant *CmpRHS = cast<Constant>(Cmp.getOperand(1));
2201 Constant *DivRHS = cast<Constant>(Div->getOperand(1));
Sanjay Patelb3714572016-08-30 17:31:34 +00002202
Sanjay Patel541aef42016-08-31 21:57:21 +00002203 // Compute Prod = CmpRHS * DivRHS. We are essentially solving an equation of
2204 // form X / C2 = C. We solve for X by multiplying C2 (DivRHS) and C (CmpRHS).
2205 // By solving for X, we can turn this into a range check instead of computing
2206 // a divide.
2207 Constant *Prod = ConstantExpr::getMul(CmpRHS, DivRHS);
Sanjay Patel16554142016-08-24 23:03:36 +00002208
Sanjay Patel541aef42016-08-31 21:57:21 +00002209 // Determine if the product overflows by seeing if the product is not equal to
2210 // the divide. Make sure we do the same kind of divide as in the LHS
2211 // instruction that we're folding.
2212 bool ProdOV = (DivIsSigned ? ConstantExpr::getSDiv(Prod, DivRHS)
2213 : ConstantExpr::getUDiv(Prod, DivRHS)) != CmpRHS;
Sanjay Patel16554142016-08-24 23:03:36 +00002214
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002215 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002216
2217 // If the division is known to be exact, then there is no remainder from the
2218 // divide, so the covered range size is unit, otherwise it is the divisor.
Sanjay Patel541aef42016-08-31 21:57:21 +00002219 Constant *RangeSize =
2220 Div->isExact() ? ConstantInt::get(Div->getType(), 1) : DivRHS;
Sanjay Patel16554142016-08-24 23:03:36 +00002221
2222 // Figure out the interval that is being checked. For example, a comparison
2223 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2224 // Compute this interval based on the constants involved and the signedness of
2225 // the compare/divide. This computes a half-open interval, keeping track of
2226 // whether either value in the interval overflows. After analysis each
2227 // overflow variable is set to 0 if it's corresponding bound variable is valid
2228 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2229 int LoOverflow = 0, HiOverflow = 0;
2230 Constant *LoBound = nullptr, *HiBound = nullptr;
2231
2232 if (!DivIsSigned) { // udiv
2233 // e.g. X/5 op 3 --> [15, 20)
2234 LoBound = Prod;
2235 HiOverflow = LoOverflow = ProdOV;
2236 if (!HiOverflow) {
2237 // If this is not an exact divide, then many values in the range collapse
2238 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002239 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002240 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002241 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper73ba1c82017-06-07 07:40:37 +00002242 if (C->isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002243 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
2244 LoBound = ConstantExpr::getNeg(SubOne(RangeSize));
2245 HiBound = RangeSize;
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002246 } else if (C->isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002247 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2248 HiOverflow = LoOverflow = ProdOV;
2249 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002250 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002251 } else { // (X / pos) op neg
2252 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
2253 HiBound = AddOne(Prod);
2254 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2255 if (!LoOverflow) {
Sanjay Patel541aef42016-08-31 21:57:21 +00002256 Constant *DivNeg = ConstantExpr::getNeg(RangeSize);
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002257 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002258 }
2259 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002260 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002261 if (Div->isExact())
Sanjay Patel541aef42016-08-31 21:57:21 +00002262 RangeSize = ConstantExpr::getNeg(RangeSize);
Craig Topper73ba1c82017-06-07 07:40:37 +00002263 if (C->isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002264 // e.g. X/-5 op 0 --> [-4, 5)
2265 LoBound = AddOne(RangeSize);
Sanjay Patel541aef42016-08-31 21:57:21 +00002266 HiBound = ConstantExpr::getNeg(RangeSize);
Sanjay Patel16554142016-08-24 23:03:36 +00002267 if (HiBound == DivRHS) { // -INTMIN = INTMIN
2268 HiOverflow = 1; // [INTMIN+1, overflow)
2269 HiBound = nullptr; // e.g. X/INTMIN = 0 --> X > INTMIN
2270 }
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002271 } else if (C->isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002272 // e.g. X/-5 op 3 --> [-19, -14)
2273 HiBound = AddOne(Prod);
2274 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2275 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002276 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002277 } else { // (X / neg) op neg
2278 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2279 LoOverflow = HiOverflow = ProdOV;
2280 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002281 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002282 }
2283
2284 // Dividing by a negative swaps the condition. LT <-> GT
2285 Pred = ICmpInst::getSwappedPredicate(Pred);
2286 }
2287
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002288 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002289 switch (Pred) {
2290 default: llvm_unreachable("Unhandled icmp opcode!");
2291 case ICmpInst::ICMP_EQ:
2292 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002293 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002294 if (HiOverflow)
2295 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
2296 ICmpInst::ICMP_UGE, X, LoBound);
2297 if (LoOverflow)
2298 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
2299 ICmpInst::ICMP_ULT, X, HiBound);
Sanjay Patel85d79742016-08-31 19:49:56 +00002300 return replaceInstUsesWith(
Sanjay Patel541aef42016-08-31 21:57:21 +00002301 Cmp, insertRangeTest(X, LoBound->getUniqueInteger(),
2302 HiBound->getUniqueInteger(), DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002303 case ICmpInst::ICMP_NE:
2304 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002305 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002306 if (HiOverflow)
2307 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
2308 ICmpInst::ICMP_ULT, X, LoBound);
2309 if (LoOverflow)
2310 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
2311 ICmpInst::ICMP_UGE, X, HiBound);
Sanjay Patel541aef42016-08-31 21:57:21 +00002312 return replaceInstUsesWith(Cmp,
2313 insertRangeTest(X, LoBound->getUniqueInteger(),
2314 HiBound->getUniqueInteger(),
2315 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002316 case ICmpInst::ICMP_ULT:
2317 case ICmpInst::ICMP_SLT:
2318 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002319 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002320 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002321 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002322 return new ICmpInst(Pred, X, LoBound);
2323 case ICmpInst::ICMP_UGT:
2324 case ICmpInst::ICMP_SGT:
2325 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002326 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002327 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002328 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002329 if (Pred == ICmpInst::ICMP_UGT)
2330 return new ICmpInst(ICmpInst::ICMP_UGE, X, HiBound);
2331 return new ICmpInst(ICmpInst::ICMP_SGE, X, HiBound);
2332 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002333
2334 return nullptr;
2335}
2336
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002337/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002338Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2339 BinaryOperator *Sub,
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002340 const APInt *C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002341 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2342 ICmpInst::Predicate Pred = Cmp.getPredicate();
2343
2344 // The following transforms are only worth it if the only user of the subtract
2345 // is the icmp.
2346 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002347 return nullptr;
2348
Sanjay Patel886a5422016-09-15 18:05:17 +00002349 if (Sub->hasNoSignedWrap()) {
2350 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
2351 if (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())
2352 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002353
Sanjay Patel886a5422016-09-15 18:05:17 +00002354 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper73ba1c82017-06-07 07:40:37 +00002355 if (Pred == ICmpInst::ICMP_SGT && C->isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002356 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2357
2358 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper73ba1c82017-06-07 07:40:37 +00002359 if (Pred == ICmpInst::ICMP_SLT && C->isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002360 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2361
2362 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper73ba1c82017-06-07 07:40:37 +00002363 if (Pred == ICmpInst::ICMP_SLT && C->isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002364 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2365 }
2366
2367 const APInt *C2;
2368 if (!match(X, m_APInt(C2)))
2369 return nullptr;
2370
2371 // C2 - Y <u C -> (Y | (C - 1)) == C2
2372 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
2373 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() &&
2374 (*C2 & (*C - 1)) == (*C - 1))
Craig Topperbb4069e2017-07-07 23:16:26 +00002375 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, *C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002376
2377 // C2 - Y >u C -> (Y | C) != C2
2378 // iff C2 & C == C and C + 1 is a power of 2
2379 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == *C)
Craig Topperbb4069e2017-07-07 23:16:26 +00002380 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, *C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002381
2382 return nullptr;
2383}
2384
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002385/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002386Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2387 BinaryOperator *Add,
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002388 const APInt *C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002389 Value *Y = Add->getOperand(1);
2390 const APInt *C2;
2391 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002392 return nullptr;
2393
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002394 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002395 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002396 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002397 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002398
2399 // If the add does not wrap, we can always adjust the compare by subtracting
2400 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are
2401 // canonicalized to SGT/SLT.
2402 if (Add->hasNoSignedWrap() &&
2403 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) {
2404 bool Overflow;
2405 APInt NewC = C->ssub_ov(*C2, Overflow);
2406 // If there is overflow, the result must be true or false.
2407 // TODO: Can we assert there is no overflow because InstSimplify always
2408 // handles those cases?
2409 if (!Overflow)
2410 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2411 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2412 }
2413
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002414 auto CR = ConstantRange::makeExactICmpRegion(Pred, *C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002415 const APInt &Upper = CR.getUpper();
2416 const APInt &Lower = CR.getLower();
2417 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002418 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002419 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002420 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002421 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002422 } else {
2423 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002424 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002425 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002426 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002427 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002428
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002429 if (!Add->hasOneUse())
2430 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00002431
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002432 // X+C <u C2 -> (X & -C2) == C
2433 // iff C & (C2-1) == 0
2434 // C2 is a power of 2
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002435 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() && (*C2 & (*C - 1)) == 0)
Craig Topperbb4069e2017-07-07 23:16:26 +00002436 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -(*C)),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002437 ConstantExpr::getNeg(cast<Constant>(Y)));
2438
2439 // X+C >u C2 -> (X & ~C2) != C
2440 // iff C & C2 == 0
2441 // C2+1 is a power of 2
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002442 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == 0)
Craig Topperbb4069e2017-07-07 23:16:26 +00002443 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~(*C)),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002444 ConstantExpr::getNeg(cast<Constant>(Y)));
2445
Sanjay Patela3f4f082016-08-16 17:54:36 +00002446 return nullptr;
2447}
2448
Anna Thomasd67165c2017-06-23 13:41:45 +00002449bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2450 Value *&RHS, ConstantInt *&Less,
2451 ConstantInt *&Equal,
2452 ConstantInt *&Greater) {
2453 // TODO: Generalize this to work with other comparison idioms or ensure
2454 // they get canonicalized into this form.
2455
2456 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2457 // Greater), where Equal, Less and Greater are placeholders for any three
2458 // constants.
2459 ICmpInst::Predicate PredA, PredB;
2460 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2461 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2462 PredA == ICmpInst::ICMP_EQ &&
2463 match(SI->getFalseValue(),
2464 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2465 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2466 PredB == ICmpInst::ICMP_SLT) {
2467 return true;
2468 }
2469 return false;
2470}
2471
2472Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002473 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002474 ConstantInt *C) {
2475
2476 assert(C && "Cmp RHS should be a constant int!");
2477 // If we're testing a constant value against the result of a three way
2478 // comparison, the result can be expressed directly in terms of the
2479 // original values being compared. Note: We could possibly be more
2480 // aggressive here and remove the hasOneUse test. The original select is
2481 // really likely to simplify or sink when we remove a test of the result.
2482 Value *OrigLHS, *OrigRHS;
2483 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2484 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002485 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2486 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002487 assert(C1LessThan && C2Equal && C3GreaterThan);
2488
2489 bool TrueWhenLessThan =
2490 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2491 ->isAllOnesValue();
2492 bool TrueWhenEqual =
2493 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2494 ->isAllOnesValue();
2495 bool TrueWhenGreaterThan =
2496 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2497 ->isAllOnesValue();
2498
2499 // This generates the new instruction that will replace the original Cmp
2500 // Instruction. Instead of enumerating the various combinations when
2501 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2502 // false, we rely on chaining of ORs and future passes of InstCombine to
2503 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2504
2505 // When none of the three constants satisfy the predicate for the RHS (C),
2506 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002507 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002508 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002509 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002510 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002511 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002512 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002513 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002514
2515 return replaceInstUsesWith(Cmp, Cond);
2516 }
2517 return nullptr;
2518}
2519
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002520/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2521/// where X is some kind of instruction.
2522Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002523 const APInt *C;
2524 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002525 return nullptr;
2526
Sanjay Patelc9196c42016-08-22 21:24:29 +00002527 BinaryOperator *BO;
2528 if (match(Cmp.getOperand(0), m_BinOp(BO))) {
2529 switch (BO->getOpcode()) {
2530 case Instruction::Xor:
2531 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C))
2532 return I;
2533 break;
2534 case Instruction::And:
2535 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C))
2536 return I;
2537 break;
2538 case Instruction::Or:
2539 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C))
2540 return I;
2541 break;
2542 case Instruction::Mul:
2543 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C))
2544 return I;
2545 break;
2546 case Instruction::Shl:
2547 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C))
2548 return I;
2549 break;
2550 case Instruction::LShr:
2551 case Instruction::AShr:
2552 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C))
2553 return I;
2554 break;
2555 case Instruction::UDiv:
2556 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C))
2557 return I;
2558 LLVM_FALLTHROUGH;
2559 case Instruction::SDiv:
2560 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C))
2561 return I;
2562 break;
2563 case Instruction::Sub:
2564 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C))
2565 return I;
2566 break;
2567 case Instruction::Add:
2568 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C))
2569 return I;
2570 break;
2571 default:
2572 break;
2573 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002574 // TODO: These folds could be refactored to be part of the above calls.
2575 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, C))
2576 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002577 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002578
Anna Thomasd67165c2017-06-23 13:41:45 +00002579 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002580
2581 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2582 // For now, we only support constant integers while folding the
2583 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2584 // similar to the cases handled by binary ops above.
2585 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2586 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002587 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002588 }
2589
2590 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
2591 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, C))
2592 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002593 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002594
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002595 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, C))
2596 return I;
2597
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002598 return nullptr;
2599}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002600
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002601/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2602/// icmp eq/ne BO, C.
2603Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2604 BinaryOperator *BO,
2605 const APInt *C) {
2606 // TODO: Some of these folds could work with arbitrary constants, but this
2607 // function is limited to scalar and vector splat constants.
2608 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002609 return nullptr;
2610
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002611 ICmpInst::Predicate Pred = Cmp.getPredicate();
2612 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2613 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002614 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002615
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002616 switch (BO->getOpcode()) {
2617 case Instruction::SRem:
2618 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper73ba1c82017-06-07 07:40:37 +00002619 if (C->isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002620 const APInt *BOC;
2621 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002622 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002623 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002624 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002625 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002626 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002627 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002628 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002629 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002630 const APInt *BOC;
2631 if (match(BOp1, m_APInt(BOC))) {
2632 if (BO->hasOneUse()) {
2633 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002634 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002635 }
Craig Topper73ba1c82017-06-07 07:40:37 +00002636 } else if (C->isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002637 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2638 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002639 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002640 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002641 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002642 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002643 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002644 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002645 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002646 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002647 }
2648 }
2649 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002650 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002651 case Instruction::Xor:
2652 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002653 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002654 // For the xor case, we can xor two constants together, eliminating
2655 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002656 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper73ba1c82017-06-07 07:40:37 +00002657 } else if (C->isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002658 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002659 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002660 }
2661 }
2662 break;
2663 case Instruction::Sub:
2664 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002665 const APInt *BOC;
2666 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002667 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002668 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002669 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper73ba1c82017-06-07 07:40:37 +00002670 } else if (C->isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002671 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002672 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002673 }
2674 }
2675 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002676 case Instruction::Or: {
2677 const APInt *BOC;
2678 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002679 // Comparing if all bits outside of a constant mask are set?
2680 // Replace (X | C) == -1 with (X & ~C) == ~C.
2681 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002682 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002683 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002684 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002685 }
2686 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002687 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002688 case Instruction::And: {
2689 const APInt *BOC;
2690 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002691 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002692 if (C == BOC && C->isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002693 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002694 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002695
2696 // Don't perform the following transforms if the AND has multiple uses
2697 if (!BO->hasOneUse())
2698 break;
2699
2700 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002701 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002702 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002703 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2704 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002705 }
2706
2707 // ((X & ~7) == 0) --> X < 8
Craig Topper73ba1c82017-06-07 07:40:37 +00002708 if (C->isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002709 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002710 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2711 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002712 }
2713 }
2714 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002715 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002716 case Instruction::Mul:
Craig Topper73ba1c82017-06-07 07:40:37 +00002717 if (C->isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002718 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002719 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002720 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002721 // General case : (mul X, C) != 0 iff X != 0
2722 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002723 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002724 }
2725 }
2726 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002727 case Instruction::UDiv:
Craig Topper73ba1c82017-06-07 07:40:37 +00002728 if (C->isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002729 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002730 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2731 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002732 }
2733 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002734 default:
2735 break;
2736 }
2737 return nullptr;
2738}
2739
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002740/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2741Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2742 const APInt *C) {
2743 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2744 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002745 return nullptr;
2746
Sanjay Patelb51e0722017-07-02 16:05:11 +00002747 // Handle icmp {eq|ne} <intrinsic>, Constant.
2748 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002749 switch (II->getIntrinsicID()) {
2750 case Intrinsic::bswap:
2751 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002752 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002753 Cmp.setOperand(1, ConstantInt::get(Ty, C->byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002754 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002755
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002756 case Intrinsic::ctlz:
2757 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002758 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002759 if (*C == C->getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002760 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002761 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002762 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002763 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002764 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002765 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002766
Amaury Sechet6bea6742016-08-04 05:27:20 +00002767 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002768 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002769 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper73ba1c82017-06-07 07:40:37 +00002770 bool IsZero = C->isNullValue();
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002771 if (IsZero || *C == C->getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002772 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002773 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002774 auto *NewOp =
2775 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002776 Cmp.setOperand(1, NewOp);
2777 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002778 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002779 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002780 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002781 default:
2782 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002783 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002784
Craig Topperf40110f2014-04-25 05:29:35 +00002785 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002786}
2787
Sanjay Patel10494b22016-09-16 16:10:22 +00002788/// Handle icmp with constant (but not simple integer constant) RHS.
2789Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2790 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2791 Constant *RHSC = dyn_cast<Constant>(Op1);
2792 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2793 if (!RHSC || !LHSI)
2794 return nullptr;
2795
2796 switch (LHSI->getOpcode()) {
2797 case Instruction::GetElementPtr:
2798 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2799 if (RHSC->isNullValue() &&
2800 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2801 return new ICmpInst(
2802 I.getPredicate(), LHSI->getOperand(0),
2803 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2804 break;
2805 case Instruction::PHI:
2806 // Only fold icmp into the PHI if the phi and icmp are in the same
2807 // block. If in the same block, we're encouraging jump threading. If
2808 // not, we are just pessimizing the code by making an i1 phi.
2809 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002810 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002811 return NV;
2812 break;
2813 case Instruction::Select: {
2814 // If either operand of the select is a constant, we can fold the
2815 // comparison into the select arms, which will cause one to be
2816 // constant folded and the select turned into a bitwise or.
2817 Value *Op1 = nullptr, *Op2 = nullptr;
2818 ConstantInt *CI = nullptr;
2819 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2820 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2821 CI = dyn_cast<ConstantInt>(Op1);
2822 }
2823 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2824 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2825 CI = dyn_cast<ConstantInt>(Op2);
2826 }
2827
2828 // We only want to perform this transformation if it will not lead to
2829 // additional code. This is true if either both sides of the select
2830 // fold to a constant (in which case the icmp is replaced with a select
2831 // which will usually simplify) or this is the only user of the
2832 // select (in which case we are trading a select+icmp for a simpler
2833 // select+icmp) or all uses of the select can be replaced based on
2834 // dominance information ("Global cases").
2835 bool Transform = false;
2836 if (Op1 && Op2)
2837 Transform = true;
2838 else if (Op1 || Op2) {
2839 // Local case
2840 if (LHSI->hasOneUse())
2841 Transform = true;
2842 // Global cases
2843 else if (CI && !CI->isZero())
2844 // When Op1 is constant try replacing select with second operand.
2845 // Otherwise Op2 is constant and try replacing select with first
2846 // operand.
2847 Transform =
2848 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2849 }
2850 if (Transform) {
2851 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002852 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2853 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002854 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002855 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2856 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002857 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2858 }
2859 break;
2860 }
2861 case Instruction::IntToPtr:
2862 // icmp pred inttoptr(X), null -> icmp pred X, 0
2863 if (RHSC->isNullValue() &&
2864 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2865 return new ICmpInst(
2866 I.getPredicate(), LHSI->getOperand(0),
2867 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2868 break;
2869
2870 case Instruction::Load:
2871 // Try to optimize things like "A[i] > 4" to index computations.
2872 if (GetElementPtrInst *GEP =
2873 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2874 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2875 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2876 !cast<LoadInst>(LHSI)->isVolatile())
2877 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2878 return Res;
2879 }
2880 break;
2881 }
2882
2883 return nullptr;
2884}
2885
2886/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00002887/// TODO: A large part of this logic is duplicated in InstSimplify's
2888/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
2889/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00002890Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
2891 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2892
2893 // Special logic for binary operators.
2894 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
2895 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
2896 if (!BO0 && !BO1)
2897 return nullptr;
2898
Sanjay Patel2a062632017-05-08 16:33:42 +00002899 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00002900 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
2901 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
2902 NoOp0WrapProblem =
2903 ICmpInst::isEquality(Pred) ||
2904 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
2905 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
2906 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
2907 NoOp1WrapProblem =
2908 ICmpInst::isEquality(Pred) ||
2909 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
2910 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
2911
2912 // Analyze the case when either Op0 or Op1 is an add instruction.
2913 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
2914 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
2915 if (BO0 && BO0->getOpcode() == Instruction::Add) {
2916 A = BO0->getOperand(0);
2917 B = BO0->getOperand(1);
2918 }
2919 if (BO1 && BO1->getOpcode() == Instruction::Add) {
2920 C = BO1->getOperand(0);
2921 D = BO1->getOperand(1);
2922 }
2923
Sanjay Patel10494b22016-09-16 16:10:22 +00002924 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
2925 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
2926 return new ICmpInst(Pred, A == Op1 ? B : A,
2927 Constant::getNullValue(Op1->getType()));
2928
2929 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
2930 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
2931 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
2932 C == Op0 ? D : C);
2933
2934 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
2935 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
2936 NoOp1WrapProblem &&
2937 // Try not to increase register pressure.
2938 BO0->hasOneUse() && BO1->hasOneUse()) {
2939 // Determine Y and Z in the form icmp (X+Y), (X+Z).
2940 Value *Y, *Z;
2941 if (A == C) {
2942 // C + B == C + D -> B == D
2943 Y = B;
2944 Z = D;
2945 } else if (A == D) {
2946 // D + B == C + D -> B == C
2947 Y = B;
2948 Z = C;
2949 } else if (B == C) {
2950 // A + C == C + D -> A == D
2951 Y = A;
2952 Z = D;
2953 } else {
2954 assert(B == D);
2955 // A + D == C + D -> A == C
2956 Y = A;
2957 Z = C;
2958 }
2959 return new ICmpInst(Pred, Y, Z);
2960 }
2961
2962 // icmp slt (X + -1), Y -> icmp sle X, Y
2963 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
2964 match(B, m_AllOnes()))
2965 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
2966
2967 // icmp sge (X + -1), Y -> icmp sgt X, Y
2968 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
2969 match(B, m_AllOnes()))
2970 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
2971
2972 // icmp sle (X + 1), Y -> icmp slt X, Y
2973 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
2974 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
2975
2976 // icmp sgt (X + 1), Y -> icmp sge X, Y
2977 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
2978 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
2979
2980 // icmp sgt X, (Y + -1) -> icmp sge X, Y
2981 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
2982 match(D, m_AllOnes()))
2983 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
2984
2985 // icmp sle X, (Y + -1) -> icmp slt X, Y
2986 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
2987 match(D, m_AllOnes()))
2988 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
2989
2990 // icmp sge X, (Y + 1) -> icmp sgt X, Y
2991 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
2992 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
2993
2994 // icmp slt X, (Y + 1) -> icmp sle X, Y
2995 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
2996 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
2997
Sanjay Patel40f40172017-01-13 23:25:46 +00002998 // TODO: The subtraction-related identities shown below also hold, but
2999 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3000 // wouldn't happen even if they were implemented.
3001 //
3002 // icmp ult (X - 1), Y -> icmp ule X, Y
3003 // icmp uge (X - 1), Y -> icmp ugt X, Y
3004 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3005 // icmp ule X, (Y - 1) -> icmp ult X, Y
3006
3007 // icmp ule (X + 1), Y -> icmp ult X, Y
3008 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3009 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3010
3011 // icmp ugt (X + 1), Y -> icmp uge X, Y
3012 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3013 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3014
3015 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3016 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3017 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3018
3019 // icmp ult X, (Y + 1) -> icmp ule X, Y
3020 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3021 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3022
Sanjay Patel10494b22016-09-16 16:10:22 +00003023 // if C1 has greater magnitude than C2:
3024 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3025 // s.t. C3 = C1 - C2
3026 //
3027 // if C2 has greater magnitude than C1:
3028 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3029 // s.t. C3 = C2 - C1
3030 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3031 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3032 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3033 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3034 const APInt &AP1 = C1->getValue();
3035 const APInt &AP2 = C2->getValue();
3036 if (AP1.isNegative() == AP2.isNegative()) {
3037 APInt AP1Abs = C1->getValue().abs();
3038 APInt AP2Abs = C2->getValue().abs();
3039 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003040 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3041 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003042 return new ICmpInst(Pred, NewAdd, C);
3043 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003044 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3045 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003046 return new ICmpInst(Pred, A, NewAdd);
3047 }
3048 }
3049 }
3050
3051 // Analyze the case when either Op0 or Op1 is a sub instruction.
3052 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3053 A = nullptr;
3054 B = nullptr;
3055 C = nullptr;
3056 D = nullptr;
3057 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3058 A = BO0->getOperand(0);
3059 B = BO0->getOperand(1);
3060 }
3061 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3062 C = BO1->getOperand(0);
3063 D = BO1->getOperand(1);
3064 }
3065
3066 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3067 if (A == Op1 && NoOp0WrapProblem)
3068 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
3069
3070 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3071 if (C == Op0 && NoOp1WrapProblem)
3072 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3073
3074 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3075 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3076 // Try not to increase register pressure.
3077 BO0->hasOneUse() && BO1->hasOneUse())
3078 return new ICmpInst(Pred, A, C);
3079
3080 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3081 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3082 // Try not to increase register pressure.
3083 BO0->hasOneUse() && BO1->hasOneUse())
3084 return new ICmpInst(Pred, D, B);
3085
3086 // icmp (0-X) < cst --> x > -cst
3087 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3088 Value *X;
3089 if (match(BO0, m_Neg(m_Value(X))))
3090 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
3091 if (!RHSC->isMinValue(/*isSigned=*/true))
3092 return new ICmpInst(I.getSwappedPredicate(), X,
3093 ConstantExpr::getNeg(RHSC));
3094 }
3095
3096 BinaryOperator *SRem = nullptr;
3097 // icmp (srem X, Y), Y
3098 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3099 SRem = BO0;
3100 // icmp Y, (srem X, Y)
3101 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3102 Op0 == BO1->getOperand(1))
3103 SRem = BO1;
3104 if (SRem) {
3105 // We don't check hasOneUse to avoid increasing register pressure because
3106 // the value we use is the same value this instruction was already using.
3107 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3108 default:
3109 break;
3110 case ICmpInst::ICMP_EQ:
3111 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3112 case ICmpInst::ICMP_NE:
3113 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3114 case ICmpInst::ICMP_SGT:
3115 case ICmpInst::ICMP_SGE:
3116 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3117 Constant::getAllOnesValue(SRem->getType()));
3118 case ICmpInst::ICMP_SLT:
3119 case ICmpInst::ICMP_SLE:
3120 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3121 Constant::getNullValue(SRem->getType()));
3122 }
3123 }
3124
3125 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3126 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3127 switch (BO0->getOpcode()) {
3128 default:
3129 break;
3130 case Instruction::Add:
3131 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003132 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003133 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003134 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003135
3136 const APInt *C;
3137 if (match(BO0->getOperand(1), m_APInt(C))) {
3138 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3139 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003140 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003141 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003142 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003143 }
3144
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003145 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3146 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003147 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003148 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003149 NewPred = I.getSwappedPredicate(NewPred);
3150 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003151 }
3152 }
3153 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003154 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003155 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003156 if (!I.isEquality())
3157 break;
3158
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003159 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003160 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3161 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003162 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3163 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003164 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003165 Constant *Mask = ConstantInt::get(
3166 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003167 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003168 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3169 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003170 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003171 }
Sanjay Patel51506122017-05-25 14:13:57 +00003172 // If there are no trailing zeros in the multiplier, just eliminate
3173 // the multiplies (no masking is needed):
3174 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3175 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003176 }
3177 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003178 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003179 case Instruction::UDiv:
3180 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003181 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003182 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003183 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3184
Sanjay Patel10494b22016-09-16 16:10:22 +00003185 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003186 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3187 break;
3188 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3189
Sanjay Patel10494b22016-09-16 16:10:22 +00003190 case Instruction::AShr:
3191 if (!BO0->isExact() || !BO1->isExact())
3192 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003193 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003194
Sanjay Patel10494b22016-09-16 16:10:22 +00003195 case Instruction::Shl: {
3196 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3197 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3198 if (!NUW && !NSW)
3199 break;
3200 if (!NSW && I.isSigned())
3201 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003202 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003203 }
3204 }
3205 }
3206
3207 if (BO0) {
3208 // Transform A & (L - 1) `ult` L --> L != 0
3209 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003210 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003211
Sanjay Patel2a062632017-05-08 16:33:42 +00003212 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003213 auto *Zero = Constant::getNullValue(BO0->getType());
3214 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3215 }
3216 }
3217
3218 return nullptr;
3219}
3220
Sanjay Pateldd46b522016-12-19 17:32:37 +00003221/// Fold icmp Pred min|max(X, Y), X.
3222static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003223 ICmpInst::Predicate Pred = Cmp.getPredicate();
3224 Value *Op0 = Cmp.getOperand(0);
3225 Value *X = Cmp.getOperand(1);
3226
Sanjay Pateldd46b522016-12-19 17:32:37 +00003227 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003228 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003229 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3230 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3231 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003232 std::swap(Op0, X);
3233 Pred = Cmp.getSwappedPredicate();
3234 }
3235
3236 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003237 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003238 // smin(X, Y) == X --> X s<= Y
3239 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003240 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3241 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3242
Sanjay Pateldd46b522016-12-19 17:32:37 +00003243 // smin(X, Y) != X --> X s> Y
3244 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003245 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3246 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3247
3248 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003249 // smin(X, Y) s<= X --> true
3250 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003251 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003252 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003253
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003254 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003255 // smax(X, Y) == X --> X s>= Y
3256 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003257 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3258 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003259
Sanjay Pateldd46b522016-12-19 17:32:37 +00003260 // smax(X, Y) != X --> X s< Y
3261 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003262 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3263 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003264
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003265 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003266 // smax(X, Y) s>= X --> true
3267 // smax(X, Y) s< X --> false
3268 return nullptr;
3269 }
3270
3271 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3272 // umin(X, Y) == X --> X u<= Y
3273 // umin(X, Y) u>= X --> X u<= Y
3274 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3275 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3276
3277 // umin(X, Y) != X --> X u> Y
3278 // umin(X, Y) u< X --> X u> Y
3279 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3280 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3281
3282 // These cases should be handled in InstSimplify:
3283 // umin(X, Y) u<= X --> true
3284 // umin(X, Y) u> X --> false
3285 return nullptr;
3286 }
3287
3288 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3289 // umax(X, Y) == X --> X u>= Y
3290 // umax(X, Y) u<= X --> X u>= Y
3291 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3292 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3293
3294 // umax(X, Y) != X --> X u< Y
3295 // umax(X, Y) u> X --> X u< Y
3296 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3297 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3298
3299 // These cases should be handled in InstSimplify:
3300 // umax(X, Y) u>= X --> true
3301 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003302 return nullptr;
3303 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003304
Sanjay Pateld6406412016-12-15 19:13:37 +00003305 return nullptr;
3306}
3307
Sanjay Patel10494b22016-09-16 16:10:22 +00003308Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3309 if (!I.isEquality())
3310 return nullptr;
3311
3312 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003313 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003314 Value *A, *B, *C, *D;
3315 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3316 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3317 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003318 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003319 }
3320
3321 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3322 // A^c1 == C^c2 --> A == C^(c1^c2)
3323 ConstantInt *C1, *C2;
3324 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3325 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003326 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3327 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003328 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003329 }
3330
3331 // A^B == A^D -> B == D
3332 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003333 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003334 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003335 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003336 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003337 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003338 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003339 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003340 }
3341 }
3342
3343 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3344 // A == (A^B) -> B == 0
3345 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003346 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003347 }
3348
3349 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3350 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3351 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3352 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3353
3354 if (A == C) {
3355 X = B;
3356 Y = D;
3357 Z = A;
3358 } else if (A == D) {
3359 X = B;
3360 Y = C;
3361 Z = A;
3362 } else if (B == C) {
3363 X = A;
3364 Y = D;
3365 Z = B;
3366 } else if (B == D) {
3367 X = A;
3368 Y = C;
3369 Z = B;
3370 }
3371
3372 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003373 Op1 = Builder.CreateXor(X, Y);
3374 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003375 I.setOperand(0, Op1);
3376 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3377 return &I;
3378 }
3379 }
3380
3381 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3382 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3383 ConstantInt *Cst1;
3384 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3385 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3386 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3387 match(Op1, m_ZExt(m_Value(A))))) {
3388 APInt Pow2 = Cst1->getValue() + 1;
3389 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3390 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003391 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003392 }
3393
3394 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3395 // For lshr and ashr pairs.
3396 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3397 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3398 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3399 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3400 unsigned TypeBits = Cst1->getBitWidth();
3401 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3402 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003403 ICmpInst::Predicate NewPred =
3404 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003405 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003406 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003407 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003408 }
3409 }
3410
3411 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3412 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3413 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3414 unsigned TypeBits = Cst1->getBitWidth();
3415 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3416 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003417 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003418 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003419 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003420 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003421 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003422 }
3423 }
3424
3425 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3426 // "icmp (and X, mask), cst"
3427 uint64_t ShAmt = 0;
3428 if (Op0->hasOneUse() &&
3429 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3430 match(Op1, m_ConstantInt(Cst1)) &&
3431 // Only do this when A has multiple uses. This is most important to do
3432 // when it exposes other optimizations.
3433 !A->hasOneUse()) {
3434 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3435
3436 if (ShAmt < ASize) {
3437 APInt MaskV =
3438 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3439 MaskV <<= ShAmt;
3440
3441 APInt CmpV = Cst1->getValue().zext(ASize);
3442 CmpV <<= ShAmt;
3443
Craig Topperbb4069e2017-07-07 23:16:26 +00003444 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3445 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003446 }
3447 }
3448
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003449 // If both operands are byte-swapped or bit-reversed, just compare the
3450 // original values.
3451 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3452 // and handle more intrinsics.
3453 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003454 (match(Op0, m_BitReverse(m_Value(A))) &&
3455 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003456 return new ICmpInst(Pred, A, B);
3457
Sanjay Patel10494b22016-09-16 16:10:22 +00003458 return nullptr;
3459}
3460
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003461/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3462/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003463Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003464 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003465 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003466 Type *SrcTy = LHSCIOp->getType();
3467 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003468 Value *RHSCIOp;
3469
Jim Grosbach129c52a2011-09-30 18:09:53 +00003470 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003471 // integer type is the same size as the pointer type.
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003472 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
3473 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) {
Craig Topperf40110f2014-04-25 05:29:35 +00003474 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003475 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003476 Value *RHSCIOp = RHSC->getOperand(0);
3477 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3478 LHSCIOp->getType()->getPointerAddressSpace()) {
3479 RHSOp = RHSC->getOperand(0);
3480 // If the pointer types don't match, insert a bitcast.
3481 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003482 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003483 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003484 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003485 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003486 }
Chris Lattner2188e402010-01-04 07:37:31 +00003487
3488 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003489 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003490 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003491
Chris Lattner2188e402010-01-04 07:37:31 +00003492 // The code below only handles extension cast instructions, so far.
3493 // Enforce this.
3494 if (LHSCI->getOpcode() != Instruction::ZExt &&
3495 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003496 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003497
3498 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003499 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003500
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003501 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003502 // Not an extension from the same type?
3503 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003504 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003505 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003506
Chris Lattner2188e402010-01-04 07:37:31 +00003507 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3508 // and the other is a zext), then we can't handle this.
3509 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003510 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003511
3512 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003513 if (ICmp.isEquality())
3514 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003515
3516 // A signed comparison of sign extended values simplifies into a
3517 // signed comparison.
3518 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003519 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003520
3521 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003522 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003523 }
3524
Sanjay Patel4c204232016-06-04 20:39:22 +00003525 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003526 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3527 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003528 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003529
3530 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003531 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003532 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003533 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003534
3535 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003536 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003537 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003538 if (ICmp.isEquality())
3539 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003540
3541 // A signed comparison of sign extended values simplifies into a
3542 // signed comparison.
3543 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003544 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003545
3546 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003547 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003548 }
3549
Sanjay Patel6a333c32016-06-06 16:56:57 +00003550 // The re-extended constant changed, partly changed (in the case of a vector),
3551 // or could not be determined to be equal (in the case of a constant
3552 // expression), so the constant cannot be represented in the shorter type.
3553 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003554 // All the cases that fold to true or false will have already been handled
3555 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003556
Sanjay Patel6a333c32016-06-06 16:56:57 +00003557 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003558 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003559
3560 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3561 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003562
3563 // We're performing an unsigned comp with a sign extended value.
3564 // This is true if the input is >= 0. [aka >s -1]
3565 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003566 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003567
3568 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003569 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3570 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003571
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003572 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003573 return BinaryOperator::CreateNot(Result);
3574}
3575
Sanjoy Dasb0984472015-04-08 04:27:22 +00003576bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3577 Value *RHS, Instruction &OrigI,
3578 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003579 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3580 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003581
3582 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3583 Result = OpResult;
3584 Overflow = OverflowVal;
3585 if (ReuseName)
3586 Result->takeName(&OrigI);
3587 return true;
3588 };
3589
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003590 // If the overflow check was an add followed by a compare, the insertion point
3591 // may be pointing to the compare. We want to insert the new instructions
3592 // before the add in case there are uses of the add between the add and the
3593 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003594 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003595
Sanjoy Dasb0984472015-04-08 04:27:22 +00003596 switch (OCF) {
3597 case OCF_INVALID:
3598 llvm_unreachable("bad overflow check kind!");
3599
3600 case OCF_UNSIGNED_ADD: {
3601 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3602 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003603 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003604 true);
3605
3606 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003607 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003608
3609 // Fall through uadd into sadd
3610 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003611 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003612 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003613 // X + 0 -> {X, false}
3614 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003615 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003616
3617 // We can strength reduce this signed add into a regular add if we can prove
3618 // that it will never overflow.
3619 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003620 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003621 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003622 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003623 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003624 }
3625
3626 case OCF_UNSIGNED_SUB:
3627 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003628 // X - 0 -> {X, false}
3629 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003630 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003631
3632 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003633 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003634 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003635 true);
3636 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003637 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003638 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003639 true);
3640 }
3641 break;
3642 }
3643
3644 case OCF_UNSIGNED_MUL: {
3645 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3646 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003647 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003648 true);
3649 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003650 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003651 LLVM_FALLTHROUGH;
3652 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003653 case OCF_SIGNED_MUL:
3654 // X * undef -> undef
3655 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003656 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003657
David Majnemer27e89ba2015-05-21 23:04:21 +00003658 // X * 0 -> {0, false}
3659 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003660 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003661
David Majnemer27e89ba2015-05-21 23:04:21 +00003662 // X * 1 -> {X, false}
3663 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003664 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003665
3666 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003667 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003668 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003669 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003670 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003671 }
3672
3673 return false;
3674}
3675
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003676/// \brief Recognize and process idiom involving test for multiplication
3677/// overflow.
3678///
3679/// The caller has matched a pattern of the form:
3680/// I = cmp u (mul(zext A, zext B), V
3681/// The function checks if this is a test for overflow and if so replaces
3682/// multiplication with call to 'mul.with.overflow' intrinsic.
3683///
3684/// \param I Compare instruction.
3685/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3686/// the compare instruction. Must be of integer type.
3687/// \param OtherVal The other argument of compare instruction.
3688/// \returns Instruction which must replace the compare instruction, NULL if no
3689/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003690static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003691 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003692 // Don't bother doing this transformation for pointers, don't do it for
3693 // vectors.
3694 if (!isa<IntegerType>(MulVal->getType()))
3695 return nullptr;
3696
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003697 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3698 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003699 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3700 if (!MulInstr)
3701 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003702 assert(MulInstr->getOpcode() == Instruction::Mul);
3703
David Majnemer634ca232014-11-01 23:46:05 +00003704 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3705 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003706 assert(LHS->getOpcode() == Instruction::ZExt);
3707 assert(RHS->getOpcode() == Instruction::ZExt);
3708 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3709
3710 // Calculate type and width of the result produced by mul.with.overflow.
3711 Type *TyA = A->getType(), *TyB = B->getType();
3712 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3713 WidthB = TyB->getPrimitiveSizeInBits();
3714 unsigned MulWidth;
3715 Type *MulType;
3716 if (WidthB > WidthA) {
3717 MulWidth = WidthB;
3718 MulType = TyB;
3719 } else {
3720 MulWidth = WidthA;
3721 MulType = TyA;
3722 }
3723
3724 // In order to replace the original mul with a narrower mul.with.overflow,
3725 // all uses must ignore upper bits of the product. The number of used low
3726 // bits must be not greater than the width of mul.with.overflow.
3727 if (MulVal->hasNUsesOrMore(2))
3728 for (User *U : MulVal->users()) {
3729 if (U == &I)
3730 continue;
3731 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3732 // Check if truncation ignores bits above MulWidth.
3733 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3734 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003735 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003736 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3737 // Check if AND ignores bits above MulWidth.
3738 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003739 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003740 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3741 const APInt &CVal = CI->getValue();
3742 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003743 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003744 } else {
3745 // In this case we could have the operand of the binary operation
3746 // being defined in another block, and performing the replacement
3747 // could break the dominance relation.
3748 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003749 }
3750 } else {
3751 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003752 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003753 }
3754 }
3755
3756 // Recognize patterns
3757 switch (I.getPredicate()) {
3758 case ICmpInst::ICMP_EQ:
3759 case ICmpInst::ICMP_NE:
3760 // Recognize pattern:
3761 // mulval = mul(zext A, zext B)
3762 // cmp eq/neq mulval, zext trunc mulval
3763 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3764 if (Zext->hasOneUse()) {
3765 Value *ZextArg = Zext->getOperand(0);
3766 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3767 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3768 break; //Recognized
3769 }
3770
3771 // Recognize pattern:
3772 // mulval = mul(zext A, zext B)
3773 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3774 ConstantInt *CI;
3775 Value *ValToMask;
3776 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3777 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003778 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003779 const APInt &CVal = CI->getValue() + 1;
3780 if (CVal.isPowerOf2()) {
3781 unsigned MaskWidth = CVal.logBase2();
3782 if (MaskWidth == MulWidth)
3783 break; // Recognized
3784 }
3785 }
Craig Topperf40110f2014-04-25 05:29:35 +00003786 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003787
3788 case ICmpInst::ICMP_UGT:
3789 // Recognize pattern:
3790 // mulval = mul(zext A, zext B)
3791 // cmp ugt mulval, max
3792 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3793 APInt MaxVal = APInt::getMaxValue(MulWidth);
3794 MaxVal = MaxVal.zext(CI->getBitWidth());
3795 if (MaxVal.eq(CI->getValue()))
3796 break; // Recognized
3797 }
Craig Topperf40110f2014-04-25 05:29:35 +00003798 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003799
3800 case ICmpInst::ICMP_UGE:
3801 // Recognize pattern:
3802 // mulval = mul(zext A, zext B)
3803 // cmp uge mulval, max+1
3804 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3805 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3806 if (MaxVal.eq(CI->getValue()))
3807 break; // Recognized
3808 }
Craig Topperf40110f2014-04-25 05:29:35 +00003809 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003810
3811 case ICmpInst::ICMP_ULE:
3812 // Recognize pattern:
3813 // mulval = mul(zext A, zext B)
3814 // cmp ule mulval, max
3815 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3816 APInt MaxVal = APInt::getMaxValue(MulWidth);
3817 MaxVal = MaxVal.zext(CI->getBitWidth());
3818 if (MaxVal.eq(CI->getValue()))
3819 break; // Recognized
3820 }
Craig Topperf40110f2014-04-25 05:29:35 +00003821 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003822
3823 case ICmpInst::ICMP_ULT:
3824 // Recognize pattern:
3825 // mulval = mul(zext A, zext B)
3826 // cmp ule mulval, max + 1
3827 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003828 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003829 if (MaxVal.eq(CI->getValue()))
3830 break; // Recognized
3831 }
Craig Topperf40110f2014-04-25 05:29:35 +00003832 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003833
3834 default:
Craig Topperf40110f2014-04-25 05:29:35 +00003835 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003836 }
3837
Craig Topperbb4069e2017-07-07 23:16:26 +00003838 InstCombiner::BuilderTy &Builder = IC.Builder;
3839 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003840
3841 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
3842 Value *MulA = A, *MulB = B;
3843 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00003844 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003845 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00003846 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00003847 Value *F = Intrinsic::getDeclaration(I.getModule(),
3848 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00003849 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003850 IC.Worklist.Add(MulInstr);
3851
3852 // If there are uses of mul result other than the comparison, we know that
3853 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003854 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003855 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003856 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003857 for (User *U : MulVal->users()) {
3858 if (U == &I || U == OtherVal)
3859 continue;
3860 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3861 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00003862 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003863 else
3864 TI->setOperand(0, Mul);
3865 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3866 assert(BO->getOpcode() == Instruction::And);
3867 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00003868 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
3869 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00003870 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00003871 Instruction *Zext =
3872 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
3873 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00003874 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003875 } else {
3876 llvm_unreachable("Unexpected Binary operation");
3877 }
Davide Italiano579064e2017-07-16 18:56:30 +00003878 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003879 }
3880 }
3881 if (isa<Instruction>(OtherVal))
3882 IC.Worklist.Add(cast<Instruction>(OtherVal));
3883
3884 // The original icmp gets replaced with the overflow value, maybe inverted
3885 // depending on predicate.
3886 bool Inverse = false;
3887 switch (I.getPredicate()) {
3888 case ICmpInst::ICMP_NE:
3889 break;
3890 case ICmpInst::ICMP_EQ:
3891 Inverse = true;
3892 break;
3893 case ICmpInst::ICMP_UGT:
3894 case ICmpInst::ICMP_UGE:
3895 if (I.getOperand(0) == MulVal)
3896 break;
3897 Inverse = true;
3898 break;
3899 case ICmpInst::ICMP_ULT:
3900 case ICmpInst::ICMP_ULE:
3901 if (I.getOperand(1) == MulVal)
3902 break;
3903 Inverse = true;
3904 break;
3905 default:
3906 llvm_unreachable("Unexpected predicate");
3907 }
3908 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003909 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003910 return BinaryOperator::CreateNot(Res);
3911 }
3912
3913 return ExtractValueInst::Create(Call, 1);
3914}
3915
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003916/// When performing a comparison against a constant, it is possible that not all
3917/// the bits in the LHS are demanded. This helper method computes the mask that
3918/// IS demanded.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003919static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth,
3920 bool isSignCheck) {
Owen Andersond490c2d2011-01-11 00:36:45 +00003921 if (isSignCheck)
Craig Topperbcfd2d12017-04-20 16:56:25 +00003922 return APInt::getSignMask(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003923
Owen Andersond490c2d2011-01-11 00:36:45 +00003924 ConstantInt *CI = dyn_cast<ConstantInt>(I.getOperand(1));
3925 if (!CI) return APInt::getAllOnesValue(BitWidth);
Owen Anderson0022a4b2011-01-11 18:26:37 +00003926 const APInt &RHS = CI->getValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +00003927
Owen Andersond490c2d2011-01-11 00:36:45 +00003928 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00003929 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00003930 // correspond to the trailing ones of the comparand. The value of these
3931 // bits doesn't impact the outcome of the comparison, because any value
3932 // greater than the RHS must differ in a bit higher than these due to carry.
3933 case ICmpInst::ICMP_UGT: {
3934 unsigned trailingOnes = RHS.countTrailingOnes();
Craig Toppere7563f82017-04-13 21:49:48 +00003935 return APInt::getBitsSetFrom(BitWidth, trailingOnes);
Owen Andersond490c2d2011-01-11 00:36:45 +00003936 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003937
Owen Andersond490c2d2011-01-11 00:36:45 +00003938 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
3939 // Any value less than the RHS must differ in a higher bit because of carries.
3940 case ICmpInst::ICMP_ULT: {
3941 unsigned trailingZeros = RHS.countTrailingZeros();
Craig Toppere7563f82017-04-13 21:49:48 +00003942 return APInt::getBitsSetFrom(BitWidth, trailingZeros);
Owen Andersond490c2d2011-01-11 00:36:45 +00003943 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003944
Owen Andersond490c2d2011-01-11 00:36:45 +00003945 default:
3946 return APInt::getAllOnesValue(BitWidth);
3947 }
Owen Andersond490c2d2011-01-11 00:36:45 +00003948}
Chris Lattner2188e402010-01-04 07:37:31 +00003949
Quentin Colombet5ab55552013-09-09 20:56:48 +00003950/// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst
3951/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00003952/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00003953/// as subtract operands and their positions in those instructions.
3954/// The rational is that several architectures use the same instruction for
3955/// both subtract and cmp, thus it is better if the order of those operands
3956/// match.
3957/// \return true if Op0 and Op1 should be swapped.
3958static bool swapMayExposeCSEOpportunities(const Value * Op0,
3959 const Value * Op1) {
3960 // Filter out pointer value as those cannot appears directly in subtract.
3961 // FIXME: we may want to go through inttoptrs or bitcasts.
3962 if (Op0->getType()->isPointerTy())
3963 return false;
3964 // Count every uses of both Op0 and Op1 in a subtract.
3965 // Each time Op0 is the first operand, count -1: swapping is bad, the
3966 // subtract has already the same layout as the compare.
3967 // Each time Op0 is the second operand, count +1: swapping is good, the
Alp Tokercb402912014-01-24 17:20:08 +00003968 // subtract has a different layout as the compare.
Quentin Colombet5ab55552013-09-09 20:56:48 +00003969 // At the end, if the benefit is greater than 0, Op0 should come second to
3970 // expose more CSE opportunities.
3971 int GlobalSwapBenefits = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00003972 for (const User *U : Op0->users()) {
3973 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U);
Quentin Colombet5ab55552013-09-09 20:56:48 +00003974 if (!BinOp || BinOp->getOpcode() != Instruction::Sub)
3975 continue;
3976 // If Op0 is the first argument, this is not beneficial to swap the
3977 // arguments.
3978 int LocalSwapBenefits = -1;
3979 unsigned Op1Idx = 1;
3980 if (BinOp->getOperand(Op1Idx) == Op0) {
3981 Op1Idx = 0;
3982 LocalSwapBenefits = 1;
3983 }
3984 if (BinOp->getOperand(Op1Idx) != Op1)
3985 continue;
3986 GlobalSwapBenefits += LocalSwapBenefits;
3987 }
3988 return GlobalSwapBenefits > 0;
3989}
3990
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003991/// \brief Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00003992/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003993///
3994/// \param DI Definition
3995/// \param UI Use
3996/// \param DB Block that must dominate all uses of \p DI outside
3997/// the parent block
3998/// \return true when \p UI is the only use of \p DI in the parent block
3999/// and all other uses of \p DI are in blocks dominated by \p DB.
4000///
4001bool InstCombiner::dominatesAllUses(const Instruction *DI,
4002 const Instruction *UI,
4003 const BasicBlock *DB) const {
4004 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004005 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004006 if (!DI->getParent())
4007 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004008 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004009 if (DI->getParent() != UI->getParent())
4010 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004011 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004012 if (DI->getParent() == DB)
4013 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004014 for (const User *U : DI->users()) {
4015 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004016 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004017 return false;
4018 }
4019 return true;
4020}
4021
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004022/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004023static bool isChainSelectCmpBranch(const SelectInst *SI) {
4024 const BasicBlock *BB = SI->getParent();
4025 if (!BB)
4026 return false;
4027 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4028 if (!BI || BI->getNumSuccessors() != 2)
4029 return false;
4030 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4031 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4032 return false;
4033 return true;
4034}
4035
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004036/// \brief True when a select result is replaced by one of its operands
4037/// in select-icmp sequence. This will eventually result in the elimination
4038/// of the select.
4039///
4040/// \param SI Select instruction
4041/// \param Icmp Compare instruction
4042/// \param SIOpd Operand that replaces the select
4043///
4044/// Notes:
4045/// - The replacement is global and requires dominator information
4046/// - The caller is responsible for the actual replacement
4047///
4048/// Example:
4049///
4050/// entry:
4051/// %4 = select i1 %3, %C* %0, %C* null
4052/// %5 = icmp eq %C* %4, null
4053/// br i1 %5, label %9, label %7
4054/// ...
4055/// ; <label>:7 ; preds = %entry
4056/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4057/// ...
4058///
4059/// can be transformed to
4060///
4061/// %5 = icmp eq %C* %0, null
4062/// %6 = select i1 %3, i1 %5, i1 true
4063/// br i1 %6, label %9, label %7
4064/// ...
4065/// ; <label>:7 ; preds = %entry
4066/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4067///
4068/// Similar when the first operand of the select is a constant or/and
4069/// the compare is for not equal rather than equal.
4070///
4071/// NOTE: The function is only called when the select and compare constants
4072/// are equal, the optimization can work only for EQ predicates. This is not a
4073/// major restriction since a NE compare should be 'normalized' to an equal
4074/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004075/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004076bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4077 const ICmpInst *Icmp,
4078 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004079 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004080 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4081 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004082 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004083 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004084 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4085 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4086 // replaced can be reached on either path. So the uniqueness check
4087 // guarantees that the path all uses of SI (outside SI's parent) are on
4088 // is disjoint from all other paths out of SI. But that information
4089 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004090 // of compile-time. It should also be noticed that we check for a single
4091 // predecessor and not only uniqueness. This to handle the situation when
4092 // Succ and Succ1 points to the same basic block.
4093 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004094 NumSel++;
4095 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4096 return true;
4097 }
4098 }
4099 return false;
4100}
4101
Sanjay Patel3151dec2016-09-12 15:24:31 +00004102/// Try to fold the comparison based on range information we can get by checking
4103/// whether bits are known to be zero or one in the inputs.
4104Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4105 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4106 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004107 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004108
4109 // Get scalar or pointer size.
4110 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4111 ? Ty->getScalarSizeInBits()
4112 : DL.getTypeSizeInBits(Ty->getScalarType());
4113
4114 if (!BitWidth)
4115 return nullptr;
4116
4117 // If this is a normal comparison, it demands all bits. If it is a sign bit
4118 // comparison, it only demands the sign bit.
4119 bool IsSignBit = false;
Sanjay Patelf5887f12016-09-12 16:25:41 +00004120 const APInt *CmpC;
4121 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004122 bool UnusedBit;
Sanjay Patelf5887f12016-09-12 16:25:41 +00004123 IsSignBit = isSignBitCheck(Pred, *CmpC, UnusedBit);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004124 }
4125
Craig Topperb45eabc2017-04-26 16:39:58 +00004126 KnownBits Op0Known(BitWidth);
4127 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004128
Craig Topper47596dd2017-03-25 06:52:52 +00004129 if (SimplifyDemandedBits(&I, 0,
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004130 getDemandedBitsLHSMask(I, BitWidth, IsSignBit),
Craig Topperb45eabc2017-04-26 16:39:58 +00004131 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004132 return &I;
4133
Craig Topper47596dd2017-03-25 06:52:52 +00004134 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004135 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004136 return &I;
4137
4138 // Given the known and unknown bits, compute a range that the LHS could be
4139 // in. Compute the Min, Max and RHS values based on the known bits. For the
4140 // EQ and NE we use unsigned values.
4141 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4142 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4143 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004144 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4145 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004146 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004147 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4148 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004149 }
4150
4151 // If Min and Max are known to be the same, then SimplifyDemandedBits
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004152 // figured out that the LHS is a constant. Constant fold this now, so that
4153 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004154 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004155 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004156 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004157 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004158
4159 // Based on the range information we know about the LHS, see if we can
4160 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004161 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004162 default:
4163 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004164 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004165 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004166 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4167 return Pred == CmpInst::ICMP_EQ
4168 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4169 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4170 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004171
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004172 // If all bits are known zero except for one, then we know at most one bit
4173 // is set. If the comparison is against zero, then this is a check to see if
4174 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004175 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004176 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004177 // If the LHS is an AND with the same constant, look through it.
4178 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004179 const APInt *LHSC;
4180 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4181 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004182 LHS = Op0;
4183
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004184 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004185 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4186 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004187 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004188 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004189 // ((1 << X) & 8) == 0 -> X != 3
4190 // ((1 << X) & 8) != 0 -> X == 3
4191 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4192 auto NewPred = ICmpInst::getInversePredicate(Pred);
4193 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004194 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004195 // ((1 << X) & 7) == 0 -> X >= 3
4196 // ((1 << X) & 7) != 0 -> X < 3
4197 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4198 auto NewPred =
4199 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4200 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004201 }
4202 }
4203
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004204 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004205 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004206 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004207 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4208 // ((8 >>u X) & 1) == 0 -> X != 3
4209 // ((8 >>u X) & 1) != 0 -> X == 3
4210 unsigned CmpVal = CI->countTrailingZeros();
4211 auto NewPred = ICmpInst::getInversePredicate(Pred);
4212 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4213 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004214 }
4215 break;
4216 }
4217 case ICmpInst::ICMP_ULT: {
4218 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4219 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4220 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4221 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4222 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4223 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4224
4225 const APInt *CmpC;
4226 if (match(Op1, m_APInt(CmpC))) {
4227 // A <u C -> A == C-1 if min(A)+1 == C
4228 if (Op1Max == Op0Min + 1) {
4229 Constant *CMinus1 = ConstantInt::get(Op0->getType(), *CmpC - 1);
4230 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, CMinus1);
4231 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004232 }
4233 break;
4234 }
4235 case ICmpInst::ICMP_UGT: {
4236 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4237 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4238
4239 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4240 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4241
4242 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4243 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4244
4245 const APInt *CmpC;
4246 if (match(Op1, m_APInt(CmpC))) {
4247 // A >u C -> A == C+1 if max(a)-1 == C
4248 if (*CmpC == Op0Max - 1)
4249 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4250 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004251 }
4252 break;
4253 }
4254 case ICmpInst::ICMP_SLT:
4255 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4256 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4257 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4258 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4259 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4260 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4261 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) {
4262 if (Op1Max == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
4263 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topperbb4069e2017-07-07 23:16:26 +00004264 Builder.getInt(CI->getValue() - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004265 }
4266 break;
4267 case ICmpInst::ICMP_SGT:
4268 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4269 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4270 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4271 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4272
4273 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4274 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4275 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) {
4276 if (Op1Min == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
4277 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topperbb4069e2017-07-07 23:16:26 +00004278 Builder.getInt(CI->getValue() + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004279 }
4280 break;
4281 case ICmpInst::ICMP_SGE:
4282 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4283 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4284 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4285 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4286 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4287 break;
4288 case ICmpInst::ICMP_SLE:
4289 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4290 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4291 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4292 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4293 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4294 break;
4295 case ICmpInst::ICMP_UGE:
4296 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4297 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4298 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4299 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4300 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4301 break;
4302 case ICmpInst::ICMP_ULE:
4303 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4304 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4305 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4306 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4307 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4308 break;
4309 }
4310
4311 // Turn a signed comparison into an unsigned one if both operands are known to
4312 // have the same sign.
4313 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004314 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4315 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004316 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4317
4318 return nullptr;
4319}
4320
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004321/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4322/// it into the appropriate icmp lt or icmp gt instruction. This transform
4323/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004324static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4325 ICmpInst::Predicate Pred = I.getPredicate();
4326 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4327 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4328 return nullptr;
4329
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004330 Value *Op0 = I.getOperand(0);
4331 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004332 auto *Op1C = dyn_cast<Constant>(Op1);
4333 if (!Op1C)
4334 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004335
Sanjay Patele9b2c322016-05-17 00:57:57 +00004336 // Check if the constant operand can be safely incremented/decremented without
4337 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4338 // the edge cases for us, so we just assert on them. For vectors, we must
4339 // handle the edge cases.
4340 Type *Op1Type = Op1->getType();
4341 bool IsSigned = I.isSigned();
4342 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004343 auto *CI = dyn_cast<ConstantInt>(Op1C);
4344 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004345 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4346 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4347 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004348 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004349 // are for scalar, we could remove the min/max checks. However, to do that,
4350 // we would have to use insertelement/shufflevector to replace edge values.
4351 unsigned NumElts = Op1Type->getVectorNumElements();
4352 for (unsigned i = 0; i != NumElts; ++i) {
4353 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004354 if (!Elt)
4355 return nullptr;
4356
Sanjay Patele9b2c322016-05-17 00:57:57 +00004357 if (isa<UndefValue>(Elt))
4358 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004359
Sanjay Patele9b2c322016-05-17 00:57:57 +00004360 // Bail out if we can't determine if this constant is min/max or if we
4361 // know that this constant is min/max.
4362 auto *CI = dyn_cast<ConstantInt>(Elt);
4363 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4364 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004365 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004366 } else {
4367 // ConstantExpr?
4368 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004369 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004370
Sanjay Patele9b2c322016-05-17 00:57:57 +00004371 // Increment or decrement the constant and set the new comparison predicate:
4372 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004373 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004374 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4375 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4376 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004377}
4378
Sanjay Patele5747e32017-05-17 22:15:07 +00004379/// Integer compare with boolean values can always be turned into bitwise ops.
4380static Instruction *canonicalizeICmpBool(ICmpInst &I,
4381 InstCombiner::BuilderTy &Builder) {
4382 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004383 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004384
Sanjay Patelba212c22017-05-17 22:29:40 +00004385 // A boolean compared to true/false can be simplified to Op0/true/false in
4386 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4387 // Cases not handled by InstSimplify are always 'not' of Op0.
4388 if (match(B, m_Zero())) {
4389 switch (I.getPredicate()) {
4390 case CmpInst::ICMP_EQ: // A == 0 -> !A
4391 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4392 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4393 return BinaryOperator::CreateNot(A);
4394 default:
4395 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4396 }
4397 } else if (match(B, m_One())) {
4398 switch (I.getPredicate()) {
4399 case CmpInst::ICMP_NE: // A != 1 -> !A
4400 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4401 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4402 return BinaryOperator::CreateNot(A);
4403 default:
4404 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4405 }
4406 }
4407
Sanjay Patele5747e32017-05-17 22:15:07 +00004408 switch (I.getPredicate()) {
4409 default:
4410 llvm_unreachable("Invalid icmp instruction!");
4411 case ICmpInst::ICMP_EQ:
4412 // icmp eq i1 A, B -> ~(A ^ B)
4413 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4414
4415 case ICmpInst::ICMP_NE:
4416 // icmp ne i1 A, B -> A ^ B
4417 return BinaryOperator::CreateXor(A, B);
4418
4419 case ICmpInst::ICMP_UGT:
4420 // icmp ugt -> icmp ult
4421 std::swap(A, B);
4422 LLVM_FALLTHROUGH;
4423 case ICmpInst::ICMP_ULT:
4424 // icmp ult i1 A, B -> ~A & B
4425 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4426
4427 case ICmpInst::ICMP_SGT:
4428 // icmp sgt -> icmp slt
4429 std::swap(A, B);
4430 LLVM_FALLTHROUGH;
4431 case ICmpInst::ICMP_SLT:
4432 // icmp slt i1 A, B -> A & ~B
4433 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4434
4435 case ICmpInst::ICMP_UGE:
4436 // icmp uge -> icmp ule
4437 std::swap(A, B);
4438 LLVM_FALLTHROUGH;
4439 case ICmpInst::ICMP_ULE:
4440 // icmp ule i1 A, B -> ~A | B
4441 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4442
4443 case ICmpInst::ICMP_SGE:
4444 // icmp sge -> icmp sle
4445 std::swap(A, B);
4446 LLVM_FALLTHROUGH;
4447 case ICmpInst::ICMP_SLE:
4448 // icmp sle i1 A, B -> A | ~B
4449 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4450 }
4451}
4452
Chris Lattner2188e402010-01-04 07:37:31 +00004453Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4454 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004455 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004456 unsigned Op0Cplxity = getComplexity(Op0);
4457 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004458
Chris Lattner2188e402010-01-04 07:37:31 +00004459 /// Orders the operands of the compare so that they are listed from most
4460 /// complex to least complex. This puts constants before unary operators,
4461 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004462 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004463 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004464 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004465 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004466 Changed = true;
4467 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004468
Daniel Berlin2c75c632017-04-26 20:56:07 +00004469 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4470 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004471 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004472
Pete Cooperbc5c5242011-12-01 03:58:40 +00004473 // comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004474 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004475 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004476 Value *Cond, *SelectTrue, *SelectFalse;
4477 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004478 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004479 if (Value *V = dyn_castNegVal(SelectTrue)) {
4480 if (V == SelectFalse)
4481 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4482 }
4483 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4484 if (V == SelectTrue)
4485 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004486 }
4487 }
4488 }
4489
Craig Topperfde47232017-07-09 07:04:03 +00004490 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004491 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004492 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004493
Sanjay Patele9b2c322016-05-17 00:57:57 +00004494 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004495 return NewICmp;
4496
Sanjay Patel06b127a2016-09-15 14:37:50 +00004497 if (Instruction *Res = foldICmpWithConstant(I))
4498 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004499
Sanjay Patel3151dec2016-09-12 15:24:31 +00004500 if (Instruction *Res = foldICmpUsingKnownBits(I))
4501 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004502
4503 // Test if the ICmpInst instruction is used exclusively by a select as
4504 // part of a minimum or maximum operation. If so, refrain from doing
4505 // any other folding. This helps out other analyses which understand
4506 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4507 // and CodeGen. And in this case, at least one of the comparison
4508 // operands has at least one user besides the compare (the select),
4509 // which would often largely negate the benefit of folding anyway.
4510 if (I.hasOneUse())
Chandler Carruthcdf47882014-03-09 03:16:01 +00004511 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
Chris Lattner2188e402010-01-04 07:37:31 +00004512 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4513 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
Craig Topperf40110f2014-04-25 05:29:35 +00004514 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004515
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004516 // FIXME: We only do this after checking for min/max to prevent infinite
4517 // looping caused by a reverse canonicalization of these patterns for min/max.
4518 // FIXME: The organization of folds is a mess. These would naturally go into
4519 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4520 // down here after the min/max restriction.
4521 ICmpInst::Predicate Pred = I.getPredicate();
4522 const APInt *C;
4523 if (match(Op1, m_APInt(C))) {
4524 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4525 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4526 Constant *Zero = Constant::getNullValue(Op0->getType());
4527 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4528 }
4529
4530 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4531 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4532 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4533 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4534 }
4535 }
4536
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004537 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004538 return Res;
4539
Sanjay Patel10494b22016-09-16 16:10:22 +00004540 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4541 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004542
4543 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4544 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004545 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004546 return NI;
4547 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004548 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004549 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4550 return NI;
4551
Hans Wennborgf1f36512015-10-07 00:20:07 +00004552 // Try to optimize equality comparisons against alloca-based pointers.
4553 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4554 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4555 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004556 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004557 return New;
4558 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004559 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004560 return New;
4561 }
4562
Chris Lattner2188e402010-01-04 07:37:31 +00004563 // Test to see if the operands of the icmp are casted versions of other
4564 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4565 // now.
4566 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004567 if (Op0->getType()->isPointerTy() &&
4568 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004569 // We keep moving the cast from the left operand over to the right
4570 // operand, where it can often be eliminated completely.
4571 Op0 = CI->getOperand(0);
4572
4573 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4574 // so eliminate it as well.
4575 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4576 Op1 = CI2->getOperand(0);
4577
4578 // If Op1 is a constant, we can fold the cast into the constant.
4579 if (Op0->getType() != Op1->getType()) {
4580 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4581 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4582 } else {
4583 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004584 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004585 }
4586 }
4587 return new ICmpInst(I.getPredicate(), Op0, Op1);
4588 }
4589 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004590
Chris Lattner2188e402010-01-04 07:37:31 +00004591 if (isa<CastInst>(Op0)) {
4592 // Handle the special case of: icmp (cast bool to X), <cst>
4593 // This comes up when you have code like
4594 // int X = A < B;
4595 // if (X) ...
4596 // For generality, we handle any zero-extension of any operand comparison
4597 // with a constant or another cast from the same type.
4598 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004599 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004600 return R;
4601 }
Chris Lattner2188e402010-01-04 07:37:31 +00004602
Sanjay Patel10494b22016-09-16 16:10:22 +00004603 if (Instruction *Res = foldICmpBinOp(I))
4604 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004605
Sanjay Pateldd46b522016-12-19 17:32:37 +00004606 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004607 return Res;
4608
Sanjay Patel10494b22016-09-16 16:10:22 +00004609 {
4610 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004611 // Transform (A & ~B) == 0 --> (A & B) != 0
4612 // and (A & ~B) != 0 --> (A & B) == 0
4613 // if A is a power of 2.
4614 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004615 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004616 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004617 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004618 Op1);
4619
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004620 // ~X < ~Y --> Y < X
4621 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004622 if (match(Op0, m_Not(m_Value(A)))) {
4623 if (match(Op1, m_Not(m_Value(B))))
4624 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004625
Sanjay Patelce241f42017-06-02 16:29:41 +00004626 const APInt *C;
4627 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004628 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004629 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004630 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004631
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004632 Instruction *AddI = nullptr;
4633 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4634 m_Instruction(AddI))) &&
4635 isa<IntegerType>(A->getType())) {
4636 Value *Result;
4637 Constant *Overflow;
4638 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4639 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004640 replaceInstUsesWith(*AddI, Result);
4641 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004642 }
4643 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004644
4645 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4646 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004647 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004648 return R;
4649 }
4650 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004651 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004652 return R;
4653 }
Chris Lattner2188e402010-01-04 07:37:31 +00004654 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004655
Sanjay Patel10494b22016-09-16 16:10:22 +00004656 if (Instruction *Res = foldICmpEquality(I))
4657 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004658
David Majnemerc1eca5a2014-11-06 23:23:30 +00004659 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4660 // an i1 which indicates whether or not we successfully did the swap.
4661 //
4662 // Replace comparisons between the old value and the expected value with the
4663 // indicator that 'cmpxchg' returns.
4664 //
4665 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4666 // spuriously fail. In those cases, the old value may equal the expected
4667 // value but it is possible for the swap to not occur.
4668 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4669 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4670 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4671 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4672 !ACXI->isWeak())
4673 return ExtractValueInst::Create(ACXI, 1);
4674
Chris Lattner2188e402010-01-04 07:37:31 +00004675 {
4676 Value *X; ConstantInt *Cst;
4677 // icmp X+Cst, X
4678 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X)
Sanjay Patel43395062016-07-21 18:07:40 +00004679 return foldICmpAddOpConst(I, X, Cst, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004680
4681 // icmp X, X+Cst
4682 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X)
Sanjay Patel43395062016-07-21 18:07:40 +00004683 return foldICmpAddOpConst(I, X, Cst, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004684 }
Craig Topperf40110f2014-04-25 05:29:35 +00004685 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004686}
4687
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004688/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004689Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004690 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004691 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004692 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004693
Chris Lattner2188e402010-01-04 07:37:31 +00004694 // Get the width of the mantissa. We don't want to hack on conversions that
4695 // might lose information from the integer, e.g. "i64 -> float"
4696 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00004697 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004698
Matt Arsenault55e73122015-01-06 15:50:59 +00004699 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
4700
Chris Lattner2188e402010-01-04 07:37:31 +00004701 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004702
Matt Arsenault55e73122015-01-06 15:50:59 +00004703 if (I.isEquality()) {
4704 FCmpInst::Predicate P = I.getPredicate();
4705 bool IsExact = false;
4706 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
4707 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
4708
4709 // If the floating point constant isn't an integer value, we know if we will
4710 // ever compare equal / not equal to it.
4711 if (!IsExact) {
4712 // TODO: Can never be -0.0 and other non-representable values
4713 APFloat RHSRoundInt(RHS);
4714 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
4715 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
4716 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00004717 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00004718
4719 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00004720 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00004721 }
4722 }
4723
4724 // TODO: If the constant is exactly representable, is it always OK to do
4725 // equality compares as integer?
4726 }
4727
Arch D. Robison8ed08542015-09-15 17:51:59 +00004728 // Check to see that the input is converted from an integer type that is small
4729 // enough that preserves all bits. TODO: check here for "known" sign bits.
4730 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
4731 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00004732
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004733 // Following test does NOT adjust InputSize downwards for signed inputs,
4734 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00004735 // to distinguish it from one less than that value.
4736 if ((int)InputSize > MantissaWidth) {
4737 // Conversion would lose accuracy. Check if loss can impact comparison.
4738 int Exp = ilogb(RHS);
4739 if (Exp == APFloat::IEK_Inf) {
4740 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004741 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004742 // Conversion could create infinity.
4743 return nullptr;
4744 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004745 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00004746 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004747 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004748 // Conversion could affect comparison.
4749 return nullptr;
4750 }
4751 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004752
Chris Lattner2188e402010-01-04 07:37:31 +00004753 // Otherwise, we can potentially simplify the comparison. We know that it
4754 // will always come through as an integer value and we know the constant is
4755 // not a NAN (it would have been previously simplified).
4756 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00004757
Chris Lattner2188e402010-01-04 07:37:31 +00004758 ICmpInst::Predicate Pred;
4759 switch (I.getPredicate()) {
4760 default: llvm_unreachable("Unexpected predicate!");
4761 case FCmpInst::FCMP_UEQ:
4762 case FCmpInst::FCMP_OEQ:
4763 Pred = ICmpInst::ICMP_EQ;
4764 break;
4765 case FCmpInst::FCMP_UGT:
4766 case FCmpInst::FCMP_OGT:
4767 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
4768 break;
4769 case FCmpInst::FCMP_UGE:
4770 case FCmpInst::FCMP_OGE:
4771 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
4772 break;
4773 case FCmpInst::FCMP_ULT:
4774 case FCmpInst::FCMP_OLT:
4775 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
4776 break;
4777 case FCmpInst::FCMP_ULE:
4778 case FCmpInst::FCMP_OLE:
4779 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
4780 break;
4781 case FCmpInst::FCMP_UNE:
4782 case FCmpInst::FCMP_ONE:
4783 Pred = ICmpInst::ICMP_NE;
4784 break;
4785 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00004786 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004787 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00004788 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004789 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004790
Chris Lattner2188e402010-01-04 07:37:31 +00004791 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004792
Chris Lattner2188e402010-01-04 07:37:31 +00004793 // See if the FP constant is too large for the integer. For example,
4794 // comparing an i8 to 300.0.
4795 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004796
Chris Lattner2188e402010-01-04 07:37:31 +00004797 if (!LHSUnsigned) {
4798 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
4799 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004800 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004801 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
4802 APFloat::rmNearestTiesToEven);
4803 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
4804 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
4805 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004806 return replaceInstUsesWith(I, Builder.getTrue());
4807 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004808 }
4809 } else {
4810 // If the RHS value is > UnsignedMax, fold the comparison. This handles
4811 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004812 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004813 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
4814 APFloat::rmNearestTiesToEven);
4815 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
4816 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
4817 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004818 return replaceInstUsesWith(I, Builder.getTrue());
4819 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004820 }
4821 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004822
Chris Lattner2188e402010-01-04 07:37:31 +00004823 if (!LHSUnsigned) {
4824 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004825 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004826 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
4827 APFloat::rmNearestTiesToEven);
4828 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
4829 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
4830 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004831 return replaceInstUsesWith(I, Builder.getTrue());
4832 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004833 }
Devang Patel698452b2012-02-13 23:05:18 +00004834 } else {
4835 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004836 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00004837 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
4838 APFloat::rmNearestTiesToEven);
4839 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
4840 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
4841 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004842 return replaceInstUsesWith(I, Builder.getTrue());
4843 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00004844 }
Chris Lattner2188e402010-01-04 07:37:31 +00004845 }
4846
4847 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
4848 // [0, UMAX], but it may still be fractional. See if it is fractional by
4849 // casting the FP value to the integer value and back, checking for equality.
4850 // Don't do this for zero, because -0.0 is not fractional.
4851 Constant *RHSInt = LHSUnsigned
4852 ? ConstantExpr::getFPToUI(RHSC, IntTy)
4853 : ConstantExpr::getFPToSI(RHSC, IntTy);
4854 if (!RHS.isZero()) {
4855 bool Equal = LHSUnsigned
4856 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
4857 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
4858 if (!Equal) {
4859 // If we had a comparison against a fractional value, we have to adjust
4860 // the compare predicate and sometimes the value. RHSC is rounded towards
4861 // zero at this point.
4862 switch (Pred) {
4863 default: llvm_unreachable("Unexpected integer comparison!");
4864 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00004865 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004866 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00004867 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004868 case ICmpInst::ICMP_ULE:
4869 // (float)int <= 4.4 --> int <= 4
4870 // (float)int <= -4.4 --> false
4871 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004872 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004873 break;
4874 case ICmpInst::ICMP_SLE:
4875 // (float)int <= 4.4 --> int <= 4
4876 // (float)int <= -4.4 --> int < -4
4877 if (RHS.isNegative())
4878 Pred = ICmpInst::ICMP_SLT;
4879 break;
4880 case ICmpInst::ICMP_ULT:
4881 // (float)int < -4.4 --> false
4882 // (float)int < 4.4 --> int <= 4
4883 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004884 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004885 Pred = ICmpInst::ICMP_ULE;
4886 break;
4887 case ICmpInst::ICMP_SLT:
4888 // (float)int < -4.4 --> int < -4
4889 // (float)int < 4.4 --> int <= 4
4890 if (!RHS.isNegative())
4891 Pred = ICmpInst::ICMP_SLE;
4892 break;
4893 case ICmpInst::ICMP_UGT:
4894 // (float)int > 4.4 --> int > 4
4895 // (float)int > -4.4 --> true
4896 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004897 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004898 break;
4899 case ICmpInst::ICMP_SGT:
4900 // (float)int > 4.4 --> int > 4
4901 // (float)int > -4.4 --> int >= -4
4902 if (RHS.isNegative())
4903 Pred = ICmpInst::ICMP_SGE;
4904 break;
4905 case ICmpInst::ICMP_UGE:
4906 // (float)int >= -4.4 --> true
4907 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00004908 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004909 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004910 Pred = ICmpInst::ICMP_UGT;
4911 break;
4912 case ICmpInst::ICMP_SGE:
4913 // (float)int >= -4.4 --> int >= -4
4914 // (float)int >= 4.4 --> int > 4
4915 if (!RHS.isNegative())
4916 Pred = ICmpInst::ICMP_SGT;
4917 break;
4918 }
4919 }
4920 }
4921
4922 // Lower this FP comparison into an appropriate integer version of the
4923 // comparison.
4924 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
4925}
4926
4927Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
4928 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004929
Chris Lattner2188e402010-01-04 07:37:31 +00004930 /// Orders the operands of the compare so that they are listed from most
4931 /// complex to least complex. This puts constants before unary operators,
4932 /// before binary operators.
4933 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
4934 I.swapOperands();
4935 Changed = true;
4936 }
4937
4938 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004939
Daniel Berlin2c75c632017-04-26 20:56:07 +00004940 if (Value *V =
4941 SimplifyFCmpInst(I.getPredicate(), Op0, Op1, I.getFastMathFlags(),
4942 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004943 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00004944
4945 // Simplify 'fcmp pred X, X'
4946 if (Op0 == Op1) {
4947 switch (I.getPredicate()) {
4948 default: llvm_unreachable("Unknown predicate!");
4949 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
4950 case FCmpInst::FCMP_ULT: // True if unordered or less than
4951 case FCmpInst::FCMP_UGT: // True if unordered or greater than
4952 case FCmpInst::FCMP_UNE: // True if unordered or not equal
4953 // Canonicalize these to be 'fcmp uno %X, 0.0'.
4954 I.setPredicate(FCmpInst::FCMP_UNO);
4955 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4956 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004957
Chris Lattner2188e402010-01-04 07:37:31 +00004958 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
4959 case FCmpInst::FCMP_OEQ: // True if ordered and equal
4960 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
4961 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
4962 // Canonicalize these to be 'fcmp ord %X, 0.0'.
4963 I.setPredicate(FCmpInst::FCMP_ORD);
4964 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4965 return &I;
4966 }
4967 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004968
James Molloy2b21a7c2015-05-20 18:41:25 +00004969 // Test if the FCmpInst instruction is used exclusively by a select as
4970 // part of a minimum or maximum operation. If so, refrain from doing
4971 // any other folding. This helps out other analyses which understand
4972 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4973 // and CodeGen. And in this case, at least one of the comparison
4974 // operands has at least one user besides the compare (the select),
4975 // which would often largely negate the benefit of folding anyway.
4976 if (I.hasOneUse())
4977 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
4978 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4979 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
4980 return nullptr;
4981
Chris Lattner2188e402010-01-04 07:37:31 +00004982 // Handle fcmp with constant RHS
4983 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
4984 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
4985 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004986 case Instruction::FPExt: {
4987 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
4988 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
4989 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
4990 if (!RHSF)
4991 break;
4992
4993 const fltSemantics *Sem;
4994 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00004995 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004996 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00004997 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004998 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004999 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005000 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005001 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005002 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005003 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005004 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00005005 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005006 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005007 else
5008 break;
5009
5010 bool Lossy;
5011 APFloat F = RHSF->getValueAPF();
5012 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
5013
Jim Grosbach24ff8342011-09-30 18:45:50 +00005014 // Avoid lossy conversions and denormals. Zero is a special case
5015 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00005016 APFloat Fabs = F;
5017 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005018 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00005019 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
5020 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00005021
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005022 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0),
5023 ConstantFP::get(RHSC->getContext(), F));
5024 break;
5025 }
Chris Lattner2188e402010-01-04 07:37:31 +00005026 case Instruction::PHI:
5027 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5028 // block. If in the same block, we're encouraging jump threading. If
5029 // not, we are just pessimizing the code by making an i1 phi.
5030 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00005031 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005032 return NV;
5033 break;
5034 case Instruction::SIToFP:
5035 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00005036 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00005037 return NV;
5038 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00005039 case Instruction::FSub: {
5040 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
5041 Value *Op;
5042 if (match(LHSI, m_FNeg(m_Value(Op))))
5043 return new FCmpInst(I.getSwappedPredicate(), Op,
5044 ConstantExpr::getFNeg(RHSC));
5045 break;
5046 }
Dan Gohman94732022010-02-24 06:46:09 +00005047 case Instruction::Load:
5048 if (GetElementPtrInst *GEP =
5049 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
5050 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5051 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5052 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00005053 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00005054 return Res;
5055 }
5056 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005057 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005058 if (!RHSC->isNullValue())
5059 break;
5060
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005061 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00005062 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00005063 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005064 break;
5065
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005066 // Various optimization for fabs compared with zero.
David Majnemer2e02ba72016-04-15 17:21:03 +00005067 switch (I.getPredicate()) {
5068 default:
5069 break;
5070 // fabs(x) < 0 --> false
5071 case FCmpInst::FCMP_OLT:
5072 llvm_unreachable("handled by SimplifyFCmpInst");
5073 // fabs(x) > 0 --> x != 0
5074 case FCmpInst::FCMP_OGT:
5075 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
5076 // fabs(x) <= 0 --> x == 0
5077 case FCmpInst::FCMP_OLE:
5078 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
5079 // fabs(x) >= 0 --> !isnan(x)
5080 case FCmpInst::FCMP_OGE:
5081 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
5082 // fabs(x) == 0 --> x == 0
5083 // fabs(x) != 0 --> x != 0
5084 case FCmpInst::FCMP_OEQ:
5085 case FCmpInst::FCMP_UEQ:
5086 case FCmpInst::FCMP_ONE:
5087 case FCmpInst::FCMP_UNE:
5088 return new FCmpInst(I.getPredicate(), CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005089 }
5090 }
Chris Lattner2188e402010-01-04 07:37:31 +00005091 }
Chris Lattner2188e402010-01-04 07:37:31 +00005092 }
5093
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005094 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00005095 Value *X, *Y;
5096 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005097 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00005098
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005099 // fcmp (fpext x), (fpext y) -> fcmp x, y
5100 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
5101 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
5102 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
5103 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0),
5104 RHSExt->getOperand(0));
5105
Craig Topperf40110f2014-04-25 05:29:35 +00005106 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005107}