blob: d89fa9d6ef124f32aeb45635b2b0e28fa956bbe5 [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// VertexArrayVk.cpp:
7// Implements the class methods for VertexArrayVk.
8//
9
10#include "libANGLE/renderer/vulkan/VertexArrayVk.h"
11
12#include "common/debug.h"
13
Jamie Madillc564c072017-06-01 12:45:42 -040014#include "libANGLE/Context.h"
Jamie Madillbd159f02017-10-09 19:39:06 -040015#include "libANGLE/renderer/vulkan/BufferVk.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050016#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madilldd43e6c2017-03-24 14:18:49 -040017#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madillc3755fc2018-04-05 08:39:13 -040018#include "libANGLE/renderer/vulkan/RendererVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050019#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Jamie Madilldd43e6c2017-03-24 14:18:49 -040020
Jamie Madill9e54b5a2016-05-25 12:57:39 -040021namespace rx
22{
Jamie Madillc3755fc2018-04-05 08:39:13 -040023namespace
24{
25constexpr size_t kDynamicVertexDataSize = 1024 * 1024;
26constexpr size_t kDynamicIndexDataSize = 1024 * 8;
27} // anonymous namespace
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
Jamie Madillbd159f02017-10-09 19:39:06 -040029VertexArrayVk::VertexArrayVk(const gl::VertexArrayState &state)
30 : VertexArrayImpl(state),
Jamie Madillda854a22017-11-30 17:24:21 -050031 mCurrentArrayBufferHandles{},
Frank Henigman17448952017-01-05 15:48:26 -050032 mCurrentArrayBufferOffsets{},
Jamie Madillda854a22017-11-30 17:24:21 -050033 mCurrentArrayBufferResources{},
Jamie Madillc3755fc2018-04-05 08:39:13 -040034 mCurrentElementArrayBufferHandle(VK_NULL_HANDLE),
35 mCurrentElementArrayBufferOffset(0),
36 mCurrentElementArrayBufferResource(nullptr),
37 mDynamicVertexData(VK_BUFFER_USAGE_VERTEX_BUFFER_BIT, kDynamicVertexDataSize),
38 mDynamicIndexData(VK_BUFFER_USAGE_INDEX_BUFFER_BIT, kDynamicIndexDataSize),
Jamie Madillb8e39662018-04-04 11:41:42 -040039 mDirtyLineLoopTranslation(true),
Jamie Madillc3755fc2018-04-05 08:39:13 -040040 mVertexBuffersDirty(false),
41 mIndexBufferDirty(false)
Jamie Madill9e54b5a2016-05-25 12:57:39 -040042{
Jamie Madillda854a22017-11-30 17:24:21 -050043 mCurrentArrayBufferHandles.fill(VK_NULL_HANDLE);
Frank Henigman17448952017-01-05 15:48:26 -050044 mCurrentArrayBufferOffsets.fill(0);
Jamie Madillda854a22017-11-30 17:24:21 -050045 mCurrentArrayBufferResources.fill(nullptr);
Jamie Madill112a3a82018-01-23 13:04:06 -050046
47 mPackedInputBindings.fill({0, 0});
48 mPackedInputAttributes.fill({0, 0, 0});
Jamie Madillc3755fc2018-04-05 08:39:13 -040049
50 mDynamicVertexData.init(1);
51 mDynamicIndexData.init(1);
Jamie Madill9e54b5a2016-05-25 12:57:39 -040052}
53
Jamie Madillacf2f3a2017-11-21 19:22:44 -050054VertexArrayVk::~VertexArrayVk()
55{
56}
57
Jamie Madill4928b7c2017-06-20 12:57:39 -040058void VertexArrayVk::destroy(const gl::Context *context)
Jamie Madill9e54b5a2016-05-25 12:57:39 -040059{
Jamie Madillc3755fc2018-04-05 08:39:13 -040060 VkDevice device = vk::GetImpl(context)->getRenderer()->getDevice();
61
62 mDynamicVertexData.destroy(device);
63 mDynamicIndexData.destroy(device);
64 mLineLoopHandler.destroy(device);
Jamie Madill9e54b5a2016-05-25 12:57:39 -040065}
66
Jamie Madillc3755fc2018-04-05 08:39:13 -040067gl::Error VertexArrayVk::streamVertexData(RendererVk *renderer,
68 const gl::AttributesMask &attribsToStream,
Jamie Madill32fd63b2018-03-31 11:20:35 -040069 const gl::DrawCallParams &drawCallParams)
Frank Henigman17448952017-01-05 15:48:26 -050070{
Jamie Madillc3755fc2018-04-05 08:39:13 -040071 ASSERT(!attribsToStream.none());
72
Frank Henigman17448952017-01-05 15:48:26 -050073 const auto &attribs = mState.getVertexAttributes();
74 const auto &bindings = mState.getVertexBindings();
Frank Henigman17448952017-01-05 15:48:26 -050075
Jamie Madill32fd63b2018-03-31 11:20:35 -040076 const size_t lastVertex = drawCallParams.firstVertex() + drawCallParams.vertexCount();
77
Frank Henigman17448952017-01-05 15:48:26 -050078 // TODO(fjhenigman): When we have a bunch of interleaved attributes, they end up
79 // un-interleaved, wasting space and copying time. Consider improving on that.
Jamie Madillb8e39662018-04-04 11:41:42 -040080 for (size_t attribIndex : attribsToStream)
Frank Henigman17448952017-01-05 15:48:26 -050081 {
Frank Henigman6dd4a922018-03-02 16:35:13 -050082 const gl::VertexAttribute &attrib = attribs[attribIndex];
83 const gl::VertexBinding &binding = bindings[attrib.bindingIndex];
84 ASSERT(attrib.enabled && binding.getBuffer().get() == nullptr);
Frank Henigman17448952017-01-05 15:48:26 -050085
Frank Henigman6dd4a922018-03-02 16:35:13 -050086 // TODO(fjhenigman): Work with more formats than just GL_FLOAT.
87 if (attrib.type != GL_FLOAT)
Frank Henigman17448952017-01-05 15:48:26 -050088 {
Frank Henigman6dd4a922018-03-02 16:35:13 -050089 UNIMPLEMENTED();
90 return gl::InternalError();
Frank Henigman17448952017-01-05 15:48:26 -050091 }
Frank Henigman6dd4a922018-03-02 16:35:13 -050092
93 // Only [firstVertex, lastVertex] is needed by the upcoming draw so that
94 // is all we copy, but we allocate space for [0, lastVertex] so indexing
95 // will work. If we don't start at zero all the indices will be off.
96 // TODO(fjhenigman): See if we can account for indices being off by adjusting
97 // the offset, thus avoiding wasted memory.
Jamie Madill32fd63b2018-03-31 11:20:35 -040098 const size_t firstByte = drawCallParams.firstVertex() * binding.getStride();
Frank Henigman6dd4a922018-03-02 16:35:13 -050099 const size_t lastByte =
100 lastVertex * binding.getStride() + gl::ComputeVertexAttributeTypeSize(attrib);
101 uint8_t *dst = nullptr;
Luc Ferron7a06ac12018-03-15 10:17:04 -0400102 uint32_t offset = 0;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400103 ANGLE_TRY(mDynamicVertexData.allocate(
104 renderer, lastByte, &dst, &mCurrentArrayBufferHandles[attribIndex], &offset, nullptr));
Luc Ferron7a06ac12018-03-15 10:17:04 -0400105 mCurrentArrayBufferOffsets[attribIndex] = static_cast<VkDeviceSize>(offset);
Frank Henigman6dd4a922018-03-02 16:35:13 -0500106 memcpy(dst + firstByte, static_cast<const uint8_t *>(attrib.pointer) + firstByte,
107 lastByte - firstByte);
Frank Henigman17448952017-01-05 15:48:26 -0500108 }
109
Jamie Madillc3755fc2018-04-05 08:39:13 -0400110 ANGLE_TRY(mDynamicVertexData.flush(renderer->getDevice()));
111 return gl::NoError();
112}
113
114gl::Error VertexArrayVk::streamIndexData(RendererVk *renderer,
115 const gl::DrawCallParams &drawCallParams)
116{
117 ASSERT(!mState.getElementArrayBuffer().get());
118
119 uint32_t offset = 0;
120
121 const GLsizei amount = sizeof(GLushort) * drawCallParams.indexCount();
122 GLubyte *dst = nullptr;
123
124 ANGLE_TRY(mDynamicIndexData.allocate(renderer, amount, &dst, &mCurrentElementArrayBufferHandle,
125 &offset, nullptr));
126 if (drawCallParams.type() == GL_UNSIGNED_BYTE)
127 {
128 // Unsigned bytes don't have direct support in Vulkan so we have to expand the
129 // memory to a GLushort.
130 const GLubyte *in = static_cast<const GLubyte *>(drawCallParams.indices());
131 GLushort *expandedDst = reinterpret_cast<GLushort *>(dst);
132 for (GLsizei index = 0; index < drawCallParams.indexCount(); index++)
133 {
134 expandedDst[index] = static_cast<GLushort>(in[index]);
135 }
136 }
137 else
138 {
139 memcpy(dst, drawCallParams.indices(), amount);
140 }
141 ANGLE_TRY(mDynamicIndexData.flush(renderer->getDevice()));
142
143 mCurrentElementArrayBufferOffset = offset;
144
Frank Henigman17448952017-01-05 15:48:26 -0500145 return gl::NoError();
146}
147
Frank Henigman0af5b862018-03-27 20:19:33 -0400148gl::Error VertexArrayVk::syncState(const gl::Context *context,
149 const gl::VertexArray::DirtyBits &dirtyBits,
150 const gl::VertexArray::DirtyAttribBitsArray &attribBits,
151 const gl::VertexArray::DirtyBindingBitsArray &bindingBits)
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400152{
153 ASSERT(dirtyBits.any());
Jamie Madill72106562017-03-24 14:18:50 -0400154
Jamie Madillc3755fc2018-04-05 08:39:13 -0400155 bool invalidatePipeline = false;
156
Jamie Madillbd159f02017-10-09 19:39:06 -0400157 // Invalidate current pipeline.
Jamie Madillacf2f3a2017-11-21 19:22:44 -0500158 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madillbd159f02017-10-09 19:39:06 -0400159
160 // Rebuild current attribute buffers cache. This will fail horribly if the buffer changes.
161 // TODO(jmadill): Handle buffer storage changes.
162 const auto &attribs = mState.getVertexAttributes();
163 const auto &bindings = mState.getVertexBindings();
164
Jamie Madill09463932018-04-04 05:26:59 -0400165 for (size_t dirtyBit : dirtyBits)
Jamie Madillbd159f02017-10-09 19:39:06 -0400166 {
Jamie Madill09463932018-04-04 05:26:59 -0400167 switch (dirtyBit)
Jamie Madillda854a22017-11-30 17:24:21 -0500168 {
Jamie Madill09463932018-04-04 05:26:59 -0400169 case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER:
Jamie Madillda854a22017-11-30 17:24:21 -0500170 {
Jamie Madill09463932018-04-04 05:26:59 -0400171 gl::Buffer *bufferGL = mState.getElementArrayBuffer().get();
172 if (bufferGL)
173 {
Jamie Madillc3755fc2018-04-05 08:39:13 -0400174 BufferVk *bufferVk = vk::GetImpl(bufferGL);
175 mCurrentElementArrayBufferResource = bufferVk;
176 mCurrentElementArrayBufferHandle = bufferVk->getVkBuffer().getHandle();
177 mCurrentElementArrayBufferOffset = 0;
Jamie Madill09463932018-04-04 05:26:59 -0400178 }
179 else
180 {
181 mCurrentElementArrayBufferResource = nullptr;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400182 mCurrentElementArrayBufferHandle = VK_NULL_HANDLE;
183 mCurrentElementArrayBufferOffset = 0;
Jamie Madill09463932018-04-04 05:26:59 -0400184 }
Jamie Madillb8e39662018-04-04 11:41:42 -0400185 mIndexBufferDirty = true;
186 mDirtyLineLoopTranslation = true;
Jamie Madill09463932018-04-04 05:26:59 -0400187 break;
Jamie Madillda854a22017-11-30 17:24:21 -0500188 }
Jamie Madill09463932018-04-04 05:26:59 -0400189
190 case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA:
Jamie Madillc3755fc2018-04-05 08:39:13 -0400191 mLineLoopBufferFirstIndex.reset();
192 mLineLoopBufferLastIndex.reset();
Jamie Madillb8e39662018-04-04 11:41:42 -0400193 mDirtyLineLoopTranslation = true;
Jamie Madill09463932018-04-04 05:26:59 -0400194 break;
195
196 default:
Jamie Madillda854a22017-11-30 17:24:21 -0500197 {
Jamie Madill09463932018-04-04 05:26:59 -0400198 size_t attribIndex = gl::VertexArray::GetVertexIndexFromDirtyBit(dirtyBit);
199
200 // Invalidate the input description for pipelines.
201 mDirtyPackedInputs.set(attribIndex);
202
203 const auto &attrib = attribs[attribIndex];
204 const auto &binding = bindings[attrib.bindingIndex];
205
206 if (attrib.enabled)
207 {
208 gl::Buffer *bufferGL = binding.getBuffer().get();
209
210 if (bufferGL)
211 {
212 BufferVk *bufferVk = vk::GetImpl(bufferGL);
213 mCurrentArrayBufferResources[attribIndex] = bufferVk;
214 mCurrentArrayBufferHandles[attribIndex] =
215 bufferVk->getVkBuffer().getHandle();
216 mClientMemoryAttribs.reset(attribIndex);
217 }
218 else
219 {
220 mCurrentArrayBufferResources[attribIndex] = nullptr;
221 mCurrentArrayBufferHandles[attribIndex] = VK_NULL_HANDLE;
222 mClientMemoryAttribs.set(attribIndex);
223 }
224 // TODO(jmadill): Offset handling. Assume zero for now.
225 mCurrentArrayBufferOffsets[attribIndex] = 0;
226 }
227 else
228 {
229 mClientMemoryAttribs.reset(attribIndex);
230 UNIMPLEMENTED();
231 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400232
233 invalidatePipeline = true;
Jamie Madill09463932018-04-04 05:26:59 -0400234 break;
Jamie Madillda854a22017-11-30 17:24:21 -0500235 }
Jamie Madillbd159f02017-10-09 19:39:06 -0400236 }
237 }
Frank Henigman0af5b862018-03-27 20:19:33 -0400238
Jamie Madillc3755fc2018-04-05 08:39:13 -0400239 if (invalidatePipeline)
240 {
241 mVertexBuffersDirty = true;
242 contextVk->invalidateCurrentPipeline();
243 }
244
Frank Henigman0af5b862018-03-27 20:19:33 -0400245 return gl::NoError();
Jamie Madillbd159f02017-10-09 19:39:06 -0400246}
247
Jamie Madillda854a22017-11-30 17:24:21 -0500248const gl::AttribArray<VkBuffer> &VertexArrayVk::getCurrentArrayBufferHandles() const
Jamie Madillbd159f02017-10-09 19:39:06 -0400249{
Jamie Madillda854a22017-11-30 17:24:21 -0500250 return mCurrentArrayBufferHandles;
Jamie Madillbd159f02017-10-09 19:39:06 -0400251}
252
Frank Henigman17448952017-01-05 15:48:26 -0500253const gl::AttribArray<VkDeviceSize> &VertexArrayVk::getCurrentArrayBufferOffsets() const
254{
255 return mCurrentArrayBufferOffsets;
256}
257
Jamie Madill9cceac42018-03-31 14:19:16 -0400258void VertexArrayVk::updateArrayBufferReadDependencies(vk::CommandGraphNode *readingNode,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400259 const gl::AttributesMask &activeAttribsMask,
260 Serial serial)
Jamie Madillbd159f02017-10-09 19:39:06 -0400261{
Jamie Madillda854a22017-11-30 17:24:21 -0500262 // Handle the bound array buffers.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400263 for (size_t attribIndex : activeAttribsMask)
Jamie Madillbd159f02017-10-09 19:39:06 -0400264 {
Frank Henigman17448952017-01-05 15:48:26 -0500265 if (mCurrentArrayBufferResources[attribIndex])
Jamie Madill9cceac42018-03-31 14:19:16 -0400266 mCurrentArrayBufferResources[attribIndex]->onReadResource(readingNode, serial);
Jamie Madillda854a22017-11-30 17:24:21 -0500267 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400268}
Jamie Madillda854a22017-11-30 17:24:21 -0500269
Jamie Madill9cceac42018-03-31 14:19:16 -0400270void VertexArrayVk::updateElementArrayBufferReadDependency(vk::CommandGraphNode *readingNode,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400271 Serial serial)
272{
Jamie Madillda854a22017-11-30 17:24:21 -0500273 // Handle the bound element array buffer.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400274 if (mCurrentElementArrayBufferResource)
Jamie Madillda854a22017-11-30 17:24:21 -0500275 {
Jamie Madill9cceac42018-03-31 14:19:16 -0400276 mCurrentElementArrayBufferResource->onReadResource(readingNode, serial);
Jamie Madillbd159f02017-10-09 19:39:06 -0400277 }
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400278}
279
Jamie Madill112a3a82018-01-23 13:04:06 -0500280void VertexArrayVk::getPackedInputDescriptions(vk::PipelineDesc *pipelineDesc)
Jamie Madillebf72992017-10-13 14:09:45 -0400281{
Jamie Madill112a3a82018-01-23 13:04:06 -0500282 updatePackedInputDescriptions();
283 pipelineDesc->updateVertexInputInfo(mPackedInputBindings, mPackedInputAttributes);
Jamie Madillebf72992017-10-13 14:09:45 -0400284}
285
Jamie Madill112a3a82018-01-23 13:04:06 -0500286void VertexArrayVk::updatePackedInputDescriptions()
Jamie Madillebf72992017-10-13 14:09:45 -0400287{
Jamie Madill112a3a82018-01-23 13:04:06 -0500288 if (!mDirtyPackedInputs.any())
Jamie Madillebf72992017-10-13 14:09:45 -0400289 {
290 return;
291 }
292
293 const auto &attribs = mState.getVertexAttributes();
294 const auto &bindings = mState.getVertexBindings();
295
Jamie Madill112a3a82018-01-23 13:04:06 -0500296 for (auto attribIndex : mDirtyPackedInputs)
Jamie Madillebf72992017-10-13 14:09:45 -0400297 {
298 const auto &attrib = attribs[attribIndex];
299 const auto &binding = bindings[attrib.bindingIndex];
300 if (attrib.enabled)
301 {
Jamie Madill112a3a82018-01-23 13:04:06 -0500302 updatePackedInputInfo(static_cast<uint32_t>(attribIndex), binding, attrib);
Jamie Madillebf72992017-10-13 14:09:45 -0400303 }
304 else
305 {
306 UNIMPLEMENTED();
307 }
308 }
309
Jamie Madill112a3a82018-01-23 13:04:06 -0500310 mDirtyPackedInputs.reset();
311}
312
313void VertexArrayVk::updatePackedInputInfo(uint32_t attribIndex,
314 const gl::VertexBinding &binding,
315 const gl::VertexAttribute &attrib)
316{
317 vk::PackedVertexInputBindingDesc &bindingDesc = mPackedInputBindings[attribIndex];
318
319 size_t attribSize = gl::ComputeVertexAttributeTypeSize(attrib);
320 ASSERT(attribSize <= std::numeric_limits<uint16_t>::max());
321
Frank Henigmana8e868f2018-01-28 23:32:25 -0500322 bindingDesc.stride = static_cast<uint16_t>(binding.getStride());
Jamie Madill112a3a82018-01-23 13:04:06 -0500323 bindingDesc.inputRate = static_cast<uint16_t>(
324 binding.getDivisor() > 0 ? VK_VERTEX_INPUT_RATE_INSTANCE : VK_VERTEX_INPUT_RATE_VERTEX);
325
326 gl::VertexFormatType vertexFormatType = gl::GetVertexFormatType(attrib);
327 VkFormat vkFormat = vk::GetNativeVertexFormat(vertexFormatType);
328 ASSERT(vkFormat <= std::numeric_limits<uint16_t>::max());
329
330 vk::PackedVertexInputAttributeDesc &attribDesc = mPackedInputAttributes[attribIndex];
331 attribDesc.format = static_cast<uint16_t>(vkFormat);
332 attribDesc.location = static_cast<uint16_t>(attribIndex);
333 attribDesc.offset = static_cast<uint32_t>(ComputeVertexAttributeOffset(attrib, binding));
Jamie Madillebf72992017-10-13 14:09:45 -0400334}
335
Jamie Madillc3755fc2018-04-05 08:39:13 -0400336gl::Error VertexArrayVk::drawArrays(const gl::Context *context,
337 RendererVk *renderer,
338 const gl::DrawCallParams &drawCallParams,
339 vk::CommandGraphNode *drawNode,
340 bool newCommandBuffer)
341{
342 vk::CommandBuffer *commandBuffer = drawNode->getInsideRenderPassCommands();
343 ASSERT(commandBuffer->valid());
344
345 ANGLE_TRY(onDraw(context, renderer, drawCallParams, drawNode, newCommandBuffer));
346
347 if (drawCallParams.mode() != GL_LINE_LOOP)
348 {
349 commandBuffer->draw(drawCallParams.vertexCount(), 1, drawCallParams.firstVertex(), 0);
350 return gl::NoError();
351 }
352
353 // Handle GL_LINE_LOOP drawArrays.
Jamie Madillb8e39662018-04-04 11:41:42 -0400354 // This test may be incorrect if the draw call switches from DrawArrays/DrawElements.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400355 int lastVertex = drawCallParams.firstVertex() + drawCallParams.vertexCount();
356 if (!mLineLoopBufferFirstIndex.valid() || !mLineLoopBufferLastIndex.valid() ||
357 mLineLoopBufferFirstIndex != drawCallParams.firstVertex() ||
358 mLineLoopBufferLastIndex != lastVertex)
359 {
360 ANGLE_TRY(mLineLoopHandler.createIndexBuffer(renderer, drawCallParams,
361 &mCurrentElementArrayBufferHandle,
362 &mCurrentElementArrayBufferOffset));
363
364 mLineLoopBufferFirstIndex = drawCallParams.firstVertex();
365 mLineLoopBufferLastIndex = lastVertex;
366 }
367
368 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
369 mCurrentElementArrayBufferOffset, VK_INDEX_TYPE_UINT32);
370
371 vk::LineLoopHandler::Draw(drawCallParams.vertexCount(), commandBuffer);
372
373 return gl::NoError();
374}
375
376gl::Error VertexArrayVk::drawElements(const gl::Context *context,
377 RendererVk *renderer,
378 const gl::DrawCallParams &drawCallParams,
379 vk::CommandGraphNode *drawNode,
380 bool newCommandBuffer)
381{
382 vk::CommandBuffer *commandBuffer = drawNode->getInsideRenderPassCommands();
383 ASSERT(commandBuffer->valid());
384
385 if (drawCallParams.mode() != GL_LINE_LOOP)
386 {
387 ANGLE_TRY(onIndexedDraw(context, renderer, drawCallParams, drawNode, newCommandBuffer));
388 commandBuffer->drawIndexed(drawCallParams.indexCount(), 1, 0, 0, 0);
389 return gl::NoError();
390 }
391
392 // Handle GL_LINE_LOOP drawElements.
393 gl::Buffer *elementArrayBuffer = mState.getElementArrayBuffer().get();
394 if (!elementArrayBuffer)
395 {
396 UNIMPLEMENTED();
397 return gl::InternalError() << "Line loop indices in client memory not supported";
398 }
399
400 BufferVk *elementArrayBufferVk = vk::GetImpl(elementArrayBuffer);
401
402 VkIndexType indexType = gl_vk::GetIndexType(drawCallParams.type());
403
Jamie Madillb8e39662018-04-04 11:41:42 -0400404 // This also doesn't check if the element type changed, which should trigger translation.
405 if (mDirtyLineLoopTranslation)
406 {
407 ANGLE_TRY(mLineLoopHandler.createIndexBufferFromElementArrayBuffer(
408 renderer, elementArrayBufferVk, indexType, drawCallParams.indexCount(),
409 &mCurrentElementArrayBufferHandle, &mCurrentElementArrayBufferOffset));
410 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400411
412 ANGLE_TRY(onIndexedDraw(context, renderer, drawCallParams, drawNode, newCommandBuffer));
413 vk::LineLoopHandler::Draw(drawCallParams.indexCount(), commandBuffer);
414
415 return gl::NoError();
416}
417
418gl::Error VertexArrayVk::onDraw(const gl::Context *context,
419 RendererVk *renderer,
420 const gl::DrawCallParams &drawCallParams,
421 vk::CommandGraphNode *drawNode,
422 bool newCommandBuffer)
423{
424 const gl::State &state = context->getGLState();
425 const gl::Program *programGL = state.getProgram();
426 const gl::AttributesMask &activeAttribs = programGL->getActiveAttribLocationsMask();
427 uint32_t maxAttrib = programGL->getState().getMaxActiveAttribLocation();
428
429 if (mClientMemoryAttribs.any())
430 {
431 const gl::AttributesMask &attribsToStream = (mClientMemoryAttribs & activeAttribs);
432 if (attribsToStream.any())
433 {
434 ANGLE_TRY(drawCallParams.ensureIndexRangeResolved(context));
435 ANGLE_TRY(streamVertexData(renderer, attribsToStream, drawCallParams));
436 vk::CommandBuffer *commandBuffer = drawNode->getInsideRenderPassCommands();
437 commandBuffer->bindVertexBuffers(0, maxAttrib, mCurrentArrayBufferHandles.data(),
438 mCurrentArrayBufferOffsets.data());
439 }
440 }
441 else if (mVertexBuffersDirty || newCommandBuffer)
442 {
443 vk::CommandBuffer *commandBuffer = drawNode->getInsideRenderPassCommands();
444 commandBuffer->bindVertexBuffers(0, maxAttrib, mCurrentArrayBufferHandles.data(),
445 mCurrentArrayBufferOffsets.data());
446 updateArrayBufferReadDependencies(drawNode, activeAttribs,
447 renderer->getCurrentQueueSerial());
448 mVertexBuffersDirty = false;
449 }
450
451 return gl::NoError();
452}
453
454gl::Error VertexArrayVk::onIndexedDraw(const gl::Context *context,
455 RendererVk *renderer,
456 const gl::DrawCallParams &drawCallParams,
457 vk::CommandGraphNode *drawNode,
458 bool newCommandBuffer)
459{
460 ANGLE_TRY(onDraw(context, renderer, drawCallParams, drawNode, newCommandBuffer));
461
462 if (!mState.getElementArrayBuffer().get())
463 {
464 ANGLE_TRY(drawCallParams.ensureIndexRangeResolved(context));
465 ANGLE_TRY(streamIndexData(renderer, drawCallParams));
466 vk::CommandBuffer *commandBuffer = drawNode->getInsideRenderPassCommands();
467 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
468 mCurrentElementArrayBufferOffset,
469 gl_vk::GetIndexType(drawCallParams.type()));
470 }
471 else if (mIndexBufferDirty || newCommandBuffer)
472 {
473 if (drawCallParams.type() == GL_UNSIGNED_BYTE)
474 {
475 // TODO(fjhenigman): Index format translation.
476 UNIMPLEMENTED();
477 return gl::InternalError()
478 << "Unsigned byte translation is not implemented for indices in a buffer object";
479 }
480
481 vk::CommandBuffer *commandBuffer = drawNode->getInsideRenderPassCommands();
482 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
483 mCurrentElementArrayBufferOffset,
484 gl_vk::GetIndexType(drawCallParams.type()));
485 updateElementArrayBufferReadDependency(drawNode, renderer->getCurrentQueueSerial());
486 mIndexBufferDirty = false;
487 }
488
489 return gl::NoError();
490}
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400491} // namespace rx