Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES.h: Validation functions for generic OpenGL ES entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES.h" |
| 10 | #include "libANGLE/validationES2.h" |
| 11 | #include "libANGLE/validationES3.h" |
| 12 | #include "libANGLE/Context.h" |
| 13 | #include "libANGLE/Texture.h" |
| 14 | #include "libANGLE/Framebuffer.h" |
| 15 | #include "libANGLE/FramebufferAttachment.h" |
| 16 | #include "libANGLE/formatutils.h" |
| 17 | #include "libANGLE/Query.h" |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 18 | #include "libANGLE/Program.h" |
| 19 | #include "libANGLE/Uniform.h" |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 20 | #include "libANGLE/TransformFeedback.h" |
| 21 | #include "libANGLE/VertexArray.h" |
| 22 | #include "libANGLE/renderer/BufferImpl.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 23 | |
| 24 | #include "common/mathutil.h" |
| 25 | #include "common/utilities.h" |
| 26 | |
Jamie Madill | 9ae396b | 2014-10-21 17:46:30 -0400 | [diff] [blame] | 27 | // FIXME(jmadill): remove this when we support buffer data caching |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 28 | #include "libANGLE/renderer/d3d/BufferD3D.h" |
Jamie Madill | 9ae396b | 2014-10-21 17:46:30 -0400 | [diff] [blame] | 29 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 30 | namespace gl |
| 31 | { |
| 32 | |
Geoff Lang | 0550d03 | 2014-01-30 11:29:07 -0500 | [diff] [blame] | 33 | bool ValidCap(const Context *context, GLenum cap) |
| 34 | { |
| 35 | switch (cap) |
| 36 | { |
| 37 | case GL_CULL_FACE: |
| 38 | case GL_POLYGON_OFFSET_FILL: |
| 39 | case GL_SAMPLE_ALPHA_TO_COVERAGE: |
| 40 | case GL_SAMPLE_COVERAGE: |
| 41 | case GL_SCISSOR_TEST: |
| 42 | case GL_STENCIL_TEST: |
| 43 | case GL_DEPTH_TEST: |
| 44 | case GL_BLEND: |
| 45 | case GL_DITHER: |
| 46 | return true; |
| 47 | case GL_PRIMITIVE_RESTART_FIXED_INDEX: |
| 48 | case GL_RASTERIZER_DISCARD: |
| 49 | return (context->getClientVersion() >= 3); |
| 50 | default: |
| 51 | return false; |
| 52 | } |
| 53 | } |
| 54 | |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 55 | bool ValidTextureTarget(const Context *context, GLenum target) |
Jamie Madill | 35d1501 | 2013-10-07 10:46:37 -0400 | [diff] [blame] | 56 | { |
Jamie Madill | d7460c7 | 2014-01-21 16:38:14 -0500 | [diff] [blame] | 57 | switch (target) |
Jamie Madill | 35d1501 | 2013-10-07 10:46:37 -0400 | [diff] [blame] | 58 | { |
Jamie Madill | d7460c7 | 2014-01-21 16:38:14 -0500 | [diff] [blame] | 59 | case GL_TEXTURE_2D: |
| 60 | case GL_TEXTURE_CUBE_MAP: |
| 61 | return true; |
Jamie Madill | 35d1501 | 2013-10-07 10:46:37 -0400 | [diff] [blame] | 62 | |
Jamie Madill | d7460c7 | 2014-01-21 16:38:14 -0500 | [diff] [blame] | 63 | case GL_TEXTURE_3D: |
| 64 | case GL_TEXTURE_2D_ARRAY: |
| 65 | return (context->getClientVersion() >= 3); |
| 66 | |
| 67 | default: |
| 68 | return false; |
| 69 | } |
Jamie Madill | 35d1501 | 2013-10-07 10:46:37 -0400 | [diff] [blame] | 70 | } |
| 71 | |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 72 | // This function differs from ValidTextureTarget in that the target must be |
| 73 | // usable as the destination of a 2D operation-- so a cube face is valid, but |
| 74 | // GL_TEXTURE_CUBE_MAP is not. |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 75 | // Note: duplicate of IsInternalTextureTarget |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 76 | bool ValidTexture2DDestinationTarget(const Context *context, GLenum target) |
| 77 | { |
| 78 | switch (target) |
| 79 | { |
| 80 | case GL_TEXTURE_2D: |
| 81 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 82 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 83 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 84 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 85 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 86 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| 87 | return true; |
| 88 | case GL_TEXTURE_2D_ARRAY: |
| 89 | case GL_TEXTURE_3D: |
| 90 | return (context->getClientVersion() >= 3); |
| 91 | default: |
| 92 | return false; |
| 93 | } |
| 94 | } |
| 95 | |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 96 | bool ValidFramebufferTarget(GLenum target) |
| 97 | { |
| 98 | META_ASSERT(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER && GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER); |
| 99 | |
| 100 | switch (target) |
| 101 | { |
| 102 | case GL_FRAMEBUFFER: return true; |
| 103 | case GL_READ_FRAMEBUFFER: return true; |
| 104 | case GL_DRAW_FRAMEBUFFER: return true; |
| 105 | default: return false; |
| 106 | } |
| 107 | } |
| 108 | |
Jamie Madill | 8c96d58 | 2014-03-05 15:01:23 -0500 | [diff] [blame] | 109 | bool ValidBufferTarget(const Context *context, GLenum target) |
| 110 | { |
| 111 | switch (target) |
| 112 | { |
| 113 | case GL_ARRAY_BUFFER: |
| 114 | case GL_ELEMENT_ARRAY_BUFFER: |
| 115 | return true; |
| 116 | |
Jamie Madill | 8c96d58 | 2014-03-05 15:01:23 -0500 | [diff] [blame] | 117 | case GL_PIXEL_PACK_BUFFER: |
| 118 | case GL_PIXEL_UNPACK_BUFFER: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 119 | return context->getExtensions().pixelBufferObject; |
Shannon Woods | 158c438 | 2014-05-06 13:00:07 -0400 | [diff] [blame] | 120 | |
Shannon Woods | b380174 | 2014-03-27 14:59:19 -0400 | [diff] [blame] | 121 | case GL_COPY_READ_BUFFER: |
| 122 | case GL_COPY_WRITE_BUFFER: |
Jamie Madill | 8c96d58 | 2014-03-05 15:01:23 -0500 | [diff] [blame] | 123 | case GL_TRANSFORM_FEEDBACK_BUFFER: |
| 124 | case GL_UNIFORM_BUFFER: |
| 125 | return (context->getClientVersion() >= 3); |
| 126 | |
| 127 | default: |
| 128 | return false; |
| 129 | } |
| 130 | } |
| 131 | |
Jamie Madill | 70656a6 | 2014-03-05 15:01:26 -0500 | [diff] [blame] | 132 | bool ValidBufferParameter(const Context *context, GLenum pname) |
| 133 | { |
| 134 | switch (pname) |
| 135 | { |
| 136 | case GL_BUFFER_USAGE: |
| 137 | case GL_BUFFER_SIZE: |
| 138 | return true; |
| 139 | |
| 140 | // GL_BUFFER_MAP_POINTER is a special case, and may only be |
| 141 | // queried with GetBufferPointerv |
| 142 | case GL_BUFFER_ACCESS_FLAGS: |
| 143 | case GL_BUFFER_MAPPED: |
| 144 | case GL_BUFFER_MAP_OFFSET: |
| 145 | case GL_BUFFER_MAP_LENGTH: |
| 146 | return (context->getClientVersion() >= 3); |
| 147 | |
| 148 | default: |
| 149 | return false; |
| 150 | } |
| 151 | } |
| 152 | |
Jamie Madill | 8c96d58 | 2014-03-05 15:01:23 -0500 | [diff] [blame] | 153 | bool ValidMipLevel(const Context *context, GLenum target, GLint level) |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 154 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 155 | size_t maxDimension = 0; |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 156 | switch (target) |
| 157 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 158 | case GL_TEXTURE_2D: maxDimension = context->getCaps().max2DTextureSize; break; |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 159 | case GL_TEXTURE_CUBE_MAP: |
| 160 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 161 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 162 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 163 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 164 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 165 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: maxDimension = context->getCaps().maxCubeMapTextureSize; break; |
| 166 | case GL_TEXTURE_3D: maxDimension = context->getCaps().max3DTextureSize; break; |
| 167 | case GL_TEXTURE_2D_ARRAY: maxDimension = context->getCaps().max2DTextureSize; break; |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 168 | default: UNREACHABLE(); |
| 169 | } |
| 170 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 171 | return level <= gl::log2(maxDimension); |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 172 | } |
| 173 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 174 | bool ValidImageSize(const Context *context, GLenum target, GLint level, |
Jamie Madill | 4fd75c1 | 2014-06-23 10:53:54 -0400 | [diff] [blame] | 175 | GLsizei width, GLsizei height, GLsizei depth) |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 176 | { |
| 177 | if (level < 0 || width < 0 || height < 0 || depth < 0) |
| 178 | { |
| 179 | return false; |
| 180 | } |
| 181 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 182 | if (!context->getExtensions().textureNPOT && |
Jamie Madill | 4fd75c1 | 2014-06-23 10:53:54 -0400 | [diff] [blame] | 183 | (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth)))) |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 184 | { |
| 185 | return false; |
| 186 | } |
| 187 | |
| 188 | if (!ValidMipLevel(context, target, level)) |
| 189 | { |
| 190 | return false; |
| 191 | } |
| 192 | |
| 193 | return true; |
| 194 | } |
| 195 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 196 | bool ValidCompressedImageSize(const Context *context, GLenum internalFormat, GLsizei width, GLsizei height) |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 197 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 198 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalFormat); |
| 199 | if (!formatInfo.compressed) |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 200 | { |
| 201 | return false; |
| 202 | } |
| 203 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 204 | if (width < 0 || (static_cast<GLuint>(width) > formatInfo.compressedBlockWidth && width % formatInfo.compressedBlockWidth != 0) || |
| 205 | height < 0 || (static_cast<GLuint>(height) > formatInfo.compressedBlockHeight && height % formatInfo.compressedBlockHeight != 0)) |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 206 | { |
| 207 | return false; |
| 208 | } |
| 209 | |
| 210 | return true; |
| 211 | } |
| 212 | |
Geoff Lang | 37dde69 | 2014-01-31 16:34:54 -0500 | [diff] [blame] | 213 | bool ValidQueryType(const Context *context, GLenum queryType) |
| 214 | { |
| 215 | META_ASSERT(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT); |
| 216 | META_ASSERT(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT); |
| 217 | |
| 218 | switch (queryType) |
| 219 | { |
| 220 | case GL_ANY_SAMPLES_PASSED: |
| 221 | case GL_ANY_SAMPLES_PASSED_CONSERVATIVE: |
| 222 | return true; |
| 223 | case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN: |
| 224 | return (context->getClientVersion() >= 3); |
| 225 | default: |
| 226 | return false; |
| 227 | } |
| 228 | } |
| 229 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 230 | bool ValidProgram(Context *context, GLuint id) |
Geoff Lang | 48dcae7 | 2014-02-05 16:28:24 -0500 | [diff] [blame] | 231 | { |
| 232 | // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will generate the |
| 233 | // error INVALID_VALUE if the provided name is not the name of either a shader or program object and |
| 234 | // INVALID_OPERATION if the provided name identifies an object that is not the expected type." |
| 235 | |
| 236 | if (context->getProgram(id) != NULL) |
| 237 | { |
| 238 | return true; |
| 239 | } |
| 240 | else if (context->getShader(id) != NULL) |
| 241 | { |
| 242 | // ID is the wrong type |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 243 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 244 | return false; |
Geoff Lang | 48dcae7 | 2014-02-05 16:28:24 -0500 | [diff] [blame] | 245 | } |
| 246 | else |
| 247 | { |
| 248 | // No shader/program object has this ID |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 249 | context->recordError(Error(GL_INVALID_VALUE)); |
| 250 | return false; |
Geoff Lang | 48dcae7 | 2014-02-05 16:28:24 -0500 | [diff] [blame] | 251 | } |
| 252 | } |
| 253 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 254 | bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment) |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 255 | { |
| 256 | if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT) |
| 257 | { |
| 258 | const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT); |
| 259 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 260 | if (colorAttachment >= context->getCaps().maxColorAttachments) |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 261 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 262 | context->recordError(Error(GL_INVALID_VALUE)); |
| 263 | return false; |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 264 | } |
| 265 | } |
| 266 | else |
| 267 | { |
| 268 | switch (attachment) |
| 269 | { |
| 270 | case GL_DEPTH_ATTACHMENT: |
| 271 | case GL_STENCIL_ATTACHMENT: |
| 272 | break; |
| 273 | |
| 274 | case GL_DEPTH_STENCIL_ATTACHMENT: |
| 275 | if (context->getClientVersion() < 3) |
| 276 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 277 | context->recordError(Error(GL_INVALID_ENUM)); |
| 278 | return false; |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 279 | } |
| 280 | break; |
| 281 | |
| 282 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 283 | context->recordError(Error(GL_INVALID_ENUM)); |
| 284 | return false; |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 285 | } |
| 286 | } |
| 287 | |
| 288 | return true; |
| 289 | } |
| 290 | |
Corentin Wallez | e090264 | 2014-11-04 12:32:15 -0800 | [diff] [blame] | 291 | bool ValidateRenderbufferStorageParametersBase(gl::Context *context, GLenum target, GLsizei samples, |
| 292 | GLenum internalformat, GLsizei width, GLsizei height) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 293 | { |
| 294 | switch (target) |
| 295 | { |
| 296 | case GL_RENDERBUFFER: |
| 297 | break; |
| 298 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 299 | context->recordError(Error(GL_INVALID_ENUM)); |
| 300 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 301 | } |
| 302 | |
| 303 | if (width < 0 || height < 0 || samples < 0) |
| 304 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 305 | context->recordError(Error(GL_INVALID_VALUE)); |
| 306 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 307 | } |
| 308 | |
Geoff Lang | d87878e | 2014-09-19 15:42:59 -0400 | [diff] [blame] | 309 | const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat); |
| 310 | if (!formatCaps.renderable) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 311 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 312 | context->recordError(Error(GL_INVALID_ENUM)); |
| 313 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 314 | } |
| 315 | |
| 316 | // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be |
| 317 | // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains |
Corentin Wallez | e090264 | 2014-11-04 12:32:15 -0800 | [diff] [blame] | 318 | // only sized internal formats. |
Geoff Lang | d87878e | 2014-09-19 15:42:59 -0400 | [diff] [blame] | 319 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 320 | if (formatInfo.pixelBytes == 0) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 321 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 322 | context->recordError(Error(GL_INVALID_ENUM)); |
| 323 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 324 | } |
| 325 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 326 | if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 327 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 328 | context->recordError(Error(GL_INVALID_VALUE)); |
| 329 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 330 | } |
| 331 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 332 | GLuint handle = context->getState().getRenderbufferId(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 333 | if (handle == 0) |
| 334 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 335 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 336 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 337 | } |
| 338 | |
| 339 | return true; |
| 340 | } |
| 341 | |
Corentin Wallez | e090264 | 2014-11-04 12:32:15 -0800 | [diff] [blame] | 342 | bool ValidateRenderbufferStorageParametersANGLE(gl::Context *context, GLenum target, GLsizei samples, |
| 343 | GLenum internalformat, GLsizei width, GLsizei height) |
| 344 | { |
| 345 | ASSERT(context->getExtensions().framebufferMultisample); |
| 346 | |
| 347 | // ANGLE_framebuffer_multisample states that the value of samples must be less than or equal |
| 348 | // to MAX_SAMPLES_ANGLE (Context::getExtensions().maxSamples) otherwise GL_INVALID_VALUE is |
| 349 | // generated. |
| 350 | if (static_cast<GLuint>(samples) > context->getExtensions().maxSamples) |
| 351 | { |
| 352 | context->recordError(Error(GL_INVALID_VALUE)); |
| 353 | return false; |
| 354 | } |
| 355 | |
| 356 | // ANGLE_framebuffer_multisample states GL_OUT_OF_MEMORY is generated on a failure to create |
| 357 | // the specified storage. This is different than ES 3.0 in which a sample number higher |
| 358 | // than the maximum sample number supported by this format generates a GL_INVALID_VALUE. |
| 359 | const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat); |
| 360 | if (static_cast<GLuint>(samples) > formatCaps.getMaxSamples()) |
| 361 | { |
| 362 | context->recordError(Error(GL_OUT_OF_MEMORY)); |
| 363 | return false; |
| 364 | } |
| 365 | |
| 366 | return ValidateRenderbufferStorageParametersBase(context, target, samples, internalformat, width, height); |
| 367 | } |
| 368 | |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 369 | bool ValidateFramebufferRenderbufferParameters(gl::Context *context, GLenum target, GLenum attachment, |
| 370 | GLenum renderbuffertarget, GLuint renderbuffer) |
| 371 | { |
Shannon Woods | 1da3cf6 | 2014-06-27 15:32:23 -0400 | [diff] [blame] | 372 | if (!ValidFramebufferTarget(target)) |
| 373 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 374 | context->recordError(Error(GL_INVALID_ENUM)); |
| 375 | return false; |
Shannon Woods | 1da3cf6 | 2014-06-27 15:32:23 -0400 | [diff] [blame] | 376 | } |
| 377 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 378 | gl::Framebuffer *framebuffer = context->getState().getTargetFramebuffer(target); |
| 379 | GLuint framebufferHandle = context->getState().getTargetFramebuffer(target)->id(); |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 380 | |
| 381 | if (!framebuffer || (framebufferHandle == 0 && renderbuffer != 0)) |
| 382 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 383 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 384 | return false; |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 385 | } |
| 386 | |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 387 | if (!ValidateAttachmentTarget(context, attachment)) |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 388 | { |
Jamie Madill | b447227 | 2014-07-03 10:38:55 -0400 | [diff] [blame] | 389 | return false; |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 390 | } |
| 391 | |
Jamie Madill | ab9d82c | 2014-01-21 16:38:14 -0500 | [diff] [blame] | 392 | // [OpenGL ES 2.0.25] Section 4.4.3 page 112 |
| 393 | // [OpenGL ES 3.0.2] Section 4.4.2 page 201 |
| 394 | // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of |
| 395 | // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated. |
| 396 | if (renderbuffer != 0) |
| 397 | { |
| 398 | if (!context->getRenderbuffer(renderbuffer)) |
| 399 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 400 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 401 | return false; |
Jamie Madill | ab9d82c | 2014-01-21 16:38:14 -0500 | [diff] [blame] | 402 | } |
| 403 | } |
| 404 | |
Jamie Madill | 1fc7e2c | 2014-01-21 16:47:10 -0500 | [diff] [blame] | 405 | return true; |
| 406 | } |
| 407 | |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 408 | static bool IsPartialBlit(gl::Context *context, gl::FramebufferAttachment *readBuffer, gl::FramebufferAttachment *writeBuffer, |
Geoff Lang | 125deab | 2013-08-09 13:34:16 -0400 | [diff] [blame] | 409 | GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, |
| 410 | GLint dstX0, GLint dstY0, GLint dstX1, GLint dstY1) |
| 411 | { |
| 412 | if (srcX0 != 0 || srcY0 != 0 || dstX0 != 0 || dstY0 != 0 || |
| 413 | dstX1 != writeBuffer->getWidth() || dstY1 != writeBuffer->getHeight() || |
| 414 | srcX1 != readBuffer->getWidth() || srcY1 != readBuffer->getHeight()) |
| 415 | { |
| 416 | return true; |
| 417 | } |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 418 | else if (context->getState().isScissorTestEnabled()) |
Geoff Lang | 125deab | 2013-08-09 13:34:16 -0400 | [diff] [blame] | 419 | { |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 420 | const Rectangle &scissor = context->getState().getScissor(); |
Geoff Lang | 125deab | 2013-08-09 13:34:16 -0400 | [diff] [blame] | 421 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 422 | return scissor.x > 0 || scissor.y > 0 || |
| 423 | scissor.width < writeBuffer->getWidth() || |
| 424 | scissor.height < writeBuffer->getHeight(); |
Geoff Lang | 125deab | 2013-08-09 13:34:16 -0400 | [diff] [blame] | 425 | } |
| 426 | else |
| 427 | { |
| 428 | return false; |
| 429 | } |
| 430 | } |
| 431 | |
Geoff Lang | 34dbb6f | 2013-08-05 15:05:47 -0400 | [diff] [blame] | 432 | bool ValidateBlitFramebufferParameters(gl::Context *context, GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 433 | GLint dstX0, GLint dstY0, GLint dstX1, GLint dstY1, GLbitfield mask, |
| 434 | GLenum filter, bool fromAngleExtension) |
| 435 | { |
| 436 | switch (filter) |
| 437 | { |
| 438 | case GL_NEAREST: |
| 439 | break; |
| 440 | case GL_LINEAR: |
| 441 | if (fromAngleExtension) |
| 442 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 443 | context->recordError(Error(GL_INVALID_ENUM)); |
| 444 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 445 | } |
| 446 | break; |
| 447 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 448 | context->recordError(Error(GL_INVALID_ENUM)); |
| 449 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 450 | } |
| 451 | |
| 452 | if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0) |
| 453 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 454 | context->recordError(Error(GL_INVALID_VALUE)); |
| 455 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 456 | } |
| 457 | |
| 458 | if (mask == 0) |
| 459 | { |
| 460 | // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no |
| 461 | // buffers are copied. |
| 462 | return false; |
| 463 | } |
| 464 | |
| 465 | if (fromAngleExtension && (srcX1 - srcX0 != dstX1 - dstX0 || srcY1 - srcY0 != dstY1 - dstY0)) |
| 466 | { |
| 467 | ERR("Scaling and flipping in BlitFramebufferANGLE not supported by this implementation."); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 468 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 469 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 470 | } |
| 471 | |
| 472 | // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the |
| 473 | // color buffer, leaving only nearest being unfiltered from above |
| 474 | if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST) |
| 475 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 476 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 477 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 478 | } |
| 479 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 480 | if (context->getState().getReadFramebuffer()->id() == context->getState().getDrawFramebuffer()->id()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 481 | { |
| 482 | if (fromAngleExtension) |
| 483 | { |
| 484 | ERR("Blits with the same source and destination framebuffer are not supported by this " |
| 485 | "implementation."); |
| 486 | } |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 487 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 488 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 489 | } |
| 490 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 491 | gl::Framebuffer *readFramebuffer = context->getState().getReadFramebuffer(); |
| 492 | gl::Framebuffer *drawFramebuffer = context->getState().getDrawFramebuffer(); |
Jamie Madill | 48faf80 | 2014-11-06 15:27:22 -0500 | [diff] [blame] | 493 | |
| 494 | if (!readFramebuffer || !drawFramebuffer) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 495 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 496 | context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
| 497 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 498 | } |
| 499 | |
Geoff Lang | 748f74e | 2014-12-01 11:25:34 -0500 | [diff] [blame] | 500 | if (!readFramebuffer->checkStatus(context->getData())) |
Jamie Madill | 48faf80 | 2014-11-06 15:27:22 -0500 | [diff] [blame] | 501 | { |
| 502 | context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
| 503 | return false; |
| 504 | } |
| 505 | |
Geoff Lang | 748f74e | 2014-12-01 11:25:34 -0500 | [diff] [blame] | 506 | if (!drawFramebuffer->checkStatus(context->getData())) |
Jamie Madill | 48faf80 | 2014-11-06 15:27:22 -0500 | [diff] [blame] | 507 | { |
| 508 | context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
| 509 | return false; |
| 510 | } |
| 511 | |
| 512 | if (drawFramebuffer->getSamples(context->getData()) != 0) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 513 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 514 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 515 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 516 | } |
| 517 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 518 | bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1; |
| 519 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 520 | if (mask & GL_COLOR_BUFFER_BIT) |
| 521 | { |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 522 | gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer(); |
| 523 | gl::FramebufferAttachment *drawColorBuffer = drawFramebuffer->getFirstColorbuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 524 | |
| 525 | if (readColorBuffer && drawColorBuffer) |
| 526 | { |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 527 | GLenum readInternalFormat = readColorBuffer->getActualFormat(); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 528 | const InternalFormat &readFormatInfo = GetInternalFormatInfo(readInternalFormat); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 529 | |
| 530 | for (unsigned int i = 0; i < gl::IMPLEMENTATION_MAX_DRAW_BUFFERS; i++) |
| 531 | { |
| 532 | if (drawFramebuffer->isEnabledColorAttachment(i)) |
| 533 | { |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 534 | GLenum drawInternalFormat = drawFramebuffer->getColorbuffer(i)->getActualFormat(); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 535 | const InternalFormat &drawFormatInfo = GetInternalFormatInfo(drawInternalFormat); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 536 | |
Geoff Lang | b2f3d05 | 2013-08-13 12:49:27 -0400 | [diff] [blame] | 537 | // The GL ES 3.0.2 spec (pg 193) states that: |
| 538 | // 1) If the read buffer is fixed point format, the draw buffer must be as well |
| 539 | // 2) If the read buffer is an unsigned integer format, the draw buffer must be as well |
| 540 | // 3) If the read buffer is a signed integer format, the draw buffer must be as well |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 541 | if ( (readFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || readFormatInfo.componentType == GL_SIGNED_NORMALIZED) && |
| 542 | !(drawFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || drawFormatInfo.componentType == GL_SIGNED_NORMALIZED)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 543 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 544 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 545 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 546 | } |
| 547 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 548 | if (readFormatInfo.componentType == GL_UNSIGNED_INT && drawFormatInfo.componentType != GL_UNSIGNED_INT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 549 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 550 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 551 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 552 | } |
| 553 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 554 | if (readFormatInfo.componentType == GL_INT && drawFormatInfo.componentType != GL_INT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 555 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 556 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 557 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 558 | } |
| 559 | |
Geoff Lang | b2f3d05 | 2013-08-13 12:49:27 -0400 | [diff] [blame] | 560 | if (readColorBuffer->getSamples() > 0 && (readInternalFormat != drawInternalFormat || !sameBounds)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 561 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 562 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 563 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 564 | } |
| 565 | } |
| 566 | } |
| 567 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 568 | if ((readFormatInfo.componentType == GL_INT || readFormatInfo.componentType == GL_UNSIGNED_INT) && filter == GL_LINEAR) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 569 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 570 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 571 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 572 | } |
| 573 | |
| 574 | if (fromAngleExtension) |
| 575 | { |
Geoff Lang | 6a1e6b9 | 2014-11-06 10:42:45 -0500 | [diff] [blame] | 576 | FramebufferAttachment *readColorAttachment = readFramebuffer->getReadColorbuffer(); |
| 577 | if (!readColorAttachment || |
| 578 | (!(readColorAttachment->type() == GL_TEXTURE && readColorAttachment->getTextureImageIndex()->type == GL_TEXTURE_2D) && |
| 579 | readColorAttachment->type() != GL_RENDERBUFFER && |
| 580 | readColorAttachment->type() != GL_FRAMEBUFFER_DEFAULT)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 581 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 582 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 583 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 584 | } |
| 585 | |
| 586 | for (unsigned int colorAttachment = 0; colorAttachment < gl::IMPLEMENTATION_MAX_DRAW_BUFFERS; colorAttachment++) |
| 587 | { |
| 588 | if (drawFramebuffer->isEnabledColorAttachment(colorAttachment)) |
| 589 | { |
Jamie Madill | e92a354 | 2014-07-03 10:38:58 -0400 | [diff] [blame] | 590 | FramebufferAttachment *attachment = drawFramebuffer->getColorbuffer(colorAttachment); |
| 591 | ASSERT(attachment); |
| 592 | |
Geoff Lang | 6a1e6b9 | 2014-11-06 10:42:45 -0500 | [diff] [blame] | 593 | if (!(attachment->type() == GL_TEXTURE && attachment->getTextureImageIndex()->type == GL_TEXTURE_2D) && |
| 594 | attachment->type() != GL_RENDERBUFFER && |
| 595 | attachment->type() != GL_FRAMEBUFFER_DEFAULT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 596 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 597 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 598 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 599 | } |
| 600 | |
Jamie Madill | f8f18f0 | 2014-10-02 10:44:17 -0400 | [diff] [blame] | 601 | // Return an error if the destination formats do not match |
| 602 | if (attachment->getInternalFormat() != readColorBuffer->getInternalFormat()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 603 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 604 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 605 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 606 | } |
| 607 | } |
| 608 | } |
Jamie Madill | 48faf80 | 2014-11-06 15:27:22 -0500 | [diff] [blame] | 609 | |
| 610 | int readSamples = readFramebuffer->getSamples(context->getData()); |
| 611 | |
| 612 | if (readSamples != 0 && IsPartialBlit(context, readColorBuffer, drawColorBuffer, |
| 613 | srcX0, srcY0, srcX1, srcY1, |
| 614 | dstX0, dstY0, dstX1, dstY1)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 615 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 616 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 617 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 618 | } |
| 619 | } |
| 620 | } |
| 621 | } |
| 622 | |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 623 | GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT}; |
| 624 | GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT}; |
| 625 | for (size_t i = 0; i < 2; i++) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 626 | { |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 627 | if (mask & masks[i]) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 628 | { |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 629 | gl::FramebufferAttachment *readBuffer = readFramebuffer->getAttachment(attachments[i]); |
| 630 | gl::FramebufferAttachment *drawBuffer = drawFramebuffer->getAttachment(attachments[i]); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 631 | |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 632 | if (readBuffer && drawBuffer) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 633 | { |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 634 | if (readBuffer->getActualFormat() != drawBuffer->getActualFormat()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 635 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 636 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 637 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 638 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 639 | |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 640 | if (readBuffer->getSamples() > 0 && !sameBounds) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 641 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 642 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 643 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 644 | } |
Dongseong Hwang | 44b422c | 2014-12-09 15:42:01 +0200 | [diff] [blame] | 645 | |
| 646 | if (fromAngleExtension) |
| 647 | { |
| 648 | if (IsPartialBlit(context, readBuffer, drawBuffer, |
| 649 | srcX0, srcY0, srcX1, srcY1, dstX0, dstY0, dstX1, dstY1)) |
| 650 | { |
| 651 | ERR("Only whole-buffer depth and stencil blits are supported by this implementation."); |
| 652 | context->recordError(Error(GL_INVALID_OPERATION)); // only whole-buffer copies are permitted |
| 653 | return false; |
| 654 | } |
| 655 | |
| 656 | if (readBuffer->getSamples() != 0 || drawBuffer->getSamples() != 0) |
| 657 | { |
| 658 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 659 | return false; |
| 660 | } |
| 661 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 662 | } |
| 663 | } |
| 664 | } |
| 665 | |
| 666 | return true; |
| 667 | } |
| 668 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 669 | bool ValidateGetVertexAttribParameters(Context *context, GLenum pname) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 670 | { |
| 671 | switch (pname) |
| 672 | { |
| 673 | case GL_VERTEX_ATTRIB_ARRAY_ENABLED: |
| 674 | case GL_VERTEX_ATTRIB_ARRAY_SIZE: |
| 675 | case GL_VERTEX_ATTRIB_ARRAY_STRIDE: |
| 676 | case GL_VERTEX_ATTRIB_ARRAY_TYPE: |
| 677 | case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED: |
| 678 | case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING: |
| 679 | case GL_CURRENT_VERTEX_ATTRIB: |
| 680 | return true; |
| 681 | |
| 682 | case GL_VERTEX_ATTRIB_ARRAY_DIVISOR: |
| 683 | // Don't verify ES3 context because GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE uses |
| 684 | // the same constant. |
| 685 | META_ASSERT(GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE); |
| 686 | return true; |
| 687 | |
| 688 | case GL_VERTEX_ATTRIB_ARRAY_INTEGER: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 689 | if (context->getClientVersion() < 3) |
| 690 | { |
| 691 | context->recordError(Error(GL_INVALID_ENUM)); |
| 692 | return false; |
| 693 | } |
| 694 | return true; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 695 | |
| 696 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 697 | context->recordError(Error(GL_INVALID_ENUM)); |
| 698 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 699 | } |
| 700 | } |
| 701 | |
Geoff Lang | 34dbb6f | 2013-08-05 15:05:47 -0400 | [diff] [blame] | 702 | bool ValidateTexParamParameters(gl::Context *context, GLenum pname, GLint param) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 703 | { |
| 704 | switch (pname) |
| 705 | { |
| 706 | case GL_TEXTURE_WRAP_R: |
| 707 | case GL_TEXTURE_SWIZZLE_R: |
| 708 | case GL_TEXTURE_SWIZZLE_G: |
| 709 | case GL_TEXTURE_SWIZZLE_B: |
| 710 | case GL_TEXTURE_SWIZZLE_A: |
| 711 | case GL_TEXTURE_BASE_LEVEL: |
| 712 | case GL_TEXTURE_MAX_LEVEL: |
| 713 | case GL_TEXTURE_COMPARE_MODE: |
| 714 | case GL_TEXTURE_COMPARE_FUNC: |
| 715 | case GL_TEXTURE_MIN_LOD: |
| 716 | case GL_TEXTURE_MAX_LOD: |
| 717 | if (context->getClientVersion() < 3) |
| 718 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 719 | context->recordError(Error(GL_INVALID_ENUM)); |
| 720 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 721 | } |
| 722 | break; |
| 723 | |
| 724 | default: break; |
| 725 | } |
| 726 | |
| 727 | switch (pname) |
| 728 | { |
| 729 | case GL_TEXTURE_WRAP_S: |
| 730 | case GL_TEXTURE_WRAP_T: |
| 731 | case GL_TEXTURE_WRAP_R: |
| 732 | switch (param) |
| 733 | { |
| 734 | case GL_REPEAT: |
| 735 | case GL_CLAMP_TO_EDGE: |
| 736 | case GL_MIRRORED_REPEAT: |
| 737 | return true; |
| 738 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 739 | context->recordError(Error(GL_INVALID_ENUM)); |
| 740 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 741 | } |
| 742 | |
| 743 | case GL_TEXTURE_MIN_FILTER: |
| 744 | switch (param) |
| 745 | { |
| 746 | case GL_NEAREST: |
| 747 | case GL_LINEAR: |
| 748 | case GL_NEAREST_MIPMAP_NEAREST: |
| 749 | case GL_LINEAR_MIPMAP_NEAREST: |
| 750 | case GL_NEAREST_MIPMAP_LINEAR: |
| 751 | case GL_LINEAR_MIPMAP_LINEAR: |
| 752 | return true; |
| 753 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 754 | context->recordError(Error(GL_INVALID_ENUM)); |
| 755 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 756 | } |
| 757 | break; |
| 758 | |
| 759 | case GL_TEXTURE_MAG_FILTER: |
| 760 | switch (param) |
| 761 | { |
| 762 | case GL_NEAREST: |
| 763 | case GL_LINEAR: |
| 764 | return true; |
| 765 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 766 | context->recordError(Error(GL_INVALID_ENUM)); |
| 767 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 768 | } |
| 769 | break; |
| 770 | |
| 771 | case GL_TEXTURE_USAGE_ANGLE: |
| 772 | switch (param) |
| 773 | { |
| 774 | case GL_NONE: |
| 775 | case GL_FRAMEBUFFER_ATTACHMENT_ANGLE: |
| 776 | return true; |
| 777 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 778 | context->recordError(Error(GL_INVALID_ENUM)); |
| 779 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 780 | } |
| 781 | break; |
| 782 | |
| 783 | case GL_TEXTURE_MAX_ANISOTROPY_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 784 | if (!context->getExtensions().textureFilterAnisotropic) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 785 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 786 | context->recordError(Error(GL_INVALID_ENUM)); |
| 787 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 788 | } |
| 789 | |
| 790 | // we assume the parameter passed to this validation method is truncated, not rounded |
| 791 | if (param < 1) |
| 792 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 793 | context->recordError(Error(GL_INVALID_VALUE)); |
| 794 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 795 | } |
| 796 | return true; |
| 797 | |
| 798 | case GL_TEXTURE_MIN_LOD: |
| 799 | case GL_TEXTURE_MAX_LOD: |
| 800 | // any value is permissible |
| 801 | return true; |
| 802 | |
| 803 | case GL_TEXTURE_COMPARE_MODE: |
Geoff Lang | 63b5f1f | 2013-09-23 14:52:14 -0400 | [diff] [blame] | 804 | // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17 |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 805 | switch (param) |
| 806 | { |
| 807 | case GL_NONE: |
| 808 | case GL_COMPARE_REF_TO_TEXTURE: |
| 809 | return true; |
| 810 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 811 | context->recordError(Error(GL_INVALID_ENUM)); |
| 812 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 813 | } |
| 814 | break; |
| 815 | |
| 816 | case GL_TEXTURE_COMPARE_FUNC: |
Geoff Lang | 63b5f1f | 2013-09-23 14:52:14 -0400 | [diff] [blame] | 817 | // Acceptable function parameters from GLES 3.0.2 spec, table 3.17 |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 818 | switch (param) |
| 819 | { |
| 820 | case GL_LEQUAL: |
| 821 | case GL_GEQUAL: |
| 822 | case GL_LESS: |
| 823 | case GL_GREATER: |
| 824 | case GL_EQUAL: |
| 825 | case GL_NOTEQUAL: |
| 826 | case GL_ALWAYS: |
| 827 | case GL_NEVER: |
| 828 | return true; |
| 829 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 830 | context->recordError(Error(GL_INVALID_ENUM)); |
| 831 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 832 | } |
| 833 | break; |
| 834 | |
| 835 | case GL_TEXTURE_SWIZZLE_R: |
| 836 | case GL_TEXTURE_SWIZZLE_G: |
| 837 | case GL_TEXTURE_SWIZZLE_B: |
| 838 | case GL_TEXTURE_SWIZZLE_A: |
Geoff Lang | bc90a48 | 2013-09-17 16:51:27 -0400 | [diff] [blame] | 839 | switch (param) |
| 840 | { |
| 841 | case GL_RED: |
| 842 | case GL_GREEN: |
| 843 | case GL_BLUE: |
| 844 | case GL_ALPHA: |
| 845 | case GL_ZERO: |
| 846 | case GL_ONE: |
| 847 | return true; |
| 848 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 849 | context->recordError(Error(GL_INVALID_ENUM)); |
| 850 | return false; |
Geoff Lang | bc90a48 | 2013-09-17 16:51:27 -0400 | [diff] [blame] | 851 | } |
| 852 | break; |
| 853 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 854 | case GL_TEXTURE_BASE_LEVEL: |
| 855 | case GL_TEXTURE_MAX_LEVEL: |
Nicolas Capens | 8de6828 | 2014-04-04 11:10:27 -0400 | [diff] [blame] | 856 | if (param < 0) |
| 857 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 858 | context->recordError(Error(GL_INVALID_VALUE)); |
| 859 | return false; |
Nicolas Capens | 8de6828 | 2014-04-04 11:10:27 -0400 | [diff] [blame] | 860 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 861 | return true; |
| 862 | |
| 863 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 864 | context->recordError(Error(GL_INVALID_ENUM)); |
| 865 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 866 | } |
| 867 | } |
| 868 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 869 | bool ValidateSamplerObjectParameter(gl::Context *context, GLenum pname) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 870 | { |
| 871 | switch (pname) |
| 872 | { |
| 873 | case GL_TEXTURE_MIN_FILTER: |
| 874 | case GL_TEXTURE_MAG_FILTER: |
| 875 | case GL_TEXTURE_WRAP_S: |
| 876 | case GL_TEXTURE_WRAP_T: |
| 877 | case GL_TEXTURE_WRAP_R: |
| 878 | case GL_TEXTURE_MIN_LOD: |
| 879 | case GL_TEXTURE_MAX_LOD: |
| 880 | case GL_TEXTURE_COMPARE_MODE: |
| 881 | case GL_TEXTURE_COMPARE_FUNC: |
| 882 | return true; |
| 883 | |
| 884 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 885 | context->recordError(Error(GL_INVALID_ENUM)); |
| 886 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 887 | } |
| 888 | } |
| 889 | |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 890 | bool ValidateReadPixelsParameters(gl::Context *context, GLint x, GLint y, GLsizei width, GLsizei height, |
| 891 | GLenum format, GLenum type, GLsizei *bufSize, GLvoid *pixels) |
| 892 | { |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 893 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 894 | ASSERT(framebuffer); |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 895 | |
Geoff Lang | 748f74e | 2014-12-01 11:25:34 -0500 | [diff] [blame] | 896 | if (framebuffer->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 897 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 898 | context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
| 899 | return false; |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 900 | } |
| 901 | |
Jamie Madill | 48faf80 | 2014-11-06 15:27:22 -0500 | [diff] [blame] | 902 | if (context->getState().getReadFramebuffer()->id() != 0 && |
| 903 | framebuffer->getSamples(context->getData()) != 0) |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 904 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 905 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 906 | return false; |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 907 | } |
| 908 | |
Geoff Lang | bce529e | 2014-12-01 12:48:41 -0500 | [diff] [blame^] | 909 | const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer(); |
| 910 | if (!readBuffer) |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 911 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 912 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 913 | return false; |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 914 | } |
| 915 | |
Geoff Lang | bce529e | 2014-12-01 12:48:41 -0500 | [diff] [blame^] | 916 | GLenum currentFormat = framebuffer->getImplementationColorReadFormat(); |
| 917 | GLenum currentType = framebuffer->getImplementationColorReadType(); |
| 918 | GLenum currentInternalFormat = readBuffer->getActualFormat(); |
Geoff Lang | e4a492b | 2014-06-19 14:14:41 -0400 | [diff] [blame] | 919 | GLuint clientVersion = context->getClientVersion(); |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 920 | |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 921 | bool validReadFormat = (clientVersion < 3) ? ValidES2ReadFormatType(context, format, type) : |
| 922 | ValidES3ReadFormatType(context, currentInternalFormat, format, type); |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 923 | |
| 924 | if (!(currentFormat == format && currentType == type) && !validReadFormat) |
| 925 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 926 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 927 | return false; |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 928 | } |
| 929 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 930 | GLenum sizedInternalFormat = GetSizedInternalFormat(format, type); |
| 931 | const InternalFormat &sizedFormatInfo = GetInternalFormatInfo(sizedInternalFormat); |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 932 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 933 | GLsizei outputPitch = sizedFormatInfo.computeRowPitch(type, width, context->getState().getPackAlignment()); |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 934 | // sized query sanity check |
| 935 | if (bufSize) |
| 936 | { |
| 937 | int requiredSize = outputPitch * height; |
| 938 | if (requiredSize > *bufSize) |
| 939 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 940 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 941 | return false; |
Jamie Madill | 26e9195 | 2014-03-05 15:01:27 -0500 | [diff] [blame] | 942 | } |
| 943 | } |
| 944 | |
| 945 | return true; |
| 946 | } |
| 947 | |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 948 | bool ValidateBeginQuery(gl::Context *context, GLenum target, GLuint id) |
| 949 | { |
| 950 | if (!ValidQueryType(context, target)) |
| 951 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 952 | context->recordError(Error(GL_INVALID_ENUM)); |
| 953 | return false; |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 954 | } |
| 955 | |
| 956 | if (id == 0) |
| 957 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 958 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 959 | return false; |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 960 | } |
| 961 | |
| 962 | // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id> |
| 963 | // of zero, if the active query object name for <target> is non-zero (for the |
| 964 | // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if |
| 965 | // the active query for either target is non-zero), if <id> is the name of an |
| 966 | // existing query object whose type does not match <target>, or if <id> is the |
| 967 | // active query object name for any query type, the error INVALID_OPERATION is |
| 968 | // generated. |
| 969 | |
| 970 | // Ensure no other queries are active |
| 971 | // NOTE: If other queries than occlusion are supported, we will need to check |
| 972 | // separately that: |
| 973 | // a) The query ID passed is not the current active query for any target/type |
| 974 | // b) There are no active queries for the requested target (and in the case |
| 975 | // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, |
| 976 | // no query may be active for either if glBeginQuery targets either. |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 977 | if (context->getState().isQueryActive()) |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 978 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 979 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 980 | return false; |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 981 | } |
| 982 | |
| 983 | Query *queryObject = context->getQuery(id, true, target); |
| 984 | |
| 985 | // check that name was obtained with glGenQueries |
| 986 | if (!queryObject) |
| 987 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 988 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 989 | return false; |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 990 | } |
| 991 | |
| 992 | // check for type mismatch |
| 993 | if (queryObject->getType() != target) |
| 994 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 995 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 996 | return false; |
Jamie Madill | db2f14c | 2014-05-13 13:56:30 -0400 | [diff] [blame] | 997 | } |
| 998 | |
| 999 | return true; |
| 1000 | } |
| 1001 | |
Jamie Madill | 45c785d | 2014-05-13 14:09:34 -0400 | [diff] [blame] | 1002 | bool ValidateEndQuery(gl::Context *context, GLenum target) |
| 1003 | { |
| 1004 | if (!ValidQueryType(context, target)) |
| 1005 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1006 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1007 | return false; |
Jamie Madill | 45c785d | 2014-05-13 14:09:34 -0400 | [diff] [blame] | 1008 | } |
| 1009 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 1010 | const Query *queryObject = context->getState().getActiveQuery(target); |
Jamie Madill | 45c785d | 2014-05-13 14:09:34 -0400 | [diff] [blame] | 1011 | |
| 1012 | if (queryObject == NULL) |
| 1013 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1014 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1015 | return false; |
Jamie Madill | 45c785d | 2014-05-13 14:09:34 -0400 | [diff] [blame] | 1016 | } |
| 1017 | |
Jamie Madill | 45c785d | 2014-05-13 14:09:34 -0400 | [diff] [blame] | 1018 | return true; |
| 1019 | } |
| 1020 | |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1021 | static bool ValidateUniformCommonBase(gl::Context *context, GLenum targetUniformType, |
| 1022 | GLint location, GLsizei count, LinkedUniform **uniformOut) |
Jamie Madill | d7c7bb2 | 2014-05-20 10:55:54 -0400 | [diff] [blame] | 1023 | { |
| 1024 | if (count < 0) |
| 1025 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1026 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1027 | return false; |
Jamie Madill | d7c7bb2 | 2014-05-20 10:55:54 -0400 | [diff] [blame] | 1028 | } |
| 1029 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1030 | gl::Program *program = context->getState().getProgram(); |
| 1031 | if (!program) |
Jamie Madill | d7c7bb2 | 2014-05-20 10:55:54 -0400 | [diff] [blame] | 1032 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1033 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1034 | return false; |
Jamie Madill | d7c7bb2 | 2014-05-20 10:55:54 -0400 | [diff] [blame] | 1035 | } |
| 1036 | |
| 1037 | if (location == -1) |
| 1038 | { |
| 1039 | // Silently ignore the uniform command |
| 1040 | return false; |
| 1041 | } |
| 1042 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1043 | if (!program->isValidUniformLocation(location)) |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1044 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1045 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1046 | return false; |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1047 | } |
| 1048 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1049 | LinkedUniform *uniform = program->getUniformByLocation(location); |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1050 | |
| 1051 | // attempting to write an array to a non-array uniform is an INVALID_OPERATION |
| 1052 | if (uniform->elementCount() == 1 && count > 1) |
| 1053 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1054 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1055 | return false; |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1056 | } |
| 1057 | |
| 1058 | *uniformOut = uniform; |
Jamie Madill | d7c7bb2 | 2014-05-20 10:55:54 -0400 | [diff] [blame] | 1059 | return true; |
| 1060 | } |
| 1061 | |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1062 | bool ValidateUniform(gl::Context *context, GLenum uniformType, GLint location, GLsizei count) |
| 1063 | { |
| 1064 | // Check for ES3 uniform entry points |
Jamie Madill | f257598 | 2014-06-25 16:04:54 -0400 | [diff] [blame] | 1065 | if (VariableComponentType(uniformType) == GL_UNSIGNED_INT && context->getClientVersion() < 3) |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1066 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1067 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1068 | return false; |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1069 | } |
| 1070 | |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1071 | LinkedUniform *uniform = NULL; |
| 1072 | if (!ValidateUniformCommonBase(context, uniformType, location, count, &uniform)) |
| 1073 | { |
| 1074 | return false; |
| 1075 | } |
| 1076 | |
Jamie Madill | f257598 | 2014-06-25 16:04:54 -0400 | [diff] [blame] | 1077 | GLenum targetBoolType = VariableBoolVectorType(uniformType); |
Geoff Lang | 2ec386b | 2014-12-03 14:44:38 -0500 | [diff] [blame] | 1078 | bool samplerUniformCheck = (IsSamplerType(uniform->type) && uniformType == GL_INT); |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1079 | if (!samplerUniformCheck && uniformType != uniform->type && targetBoolType != uniform->type) |
| 1080 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1081 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1082 | return false; |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1083 | } |
| 1084 | |
| 1085 | return true; |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1086 | } |
| 1087 | |
| 1088 | bool ValidateUniformMatrix(gl::Context *context, GLenum matrixType, GLint location, GLsizei count, |
| 1089 | GLboolean transpose) |
| 1090 | { |
| 1091 | // Check for ES3 uniform entry points |
| 1092 | int rows = VariableRowCount(matrixType); |
| 1093 | int cols = VariableColumnCount(matrixType); |
| 1094 | if (rows != cols && context->getClientVersion() < 3) |
| 1095 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1096 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1097 | return false; |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1098 | } |
| 1099 | |
| 1100 | if (transpose != GL_FALSE && context->getClientVersion() < 3) |
| 1101 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1102 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1103 | return false; |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1104 | } |
| 1105 | |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1106 | LinkedUniform *uniform = NULL; |
| 1107 | if (!ValidateUniformCommonBase(context, matrixType, location, count, &uniform)) |
| 1108 | { |
| 1109 | return false; |
| 1110 | } |
| 1111 | |
| 1112 | if (uniform->type != matrixType) |
| 1113 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1114 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1115 | return false; |
Jamie Madill | 3639892 | 2014-05-20 14:51:53 -0400 | [diff] [blame] | 1116 | } |
| 1117 | |
| 1118 | return true; |
Jamie Madill | aa981bd | 2014-05-20 10:55:55 -0400 | [diff] [blame] | 1119 | } |
| 1120 | |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1121 | bool ValidateStateQuery(gl::Context *context, GLenum pname, GLenum *nativeType, unsigned int *numParams) |
| 1122 | { |
| 1123 | if (!context->getQueryParameterInfo(pname, nativeType, numParams)) |
| 1124 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1125 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1126 | return false; |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1127 | } |
| 1128 | |
| 1129 | if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15) |
| 1130 | { |
| 1131 | unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0); |
| 1132 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1133 | if (colorAttachment >= context->getCaps().maxDrawBuffers) |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1134 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1135 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1136 | return false; |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1137 | } |
| 1138 | } |
| 1139 | |
| 1140 | switch (pname) |
| 1141 | { |
| 1142 | case GL_TEXTURE_BINDING_2D: |
| 1143 | case GL_TEXTURE_BINDING_CUBE_MAP: |
| 1144 | case GL_TEXTURE_BINDING_3D: |
| 1145 | case GL_TEXTURE_BINDING_2D_ARRAY: |
Geoff Lang | 3a61c32 | 2014-07-10 13:01:54 -0400 | [diff] [blame] | 1146 | if (context->getState().getActiveSampler() >= context->getCaps().maxCombinedTextureImageUnits) |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1147 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1148 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1149 | return false; |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1150 | } |
| 1151 | break; |
| 1152 | |
| 1153 | case GL_IMPLEMENTATION_COLOR_READ_TYPE: |
| 1154 | case GL_IMPLEMENTATION_COLOR_READ_FORMAT: |
| 1155 | { |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 1156 | Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1157 | ASSERT(framebuffer); |
Geoff Lang | 748f74e | 2014-12-01 11:25:34 -0500 | [diff] [blame] | 1158 | if (framebuffer->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1159 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1160 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1161 | return false; |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1162 | } |
| 1163 | |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 1164 | FramebufferAttachment *attachment = framebuffer->getReadColorbuffer(); |
| 1165 | if (!attachment) |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1166 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1167 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1168 | return false; |
Jamie Madill | 893ab08 | 2014-05-16 16:56:10 -0400 | [diff] [blame] | 1169 | } |
| 1170 | } |
| 1171 | break; |
| 1172 | |
| 1173 | default: |
| 1174 | break; |
| 1175 | } |
| 1176 | |
| 1177 | // pname is valid, but there are no parameters to return |
| 1178 | if (numParams == 0) |
| 1179 | { |
| 1180 | return false; |
| 1181 | } |
| 1182 | |
| 1183 | return true; |
| 1184 | } |
| 1185 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1186 | bool ValidateCopyTexImageParametersBase(gl::Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
| 1187 | GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 1188 | GLint border, GLenum *textureFormatOut) |
| 1189 | { |
| 1190 | |
| 1191 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 1192 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1193 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1194 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1195 | } |
| 1196 | |
| 1197 | if (level < 0 || xoffset < 0 || yoffset < 0 || zoffset < 0 || width < 0 || height < 0) |
| 1198 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1199 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1200 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1201 | } |
| 1202 | |
| 1203 | if (std::numeric_limits<GLsizei>::max() - xoffset < width || std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 1204 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1205 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1206 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1207 | } |
| 1208 | |
| 1209 | if (border != 0) |
| 1210 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1211 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1212 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1213 | } |
| 1214 | |
| 1215 | if (!ValidMipLevel(context, target, level)) |
| 1216 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1217 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1218 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1219 | } |
| 1220 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 1221 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | 748f74e | 2014-12-01 11:25:34 -0500 | [diff] [blame] | 1222 | if (framebuffer->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1223 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1224 | context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
| 1225 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1226 | } |
| 1227 | |
Jamie Madill | 48faf80 | 2014-11-06 15:27:22 -0500 | [diff] [blame] | 1228 | if (context->getState().getReadFramebuffer()->id() != 0 && framebuffer->getSamples(context->getData()) != 0) |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1229 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1230 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1231 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1232 | } |
| 1233 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1234 | const gl::Caps &caps = context->getCaps(); |
| 1235 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1236 | gl::Texture *texture = NULL; |
| 1237 | GLenum textureInternalFormat = GL_NONE; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1238 | GLint textureLevelWidth = 0; |
| 1239 | GLint textureLevelHeight = 0; |
| 1240 | GLint textureLevelDepth = 0; |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1241 | GLuint maxDimension = 0; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1242 | |
| 1243 | switch (target) |
| 1244 | { |
| 1245 | case GL_TEXTURE_2D: |
| 1246 | { |
| 1247 | gl::Texture2D *texture2d = context->getTexture2D(); |
| 1248 | if (texture2d) |
| 1249 | { |
| 1250 | textureInternalFormat = texture2d->getInternalFormat(level); |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1251 | textureLevelWidth = texture2d->getWidth(level); |
| 1252 | textureLevelHeight = texture2d->getHeight(level); |
| 1253 | textureLevelDepth = 1; |
| 1254 | texture = texture2d; |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1255 | maxDimension = caps.max2DTextureSize; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1256 | } |
| 1257 | } |
| 1258 | break; |
| 1259 | |
| 1260 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 1261 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 1262 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 1263 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 1264 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 1265 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| 1266 | { |
| 1267 | gl::TextureCubeMap *textureCube = context->getTextureCubeMap(); |
| 1268 | if (textureCube) |
| 1269 | { |
| 1270 | textureInternalFormat = textureCube->getInternalFormat(target, level); |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1271 | textureLevelWidth = textureCube->getWidth(target, level); |
| 1272 | textureLevelHeight = textureCube->getHeight(target, level); |
| 1273 | textureLevelDepth = 1; |
| 1274 | texture = textureCube; |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1275 | maxDimension = caps.maxCubeMapTextureSize; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1276 | } |
| 1277 | } |
| 1278 | break; |
| 1279 | |
| 1280 | case GL_TEXTURE_2D_ARRAY: |
| 1281 | { |
| 1282 | gl::Texture2DArray *texture2dArray = context->getTexture2DArray(); |
| 1283 | if (texture2dArray) |
| 1284 | { |
| 1285 | textureInternalFormat = texture2dArray->getInternalFormat(level); |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1286 | textureLevelWidth = texture2dArray->getWidth(level); |
| 1287 | textureLevelHeight = texture2dArray->getHeight(level); |
| 1288 | textureLevelDepth = texture2dArray->getLayers(level); |
| 1289 | texture = texture2dArray; |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1290 | maxDimension = caps.max2DTextureSize; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1291 | } |
| 1292 | } |
| 1293 | break; |
| 1294 | |
| 1295 | case GL_TEXTURE_3D: |
| 1296 | { |
| 1297 | gl::Texture3D *texture3d = context->getTexture3D(); |
| 1298 | if (texture3d) |
| 1299 | { |
| 1300 | textureInternalFormat = texture3d->getInternalFormat(level); |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1301 | textureLevelWidth = texture3d->getWidth(level); |
| 1302 | textureLevelHeight = texture3d->getHeight(level); |
| 1303 | textureLevelDepth = texture3d->getDepth(level); |
| 1304 | texture = texture3d; |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1305 | maxDimension = caps.max3DTextureSize; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1306 | } |
| 1307 | } |
| 1308 | break; |
| 1309 | |
| 1310 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1311 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1312 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1313 | } |
| 1314 | |
| 1315 | if (!texture) |
| 1316 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1317 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1318 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1319 | } |
| 1320 | |
| 1321 | if (texture->isImmutable() && !isSubImage) |
| 1322 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1323 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1324 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1325 | } |
| 1326 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1327 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 1328 | |
| 1329 | if (formatInfo.depthBits > 0) |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1330 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1331 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1332 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1333 | } |
| 1334 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1335 | if (formatInfo.compressed) |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1336 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1337 | if (((width % formatInfo.compressedBlockWidth) != 0 && width != textureLevelWidth) || |
| 1338 | ((height % formatInfo.compressedBlockHeight) != 0 && height != textureLevelHeight)) |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1339 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1340 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1341 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1342 | } |
| 1343 | } |
| 1344 | |
| 1345 | if (isSubImage) |
| 1346 | { |
| 1347 | if (xoffset + width > textureLevelWidth || |
| 1348 | yoffset + height > textureLevelHeight || |
| 1349 | zoffset >= textureLevelDepth) |
| 1350 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1351 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1352 | return false; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1353 | } |
| 1354 | } |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 1355 | else |
| 1356 | { |
| 1357 | if (IsCubemapTextureTarget(target) && width != height) |
| 1358 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1359 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1360 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 1361 | } |
| 1362 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1363 | if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions())) |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 1364 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1365 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1366 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 1367 | } |
| 1368 | |
| 1369 | int maxLevelDimension = (maxDimension >> level); |
| 1370 | if (static_cast<int>(width) > maxLevelDimension || static_cast<int>(height) > maxLevelDimension) |
| 1371 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1372 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1373 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 1374 | } |
| 1375 | } |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 1376 | |
| 1377 | *textureFormatOut = textureInternalFormat; |
| 1378 | return true; |
| 1379 | } |
| 1380 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1381 | static bool ValidateDrawBase(Context *context, GLenum mode, GLsizei count, GLsizei maxVertex, GLsizei primcount) |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1382 | { |
Jamie Madill | 1aeb131 | 2014-06-20 13:21:25 -0400 | [diff] [blame] | 1383 | switch (mode) |
| 1384 | { |
| 1385 | case GL_POINTS: |
| 1386 | case GL_LINES: |
| 1387 | case GL_LINE_LOOP: |
| 1388 | case GL_LINE_STRIP: |
| 1389 | case GL_TRIANGLES: |
| 1390 | case GL_TRIANGLE_STRIP: |
| 1391 | case GL_TRIANGLE_FAN: |
| 1392 | break; |
| 1393 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1394 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1395 | return false; |
Jamie Madill | 1aeb131 | 2014-06-20 13:21:25 -0400 | [diff] [blame] | 1396 | } |
| 1397 | |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1398 | if (count < 0) |
| 1399 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1400 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1401 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1402 | } |
| 1403 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1404 | const State &state = context->getState(); |
| 1405 | |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1406 | // Check for mapped buffers |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1407 | if (state.hasMappedBuffer(GL_ARRAY_BUFFER)) |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1408 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1409 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1410 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1411 | } |
| 1412 | |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1413 | const gl::DepthStencilState &depthStencilState = state.getDepthStencilState(); |
Jamie Madill | ac52801 | 2014-06-20 13:21:23 -0400 | [diff] [blame] | 1414 | if (depthStencilState.stencilWritemask != depthStencilState.stencilBackWritemask || |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1415 | state.getStencilRef() != state.getStencilBackRef() || |
Jamie Madill | ac52801 | 2014-06-20 13:21:23 -0400 | [diff] [blame] | 1416 | depthStencilState.stencilMask != depthStencilState.stencilBackMask) |
| 1417 | { |
| 1418 | // Note: these separate values are not supported in WebGL, due to D3D's limitations. |
| 1419 | // See Section 6.10 of the WebGL 1.0 spec |
| 1420 | ERR("This ANGLE implementation does not support separate front/back stencil " |
| 1421 | "writemasks, reference values, or stencil mask values."); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1422 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1423 | return false; |
Jamie Madill | ac52801 | 2014-06-20 13:21:23 -0400 | [diff] [blame] | 1424 | } |
| 1425 | |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1426 | const gl::Framebuffer *fbo = state.getDrawFramebuffer(); |
Geoff Lang | 748f74e | 2014-12-01 11:25:34 -0500 | [diff] [blame] | 1427 | if (!fbo || fbo->checkStatus(context->getData()) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1428 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1429 | context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
| 1430 | return false; |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1431 | } |
| 1432 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1433 | gl::Program *program = state.getProgram(); |
| 1434 | if (!program) |
Jamie Madill | d4cfa57 | 2014-07-08 10:00:32 -0400 | [diff] [blame] | 1435 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1436 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1437 | return false; |
Jamie Madill | d4cfa57 | 2014-07-08 10:00:32 -0400 | [diff] [blame] | 1438 | } |
| 1439 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1440 | if (!program->validateSamplers(NULL, context->getCaps())) |
Jamie Madill | d4cfa57 | 2014-07-08 10:00:32 -0400 | [diff] [blame] | 1441 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1442 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1443 | return false; |
Jamie Madill | d4cfa57 | 2014-07-08 10:00:32 -0400 | [diff] [blame] | 1444 | } |
| 1445 | |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1446 | // Buffer validations |
| 1447 | const VertexArray *vao = state.getVertexArray(); |
| 1448 | for (int attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++) |
| 1449 | { |
| 1450 | const VertexAttribute &attrib = vao->getVertexAttribute(attributeIndex); |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1451 | bool attribActive = (program->getSemanticIndex(attributeIndex) != -1); |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1452 | if (attribActive && attrib.enabled) |
| 1453 | { |
| 1454 | gl::Buffer *buffer = attrib.buffer.get(); |
| 1455 | |
| 1456 | if (buffer) |
| 1457 | { |
| 1458 | GLint64 attribStride = static_cast<GLint64>(ComputeVertexAttributeStride(attrib)); |
| 1459 | GLint64 maxVertexElement = 0; |
| 1460 | |
| 1461 | if (attrib.divisor > 0) |
| 1462 | { |
| 1463 | maxVertexElement = static_cast<GLint64>(primcount) / static_cast<GLint64>(attrib.divisor); |
| 1464 | } |
| 1465 | else |
| 1466 | { |
| 1467 | maxVertexElement = static_cast<GLint64>(maxVertex); |
| 1468 | } |
| 1469 | |
| 1470 | GLint64 attribDataSize = maxVertexElement * attribStride; |
| 1471 | |
| 1472 | // [OpenGL ES 3.0.2] section 2.9.4 page 40: |
| 1473 | // We can return INVALID_OPERATION if our vertex attribute does not have |
| 1474 | // enough backing data. |
| 1475 | if (attribDataSize > buffer->getSize()) |
| 1476 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1477 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1478 | return false; |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1479 | } |
| 1480 | } |
| 1481 | else if (attrib.pointer == NULL) |
| 1482 | { |
| 1483 | // This is an application error that would normally result in a crash, |
| 1484 | // but we catch it and return an error |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1485 | context->recordError(Error(GL_INVALID_OPERATION, "An enabled vertex array has no buffer and no pointer.")); |
| 1486 | return false; |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1487 | } |
| 1488 | } |
| 1489 | } |
| 1490 | |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1491 | // No-op if zero count |
| 1492 | return (count > 0); |
| 1493 | } |
| 1494 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1495 | bool ValidateDrawArrays(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount) |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1496 | { |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1497 | if (first < 0) |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1498 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1499 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1500 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1501 | } |
| 1502 | |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1503 | const State &state = context->getState(); |
| 1504 | gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback(); |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1505 | if (curTransformFeedback && curTransformFeedback->isStarted() && !curTransformFeedback->isPaused() && |
| 1506 | curTransformFeedback->getDrawMode() != mode) |
| 1507 | { |
| 1508 | // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode |
| 1509 | // that does not match the current transform feedback object's draw mode (if transform feedback |
| 1510 | // is active), (3.0.2, section 2.14, pg 86) |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1511 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1512 | return false; |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1513 | } |
| 1514 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1515 | if (!ValidateDrawBase(context, mode, count, count, primcount)) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1516 | { |
| 1517 | return false; |
| 1518 | } |
| 1519 | |
| 1520 | return true; |
| 1521 | } |
| 1522 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1523 | bool ValidateDrawArraysInstanced(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1524 | { |
| 1525 | if (primcount < 0) |
| 1526 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1527 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1528 | return false; |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1529 | } |
| 1530 | |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1531 | if (!ValidateDrawArrays(context, mode, first, count, primcount)) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1532 | { |
| 1533 | return false; |
| 1534 | } |
| 1535 | |
| 1536 | // No-op if zero primitive count |
| 1537 | return (primcount > 0); |
| 1538 | } |
| 1539 | |
Geoff Lang | 87a9330 | 2014-09-16 13:29:43 -0400 | [diff] [blame] | 1540 | static bool ValidateDrawInstancedANGLE(Context *context) |
| 1541 | { |
| 1542 | // Verify there is at least one active attribute with a divisor of zero |
| 1543 | const gl::State& state = context->getState(); |
| 1544 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1545 | gl::Program *program = state.getProgram(); |
Geoff Lang | 87a9330 | 2014-09-16 13:29:43 -0400 | [diff] [blame] | 1546 | |
| 1547 | const VertexArray *vao = state.getVertexArray(); |
| 1548 | for (int attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++) |
| 1549 | { |
| 1550 | const VertexAttribute &attrib = vao->getVertexAttribute(attributeIndex); |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1551 | bool active = (program->getSemanticIndex(attributeIndex) != -1); |
Geoff Lang | 87a9330 | 2014-09-16 13:29:43 -0400 | [diff] [blame] | 1552 | if (active && attrib.divisor == 0) |
| 1553 | { |
| 1554 | return true; |
| 1555 | } |
| 1556 | } |
| 1557 | |
| 1558 | context->recordError(Error(GL_INVALID_OPERATION, "ANGLE_instanced_arrays requires that at least one active attribute" |
| 1559 | "has a divisor of zero.")); |
| 1560 | return false; |
| 1561 | } |
| 1562 | |
| 1563 | bool ValidateDrawArraysInstancedANGLE(Context *context, GLenum mode, GLint first, GLsizei count, GLsizei primcount) |
| 1564 | { |
| 1565 | if (!ValidateDrawInstancedANGLE(context)) |
| 1566 | { |
| 1567 | return false; |
| 1568 | } |
| 1569 | |
| 1570 | return ValidateDrawArraysInstanced(context, mode, first, count, primcount); |
| 1571 | } |
| 1572 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1573 | bool ValidateDrawElements(Context *context, GLenum mode, GLsizei count, GLenum type, |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1574 | const GLvoid* indices, GLsizei primcount, rx::RangeUI *indexRangeOut) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1575 | { |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1576 | switch (type) |
| 1577 | { |
| 1578 | case GL_UNSIGNED_BYTE: |
| 1579 | case GL_UNSIGNED_SHORT: |
| 1580 | break; |
| 1581 | case GL_UNSIGNED_INT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 1582 | if (!context->getExtensions().elementIndexUint) |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1583 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1584 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1585 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1586 | } |
| 1587 | break; |
| 1588 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1589 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1590 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1591 | } |
| 1592 | |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1593 | const State &state = context->getState(); |
| 1594 | |
| 1595 | gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback(); |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1596 | if (curTransformFeedback && curTransformFeedback->isStarted() && !curTransformFeedback->isPaused()) |
| 1597 | { |
| 1598 | // It is an invalid operation to call DrawElements, DrawRangeElements or DrawElementsInstanced |
| 1599 | // while transform feedback is active, (3.0.2, section 2.14, pg 86) |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1600 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1601 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1602 | } |
| 1603 | |
| 1604 | // Check for mapped buffers |
Jamie Madill | d9ba4f7 | 2014-08-04 10:47:59 -0400 | [diff] [blame] | 1605 | if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER)) |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1606 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1607 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1608 | return false; |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1609 | } |
| 1610 | |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1611 | const gl::VertexArray *vao = state.getVertexArray(); |
| 1612 | const gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer(); |
| 1613 | if (!indices && !elementArrayBuffer) |
Jamie Madill | d4cfa57 | 2014-07-08 10:00:32 -0400 | [diff] [blame] | 1614 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1615 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1616 | return false; |
Jamie Madill | d4cfa57 | 2014-07-08 10:00:32 -0400 | [diff] [blame] | 1617 | } |
| 1618 | |
Jamie Madill | ae3000b | 2014-08-25 15:47:51 -0400 | [diff] [blame] | 1619 | if (elementArrayBuffer) |
| 1620 | { |
| 1621 | const gl::Type &typeInfo = gl::GetTypeInfo(type); |
| 1622 | |
| 1623 | GLint64 offset = reinterpret_cast<GLint64>(indices); |
| 1624 | GLint64 byteCount = static_cast<GLint64>(typeInfo.bytes) * static_cast<GLint64>(count)+offset; |
| 1625 | |
| 1626 | // check for integer overflows |
| 1627 | if (static_cast<GLuint>(count) > (std::numeric_limits<GLuint>::max() / typeInfo.bytes) || |
| 1628 | byteCount > static_cast<GLint64>(std::numeric_limits<GLuint>::max())) |
| 1629 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1630 | context->recordError(Error(GL_OUT_OF_MEMORY)); |
| 1631 | return false; |
Jamie Madill | ae3000b | 2014-08-25 15:47:51 -0400 | [diff] [blame] | 1632 | } |
| 1633 | |
| 1634 | // Check for reading past the end of the bound buffer object |
| 1635 | if (byteCount > elementArrayBuffer->getSize()) |
| 1636 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1637 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1638 | return false; |
Jamie Madill | ae3000b | 2014-08-25 15:47:51 -0400 | [diff] [blame] | 1639 | } |
| 1640 | } |
| 1641 | else if (!indices) |
| 1642 | { |
| 1643 | // Catch this programming error here |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1644 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1645 | return false; |
Jamie Madill | ae3000b | 2014-08-25 15:47:51 -0400 | [diff] [blame] | 1646 | } |
| 1647 | |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1648 | // Use max index to validate if our vertex buffers are large enough for the pull. |
| 1649 | // TODO: offer fast path, with disabled index validation. |
| 1650 | // TODO: also disable index checking on back-ends that are robust to out-of-range accesses. |
| 1651 | if (elementArrayBuffer) |
| 1652 | { |
Jacek Caban | a5521de | 2014-10-01 17:23:46 +0200 | [diff] [blame] | 1653 | uintptr_t offset = reinterpret_cast<uintptr_t>(indices); |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1654 | if (!elementArrayBuffer->getIndexRangeCache()->findRange(type, offset, count, indexRangeOut, NULL)) |
| 1655 | { |
Jamie Madill | 9ae396b | 2014-10-21 17:46:30 -0400 | [diff] [blame] | 1656 | // FIXME(jmadill): Use buffer data caching instead of the D3D back-end |
| 1657 | rx::BufferD3D *bufferD3D = rx::BufferD3D::makeBufferD3D(elementArrayBuffer->getImplementation()); |
Geoff Lang | c8d297a | 2014-09-19 11:09:08 -0400 | [diff] [blame] | 1658 | const uint8_t *dataPointer = NULL; |
Jamie Madill | 9ae396b | 2014-10-21 17:46:30 -0400 | [diff] [blame] | 1659 | Error error = bufferD3D->getData(&dataPointer); |
Geoff Lang | c8d297a | 2014-09-19 11:09:08 -0400 | [diff] [blame] | 1660 | if (error.isError()) |
| 1661 | { |
| 1662 | context->recordError(error); |
| 1663 | return false; |
| 1664 | } |
| 1665 | |
| 1666 | const uint8_t *offsetPointer = dataPointer + offset; |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1667 | *indexRangeOut = rx::IndexRangeCache::ComputeRange(type, offsetPointer, count); |
| 1668 | } |
| 1669 | } |
| 1670 | else |
| 1671 | { |
| 1672 | *indexRangeOut = rx::IndexRangeCache::ComputeRange(type, indices, count); |
| 1673 | } |
| 1674 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1675 | if (!ValidateDrawBase(context, mode, count, static_cast<GLsizei>(indexRangeOut->end), primcount)) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1676 | { |
| 1677 | return false; |
| 1678 | } |
| 1679 | |
| 1680 | return true; |
| 1681 | } |
| 1682 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1683 | bool ValidateDrawElementsInstanced(Context *context, |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1684 | GLenum mode, GLsizei count, GLenum type, |
| 1685 | const GLvoid *indices, GLsizei primcount, |
| 1686 | rx::RangeUI *indexRangeOut) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1687 | { |
| 1688 | if (primcount < 0) |
| 1689 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1690 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1691 | return false; |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1692 | } |
| 1693 | |
Jamie Madill | 2b97681 | 2014-08-25 15:47:49 -0400 | [diff] [blame] | 1694 | if (!ValidateDrawElements(context, mode, count, type, indices, primcount, indexRangeOut)) |
Jamie Madill | fd71658 | 2014-06-06 17:09:04 -0400 | [diff] [blame] | 1695 | { |
| 1696 | return false; |
| 1697 | } |
| 1698 | |
| 1699 | // No-op zero primitive count |
| 1700 | return (primcount > 0); |
Jamie Madill | 250d33f | 2014-06-06 17:09:03 -0400 | [diff] [blame] | 1701 | } |
| 1702 | |
Geoff Lang | 87a9330 | 2014-09-16 13:29:43 -0400 | [diff] [blame] | 1703 | bool ValidateDrawElementsInstancedANGLE(Context *context, GLenum mode, GLsizei count, GLenum type, |
| 1704 | const GLvoid *indices, GLsizei primcount, rx::RangeUI *indexRangeOut) |
| 1705 | { |
| 1706 | if (!ValidateDrawInstancedANGLE(context)) |
| 1707 | { |
| 1708 | return false; |
| 1709 | } |
| 1710 | |
| 1711 | return ValidateDrawElementsInstanced(context, mode, count, type, indices, primcount, indexRangeOut); |
| 1712 | } |
| 1713 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1714 | bool ValidateFramebufferTextureBase(Context *context, GLenum target, GLenum attachment, |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1715 | GLuint texture, GLint level) |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1716 | { |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1717 | if (!ValidFramebufferTarget(target)) |
| 1718 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1719 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1720 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1721 | } |
| 1722 | |
| 1723 | if (!ValidateAttachmentTarget(context, attachment)) |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1724 | { |
| 1725 | return false; |
| 1726 | } |
| 1727 | |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1728 | if (texture != 0) |
| 1729 | { |
| 1730 | gl::Texture *tex = context->getTexture(texture); |
| 1731 | |
| 1732 | if (tex == NULL) |
| 1733 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1734 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1735 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1736 | } |
| 1737 | |
| 1738 | if (level < 0) |
| 1739 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1740 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1741 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1742 | } |
| 1743 | } |
| 1744 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 1745 | const gl::Framebuffer *framebuffer = context->getState().getTargetFramebuffer(target); |
| 1746 | GLuint framebufferHandle = context->getState().getTargetFramebuffer(target)->id(); |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1747 | |
| 1748 | if (framebufferHandle == 0 || !framebuffer) |
| 1749 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1750 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1751 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1752 | } |
| 1753 | |
| 1754 | return true; |
| 1755 | } |
| 1756 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1757 | bool ValidateFramebufferTexture2D(Context *context, GLenum target, GLenum attachment, |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1758 | GLenum textarget, GLuint texture, GLint level) |
| 1759 | { |
| 1760 | // Attachments are required to be bound to level 0 in ES2 |
| 1761 | if (context->getClientVersion() < 3 && level != 0) |
| 1762 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1763 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1764 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1765 | } |
| 1766 | |
| 1767 | if (!ValidateFramebufferTextureBase(context, target, attachment, texture, level)) |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1768 | { |
| 1769 | return false; |
| 1770 | } |
| 1771 | |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1772 | if (texture != 0) |
| 1773 | { |
| 1774 | gl::Texture *tex = context->getTexture(texture); |
| 1775 | ASSERT(tex); |
| 1776 | |
Jamie Madill | 2a6564e | 2014-07-11 09:53:19 -0400 | [diff] [blame] | 1777 | const gl::Caps &caps = context->getCaps(); |
| 1778 | |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1779 | switch (textarget) |
| 1780 | { |
| 1781 | case GL_TEXTURE_2D: |
| 1782 | { |
Jamie Madill | 2a6564e | 2014-07-11 09:53:19 -0400 | [diff] [blame] | 1783 | if (level > gl::log2(caps.max2DTextureSize)) |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1784 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1785 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1786 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1787 | } |
| 1788 | if (tex->getTarget() != GL_TEXTURE_2D) |
| 1789 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1790 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1791 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1792 | } |
| 1793 | gl::Texture2D *tex2d = static_cast<gl::Texture2D *>(tex); |
| 1794 | if (tex2d->isCompressed(level)) |
| 1795 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1796 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1797 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1798 | } |
| 1799 | } |
| 1800 | break; |
| 1801 | |
| 1802 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 1803 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 1804 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 1805 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 1806 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 1807 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| 1808 | { |
Jamie Madill | 2a6564e | 2014-07-11 09:53:19 -0400 | [diff] [blame] | 1809 | if (level > gl::log2(caps.maxCubeMapTextureSize)) |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1810 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1811 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1812 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1813 | } |
| 1814 | if (tex->getTarget() != GL_TEXTURE_CUBE_MAP) |
| 1815 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1816 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1817 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1818 | } |
| 1819 | gl::TextureCubeMap *texcube = static_cast<gl::TextureCubeMap *>(tex); |
| 1820 | if (texcube->isCompressed(textarget, level)) |
| 1821 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1822 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1823 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1824 | } |
| 1825 | } |
| 1826 | break; |
| 1827 | |
| 1828 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1829 | context->recordError(Error(GL_INVALID_ENUM)); |
| 1830 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1831 | } |
| 1832 | } |
| 1833 | |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1834 | return true; |
| 1835 | } |
| 1836 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1837 | bool ValidateGetUniformBase(Context *context, GLuint program, GLint location) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1838 | { |
| 1839 | if (program == 0) |
| 1840 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1841 | context->recordError(Error(GL_INVALID_VALUE)); |
| 1842 | return false; |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1843 | } |
| 1844 | |
Shannon Woods | 4de4fd6 | 2014-11-07 16:22:02 -0500 | [diff] [blame] | 1845 | if (!ValidProgram(context, program)) |
| 1846 | { |
| 1847 | return false; |
| 1848 | } |
| 1849 | |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1850 | gl::Program *programObject = context->getProgram(program); |
| 1851 | |
| 1852 | if (!programObject || !programObject->isLinked()) |
| 1853 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1854 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1855 | return false; |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1856 | } |
| 1857 | |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1858 | if (!programObject->isValidUniformLocation(location)) |
Jamie Madill | 549c7fd | 2014-08-25 15:47:56 -0400 | [diff] [blame] | 1859 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1860 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1861 | return false; |
Jamie Madill | 549c7fd | 2014-08-25 15:47:56 -0400 | [diff] [blame] | 1862 | } |
| 1863 | |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1864 | return true; |
| 1865 | } |
| 1866 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1867 | bool ValidateGetUniformfv(Context *context, GLuint program, GLint location, GLfloat* params) |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1868 | { |
| 1869 | return ValidateGetUniformBase(context, program, location); |
| 1870 | } |
| 1871 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1872 | bool ValidateGetUniformiv(Context *context, GLuint program, GLint location, GLint* params) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1873 | { |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1874 | return ValidateGetUniformBase(context, program, location); |
| 1875 | } |
| 1876 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1877 | static bool ValidateSizedGetUniform(Context *context, GLuint program, GLint location, GLsizei bufSize) |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1878 | { |
| 1879 | if (!ValidateGetUniformBase(context, program, location)) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1880 | { |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1881 | return false; |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1882 | } |
| 1883 | |
Jamie Madill | a502c74 | 2014-08-28 17:19:13 -0400 | [diff] [blame] | 1884 | gl::Program *programObject = context->getProgram(program); |
| 1885 | ASSERT(programObject); |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1886 | |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1887 | // sized queries -- ensure the provided buffer is large enough |
Geoff Lang | 7dd2e10 | 2014-11-10 15:19:26 -0500 | [diff] [blame] | 1888 | LinkedUniform *uniform = programObject->getUniformByLocation(location); |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1889 | size_t requiredBytes = VariableExternalSize(uniform->type); |
| 1890 | if (static_cast<size_t>(bufSize) < requiredBytes) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1891 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1892 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 1893 | return false; |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1894 | } |
| 1895 | |
| 1896 | return true; |
| 1897 | } |
| 1898 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1899 | bool ValidateGetnUniformfvEXT(Context *context, GLuint program, GLint location, GLsizei bufSize, GLfloat* params) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1900 | { |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1901 | return ValidateSizedGetUniform(context, program, location, bufSize); |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1902 | } |
| 1903 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1904 | bool ValidateGetnUniformivEXT(Context *context, GLuint program, GLint location, GLsizei bufSize, GLint* params) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1905 | { |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1906 | return ValidateSizedGetUniform(context, program, location, bufSize); |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1907 | } |
| 1908 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1909 | } |