daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 12 | #include "common/mathutil.h" |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 13 | #include "compiler/preprocessor/SourceLocation.h" |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 14 | #include "compiler/translator/Declarator.h" |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 15 | #include "compiler/translator/ParseContext_autogen.h" |
Kai Ninomiya | 614dd0f | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 16 | #include "compiler/translator/StaticType.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 17 | #include "compiler/translator/ValidateGlobalInitializer.h" |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 18 | #include "compiler/translator/ValidateSwitch.h" |
| 19 | #include "compiler/translator/glslang.h" |
Olli Etuaho | c26214d | 2018-03-16 10:43:11 +0200 | [diff] [blame] | 20 | #include "compiler/translator/tree_util/IntermNode_util.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 21 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 22 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 23 | namespace sh |
| 24 | { |
| 25 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 26 | /////////////////////////////////////////////////////////////////////// |
| 27 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 28 | // Sub- vector and matrix fields |
| 29 | // |
| 30 | //////////////////////////////////////////////////////////////////////// |
| 31 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 32 | namespace |
| 33 | { |
| 34 | |
| 35 | const int kWebGLMaxStructNesting = 4; |
| 36 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 37 | bool ContainsSampler(const TStructure *structType); |
| 38 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 39 | bool ContainsSampler(const TType &type) |
| 40 | { |
| 41 | if (IsSampler(type.getBasicType())) |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 42 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 43 | return true; |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 44 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 45 | if (type.getBasicType() == EbtStruct) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 46 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 47 | return ContainsSampler(type.getStruct()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 48 | } |
| 49 | |
| 50 | return false; |
| 51 | } |
| 52 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 53 | bool ContainsSampler(const TStructure *structType) |
| 54 | { |
| 55 | for (const auto &field : structType->fields()) |
| 56 | { |
| 57 | if (ContainsSampler(*field->type())) |
| 58 | return true; |
| 59 | } |
| 60 | return false; |
| 61 | } |
| 62 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 63 | // Get a token from an image argument to use as an error message token. |
| 64 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 65 | { |
| 66 | ASSERT(IsImage(imageNode->getBasicType())); |
| 67 | while (imageNode->getAsBinaryNode() && |
| 68 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 69 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 70 | { |
| 71 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 72 | } |
| 73 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 74 | if (imageSymbol) |
| 75 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 76 | return imageSymbol->getName().data(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 77 | } |
| 78 | return "image"; |
| 79 | } |
| 80 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 81 | bool CanSetDefaultPrecisionOnType(const TPublicType &type) |
| 82 | { |
| 83 | if (!SupportsPrecision(type.getBasicType())) |
| 84 | { |
| 85 | return false; |
| 86 | } |
| 87 | if (type.getBasicType() == EbtUInt) |
| 88 | { |
| 89 | // ESSL 3.00.4 section 4.5.4 |
| 90 | return false; |
| 91 | } |
| 92 | if (type.isAggregate()) |
| 93 | { |
| 94 | // Not allowed to set for aggregate types |
| 95 | return false; |
| 96 | } |
| 97 | return true; |
| 98 | } |
| 99 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 100 | // Map input primitive types to input array sizes in a geometry shader. |
| 101 | GLuint GetGeometryShaderInputArraySize(TLayoutPrimitiveType primitiveType) |
| 102 | { |
| 103 | switch (primitiveType) |
| 104 | { |
| 105 | case EptPoints: |
| 106 | return 1u; |
| 107 | case EptLines: |
| 108 | return 2u; |
| 109 | case EptTriangles: |
| 110 | return 3u; |
| 111 | case EptLinesAdjacency: |
| 112 | return 4u; |
| 113 | case EptTrianglesAdjacency: |
| 114 | return 6u; |
| 115 | default: |
| 116 | UNREACHABLE(); |
| 117 | return 0u; |
| 118 | } |
| 119 | } |
| 120 | |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 121 | bool IsBufferOrSharedVariable(TIntermTyped *var) |
| 122 | { |
| 123 | if (var->isInterfaceBlock() || var->getQualifier() == EvqBuffer || |
| 124 | var->getQualifier() == EvqShared) |
| 125 | { |
| 126 | return true; |
| 127 | } |
| 128 | return false; |
| 129 | } |
| 130 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 131 | } // namespace |
| 132 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 133 | // This tracks each binding point's current default offset for inheritance of subsequent |
| 134 | // variables using the same binding, and keeps offsets unique and non overlapping. |
| 135 | // See GLSL ES 3.1, section 4.4.6. |
| 136 | class TParseContext::AtomicCounterBindingState |
| 137 | { |
| 138 | public: |
| 139 | AtomicCounterBindingState() : mDefaultOffset(0) {} |
| 140 | // Inserts a new span and returns -1 if overlapping, else returns the starting offset of |
| 141 | // newly inserted span. |
| 142 | int insertSpan(int start, size_t length) |
| 143 | { |
| 144 | gl::RangeI newSpan(start, start + static_cast<int>(length)); |
| 145 | for (const auto &span : mSpans) |
| 146 | { |
| 147 | if (newSpan.intersects(span)) |
| 148 | { |
| 149 | return -1; |
| 150 | } |
| 151 | } |
| 152 | mSpans.push_back(newSpan); |
| 153 | mDefaultOffset = newSpan.high(); |
| 154 | return start; |
| 155 | } |
| 156 | // Inserts a new span starting from the default offset. |
| 157 | int appendSpan(size_t length) { return insertSpan(mDefaultOffset, length); } |
| 158 | void setDefaultOffset(int offset) { mDefaultOffset = offset; } |
| 159 | |
| 160 | private: |
| 161 | int mDefaultOffset; |
| 162 | std::vector<gl::RangeI> mSpans; |
| 163 | }; |
| 164 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 165 | TParseContext::TParseContext(TSymbolTable &symt, |
| 166 | TExtensionBehavior &ext, |
| 167 | sh::GLenum type, |
| 168 | ShShaderSpec spec, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 169 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 170 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 171 | const ShBuiltInResources &resources) |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 172 | : symbolTable(symt), |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 173 | mDeferredNonEmptyDeclarationErrorCheck(false), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 174 | mShaderType(type), |
| 175 | mShaderSpec(spec), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 176 | mShaderVersion(100), |
| 177 | mTreeRoot(nullptr), |
| 178 | mLoopNestingLevel(0), |
| 179 | mStructNestingLevel(0), |
| 180 | mSwitchNestingLevel(0), |
| 181 | mCurrentFunctionType(nullptr), |
| 182 | mFunctionReturnsValue(false), |
| 183 | mChecksPrecisionErrors(checksPrecErrors), |
| 184 | mFragmentPrecisionHighOnESSL1(false), |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 185 | mDefaultUniformMatrixPacking(EmpColumnMajor), |
| 186 | mDefaultUniformBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
| 187 | mDefaultBufferMatrixPacking(EmpColumnMajor), |
| 188 | mDefaultBufferBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 189 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 190 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 191 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 192 | mShaderVersion, |
| 193 | mShaderType, |
| 194 | resources.WEBGL_debug_shader_precision == 1), |
Jamie Madill | c3bef3e | 2018-10-03 07:35:09 -0400 | [diff] [blame] | 195 | mPreprocessor(mDiagnostics, &mDirectiveHandler, angle::pp::PreprocessorSettings(spec)), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 196 | mScanner(nullptr), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 197 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 198 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 199 | mMinProgramTextureGatherOffset(resources.MinProgramTextureGatherOffset), |
| 200 | mMaxProgramTextureGatherOffset(resources.MaxProgramTextureGatherOffset), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 201 | mComputeShaderLocalSizeDeclared(false), |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 202 | mComputeShaderLocalSize(-1), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 203 | mNumViews(-1), |
| 204 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 205 | mMaxImageUnits(resources.MaxImageUnits), |
| 206 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 207 | mMaxUniformLocations(resources.MaxUniformLocations), |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 208 | mMaxUniformBufferBindings(resources.MaxUniformBufferBindings), |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 209 | mMaxAtomicCounterBindings(resources.MaxAtomicCounterBindings), |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 210 | mMaxShaderStorageBufferBindings(resources.MaxShaderStorageBufferBindings), |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 211 | mDeclaringFunction(false), |
| 212 | mGeometryShaderInputPrimitiveType(EptUndefined), |
| 213 | mGeometryShaderOutputPrimitiveType(EptUndefined), |
| 214 | mGeometryShaderInvocations(0), |
| 215 | mGeometryShaderMaxVertices(-1), |
| 216 | mMaxGeometryShaderInvocations(resources.MaxGeometryShaderInvocations), |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 217 | mMaxGeometryShaderMaxVertices(resources.MaxGeometryOutputVertices) |
Jamie Madill | b980c56 | 2018-11-27 11:34:27 -0500 | [diff] [blame] | 218 | {} |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 219 | |
Jamie Madill | b980c56 | 2018-11-27 11:34:27 -0500 | [diff] [blame] | 220 | TParseContext::~TParseContext() {} |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 221 | |
Mingyu Hu | ebab670 | 2019-04-19 14:36:45 -0700 | [diff] [blame^] | 222 | bool TParseContext::anyMultiviewExtensionAvailable() |
| 223 | { |
| 224 | return isExtensionEnabled(TExtension::OVR_multiview) || |
| 225 | isExtensionEnabled(TExtension::OVR_multiview2); |
| 226 | } |
| 227 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 228 | bool TParseContext::parseVectorFields(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 229 | const ImmutableString &compString, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 230 | int vecSize, |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 231 | TVector<int> *fieldOffsets) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 232 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 233 | ASSERT(fieldOffsets); |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 234 | size_t fieldCount = compString.length(); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 235 | if (fieldCount > 4u) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 236 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 237 | error(line, "illegal vector field selection", compString); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 238 | return false; |
| 239 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 240 | fieldOffsets->resize(fieldCount); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 241 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 242 | enum |
| 243 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 244 | exyzw, |
| 245 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 246 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 247 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 248 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 249 | for (unsigned int i = 0u; i < fieldOffsets->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 250 | { |
| 251 | switch (compString[i]) |
| 252 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 253 | case 'x': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 254 | (*fieldOffsets)[i] = 0; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 255 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 256 | break; |
| 257 | case 'r': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 258 | (*fieldOffsets)[i] = 0; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 259 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 260 | break; |
| 261 | case 's': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 262 | (*fieldOffsets)[i] = 0; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 263 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 264 | break; |
| 265 | case 'y': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 266 | (*fieldOffsets)[i] = 1; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 267 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 268 | break; |
| 269 | case 'g': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 270 | (*fieldOffsets)[i] = 1; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 271 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 272 | break; |
| 273 | case 't': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 274 | (*fieldOffsets)[i] = 1; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 275 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 276 | break; |
| 277 | case 'z': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 278 | (*fieldOffsets)[i] = 2; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 279 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 280 | break; |
| 281 | case 'b': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 282 | (*fieldOffsets)[i] = 2; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 283 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 284 | break; |
| 285 | case 'p': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 286 | (*fieldOffsets)[i] = 2; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 287 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 288 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 289 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 290 | case 'w': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 291 | (*fieldOffsets)[i] = 3; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 292 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 293 | break; |
| 294 | case 'a': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 295 | (*fieldOffsets)[i] = 3; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 296 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 297 | break; |
| 298 | case 'q': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 299 | (*fieldOffsets)[i] = 3; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 300 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 301 | break; |
| 302 | default: |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 303 | error(line, "illegal vector field selection", compString); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 304 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 305 | } |
| 306 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 307 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 308 | for (unsigned int i = 0u; i < fieldOffsets->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 309 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 310 | if ((*fieldOffsets)[i] >= vecSize) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 311 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 312 | error(line, "vector field selection out of range", compString); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 313 | return false; |
| 314 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 315 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 316 | if (i > 0) |
| 317 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 318 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 319 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 320 | error(line, "illegal - vector component fields not from the same set", compString); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 321 | return false; |
| 322 | } |
| 323 | } |
| 324 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 325 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 326 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 327 | } |
| 328 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 329 | /////////////////////////////////////////////////////////////////////// |
| 330 | // |
| 331 | // Errors |
| 332 | // |
| 333 | //////////////////////////////////////////////////////////////////////// |
| 334 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 335 | // |
| 336 | // Used by flex/bison to output all syntax and parsing errors. |
| 337 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 338 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 339 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 340 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 341 | } |
| 342 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 343 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const ImmutableString &token) |
| 344 | { |
| 345 | mDiagnostics->error(loc, reason, token.data()); |
| 346 | } |
| 347 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 348 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 349 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 350 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 351 | } |
| 352 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 353 | void TParseContext::outOfRangeError(bool isError, |
| 354 | const TSourceLoc &loc, |
| 355 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 356 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 357 | { |
| 358 | if (isError) |
| 359 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 360 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 361 | } |
| 362 | else |
| 363 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 364 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 365 | } |
| 366 | } |
| 367 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 368 | // |
| 369 | // Same error message for all places assignments don't work. |
| 370 | // |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 371 | void TParseContext::assignError(const TSourceLoc &line, |
| 372 | const char *op, |
| 373 | const TType &left, |
| 374 | const TType &right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 375 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 376 | TInfoSinkBase reasonStream; |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 377 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 378 | error(line, reasonStream.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 379 | } |
| 380 | |
| 381 | // |
| 382 | // Same error message for all places unary operations don't work. |
| 383 | // |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 384 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, const TType &operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 385 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 386 | TInfoSinkBase reasonStream; |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 387 | reasonStream << "wrong operand type - no operation '" << op |
| 388 | << "' exists that takes an operand of type " << operand |
| 389 | << " (or there is no acceptable conversion)"; |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 390 | error(line, reasonStream.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 391 | } |
| 392 | |
| 393 | // |
| 394 | // Same error message for all binary operations don't work. |
| 395 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 396 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 397 | const char *op, |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 398 | const TType &left, |
| 399 | const TType &right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 400 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 401 | TInfoSinkBase reasonStream; |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 402 | reasonStream << "wrong operand types - no operation '" << op |
| 403 | << "' exists that takes a left-hand operand of type '" << left |
| 404 | << "' and a right operand of type '" << right |
| 405 | << "' (or there is no acceptable conversion)"; |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 406 | error(line, reasonStream.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 407 | } |
| 408 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 409 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 410 | TPrecision precision, |
| 411 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 412 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 413 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 414 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 415 | |
| 416 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 417 | { |
| 418 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 419 | } |
| 420 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 421 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 422 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 423 | switch (type) |
| 424 | { |
| 425 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 426 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 427 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 428 | case EbtInt: |
| 429 | case EbtUInt: |
| 430 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 431 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 432 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 433 | default: |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 434 | if (IsOpaqueType(type)) |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 435 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 436 | error(line, "No precision specified", getBasicString(type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 437 | return; |
| 438 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 439 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 440 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 441 | } |
| 442 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 443 | void TParseContext::markStaticReadIfSymbol(TIntermNode *node) |
| 444 | { |
| 445 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 446 | if (swizzleNode) |
| 447 | { |
| 448 | markStaticReadIfSymbol(swizzleNode->getOperand()); |
| 449 | return; |
| 450 | } |
| 451 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
| 452 | if (binaryNode) |
| 453 | { |
| 454 | switch (binaryNode->getOp()) |
| 455 | { |
| 456 | case EOpIndexDirect: |
| 457 | case EOpIndexIndirect: |
| 458 | case EOpIndexDirectStruct: |
| 459 | case EOpIndexDirectInterfaceBlock: |
| 460 | markStaticReadIfSymbol(binaryNode->getLeft()); |
| 461 | return; |
| 462 | default: |
| 463 | return; |
| 464 | } |
| 465 | } |
| 466 | TIntermSymbol *symbolNode = node->getAsSymbolNode(); |
| 467 | if (symbolNode) |
| 468 | { |
| 469 | symbolTable.markStaticRead(symbolNode->variable()); |
| 470 | } |
| 471 | } |
| 472 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 473 | // Both test and if necessary, spit out an error, to see if the node is really |
| 474 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 475 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 476 | { |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 477 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 478 | if (swizzleNode) |
| 479 | { |
| 480 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 481 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 482 | { |
| 483 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 484 | return false; |
| 485 | } |
| 486 | return ok; |
| 487 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 488 | |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 489 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 490 | if (binaryNode) |
| 491 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 492 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 493 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 494 | case EOpIndexDirect: |
| 495 | case EOpIndexIndirect: |
| 496 | case EOpIndexDirectStruct: |
| 497 | case EOpIndexDirectInterfaceBlock: |
Qin Jiajia | 76bf01d | 2018-02-22 14:11:34 +0800 | [diff] [blame] | 498 | if (node->getMemoryQualifier().readonly) |
| 499 | { |
| 500 | error(line, "can't modify a readonly variable", op); |
| 501 | return false; |
| 502 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 503 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 504 | default: |
| 505 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 506 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 507 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 508 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 509 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 510 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 511 | std::string message; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 512 | switch (node->getQualifier()) |
| 513 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 514 | case EvqConst: |
| 515 | message = "can't modify a const"; |
| 516 | break; |
| 517 | case EvqConstReadOnly: |
| 518 | message = "can't modify a const"; |
| 519 | break; |
| 520 | case EvqAttribute: |
| 521 | message = "can't modify an attribute"; |
| 522 | break; |
| 523 | case EvqFragmentIn: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 524 | case EvqVertexIn: |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 525 | case EvqGeometryIn: |
Jiawei Shao | e8ef2bc | 2017-08-29 13:38:57 +0800 | [diff] [blame] | 526 | case EvqFlatIn: |
| 527 | case EvqSmoothIn: |
| 528 | case EvqCentroidIn: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 529 | message = "can't modify an input"; |
| 530 | break; |
| 531 | case EvqUniform: |
| 532 | message = "can't modify a uniform"; |
| 533 | break; |
| 534 | case EvqVaryingIn: |
| 535 | message = "can't modify a varying"; |
| 536 | break; |
| 537 | case EvqFragCoord: |
| 538 | message = "can't modify gl_FragCoord"; |
| 539 | break; |
| 540 | case EvqFrontFacing: |
| 541 | message = "can't modify gl_FrontFacing"; |
| 542 | break; |
| 543 | case EvqPointCoord: |
| 544 | message = "can't modify gl_PointCoord"; |
| 545 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 546 | case EvqNumWorkGroups: |
| 547 | message = "can't modify gl_NumWorkGroups"; |
| 548 | break; |
| 549 | case EvqWorkGroupSize: |
| 550 | message = "can't modify gl_WorkGroupSize"; |
| 551 | break; |
| 552 | case EvqWorkGroupID: |
| 553 | message = "can't modify gl_WorkGroupID"; |
| 554 | break; |
| 555 | case EvqLocalInvocationID: |
| 556 | message = "can't modify gl_LocalInvocationID"; |
| 557 | break; |
| 558 | case EvqGlobalInvocationID: |
| 559 | message = "can't modify gl_GlobalInvocationID"; |
| 560 | break; |
| 561 | case EvqLocalInvocationIndex: |
| 562 | message = "can't modify gl_LocalInvocationIndex"; |
| 563 | break; |
Olli Etuaho | 7142f6c | 2017-05-05 17:07:26 +0300 | [diff] [blame] | 564 | case EvqViewIDOVR: |
| 565 | message = "can't modify gl_ViewID_OVR"; |
| 566 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 567 | case EvqComputeIn: |
| 568 | message = "can't modify work group size variable"; |
| 569 | break; |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 570 | case EvqPerVertexIn: |
| 571 | message = "can't modify any member in gl_in"; |
| 572 | break; |
Jiawei Shao | d27f5c8 | 2017-08-23 09:38:08 +0800 | [diff] [blame] | 573 | case EvqPrimitiveIDIn: |
| 574 | message = "can't modify gl_PrimitiveIDIn"; |
| 575 | break; |
| 576 | case EvqInvocationID: |
| 577 | message = "can't modify gl_InvocationID"; |
| 578 | break; |
| 579 | case EvqPrimitiveID: |
| 580 | if (mShaderType == GL_FRAGMENT_SHADER) |
| 581 | { |
| 582 | message = "can't modify gl_PrimitiveID in a fragment shader"; |
| 583 | } |
| 584 | break; |
| 585 | case EvqLayer: |
| 586 | if (mShaderType == GL_FRAGMENT_SHADER) |
| 587 | { |
| 588 | message = "can't modify gl_Layer in a fragment shader"; |
| 589 | } |
| 590 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 591 | default: |
| 592 | // |
| 593 | // Type that can't be written to? |
| 594 | // |
| 595 | if (node->getBasicType() == EbtVoid) |
| 596 | { |
| 597 | message = "can't modify void"; |
| 598 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 599 | if (IsOpaqueType(node->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 600 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 601 | message = "can't modify a variable with type "; |
| 602 | message += getBasicString(node->getBasicType()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 603 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 604 | else if (node->getMemoryQualifier().readonly) |
| 605 | { |
| 606 | message = "can't modify a readonly variable"; |
| 607 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 608 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 609 | |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 610 | ASSERT(binaryNode == nullptr && swizzleNode == nullptr); |
| 611 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 612 | if (message.empty() && symNode != nullptr) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 613 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 614 | symbolTable.markStaticWrite(symNode->variable()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 615 | return true; |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 616 | } |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 617 | |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 618 | std::stringstream reasonStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 619 | reasonStream << "l-value required"; |
| 620 | if (!message.empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 621 | { |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 622 | if (symNode) |
| 623 | { |
| 624 | // Symbol inside an expression can't be nameless. |
| 625 | ASSERT(symNode->variable().symbolType() != SymbolType::Empty); |
| 626 | const ImmutableString &symbol = symNode->getName(); |
| 627 | reasonStream << " (" << message << " \"" << symbol << "\")"; |
| 628 | } |
| 629 | else |
| 630 | { |
| 631 | reasonStream << " (" << message << ")"; |
| 632 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 633 | } |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 634 | std::string reason = reasonStream.str(); |
| 635 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 636 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 637 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 638 | } |
| 639 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 640 | // Both test, and if necessary spit out an error, to see if the node is really |
| 641 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 642 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 643 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 644 | if (node->getQualifier() != EvqConst) |
| 645 | { |
| 646 | error(node->getLine(), "constant expression required", ""); |
| 647 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 648 | } |
| 649 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 650 | // Both test, and if necessary spit out an error, to see if the node is really |
| 651 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 652 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 653 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 654 | if (!node->isScalarInt()) |
| 655 | { |
| 656 | error(node->getLine(), "integer expression required", token); |
| 657 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 658 | } |
| 659 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 660 | // Both test, and if necessary spit out an error, to see if we are currently |
| 661 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 662 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 663 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 664 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 665 | { |
| 666 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 667 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 668 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 669 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 670 | } |
| 671 | |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 672 | // ESSL 3.00.5 sections 3.8 and 3.9. |
| 673 | // If it starts "gl_" or contains two consecutive underscores, it's reserved. |
| 674 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a webgl shader. |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 675 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const ImmutableString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 676 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 677 | static const char *reservedErrMsg = "reserved built-in name"; |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 678 | if (identifier.beginsWith("gl_")) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 679 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 680 | error(line, reservedErrMsg, "gl_"); |
| 681 | return false; |
| 682 | } |
| 683 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
| 684 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 685 | if (identifier.beginsWith("webgl_")) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 686 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 687 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 688 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 689 | } |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 690 | if (identifier.beginsWith("_webgl_")) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 691 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 692 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 693 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 694 | } |
| 695 | } |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 696 | if (identifier.contains("__")) |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 697 | { |
| 698 | error(line, |
| 699 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 700 | "possible future keywords", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 701 | identifier); |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 702 | return false; |
| 703 | } |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 704 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 705 | } |
| 706 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 707 | // Make sure the argument types are correct for constructing a specific type. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 708 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 709 | const TIntermSequence &arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 710 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 711 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 712 | if (arguments.empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 713 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 714 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 715 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 716 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 717 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 718 | for (TIntermNode *arg : arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 719 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 720 | markStaticReadIfSymbol(arg); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 721 | const TIntermTyped *argTyped = arg->getAsTyped(); |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 722 | ASSERT(argTyped != nullptr); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 723 | if (type.getBasicType() != EbtStruct && IsOpaqueType(argTyped->getBasicType())) |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 724 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 725 | std::string reason("cannot convert a variable with type "); |
| 726 | reason += getBasicString(argTyped->getBasicType()); |
| 727 | error(line, reason.c_str(), "constructor"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 728 | return false; |
| 729 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 730 | else if (argTyped->getMemoryQualifier().writeonly) |
| 731 | { |
| 732 | error(line, "cannot convert a variable with writeonly", "constructor"); |
| 733 | return false; |
| 734 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 735 | if (argTyped->getBasicType() == EbtVoid) |
| 736 | { |
| 737 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 738 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 739 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 740 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 741 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 742 | if (type.isArray()) |
| 743 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 744 | // The size of an unsized constructor should already have been determined. |
| 745 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 746 | if (static_cast<size_t>(type.getOutermostArraySize()) != arguments.size()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 747 | { |
| 748 | error(line, "array constructor needs one argument per array element", "constructor"); |
| 749 | return false; |
| 750 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 751 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 752 | // the array. |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 753 | for (TIntermNode *const &argNode : arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 754 | { |
| 755 | const TType &argType = argNode->getAsTyped()->getType(); |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 756 | if (mShaderVersion < 310 && argType.isArray()) |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 757 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 758 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 759 | return false; |
| 760 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 761 | if (!argType.isElementTypeOf(type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 762 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 763 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 764 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 765 | } |
| 766 | } |
| 767 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 768 | else if (type.getBasicType() == EbtStruct) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 769 | { |
| 770 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 771 | if (fields.size() != arguments.size()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 772 | { |
| 773 | error(line, |
| 774 | "Number of constructor parameters does not match the number of structure fields", |
| 775 | "constructor"); |
| 776 | return false; |
| 777 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 778 | |
| 779 | for (size_t i = 0; i < fields.size(); i++) |
| 780 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 781 | if (i >= arguments.size() || |
| 782 | arguments[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 783 | { |
| 784 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 785 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 786 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 787 | } |
| 788 | } |
| 789 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 790 | else |
| 791 | { |
| 792 | // We're constructing a scalar, vector, or matrix. |
| 793 | |
| 794 | // Note: It's okay to have too many components available, but not okay to have unused |
| 795 | // arguments. 'full' will go to true when enough args have been seen. If we loop again, |
| 796 | // there is an extra argument, so 'overFull' will become true. |
| 797 | |
| 798 | size_t size = 0; |
| 799 | bool full = false; |
| 800 | bool overFull = false; |
| 801 | bool matrixArg = false; |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 802 | for (TIntermNode *arg : arguments) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 803 | { |
| 804 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 805 | ASSERT(argTyped != nullptr); |
| 806 | |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 807 | if (argTyped->getBasicType() == EbtStruct) |
| 808 | { |
| 809 | error(line, "a struct cannot be used as a constructor argument for this type", |
| 810 | "constructor"); |
| 811 | return false; |
| 812 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 813 | if (argTyped->getType().isArray()) |
| 814 | { |
| 815 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 816 | return false; |
| 817 | } |
| 818 | if (argTyped->getType().isMatrix()) |
| 819 | { |
| 820 | matrixArg = true; |
| 821 | } |
| 822 | |
| 823 | size += argTyped->getType().getObjectSize(); |
| 824 | if (full) |
| 825 | { |
| 826 | overFull = true; |
| 827 | } |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 828 | if (size >= type.getObjectSize()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 829 | { |
| 830 | full = true; |
| 831 | } |
| 832 | } |
| 833 | |
| 834 | if (type.isMatrix() && matrixArg) |
| 835 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 836 | if (arguments.size() != 1) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 837 | { |
| 838 | error(line, "constructing matrix from matrix can only take one argument", |
| 839 | "constructor"); |
| 840 | return false; |
| 841 | } |
| 842 | } |
| 843 | else |
| 844 | { |
| 845 | if (size != 1 && size < type.getObjectSize()) |
| 846 | { |
| 847 | error(line, "not enough data provided for construction", "constructor"); |
| 848 | return false; |
| 849 | } |
| 850 | if (overFull) |
| 851 | { |
| 852 | error(line, "too many arguments", "constructor"); |
| 853 | return false; |
| 854 | } |
| 855 | } |
| 856 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 857 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 858 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 859 | } |
| 860 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 861 | // This function checks to see if a void variable has been declared and raise an error message for |
| 862 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 863 | // |
| 864 | // returns true in case of an error |
| 865 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 866 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 867 | const ImmutableString &identifier, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 868 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 869 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 870 | if (type == EbtVoid) |
| 871 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 872 | error(line, "illegal use of type 'void'", identifier); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 873 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 874 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 875 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 876 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 877 | } |
| 878 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 879 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 880 | // or not. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 881 | bool TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 882 | { |
Olli Etuaho | 37d96cc | 2017-07-11 14:14:03 +0300 | [diff] [blame] | 883 | if (type->getBasicType() != EbtBool || !type->isScalar()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 884 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 885 | error(line, "boolean expression expected", ""); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 886 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 887 | } |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 888 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 889 | } |
| 890 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 891 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 892 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 893 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 894 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 895 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 896 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 897 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 898 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 899 | } |
| 900 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 901 | bool TParseContext::checkIsNotOpaqueType(const TSourceLoc &line, |
| 902 | const TTypeSpecifierNonArray &pType, |
| 903 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 904 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 905 | if (pType.type == EbtStruct) |
| 906 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 907 | if (ContainsSampler(pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 908 | { |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 909 | std::stringstream reasonStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 910 | reasonStream << reason << " (structure contains a sampler)"; |
| 911 | std::string reasonStr = reasonStream.str(); |
| 912 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 913 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 914 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 915 | // only samplers need to be checked from structs, since other opaque types can't be struct |
| 916 | // members. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 917 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 918 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 919 | else if (IsOpaqueType(pType.type)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 920 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 921 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 922 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 923 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 924 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 925 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 926 | } |
| 927 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 928 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 929 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 930 | { |
| 931 | if (pType.layoutQualifier.location != -1) |
| 932 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 933 | error(line, "location must only be specified for a single input or output variable", |
| 934 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 935 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 936 | } |
| 937 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 938 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 939 | const TLayoutQualifier &layoutQualifier) |
| 940 | { |
| 941 | if (layoutQualifier.location != -1) |
| 942 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 943 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 944 | if (mShaderVersion >= 310) |
| 945 | { |
| 946 | errorMsg = |
Jiawei Shao | 4cc89e2 | 2017-08-31 14:25:54 +0800 | [diff] [blame] | 947 | "invalid layout qualifier: only valid on shader inputs, outputs, and uniforms"; |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 948 | } |
| 949 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 950 | } |
| 951 | } |
| 952 | |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 953 | void TParseContext::checkStd430IsForShaderStorageBlock(const TSourceLoc &location, |
| 954 | const TLayoutBlockStorage &blockStorage, |
| 955 | const TQualifier &qualifier) |
| 956 | { |
| 957 | if (blockStorage == EbsStd430 && qualifier != EvqBuffer) |
| 958 | { |
| 959 | error(location, "The std430 layout is supported only for shader storage blocks.", "std430"); |
| 960 | } |
| 961 | } |
| 962 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 963 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 964 | TQualifier qualifier, |
| 965 | const TType &type) |
| 966 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 967 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 968 | if (IsOpaqueType(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 969 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 970 | error(line, "opaque types cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 971 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 972 | } |
| 973 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 974 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 975 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 976 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 977 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 978 | |
Olli Etuaho | 1dfd8ae | 2018-10-01 15:59:59 +0300 | [diff] [blame] | 979 | // ANGLE should be able to fold any EvqConst expressions resulting in an integer - but to be |
| 980 | // safe against corner cases we still check for constant folding. Some interpretations of the |
| 981 | // spec have allowed constant expressions with side effects - like array length() method on a |
| 982 | // non-constant array. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 983 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 984 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 985 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 986 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 987 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 988 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 989 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 990 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 991 | if (constant->getBasicType() == EbtUInt) |
| 992 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 993 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 994 | } |
| 995 | else |
| 996 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 997 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 998 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 999 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 1000 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1001 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1002 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 1003 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1004 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1005 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1006 | } |
| 1007 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1008 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1009 | { |
| 1010 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1011 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1012 | } |
| 1013 | |
| 1014 | // The size of arrays is restricted here to prevent issues further down the |
| 1015 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 1016 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 1017 | const unsigned int sizeLimit = 65536; |
| 1018 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1019 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1020 | { |
| 1021 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1022 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1023 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1024 | |
| 1025 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1026 | } |
| 1027 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1028 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1029 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 1030 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1031 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1032 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 1033 | (elementQualifier.qualifier == EvqVertexIn) || |
| 1034 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1035 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1036 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1037 | TType(elementQualifier).getQualifierString()); |
| 1038 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1039 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1040 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1041 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1042 | } |
| 1043 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1044 | // See if this element type can be formed into an array. |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1045 | bool TParseContext::checkArrayElementIsNotArray(const TSourceLoc &line, |
| 1046 | const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1047 | { |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 1048 | if (mShaderVersion < 310 && elementType.isArray()) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 1049 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 1050 | TInfoSinkBase typeString; |
| 1051 | typeString << TType(elementType); |
| 1052 | error(line, "cannot declare arrays of arrays", typeString.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1053 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1054 | } |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1055 | return true; |
| 1056 | } |
| 1057 | |
| 1058 | // Check if this qualified element type can be formed into an array. This is only called when array |
| 1059 | // brackets are associated with an identifier in a declaration, like this: |
| 1060 | // float a[2]; |
| 1061 | // Similar checks are done in addFullySpecifiedType for array declarations where the array brackets |
| 1062 | // are associated with the type, like this: |
| 1063 | // float[2] a; |
| 1064 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 1065 | const TPublicType &elementType) |
| 1066 | { |
| 1067 | if (!checkArrayElementIsNotArray(indexLocation, elementType)) |
| 1068 | { |
| 1069 | return false; |
| 1070 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1071 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 1072 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 1073 | // 4.3.4). |
Jiawei Shao | 492b5f5 | 2017-12-13 09:39:27 +0800 | [diff] [blame] | 1074 | // Geometry shader requires each user-defined input be declared as arrays or inside input |
| 1075 | // blocks declared as arrays (GL_EXT_geometry_shader section 11.1gs.4.3). For the purposes of |
| 1076 | // interface matching, such variables and blocks are treated as though they were not declared |
| 1077 | // as arrays (GL_EXT_geometry_shader section 7.4.1). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1078 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Jiawei Shao | 492b5f5 | 2017-12-13 09:39:27 +0800 | [diff] [blame] | 1079 | sh::IsVarying(elementType.qualifier) && |
| 1080 | !IsGeometryShaderInput(mShaderType, elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1081 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 1082 | TInfoSinkBase typeString; |
| 1083 | typeString << TType(elementType); |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1084 | error(indexLocation, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 1085 | typeString.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1086 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1087 | } |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1088 | return checkIsValidQualifierForArray(indexLocation, elementType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1089 | } |
| 1090 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1091 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1092 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1093 | const ImmutableString &identifier, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1094 | TType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1095 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1096 | ASSERT(type != nullptr); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1097 | if (type->getQualifier() == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1098 | { |
| 1099 | // Make the qualifier make sense. |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1100 | type->setQualifier(EvqTemporary); |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1101 | |
| 1102 | // Generate informative error messages for ESSL1. |
| 1103 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1104 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1105 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1106 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1107 | "structures containing arrays may not be declared constant since they cannot be " |
| 1108 | "initialized", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1109 | identifier); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1110 | } |
| 1111 | else |
| 1112 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1113 | error(line, "variables with qualifier 'const' must be initialized", identifier); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1114 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1115 | } |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1116 | // This will make the type sized if it isn't sized yet. |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1117 | checkIsNotUnsizedArray(line, "implicitly sized arrays need to be initialized", identifier, |
| 1118 | type); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1119 | } |
| 1120 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1121 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1122 | // and update the symbol table. |
| 1123 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1124 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1125 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1126 | bool TParseContext::declareVariable(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1127 | const ImmutableString &identifier, |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1128 | const TType *type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1129 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1130 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1131 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1132 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1133 | (*variable) = new TVariable(&symbolTable, identifier, type, SymbolType::UserDefined); |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 1134 | |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 1135 | ASSERT(type->getLayoutQualifier().index == -1 || |
| 1136 | (isExtensionEnabled(TExtension::EXT_blend_func_extended) && |
| 1137 | mShaderType == GL_FRAGMENT_SHADER && mShaderVersion >= 300)); |
| 1138 | if (type->getQualifier() == EvqFragmentOut) |
| 1139 | { |
| 1140 | if (type->getLayoutQualifier().index != -1 && type->getLayoutQualifier().location == -1) |
| 1141 | { |
| 1142 | error(line, |
| 1143 | "If index layout qualifier is specified for a fragment output, location must " |
| 1144 | "also be specified.", |
| 1145 | "index"); |
| 1146 | return false; |
| 1147 | } |
| 1148 | } |
| 1149 | else |
| 1150 | { |
| 1151 | checkIndexIsNotSpecified(line, type->getLayoutQualifier().index); |
| 1152 | } |
| 1153 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1154 | checkBindingIsValid(line, *type); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1155 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1156 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1157 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1158 | // gl_LastFragData may be redeclared with a new precision qualifier |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1159 | if (type->isArray() && identifier.beginsWith("gl_LastFragData")) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1160 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1161 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1162 | symbolTable.findBuiltIn(ImmutableString("gl_MaxDrawBuffers"), mShaderVersion)); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1163 | if (type->isArrayOfArrays()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1164 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1165 | error(line, "redeclaration of gl_LastFragData as an array of arrays", identifier); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1166 | return false; |
| 1167 | } |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1168 | else if (static_cast<int>(type->getOutermostArraySize()) == |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1169 | maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1170 | { |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 1171 | if (const TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1172 | { |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 1173 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->extension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1174 | } |
| 1175 | } |
| 1176 | else |
| 1177 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1178 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1179 | identifier); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1180 | return false; |
| 1181 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1182 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1183 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1184 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1185 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1186 | |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 1187 | if (!symbolTable.declare(*variable)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1188 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1189 | error(line, "redefinition", identifier); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1190 | return false; |
| 1191 | } |
| 1192 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1193 | if (!checkIsNonVoid(line, identifier, type->getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1194 | return false; |
| 1195 | |
| 1196 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1197 | } |
| 1198 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1199 | void TParseContext::checkIsParameterQualifierValid( |
| 1200 | const TSourceLoc &line, |
| 1201 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1202 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1203 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 1204 | // The only parameter qualifiers a parameter can have are in, out, inout or const. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1205 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1206 | |
| 1207 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1208 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1209 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1210 | } |
| 1211 | |
| 1212 | if (!IsImage(type->getBasicType())) |
| 1213 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1214 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1215 | } |
| 1216 | else |
| 1217 | { |
| 1218 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1219 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1220 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1221 | type->setQualifier(typeQualifier.qualifier); |
| 1222 | |
| 1223 | if (typeQualifier.precision != EbpUndefined) |
| 1224 | { |
| 1225 | type->setPrecision(typeQualifier.precision); |
| 1226 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1227 | } |
| 1228 | |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 1229 | template <size_t size> |
| 1230 | bool TParseContext::checkCanUseOneOfExtensions(const TSourceLoc &line, |
| 1231 | const std::array<TExtension, size> &extensions) |
| 1232 | { |
| 1233 | ASSERT(!extensions.empty()); |
| 1234 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
| 1235 | |
| 1236 | bool canUseWithWarning = false; |
| 1237 | bool canUseWithoutWarning = false; |
| 1238 | |
| 1239 | const char *errorMsgString = ""; |
| 1240 | TExtension errorMsgExtension = TExtension::UNDEFINED; |
| 1241 | |
| 1242 | for (TExtension extension : extensions) |
| 1243 | { |
| 1244 | auto extIter = extBehavior.find(extension); |
| 1245 | if (canUseWithWarning) |
| 1246 | { |
| 1247 | // We already have an extension that we can use, but with a warning. |
| 1248 | // See if we can use the alternative extension without a warning. |
| 1249 | if (extIter == extBehavior.end()) |
| 1250 | { |
| 1251 | continue; |
| 1252 | } |
| 1253 | if (extIter->second == EBhEnable || extIter->second == EBhRequire) |
| 1254 | { |
| 1255 | canUseWithoutWarning = true; |
| 1256 | break; |
| 1257 | } |
| 1258 | continue; |
| 1259 | } |
| 1260 | if (extIter == extBehavior.end()) |
| 1261 | { |
| 1262 | errorMsgString = "extension is not supported"; |
| 1263 | errorMsgExtension = extension; |
| 1264 | } |
| 1265 | else if (extIter->second == EBhUndefined || extIter->second == EBhDisable) |
| 1266 | { |
| 1267 | errorMsgString = "extension is disabled"; |
| 1268 | errorMsgExtension = extension; |
| 1269 | } |
| 1270 | else if (extIter->second == EBhWarn) |
| 1271 | { |
| 1272 | errorMsgExtension = extension; |
| 1273 | canUseWithWarning = true; |
| 1274 | } |
| 1275 | else |
| 1276 | { |
| 1277 | ASSERT(extIter->second == EBhEnable || extIter->second == EBhRequire); |
| 1278 | canUseWithoutWarning = true; |
| 1279 | break; |
| 1280 | } |
| 1281 | } |
| 1282 | |
| 1283 | if (canUseWithoutWarning) |
| 1284 | { |
| 1285 | return true; |
| 1286 | } |
| 1287 | if (canUseWithWarning) |
| 1288 | { |
| 1289 | warning(line, "extension is being used", GetExtensionNameString(errorMsgExtension)); |
| 1290 | return true; |
| 1291 | } |
| 1292 | error(line, errorMsgString, GetExtensionNameString(errorMsgExtension)); |
| 1293 | return false; |
| 1294 | } |
| 1295 | |
| 1296 | template bool TParseContext::checkCanUseOneOfExtensions( |
| 1297 | const TSourceLoc &line, |
| 1298 | const std::array<TExtension, 1> &extensions); |
| 1299 | template bool TParseContext::checkCanUseOneOfExtensions( |
| 1300 | const TSourceLoc &line, |
| 1301 | const std::array<TExtension, 2> &extensions); |
| 1302 | template bool TParseContext::checkCanUseOneOfExtensions( |
| 1303 | const TSourceLoc &line, |
| 1304 | const std::array<TExtension, 3> &extensions); |
| 1305 | |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1306 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, TExtension extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1307 | { |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1308 | ASSERT(extension != TExtension::UNDEFINED); |
Corentin Wallez | 1d33c21 | 2017-11-13 10:21:39 -0800 | [diff] [blame] | 1309 | return checkCanUseOneOfExtensions(line, std::array<TExtension, 1u>{{extension}}); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1310 | } |
| 1311 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1312 | // ESSL 3.00.6 section 4.8 Empty Declarations: "The combinations of qualifiers that cause |
| 1313 | // compile-time or link-time errors are the same whether or not the declaration is empty". |
| 1314 | // This function implements all the checks that are done on qualifiers regardless of if the |
| 1315 | // declaration is empty. |
| 1316 | void TParseContext::declarationQualifierErrorCheck(const sh::TQualifier qualifier, |
| 1317 | const sh::TLayoutQualifier &layoutQualifier, |
| 1318 | const TSourceLoc &location) |
| 1319 | { |
| 1320 | if (qualifier == EvqShared && !layoutQualifier.isEmpty()) |
| 1321 | { |
| 1322 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1323 | } |
| 1324 | |
| 1325 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1326 | { |
| 1327 | error(location, "layout qualifier only valid for interface blocks", |
| 1328 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
| 1329 | return; |
| 1330 | } |
| 1331 | |
| 1332 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1333 | { |
| 1334 | error(location, "layout qualifier only valid for interface blocks", |
| 1335 | getBlockStorageString(layoutQualifier.blockStorage)); |
| 1336 | return; |
| 1337 | } |
| 1338 | |
| 1339 | if (qualifier == EvqFragmentOut) |
| 1340 | { |
| 1341 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1342 | { |
| 1343 | error(location, "invalid layout qualifier combination", "yuv"); |
| 1344 | return; |
| 1345 | } |
| 1346 | } |
| 1347 | else |
| 1348 | { |
| 1349 | checkYuvIsNotSpecified(location, layoutQualifier.yuv); |
| 1350 | } |
| 1351 | |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 1352 | // If multiview extension is enabled, "in" qualifier is allowed in the vertex shader in previous |
| 1353 | // parsing steps. So it needs to be checked here. |
Mingyu Hu | ebab670 | 2019-04-19 14:36:45 -0700 | [diff] [blame^] | 1354 | if (anyMultiviewExtensionAvailable() && mShaderVersion < 300 && qualifier == EvqVertexIn) |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 1355 | { |
| 1356 | error(location, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 1357 | } |
| 1358 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1359 | bool canHaveLocation = qualifier == EvqVertexIn || qualifier == EvqFragmentOut; |
Jiawei Shao | 4cc89e2 | 2017-08-31 14:25:54 +0800 | [diff] [blame] | 1360 | if (mShaderVersion >= 310) |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1361 | { |
Jiawei Shao | 4cc89e2 | 2017-08-31 14:25:54 +0800 | [diff] [blame] | 1362 | canHaveLocation = canHaveLocation || qualifier == EvqUniform || IsVarying(qualifier); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1363 | // We're not checking whether the uniform location is in range here since that depends on |
| 1364 | // the type of the variable. |
| 1365 | // The type can only be fully determined for non-empty declarations. |
| 1366 | } |
| 1367 | if (!canHaveLocation) |
| 1368 | { |
| 1369 | checkLocationIsNotSpecified(location, layoutQualifier); |
| 1370 | } |
| 1371 | } |
| 1372 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1373 | void TParseContext::atomicCounterQualifierErrorCheck(const TPublicType &publicType, |
| 1374 | const TSourceLoc &location) |
| 1375 | { |
| 1376 | if (publicType.precision != EbpHigh) |
| 1377 | { |
| 1378 | error(location, "Can only be highp", "atomic counter"); |
| 1379 | } |
| 1380 | // dEQP enforces compile error if location is specified. See uniform_location.test. |
| 1381 | if (publicType.layoutQualifier.location != -1) |
| 1382 | { |
| 1383 | error(location, "location must not be set for atomic_uint", "layout"); |
| 1384 | } |
| 1385 | if (publicType.layoutQualifier.binding == -1) |
| 1386 | { |
| 1387 | error(location, "no binding specified", "atomic counter"); |
| 1388 | } |
| 1389 | } |
| 1390 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1391 | void TParseContext::emptyDeclarationErrorCheck(const TType &type, const TSourceLoc &location) |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1392 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1393 | if (type.isUnsizedArray()) |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1394 | { |
| 1395 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1396 | // error. It is assumed that this applies to empty declarations as well. |
| 1397 | error(location, "empty array declaration needs to specify a size", ""); |
| 1398 | } |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 1399 | |
| 1400 | if (type.getQualifier() != EvqFragmentOut) |
| 1401 | { |
| 1402 | checkIndexIsNotSpecified(location, type.getLayoutQualifier().index); |
| 1403 | } |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1404 | } |
| 1405 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1406 | // These checks are done for all declarations that are non-empty. They're done for non-empty |
| 1407 | // declarations starting a declarator list, and declarators that follow an empty declaration. |
| 1408 | void TParseContext::nonEmptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1409 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1410 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1411 | switch (publicType.qualifier) |
| 1412 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1413 | case EvqVaryingIn: |
| 1414 | case EvqVaryingOut: |
| 1415 | case EvqAttribute: |
| 1416 | case EvqVertexIn: |
| 1417 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1418 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1419 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1420 | { |
| 1421 | error(identifierLocation, "cannot be used with a structure", |
| 1422 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1423 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1424 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1425 | break; |
| 1426 | case EvqBuffer: |
| 1427 | if (publicType.getBasicType() != EbtInterfaceBlock) |
| 1428 | { |
| 1429 | error(identifierLocation, |
| 1430 | "cannot declare buffer variables at global scope(outside a block)", |
| 1431 | getQualifierString(publicType.qualifier)); |
| 1432 | return; |
| 1433 | } |
| 1434 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1435 | default: |
| 1436 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1437 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1438 | std::string reason(getBasicString(publicType.getBasicType())); |
| 1439 | reason += "s must be uniform"; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1440 | if (publicType.qualifier != EvqUniform && |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1441 | !checkIsNotOpaqueType(identifierLocation, publicType.typeSpecifierNonArray, reason.c_str())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1442 | { |
| 1443 | return; |
| 1444 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1445 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1446 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1447 | publicType.qualifier != EvqConst) && |
| 1448 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1449 | { |
| 1450 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1451 | getQualifierString(publicType.qualifier)); |
| 1452 | return; |
| 1453 | } |
| 1454 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1455 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1456 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1457 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1458 | // But invalid shaders may still reach here with an unsized array declaration. |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1459 | TType type(publicType); |
| 1460 | if (!type.isUnsizedArray()) |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1461 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1462 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1463 | publicType.layoutQualifier); |
| 1464 | } |
| 1465 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1466 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1467 | // check for layout qualifier issues |
| 1468 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1469 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1470 | if (IsImage(publicType.getBasicType())) |
| 1471 | { |
| 1472 | |
| 1473 | switch (layoutQualifier.imageInternalFormat) |
| 1474 | { |
| 1475 | case EiifRGBA32F: |
| 1476 | case EiifRGBA16F: |
| 1477 | case EiifR32F: |
| 1478 | case EiifRGBA8: |
| 1479 | case EiifRGBA8_SNORM: |
| 1480 | if (!IsFloatImage(publicType.getBasicType())) |
| 1481 | { |
| 1482 | error(identifierLocation, |
| 1483 | "internal image format requires a floating image type", |
| 1484 | getBasicString(publicType.getBasicType())); |
| 1485 | return; |
| 1486 | } |
| 1487 | break; |
| 1488 | case EiifRGBA32I: |
| 1489 | case EiifRGBA16I: |
| 1490 | case EiifRGBA8I: |
| 1491 | case EiifR32I: |
| 1492 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1493 | { |
| 1494 | error(identifierLocation, |
| 1495 | "internal image format requires an integer image type", |
| 1496 | getBasicString(publicType.getBasicType())); |
| 1497 | return; |
| 1498 | } |
| 1499 | break; |
| 1500 | case EiifRGBA32UI: |
| 1501 | case EiifRGBA16UI: |
| 1502 | case EiifRGBA8UI: |
| 1503 | case EiifR32UI: |
| 1504 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1505 | { |
| 1506 | error(identifierLocation, |
| 1507 | "internal image format requires an unsigned image type", |
| 1508 | getBasicString(publicType.getBasicType())); |
| 1509 | return; |
| 1510 | } |
| 1511 | break; |
| 1512 | case EiifUnspecified: |
| 1513 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1514 | return; |
| 1515 | default: |
| 1516 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1517 | return; |
| 1518 | } |
| 1519 | |
| 1520 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1521 | switch (layoutQualifier.imageInternalFormat) |
| 1522 | { |
| 1523 | case EiifR32F: |
| 1524 | case EiifR32I: |
| 1525 | case EiifR32UI: |
| 1526 | break; |
| 1527 | default: |
| 1528 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1529 | { |
| 1530 | error(identifierLocation, "layout qualifier", |
| 1531 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1532 | "image variables must be qualified readonly and/or writeonly"); |
| 1533 | return; |
| 1534 | } |
| 1535 | break; |
| 1536 | } |
| 1537 | } |
| 1538 | else |
| 1539 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1540 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1541 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1542 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1543 | |
| 1544 | if (IsAtomicCounter(publicType.getBasicType())) |
| 1545 | { |
| 1546 | atomicCounterQualifierErrorCheck(publicType, identifierLocation); |
| 1547 | } |
| 1548 | else |
| 1549 | { |
| 1550 | checkOffsetIsNotSpecified(identifierLocation, layoutQualifier.offset); |
| 1551 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1552 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1553 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1554 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1555 | { |
| 1556 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1557 | // Note that the ESSL 3.10 section 4.4.5 is not particularly clear on how the binding qualifier |
| 1558 | // on arrays of arrays should be handled. We interpret the spec so that the binding value is |
| 1559 | // incremented for each element of the innermost nested arrays. This is in line with how arrays |
| 1560 | // of arrays of blocks are specified to behave in GLSL 4.50 and a conservative interpretation |
| 1561 | // when it comes to which shaders are accepted by the compiler. |
| 1562 | int arrayTotalElementCount = type.getArraySizeProduct(); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1563 | if (IsImage(type.getBasicType())) |
| 1564 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1565 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, |
| 1566 | arrayTotalElementCount); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1567 | } |
| 1568 | else if (IsSampler(type.getBasicType())) |
| 1569 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1570 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, |
| 1571 | arrayTotalElementCount); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1572 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1573 | else if (IsAtomicCounter(type.getBasicType())) |
| 1574 | { |
| 1575 | checkAtomicCounterBindingIsValid(identifierLocation, layoutQualifier.binding); |
| 1576 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1577 | else |
| 1578 | { |
| 1579 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1580 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1581 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1582 | } |
| 1583 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1584 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1585 | const ImmutableString &layoutQualifierName, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1586 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1587 | { |
| 1588 | |
| 1589 | if (mShaderVersion < versionRequired) |
| 1590 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1591 | error(location, "invalid layout qualifier: not supported", layoutQualifierName); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1592 | } |
| 1593 | } |
| 1594 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1595 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1596 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1597 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1598 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1599 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1600 | { |
| 1601 | if (localSize[i] != -1) |
| 1602 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1603 | error(location, |
| 1604 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1605 | "global layout declaration", |
| 1606 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1607 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1608 | } |
| 1609 | } |
| 1610 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1611 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1612 | } |
| 1613 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1614 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1615 | TLayoutImageInternalFormat internalFormat) |
| 1616 | { |
| 1617 | if (internalFormat != EiifUnspecified) |
| 1618 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1619 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1620 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1621 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1622 | } |
| 1623 | |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 1624 | void TParseContext::checkIndexIsNotSpecified(const TSourceLoc &location, int index) |
| 1625 | { |
| 1626 | if (index != -1) |
| 1627 | { |
| 1628 | error(location, |
| 1629 | "invalid layout qualifier: only valid when used with a fragment shader output in " |
| 1630 | "ESSL version >= 3.00 and EXT_blend_func_extended is enabled", |
| 1631 | "index"); |
| 1632 | } |
| 1633 | } |
| 1634 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1635 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1636 | { |
| 1637 | if (binding != -1) |
| 1638 | { |
| 1639 | error(location, |
| 1640 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1641 | "binding"); |
| 1642 | } |
| 1643 | } |
| 1644 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1645 | void TParseContext::checkOffsetIsNotSpecified(const TSourceLoc &location, int offset) |
| 1646 | { |
| 1647 | if (offset != -1) |
| 1648 | { |
| 1649 | error(location, "invalid layout qualifier: only valid when used with atomic counters", |
| 1650 | "offset"); |
| 1651 | } |
| 1652 | } |
| 1653 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1654 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, |
| 1655 | int binding, |
| 1656 | int arrayTotalElementCount) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1657 | { |
| 1658 | // Expects arraySize to be 1 when setting binding for only a single variable. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1659 | if (binding >= 0 && binding + arrayTotalElementCount > mMaxImageUnits) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1660 | { |
| 1661 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1662 | } |
| 1663 | } |
| 1664 | |
| 1665 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1666 | int binding, |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1667 | int arrayTotalElementCount) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1668 | { |
| 1669 | // Expects arraySize to be 1 when setting binding for only a single variable. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1670 | if (binding >= 0 && binding + arrayTotalElementCount > mMaxCombinedTextureImageUnits) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1671 | { |
| 1672 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1673 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1674 | } |
| 1675 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1676 | void TParseContext::checkBlockBindingIsValid(const TSourceLoc &location, |
| 1677 | const TQualifier &qualifier, |
| 1678 | int binding, |
| 1679 | int arraySize) |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1680 | { |
| 1681 | int size = (arraySize == 0 ? 1 : arraySize); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1682 | if (qualifier == EvqUniform) |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1683 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1684 | if (binding + size > mMaxUniformBufferBindings) |
| 1685 | { |
| 1686 | error(location, "uniform block binding greater than MAX_UNIFORM_BUFFER_BINDINGS", |
| 1687 | "binding"); |
| 1688 | } |
| 1689 | } |
| 1690 | else if (qualifier == EvqBuffer) |
| 1691 | { |
| 1692 | if (binding + size > mMaxShaderStorageBufferBindings) |
| 1693 | { |
| 1694 | error(location, |
| 1695 | "shader storage block binding greater than MAX_SHADER_STORAGE_BUFFER_BINDINGS", |
| 1696 | "binding"); |
| 1697 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1698 | } |
| 1699 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1700 | void TParseContext::checkAtomicCounterBindingIsValid(const TSourceLoc &location, int binding) |
| 1701 | { |
| 1702 | if (binding >= mMaxAtomicCounterBindings) |
| 1703 | { |
| 1704 | error(location, "atomic counter binding greater than gl_MaxAtomicCounterBindings", |
| 1705 | "binding"); |
| 1706 | } |
| 1707 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1708 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1709 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1710 | int objectLocationCount, |
| 1711 | const TLayoutQualifier &layoutQualifier) |
| 1712 | { |
| 1713 | int loc = layoutQualifier.location; |
| 1714 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1715 | { |
| 1716 | error(location, "Uniform location out of range", "location"); |
| 1717 | } |
| 1718 | } |
| 1719 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1720 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1721 | { |
| 1722 | if (yuv != false) |
| 1723 | { |
| 1724 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1725 | } |
| 1726 | } |
| 1727 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1728 | void TParseContext::functionCallRValueLValueErrorCheck(const TFunction *fnCandidate, |
| 1729 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1730 | { |
| 1731 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1732 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 1733 | TQualifier qual = fnCandidate->getParam(i)->getType().getQualifier(); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1734 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1735 | bool argumentIsRead = (IsQualifierUnspecified(qual) || qual == EvqIn || qual == EvqInOut || |
| 1736 | qual == EvqConstReadOnly); |
| 1737 | if (argumentIsRead) |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1738 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1739 | markStaticReadIfSymbol(argument); |
| 1740 | if (!IsImage(argument->getBasicType())) |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1741 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1742 | if (argument->getMemoryQualifier().writeonly) |
| 1743 | { |
| 1744 | error(argument->getLine(), |
| 1745 | "Writeonly value cannot be passed for 'in' or 'inout' parameters.", |
| 1746 | fnCall->functionName()); |
| 1747 | return; |
| 1748 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1749 | } |
| 1750 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1751 | if (qual == EvqOut || qual == EvqInOut) |
| 1752 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1753 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1754 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1755 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1756 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | 0c37100 | 2017-12-13 17:00:25 +0400 | [diff] [blame] | 1757 | fnCall->functionName()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1758 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1759 | } |
| 1760 | } |
| 1761 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1762 | } |
| 1763 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1764 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1765 | const TQualifier qualifier, |
| 1766 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1767 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1768 | if (!invariant) |
| 1769 | return; |
| 1770 | |
| 1771 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1772 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1773 | // input variables in the fragment shader can be also qualified as invariant |
| 1774 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1775 | { |
| 1776 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1777 | } |
| 1778 | } |
| 1779 | else |
| 1780 | { |
| 1781 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1782 | { |
| 1783 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1784 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1785 | } |
| 1786 | } |
| 1787 | |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1788 | bool TParseContext::isExtensionEnabled(TExtension extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1789 | { |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1790 | return IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1791 | } |
| 1792 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1793 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1794 | const char *extName, |
| 1795 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1796 | { |
Geoff Lang | 197d529 | 2018-04-25 14:29:00 -0400 | [diff] [blame] | 1797 | angle::pp::SourceLocation srcLoc; |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1798 | srcLoc.file = loc.first_file; |
| 1799 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1800 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1801 | } |
| 1802 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1803 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1804 | const char *name, |
| 1805 | const char *value, |
| 1806 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1807 | { |
Geoff Lang | 197d529 | 2018-04-25 14:29:00 -0400 | [diff] [blame] | 1808 | angle::pp::SourceLocation srcLoc; |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1809 | srcLoc.file = loc.first_file; |
| 1810 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1811 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1812 | } |
| 1813 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1814 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1815 | { |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 1816 | sh::WorkGroupSize result(-1); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1817 | for (size_t i = 0u; i < result.size(); ++i) |
| 1818 | { |
| 1819 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1820 | { |
| 1821 | result[i] = 1; |
| 1822 | } |
| 1823 | else |
| 1824 | { |
| 1825 | result[i] = mComputeShaderLocalSize[i]; |
| 1826 | } |
| 1827 | } |
| 1828 | return result; |
| 1829 | } |
| 1830 | |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1831 | TIntermConstantUnion *TParseContext::addScalarLiteral(const TConstantUnion *constantUnion, |
| 1832 | const TSourceLoc &line) |
| 1833 | { |
| 1834 | TIntermConstantUnion *node = new TIntermConstantUnion( |
| 1835 | constantUnion, TType(constantUnion->getType(), EbpUndefined, EvqConst)); |
| 1836 | node->setLine(line); |
| 1837 | return node; |
| 1838 | } |
| 1839 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1840 | ///////////////////////////////////////////////////////////////////////////////// |
| 1841 | // |
| 1842 | // Non-Errors. |
| 1843 | // |
| 1844 | ///////////////////////////////////////////////////////////////////////////////// |
| 1845 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1846 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1847 | const ImmutableString &name, |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1848 | const TSymbol *symbol) |
| 1849 | { |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1850 | if (!symbol) |
| 1851 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1852 | error(location, "undeclared identifier", name); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1853 | return nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1854 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1855 | |
| 1856 | if (!symbol->isVariable()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1857 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1858 | error(location, "variable expected", name); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1859 | return nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1860 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1861 | |
| 1862 | const TVariable *variable = static_cast<const TVariable *>(symbol); |
| 1863 | |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 1864 | if (variable->extension() != TExtension::UNDEFINED) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1865 | { |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 1866 | checkCanUseExtension(location, variable->extension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1867 | } |
| 1868 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1869 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1870 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
Olli Etuaho | 59c5b89 | 2018-04-03 11:44:50 +0300 | [diff] [blame] | 1871 | variable->getType().getQualifier() == EvqWorkGroupSize) |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1872 | { |
| 1873 | error(location, |
| 1874 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1875 | "gl_WorkGroupSize"); |
| 1876 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1877 | return variable; |
| 1878 | } |
| 1879 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1880 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1881 | const ImmutableString &name, |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1882 | const TSymbol *symbol) |
| 1883 | { |
| 1884 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1885 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1886 | if (!variable) |
| 1887 | { |
| 1888 | TIntermTyped *node = CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
| 1889 | node->setLine(location); |
| 1890 | return node; |
| 1891 | } |
| 1892 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1893 | const TType &variableType = variable->getType(); |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 1894 | TIntermTyped *node = nullptr; |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1895 | |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 1896 | if (variable->getConstPointer() && variableType.canReplaceWithConstantUnion()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1897 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1898 | const TConstantUnion *constArray = variable->getConstPointer(); |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1899 | node = new TIntermConstantUnion(constArray, variableType); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1900 | } |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1901 | else if (variableType.getQualifier() == EvqWorkGroupSize && mComputeShaderLocalSizeDeclared) |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1902 | { |
| 1903 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1904 | // needs to be added to the AST as a constant and not as a symbol. |
| 1905 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1906 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1907 | for (size_t i = 0; i < 3; ++i) |
| 1908 | { |
| 1909 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1910 | } |
| 1911 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1912 | ASSERT(variableType.getBasicType() == EbtUInt); |
| 1913 | ASSERT(variableType.getObjectSize() == 3); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1914 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1915 | TType type(variableType); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1916 | type.setQualifier(EvqConst); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1917 | node = new TIntermConstantUnion(constArray, type); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1918 | } |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1919 | else if ((mGeometryShaderInputPrimitiveType != EptUndefined) && |
| 1920 | (variableType.getQualifier() == EvqPerVertexIn)) |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 1921 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1922 | ASSERT(symbolTable.getGlInVariableWithArraySize() != nullptr); |
| 1923 | node = new TIntermSymbol(symbolTable.getGlInVariableWithArraySize()); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 1924 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1925 | else |
| 1926 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 1927 | node = new TIntermSymbol(variable); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1928 | } |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1929 | ASSERT(node != nullptr); |
| 1930 | node->setLine(location); |
| 1931 | return node; |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1932 | } |
| 1933 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1934 | // Initializers show up in several places in the grammar. Have one set of |
| 1935 | // code to handle them here. |
| 1936 | // |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1937 | // Returns true on success. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1938 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1939 | const ImmutableString &identifier, |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1940 | TType *type, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1941 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1942 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1943 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1944 | ASSERT(initNode != nullptr); |
| 1945 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1946 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1947 | if (type->isUnsizedArray()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1948 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1949 | // In case initializer is not an array or type has more dimensions than initializer, this |
| 1950 | // will default to setting array sizes to 1. We have not checked yet whether the initializer |
| 1951 | // actually is an array or not. Having a non-array initializer for an unsized array will |
| 1952 | // result in an error later, so we don't generate an error message here. |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 1953 | auto *arraySizes = initializer->getType().getArraySizes(); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1954 | type->sizeUnsizedArrays(arraySizes); |
| 1955 | } |
| 1956 | |
| 1957 | const TQualifier qualifier = type->getQualifier(); |
| 1958 | |
| 1959 | bool constError = false; |
| 1960 | if (qualifier == EvqConst) |
| 1961 | { |
| 1962 | if (EvqConst != initializer->getType().getQualifier()) |
| 1963 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 1964 | TInfoSinkBase reasonStream; |
| 1965 | reasonStream << "assigning non-constant to '" << *type << "'"; |
| 1966 | error(line, reasonStream.c_str(), "="); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1967 | |
| 1968 | // We're still going to declare the variable to avoid extra error messages. |
| 1969 | type->setQualifier(EvqTemporary); |
| 1970 | constError = true; |
| 1971 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1972 | } |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 1973 | |
| 1974 | TVariable *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1975 | if (!declareVariable(line, identifier, type, &variable)) |
| 1976 | { |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1977 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1978 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1979 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1980 | if (constError) |
| 1981 | { |
| 1982 | return false; |
| 1983 | } |
| 1984 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1985 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1986 | if (symbolTable.atGlobalLevel() && |
Olli Etuaho | a2d9814 | 2017-12-15 14:18:55 +0200 | [diff] [blame] | 1987 | !ValidateGlobalInitializer(initializer, mShaderVersion, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1988 | { |
| 1989 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1990 | // we want to steer developers towards only using constant expressions. |
| 1991 | error(line, "global variable initializers must be constant expressions", "="); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1992 | return false; |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1993 | } |
| 1994 | if (globalInitWarning) |
| 1995 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1996 | warning( |
| 1997 | line, |
| 1998 | "global variable initializers should be constant expressions " |
| 1999 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 2000 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 2001 | } |
| 2002 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 2003 | // identifier must be of type constant, a global, or a temporary |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2004 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 2005 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2006 | error(line, " cannot initialize this type of qualifier ", |
| 2007 | variable->getType().getQualifierString()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2008 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 2009 | } |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2010 | |
| 2011 | TIntermSymbol *intermSymbol = new TIntermSymbol(variable); |
| 2012 | intermSymbol->setLine(line); |
| 2013 | |
| 2014 | if (!binaryOpCommonCheck(EOpInitialize, intermSymbol, initializer, line)) |
| 2015 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 2016 | assignError(line, "=", variable->getType(), initializer->getType()); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2017 | return false; |
| 2018 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2019 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2020 | if (qualifier == EvqConst) |
| 2021 | { |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 2022 | // Save the constant folded value to the variable if possible. |
| 2023 | const TConstantUnion *constArray = initializer->getConstantValue(); |
| 2024 | if (constArray) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2025 | { |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 2026 | variable->shareConstPointer(constArray); |
| 2027 | if (initializer->getType().canReplaceWithConstantUnion()) |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 2028 | { |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2029 | ASSERT(*initNode == nullptr); |
| 2030 | return true; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 2031 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 2032 | } |
| 2033 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2034 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2035 | *initNode = new TIntermBinary(EOpInitialize, intermSymbol, initializer); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2036 | markStaticReadIfSymbol(initializer); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2037 | (*initNode)->setLine(line); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2038 | return true; |
| 2039 | } |
| 2040 | |
| 2041 | TIntermNode *TParseContext::addConditionInitializer(const TPublicType &pType, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2042 | const ImmutableString &identifier, |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2043 | TIntermTyped *initializer, |
| 2044 | const TSourceLoc &loc) |
| 2045 | { |
| 2046 | checkIsScalarBool(loc, pType); |
| 2047 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2048 | TType *type = new TType(pType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2049 | if (executeInitializer(loc, identifier, type, initializer, &initNode)) |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2050 | { |
| 2051 | // The initializer is valid. The init condition needs to have a node - either the |
| 2052 | // initializer node, or a constant node in case the initialized variable is const and won't |
| 2053 | // be recorded in the AST. |
| 2054 | if (initNode == nullptr) |
| 2055 | { |
| 2056 | return initializer; |
| 2057 | } |
| 2058 | else |
| 2059 | { |
| 2060 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2061 | declaration->appendDeclarator(initNode); |
| 2062 | return declaration; |
| 2063 | } |
| 2064 | } |
| 2065 | return nullptr; |
| 2066 | } |
| 2067 | |
| 2068 | TIntermNode *TParseContext::addLoop(TLoopType type, |
| 2069 | TIntermNode *init, |
| 2070 | TIntermNode *cond, |
| 2071 | TIntermTyped *expr, |
| 2072 | TIntermNode *body, |
| 2073 | const TSourceLoc &line) |
| 2074 | { |
| 2075 | TIntermNode *node = nullptr; |
| 2076 | TIntermTyped *typedCond = nullptr; |
| 2077 | if (cond) |
| 2078 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2079 | markStaticReadIfSymbol(cond); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2080 | typedCond = cond->getAsTyped(); |
| 2081 | } |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2082 | if (expr) |
| 2083 | { |
| 2084 | markStaticReadIfSymbol(expr); |
| 2085 | } |
| 2086 | // In case the loop body was not parsed as a block and contains a statement that simply refers |
| 2087 | // to a variable, we need to mark it as statically used. |
| 2088 | if (body) |
| 2089 | { |
| 2090 | markStaticReadIfSymbol(body); |
| 2091 | } |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2092 | if (cond == nullptr || typedCond) |
| 2093 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2094 | if (type == ELoopDoWhile) |
| 2095 | { |
| 2096 | checkIsScalarBool(line, typedCond); |
| 2097 | } |
| 2098 | // In the case of other loops, it was checked before that the condition is a scalar boolean. |
| 2099 | ASSERT(mDiagnostics->numErrors() > 0 || typedCond == nullptr || |
| 2100 | (typedCond->getBasicType() == EbtBool && !typedCond->isArray() && |
| 2101 | !typedCond->isVector())); |
| 2102 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2103 | node = new TIntermLoop(type, init, typedCond, expr, EnsureBlock(body)); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2104 | node->setLine(line); |
| 2105 | return node; |
| 2106 | } |
| 2107 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2108 | ASSERT(type != ELoopDoWhile); |
| 2109 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2110 | TIntermDeclaration *declaration = cond->getAsDeclarationNode(); |
| 2111 | ASSERT(declaration); |
| 2112 | TIntermBinary *declarator = declaration->getSequence()->front()->getAsBinaryNode(); |
| 2113 | ASSERT(declarator->getLeft()->getAsSymbolNode()); |
| 2114 | |
| 2115 | // The condition is a declaration. In the AST representation we don't support declarations as |
| 2116 | // loop conditions. Wrap the loop to a block that declares the condition variable and contains |
| 2117 | // the loop. |
| 2118 | TIntermBlock *block = new TIntermBlock(); |
| 2119 | |
| 2120 | TIntermDeclaration *declareCondition = new TIntermDeclaration(); |
| 2121 | declareCondition->appendDeclarator(declarator->getLeft()->deepCopy()); |
| 2122 | block->appendStatement(declareCondition); |
| 2123 | |
| 2124 | TIntermBinary *conditionInit = new TIntermBinary(EOpAssign, declarator->getLeft()->deepCopy(), |
| 2125 | declarator->getRight()->deepCopy()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2126 | TIntermLoop *loop = new TIntermLoop(type, init, conditionInit, expr, EnsureBlock(body)); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2127 | block->appendStatement(loop); |
| 2128 | loop->setLine(line); |
| 2129 | block->setLine(line); |
| 2130 | return block; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2131 | } |
| 2132 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2133 | TIntermNode *TParseContext::addIfElse(TIntermTyped *cond, |
| 2134 | TIntermNodePair code, |
| 2135 | const TSourceLoc &loc) |
| 2136 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 2137 | bool isScalarBool = checkIsScalarBool(loc, cond); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2138 | // In case the conditional statements were not parsed as blocks and contain a statement that |
| 2139 | // simply refers to a variable, we need to mark them as statically used. |
| 2140 | if (code.node1) |
| 2141 | { |
| 2142 | markStaticReadIfSymbol(code.node1); |
| 2143 | } |
| 2144 | if (code.node2) |
| 2145 | { |
| 2146 | markStaticReadIfSymbol(code.node2); |
| 2147 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2148 | |
| 2149 | // For compile time constant conditions, prune the code now. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 2150 | if (isScalarBool && cond->getAsConstantUnion()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2151 | { |
| 2152 | if (cond->getAsConstantUnion()->getBConst(0) == true) |
| 2153 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2154 | return EnsureBlock(code.node1); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2155 | } |
| 2156 | else |
| 2157 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2158 | return EnsureBlock(code.node2); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2159 | } |
| 2160 | } |
| 2161 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2162 | TIntermIfElse *node = new TIntermIfElse(cond, EnsureBlock(code.node1), EnsureBlock(code.node2)); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2163 | markStaticReadIfSymbol(cond); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2164 | node->setLine(loc); |
| 2165 | |
| 2166 | return node; |
| 2167 | } |
| 2168 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 2169 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 2170 | { |
| 2171 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 2172 | typeSpecifier->getBasicType()); |
| 2173 | |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2174 | if (mShaderVersion < 300 && typeSpecifier->isArray()) |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 2175 | { |
| 2176 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 2177 | typeSpecifier->clearArrayness(); |
| 2178 | } |
| 2179 | } |
| 2180 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2181 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2182 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2183 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2184 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2185 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2186 | TPublicType returnType = typeSpecifier; |
| 2187 | returnType.qualifier = typeQualifier.qualifier; |
| 2188 | returnType.invariant = typeQualifier.invariant; |
| 2189 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2190 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2191 | returnType.precision = typeSpecifier.precision; |
| 2192 | |
| 2193 | if (typeQualifier.precision != EbpUndefined) |
| 2194 | { |
| 2195 | returnType.precision = typeQualifier.precision; |
| 2196 | } |
| 2197 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2198 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 2199 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2200 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2201 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 2202 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2203 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2204 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2205 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2206 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2207 | { |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2208 | if (typeSpecifier.isArray()) |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 2209 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2210 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 2211 | returnType.clearArrayness(); |
| 2212 | } |
| 2213 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2214 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2215 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2216 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2217 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2218 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2219 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2220 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2221 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2222 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2223 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2224 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2225 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2226 | } |
| 2227 | } |
| 2228 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2229 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2230 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 2231 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2232 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 2233 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2234 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 2235 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2236 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2237 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 2238 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2239 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2240 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2241 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2242 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2243 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2244 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2245 | } |
| 2246 | |
| 2247 | return returnType; |
| 2248 | } |
| 2249 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2250 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 2251 | const TPublicType &type, |
| 2252 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2253 | { |
| 2254 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2255 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2256 | { |
| 2257 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2258 | } |
| 2259 | |
| 2260 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 2261 | switch (qualifier) |
| 2262 | { |
| 2263 | case EvqVertexIn: |
| 2264 | // ESSL 3.00 section 4.3.4 |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2265 | if (type.isArray()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2266 | { |
| 2267 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2268 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2269 | // Vertex inputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2270 | return; |
| 2271 | case EvqFragmentOut: |
| 2272 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2273 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2274 | { |
| 2275 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2276 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2277 | // Fragment outputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2278 | return; |
| 2279 | default: |
| 2280 | break; |
| 2281 | } |
| 2282 | |
| 2283 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 2284 | // restrictions. |
| 2285 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2286 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 2287 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2288 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 2289 | { |
| 2290 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 2291 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2292 | } |
| 2293 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2294 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2295 | { |
| 2296 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 2297 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 2298 | // the ESSL 3.10 spec lists these restrictions explicitly. |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2299 | if (type.isArray()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2300 | { |
| 2301 | error(qualifierLocation, "cannot be an array of structures", |
| 2302 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2303 | } |
| 2304 | if (type.isStructureContainingArrays()) |
| 2305 | { |
| 2306 | error(qualifierLocation, "cannot be a structure containing an array", |
| 2307 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2308 | } |
| 2309 | if (type.isStructureContainingType(EbtStruct)) |
| 2310 | { |
| 2311 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 2312 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2313 | } |
| 2314 | if (type.isStructureContainingType(EbtBool)) |
| 2315 | { |
| 2316 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 2317 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2318 | } |
| 2319 | } |
| 2320 | } |
| 2321 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2322 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 2323 | { |
| 2324 | if (qualifier.getType() == QtStorage) |
| 2325 | { |
| 2326 | const TStorageQualifierWrapper &storageQualifier = |
| 2327 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 2328 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 2329 | !symbolTable.atGlobalLevel()) |
| 2330 | { |
| 2331 | error(storageQualifier.getLine(), |
| 2332 | "Local variables can only use the const storage qualifier.", |
Olli Etuaho | 1a3bbaa | 2018-01-25 11:41:31 +0200 | [diff] [blame] | 2333 | storageQualifier.getQualifierString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2334 | } |
| 2335 | } |
| 2336 | } |
| 2337 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2338 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2339 | const TSourceLoc &location) |
| 2340 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2341 | const std::string reason( |
| 2342 | "Only allowed with shader storage blocks, variables declared within shader storage blocks " |
| 2343 | "and variables declared as image types."); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2344 | if (memoryQualifier.readonly) |
| 2345 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2346 | error(location, reason.c_str(), "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2347 | } |
| 2348 | if (memoryQualifier.writeonly) |
| 2349 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2350 | error(location, reason.c_str(), "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2351 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2352 | if (memoryQualifier.coherent) |
| 2353 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2354 | error(location, reason.c_str(), "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2355 | } |
| 2356 | if (memoryQualifier.restrictQualifier) |
| 2357 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2358 | error(location, reason.c_str(), "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2359 | } |
| 2360 | if (memoryQualifier.volatileQualifier) |
| 2361 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2362 | error(location, reason.c_str(), "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2363 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2364 | } |
| 2365 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2366 | // Make sure there is no offset overlapping, and store the newly assigned offset to "type" in |
| 2367 | // intermediate tree. |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2368 | void TParseContext::checkAtomicCounterOffsetDoesNotOverlap(bool forceAppend, |
| 2369 | const TSourceLoc &loc, |
| 2370 | TType *type) |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2371 | { |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2372 | const size_t size = type->isArray() ? kAtomicCounterArrayStride * type->getArraySizeProduct() |
| 2373 | : kAtomicCounterSize; |
| 2374 | TLayoutQualifier layoutQualifier = type->getLayoutQualifier(); |
| 2375 | auto &bindingState = mAtomicCounterBindingStates[layoutQualifier.binding]; |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2376 | int offset; |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2377 | if (layoutQualifier.offset == -1 || forceAppend) |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2378 | { |
| 2379 | offset = bindingState.appendSpan(size); |
| 2380 | } |
| 2381 | else |
| 2382 | { |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2383 | offset = bindingState.insertSpan(layoutQualifier.offset, size); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2384 | } |
| 2385 | if (offset == -1) |
| 2386 | { |
| 2387 | error(loc, "Offset overlapping", "atomic counter"); |
| 2388 | return; |
| 2389 | } |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2390 | layoutQualifier.offset = offset; |
| 2391 | type->setLayoutQualifier(layoutQualifier); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2392 | } |
| 2393 | |
Enrico Galli | ee7ffd9 | 2018-12-13 14:07:52 -0800 | [diff] [blame] | 2394 | void TParseContext::checkAtomicCounterOffsetAlignment(const TSourceLoc &location, const TType &type) |
| 2395 | { |
| 2396 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
| 2397 | |
| 2398 | // OpenGL ES 3.1 Table 6.5, Atomic counter offset must be a multiple of 4 |
| 2399 | if (layoutQualifier.offset % 4 != 0) |
| 2400 | { |
| 2401 | error(location, "Offset must be multiple of 4", "atomic counter"); |
| 2402 | } |
| 2403 | } |
| 2404 | |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2405 | void TParseContext::checkGeometryShaderInputAndSetArraySize(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2406 | const ImmutableString &token, |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2407 | TType *type) |
| 2408 | { |
| 2409 | if (IsGeometryShaderInput(mShaderType, type->getQualifier())) |
| 2410 | { |
| 2411 | if (type->isArray() && type->getOutermostArraySize() == 0u) |
| 2412 | { |
| 2413 | // Set size for the unsized geometry shader inputs if they are declared after a valid |
| 2414 | // input primitive declaration. |
| 2415 | if (mGeometryShaderInputPrimitiveType != EptUndefined) |
| 2416 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2417 | ASSERT(symbolTable.getGlInVariableWithArraySize() != nullptr); |
Olli Etuaho | c74ec1a | 2018-01-09 15:23:28 +0200 | [diff] [blame] | 2418 | type->sizeOutermostUnsizedArray( |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2419 | symbolTable.getGlInVariableWithArraySize()->getType().getOutermostArraySize()); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2420 | } |
| 2421 | else |
| 2422 | { |
| 2423 | // [GLSL ES 3.2 SPEC Chapter 4.4.1.2] |
| 2424 | // An input can be declared without an array size if there is a previous layout |
| 2425 | // which specifies the size. |
| 2426 | error(location, |
| 2427 | "Missing a valid input primitive declaration before declaring an unsized " |
| 2428 | "array input", |
| 2429 | token); |
| 2430 | } |
| 2431 | } |
| 2432 | else if (type->isArray()) |
| 2433 | { |
| 2434 | setGeometryShaderInputArraySize(type->getOutermostArraySize(), location); |
| 2435 | } |
| 2436 | else |
| 2437 | { |
| 2438 | error(location, "Geometry shader input variable must be declared as an array", token); |
| 2439 | } |
| 2440 | } |
| 2441 | } |
| 2442 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2443 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 2444 | TPublicType &publicType, |
| 2445 | const TSourceLoc &identifierOrTypeLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2446 | const ImmutableString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2447 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2448 | TType *type = new TType(publicType); |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2449 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2450 | checkGeometryShaderInputAndSetArraySize(identifierOrTypeLocation, identifier, type); |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2451 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2452 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2453 | identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2454 | |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 2455 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2456 | mDeferredNonEmptyDeclarationErrorCheck = emptyDeclaration; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2457 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2458 | TIntermSymbol *symbol = nullptr; |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2459 | if (emptyDeclaration) |
| 2460 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2461 | emptyDeclarationErrorCheck(*type, identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2462 | // In most cases we don't need to create a symbol node for an empty declaration. |
| 2463 | // But if the empty declaration is declaring a struct type, the symbol node will store that. |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2464 | if (type->getBasicType() == EbtStruct) |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2465 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2466 | TVariable *emptyVariable = |
Jamie Madill | b779b12 | 2018-06-20 11:46:43 -0400 | [diff] [blame] | 2467 | new TVariable(&symbolTable, kEmptyImmutableString, type, SymbolType::Empty); |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2468 | symbol = new TIntermSymbol(emptyVariable); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2469 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2470 | else if (IsAtomicCounter(publicType.getBasicType())) |
| 2471 | { |
| 2472 | setAtomicCounterBindingDefaultOffset(publicType, identifierOrTypeLocation); |
| 2473 | } |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2474 | } |
| 2475 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2476 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2477 | nonEmptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2478 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2479 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, type); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2480 | |
Enrico Galli | ee7ffd9 | 2018-12-13 14:07:52 -0800 | [diff] [blame] | 2481 | if (IsAtomicCounter(type->getBasicType())) |
| 2482 | { |
| 2483 | checkAtomicCounterOffsetDoesNotOverlap(false, identifierOrTypeLocation, type); |
| 2484 | |
| 2485 | checkAtomicCounterOffsetAlignment(identifierOrTypeLocation, *type); |
| 2486 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2487 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2488 | TVariable *variable = nullptr; |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2489 | if (declareVariable(identifierOrTypeLocation, identifier, type, &variable)) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2490 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2491 | symbol = new TIntermSymbol(variable); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2492 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2493 | } |
| 2494 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2495 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2496 | declaration->setLine(identifierOrTypeLocation); |
| 2497 | if (symbol) |
| 2498 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2499 | symbol->setLine(identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2500 | declaration->appendDeclarator(symbol); |
| 2501 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2502 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2503 | } |
| 2504 | |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2505 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration( |
| 2506 | TPublicType &elementType, |
| 2507 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2508 | const ImmutableString &identifier, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2509 | const TSourceLoc &indexLocation, |
| 2510 | const TVector<unsigned int> &arraySizes) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2511 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2512 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2513 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2514 | declarationQualifierErrorCheck(elementType.qualifier, elementType.layoutQualifier, |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2515 | identifierLocation); |
| 2516 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2517 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2518 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2519 | checkIsValidTypeAndQualifierForArray(indexLocation, elementType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2520 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2521 | TType *arrayType = new TType(elementType); |
| 2522 | arrayType->makeArrays(arraySizes); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2523 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2524 | checkGeometryShaderInputAndSetArraySize(indexLocation, identifier, arrayType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2525 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2526 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, arrayType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2527 | |
Enrico Galli | ee7ffd9 | 2018-12-13 14:07:52 -0800 | [diff] [blame] | 2528 | if (IsAtomicCounter(arrayType->getBasicType())) |
| 2529 | { |
| 2530 | checkAtomicCounterOffsetDoesNotOverlap(false, identifierLocation, arrayType); |
| 2531 | |
| 2532 | checkAtomicCounterOffsetAlignment(identifierLocation, *arrayType); |
| 2533 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2534 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2535 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2536 | declaration->setLine(identifierLocation); |
| 2537 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2538 | TVariable *variable = nullptr; |
| 2539 | if (declareVariable(identifierLocation, identifier, arrayType, &variable)) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2540 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2541 | TIntermSymbol *symbol = new TIntermSymbol(variable); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2542 | symbol->setLine(identifierLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2543 | declaration->appendDeclarator(symbol); |
| 2544 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2545 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2546 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2547 | } |
| 2548 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2549 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2550 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2551 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2552 | const TSourceLoc &initLocation, |
| 2553 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2554 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2555 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2556 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2557 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2558 | identifierLocation); |
| 2559 | |
| 2560 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2561 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2562 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2563 | declaration->setLine(identifierLocation); |
| 2564 | |
| 2565 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2566 | TType *type = new TType(publicType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2567 | if (executeInitializer(identifierLocation, identifier, type, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2568 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2569 | if (initNode) |
| 2570 | { |
| 2571 | declaration->appendDeclarator(initNode); |
| 2572 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2573 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2574 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2575 | } |
| 2576 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2577 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2578 | TPublicType &elementType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2579 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2580 | const ImmutableString &identifier, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2581 | const TSourceLoc &indexLocation, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2582 | const TVector<unsigned int> &arraySizes, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2583 | const TSourceLoc &initLocation, |
| 2584 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2585 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2586 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2587 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2588 | declarationQualifierErrorCheck(elementType.qualifier, elementType.layoutQualifier, |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2589 | identifierLocation); |
| 2590 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2591 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2592 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2593 | checkIsValidTypeAndQualifierForArray(indexLocation, elementType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2594 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2595 | TType *arrayType = new TType(elementType); |
| 2596 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2597 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2598 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2599 | declaration->setLine(identifierLocation); |
| 2600 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2601 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2602 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2603 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2604 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2605 | if (initNode) |
| 2606 | { |
| 2607 | declaration->appendDeclarator(initNode); |
| 2608 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2609 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2610 | |
| 2611 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2612 | } |
| 2613 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2614 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2615 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2616 | const TSourceLoc &identifierLoc, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2617 | const ImmutableString &identifier, |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2618 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2619 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2620 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2621 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2622 | if (!typeQualifier.invariant) |
| 2623 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2624 | error(identifierLoc, "Expected invariant", identifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2625 | return nullptr; |
| 2626 | } |
| 2627 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2628 | { |
| 2629 | return nullptr; |
| 2630 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2631 | if (!symbol) |
| 2632 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2633 | error(identifierLoc, "undeclared identifier declared as invariant", identifier); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2634 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2635 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2636 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2637 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2638 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2639 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2640 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2641 | if (typeQualifier.precision != EbpUndefined) |
| 2642 | { |
| 2643 | error(identifierLoc, "invariant declaration specifies precision", |
| 2644 | getPrecisionString(typeQualifier.precision)); |
| 2645 | } |
| 2646 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2647 | { |
| 2648 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2649 | } |
| 2650 | |
| 2651 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 2652 | if (!variable) |
| 2653 | { |
| 2654 | return nullptr; |
| 2655 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2656 | const TType &type = variable->getType(); |
| 2657 | |
| 2658 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2659 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2660 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2661 | |
Olli Etuaho | 76b2c38 | 2018-03-19 15:51:29 +0200 | [diff] [blame] | 2662 | symbolTable.addInvariantVarying(*variable); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2663 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2664 | TIntermSymbol *intermSymbol = new TIntermSymbol(variable); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2665 | intermSymbol->setLine(identifierLoc); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2666 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2667 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2668 | } |
| 2669 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2670 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2671 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2672 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2673 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2674 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2675 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2676 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2677 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2678 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2679 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2680 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2681 | } |
| 2682 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2683 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2684 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2685 | TType *type = new TType(publicType); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2686 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2687 | checkGeometryShaderInputAndSetArraySize(identifierLocation, identifier, type); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2688 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2689 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, type); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2690 | |
Enrico Galli | ee7ffd9 | 2018-12-13 14:07:52 -0800 | [diff] [blame] | 2691 | if (IsAtomicCounter(type->getBasicType())) |
| 2692 | { |
| 2693 | checkAtomicCounterOffsetDoesNotOverlap(true, identifierLocation, type); |
| 2694 | |
| 2695 | checkAtomicCounterOffsetAlignment(identifierLocation, *type); |
| 2696 | } |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2697 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2698 | TVariable *variable = nullptr; |
| 2699 | if (declareVariable(identifierLocation, identifier, type, &variable)) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2700 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2701 | TIntermSymbol *symbol = new TIntermSymbol(variable); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2702 | symbol->setLine(identifierLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2703 | declarationOut->appendDeclarator(symbol); |
| 2704 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2705 | } |
| 2706 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2707 | void TParseContext::parseArrayDeclarator(TPublicType &elementType, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2708 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2709 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2710 | const TSourceLoc &arrayLocation, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2711 | const TVector<unsigned int> &arraySizes, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2712 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2713 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2714 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2715 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2716 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2717 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2718 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2719 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2720 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2721 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2722 | checkDeclaratorLocationIsNotSpecified(identifierLocation, elementType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2723 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2724 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, elementType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2725 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2726 | TType *arrayType = new TType(elementType); |
| 2727 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2728 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2729 | checkGeometryShaderInputAndSetArraySize(identifierLocation, identifier, arrayType); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2730 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2731 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, arrayType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2732 | |
Enrico Galli | ee7ffd9 | 2018-12-13 14:07:52 -0800 | [diff] [blame] | 2733 | if (IsAtomicCounter(arrayType->getBasicType())) |
| 2734 | { |
| 2735 | checkAtomicCounterOffsetDoesNotOverlap(true, identifierLocation, arrayType); |
| 2736 | |
| 2737 | checkAtomicCounterOffsetAlignment(identifierLocation, *arrayType); |
| 2738 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2739 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2740 | TVariable *variable = nullptr; |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2741 | if (declareVariable(identifierLocation, identifier, arrayType, &variable)) |
Olli Etuaho | d7ceaa1 | 2017-07-12 17:46:35 +0300 | [diff] [blame] | 2742 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2743 | TIntermSymbol *symbol = new TIntermSymbol(variable); |
Olli Etuaho | d7ceaa1 | 2017-07-12 17:46:35 +0300 | [diff] [blame] | 2744 | symbol->setLine(identifierLocation); |
| 2745 | declarationOut->appendDeclarator(symbol); |
| 2746 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2747 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2748 | } |
| 2749 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2750 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2751 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2752 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2753 | const TSourceLoc &initLocation, |
| 2754 | TIntermTyped *initializer, |
| 2755 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2756 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2757 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2758 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2759 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2760 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2761 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2762 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2763 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2764 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2765 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2766 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2767 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2768 | TType *type = new TType(publicType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2769 | if (executeInitializer(identifierLocation, identifier, type, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2770 | { |
| 2771 | // |
| 2772 | // build the intermediate representation |
| 2773 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2774 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2775 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2776 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2777 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2778 | } |
| 2779 | } |
| 2780 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2781 | void TParseContext::parseArrayInitDeclarator(const TPublicType &elementType, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2782 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2783 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2784 | const TSourceLoc &indexLocation, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2785 | const TVector<unsigned int> &arraySizes, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2786 | const TSourceLoc &initLocation, |
| 2787 | TIntermTyped *initializer, |
| 2788 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2789 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2790 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2791 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2792 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2793 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2794 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2795 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2796 | } |
| 2797 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2798 | checkDeclaratorLocationIsNotSpecified(identifierLocation, elementType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2799 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2800 | checkIsValidTypeAndQualifierForArray(indexLocation, elementType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2801 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2802 | TType *arrayType = new TType(elementType); |
| 2803 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2804 | |
| 2805 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2806 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2807 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2808 | { |
| 2809 | if (initNode) |
| 2810 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2811 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2812 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2813 | } |
| 2814 | } |
| 2815 | |
Olli Etuaho | b8ee9dd | 2017-10-30 12:43:27 +0200 | [diff] [blame] | 2816 | TIntermNode *TParseContext::addEmptyStatement(const TSourceLoc &location) |
| 2817 | { |
| 2818 | // It's simpler to parse an empty statement as a constant expression rather than having a |
| 2819 | // different type of node just for empty statements, that will be pruned from the AST anyway. |
| 2820 | TIntermNode *node = CreateZeroNode(TType(EbtInt, EbpMedium)); |
| 2821 | node->setLine(location); |
| 2822 | return node; |
| 2823 | } |
| 2824 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2825 | void TParseContext::setAtomicCounterBindingDefaultOffset(const TPublicType &publicType, |
| 2826 | const TSourceLoc &location) |
| 2827 | { |
| 2828 | const TLayoutQualifier &layoutQualifier = publicType.layoutQualifier; |
| 2829 | checkAtomicCounterBindingIsValid(location, layoutQualifier.binding); |
| 2830 | if (layoutQualifier.binding == -1 || layoutQualifier.offset == -1) |
| 2831 | { |
| 2832 | error(location, "Requires both binding and offset", "layout"); |
| 2833 | return; |
| 2834 | } |
| 2835 | mAtomicCounterBindingStates[layoutQualifier.binding].setDefaultOffset(layoutQualifier.offset); |
| 2836 | } |
| 2837 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2838 | void TParseContext::parseDefaultPrecisionQualifier(const TPrecision precision, |
| 2839 | const TPublicType &type, |
| 2840 | const TSourceLoc &loc) |
| 2841 | { |
| 2842 | if ((precision == EbpHigh) && (getShaderType() == GL_FRAGMENT_SHADER) && |
| 2843 | !getFragmentPrecisionHigh()) |
| 2844 | { |
| 2845 | error(loc, "precision is not supported in fragment shader", "highp"); |
| 2846 | } |
| 2847 | |
| 2848 | if (!CanSetDefaultPrecisionOnType(type)) |
| 2849 | { |
| 2850 | error(loc, "illegal type argument for default precision qualifier", |
| 2851 | getBasicString(type.getBasicType())); |
| 2852 | return; |
| 2853 | } |
| 2854 | symbolTable.setDefaultPrecision(type.getBasicType(), precision); |
| 2855 | } |
| 2856 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2857 | bool TParseContext::checkPrimitiveTypeMatchesTypeQualifier(const TTypeQualifier &typeQualifier) |
| 2858 | { |
| 2859 | switch (typeQualifier.layoutQualifier.primitiveType) |
| 2860 | { |
| 2861 | case EptLines: |
| 2862 | case EptLinesAdjacency: |
| 2863 | case EptTriangles: |
| 2864 | case EptTrianglesAdjacency: |
| 2865 | return typeQualifier.qualifier == EvqGeometryIn; |
| 2866 | |
| 2867 | case EptLineStrip: |
| 2868 | case EptTriangleStrip: |
| 2869 | return typeQualifier.qualifier == EvqGeometryOut; |
| 2870 | |
| 2871 | case EptPoints: |
| 2872 | return true; |
| 2873 | |
| 2874 | default: |
| 2875 | UNREACHABLE(); |
| 2876 | return false; |
| 2877 | } |
| 2878 | } |
| 2879 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2880 | void TParseContext::setGeometryShaderInputArraySize(unsigned int inputArraySize, |
| 2881 | const TSourceLoc &line) |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 2882 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2883 | if (!symbolTable.setGlInArraySize(inputArraySize)) |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2884 | { |
| 2885 | error(line, |
| 2886 | "Array size or input primitive declaration doesn't match the size of earlier sized " |
| 2887 | "array inputs.", |
| 2888 | "layout"); |
| 2889 | } |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 2890 | } |
| 2891 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2892 | bool TParseContext::parseGeometryShaderInputLayoutQualifier(const TTypeQualifier &typeQualifier) |
| 2893 | { |
| 2894 | ASSERT(typeQualifier.qualifier == EvqGeometryIn); |
| 2895 | |
| 2896 | const TLayoutQualifier &layoutQualifier = typeQualifier.layoutQualifier; |
| 2897 | |
| 2898 | if (layoutQualifier.maxVertices != -1) |
| 2899 | { |
| 2900 | error(typeQualifier.line, |
| 2901 | "max_vertices can only be declared in 'out' layout in a geometry shader", "layout"); |
| 2902 | return false; |
| 2903 | } |
| 2904 | |
| 2905 | // Set mGeometryInputPrimitiveType if exists |
| 2906 | if (layoutQualifier.primitiveType != EptUndefined) |
| 2907 | { |
| 2908 | if (!checkPrimitiveTypeMatchesTypeQualifier(typeQualifier)) |
| 2909 | { |
| 2910 | error(typeQualifier.line, "invalid primitive type for 'in' layout", "layout"); |
| 2911 | return false; |
| 2912 | } |
| 2913 | |
| 2914 | if (mGeometryShaderInputPrimitiveType == EptUndefined) |
| 2915 | { |
| 2916 | mGeometryShaderInputPrimitiveType = layoutQualifier.primitiveType; |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2917 | setGeometryShaderInputArraySize( |
| 2918 | GetGeometryShaderInputArraySize(mGeometryShaderInputPrimitiveType), |
| 2919 | typeQualifier.line); |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2920 | } |
| 2921 | else if (mGeometryShaderInputPrimitiveType != layoutQualifier.primitiveType) |
| 2922 | { |
| 2923 | error(typeQualifier.line, "primitive doesn't match earlier input primitive declaration", |
| 2924 | "layout"); |
| 2925 | return false; |
| 2926 | } |
| 2927 | } |
| 2928 | |
| 2929 | // Set mGeometryInvocations if exists |
| 2930 | if (layoutQualifier.invocations > 0) |
| 2931 | { |
| 2932 | if (mGeometryShaderInvocations == 0) |
| 2933 | { |
| 2934 | mGeometryShaderInvocations = layoutQualifier.invocations; |
| 2935 | } |
| 2936 | else if (mGeometryShaderInvocations != layoutQualifier.invocations) |
| 2937 | { |
| 2938 | error(typeQualifier.line, "invocations contradicts to the earlier declaration", |
| 2939 | "layout"); |
| 2940 | return false; |
| 2941 | } |
| 2942 | } |
| 2943 | |
| 2944 | return true; |
| 2945 | } |
| 2946 | |
| 2947 | bool TParseContext::parseGeometryShaderOutputLayoutQualifier(const TTypeQualifier &typeQualifier) |
| 2948 | { |
| 2949 | ASSERT(typeQualifier.qualifier == EvqGeometryOut); |
| 2950 | |
| 2951 | const TLayoutQualifier &layoutQualifier = typeQualifier.layoutQualifier; |
| 2952 | |
| 2953 | if (layoutQualifier.invocations > 0) |
| 2954 | { |
| 2955 | error(typeQualifier.line, |
| 2956 | "invocations can only be declared in 'in' layout in a geometry shader", "layout"); |
| 2957 | return false; |
| 2958 | } |
| 2959 | |
| 2960 | // Set mGeometryOutputPrimitiveType if exists |
| 2961 | if (layoutQualifier.primitiveType != EptUndefined) |
| 2962 | { |
| 2963 | if (!checkPrimitiveTypeMatchesTypeQualifier(typeQualifier)) |
| 2964 | { |
| 2965 | error(typeQualifier.line, "invalid primitive type for 'out' layout", "layout"); |
| 2966 | return false; |
| 2967 | } |
| 2968 | |
| 2969 | if (mGeometryShaderOutputPrimitiveType == EptUndefined) |
| 2970 | { |
| 2971 | mGeometryShaderOutputPrimitiveType = layoutQualifier.primitiveType; |
| 2972 | } |
| 2973 | else if (mGeometryShaderOutputPrimitiveType != layoutQualifier.primitiveType) |
| 2974 | { |
| 2975 | error(typeQualifier.line, |
| 2976 | "primitive doesn't match earlier output primitive declaration", "layout"); |
| 2977 | return false; |
| 2978 | } |
| 2979 | } |
| 2980 | |
| 2981 | // Set mGeometryMaxVertices if exists |
| 2982 | if (layoutQualifier.maxVertices > -1) |
| 2983 | { |
| 2984 | if (mGeometryShaderMaxVertices == -1) |
| 2985 | { |
| 2986 | mGeometryShaderMaxVertices = layoutQualifier.maxVertices; |
| 2987 | } |
| 2988 | else if (mGeometryShaderMaxVertices != layoutQualifier.maxVertices) |
| 2989 | { |
| 2990 | error(typeQualifier.line, "max_vertices contradicts to the earlier declaration", |
| 2991 | "layout"); |
| 2992 | return false; |
| 2993 | } |
| 2994 | } |
| 2995 | |
| 2996 | return true; |
| 2997 | } |
| 2998 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2999 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3000 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3001 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3002 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 3003 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3004 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 3005 | typeQualifier.line); |
| 3006 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 3007 | // It should never be the case, but some strange parser errors can send us here. |
| 3008 | if (layoutQualifier.isEmpty()) |
| 3009 | { |
| 3010 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 3011 | return; |
| 3012 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3013 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3014 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3015 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3016 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3017 | return; |
| 3018 | } |
| 3019 | |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 3020 | checkIndexIsNotSpecified(typeQualifier.line, layoutQualifier.index); |
| 3021 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3022 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 3023 | |
| 3024 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3025 | |
| 3026 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 3027 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3028 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 3029 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 3030 | checkOffsetIsNotSpecified(typeQualifier.line, layoutQualifier.offset); |
| 3031 | |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 3032 | checkStd430IsForShaderStorageBlock(typeQualifier.line, layoutQualifier.blockStorage, |
| 3033 | typeQualifier.qualifier); |
| 3034 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3035 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3036 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3037 | if (mComputeShaderLocalSizeDeclared && |
| 3038 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 3039 | { |
| 3040 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 3041 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3042 | return; |
| 3043 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3044 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3045 | if (mShaderVersion < 310) |
| 3046 | { |
| 3047 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3048 | return; |
| 3049 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3050 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3051 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3052 | { |
| 3053 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3054 | return; |
| 3055 | } |
| 3056 | |
| 3057 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3058 | symbolTable.findBuiltIn(ImmutableString("gl_MaxComputeWorkGroupSize"), mShaderVersion)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3059 | |
| 3060 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 3061 | maxComputeWorkGroupSize->getConstPointer(); |
| 3062 | |
| 3063 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 3064 | { |
| 3065 | if (layoutQualifier.localSize[i] != -1) |
| 3066 | { |
| 3067 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 3068 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 3069 | if (mComputeShaderLocalSize[i] < 1 || |
| 3070 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 3071 | { |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 3072 | std::stringstream reasonStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3073 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 3074 | << maxComputeWorkGroupSizeValue; |
| 3075 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3076 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3077 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3078 | return; |
| 3079 | } |
| 3080 | } |
| 3081 | } |
| 3082 | |
| 3083 | mComputeShaderLocalSizeDeclared = true; |
| 3084 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 3085 | else if (typeQualifier.qualifier == EvqGeometryIn) |
| 3086 | { |
| 3087 | if (mShaderVersion < 310) |
| 3088 | { |
| 3089 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
| 3090 | return; |
| 3091 | } |
| 3092 | |
| 3093 | if (!parseGeometryShaderInputLayoutQualifier(typeQualifier)) |
| 3094 | { |
| 3095 | return; |
| 3096 | } |
| 3097 | } |
| 3098 | else if (typeQualifier.qualifier == EvqGeometryOut) |
| 3099 | { |
| 3100 | if (mShaderVersion < 310) |
| 3101 | { |
| 3102 | error(typeQualifier.line, "out type qualifier supported in GLSL ES 3.10 only", |
| 3103 | "layout"); |
| 3104 | return; |
| 3105 | } |
| 3106 | |
| 3107 | if (!parseGeometryShaderOutputLayoutQualifier(typeQualifier)) |
| 3108 | { |
| 3109 | return; |
| 3110 | } |
| 3111 | } |
Mingyu Hu | ebab670 | 2019-04-19 14:36:45 -0700 | [diff] [blame^] | 3112 | else if (anyMultiviewExtensionAvailable() && typeQualifier.qualifier == EvqVertexIn) |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3113 | { |
| 3114 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 3115 | // specification. |
| 3116 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 3117 | { |
| 3118 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 3119 | "layout"); |
| 3120 | return; |
| 3121 | } |
| 3122 | |
| 3123 | if (layoutQualifier.numViews == -1) |
| 3124 | { |
| 3125 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 3126 | return; |
| 3127 | } |
| 3128 | |
| 3129 | if (layoutQualifier.numViews > mMaxNumViews) |
| 3130 | { |
| 3131 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 3132 | "layout"); |
| 3133 | return; |
| 3134 | } |
| 3135 | |
| 3136 | mNumViews = layoutQualifier.numViews; |
| 3137 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3138 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3139 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3140 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3141 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3142 | return; |
| 3143 | } |
| 3144 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3145 | if (typeQualifier.qualifier != EvqUniform && typeQualifier.qualifier != EvqBuffer) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3146 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3147 | error(typeQualifier.line, "invalid qualifier: global layout can only be set for blocks", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3148 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3149 | return; |
| 3150 | } |
| 3151 | |
| 3152 | if (mShaderVersion < 300) |
| 3153 | { |
| 3154 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 3155 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3156 | return; |
| 3157 | } |
| 3158 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3159 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3160 | |
| 3161 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 3162 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3163 | if (typeQualifier.qualifier == EvqUniform) |
| 3164 | { |
| 3165 | mDefaultUniformMatrixPacking = layoutQualifier.matrixPacking; |
| 3166 | } |
| 3167 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3168 | { |
| 3169 | mDefaultBufferMatrixPacking = layoutQualifier.matrixPacking; |
| 3170 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3171 | } |
| 3172 | |
| 3173 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 3174 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3175 | if (typeQualifier.qualifier == EvqUniform) |
| 3176 | { |
| 3177 | mDefaultUniformBlockStorage = layoutQualifier.blockStorage; |
| 3178 | } |
| 3179 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3180 | { |
| 3181 | mDefaultBufferBlockStorage = layoutQualifier.blockStorage; |
| 3182 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3183 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3184 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3185 | } |
| 3186 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3187 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 3188 | const TFunction &function, |
| 3189 | const TSourceLoc &location, |
| 3190 | bool insertParametersToSymbolTable) |
| 3191 | { |
Olli Etuaho | bed35d7 | 2017-12-20 16:36:26 +0200 | [diff] [blame] | 3192 | checkIsNotReserved(location, function.name()); |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 3193 | |
Olli Etuaho | beb6dc7 | 2017-12-14 16:03:03 +0200 | [diff] [blame] | 3194 | TIntermFunctionPrototype *prototype = new TIntermFunctionPrototype(&function); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3195 | prototype->setLine(location); |
| 3196 | |
| 3197 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 3198 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3199 | const TVariable *param = function.getParam(i); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3200 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3201 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 3202 | // be used for unused args). |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3203 | if (param->symbolType() != SymbolType::Empty) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3204 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3205 | if (insertParametersToSymbolTable) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3206 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3207 | if (!symbolTable.declare(const_cast<TVariable *>(param))) |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3208 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3209 | error(location, "redefinition", param->name()); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3210 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3211 | } |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3212 | // Unsized type of a named parameter should have already been checked and sanitized. |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3213 | ASSERT(!param->getType().isUnsizedArray()); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3214 | } |
| 3215 | else |
| 3216 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3217 | if (param->getType().isUnsizedArray()) |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3218 | { |
| 3219 | error(location, "function parameter array must be sized at compile time", "[]"); |
| 3220 | // We don't need to size the arrays since the parameter is unnamed and hence |
| 3221 | // inaccessible. |
| 3222 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3223 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3224 | } |
| 3225 | return prototype; |
| 3226 | } |
| 3227 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 3228 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 3229 | const TFunction &parsedFunction, |
| 3230 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3231 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3232 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 3233 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 3234 | // function is declared multiple times. |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3235 | bool hadPrototypeDeclaration = false; |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3236 | const TFunction *function = symbolTable.markFunctionHasPrototypeDeclaration( |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3237 | parsedFunction.getMangledName(), &hadPrototypeDeclaration); |
| 3238 | |
| 3239 | if (hadPrototypeDeclaration && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3240 | { |
| 3241 | // ESSL 1.00.17 section 4.2.7. |
| 3242 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 3243 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3244 | } |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3245 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3246 | TIntermFunctionPrototype *prototype = |
| 3247 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3248 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3249 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 3250 | |
| 3251 | if (!symbolTable.atGlobalLevel()) |
| 3252 | { |
| 3253 | // ESSL 3.00.4 section 4.2.4. |
| 3254 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 3255 | } |
| 3256 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3257 | return prototype; |
| 3258 | } |
| 3259 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3260 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3261 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3262 | TIntermBlock *functionBody, |
| 3263 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3264 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3265 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3266 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 3267 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3268 | error(location, |
| 3269 | "function does not return a value:", functionPrototype->getFunction()->name()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3270 | } |
| 3271 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3272 | if (functionBody == nullptr) |
| 3273 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3274 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3275 | functionBody->setLine(location); |
| 3276 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3277 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3278 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3279 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3280 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3281 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3282 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3283 | } |
| 3284 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3285 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3286 | const TFunction *function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3287 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3288 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3289 | ASSERT(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3290 | |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3291 | bool wasDefined = false; |
| 3292 | function = symbolTable.setFunctionParameterNamesFromDefinition(function, &wasDefined); |
| 3293 | if (wasDefined) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3294 | { |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3295 | error(location, "function already has a body", function->name()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3296 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3297 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3298 | // Remember the return type for later checking for return statements. |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3299 | mCurrentFunctionType = &(function->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3300 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3301 | |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3302 | *prototypeOut = createPrototypeNodeFromFunction(*function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3303 | setLoopNestingLevel(0); |
| 3304 | } |
| 3305 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3306 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3307 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3308 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3309 | // We don't know at this point whether this is a function definition or a prototype. |
| 3310 | // The definition production code will check for redefinitions. |
| 3311 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3312 | // |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3313 | |
Olli Etuaho | d80f294 | 2017-11-06 12:44:45 +0200 | [diff] [blame] | 3314 | for (size_t i = 0u; i < function->getParamCount(); ++i) |
| 3315 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3316 | const TVariable *param = function->getParam(i); |
| 3317 | if (param->getType().isStructSpecifier()) |
Olli Etuaho | d80f294 | 2017-11-06 12:44:45 +0200 | [diff] [blame] | 3318 | { |
| 3319 | // ESSL 3.00.6 section 12.10. |
| 3320 | error(location, "Function parameter type cannot be a structure definition", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3321 | function->name()); |
Olli Etuaho | d80f294 | 2017-11-06 12:44:45 +0200 | [diff] [blame] | 3322 | } |
| 3323 | } |
| 3324 | |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3325 | if (getShaderVersion() >= 300) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3326 | { |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3327 | const UnmangledBuiltIn *builtIn = |
| 3328 | symbolTable.getUnmangledBuiltInForShaderVersion(function->name(), getShaderVersion()); |
| 3329 | if (builtIn && |
| 3330 | (builtIn->extension == TExtension::UNDEFINED || isExtensionEnabled(builtIn->extension))) |
| 3331 | { |
| 3332 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as |
| 3333 | // functions. Therefore overloading or redefining builtin functions is an error. |
| 3334 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 3335 | function->name()); |
| 3336 | } |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3337 | } |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3338 | else |
| 3339 | { |
| 3340 | // ESSL 1.00.17 section 4.2.6: built-ins can be overloaded but not redefined. We assume that |
| 3341 | // this applies to redeclarations as well. |
| 3342 | const TSymbol *builtIn = |
| 3343 | symbolTable.findBuiltIn(function->getMangledName(), getShaderVersion()); |
| 3344 | if (builtIn) |
| 3345 | { |
| 3346 | error(location, "built-in functions cannot be redefined", function->name()); |
| 3347 | } |
| 3348 | } |
| 3349 | |
| 3350 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 3351 | // here. |
| 3352 | const TFunction *prevDec = |
| 3353 | static_cast<const TFunction *>(symbolTable.findGlobal(function->getMangledName())); |
| 3354 | if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3355 | { |
| 3356 | if (prevDec->getReturnType() != function->getReturnType()) |
| 3357 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3358 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3359 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3360 | } |
| 3361 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 3362 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3363 | if (prevDec->getParam(i)->getType().getQualifier() != |
| 3364 | function->getParam(i)->getType().getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3365 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3366 | error(location, |
| 3367 | "function must have the same parameter qualifiers in all of its declarations", |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3368 | function->getParam(i)->getType().getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3369 | } |
| 3370 | } |
| 3371 | } |
| 3372 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3373 | // Check for previously declared variables using the same name. |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3374 | const TSymbol *prevSym = symbolTable.find(function->name(), getShaderVersion()); |
| 3375 | bool insertUnmangledName = true; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3376 | if (prevSym) |
| 3377 | { |
| 3378 | if (!prevSym->isFunction()) |
| 3379 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3380 | error(location, "redefinition of a function", function->name()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3381 | } |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3382 | insertUnmangledName = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3383 | } |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3384 | // Parsing is at the inner scope level of the function's arguments and body statement at this |
| 3385 | // point, but declareUserDefinedFunction takes care of declaring the function at the global |
| 3386 | // scope. |
| 3387 | symbolTable.declareUserDefinedFunction(function, insertUnmangledName); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3388 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 3389 | // Raise error message if main function takes any parameters or return anything other than void |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3390 | if (function->isMain()) |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 3391 | { |
| 3392 | if (function->getParamCount() > 0) |
| 3393 | { |
| 3394 | error(location, "function cannot take any parameter(s)", "main"); |
| 3395 | } |
| 3396 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 3397 | { |
| 3398 | error(location, "main function cannot return a value", |
| 3399 | function->getReturnType().getBasicString()); |
| 3400 | } |
| 3401 | } |
| 3402 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3403 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3404 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 3405 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3406 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 3407 | // |
| 3408 | return function; |
| 3409 | } |
| 3410 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3411 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3412 | const ImmutableString &name, |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3413 | const TSourceLoc &location) |
| 3414 | { |
| 3415 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 3416 | { |
| 3417 | error(location, "no qualifiers allowed for function return", |
| 3418 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3419 | } |
| 3420 | if (!type.layoutQualifier.isEmpty()) |
| 3421 | { |
| 3422 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3423 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3424 | // make sure an opaque type is not involved as well... |
| 3425 | std::string reason(getBasicString(type.getBasicType())); |
| 3426 | reason += "s can't be function return values"; |
| 3427 | checkIsNotOpaqueType(location, type.typeSpecifierNonArray, reason.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3428 | if (mShaderVersion < 300) |
| 3429 | { |
| 3430 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 3431 | // return values in ESSL 1.00. |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3432 | ASSERT(!type.isArray() || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3433 | |
| 3434 | if (type.isStructureContainingArrays()) |
| 3435 | { |
| 3436 | // ESSL 1.00.17 section 6.1 Function Definitions |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 3437 | TInfoSinkBase typeString; |
| 3438 | typeString << TType(type); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3439 | error(location, "structures containing arrays can't be function return values", |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 3440 | typeString.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3441 | } |
| 3442 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3443 | |
| 3444 | // Add the function as a prototype after parsing it (we do not support recursion) |
Olli Etuaho | 029e8ca | 2018-02-16 14:06:49 +0200 | [diff] [blame] | 3445 | return new TFunction(&symbolTable, name, SymbolType::UserDefined, new TType(type), false); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3446 | } |
| 3447 | |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 3448 | TFunctionLookup *TParseContext::addNonConstructorFunc(const ImmutableString &name, |
| 3449 | const TSymbol *symbol) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3450 | { |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 3451 | return TFunctionLookup::CreateFunctionCall(name, symbol); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3452 | } |
| 3453 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3454 | TFunctionLookup *TParseContext::addConstructorFunc(const TPublicType &publicType) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3455 | { |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3456 | if (mShaderVersion < 300 && publicType.isArray()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3457 | { |
| 3458 | error(publicType.getLine(), "array constructor supported in GLSL ES 3.00 and above only", |
| 3459 | "[]"); |
| 3460 | } |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3461 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3462 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3463 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 3464 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3465 | } |
| 3466 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3467 | TType *type = new TType(publicType); |
| 3468 | if (!type->canBeConstructed()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3469 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3470 | error(publicType.getLine(), "cannot construct this type", |
| 3471 | getBasicString(publicType.getBasicType())); |
| 3472 | type->setBasicType(EbtFloat); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3473 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3474 | return TFunctionLookup::CreateConstructor(type); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3475 | } |
| 3476 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3477 | void TParseContext::checkIsNotUnsizedArray(const TSourceLoc &line, |
| 3478 | const char *errorMessage, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3479 | const ImmutableString &token, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3480 | TType *arrayType) |
| 3481 | { |
| 3482 | if (arrayType->isUnsizedArray()) |
| 3483 | { |
| 3484 | error(line, errorMessage, token); |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3485 | arrayType->sizeUnsizedArrays(nullptr); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3486 | } |
| 3487 | } |
| 3488 | |
| 3489 | TParameter TParseContext::parseParameterDeclarator(TType *type, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3490 | const ImmutableString &name, |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3491 | const TSourceLoc &nameLoc) |
| 3492 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3493 | ASSERT(type); |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3494 | checkIsNotUnsizedArray(nameLoc, "function parameter array must specify a size", name, type); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3495 | if (type->getBasicType() == EbtVoid) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3496 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3497 | error(nameLoc, "illegal use of type 'void'", name); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3498 | } |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3499 | checkIsNotReserved(nameLoc, name); |
| 3500 | TParameter param = {name.data(), type}; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3501 | return param; |
| 3502 | } |
| 3503 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3504 | TParameter TParseContext::parseParameterDeclarator(const TPublicType &publicType, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3505 | const ImmutableString &name, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3506 | const TSourceLoc &nameLoc) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3507 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3508 | TType *type = new TType(publicType); |
| 3509 | return parseParameterDeclarator(type, name, nameLoc); |
| 3510 | } |
| 3511 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3512 | TParameter TParseContext::parseParameterArrayDeclarator(const ImmutableString &name, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3513 | const TSourceLoc &nameLoc, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3514 | const TVector<unsigned int> &arraySizes, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3515 | const TSourceLoc &arrayLoc, |
| 3516 | TPublicType *elementType) |
| 3517 | { |
| 3518 | checkArrayElementIsNotArray(arrayLoc, *elementType); |
| 3519 | TType *arrayType = new TType(*elementType); |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3520 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3521 | return parseParameterDeclarator(arrayType, name, nameLoc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3522 | } |
| 3523 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3524 | bool TParseContext::checkUnsizedArrayConstructorArgumentDimensionality( |
| 3525 | const TIntermSequence &arguments, |
| 3526 | TType type, |
| 3527 | const TSourceLoc &line) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3528 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3529 | if (arguments.empty()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3530 | { |
| 3531 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 3532 | return false; |
| 3533 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3534 | for (TIntermNode *arg : arguments) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3535 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3536 | const TIntermTyped *element = arg->getAsTyped(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3537 | ASSERT(element); |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3538 | size_t dimensionalityFromElement = element->getType().getNumArraySizes() + 1u; |
| 3539 | if (dimensionalityFromElement > type.getNumArraySizes()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3540 | { |
| 3541 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 3542 | return false; |
| 3543 | } |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3544 | else if (dimensionalityFromElement < type.getNumArraySizes()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3545 | { |
| 3546 | if (dimensionalityFromElement == 1u) |
| 3547 | { |
| 3548 | error(line, "implicitly sized array of arrays constructor argument is not an array", |
| 3549 | "constructor"); |
| 3550 | } |
| 3551 | else |
| 3552 | { |
| 3553 | error(line, |
| 3554 | "implicitly sized array of arrays constructor argument dimensionality is too " |
| 3555 | "low", |
| 3556 | "constructor"); |
| 3557 | } |
| 3558 | return false; |
| 3559 | } |
| 3560 | } |
| 3561 | return true; |
| 3562 | } |
| 3563 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3564 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 3565 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3566 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3567 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3568 | // |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3569 | TIntermTyped *TParseContext::addConstructor(TFunctionLookup *fnCall, const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3570 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3571 | TType type = fnCall->constructorType(); |
| 3572 | TIntermSequence &arguments = fnCall->arguments(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3573 | if (type.isUnsizedArray()) |
| 3574 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3575 | if (!checkUnsizedArrayConstructorArgumentDimensionality(arguments, type, line)) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3576 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3577 | type.sizeUnsizedArrays(nullptr); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3578 | return CreateZeroNode(type); |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3579 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3580 | TIntermTyped *firstElement = arguments.at(0)->getAsTyped(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3581 | ASSERT(firstElement); |
Olli Etuaho | 9cd7163 | 2017-10-26 14:43:20 +0300 | [diff] [blame] | 3582 | if (type.getOutermostArraySize() == 0u) |
| 3583 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3584 | type.sizeOutermostUnsizedArray(static_cast<unsigned int>(arguments.size())); |
Olli Etuaho | 9cd7163 | 2017-10-26 14:43:20 +0300 | [diff] [blame] | 3585 | } |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3586 | for (size_t i = 0; i < firstElement->getType().getNumArraySizes(); ++i) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3587 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3588 | if ((*type.getArraySizes())[i] == 0u) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3589 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3590 | type.setArraySize(i, (*firstElement->getType().getArraySizes())[i]); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3591 | } |
| 3592 | } |
| 3593 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3594 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3595 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3596 | if (!checkConstructorArguments(line, arguments, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3597 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3598 | return CreateZeroNode(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3599 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3600 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3601 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, &arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3602 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3603 | |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 3604 | return constructorNode->fold(mDiagnostics); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3605 | } |
| 3606 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3607 | // |
| 3608 | // Interface/uniform blocks |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 3609 | // TODO(jiawei.shao@intel.com): implement GL_EXT_shader_io_blocks. |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3610 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3611 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3612 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3613 | const TSourceLoc &nameLine, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3614 | const ImmutableString &blockName, |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3615 | TFieldList *fieldList, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3616 | const ImmutableString &instanceName, |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3617 | const TSourceLoc &instanceLine, |
| 3618 | TIntermTyped *arrayIndex, |
| 3619 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3620 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3621 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3622 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3623 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3624 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3625 | if (mShaderVersion < 310 && typeQualifier.qualifier != EvqUniform) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3626 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3627 | error(typeQualifier.line, |
| 3628 | "invalid qualifier: interface blocks must be uniform in version lower than GLSL ES " |
| 3629 | "3.10", |
| 3630 | getQualifierString(typeQualifier.qualifier)); |
| 3631 | } |
| 3632 | else if (typeQualifier.qualifier != EvqUniform && typeQualifier.qualifier != EvqBuffer) |
| 3633 | { |
| 3634 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform or buffer", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3635 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3636 | } |
| 3637 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3638 | if (typeQualifier.invariant) |
| 3639 | { |
| 3640 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 3641 | } |
| 3642 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3643 | if (typeQualifier.qualifier != EvqBuffer) |
| 3644 | { |
| 3645 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 3646 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3647 | |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3648 | // add array index |
| 3649 | unsigned int arraySize = 0; |
| 3650 | if (arrayIndex != nullptr) |
| 3651 | { |
| 3652 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
| 3653 | } |
| 3654 | |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 3655 | checkIndexIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.index); |
| 3656 | |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3657 | if (mShaderVersion < 310) |
| 3658 | { |
| 3659 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
| 3660 | } |
| 3661 | else |
| 3662 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3663 | checkBlockBindingIsValid(typeQualifier.line, typeQualifier.qualifier, |
| 3664 | typeQualifier.layoutQualifier.binding, arraySize); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3665 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3666 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3667 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 3668 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3669 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3670 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 3671 | checkStd430IsForShaderStorageBlock(typeQualifier.line, blockLayoutQualifier.blockStorage, |
| 3672 | typeQualifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3673 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3674 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 3675 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3676 | if (typeQualifier.qualifier == EvqUniform) |
| 3677 | { |
| 3678 | blockLayoutQualifier.matrixPacking = mDefaultUniformMatrixPacking; |
| 3679 | } |
| 3680 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3681 | { |
| 3682 | blockLayoutQualifier.matrixPacking = mDefaultBufferMatrixPacking; |
| 3683 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3684 | } |
| 3685 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3686 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 3687 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3688 | if (typeQualifier.qualifier == EvqUniform) |
| 3689 | { |
| 3690 | blockLayoutQualifier.blockStorage = mDefaultUniformBlockStorage; |
| 3691 | } |
| 3692 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3693 | { |
| 3694 | blockLayoutQualifier.blockStorage = mDefaultBufferBlockStorage; |
| 3695 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3696 | } |
| 3697 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3698 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3699 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3700 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 3701 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3702 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3703 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3704 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3705 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3706 | TType *fieldType = field->type(); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3707 | if (IsOpaqueType(fieldType->getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3708 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3709 | std::string reason("unsupported type - "); |
| 3710 | reason += fieldType->getBasicString(); |
| 3711 | reason += " types are not allowed in interface blocks"; |
| 3712 | error(field->line(), reason.c_str(), fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3713 | } |
| 3714 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3715 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3716 | switch (qualifier) |
| 3717 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3718 | case EvqGlobal: |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3719 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3720 | case EvqUniform: |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3721 | if (typeQualifier.qualifier == EvqBuffer) |
| 3722 | { |
| 3723 | error(field->line(), "invalid qualifier on shader storage block member", |
| 3724 | getQualifierString(qualifier)); |
| 3725 | } |
| 3726 | break; |
| 3727 | case EvqBuffer: |
| 3728 | if (typeQualifier.qualifier == EvqUniform) |
| 3729 | { |
| 3730 | error(field->line(), "invalid qualifier on uniform block member", |
| 3731 | getQualifierString(qualifier)); |
| 3732 | } |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3733 | break; |
| 3734 | default: |
| 3735 | error(field->line(), "invalid qualifier on interface block member", |
| 3736 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3737 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3738 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3739 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3740 | if (fieldType->isInvariant()) |
| 3741 | { |
| 3742 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 3743 | } |
| 3744 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3745 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3746 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3747 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 3748 | checkIndexIsNotSpecified(field->line(), fieldLayoutQualifier.index); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3749 | checkBindingIsNotSpecified(field->line(), fieldLayoutQualifier.binding); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3750 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3751 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3752 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3753 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 3754 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3755 | } |
| 3756 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3757 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3758 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3759 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3760 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 3761 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3762 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3763 | warning(field->line(), |
| 3764 | "extraneous layout qualifier: only has an effect on matrix types", |
| 3765 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3766 | } |
| 3767 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3768 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3769 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3770 | if (mShaderVersion < 310 || memberIndex != fieldList->size() - 1u || |
| 3771 | typeQualifier.qualifier != EvqBuffer) |
| 3772 | { |
| 3773 | // ESSL 3.10 spec section 4.1.9 allows for runtime-sized arrays. |
| 3774 | checkIsNotUnsizedArray(field->line(), |
| 3775 | "array members of interface blocks must specify a size", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3776 | field->name(), field->type()); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3777 | } |
| 3778 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3779 | if (typeQualifier.qualifier == EvqBuffer) |
| 3780 | { |
| 3781 | // set memory qualifiers |
| 3782 | // GLSL ES 3.10 session 4.9 [Memory Access Qualifiers]. When a block declaration is |
| 3783 | // qualified with a memory qualifier, it is as if all of its members were declared with |
| 3784 | // the same memory qualifier. |
| 3785 | const TMemoryQualifier &blockMemoryQualifier = typeQualifier.memoryQualifier; |
| 3786 | TMemoryQualifier fieldMemoryQualifier = fieldType->getMemoryQualifier(); |
| 3787 | fieldMemoryQualifier.readonly |= blockMemoryQualifier.readonly; |
| 3788 | fieldMemoryQualifier.writeonly |= blockMemoryQualifier.writeonly; |
| 3789 | fieldMemoryQualifier.coherent |= blockMemoryQualifier.coherent; |
| 3790 | fieldMemoryQualifier.restrictQualifier |= blockMemoryQualifier.restrictQualifier; |
| 3791 | fieldMemoryQualifier.volatileQualifier |= blockMemoryQualifier.volatileQualifier; |
| 3792 | // TODO(jiajia.qin@intel.com): Decide whether if readonly and writeonly buffer variable |
| 3793 | // is legal. See bug https://github.com/KhronosGroup/OpenGL-API/issues/7 |
| 3794 | fieldType->setMemoryQualifier(fieldMemoryQualifier); |
| 3795 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3796 | } |
| 3797 | |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 3798 | TInterfaceBlock *interfaceBlock = new TInterfaceBlock( |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3799 | &symbolTable, blockName, fieldList, blockLayoutQualifier, SymbolType::UserDefined); |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 3800 | if (!symbolTable.declare(interfaceBlock)) |
Olli Etuaho | 378c3a5 | 2017-12-04 11:32:13 +0200 | [diff] [blame] | 3801 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3802 | error(nameLine, "redefinition of an interface block name", blockName); |
Olli Etuaho | 378c3a5 | 2017-12-04 11:32:13 +0200 | [diff] [blame] | 3803 | } |
| 3804 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3805 | TType *interfaceBlockType = |
| 3806 | new TType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3807 | if (arrayIndex != nullptr) |
| 3808 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3809 | interfaceBlockType->makeArray(arraySize); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3810 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3811 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3812 | // The instance variable gets created to refer to the interface block type from the AST |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 3813 | // regardless of if there's an instance name. It's created as an empty symbol if there is no |
| 3814 | // instance name. |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3815 | TVariable *instanceVariable = |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 3816 | new TVariable(&symbolTable, instanceName, interfaceBlockType, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3817 | instanceName.empty() ? SymbolType::Empty : SymbolType::UserDefined); |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3818 | |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 3819 | if (instanceVariable->symbolType() == SymbolType::Empty) |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3820 | { |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3821 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3822 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3823 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3824 | TField *field = (*fieldList)[memberIndex]; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3825 | TType *fieldType = new TType(*field->type()); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3826 | |
| 3827 | // set parent pointer of the field variable |
| 3828 | fieldType->setInterfaceBlock(interfaceBlock); |
| 3829 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3830 | fieldType->setQualifier(typeQualifier.qualifier); |
| 3831 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3832 | TVariable *fieldVariable = |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3833 | new TVariable(&symbolTable, field->name(), fieldType, SymbolType::UserDefined); |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 3834 | if (!symbolTable.declare(fieldVariable)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3835 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3836 | error(field->line(), "redefinition of an interface block member name", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3837 | field->name()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3838 | } |
| 3839 | } |
| 3840 | } |
| 3841 | else |
| 3842 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3843 | checkIsNotReserved(instanceLine, instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 3844 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3845 | // add a symbol for this interface block |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 3846 | if (!symbolTable.declare(instanceVariable)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3847 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3848 | error(instanceLine, "redefinition of an interface block instance name", instanceName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3849 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3850 | } |
| 3851 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3852 | TIntermSymbol *blockSymbol = new TIntermSymbol(instanceVariable); |
| 3853 | blockSymbol->setLine(typeQualifier.line); |
| 3854 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 3855 | declaration->appendDeclarator(blockSymbol); |
| 3856 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3857 | |
| 3858 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3859 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3860 | } |
| 3861 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3862 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, |
| 3863 | const ImmutableString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3864 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3865 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3866 | |
| 3867 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3868 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3869 | if (mStructNestingLevel > 1) |
| 3870 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3871 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3872 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3873 | } |
| 3874 | |
| 3875 | void TParseContext::exitStructDeclaration() |
| 3876 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3877 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3878 | } |
| 3879 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3880 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3881 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3882 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3883 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3884 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3885 | } |
| 3886 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3887 | if (field.type()->getBasicType() != EbtStruct) |
| 3888 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3889 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3890 | } |
| 3891 | |
| 3892 | // We're already inside a structure definition at this point, so add |
| 3893 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3894 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 3895 | { |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 3896 | std::stringstream reasonStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | f095799 | 2017-12-22 11:10:04 +0200 | [diff] [blame] | 3897 | if (field.type()->getStruct()->symbolType() == SymbolType::Empty) |
| 3898 | { |
| 3899 | // This may happen in case there are nested struct definitions. While they are also |
| 3900 | // invalid GLSL, they don't cause a syntax error. |
| 3901 | reasonStream << "Struct nesting"; |
| 3902 | } |
| 3903 | else |
| 3904 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3905 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name(); |
Olli Etuaho | f095799 | 2017-12-22 11:10:04 +0200 | [diff] [blame] | 3906 | } |
| 3907 | reasonStream << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3908 | std::string reason = reasonStream.str(); |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3909 | error(line, reason.c_str(), field.name()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3910 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3911 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3912 | } |
| 3913 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3914 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3915 | // Parse an array index expression |
| 3916 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3917 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 3918 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3919 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3920 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3921 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 3922 | { |
| 3923 | if (baseExpression->getAsSymbolNode()) |
| 3924 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3925 | error(location, " left of '[' is not of type array, matrix, or vector ", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3926 | baseExpression->getAsSymbolNode()->getName()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3927 | } |
| 3928 | else |
| 3929 | { |
| 3930 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 3931 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3932 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3933 | return CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3934 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 3935 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3936 | if (baseExpression->getQualifier() == EvqPerVertexIn) |
| 3937 | { |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 3938 | ASSERT(mShaderType == GL_GEOMETRY_SHADER_EXT); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3939 | if (mGeometryShaderInputPrimitiveType == EptUndefined) |
| 3940 | { |
| 3941 | error(location, "missing input primitive declaration before indexing gl_in.", "["); |
| 3942 | return CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
| 3943 | } |
| 3944 | } |
| 3945 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 3946 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 3947 | |
Olli Etuaho | 1dfd8ae | 2018-10-01 15:59:59 +0300 | [diff] [blame] | 3948 | // ANGLE should be able to fold any constant expressions resulting in an integer - but to be |
| 3949 | // safe we don't treat "EvqConst" that's evaluated according to the spec as being sufficient |
| 3950 | // for constness. Some interpretations of the spec have allowed constant expressions with side |
| 3951 | // effects - like array length() method on a non-constant array. |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3952 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 3953 | { |
| 3954 | if (baseExpression->isInterfaceBlock()) |
| 3955 | { |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 3956 | // TODO(jiawei.shao@intel.com): implement GL_EXT_shader_io_blocks. |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3957 | switch (baseExpression->getQualifier()) |
| 3958 | { |
| 3959 | case EvqPerVertexIn: |
| 3960 | break; |
| 3961 | case EvqUniform: |
| 3962 | case EvqBuffer: |
| 3963 | error(location, |
| 3964 | "array indexes for uniform block arrays and shader storage block arrays " |
| 3965 | "must be constant integral expressions", |
| 3966 | "["); |
| 3967 | break; |
| 3968 | default: |
Jiawei Shao | 7e1197e | 2017-08-24 15:48:38 +0800 | [diff] [blame] | 3969 | // We can reach here only in error cases. |
| 3970 | ASSERT(mDiagnostics->numErrors() > 0); |
| 3971 | break; |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3972 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3973 | } |
| 3974 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 3975 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3976 | error(location, |
| 3977 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3978 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3979 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3980 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3981 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3982 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3983 | } |
| 3984 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3985 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3986 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3987 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3988 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3989 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3990 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3991 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3992 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 3993 | int index = 0; |
| 3994 | if (indexConstantUnion->getBasicType() == EbtInt) |
| 3995 | { |
| 3996 | index = indexConstantUnion->getIConst(0); |
| 3997 | } |
| 3998 | else if (indexConstantUnion->getBasicType() == EbtUInt) |
| 3999 | { |
| 4000 | index = static_cast<int>(indexConstantUnion->getUConst(0)); |
| 4001 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4002 | |
| 4003 | int safeIndex = -1; |
| 4004 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4005 | if (index < 0) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 4006 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4007 | outOfRangeError(outOfRangeIndexIsError, location, "index expression is negative", "[]"); |
| 4008 | safeIndex = 0; |
| 4009 | } |
| 4010 | |
| 4011 | if (!baseExpression->getType().isUnsizedArray()) |
| 4012 | { |
| 4013 | if (baseExpression->isArray()) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4014 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4015 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4016 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4017 | if (!isExtensionEnabled(TExtension::EXT_draw_buffers)) |
| 4018 | { |
| 4019 | outOfRangeError(outOfRangeIndexIsError, location, |
| 4020 | "array index for gl_FragData must be zero when " |
| 4021 | "GL_EXT_draw_buffers is disabled", |
| 4022 | "[]"); |
| 4023 | safeIndex = 0; |
| 4024 | } |
| 4025 | } |
Olli Etuaho | f13cadd | 2017-11-28 10:53:09 +0200 | [diff] [blame] | 4026 | } |
| 4027 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 4028 | if (safeIndex < 0) |
| 4029 | { |
| 4030 | if (baseExpression->isArray()) |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4031 | { |
| 4032 | safeIndex = checkIndexLessThan(outOfRangeIndexIsError, location, index, |
| 4033 | baseExpression->getOutermostArraySize(), |
| 4034 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4035 | } |
Olli Etuaho | f13cadd | 2017-11-28 10:53:09 +0200 | [diff] [blame] | 4036 | else if (baseExpression->isMatrix()) |
| 4037 | { |
| 4038 | safeIndex = checkIndexLessThan(outOfRangeIndexIsError, location, index, |
| 4039 | baseExpression->getType().getCols(), |
| 4040 | "matrix field selection out of range"); |
| 4041 | } |
| 4042 | else |
| 4043 | { |
| 4044 | ASSERT(baseExpression->isVector()); |
| 4045 | safeIndex = checkIndexLessThan(outOfRangeIndexIsError, location, index, |
| 4046 | baseExpression->getType().getNominalSize(), |
| 4047 | "vector field selection out of range"); |
| 4048 | } |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4049 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4050 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4051 | ASSERT(safeIndex >= 0); |
| 4052 | // Data of constant unions can't be changed, because it may be shared with other |
| 4053 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 4054 | // sanitized object. |
| 4055 | if (safeIndex != index || indexConstantUnion->getBasicType() != EbtInt) |
| 4056 | { |
| 4057 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 4058 | safeConstantUnion->setIConst(safeIndex); |
Olli Etuaho | 0e99b7a | 2018-01-12 12:05:48 +0200 | [diff] [blame] | 4059 | indexExpression = new TIntermConstantUnion( |
| 4060 | safeConstantUnion, TType(EbtInt, indexExpression->getPrecision(), |
| 4061 | indexExpression->getQualifier())); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4062 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4063 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4064 | TIntermBinary *node = |
| 4065 | new TIntermBinary(EOpIndexDirect, baseExpression, indexExpression); |
| 4066 | node->setLine(location); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 4067 | return expressionOrFoldedResult(node); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4068 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4069 | } |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4070 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 4071 | markStaticReadIfSymbol(indexExpression); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4072 | TIntermBinary *node = new TIntermBinary(EOpIndexIndirect, baseExpression, indexExpression); |
| 4073 | node->setLine(location); |
| 4074 | // Indirect indexing can never be constant folded. |
| 4075 | return node; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4076 | } |
| 4077 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4078 | int TParseContext::checkIndexLessThan(bool outOfRangeIndexIsError, |
| 4079 | const TSourceLoc &location, |
| 4080 | int index, |
| 4081 | int arraySize, |
| 4082 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4083 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4084 | // Should not reach here with an unsized / runtime-sized array. |
| 4085 | ASSERT(arraySize > 0); |
Olli Etuaho | f13cadd | 2017-11-28 10:53:09 +0200 | [diff] [blame] | 4086 | // A negative index should already have been checked. |
| 4087 | ASSERT(index >= 0); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4088 | if (index >= arraySize) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4089 | { |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 4090 | std::stringstream reasonStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4091 | reasonStream << reason << " '" << index << "'"; |
| 4092 | std::string token = reasonStream.str(); |
| 4093 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4094 | return arraySize - 1; |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4095 | } |
| 4096 | return index; |
| 4097 | } |
| 4098 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4099 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 4100 | const TSourceLoc &dotLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4101 | const ImmutableString &fieldString, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4102 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4103 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4104 | if (baseExpression->isArray()) |
| 4105 | { |
| 4106 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4107 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4108 | } |
| 4109 | |
| 4110 | if (baseExpression->isVector()) |
| 4111 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4112 | TVector<int> fieldOffsets; |
| 4113 | if (!parseVectorFields(fieldLocation, fieldString, baseExpression->getNominalSize(), |
| 4114 | &fieldOffsets)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4115 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4116 | fieldOffsets.resize(1); |
| 4117 | fieldOffsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4118 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4119 | TIntermSwizzle *node = new TIntermSwizzle(baseExpression, fieldOffsets); |
| 4120 | node->setLine(dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4121 | |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 4122 | return node->fold(mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4123 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4124 | else if (baseExpression->getBasicType() == EbtStruct) |
| 4125 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4126 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4127 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4128 | { |
| 4129 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4130 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4131 | } |
| 4132 | else |
| 4133 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4134 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4135 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4136 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4137 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4138 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4139 | { |
| 4140 | fieldFound = true; |
| 4141 | break; |
| 4142 | } |
| 4143 | } |
| 4144 | if (fieldFound) |
| 4145 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 4146 | TIntermTyped *index = CreateIndexNode(i); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4147 | index->setLine(fieldLocation); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4148 | TIntermBinary *node = |
| 4149 | new TIntermBinary(EOpIndexDirectStruct, baseExpression, index); |
| 4150 | node->setLine(dotLocation); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 4151 | return expressionOrFoldedResult(node); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4152 | } |
| 4153 | else |
| 4154 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4155 | error(dotLocation, " no such field in structure", fieldString); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4156 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4157 | } |
| 4158 | } |
| 4159 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4160 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4161 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4162 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4163 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4164 | { |
| 4165 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4166 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4167 | } |
| 4168 | else |
| 4169 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4170 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4171 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4172 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4173 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4174 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4175 | { |
| 4176 | fieldFound = true; |
| 4177 | break; |
| 4178 | } |
| 4179 | } |
| 4180 | if (fieldFound) |
| 4181 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 4182 | TIntermTyped *index = CreateIndexNode(i); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4183 | index->setLine(fieldLocation); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4184 | TIntermBinary *node = |
| 4185 | new TIntermBinary(EOpIndexDirectInterfaceBlock, baseExpression, index); |
| 4186 | node->setLine(dotLocation); |
| 4187 | // Indexing interface blocks can never be constant folded. |
| 4188 | return node; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4189 | } |
| 4190 | else |
| 4191 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4192 | error(dotLocation, " no such field in interface block", fieldString); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4193 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4194 | } |
| 4195 | } |
| 4196 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4197 | else |
| 4198 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4199 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4200 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 4201 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4202 | fieldString); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4203 | } |
| 4204 | else |
| 4205 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4206 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 4207 | " field selection requires structure, vector, or interface block on left hand " |
| 4208 | "side", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4209 | fieldString); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4210 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4211 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4212 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4213 | } |
| 4214 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4215 | TLayoutQualifier TParseContext::parseLayoutQualifier(const ImmutableString &qualifierType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4216 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4217 | { |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 4218 | TLayoutQualifier qualifier = TLayoutQualifier::Create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4219 | |
| 4220 | if (qualifierType == "shared") |
| 4221 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 4222 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 4223 | { |
| 4224 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 4225 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4226 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4227 | } |
| 4228 | else if (qualifierType == "packed") |
| 4229 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 4230 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 4231 | { |
| 4232 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 4233 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4234 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4235 | } |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 4236 | else if (qualifierType == "std430") |
| 4237 | { |
| 4238 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4239 | qualifier.blockStorage = EbsStd430; |
| 4240 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4241 | else if (qualifierType == "std140") |
| 4242 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4243 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4244 | } |
| 4245 | else if (qualifierType == "row_major") |
| 4246 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4247 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4248 | } |
| 4249 | else if (qualifierType == "column_major") |
| 4250 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4251 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4252 | } |
| 4253 | else if (qualifierType == "location") |
| 4254 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4255 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4256 | qualifierType); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4257 | } |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4258 | else if (qualifierType == "yuv" && mShaderType == GL_FRAGMENT_SHADER) |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 4259 | { |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4260 | if (checkCanUseExtension(qualifierTypeLine, TExtension::EXT_YUV_target)) |
| 4261 | { |
| 4262 | qualifier.yuv = true; |
| 4263 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 4264 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4265 | else if (qualifierType == "rgba32f") |
| 4266 | { |
| 4267 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4268 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 4269 | } |
| 4270 | else if (qualifierType == "rgba16f") |
| 4271 | { |
| 4272 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4273 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 4274 | } |
| 4275 | else if (qualifierType == "r32f") |
| 4276 | { |
| 4277 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4278 | qualifier.imageInternalFormat = EiifR32F; |
| 4279 | } |
| 4280 | else if (qualifierType == "rgba8") |
| 4281 | { |
| 4282 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4283 | qualifier.imageInternalFormat = EiifRGBA8; |
| 4284 | } |
| 4285 | else if (qualifierType == "rgba8_snorm") |
| 4286 | { |
| 4287 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4288 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 4289 | } |
| 4290 | else if (qualifierType == "rgba32i") |
| 4291 | { |
| 4292 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4293 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 4294 | } |
| 4295 | else if (qualifierType == "rgba16i") |
| 4296 | { |
| 4297 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4298 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 4299 | } |
| 4300 | else if (qualifierType == "rgba8i") |
| 4301 | { |
| 4302 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4303 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 4304 | } |
| 4305 | else if (qualifierType == "r32i") |
| 4306 | { |
| 4307 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4308 | qualifier.imageInternalFormat = EiifR32I; |
| 4309 | } |
| 4310 | else if (qualifierType == "rgba32ui") |
| 4311 | { |
| 4312 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4313 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 4314 | } |
| 4315 | else if (qualifierType == "rgba16ui") |
| 4316 | { |
| 4317 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4318 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 4319 | } |
| 4320 | else if (qualifierType == "rgba8ui") |
| 4321 | { |
| 4322 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4323 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 4324 | } |
| 4325 | else if (qualifierType == "r32ui") |
| 4326 | { |
| 4327 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4328 | qualifier.imageInternalFormat = EiifR32UI; |
| 4329 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4330 | else if (qualifierType == "points" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4331 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4332 | { |
| 4333 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4334 | qualifier.primitiveType = EptPoints; |
| 4335 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4336 | else if (qualifierType == "lines" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4337 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4338 | { |
| 4339 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4340 | qualifier.primitiveType = EptLines; |
| 4341 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4342 | else if (qualifierType == "lines_adjacency" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4343 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4344 | { |
| 4345 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4346 | qualifier.primitiveType = EptLinesAdjacency; |
| 4347 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4348 | else if (qualifierType == "triangles" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4349 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4350 | { |
| 4351 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4352 | qualifier.primitiveType = EptTriangles; |
| 4353 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4354 | else if (qualifierType == "triangles_adjacency" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4355 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4356 | { |
| 4357 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4358 | qualifier.primitiveType = EptTrianglesAdjacency; |
| 4359 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4360 | else if (qualifierType == "line_strip" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4361 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4362 | { |
| 4363 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4364 | qualifier.primitiveType = EptLineStrip; |
| 4365 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4366 | else if (qualifierType == "triangle_strip" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4367 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4368 | { |
| 4369 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4370 | qualifier.primitiveType = EptTriangleStrip; |
| 4371 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4372 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4373 | else |
| 4374 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4375 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4376 | } |
| 4377 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4378 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4379 | } |
| 4380 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4381 | void TParseContext::parseLocalSize(const ImmutableString &qualifierType, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4382 | const TSourceLoc &qualifierTypeLine, |
| 4383 | int intValue, |
| 4384 | const TSourceLoc &intValueLine, |
| 4385 | const std::string &intValueString, |
| 4386 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 4387 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4388 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4389 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4390 | if (intValue < 1) |
| 4391 | { |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 4392 | std::stringstream reasonStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4393 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 4394 | std::string reason = reasonStream.str(); |
| 4395 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4396 | } |
| 4397 | (*localSize)[index] = intValue; |
| 4398 | } |
| 4399 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4400 | void TParseContext::parseNumViews(int intValue, |
| 4401 | const TSourceLoc &intValueLine, |
| 4402 | const std::string &intValueString, |
| 4403 | int *numViews) |
| 4404 | { |
| 4405 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 4406 | // specification. |
| 4407 | if (intValue < 1) |
| 4408 | { |
| 4409 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 4410 | } |
| 4411 | *numViews = intValue; |
| 4412 | } |
| 4413 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4414 | void TParseContext::parseInvocations(int intValue, |
| 4415 | const TSourceLoc &intValueLine, |
| 4416 | const std::string &intValueString, |
| 4417 | int *numInvocations) |
| 4418 | { |
| 4419 | // Although SPEC isn't clear whether invocations can be less than 1, we add this limit because |
| 4420 | // it doesn't make sense to accept invocations <= 0. |
| 4421 | if (intValue < 1 || intValue > mMaxGeometryShaderInvocations) |
| 4422 | { |
| 4423 | error(intValueLine, |
| 4424 | "out of range: invocations must be in the range of [1, " |
| 4425 | "MAX_GEOMETRY_SHADER_INVOCATIONS_OES]", |
| 4426 | intValueString.c_str()); |
| 4427 | } |
| 4428 | else |
| 4429 | { |
| 4430 | *numInvocations = intValue; |
| 4431 | } |
| 4432 | } |
| 4433 | |
| 4434 | void TParseContext::parseMaxVertices(int intValue, |
| 4435 | const TSourceLoc &intValueLine, |
| 4436 | const std::string &intValueString, |
| 4437 | int *maxVertices) |
| 4438 | { |
| 4439 | // Although SPEC isn't clear whether max_vertices can be less than 0, we add this limit because |
| 4440 | // it doesn't make sense to accept max_vertices < 0. |
| 4441 | if (intValue < 0 || intValue > mMaxGeometryShaderMaxVertices) |
| 4442 | { |
| 4443 | error( |
| 4444 | intValueLine, |
| 4445 | "out of range: max_vertices must be in the range of [0, gl_MaxGeometryOutputVertices]", |
| 4446 | intValueString.c_str()); |
| 4447 | } |
| 4448 | else |
| 4449 | { |
| 4450 | *maxVertices = intValue; |
| 4451 | } |
| 4452 | } |
| 4453 | |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 4454 | void TParseContext::parseIndexLayoutQualifier(int intValue, |
| 4455 | const TSourceLoc &intValueLine, |
| 4456 | const std::string &intValueString, |
| 4457 | int *index) |
| 4458 | { |
| 4459 | // EXT_blend_func_extended specifies that most validation should happen at link time, but since |
| 4460 | // we're validating output variable locations at compile time, it makes sense to validate that |
| 4461 | // index is 0 or 1 also at compile time. Also since we use "-1" as a placeholder for unspecified |
| 4462 | // index, we can't accept it here. |
| 4463 | if (intValue < 0 || intValue > 1) |
| 4464 | { |
| 4465 | error(intValueLine, "out of range: index layout qualifier can only be 0 or 1", |
| 4466 | intValueString.c_str()); |
| 4467 | } |
| 4468 | else |
| 4469 | { |
| 4470 | *index = intValue; |
| 4471 | } |
| 4472 | } |
| 4473 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4474 | TLayoutQualifier TParseContext::parseLayoutQualifier(const ImmutableString &qualifierType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4475 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4476 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4477 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4478 | { |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 4479 | TLayoutQualifier qualifier = TLayoutQualifier::Create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4480 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4481 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4482 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4483 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4484 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 4485 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4486 | if (intValue < 0) |
| 4487 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4488 | error(intValueLine, "out of range: location must be non-negative", |
| 4489 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4490 | } |
| 4491 | else |
| 4492 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4493 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 4494 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4495 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4496 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4497 | else if (qualifierType == "binding") |
| 4498 | { |
| 4499 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4500 | if (intValue < 0) |
| 4501 | { |
| 4502 | error(intValueLine, "out of range: binding must be non-negative", |
| 4503 | intValueString.c_str()); |
| 4504 | } |
| 4505 | else |
| 4506 | { |
| 4507 | qualifier.binding = intValue; |
| 4508 | } |
| 4509 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4510 | else if (qualifierType == "offset") |
| 4511 | { |
| 4512 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4513 | if (intValue < 0) |
| 4514 | { |
| 4515 | error(intValueLine, "out of range: offset must be non-negative", |
| 4516 | intValueString.c_str()); |
| 4517 | } |
| 4518 | else |
| 4519 | { |
| 4520 | qualifier.offset = intValue; |
| 4521 | } |
| 4522 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4523 | else if (qualifierType == "local_size_x") |
| 4524 | { |
| 4525 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 4526 | &qualifier.localSize); |
| 4527 | } |
| 4528 | else if (qualifierType == "local_size_y") |
| 4529 | { |
| 4530 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 4531 | &qualifier.localSize); |
| 4532 | } |
| 4533 | else if (qualifierType == "local_size_z") |
| 4534 | { |
| 4535 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 4536 | &qualifier.localSize); |
| 4537 | } |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4538 | else if (qualifierType == "num_views" && mShaderType == GL_VERTEX_SHADER) |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4539 | { |
Mingyu Hu | ebab670 | 2019-04-19 14:36:45 -0700 | [diff] [blame^] | 4540 | if (checkCanUseOneOfExtensions( |
| 4541 | qualifierTypeLine, std::array<TExtension, 2u>{ |
| 4542 | {TExtension::OVR_multiview, TExtension::OVR_multiview2}})) |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4543 | { |
| 4544 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 4545 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4546 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4547 | else if (qualifierType == "invocations" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4548 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4549 | { |
| 4550 | parseInvocations(intValue, intValueLine, intValueString, &qualifier.invocations); |
| 4551 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4552 | else if (qualifierType == "max_vertices" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4553 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4554 | { |
| 4555 | parseMaxVertices(intValue, intValueLine, intValueString, &qualifier.maxVertices); |
| 4556 | } |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 4557 | else if (qualifierType == "index" && mShaderType == GL_FRAGMENT_SHADER && |
| 4558 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_blend_func_extended)) |
| 4559 | { |
| 4560 | parseIndexLayoutQualifier(intValue, intValueLine, intValueString, &qualifier.index); |
| 4561 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4562 | else |
| 4563 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4564 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4565 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4566 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4567 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4568 | } |
| 4569 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 4570 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 4571 | { |
| 4572 | return new TTypeQualifierBuilder( |
| 4573 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 4574 | mShaderVersion); |
| 4575 | } |
| 4576 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4577 | TStorageQualifierWrapper *TParseContext::parseGlobalStorageQualifier(TQualifier qualifier, |
| 4578 | const TSourceLoc &loc) |
| 4579 | { |
| 4580 | checkIsAtGlobalLevel(loc, getQualifierString(qualifier)); |
| 4581 | return new TStorageQualifierWrapper(qualifier, loc); |
| 4582 | } |
| 4583 | |
| 4584 | TStorageQualifierWrapper *TParseContext::parseVaryingQualifier(const TSourceLoc &loc) |
| 4585 | { |
| 4586 | if (getShaderType() == GL_VERTEX_SHADER) |
| 4587 | { |
| 4588 | return parseGlobalStorageQualifier(EvqVaryingOut, loc); |
| 4589 | } |
| 4590 | return parseGlobalStorageQualifier(EvqVaryingIn, loc); |
| 4591 | } |
| 4592 | |
| 4593 | TStorageQualifierWrapper *TParseContext::parseInQualifier(const TSourceLoc &loc) |
| 4594 | { |
| 4595 | if (declaringFunction()) |
| 4596 | { |
| 4597 | return new TStorageQualifierWrapper(EvqIn, loc); |
| 4598 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4599 | |
| 4600 | switch (getShaderType()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4601 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4602 | case GL_VERTEX_SHADER: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4603 | { |
Mingyu Hu | ebab670 | 2019-04-19 14:36:45 -0700 | [diff] [blame^] | 4604 | if (mShaderVersion < 300 && !anyMultiviewExtensionAvailable()) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4605 | { |
| 4606 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 4607 | } |
| 4608 | return new TStorageQualifierWrapper(EvqVertexIn, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4609 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4610 | case GL_FRAGMENT_SHADER: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4611 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4612 | if (mShaderVersion < 300) |
| 4613 | { |
| 4614 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 4615 | } |
| 4616 | return new TStorageQualifierWrapper(EvqFragmentIn, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4617 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4618 | case GL_COMPUTE_SHADER: |
| 4619 | { |
| 4620 | return new TStorageQualifierWrapper(EvqComputeIn, loc); |
| 4621 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4622 | case GL_GEOMETRY_SHADER_EXT: |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4623 | { |
| 4624 | return new TStorageQualifierWrapper(EvqGeometryIn, loc); |
| 4625 | } |
| 4626 | default: |
| 4627 | { |
| 4628 | UNREACHABLE(); |
| 4629 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4630 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4631 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4632 | } |
| 4633 | |
| 4634 | TStorageQualifierWrapper *TParseContext::parseOutQualifier(const TSourceLoc &loc) |
| 4635 | { |
| 4636 | if (declaringFunction()) |
| 4637 | { |
| 4638 | return new TStorageQualifierWrapper(EvqOut, loc); |
| 4639 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4640 | switch (getShaderType()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4641 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4642 | case GL_VERTEX_SHADER: |
| 4643 | { |
| 4644 | if (mShaderVersion < 300) |
| 4645 | { |
| 4646 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 4647 | } |
| 4648 | return new TStorageQualifierWrapper(EvqVertexOut, loc); |
| 4649 | } |
| 4650 | case GL_FRAGMENT_SHADER: |
| 4651 | { |
| 4652 | if (mShaderVersion < 300) |
| 4653 | { |
| 4654 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 4655 | } |
| 4656 | return new TStorageQualifierWrapper(EvqFragmentOut, loc); |
| 4657 | } |
| 4658 | case GL_COMPUTE_SHADER: |
| 4659 | { |
| 4660 | error(loc, "storage qualifier isn't supported in compute shaders", "out"); |
| 4661 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4662 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4663 | case GL_GEOMETRY_SHADER_EXT: |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4664 | { |
| 4665 | return new TStorageQualifierWrapper(EvqGeometryOut, loc); |
| 4666 | } |
| 4667 | default: |
| 4668 | { |
| 4669 | UNREACHABLE(); |
| 4670 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4671 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4672 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4673 | } |
| 4674 | |
| 4675 | TStorageQualifierWrapper *TParseContext::parseInOutQualifier(const TSourceLoc &loc) |
| 4676 | { |
| 4677 | if (!declaringFunction()) |
| 4678 | { |
| 4679 | error(loc, "invalid qualifier: can be only used with function parameters", "inout"); |
| 4680 | } |
| 4681 | return new TStorageQualifierWrapper(EvqInOut, loc); |
| 4682 | } |
| 4683 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4684 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4685 | TLayoutQualifier rightQualifier, |
| 4686 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4687 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4688 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4689 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4690 | } |
| 4691 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4692 | TDeclarator *TParseContext::parseStructDeclarator(const ImmutableString &identifier, |
| 4693 | const TSourceLoc &loc) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4694 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4695 | checkIsNotReserved(loc, identifier); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4696 | return new TDeclarator(identifier, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4697 | } |
| 4698 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4699 | TDeclarator *TParseContext::parseStructArrayDeclarator(const ImmutableString &identifier, |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4700 | const TSourceLoc &loc, |
| 4701 | const TVector<unsigned int> *arraySizes) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4702 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4703 | checkIsNotReserved(loc, identifier); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4704 | return new TDeclarator(identifier, arraySizes, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4705 | } |
| 4706 | |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4707 | void TParseContext::checkDoesNotHaveDuplicateFieldName(const TFieldList::const_iterator begin, |
| 4708 | const TFieldList::const_iterator end, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4709 | const ImmutableString &name, |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4710 | const TSourceLoc &location) |
| 4711 | { |
| 4712 | for (auto fieldIter = begin; fieldIter != end; ++fieldIter) |
| 4713 | { |
| 4714 | if ((*fieldIter)->name() == name) |
| 4715 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4716 | error(location, "duplicate field name in structure", name); |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4717 | } |
| 4718 | } |
| 4719 | } |
| 4720 | |
| 4721 | TFieldList *TParseContext::addStructFieldList(TFieldList *fields, const TSourceLoc &location) |
| 4722 | { |
| 4723 | for (TFieldList::const_iterator fieldIter = fields->begin(); fieldIter != fields->end(); |
| 4724 | ++fieldIter) |
| 4725 | { |
| 4726 | checkDoesNotHaveDuplicateFieldName(fields->begin(), fieldIter, (*fieldIter)->name(), |
| 4727 | location); |
| 4728 | } |
| 4729 | return fields; |
| 4730 | } |
| 4731 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4732 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 4733 | const TFieldList *newlyAddedFields, |
| 4734 | const TSourceLoc &location) |
| 4735 | { |
| 4736 | for (TField *field : *newlyAddedFields) |
| 4737 | { |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4738 | checkDoesNotHaveDuplicateFieldName(processedFields->begin(), processedFields->end(), |
| 4739 | field->name(), location); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4740 | processedFields->push_back(field); |
| 4741 | } |
| 4742 | return processedFields; |
| 4743 | } |
| 4744 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4745 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 4746 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 4747 | TPublicType *typeSpecifier, |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4748 | const TDeclaratorList *declaratorList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4749 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4750 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4751 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4752 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 4753 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4754 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4755 | typeSpecifier->invariant = typeQualifier.invariant; |
| 4756 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4757 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4758 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4759 | } |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4760 | return addStructDeclaratorList(*typeSpecifier, declaratorList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4761 | } |
| 4762 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4763 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4764 | const TDeclaratorList *declaratorList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4765 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4766 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 4767 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4768 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4769 | checkIsNonVoid(typeSpecifier.getLine(), (*declaratorList)[0]->name(), |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4770 | typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4771 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4772 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4773 | |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4774 | TFieldList *fieldList = new TFieldList(); |
| 4775 | |
| 4776 | for (const TDeclarator *declarator : *declaratorList) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4777 | { |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4778 | TType *type = new TType(typeSpecifier); |
| 4779 | if (declarator->isArray()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4780 | { |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4781 | // Don't allow arrays of arrays in ESSL < 3.10. |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 4782 | checkArrayElementIsNotArray(typeSpecifier.getLine(), typeSpecifier); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4783 | type->makeArrays(*declarator->arraySizes()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4784 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4785 | |
Jamie Madill | f5557ac | 2018-06-15 09:46:58 -0400 | [diff] [blame] | 4786 | TField *field = |
| 4787 | new TField(type, declarator->name(), declarator->line(), SymbolType::UserDefined); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4788 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *field); |
| 4789 | fieldList->push_back(field); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4790 | } |
| 4791 | |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4792 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4793 | } |
| 4794 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4795 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 4796 | const TSourceLoc &nameLine, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4797 | const ImmutableString &structName, |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4798 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4799 | { |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4800 | SymbolType structSymbolType = SymbolType::UserDefined; |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4801 | if (structName.empty()) |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4802 | { |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4803 | structSymbolType = SymbolType::Empty; |
| 4804 | } |
| 4805 | TStructure *structure = new TStructure(&symbolTable, structName, fieldList, structSymbolType); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4806 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4807 | // Store a bool in the struct if we're at global scope, to allow us to |
| 4808 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4809 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 4810 | |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4811 | if (structSymbolType != SymbolType::Empty) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4812 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4813 | checkIsNotReserved(nameLine, structName); |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 4814 | if (!symbolTable.declare(structure)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4815 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4816 | error(nameLine, "redefinition of a struct", structName); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4817 | } |
| 4818 | } |
| 4819 | |
| 4820 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4821 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4822 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4823 | TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4824 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4825 | switch (qualifier) |
| 4826 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4827 | case EvqGlobal: |
| 4828 | case EvqTemporary: |
| 4829 | break; |
| 4830 | default: |
| 4831 | error(field.line(), "invalid qualifier on struct member", |
| 4832 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4833 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4834 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4835 | if (field.type()->isInvariant()) |
| 4836 | { |
| 4837 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 4838 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4839 | // ESSL 3.10 section 4.1.8 -- atomic_uint or images are not allowed as structure member. |
| 4840 | if (IsImage(field.type()->getBasicType()) || IsAtomicCounter(field.type()->getBasicType())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4841 | { |
| 4842 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 4843 | } |
| 4844 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4845 | checkIsNotUnsizedArray(field.line(), "array members of structs must specify a size", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4846 | field.name(), field.type()); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4847 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4848 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 4849 | |
Olli Etuaho | a78092c | 2018-09-26 14:16:13 +0300 | [diff] [blame] | 4850 | checkIndexIsNotSpecified(field.line(), field.type()->getLayoutQualifier().index); |
| 4851 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4852 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4853 | |
| 4854 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4855 | } |
| 4856 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4857 | TTypeSpecifierNonArray typeSpecifierNonArray; |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 4858 | typeSpecifierNonArray.initializeStruct(structure, true, structLine); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4859 | exitStructDeclaration(); |
| 4860 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4861 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4862 | } |
| 4863 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4864 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 4865 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4866 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4867 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4868 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4869 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4870 | init->isVector()) |
| 4871 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4872 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 4873 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4874 | return nullptr; |
| 4875 | } |
| 4876 | |
Olli Etuaho | 923ecef | 2017-10-11 12:01:38 +0300 | [diff] [blame] | 4877 | ASSERT(statementList); |
Olli Etuaho | d05f964 | 2018-03-05 12:13:26 +0200 | [diff] [blame] | 4878 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4879 | { |
Olli Etuaho | cbcb96f | 2017-10-19 14:14:06 +0300 | [diff] [blame] | 4880 | ASSERT(mDiagnostics->numErrors() > 0); |
Olli Etuaho | 923ecef | 2017-10-11 12:01:38 +0300 | [diff] [blame] | 4881 | return nullptr; |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4882 | } |
| 4883 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 4884 | markStaticReadIfSymbol(init); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4885 | TIntermSwitch *node = new TIntermSwitch(init, statementList); |
| 4886 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4887 | return node; |
| 4888 | } |
| 4889 | |
| 4890 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 4891 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4892 | if (mSwitchNestingLevel == 0) |
| 4893 | { |
| 4894 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4895 | return nullptr; |
| 4896 | } |
| 4897 | if (condition == nullptr) |
| 4898 | { |
| 4899 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4900 | return nullptr; |
| 4901 | } |
| 4902 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4903 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4904 | { |
| 4905 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4906 | } |
| 4907 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 1dfd8ae | 2018-10-01 15:59:59 +0300 | [diff] [blame] | 4908 | // ANGLE should be able to fold any EvqConst expressions resulting in an integer - but to be |
| 4909 | // safe against corner cases we still check for conditionConst. Some interpretations of the |
| 4910 | // spec have allowed constant expressions with side effects - like array length() method on a |
| 4911 | // non-constant array. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4912 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4913 | { |
| 4914 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4915 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4916 | TIntermCase *node = new TIntermCase(condition); |
| 4917 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4918 | return node; |
| 4919 | } |
| 4920 | |
| 4921 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 4922 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4923 | if (mSwitchNestingLevel == 0) |
| 4924 | { |
| 4925 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4926 | return nullptr; |
| 4927 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4928 | TIntermCase *node = new TIntermCase(nullptr); |
| 4929 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4930 | return node; |
| 4931 | } |
| 4932 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4933 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 4934 | TIntermTyped *child, |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 4935 | const TSourceLoc &loc, |
| 4936 | const TFunction *func) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4937 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4938 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4939 | |
| 4940 | switch (op) |
| 4941 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4942 | case EOpLogicalNot: |
| 4943 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 4944 | child->isVector()) |
| 4945 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 4946 | unaryOpError(loc, GetOperatorString(op), child->getType()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4947 | return nullptr; |
| 4948 | } |
| 4949 | break; |
| 4950 | case EOpBitwiseNot: |
| 4951 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 4952 | child->isMatrix() || child->isArray()) |
| 4953 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 4954 | unaryOpError(loc, GetOperatorString(op), child->getType()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4955 | return nullptr; |
| 4956 | } |
| 4957 | break; |
| 4958 | case EOpPostIncrement: |
| 4959 | case EOpPreIncrement: |
| 4960 | case EOpPostDecrement: |
| 4961 | case EOpPreDecrement: |
| 4962 | case EOpNegative: |
| 4963 | case EOpPositive: |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4964 | if (child->getBasicType() == EbtStruct || child->isInterfaceBlock() || |
| 4965 | child->getBasicType() == EbtBool || child->isArray() || |
Geoff Lang | 6aab06e | 2018-11-20 14:04:11 -0500 | [diff] [blame] | 4966 | child->getBasicType() == EbtVoid || IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4967 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 4968 | unaryOpError(loc, GetOperatorString(op), child->getType()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4969 | return nullptr; |
| 4970 | } |
Nico Weber | 41b072b | 2018-02-09 10:01:32 -0500 | [diff] [blame] | 4971 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4972 | // Operators for built-ins are already type checked against their prototype. |
| 4973 | default: |
| 4974 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4975 | } |
| 4976 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 4977 | if (child->getMemoryQualifier().writeonly) |
| 4978 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 4979 | unaryOpError(loc, GetOperatorString(op), child->getType()); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 4980 | return nullptr; |
| 4981 | } |
| 4982 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 4983 | markStaticReadIfSymbol(child); |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 4984 | TIntermUnary *node = new TIntermUnary(op, child, func); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4985 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4986 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4987 | return node->fold(mDiagnostics); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4988 | } |
| 4989 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4990 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 4991 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4992 | ASSERT(op != EOpNull); |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 4993 | TIntermTyped *node = createUnaryMath(op, child, loc, nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4994 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4995 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4996 | return child; |
| 4997 | } |
| 4998 | return node; |
| 4999 | } |
| 5000 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5001 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 5002 | TIntermTyped *child, |
| 5003 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5004 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 5005 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5006 | return addUnaryMath(op, child, loc); |
| 5007 | } |
| 5008 | |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 5009 | TIntermTyped *TParseContext::expressionOrFoldedResult(TIntermTyped *expression) |
| 5010 | { |
| 5011 | // If we can, we should return the folded version of the expression for subsequent parsing. This |
| 5012 | // enables folding the containing expression during parsing as well, instead of the separate |
| 5013 | // FoldExpressions() step where folding nested expressions requires multiple full AST |
| 5014 | // traversals. |
| 5015 | |
| 5016 | // Even if folding fails the fold() functions return some node representing the expression, |
| 5017 | // typically the original node. So "folded" can be assumed to be non-null. |
| 5018 | TIntermTyped *folded = expression->fold(mDiagnostics); |
| 5019 | ASSERT(folded != nullptr); |
| 5020 | if (folded->getQualifier() == expression->getQualifier()) |
| 5021 | { |
| 5022 | // We need this expression to have the correct qualifier when validating the consuming |
| 5023 | // expression. So we can only return the folded node from here in case it has the same |
| 5024 | // qualifier as the original expression. In this kind of a cases the qualifier of the folded |
| 5025 | // node is EvqConst, whereas the qualifier of the expression is EvqTemporary: |
| 5026 | // 1. (true ? 1.0 : non_constant) |
| 5027 | // 2. (non_constant, 1.0) |
| 5028 | return folded; |
| 5029 | } |
| 5030 | return expression; |
| 5031 | } |
| 5032 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5033 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 5034 | TIntermTyped *left, |
| 5035 | TIntermTyped *right, |
| 5036 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5037 | { |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 5038 | // Check opaque types are not allowed to be operands in expressions other than array indexing |
| 5039 | // and structure member selection. |
| 5040 | if (IsOpaqueType(left->getBasicType()) || IsOpaqueType(right->getBasicType())) |
| 5041 | { |
| 5042 | switch (op) |
| 5043 | { |
| 5044 | case EOpIndexDirect: |
| 5045 | case EOpIndexIndirect: |
| 5046 | break; |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 5047 | |
| 5048 | default: |
Nico Weber | b5db2b4 | 2018-02-12 15:31:56 -0500 | [diff] [blame] | 5049 | ASSERT(op != EOpIndexDirectStruct); |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 5050 | error(loc, "Invalid operation for variables with an opaque type", |
| 5051 | GetOperatorString(op)); |
| 5052 | return false; |
| 5053 | } |
| 5054 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 5055 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 5056 | if (right->getMemoryQualifier().writeonly) |
| 5057 | { |
| 5058 | error(loc, "Invalid operation for variables with writeonly", GetOperatorString(op)); |
| 5059 | return false; |
| 5060 | } |
| 5061 | |
| 5062 | if (left->getMemoryQualifier().writeonly) |
| 5063 | { |
| 5064 | switch (op) |
| 5065 | { |
| 5066 | case EOpAssign: |
| 5067 | case EOpInitialize: |
| 5068 | case EOpIndexDirect: |
| 5069 | case EOpIndexIndirect: |
| 5070 | case EOpIndexDirectStruct: |
| 5071 | case EOpIndexDirectInterfaceBlock: |
| 5072 | break; |
| 5073 | default: |
| 5074 | error(loc, "Invalid operation for variables with writeonly", GetOperatorString(op)); |
| 5075 | return false; |
| 5076 | } |
| 5077 | } |
| 5078 | |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5079 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 5080 | { |
| 5081 | switch (op) |
| 5082 | { |
| 5083 | case EOpIndexDirectStruct: |
| 5084 | ASSERT(left->getType().getStruct()); |
| 5085 | break; |
| 5086 | case EOpEqual: |
| 5087 | case EOpNotEqual: |
| 5088 | case EOpAssign: |
| 5089 | case EOpInitialize: |
| 5090 | if (left->getType() != right->getType()) |
| 5091 | { |
| 5092 | return false; |
| 5093 | } |
| 5094 | break; |
| 5095 | default: |
| 5096 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 5097 | return false; |
| 5098 | } |
| 5099 | } |
| 5100 | |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5101 | if (left->isInterfaceBlock() || right->isInterfaceBlock()) |
| 5102 | { |
| 5103 | switch (op) |
| 5104 | { |
| 5105 | case EOpIndexDirectInterfaceBlock: |
| 5106 | ASSERT(left->getType().getInterfaceBlock()); |
| 5107 | break; |
| 5108 | default: |
| 5109 | error(loc, "Invalid operation for interface blocks", GetOperatorString(op)); |
| 5110 | return false; |
| 5111 | } |
| 5112 | } |
| 5113 | |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 5114 | if (left->isArray() != right->isArray()) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5115 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 5116 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 5117 | return false; |
| 5118 | } |
| 5119 | |
| 5120 | if (left->isArray()) |
| 5121 | { |
| 5122 | ASSERT(right->isArray()); |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 5123 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5124 | { |
| 5125 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 5126 | return false; |
| 5127 | } |
| 5128 | |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5129 | switch (op) |
| 5130 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5131 | case EOpEqual: |
| 5132 | case EOpNotEqual: |
| 5133 | case EOpAssign: |
| 5134 | case EOpInitialize: |
| 5135 | break; |
| 5136 | default: |
| 5137 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 5138 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5139 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 5140 | // At this point, size of implicitly sized arrays should be resolved. |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 5141 | if (*left->getType().getArraySizes() != *right->getType().getArraySizes()) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5142 | { |
| 5143 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 5144 | return false; |
| 5145 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5146 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5147 | |
| 5148 | // Check ops which require integer / ivec parameters |
| 5149 | bool isBitShift = false; |
| 5150 | switch (op) |
| 5151 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5152 | case EOpBitShiftLeft: |
| 5153 | case EOpBitShiftRight: |
| 5154 | case EOpBitShiftLeftAssign: |
| 5155 | case EOpBitShiftRightAssign: |
| 5156 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 5157 | // check that the basic type is an integer type. |
| 5158 | isBitShift = true; |
| 5159 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 5160 | { |
| 5161 | return false; |
| 5162 | } |
| 5163 | break; |
| 5164 | case EOpBitwiseAnd: |
| 5165 | case EOpBitwiseXor: |
| 5166 | case EOpBitwiseOr: |
| 5167 | case EOpBitwiseAndAssign: |
| 5168 | case EOpBitwiseXorAssign: |
| 5169 | case EOpBitwiseOrAssign: |
| 5170 | // It is enough to check the type of only one operand, since later it |
| 5171 | // is checked that the operand types match. |
| 5172 | if (!IsInteger(left->getBasicType())) |
| 5173 | { |
| 5174 | return false; |
| 5175 | } |
| 5176 | break; |
| 5177 | default: |
| 5178 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5179 | } |
| 5180 | |
| 5181 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 5182 | // So the basic type should usually match. |
| 5183 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 5184 | { |
| 5185 | return false; |
| 5186 | } |
| 5187 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 5188 | // Check that: |
| 5189 | // 1. Type sizes match exactly on ops that require that. |
| 5190 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 5191 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5192 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5193 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5194 | case EOpAssign: |
| 5195 | case EOpInitialize: |
| 5196 | case EOpEqual: |
| 5197 | case EOpNotEqual: |
| 5198 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 5199 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 5200 | { |
| 5201 | error(loc, "undefined operation for structs containing arrays", |
| 5202 | GetOperatorString(op)); |
| 5203 | return false; |
| 5204 | } |
| 5205 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 5206 | // we interpret the spec so that this extends to structs containing samplers, |
| 5207 | // similarly to ESSL 1.00 spec. |
| 5208 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 5209 | left->getType().isStructureContainingSamplers()) |
| 5210 | { |
| 5211 | error(loc, "undefined operation for structs containing samplers", |
| 5212 | GetOperatorString(op)); |
| 5213 | return false; |
| 5214 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5215 | |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 5216 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 5217 | (left->getSecondarySize() != right->getSecondarySize())) |
| 5218 | { |
| 5219 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 5220 | return false; |
| 5221 | } |
| 5222 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5223 | case EOpLessThan: |
| 5224 | case EOpGreaterThan: |
| 5225 | case EOpLessThanEqual: |
| 5226 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 5227 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5228 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 5229 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5230 | return false; |
| 5231 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 5232 | break; |
| 5233 | case EOpAdd: |
| 5234 | case EOpSub: |
| 5235 | case EOpDiv: |
| 5236 | case EOpIMod: |
| 5237 | case EOpBitShiftLeft: |
| 5238 | case EOpBitShiftRight: |
| 5239 | case EOpBitwiseAnd: |
| 5240 | case EOpBitwiseXor: |
| 5241 | case EOpBitwiseOr: |
| 5242 | case EOpAddAssign: |
| 5243 | case EOpSubAssign: |
| 5244 | case EOpDivAssign: |
| 5245 | case EOpIModAssign: |
| 5246 | case EOpBitShiftLeftAssign: |
| 5247 | case EOpBitShiftRightAssign: |
| 5248 | case EOpBitwiseAndAssign: |
| 5249 | case EOpBitwiseXorAssign: |
| 5250 | case EOpBitwiseOrAssign: |
| 5251 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 5252 | { |
| 5253 | return false; |
| 5254 | } |
| 5255 | |
| 5256 | // Are the sizes compatible? |
| 5257 | if (left->getNominalSize() != right->getNominalSize() || |
| 5258 | left->getSecondarySize() != right->getSecondarySize()) |
| 5259 | { |
| 5260 | // If the nominal sizes of operands do not match: |
| 5261 | // One of them must be a scalar. |
| 5262 | if (!left->isScalar() && !right->isScalar()) |
| 5263 | return false; |
| 5264 | |
| 5265 | // In the case of compound assignment other than multiply-assign, |
| 5266 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 5267 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 5268 | // vector either. |
| 5269 | if (!right->isScalar() && |
| 5270 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 5271 | return false; |
| 5272 | } |
| 5273 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5274 | default: |
| 5275 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5276 | } |
| 5277 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5278 | return true; |
| 5279 | } |
| 5280 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 5281 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 5282 | const TType &left, |
| 5283 | const TType &right) |
| 5284 | { |
| 5285 | switch (op) |
| 5286 | { |
| 5287 | case EOpMul: |
| 5288 | case EOpMulAssign: |
| 5289 | return left.getNominalSize() == right.getNominalSize() && |
| 5290 | left.getSecondarySize() == right.getSecondarySize(); |
| 5291 | case EOpVectorTimesScalar: |
| 5292 | return true; |
| 5293 | case EOpVectorTimesScalarAssign: |
| 5294 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 5295 | return left.isVector() && !right.isVector(); |
| 5296 | case EOpVectorTimesMatrix: |
| 5297 | return left.getNominalSize() == right.getRows(); |
| 5298 | case EOpVectorTimesMatrixAssign: |
| 5299 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 5300 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 5301 | left.getNominalSize() == right.getCols(); |
| 5302 | case EOpMatrixTimesVector: |
| 5303 | return left.getCols() == right.getNominalSize(); |
| 5304 | case EOpMatrixTimesScalar: |
| 5305 | return true; |
| 5306 | case EOpMatrixTimesScalarAssign: |
| 5307 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 5308 | return !right.isVector(); |
| 5309 | case EOpMatrixTimesMatrix: |
| 5310 | return left.getCols() == right.getRows(); |
| 5311 | case EOpMatrixTimesMatrixAssign: |
| 5312 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 5313 | // We need to check two things: |
| 5314 | // 1. The matrix multiplication step is valid. |
| 5315 | // 2. The result will have the same number of columns as the lvalue. |
| 5316 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 5317 | |
| 5318 | default: |
| 5319 | UNREACHABLE(); |
| 5320 | return false; |
| 5321 | } |
| 5322 | } |
| 5323 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5324 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 5325 | TIntermTyped *left, |
| 5326 | TIntermTyped *right, |
| 5327 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5328 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5329 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5330 | return nullptr; |
| 5331 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5332 | switch (op) |
| 5333 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5334 | case EOpEqual: |
| 5335 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5336 | case EOpLessThan: |
| 5337 | case EOpGreaterThan: |
| 5338 | case EOpLessThanEqual: |
| 5339 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5340 | break; |
| 5341 | case EOpLogicalOr: |
| 5342 | case EOpLogicalXor: |
| 5343 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5344 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5345 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 5346 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5347 | { |
| 5348 | return nullptr; |
| 5349 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 5350 | // Basic types matching should have been already checked. |
| 5351 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5352 | break; |
| 5353 | case EOpAdd: |
| 5354 | case EOpSub: |
| 5355 | case EOpDiv: |
| 5356 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5357 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5358 | !right->getType().getStruct()); |
| 5359 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5360 | { |
| 5361 | return nullptr; |
| 5362 | } |
| 5363 | break; |
| 5364 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5365 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5366 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5367 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5368 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5369 | { |
| 5370 | return nullptr; |
| 5371 | } |
| 5372 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5373 | default: |
| 5374 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5375 | } |
| 5376 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 5377 | if (op == EOpMul) |
| 5378 | { |
| 5379 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 5380 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 5381 | { |
| 5382 | return nullptr; |
| 5383 | } |
| 5384 | } |
| 5385 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5386 | TIntermBinary *node = new TIntermBinary(op, left, right); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5387 | ASSERT(op != EOpAssign); |
| 5388 | markStaticReadIfSymbol(left); |
| 5389 | markStaticReadIfSymbol(right); |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5390 | node->setLine(loc); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 5391 | return expressionOrFoldedResult(node); |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5392 | } |
| 5393 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5394 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 5395 | TIntermTyped *left, |
| 5396 | TIntermTyped *right, |
| 5397 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5398 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5399 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5400 | if (node == 0) |
| 5401 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 5402 | binaryOpError(loc, GetOperatorString(op), left->getType(), right->getType()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5403 | return left; |
| 5404 | } |
| 5405 | return node; |
| 5406 | } |
| 5407 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5408 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 5409 | TIntermTyped *left, |
| 5410 | TIntermTyped *right, |
| 5411 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5412 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5413 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5414 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5415 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 5416 | binaryOpError(loc, GetOperatorString(op), left->getType(), right->getType()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 5417 | node = CreateBoolNode(false); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5418 | node->setLine(loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5419 | } |
| 5420 | return node; |
| 5421 | } |
| 5422 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5423 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 5424 | TIntermTyped *left, |
| 5425 | TIntermTyped *right, |
| 5426 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5427 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5428 | checkCanBeLValue(loc, "assign", left); |
Olli Etuaho | 7b7d2e6 | 2018-03-23 16:37:36 +0200 | [diff] [blame] | 5429 | TIntermBinary *node = nullptr; |
| 5430 | if (binaryOpCommonCheck(op, left, right, loc)) |
| 5431 | { |
| 5432 | if (op == EOpMulAssign) |
| 5433 | { |
| 5434 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 5435 | if (isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 5436 | { |
| 5437 | node = new TIntermBinary(op, left, right); |
| 5438 | } |
| 5439 | } |
| 5440 | else |
| 5441 | { |
| 5442 | node = new TIntermBinary(op, left, right); |
| 5443 | } |
| 5444 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5445 | if (node == nullptr) |
| 5446 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 5447 | assignError(loc, "assign", left->getType(), right->getType()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5448 | return left; |
| 5449 | } |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5450 | if (op != EOpAssign) |
| 5451 | { |
| 5452 | markStaticReadIfSymbol(left); |
| 5453 | } |
| 5454 | markStaticReadIfSymbol(right); |
Olli Etuaho | 7b7d2e6 | 2018-03-23 16:37:36 +0200 | [diff] [blame] | 5455 | node->setLine(loc); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5456 | return node; |
| 5457 | } |
| 5458 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 5459 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 5460 | TIntermTyped *right, |
| 5461 | const TSourceLoc &loc) |
| 5462 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5463 | // WebGL2 section 5.26, the following results in an error: |
| 5464 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 5465 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 5466 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 5467 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 5468 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5469 | { |
| 5470 | error(loc, |
| 5471 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 5472 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5473 | } |
| 5474 | |
Olli Etuaho | 0e99b7a | 2018-01-12 12:05:48 +0200 | [diff] [blame] | 5475 | TIntermBinary *commaNode = TIntermBinary::CreateComma(left, right, mShaderVersion); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5476 | markStaticReadIfSymbol(left); |
| 5477 | markStaticReadIfSymbol(right); |
| 5478 | commaNode->setLine(loc); |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 5479 | |
| 5480 | return expressionOrFoldedResult(commaNode); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 5481 | } |
| 5482 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5483 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 5484 | { |
| 5485 | switch (op) |
| 5486 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5487 | case EOpContinue: |
| 5488 | if (mLoopNestingLevel <= 0) |
| 5489 | { |
| 5490 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5491 | } |
| 5492 | break; |
| 5493 | case EOpBreak: |
| 5494 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 5495 | { |
| 5496 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5497 | } |
| 5498 | break; |
| 5499 | case EOpReturn: |
| 5500 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 5501 | { |
| 5502 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5503 | } |
| 5504 | break; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5505 | case EOpKill: |
| 5506 | if (mShaderType != GL_FRAGMENT_SHADER) |
| 5507 | { |
| 5508 | error(loc, "discard supported in fragment shaders only", "discard"); |
| 5509 | } |
| 5510 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5511 | default: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5512 | UNREACHABLE(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5513 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5514 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5515 | return addBranch(op, nullptr, loc); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5516 | } |
| 5517 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5518 | TIntermBranch *TParseContext::addBranch(TOperator op, |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5519 | TIntermTyped *expression, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5520 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5521 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5522 | if (expression != nullptr) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5523 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5524 | markStaticReadIfSymbol(expression); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5525 | ASSERT(op == EOpReturn); |
| 5526 | mFunctionReturnsValue = true; |
| 5527 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
| 5528 | { |
| 5529 | error(loc, "void function cannot return a value", "return"); |
| 5530 | } |
| 5531 | else if (*mCurrentFunctionType != expression->getType()) |
| 5532 | { |
| 5533 | error(loc, "function return is not matching type:", "return"); |
| 5534 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5535 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5536 | TIntermBranch *node = new TIntermBranch(op, expression); |
| 5537 | node->setLine(loc); |
| 5538 | return node; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5539 | } |
| 5540 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5541 | void TParseContext::appendStatement(TIntermBlock *block, TIntermNode *statement) |
| 5542 | { |
| 5543 | if (statement != nullptr) |
| 5544 | { |
| 5545 | markStaticReadIfSymbol(statement); |
| 5546 | block->appendStatement(statement); |
| 5547 | } |
| 5548 | } |
| 5549 | |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5550 | void TParseContext::checkTextureGather(TIntermAggregate *functionCall) |
| 5551 | { |
| 5552 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5553 | const TFunction *func = functionCall->getFunction(); |
| 5554 | if (BuiltInGroup::isTextureGather(func)) |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5555 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5556 | bool isTextureGatherOffset = BuiltInGroup::isTextureGatherOffset(func); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5557 | TIntermNode *componentNode = nullptr; |
| 5558 | TIntermSequence *arguments = functionCall->getSequence(); |
| 5559 | ASSERT(arguments->size() >= 2u && arguments->size() <= 4u); |
| 5560 | const TIntermTyped *sampler = arguments->front()->getAsTyped(); |
| 5561 | ASSERT(sampler != nullptr); |
| 5562 | switch (sampler->getBasicType()) |
| 5563 | { |
| 5564 | case EbtSampler2D: |
| 5565 | case EbtISampler2D: |
| 5566 | case EbtUSampler2D: |
| 5567 | case EbtSampler2DArray: |
| 5568 | case EbtISampler2DArray: |
| 5569 | case EbtUSampler2DArray: |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5570 | if ((!isTextureGatherOffset && arguments->size() == 3u) || |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5571 | (isTextureGatherOffset && arguments->size() == 4u)) |
| 5572 | { |
| 5573 | componentNode = arguments->back(); |
| 5574 | } |
| 5575 | break; |
| 5576 | case EbtSamplerCube: |
| 5577 | case EbtISamplerCube: |
| 5578 | case EbtUSamplerCube: |
| 5579 | ASSERT(!isTextureGatherOffset); |
| 5580 | if (arguments->size() == 3u) |
| 5581 | { |
| 5582 | componentNode = arguments->back(); |
| 5583 | } |
| 5584 | break; |
| 5585 | case EbtSampler2DShadow: |
| 5586 | case EbtSampler2DArrayShadow: |
| 5587 | case EbtSamplerCubeShadow: |
| 5588 | break; |
| 5589 | default: |
| 5590 | UNREACHABLE(); |
| 5591 | break; |
| 5592 | } |
| 5593 | if (componentNode) |
| 5594 | { |
| 5595 | const TIntermConstantUnion *componentConstantUnion = |
| 5596 | componentNode->getAsConstantUnion(); |
| 5597 | if (componentNode->getAsTyped()->getQualifier() != EvqConst || !componentConstantUnion) |
| 5598 | { |
| 5599 | error(functionCall->getLine(), "Texture component must be a constant expression", |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5600 | func->name()); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5601 | } |
| 5602 | else |
| 5603 | { |
| 5604 | int component = componentConstantUnion->getIConst(0); |
| 5605 | if (component < 0 || component > 3) |
| 5606 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5607 | error(functionCall->getLine(), "Component must be in the range [0;3]", |
| 5608 | func->name()); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5609 | } |
| 5610 | } |
| 5611 | } |
| 5612 | } |
| 5613 | } |
| 5614 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5615 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 5616 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5617 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5618 | const TFunction *func = functionCall->getFunction(); |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 5619 | TIntermNode *offset = nullptr; |
| 5620 | TIntermSequence *arguments = functionCall->getSequence(); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5621 | bool useTextureGatherOffsetConstraints = false; |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5622 | if (BuiltInGroup::isTextureOffsetNoBias(func)) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5623 | { |
| 5624 | offset = arguments->back(); |
| 5625 | } |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5626 | else if (BuiltInGroup::isTextureOffsetBias(func)) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5627 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5628 | // A bias parameter follows the offset parameter. |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5629 | ASSERT(arguments->size() >= 3); |
| 5630 | offset = (*arguments)[2]; |
| 5631 | } |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5632 | else if (BuiltInGroup::isTextureGatherOffset(func)) |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5633 | { |
| 5634 | ASSERT(arguments->size() >= 3u); |
| 5635 | const TIntermTyped *sampler = arguments->front()->getAsTyped(); |
| 5636 | ASSERT(sampler != nullptr); |
| 5637 | switch (sampler->getBasicType()) |
| 5638 | { |
| 5639 | case EbtSampler2D: |
| 5640 | case EbtISampler2D: |
| 5641 | case EbtUSampler2D: |
| 5642 | case EbtSampler2DArray: |
| 5643 | case EbtISampler2DArray: |
| 5644 | case EbtUSampler2DArray: |
| 5645 | offset = (*arguments)[2]; |
| 5646 | break; |
| 5647 | case EbtSampler2DShadow: |
| 5648 | case EbtSampler2DArrayShadow: |
| 5649 | offset = (*arguments)[3]; |
| 5650 | break; |
| 5651 | default: |
| 5652 | UNREACHABLE(); |
| 5653 | break; |
| 5654 | } |
| 5655 | useTextureGatherOffsetConstraints = true; |
| 5656 | } |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5657 | if (offset != nullptr) |
| 5658 | { |
| 5659 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 5660 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 5661 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5662 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
| 5663 | func->name()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5664 | } |
| 5665 | else |
| 5666 | { |
| 5667 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 5668 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 5669 | const TConstantUnion *values = offsetConstantUnion->getConstantValue(); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5670 | int minOffsetValue = useTextureGatherOffsetConstraints ? mMinProgramTextureGatherOffset |
| 5671 | : mMinProgramTexelOffset; |
| 5672 | int maxOffsetValue = useTextureGatherOffsetConstraints ? mMaxProgramTextureGatherOffset |
| 5673 | : mMaxProgramTexelOffset; |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5674 | for (size_t i = 0u; i < size; ++i) |
| 5675 | { |
| 5676 | int offsetValue = values[i].getIConst(); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5677 | if (offsetValue > maxOffsetValue || offsetValue < minOffsetValue) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5678 | { |
Jonah Ryan-Davis | f563fdc | 2019-01-31 13:53:59 -0500 | [diff] [blame] | 5679 | std::stringstream tokenStream = sh::InitializeStream<std::stringstream>(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5680 | tokenStream << offsetValue; |
| 5681 | std::string token = tokenStream.str(); |
| 5682 | error(offset->getLine(), "Texture offset value out of valid range", |
| 5683 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5684 | } |
| 5685 | } |
| 5686 | } |
| 5687 | } |
| 5688 | } |
| 5689 | |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5690 | void TParseContext::checkAtomicMemoryBuiltinFunctions(TIntermAggregate *functionCall) |
| 5691 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5692 | const TFunction *func = functionCall->getFunction(); |
| 5693 | if (BuiltInGroup::isAtomicMemory(func)) |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5694 | { |
Jiawei Shao | a6a7842 | 2018-06-28 08:32:54 +0800 | [diff] [blame] | 5695 | ASSERT(IsAtomicFunction(functionCall->getOp())); |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5696 | TIntermSequence *arguments = functionCall->getSequence(); |
| 5697 | TIntermTyped *memNode = (*arguments)[0]->getAsTyped(); |
| 5698 | |
| 5699 | if (IsBufferOrSharedVariable(memNode)) |
| 5700 | { |
| 5701 | return; |
| 5702 | } |
| 5703 | |
| 5704 | while (memNode->getAsBinaryNode()) |
| 5705 | { |
| 5706 | memNode = memNode->getAsBinaryNode()->getLeft(); |
| 5707 | if (IsBufferOrSharedVariable(memNode)) |
| 5708 | { |
| 5709 | return; |
| 5710 | } |
| 5711 | } |
| 5712 | |
| 5713 | error(memNode->getLine(), |
| 5714 | "The value passed to the mem argument of an atomic memory function does not " |
| 5715 | "correspond to a buffer or shared variable.", |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5716 | func->name()); |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5717 | } |
| 5718 | } |
| 5719 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5720 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 5721 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 5722 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5723 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5724 | |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5725 | const TFunction *func = functionCall->getFunction(); |
| 5726 | |
| 5727 | if (BuiltInGroup::isImage(func)) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5728 | { |
| 5729 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5730 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5731 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5732 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5733 | |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5734 | if (BuiltInGroup::isImageStore(func)) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5735 | { |
| 5736 | if (memoryQualifier.readonly) |
| 5737 | { |
| 5738 | error(imageNode->getLine(), |
| 5739 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5740 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5741 | } |
| 5742 | } |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5743 | else if (BuiltInGroup::isImageLoad(func)) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5744 | { |
| 5745 | if (memoryQualifier.writeonly) |
| 5746 | { |
| 5747 | error(imageNode->getLine(), |
| 5748 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5749 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5750 | } |
| 5751 | } |
| 5752 | } |
| 5753 | } |
| 5754 | |
| 5755 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 5756 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 5757 | const TFunction *functionDefinition, |
| 5758 | const TIntermAggregate *functionCall) |
| 5759 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5760 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5761 | |
| 5762 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 5763 | |
| 5764 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 5765 | |
| 5766 | for (size_t i = 0; i < arguments.size(); ++i) |
| 5767 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5768 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 5769 | const TType &functionArgumentType = typedArgument->getType(); |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 5770 | const TType &functionParameterType = functionDefinition->getParam(i)->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5771 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 5772 | |
| 5773 | if (IsImage(functionArgumentType.getBasicType())) |
| 5774 | { |
| 5775 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 5776 | functionArgumentType.getMemoryQualifier(); |
| 5777 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 5778 | functionParameterType.getMemoryQualifier(); |
| 5779 | if (functionArgumentMemoryQualifier.readonly && |
| 5780 | !functionParameterMemoryQualifier.readonly) |
| 5781 | { |
| 5782 | error(functionCall->getLine(), |
| 5783 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5784 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5785 | } |
| 5786 | |
| 5787 | if (functionArgumentMemoryQualifier.writeonly && |
| 5788 | !functionParameterMemoryQualifier.writeonly) |
| 5789 | { |
| 5790 | error(functionCall->getLine(), |
| 5791 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5792 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5793 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5794 | |
| 5795 | if (functionArgumentMemoryQualifier.coherent && |
| 5796 | !functionParameterMemoryQualifier.coherent) |
| 5797 | { |
| 5798 | error(functionCall->getLine(), |
| 5799 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5800 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5801 | } |
| 5802 | |
| 5803 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 5804 | !functionParameterMemoryQualifier.volatileQualifier) |
| 5805 | { |
| 5806 | error(functionCall->getLine(), |
| 5807 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5808 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5809 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5810 | } |
| 5811 | } |
| 5812 | } |
| 5813 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5814 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunctionLookup *fnCall, const TSourceLoc &loc) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5815 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5816 | if (fnCall->thisNode() != nullptr) |
| 5817 | { |
| 5818 | return addMethod(fnCall, loc); |
| 5819 | } |
| 5820 | if (fnCall->isConstructor()) |
| 5821 | { |
| 5822 | return addConstructor(fnCall, loc); |
| 5823 | } |
| 5824 | return addNonConstructorFunctionCall(fnCall, loc); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5825 | } |
| 5826 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5827 | TIntermTyped *TParseContext::addMethod(TFunctionLookup *fnCall, const TSourceLoc &loc) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5828 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5829 | TIntermTyped *thisNode = fnCall->thisNode(); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5830 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 5831 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 5832 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 5833 | // So accessing fnCall->name() below is safe. |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5834 | if (fnCall->name() != "length") |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5835 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 5836 | error(loc, "invalid method", fnCall->name()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5837 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5838 | else if (!fnCall->arguments().empty()) |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5839 | { |
| 5840 | error(loc, "method takes no parameters", "length"); |
| 5841 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5842 | else if (!thisNode->isArray()) |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5843 | { |
| 5844 | error(loc, "length can only be called on arrays", "length"); |
| 5845 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5846 | else if (thisNode->getQualifier() == EvqPerVertexIn && |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 5847 | mGeometryShaderInputPrimitiveType == EptUndefined) |
| 5848 | { |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 5849 | ASSERT(mShaderType == GL_GEOMETRY_SHADER_EXT); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 5850 | error(loc, "missing input primitive declaration before calling length on gl_in", "length"); |
| 5851 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5852 | else |
| 5853 | { |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 5854 | TIntermUnary *node = new TIntermUnary(EOpArrayLength, thisNode, nullptr); |
Qin Jiajia | 19f2f9e | 2018-12-07 15:10:48 +0800 | [diff] [blame] | 5855 | markStaticReadIfSymbol(thisNode); |
Olli Etuaho | bb2bbfb | 2017-08-24 15:43:33 +0300 | [diff] [blame] | 5856 | node->setLine(loc); |
| 5857 | return node->fold(mDiagnostics); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5858 | } |
Olli Etuaho | bb2bbfb | 2017-08-24 15:43:33 +0300 | [diff] [blame] | 5859 | return CreateZeroNode(TType(EbtInt, EbpUndefined, EvqConst)); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5860 | } |
| 5861 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5862 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunctionLookup *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5863 | const TSourceLoc &loc) |
| 5864 | { |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 5865 | // First check whether the function has been hidden by a variable name or struct typename by |
| 5866 | // using the symbol looked up in the lexical phase. If the function is not hidden, look for one |
| 5867 | // with a matching argument list. |
| 5868 | if (fnCall->symbol() != nullptr && !fnCall->symbol()->isFunction()) |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5869 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 5870 | error(loc, "function name expected", fnCall->name()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5871 | } |
| 5872 | else |
| 5873 | { |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5874 | // There are no inner functions, so it's enough to look for user-defined functions in the |
| 5875 | // global scope. |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 5876 | const TSymbol *symbol = symbolTable.findGlobal(fnCall->getMangledName()); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5877 | if (symbol != nullptr) |
| 5878 | { |
| 5879 | // A user-defined function - could be an overloaded built-in as well. |
| 5880 | ASSERT(symbol->symbolType() == SymbolType::UserDefined); |
| 5881 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
| 5882 | TIntermAggregate *callNode = |
| 5883 | TIntermAggregate::CreateFunctionCall(*fnCandidate, &fnCall->arguments()); |
| 5884 | callNode->setLine(loc); |
| 5885 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
| 5886 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
| 5887 | return callNode; |
| 5888 | } |
| 5889 | |
| 5890 | symbol = symbolTable.findBuiltIn(fnCall->getMangledName(), mShaderVersion); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5891 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5892 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 5893 | error(loc, "no matching overloaded function found", fnCall->name()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5894 | } |
| 5895 | else |
| 5896 | { |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5897 | // A built-in function. |
| 5898 | ASSERT(symbol->symbolType() == SymbolType::BuiltIn); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5899 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5900 | |
Olli Etuaho | 37b697e | 2018-01-29 12:19:27 +0200 | [diff] [blame] | 5901 | if (fnCandidate->extension() != TExtension::UNDEFINED) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5902 | { |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 5903 | checkCanUseExtension(loc, fnCandidate->extension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5904 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5905 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5906 | if (op != EOpCallBuiltInFunction) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5907 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5908 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5909 | if (fnCandidate->getParamCount() == 1) |
| 5910 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5911 | // Treat it like a built-in unary operator. |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5912 | TIntermNode *unaryParamNode = fnCall->arguments().front(); |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 5913 | TIntermTyped *callNode = |
| 5914 | createUnaryMath(op, unaryParamNode->getAsTyped(), loc, fnCandidate); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 5915 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5916 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5917 | } |
Jiawei Shao | a6a7842 | 2018-06-28 08:32:54 +0800 | [diff] [blame] | 5918 | |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5919 | TIntermAggregate *callNode = |
| 5920 | TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, &fnCall->arguments()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5921 | callNode->setLine(loc); |
| 5922 | |
Jiawei Shao | a6a7842 | 2018-06-28 08:32:54 +0800 | [diff] [blame] | 5923 | checkAtomicMemoryBuiltinFunctions(callNode); |
| 5924 | |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5925 | // Some built-in functions have out parameters too. |
| 5926 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
| 5927 | |
| 5928 | // See if we can constant fold a built-in. Note that this may be possible |
| 5929 | // even if it is not const-qualified. |
| 5930 | return callNode->fold(mDiagnostics); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5931 | } |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5932 | |
| 5933 | // This is a built-in function with no op associated with it. |
| 5934 | TIntermAggregate *callNode = |
| 5935 | TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, &fnCall->arguments()); |
| 5936 | callNode->setLine(loc); |
| 5937 | checkTextureOffsetConst(callNode); |
| 5938 | checkTextureGather(callNode); |
| 5939 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5940 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
| 5941 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5942 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5943 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5944 | |
| 5945 | // Error message was already written. Put on a dummy node for error recovery. |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 5946 | return CreateZeroNode(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5947 | } |
| 5948 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5949 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5950 | TIntermTyped *trueExpression, |
| 5951 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5952 | const TSourceLoc &loc) |
| 5953 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5954 | if (!checkIsScalarBool(loc, cond)) |
| 5955 | { |
| 5956 | return falseExpression; |
| 5957 | } |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5958 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5959 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5960 | { |
Olli Etuaho | 72e3589 | 2018-06-20 11:43:08 +0300 | [diff] [blame] | 5961 | TInfoSinkBase reasonStream; |
| 5962 | reasonStream << "mismatching ternary operator operand types '" << trueExpression->getType() |
| 5963 | << " and '" << falseExpression->getType() << "'"; |
| 5964 | error(loc, reasonStream.c_str(), "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5965 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5966 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5967 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 5968 | { |
| 5969 | // ESSL 1.00 section 4.1.7 |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5970 | // ESSL 3.00.6 section 4.1.7 |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5971 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 5972 | // Note that structs containing opaque types don't need to be checked as structs are |
| 5973 | // forbidden below. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5974 | error(loc, "ternary operator is not allowed for opaque types", "?:"); |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5975 | return falseExpression; |
| 5976 | } |
| 5977 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 5978 | if (cond->getMemoryQualifier().writeonly || trueExpression->getMemoryQualifier().writeonly || |
| 5979 | falseExpression->getMemoryQualifier().writeonly) |
| 5980 | { |
| 5981 | error(loc, "ternary operator is not allowed for variables with writeonly", "?:"); |
| 5982 | return falseExpression; |
| 5983 | } |
| 5984 | |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5985 | // ESSL 1.00.17 sections 5.2 and 5.7: |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5986 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5987 | // ESSL 3.00.6 section 5.7: |
| 5988 | // Ternary operator support is optional for arrays. No certainty that it works across all |
| 5989 | // devices with struct either, so we err on the side of caution here. TODO (oetuaho@nvidia.com): |
| 5990 | // Would be nice to make the spec and implementation agree completely here. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5991 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5992 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5993 | error(loc, "ternary operator is not allowed for structures or arrays", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5994 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5995 | } |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5996 | if (trueExpression->getBasicType() == EbtInterfaceBlock) |
| 5997 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5998 | error(loc, "ternary operator is not allowed for interface blocks", "?:"); |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5999 | return falseExpression; |
| 6000 | } |
| 6001 | |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 6002 | // WebGL2 section 5.26, the following results in an error: |
| 6003 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 6004 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 6005 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 6006 | error(loc, "ternary operator is not allowed for void", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 6007 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 6008 | } |
| 6009 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 6010 | TIntermTernary *node = new TIntermTernary(cond, trueExpression, falseExpression); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 6011 | markStaticReadIfSymbol(cond); |
| 6012 | markStaticReadIfSymbol(trueExpression); |
| 6013 | markStaticReadIfSymbol(falseExpression); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 6014 | node->setLine(loc); |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 6015 | return expressionOrFoldedResult(node); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 6016 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 6017 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 6018 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 6019 | // Parse an array of strings using yyparse. |
| 6020 | // |
| 6021 | // Returns 0 for success. |
| 6022 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 6023 | int PaParseStrings(size_t count, |
| 6024 | const char *const string[], |
| 6025 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 6026 | TParseContext *context) |
| 6027 | { |
Yunchao He | 4f28544 | 2017-04-21 12:15:49 +0800 | [diff] [blame] | 6028 | if ((count == 0) || (string == nullptr)) |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 6029 | return 1; |
| 6030 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 6031 | if (glslang_initialize(context)) |
| 6032 | return 1; |
| 6033 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 6034 | int error = glslang_scan(count, string, length, context); |
| 6035 | if (!error) |
| 6036 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 6037 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 6038 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 6039 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 6040 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 6041 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 6042 | |
| 6043 | } // namespace sh |