blob: ba481e8d2a97ec8c877388b21dbe0a722794c7a9 [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
14#include "src/sksl/SkSLAnalysis.h"
15#include "src/sksl/ir/SkSLBinaryExpression.h"
16#include "src/sksl/ir/SkSLBoolLiteral.h"
17#include "src/sksl/ir/SkSLBreakStatement.h"
18#include "src/sksl/ir/SkSLConstructor.h"
19#include "src/sksl/ir/SkSLContinueStatement.h"
20#include "src/sksl/ir/SkSLDiscardStatement.h"
21#include "src/sksl/ir/SkSLDoStatement.h"
22#include "src/sksl/ir/SkSLEnum.h"
23#include "src/sksl/ir/SkSLExpressionStatement.h"
24#include "src/sksl/ir/SkSLExternalFunctionCall.h"
25#include "src/sksl/ir/SkSLExternalValueReference.h"
26#include "src/sksl/ir/SkSLField.h"
27#include "src/sksl/ir/SkSLFieldAccess.h"
28#include "src/sksl/ir/SkSLFloatLiteral.h"
29#include "src/sksl/ir/SkSLForStatement.h"
30#include "src/sksl/ir/SkSLFunctionCall.h"
31#include "src/sksl/ir/SkSLFunctionDeclaration.h"
32#include "src/sksl/ir/SkSLFunctionDefinition.h"
33#include "src/sksl/ir/SkSLFunctionReference.h"
34#include "src/sksl/ir/SkSLIfStatement.h"
35#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040036#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040037#include "src/sksl/ir/SkSLIntLiteral.h"
38#include "src/sksl/ir/SkSLInterfaceBlock.h"
39#include "src/sksl/ir/SkSLLayout.h"
40#include "src/sksl/ir/SkSLNop.h"
41#include "src/sksl/ir/SkSLNullLiteral.h"
42#include "src/sksl/ir/SkSLPostfixExpression.h"
43#include "src/sksl/ir/SkSLPrefixExpression.h"
44#include "src/sksl/ir/SkSLReturnStatement.h"
45#include "src/sksl/ir/SkSLSetting.h"
46#include "src/sksl/ir/SkSLSwitchCase.h"
47#include "src/sksl/ir/SkSLSwitchStatement.h"
48#include "src/sksl/ir/SkSLSwizzle.h"
49#include "src/sksl/ir/SkSLTernaryExpression.h"
50#include "src/sksl/ir/SkSLUnresolvedFunction.h"
51#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040052#include "src/sksl/ir/SkSLVariable.h"
53#include "src/sksl/ir/SkSLVariableReference.h"
54#include "src/sksl/ir/SkSLWhileStatement.h"
55
56namespace SkSL {
57namespace {
58
John Stiles031a7672020-11-13 16:13:18 -050059static constexpr int kInlinedStatementLimit = 2500;
60
John Stiles345d7212020-12-15 18:06:29 -050061static int count_returns_up_to_limit(const FunctionDefinition& funcDef, int limit) {
John Stiles44dff4f2020-09-21 12:28:01 -040062 class CountReturnsWithLimit : public ProgramVisitor {
John Stiles44e96be2020-08-31 13:16:04 -040063 public:
John Stiles44dff4f2020-09-21 12:28:01 -040064 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
John Stiles44e96be2020-08-31 13:16:04 -040065 this->visitProgramElement(funcDef);
66 }
67
68 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040069 switch (stmt.kind()) {
70 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040071 ++fNumReturns;
John Stiles345d7212020-12-15 18:06:29 -050072 return (fNumReturns >= fLimit) || INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040073
74 default:
John Stiles93442622020-09-11 12:11:27 -040075 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040076 }
77 }
78
79 int fNumReturns = 0;
John Stiles44dff4f2020-09-21 12:28:01 -040080 int fLimit = 0;
John Stiles44e96be2020-08-31 13:16:04 -040081 using INHERITED = ProgramVisitor;
82 };
83
John Stiles345d7212020-12-15 18:06:29 -050084 return CountReturnsWithLimit{funcDef, limit}.fNumReturns;
John Stiles44e96be2020-08-31 13:16:04 -040085}
86
87static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
88 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
89 public:
90 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
91 this->visitProgramElement(funcDef);
92 }
93
94 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040095 switch (stmt.kind()) {
96 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040097 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040098 const auto& block = stmt.as<Block>();
99 return block.children().size() &&
100 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -0400101 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400102 case Statement::Kind::kSwitch:
103 case Statement::Kind::kWhile:
104 case Statement::Kind::kDo:
105 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -0400106 // Don't introspect switches or loop structures at all.
107 return false;
108
Ethan Nicholase6592142020-09-08 10:22:09 -0400109 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -0400110 ++fNumReturns;
111 [[fallthrough]];
112
113 default:
John Stiles93442622020-09-11 12:11:27 -0400114 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400115 }
116 }
117
118 int fNumReturns = 0;
119 using INHERITED = ProgramVisitor;
120 };
121
122 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
123}
124
125static int count_returns_in_breakable_constructs(const FunctionDefinition& funcDef) {
126 class CountReturnsInBreakableConstructs : public ProgramVisitor {
127 public:
128 CountReturnsInBreakableConstructs(const FunctionDefinition& funcDef) {
129 this->visitProgramElement(funcDef);
130 }
131
132 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -0400133 switch (stmt.kind()) {
134 case Statement::Kind::kSwitch:
135 case Statement::Kind::kWhile:
136 case Statement::Kind::kDo:
137 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400138 ++fInsideBreakableConstruct;
John Stiles93442622020-09-11 12:11:27 -0400139 bool result = INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400140 --fInsideBreakableConstruct;
141 return result;
142 }
143
Ethan Nicholase6592142020-09-08 10:22:09 -0400144 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -0400145 fNumReturns += (fInsideBreakableConstruct > 0) ? 1 : 0;
146 [[fallthrough]];
147
148 default:
John Stiles93442622020-09-11 12:11:27 -0400149 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400150 }
151 }
152
153 int fNumReturns = 0;
154 int fInsideBreakableConstruct = 0;
155 using INHERITED = ProgramVisitor;
156 };
157
158 return CountReturnsInBreakableConstructs{funcDef}.fNumReturns;
159}
160
John Stiles991b09d2020-09-10 13:33:40 -0400161static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
162 class ContainsRecursiveCall : public ProgramVisitor {
163 public:
164 bool visit(const FunctionDeclaration& funcDecl) {
165 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400166 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
167 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400168 }
169
170 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400171 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400172 return true;
173 }
174 return INHERITED::visitExpression(expr);
175 }
176
177 bool visitStatement(const Statement& stmt) override {
Ethan Nicholasceb62142020-10-09 16:51:18 -0400178 if (stmt.is<InlineMarker>() &&
179 stmt.as<InlineMarker>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400180 return true;
181 }
182 return INHERITED::visitStatement(stmt);
183 }
184
185 const FunctionDeclaration* fFuncDecl;
186 using INHERITED = ProgramVisitor;
187 };
188
189 return ContainsRecursiveCall{}.visit(funcDecl);
190}
191
John Stiles44e96be2020-08-31 13:16:04 -0400192static const Type* copy_if_needed(const Type* src, SymbolTable& symbolTable) {
John Stilesc0c51062020-12-03 17:16:29 -0500193 if (src->isArray()) {
John Stiles74ff1d62020-11-30 11:56:16 -0500194 const Type* innerType = copy_if_needed(&src->componentType(), symbolTable);
John Stilesad2d4942020-12-11 16:55:58 -0500195 return symbolTable.takeOwnershipOfSymbol(Type::MakeArrayType(src->name(), *innerType,
196 src->columns()));
John Stiles44e96be2020-08-31 13:16:04 -0400197 }
198 return src;
199}
200
John Stiles6d696082020-10-01 10:18:54 -0400201static std::unique_ptr<Statement>* find_parent_statement(
202 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400203 SkASSERT(!stmtStack.empty());
204
205 // Walk the statement stack from back to front, ignoring the last element (which is the
206 // enclosing statement).
207 auto iter = stmtStack.rbegin();
208 ++iter;
209
210 // Anything counts as a parent statement other than a scopeless Block.
211 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400212 std::unique_ptr<Statement>* stmt = *iter;
213 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400214 return stmt;
215 }
216 }
217
218 // There wasn't any parent statement to be found.
219 return nullptr;
220}
221
John Stilese41b4ee2020-09-28 12:28:16 -0400222std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
223 VariableReference::RefKind refKind) {
224 std::unique_ptr<Expression> clone = expr.clone();
John Stiles70b82422020-09-30 10:55:12 -0400225 class SetRefKindInExpression : public ProgramWriter {
John Stilese41b4ee2020-09-28 12:28:16 -0400226 public:
227 SetRefKindInExpression(VariableReference::RefKind refKind) : fRefKind(refKind) {}
John Stiles70b82422020-09-30 10:55:12 -0400228 bool visitExpression(Expression& expr) override {
John Stilese41b4ee2020-09-28 12:28:16 -0400229 if (expr.is<VariableReference>()) {
John Stiles70b82422020-09-30 10:55:12 -0400230 expr.as<VariableReference>().setRefKind(fRefKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400231 }
232 return INHERITED::visitExpression(expr);
233 }
234
235 private:
236 VariableReference::RefKind fRefKind;
237
John Stiles70b82422020-09-30 10:55:12 -0400238 using INHERITED = ProgramWriter;
John Stilese41b4ee2020-09-28 12:28:16 -0400239 };
240
241 SetRefKindInExpression{refKind}.visitExpression(*clone);
242 return clone;
243}
244
John Stiles44e96be2020-08-31 13:16:04 -0400245} // namespace
246
John Stiles345d7212020-12-15 18:06:29 -0500247Inliner::ReturnComplexity Inliner::GetReturnComplexity(const FunctionDefinition& funcDef) {
248 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
249 int numReturns = count_returns_up_to_limit(funcDef, returnsAtEndOfControlFlow + 1);
250
251 return (numReturns > returnsAtEndOfControlFlow)
252 ? ReturnComplexity::kEarlyReturns
253 : (numReturns > 1) ? ReturnComplexity::kReturnsAtEndOfControlFlow
254 : ReturnComplexity::kSingleReturn;
255}
256
John Stilesb61ee902020-09-21 12:26:59 -0400257void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
258 // No changes necessary if this statement isn't actually a block.
259 if (!inlinedBody || !inlinedBody->is<Block>()) {
260 return;
261 }
262
263 // No changes necessary if the parent statement doesn't require a scope.
264 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
265 parentStmt->is<DoStatement>() || parentStmt->is<WhileStatement>())) {
266 return;
267 }
268
269 Block& block = inlinedBody->as<Block>();
270
271 // The inliner will create inlined function bodies as a Block containing multiple statements,
272 // but no scope. Normally, this is fine, but if this block is used as the statement for a
273 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
274 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
275 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
276 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
277 // absorbing the following statement into our loop--so we also add a scope to these.
278 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400279 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400280 // We found an explicit scope; all is well.
281 return;
282 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400283 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400284 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
285 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400286 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400287 return;
288 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400289 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400290 // This block has exactly one thing inside, and it's not another block. No need to scope
291 // it.
292 return;
293 }
294 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400295 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400296 }
297}
298
Brian Osman0006ad02020-11-18 15:38:39 -0500299void Inliner::reset(ModifiersPool* modifiers, const Program::Settings* settings) {
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400300 fModifiers = modifiers;
301 fSettings = settings;
John Stiles44e96be2020-08-31 13:16:04 -0400302 fInlineVarCounter = 0;
John Stiles031a7672020-11-13 16:13:18 -0500303 fInlinedStatementCounter = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400304}
305
John Stilesc75abb82020-09-14 18:24:12 -0400306String Inliner::uniqueNameForInlineVar(const String& baseName, SymbolTable* symbolTable) {
307 // If the base name starts with an underscore, like "_coords", we can't append another
308 // underscore, because OpenGL disallows two consecutive underscores anywhere in the string. But
309 // in the general case, using the underscore as a splitter reads nicely enough that it's worth
310 // putting in this special case.
311 const char* splitter = baseName.startsWith("_") ? "" : "_";
312
313 // Append a unique numeric prefix to avoid name overlap. Check the symbol table to make sure
314 // we're not reusing an existing name. (Note that within a single compilation pass, this check
315 // isn't fully comprehensive, as code isn't always generated in top-to-bottom order.)
316 String uniqueName;
317 for (;;) {
318 uniqueName = String::printf("_%d%s%s", fInlineVarCounter++, splitter, baseName.c_str());
319 StringFragment frag{uniqueName.data(), uniqueName.length()};
320 if ((*symbolTable)[frag] == nullptr) {
321 break;
322 }
323 }
324
325 return uniqueName;
326}
327
John Stiles44e96be2020-08-31 13:16:04 -0400328std::unique_ptr<Expression> Inliner::inlineExpression(int offset,
329 VariableRewriteMap* varMap,
John Stilesd7cc0932020-11-30 12:24:27 -0500330 SymbolTable* symbolTableForExpression,
John Stiles44e96be2020-08-31 13:16:04 -0400331 const Expression& expression) {
332 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
333 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500334 return this->inlineExpression(offset, varMap, symbolTableForExpression, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400335 }
336 return nullptr;
337 };
John Stiles8e3b6be2020-10-13 11:14:08 -0400338 auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray {
339 ExpressionArray args;
John Stilesf4bda742020-10-14 16:57:41 -0400340 args.reserve_back(originalArgs.size());
John Stiles44e96be2020-08-31 13:16:04 -0400341 for (const std::unique_ptr<Expression>& arg : originalArgs) {
342 args.push_back(expr(arg));
343 }
344 return args;
345 };
346
Ethan Nicholase6592142020-09-08 10:22:09 -0400347 switch (expression.kind()) {
348 case Expression::Kind::kBinary: {
John Stiles44e96be2020-08-31 13:16:04 -0400349 const BinaryExpression& b = expression.as<BinaryExpression>();
350 return std::make_unique<BinaryExpression>(offset,
John Stiles2d4f9592020-10-30 10:29:12 -0400351 expr(b.left()),
Ethan Nicholasc8d9c8e2020-09-22 15:05:37 -0400352 b.getOperator(),
John Stiles2d4f9592020-10-30 10:29:12 -0400353 expr(b.right()),
Ethan Nicholas30d30222020-09-11 12:27:26 -0400354 &b.type());
John Stiles44e96be2020-08-31 13:16:04 -0400355 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400356 case Expression::Kind::kBoolLiteral:
357 case Expression::Kind::kIntLiteral:
358 case Expression::Kind::kFloatLiteral:
359 case Expression::Kind::kNullLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400360 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400361 case Expression::Kind::kConstructor: {
John Stiles44e96be2020-08-31 13:16:04 -0400362 const Constructor& constructor = expression.as<Constructor>();
John Stilesd7cc0932020-11-30 12:24:27 -0500363 const Type* type = copy_if_needed(&constructor.type(), *symbolTableForExpression);
364 return std::make_unique<Constructor>(offset, type, argList(constructor.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400365 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400366 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400367 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400368 return std::make_unique<ExternalFunctionCall>(offset, &externalCall.function(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400369 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400370 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400371 case Expression::Kind::kExternalValue:
John Stiles44e96be2020-08-31 13:16:04 -0400372 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400373 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400374 const FieldAccess& f = expression.as<FieldAccess>();
Ethan Nicholas7a95b202020-10-09 11:55:40 -0400375 return std::make_unique<FieldAccess>(expr(f.base()), f.fieldIndex(), f.ownerKind());
John Stiles44e96be2020-08-31 13:16:04 -0400376 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400377 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400378 const FunctionCall& funcCall = expression.as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400379 return std::make_unique<FunctionCall>(offset, &funcCall.type(), &funcCall.function(),
380 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400381 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400382 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400383 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400384 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400385 const IndexExpression& idx = expression.as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400386 return std::make_unique<IndexExpression>(*fContext, expr(idx.base()),
387 expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400388 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400389 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400390 const PrefixExpression& p = expression.as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400391 return std::make_unique<PrefixExpression>(p.getOperator(), expr(p.operand()));
John Stiles44e96be2020-08-31 13:16:04 -0400392 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400393 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400394 const PostfixExpression& p = expression.as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400395 return std::make_unique<PostfixExpression>(expr(p.operand()), p.getOperator());
John Stiles44e96be2020-08-31 13:16:04 -0400396 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400397 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400398 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400399 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400400 const Swizzle& s = expression.as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -0400401 return std::make_unique<Swizzle>(*fContext, expr(s.base()), s.components());
John Stiles44e96be2020-08-31 13:16:04 -0400402 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400403 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400404 const TernaryExpression& t = expression.as<TernaryExpression>();
Ethan Nicholasdd218162020-10-08 05:48:01 -0400405 return std::make_unique<TernaryExpression>(offset, expr(t.test()),
406 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400407 }
Brian Osman83ba9302020-09-11 13:33:46 -0400408 case Expression::Kind::kTypeReference:
409 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400410 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400411 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400412 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400413 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400414 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400415 }
416 return v.clone();
417 }
418 default:
419 SkASSERT(false);
420 return nullptr;
421 }
422}
423
424std::unique_ptr<Statement> Inliner::inlineStatement(int offset,
425 VariableRewriteMap* varMap,
426 SymbolTable* symbolTableForStatement,
John Stiles345d7212020-12-15 18:06:29 -0500427 std::unique_ptr<Expression>* resultExpr,
428 ReturnComplexity returnComplexity,
Brian Osman3887a012020-09-30 13:22:27 -0400429 const Statement& statement,
430 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400431 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
432 if (s) {
John Stilesa5f3c312020-09-22 12:05:16 -0400433 return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr,
John Stiles345d7212020-12-15 18:06:29 -0500434 returnComplexity, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400435 }
436 return nullptr;
437 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400438 auto blockStmts = [&](const Block& block) {
John Stiles8f2a0cf2020-10-13 12:48:21 -0400439 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400440 result.reserve_back(block.children().size());
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400441 for (const std::unique_ptr<Statement>& child : block.children()) {
442 result.push_back(stmt(child));
443 }
444 return result;
445 };
John Stiles8f2a0cf2020-10-13 12:48:21 -0400446 auto stmts = [&](const StatementArray& ss) {
447 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400448 result.reserve_back(ss.size());
John Stiles44e96be2020-08-31 13:16:04 -0400449 for (const auto& s : ss) {
450 result.push_back(stmt(s));
451 }
452 return result;
453 };
454 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
455 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500456 return this->inlineExpression(offset, varMap, symbolTableForStatement, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400457 }
458 return nullptr;
459 };
John Stiles031a7672020-11-13 16:13:18 -0500460
461 ++fInlinedStatementCounter;
462
Ethan Nicholase6592142020-09-08 10:22:09 -0400463 switch (statement.kind()) {
464 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400465 const Block& b = statement.as<Block>();
John Stilesa1e2b412020-10-20 14:51:28 -0400466 return std::make_unique<Block>(offset, blockStmts(b),
467 SymbolTable::WrapIfBuiltin(b.symbolTable()),
468 b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400469 }
470
Ethan Nicholase6592142020-09-08 10:22:09 -0400471 case Statement::Kind::kBreak:
472 case Statement::Kind::kContinue:
473 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400474 return statement.clone();
475
Ethan Nicholase6592142020-09-08 10:22:09 -0400476 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400477 const DoStatement& d = statement.as<DoStatement>();
Ethan Nicholas1fd61162020-09-28 13:14:19 -0400478 return std::make_unique<DoStatement>(offset, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400479 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400480 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400481 const ExpressionStatement& e = statement.as<ExpressionStatement>();
Ethan Nicholasd503a5a2020-09-30 09:29:55 -0400482 return std::make_unique<ExpressionStatement>(expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400483 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400484 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400485 const ForStatement& f = statement.as<ForStatement>();
486 // need to ensure initializer is evaluated first so that we've already remapped its
487 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400488 std::unique_ptr<Statement> initializer = stmt(f.initializer());
489 return std::make_unique<ForStatement>(offset, std::move(initializer), expr(f.test()),
John Stilesa1e2b412020-10-20 14:51:28 -0400490 expr(f.next()), stmt(f.statement()),
491 SymbolTable::WrapIfBuiltin(f.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400492 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400493 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400494 const IfStatement& i = statement.as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400495 return std::make_unique<IfStatement>(offset, i.isStatic(), expr(i.test()),
496 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400497 }
John Stiles98c1f822020-09-09 14:18:53 -0400498 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400499 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400500 return statement.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400501 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400502 const ReturnStatement& r = statement.as<ReturnStatement>();
John Stiles345d7212020-12-15 18:06:29 -0500503 if (!r.expression()) {
504 if (returnComplexity >= ReturnComplexity::kEarlyReturns) {
505 // This function doesn't return a value, but has early returns, so we've wrapped
506 // it in a do-while block. Use a break to leave the inlined function early.
John Stiles44e96be2020-08-31 13:16:04 -0400507 return std::make_unique<BreakStatement>(offset);
508 } else {
John Stiles345d7212020-12-15 18:06:29 -0500509 // This function doesn't exit early or return a value. A return statement at the
510 // end is a no-op and can be treated as such.
John Stiles44e96be2020-08-31 13:16:04 -0400511 return std::make_unique<Nop>();
512 }
513 }
John Stiles345d7212020-12-15 18:06:29 -0500514
515 // For a function that only contains a single return, we don't need to store the result
516 // in a variable at all. Just move the return value right into the result expression.
517 SkASSERT(resultExpr);
518 SkASSERT(*resultExpr);
519 if (returnComplexity == ReturnComplexity::kSingleReturn) {
520 *resultExpr = expr(r.expression());
521 return std::make_unique<Nop>();
522 }
523
524 // For more complex functions, assign their result into a variable.
525 auto assignment =
526 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
527 offset,
528 clone_with_ref_kind(**resultExpr, VariableReference::RefKind::kWrite),
529 Token::Kind::TK_EQ,
530 expr(r.expression()),
531 &resultExpr->get()->type()));
532
533 // Early returns are wrapped in a do-while block; we need to synthesize a break
534 // statement to "leave" the function.
535 if (returnComplexity >= ReturnComplexity::kEarlyReturns) {
536 StatementArray block;
537 block.reserve_back(2);
538 block.push_back(std::move(assignment));
539 block.push_back(std::make_unique<BreakStatement>(offset));
540 return std::make_unique<Block>(offset, std::move(block), /*symbols=*/nullptr,
541 /*isScope=*/true);
542 }
543 // Functions without early returns aren't wrapped by a do-while block and don't
544 // need to worry about breaking out of the control flow.
545 return std::move(assignment);
546
John Stiles44e96be2020-08-31 13:16:04 -0400547 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400548 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400549 const SwitchStatement& ss = statement.as<SwitchStatement>();
550 std::vector<std::unique_ptr<SwitchCase>> cases;
John Stiles2d4f9592020-10-30 10:29:12 -0400551 cases.reserve(ss.cases().size());
552 for (const std::unique_ptr<SwitchCase>& sc : ss.cases()) {
553 cases.push_back(std::make_unique<SwitchCase>(offset, expr(sc->value()),
554 stmts(sc->statements())));
John Stiles44e96be2020-08-31 13:16:04 -0400555 }
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400556 return std::make_unique<SwitchStatement>(offset, ss.isStatic(), expr(ss.value()),
John Stilesa1e2b412020-10-20 14:51:28 -0400557 std::move(cases),
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400558 SymbolTable::WrapIfBuiltin(ss.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400559 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400560 case Statement::Kind::kVarDeclaration: {
John Stilese8e4aca2020-12-15 17:50:21 -0500561 // We've declared variables already via inlineVarDecls. So we don't want to emit a
562 // VarDeclaration; instead, we need to convert the vardecl's initial value into an
563 // assignment statement.
John Stiles44e96be2020-08-31 13:16:04 -0400564 const VarDeclaration& decl = statement.as<VarDeclaration>();
John Stilese8e4aca2020-12-15 17:50:21 -0500565 if (decl.value()) {
566 auto varMapIter = varMap->find(&decl.var());
567 if (varMapIter == varMap->end()) {
568 SkDEBUGFAILF("inlined variable '%s' not found in VariableRewriteMap",
569 decl.var().description().c_str());
570 return std::make_unique<Nop>();
571 }
572 std::unique_ptr<Expression>& varRef = varMapIter->second;
573 return std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
574 offset,
575 clone_with_ref_kind(*varRef, VariableReference::RefKind::kWrite),
576 Token::Kind::TK_EQ,
577 expr(decl.value()),
578 &varRef->type()));
579 }
580 // No initial value? Nothing to do.
581 return std::make_unique<Nop>();
John Stiles44e96be2020-08-31 13:16:04 -0400582 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400583 case Statement::Kind::kWhile: {
John Stiles44e96be2020-08-31 13:16:04 -0400584 const WhileStatement& w = statement.as<WhileStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400585 return std::make_unique<WhileStatement>(offset, expr(w.test()), stmt(w.statement()));
John Stiles44e96be2020-08-31 13:16:04 -0400586 }
587 default:
588 SkASSERT(false);
589 return nullptr;
590 }
591}
592
John Stilese8e4aca2020-12-15 17:50:21 -0500593void Inliner::inlineVarDecls(const Block& body,
594 Block* inlineBlock,
595 VariableRewriteMap* varMap,
596 SymbolTable* symbolTable,
597 bool isBuiltinCode) {
598 // We assign unique names to inlined variables to avoid a variety of problems.
599 class InlineVarDeclsPass : public ProgramVisitor {
600 public:
601 InlineVarDeclsPass(Inliner* inliner,
602 Block* inlineBlock,
603 VariableRewriteMap* varMap,
604 SymbolTable* symbolTable,
605 bool isBuiltinCode)
606 : fInliner(inliner)
607 , fInlineBlock(inlineBlock)
608 , fVarMap(varMap)
609 , fSymbolTable(symbolTable)
610 , fIsBuiltinCode(isBuiltinCode) {}
611
612 bool visitStatement(const Statement& stmt) override {
613 if (stmt.is<VarDeclaration>()) {
614 fInlineBlock->children().push_back(this->inlineVarDecl(stmt.as<VarDeclaration>()));
615 }
616 return INHERITED::visitStatement(stmt);
617 }
618
619 std::unique_ptr<Statement> inlineVarDecl(const VarDeclaration& decl) {
620 int arraySize = decl.arraySize();
621 const Variable& old = decl.var();
622 int offset = decl.fOffset;
623 auto name = std::make_unique<String>(
624 fInliner->uniqueNameForInlineVar(old.name(), fSymbolTable));
625 const String* namePtr = fSymbolTable->takeOwnershipOfString(std::move(name));
626 const Type* baseTypePtr = copy_if_needed(&decl.baseType(), *fSymbolTable);
627 const Type* typePtr = copy_if_needed(&old.type(), *fSymbolTable);
628 const Variable* clone = fSymbolTable->takeOwnershipOfSymbol(
629 std::make_unique<Variable>(offset,
630 &old.modifiers(),
631 namePtr->c_str(),
632 typePtr,
633 fIsBuiltinCode,
634 old.storage(),
635 /*initialValue=*/nullptr));
636 (*fVarMap)[&old] = std::make_unique<VariableReference>(offset, clone);
637 return std::make_unique<VarDeclaration>(clone, baseTypePtr, arraySize,
638 /*value=*/nullptr);
639 }
640
641 Inliner* fInliner;
642 Block* fInlineBlock;
643 VariableRewriteMap* fVarMap;
644 SymbolTable* fSymbolTable;
645 bool fIsBuiltinCode;
646
647 using INHERITED = ProgramVisitor;
648 };
649 InlineVarDeclsPass{this, inlineBlock, varMap, symbolTable, isBuiltinCode}.visitStatement(body);
650}
651
John Stiles6eadf132020-09-08 10:16:10 -0400652Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
Brian Osman3887a012020-09-30 13:22:27 -0400653 SymbolTable* symbolTableForCall,
654 const FunctionDeclaration* caller) {
John Stiles44e96be2020-08-31 13:16:04 -0400655 // Inlining is more complicated here than in a typical compiler, because we have to have a
656 // high-level IR and can't just drop statements into the middle of an expression or even use
657 // gotos.
658 //
659 // Since we can't insert statements into an expression, we run the inline function as extra
660 // statements before the statement we're currently processing, relying on a lack of execution
661 // order guarantees. Since we can't use gotos (which are normally used to replace return
662 // statements), we wrap the whole function in a loop and use break statements to jump to the
663 // end.
664 SkASSERT(fSettings);
665 SkASSERT(fContext);
666 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400667 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400668
John Stiles8e3b6be2020-10-13 11:14:08 -0400669 ExpressionArray& arguments = call->arguments();
John Stiles6eadf132020-09-08 10:16:10 -0400670 const int offset = call->fOffset;
Ethan Nicholased84b732020-10-08 11:45:44 -0400671 const FunctionDefinition& function = *call->function().definition();
John Stiles345d7212020-12-15 18:06:29 -0500672 const ReturnComplexity returnComplexity = GetReturnComplexity(function);
673 bool hasEarlyReturn = (returnComplexity >= ReturnComplexity::kEarlyReturns);
John Stiles6eadf132020-09-08 10:16:10 -0400674
John Stiles44e96be2020-08-31 13:16:04 -0400675 InlinedCall inlinedCall;
John Stiles8f2a0cf2020-10-13 12:48:21 -0400676 inlinedCall.fInlinedBody = std::make_unique<Block>(offset, StatementArray{},
John Stiles6eadf132020-09-08 10:16:10 -0400677 /*symbols=*/nullptr,
678 /*isScope=*/false);
John Stiles98c1f822020-09-09 14:18:53 -0400679
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400680 Block& inlinedBody = *inlinedCall.fInlinedBody;
John Stiles82f373c2020-10-20 13:58:05 -0400681 inlinedBody.children().reserve_back(
682 1 + // Inline marker
683 1 + // Result variable
684 arguments.size() + // Function arguments (passing in)
685 arguments.size() + // Function arguments (copy out-params back)
686 1); // Inlined code (Block or do-while loop)
John Stiles98c1f822020-09-09 14:18:53 -0400687
Ethan Nicholasceb62142020-10-09 16:51:18 -0400688 inlinedBody.children().push_back(std::make_unique<InlineMarker>(&call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400689
John Stilese41b4ee2020-09-28 12:28:16 -0400690 auto makeInlineVar =
691 [&](const String& baseName, const Type* type, Modifiers modifiers,
692 std::unique_ptr<Expression>* initialValue) -> std::unique_ptr<Expression> {
John Stilesa003e812020-09-11 09:43:49 -0400693 // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so
694 // replace them if they ever appear here. If this happens, we likely forgot to coerce a type
695 // somewhere during compilation.
696 if (type == fContext->fFloatLiteral_Type.get()) {
John Stilesd2be5c52020-09-11 14:58:06 -0400697 SkDEBUGFAIL("found a $floatLiteral type while inlining");
John Stilesa003e812020-09-11 09:43:49 -0400698 type = fContext->fFloat_Type.get();
699 } else if (type == fContext->fIntLiteral_Type.get()) {
John Stilesd2be5c52020-09-11 14:58:06 -0400700 SkDEBUGFAIL("found an $intLiteral type while inlining");
John Stilesa003e812020-09-11 09:43:49 -0400701 type = fContext->fInt_Type.get();
702 }
703
John Stilesc75abb82020-09-14 18:24:12 -0400704 // Provide our new variable with a unique name, and add it to our symbol table.
705 String uniqueName = this->uniqueNameForInlineVar(baseName, symbolTableForCall);
John Stilescf936f92020-08-31 17:18:45 -0400706 const String* namePtr = symbolTableForCall->takeOwnershipOfString(
707 std::make_unique<String>(std::move(uniqueName)));
John Stiles44e96be2020-08-31 13:16:04 -0400708 StringFragment nameFrag{namePtr->c_str(), namePtr->length()};
709
710 // Add our new variable to the symbol table.
John Stilesb8cc6652020-10-08 09:12:07 -0400711 const Variable* variableSymbol = symbolTableForCall->add(std::make_unique<Variable>(
John Stiles586df952020-11-12 18:27:13 -0500712 /*offset=*/-1, fModifiers->addToPool(Modifiers()),
Ethan Nicholased84b732020-10-08 11:45:44 -0400713 nameFrag, type, caller->isBuiltin(),
Ethan Nicholas453f67f2020-10-09 10:43:45 -0400714 Variable::Storage::kLocal, initialValue->get()));
John Stiles44e96be2020-08-31 13:16:04 -0400715
716 // Prepare the variable declaration (taking extra care with `out` params to not clobber any
717 // initial value).
Brian Osmanc0213602020-10-06 14:43:32 -0400718 std::unique_ptr<Statement> variable;
John Stiles44e96be2020-08-31 13:16:04 -0400719 if (initialValue && (modifiers.fFlags & Modifiers::kOut_Flag)) {
John Stiles62a56462020-12-03 10:41:58 -0500720 variable = std::make_unique<VarDeclaration>(variableSymbol, type, /*arraySize=*/0,
721 (*initialValue)->clone());
John Stiles44e96be2020-08-31 13:16:04 -0400722 } else {
John Stiles62a56462020-12-03 10:41:58 -0500723 variable = std::make_unique<VarDeclaration>(variableSymbol, type, /*arraySize=*/0,
724 std::move(*initialValue));
John Stiles44e96be2020-08-31 13:16:04 -0400725 }
726
727 // Add the new variable-declaration statement to our block of extra statements.
Brian Osmanc0213602020-10-06 14:43:32 -0400728 inlinedBody.children().push_back(std::move(variable));
John Stiles44e96be2020-08-31 13:16:04 -0400729
John Stilese41b4ee2020-09-28 12:28:16 -0400730 return std::make_unique<VariableReference>(offset, variableSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400731 };
732
733 // Create a variable to hold the result in the extra statements (excepting void).
John Stilese41b4ee2020-09-28 12:28:16 -0400734 std::unique_ptr<Expression> resultExpr;
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400735 if (function.declaration().returnType() != *fContext->fVoid_Type) {
John Stiles44e96be2020-08-31 13:16:04 -0400736 std::unique_ptr<Expression> noInitialValue;
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400737 resultExpr = makeInlineVar(String(function.declaration().name()),
738 &function.declaration().returnType(),
John Stilese41b4ee2020-09-28 12:28:16 -0400739 Modifiers{}, &noInitialValue);
John Stilese8e4aca2020-12-15 17:50:21 -0500740 }
John Stiles44e96be2020-08-31 13:16:04 -0400741
742 // Create variables in the extra statements to hold the arguments, and assign the arguments to
743 // them.
744 VariableRewriteMap varMap;
John Stilese41b4ee2020-09-28 12:28:16 -0400745 std::vector<int> argsToCopyBack;
John Stiles44e96be2020-08-31 13:16:04 -0400746 for (int i = 0; i < (int) arguments.size(); ++i) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400747 const Variable* param = function.declaration().parameters()[i];
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400748 bool isOutParam = param->modifiers().fFlags & Modifiers::kOut_Flag;
John Stiles44e96be2020-08-31 13:16:04 -0400749
John Stiles44733aa2020-09-29 17:42:23 -0400750 // If this argument can be inlined trivially (e.g. a swizzle, or a constant array index)...
John Stilesc30fbca2020-11-19 16:25:49 -0500751 if (Analysis::IsTrivialExpression(*arguments[i])) {
John Stilese41b4ee2020-09-28 12:28:16 -0400752 // ... and it's an `out` param, or it isn't written to within the inline function...
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400753 if (isOutParam || !Analysis::StatementWritesToVariable(*function.body(), *param)) {
John Stilesf201af82020-09-29 16:57:55 -0400754 // ... we don't need to copy it at all! We can just use the existing expression.
755 varMap[param] = arguments[i]->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400756 continue;
757 }
758 }
759
John Stilese41b4ee2020-09-28 12:28:16 -0400760 if (isOutParam) {
761 argsToCopyBack.push_back(i);
762 }
763
Ethan Nicholase2c49992020-10-05 11:49:11 -0400764 varMap[param] = makeInlineVar(String(param->name()), &arguments[i]->type(),
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400765 param->modifiers(), &arguments[i]);
John Stiles44e96be2020-08-31 13:16:04 -0400766 }
767
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400768 const Block& body = function.body()->as<Block>();
John Stilesd0590052020-12-15 15:21:03 -0500769 auto inlineBlock = std::make_unique<Block>(offset, StatementArray{},
770 /*symbols=*/nullptr, /*isScope=*/hasEarlyReturn);
John Stilesf4bda742020-10-14 16:57:41 -0400771 inlineBlock->children().reserve_back(body.children().size());
John Stilese8e4aca2020-12-15 17:50:21 -0500772
773 // Declare the inlined function's variables at the very top of the block so that they don't get
774 // created in an inner scope.
775 this->inlineVarDecls(body, inlineBlock.get(), &varMap, symbolTableForCall, caller->isBuiltin());
776
777 // Inline the function.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400778 for (const std::unique_ptr<Statement>& stmt : body.children()) {
Brian Osman3887a012020-09-30 13:22:27 -0400779 inlineBlock->children().push_back(this->inlineStatement(offset, &varMap, symbolTableForCall,
John Stiles345d7212020-12-15 18:06:29 -0500780 &resultExpr, returnComplexity,
Ethan Nicholased84b732020-10-08 11:45:44 -0400781 *stmt, caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400782 }
783 if (hasEarlyReturn) {
784 // Since we output to backends that don't have a goto statement (which would normally be
785 // used to perform an early return), we fake it by wrapping the function in a
786 // do { } while (false); and then use break statements to jump to the end in order to
787 // emulate a goto.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400788 inlinedBody.children().push_back(std::make_unique<DoStatement>(
John Stiles44e96be2020-08-31 13:16:04 -0400789 /*offset=*/-1,
790 std::move(inlineBlock),
791 std::make_unique<BoolLiteral>(*fContext, offset, /*value=*/false)));
792 } else {
John Stiles6eadf132020-09-08 10:16:10 -0400793 // No early returns, so we can just dump the code in. We still need to keep the block so we
794 // don't get name conflicts with locals.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400795 inlinedBody.children().push_back(std::move(inlineBlock));
John Stiles44e96be2020-08-31 13:16:04 -0400796 }
797
John Stilese41b4ee2020-09-28 12:28:16 -0400798 // Copy back the values of `out` parameters into their real destinations.
799 for (int i : argsToCopyBack) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400800 const Variable* p = function.declaration().parameters()[i];
John Stilese41b4ee2020-09-28 12:28:16 -0400801 SkASSERT(varMap.find(p) != varMap.end());
802 inlinedBody.children().push_back(
803 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
804 offset,
Ethan Nicholas453f67f2020-10-09 10:43:45 -0400805 clone_with_ref_kind(*arguments[i], VariableReference::RefKind::kWrite),
John Stilese41b4ee2020-09-28 12:28:16 -0400806 Token::Kind::TK_EQ,
807 std::move(varMap[p]),
808 &arguments[i]->type())));
John Stiles44e96be2020-08-31 13:16:04 -0400809 }
810
John Stilese41b4ee2020-09-28 12:28:16 -0400811 if (resultExpr != nullptr) {
812 // Return our result variable as our replacement expression.
John Stilese41b4ee2020-09-28 12:28:16 -0400813 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles44e96be2020-08-31 13:16:04 -0400814 } else {
815 // It's a void function, so it doesn't actually result in anything, but we have to return
816 // something non-null as a standin.
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400817 inlinedCall.fReplacementExpr = std::make_unique<BoolLiteral>(*fContext,
818 offset,
John Stiles44e96be2020-08-31 13:16:04 -0400819 /*value=*/false);
820 }
821
John Stiles44e96be2020-08-31 13:16:04 -0400822 return inlinedCall;
823}
824
John Stiles2d7973a2020-10-02 15:01:03 -0400825bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400826 SkASSERT(fSettings);
827
John Stiles1c03d332020-10-13 10:30:23 -0400828 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
829 if (fSettings->fInlineThreshold <= 0) {
830 return false;
831 }
832
John Stiles031a7672020-11-13 16:13:18 -0500833 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
834 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
835 return false;
836 }
837
John Stiles2d7973a2020-10-02 15:01:03 -0400838 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400839 // Can't inline something if we don't actually have its definition.
840 return false;
841 }
John Stiles2d7973a2020-10-02 15:01:03 -0400842
John Stiles345d7212020-12-15 18:06:29 -0500843 ReturnComplexity complexity = GetReturnComplexity(*functionDef);
844 bool hasEarlyReturn = (complexity >= ReturnComplexity::kEarlyReturns);
John Stiles44e96be2020-08-31 13:16:04 -0400845
John Stiles345d7212020-12-15 18:06:29 -0500846 if (!fCaps || !fCaps->canUseDoLoops()) {
John Stiles44e96be2020-08-31 13:16:04 -0400847 // If we didn't detect an early return, there shouldn't be any returns in breakable
848 // constructs either.
John Stiles2d7973a2020-10-02 15:01:03 -0400849 SkASSERT(hasEarlyReturn || count_returns_in_breakable_constructs(*functionDef) == 0);
John Stiles345d7212020-12-15 18:06:29 -0500850
851 // We don't have do-while loops. We use do-while loops to simulate early returns, so we
852 // can't inline functions that have an early return.
John Stiles44e96be2020-08-31 13:16:04 -0400853 return !hasEarlyReturn;
854 }
855 // We have do-while loops, but we don't have any mechanism to simulate early returns within a
856 // breakable construct (switch/for/do/while), so we can't inline if there's a return inside one.
John Stiles2d7973a2020-10-02 15:01:03 -0400857 bool hasReturnInBreakableConstruct = (count_returns_in_breakable_constructs(*functionDef) > 0);
John Stiles44e96be2020-08-31 13:16:04 -0400858
859 // If we detected returns in breakable constructs, we should also detect an early return.
John Stiles345d7212020-12-15 18:06:29 -0500860 SkASSERT(!hasReturnInBreakableConstruct || hasEarlyReturn);
John Stiles44e96be2020-08-31 13:16:04 -0400861 return !hasReturnInBreakableConstruct;
862}
863
John Stiles2d7973a2020-10-02 15:01:03 -0400864// A candidate function for inlining, containing everything that `inlineCall` needs.
865struct InlineCandidate {
866 SymbolTable* fSymbols; // the SymbolTable of the candidate
867 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
868 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
869 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
870 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400871};
John Stiles93442622020-09-11 12:11:27 -0400872
John Stiles2d7973a2020-10-02 15:01:03 -0400873struct InlineCandidateList {
874 std::vector<InlineCandidate> fCandidates;
875};
876
877class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400878public:
879 // A list of all the inlining candidates we found during analysis.
880 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400881
John Stiles70957c82020-10-02 16:42:10 -0400882 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
883 // the enclosing-statement stack.
884 std::vector<SymbolTable*> fSymbolTableStack;
885 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
886 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
887 // inliner might replace a statement with a block containing the statement.
888 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
889 // The function that we're currently processing (i.e. inlining into).
890 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400891
Brian Osman0006ad02020-11-18 15:38:39 -0500892 void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements,
893 SymbolTable* symbols,
894 InlineCandidateList* candidateList) {
John Stiles70957c82020-10-02 16:42:10 -0400895 fCandidateList = candidateList;
Brian Osman0006ad02020-11-18 15:38:39 -0500896 fSymbolTableStack.push_back(symbols);
John Stiles93442622020-09-11 12:11:27 -0400897
Brian Osman0006ad02020-11-18 15:38:39 -0500898 for (const std::unique_ptr<ProgramElement>& pe : elements) {
Brian Osman1179fcf2020-10-08 16:04:40 -0400899 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400900 }
901
John Stiles70957c82020-10-02 16:42:10 -0400902 fSymbolTableStack.pop_back();
903 fCandidateList = nullptr;
904 }
905
906 void visitProgramElement(ProgramElement* pe) {
907 switch (pe->kind()) {
908 case ProgramElement::Kind::kFunction: {
909 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
Brian Osman0006ad02020-11-18 15:38:39 -0500910 fEnclosingFunction = &funcDef;
911 this->visitStatement(&funcDef.body());
John Stiles70957c82020-10-02 16:42:10 -0400912 break;
John Stiles93442622020-09-11 12:11:27 -0400913 }
John Stiles70957c82020-10-02 16:42:10 -0400914 default:
915 // The inliner can't operate outside of a function's scope.
916 break;
917 }
918 }
919
920 void visitStatement(std::unique_ptr<Statement>* stmt,
921 bool isViableAsEnclosingStatement = true) {
922 if (!*stmt) {
923 return;
John Stiles93442622020-09-11 12:11:27 -0400924 }
925
John Stiles70957c82020-10-02 16:42:10 -0400926 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
927 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400928
John Stiles70957c82020-10-02 16:42:10 -0400929 if (isViableAsEnclosingStatement) {
930 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400931 }
932
John Stiles70957c82020-10-02 16:42:10 -0400933 switch ((*stmt)->kind()) {
934 case Statement::Kind::kBreak:
935 case Statement::Kind::kContinue:
936 case Statement::Kind::kDiscard:
937 case Statement::Kind::kInlineMarker:
938 case Statement::Kind::kNop:
939 break;
940
941 case Statement::Kind::kBlock: {
942 Block& block = (*stmt)->as<Block>();
943 if (block.symbolTable()) {
944 fSymbolTableStack.push_back(block.symbolTable().get());
945 }
946
947 for (std::unique_ptr<Statement>& stmt : block.children()) {
948 this->visitStatement(&stmt);
949 }
950 break;
John Stiles93442622020-09-11 12:11:27 -0400951 }
John Stiles70957c82020-10-02 16:42:10 -0400952 case Statement::Kind::kDo: {
953 DoStatement& doStmt = (*stmt)->as<DoStatement>();
954 // The loop body is a candidate for inlining.
955 this->visitStatement(&doStmt.statement());
956 // The inliner isn't smart enough to inline the test-expression for a do-while
957 // loop at this time. There are two limitations:
958 // - We would need to insert the inlined-body block at the very end of the do-
959 // statement's inner fStatement. We don't support that today, but it's doable.
960 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
961 // would skip over the inlined block that evaluates the test expression. There
962 // isn't a good fix for this--any workaround would be more complex than the cost
963 // of a function call. However, loops that don't use `continue` would still be
964 // viable candidates for inlining.
965 break;
John Stiles93442622020-09-11 12:11:27 -0400966 }
John Stiles70957c82020-10-02 16:42:10 -0400967 case Statement::Kind::kExpression: {
968 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
969 this->visitExpression(&expr.expression());
970 break;
971 }
972 case Statement::Kind::kFor: {
973 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400974 if (forStmt.symbols()) {
975 fSymbolTableStack.push_back(forStmt.symbols().get());
John Stiles70957c82020-10-02 16:42:10 -0400976 }
977
978 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400979 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400980 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400981 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400982
983 // The inliner isn't smart enough to inline the test- or increment-expressions
984 // of a for loop loop at this time. There are a handful of limitations:
985 // - We would need to insert the test-expression block at the very beginning of the
986 // for-loop's inner fStatement, and the increment-expression block at the very
987 // end. We don't support that today, but it's doable.
988 // - The for-loop's built-in test-expression would need to be dropped entirely,
989 // and the loop would be halted via a break statement at the end of the inlined
990 // test-expression. This is again something we don't support today, but it could
991 // be implemented.
992 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
993 // that would skip over the inlined block that evaluates the increment expression.
994 // There isn't a good fix for this--any workaround would be more complex than the
995 // cost of a function call. However, loops that don't use `continue` would still
996 // be viable candidates for increment-expression inlining.
997 break;
998 }
999 case Statement::Kind::kIf: {
1000 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -04001001 this->visitExpression(&ifStmt.test());
1002 this->visitStatement(&ifStmt.ifTrue());
1003 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -04001004 break;
1005 }
1006 case Statement::Kind::kReturn: {
1007 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001008 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -04001009 break;
1010 }
1011 case Statement::Kind::kSwitch: {
1012 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
Ethan Nicholas01b05e52020-10-22 15:53:41 -04001013 if (switchStmt.symbols()) {
1014 fSymbolTableStack.push_back(switchStmt.symbols().get());
John Stiles70957c82020-10-02 16:42:10 -04001015 }
1016
Ethan Nicholas01b05e52020-10-22 15:53:41 -04001017 this->visitExpression(&switchStmt.value());
John Stiles2d4f9592020-10-30 10:29:12 -04001018 for (const std::unique_ptr<SwitchCase>& switchCase : switchStmt.cases()) {
John Stiles70957c82020-10-02 16:42:10 -04001019 // The switch-case's fValue cannot be a FunctionCall; skip it.
John Stiles2d4f9592020-10-30 10:29:12 -04001020 for (std::unique_ptr<Statement>& caseBlock : switchCase->statements()) {
John Stiles70957c82020-10-02 16:42:10 -04001021 this->visitStatement(&caseBlock);
1022 }
1023 }
1024 break;
1025 }
1026 case Statement::Kind::kVarDeclaration: {
1027 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
1028 // Don't need to scan the declaration's sizes; those are always IntLiterals.
Ethan Nicholasc51f33e2020-10-13 13:49:44 -04001029 this->visitExpression(&varDeclStmt.value());
John Stiles70957c82020-10-02 16:42:10 -04001030 break;
1031 }
John Stiles70957c82020-10-02 16:42:10 -04001032 case Statement::Kind::kWhile: {
1033 WhileStatement& whileStmt = (*stmt)->as<WhileStatement>();
1034 // The loop body is a candidate for inlining.
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001035 this->visitStatement(&whileStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -04001036 // The inliner isn't smart enough to inline the test-expression for a while loop at
1037 // this time. There are two limitations:
1038 // - We would need to insert the inlined-body block at the very beginning of the
1039 // while loop's inner fStatement. We don't support that today, but it's doable.
1040 // - The while-loop's built-in test-expression would need to be replaced with a
1041 // `true` BoolLiteral, and the loop would be halted via a break statement at the
1042 // end of the inlined test-expression. This is again something we don't support
1043 // today, but it could be implemented.
1044 break;
1045 }
1046 default:
1047 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -04001048 }
1049
John Stiles70957c82020-10-02 16:42:10 -04001050 // Pop our symbol and enclosing-statement stacks.
1051 fSymbolTableStack.resize(oldSymbolStackSize);
1052 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
1053 }
1054
1055 void visitExpression(std::unique_ptr<Expression>* expr) {
1056 if (!*expr) {
1057 return;
John Stiles93442622020-09-11 12:11:27 -04001058 }
John Stiles70957c82020-10-02 16:42:10 -04001059
1060 switch ((*expr)->kind()) {
1061 case Expression::Kind::kBoolLiteral:
1062 case Expression::Kind::kDefined:
1063 case Expression::Kind::kExternalValue:
1064 case Expression::Kind::kFieldAccess:
1065 case Expression::Kind::kFloatLiteral:
1066 case Expression::Kind::kFunctionReference:
1067 case Expression::Kind::kIntLiteral:
1068 case Expression::Kind::kNullLiteral:
1069 case Expression::Kind::kSetting:
1070 case Expression::Kind::kTypeReference:
1071 case Expression::Kind::kVariableReference:
1072 // Nothing to scan here.
1073 break;
1074
1075 case Expression::Kind::kBinary: {
1076 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
John Stiles2d4f9592020-10-30 10:29:12 -04001077 this->visitExpression(&binaryExpr.left());
John Stiles70957c82020-10-02 16:42:10 -04001078
1079 // Logical-and and logical-or binary expressions do not inline the right side,
1080 // because that would invalidate short-circuiting. That is, when evaluating
1081 // expressions like these:
1082 // (false && x()) // always false
1083 // (true || y()) // always true
1084 // It is illegal for side-effects from x() or y() to occur. The simplest way to
1085 // enforce that rule is to avoid inlining the right side entirely. However, it is
1086 // safe for other types of binary expression to inline both sides.
1087 Token::Kind op = binaryExpr.getOperator();
1088 bool shortCircuitable = (op == Token::Kind::TK_LOGICALAND ||
1089 op == Token::Kind::TK_LOGICALOR);
1090 if (!shortCircuitable) {
John Stiles2d4f9592020-10-30 10:29:12 -04001091 this->visitExpression(&binaryExpr.right());
John Stiles70957c82020-10-02 16:42:10 -04001092 }
1093 break;
1094 }
1095 case Expression::Kind::kConstructor: {
1096 Constructor& constructorExpr = (*expr)->as<Constructor>();
1097 for (std::unique_ptr<Expression>& arg : constructorExpr.arguments()) {
1098 this->visitExpression(&arg);
1099 }
1100 break;
1101 }
1102 case Expression::Kind::kExternalFunctionCall: {
1103 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
1104 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
1105 this->visitExpression(&arg);
1106 }
1107 break;
1108 }
1109 case Expression::Kind::kFunctionCall: {
1110 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001111 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -04001112 this->visitExpression(&arg);
1113 }
1114 this->addInlineCandidate(expr);
1115 break;
1116 }
1117 case Expression::Kind::kIndex:{
1118 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001119 this->visitExpression(&indexExpr.base());
1120 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -04001121 break;
1122 }
1123 case Expression::Kind::kPostfix: {
1124 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001125 this->visitExpression(&postfixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001126 break;
1127 }
1128 case Expression::Kind::kPrefix: {
1129 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001130 this->visitExpression(&prefixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001131 break;
1132 }
1133 case Expression::Kind::kSwizzle: {
1134 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -04001135 this->visitExpression(&swizzleExpr.base());
John Stiles70957c82020-10-02 16:42:10 -04001136 break;
1137 }
1138 case Expression::Kind::kTernary: {
1139 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1140 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001141 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001142 // The true- and false-expressions cannot be inlined, because we are only allowed to
1143 // evaluate one side.
1144 break;
1145 }
1146 default:
1147 SkUNREACHABLE;
1148 }
1149 }
1150
1151 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1152 fCandidateList->fCandidates.push_back(
1153 InlineCandidate{fSymbolTableStack.back(),
1154 find_parent_statement(fEnclosingStmtStack),
1155 fEnclosingStmtStack.back(),
1156 candidate,
John Stiles9b9415e2020-11-23 14:48:06 -05001157 fEnclosingFunction});
John Stiles70957c82020-10-02 16:42:10 -04001158 }
John Stiles2d7973a2020-10-02 15:01:03 -04001159};
John Stiles93442622020-09-11 12:11:27 -04001160
John Stiles9b9415e2020-11-23 14:48:06 -05001161static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) {
1162 return (*candidate.fCandidateExpr)->as<FunctionCall>().function();
1163}
John Stiles915a38c2020-09-14 09:38:13 -04001164
John Stiles9b9415e2020-11-23 14:48:06 -05001165bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
1166 const FunctionDeclaration& funcDecl = candidate_func(candidate);
John Stiles1c03d332020-10-13 10:30:23 -04001167 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
John Stiles2d7973a2020-10-02 15:01:03 -04001168 if (wasInserted) {
1169 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
John Stiles1c03d332020-10-13 10:30:23 -04001170 iter->second = this->isSafeToInline(funcDecl.definition()) &&
1171 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001172 }
1173
John Stiles2d7973a2020-10-02 15:01:03 -04001174 return iter->second;
1175}
1176
John Stiles9b9415e2020-11-23 14:48:06 -05001177int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) {
1178 auto [iter, wasInserted] = cache->insert({&funcDecl, 0});
John Stiles2d7973a2020-10-02 15:01:03 -04001179 if (wasInserted) {
John Stiles9b9415e2020-11-23 14:48:06 -05001180 iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(),
1181 fSettings->fInlineThreshold);
John Stiles2d7973a2020-10-02 15:01:03 -04001182 }
John Stiles2d7973a2020-10-02 15:01:03 -04001183 return iter->second;
1184}
1185
Brian Osman0006ad02020-11-18 15:38:39 -05001186void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles9b9415e2020-11-23 14:48:06 -05001187 SymbolTable* symbols, ProgramUsage* usage,
Brian Osman0006ad02020-11-18 15:38:39 -05001188 InlineCandidateList* candidateList) {
John Stiles2d7973a2020-10-02 15:01:03 -04001189 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1190 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1191 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1192 // `const T&`.
1193 InlineCandidateAnalyzer analyzer;
Brian Osman0006ad02020-11-18 15:38:39 -05001194 analyzer.visit(elements, symbols, candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001195
John Stiles0ad233f2020-11-25 11:02:05 -05001196 // Early out if there are no inlining candidates.
John Stiles2d7973a2020-10-02 15:01:03 -04001197 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
John Stiles0ad233f2020-11-25 11:02:05 -05001198 if (candidates.empty()) {
1199 return;
1200 }
1201
1202 // Remove candidates that are not safe to inline.
John Stiles2d7973a2020-10-02 15:01:03 -04001203 InlinabilityCache cache;
1204 candidates.erase(std::remove_if(candidates.begin(),
1205 candidates.end(),
1206 [&](const InlineCandidate& candidate) {
1207 return !this->candidateCanBeInlined(candidate, &cache);
1208 }),
1209 candidates.end());
1210
John Stiles0ad233f2020-11-25 11:02:05 -05001211 // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is
1212 // complete.
1213 if (fSettings->fInlineThreshold == INT_MAX || candidates.empty()) {
1214 return;
John Stiles2d7973a2020-10-02 15:01:03 -04001215 }
John Stiles0ad233f2020-11-25 11:02:05 -05001216
1217 // Remove candidates on a per-function basis if the effect of inlining would be to make more
1218 // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is
1219 // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.)
1220 FunctionSizeCache functionSizeCache;
1221 FunctionSizeCache candidateTotalCost;
1222 for (InlineCandidate& candidate : candidates) {
1223 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1224 candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache);
1225 }
1226
1227 candidates.erase(
1228 std::remove_if(candidates.begin(),
1229 candidates.end(),
1230 [&](const InlineCandidate& candidate) {
1231 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1232 if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) {
1233 // Functions marked `inline` ignore size limitations.
1234 return false;
1235 }
1236 if (usage->get(fnDecl) == 1) {
1237 // If a function is only used once, it's cost-free to inline.
1238 return false;
1239 }
1240 if (candidateTotalCost[&fnDecl] <= fSettings->fInlineThreshold) {
1241 // We won't exceed the inline threshold by inlining this.
1242 return false;
1243 }
1244 // Inlining this function will add too many IRNodes.
1245 return true;
1246 }),
1247 candidates.end());
John Stiles2d7973a2020-10-02 15:01:03 -04001248}
1249
Brian Osman0006ad02020-11-18 15:38:39 -05001250bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements,
1251 SymbolTable* symbols,
1252 ProgramUsage* usage) {
John Stilesd34d56e2020-10-12 12:04:47 -04001253 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
1254 if (fSettings->fInlineThreshold <= 0) {
1255 return false;
1256 }
1257
John Stiles031a7672020-11-13 16:13:18 -05001258 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
1259 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1260 return false;
1261 }
1262
John Stiles2d7973a2020-10-02 15:01:03 -04001263 InlineCandidateList candidateList;
John Stiles9b9415e2020-11-23 14:48:06 -05001264 this->buildCandidateList(elements, symbols, usage, &candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001265
John Stiles915a38c2020-09-14 09:38:13 -04001266 // Inline the candidates where we've determined that it's safe to do so.
1267 std::unordered_set<const std::unique_ptr<Statement>*> enclosingStmtSet;
1268 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001269 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001270 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
John Stiles915a38c2020-09-14 09:38:13 -04001271
1272 // Inlining two expressions using the same enclosing statement in the same inlining pass
1273 // does not work properly. If this happens, skip it; we'll get it in the next pass.
1274 auto [unusedIter, inserted] = enclosingStmtSet.insert(candidate.fEnclosingStmt);
1275 if (!inserted) {
1276 continue;
1277 }
1278
1279 // Convert the function call to its inlined equivalent.
Brian Osman3887a012020-09-30 13:22:27 -04001280 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols,
Ethan Nicholas0a5d0962020-10-14 13:33:18 -04001281 &candidate.fEnclosingFunction->declaration());
John Stiles915a38c2020-09-14 09:38:13 -04001282 if (inlinedCall.fInlinedBody) {
1283 // Ensure that the inlined body has a scope if it needs one.
John Stiles6d696082020-10-01 10:18:54 -04001284 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
John Stiles915a38c2020-09-14 09:38:13 -04001285
Brian Osman010ce6a2020-10-19 16:34:10 -04001286 // Add references within the inlined body
1287 usage->add(inlinedCall.fInlinedBody.get());
1288
John Stiles915a38c2020-09-14 09:38:13 -04001289 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1290 // function, then replace the enclosing statement with that Block.
1291 // Before:
1292 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1293 // fEnclosingStmt = stmt4
1294 // After:
1295 // fInlinedBody = null
1296 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -04001297 inlinedCall.fInlinedBody->children().push_back(std::move(*candidate.fEnclosingStmt));
John Stiles915a38c2020-09-14 09:38:13 -04001298 *candidate.fEnclosingStmt = std::move(inlinedCall.fInlinedBody);
1299 }
1300
1301 // Replace the candidate function call with our replacement expression.
Brian Osman010ce6a2020-10-19 16:34:10 -04001302 usage->replace(candidate.fCandidateExpr->get(), inlinedCall.fReplacementExpr.get());
John Stiles915a38c2020-09-14 09:38:13 -04001303 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1304 madeChanges = true;
1305
John Stiles031a7672020-11-13 16:13:18 -05001306 // Stop inlining if we've reached our hard cap on new statements.
1307 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1308 break;
1309 }
1310
John Stiles915a38c2020-09-14 09:38:13 -04001311 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1312 // remain valid.
1313 }
1314
1315 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001316}
1317
John Stiles44e96be2020-08-31 13:16:04 -04001318} // namespace SkSL