blob: 3950d00f279e3b70ab290261069607f162010500 [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
14#include "src/sksl/SkSLAnalysis.h"
15#include "src/sksl/ir/SkSLBinaryExpression.h"
16#include "src/sksl/ir/SkSLBoolLiteral.h"
17#include "src/sksl/ir/SkSLBreakStatement.h"
18#include "src/sksl/ir/SkSLConstructor.h"
19#include "src/sksl/ir/SkSLContinueStatement.h"
20#include "src/sksl/ir/SkSLDiscardStatement.h"
21#include "src/sksl/ir/SkSLDoStatement.h"
22#include "src/sksl/ir/SkSLEnum.h"
23#include "src/sksl/ir/SkSLExpressionStatement.h"
24#include "src/sksl/ir/SkSLExternalFunctionCall.h"
25#include "src/sksl/ir/SkSLExternalValueReference.h"
26#include "src/sksl/ir/SkSLField.h"
27#include "src/sksl/ir/SkSLFieldAccess.h"
28#include "src/sksl/ir/SkSLFloatLiteral.h"
29#include "src/sksl/ir/SkSLForStatement.h"
30#include "src/sksl/ir/SkSLFunctionCall.h"
31#include "src/sksl/ir/SkSLFunctionDeclaration.h"
32#include "src/sksl/ir/SkSLFunctionDefinition.h"
33#include "src/sksl/ir/SkSLFunctionReference.h"
34#include "src/sksl/ir/SkSLIfStatement.h"
35#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040036#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040037#include "src/sksl/ir/SkSLIntLiteral.h"
38#include "src/sksl/ir/SkSLInterfaceBlock.h"
39#include "src/sksl/ir/SkSLLayout.h"
40#include "src/sksl/ir/SkSLNop.h"
41#include "src/sksl/ir/SkSLNullLiteral.h"
42#include "src/sksl/ir/SkSLPostfixExpression.h"
43#include "src/sksl/ir/SkSLPrefixExpression.h"
44#include "src/sksl/ir/SkSLReturnStatement.h"
45#include "src/sksl/ir/SkSLSetting.h"
46#include "src/sksl/ir/SkSLSwitchCase.h"
47#include "src/sksl/ir/SkSLSwitchStatement.h"
48#include "src/sksl/ir/SkSLSwizzle.h"
49#include "src/sksl/ir/SkSLTernaryExpression.h"
50#include "src/sksl/ir/SkSLUnresolvedFunction.h"
51#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040052#include "src/sksl/ir/SkSLVariable.h"
53#include "src/sksl/ir/SkSLVariableReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040054
55namespace SkSL {
56namespace {
57
John Stiles031a7672020-11-13 16:13:18 -050058static constexpr int kInlinedStatementLimit = 2500;
59
John Stiles9e948122020-12-16 18:24:48 +000060static bool contains_returns_above_limit(const FunctionDefinition& funcDef, int limit) {
John Stiles44dff4f2020-09-21 12:28:01 -040061 class CountReturnsWithLimit : public ProgramVisitor {
John Stiles44e96be2020-08-31 13:16:04 -040062 public:
John Stiles44dff4f2020-09-21 12:28:01 -040063 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
John Stiles44e96be2020-08-31 13:16:04 -040064 this->visitProgramElement(funcDef);
65 }
66
67 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040068 switch (stmt.kind()) {
69 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040070 ++fNumReturns;
John Stiles9e948122020-12-16 18:24:48 +000071 return (fNumReturns > fLimit) || INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040072
73 default:
John Stiles93442622020-09-11 12:11:27 -040074 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040075 }
76 }
77
78 int fNumReturns = 0;
John Stiles44dff4f2020-09-21 12:28:01 -040079 int fLimit = 0;
John Stiles44e96be2020-08-31 13:16:04 -040080 using INHERITED = ProgramVisitor;
81 };
82
John Stiles9e948122020-12-16 18:24:48 +000083 return CountReturnsWithLimit{funcDef, limit}.fNumReturns > limit;
John Stiles44e96be2020-08-31 13:16:04 -040084}
85
86static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
87 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
88 public:
89 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
90 this->visitProgramElement(funcDef);
91 }
92
93 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040094 switch (stmt.kind()) {
95 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040096 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040097 const auto& block = stmt.as<Block>();
98 return block.children().size() &&
99 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -0400100 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400101 case Statement::Kind::kSwitch:
Ethan Nicholase6592142020-09-08 10:22:09 -0400102 case Statement::Kind::kDo:
103 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -0400104 // Don't introspect switches or loop structures at all.
105 return false;
106
Ethan Nicholase6592142020-09-08 10:22:09 -0400107 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -0400108 ++fNumReturns;
109 [[fallthrough]];
110
111 default:
John Stiles93442622020-09-11 12:11:27 -0400112 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400113 }
114 }
115
116 int fNumReturns = 0;
117 using INHERITED = ProgramVisitor;
118 };
119
120 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
121}
122
123static int count_returns_in_breakable_constructs(const FunctionDefinition& funcDef) {
124 class CountReturnsInBreakableConstructs : public ProgramVisitor {
125 public:
126 CountReturnsInBreakableConstructs(const FunctionDefinition& funcDef) {
127 this->visitProgramElement(funcDef);
128 }
129
130 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -0400131 switch (stmt.kind()) {
132 case Statement::Kind::kSwitch:
Ethan Nicholase6592142020-09-08 10:22:09 -0400133 case Statement::Kind::kDo:
134 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400135 ++fInsideBreakableConstruct;
John Stiles93442622020-09-11 12:11:27 -0400136 bool result = INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400137 --fInsideBreakableConstruct;
138 return result;
139 }
140
Ethan Nicholase6592142020-09-08 10:22:09 -0400141 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -0400142 fNumReturns += (fInsideBreakableConstruct > 0) ? 1 : 0;
143 [[fallthrough]];
144
145 default:
John Stiles93442622020-09-11 12:11:27 -0400146 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400147 }
148 }
149
150 int fNumReturns = 0;
151 int fInsideBreakableConstruct = 0;
152 using INHERITED = ProgramVisitor;
153 };
154
155 return CountReturnsInBreakableConstructs{funcDef}.fNumReturns;
156}
157
John Stiles9e948122020-12-16 18:24:48 +0000158static bool has_early_return(const FunctionDefinition& funcDef) {
159 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
160 return contains_returns_above_limit(funcDef, returnsAtEndOfControlFlow);
161}
162
John Stiles991b09d2020-09-10 13:33:40 -0400163static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
164 class ContainsRecursiveCall : public ProgramVisitor {
165 public:
166 bool visit(const FunctionDeclaration& funcDecl) {
167 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400168 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
169 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400170 }
171
172 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400173 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400174 return true;
175 }
176 return INHERITED::visitExpression(expr);
177 }
178
179 bool visitStatement(const Statement& stmt) override {
Ethan Nicholasceb62142020-10-09 16:51:18 -0400180 if (stmt.is<InlineMarker>() &&
181 stmt.as<InlineMarker>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400182 return true;
183 }
184 return INHERITED::visitStatement(stmt);
185 }
186
187 const FunctionDeclaration* fFuncDecl;
188 using INHERITED = ProgramVisitor;
189 };
190
191 return ContainsRecursiveCall{}.visit(funcDecl);
192}
193
John Stiles44e96be2020-08-31 13:16:04 -0400194static const Type* copy_if_needed(const Type* src, SymbolTable& symbolTable) {
John Stilesc0c51062020-12-03 17:16:29 -0500195 if (src->isArray()) {
John Stiles74ff1d62020-11-30 11:56:16 -0500196 const Type* innerType = copy_if_needed(&src->componentType(), symbolTable);
John Stilesad2d4942020-12-11 16:55:58 -0500197 return symbolTable.takeOwnershipOfSymbol(Type::MakeArrayType(src->name(), *innerType,
198 src->columns()));
John Stiles44e96be2020-08-31 13:16:04 -0400199 }
200 return src;
201}
202
John Stiles6d696082020-10-01 10:18:54 -0400203static std::unique_ptr<Statement>* find_parent_statement(
204 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400205 SkASSERT(!stmtStack.empty());
206
207 // Walk the statement stack from back to front, ignoring the last element (which is the
208 // enclosing statement).
209 auto iter = stmtStack.rbegin();
210 ++iter;
211
212 // Anything counts as a parent statement other than a scopeless Block.
213 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400214 std::unique_ptr<Statement>* stmt = *iter;
215 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400216 return stmt;
217 }
218 }
219
220 // There wasn't any parent statement to be found.
221 return nullptr;
222}
223
John Stilese41b4ee2020-09-28 12:28:16 -0400224std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
225 VariableReference::RefKind refKind) {
226 std::unique_ptr<Expression> clone = expr.clone();
John Stiles70b82422020-09-30 10:55:12 -0400227 class SetRefKindInExpression : public ProgramWriter {
John Stilese41b4ee2020-09-28 12:28:16 -0400228 public:
229 SetRefKindInExpression(VariableReference::RefKind refKind) : fRefKind(refKind) {}
John Stiles70b82422020-09-30 10:55:12 -0400230 bool visitExpression(Expression& expr) override {
John Stilese41b4ee2020-09-28 12:28:16 -0400231 if (expr.is<VariableReference>()) {
John Stiles70b82422020-09-30 10:55:12 -0400232 expr.as<VariableReference>().setRefKind(fRefKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400233 }
234 return INHERITED::visitExpression(expr);
235 }
236
237 private:
238 VariableReference::RefKind fRefKind;
239
John Stiles70b82422020-09-30 10:55:12 -0400240 using INHERITED = ProgramWriter;
John Stilese41b4ee2020-09-28 12:28:16 -0400241 };
242
243 SetRefKindInExpression{refKind}.visitExpression(*clone);
244 return clone;
245}
246
John Stiles44e96be2020-08-31 13:16:04 -0400247} // namespace
248
John Stilesb61ee902020-09-21 12:26:59 -0400249void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
250 // No changes necessary if this statement isn't actually a block.
251 if (!inlinedBody || !inlinedBody->is<Block>()) {
252 return;
253 }
254
255 // No changes necessary if the parent statement doesn't require a scope.
256 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
Brian Osmand6f23382020-12-15 17:08:59 -0500257 parentStmt->is<DoStatement>())) {
John Stilesb61ee902020-09-21 12:26:59 -0400258 return;
259 }
260
261 Block& block = inlinedBody->as<Block>();
262
263 // The inliner will create inlined function bodies as a Block containing multiple statements,
264 // but no scope. Normally, this is fine, but if this block is used as the statement for a
265 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
266 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
267 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
268 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
269 // absorbing the following statement into our loop--so we also add a scope to these.
270 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400271 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400272 // We found an explicit scope; all is well.
273 return;
274 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400275 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400276 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
277 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400278 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400279 return;
280 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400281 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400282 // This block has exactly one thing inside, and it's not another block. No need to scope
283 // it.
284 return;
285 }
286 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400287 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400288 }
289}
290
Brian Osman0006ad02020-11-18 15:38:39 -0500291void Inliner::reset(ModifiersPool* modifiers, const Program::Settings* settings) {
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400292 fModifiers = modifiers;
293 fSettings = settings;
John Stiles44e96be2020-08-31 13:16:04 -0400294 fInlineVarCounter = 0;
John Stiles031a7672020-11-13 16:13:18 -0500295 fInlinedStatementCounter = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400296}
297
John Stiles6f31e272020-12-16 13:30:54 -0500298String Inliner::uniqueNameForInlineVar(String baseName, SymbolTable* symbolTable) {
299 // The inliner runs more than once, so the base name might already have a prefix like "_123_x".
300 // Let's strip that prefix off to make the generated code easier to read.
301 if (baseName.startsWith("_")) {
302 // Determine if we have a string of digits.
303 int offset = 1;
304 while (isdigit(baseName[offset])) {
305 ++offset;
306 }
307 // If we found digits, another underscore, and anything else, that's the inliner prefix.
308 // Strip it off.
309 if (offset > 1 && baseName[offset] == '_' && baseName[offset + 1] != '\0') {
310 baseName.erase(0, offset + 1);
311 } else {
312 // This name doesn't contain an inliner prefix, but it does start with an underscore.
313 // OpenGL disallows two consecutive underscores anywhere in the string, and we'll be
314 // adding one as part of the inliner prefix, so strip the leading underscore.
315 baseName.erase(0, 1);
316 }
317 }
John Stilesc75abb82020-09-14 18:24:12 -0400318
319 // Append a unique numeric prefix to avoid name overlap. Check the symbol table to make sure
320 // we're not reusing an existing name. (Note that within a single compilation pass, this check
321 // isn't fully comprehensive, as code isn't always generated in top-to-bottom order.)
322 String uniqueName;
323 for (;;) {
John Stiles6f31e272020-12-16 13:30:54 -0500324 uniqueName = String::printf("_%d_%s", fInlineVarCounter++, baseName.c_str());
John Stilesc75abb82020-09-14 18:24:12 -0400325 StringFragment frag{uniqueName.data(), uniqueName.length()};
326 if ((*symbolTable)[frag] == nullptr) {
327 break;
328 }
329 }
330
331 return uniqueName;
332}
333
John Stiles44e96be2020-08-31 13:16:04 -0400334std::unique_ptr<Expression> Inliner::inlineExpression(int offset,
335 VariableRewriteMap* varMap,
John Stilesd7cc0932020-11-30 12:24:27 -0500336 SymbolTable* symbolTableForExpression,
John Stiles44e96be2020-08-31 13:16:04 -0400337 const Expression& expression) {
338 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
339 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500340 return this->inlineExpression(offset, varMap, symbolTableForExpression, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400341 }
342 return nullptr;
343 };
John Stiles8e3b6be2020-10-13 11:14:08 -0400344 auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray {
345 ExpressionArray args;
John Stilesf4bda742020-10-14 16:57:41 -0400346 args.reserve_back(originalArgs.size());
John Stiles44e96be2020-08-31 13:16:04 -0400347 for (const std::unique_ptr<Expression>& arg : originalArgs) {
348 args.push_back(expr(arg));
349 }
350 return args;
351 };
352
Ethan Nicholase6592142020-09-08 10:22:09 -0400353 switch (expression.kind()) {
354 case Expression::Kind::kBinary: {
John Stiles44e96be2020-08-31 13:16:04 -0400355 const BinaryExpression& b = expression.as<BinaryExpression>();
356 return std::make_unique<BinaryExpression>(offset,
John Stiles2d4f9592020-10-30 10:29:12 -0400357 expr(b.left()),
Ethan Nicholasc8d9c8e2020-09-22 15:05:37 -0400358 b.getOperator(),
John Stiles2d4f9592020-10-30 10:29:12 -0400359 expr(b.right()),
Ethan Nicholas30d30222020-09-11 12:27:26 -0400360 &b.type());
John Stiles44e96be2020-08-31 13:16:04 -0400361 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400362 case Expression::Kind::kBoolLiteral:
363 case Expression::Kind::kIntLiteral:
364 case Expression::Kind::kFloatLiteral:
365 case Expression::Kind::kNullLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400366 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400367 case Expression::Kind::kConstructor: {
John Stiles44e96be2020-08-31 13:16:04 -0400368 const Constructor& constructor = expression.as<Constructor>();
John Stilesd7cc0932020-11-30 12:24:27 -0500369 const Type* type = copy_if_needed(&constructor.type(), *symbolTableForExpression);
370 return std::make_unique<Constructor>(offset, type, argList(constructor.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400371 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400372 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400373 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400374 return std::make_unique<ExternalFunctionCall>(offset, &externalCall.function(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400375 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400376 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400377 case Expression::Kind::kExternalValue:
John Stiles44e96be2020-08-31 13:16:04 -0400378 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400379 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400380 const FieldAccess& f = expression.as<FieldAccess>();
Ethan Nicholas7a95b202020-10-09 11:55:40 -0400381 return std::make_unique<FieldAccess>(expr(f.base()), f.fieldIndex(), f.ownerKind());
John Stiles44e96be2020-08-31 13:16:04 -0400382 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400383 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400384 const FunctionCall& funcCall = expression.as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400385 return std::make_unique<FunctionCall>(offset, &funcCall.type(), &funcCall.function(),
386 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400387 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400388 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400389 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400390 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400391 const IndexExpression& idx = expression.as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400392 return std::make_unique<IndexExpression>(*fContext, expr(idx.base()),
393 expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400394 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400395 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400396 const PrefixExpression& p = expression.as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400397 return std::make_unique<PrefixExpression>(p.getOperator(), expr(p.operand()));
John Stiles44e96be2020-08-31 13:16:04 -0400398 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400399 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400400 const PostfixExpression& p = expression.as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400401 return std::make_unique<PostfixExpression>(expr(p.operand()), p.getOperator());
John Stiles44e96be2020-08-31 13:16:04 -0400402 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400403 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400404 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400405 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400406 const Swizzle& s = expression.as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -0400407 return std::make_unique<Swizzle>(*fContext, expr(s.base()), s.components());
John Stiles44e96be2020-08-31 13:16:04 -0400408 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400409 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400410 const TernaryExpression& t = expression.as<TernaryExpression>();
Ethan Nicholasdd218162020-10-08 05:48:01 -0400411 return std::make_unique<TernaryExpression>(offset, expr(t.test()),
412 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400413 }
Brian Osman83ba9302020-09-11 13:33:46 -0400414 case Expression::Kind::kTypeReference:
415 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400416 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400417 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400418 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400419 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400420 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400421 }
422 return v.clone();
423 }
424 default:
425 SkASSERT(false);
426 return nullptr;
427 }
428}
429
430std::unique_ptr<Statement> Inliner::inlineStatement(int offset,
431 VariableRewriteMap* varMap,
432 SymbolTable* symbolTableForStatement,
John Stiles9e948122020-12-16 18:24:48 +0000433 const Expression* resultExpr,
434 bool haveEarlyReturns,
Brian Osman3887a012020-09-30 13:22:27 -0400435 const Statement& statement,
436 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400437 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
438 if (s) {
John Stilesa5f3c312020-09-22 12:05:16 -0400439 return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr,
John Stiles9e948122020-12-16 18:24:48 +0000440 haveEarlyReturns, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400441 }
442 return nullptr;
443 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400444 auto blockStmts = [&](const Block& block) {
John Stiles8f2a0cf2020-10-13 12:48:21 -0400445 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400446 result.reserve_back(block.children().size());
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400447 for (const std::unique_ptr<Statement>& child : block.children()) {
448 result.push_back(stmt(child));
449 }
450 return result;
451 };
John Stiles8f2a0cf2020-10-13 12:48:21 -0400452 auto stmts = [&](const StatementArray& ss) {
453 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400454 result.reserve_back(ss.size());
John Stiles44e96be2020-08-31 13:16:04 -0400455 for (const auto& s : ss) {
456 result.push_back(stmt(s));
457 }
458 return result;
459 };
460 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
461 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500462 return this->inlineExpression(offset, varMap, symbolTableForStatement, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400463 }
464 return nullptr;
465 };
John Stiles031a7672020-11-13 16:13:18 -0500466
467 ++fInlinedStatementCounter;
468
Ethan Nicholase6592142020-09-08 10:22:09 -0400469 switch (statement.kind()) {
470 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400471 const Block& b = statement.as<Block>();
John Stilesa1e2b412020-10-20 14:51:28 -0400472 return std::make_unique<Block>(offset, blockStmts(b),
473 SymbolTable::WrapIfBuiltin(b.symbolTable()),
474 b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400475 }
476
Ethan Nicholase6592142020-09-08 10:22:09 -0400477 case Statement::Kind::kBreak:
478 case Statement::Kind::kContinue:
479 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400480 return statement.clone();
481
Ethan Nicholase6592142020-09-08 10:22:09 -0400482 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400483 const DoStatement& d = statement.as<DoStatement>();
Ethan Nicholas1fd61162020-09-28 13:14:19 -0400484 return std::make_unique<DoStatement>(offset, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400485 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400486 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400487 const ExpressionStatement& e = statement.as<ExpressionStatement>();
Ethan Nicholasd503a5a2020-09-30 09:29:55 -0400488 return std::make_unique<ExpressionStatement>(expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400489 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400490 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400491 const ForStatement& f = statement.as<ForStatement>();
492 // need to ensure initializer is evaluated first so that we've already remapped its
493 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400494 std::unique_ptr<Statement> initializer = stmt(f.initializer());
495 return std::make_unique<ForStatement>(offset, std::move(initializer), expr(f.test()),
John Stilesa1e2b412020-10-20 14:51:28 -0400496 expr(f.next()), stmt(f.statement()),
497 SymbolTable::WrapIfBuiltin(f.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400498 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400499 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400500 const IfStatement& i = statement.as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400501 return std::make_unique<IfStatement>(offset, i.isStatic(), expr(i.test()),
502 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400503 }
John Stiles98c1f822020-09-09 14:18:53 -0400504 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400505 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400506 return statement.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400507 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400508 const ReturnStatement& r = statement.as<ReturnStatement>();
John Stiles9e948122020-12-16 18:24:48 +0000509 if (r.expression()) {
510 SkASSERT(resultExpr);
511 auto assignment =
512 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
513 offset,
514 clone_with_ref_kind(*resultExpr,
515 VariableReference::RefKind::kWrite),
516 Token::Kind::TK_EQ,
517 expr(r.expression()),
518 &resultExpr->type()));
519 if (haveEarlyReturns) {
520 StatementArray block;
521 block.reserve_back(2);
522 block.push_back(std::move(assignment));
John Stiles7b920442020-12-17 10:43:41 -0500523 block.push_back(std::make_unique<ContinueStatement>(offset));
524 return std::make_unique<Block>(offset, std::move(block),
525 /*symbols=*/nullptr, /*isScope=*/true);
John Stiles9e948122020-12-16 18:24:48 +0000526 } else {
527 return std::move(assignment);
528 }
529 } else {
530 if (haveEarlyReturns) {
John Stiles7b920442020-12-17 10:43:41 -0500531 return std::make_unique<ContinueStatement>(offset);
John Stiles44e96be2020-08-31 13:16:04 -0400532 } else {
533 return std::make_unique<Nop>();
534 }
535 }
536 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400537 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400538 const SwitchStatement& ss = statement.as<SwitchStatement>();
539 std::vector<std::unique_ptr<SwitchCase>> cases;
John Stiles2d4f9592020-10-30 10:29:12 -0400540 cases.reserve(ss.cases().size());
541 for (const std::unique_ptr<SwitchCase>& sc : ss.cases()) {
542 cases.push_back(std::make_unique<SwitchCase>(offset, expr(sc->value()),
543 stmts(sc->statements())));
John Stiles44e96be2020-08-31 13:16:04 -0400544 }
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400545 return std::make_unique<SwitchStatement>(offset, ss.isStatic(), expr(ss.value()),
John Stilesa1e2b412020-10-20 14:51:28 -0400546 std::move(cases),
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400547 SymbolTable::WrapIfBuiltin(ss.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400548 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400549 case Statement::Kind::kVarDeclaration: {
John Stiles44e96be2020-08-31 13:16:04 -0400550 const VarDeclaration& decl = statement.as<VarDeclaration>();
John Stiles35fee4c2020-12-16 18:25:14 +0000551 std::unique_ptr<Expression> initialValue = expr(decl.value());
552 int arraySize = decl.arraySize();
553 const Variable& old = decl.var();
554 // We assign unique names to inlined variables--scopes hide most of the problems in this
555 // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique
556 // names are important.
557 auto name = std::make_unique<String>(
558 this->uniqueNameForInlineVar(String(old.name()), symbolTableForStatement));
559 const String* namePtr = symbolTableForStatement->takeOwnershipOfString(std::move(name));
560 const Type* baseTypePtr = copy_if_needed(&decl.baseType(), *symbolTableForStatement);
561 const Type* typePtr = copy_if_needed(&old.type(), *symbolTableForStatement);
562 const Variable* clone = symbolTableForStatement->takeOwnershipOfSymbol(
563 std::make_unique<Variable>(offset,
564 &old.modifiers(),
565 namePtr->c_str(),
566 typePtr,
567 isBuiltinCode,
568 old.storage(),
569 initialValue.get()));
570 (*varMap)[&old] = std::make_unique<VariableReference>(offset, clone);
571 return std::make_unique<VarDeclaration>(clone, baseTypePtr, arraySize,
572 std::move(initialValue));
John Stiles44e96be2020-08-31 13:16:04 -0400573 }
John Stiles44e96be2020-08-31 13:16:04 -0400574 default:
575 SkASSERT(false);
576 return nullptr;
577 }
578}
579
John Stiles7b920442020-12-17 10:43:41 -0500580Inliner::InlineVariable Inliner::makeInlineVariable(const String& baseName,
581 const Type* type,
582 SymbolTable* symbolTable,
583 Modifiers modifiers,
584 bool isBuiltinCode,
585 std::unique_ptr<Expression>* initialValue) {
586 // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so
587 // replace them if they ever appear here. If this happens, we likely forgot to coerce a type
588 // somewhere during compilation.
589 if (type == fContext->fFloatLiteral_Type.get()) {
590 SkDEBUGFAIL("found a $floatLiteral type while inlining");
591 type = fContext->fFloat_Type.get();
592 } else if (type == fContext->fIntLiteral_Type.get()) {
593 SkDEBUGFAIL("found an $intLiteral type while inlining");
594 type = fContext->fInt_Type.get();
595 }
596
597 // Provide our new variable with a unique name, and add it to our symbol table.
598 const String* namePtr = symbolTable->takeOwnershipOfString(
599 std::make_unique<String>(this->uniqueNameForInlineVar(baseName, symbolTable)));
600 StringFragment nameFrag{namePtr->c_str(), namePtr->length()};
601
602 // Create our new variable and add it to the symbol table.
603 InlineVariable result;
604 result.fVarSymbol =
605 symbolTable->add(std::make_unique<Variable>(/*offset=*/-1,
606 fModifiers->addToPool(Modifiers()),
607 nameFrag,
608 type,
609 isBuiltinCode,
610 Variable::Storage::kLocal,
611 initialValue->get()));
612
613 // Prepare the variable declaration (taking extra care with `out` params to not clobber any
614 // initial value).
615 if (*initialValue && (modifiers.fFlags & Modifiers::kOut_Flag)) {
616 result.fVarDecl = std::make_unique<VarDeclaration>(result.fVarSymbol, type, /*arraySize=*/0,
617 (*initialValue)->clone());
618 } else {
619 result.fVarDecl = std::make_unique<VarDeclaration>(result.fVarSymbol, type, /*arraySize=*/0,
620 std::move(*initialValue));
621 }
622 return result;
623}
624
John Stiles6eadf132020-09-08 10:16:10 -0400625Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
John Stiles78047582020-12-16 16:17:41 -0500626 std::shared_ptr<SymbolTable> symbolTable,
Brian Osman3887a012020-09-30 13:22:27 -0400627 const FunctionDeclaration* caller) {
John Stiles44e96be2020-08-31 13:16:04 -0400628 // Inlining is more complicated here than in a typical compiler, because we have to have a
629 // high-level IR and can't just drop statements into the middle of an expression or even use
630 // gotos.
631 //
632 // Since we can't insert statements into an expression, we run the inline function as extra
633 // statements before the statement we're currently processing, relying on a lack of execution
634 // order guarantees. Since we can't use gotos (which are normally used to replace return
635 // statements), we wrap the whole function in a loop and use break statements to jump to the
636 // end.
637 SkASSERT(fSettings);
638 SkASSERT(fContext);
639 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400640 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400641
John Stiles8e3b6be2020-10-13 11:14:08 -0400642 ExpressionArray& arguments = call->arguments();
John Stiles6eadf132020-09-08 10:16:10 -0400643 const int offset = call->fOffset;
Ethan Nicholased84b732020-10-08 11:45:44 -0400644 const FunctionDefinition& function = *call->function().definition();
John Stiles9e948122020-12-16 18:24:48 +0000645 const bool hasEarlyReturn = has_early_return(function);
John Stiles6eadf132020-09-08 10:16:10 -0400646
John Stiles44e96be2020-08-31 13:16:04 -0400647 InlinedCall inlinedCall;
John Stiles8f2a0cf2020-10-13 12:48:21 -0400648 inlinedCall.fInlinedBody = std::make_unique<Block>(offset, StatementArray{},
John Stiles6eadf132020-09-08 10:16:10 -0400649 /*symbols=*/nullptr,
650 /*isScope=*/false);
John Stiles98c1f822020-09-09 14:18:53 -0400651
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400652 Block& inlinedBody = *inlinedCall.fInlinedBody;
John Stiles82f373c2020-10-20 13:58:05 -0400653 inlinedBody.children().reserve_back(
654 1 + // Inline marker
655 1 + // Result variable
656 arguments.size() + // Function arguments (passing in)
657 arguments.size() + // Function arguments (copy out-params back)
John Stiles7b920442020-12-17 10:43:41 -0500658 1); // Block for inlined code
John Stiles98c1f822020-09-09 14:18:53 -0400659
Ethan Nicholasceb62142020-10-09 16:51:18 -0400660 inlinedBody.children().push_back(std::make_unique<InlineMarker>(&call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400661
John Stiles44e96be2020-08-31 13:16:04 -0400662 // Create a variable to hold the result in the extra statements (excepting void).
John Stilese41b4ee2020-09-28 12:28:16 -0400663 std::unique_ptr<Expression> resultExpr;
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400664 if (function.declaration().returnType() != *fContext->fVoid_Type) {
John Stiles44e96be2020-08-31 13:16:04 -0400665 std::unique_ptr<Expression> noInitialValue;
John Stiles7b920442020-12-17 10:43:41 -0500666 InlineVariable var = this->makeInlineVariable(function.declaration().name(),
667 &function.declaration().returnType(),
668 symbolTable.get(), Modifiers{},
669 caller->isBuiltin(), &noInitialValue);
670 inlinedBody.children().push_back(std::move(var.fVarDecl));
671 resultExpr = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles35fee4c2020-12-16 18:25:14 +0000672 }
John Stiles44e96be2020-08-31 13:16:04 -0400673
674 // Create variables in the extra statements to hold the arguments, and assign the arguments to
675 // them.
676 VariableRewriteMap varMap;
John Stilese41b4ee2020-09-28 12:28:16 -0400677 std::vector<int> argsToCopyBack;
John Stiles44e96be2020-08-31 13:16:04 -0400678 for (int i = 0; i < (int) arguments.size(); ++i) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400679 const Variable* param = function.declaration().parameters()[i];
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400680 bool isOutParam = param->modifiers().fFlags & Modifiers::kOut_Flag;
John Stiles44e96be2020-08-31 13:16:04 -0400681
John Stiles44733aa2020-09-29 17:42:23 -0400682 // If this argument can be inlined trivially (e.g. a swizzle, or a constant array index)...
John Stilesc30fbca2020-11-19 16:25:49 -0500683 if (Analysis::IsTrivialExpression(*arguments[i])) {
John Stilese41b4ee2020-09-28 12:28:16 -0400684 // ... and it's an `out` param, or it isn't written to within the inline function...
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400685 if (isOutParam || !Analysis::StatementWritesToVariable(*function.body(), *param)) {
John Stilesf201af82020-09-29 16:57:55 -0400686 // ... we don't need to copy it at all! We can just use the existing expression.
687 varMap[param] = arguments[i]->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400688 continue;
689 }
690 }
John Stilese41b4ee2020-09-28 12:28:16 -0400691 if (isOutParam) {
692 argsToCopyBack.push_back(i);
693 }
John Stiles7b920442020-12-17 10:43:41 -0500694 InlineVariable var = this->makeInlineVariable(param->name(), &arguments[i]->type(),
695 symbolTable.get(), param->modifiers(),
696 caller->isBuiltin(), &arguments[i]);
697 inlinedBody.children().push_back(std::move(var.fVarDecl));
698 varMap[param] = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400699 }
700
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400701 const Block& body = function.body()->as<Block>();
John Stiles7b920442020-12-17 10:43:41 -0500702 StatementArray* inlineStatements;
703
John Stiles44e96be2020-08-31 13:16:04 -0400704 if (hasEarlyReturn) {
705 // Since we output to backends that don't have a goto statement (which would normally be
John Stiles7b920442020-12-17 10:43:41 -0500706 // used to perform an early return), we fake it by wrapping the function in a single-
707 // iteration for loop, and use a continue statement to jump to the end of the loop
708 // prematurely.
709
710 // int _1_loop = 0;
711 symbolTable = std::make_shared<SymbolTable>(std::move(symbolTable), caller->isBuiltin());
712 const Type* intType = fContext->fInt_Type.get();
713 std::unique_ptr<Expression> initialValue = std::make_unique<IntLiteral>(/*offset=*/-1,
714 /*value=*/0,
715 intType);
716 InlineVariable loopVar = this->makeInlineVariable("loop", intType, symbolTable.get(),
717 Modifiers{}, caller->isBuiltin(),
718 &initialValue);
719
720 // _1_loop < 1;
721 std::unique_ptr<Expression> test = std::make_unique<BinaryExpression>(
John Stiles44e96be2020-08-31 13:16:04 -0400722 /*offset=*/-1,
John Stiles7b920442020-12-17 10:43:41 -0500723 std::make_unique<VariableReference>(/*offset=*/-1, loopVar.fVarSymbol),
724 Token::Kind::TK_LT,
725 std::make_unique<IntLiteral>(/*offset=*/-1, /*value=*/1, intType),
726 fContext->fBool_Type.get());
727
728 // _1_loop++
729 std::unique_ptr<Expression> increment = std::make_unique<PostfixExpression>(
730 std::make_unique<VariableReference>(/*offset=*/-1, loopVar.fVarSymbol,
731 VariableReference::RefKind::kReadWrite),
732 Token::Kind::TK_PLUSPLUS);
733
734 // {...}
735 auto innerBlock = std::make_unique<Block>(offset, StatementArray{},
736 /*symbols=*/nullptr, /*isScope=*/true);
737 inlineStatements = &innerBlock->children();
738
739 // for (int _1_loop = 0; _1_loop < 1; _1_loop++) {...}
740 inlinedBody.children().push_back(std::make_unique<ForStatement>(/*offset=*/-1,
741 std::move(loopVar.fVarDecl),
742 std::move(test),
743 std::move(increment),
744 std::move(innerBlock),
745 symbolTable));
John Stiles44e96be2020-08-31 13:16:04 -0400746 } else {
John Stiles7b920442020-12-17 10:43:41 -0500747 // No early returns, so we can just dump the code into a scopeless block.
748 auto innerBlock = std::make_unique<Block>(offset, StatementArray{},
749 /*symbols=*/nullptr, /*isScope=*/false);
750 inlineStatements = &innerBlock->children();
751 inlinedBody.children().push_back(std::move(innerBlock));
752 }
753
754 inlineStatements->reserve_back(body.children().size() + argsToCopyBack.size());
755 for (const std::unique_ptr<Statement>& stmt : body.children()) {
756 inlineStatements->push_back(this->inlineStatement(offset, &varMap, symbolTable.get(),
757 resultExpr.get(), hasEarlyReturn, *stmt,
758 caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400759 }
760
John Stilese41b4ee2020-09-28 12:28:16 -0400761 // Copy back the values of `out` parameters into their real destinations.
762 for (int i : argsToCopyBack) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400763 const Variable* p = function.declaration().parameters()[i];
John Stilese41b4ee2020-09-28 12:28:16 -0400764 SkASSERT(varMap.find(p) != varMap.end());
John Stiles7b920442020-12-17 10:43:41 -0500765 inlineStatements->push_back(
John Stilese41b4ee2020-09-28 12:28:16 -0400766 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
767 offset,
Ethan Nicholas453f67f2020-10-09 10:43:45 -0400768 clone_with_ref_kind(*arguments[i], VariableReference::RefKind::kWrite),
John Stilese41b4ee2020-09-28 12:28:16 -0400769 Token::Kind::TK_EQ,
770 std::move(varMap[p]),
771 &arguments[i]->type())));
John Stiles44e96be2020-08-31 13:16:04 -0400772 }
773
John Stilese41b4ee2020-09-28 12:28:16 -0400774 if (resultExpr != nullptr) {
775 // Return our result variable as our replacement expression.
John Stiles9e948122020-12-16 18:24:48 +0000776 SkASSERT(resultExpr->as<VariableReference>().refKind() ==
777 VariableReference::RefKind::kRead);
John Stilese41b4ee2020-09-28 12:28:16 -0400778 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles44e96be2020-08-31 13:16:04 -0400779 } else {
780 // It's a void function, so it doesn't actually result in anything, but we have to return
781 // something non-null as a standin.
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400782 inlinedCall.fReplacementExpr = std::make_unique<BoolLiteral>(*fContext,
783 offset,
John Stiles44e96be2020-08-31 13:16:04 -0400784 /*value=*/false);
785 }
786
John Stiles44e96be2020-08-31 13:16:04 -0400787 return inlinedCall;
788}
789
John Stiles2d7973a2020-10-02 15:01:03 -0400790bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400791 SkASSERT(fSettings);
792
John Stiles1c03d332020-10-13 10:30:23 -0400793 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
794 if (fSettings->fInlineThreshold <= 0) {
795 return false;
796 }
797
John Stiles031a7672020-11-13 16:13:18 -0500798 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
799 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
800 return false;
801 }
802
John Stiles2d7973a2020-10-02 15:01:03 -0400803 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400804 // Can't inline something if we don't actually have its definition.
805 return false;
806 }
John Stiles2d7973a2020-10-02 15:01:03 -0400807
John Stiles7b920442020-12-17 10:43:41 -0500808 // We don't have any mechanism to simulate early returns within a breakable construct
809 // (switch/for/do/while), so we can't inline if there's a return inside one.
John Stiles2d7973a2020-10-02 15:01:03 -0400810 bool hasReturnInBreakableConstruct = (count_returns_in_breakable_constructs(*functionDef) > 0);
John Stiles44e96be2020-08-31 13:16:04 -0400811
812 // If we detected returns in breakable constructs, we should also detect an early return.
John Stiles9e948122020-12-16 18:24:48 +0000813 SkASSERT(!hasReturnInBreakableConstruct || has_early_return(*functionDef));
John Stiles44e96be2020-08-31 13:16:04 -0400814 return !hasReturnInBreakableConstruct;
815}
816
John Stiles2d7973a2020-10-02 15:01:03 -0400817// A candidate function for inlining, containing everything that `inlineCall` needs.
818struct InlineCandidate {
John Stiles78047582020-12-16 16:17:41 -0500819 std::shared_ptr<SymbolTable> fSymbols; // the SymbolTable of the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400820 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
821 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
822 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
823 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400824};
John Stiles93442622020-09-11 12:11:27 -0400825
John Stiles2d7973a2020-10-02 15:01:03 -0400826struct InlineCandidateList {
827 std::vector<InlineCandidate> fCandidates;
828};
829
830class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400831public:
832 // A list of all the inlining candidates we found during analysis.
833 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400834
John Stiles70957c82020-10-02 16:42:10 -0400835 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
836 // the enclosing-statement stack.
John Stiles78047582020-12-16 16:17:41 -0500837 std::vector<std::shared_ptr<SymbolTable>> fSymbolTableStack;
John Stiles70957c82020-10-02 16:42:10 -0400838 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
839 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
840 // inliner might replace a statement with a block containing the statement.
841 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
842 // The function that we're currently processing (i.e. inlining into).
843 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400844
Brian Osman0006ad02020-11-18 15:38:39 -0500845 void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -0500846 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -0500847 InlineCandidateList* candidateList) {
John Stiles70957c82020-10-02 16:42:10 -0400848 fCandidateList = candidateList;
Brian Osman0006ad02020-11-18 15:38:39 -0500849 fSymbolTableStack.push_back(symbols);
John Stiles93442622020-09-11 12:11:27 -0400850
Brian Osman0006ad02020-11-18 15:38:39 -0500851 for (const std::unique_ptr<ProgramElement>& pe : elements) {
Brian Osman1179fcf2020-10-08 16:04:40 -0400852 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400853 }
854
John Stiles70957c82020-10-02 16:42:10 -0400855 fSymbolTableStack.pop_back();
856 fCandidateList = nullptr;
857 }
858
859 void visitProgramElement(ProgramElement* pe) {
860 switch (pe->kind()) {
861 case ProgramElement::Kind::kFunction: {
862 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
Brian Osman0006ad02020-11-18 15:38:39 -0500863 fEnclosingFunction = &funcDef;
864 this->visitStatement(&funcDef.body());
John Stiles70957c82020-10-02 16:42:10 -0400865 break;
John Stiles93442622020-09-11 12:11:27 -0400866 }
John Stiles70957c82020-10-02 16:42:10 -0400867 default:
868 // The inliner can't operate outside of a function's scope.
869 break;
870 }
871 }
872
873 void visitStatement(std::unique_ptr<Statement>* stmt,
874 bool isViableAsEnclosingStatement = true) {
875 if (!*stmt) {
876 return;
John Stiles93442622020-09-11 12:11:27 -0400877 }
878
John Stiles70957c82020-10-02 16:42:10 -0400879 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
880 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400881
John Stiles70957c82020-10-02 16:42:10 -0400882 if (isViableAsEnclosingStatement) {
883 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400884 }
885
John Stiles70957c82020-10-02 16:42:10 -0400886 switch ((*stmt)->kind()) {
887 case Statement::Kind::kBreak:
888 case Statement::Kind::kContinue:
889 case Statement::Kind::kDiscard:
890 case Statement::Kind::kInlineMarker:
891 case Statement::Kind::kNop:
892 break;
893
894 case Statement::Kind::kBlock: {
895 Block& block = (*stmt)->as<Block>();
896 if (block.symbolTable()) {
John Stiles78047582020-12-16 16:17:41 -0500897 fSymbolTableStack.push_back(block.symbolTable());
John Stiles70957c82020-10-02 16:42:10 -0400898 }
899
900 for (std::unique_ptr<Statement>& stmt : block.children()) {
901 this->visitStatement(&stmt);
902 }
903 break;
John Stiles93442622020-09-11 12:11:27 -0400904 }
John Stiles70957c82020-10-02 16:42:10 -0400905 case Statement::Kind::kDo: {
906 DoStatement& doStmt = (*stmt)->as<DoStatement>();
907 // The loop body is a candidate for inlining.
908 this->visitStatement(&doStmt.statement());
909 // The inliner isn't smart enough to inline the test-expression for a do-while
910 // loop at this time. There are two limitations:
911 // - We would need to insert the inlined-body block at the very end of the do-
912 // statement's inner fStatement. We don't support that today, but it's doable.
913 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
914 // would skip over the inlined block that evaluates the test expression. There
915 // isn't a good fix for this--any workaround would be more complex than the cost
916 // of a function call. However, loops that don't use `continue` would still be
917 // viable candidates for inlining.
918 break;
John Stiles93442622020-09-11 12:11:27 -0400919 }
John Stiles70957c82020-10-02 16:42:10 -0400920 case Statement::Kind::kExpression: {
921 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
922 this->visitExpression(&expr.expression());
923 break;
924 }
925 case Statement::Kind::kFor: {
926 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400927 if (forStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500928 fSymbolTableStack.push_back(forStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400929 }
930
931 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400932 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400933 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400934 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400935
936 // The inliner isn't smart enough to inline the test- or increment-expressions
937 // of a for loop loop at this time. There are a handful of limitations:
938 // - We would need to insert the test-expression block at the very beginning of the
939 // for-loop's inner fStatement, and the increment-expression block at the very
940 // end. We don't support that today, but it's doable.
941 // - The for-loop's built-in test-expression would need to be dropped entirely,
942 // and the loop would be halted via a break statement at the end of the inlined
943 // test-expression. This is again something we don't support today, but it could
944 // be implemented.
945 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
946 // that would skip over the inlined block that evaluates the increment expression.
947 // There isn't a good fix for this--any workaround would be more complex than the
948 // cost of a function call. However, loops that don't use `continue` would still
949 // be viable candidates for increment-expression inlining.
950 break;
951 }
952 case Statement::Kind::kIf: {
953 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400954 this->visitExpression(&ifStmt.test());
955 this->visitStatement(&ifStmt.ifTrue());
956 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -0400957 break;
958 }
959 case Statement::Kind::kReturn: {
960 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400961 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -0400962 break;
963 }
964 case Statement::Kind::kSwitch: {
965 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400966 if (switchStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500967 fSymbolTableStack.push_back(switchStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400968 }
969
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400970 this->visitExpression(&switchStmt.value());
John Stiles2d4f9592020-10-30 10:29:12 -0400971 for (const std::unique_ptr<SwitchCase>& switchCase : switchStmt.cases()) {
John Stiles70957c82020-10-02 16:42:10 -0400972 // The switch-case's fValue cannot be a FunctionCall; skip it.
John Stiles2d4f9592020-10-30 10:29:12 -0400973 for (std::unique_ptr<Statement>& caseBlock : switchCase->statements()) {
John Stiles70957c82020-10-02 16:42:10 -0400974 this->visitStatement(&caseBlock);
975 }
976 }
977 break;
978 }
979 case Statement::Kind::kVarDeclaration: {
980 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
981 // Don't need to scan the declaration's sizes; those are always IntLiterals.
Ethan Nicholasc51f33e2020-10-13 13:49:44 -0400982 this->visitExpression(&varDeclStmt.value());
John Stiles70957c82020-10-02 16:42:10 -0400983 break;
984 }
John Stiles70957c82020-10-02 16:42:10 -0400985 default:
986 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -0400987 }
988
John Stiles70957c82020-10-02 16:42:10 -0400989 // Pop our symbol and enclosing-statement stacks.
990 fSymbolTableStack.resize(oldSymbolStackSize);
991 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
992 }
993
994 void visitExpression(std::unique_ptr<Expression>* expr) {
995 if (!*expr) {
996 return;
John Stiles93442622020-09-11 12:11:27 -0400997 }
John Stiles70957c82020-10-02 16:42:10 -0400998
999 switch ((*expr)->kind()) {
1000 case Expression::Kind::kBoolLiteral:
1001 case Expression::Kind::kDefined:
1002 case Expression::Kind::kExternalValue:
1003 case Expression::Kind::kFieldAccess:
1004 case Expression::Kind::kFloatLiteral:
1005 case Expression::Kind::kFunctionReference:
1006 case Expression::Kind::kIntLiteral:
1007 case Expression::Kind::kNullLiteral:
1008 case Expression::Kind::kSetting:
1009 case Expression::Kind::kTypeReference:
1010 case Expression::Kind::kVariableReference:
1011 // Nothing to scan here.
1012 break;
1013
1014 case Expression::Kind::kBinary: {
1015 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
John Stiles2d4f9592020-10-30 10:29:12 -04001016 this->visitExpression(&binaryExpr.left());
John Stiles70957c82020-10-02 16:42:10 -04001017
1018 // Logical-and and logical-or binary expressions do not inline the right side,
1019 // because that would invalidate short-circuiting. That is, when evaluating
1020 // expressions like these:
1021 // (false && x()) // always false
1022 // (true || y()) // always true
1023 // It is illegal for side-effects from x() or y() to occur. The simplest way to
1024 // enforce that rule is to avoid inlining the right side entirely. However, it is
1025 // safe for other types of binary expression to inline both sides.
1026 Token::Kind op = binaryExpr.getOperator();
1027 bool shortCircuitable = (op == Token::Kind::TK_LOGICALAND ||
1028 op == Token::Kind::TK_LOGICALOR);
1029 if (!shortCircuitable) {
John Stiles2d4f9592020-10-30 10:29:12 -04001030 this->visitExpression(&binaryExpr.right());
John Stiles70957c82020-10-02 16:42:10 -04001031 }
1032 break;
1033 }
1034 case Expression::Kind::kConstructor: {
1035 Constructor& constructorExpr = (*expr)->as<Constructor>();
1036 for (std::unique_ptr<Expression>& arg : constructorExpr.arguments()) {
1037 this->visitExpression(&arg);
1038 }
1039 break;
1040 }
1041 case Expression::Kind::kExternalFunctionCall: {
1042 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
1043 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
1044 this->visitExpression(&arg);
1045 }
1046 break;
1047 }
1048 case Expression::Kind::kFunctionCall: {
1049 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001050 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -04001051 this->visitExpression(&arg);
1052 }
1053 this->addInlineCandidate(expr);
1054 break;
1055 }
1056 case Expression::Kind::kIndex:{
1057 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001058 this->visitExpression(&indexExpr.base());
1059 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -04001060 break;
1061 }
1062 case Expression::Kind::kPostfix: {
1063 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001064 this->visitExpression(&postfixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001065 break;
1066 }
1067 case Expression::Kind::kPrefix: {
1068 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001069 this->visitExpression(&prefixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001070 break;
1071 }
1072 case Expression::Kind::kSwizzle: {
1073 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -04001074 this->visitExpression(&swizzleExpr.base());
John Stiles70957c82020-10-02 16:42:10 -04001075 break;
1076 }
1077 case Expression::Kind::kTernary: {
1078 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1079 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001080 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001081 // The true- and false-expressions cannot be inlined, because we are only allowed to
1082 // evaluate one side.
1083 break;
1084 }
1085 default:
1086 SkUNREACHABLE;
1087 }
1088 }
1089
1090 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1091 fCandidateList->fCandidates.push_back(
1092 InlineCandidate{fSymbolTableStack.back(),
1093 find_parent_statement(fEnclosingStmtStack),
1094 fEnclosingStmtStack.back(),
1095 candidate,
John Stiles9b9415e2020-11-23 14:48:06 -05001096 fEnclosingFunction});
John Stiles70957c82020-10-02 16:42:10 -04001097 }
John Stiles2d7973a2020-10-02 15:01:03 -04001098};
John Stiles93442622020-09-11 12:11:27 -04001099
John Stiles9b9415e2020-11-23 14:48:06 -05001100static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) {
1101 return (*candidate.fCandidateExpr)->as<FunctionCall>().function();
1102}
John Stiles915a38c2020-09-14 09:38:13 -04001103
John Stiles9b9415e2020-11-23 14:48:06 -05001104bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
1105 const FunctionDeclaration& funcDecl = candidate_func(candidate);
John Stiles1c03d332020-10-13 10:30:23 -04001106 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
John Stiles2d7973a2020-10-02 15:01:03 -04001107 if (wasInserted) {
1108 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
John Stiles1c03d332020-10-13 10:30:23 -04001109 iter->second = this->isSafeToInline(funcDecl.definition()) &&
1110 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001111 }
1112
John Stiles2d7973a2020-10-02 15:01:03 -04001113 return iter->second;
1114}
1115
John Stiles9b9415e2020-11-23 14:48:06 -05001116int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) {
1117 auto [iter, wasInserted] = cache->insert({&funcDecl, 0});
John Stiles2d7973a2020-10-02 15:01:03 -04001118 if (wasInserted) {
John Stiles9b9415e2020-11-23 14:48:06 -05001119 iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(),
1120 fSettings->fInlineThreshold);
John Stiles2d7973a2020-10-02 15:01:03 -04001121 }
John Stiles2d7973a2020-10-02 15:01:03 -04001122 return iter->second;
1123}
1124
Brian Osman0006ad02020-11-18 15:38:39 -05001125void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001126 std::shared_ptr<SymbolTable> symbols, ProgramUsage* usage,
Brian Osman0006ad02020-11-18 15:38:39 -05001127 InlineCandidateList* candidateList) {
John Stiles2d7973a2020-10-02 15:01:03 -04001128 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1129 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1130 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1131 // `const T&`.
1132 InlineCandidateAnalyzer analyzer;
Brian Osman0006ad02020-11-18 15:38:39 -05001133 analyzer.visit(elements, symbols, candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001134
John Stiles0ad233f2020-11-25 11:02:05 -05001135 // Early out if there are no inlining candidates.
John Stiles2d7973a2020-10-02 15:01:03 -04001136 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
John Stiles0ad233f2020-11-25 11:02:05 -05001137 if (candidates.empty()) {
1138 return;
1139 }
1140
1141 // Remove candidates that are not safe to inline.
John Stiles2d7973a2020-10-02 15:01:03 -04001142 InlinabilityCache cache;
1143 candidates.erase(std::remove_if(candidates.begin(),
1144 candidates.end(),
1145 [&](const InlineCandidate& candidate) {
1146 return !this->candidateCanBeInlined(candidate, &cache);
1147 }),
1148 candidates.end());
1149
John Stiles0ad233f2020-11-25 11:02:05 -05001150 // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is
1151 // complete.
1152 if (fSettings->fInlineThreshold == INT_MAX || candidates.empty()) {
1153 return;
John Stiles2d7973a2020-10-02 15:01:03 -04001154 }
John Stiles0ad233f2020-11-25 11:02:05 -05001155
1156 // Remove candidates on a per-function basis if the effect of inlining would be to make more
1157 // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is
1158 // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.)
1159 FunctionSizeCache functionSizeCache;
1160 FunctionSizeCache candidateTotalCost;
1161 for (InlineCandidate& candidate : candidates) {
1162 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1163 candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache);
1164 }
1165
1166 candidates.erase(
1167 std::remove_if(candidates.begin(),
1168 candidates.end(),
1169 [&](const InlineCandidate& candidate) {
1170 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1171 if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) {
1172 // Functions marked `inline` ignore size limitations.
1173 return false;
1174 }
1175 if (usage->get(fnDecl) == 1) {
1176 // If a function is only used once, it's cost-free to inline.
1177 return false;
1178 }
1179 if (candidateTotalCost[&fnDecl] <= fSettings->fInlineThreshold) {
1180 // We won't exceed the inline threshold by inlining this.
1181 return false;
1182 }
1183 // Inlining this function will add too many IRNodes.
1184 return true;
1185 }),
1186 candidates.end());
John Stiles2d7973a2020-10-02 15:01:03 -04001187}
1188
Brian Osman0006ad02020-11-18 15:38:39 -05001189bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001190 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -05001191 ProgramUsage* usage) {
John Stilesd34d56e2020-10-12 12:04:47 -04001192 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
1193 if (fSettings->fInlineThreshold <= 0) {
1194 return false;
1195 }
1196
John Stiles031a7672020-11-13 16:13:18 -05001197 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
1198 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1199 return false;
1200 }
1201
John Stiles2d7973a2020-10-02 15:01:03 -04001202 InlineCandidateList candidateList;
John Stiles9b9415e2020-11-23 14:48:06 -05001203 this->buildCandidateList(elements, symbols, usage, &candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001204
John Stiles915a38c2020-09-14 09:38:13 -04001205 // Inline the candidates where we've determined that it's safe to do so.
1206 std::unordered_set<const std::unique_ptr<Statement>*> enclosingStmtSet;
1207 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001208 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001209 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
John Stiles915a38c2020-09-14 09:38:13 -04001210
1211 // Inlining two expressions using the same enclosing statement in the same inlining pass
1212 // does not work properly. If this happens, skip it; we'll get it in the next pass.
1213 auto [unusedIter, inserted] = enclosingStmtSet.insert(candidate.fEnclosingStmt);
1214 if (!inserted) {
1215 continue;
1216 }
1217
1218 // Convert the function call to its inlined equivalent.
Brian Osman3887a012020-09-30 13:22:27 -04001219 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols,
Ethan Nicholas0a5d0962020-10-14 13:33:18 -04001220 &candidate.fEnclosingFunction->declaration());
John Stiles915a38c2020-09-14 09:38:13 -04001221 if (inlinedCall.fInlinedBody) {
1222 // Ensure that the inlined body has a scope if it needs one.
John Stiles6d696082020-10-01 10:18:54 -04001223 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
John Stiles915a38c2020-09-14 09:38:13 -04001224
Brian Osman010ce6a2020-10-19 16:34:10 -04001225 // Add references within the inlined body
1226 usage->add(inlinedCall.fInlinedBody.get());
1227
John Stiles915a38c2020-09-14 09:38:13 -04001228 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1229 // function, then replace the enclosing statement with that Block.
1230 // Before:
1231 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1232 // fEnclosingStmt = stmt4
1233 // After:
1234 // fInlinedBody = null
1235 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -04001236 inlinedCall.fInlinedBody->children().push_back(std::move(*candidate.fEnclosingStmt));
John Stiles915a38c2020-09-14 09:38:13 -04001237 *candidate.fEnclosingStmt = std::move(inlinedCall.fInlinedBody);
1238 }
1239
1240 // Replace the candidate function call with our replacement expression.
Brian Osman010ce6a2020-10-19 16:34:10 -04001241 usage->replace(candidate.fCandidateExpr->get(), inlinedCall.fReplacementExpr.get());
John Stiles915a38c2020-09-14 09:38:13 -04001242 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1243 madeChanges = true;
1244
John Stiles031a7672020-11-13 16:13:18 -05001245 // Stop inlining if we've reached our hard cap on new statements.
1246 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1247 break;
1248 }
1249
John Stiles915a38c2020-09-14 09:38:13 -04001250 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1251 // remain valid.
1252 }
1253
1254 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001255}
1256
John Stiles44e96be2020-08-31 13:16:04 -04001257} // namespace SkSL