junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2013 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
tfarina@chromium.org | 4ee16bf | 2014-01-10 22:08:27 +0000 | [diff] [blame] | 7 | |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 8 | #include "include/core/SkCanvas.h" |
| 9 | #include "include/core/SkData.h" |
| 10 | #include "include/core/SkOverdrawCanvas.h" |
| 11 | #include "include/core/SkPath.h" |
| 12 | #include "include/core/SkRRect.h" |
| 13 | #include "include/core/SkRegion.h" |
| 14 | #include "include/core/SkSurface.h" |
| 15 | #include "include/gpu/GrBackendSurface.h" |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 16 | #include "include/gpu/GrDirectContext.h" |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 17 | #include "src/core/SkAutoPixmapStorage.h" |
Brian Salomon | 8f7d953 | 2020-12-23 09:16:59 -0500 | [diff] [blame] | 18 | #include "src/core/SkCanvasPriv.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 19 | #include "src/core/SkDevice.h" |
| 20 | #include "src/core/SkUtils.h" |
Robert Phillips | cc44feb | 2021-07-06 12:21:37 -0400 | [diff] [blame] | 21 | #include "src/gpu/BaseDevice.h" |
Adlai Holler | a069304 | 2020-10-14 11:23:11 -0400 | [diff] [blame] | 22 | #include "src/gpu/GrDirectContextPriv.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 23 | #include "src/gpu/GrGpu.h" |
| 24 | #include "src/gpu/GrGpuResourcePriv.h" |
Brian Salomon | f2ebdd9 | 2019-09-30 12:15:30 -0400 | [diff] [blame] | 25 | #include "src/gpu/GrImageInfo.h" |
Stephen White | fdba6c8 | 2020-05-26 17:00:32 -0400 | [diff] [blame] | 26 | #include "src/gpu/GrRenderTarget.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 27 | #include "src/gpu/GrResourceProvider.h" |
Robert Phillips | f386862 | 2021-08-04 13:27:43 -0400 | [diff] [blame] | 28 | #include "src/gpu/SurfaceFillContext.h" |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 29 | #include "src/image/SkImage_Base.h" |
| 30 | #include "src/image/SkImage_Gpu.h" |
| 31 | #include "src/image/SkSurface_Gpu.h" |
| 32 | #include "tests/Test.h" |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 33 | #include "tools/ToolUtils.h" |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 34 | #include "tools/gpu/BackendSurfaceFactory.h" |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 35 | #include "tools/gpu/ManagedBackendTexture.h" |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 36 | #include "tools/gpu/ProxyUtils.h" |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 37 | |
Hal Canary | 8a00144 | 2018-09-19 11:31:27 -0400 | [diff] [blame] | 38 | #include <functional> |
| 39 | #include <initializer_list> |
| 40 | #include <vector> |
| 41 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 42 | static void release_direct_surface_storage(void* pixels, void* context) { |
reed | 982542d | 2014-06-27 06:48:14 -0700 | [diff] [blame] | 43 | SkASSERT(pixels == context); |
| 44 | sk_free(pixels); |
| 45 | } |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 46 | static sk_sp<SkSurface> create_surface(SkAlphaType at = kPremul_SkAlphaType, |
| 47 | SkImageInfo* requestedInfo = nullptr) { |
bsalomon | 74f681d | 2015-06-23 14:38:48 -0700 | [diff] [blame] | 48 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 49 | if (requestedInfo) { |
| 50 | *requestedInfo = info; |
| 51 | } |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 52 | return SkSurface::MakeRaster(info); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 53 | } |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 54 | static sk_sp<SkSurface> create_direct_surface(SkAlphaType at = kPremul_SkAlphaType, |
| 55 | SkImageInfo* requestedInfo = nullptr) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 56 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
| 57 | if (requestedInfo) { |
| 58 | *requestedInfo = info; |
| 59 | } |
| 60 | const size_t rowBytes = info.minRowBytes(); |
Mike Reed | f0ffb89 | 2017-10-03 14:47:21 -0400 | [diff] [blame] | 61 | void* storage = sk_malloc_throw(info.computeByteSize(rowBytes)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 62 | return SkSurface::MakeRasterDirectReleaseProc(info, storage, rowBytes, |
| 63 | release_direct_surface_storage, |
| 64 | storage); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 65 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 66 | static sk_sp<SkSurface> create_gpu_surface(GrRecordingContext* rContext, |
| 67 | SkAlphaType at = kPremul_SkAlphaType, |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 68 | SkImageInfo* requestedInfo = nullptr) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 69 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
| 70 | if (requestedInfo) { |
| 71 | *requestedInfo = info; |
| 72 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 73 | return SkSurface::MakeRenderTarget(rContext, SkBudgeted::kNo, info); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 74 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 75 | static sk_sp<SkSurface> create_gpu_scratch_surface(GrRecordingContext* rContext, |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 76 | SkAlphaType at = kPremul_SkAlphaType, |
| 77 | SkImageInfo* requestedInfo = nullptr) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 78 | const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); |
| 79 | if (requestedInfo) { |
| 80 | *requestedInfo = info; |
| 81 | } |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 82 | return SkSurface::MakeRenderTarget(rContext, SkBudgeted::kYes, info); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 83 | } |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 84 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 85 | DEF_TEST(SurfaceEmpty, reporter) { |
reed | b2497c2 | 2014-12-31 12:31:43 -0800 | [diff] [blame] | 86 | const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 87 | REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRaster(info)); |
| 88 | REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRasterDirect(info, nullptr, 0)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 89 | |
reed | b2497c2 | 2014-12-31 12:31:43 -0800 | [diff] [blame] | 90 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 91 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceEmpty_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 92 | const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType); |
| 93 | REPORTER_ASSERT(reporter, nullptr == |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 94 | SkSurface::MakeRenderTarget(ctxInfo.directContext(), SkBudgeted::kNo, info)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 95 | } |
reed | b2497c2 | 2014-12-31 12:31:43 -0800 | [diff] [blame] | 96 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 97 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(GrContext_colorTypeSupportedAsSurface, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 98 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 99 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 100 | for (int ct = 0; ct < kLastEnum_SkColorType; ++ct) { |
| 101 | static constexpr int kSize = 10; |
| 102 | |
| 103 | SkColorType colorType = static_cast<SkColorType>(ct); |
| 104 | auto info = SkImageInfo::Make(kSize, kSize, colorType, kOpaque_SkAlphaType, nullptr); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 105 | |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 106 | { |
| 107 | bool can = context->colorTypeSupportedAsSurface(colorType); |
| 108 | auto surf = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, info, 1, nullptr); |
| 109 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, can: %d, surf: %d", |
| 110 | colorType, can, SkToBool(surf)); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 111 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 112 | surf = sk_gpu_test::MakeBackendTextureSurface(context, |
| 113 | {kSize, kSize}, |
| 114 | kTopLeft_GrSurfaceOrigin, |
| 115 | /*sample cnt*/ 1, |
| 116 | colorType); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 117 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, can: %d, surf: %d", |
| 118 | colorType, can, SkToBool(surf)); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 119 | } |
| 120 | |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 121 | // The MSAA test only makes sense if the colorType is renderable to begin with. |
| 122 | if (context->colorTypeSupportedAsSurface(colorType)) { |
| 123 | static constexpr int kSampleCnt = 2; |
| 124 | |
| 125 | bool can = context->maxSurfaceSampleCountForColorType(colorType) >= kSampleCnt; |
| 126 | auto surf = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, info, kSampleCnt, |
| 127 | nullptr); |
| 128 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, can: %d, surf: %d", |
| 129 | colorType, can, SkToBool(surf)); |
| 130 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 131 | surf = sk_gpu_test::MakeBackendTextureSurface( |
| 132 | context, {kSize, kSize}, kTopLeft_GrSurfaceOrigin, kSampleCnt, colorType); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 133 | REPORTER_ASSERT(reporter, can == SkToBool(surf), |
| 134 | "colorTypeSupportedAsSurface:%d, surf:%d, ct:%d", can, SkToBool(surf), |
| 135 | colorType); |
| 136 | // Ensure that the sample count stored on the resulting SkSurface is a valid value. |
| 137 | if (surf) { |
Robert Phillips | fa8af0a | 2021-06-03 11:58:43 -0400 | [diff] [blame] | 138 | auto rtp = SkCanvasPriv::TopDeviceTargetProxy(surf->getCanvas()); |
| 139 | int storedCnt = rtp->numSamples(); |
| 140 | const GrBackendFormat& format = rtp->backendFormat(); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 141 | int allowedCnt = |
| 142 | context->priv().caps()->getRenderTargetSampleCount(storedCnt, format); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 143 | REPORTER_ASSERT(reporter, storedCnt == allowedCnt, |
| 144 | "Should store an allowed sample count (%d vs %d)", allowedCnt, |
| 145 | storedCnt); |
| 146 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 147 | } |
| 148 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 149 | for (int sampleCnt : {1, 2}) { |
Brian Salomon | f9b0042 | 2020-10-08 16:00:14 -0400 | [diff] [blame] | 150 | auto surf = sk_gpu_test::MakeBackendRenderTargetSurface(context, |
| 151 | {16, 16}, |
| 152 | kTopLeft_GrSurfaceOrigin, |
| 153 | sampleCnt, |
| 154 | colorType); |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 155 | bool can = context->colorTypeSupportedAsSurface(colorType) && |
| 156 | context->maxSurfaceSampleCountForColorType(colorType) >= sampleCnt; |
| 157 | if (!surf && can && colorType == kBGRA_8888_SkColorType && sampleCnt > 1 && |
| 158 | context->backend() == GrBackendApi::kOpenGL) { |
| 159 | // This is an execeptional case. On iOS GLES we support MSAA BGRA for internally- |
| 160 | // created render targets by using a MSAA RGBA8 renderbuffer that resolves to a |
| 161 | // BGRA8 texture. However, the GL_APPLE_texture_format_BGRA8888 extension does not |
| 162 | // allow creation of BGRA8 renderbuffers and we don't support multisampled textures. |
| 163 | // So this is expected to fail. As of 10/5/2020 it actually seems to work to create |
| 164 | // a MSAA BGRA8 renderbuffer (at least in the simulator) but we don't want to rely |
| 165 | // on this undocumented behavior. |
| 166 | continue; |
| 167 | } |
| 168 | REPORTER_ASSERT(reporter, can == SkToBool(surf), "ct: %d, sc: %d, can: %d, surf: %d", |
| 169 | colorType, sampleCnt, can, SkToBool(surf)); |
| 170 | if (surf) { |
Robert Phillips | fa8af0a | 2021-06-03 11:58:43 -0400 | [diff] [blame] | 171 | auto rtp = SkCanvasPriv::TopDeviceTargetProxy(surf->getCanvas()); |
| 172 | int storedCnt = rtp->numSamples(); |
| 173 | const GrBackendFormat& backendFormat = rtp->backendFormat(); |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 174 | int allowedCnt = context->priv().caps()->getRenderTargetSampleCount(storedCnt, |
| 175 | backendFormat); |
| 176 | REPORTER_ASSERT(reporter, storedCnt == allowedCnt, |
| 177 | "Should store an allowed sample count (%d vs %d)", allowedCnt, |
| 178 | storedCnt); |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 179 | } |
Brian Salomon | 93348dd | 2018-08-29 12:56:23 -0400 | [diff] [blame] | 180 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 181 | } |
| 182 | } |
| 183 | |
| 184 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(GrContext_maxSurfaceSamplesForColorType, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 185 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 186 | |
| 187 | static constexpr int kSize = 10; |
| 188 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 189 | for (int ct = 0; ct < kLastEnum_SkColorType; ++ct) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 190 | |
| 191 | SkColorType colorType = static_cast<SkColorType>(ct); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 192 | int maxSampleCnt = context->maxSurfaceSampleCountForColorType(colorType); |
| 193 | if (!maxSampleCnt) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 194 | continue; |
| 195 | } |
Robert Phillips | 429f0d3 | 2019-09-11 17:03:28 -0400 | [diff] [blame] | 196 | if (!context->colorTypeSupportedAsSurface(colorType)) { |
| 197 | continue; |
| 198 | } |
| 199 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 200 | auto info = SkImageInfo::Make(kSize, kSize, colorType, kOpaque_SkAlphaType, nullptr); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 201 | auto surf = sk_gpu_test::MakeBackendTextureSurface( |
| 202 | context, info, kTopLeft_GrSurfaceOrigin, maxSampleCnt); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 203 | if (!surf) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 204 | ERRORF(reporter, "Could not make surface of color type %d.", colorType); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 205 | continue; |
| 206 | } |
Robert Phillips | 5ccb4c1 | 2021-05-24 15:35:08 -0400 | [diff] [blame] | 207 | int sampleCnt = |
| 208 | ((SkSurface_Gpu*)(surf.get()))->getDevice()->targetProxy()->numSamples(); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 209 | REPORTER_ASSERT(reporter, sampleCnt == maxSampleCnt, "Exected: %d, actual: %d", |
| 210 | maxSampleCnt, sampleCnt); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 211 | } |
| 212 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 213 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 214 | static void test_canvas_peek(skiatest::Reporter* reporter, |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 215 | sk_sp<SkSurface>& surface, |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 216 | const SkImageInfo& requestInfo, |
| 217 | bool expectPeekSuccess) { |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 218 | const SkColor color = SK_ColorRED; |
| 219 | const SkPMColor pmcolor = SkPreMultiplyColor(color); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 220 | surface->getCanvas()->clear(color); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 221 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 222 | SkPixmap pmap; |
| 223 | bool success = surface->getCanvas()->peekPixels(&pmap); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 224 | REPORTER_ASSERT(reporter, expectPeekSuccess == success); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 225 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 226 | SkPixmap pmap2; |
| 227 | const void* addr2 = surface->peekPixels(&pmap2) ? pmap2.addr() : nullptr; |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 228 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 229 | if (success) { |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 230 | REPORTER_ASSERT(reporter, requestInfo == pmap.info()); |
| 231 | REPORTER_ASSERT(reporter, requestInfo.minRowBytes() <= pmap.rowBytes()); |
| 232 | REPORTER_ASSERT(reporter, pmcolor == *pmap.addr32()); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 233 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 234 | REPORTER_ASSERT(reporter, pmap.addr() == pmap2.addr()); |
| 235 | REPORTER_ASSERT(reporter, pmap.info() == pmap2.info()); |
| 236 | REPORTER_ASSERT(reporter, pmap.rowBytes() == pmap2.rowBytes()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 237 | } else { |
| 238 | REPORTER_ASSERT(reporter, nullptr == addr2); |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 239 | } |
| 240 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 241 | DEF_TEST(SurfaceCanvasPeek, reporter) { |
| 242 | for (auto& surface_func : { &create_surface, &create_direct_surface }) { |
| 243 | SkImageInfo requestInfo; |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 244 | auto surface(surface_func(kPremul_SkAlphaType, &requestInfo)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 245 | test_canvas_peek(reporter, surface, requestInfo, true); |
| 246 | } |
| 247 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 248 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCanvasPeek_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 249 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
| 250 | SkImageInfo requestInfo; |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 251 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, &requestInfo)); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 252 | test_canvas_peek(reporter, surface, requestInfo, false); |
| 253 | } |
| 254 | } |
commit-bot@chromium.org | c3bd8af | 2014-02-13 17:14:46 +0000 | [diff] [blame] | 255 | |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 256 | static void test_snapshot_alphatype(skiatest::Reporter* reporter, const sk_sp<SkSurface>& surface, |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 257 | SkAlphaType expectedAlphaType) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 258 | REPORTER_ASSERT(reporter, surface); |
| 259 | if (surface) { |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 260 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 261 | REPORTER_ASSERT(reporter, image); |
| 262 | if (image) { |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 263 | REPORTER_ASSERT(reporter, image->alphaType() == expectedAlphaType); |
reed | 41e010c | 2015-06-09 12:16:53 -0700 | [diff] [blame] | 264 | } |
| 265 | } |
| 266 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 267 | DEF_TEST(SurfaceSnapshotAlphaType, reporter) { |
| 268 | for (auto& surface_func : { &create_surface, &create_direct_surface }) { |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 269 | for (auto& at: { kOpaque_SkAlphaType, kPremul_SkAlphaType, kUnpremul_SkAlphaType }) { |
| 270 | auto surface(surface_func(at, nullptr)); |
| 271 | test_snapshot_alphatype(reporter, surface, at); |
bsalomon | 74f681d | 2015-06-23 14:38:48 -0700 | [diff] [blame] | 272 | } |
| 273 | } |
| 274 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 275 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceSnapshotAlphaType_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 276 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 277 | // GPU doesn't support creating unpremul surfaces, so only test opaque + premul |
| 278 | for (auto& at : { kOpaque_SkAlphaType, kPremul_SkAlphaType }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 279 | auto surface(surface_func(ctxInfo.directContext(), at, nullptr)); |
brianosman | 69c166d | 2016-08-17 14:01:05 -0700 | [diff] [blame] | 280 | test_snapshot_alphatype(reporter, surface, at); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 281 | } |
| 282 | } |
| 283 | } |
bsalomon | 74f681d | 2015-06-23 14:38:48 -0700 | [diff] [blame] | 284 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 285 | static void test_backend_texture_access_copy_on_write( |
| 286 | skiatest::Reporter* reporter, SkSurface* surface, SkSurface::BackendHandleAccess access) { |
| 287 | GrBackendTexture tex1 = surface->getBackendTexture(access); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 288 | sk_sp<SkImage> snap1(surface->makeImageSnapshot()); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 289 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 290 | GrBackendTexture tex2 = surface->getBackendTexture(access); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 291 | sk_sp<SkImage> snap2(surface->makeImageSnapshot()); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 292 | |
| 293 | // If the access mode triggers CoW, then the backend objects should reflect it. |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 294 | REPORTER_ASSERT(reporter, GrBackendTexture::TestingOnly_Equals(tex1, tex2) == (snap1 == snap2)); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 295 | } |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 296 | |
| 297 | static void test_backend_rendertarget_access_copy_on_write( |
| 298 | skiatest::Reporter* reporter, SkSurface* surface, SkSurface::BackendHandleAccess access) { |
| 299 | GrBackendRenderTarget rt1 = surface->getBackendRenderTarget(access); |
| 300 | sk_sp<SkImage> snap1(surface->makeImageSnapshot()); |
| 301 | |
| 302 | GrBackendRenderTarget rt2 = surface->getBackendRenderTarget(access); |
| 303 | sk_sp<SkImage> snap2(surface->makeImageSnapshot()); |
| 304 | |
| 305 | // If the access mode triggers CoW, then the backend objects should reflect it. |
| 306 | REPORTER_ASSERT(reporter, GrBackendRenderTarget::TestingOnly_Equals(rt1, rt2) == |
| 307 | (snap1 == snap2)); |
| 308 | } |
| 309 | |
| 310 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendSurfaceAccessCopyOnWrite_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 311 | const SkSurface::BackendHandleAccess accessModes[] = { |
| 312 | SkSurface::kFlushRead_BackendHandleAccess, |
| 313 | SkSurface::kFlushWrite_BackendHandleAccess, |
| 314 | SkSurface::kDiscardWrite_BackendHandleAccess, |
| 315 | }; |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 316 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 317 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 318 | for (auto& accessMode : accessModes) { |
| 319 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 320 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 321 | test_backend_texture_access_copy_on_write(reporter, surface.get(), accessMode); |
| 322 | } |
| 323 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 324 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 325 | test_backend_rendertarget_access_copy_on_write(reporter, surface.get(), accessMode); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 326 | } |
| 327 | } |
| 328 | } |
| 329 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 330 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 331 | template<typename Type, Type(SkSurface::*func)(SkSurface::BackendHandleAccess)> |
| 332 | static void test_backend_unique_id(skiatest::Reporter* reporter, SkSurface* surface) { |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 333 | sk_sp<SkImage> image0(surface->makeImageSnapshot()); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 334 | |
| 335 | Type obj = (surface->*func)(SkSurface::kFlushRead_BackendHandleAccess); |
| 336 | REPORTER_ASSERT(reporter, obj.isValid()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 337 | sk_sp<SkImage> image1(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 338 | // just read access should not affect the snapshot |
| 339 | REPORTER_ASSERT(reporter, image0->uniqueID() == image1->uniqueID()); |
| 340 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 341 | obj = (surface->*func)(SkSurface::kFlushWrite_BackendHandleAccess); |
| 342 | REPORTER_ASSERT(reporter, obj.isValid()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 343 | sk_sp<SkImage> image2(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 344 | // expect a new image, since we claimed we would write |
| 345 | REPORTER_ASSERT(reporter, image0->uniqueID() != image2->uniqueID()); |
| 346 | |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 347 | obj = (surface->*func)(SkSurface::kDiscardWrite_BackendHandleAccess); |
| 348 | REPORTER_ASSERT(reporter, obj.isValid()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 349 | sk_sp<SkImage> image3(surface->makeImageSnapshot()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 350 | // expect a new(er) image, since we claimed we would write |
| 351 | REPORTER_ASSERT(reporter, image0->uniqueID() != image3->uniqueID()); |
| 352 | REPORTER_ASSERT(reporter, image2->uniqueID() != image3->uniqueID()); |
| 353 | } |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 354 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 355 | // No CPU test. |
bsalomon | 68d9134 | 2016-04-12 09:59:58 -0700 | [diff] [blame] | 356 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendHandleAccessIDs_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 357 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 358 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 359 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 360 | test_backend_unique_id<GrBackendTexture, &SkSurface::getBackendTexture>(reporter, |
| 361 | surface.get()); |
| 362 | } |
| 363 | { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 364 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
Robert Phillips | 8caf85f | 2018-04-05 09:30:38 -0400 | [diff] [blame] | 365 | test_backend_unique_id<GrBackendRenderTarget, &SkSurface::getBackendRenderTarget>( |
| 366 | reporter, surface.get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 367 | } |
| 368 | } |
| 369 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 370 | |
Greg Daniel | 9b6e30b | 2021-03-10 12:45:36 -0500 | [diff] [blame] | 371 | // No CPU test. |
| 372 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceAbandonPostFlush_Gpu, reporter, ctxInfo) { |
| 373 | auto direct = ctxInfo.directContext(); |
| 374 | sk_sp<SkSurface> surface = create_gpu_surface(direct, kPremul_SkAlphaType, nullptr); |
| 375 | if (!surface) { |
| 376 | return; |
| 377 | } |
| 378 | // This flush can put command buffer refs on the GrGpuResource for the surface. |
| 379 | surface->flush(); |
| 380 | direct->abandonContext(); |
| 381 | // We pass the test if we don't hit any asserts or crashes when the ref on the surface goes away |
| 382 | // after we abanonded the context. One thing specifically this checks is to make sure we're |
| 383 | // correctly handling the mix of normal refs and command buffer refs, and correctly deleting |
| 384 | // the object at the right time. |
| 385 | } |
| 386 | |
Greg Daniel | 80ef70e | 2021-03-10 16:17:21 -0500 | [diff] [blame] | 387 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendAccessAbandoned_Gpu, reporter, ctxInfo) { |
| 388 | auto dContext = ctxInfo.directContext(); |
| 389 | sk_sp<SkSurface> surface = create_gpu_surface(dContext, kPremul_SkAlphaType, nullptr); |
| 390 | if (!surface) { |
| 391 | return; |
| 392 | } |
| 393 | |
| 394 | GrBackendRenderTarget beRT = |
| 395 | surface->getBackendRenderTarget(SkSurface::kFlushRead_BackendHandleAccess); |
| 396 | REPORTER_ASSERT(reporter, beRT.isValid()); |
| 397 | GrBackendTexture beTex = |
| 398 | surface->getBackendTexture(SkSurface::kFlushRead_BackendHandleAccess); |
| 399 | REPORTER_ASSERT(reporter, beTex.isValid()); |
| 400 | |
| 401 | surface->flush(); |
| 402 | dContext->abandonContext(); |
| 403 | |
| 404 | // After abandoning the context none of the backend surfaces should be valid. |
| 405 | beRT = surface->getBackendRenderTarget(SkSurface::kFlushRead_BackendHandleAccess); |
| 406 | REPORTER_ASSERT(reporter, !beRT.isValid()); |
| 407 | beTex = surface->getBackendTexture(SkSurface::kFlushRead_BackendHandleAccess); |
| 408 | REPORTER_ASSERT(reporter, !beTex.isValid()); |
| 409 | } |
| 410 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 411 | // Verify that the right canvas commands trigger a copy on write. |
| 412 | static void test_copy_on_write(skiatest::Reporter* reporter, SkSurface* surface) { |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 413 | SkCanvas* canvas = surface->getCanvas(); |
| 414 | |
| 415 | const SkRect testRect = |
| 416 | SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0), |
| 417 | SkIntToScalar(4), SkIntToScalar(5)); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 418 | SkPath testPath; |
| 419 | testPath.addRect(SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0), |
| 420 | SkIntToScalar(2), SkIntToScalar(1))); |
| 421 | |
| 422 | const SkIRect testIRect = SkIRect::MakeXYWH(0, 0, 2, 1); |
| 423 | |
| 424 | SkRegion testRegion; |
| 425 | testRegion.setRect(testIRect); |
| 426 | |
| 427 | |
| 428 | const SkColor testColor = 0x01020304; |
| 429 | const SkPaint testPaint; |
| 430 | const SkPoint testPoints[3] = { |
| 431 | {SkIntToScalar(0), SkIntToScalar(0)}, |
| 432 | {SkIntToScalar(2), SkIntToScalar(1)}, |
| 433 | {SkIntToScalar(0), SkIntToScalar(2)} |
| 434 | }; |
| 435 | const size_t testPointCount = 3; |
| 436 | |
| 437 | SkBitmap testBitmap; |
mike@reedtribe.org | deee496 | 2014-02-13 14:41:43 +0000 | [diff] [blame] | 438 | testBitmap.allocN32Pixels(10, 10); |
robertphillips@google.com | d1ce77d | 2013-10-09 12:51:09 +0000 | [diff] [blame] | 439 | testBitmap.eraseColor(0); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 440 | |
| 441 | SkRRect testRRect; |
| 442 | testRRect.setRectXY(testRect, SK_Scalar1, SK_Scalar1); |
| 443 | |
| 444 | SkString testText("Hello World"); |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 445 | |
| 446 | #define EXPECT_COPY_ON_WRITE(command) \ |
| 447 | { \ |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 448 | sk_sp<SkImage> imageBefore = surface->makeImageSnapshot(); \ |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 449 | sk_sp<SkImage> aur_before(imageBefore); /*NOLINT*/ \ |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 450 | canvas-> command ; \ |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 451 | sk_sp<SkImage> imageAfter = surface->makeImageSnapshot(); \ |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 452 | sk_sp<SkImage> aur_after(imageAfter); /*NOLINT*/ \ |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 453 | REPORTER_ASSERT(reporter, imageBefore != imageAfter); \ |
| 454 | } |
| 455 | |
| 456 | EXPECT_COPY_ON_WRITE(clear(testColor)) |
| 457 | EXPECT_COPY_ON_WRITE(drawPaint(testPaint)) |
| 458 | EXPECT_COPY_ON_WRITE(drawPoints(SkCanvas::kPoints_PointMode, testPointCount, testPoints, \ |
| 459 | testPaint)) |
| 460 | EXPECT_COPY_ON_WRITE(drawOval(testRect, testPaint)) |
| 461 | EXPECT_COPY_ON_WRITE(drawRect(testRect, testPaint)) |
| 462 | EXPECT_COPY_ON_WRITE(drawRRect(testRRect, testPaint)) |
| 463 | EXPECT_COPY_ON_WRITE(drawPath(testPath, testPaint)) |
Mike Reed | 34a0c97 | 2021-01-25 17:49:32 -0500 | [diff] [blame] | 464 | EXPECT_COPY_ON_WRITE(drawImage(testBitmap.asImage(), 0, 0)) |
| 465 | EXPECT_COPY_ON_WRITE(drawImageRect(testBitmap.asImage(), testRect, SkSamplingOptions())) |
Hal Canary | 89a644b | 2019-01-07 09:36:09 -0500 | [diff] [blame] | 466 | EXPECT_COPY_ON_WRITE(drawString(testText, 0, 1, SkFont(), testPaint)) |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 467 | } |
| 468 | DEF_TEST(SurfaceCopyOnWrite, reporter) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 469 | test_copy_on_write(reporter, create_surface().get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 470 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 471 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCopyOnWrite_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 472 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 473 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 474 | test_copy_on_write(reporter, surface.get()); |
fmalita | e263908 | 2015-08-06 07:04:51 -0700 | [diff] [blame] | 475 | } |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 476 | } |
| 477 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 478 | static void test_writable_after_snapshot_release(skiatest::Reporter* reporter, |
| 479 | SkSurface* surface) { |
junov@chromium.org | af05835 | 2013-04-03 15:03:26 +0000 | [diff] [blame] | 480 | // This test succeeds by not triggering an assertion. |
| 481 | // The test verifies that the surface remains writable (usable) after |
| 482 | // acquiring and releasing a snapshot without triggering a copy on write. |
junov@chromium.org | af05835 | 2013-04-03 15:03:26 +0000 | [diff] [blame] | 483 | SkCanvas* canvas = surface->getCanvas(); |
| 484 | canvas->clear(1); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 485 | surface->makeImageSnapshot(); // Create and destroy SkImage |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 486 | canvas->clear(2); // Must not assert internally |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 487 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 488 | DEF_TEST(SurfaceWriteableAfterSnapshotRelease, reporter) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 489 | test_writable_after_snapshot_release(reporter, create_surface().get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 490 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 491 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceWriteableAfterSnapshotRelease_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 492 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 493 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 494 | test_writable_after_snapshot_release(reporter, surface.get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 495 | } |
| 496 | } |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 497 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 498 | static void test_crbug263329(skiatest::Reporter* reporter, |
| 499 | SkSurface* surface1, |
| 500 | SkSurface* surface2) { |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 501 | // This is a regression test for crbug.com/263329 |
| 502 | // Bug was caused by onCopyOnWrite releasing the old surface texture |
| 503 | // back to the scratch texture pool even though the texture is used |
| 504 | // by and active SkImage_Gpu. |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 505 | SkCanvas* canvas1 = surface1->getCanvas(); |
| 506 | SkCanvas* canvas2 = surface2->getCanvas(); |
| 507 | canvas1->clear(1); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 508 | sk_sp<SkImage> image1(surface1->makeImageSnapshot()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 509 | // Trigger copy on write, new backing is a scratch texture |
| 510 | canvas1->clear(2); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 511 | sk_sp<SkImage> image2(surface1->makeImageSnapshot()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 512 | // Trigger copy on write, old backing should not be returned to scratch |
| 513 | // pool because it is held by image2 |
| 514 | canvas1->clear(3); |
| 515 | |
| 516 | canvas2->clear(4); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 517 | sk_sp<SkImage> image3(surface2->makeImageSnapshot()); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 518 | // Trigger copy on write on surface2. The new backing store should not |
| 519 | // be recycling a texture that is held by an existing image. |
| 520 | canvas2->clear(5); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 521 | sk_sp<SkImage> image4(surface2->makeImageSnapshot()); |
Greg Daniel | 7c90211 | 2020-03-06 13:07:10 -0500 | [diff] [blame] | 522 | |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 523 | auto imageProxy = [ctx = surface1->recordingContext()](SkImage* img) { |
| 524 | GrTextureProxy* proxy = sk_gpu_test::GetTextureImageProxy(img, ctx); |
| 525 | SkASSERT(proxy); |
| 526 | return proxy; |
| 527 | }; |
Greg Daniel | 7c90211 | 2020-03-06 13:07:10 -0500 | [diff] [blame] | 528 | |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 529 | REPORTER_ASSERT(reporter, imageProxy(image4.get()) != imageProxy(image3.get())); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 530 | // The following assertion checks crbug.com/263329 |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 531 | REPORTER_ASSERT(reporter, imageProxy(image4.get()) != imageProxy(image2.get())); |
| 532 | REPORTER_ASSERT(reporter, imageProxy(image4.get()) != imageProxy(image1.get())); |
| 533 | REPORTER_ASSERT(reporter, imageProxy(image3.get()) != imageProxy(image2.get())); |
| 534 | REPORTER_ASSERT(reporter, imageProxy(image3.get()) != imageProxy(image1.get())); |
| 535 | REPORTER_ASSERT(reporter, imageProxy(image2.get()) != imageProxy(image1.get())); |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 536 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 537 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCRBug263329_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 538 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 539 | auto surface1(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
| 540 | auto surface2(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 541 | test_crbug263329(reporter, surface1.get(), surface2.get()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 542 | } |
| 543 | } |
commit-bot@chromium.org | 4d24b74 | 2013-07-25 23:29:40 +0000 | [diff] [blame] | 544 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 545 | DEF_TEST(SurfaceGetTexture, reporter) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 546 | auto surface(create_surface()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 547 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 548 | REPORTER_ASSERT(reporter, !as_IB(image)->isTextureBacked()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 549 | surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 550 | REPORTER_ASSERT(reporter, !as_IB(image)->isTextureBacked()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 551 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 552 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfacepeekTexture_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 553 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 554 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 555 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 556 | |
| 557 | REPORTER_ASSERT(reporter, as_IB(image)->isTextureBacked()); |
Robert Phillips | c550995 | 2018-04-04 15:54:55 -0400 | [diff] [blame] | 558 | GrBackendTexture backendTex = image->getBackendTexture(false); |
| 559 | REPORTER_ASSERT(reporter, backendTex.isValid()); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 560 | surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 561 | REPORTER_ASSERT(reporter, as_IB(image)->isTextureBacked()); |
Robert Phillips | c550995 | 2018-04-04 15:54:55 -0400 | [diff] [blame] | 562 | GrBackendTexture backendTex2 = image->getBackendTexture(false); |
| 563 | REPORTER_ASSERT(reporter, GrBackendTexture::TestingOnly_Equals(backendTex, backendTex2)); |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 564 | } |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 565 | } |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 566 | |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 567 | static SkBudgeted is_budgeted(const sk_sp<SkSurface>& surf) { |
| 568 | SkSurface_Gpu* gsurf = (SkSurface_Gpu*)surf.get(); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 569 | |
Robert Phillips | 5ccb4c1 | 2021-05-24 15:35:08 -0400 | [diff] [blame] | 570 | GrRenderTargetProxy* proxy = gsurf->getDevice()->targetProxy(); |
Robert Phillips | 6de9904 | 2017-01-31 11:31:39 -0500 | [diff] [blame] | 571 | return proxy->isBudgeted(); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 572 | } |
| 573 | |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 574 | static SkBudgeted is_budgeted(SkImage* image, GrRecordingContext* rc) { |
| 575 | return sk_gpu_test::GetTextureImageProxy(image, rc)->isBudgeted(); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 576 | } |
| 577 | |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 578 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBudget, reporter, ctxInfo) { |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 579 | SkImageInfo info = SkImageInfo::MakeN32Premul(8,8); |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 580 | GrDirectContext* dContext = ctxInfo.directContext(); |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 581 | for (auto budgeted : { SkBudgeted::kNo, SkBudgeted::kYes }) { |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 582 | auto surface(SkSurface::MakeRenderTarget(dContext, budgeted, info)); |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 583 | SkASSERT(surface); |
| 584 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface)); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 585 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 586 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 587 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 588 | // Initially the image shares a texture with the surface, and the |
| 589 | // the budgets should always match. |
| 590 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface)); |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 591 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(image.get(), dContext)); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 592 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 593 | // Now trigger copy-on-write |
| 594 | surface->getCanvas()->clear(SK_ColorBLUE); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 595 | |
Robert Phillips | ac6b1fa | 2017-03-20 08:38:50 -0400 | [diff] [blame] | 596 | // They don't share a texture anymore but the budgets should still match. |
| 597 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface)); |
Brian Salomon | e666254 | 2021-02-23 10:45:39 -0500 | [diff] [blame] | 598 | REPORTER_ASSERT(reporter, budgeted == is_budgeted(image.get(), dContext)); |
bsalomon | eaaaf0b | 2015-01-23 08:08:04 -0800 | [diff] [blame] | 599 | } |
| 600 | } |
junov@chromium.org | da90474 | 2013-05-01 22:38:16 +0000 | [diff] [blame] | 601 | |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 602 | static void test_no_canvas1(skiatest::Reporter* reporter, |
| 603 | SkSurface* surface, |
| 604 | SkSurface::ContentChangeMode mode) { |
| 605 | // Test passes by not asserting |
| 606 | surface->notifyContentWillChange(mode); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 607 | } |
| 608 | static void test_no_canvas2(skiatest::Reporter* reporter, |
| 609 | SkSurface* surface, |
| 610 | SkSurface::ContentChangeMode mode) { |
junov@chromium.org | acea3ef | 2013-04-16 19:41:09 +0000 | [diff] [blame] | 611 | // Verifies the robustness of SkSurface for handling use cases where calls |
| 612 | // are made before a canvas is created. |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 613 | sk_sp<SkImage> image1 = surface->makeImageSnapshot(); |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 614 | sk_sp<SkImage> aur_image1(image1); // NOLINT(performance-unnecessary-copy-initialization) |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 615 | surface->notifyContentWillChange(mode); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 616 | sk_sp<SkImage> image2 = surface->makeImageSnapshot(); |
John Stiles | 31954bf | 2020-08-07 17:35:54 -0400 | [diff] [blame] | 617 | sk_sp<SkImage> aur_image2(image2); // NOLINT(performance-unnecessary-copy-initialization) |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 618 | REPORTER_ASSERT(reporter, image1 != image2); |
junov@chromium.org | acea3ef | 2013-04-16 19:41:09 +0000 | [diff] [blame] | 619 | } |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 620 | DEF_TEST(SurfaceNoCanvas, reporter) { |
| 621 | SkSurface::ContentChangeMode modes[] = |
| 622 | { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode}; |
| 623 | for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) { |
| 624 | for (auto& mode : modes) { |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 625 | test_func(reporter, create_surface().get(), mode); |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 626 | } |
| 627 | } |
| 628 | } |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 629 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceNoCanvas_Gpu, reporter, ctxInfo) { |
kkinnunen | 179a8f5 | 2015-11-20 13:32:24 -0800 | [diff] [blame] | 630 | SkSurface::ContentChangeMode modes[] = |
| 631 | { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode}; |
| 632 | for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { |
| 633 | for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) { |
| 634 | for (auto& mode : modes) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 635 | auto surface(surface_func(ctxInfo.directContext(), kPremul_SkAlphaType, nullptr)); |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 636 | test_func(reporter, surface.get(), mode); |
bsalomon | e904c09 | 2014-07-17 10:50:59 -0700 | [diff] [blame] | 637 | } |
robertphillips@google.com | 3bddb38 | 2013-11-12 13:51:03 +0000 | [diff] [blame] | 638 | } |
junov@chromium.org | af05835 | 2013-04-03 15:03:26 +0000 | [diff] [blame] | 639 | } |
junov@chromium.org | 995beb6 | 2013-03-28 13:49:22 +0000 | [diff] [blame] | 640 | } |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 641 | |
| 642 | static void check_rowbytes_remain_consistent(SkSurface* surface, skiatest::Reporter* reporter) { |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 643 | SkPixmap surfacePM; |
| 644 | REPORTER_ASSERT(reporter, surface->peekPixels(&surfacePM)); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 645 | |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 646 | sk_sp<SkImage> image(surface->makeImageSnapshot()); |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 647 | SkPixmap pm; |
| 648 | REPORTER_ASSERT(reporter, image->peekPixels(&pm)); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 649 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 650 | REPORTER_ASSERT(reporter, surfacePM.rowBytes() == pm.rowBytes()); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 651 | |
| 652 | // trigger a copy-on-write |
| 653 | surface->getCanvas()->drawPaint(SkPaint()); |
reed | 9ce9d67 | 2016-03-17 10:51:11 -0700 | [diff] [blame] | 654 | sk_sp<SkImage> image2(surface->makeImageSnapshot()); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 655 | REPORTER_ASSERT(reporter, image->uniqueID() != image2->uniqueID()); |
| 656 | |
reed | 6ceeebd | 2016-03-09 14:26:26 -0800 | [diff] [blame] | 657 | SkPixmap pm2; |
| 658 | REPORTER_ASSERT(reporter, image2->peekPixels(&pm2)); |
| 659 | REPORTER_ASSERT(reporter, pm2.rowBytes() == pm.rowBytes()); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 660 | } |
| 661 | |
| 662 | DEF_TEST(surface_rowbytes, reporter) { |
| 663 | const SkImageInfo info = SkImageInfo::MakeN32Premul(100, 100); |
| 664 | |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 665 | auto surf0(SkSurface::MakeRaster(info)); |
| 666 | check_rowbytes_remain_consistent(surf0.get(), reporter); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 667 | |
| 668 | // specify a larger rowbytes |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 669 | auto surf1(SkSurface::MakeRaster(info, 500, nullptr)); |
| 670 | check_rowbytes_remain_consistent(surf1.get(), reporter); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 671 | |
| 672 | // Try some illegal rowByte values |
reed | e8f3062 | 2016-03-23 18:59:25 -0700 | [diff] [blame] | 673 | auto s = SkSurface::MakeRaster(info, 396, nullptr); // needs to be at least 400 |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 674 | REPORTER_ASSERT(reporter, nullptr == s); |
Mike Reed | f0ffb89 | 2017-10-03 14:47:21 -0400 | [diff] [blame] | 675 | s = SkSurface::MakeRaster(info, std::numeric_limits<size_t>::max(), nullptr); |
reed | 9cd016e | 2016-01-30 10:01:06 -0800 | [diff] [blame] | 676 | REPORTER_ASSERT(reporter, nullptr == s); |
| 677 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 678 | |
fmalita | 03912f1 | 2016-07-06 06:22:06 -0700 | [diff] [blame] | 679 | DEF_TEST(surface_raster_zeroinitialized, reporter) { |
| 680 | sk_sp<SkSurface> s(SkSurface::MakeRasterN32Premul(100, 100)); |
| 681 | SkPixmap pixmap; |
| 682 | REPORTER_ASSERT(reporter, s->peekPixels(&pixmap)); |
| 683 | |
| 684 | for (int i = 0; i < pixmap.info().width(); ++i) { |
| 685 | for (int j = 0; j < pixmap.info().height(); ++j) { |
| 686 | REPORTER_ASSERT(reporter, *pixmap.addr32(i, j) == 0); |
| 687 | } |
| 688 | } |
| 689 | } |
| 690 | |
Robert Phillips | effd13f | 2020-07-20 15:00:36 -0400 | [diff] [blame] | 691 | static sk_sp<SkSurface> create_gpu_surface_backend_texture(GrDirectContext* dContext, |
| 692 | int sampleCnt, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 693 | const SkColor4f& color) { |
Michael Ludwig | 72ab346 | 2018-12-10 12:43:36 -0500 | [diff] [blame] | 694 | // On Pixel and Pixel2XL's with Adreno 530 and 540s, setting width and height to 10s reliably |
| 695 | // triggers what appears to be a driver race condition where the 10x10 surface from the |
| 696 | // OverdrawSurface_gpu test is reused(?) for this surface created by the SurfacePartialDraw_gpu |
| 697 | // test. |
| 698 | // |
| 699 | // Immediately after creation of this surface, readback shows the correct initial solid color. |
| 700 | // However, sometime before content is rendered into the upper half of the surface, the driver |
| 701 | // presumably cleans up the OverdrawSurface_gpu's memory which corrupts this color buffer. The |
| 702 | // top half of the surface is fine after the partially-covering rectangle is drawn, but the |
| 703 | // untouched bottom half contains random pixel values that trigger asserts in the |
| 704 | // SurfacePartialDraw_gpu test for no longer matching the initial color. Running the |
| 705 | // SurfacePartialDraw_gpu test without the OverdrawSurface_gpu test completes successfully. |
| 706 | // |
| 707 | // Requesting a much larger backend texture size seems to prevent it from reusing the same |
| 708 | // memory and avoids the issue. |
| 709 | #if defined(SK_BUILD_FOR_SKQP) |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 710 | const int kWidth = 10; |
| 711 | const int kHeight = 10; |
Michael Ludwig | 72ab346 | 2018-12-10 12:43:36 -0500 | [diff] [blame] | 712 | #else |
| 713 | const int kWidth = 100; |
| 714 | const int kHeight = 100; |
| 715 | #endif |
| 716 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 717 | auto surf = sk_gpu_test::MakeBackendTextureSurface(dContext, |
| 718 | {kWidth, kHeight}, |
| 719 | kTopLeft_GrSurfaceOrigin, |
| 720 | sampleCnt, |
| 721 | kRGBA_8888_SkColorType); |
| 722 | if (!surf) { |
Robert Phillips | d21b2a5 | 2017-12-12 13:01:25 -0500 | [diff] [blame] | 723 | return nullptr; |
| 724 | } |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 725 | surf->getCanvas()->clear(color); |
| 726 | return surf; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 727 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 728 | |
Stephen White | fdba6c8 | 2020-05-26 17:00:32 -0400 | [diff] [blame] | 729 | static bool supports_readpixels(const GrCaps* caps, SkSurface* surface) { |
| 730 | auto surfaceGpu = static_cast<SkSurface_Gpu*>(surface); |
Robert Phillips | 5ccb4c1 | 2021-05-24 15:35:08 -0400 | [diff] [blame] | 731 | GrRenderTarget* rt = surfaceGpu->getDevice()->targetProxy()->peekRenderTarget(); |
Stephen White | fdba6c8 | 2020-05-26 17:00:32 -0400 | [diff] [blame] | 732 | if (!rt) { |
| 733 | return false; |
| 734 | } |
| 735 | return caps->surfaceSupportsReadPixels(rt) == GrCaps::SurfaceReadPixelsSupport::kSupported; |
| 736 | } |
| 737 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 738 | static sk_sp<SkSurface> create_gpu_surface_backend_render_target(GrDirectContext* dContext, |
| 739 | int sampleCnt, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 740 | const SkColor4f& color) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 741 | const int kWidth = 10; |
| 742 | const int kHeight = 10; |
Greg Daniel | 7ef28f3 | 2017-04-20 16:41:55 +0000 | [diff] [blame] | 743 | |
Brian Salomon | f9b0042 | 2020-10-08 16:00:14 -0400 | [diff] [blame] | 744 | auto surf = sk_gpu_test::MakeBackendRenderTargetSurface(dContext, |
| 745 | {kWidth, kHeight}, |
| 746 | kTopLeft_GrSurfaceOrigin, |
| 747 | sampleCnt, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 748 | kRGBA_8888_SkColorType); |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 749 | if (!surf) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 750 | return nullptr; |
| 751 | } |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 752 | surf->getCanvas()->clear(color); |
| 753 | return surf; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 754 | } |
| 755 | |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 756 | static void test_surface_context_clear(skiatest::Reporter* reporter, |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 757 | GrDirectContext* dContext, |
Robert Phillips | 53eaa64 | 2021-08-10 13:49:51 -0400 | [diff] [blame] | 758 | skgpu::SurfaceContext* surfaceContext, |
Robert Phillips | 04f22ea | 2021-07-22 15:11:03 -0400 | [diff] [blame] | 759 | uint32_t expectedValue) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 760 | int w = surfaceContext->width(); |
| 761 | int h = surfaceContext->height(); |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 762 | |
| 763 | SkImageInfo ii = SkImageInfo::Make(w, h, kRGBA_8888_SkColorType, kPremul_SkAlphaType); |
| 764 | |
| 765 | SkAutoPixmapStorage readback; |
| 766 | readback.alloc(ii); |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 767 | |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 768 | readback.erase(~expectedValue); |
Brian Salomon | dd4087d | 2020-12-23 20:36:44 -0500 | [diff] [blame] | 769 | surfaceContext->readPixels(dContext, readback, {0, 0}); |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 770 | for (int y = 0; y < h; ++y) { |
| 771 | for (int x = 0; x < w; ++x) { |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 772 | uint32_t pixel = readback.addr32()[y * w + x]; |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 773 | if (pixel != expectedValue) { |
| 774 | SkString msg; |
| 775 | if (expectedValue) { |
| 776 | msg = "SkSurface should have left render target unmodified"; |
| 777 | } else { |
| 778 | msg = "SkSurface should have cleared the render target"; |
| 779 | } |
| 780 | ERRORF(reporter, |
| 781 | "%s but read 0x%08x (instead of 0x%08x) at %x,%d", msg.c_str(), pixel, |
| 782 | expectedValue, x, y); |
| 783 | return; |
| 784 | } |
| 785 | } |
| 786 | } |
| 787 | } |
| 788 | |
bsalomon | 758586c | 2016-04-06 14:02:39 -0700 | [diff] [blame] | 789 | DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceClear_Gpu, reporter, ctxInfo) { |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 790 | auto dContext = ctxInfo.directContext(); |
Robert Phillips | 53eaa64 | 2021-08-10 13:49:51 -0400 | [diff] [blame] | 791 | // Snaps an image from a surface and then makes a SurfaceContext from the image's texture. |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 792 | auto makeImageSurfaceContext = [dContext](SkSurface* surface) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 793 | sk_sp<SkImage> i(surface->makeImageSnapshot()); |
Brian Salomon | d0924f3 | 2021-02-03 10:15:31 -0500 | [diff] [blame] | 794 | auto gpuImage = static_cast<SkImage_Gpu*>(as_IB(i)); |
| 795 | auto [view, ct] = gpuImage->asView(dContext, GrMipmapped::kNo); |
| 796 | GrColorInfo colorInfo(ct, i->alphaType(), i->refColorSpace()); |
Robert Phillips | 33bf2b5 | 2021-08-02 11:14:38 -0400 | [diff] [blame] | 797 | return dContext->priv().makeSC(view, std::move(colorInfo)); |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 798 | }; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 799 | |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 800 | // Test that non-wrapped RTs are created clear. |
| 801 | for (auto& surface_func : {&create_gpu_surface, &create_gpu_scratch_surface}) { |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 802 | auto surface = surface_func(dContext, kPremul_SkAlphaType, nullptr); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 803 | if (!surface) { |
| 804 | ERRORF(reporter, "Could not create GPU SkSurface."); |
| 805 | return; |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 806 | } |
Robert Phillips | 04f22ea | 2021-07-22 15:11:03 -0400 | [diff] [blame] | 807 | auto sfc = SkCanvasPriv::TopDeviceSurfaceFillContext(surface->getCanvas()); |
| 808 | if (!sfc) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 809 | ERRORF(reporter, "Could access surface context of GPU SkSurface."); |
| 810 | return; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 811 | } |
Robert Phillips | 04f22ea | 2021-07-22 15:11:03 -0400 | [diff] [blame] | 812 | test_surface_context_clear(reporter, dContext, sfc, 0x0); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 813 | auto imageSurfaceCtx = makeImageSurfaceContext(surface.get()); |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 814 | test_surface_context_clear(reporter, dContext, imageSurfaceCtx.get(), 0x0); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 815 | } |
| 816 | |
| 817 | // Wrapped RTs are *not* supposed to clear (to allow client to partially update a surface). |
| 818 | const SkColor4f kOrigColor{.67f, .67f, .67f, 1}; |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 819 | for (auto& surfaceFunc : |
| 820 | {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_render_target}) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 821 | auto surface = surfaceFunc(dContext, 1, kOrigColor); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 822 | if (!surface) { |
| 823 | ERRORF(reporter, "Could not create GPU SkSurface."); |
| 824 | return; |
| 825 | } |
Robert Phillips | 04f22ea | 2021-07-22 15:11:03 -0400 | [diff] [blame] | 826 | auto sfc = SkCanvasPriv::TopDeviceSurfaceFillContext(surface->getCanvas()); |
| 827 | if (!sfc) { |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 828 | ERRORF(reporter, "Could access surface context of GPU SkSurface."); |
| 829 | return; |
| 830 | } |
Robert Phillips | 04f22ea | 2021-07-22 15:11:03 -0400 | [diff] [blame] | 831 | test_surface_context_clear(reporter, dContext, sfc, kOrigColor.toSkColor()); |
Brian Salomon | bf6b979 | 2019-08-21 09:38:10 -0400 | [diff] [blame] | 832 | auto imageSurfaceCtx = makeImageSurfaceContext(surface.get()); |
Adlai Holler | c95b589 | 2020-08-11 12:02:22 -0400 | [diff] [blame] | 833 | test_surface_context_clear(reporter, dContext, imageSurfaceCtx.get(), |
| 834 | kOrigColor.toSkColor()); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 835 | } |
| 836 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 837 | |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 838 | static void test_surface_draw_partially( |
Robert Phillips | 6694440 | 2019-09-30 13:21:25 -0400 | [diff] [blame] | 839 | skiatest::Reporter* reporter, sk_sp<SkSurface> surface, SkColor origColor) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 840 | const int kW = surface->width(); |
| 841 | const int kH = surface->height(); |
| 842 | SkPaint paint; |
| 843 | const SkColor kRectColor = ~origColor | 0xFF000000; |
| 844 | paint.setColor(kRectColor); |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 845 | surface->getCanvas()->drawRect(SkRect::MakeIWH(kW, kH/2), paint); |
| 846 | |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 847 | // Read back RGBA to avoid format conversions that may not be supported on all platforms. |
| 848 | SkImageInfo readInfo = SkImageInfo::Make(kW, kH, kRGBA_8888_SkColorType, kPremul_SkAlphaType); |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 849 | |
| 850 | SkAutoPixmapStorage readback; |
| 851 | readback.alloc(readInfo); |
| 852 | |
| 853 | readback.erase(~origColor); |
Stephen White | dbb3e1d | 2020-05-13 17:55:18 -0400 | [diff] [blame] | 854 | REPORTER_ASSERT(reporter, surface->readPixels(readback.info(), readback.writable_addr(), |
| 855 | readback.rowBytes(), 0, 0)); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 856 | bool stop = false; |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 857 | |
Robert Phillips | 6694440 | 2019-09-30 13:21:25 -0400 | [diff] [blame] | 858 | SkPMColor origColorPM = SkPackARGB_as_RGBA(SkColorGetA(origColor), |
| 859 | SkColorGetR(origColor), |
| 860 | SkColorGetG(origColor), |
| 861 | SkColorGetB(origColor)); |
| 862 | SkPMColor rectColorPM = SkPackARGB_as_RGBA(SkColorGetA(kRectColor), |
| 863 | SkColorGetR(kRectColor), |
| 864 | SkColorGetG(kRectColor), |
| 865 | SkColorGetB(kRectColor)); |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 866 | |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 867 | for (int y = 0; y < kH/2 && !stop; ++y) { |
| 868 | for (int x = 0; x < kW && !stop; ++x) { |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 869 | REPORTER_ASSERT(reporter, rectColorPM == readback.addr32()[x + y * kW]); |
| 870 | if (rectColorPM != readback.addr32()[x + y * kW]) { |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 871 | SkDebugf("--- got [%x] expected [%x], x = %d, y = %d\n", |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 872 | readback.addr32()[x + y * kW], rectColorPM, x, y); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 873 | stop = true; |
| 874 | } |
| 875 | } |
| 876 | } |
| 877 | stop = false; |
| 878 | for (int y = kH/2; y < kH && !stop; ++y) { |
| 879 | for (int x = 0; x < kW && !stop; ++x) { |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 880 | REPORTER_ASSERT(reporter, origColorPM == readback.addr32()[x + y * kW]); |
| 881 | if (origColorPM != readback.addr32()[x + y * kW]) { |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 882 | SkDebugf("--- got [%x] expected [%x], x = %d, y = %d\n", |
Robert Phillips | d344284 | 2019-08-02 12:26:22 -0400 | [diff] [blame] | 883 | readback.addr32()[x + y * kW], origColorPM, x, y); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 884 | stop = true; |
| 885 | } |
| 886 | } |
| 887 | } |
| 888 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 889 | |
egdaniel | ab527a5 | 2016-06-28 08:07:26 -0700 | [diff] [blame] | 890 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfacePartialDraw_Gpu, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 891 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 892 | |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 893 | static const SkColor4f kOrigColor { 0.667f, 0.733f, 0.8f, 1 }; |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 894 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 895 | for (auto& surfaceFunc : |
| 896 | {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_render_target}) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 897 | // Validate that we can draw to the canvas and that the original texture color is |
| 898 | // preserved in pixels that aren't rendered to via the surface. |
| 899 | // This works only for non-multisampled case. |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 900 | auto surface = surfaceFunc(context, 1, kOrigColor); |
| 901 | if (surface && supports_readpixels(context->priv().caps(), surface.get())) { |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 902 | test_surface_draw_partially(reporter, surface, kOrigColor.toSkColor()); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 903 | } |
| 904 | } |
| 905 | } |
| 906 | |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 907 | struct ReleaseChecker { |
| 908 | ReleaseChecker() : fReleaseCount(0) {} |
| 909 | int fReleaseCount; |
| 910 | static void Release(void* self) { |
| 911 | static_cast<ReleaseChecker*>(self)->fReleaseCount++; |
| 912 | } |
| 913 | }; |
| 914 | |
| 915 | |
| 916 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceWrappedWithRelease_Gpu, reporter, ctxInfo) { |
| 917 | const int kWidth = 10; |
| 918 | const int kHeight = 10; |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 919 | |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 920 | auto ctx = ctxInfo.directContext(); |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 921 | GrGpu* gpu = ctx->priv().getGpu(); |
| 922 | |
| 923 | for (bool useTexture : {false, true}) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 924 | sk_sp<sk_gpu_test::ManagedBackendTexture> mbet; |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 925 | GrBackendRenderTarget backendRT; |
| 926 | sk_sp<SkSurface> surface; |
| 927 | |
| 928 | ReleaseChecker releaseChecker; |
| 929 | GrSurfaceOrigin texOrigin = kBottomLeft_GrSurfaceOrigin; |
| 930 | |
| 931 | if (useTexture) { |
Robert Phillips | ee5fd13 | 2019-05-07 13:29:22 -0400 | [diff] [blame] | 932 | SkImageInfo ii = SkImageInfo::Make(kWidth, kHeight, SkColorType::kRGBA_8888_SkColorType, |
| 933 | kPremul_SkAlphaType); |
Brian Salomon | 7d2757f | 2021-01-26 17:46:50 -0500 | [diff] [blame] | 934 | mbet = sk_gpu_test::ManagedBackendTexture::MakeFromInfo(ctx, ii, GrMipmapped::kNo, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 935 | GrRenderable::kYes); |
| 936 | if (!mbet) { |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 937 | continue; |
| 938 | } |
| 939 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 940 | surface = SkSurface::MakeFromBackendTexture( |
| 941 | ctx, |
| 942 | mbet->texture(), |
| 943 | texOrigin, |
| 944 | /*sample count*/ 1, |
| 945 | kRGBA_8888_SkColorType, |
| 946 | /*color space*/ nullptr, |
| 947 | /*surface props*/ nullptr, |
| 948 | sk_gpu_test::ManagedBackendTexture::ReleaseProc, |
| 949 | mbet->releaseContext(ReleaseChecker::Release, &releaseChecker)); |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 950 | } else { |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 951 | backendRT = gpu->createTestingOnlyBackendRenderTarget({kWidth, kHeight}, |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 952 | GrColorType::kRGBA_8888); |
| 953 | if (!backendRT.isValid()) { |
| 954 | continue; |
| 955 | } |
| 956 | surface = SkSurface::MakeFromBackendRenderTarget(ctx, backendRT, texOrigin, |
| 957 | kRGBA_8888_SkColorType, |
| 958 | nullptr, nullptr, |
| 959 | ReleaseChecker::Release, |
| 960 | &releaseChecker); |
| 961 | } |
| 962 | if (!surface) { |
| 963 | ERRORF(reporter, "Failed to create surface"); |
| 964 | continue; |
| 965 | } |
| 966 | |
| 967 | surface->getCanvas()->clear(SK_ColorRED); |
Greg Daniel | ce9f016 | 2020-06-30 13:42:46 -0400 | [diff] [blame] | 968 | surface->flush(); |
Greg Daniel | 0a2464f | 2020-05-14 15:45:44 -0400 | [diff] [blame] | 969 | ctx->submit(true); |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 970 | |
| 971 | // Now exercise the release proc |
| 972 | REPORTER_ASSERT(reporter, 0 == releaseChecker.fReleaseCount); |
| 973 | surface.reset(nullptr); // force a release of the surface |
| 974 | REPORTER_ASSERT(reporter, 1 == releaseChecker.fReleaseCount); |
| 975 | |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 976 | if (!useTexture) { |
Greg Daniel | 8ce7991 | 2019-02-05 10:08:43 -0500 | [diff] [blame] | 977 | gpu->deleteTestingOnlyBackendRenderTarget(backendRT); |
| 978 | } |
| 979 | } |
| 980 | } |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 981 | |
| 982 | DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceAttachStencil_Gpu, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 983 | auto context = ctxInfo.directContext(); |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 984 | const GrCaps* caps = context->priv().caps(); |
| 985 | |
| 986 | if (caps->avoidStencilBuffers()) { |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 987 | return; |
| 988 | } |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 989 | |
Robert Phillips | 4d87b2b | 2019-07-23 13:44:16 -0400 | [diff] [blame] | 990 | static const SkColor4f kOrigColor { 0.667f, 0.733f, 0.8f, 1 }; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 991 | |
Robert Phillips | 9b16f81 | 2019-05-17 10:01:21 -0400 | [diff] [blame] | 992 | auto resourceProvider = context->priv().resourceProvider(); |
Robert Phillips | 6be756b | 2018-01-16 15:07:54 -0500 | [diff] [blame] | 993 | |
Brian Salomon | 72c7b98 | 2020-10-06 10:07:38 -0400 | [diff] [blame] | 994 | for (auto& surfaceFunc : |
| 995 | {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_render_target}) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 996 | for (int sampleCnt : {1, 4, 8}) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 997 | auto surface = surfaceFunc(context, sampleCnt, kOrigColor); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 998 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 999 | if (!surface && sampleCnt > 1) { |
Robert Phillips | d21b2a5 | 2017-12-12 13:01:25 -0500 | [diff] [blame] | 1000 | // Certain platforms don't support MSAA, skip these. |
| 1001 | continue; |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 1002 | } |
| 1003 | |
| 1004 | // Validate that we can attach a stencil buffer to an SkSurface created by either of |
| 1005 | // our surface functions. |
Robert Phillips | fa8af0a | 2021-06-03 11:58:43 -0400 | [diff] [blame] | 1006 | auto rtp = SkCanvasPriv::TopDeviceTargetProxy(surface->getCanvas()); |
| 1007 | GrRenderTarget* rt = rtp->peekRenderTarget(); |
Chris Dalton | e0fe23a | 2021-04-23 13:11:44 -0600 | [diff] [blame] | 1008 | REPORTER_ASSERT(reporter, |
| 1009 | resourceProvider->attachStencilAttachment(rt, rt->numSamples() > 1)); |
ericrk | c402518 | 2016-05-04 12:01:58 -0700 | [diff] [blame] | 1010 | } |
bsalomon | e63ffef | 2016-02-05 07:17:34 -0800 | [diff] [blame] | 1011 | } |
| 1012 | } |
brianosman | 0e22eb8 | 2016-08-30 07:07:59 -0700 | [diff] [blame] | 1013 | |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1014 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(ReplaceSurfaceBackendTexture, reporter, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 1015 | auto context = ctxInfo.directContext(); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1016 | |
| 1017 | for (int sampleCnt : {1, 2}) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1018 | auto ii = SkImageInfo::Make(10, 10, kRGBA_8888_SkColorType, kPremul_SkAlphaType, nullptr); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1019 | auto mbet1 = sk_gpu_test::ManagedBackendTexture::MakeFromInfo( |
| 1020 | context, ii, GrMipmapped::kNo, GrRenderable::kYes); |
| 1021 | if (!mbet1) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1022 | continue; |
| 1023 | } |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1024 | auto mbet2 = sk_gpu_test::ManagedBackendTexture::MakeFromInfo( |
| 1025 | context, ii, GrMipmapped::kNo, GrRenderable::kYes); |
| 1026 | if (!mbet2) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1027 | ERRORF(reporter, "Expected to be able to make second texture"); |
| 1028 | continue; |
| 1029 | } |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1030 | auto ii2 = ii.makeWH(8, 8); |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1031 | auto mbet3 = sk_gpu_test::ManagedBackendTexture::MakeFromInfo( |
| 1032 | context, ii2, GrMipmapped::kNo, GrRenderable::kYes); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1033 | GrBackendTexture backendTexture3; |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1034 | if (!mbet3) { |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1035 | ERRORF(reporter, "Couldn't create different sized texture."); |
| 1036 | continue; |
| 1037 | } |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1038 | |
| 1039 | auto surf = SkSurface::MakeFromBackendTexture( |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1040 | context, mbet1->texture(), kTopLeft_GrSurfaceOrigin, sampleCnt, |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1041 | kRGBA_8888_SkColorType, ii.refColorSpace(), nullptr); |
| 1042 | if (!surf) { |
| 1043 | continue; |
| 1044 | } |
| 1045 | surf->getCanvas()->clear(SK_ColorBLUE); |
| 1046 | // Change matrix, layer, and clip state before swapping out the backing texture. |
| 1047 | surf->getCanvas()->translate(5, 5); |
| 1048 | surf->getCanvas()->saveLayer(nullptr, nullptr); |
| 1049 | surf->getCanvas()->clipRect(SkRect::MakeXYWH(0, 0, 1, 1)); |
| 1050 | // switch origin while we're at it. |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1051 | bool replaced = surf->replaceBackendTexture(mbet2->texture(), kBottomLeft_GrSurfaceOrigin); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1052 | REPORTER_ASSERT(reporter, replaced); |
| 1053 | SkPaint paint; |
| 1054 | paint.setColor(SK_ColorRED); |
| 1055 | surf->getCanvas()->drawRect(SkRect::MakeWH(5, 5), paint); |
| 1056 | surf->getCanvas()->restore(); |
| 1057 | |
| 1058 | // Check that the replacement texture got the right color values. |
| 1059 | SkAutoPixmapStorage pm; |
| 1060 | pm.alloc(ii); |
| 1061 | bool bad = !surf->readPixels(pm, 0, 0); |
| 1062 | REPORTER_ASSERT(reporter, !bad, "Could not read surface."); |
| 1063 | for (int y = 0; y < ii.height() && !bad; ++y) { |
| 1064 | for (int x = 0; x < ii.width() && !bad; ++x) { |
| 1065 | auto expected = (x == 5 && y == 5) ? 0xFF0000FF : 0xFFFF0000; |
| 1066 | auto found = *pm.addr32(x, y); |
| 1067 | if (found != expected) { |
| 1068 | bad = true; |
| 1069 | ERRORF(reporter, "Expected color 0x%08x, found color 0x%08x at %d, %d.", |
| 1070 | expected, found, x, y); |
| 1071 | } |
| 1072 | } |
| 1073 | } |
| 1074 | // The original texture should still be all blue. |
| 1075 | surf = SkSurface::MakeFromBackendTexture( |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1076 | context, mbet1->texture(), kBottomLeft_GrSurfaceOrigin, sampleCnt, |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1077 | kRGBA_8888_SkColorType, ii.refColorSpace(), nullptr); |
| 1078 | if (!surf) { |
| 1079 | ERRORF(reporter, "Could not create second surface."); |
| 1080 | continue; |
| 1081 | } |
| 1082 | bad = !surf->readPixels(pm, 0, 0); |
| 1083 | REPORTER_ASSERT(reporter, !bad, "Could not read second surface."); |
| 1084 | for (int y = 0; y < ii.height() && !bad; ++y) { |
| 1085 | for (int x = 0; x < ii.width() && !bad; ++x) { |
| 1086 | auto expected = 0xFFFF0000; |
| 1087 | auto found = *pm.addr32(x, y); |
| 1088 | if (found != expected) { |
| 1089 | bad = true; |
| 1090 | ERRORF(reporter, "Expected color 0x%08x, found color 0x%08x at %d, %d.", |
| 1091 | expected, found, x, y); |
| 1092 | } |
| 1093 | } |
| 1094 | } |
| 1095 | |
| 1096 | // Can't replace with the same texture |
| 1097 | REPORTER_ASSERT(reporter, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1098 | !surf->replaceBackendTexture(mbet1->texture(), kTopLeft_GrSurfaceOrigin)); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1099 | // Can't replace with invalid texture |
| 1100 | REPORTER_ASSERT(reporter, !surf->replaceBackendTexture({}, kTopLeft_GrSurfaceOrigin)); |
| 1101 | // Can't replace with different size texture. |
| 1102 | REPORTER_ASSERT(reporter, |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1103 | !surf->replaceBackendTexture(mbet3->texture(), kTopLeft_GrSurfaceOrigin)); |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1104 | // Can't replace texture of non-wrapped SkSurface. |
| 1105 | surf = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, ii, sampleCnt, nullptr); |
| 1106 | REPORTER_ASSERT(reporter, surf); |
| 1107 | if (surf) { |
Brian Salomon | 7205080 | 2020-10-12 20:45:06 -0400 | [diff] [blame] | 1108 | REPORTER_ASSERT(reporter, !surf->replaceBackendTexture(mbet1->texture(), |
Brian Salomon | aad8315 | 2019-05-24 10:16:35 -0400 | [diff] [blame] | 1109 | kTopLeft_GrSurfaceOrigin)); |
| 1110 | } |
| 1111 | } |
| 1112 | } |
| 1113 | |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1114 | static void test_overdraw_surface(skiatest::Reporter* r, SkSurface* surface) { |
Matt Sarett | e11b614 | 2016-11-28 18:28:07 -0500 | [diff] [blame] | 1115 | SkOverdrawCanvas canvas(surface->getCanvas()); |
| 1116 | canvas.drawPaint(SkPaint()); |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1117 | sk_sp<SkImage> image = surface->makeImageSnapshot(); |
| 1118 | |
| 1119 | SkBitmap bitmap; |
Cary Clark | 4f5a79c | 2018-02-07 15:51:00 -0500 | [diff] [blame] | 1120 | image->asLegacyBitmap(&bitmap); |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1121 | for (int y = 0; y < 10; y++) { |
| 1122 | for (int x = 0; x < 10; x++) { |
| 1123 | REPORTER_ASSERT(r, 1 == SkGetPackedA32(*bitmap.getAddr32(x, y))); |
| 1124 | } |
| 1125 | } |
| 1126 | } |
| 1127 | |
| 1128 | DEF_TEST(OverdrawSurface_Raster, r) { |
| 1129 | sk_sp<SkSurface> surface = create_surface(); |
| 1130 | test_overdraw_surface(r, surface.get()); |
| 1131 | } |
| 1132 | |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1133 | DEF_GPUTEST_FOR_RENDERING_CONTEXTS(OverdrawSurface_Gpu, r, ctxInfo) { |
Robert Phillips | 6d344c3 | 2020-07-06 10:56:46 -0400 | [diff] [blame] | 1134 | auto context = ctxInfo.directContext(); |
Matt Sarett | 22886c4 | 2016-11-22 11:31:41 -0500 | [diff] [blame] | 1135 | sk_sp<SkSurface> surface = create_gpu_surface(context); |
| 1136 | test_overdraw_surface(r, surface.get()); |
| 1137 | } |
Mike Reed | 44d04bd | 2017-06-28 19:57:21 -0400 | [diff] [blame] | 1138 | |
| 1139 | DEF_TEST(Surface_null, r) { |
| 1140 | REPORTER_ASSERT(r, SkSurface::MakeNull(0, 0) == nullptr); |
| 1141 | |
| 1142 | const int w = 37; |
| 1143 | const int h = 1000; |
| 1144 | auto surf = SkSurface::MakeNull(w, h); |
| 1145 | auto canvas = surf->getCanvas(); |
| 1146 | |
| 1147 | canvas->drawPaint(SkPaint()); // should not crash, but don't expect anything to draw |
| 1148 | REPORTER_ASSERT(r, surf->makeImageSnapshot() == nullptr); |
| 1149 | } |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1150 | |
| 1151 | // assert: if a given imageinfo is valid for a surface, then it must be valid for an image |
| 1152 | // (so the snapshot can succeed) |
| 1153 | DEF_TEST(surface_image_unity, reporter) { |
| 1154 | auto do_test = [reporter](const SkImageInfo& info) { |
| 1155 | size_t rowBytes = info.minRowBytes(); |
| 1156 | auto surf = SkSurface::MakeRaster(info, rowBytes, nullptr); |
| 1157 | if (surf) { |
| 1158 | auto img = surf->makeImageSnapshot(); |
| 1159 | if (!img && false) { // change to true to document the differences |
| 1160 | SkDebugf("image failed: [%08X %08X] %14s %s\n", |
Mike Klein | ea3f014 | 2019-03-20 11:12:10 -0500 | [diff] [blame] | 1161 | info.width(), |
| 1162 | info.height(), |
| 1163 | ToolUtils::colortype_name(info.colorType()), |
| 1164 | ToolUtils::alphatype_name(info.alphaType())); |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1165 | return; |
| 1166 | } |
| 1167 | REPORTER_ASSERT(reporter, img != nullptr); |
| 1168 | |
Kevin Lubick | be03ef1 | 2021-06-16 15:28:00 -0400 | [diff] [blame] | 1169 | char tempPixel = 0; // just need a valid address (not a valid size) |
| 1170 | SkPixmap pmap = { info, &tempPixel, rowBytes }; |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1171 | img = SkImage::MakeFromRaster(pmap, nullptr, nullptr); |
| 1172 | REPORTER_ASSERT(reporter, img != nullptr); |
| 1173 | } |
| 1174 | }; |
| 1175 | |
Mike Klein | e978ca2 | 2018-10-29 11:29:58 -0400 | [diff] [blame] | 1176 | const int32_t sizes[] = { -1, 0, 1, 1 << 18 }; |
Mike Klein | 30dc8f9 | 2018-02-16 10:08:10 -0500 | [diff] [blame] | 1177 | for (int cti = 0; cti <= kLastEnum_SkColorType; ++cti) { |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1178 | SkColorType ct = static_cast<SkColorType>(cti); |
Mike Klein | 30dc8f9 | 2018-02-16 10:08:10 -0500 | [diff] [blame] | 1179 | for (int ati = 0; ati <= kLastEnum_SkAlphaType; ++ati) { |
Mike Reed | d474698 | 2018-02-07 16:05:29 -0500 | [diff] [blame] | 1180 | SkAlphaType at = static_cast<SkAlphaType>(ati); |
| 1181 | for (int32_t size : sizes) { |
| 1182 | do_test(SkImageInfo::Make(1, size, ct, at)); |
| 1183 | do_test(SkImageInfo::Make(size, 1, ct, at)); |
| 1184 | } |
| 1185 | } |
| 1186 | } |
| 1187 | } |