blob: 812858434044aef7a7295d6bfc5c70d6fdbd3da5 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <memory>
12#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020015#include "api/audio_codecs/builtin_audio_decoder_factory.h"
16#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070017#include "api/jsep.h"
18#include "api/mediastreaminterface.h"
19#include "api/peerconnectioninterface.h"
Yves Gerey2e00abc2018-10-05 15:39:24 +020020#include "api/umametrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020021#include "api/video_codecs/builtin_video_decoder_factory.h"
22#include "api/video_codecs/builtin_video_encoder_factory.h"
Seth Hampson5b4f0752018-04-02 16:31:36 -070023#include "pc/mediasession.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070024#include "pc/mediastream.h"
25#include "pc/mediastreamtrack.h"
26#include "pc/peerconnectionwrapper.h"
Steve Antone831b8c2018-02-01 12:22:16 -080027#include "pc/sdputils.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070028#include "pc/test/fakeaudiocapturemodule.h"
29#include "pc/test/mockpeerconnectionobservers.h"
30#include "rtc_base/checks.h"
31#include "rtc_base/gunit.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070032#include "rtc_base/refcountedobject.h"
33#include "rtc_base/scoped_ref_ptr.h"
34#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020035#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080036#include "test/gmock.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070037
38// This file contains tests for RTP Media API-related behavior of
39// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
40
Steve Anton9158ef62017-11-27 13:01:52 -080041namespace webrtc {
42
43using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
44using ::testing::ElementsAre;
45using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070046using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070047
Henrik Boström31638672017-11-23 17:48:32 +010048const uint32_t kDefaultTimeout = 10000u;
49
50template <typename MethodFunctor>
51class OnSuccessObserver : public rtc::RefCountedObject<
52 webrtc::SetRemoteDescriptionObserverInterface> {
53 public:
54 explicit OnSuccessObserver(MethodFunctor on_success)
55 : on_success_(std::move(on_success)) {}
56
57 // webrtc::SetRemoteDescriptionObserverInterface implementation.
58 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
59 RTC_CHECK(error.ok());
60 on_success_();
61 }
62
63 private:
64 MethodFunctor on_success_;
65};
66
Steve Anton3172c032018-05-03 15:30:18 -070067class PeerConnectionRtpBaseTest : public testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070068 public:
Steve Anton3172c032018-05-03 15:30:18 -070069 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
70 : sdp_semantics_(sdp_semantics),
71 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080072 CreatePeerConnectionFactory(rtc::Thread::Current(),
73 rtc::Thread::Current(),
74 rtc::Thread::Current(),
75 FakeAudioCaptureModule::Create(),
76 CreateBuiltinAudioEncoderFactory(),
77 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +020078 CreateBuiltinVideoEncoderFactory(),
79 CreateBuiltinVideoDecoderFactory(),
80 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -070081 nullptr /* audio_processing */)) {
82 webrtc::metrics::Reset();
83 }
Henrik Boström933d8b02017-10-10 10:05:16 -070084
Steve Anton9158ef62017-11-27 13:01:52 -080085 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
86 return CreatePeerConnection(RTCConfiguration());
87 }
88
Steve Antone831b8c2018-02-01 12:22:16 -080089 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
90 RTCConfiguration config;
91 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -070092 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -080093 }
94
Steve Anton9158ef62017-11-27 13:01:52 -080095 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
96 RTCConfiguration config;
97 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -070098 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -080099 }
100
101 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
102 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700103 RTCConfiguration modified_config = config;
104 modified_config.sdp_semantics = sdp_semantics_;
105 return CreatePeerConnectionInternal(modified_config);
106 }
107
108 protected:
109 const SdpSemantics sdp_semantics_;
110 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
111
112 private:
113 // Private so that tests don't accidentally bypass the SdpSemantics
114 // adjustment.
115 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
116 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200117 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700118 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
119 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100120 EXPECT_TRUE(pc.get());
121 observer->SetPeerConnectionInterface(pc.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200122 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
123 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700124 }
Steve Anton3172c032018-05-03 15:30:18 -0700125};
Henrik Boström933d8b02017-10-10 10:05:16 -0700126
Steve Anton3172c032018-05-03 15:30:18 -0700127class PeerConnectionRtpTest
128 : public PeerConnectionRtpBaseTest,
129 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700130 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700131 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
132};
133
134class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
135 protected:
136 PeerConnectionRtpTestPlanB()
137 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
138};
139
140class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
141 protected:
142 PeerConnectionRtpTestUnifiedPlan()
143 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700144};
145
Henrik Boström31638672017-11-23 17:48:32 +0100146// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
147// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100148
Steve Anton3172c032018-05-03 15:30:18 -0700149TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700150 auto caller = CreatePeerConnection();
151 auto callee = CreatePeerConnection();
152
Steve Anton3172c032018-05-03 15:30:18 -0700153 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700154 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700155
Henrik Boström31638672017-11-23 17:48:32 +0100156 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700157 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100158 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700159
160 if (sdp_semantics_ == SdpSemantics::kPlanB) {
161 // Since we are not supporting the no stream case with Plan B, there should
162 // be a generated stream, even though we didn't set one with AddTrack.
163 ASSERT_EQ(1u, add_track_event.streams.size());
164 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
165 } else {
166 EXPECT_EQ(0u, add_track_event.streams.size());
167 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700168}
169
Steve Anton3172c032018-05-03 15:30:18 -0700170TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700171 auto caller = CreatePeerConnection();
172 auto callee = CreatePeerConnection();
173
Steve Anton3172c032018-05-03 15:30:18 -0700174 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700175 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700176
Henrik Boström31638672017-11-23 17:48:32 +0100177 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100178 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100179 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700180 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100181 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
182 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700183}
184
Steve Anton3172c032018-05-03 15:30:18 -0700185TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700186 auto caller = CreatePeerConnection();
187 auto callee = CreatePeerConnection();
188
Steve Anton3172c032018-05-03 15:30:18 -0700189 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700190 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100191 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700192 ASSERT_TRUE(
193 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
194
Henrik Boström933d8b02017-10-10 10:05:16 -0700195 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700196 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700197
Henrik Boström31638672017-11-23 17:48:32 +0100198 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700199 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
200 callee->observer()->remove_track_events_);
201}
202
Steve Anton3172c032018-05-03 15:30:18 -0700203TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700204 auto caller = CreatePeerConnection();
205 auto callee = CreatePeerConnection();
206
Steve Anton3172c032018-05-03 15:30:18 -0700207 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700208 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100209 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700210 ASSERT_TRUE(
211 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
212
Henrik Boström933d8b02017-10-10 10:05:16 -0700213 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700214 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700215
Henrik Boström31638672017-11-23 17:48:32 +0100216 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700217 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
218 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700219 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700220}
221
Steve Anton3172c032018-05-03 15:30:18 -0700222TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700223 auto caller = CreatePeerConnection();
224 auto callee = CreatePeerConnection();
225
Seth Hampson845e8782018-03-02 11:34:10 -0800226 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700227 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
228 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700229 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100230 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700231 ASSERT_TRUE(
232 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700233
234 // Remove "audio_track1".
235 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700236 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100237 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700238 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800239 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700240 callee->observer()->add_track_events_[0].receiver},
241 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700242 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
243 ASSERT_TRUE(
244 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700245
246 // Remove "audio_track2".
247 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700248 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100249 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700250 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
251 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700252 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700253}
254
Seth Hampson5b4f0752018-04-02 16:31:36 -0700255// Tests the edge case that if a stream ID changes for a given track that both
256// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700257TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700258 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
259 auto caller = CreatePeerConnection();
260 auto callee = CreatePeerConnection();
261
262 const char kStreamId1[] = "stream1";
263 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700264 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700265 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700266 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
267
268 // Change the stream ID of the sender in the session description.
269 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700270 auto* audio_desc =
271 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700272 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
273 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700274 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700275
276 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
277 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
278 kStreamId2);
279 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
280 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
281 kStreamId1);
282}
283
Steve Anton8b815cd2018-02-16 16:14:42 -0800284// Tests that setting a remote description with sending transceivers will fire
285// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700286// with receive only transceivers will not call OnTrack. One transceiver is
287// created without any stream_ids, while the other is created with multiple
288// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700289TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700290 const std::string kStreamId1 = "video_stream1";
291 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700292 auto caller = CreatePeerConnection();
293 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800294
295 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700296 RtpTransceiverInit video_transceiver_init;
297 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
298 auto video_transceiver =
299 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800300
301 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
302
303 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
304 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
305 EXPECT_EQ(audio_transceiver->mid(),
306 callee->pc()->GetTransceivers()[0]->mid());
307 EXPECT_EQ(video_transceiver->mid(),
308 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700309 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
310 callee->pc()->GetTransceivers()[0]->receiver()->streams();
311 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
312 callee->pc()->GetTransceivers()[1]->receiver()->streams();
313 ASSERT_EQ(0u, audio_streams.size());
314 ASSERT_EQ(2u, video_streams.size());
315 EXPECT_EQ(kStreamId1, video_streams[0]->id());
316 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800317}
318
319// Test that doing additional offer/answer exchanges with no changes to tracks
320// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700321TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
322 auto caller = CreatePeerConnection();
323 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800324
325 caller->AddAudioTrack("audio");
326 callee->AddAudioTrack("audio");
327
328 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
329 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
330 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
331
332 // If caller reoffers with no changes expect no additional OnTrack calls.
333 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
334 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
335 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
336
337 // Also if callee reoffers with no changes expect no additional OnTrack calls.
338 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
339 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
340 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
341}
342
343// Test that OnTrack is called when the transceiver direction changes to send
344// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700345TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
346 auto caller = CreatePeerConnection();
347 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800348
349 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
350 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
351 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
352 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
353 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
354
355 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
356 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
357 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
358 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
359
360 // If the direction changes but it is still receiving on the remote side, then
361 // OnTrack should not be fired again.
362 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
363 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
364 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
365 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
366}
367
368// Test that OnTrack is called twice when a sendrecv call is started, the callee
369// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700370TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
371 auto caller = CreatePeerConnection();
372 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800373
374 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
375
376 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
377 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
378 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
379
380 // Put the call on hold by no longer receiving the track.
381 callee->pc()->GetTransceivers()[0]->SetDirection(
382 RtpTransceiverDirection::kInactive);
383
384 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
385 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
386 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
387
388 // Resume the call by changing the direction to recvonly. This should call
389 // OnTrack again on the callee side.
390 callee->pc()->GetTransceivers()[0]->SetDirection(
391 RtpTransceiverDirection::kRecvOnly);
392
393 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
394 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
395 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
396}
397
Steve Anton3172c032018-05-03 15:30:18 -0700398// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700399// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700400TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700401 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100402 auto caller = CreatePeerConnection();
403 auto callee = CreatePeerConnection();
404
Steve Anton3172c032018-05-03 15:30:18 -0700405 caller->AddAudioTrack("audio_track", {});
406
407 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
408 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
409
410 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700411 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700412}
413
414// Test that setting a remote offer twice with no answer in the middle and the
415// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700416// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700417TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700418 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700419 auto caller = CreatePeerConnection();
420 auto callee = CreatePeerConnection();
421
422 auto sender = caller->AddAudioTrack("audio_track", {});
423
424 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
425 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700426 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700427
428 caller->pc()->RemoveTrack(sender);
429
430 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
431 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700432 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
433}
434
435// Test that changing the direction from receiving to not receiving between
436// setting the remote offer and creating / setting the local answer results in
437// a remove track event when SetLocalDescription is called.
438TEST_F(PeerConnectionRtpTestUnifiedPlan,
439 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
440 auto caller = CreatePeerConnection();
441 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
442 auto callee = CreatePeerConnection();
443 callee->AddAudioTrack("audio_track", {});
444
445 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
446 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700447 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700448
449 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
450 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
451
452 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
453 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
454 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700455}
456
457// These tests examine the state of the peer connection as a result of
458// performing SetRemoteDescription().
459
460TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
461 auto caller = CreatePeerConnection();
462 auto callee = CreatePeerConnection();
463
464 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700465 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100466
467 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
468 auto receiver_added = callee->pc()->GetReceivers()[0];
469 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700470
471 if (sdp_semantics_ == SdpSemantics::kPlanB) {
472 // Since we are not supporting the no stream case with Plan B, there should
473 // be a generated stream, even though we didn't set one with AddTrack.
474 ASSERT_EQ(1u, receiver_added->streams().size());
475 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
476 } else {
477 EXPECT_EQ(0u, receiver_added->streams().size());
478 }
Henrik Boström31638672017-11-23 17:48:32 +0100479}
480
Steve Anton3172c032018-05-03 15:30:18 -0700481TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100482 auto caller = CreatePeerConnection();
483 auto callee = CreatePeerConnection();
484
Steve Anton3172c032018-05-03 15:30:18 -0700485 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700486 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100487
488 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
489 auto receiver_added = callee->pc()->GetReceivers()[0];
490 EXPECT_EQ("audio_track", receiver_added->track()->id());
491 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700492 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100493 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
494}
495
Steve Anton3172c032018-05-03 15:30:18 -0700496TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100497 auto caller = CreatePeerConnection();
498 auto callee = CreatePeerConnection();
499
Steve Anton3172c032018-05-03 15:30:18 -0700500 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100501 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700502 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
503
Henrik Boström31638672017-11-23 17:48:32 +0100504 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
505 auto receiver = callee->pc()->GetReceivers()[0];
506 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700507 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100508
Steve Anton3172c032018-05-03 15:30:18 -0700509 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
510 // With Unified Plan the receiver stays but the transceiver transitions to
511 // inactive.
512 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
513 EXPECT_EQ(RtpTransceiverDirection::kInactive,
514 callee->pc()->GetTransceivers()[0]->current_direction());
515 } else {
516 // With Plan B the receiver is removed.
517 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
518 }
Henrik Boström31638672017-11-23 17:48:32 +0100519}
520
Steve Anton3172c032018-05-03 15:30:18 -0700521TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100522 auto caller = CreatePeerConnection();
523 auto callee = CreatePeerConnection();
524
Steve Anton3172c032018-05-03 15:30:18 -0700525 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100526 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700527 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100528 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
529 auto receiver = callee->pc()->GetReceivers()[0];
530 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700531 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100532
Steve Anton3172c032018-05-03 15:30:18 -0700533 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
534 // With Unified Plan the receiver stays but the transceiver transitions to
535 // inactive.
536 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
537 EXPECT_EQ(RtpTransceiverDirection::kInactive,
538 callee->pc()->GetTransceivers()[0]->current_direction());
539 } else {
540 // With Plan B the receiver is removed.
541 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
542 }
Henrik Boström31638672017-11-23 17:48:32 +0100543}
544
Steve Anton3172c032018-05-03 15:30:18 -0700545TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100546 auto caller = CreatePeerConnection();
547 auto callee = CreatePeerConnection();
548
Seth Hampson845e8782018-03-02 11:34:10 -0800549 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700550 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
551 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
552 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
553 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100554
555 // Remove "audio_track1".
556 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700557 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
558
559 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
560 // With Unified Plan the receiver stays but the transceiver transitions to
561 // inactive.
562 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
563 auto transceiver = callee->pc()->GetTransceivers()[0];
564 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
565 EXPECT_EQ(RtpTransceiverDirection::kInactive,
566 transceiver->current_direction());
567 } else {
568 // With Plan B the receiver is removed.
569 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
570 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
571 }
Henrik Boström31638672017-11-23 17:48:32 +0100572
573 // Remove "audio_track2".
574 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700575 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
576
577 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
578 // With Unified Plan the receiver stays but the transceiver transitions to
579 // inactive.
580 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
581 auto transceiver = callee->pc()->GetTransceivers()[1];
582 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
583 EXPECT_EQ(RtpTransceiverDirection::kInactive,
584 transceiver->current_direction());
585 } else {
586 // With Plan B the receiver is removed.
587 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
588 }
Henrik Boström31638672017-11-23 17:48:32 +0100589}
590
Florent Castelliabe301f2018-06-12 18:33:49 +0200591TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
592 auto caller = CreatePeerConnection();
593 auto callee = CreatePeerConnection();
594 auto sender = caller->AddAudioTrack("audio_track");
595 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
596
597 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
598 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
599
600 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
601 auto receiver = callee->pc()->GetReceivers()[0];
602 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
603}
604
605TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
606 auto caller = CreatePeerConnection();
607 auto callee = CreatePeerConnection();
608 auto sender = caller->AddVideoTrack("video_track");
609 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
610
611 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
612 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
613
614 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
615 auto receiver = callee->pc()->GetReceivers()[0];
616 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
617}
618
Henrik Boström31638672017-11-23 17:48:32 +0100619// Invokes SetRemoteDescription() twice in a row without synchronizing the two
620// calls and examine the state of the peer connection inside the callbacks to
621// ensure that the second call does not occur prematurely, contaminating the
622// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700623TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100624 StatesCorrelateWithSetRemoteDescriptionCall) {
625 auto caller = CreatePeerConnection();
626 auto callee = CreatePeerConnection();
627
Henrik Boström31638672017-11-23 17:48:32 +0100628 // Create SDP for adding a track and for removing it. This will be used in the
629 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700630 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100631 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
632 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
633 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
634
635 // In the first SetRemoteDescription() callback, check that we have a
636 // receiver for the track.
637 auto pc = callee->pc();
638 bool srd1_callback_called = false;
639 auto srd1_callback = [&srd1_callback_called, &pc]() {
640 EXPECT_EQ(pc->GetReceivers().size(), 1u);
641 srd1_callback_called = true;
642 };
643
644 // In the second SetRemoteDescription() callback, check that the receiver has
645 // been removed.
646 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
647 // Instead, the transceiver owning the receiver will become inactive.
648 // https://crbug.com/webrtc/7600
649 bool srd2_callback_called = false;
650 auto srd2_callback = [&srd2_callback_called, &pc]() {
651 EXPECT_TRUE(pc->GetReceivers().empty());
652 srd2_callback_called = true;
653 };
654
655 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
656 // calls. The callbacks verify that the two calls are synchronized, as in, the
657 // effects of the second SetRemoteDescription() call must not have happened by
658 // the time the first callback is invoked. If it has then the receiver that is
659 // added as a result of the first SetRemoteDescription() call will already
660 // have been removed as a result of the second SetRemoteDescription() call
661 // when the first callback is invoked.
662 callee->pc()->SetRemoteDescription(
663 std::move(srd1_sdp),
664 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
665 callee->pc()->SetRemoteDescription(
666 std::move(srd2_sdp),
667 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
668 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
669 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
670}
671
Seth Hampson5897a6e2018-04-03 11:16:33 -0700672// Tests that a remote track is created with the signaled MSIDs when they are
673// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
674// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700675TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
676 auto caller = CreatePeerConnection();
677 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700678 const char kStreamId1[] = "stream1";
679 const char kStreamId2[] = "stream2";
680 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
681 {kStreamId1, kStreamId2});
682
683 auto offer = caller->CreateOfferAndSetAsLocal();
684 // Munge the offer to take out everything but the stream_ids.
685 auto contents = offer->description()->contents();
686 ASSERT_TRUE(!contents.empty());
687 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
688 std::vector<std::string> stream_ids =
689 contents[0].media_description()->streams()[0].stream_ids();
690 contents[0].media_description()->mutable_streams().clear();
691 cricket::StreamParams new_stream;
692 new_stream.set_stream_ids(stream_ids);
693 contents[0].media_description()->AddStream(new_stream);
694
695 // Set the remote description and verify that the streams were added to the
696 // receiver correctly.
697 ASSERT_TRUE(
698 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
699 auto receivers = callee->pc()->GetReceivers();
700 ASSERT_EQ(receivers.size(), 1u);
701 ASSERT_EQ(receivers[0]->streams().size(), 2u);
702 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
703 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
704}
705
Seth Hampson5b4f0752018-04-02 16:31:36 -0700706// Tests that with Unified Plan if the the stream id changes for a track when
707// when setting a new remote description, that the media stream is updated
708// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700709// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
710// test.
711TEST_F(PeerConnectionRtpTestUnifiedPlan,
712 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700713 auto caller = CreatePeerConnection();
714 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700715
716 const char kStreamId1[] = "stream1";
717 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700718 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700719 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700720 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
721
722 // Change the stream id of the sender in the session description.
723 auto offer = caller->CreateOfferAndSetAsLocal();
724 auto contents = offer->description()->contents();
725 ASSERT_EQ(contents.size(), 1u);
726 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
727 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
728 {kStreamId2});
729
Steve Anton0f5400a2018-07-17 14:25:36 -0700730 // Set the remote description and verify that the stream was updated
731 // properly.
732 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700733 auto receivers = callee->pc()->GetReceivers();
734 ASSERT_EQ(receivers.size(), 1u);
735 ASSERT_EQ(receivers[0]->streams().size(), 1u);
736 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
737}
738
739// This tests a regression caught by a downstream client, that occured when
740// applying a remote description with a SessionDescription object that
741// contained StreamParams that didn't have ids. Although there were multiple
742// remote audio senders, FindSenderInfo didn't find them as unique, because
743// it looked up by StreamParam.id, which none had. This meant only one
744// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700745TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700746 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
747 auto caller = CreatePeerConnection();
748 auto callee = CreatePeerConnection();
749
750 const char kStreamId1[] = "stream1";
751 const char kStreamId2[] = "stream2";
752 caller->AddAudioTrack("audio_track1", {kStreamId1});
753 caller->AddAudioTrack("audio_track2", {kStreamId2});
754
755 auto offer = caller->CreateOfferAndSetAsLocal();
756 auto mutable_streams =
757 cricket::GetFirstAudioContentDescription(offer->description())
758 ->mutable_streams();
759 ASSERT_EQ(mutable_streams.size(), 2u);
760 // Clear the IDs in the StreamParams.
761 mutable_streams[0].id.clear();
762 mutable_streams[1].id.clear();
763 ASSERT_TRUE(
764 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
765
766 auto receivers = callee->pc()->GetReceivers();
767 ASSERT_EQ(receivers.size(), 2u);
768 ASSERT_EQ(receivers[0]->streams().size(), 1u);
769 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
770 ASSERT_EQ(receivers[1]->streams().size(), 1u);
771 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
772}
773
Henrik Boström31638672017-11-23 17:48:32 +0100774// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100775
776// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700777TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100778 auto caller = CreatePeerConnection();
779 auto callee = CreatePeerConnection();
780
781 std::string error;
782 ASSERT_TRUE(
783 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
784}
785
786// Verifies legacy behavior: The observer is not called if if the peer
787// connection is destroyed because the asynchronous callback is executed in the
788// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700789TEST_P(PeerConnectionRtpTest,
790 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100791 auto caller = CreatePeerConnection();
792 auto callee = CreatePeerConnection();
793
794 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
795 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
796
797 auto offer = caller->CreateOfferAndSetAsLocal();
798 callee->pc()->SetRemoteDescription(observer, offer.release());
799 callee = nullptr;
800 rtc::Thread::Current()->ProcessMessages(0);
801 EXPECT_FALSE(observer->called());
802}
803
Steve Antonf9381f02017-12-14 10:23:57 -0800804// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800805
806// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700807TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
808 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800809 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
810}
811
812// Test that a transceiver created with the audio kind has the correct initial
813// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700814TEST_F(PeerConnectionRtpTestUnifiedPlan,
815 AddTransceiverHasCorrectInitProperties) {
816 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800817
818 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200819 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800820 EXPECT_FALSE(transceiver->stopped());
821 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200822 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800823}
824
825// Test that adding a transceiver with the audio kind creates an audio sender
826// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700827TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800828 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700829 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800830
831 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800832 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800833
834 ASSERT_TRUE(transceiver->sender());
835 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
836
837 ASSERT_TRUE(transceiver->receiver());
838 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
839
840 auto track = transceiver->receiver()->track();
841 ASSERT_TRUE(track);
842 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
843 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
844}
845
846// Test that adding a transceiver with the video kind creates an video sender
847// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700848TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800849 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700850 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800851
852 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800853 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800854
855 ASSERT_TRUE(transceiver->sender());
856 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
857
858 ASSERT_TRUE(transceiver->receiver());
859 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
860
861 auto track = transceiver->receiver()->track();
862 ASSERT_TRUE(track);
863 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
864 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
865}
866
867// Test that after a call to AddTransceiver, the transceiver shows in
868// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
869// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700870TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
871 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800872
873 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
874 EXPECT_EQ(
875 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
876 caller->pc()->GetTransceivers());
877 EXPECT_EQ(
878 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
879 transceiver->sender()},
880 caller->pc()->GetSenders());
881 EXPECT_EQ(
882 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
883 transceiver->receiver()},
884 caller->pc()->GetReceivers());
885}
886
887// Test that the direction passed in through the AddTransceiver init parameter
888// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700889TEST_F(PeerConnectionRtpTestUnifiedPlan,
890 AddTransceiverWithDirectionIsReflected) {
891 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800892
893 RtpTransceiverInit init;
894 init.direction = RtpTransceiverDirection::kSendOnly;
895 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
896 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
897}
898
Steve Anton9158ef62017-11-27 13:01:52 -0800899// Test that calling AddTransceiver with a track creates a transceiver which has
900// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700901TEST_F(PeerConnectionRtpTestUnifiedPlan,
902 AddTransceiverWithTrackCreatesSenderWithTrack) {
903 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800904
905 auto audio_track = caller->CreateAudioTrack("audio track");
906 auto transceiver = caller->AddTransceiver(audio_track);
907
908 auto sender = transceiver->sender();
909 ASSERT_TRUE(sender->track());
910 EXPECT_EQ(audio_track, sender->track());
911
912 auto receiver = transceiver->receiver();
913 ASSERT_TRUE(receiver->track());
914 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
915 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
916 receiver->track()->state());
917}
918
919// Test that calling AddTransceiver twice with the same track creates distinct
920// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700921TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800922 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700923 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800924
925 auto audio_track = caller->CreateAudioTrack("audio track");
926
927 auto transceiver1 = caller->AddTransceiver(audio_track);
928 auto transceiver2 = caller->AddTransceiver(audio_track);
929
930 EXPECT_NE(transceiver1, transceiver2);
931
932 auto sender1 = transceiver1->sender();
933 auto sender2 = transceiver2->sender();
934 EXPECT_NE(sender1, sender2);
935 EXPECT_EQ(audio_track, sender1->track());
936 EXPECT_EQ(audio_track, sender2->track());
937
938 EXPECT_THAT(caller->pc()->GetTransceivers(),
939 UnorderedElementsAre(transceiver1, transceiver2));
940 EXPECT_THAT(caller->pc()->GetSenders(),
941 UnorderedElementsAre(sender1, sender2));
942}
943
Steve Anton3fe1b152017-12-12 10:20:08 -0800944// RtpTransceiver error handling tests.
945
Steve Anton3172c032018-05-03 15:30:18 -0700946TEST_F(PeerConnectionRtpTestUnifiedPlan,
947 AddTransceiverWithInvalidKindReturnsError) {
948 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800949
950 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
951 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
952}
953
Steve Anton3172c032018-05-03 15:30:18 -0700954TEST_F(PeerConnectionRtpTestUnifiedPlan,
955 CanClosePeerConnectionWithoutCrashing) {
956 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800957
958 caller->pc()->Close();
959}
960
Steve Antonf9381f02017-12-14 10:23:57 -0800961// Unified Plan AddTrack tests.
962
Steve Antonf9381f02017-12-14 10:23:57 -0800963// Test that adding an audio track creates a new audio RtpSender with the given
964// track.
Steve Anton3172c032018-05-03 15:30:18 -0700965TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
966 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800967
968 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800969 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800970 ASSERT_TRUE(sender);
971
972 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
973 EXPECT_EQ(audio_track, sender->track());
974}
975
976// Test that adding a video track creates a new video RtpSender with the given
977// track.
Steve Anton3172c032018-05-03 15:30:18 -0700978TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
979 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800980
981 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800982 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800983 ASSERT_TRUE(sender);
984
985 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
986 EXPECT_EQ(video_track, sender->track());
987}
988
989// Test that adding a track to a new PeerConnection creates an RtpTransceiver
990// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -0700991TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
992 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800993
994 auto sender = caller->AddAudioTrack("a");
995 ASSERT_TRUE(sender);
996
997 auto transceivers = caller->pc()->GetTransceivers();
998 ASSERT_EQ(1u, transceivers.size());
999 EXPECT_EQ(sender, transceivers[0]->sender());
1000 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1001}
1002
1003// Test that if a transceiver of the same type but no track had been added to
1004// the PeerConnection and later a call to AddTrack is made, the resulting sender
1005// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001006TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1007 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001008
1009 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1010 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001011 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001012 ASSERT_TRUE(sender);
1013
1014 auto transceivers = caller->pc()->GetTransceivers();
1015 ASSERT_EQ(1u, transceivers.size());
1016 EXPECT_EQ(transceiver, transceivers[0]);
1017 EXPECT_EQ(sender, transceiver->sender());
1018 EXPECT_EQ(audio_track, sender->track());
1019}
1020
1021// Test that adding two tracks to a new PeerConnection creates two
1022// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001023TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1024 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001025
1026 auto sender1 = caller->AddAudioTrack("a");
1027 auto sender2 = caller->AddVideoTrack("v");
1028 ASSERT_TRUE(sender2);
1029
1030 auto transceivers = caller->pc()->GetTransceivers();
1031 ASSERT_EQ(2u, transceivers.size());
1032 EXPECT_EQ(sender1, transceivers[0]->sender());
1033 EXPECT_EQ(sender2, transceivers[1]->sender());
1034}
1035
1036// Test that if there are multiple transceivers with no sending track then a
1037// later call to AddTrack will use the one of the same type as the newly-added
1038// track.
Steve Anton3172c032018-05-03 15:30:18 -07001039TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1040 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001041
1042 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1043 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1044 auto sender = caller->AddVideoTrack("v");
1045
1046 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1047 EXPECT_NE(sender, audio_transceiver->sender());
1048 EXPECT_EQ(sender, video_transceiver->sender());
1049}
1050
1051// Test that if the only transceivers that do not have a sending track have a
1052// different type from the added track, then AddTrack will create a new
1053// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001054TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001055 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001056 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001057
1058 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1059 auto sender = caller->AddVideoTrack("v");
1060
1061 auto transceivers = caller->pc()->GetTransceivers();
1062 ASSERT_EQ(2u, transceivers.size());
1063 EXPECT_NE(sender, transceivers[0]->sender());
1064 EXPECT_EQ(sender, transceivers[1]->sender());
1065}
1066
1067// Test that the first available transceiver is reused by AddTrack when multiple
1068// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001069TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001070 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001071 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001072
1073 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1074 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1075 auto sender = caller->AddAudioTrack("a");
1076
1077 auto transceivers = caller->pc()->GetTransceivers();
1078 ASSERT_EQ(2u, transceivers.size());
1079 EXPECT_EQ(sender, transceivers[0]->sender());
1080 EXPECT_NE(sender, transceivers[1]->sender());
1081}
1082
1083// Test that a call to AddTrack that reuses a transceiver will change the
1084// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001085TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001086 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001087 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001088
1089 RtpTransceiverInit init;
1090 init.direction = RtpTransceiverDirection::kInactive;
1091 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1092
1093 caller->observer()->clear_negotiation_needed();
1094 ASSERT_TRUE(caller->AddAudioTrack("a"));
1095 EXPECT_TRUE(caller->observer()->negotiation_needed());
1096
1097 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1098}
1099
1100// Test that a call to AddTrack that reuses a transceiver will change the
1101// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001102TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001103 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001104 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001105
1106 RtpTransceiverInit init;
1107 init.direction = RtpTransceiverDirection::kRecvOnly;
1108 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1109
1110 caller->observer()->clear_negotiation_needed();
1111 ASSERT_TRUE(caller->AddAudioTrack("a"));
1112 EXPECT_TRUE(caller->observer()->negotiation_needed());
1113
1114 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1115}
1116
Steve Anton3172c032018-05-03 15:30:18 -07001117TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001118 const std::string kTrackId = "audio_track";
1119
Steve Anton3172c032018-05-03 15:30:18 -07001120 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001121
1122 auto audio_track = caller->CreateAudioTrack(kTrackId);
1123 auto sender = caller->AddTrack(audio_track);
1124
1125 EXPECT_EQ(kTrackId, sender->id());
1126}
1127
Steve Antonf9381f02017-12-14 10:23:57 -08001128// Unified Plan AddTrack error handling.
1129
Steve Anton3172c032018-05-03 15:30:18 -07001130TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1131 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001132
1133 auto audio_track = caller->CreateAudioTrack("a");
1134 caller->pc()->Close();
1135
1136 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001137 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001138 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001139 EXPECT_FALSE(caller->observer()->negotiation_needed());
1140}
1141
Steve Anton3172c032018-05-03 15:30:18 -07001142TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1143 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001144
1145 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001146 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001147
1148 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001149 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001150 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001151 EXPECT_FALSE(caller->observer()->negotiation_needed());
1152}
1153
1154// Unified Plan RemoveTrack tests.
1155
1156// Test that calling RemoveTrack on a sender with a previously-added track
1157// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001158TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1159 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001160
1161 auto sender = caller->AddAudioTrack("a");
1162 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1163
1164 EXPECT_FALSE(sender->track());
1165}
1166
1167// Test that calling RemoveTrack on a sender where the transceiver is configured
1168// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001169TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001170 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001171 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001172
1173 RtpTransceiverInit init;
1174 init.direction = RtpTransceiverDirection::kSendRecv;
1175 auto transceiver =
1176 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1177
1178 caller->observer()->clear_negotiation_needed();
1179 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1180 EXPECT_TRUE(caller->observer()->negotiation_needed());
1181
1182 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
1183 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
1184}
1185
1186// Test that calling RemoveTrack on a sender where the transceiver is configured
1187// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001188TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001189 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001190 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001191
1192 RtpTransceiverInit init;
1193 init.direction = RtpTransceiverDirection::kSendOnly;
1194 auto transceiver =
1195 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1196
1197 caller->observer()->clear_negotiation_needed();
1198 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1199 EXPECT_TRUE(caller->observer()->negotiation_needed());
1200
1201 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1202}
1203
1204// Test that calling RemoveTrack with a sender that has a null track results in
1205// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001206TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1207 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001208
1209 auto sender = caller->AddAudioTrack("a");
1210 auto transceiver = caller->pc()->GetTransceivers()[0];
1211 ASSERT_TRUE(sender->SetTrack(nullptr));
1212
1213 caller->observer()->clear_negotiation_needed();
1214 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1215 EXPECT_FALSE(caller->observer()->negotiation_needed());
1216
1217 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1218}
1219
1220// Unified Plan RemoveTrack error handling.
1221
Steve Anton3172c032018-05-03 15:30:18 -07001222TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1223 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001224
1225 auto sender = caller->AddAudioTrack("a");
1226 caller->pc()->Close();
1227
1228 caller->observer()->clear_negotiation_needed();
1229 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1230 EXPECT_FALSE(caller->observer()->negotiation_needed());
1231}
1232
Steve Anton3172c032018-05-03 15:30:18 -07001233TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001234 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001235 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001236
1237 auto sender = caller->AddAudioTrack("a");
1238 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1239
1240 caller->observer()->clear_negotiation_needed();
1241 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1242 EXPECT_FALSE(caller->observer()->negotiation_needed());
1243}
1244
Steve Anton60b6c1d2018-06-13 11:32:27 -07001245// Test that setting offers that add/remove/add a track repeatedly without
1246// setting the appropriate answer in between works.
1247// These are regression tests for bugs.webrtc.org/9401
1248TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1249 auto caller = CreatePeerConnection();
1250
1251 auto sender1 = caller->AddAudioTrack("audio1");
1252 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1253
1254 caller->pc()->RemoveTrack(sender1);
1255 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1256
1257 // This will re-use the transceiver created by the first AddTrack.
1258 auto sender2 = caller->AddAudioTrack("audio2");
1259 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1260
1261 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1262 EXPECT_EQ(sender1, sender2);
1263}
1264TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1265 auto caller = CreatePeerConnection();
1266
1267 auto sender1 = caller->AddVideoTrack("video1");
1268 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1269
1270 caller->pc()->RemoveTrack(sender1);
1271 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1272
1273 // This will re-use the transceiver created by the first AddTrack.
1274 auto sender2 = caller->AddVideoTrack("video2");
1275 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1276
1277 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1278 EXPECT_EQ(sender1, sender2);
1279}
1280
Steve Anton07563732018-06-26 11:13:50 -07001281// Test that CreateOffer succeeds if two tracks with the same label are added.
1282TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1283 auto caller = CreatePeerConnection();
1284
1285 auto audio_sender = caller->AddAudioTrack("track", {});
1286 auto video_sender = caller->AddVideoTrack("track", {});
1287
1288 EXPECT_TRUE(caller->CreateOffer());
1289
1290 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1291 EXPECT_NE(audio_sender->id(), video_sender->id());
1292}
1293
1294// Test that CreateAnswer succeeds if two tracks with the same label are added.
1295TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1296 auto caller = CreatePeerConnection();
1297 auto callee = CreatePeerConnection();
1298
1299 RtpTransceiverInit recvonly;
1300 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1301 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1302 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1303
1304 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1305
1306 auto audio_sender = callee->AddAudioTrack("track", {});
1307 auto video_sender = callee->AddVideoTrack("track", {});
1308
1309 EXPECT_TRUE(callee->CreateAnswer());
1310
1311 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1312 EXPECT_NE(audio_sender->id(), video_sender->id());
1313}
1314
1315// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1316// m= section with a random sender id (different from the first, now rejected,
1317// m= section).
1318TEST_F(PeerConnectionRtpTestUnifiedPlan,
1319 AddRemoveAddTrackGeneratesNewSenderId) {
1320 auto caller = CreatePeerConnection();
1321 auto callee = CreatePeerConnection();
1322
1323 auto track = caller->CreateVideoTrack("video");
1324 auto sender1 = caller->AddTrack(track);
1325 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1326
1327 caller->pc()->RemoveTrack(sender1);
1328 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1329
1330 auto sender2 = caller->AddTrack(track);
1331
1332 EXPECT_NE(sender1, sender2);
1333 EXPECT_NE(sender1->id(), sender2->id());
1334 std::string sender2_id = sender2->id();
1335
1336 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1337
1338 // The sender's ID should not change after negotiation.
1339 EXPECT_EQ(sender2_id, sender2->id());
1340}
1341
Steve Anton52d86772018-02-20 15:48:12 -08001342// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1343// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001344TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001345 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001346 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001347
1348 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1349
1350 caller->observer()->clear_negotiation_needed();
1351 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1352 EXPECT_TRUE(caller->observer()->negotiation_needed());
1353}
1354
1355// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1356// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001357TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001358 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001359 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001360
1361 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1362
1363 caller->observer()->clear_negotiation_needed();
1364 transceiver->SetDirection(transceiver->direction());
1365 EXPECT_FALSE(caller->observer()->negotiation_needed());
1366}
1367
1368// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1369// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001370TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001371 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001372 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001373
1374 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1375 transceiver->Stop();
1376
1377 caller->observer()->clear_negotiation_needed();
1378 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1379 EXPECT_FALSE(caller->observer()->negotiation_needed());
1380}
1381
Florent Castelli892acf02018-10-01 22:47:20 +02001382// Test that AddTransceiver fails if trying to use simulcast using
1383// send_encodings as it isn't currently supported.
1384TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForUnsupportedSimulcast) {
1385 auto caller = CreatePeerConnection();
1386
1387 RtpTransceiverInit init;
1388 init.send_encodings.emplace_back();
1389 init.send_encodings.emplace_back();
1390 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
1391 EXPECT_EQ(result.error().type(), RTCErrorType::UNSUPPORTED_PARAMETER);
1392}
1393
1394// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1395// parameters with the send_encodings parameters.
1396TEST_F(PeerConnectionRtpTestUnifiedPlan,
1397 CheckForUnsupportedEncodingParameters) {
1398 auto caller = CreatePeerConnection();
1399
1400 RtpTransceiverInit init;
1401 init.send_encodings.emplace_back();
1402
1403 auto default_send_encodings = init.send_encodings;
1404
1405 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
1406 // ptime, scale_resolution_down_by, scale_framerate_down_by, rid,
1407 // dependency_rids.
1408 init.send_encodings[0].ssrc = 1;
1409 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1410 caller->pc()
1411 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1412 .error()
1413 .type());
1414 init.send_encodings = default_send_encodings;
1415
1416 init.send_encodings[0].codec_payload_type = 1;
1417 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1418 caller->pc()
1419 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1420 .error()
1421 .type());
1422 init.send_encodings = default_send_encodings;
1423
1424 init.send_encodings[0].fec = RtpFecParameters();
1425 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1426 caller->pc()
1427 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1428 .error()
1429 .type());
1430 init.send_encodings = default_send_encodings;
1431
1432 init.send_encodings[0].rtx = RtpRtxParameters();
1433 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1434 caller->pc()
1435 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1436 .error()
1437 .type());
1438 init.send_encodings = default_send_encodings;
1439
1440 init.send_encodings[0].dtx = DtxStatus::ENABLED;
1441 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1442 caller->pc()
1443 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1444 .error()
1445 .type());
1446 init.send_encodings = default_send_encodings;
1447
1448 init.send_encodings[0].ptime = 1;
1449 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1450 caller->pc()
1451 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1452 .error()
1453 .type());
1454 init.send_encodings = default_send_encodings;
1455
1456 init.send_encodings[0].scale_resolution_down_by = 2.0;
1457 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1458 caller->pc()
1459 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1460 .error()
1461 .type());
1462 init.send_encodings = default_send_encodings;
1463
1464 init.send_encodings[0].rid = "dummy_rid";
1465 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1466 caller->pc()
1467 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1468 .error()
1469 .type());
1470 init.send_encodings = default_send_encodings;
1471
1472 init.send_encodings[0].dependency_rids.push_back("dummy_rid");
1473 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1474 caller->pc()
1475 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1476 .error()
1477 .type());
1478}
1479
1480// Test that AddTransceiver transfers the send_encodings to the sender and they
1481// are retained after SetLocalDescription().
1482TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1483 auto caller = CreatePeerConnection();
1484
1485 RtpTransceiverInit init;
1486 init.send_encodings.emplace_back();
1487 init.send_encodings[0].active = false;
1488 init.send_encodings[0].max_bitrate_bps = 180000;
1489
1490 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1491 ASSERT_TRUE(result.ok());
1492
1493 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1494 EXPECT_FALSE(init_send_encodings[0].active);
1495 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1496
1497 auto parameters = result.value()->sender()->GetParameters();
1498 EXPECT_FALSE(parameters.encodings[0].active);
1499 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1500
1501 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1502
1503 parameters = result.value()->sender()->GetParameters();
1504 EXPECT_FALSE(parameters.encodings[0].active);
1505 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1506}
1507
Steve Antone831b8c2018-02-01 12:22:16 -08001508// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1509// options for this kind of signaling: media section based (a=msid) and ssrc
1510// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1511// we want to ensure compatibility with older Plan B endpoints that might expect
1512// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1513// types but answers with the same type as the offer.
1514
Steve Anton3172c032018-05-03 15:30:18 -07001515class PeerConnectionMsidSignalingTest
1516 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001517
1518TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1519 auto caller = CreatePeerConnectionWithUnifiedPlan();
1520 caller->AddAudioTrack("caller_audio");
1521 auto callee = CreatePeerConnectionWithUnifiedPlan();
1522 callee->AddAudioTrack("callee_audio");
1523
1524 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1525
1526 // Offer should have had both a=msid and a=ssrc MSID lines.
1527 auto* offer = callee->pc()->remote_description();
1528 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1529 cricket::kMsidSignalingSsrcAttribute),
1530 offer->description()->msid_signaling());
1531
1532 // Answer should have had only a=msid lines.
1533 auto* answer = caller->pc()->remote_description();
1534 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1535 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001536 // Check that this is counted correctly
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001537 EXPECT_EQ(2, webrtc::metrics::NumSamples(
1538 "WebRTC.PeerConnection.SdpSemanticNegotiated"));
1539 EXPECT_EQ(2, webrtc::metrics::NumEvents(
1540 "WebRTC.PeerConnection.SdpSemanticNegotiated",
1541 kSdpSemanticNegotiatedUnifiedPlan));
Steve Antone831b8c2018-02-01 12:22:16 -08001542}
1543
1544TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1545 auto caller = CreatePeerConnectionWithPlanB();
1546 caller->AddAudioTrack("caller_audio");
1547 auto callee = CreatePeerConnectionWithUnifiedPlan();
1548 callee->AddAudioTrack("callee_audio");
1549
1550 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1551
1552 // Offer should have only a=ssrc MSID lines.
1553 auto* offer = callee->pc()->remote_description();
1554 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1555 offer->description()->msid_signaling());
1556
1557 // Answer should have only a=ssrc MSID lines to match the offer.
1558 auto* answer = caller->pc()->remote_description();
1559 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1560 answer->description()->msid_signaling());
1561}
1562
Seth Hampson5b4f0752018-04-02 16:31:36 -07001563// This tests that a Plan B endpoint appropriately sets the remote description
1564// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1565// that signal no stream ids or multiple stream ids we expect that the Plan B
1566// endpoint always has exactly one media stream per track.
1567TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1568 const std::string kStreamId1 = "audio_stream_1";
1569 const std::string kStreamId2 = "audio_stream_2";
1570
1571 auto caller = CreatePeerConnectionWithUnifiedPlan();
1572 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1573 caller->AddVideoTrack("caller_video", {});
1574 auto callee = CreatePeerConnectionWithPlanB();
1575 callee->AddAudioTrack("callee_audio");
1576 caller->AddVideoTrack("callee_video");
1577
1578 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1579
1580 // Offer should have had both a=msid and a=ssrc MSID lines.
1581 auto* offer = callee->pc()->remote_description();
1582 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1583 cricket::kMsidSignalingSsrcAttribute),
1584 offer->description()->msid_signaling());
1585
1586 // Callee should always have 1 stream for all of it's receivers.
1587 const auto& track_events = callee->observer()->add_track_events_;
1588 ASSERT_EQ(2u, track_events.size());
1589 ASSERT_EQ(1u, track_events[0].streams.size());
1590 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1591 ASSERT_EQ(1u, track_events[1].streams.size());
1592 // This autogenerated a stream id for the empty one signalled.
1593 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1594}
1595
Steve Antone831b8c2018-02-01 12:22:16 -08001596TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1597 auto caller = CreatePeerConnectionWithUnifiedPlan();
1598 caller->AddAudioTrack("caller_audio");
1599 auto callee = CreatePeerConnectionWithUnifiedPlan();
1600 callee->AddAudioTrack("callee_audio");
1601
1602 auto offer = caller->CreateOffer();
1603 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1604 // section only.
1605 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1606
1607 ASSERT_TRUE(
1608 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1609 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1610
1611 // Answer should have only a=msid to match the offer.
1612 auto answer = callee->CreateAnswer();
1613 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1614 answer->description()->msid_signaling());
1615}
1616
Steve Anton8e20f172018-03-06 10:55:04 -08001617// Test that the correct UMA metrics are reported for simple/complex SDP.
1618
Steve Anton3172c032018-05-03 15:30:18 -07001619class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001620
1621#ifdef HAVE_SCTP
1622TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1623 auto caller = CreatePeerConnectionWithUnifiedPlan();
1624 caller->CreateDataChannel("dc");
1625 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001626
1627 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001628 // Note that only the callee does ReportSdpFormatReceived.
1629 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1630 "WebRTC.PeerConnection.SdpFormatReceived"));
1631 EXPECT_EQ(
1632 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1633 kSdpFormatReceivedNoTracks));
Steve Anton8e20f172018-03-06 10:55:04 -08001634}
1635#endif // HAVE_SCTP
1636
1637TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1638 auto caller = CreatePeerConnectionWithUnifiedPlan();
1639 caller->AddAudioTrack("audio");
1640 caller->AddVideoTrack("video");
1641 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001642
1643 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001644 // Note that only the callee does ReportSdpFormatReceived.
1645 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1646 "WebRTC.PeerConnection.SdpFormatReceived"));
1647 EXPECT_EQ(
1648 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1649 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001650}
1651
1652TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1653 auto caller = CreatePeerConnectionWithPlanB();
1654 caller->AddVideoTrack("video"); // Video only.
1655 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001656
1657 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1658
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001659 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1660 "WebRTC.PeerConnection.SdpFormatReceived"));
1661 EXPECT_EQ(
1662 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1663 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001664}
1665
1666TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1667 auto caller = CreatePeerConnectionWithUnifiedPlan();
1668 caller->AddAudioTrack("audio1");
1669 caller->AddAudioTrack("audio2");
1670 caller->AddVideoTrack("video");
1671 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001672
1673 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001674 // Note that only the callee does ReportSdpFormatReceived.
1675 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1676 "WebRTC.PeerConnection.SdpFormatReceived"));
1677 EXPECT_EQ(
1678 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1679 kSdpFormatReceivedComplexUnifiedPlan));
Steve Anton8e20f172018-03-06 10:55:04 -08001680}
1681
1682TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1683 auto caller = CreatePeerConnectionWithPlanB();
1684 caller->AddVideoTrack("video1");
1685 caller->AddVideoTrack("video2");
1686 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001687
Steve Antonba42e992018-04-09 14:10:01 -07001688 // This fails since Unified Plan cannot set a session description with
1689 // multiple "Plan B tracks" in the same media section. But we still expect the
1690 // SDP Format to be recorded.
1691 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001692 // Note that only the callee does ReportSdpFormatReceived.
1693 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1694 "WebRTC.PeerConnection.SdpFormatReceived"));
1695 EXPECT_EQ(
1696 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1697 kSdpFormatReceivedComplexPlanB));
Steve Anton8e20f172018-03-06 10:55:04 -08001698}
1699
Henrik Boström91d039b2018-01-11 17:43:30 +01001700// Sender setups in a call.
1701
Steve Anton3172c032018-05-03 15:30:18 -07001702TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001703 auto caller = CreatePeerConnection();
1704 auto callee = CreatePeerConnection();
1705
1706 auto track = caller->CreateAudioTrack("audio_track");
1707 auto sender1 = caller->AddTrack(track);
1708 ASSERT_TRUE(sender1);
1709 // We need to temporarily reset the track for the subsequent AddTrack() to
1710 // succeed.
1711 EXPECT_TRUE(sender1->SetTrack(nullptr));
1712 auto sender2 = caller->AddTrack(track);
1713 EXPECT_TRUE(sender2);
1714 EXPECT_TRUE(sender1->SetTrack(track));
1715
Steve Anton3172c032018-05-03 15:30:18 -07001716 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1717 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1718 // return true, and doing |callee->SetRemoteDescription()| should work.
1719 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1720 } else {
1721 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1722 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001723}
1724
Steve Anton3172c032018-05-03 15:30:18 -07001725INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest,
1726 PeerConnectionRtpTest,
1727 Values(SdpSemantics::kPlanB,
1728 SdpSemantics::kUnifiedPlan));
1729
Steve Anton9158ef62017-11-27 13:01:52 -08001730} // namespace webrtc