blob: 60f99ef572af905bf72d4ae2944e8e49626e959e [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
158 if (fd != null) _mask |= fd.describeContents();
159 if (fds != null) for (ParcelFileDescriptor _v0: fds) if (_v0 != null) _mask |= _v0.describeContents();
160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900162}
163)";
164
Devin Moore2f2077a2020-08-28 11:27:53 -0700165// clang-format off
166const char kExpectedCppHeaderOutput[] =
167 R"(#pragma once
168
169#include <binder/IBinder.h>
170#include <binder/IInterface.h>
171#include <binder/Status.h>
172#include <optional>
173#include <utils/String16.h>
174#include <utils/StrongPointer.h>
175#include <vector>
176
177class IFoo : public ::android::IInterface {
178public:
179 DECLARE_META_INTERFACE(Foo)
180 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
181}; // class IFoo
182class IFooDefault : public IFoo {
183public:
184 ::android::IBinder* onAsBinder() override {
185 return nullptr;
186 }
187 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
188 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
189 }
190}; // class IFooDefault
191)";
192// clang-format on
193
Christopher Wileyf8136192016-04-12 14:19:35 -0700194} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700195
Devin Moore7b8d5c92020-03-17 14:14:08 -0700196class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700197 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900198 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
199 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700200 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900202 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203 args.emplace_back("aidl");
204 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700205 for (const string& s : additional_arguments) {
206 args.emplace_back(s);
207 }
208 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900209 args.emplace_back("--preprocessed=" + f);
210 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700211 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900212 args.emplace_back("--include=" + i);
213 }
214 args.emplace_back(path);
215 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900216 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900217 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700218 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900219 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900220
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700221 if (error != nullptr) {
222 *error = actual_error;
223 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900224
225 if (actual_error != AidlError::OK) {
226 return nullptr;
227 }
228
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900229 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 EXPECT_EQ(1ul, defined_types.size());
231
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900232 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700233 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700234
Devin Moore7b8d5c92020-03-17 14:14:08 -0700235 Options::Language GetLanguage() { return GetParam(); }
236
Christopher Wiley0522cd52015-10-28 15:39:44 -0700237 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800238 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900239 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900240 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700241};
242
Devin Moore7b8d5c92020-03-17 14:14:08 -0700243// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
244// tests with each of the supported languages as a parameter.
245INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
246 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700247 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248 [](const testing::TestParamInfo<Options::Language>& info) {
249 return Options::LanguageToString(info.param);
250 });
251
252TEST_P(AidlTest, AcceptMissingPackage) {
253 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700254}
255
Devin Moore7b8d5c92020-03-17 14:14:08 -0700256TEST_P(AidlTest, EndsInSingleLineComment) {
257 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700258}
259
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000260TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
261 const string expected_stderr =
262 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
263 const std::string file_contents = "package a; interface IBar {}";
264 CaptureStderr();
265 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
266 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
267}
268
269TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
270 const string expected_stderr =
271 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
272 const std::string file_contents = "package a; interface Bar {}";
273 CaptureStderr();
274 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
275 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
276}
277
278TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
279 const string expected_stderr =
280 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
281 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
282 CaptureStderr();
283 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
284 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
285}
286
287TEST_P(AidlTest, EnumRequiresCorrectPath) {
288 const string expected_stderr =
289 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
290 const std::string file_contents = "package a; enum Bar { A, }";
291 CaptureStderr();
292 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
293 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
294}
295
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900297 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700298 io_delegate_.SetFileContents("bar/IBar.aidl",
299 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700300 const string path = "foo/IFoo.aidl";
301 const string contents =
302 "package foo;\n"
303 "import bar.IBar;\n"
304 "interface IFoo { void f(in IBar[] input); }";
305 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
306 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700307 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700308 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700312 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700313 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900314}
Devin Moore097a3ab2020-03-11 16:08:44 -0700315
Jiyong Park40782d02020-07-24 19:17:43 +0900316TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700317 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
318 const string expected_ibinder_stderr =
319 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900323}
324
Jiyong Park40782d02020-07-24 19:17:43 +0900325TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
327 const string expected_stderr =
328 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700329 CaptureStderr();
330 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900332}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700333
Jiyong Park40782d02020-07-24 19:17:43 +0900334TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900336 const string expected_stderr =
337 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700339 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700341}
342
Devin Moore7b8d5c92020-03-17 14:14:08 -0700343TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700344 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
345 const string expected_stderr =
346 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
347 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700349 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
354 const string expected_stderr =
355 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
356 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700357 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800359}
360
Devin Moore2f2077a2020-08-28 11:27:53 -0700361TEST_P(AidlTest, AcceptNullableList) {
362 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
363 const string expected_stderr = "";
364 CaptureStderr();
365 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
366 EXPECT_EQ(expected_stderr, GetCapturedStderr());
367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 const string method = "package a; interface IFoo { void f(int a, int a); }";
371 const string expected_stderr =
372 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
373 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700374 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700376}
377
Jeongik Cha13066da2020-08-06 15:43:19 +0900378TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
379 const string method = "package a; parcelable Foo { int a; String a; }";
380 const string expected_stderr =
381 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
382 CaptureStderr();
383 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
384 EXPECT_EQ(expected_stderr, GetCapturedStderr());
385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
389 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
390 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100393}
394
Devin Moore7b8d5c92020-03-17 14:14:08 -0700395TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 AidlError error;
397 const string method = "package a; @nullable interface IFoo { int f(); }";
398 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800399 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900400 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700401 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700402 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700403 EXPECT_EQ(expected_stderr, GetCapturedStderr());
404 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800405}
406
Devin Moore7b8d5c92020-03-17 14:14:08 -0700407TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700408 AidlError error;
409 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
410 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800411 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900412 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700413 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700414 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700415 EXPECT_EQ(expected_stderr, GetCapturedStderr());
416 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
422 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000423 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900424 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900425 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000434 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700435 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000436 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900437 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700438 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700439 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000440 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
442 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800443}
444
Jiyong Park40782d02020-07-24 19:17:43 +0900445TEST_P(AidlTest, ParsesNonNullableAnnotation) {
446 auto parse_result =
447 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
448 ASSERT_NE(nullptr, parse_result);
449 const AidlInterface* interface = parse_result->AsInterface();
450 ASSERT_NE(nullptr, interface);
451 ASSERT_FALSE(interface->GetMethods().empty());
452 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
453}
454
Devin Moore7b8d5c92020-03-17 14:14:08 -0700455TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900456 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
457 typenames_, GetLanguage());
458 ASSERT_NE(nullptr, parse_result);
459 const AidlInterface* interface = parse_result->AsInterface();
460 ASSERT_NE(nullptr, interface);
461 ASSERT_FALSE(interface->GetMethods().empty());
462 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
463}
464
465TEST_P(AidlTest, ParsesNonUtf8Annotations) {
466 auto parse_result =
467 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
468 ASSERT_NE(nullptr, parse_result);
469 const AidlInterface* interface = parse_result->AsInterface();
470 ASSERT_NE(nullptr, interface);
471 ASSERT_FALSE(interface->GetMethods().empty());
472 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800473}
474
Devin Moore7b8d5c92020-03-17 14:14:08 -0700475TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900476 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
477 typenames_, GetLanguage());
478 ASSERT_NE(nullptr, parse_result);
479 const AidlInterface* interface = parse_result->AsInterface();
480 ASSERT_NE(nullptr, interface);
481 ASSERT_FALSE(interface->GetMethods().empty());
482 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800483}
484
Devin Moore7b8d5c92020-03-17 14:14:08 -0700485TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700486 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700487 const string expected_stderr =
488 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
489 "\"vintf\"'\n"
490 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
491 "--structured\n";
492 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700493 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700494 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700495 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700496 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700497}
498
Devin Moore7b8d5c92020-03-17 14:14:08 -0700499TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700500 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700501 const string expected_stderr =
502 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
503 "--structured\n";
504 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700505 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700506 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700507 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700508 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700509}
510
Devin Moore7b8d5c92020-03-17 14:14:08 -0700511TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700513 const string expected_stderr =
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
515 "\"vintf\"'\n";
516 CaptureStderr();
517 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700518 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700520 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521}
522
Devin Moore7b8d5c92020-03-17 14:14:08 -0700523TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700524 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
526 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700527 ASSERT_EQ(AidlError::OK, error);
528 ASSERT_NE(nullptr, parse_result);
529 const AidlInterface* interface = parse_result->AsInterface();
530 ASSERT_NE(nullptr, interface);
531 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700532}
533
Jeongik Cha64783ed2019-06-07 18:30:54 +0900534TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
535 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900536 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
537 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900538 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700539 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900540 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900541 "a/Foo.aidl",
542 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900543
544 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900545 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700546 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900547 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700548 "Parcelable must be defined in AIDL directly.\n";
549 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900550 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700552
553 CaptureStderr();
554 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
555 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900556}
557
Jiyong Park43113fb2020-07-20 16:26:19 +0900558TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
559 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
560 @JavaDebug parcelable IFoo { int a; float b; })");
561 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
562 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
563
564 string java_out;
565 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
566 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
567
568 // Other backends shouldn't be bothered
569 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
571
572 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
573 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
574}
575
576TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
577 {
578 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
579 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
580 CaptureStderr();
581 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
582 const std::string expected_stderr =
583 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900584 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
585 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 EXPECT_EQ(expected_stderr, GetCapturedStderr());
587 }
588
589 {
590 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
591 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
592 CaptureStderr();
593 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
594 const std::string expected_stderr =
595 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
596 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
597 EXPECT_EQ(expected_stderr, GetCapturedStderr());
598 }
599}
600
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900601TEST_P(AidlTest, ParseDescriptorAnnotation) {
602 AidlError error;
603 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
604 typenames_, GetLanguage(), &error, {"--structured"});
605 ASSERT_EQ(AidlError::OK, error);
606 ASSERT_NE(nullptr, parse_result);
607 const AidlInterface* interface = parse_result->AsInterface();
608 ASSERT_NE(nullptr, interface);
609 ASSERT_EQ("IBar", interface->GetDescriptor());
610}
611
Jiyong Park40782d02020-07-24 19:17:43 +0900612TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700613 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700614 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900615}
616
617TEST_P(AidlTest, AcceptsOnewayInterface) {
618 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700619 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700620}
Christopher Wileyef140932015-11-03 09:29:19 -0800621
Devin Moore7b8d5c92020-03-17 14:14:08 -0700622TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700623 const string oneway_method =
624 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700625 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100626}
627
Steven Moreland65297cc2020-04-20 20:17:36 -0700628TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
629 const string oneway_method =
630 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
631 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
632 ASSERT_NE(nullptr, defined);
633 const AidlInterface* iface = defined->AsInterface();
634 ASSERT_NE(nullptr, iface);
635
636 const auto& methods = iface->GetMethods();
637 ASSERT_EQ(1u, methods.size());
638 const auto& method = methods[0];
639 const AidlTypeSpecifier& ret_type = method->GetType();
640
641 // TODO(b/151102494): these annotations should be on the method
642 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
643 ASSERT_TRUE(ret_type.IsHide());
644}
645
Devin Moore7b8d5c92020-03-17 14:14:08 -0700646TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100647 string foo_interface =
648 "package a; /* foo */ interface IFoo {"
649 " /* i */ int i();"
650 " /* j */ @nullable String j();"
651 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
652
Devin Moore7b8d5c92020-03-17 14:14:08 -0700653 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100654 EXPECT_NE(nullptr, parse_result);
655 EXPECT_EQ("/* foo */", parse_result->GetComments());
656
657 const AidlInterface* interface = parse_result->AsInterface();
658 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
659 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
660 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
661}
662
Jooyung Han1a551d32020-10-05 15:37:26 +0900663TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
664 io_delegate_.SetFileContents("p/cpp_header.aidl",
665 R"(package p;
666 parcelable cpp_header cpp_header "bar/header";)");
667 import_paths_.emplace("");
668 const string input_path = "p/IFoo.aidl";
669 const string input = R"(package p;
670 import p.cpp_header;
671 interface IFoo {
672 // get bar
673 cpp_header get();
674 })";
675
676 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
677 EXPECT_NE(nullptr, parse_result);
678 const AidlInterface* interface = parse_result->AsInterface();
679 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
680}
681
Christopher Wileyef140932015-11-03 09:29:19 -0800682TEST_F(AidlTest, ParsesPreprocessedFile) {
683 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
684 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700685 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900686 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700687 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
688 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800689}
690
691TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
692 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
693 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900694
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700695 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900696 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700697 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
698 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800699}
700
Devin Moore7b8d5c92020-03-17 14:14:08 -0700701TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800702 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
703 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
704 "interface IBar {}");
705 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900706 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900707 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700708 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800709 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900710
Christopher Wiley41544372015-11-03 14:52:29 -0800711 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700712 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
713 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800714 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700715 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900716 ambiguous_type.Resolve(typenames_);
717 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800718}
719
Jiyong Park8f6ec462020-01-19 20:52:47 +0900720// Special case of PreferImportToPreprocessed. Imported type should be preferred
721// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700722TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900723 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
724 io_delegate_.SetFileContents("one/IBar.aidl",
725 "package one; "
726 "interface IBar {}");
727 preprocessed_files_.push_back("preprocessed");
728 import_paths_.emplace("");
729 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700730 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900731 EXPECT_NE(nullptr, parse_result);
732
733 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700734 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
735 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900736 // But if we request just "IBar" we should get our imported one.
737 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
738 ambiguous_type.Resolve(typenames_);
739 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
740}
741
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800742TEST_F(AidlTest, WritePreprocessedFile) {
743 io_delegate_.SetFileContents("p/Outer.aidl",
744 "package p; parcelable Outer.Inner;");
745 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
746 "interface IBar {}");
747
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900748 vector<string> args {
749 "aidl",
750 "--preprocess",
751 "preprocessed",
752 "p/Outer.aidl",
753 "one/IBar.aidl"};
754 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800755 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
756
757 string output;
758 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
759 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
760}
761
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900762TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100763 io_delegate_.SetFileContents(
764 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800765 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100766 "parcelable Rect {\n"
767 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800768 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100769 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800770 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100771 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100772 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
773 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100774 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900775 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900776 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100777 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900778
779 vector<string> args{"aidl", "Rect.aidl"};
780 Options options = Options::From(args);
781 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
782
783 string output;
784 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900785 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900786}
787
Devin Moore2f2077a2020-08-28 11:27:53 -0700788TEST_F(AidlTest, CppHeaderIncludes) {
789 io_delegate_.SetFileContents("IFoo.aidl",
790 "interface IFoo {\n"
791 " @nullable List<String> foo();\n"
792 "}");
793
794 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
795 Options options = Options::From(args);
796 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
797 std::vector<std::string> empty;
798 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
799 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
800 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
801
802 // Make sure the optional and String16.h includes are added
803 string output;
804 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
805 EXPECT_EQ(kExpectedCppHeaderOutput, output);
806}
807
Devin Moore7b8d5c92020-03-17 14:14:08 -0700808TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700809 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800810 io_delegate_.SetFileContents("p/Outer.aidl",
811 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900812 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700813 CaptureStderr();
814 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
815 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700816 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700817 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800818}
819
Devin Moore7b8d5c92020-03-17 14:14:08 -0700820TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800821 io_delegate_.SetFileContents("preprocessed",
822 "parcelable p.Outer.Inner;");
823 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900824 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700825 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800826 // TODO(wiley): This should actually return nullptr because we require
827 // the outer class name. However, for legacy reasons,
828 // this behavior must be maintained. b/17415692
829 EXPECT_NE(nullptr, parse_result);
830}
831
Christopher Wiley632801d2015-11-05 14:15:49 -0800832TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700833 const string expected_foo_stderr =
834 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
835 "Declared parcelables should be in their own file and/or cannot be used with --structured "
836 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700837 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
838
Christopher Wiley632801d2015-11-05 14:15:49 -0800839 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700840 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700841 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900842 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700843 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900844
Steven Morelande2c64b42018-09-18 15:06:37 -0700845 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900846 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700847 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900848 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700849 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700850
Devin Moore097a3ab2020-03-11 16:08:44 -0700851 const string expected_bar_stderr =
852 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
853 "Declared parcelables should be in their own file and/or cannot be used with --structured "
854 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700855 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
856
Jiyong Parkda8c6932019-08-12 19:56:08 +0900857 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700858 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700859 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900860 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700861 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700862 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700863 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700864 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700865 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800866}
867
Devin Moore7b8d5c92020-03-17 14:14:08 -0700868TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 const string expected_stderr =
870 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
871 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700872 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
873 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700874 AidlError error;
875 CaptureStderr();
876 EXPECT_EQ(
877 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700878 Parse("p/IFoo.aidl",
879 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700880 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700881 EXPECT_EQ(expected_stderr, GetCapturedStderr());
882 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700883}
884
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700886 AidlError error;
887 const string expected_stderr =
888 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
889 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900890 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
891 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700892 interface IFoo {
893 const String DUPLICATED = "d";
894 const int DUPLICATED = 1;
895 }
896 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700897 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700898 EXPECT_EQ(expected_stderr, GetCapturedStderr());
899 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700900}
901
Devin Moore7b8d5c92020-03-17 14:14:08 -0700902TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700903 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700904 const string expected_stderr =
905 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700906 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700907 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
908 R"(package p;
909 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700910 parcelable IBar {}
911 parcelable StructuredParcelable {}
912 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900913 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700914 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700915 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700916 // Parse success is important for clear error handling even if the cases aren't
917 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700918 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700919}
920
Devin Moore7b8d5c92020-03-17 14:14:08 -0700921TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 AidlError error;
923 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
924 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700925 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700926 EXPECT_EQ(expected_stderr, GetCapturedStderr());
927 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700928}
929
Steven Morelandf9e922f2020-07-08 21:15:27 +0000930TEST_P(AidlTest, FailOnEmptyListWithComma) {
931 AidlError error;
932 const string expected_stderr =
933 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
934 CaptureStderr();
935 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
936 typenames_, GetLanguage(), &error));
937 EXPECT_EQ(expected_stderr, GetCapturedStderr());
938 EXPECT_EQ(AidlError::PARSE_ERROR, error);
939}
940
Devin Moore7b8d5c92020-03-17 14:14:08 -0700941TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 AidlError error;
943 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700944 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700945 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900946 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
947 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700948 interface IFoo {
949 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
950 }
951 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700952 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
954 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700955}
956
Jiyong Park18132182020-06-08 20:24:40 +0900957TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
958 AidlError error;
959 const string expected_stderr =
960 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
961 "cpp_header (which can also be used as an identifier)\n";
962 CaptureStderr();
963 // Notice the trailing dot(.) in the name, which isn't a correct name
964 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
965 GetLanguage(), &error));
966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
967 EXPECT_EQ(AidlError::PARSE_ERROR, error);
968}
969
970TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
971 AidlError error;
972 const string expected_stderr =
973 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
974 "cpp_header (which can also be used as an identifier)\n";
975 CaptureStderr();
976 // Notice the trailing dot(.) in the package name
977 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
978 GetLanguage(), &error));
979 EXPECT_EQ(expected_stderr, GetCapturedStderr());
980 EXPECT_EQ(AidlError::PARSE_ERROR, error);
981}
982
Devin Moore7b8d5c92020-03-17 14:14:08 -0700983TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700984 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700985 auto parse_result = Parse("p/IFoo.aidl",
986 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700987 interface IFoo {
988 const int POSITIVE_HEX_VALUE = 0xf5;
989 }
990 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700991 typenames_, GetLanguage(), &error);
992 EXPECT_NE(nullptr, parse_result);
993 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700994 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700995 const auto& cpp_constants = interface->GetConstantDeclarations();
996 EXPECT_EQ((size_t)1, cpp_constants.size());
997 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700998 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700999 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001000}
1001
Devin Moore7b8d5c92020-03-17 14:14:08 -07001002TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001003 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001004 auto parse_result = Parse("p/IFoo.aidl",
1005 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001006 interface IFoo {
1007 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1008 }
1009 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001010 typenames_, GetLanguage(), &error);
1011 ASSERT_NE(nullptr, parse_result);
1012 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001013 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001014 const auto& cpp_constants = interface->GetConstantDeclarations();
1015 EXPECT_EQ((size_t)1, cpp_constants.size());
1016 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001017 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001018 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001019}
1020
Devin Moore7b8d5c92020-03-17 14:14:08 -07001021TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001022 io_delegate_.SetFileContents(
1023 "p/Outer.aidl",
1024 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001025 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001026 const string input_path = "p/IFoo.aidl";
1027 const string input = "package p; import p.Outer; interface IFoo"
1028 " { Outer.Inner get(); }";
1029
Devin Moore7b8d5c92020-03-17 14:14:08 -07001030 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1031 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001032
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001033 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001034 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001035 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1036 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001037}
1038
Devin Moore7b8d5c92020-03-17 14:14:08 -07001039TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001040 io_delegate_.SetFileContents(
1041 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001042 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001043 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001044 const string input_path = "p/IFoo.aidl";
1045 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001046 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1047 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001048 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001049 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1050 native_type.Resolve(typenames_);
1051
1052 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1053 // C++ understands C++ specific stuff
1054 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1055 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001056 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001057 EXPECT_EQ(1u, headers.size());
1058 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001059}
1060
Christopher Wileyf8136192016-04-12 14:19:35 -07001061TEST_F(AidlTest, WritesCorrectDependencyFile) {
1062 // While the in tree build system always gives us an output file name,
1063 // other android tools take advantage of our ability to infer the intended
1064 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001065 vector<string> args = {
1066 "aidl",
1067 "-d dep/file/path",
1068 "-o place/for/output",
1069 "p/IFoo.aidl"};
1070 Options options = Options::From(args);
1071 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001072 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001073 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001074 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001075 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1076}
1077
Dan Willemsen93298ee2016-11-10 23:55:55 -08001078TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1079 // While the in tree build system always gives us an output file name,
1080 // other android tools take advantage of our ability to infer the intended
1081 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001082 vector<string> args = {
1083 "aidl",
1084 "-d dep/file/path",
1085 "--ninja",
1086 "-o place/for/output",
1087 "p/IFoo.aidl"};
1088 Options options = Options::From(args);
1089 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001090 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001091 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001092 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001093 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1094}
1095
Jiyong Parkdf202122019-09-30 20:48:35 +09001096TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001097 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1098 // this by calling aidl with every .aidl file it finds, then parsing the
1099 // generated dependency files. Those that reference .java output files are
1100 // for interfaces and those that do not are parcelables. However, for both
1101 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001102 vector<string> args = {
1103 "aidl",
1104 "-o place/for/output",
1105 "-d dep/file/path",
1106 "p/Foo.aidl"};
1107 Options options = Options::From(args);
1108 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001109 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001110 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001111 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001112 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1113}
1114
1115TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1116 vector<string> args = {
1117 "aidl",
1118 "--structured",
1119 "-o place/for/output",
1120 "-d dep/file/path",
1121 "p/Foo.aidl"};
1122 Options options = Options::From(args);
1123 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1124 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1125 string actual_dep_file_contents;
1126 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1127 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001128}
1129
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001130TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1131 vector<string> args = {
1132 "aidl",
1133 "--lang=java",
1134 "-o place/for/output",
1135 "p/Foo.aidl"};
1136 Options options = Options::From(args);
1137 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1138 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1139 string output_file_contents;
1140 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1141}
1142
Jeongik Cha08ca2182019-11-21 14:01:13 +09001143// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001144TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001145 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001146 "package a; interface IFoo {\n"
1147 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001148 string expected_stderr;
1149 switch (GetLanguage()) {
1150 case Options::Language::CPP:
1151 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001152 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1154 "String and IBinder.\n";
1155 break;
1156 case Options::Language::JAVA:
1157 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001158 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001159 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1160 "String, IBinder, and ParcelFileDescriptor.\n";
1161 break;
1162 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001163 case Options::Language::RUST:
1164 expected_stderr =
1165 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1166 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001167 default:
1168 AIDL_FATAL(AIDL_LOCATION_HERE)
1169 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1170 }
1171 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001172 AidlTypenames tn1;
1173 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001174 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001175
1176 string primitive_parcelable =
1177 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001178 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001179 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001180 AidlTypenames tn2;
1181 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001182 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001183}
1184
Devin Moore21b26772020-08-26 16:37:56 -07001185TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001186 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001187 const string list_array_parcelable =
1188 "package a; parcelable Foo {\n"
1189 " List[] lists; }";
1190 CaptureStderr();
1191 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1193}
1194
Jiyong Parkf8d53612020-05-04 14:06:13 +09001195TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1196 AidlError error;
1197 string expected_stderr =
1198 "ERROR: a/IFoo.aidl:2.7-11: "
1199 "Encountered an untyped List or Map. The use of untyped List/Map is "
1200 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1201 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1202 if (GetLanguage() != Options::Language::JAVA) {
1203 expected_stderr =
1204 "ERROR: a/IFoo.aidl:2.1-7: "
1205 "Currently, only the Java backend supports non-generic List.\n";
1206 }
1207
1208 const string primitive_interface =
1209 "package a; interface IFoo {\n"
1210 " List foo(); }";
1211 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001212 AidlTypenames tn1;
1213 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001214 {"--structured"}));
1215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001216
1217 string primitive_parcelable =
1218 "package a; parcelable IFoo {\n"
1219 " List foo;}";
1220 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001221 AidlTypenames tn2;
1222 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001223 {"--structured"}));
1224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1225}
1226
Jeongik Cha225519b2020-08-29 01:55:32 +09001227TEST_P(AidlTest, ExtensionTest) {
1228 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001229 string extendable_parcelable =
1230 "package a; parcelable Data {\n"
1231 " ParcelableHolder extension;\n"
1232 " ParcelableHolder extension2;\n"
1233 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001234 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1235 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1236 EXPECT_EQ(
1237 "ERROR: a/Data.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1238 "yet.\n",
1239 GetCapturedStderr());
1240 } else {
1241 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1242 EXPECT_EQ("", GetCapturedStderr());
1243 }
1244}
1245TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1246 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001247 string parcelableholder_return_interface =
1248 "package a; interface IFoo {\n"
1249 " ParcelableHolder foo();\n"
1250 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001251 EXPECT_EQ(nullptr,
1252 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001253
Jeongik Cha225519b2020-08-29 01:55:32 +09001254 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1255 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001256 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001257 "ERROR: a/IFoo.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1258 "yet.\n",
1259 GetCapturedStderr());
1260 return;
1261 }
1262 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1263 GetCapturedStderr());
1264}
1265
1266TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1267 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001268 string extendable_parcelable_arg_interface =
1269 "package a; interface IFoo {\n"
1270 " void foo(in ParcelableHolder ph);\n"
1271 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001272 EXPECT_EQ(nullptr,
1273 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1274
1275 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1276 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001277 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001278 "ERROR: a/IFoo.aidl:2.14-31: The NDK and Rust backend does not support ParcelableHolder "
1279 "yet.\n",
1280 GetCapturedStderr());
1281 return;
1282 }
1283 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1284 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001285}
1286
Jiyong Park02da7422018-07-16 16:00:26 +09001287TEST_F(AidlTest, ApiDump) {
1288 io_delegate_.SetFileContents(
1289 "foo/bar/IFoo.aidl",
1290 "package foo.bar;\n"
1291 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001292 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001293 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001294 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001295 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1296 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1297 " IFoo foo3(IFoo foo);\n"
1298 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001299 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001300 " const int A = 1;\n"
1301 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001302 "}\n");
1303 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1304 "package foo.bar;\n"
1305 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001306 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001307 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001308 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001309 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001310 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001311 " int y;\n"
1312 " IFoo foo;\n"
1313 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001314 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001315 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001316 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001317 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001318 "}\n");
1319 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001320 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1321 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001322 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001323 bool result = dump_api(options, io_delegate_);
1324 ASSERT_TRUE(result);
1325 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001326 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001327 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001328/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001329interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001330 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001331 int foo(out int[] a, String b, boolean c, inout List<String> d);
1332 int foo2(@utf8InCpp String x, inout List<String> y);
1333 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1334 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001335 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001336 const int A = 1;
1337 const String STR = "Hello";
1338}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001339)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001340
Jiyong Parke59c3682018-09-11 23:10:25 +09001341 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001342 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001343/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001344parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001345 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001346 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001347 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001348 int y;
1349 foo.bar.IFoo foo;
1350 List<foo.bar.IFoo> a;
1351 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001352 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001353 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001354}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001355)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001356}
1357
Jiyong Parked65bf42018-08-28 15:43:27 +09001358TEST_F(AidlTest, ApiDumpWithManualIds) {
1359 io_delegate_.SetFileContents(
1360 "foo/bar/IFoo.aidl",
1361 "package foo.bar;\n"
1362 "interface IFoo {\n"
1363 " int foo() = 1;\n"
1364 " int bar() = 2;\n"
1365 " int baz() = 10;\n"
1366 "}\n");
1367
Jiyong Parke59c3682018-09-11 23:10:25 +09001368 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001369 Options options = Options::From(args);
1370 bool result = dump_api(options, io_delegate_);
1371 ASSERT_TRUE(result);
1372 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001373 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001374 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001375interface IFoo {
1376 int foo() = 1;
1377 int bar() = 2;
1378 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001379}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001380)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001381}
1382
1383TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001384 const string expected_stderr =
1385 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1386 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001387 io_delegate_.SetFileContents(
1388 "foo/bar/IFoo.aidl",
1389 "package foo.bar;\n"
1390 "interface IFoo {\n"
1391 " int foo() = 1;\n"
1392 " int bar();\n"
1393 " int baz() = 10;\n"
1394 "}\n");
1395
Jiyong Parke59c3682018-09-11 23:10:25 +09001396 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001397 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001398 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001399 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001401}
1402
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001403TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001404 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001405 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1406 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001407 const string expected_map_stderr =
1408 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001409 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1410 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001411 "package p; interface IFoo {"
1412 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001413 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001414 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001415 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001416
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001417 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001418 "package p; interface IFoo {"
1419 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001420 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001421 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001422 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001423}
1424
Jeongik Chae48d9942020-01-02 17:39:00 +09001425TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001426 const string expected_stderr =
1427 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001428 Options options = Options::From("aidl -I p p/IFoo.aidl");
1429 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1430
1431 io_delegate_.SetFileContents("p/IFoo.aidl",
1432 "package p; interface IFoo {"
1433 "Map<String, Bar> foo();}");
1434 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1435
1436 io_delegate_.SetFileContents("p/IFoo.aidl",
1437 "package p; interface IFoo {"
1438 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001439 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001440 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001442
1443 io_delegate_.SetFileContents("p/IFoo.aidl",
1444 "package p; interface IFoo {"
1445 "Map<String, String> foo();}");
1446 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1447
1448 io_delegate_.SetFileContents("p/IFoo.aidl",
1449 "package p; interface IFoo {"
1450 "Map<String, ParcelFileDescriptor> foo();}");
1451 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1452}
1453
Jeongik Chadf76dc72019-11-28 00:08:47 +09001454TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001455 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001456 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1457 io_delegate_.SetFileContents(options.InputFiles().front(),
1458 "package p; interface IFoo {"
1459 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001460 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001461 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001462 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001463}
1464
1465TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1466 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1467 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001468 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001469 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001470 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1471 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001472
1473 Options options = Options::From("aidl -I p p/IFoo.aidl");
1474 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1475 io_delegate_.SetFileContents("p/IFoo.aidl",
1476 "package p; interface IFoo {"
1477 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001478 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001479 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001480 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001481 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001482 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001483 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001484 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1485 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001486 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1487 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1488 io_delegate_.SetFileContents("p/IFoo.aidl",
1489 "package p; interface IFoo {"
1490 "Bar<String, ParcelFileDescriptor> foo();}");
1491 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001492
1493 io_delegate_.SetFileContents("p/IFoo.aidl",
1494 "package p; interface IFoo {"
1495 "Bar<int, long> foo();}");
1496
1497 io_delegate_.SetFileContents("p/IFoo.aidl",
1498 "package p; interface IFoo {"
1499 "Bar<int[], long[]> foo();}");
1500
1501 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001502}
1503
Jeongik Cha0e426012019-07-29 15:57:02 +09001504TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1505 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001506 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1507 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001508 for (const auto& rawOption : rawOptions) {
1509 string expected_stderr =
1510 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001511 Options options = Options::From(rawOption);
1512 io_delegate_.SetFileContents(options.InputFiles().front(),
1513 "package foo.bar;\n"
1514 "interface IFoo1 { int foo(); }\n"
1515 "interface IFoo2 { int foo(); }\n"
1516 "parcelable Data1 { int a; int b;}\n"
1517 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001518 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001519 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001521
Jeongik Cha0e426012019-07-29 15:57:02 +09001522 io_delegate_.SetFileContents(options.InputFiles().front(),
1523 "package foo.bar;\n"
1524 "interface IFoo1 { int foo(); }\n"
1525 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001526 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001527 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001528 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001529
Devin Moore5de18ed2020-04-02 13:52:29 -07001530 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001531 io_delegate_.SetFileContents(options.InputFiles().front(),
1532 "package foo.bar;\n"
1533 "parcelable Data1 { int a; int b;}\n"
1534 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001535 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001536 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001537 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001538 }
1539}
1540
Devin Moorebdba2a82020-03-31 15:19:02 -07001541TEST_P(AidlTest, FailParseOnEmptyFile) {
1542 const string contents = "";
1543 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1544 CaptureStderr();
1545 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1546 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1547}
1548
Jiyong Parkb034bf02018-07-30 17:44:33 +09001549TEST_F(AidlTest, MultipleInputFiles) {
1550 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001551 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001552
1553 io_delegate_.SetFileContents(options.InputFiles().at(0),
1554 "package foo.bar;\n"
1555 "import foo.bar.Data;\n"
1556 "interface IFoo { Data getData(); }\n");
1557
1558 io_delegate_.SetFileContents(options.InputFiles().at(1),
1559 "package foo.bar;\n"
1560 "import foo.bar.IFoo;\n"
1561 "parcelable Data { IFoo foo; }\n");
1562
1563 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1564
1565 string content;
1566 for (const auto file : {
1567 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1568 content.clear();
1569 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1570 EXPECT_FALSE(content.empty());
1571 }
1572}
1573
1574TEST_F(AidlTest, MultipleInputFilesCpp) {
1575 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001576 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001577
1578 io_delegate_.SetFileContents(options.InputFiles().at(0),
1579 "package foo.bar;\n"
1580 "import foo.bar.Data;\n"
1581 "interface IFoo { Data getData(); }\n");
1582
1583 io_delegate_.SetFileContents(options.InputFiles().at(1),
1584 "package foo.bar;\n"
1585 "import foo.bar.IFoo;\n"
1586 "parcelable Data { IFoo foo; }\n");
1587
1588 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1589
1590 string content;
1591 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001592 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001593 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1594 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1595 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1596 content.clear();
1597 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1598 EXPECT_FALSE(content.empty());
1599 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001600}
1601
Andrei Homescub62afd92020-05-11 19:24:59 -07001602TEST_F(AidlTest, MultipleInputFilesRust) {
1603 Options options =
1604 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1605
1606 io_delegate_.SetFileContents(options.InputFiles().at(0),
1607 "package foo.bar;\n"
1608 "import foo.bar.Data;\n"
1609 "interface IFoo { Data getData(); }\n");
1610
1611 io_delegate_.SetFileContents(options.InputFiles().at(1),
1612 "package foo.bar;\n"
1613 "import foo.bar.IFoo;\n"
1614 "parcelable Data { IFoo foo; }\n");
1615
1616 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1617
1618 string content;
1619 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1620 content.clear();
1621 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1622 EXPECT_FALSE(content.empty());
1623 }
1624}
1625
Devin Moore097a3ab2020-03-11 16:08:44 -07001626TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1627 const string expected_stderr =
1628 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001629 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1630 // int getInterfaceVersion() is one of the meta transactions
1631 io_delegate_.SetFileContents(options.InputFiles().front(),
1632 "package p; interface IFoo {"
1633 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001634 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001635 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1637}
Jiyong Park309668e2018-07-28 16:55:44 +09001638
Devin Moore097a3ab2020-03-11 16:08:44 -07001639TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1640 // boolean getInterfaceVersion() is not a meta transaction, but should be
1641 // prevented because return type is not part of a method signature
1642 const string expected_stderr =
1643 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1644 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001645 io_delegate_.SetFileContents(options.InputFiles().front(),
1646 "package p; interface IFoo {"
1647 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001648 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001649 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001650 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1651}
Jiyong Park309668e2018-07-28 16:55:44 +09001652
Devin Moore097a3ab2020-03-11 16:08:44 -07001653TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001654 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 const string expected_stderr =
1656 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1657 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001658 io_delegate_.SetFileContents(options.InputFiles().front(),
1659 "package p; interface IFoo {"
1660 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001661 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001662 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001663 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001664
1665 // this is not a meta interface method as it differs type arguments
1666 io_delegate_.SetFileContents(options.InputFiles().front(),
1667 "package p; interface IFoo {"
1668 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001669 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001670}
1671
Daniel Norman85aed542019-08-21 12:01:14 -07001672TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001673 Options options = Options::From("aidl --checkapi old new");
1674 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1675 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1676 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1677 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1678
1679 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1680}
1681
Jiyong Park3656c3c2018-08-01 20:02:01 +09001682TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001683 Options options = Options::From("aidl --checkapi old new");
1684 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1685 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001686
1687 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1688}
1689
Daniel Norman85aed542019-08-21 12:01:14 -07001690class AidlTestCompatibleChanges : public AidlTest {
1691 protected:
1692 Options options_ = Options::From("aidl --checkapi old new");
1693};
1694
1695TEST_F(AidlTestCompatibleChanges, NewType) {
1696 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1697 "package p;"
1698 "interface IFoo {"
1699 " void foo(int a);"
1700 "}");
1701 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1702 "package p;"
1703 "interface IFoo {"
1704 " void foo(int a);"
1705 "}");
1706 io_delegate_.SetFileContents("new/p/IBar.aidl",
1707 "package p;"
1708 "interface IBar {"
1709 " void bar();"
1710 "}");
1711 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1712}
1713
1714TEST_F(AidlTestCompatibleChanges, NewMethod) {
1715 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1716 "package p;"
1717 "interface IFoo {"
1718 " void foo(int a);"
1719 "}");
1720 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1721 "package p;"
1722 "interface IFoo {"
1723 " void foo(int a);"
1724 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001725 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001726 "}");
1727 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1728}
1729
1730TEST_F(AidlTestCompatibleChanges, NewField) {
1731 io_delegate_.SetFileContents("old/p/Data.aidl",
1732 "package p;"
1733 "parcelable Data {"
1734 " int foo;"
1735 "}");
1736 io_delegate_.SetFileContents("new/p/Data.aidl",
1737 "package p;"
1738 "parcelable Data {"
1739 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001740 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001741 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001742 "}");
1743 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1744}
1745
1746TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1747 io_delegate_.SetFileContents("old/p/Enum.aidl",
1748 "package p;"
1749 "enum Enum {"
1750 " FOO = 1,"
1751 "}");
1752 io_delegate_.SetFileContents("new/p/Enum.aidl",
1753 "package p;"
1754 "enum Enum {"
1755 " FOO = 1,"
1756 " BAR = 2,"
1757 "}");
1758 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1759}
1760
1761TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1762 io_delegate_.SetFileContents("old/p/Enum.aidl",
1763 "package p;"
1764 "enum Enum {"
1765 " FOO = 1,"
1766 " BAR = 2,"
1767 "}");
1768 io_delegate_.SetFileContents("new/p/Enum.aidl",
1769 "package p;"
1770 "enum Enum {"
1771 " BAR = 2,"
1772 " FOO = 1,"
1773 "}");
1774 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1775}
1776
1777TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001778 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1779 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001780 "interface IFoo {"
1781 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001782 "}");
1783 io_delegate_.SetFileContents("old/p/Data.aidl",
1784 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001785 "parcelable Data {"
1786 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001787 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001788 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1789 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001790 "interface IFoo {"
1791 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001792 "}");
1793 io_delegate_.SetFileContents("new/p/Data.aidl",
1794 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001795 "parcelable Data {"
1796 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001797 "}");
1798 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1799 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001800 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001801 " void foo(int a);"
1802 "}");
1803 io_delegate_.SetFileContents("new/q/Data.aidl",
1804 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001805 "parcelable Data {"
1806 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001807 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001808 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1809}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001810
Daniel Norman85aed542019-08-21 12:01:14 -07001811TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1812 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1813 "package p;"
1814 "interface IFoo {"
1815 " void foo(int a);"
1816 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001817 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1818 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001819 "interface IFoo {"
1820 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001821 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001822 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1823}
Jiyong Parke59c3682018-09-11 23:10:25 +09001824
Daniel Norman85aed542019-08-21 12:01:14 -07001825TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001826 io_delegate_.SetFileContents("old/p/I.aidl",
1827 "package p; interface I {"
1828 "const int A = 1; }");
1829 io_delegate_.SetFileContents("new/p/I.aidl",
1830 "package p ; interface I {"
1831 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001832 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1833}
Jiyong Parka428d212018-08-29 22:26:30 +09001834
Daniel Norman85aed542019-08-21 12:01:14 -07001835TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001836 io_delegate_.SetFileContents("old/p/I.aidl",
1837 "package p; interface I {"
1838 "const int A = 1; const int B = 2;}");
1839 io_delegate_.SetFileContents("new/p/I.aidl",
1840 "package p ; interface I {"
1841 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001842 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001843}
1844
Daniel Norman85aed542019-08-21 12:01:14 -07001845class AidlTestIncompatibleChanges : public AidlTest {
1846 protected:
1847 Options options_ = Options::From("aidl --checkapi old new");
1848};
1849
1850TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001851 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001852 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1853 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001854 "interface IFoo {"
1855 " void foo(in String[] str);"
1856 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001857 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001858 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001859 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001860 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001861}
1862
1863TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001864 const string expected_stderr =
1865 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001866 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1867 "package p;"
1868 "interface IFoo {"
1869 " void foo(in String[] str);"
1870 " void bar(@utf8InCpp String str);"
1871 "}");
1872 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1873 "package p;"
1874 "interface IFoo {"
1875 " void foo(in String[] str);"
1876 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001877 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001878 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001880}
1881
Jiyong Parkf8d53612020-05-04 14:06:13 +09001882TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1883 const string expected_stderr =
1884 "ERROR: new/p/IFoo.aidl:1.61-65: "
1885 "Encountered an untyped List or Map. The use of untyped List/Map is "
1886 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1887 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1888 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1889 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1890 "package p;"
1891 "interface IFoo {"
1892 " void foo(in String[] str);"
1893 "}");
1894 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1895 "package p;"
1896 "interface IFoo {"
1897 " void foo(in String[] str);"
1898 " void bar(in List arg);"
1899 "}");
1900 CaptureStderr();
1901 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1902 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1903}
1904
1905TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1906 const string expected_stderr =
1907 "ERROR: new/p/Data.aidl:1.54-59: "
1908 "Encountered an untyped List or Map. The use of untyped List/Map is "
1909 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1910 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1911 "ERROR: new/p/Data.aidl: Failed to read.\n";
1912 io_delegate_.SetFileContents("old/p/Data.aidl",
1913 "package p;"
1914 "parcelable Data {"
1915 " int foo;"
1916 "}");
1917 io_delegate_.SetFileContents("new/p/Data.aidl",
1918 "package p;"
1919 "parcelable Data {"
1920 " int foo;"
1921 " @nullable List list;"
1922 "}");
1923 CaptureStderr();
1924 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1925 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1926}
1927
Daniel Norman85aed542019-08-21 12:01:14 -07001928TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001929 const string expected_stderr =
1930 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001931 io_delegate_.SetFileContents("old/p/Data.aidl",
1932 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001933 "parcelable Data {"
1934 " int foo;"
1935 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001936 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001937 io_delegate_.SetFileContents("new/p/Data.aidl",
1938 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001939 "parcelable Data {"
1940 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001941 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001942 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001943 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001944 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001945}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001946
Daniel Norman85aed542019-08-21 12:01:14 -07001947TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001948 const string expected_stderr =
1949 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001950 io_delegate_.SetFileContents("old/p/Enum.aidl",
1951 "package p;"
1952 "enum Enum {"
1953 " FOO = 1,"
1954 " BAR = 2,"
1955 "}");
1956 io_delegate_.SetFileContents("new/p/Enum.aidl",
1957 "package p;"
1958 "enum Enum {"
1959 " BAR = 2,"
1960 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001961 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001962 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001963 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001964}
1965
1966TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001967 const string expected_stderr =
1968 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001969 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1970 "package p;"
1971 "interface IFoo {"
1972 " void foo(in String[] str);"
1973 " void bar(@utf8InCpp String str);"
1974 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001975 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1976 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001977 "interface IFoo {"
1978 " void foo(in String[] str);"
1979 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001980 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001981 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001982 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001983 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001984}
1985
Daniel Norman85aed542019-08-21 12:01:14 -07001986TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001987 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001988 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1989 "package p;"
1990 "interface IFoo {"
1991 " void foo(in String[] str);"
1992 " void bar(@utf8InCpp String str);"
1993 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001994 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
1995 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001996 "interface IFoo2 {"
1997 " void foo(in String[] str);"
1998 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001999 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002000 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002001 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002003}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002004
Daniel Norman85aed542019-08-21 12:01:14 -07002005TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002006 const string expected_stderr =
2007 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002008 io_delegate_.SetFileContents("old/p/Enum.aidl",
2009 "package p;"
2010 "enum Enum {"
2011 " FOO = 1,"
2012 " BAR = 2,"
2013 "}");
2014 io_delegate_.SetFileContents("new/p/Enum.aidl",
2015 "package p;"
2016 "enum Enum {"
2017 " FOO = 3,"
2018 " BAR = 2,"
2019 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002020 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002021 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002022 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002023}
2024
2025TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002026 const string expected_stderr =
2027 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2028 "from 0 to 1.\n"
2029 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2030 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002031 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2032 "package p;"
2033 "interface IFoo {"
2034 " void foo(in String[] str);"
2035 " void bar(@utf8InCpp String str);"
2036 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002037 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2038 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002039 "interface IFoo {"
2040 " void bar(@utf8InCpp String str);"
2041 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002042 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002043 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002044 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002045 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002046}
2047
2048TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002049 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002050 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2051 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002052 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002053 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002054 "parcelable Data {"
2055 " int foo;"
2056 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002057 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002058 io_delegate_.SetFileContents("new/p/Data.aidl",
2059 "package p;"
2060 "parcelable Data {"
2061 " int bar;"
2062 " int foo;"
2063 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002064 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002065 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002066 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002067}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002068
Daniel Norman85aed542019-08-21 12:01:14 -07002069TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002070 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002071 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002072 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002073 "interface IFoo {"
2074 " void foo(in String[] str);"
2075 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002076 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2078 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002079 "interface IFoo {"
2080 " void foo(out String[] str);"
2081 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002082 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002083 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002084 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002085 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002086}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002087
Daniel Norman85aed542019-08-21 12:01:14 -07002088TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002089 const string expected_stderr =
2090 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002091 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2092 "package p;"
2093 "interface IFoo {"
2094 " void foo(in String[] str);"
2095 " void bar(@utf8InCpp String str);"
2096 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002097 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2098 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002099 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002100 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002101 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002102 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002103 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002104 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002106}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002107
Daniel Norman85aed542019-08-21 12:01:14 -07002108TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002109 const string expected_stderr =
2110 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002111 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2112 "package p;"
2113 "interface IFoo {"
2114 " void foo(in String[] str);"
2115 " void bar(@utf8InCpp String str);"
2116 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002117 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2118 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002119 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002120 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002121 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002122 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002123 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002124 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002125 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002126}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002127
Devin Mooredb7ac512020-08-07 11:17:36 -07002128TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2129 const string expected_stderr =
2130 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2131 io_delegate_.SetFileContents("old/p/Foo.aidl",
2132 "package p;"
2133 "parcelable Foo {"
2134 " int A;"
2135 "}");
2136 io_delegate_.SetFileContents("new/p/Foo.aidl",
2137 "package p;"
2138 "@JavaOnlyStableParcelable parcelable Foo {"
2139 " int A;"
2140 "}");
2141 CaptureStderr();
2142 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2143 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2144}
2145
2146TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2147 const string expected_stderr =
2148 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2149 io_delegate_.SetFileContents("old/p/Foo.aidl",
2150 "package p;"
2151 "@JavaOnlyStableParcelable parcelable Foo {"
2152 " int A;"
2153 "}");
2154 io_delegate_.SetFileContents("new/p/Foo.aidl",
2155 "package p;"
2156 "parcelable Foo {"
2157 " int A;"
2158 "}");
2159 CaptureStderr();
2160 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2161 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2162}
2163
Daniel Norman85aed542019-08-21 12:01:14 -07002164TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002165 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002166 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2167 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002168 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002170 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002171 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002172}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002173
Daniel Norman85aed542019-08-21 12:01:14 -07002174TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002175 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002176 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2177 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002178 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002179 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002180 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002181}
Jiyong Parka428d212018-08-29 22:26:30 +09002182
Daniel Norman85aed542019-08-21 12:01:14 -07002183TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002184 const string expected_stderr =
2185 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002186 io_delegate_.SetFileContents("old/p/I.aidl",
2187 "package p; interface I {"
2188 "const int A = 1; const int B = 2;}");
2189 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002190 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002191 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002193}
Jiyong Parka428d212018-08-29 22:26:30 +09002194
Daniel Norman85aed542019-08-21 12:01:14 -07002195TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002196 const string expected_stderr =
2197 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002198 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2199 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002200 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002201 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002202 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002203}
2204
Devin Moorec7e47a32020-08-07 10:55:25 -07002205TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2206 const string expected_stderr =
2207 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2208 "This is an incompatible change for FixedSize types.\n";
2209 io_delegate_.SetFileContents("old/p/Foo.aidl",
2210 "package p; @FixedSize parcelable Foo { int A = 1; }");
2211 io_delegate_.SetFileContents("new/p/Foo.aidl",
2212 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2213 CaptureStderr();
2214 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2216}
2217
2218TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2219 const string expected_stderr =
2220 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2221 io_delegate_.SetFileContents("old/p/Foo.aidl",
2222 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2223 io_delegate_.SetFileContents("new/p/Foo.aidl",
2224 "package p; @FixedSize parcelable Foo { int A = 1; }");
2225 CaptureStderr();
2226 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2227 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2228}
2229
2230TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2231 const string expected_stderr =
2232 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2233 "a.\n"
2234 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2235 "b.\n"
2236 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2237 "c.\n"
2238 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2239 "d.\n"
2240 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2241 "e.\n"
2242 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2243 "f.\n";
2244
2245 io_delegate_.SetFileContents("Foo.aidl",
2246 "@FixedSize parcelable Foo { "
2247 " int[] a;"
2248 " Bar b;"
2249 " String c;"
2250 " ParcelFileDescriptor d;"
2251 " IBinder e;"
2252 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002253 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002254 "}");
2255 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2256 Options options =
2257 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2258
2259 CaptureStderr();
2260 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2261 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2262}
2263
2264TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2265 const string expected_stderr = "";
2266
2267 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2268 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2269 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2270 Options options =
2271 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2272
2273 CaptureStderr();
2274 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2275 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2276}
2277
Jiyong Park8c380532018-08-30 14:55:26 +09002278TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002279 const string expected_stderr =
2280 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2281 "dir1/q/IBar.aidl\n"
2282 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002283 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002284 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2285 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2286 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2287 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2288
Devin Moore097a3ab2020-03-11 16:08:44 -07002289 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002290 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002292}
2293
Jiyong Parked65bf42018-08-28 15:43:27 +09002294TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002295 const string expected_stderr =
2296 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2297 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002298 Options options = Options::From("aidl --checkapi old new");
2299 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2300 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002301
2302 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2303
Jiyong Parke59c3682018-09-11 23:10:25 +09002304 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002305 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002306 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002307 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002308}
2309
Jiyong Parke05195e2018-10-08 18:24:23 +09002310TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2311 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2312 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002313 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002314
2315 // use without import
2316 io_delegate_.SetFileContents("p/IFoo.aidl",
2317 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2318 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2319 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002320 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002321
Devin Moore7b8d5c92020-03-17 14:14:08 -07002322 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002323 io_delegate_.SetFileContents(
2324 "p/IFoo.aidl",
2325 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2326 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2327 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002328 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002329
2330 // use with import (as before)
2331 io_delegate_.SetFileContents("p/IFoo.aidl",
2332 "package p;"
2333 "import android.os.ParcelFileDescriptor;"
2334 "interface IFoo{"
2335 " void foo(in ParcelFileDescriptor fd);"
2336 "}");
2337 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2338 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002339 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002340}
Jiyong Parked65bf42018-08-28 15:43:27 +09002341
Jiyong Park3633b722019-04-11 15:38:26 +09002342TEST_F(AidlTest, ManualIds) {
2343 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2344 io_delegate_.SetFileContents("IFoo.aidl",
2345 "interface IFoo {\n"
2346 " void foo() = 0;\n"
2347 " void bar() = 1;\n"
2348 "}");
2349 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2350}
2351
2352TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2353 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2354 io_delegate_.SetFileContents("IFoo.aidl",
2355 "interface IFoo {\n"
2356 " void foo() = 0;\n"
2357 " void bar() = 1;\n"
2358 "}");
2359 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2360}
2361
2362TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002363 const string expected_stderr =
2364 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002365 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2366 io_delegate_.SetFileContents("IFoo.aidl",
2367 "interface IFoo {\n"
2368 " void foo() = 3;\n"
2369 " void bar() = 3;\n"
2370 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002371 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002372 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002374}
2375
2376TEST_F(AidlTest, FailOnOutOfRangeIds) {
2377 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002378 const string expected_stderr =
2379 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2380 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002381 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2382 io_delegate_.SetFileContents("IFoo.aidl",
2383 "interface IFoo {\n"
2384 " void foo() = 3;\n"
2385 " void bar() = 16777115;\n"
2386 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002388 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002389 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002390}
2391
2392TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002393 const string expected_stderr =
2394 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002395 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2396 io_delegate_.SetFileContents("IFoo.aidl",
2397 "interface IFoo {\n"
2398 " void foo() = 3;\n"
2399 " void bar();\n"
2400 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002401 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002402 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002403 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002404}
2405
Jiyong Parkc6816252019-07-08 08:12:28 +09002406TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2407 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2408 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2409 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2410 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2411}
2412
2413TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002414 const string expected_stderr =
2415 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2416 "dir/IBar.aidl\n"
2417 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002418 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002419
Jiyong Parkc6816252019-07-08 08:12:28 +09002420 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2421 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2422 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2423 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002425 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002427}
2428
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002429TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2430 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2431 "package a.b;\n"
2432 "import a.b.IBar;\n"
2433 "import a.b.IQux;\n"
2434 "interface IFoo { IQux foo(); }\n");
2435 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2436 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2437
2438 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2439 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2440
2441 string output;
2442 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2443 // IBar was imported but wasn't used. include is not expected.
2444 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2445 // IBar was imported and used. include is expected.
2446 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2447}
2448
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002449TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002450 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002451 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002452 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2453 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002454 interface IFoo {
2455 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002456 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002457 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002458 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002459 // JavaPassthrough should work with other types as well (e.g. enum)
2460 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2461 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2462 @JavaPassthrough(annotation="@com.android.AliceTwo")
2463 @Backing(type="byte")
2464 enum MyEnum {
2465 a, b, c
2466 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002467
Jooyung Han4cde01d2020-10-13 11:10:47 +09002468 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002469 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2470
2471 string java_out;
2472 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002473 // type-decl-level annotations with newline at the end
2474 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2475 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2476 // member-decl-level annotations with newline at the end
2477 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2478 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2479 // inline annotations with space at the end
2480 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002481
Jooyung Han4cde01d2020-10-13 11:10:47 +09002482 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2483 // type-decl-level annotations with newline at the end
2484 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2485 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2486
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002487 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002488 Options cpp_options =
2489 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002490 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2491
Jooyung Han4cde01d2020-10-13 11:10:47 +09002492 Options ndk_options =
2493 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002494 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002495
Jooyung Han4cde01d2020-10-13 11:10:47 +09002496 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002497 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002498}
2499
Andrei Homescue61feb52020-08-18 15:44:24 -07002500TEST_F(AidlTest, ParseRustDerive) {
2501 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2502 @RustDerive(Clone=true, Copy=false)
2503 parcelable Foo {
2504 int a;
2505 })");
2506
2507 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2508 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2509
2510 string rust_out;
2511 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2512 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2513
2514 // Other backends shouldn't be bothered
2515 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2516 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2517
2518 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2519 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2520
2521 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2522 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2523}
2524
Jiyong Park56f73d72019-06-11 12:20:28 +09002525class AidlOutputPathTest : public AidlTest {
2526 protected:
2527 void SetUp() override {
2528 AidlTest::SetUp();
2529 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2530 }
2531
2532 void Test(const Options& options, const std::string expected_output_path) {
2533 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2534 // check the existence
2535 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2536 }
2537};
2538
2539TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2540 // <out_dir> / <package_name> / <type_name>.java
2541 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2542}
2543
2544TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2545 // when output file is explicitly set, it is always respected. -o option is
2546 // ignored.
2547 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2548}
2549
2550TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2551 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2552}
2553
2554TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2555 // output is the same as the input file except for the suffix
2556 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2557}
2558
Devin Moore7b8d5c92020-03-17 14:14:08 -07002559TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002560 AidlError error;
2561 const string expected_stderr =
2562 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2563 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002564 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2565 R"(package p;
2566 interface IFoo {
2567 const int int32_max_oob = 2147483650;
2568 }
2569 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002570 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002571 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2572 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002573}
2574
Devin Moore7b8d5c92020-03-17 14:14:08 -07002575TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002576 AidlError error;
2577 const string expected_stderr =
2578 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2579 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002580 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2581 R"(package p;
2582 interface IFoo {
2583 const int int32_min_oob = -2147483650;
2584 }
2585 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002586 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002587 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2588 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002589}
2590
Devin Moore7b8d5c92020-03-17 14:14:08 -07002591TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 AidlError error;
2593 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002594 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002595 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002596 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2597 R"(package p;
2598 interface IFoo {
2599 const long int64_max_oob = 21474836509999999999999999;
2600 }
2601 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002602 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002603 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2604 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002605}
2606
Devin Moore7b8d5c92020-03-17 14:14:08 -07002607TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002608 AidlError error;
2609 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002610 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002611 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002612 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2613 R"(package p;
2614 interface IFoo {
2615 const long int64_min_oob = -21474836509999999999999999;
2616 }
2617 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002618 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002619 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2620 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002621}
2622
Devin Moore7b8d5c92020-03-17 14:14:08 -07002623TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002624 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002625 const string expected_stderr =
2626 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2627 "literal: byte\n"
2628 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2629 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002630 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2631 R"(package p;
2632 @Backing(type="byte")
2633 enum TestEnum {
2634 FOO = 127,
2635 BAR,
2636 }
2637 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002638 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002639 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002640 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002641}
2642
Devin Mooredecaf292020-04-30 09:16:40 -07002643TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2644 AidlError error;
2645 const string expected_stderr =
2646 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2647 "be one of: type\n"
2648 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2649 "be one of: type\n";
2650 CaptureStderr();
2651 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2652 R"(package p;
2653 @Backing(foo="byte")
2654 enum TestEnum {
2655 FOO = 1,
2656 BAR,
2657 }
2658 )",
2659 typenames_, GetLanguage(), &error));
2660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2661 EXPECT_EQ(AidlError::BAD_TYPE, error);
2662}
2663
Jeongik Chad0a10272020-08-06 16:33:36 +09002664TEST_P(AidlTest, SupportJavaOnlyImmutableAnnotation) {
2665 io_delegate_.SetFileContents("Foo.aidl",
2666 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2667 "Map<String, Baz> d; Bar[] e; }");
2668 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2669 io_delegate_.SetFileContents("Baz.aidl",
2670 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002671 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2672 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2673}
2674
Jeongik Chad0a10272020-08-06 16:33:36 +09002675TEST_P(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
2676 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002677 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2678 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2679 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2680}
2681
2682TEST_P(AidlTest, ImmtuableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002683 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002684 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2685 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2686 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2687}
2688
2689TEST_P(AidlTest, ImmtuableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002690 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002691 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2692 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2693 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2694}
2695
Jeongik Cha91180252020-07-31 15:43:11 +09002696TEST_P(AidlTest, ImmtuableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002697 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002698 Options options = Options::From("aidl --lang=java Foo.aidl");
2699 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002700 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002701 "capitalizing the first letter\n";
2702 CaptureStderr();
2703 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2704 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2705}
Devin Moore53fc99c2020-08-12 08:07:52 -07002706
Jooyung Han1f14ab32020-10-14 13:48:29 +09002707const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2708
2709#include <a/ByteEnum.h>
2710#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002711#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002712#include <binder/Status.h>
2713#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002714#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002715#include <utility>
2716#include <variant>
2717#include <vector>
2718
2719namespace a {
2720
2721class Foo : public ::android::Parcelable {
2722public:
Jooyung Han97945de2020-10-15 16:41:38 +09002723 inline bool operator!=(const Foo& rhs) const {
2724 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002725 }
Jooyung Han97945de2020-10-15 16:41:38 +09002726 inline bool operator<(const Foo& rhs) const {
2727 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002728 }
Jooyung Han97945de2020-10-15 16:41:38 +09002729 inline bool operator<=(const Foo& rhs) const {
2730 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002731 }
Jooyung Han97945de2020-10-15 16:41:38 +09002732 inline bool operator==(const Foo& rhs) const {
2733 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002734 }
Jooyung Han97945de2020-10-15 16:41:38 +09002735 inline bool operator>(const Foo& rhs) const {
2736 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002737 }
Jooyung Han97945de2020-10-15 16:41:38 +09002738 inline bool operator>=(const Foo& rhs) const {
2739 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002740 }
Jooyung Han97945de2020-10-15 16:41:38 +09002741
Jooyung Han1f14ab32020-10-14 13:48:29 +09002742 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002743 ns = 0, // int[] ns;
2744 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002745 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002746 };
Jooyung Han97945de2020-10-15 16:41:38 +09002747
Jooyung Han1f14ab32020-10-14 13:48:29 +09002748 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002749 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002750
2751 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002752 Foo(const Foo&) = default;
2753 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002754 Foo& operator=(const Foo&) = default;
2755 Foo& operator=(Foo&&) = default;
2756
Jooyung Han97945de2020-10-15 16:41:38 +09002757 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2758 constexpr Foo(_Tp&& _arg)
2759 : _value(std::forward<_Tp>(_arg)) {}
2760
2761 template <typename... _Tp>
2762 constexpr explicit Foo(_Tp&&... _args)
2763 : _value(std::forward<_Tp>(_args)...) {}
2764
2765 template <Tag _tag, typename... _Tp>
2766 static Foo make(_Tp&&... _args) {
2767 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002768 }
Jooyung Han97945de2020-10-15 16:41:38 +09002769
2770 template <Tag _tag, typename _Tp, typename... _Up>
2771 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2772 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002773 }
2774
2775 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002776 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002777 }
2778
Jooyung Han97945de2020-10-15 16:41:38 +09002779 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002780 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002781 if (getTag() != _tag) { abort(); }
2782 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002783 }
2784
Jooyung Han97945de2020-10-15 16:41:38 +09002785 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002786 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002787 if (getTag() != _tag) { abort(); }
2788 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002789 }
2790
Jooyung Han97945de2020-10-15 16:41:38 +09002791 template <Tag _tag, typename... _Tp>
2792 void set(_Tp&&... _args) {
2793 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002794 }
2795
2796 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2797 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2798 static const std::string& getParcelableDescriptor() {
2799 static const std::string DESCIPTOR = "a.Foo";
2800 return DESCIPTOR;
2801 }
2802private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002803 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002804}; // class Foo
2805
2806} // namespace a
2807)";
2808
2809const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2810
2811namespace a {
2812
2813::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2814 ::android::status_t _aidl_ret_status;
2815 int32_t _aidl_tag;
2816 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2817 switch (_aidl_tag) {
2818 case ns: {
2819 ::std::vector<int32_t> _aidl_value;
2820 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2821 set<ns>(std::move(_aidl_value));
2822 return ::android::OK; }
2823 case e: {
2824 ::a::ByteEnum _aidl_value;
2825 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2826 set<e>(std::move(_aidl_value));
2827 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002828 case pfd: {
2829 ::android::os::ParcelFileDescriptor _aidl_value;
2830 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2831 set<pfd>(std::move(_aidl_value));
2832 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09002833 }
2834 return ::android::BAD_VALUE;
2835}
2836
2837::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2838 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2839 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2840 switch (getTag()) {
2841 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2842 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002843 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002844 }
2845 abort();
2846}
2847
2848} // namespace a
2849)";
2850
Jooyung Han6beac042020-10-17 21:59:43 +09002851const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
2852#include <android/binder_interface_utils.h>
2853#include <android/binder_parcelable_utils.h>
2854
2855#include <type_traits>
2856#include <utility>
2857#include <variant>
2858#include <cstdint>
2859#include <memory>
2860#include <optional>
2861#include <string>
2862#include <vector>
2863#ifdef BINDER_STABILITY_SUPPORT
2864#include <android/binder_stability.h>
2865#endif // BINDER_STABILITY_SUPPORT
2866#include <aidl/a/ByteEnum.h>
2867namespace aidl {
2868namespace a {
2869class Foo {
2870public:
2871 typedef std::false_type fixed_size;
2872 static const char* descriptor;
2873
2874 enum Tag : int32_t {
2875 ns = 0, // int[] ns;
2876 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002877 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09002878 };
2879
2880 template<typename _Tp>
2881 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
2882
2883 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
2884 Foo(const Foo&) = default;
2885 Foo(Foo&&) = default;
2886 Foo& operator=(const Foo&) = default;
2887 Foo& operator=(Foo&&) = default;
2888
2889 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2890 constexpr Foo(_Tp&& _arg)
2891 : _value(std::forward<_Tp>(_arg)) {}
2892
2893 template <typename... _Tp>
2894 constexpr explicit Foo(_Tp&&... _args)
2895 : _value(std::forward<_Tp>(_args)...) {}
2896
2897 template <Tag _tag, typename... _Tp>
2898 static Foo make(_Tp&&... _args) {
2899 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
2900 }
2901
2902 template <Tag _tag, typename _Tp, typename... _Up>
2903 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2904 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
2905 }
2906
2907 Tag getTag() const {
2908 return static_cast<Tag>(_value.index());
2909 }
2910
2911 template <Tag _tag>
2912 const auto& get() const {
2913 if (getTag() != _tag) { abort(); }
2914 return std::get<_tag>(_value);
2915 }
2916
2917 template <Tag _tag>
2918 auto& get() {
2919 if (getTag() != _tag) { abort(); }
2920 return std::get<_tag>(_value);
2921 }
2922
2923 template <Tag _tag, typename... _Tp>
2924 void set(_Tp&&... _args) {
2925 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
2926 }
2927
2928 binder_status_t readFromParcel(const AParcel* _parcel);
2929 binder_status_t writeToParcel(AParcel* _parcel) const;
2930 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
2931private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002932 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09002933};
2934} // namespace a
2935} // namespace aidl
2936)";
2937
2938const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
2939
2940#include <android/binder_parcel_utils.h>
2941
2942namespace aidl {
2943namespace a {
2944const char* Foo::descriptor = "a.Foo";
2945
2946binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
2947 binder_status_t _aidl_ret_status;
2948 int32_t _aidl_tag;
2949 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
2950 switch (_aidl_tag) {
2951 case ns: {
2952 std::vector<int32_t> _aidl_value;
2953 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
2954 set<ns>(std::move(_aidl_value));
2955 return STATUS_OK; }
2956 case e: {
2957 ::aidl::a::ByteEnum _aidl_value;
2958 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
2959 set<e>(std::move(_aidl_value));
2960 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002961 case pfd: {
2962 ::ndk::ScopedFileDescriptor _aidl_value;
2963 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
2964 set<pfd>(std::move(_aidl_value));
2965 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09002966 }
2967 return STATUS_BAD_VALUE;
2968}
2969binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
2970 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
2971 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
2972 switch (getTag()) {
2973 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
2974 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002975 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09002976 }
2977 abort();
2978}
2979
2980} // namespace a
2981} // namespace aidl
2982)";
2983
Jooyung Han1f14ab32020-10-14 13:48:29 +09002984const char kUnionExampleExpectedOutputJava[] = R"(/*
2985 * This file is auto-generated. DO NOT MODIFY.
2986 */
2987package a;
2988
2989
2990public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09002991 // tags for union fields
2992 public final static int ns = 0; // int[] ns;
2993 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002994 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002995
2996 private int _tag;
2997 private Object _value;
2998
2999 public Foo() {
3000 int[] value = {42};
3001 _set(ns, value);
3002 }
Jooyung Han97945de2020-10-15 16:41:38 +09003003
Jooyung Han1f14ab32020-10-14 13:48:29 +09003004 private Foo(android.os.Parcel _aidl_parcel) {
3005 readFromParcel(_aidl_parcel);
3006 }
Jooyung Han97945de2020-10-15 16:41:38 +09003007
Jooyung Han1f14ab32020-10-14 13:48:29 +09003008 private Foo(int tag, Object value) {
3009 _set(tag, value);
3010 }
3011
3012 public int getTag() {
3013 return _tag;
3014 }
3015
Jooyung Han97945de2020-10-15 16:41:38 +09003016 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003017
3018 public static Foo ns(int[] _value) {
3019 return new Foo(ns, _value);
3020 }
Jooyung Han97945de2020-10-15 16:41:38 +09003021
Jooyung Han1f14ab32020-10-14 13:48:29 +09003022 public int[] getNs() {
3023 _assertTag(ns);
3024 return (int[]) _value;
3025 }
Jooyung Han97945de2020-10-15 16:41:38 +09003026
Jooyung Han1f14ab32020-10-14 13:48:29 +09003027 public void setNs(int[] _value) {
3028 _set(ns, _value);
3029 }
3030
Jooyung Han97945de2020-10-15 16:41:38 +09003031 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003032
3033 public static Foo e(byte _value) {
3034 return new Foo(e, _value);
3035 }
Jooyung Han97945de2020-10-15 16:41:38 +09003036
Jooyung Han1f14ab32020-10-14 13:48:29 +09003037 public byte getE() {
3038 _assertTag(e);
3039 return (byte) _value;
3040 }
Jooyung Han97945de2020-10-15 16:41:38 +09003041
Jooyung Han1f14ab32020-10-14 13:48:29 +09003042 public void setE(byte _value) {
3043 _set(e, _value);
3044 }
3045
Jooyung Hand2fa0232020-10-19 02:51:41 +09003046 // ParcelFileDescriptor pfd;
3047
3048 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3049 return new Foo(pfd, _value);
3050 }
3051
3052 public android.os.ParcelFileDescriptor getPfd() {
3053 _assertTag(pfd);
3054 return (android.os.ParcelFileDescriptor) _value;
3055 }
3056
3057 public void setPfd(android.os.ParcelFileDescriptor _value) {
3058 _set(pfd, _value);
3059 }
3060
Jooyung Han1f14ab32020-10-14 13:48:29 +09003061 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3062 @Override
3063 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003064 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003065 }
3066 @Override
3067 public Foo[] newArray(int _aidl_size) {
3068 return new Foo[_aidl_size];
3069 }
3070 };
Jooyung Han97945de2020-10-15 16:41:38 +09003071
Jooyung Han1f14ab32020-10-14 13:48:29 +09003072 @Override
3073 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3074 _aidl_parcel.writeInt(_tag);
3075 switch (_tag) {
3076 case ns:
3077 _aidl_parcel.writeIntArray(getNs());
3078 break;
3079 case e:
3080 _aidl_parcel.writeByte(getE());
3081 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003082 case pfd:
3083 if ((getPfd()!=null)) {
3084 _aidl_parcel.writeInt(1);
3085 getPfd().writeToParcel(_aidl_parcel, 0);
3086 }
3087 else {
3088 _aidl_parcel.writeInt(0);
3089 }
3090 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003091 }
3092 }
Jooyung Han97945de2020-10-15 16:41:38 +09003093
Jooyung Han1f14ab32020-10-14 13:48:29 +09003094 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3095 int _aidl_tag;
3096 _aidl_tag = _aidl_parcel.readInt();
3097 switch (_aidl_tag) {
3098 case ns: {
3099 int[] _aidl_value;
3100 _aidl_value = _aidl_parcel.createIntArray();
3101 _set(_aidl_tag, _aidl_value);
3102 return; }
3103 case e: {
3104 byte _aidl_value;
3105 _aidl_value = _aidl_parcel.readByte();
3106 _set(_aidl_tag, _aidl_value);
3107 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003108 case pfd: {
3109 android.os.ParcelFileDescriptor _aidl_value;
3110 if ((0!=_aidl_parcel.readInt())) {
3111 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3112 }
3113 else {
3114 _aidl_value = null;
3115 }
3116 _set(_aidl_tag, _aidl_value);
3117 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003118 }
3119 throw new RuntimeException("union: out of range: " + _aidl_tag);
3120 }
Jooyung Han97945de2020-10-15 16:41:38 +09003121
Jooyung Han1f14ab32020-10-14 13:48:29 +09003122 @Override
3123 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003124 int _mask = 0;
3125 switch (getTag()) {
3126 case pfd:
3127 if (getPfd() != null) _mask |= getPfd().describeContents();
3128 break;
3129 }
3130 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003131 }
3132
3133 private void _assertTag(int tag) {
3134 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003135 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003136 }
3137 }
Jooyung Han97945de2020-10-15 16:41:38 +09003138
Jooyung Han1f14ab32020-10-14 13:48:29 +09003139 private String _tagString(int _tag) {
3140 switch (_tag) {
3141 case ns: return "ns";
3142 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003143 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003144 }
3145 throw new IllegalStateException("unknown field: " + _tag);
3146 }
Jooyung Han97945de2020-10-15 16:41:38 +09003147
Jooyung Han1f14ab32020-10-14 13:48:29 +09003148 private void _set(int tag, Object value) {
3149 this._tag = tag;
3150 this._value = value;
3151 }
3152}
3153)";
3154
Jooyung Han97945de2020-10-15 16:41:38 +09003155struct AidlUnionTest : ::testing::Test {
3156 void SetUp() override {
3157 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003158package a;
3159import a.ByteEnum;
3160union Foo {
3161 int[] ns = {42};
3162 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003163 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003164}
3165)");
Jooyung Han97945de2020-10-15 16:41:38 +09003166 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003167package a;
3168@Backing(type="byte")
3169enum ByteEnum {
3170 a, b, c
3171}
3172)");
Jooyung Han97945de2020-10-15 16:41:38 +09003173 }
3174 FakeIoDelegate io_delegate_;
3175 void Compile(string lang) {
3176 string command = "aidl --structured -I. -o out --lang=" + lang;
3177 if (lang == "cpp" || lang == "ndk") {
3178 command += " -h out";
3179 }
3180 command += " a/Foo.aidl";
3181 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003182 CaptureStderr();
3183 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3184 auto err = GetCapturedStderr();
3185 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003186 }
3187 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3188 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003189 string actual;
3190 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3191 EXPECT_EQ(expected, actual);
3192 }
Jooyung Han97945de2020-10-15 16:41:38 +09003193 }
3194};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003195
Jooyung Han97945de2020-10-15 16:41:38 +09003196TEST_F(AidlUnionTest, Example_Cpp) {
3197 Compile("cpp");
3198 EXPECT_COMPILE_OUTPUTS(
3199 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3200 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3201}
3202
Jooyung Han6beac042020-10-17 21:59:43 +09003203TEST_F(AidlUnionTest, Example_Ndk) {
3204 Compile("ndk");
3205 EXPECT_COMPILE_OUTPUTS(
3206 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3207 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3208}
3209
Jooyung Han97945de2020-10-15 16:41:38 +09003210TEST_F(AidlUnionTest, Example_Java) {
3211 Compile("java");
3212 EXPECT_COMPILE_OUTPUTS(
3213 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003214 // TODO(b/170689477) Rust
3215}
3216
Jooyung Hanfe89f122020-10-14 03:49:18 +09003217TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3218 const string method = "package a; union Foo {}";
3219 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3220 CaptureStderr();
3221 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3222 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3223}
3224
3225TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3226 const string method = "package a; union Foo { ParcelableHolder x; }";
3227 const string expected_stderr =
3228 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3229 CaptureStderr();
3230 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3231 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3232}
3233
Devin Moore53fc99c2020-08-12 08:07:52 -07003234TEST_P(AidlTest, GenericStructuredParcelable) {
3235 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3236 Options options =
3237 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3238 const string expected_stderr = "";
3239 CaptureStderr();
3240 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3241 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3242}
3243
Jooyung Han14004ed2020-10-16 03:49:57 +09003244struct GenericAidlTest : ::testing::Test {
3245 FakeIoDelegate io_delegate_;
3246 void Compile(string cmd) {
3247 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3248 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3249 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3250 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3251
3252 Options options = Options::From(cmd);
3253 CaptureStderr();
3254 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3255 EXPECT_EQ("", GetCapturedStderr());
3256 }
3257};
3258
3259TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3260 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3261 string code;
3262 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3263 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3264 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3265 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3266}
3267
3268TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3269 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3270 string code;
3271 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3272 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3273 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3274 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3275}
3276
Devin Moore53fc99c2020-08-12 08:07:52 -07003277TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3278 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3279 Options options =
3280 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3281 const string expected_stderr =
3282 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3283 CaptureStderr();
3284 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3285 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3286}
3287
3288TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3289 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3290 Options options =
3291 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3292 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3293 CaptureStderr();
3294 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3295 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3296}
3297
Christopher Wiley90be4e32015-10-20 14:55:25 -07003298} // namespace aidl
3299} // namespace android