blob: f3a476319885d96b3dc67b93c7170b8805c68550 [file] [log] [blame]
Eugene Zelenko900b6332017-08-29 22:32:07 +00001//===- InlineSpiller.cpp - Insert spills and restores inline --------------===//
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00002//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00006//
7//===----------------------------------------------------------------------===//
8//
9// The inline spiller modifies the machine function directly instead of
10// inserting spills and restores in VirtRegMap.
11//
12//===----------------------------------------------------------------------===//
13
Wei Mi8c4136b2016-05-11 22:37:43 +000014#include "SplitKit.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000015#include "llvm/ADT/ArrayRef.h"
16#include "llvm/ADT/DenseMap.h"
Wei Mi9a16d652016-04-13 03:08:27 +000017#include "llvm/ADT/MapVector.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000018#include "llvm/ADT/None.h"
19#include "llvm/ADT/STLExtras.h"
Benjamin Kramerbc6666b2013-05-23 15:42:57 +000020#include "llvm/ADT/SetVector.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000021#include "llvm/ADT/SmallPtrSet.h"
22#include "llvm/ADT/SmallVector.h"
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +000023#include "llvm/ADT/Statistic.h"
Jakob Stoklund Olesen868dd4e2010-11-10 23:55:56 +000024#include "llvm/Analysis/AliasAnalysis.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000025#include "llvm/CodeGen/LiveInterval.h"
Marcello Maggioniea11f472020-03-22 19:08:29 -070026#include "llvm/CodeGen/LiveIntervalCalc.h"
Matthias Braunf8422972017-12-13 02:51:04 +000027#include "llvm/CodeGen/LiveIntervals.h"
Pete Cooper3ca96f92012-04-02 22:44:18 +000028#include "llvm/CodeGen/LiveRangeEdit.h"
Matthias Braunef959692017-12-18 23:19:44 +000029#include "llvm/CodeGen/LiveStacks.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000030#include "llvm/CodeGen/MachineBasicBlock.h"
Benjamin Kramere2a1d892013-06-17 19:00:36 +000031#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
Chandler Carruth8a8cd2b2014-01-07 11:48:04 +000032#include "llvm/CodeGen/MachineDominators.h"
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +000033#include "llvm/CodeGen/MachineFunction.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000034#include "llvm/CodeGen/MachineFunctionPass.h"
35#include "llvm/CodeGen/MachineInstr.h"
David Blaikie0252265b2013-06-16 20:34:15 +000036#include "llvm/CodeGen/MachineInstrBuilder.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000037#include "llvm/CodeGen/MachineInstrBundle.h"
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +000038#include "llvm/CodeGen/MachineLoopInfo.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000039#include "llvm/CodeGen/MachineOperand.h"
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +000040#include "llvm/CodeGen/MachineRegisterInfo.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000041#include "llvm/CodeGen/SlotIndexes.h"
Marcello Maggionie5205072020-03-08 09:36:29 -070042#include "llvm/CodeGen/Spiller.h"
Serguei Katkov496e0a92020-02-28 17:34:33 +070043#include "llvm/CodeGen/StackMaps.h"
David Blaikie3f833ed2017-11-08 01:01:31 +000044#include "llvm/CodeGen/TargetInstrInfo.h"
David Blaikieb3bde2e2017-11-17 01:07:10 +000045#include "llvm/CodeGen/TargetOpcodes.h"
46#include "llvm/CodeGen/TargetRegisterInfo.h"
47#include "llvm/CodeGen/TargetSubtargetInfo.h"
Jakob Stoklund Olesen26c9d702012-11-28 19:13:06 +000048#include "llvm/CodeGen/VirtRegMap.h"
Nico Weber432a3882018-04-30 14:59:11 +000049#include "llvm/Config/llvm-config.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000050#include "llvm/Support/BlockFrequency.h"
51#include "llvm/Support/BranchProbability.h"
Jakob Stoklund Olesenbceb9e52011-09-15 21:06:00 +000052#include "llvm/Support/CommandLine.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000053#include "llvm/Support/Compiler.h"
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +000054#include "llvm/Support/Debug.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000055#include "llvm/Support/ErrorHandling.h"
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +000056#include "llvm/Support/raw_ostream.h"
Eugene Zelenko900b6332017-08-29 22:32:07 +000057#include <cassert>
58#include <iterator>
59#include <tuple>
60#include <utility>
61#include <vector>
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +000062
63using namespace llvm;
64
Chandler Carruth1b9dde02014-04-22 02:02:50 +000065#define DEBUG_TYPE "regalloc"
66
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +000067STATISTIC(NumSpilledRanges, "Number of spilled live ranges");
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +000068STATISTIC(NumSnippets, "Number of spilled snippets");
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +000069STATISTIC(NumSpills, "Number of spills inserted");
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +000070STATISTIC(NumSpillsRemoved, "Number of spills removed");
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +000071STATISTIC(NumReloads, "Number of reloads inserted");
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +000072STATISTIC(NumReloadsRemoved, "Number of reloads removed");
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +000073STATISTIC(NumFolded, "Number of folded stack accesses");
74STATISTIC(NumFoldedLoads, "Number of folded loads");
75STATISTIC(NumRemats, "Number of rematerialized defs for spilling");
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +000076
Jakob Stoklund Olesenbceb9e52011-09-15 21:06:00 +000077static cl::opt<bool> DisableHoisting("disable-spill-hoist", cl::Hidden,
78 cl::desc("Disable inline spill hoisting"));
Philip Reames7403fac2019-02-12 18:33:01 +000079static cl::opt<bool>
80RestrictStatepointRemat("restrict-statepoint-remat",
81 cl::init(false), cl::Hidden,
82 cl::desc("Restrict remat for statepoint operands"));
Jakob Stoklund Olesenbceb9e52011-09-15 21:06:00 +000083
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +000084namespace {
Eugene Zelenko900b6332017-08-29 22:32:07 +000085
Wei Mi963f2df2016-04-15 23:16:44 +000086class HoistSpillHelper : private LiveRangeEdit::Delegate {
87 MachineFunction &MF;
Wei Mi9a16d652016-04-13 03:08:27 +000088 LiveIntervals &LIS;
89 LiveStacks &LSS;
90 AliasAnalysis *AA;
91 MachineDominatorTree &MDT;
92 MachineLoopInfo &Loops;
93 VirtRegMap &VRM;
Wei Mi9a16d652016-04-13 03:08:27 +000094 MachineRegisterInfo &MRI;
95 const TargetInstrInfo &TII;
96 const TargetRegisterInfo &TRI;
97 const MachineBlockFrequencyInfo &MBFI;
98
Wei Mi8c4136b2016-05-11 22:37:43 +000099 InsertPointAnalysis IPA;
100
Wei Mic0d06642017-09-13 21:41:30 +0000101 // Map from StackSlot to the LiveInterval of the original register.
102 // Note the LiveInterval of the original register may have been deleted
103 // after it is spilled. We keep a copy here to track the range where
104 // spills can be moved.
105 DenseMap<int, std::unique_ptr<LiveInterval>> StackSlotToOrigLI;
Eugene Zelenko900b6332017-08-29 22:32:07 +0000106
Wei Mi9a16d652016-04-13 03:08:27 +0000107 // Map from pair of (StackSlot and Original VNI) to a set of spills which
108 // have the same stackslot and have equal values defined by Original VNI.
109 // These spills are mergeable and are hoist candiates.
Eugene Zelenko900b6332017-08-29 22:32:07 +0000110 using MergeableSpillsMap =
111 MapVector<std::pair<int, VNInfo *>, SmallPtrSet<MachineInstr *, 16>>;
Wei Mi9a16d652016-04-13 03:08:27 +0000112 MergeableSpillsMap MergeableSpills;
113
114 /// This is the map from original register to a set containing all its
115 /// siblings. To hoist a spill to another BB, we need to find out a live
116 /// sibling there and use it as the source of the new spill.
117 DenseMap<unsigned, SmallSetVector<unsigned, 16>> Virt2SiblingsMap;
118
Wei Mic0d06642017-09-13 21:41:30 +0000119 bool isSpillCandBB(LiveInterval &OrigLI, VNInfo &OrigVNI,
120 MachineBasicBlock &BB, unsigned &LiveReg);
Wei Mi9a16d652016-04-13 03:08:27 +0000121
122 void rmRedundantSpills(
123 SmallPtrSet<MachineInstr *, 16> &Spills,
124 SmallVectorImpl<MachineInstr *> &SpillsToRm,
125 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill);
126
127 void getVisitOrders(
128 MachineBasicBlock *Root, SmallPtrSet<MachineInstr *, 16> &Spills,
129 SmallVectorImpl<MachineDomTreeNode *> &Orders,
130 SmallVectorImpl<MachineInstr *> &SpillsToRm,
131 DenseMap<MachineDomTreeNode *, unsigned> &SpillsToKeep,
132 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill);
133
Wei Mic0d06642017-09-13 21:41:30 +0000134 void runHoistSpills(LiveInterval &OrigLI, VNInfo &OrigVNI,
Wei Mi9a16d652016-04-13 03:08:27 +0000135 SmallPtrSet<MachineInstr *, 16> &Spills,
136 SmallVectorImpl<MachineInstr *> &SpillsToRm,
137 DenseMap<MachineBasicBlock *, unsigned> &SpillsToIns);
138
139public:
140 HoistSpillHelper(MachineFunctionPass &pass, MachineFunction &mf,
141 VirtRegMap &vrm)
Wei Mi963f2df2016-04-15 23:16:44 +0000142 : MF(mf), LIS(pass.getAnalysis<LiveIntervals>()),
Wei Mi9a16d652016-04-13 03:08:27 +0000143 LSS(pass.getAnalysis<LiveStacks>()),
144 AA(&pass.getAnalysis<AAResultsWrapperPass>().getAAResults()),
145 MDT(pass.getAnalysis<MachineDominatorTree>()),
146 Loops(pass.getAnalysis<MachineLoopInfo>()), VRM(vrm),
Eugene Zelenko900b6332017-08-29 22:32:07 +0000147 MRI(mf.getRegInfo()), TII(*mf.getSubtarget().getInstrInfo()),
Wei Mi9a16d652016-04-13 03:08:27 +0000148 TRI(*mf.getSubtarget().getRegisterInfo()),
Wei Mi8c4136b2016-05-11 22:37:43 +0000149 MBFI(pass.getAnalysis<MachineBlockFrequencyInfo>()),
150 IPA(LIS, mf.getNumBlockIDs()) {}
Wei Mi9a16d652016-04-13 03:08:27 +0000151
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000152 void addToMergeableSpills(MachineInstr &Spill, int StackSlot,
Wei Mi9a16d652016-04-13 03:08:27 +0000153 unsigned Original);
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000154 bool rmFromMergeableSpills(MachineInstr &Spill, int StackSlot);
Wei Mi963f2df2016-04-15 23:16:44 +0000155 void hoistAllSpills();
156 void LRE_DidCloneVirtReg(unsigned, unsigned) override;
Wei Mi9a16d652016-04-13 03:08:27 +0000157};
158
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000159class InlineSpiller : public Spiller {
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000160 MachineFunction &MF;
161 LiveIntervals &LIS;
162 LiveStacks &LSS;
163 AliasAnalysis *AA;
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +0000164 MachineDominatorTree &MDT;
165 MachineLoopInfo &Loops;
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000166 VirtRegMap &VRM;
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000167 MachineRegisterInfo &MRI;
168 const TargetInstrInfo &TII;
169 const TargetRegisterInfo &TRI;
Benjamin Kramere2a1d892013-06-17 19:00:36 +0000170 const MachineBlockFrequencyInfo &MBFI;
Jakob Stoklund Olesenbde96ad2010-06-30 23:03:52 +0000171
172 // Variables that are valid during spill(), but used by multiple methods.
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000173 LiveRangeEdit *Edit;
Jakob Stoklund Olesene4663452011-03-26 22:16:41 +0000174 LiveInterval *StackInt;
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000175 int StackSlot;
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +0000176 unsigned Original;
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000177
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000178 // All registers to spill to StackSlot, including the main register.
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000179 SmallVector<unsigned, 8> RegsToSpill;
180
181 // All COPY instructions to/from snippets.
182 // They are ignored since both operands refer to the same stack slot.
183 SmallPtrSet<MachineInstr*, 8> SnippetCopies;
184
Jakob Stoklund Olesen2edaa2f2010-10-20 22:00:51 +0000185 // Values that failed to remat at some point.
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000186 SmallPtrSet<VNInfo*, 8> UsedValues;
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000187
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000188 // Dead defs generated during spilling.
189 SmallVector<MachineInstr*, 8> DeadDefs;
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +0000190
Wei Mi9a16d652016-04-13 03:08:27 +0000191 // Object records spills information and does the hoisting.
192 HoistSpillHelper HSpiller;
193
Eugene Zelenko900b6332017-08-29 22:32:07 +0000194 ~InlineSpiller() override = default;
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000195
196public:
Eric Christopherd9134482014-08-04 21:25:23 +0000197 InlineSpiller(MachineFunctionPass &pass, MachineFunction &mf, VirtRegMap &vrm)
198 : MF(mf), LIS(pass.getAnalysis<LiveIntervals>()),
199 LSS(pass.getAnalysis<LiveStacks>()),
Chandler Carruth7b560d42015-09-09 17:55:00 +0000200 AA(&pass.getAnalysis<AAResultsWrapperPass>().getAAResults()),
Eric Christopherd9134482014-08-04 21:25:23 +0000201 MDT(pass.getAnalysis<MachineDominatorTree>()),
202 Loops(pass.getAnalysis<MachineLoopInfo>()), VRM(vrm),
Eugene Zelenko900b6332017-08-29 22:32:07 +0000203 MRI(mf.getRegInfo()), TII(*mf.getSubtarget().getInstrInfo()),
Eric Christopherfc6de422014-08-05 02:39:49 +0000204 TRI(*mf.getSubtarget().getRegisterInfo()),
Wei Mi9a16d652016-04-13 03:08:27 +0000205 MBFI(pass.getAnalysis<MachineBlockFrequencyInfo>()),
206 HSpiller(pass, mf, vrm) {}
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000207
Craig Topper4584cd52014-03-07 09:26:03 +0000208 void spill(LiveRangeEdit &) override;
Wei Mi9a16d652016-04-13 03:08:27 +0000209 void postOptimization() override;
Jakob Stoklund Olesen72911e42010-10-14 23:49:52 +0000210
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000211private:
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000212 bool isSnippet(const LiveInterval &SnipLI);
213 void collectRegsToSpill();
214
David Majnemer42531262016-08-12 03:55:06 +0000215 bool isRegToSpill(unsigned Reg) { return is_contained(RegsToSpill, Reg); }
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000216
217 bool isSibling(unsigned Reg);
Wei Mi9a16d652016-04-13 03:08:27 +0000218 bool hoistSpillInsideBB(LiveInterval &SpillLI, MachineInstr &CopyMI);
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000219 void eliminateRedundantSpills(LiveInterval &LI, VNInfo *VNI);
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000220
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000221 void markValueUsed(LiveInterval*, VNInfo*);
Philip Reames7403fac2019-02-12 18:33:01 +0000222 bool canGuaranteeAssignmentAfterRemat(unsigned VReg, MachineInstr &MI);
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000223 bool reMaterializeFor(LiveInterval &, MachineInstr &MI);
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000224 void reMaterializeAll();
225
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000226 bool coalesceStackAccess(MachineInstr *MI, unsigned Reg);
Eugene Zelenko900b6332017-08-29 22:32:07 +0000227 bool foldMemoryOperand(ArrayRef<std::pair<MachineInstr *, unsigned>>,
Craig Topperc0196b12014-04-14 00:51:57 +0000228 MachineInstr *LoadMI = nullptr);
Mark Lacey9d8103d2013-08-14 23:50:16 +0000229 void insertReload(unsigned VReg, SlotIndex, MachineBasicBlock::iterator MI);
230 void insertSpill(unsigned VReg, bool isKill, MachineBasicBlock::iterator MI);
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000231
232 void spillAroundUses(unsigned Reg);
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +0000233 void spillAll();
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000234};
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000235
Eugene Zelenko900b6332017-08-29 22:32:07 +0000236} // end anonymous namespace
Lang Hamescdd90772014-11-06 19:12:38 +0000237
Eugene Zelenko900b6332017-08-29 22:32:07 +0000238Spiller::~Spiller() = default;
Lang Hamescdd90772014-11-06 19:12:38 +0000239
Eugene Zelenko900b6332017-08-29 22:32:07 +0000240void Spiller::anchor() {}
241
242Spiller *llvm::createInlineSpiller(MachineFunctionPass &pass,
243 MachineFunction &mf,
244 VirtRegMap &vrm) {
Jakob Stoklund Olesen0fef9dd2010-07-20 23:50:15 +0000245 return new InlineSpiller(pass, mf, vrm);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000246}
Lang Hamescdd90772014-11-06 19:12:38 +0000247
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000248//===----------------------------------------------------------------------===//
249// Snippets
250//===----------------------------------------------------------------------===//
251
252// When spilling a virtual register, we also spill any snippets it is connected
253// to. The snippets are small live ranges that only have a single real use,
254// leftovers from live range splitting. Spilling them enables memory operand
255// folding or tightens the live range around the single use.
256//
257// This minimizes register pressure and maximizes the store-to-load distance for
258// spill slots which can be important in tight loops.
259
260/// isFullCopyOf - If MI is a COPY to or from Reg, return the other register,
261/// otherwise return 0.
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000262static unsigned isFullCopyOf(const MachineInstr &MI, unsigned Reg) {
263 if (!MI.isFullCopy())
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000264 return 0;
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000265 if (MI.getOperand(0).getReg() == Reg)
266 return MI.getOperand(1).getReg();
267 if (MI.getOperand(1).getReg() == Reg)
268 return MI.getOperand(0).getReg();
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000269 return 0;
270}
271
272/// isSnippet - Identify if a live interval is a snippet that should be spilled.
273/// It is assumed that SnipLI is a virtual register with the same original as
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000274/// Edit->getReg().
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000275bool InlineSpiller::isSnippet(const LiveInterval &SnipLI) {
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000276 unsigned Reg = Edit->getReg();
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000277
278 // A snippet is a tiny live range with only a single instruction using it
279 // besides copies to/from Reg or spills/fills. We accept:
280 //
281 // %snip = COPY %Reg / FILL fi#
282 // %snip = USE %snip
283 // %Reg = COPY %snip / SPILL %snip, fi#
284 //
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000285 if (SnipLI.getNumValNums() > 2 || !LIS.intervalIsInOneMBB(SnipLI))
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000286 return false;
287
Craig Topperc0196b12014-04-14 00:51:57 +0000288 MachineInstr *UseMI = nullptr;
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000289
290 // Check that all uses satisfy our criteria.
Owen Andersonabb90c92014-03-13 06:02:25 +0000291 for (MachineRegisterInfo::reg_instr_nodbg_iterator
292 RI = MRI.reg_instr_nodbg_begin(SnipLI.reg),
293 E = MRI.reg_instr_nodbg_end(); RI != E; ) {
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000294 MachineInstr &MI = *RI++;
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000295
296 // Allow copies to/from Reg.
297 if (isFullCopyOf(MI, Reg))
298 continue;
299
300 // Allow stack slot loads.
301 int FI;
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000302 if (SnipLI.reg == TII.isLoadFromStackSlot(MI, FI) && FI == StackSlot)
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000303 continue;
304
305 // Allow stack slot stores.
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000306 if (SnipLI.reg == TII.isStoreToStackSlot(MI, FI) && FI == StackSlot)
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000307 continue;
308
309 // Allow a single additional instruction.
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000310 if (UseMI && &MI != UseMI)
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000311 return false;
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000312 UseMI = &MI;
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000313 }
314 return true;
315}
316
317/// collectRegsToSpill - Collect live range snippets that only have a single
318/// real use.
319void InlineSpiller::collectRegsToSpill() {
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000320 unsigned Reg = Edit->getReg();
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000321
322 // Main register always spills.
323 RegsToSpill.assign(1, Reg);
324 SnippetCopies.clear();
325
326 // Snippets all have the same original, so there can't be any for an original
327 // register.
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +0000328 if (Original == Reg)
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000329 return;
330
Owen Andersonabb90c92014-03-13 06:02:25 +0000331 for (MachineRegisterInfo::reg_instr_iterator
332 RI = MRI.reg_instr_begin(Reg), E = MRI.reg_instr_end(); RI != E; ) {
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000333 MachineInstr &MI = *RI++;
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000334 unsigned SnipReg = isFullCopyOf(MI, Reg);
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000335 if (!isSibling(SnipReg))
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000336 continue;
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000337 LiveInterval &SnipLI = LIS.getInterval(SnipReg);
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000338 if (!isSnippet(SnipLI))
339 continue;
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000340 SnippetCopies.insert(&MI);
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000341 if (isRegToSpill(SnipReg))
342 continue;
343 RegsToSpill.push_back(SnipReg);
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000344 LLVM_DEBUG(dbgs() << "\talso spill snippet " << SnipLI << '\n');
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000345 ++NumSnippets;
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000346 }
347}
348
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000349bool InlineSpiller::isSibling(unsigned Reg) {
Daniel Sanders2bea69b2019-08-01 23:27:28 +0000350 return Register::isVirtualRegister(Reg) && VRM.getOriginal(Reg) == Original;
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000351}
352
Wei Mi9a16d652016-04-13 03:08:27 +0000353/// It is beneficial to spill to earlier place in the same BB in case
354/// as follows:
355/// There is an alternative def earlier in the same MBB.
356/// Hoist the spill as far as possible in SpillMBB. This can ease
357/// register pressure:
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000358///
Wei Mi9a16d652016-04-13 03:08:27 +0000359/// x = def
360/// y = use x
361/// s = copy x
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000362///
Wei Mi9a16d652016-04-13 03:08:27 +0000363/// Hoisting the spill of s to immediately after the def removes the
364/// interference between x and y:
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000365///
Wei Mi9a16d652016-04-13 03:08:27 +0000366/// x = def
367/// spill x
Francis Visoiu Mistriha8a83d12017-12-07 10:40:31 +0000368/// y = use killed x
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000369///
Wei Mi9a16d652016-04-13 03:08:27 +0000370/// This hoist only helps when the copy kills its source.
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000371///
Wei Mi9a16d652016-04-13 03:08:27 +0000372bool InlineSpiller::hoistSpillInsideBB(LiveInterval &SpillLI,
373 MachineInstr &CopyMI) {
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000374 SlotIndex Idx = LIS.getInstructionIndex(CopyMI);
Wei Mi9a16d652016-04-13 03:08:27 +0000375#ifndef NDEBUG
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000376 VNInfo *VNI = SpillLI.getVNInfoAt(Idx.getRegSlot());
377 assert(VNI && VNI->def == Idx.getRegSlot() && "Not defined by copy");
Wei Mi9a16d652016-04-13 03:08:27 +0000378#endif
Wei Mifb5252c2016-04-04 17:45:03 +0000379
Daniel Sanders0c476112019-08-15 19:22:08 +0000380 Register SrcReg = CopyMI.getOperand(1).getReg();
Wei Mi9a16d652016-04-13 03:08:27 +0000381 LiveInterval &SrcLI = LIS.getInterval(SrcReg);
382 VNInfo *SrcVNI = SrcLI.getVNInfoAt(Idx);
383 LiveQueryResult SrcQ = SrcLI.Query(Idx);
384 MachineBasicBlock *DefMBB = LIS.getMBBFromIndex(SrcVNI->def);
385 if (DefMBB != CopyMI.getParent() || !SrcQ.isKill())
Hans Wennborg5a7723c2016-04-08 15:17:43 +0000386 return false;
387
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000388 // Conservatively extend the stack slot range to the range of the original
389 // value. We may be able to do better with stack slot coloring by being more
390 // careful here.
Jakob Stoklund Olesene4663452011-03-26 22:16:41 +0000391 assert(StackInt && "No stack slot assigned yet.");
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000392 LiveInterval &OrigLI = LIS.getInterval(Original);
393 VNInfo *OrigVNI = OrigLI.getVNInfoAt(Idx);
Jakob Stoklund Olesene4663452011-03-26 22:16:41 +0000394 StackInt->MergeValueInAsValue(OrigLI, OrigVNI, StackInt->getValNumInfo(0));
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000395 LLVM_DEBUG(dbgs() << "\tmerged orig valno " << OrigVNI->id << ": "
396 << *StackInt << '\n');
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000397
Wei Mi9a16d652016-04-13 03:08:27 +0000398 // We are going to spill SrcVNI immediately after its def, so clear out
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000399 // any later spills of the same value.
Wei Mi9a16d652016-04-13 03:08:27 +0000400 eliminateRedundantSpills(SrcLI, SrcVNI);
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000401
Wei Mi9a16d652016-04-13 03:08:27 +0000402 MachineBasicBlock *MBB = LIS.getMBBFromIndex(SrcVNI->def);
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000403 MachineBasicBlock::iterator MII;
Wei Mi9a16d652016-04-13 03:08:27 +0000404 if (SrcVNI->isPHIDef())
Keith Walker830a8c12016-09-16 14:07:29 +0000405 MII = MBB->SkipPHIsLabelsAndDebug(MBB->begin());
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000406 else {
Wei Mi9a16d652016-04-13 03:08:27 +0000407 MachineInstr *DefMI = LIS.getInstructionFromIndex(SrcVNI->def);
Jakob Stoklund Olesenec9b4a62011-04-30 06:42:21 +0000408 assert(DefMI && "Defining instruction disappeared");
409 MII = DefMI;
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000410 ++MII;
411 }
412 // Insert spill without kill flag immediately after def.
Wei Mi9a16d652016-04-13 03:08:27 +0000413 TII.storeRegToStackSlot(*MBB, MII, SrcReg, false, StackSlot,
414 MRI.getRegClass(SrcReg), &TRI);
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000415 --MII; // Point to store instruction.
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +0000416 LIS.InsertMachineInstrInMaps(*MII);
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000417 LLVM_DEBUG(dbgs() << "\thoisted: " << SrcVNI->def << '\t' << *MII);
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000418
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000419 HSpiller.addToMergeableSpills(*MII, StackSlot, Original);
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +0000420 ++NumSpills;
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000421 return true;
422}
423
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000424/// eliminateRedundantSpills - SLI:VNI is known to be on the stack. Remove any
425/// redundant spills of this value in SLI.reg and sibling copies.
426void InlineSpiller::eliminateRedundantSpills(LiveInterval &SLI, VNInfo *VNI) {
Jakob Stoklund Olesene55003f2011-03-20 05:44:58 +0000427 assert(VNI && "Missing value");
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000428 SmallVector<std::pair<LiveInterval*, VNInfo*>, 8> WorkList;
429 WorkList.push_back(std::make_pair(&SLI, VNI));
Jakob Stoklund Olesene4663452011-03-26 22:16:41 +0000430 assert(StackInt && "No stack slot assigned yet.");
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000431
432 do {
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000433 LiveInterval *LI;
Benjamin Kramerd6f1f842014-03-02 13:30:33 +0000434 std::tie(LI, VNI) = WorkList.pop_back_val();
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000435 unsigned Reg = LI->reg;
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000436 LLVM_DEBUG(dbgs() << "Checking redundant spills for " << VNI->id << '@'
437 << VNI->def << " in " << *LI << '\n');
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000438
439 // Regs to spill are taken care of.
440 if (isRegToSpill(Reg))
441 continue;
442
443 // Add all of VNI's live range to StackInt.
Jakob Stoklund Olesene4663452011-03-26 22:16:41 +0000444 StackInt->MergeValueInAsValue(*LI, VNI, StackInt->getValNumInfo(0));
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000445 LLVM_DEBUG(dbgs() << "Merged to stack int: " << *StackInt << '\n');
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000446
447 // Find all spills and copies of VNI.
Owen Andersonabb90c92014-03-13 06:02:25 +0000448 for (MachineRegisterInfo::use_instr_nodbg_iterator
449 UI = MRI.use_instr_nodbg_begin(Reg), E = MRI.use_instr_nodbg_end();
450 UI != E; ) {
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000451 MachineInstr &MI = *UI++;
452 if (!MI.isCopy() && !MI.mayStore())
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000453 continue;
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000454 SlotIndex Idx = LIS.getInstructionIndex(MI);
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000455 if (LI->getVNInfoAt(Idx) != VNI)
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000456 continue;
457
458 // Follow sibling copies down the dominator tree.
459 if (unsigned DstReg = isFullCopyOf(MI, Reg)) {
460 if (isSibling(DstReg)) {
461 LiveInterval &DstLI = LIS.getInterval(DstReg);
Jakob Stoklund Olesen90b5e562011-11-13 20:45:27 +0000462 VNInfo *DstVNI = DstLI.getVNInfoAt(Idx.getRegSlot());
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000463 assert(DstVNI && "Missing defined value");
Jakob Stoklund Olesen90b5e562011-11-13 20:45:27 +0000464 assert(DstVNI->def == Idx.getRegSlot() && "Wrong copy def slot");
Jakob Stoklund Olesen39488642011-03-20 05:44:55 +0000465 WorkList.push_back(std::make_pair(&DstLI, DstVNI));
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000466 }
467 continue;
468 }
469
470 // Erase spills.
471 int FI;
472 if (Reg == TII.isStoreToStackSlot(MI, FI) && FI == StackSlot) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000473 LLVM_DEBUG(dbgs() << "Redundant spill " << Idx << '\t' << MI);
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000474 // eliminateDeadDefs won't normally remove stores, so switch opcode.
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000475 MI.setDesc(TII.get(TargetOpcode::KILL));
476 DeadDefs.push_back(&MI);
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +0000477 ++NumSpillsRemoved;
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000478 if (HSpiller.rmFromMergeableSpills(MI, StackSlot))
Wei Mi9a16d652016-04-13 03:08:27 +0000479 --NumSpills;
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +0000480 }
481 }
482 } while (!WorkList.empty());
483}
484
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000485//===----------------------------------------------------------------------===//
486// Rematerialization
487//===----------------------------------------------------------------------===//
488
489/// markValueUsed - Remember that VNI failed to rematerialize, so its defining
490/// instruction cannot be eliminated. See through snippet copies
491void InlineSpiller::markValueUsed(LiveInterval *LI, VNInfo *VNI) {
492 SmallVector<std::pair<LiveInterval*, VNInfo*>, 8> WorkList;
493 WorkList.push_back(std::make_pair(LI, VNI));
494 do {
Benjamin Kramerd6f1f842014-03-02 13:30:33 +0000495 std::tie(LI, VNI) = WorkList.pop_back_val();
David Blaikie70573dc2014-11-19 07:49:26 +0000496 if (!UsedValues.insert(VNI).second)
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000497 continue;
498
499 if (VNI->isPHIDef()) {
500 MachineBasicBlock *MBB = LIS.getMBBFromIndex(VNI->def);
Craig Topper73275a22015-12-24 05:20:40 +0000501 for (MachineBasicBlock *P : MBB->predecessors()) {
502 VNInfo *PVNI = LI->getVNInfoBefore(LIS.getMBBEndIdx(P));
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000503 if (PVNI)
504 WorkList.push_back(std::make_pair(LI, PVNI));
505 }
506 continue;
507 }
508
509 // Follow snippet copies.
510 MachineInstr *MI = LIS.getInstructionFromIndex(VNI->def);
511 if (!SnippetCopies.count(MI))
512 continue;
513 LiveInterval &SnipLI = LIS.getInterval(MI->getOperand(1).getReg());
514 assert(isRegToSpill(SnipLI.reg) && "Unexpected register in copy");
Jakob Stoklund Olesen90b5e562011-11-13 20:45:27 +0000515 VNInfo *SnipVNI = SnipLI.getVNInfoAt(VNI->def.getRegSlot(true));
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000516 assert(SnipVNI && "Snippet undefined before copy");
517 WorkList.push_back(std::make_pair(&SnipLI, SnipVNI));
518 } while (!WorkList.empty());
519}
520
Philip Reames7403fac2019-02-12 18:33:01 +0000521bool InlineSpiller::canGuaranteeAssignmentAfterRemat(unsigned VReg,
522 MachineInstr &MI) {
523 if (!RestrictStatepointRemat)
524 return true;
525 // Here's a quick explanation of the problem we're trying to handle here:
526 // * There are some pseudo instructions with more vreg uses than there are
527 // physical registers on the machine.
528 // * This is normally handled by spilling the vreg, and folding the reload
529 // into the user instruction. (Thus decreasing the number of used vregs
530 // until the remainder can be assigned to physregs.)
531 // * However, since we may try to spill vregs in any order, we can end up
532 // trying to spill each operand to the instruction, and then rematting it
533 // instead. When that happens, the new live intervals (for the remats) are
534 // expected to be trivially assignable (i.e. RS_Done). However, since we
535 // may have more remats than physregs, we're guaranteed to fail to assign
536 // one.
537 // At the moment, we only handle this for STATEPOINTs since they're the only
Jay Foad8382f872020-01-03 14:05:58 +0000538 // pseudo op where we've seen this. If we start seeing other instructions
Philip Reames7403fac2019-02-12 18:33:01 +0000539 // with the same problem, we need to revisit this.
Serguei Katkov496e0a92020-02-28 17:34:33 +0700540 if (MI.getOpcode() != TargetOpcode::STATEPOINT)
541 return true;
542 // For STATEPOINTs we allow re-materialization for fixed arguments only hoping
543 // that number of physical registers is enough to cover all fixed arguments.
544 // If it is not true we need to revisit it.
545 for (unsigned Idx = StatepointOpers(&MI).getVarIdx(),
546 EndIdx = MI.getNumOperands();
547 Idx < EndIdx; ++Idx) {
548 MachineOperand &MO = MI.getOperand(Idx);
549 if (MO.isReg() && MO.getReg() == VReg)
550 return false;
551 }
552 return true;
Philip Reames7403fac2019-02-12 18:33:01 +0000553}
554
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000555/// reMaterializeFor - Attempt to rematerialize before MI instead of reloading.
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000556bool InlineSpiller::reMaterializeFor(LiveInterval &VirtReg, MachineInstr &MI) {
Patrik Hagglund296acbf2014-09-01 11:04:07 +0000557 // Analyze instruction
558 SmallVector<std::pair<MachineInstr *, unsigned>, 8> Ops;
Florian Hahn5d062562019-12-02 19:41:09 +0000559 VirtRegInfo RI = AnalyzeVirtRegInBundle(MI, VirtReg.reg, &Ops);
Patrik Hagglund296acbf2014-09-01 11:04:07 +0000560
561 if (!RI.Reads)
562 return false;
563
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000564 SlotIndex UseIdx = LIS.getInstructionIndex(MI).getRegSlot(true);
Jakob Stoklund Olesenc0dd3da2011-07-18 05:31:59 +0000565 VNInfo *ParentVNI = VirtReg.getVNInfoAt(UseIdx.getBaseIndex());
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000566
567 if (!ParentVNI) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000568 LLVM_DEBUG(dbgs() << "\tadding <undef> flags: ");
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000569 for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) {
570 MachineOperand &MO = MI.getOperand(i);
Jakob Stoklund Olesen0ed9ebc2011-03-29 17:47:02 +0000571 if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg)
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000572 MO.setIsUndef();
573 }
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000574 LLVM_DEBUG(dbgs() << UseIdx << '\t' << MI);
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000575 return true;
576 }
Jakob Stoklund Olesen2edaa2f2010-10-20 22:00:51 +0000577
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000578 if (SnippetCopies.count(&MI))
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000579 return false;
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000580
Wei Mi9a16d652016-04-13 03:08:27 +0000581 LiveInterval &OrigLI = LIS.getInterval(Original);
582 VNInfo *OrigVNI = OrigLI.getVNInfoAt(UseIdx);
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000583 LiveRangeEdit::Remat RM(ParentVNI);
Wei Mi9a16d652016-04-13 03:08:27 +0000584 RM.OrigMI = LIS.getInstructionFromIndex(OrigVNI->def);
585
586 if (!Edit->canRematerializeAt(RM, OrigVNI, UseIdx, false)) {
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000587 markValueUsed(&VirtReg, ParentVNI);
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000588 LLVM_DEBUG(dbgs() << "\tcannot remat for " << UseIdx << '\t' << MI);
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000589 return false;
590 }
591
Jakob Stoklund Olesen0ed9ebc2011-03-29 17:47:02 +0000592 // If the instruction also writes VirtReg.reg, it had better not require the
593 // same register for uses and defs.
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +0000594 if (RI.Tied) {
595 markValueUsed(&VirtReg, ParentVNI);
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000596 LLVM_DEBUG(dbgs() << "\tcannot remat tied reg: " << UseIdx << '\t' << MI);
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +0000597 return false;
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000598 }
599
Jakob Stoklund Olesen3b2966d2010-12-18 03:04:14 +0000600 // Before rematerializing into a register for a single instruction, try to
601 // fold a load into the instruction. That avoids allocating a new register.
Evan Cheng7f8e5632011-12-07 07:15:52 +0000602 if (RM.OrigMI->canFoldAsLoad() &&
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +0000603 foldMemoryOperand(Ops, RM.OrigMI)) {
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000604 Edit->markRematerialized(RM.ParentVNI);
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000605 ++NumFoldedLoads;
Jakob Stoklund Olesen3b2966d2010-12-18 03:04:14 +0000606 return true;
607 }
608
Philip Reames7403fac2019-02-12 18:33:01 +0000609 // If we can't guarantee that we'll be able to actually assign the new vreg,
610 // we can't remat.
611 if (!canGuaranteeAssignmentAfterRemat(VirtReg.reg, MI)) {
612 markValueUsed(&VirtReg, ParentVNI);
613 LLVM_DEBUG(dbgs() << "\tcannot remat for " << UseIdx << '\t' << MI);
614 return false;
615 }
616
Wolfgang Pieb8df58f42016-08-16 17:12:50 +0000617 // Allocate a new register for the remat.
Mark Lacey9d8103d2013-08-14 23:50:16 +0000618 unsigned NewVReg = Edit->createFrom(Original);
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000619
620 // Finally we can rematerialize OrigMI before MI.
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000621 SlotIndex DefIdx =
622 Edit->rematerializeAt(*MI.getParent(), MI, NewVReg, RM, TRI);
Wolfgang Pieb8df58f42016-08-16 17:12:50 +0000623
624 // We take the DebugLoc from MI, since OrigMI may be attributed to a
Junmo Park061bec82017-02-25 01:50:45 +0000625 // different source location.
Wolfgang Pieb8df58f42016-08-16 17:12:50 +0000626 auto *NewMI = LIS.getInstructionFromIndex(DefIdx);
627 NewMI->setDebugLoc(MI.getDebugLoc());
628
Mark Lacey9d8103d2013-08-14 23:50:16 +0000629 (void)DefIdx;
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000630 LLVM_DEBUG(dbgs() << "\tremat: " << DefIdx << '\t'
631 << *LIS.getInstructionFromIndex(DefIdx));
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000632
633 // Replace operands
Craig Topper73275a22015-12-24 05:20:40 +0000634 for (const auto &OpPair : Ops) {
635 MachineOperand &MO = OpPair.first->getOperand(OpPair.second);
Jakob Stoklund Olesen0ed9ebc2011-03-29 17:47:02 +0000636 if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg) {
Mark Lacey9d8103d2013-08-14 23:50:16 +0000637 MO.setReg(NewVReg);
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000638 MO.setIsKill();
639 }
640 }
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000641 LLVM_DEBUG(dbgs() << "\t " << UseIdx << '\t' << MI << '\n');
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000642
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000643 ++NumRemats;
Jakob Stoklund Olesenbde96ad2010-06-30 23:03:52 +0000644 return true;
645}
646
Jakob Stoklund Olesen72911e42010-10-14 23:49:52 +0000647/// reMaterializeAll - Try to rematerialize as many uses as possible,
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000648/// and trim the live ranges after.
649void InlineSpiller::reMaterializeAll() {
Pete Cooper2bde2f42012-04-02 22:22:53 +0000650 if (!Edit->anyRematerializable(AA))
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000651 return;
652
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000653 UsedValues.clear();
Jakob Stoklund Olesen2edaa2f2010-10-20 22:00:51 +0000654
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000655 // Try to remat before all uses of snippets.
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000656 bool anyRemat = false;
Craig Topper73275a22015-12-24 05:20:40 +0000657 for (unsigned Reg : RegsToSpill) {
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000658 LiveInterval &LI = LIS.getInterval(Reg);
Patrik Hagglund296acbf2014-09-01 11:04:07 +0000659 for (MachineRegisterInfo::reg_bundle_iterator
660 RegI = MRI.reg_bundle_begin(Reg), E = MRI.reg_bundle_end();
661 RegI != E; ) {
Duncan P. N. Exon Smithd6ebd072016-02-27 20:23:14 +0000662 MachineInstr &MI = *RegI++;
Patrik Hagglund296acbf2014-09-01 11:04:07 +0000663
664 // Debug values are not allowed to affect codegen.
Shiva Chen21eab932018-05-16 02:57:26 +0000665 if (MI.isDebugValue())
Patrik Hagglund296acbf2014-09-01 11:04:07 +0000666 continue;
667
Shiva Chen21eab932018-05-16 02:57:26 +0000668 assert(!MI.isDebugInstr() && "Did not expect to find a use in debug "
669 "instruction that isn't a DBG_VALUE");
670
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000671 anyRemat |= reMaterializeFor(LI, MI);
Owen Andersonabb90c92014-03-13 06:02:25 +0000672 }
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000673 }
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000674 if (!anyRemat)
675 return;
676
677 // Remove any values that were completely rematted.
Craig Topper73275a22015-12-24 05:20:40 +0000678 for (unsigned Reg : RegsToSpill) {
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000679 LiveInterval &LI = LIS.getInterval(Reg);
680 for (LiveInterval::vni_iterator I = LI.vni_begin(), E = LI.vni_end();
681 I != E; ++I) {
682 VNInfo *VNI = *I;
Jakob Stoklund Olesenadd79c62011-03-29 17:47:00 +0000683 if (VNI->isUnused() || VNI->isPHIDef() || UsedValues.count(VNI))
Jakob Stoklund Olesencf6c5c92010-07-02 19:54:40 +0000684 continue;
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000685 MachineInstr *MI = LIS.getInstructionFromIndex(VNI->def);
686 MI->addRegisterDead(Reg, &TRI);
687 if (!MI->allDefsAreDead())
688 continue;
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000689 LLVM_DEBUG(dbgs() << "All defs dead: " << *MI);
Jakob Stoklund Olesend8af5292011-03-29 03:12:02 +0000690 DeadDefs.push_back(MI);
Jakob Stoklund Olesencf6c5c92010-07-02 19:54:40 +0000691 }
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000692 }
Jakob Stoklund Olesenadd79c62011-03-29 17:47:00 +0000693
694 // Eliminate dead code after remat. Note that some snippet copies may be
695 // deleted here.
696 if (DeadDefs.empty())
697 return;
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000698 LLVM_DEBUG(dbgs() << "Remat created " << DeadDefs.size() << " dead defs.\n");
Wei Mic0223702016-07-08 21:08:09 +0000699 Edit->eliminateDeadDefs(DeadDefs, RegsToSpill, AA);
Jakob Stoklund Olesenadd79c62011-03-29 17:47:00 +0000700
Wei Mia62f0582016-02-05 18:14:24 +0000701 // LiveRangeEdit::eliminateDeadDef is used to remove dead define instructions
702 // after rematerialization. To remove a VNI for a vreg from its LiveInterval,
703 // LiveIntervals::removeVRegDefAt is used. However, after non-PHI VNIs are all
704 // removed, PHI VNI are still left in the LiveInterval.
705 // So to get rid of unused reg, we need to check whether it has non-dbg
706 // reference instead of whether it has non-empty interval.
Benjamin Kramer391f5a62013-05-05 11:29:14 +0000707 unsigned ResultPos = 0;
Craig Topper73275a22015-12-24 05:20:40 +0000708 for (unsigned Reg : RegsToSpill) {
Wei Mia62f0582016-02-05 18:14:24 +0000709 if (MRI.reg_nodbg_empty(Reg)) {
Benjamin Kramer391f5a62013-05-05 11:29:14 +0000710 Edit->eraseVirtReg(Reg);
Jakob Stoklund Olesenadd79c62011-03-29 17:47:00 +0000711 continue;
712 }
Matt Arsenaultc5d1e502017-07-22 00:24:01 +0000713
Matt Arsenault5fbc8702017-07-24 18:07:55 +0000714 assert(LIS.hasInterval(Reg) &&
715 (!LIS.getInterval(Reg).empty() || !MRI.reg_nodbg_empty(Reg)) &&
716 "Empty and not used live-range?!");
717
Benjamin Kramer391f5a62013-05-05 11:29:14 +0000718 RegsToSpill[ResultPos++] = Reg;
Jakob Stoklund Olesenadd79c62011-03-29 17:47:00 +0000719 }
Benjamin Kramer391f5a62013-05-05 11:29:14 +0000720 RegsToSpill.erase(RegsToSpill.begin() + ResultPos, RegsToSpill.end());
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000721 LLVM_DEBUG(dbgs() << RegsToSpill.size()
722 << " registers to spill after remat.\n");
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +0000723}
724
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +0000725//===----------------------------------------------------------------------===//
726// Spilling
727//===----------------------------------------------------------------------===//
728
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000729/// If MI is a load or store of StackSlot, it can be removed.
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000730bool InlineSpiller::coalesceStackAccess(MachineInstr *MI, unsigned Reg) {
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +0000731 int FI = 0;
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000732 unsigned InstrReg = TII.isLoadFromStackSlot(*MI, FI);
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +0000733 bool IsLoad = InstrReg;
734 if (!IsLoad)
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000735 InstrReg = TII.isStoreToStackSlot(*MI, FI);
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +0000736
737 // We have a stack access. Is it the right register and slot?
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000738 if (InstrReg != Reg || FI != StackSlot)
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +0000739 return false;
740
Wei Mi9a16d652016-04-13 03:08:27 +0000741 if (!IsLoad)
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000742 HSpiller.rmFromMergeableSpills(*MI, StackSlot);
Wei Mi9a16d652016-04-13 03:08:27 +0000743
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000744 LLVM_DEBUG(dbgs() << "Coalescing stack access: " << *MI);
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +0000745 LIS.RemoveMachineInstrFromMaps(*MI);
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +0000746 MI->eraseFromParent();
Jakob Stoklund Olesen37eb6962011-09-15 17:54:28 +0000747
748 if (IsLoad) {
749 ++NumReloadsRemoved;
750 --NumReloads;
751 } else {
752 ++NumSpillsRemoved;
753 --NumSpills;
754 }
755
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +0000756 return true;
757}
758
Aaron Ballman615eb472017-10-15 14:32:27 +0000759#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
Junmo Parkc7479ba2017-03-28 04:14:25 +0000760LLVM_DUMP_METHOD
Mark Lacey9d8103d2013-08-14 23:50:16 +0000761// Dump the range of instructions from B to E with their slot indexes.
762static void dumpMachineInstrRangeWithSlotIndex(MachineBasicBlock::iterator B,
763 MachineBasicBlock::iterator E,
764 LiveIntervals const &LIS,
765 const char *const header,
766 unsigned VReg =0) {
767 char NextLine = '\n';
768 char SlotIndent = '\t';
769
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +0000770 if (std::next(B) == E) {
Mark Lacey9d8103d2013-08-14 23:50:16 +0000771 NextLine = ' ';
772 SlotIndent = ' ';
773 }
774
775 dbgs() << '\t' << header << ": " << NextLine;
776
777 for (MachineBasicBlock::iterator I = B; I != E; ++I) {
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +0000778 SlotIndex Idx = LIS.getInstructionIndex(*I).getRegSlot();
Mark Lacey9d8103d2013-08-14 23:50:16 +0000779
780 // If a register was passed in and this instruction has it as a
781 // destination that is marked as an early clobber, print the
782 // early-clobber slot index.
783 if (VReg) {
784 MachineOperand *MO = I->findRegisterDefOperand(VReg);
785 if (MO && MO->isEarlyClobber())
786 Idx = Idx.getRegSlot(true);
787 }
788
789 dbgs() << SlotIndent << Idx << '\t' << *I;
790 }
791}
792#endif
793
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +0000794/// foldMemoryOperand - Try folding stack slot references in Ops into their
795/// instructions.
796///
Florian Hahn5d062562019-12-02 19:41:09 +0000797/// @param Ops Operand indices from AnalyzeVirtRegInBundle().
Jakob Stoklund Olesen3b2966d2010-12-18 03:04:14 +0000798/// @param LoadMI Load instruction to use instead of stack slot when non-null.
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +0000799/// @return True on success.
800bool InlineSpiller::
Eugene Zelenko900b6332017-08-29 22:32:07 +0000801foldMemoryOperand(ArrayRef<std::pair<MachineInstr *, unsigned>> Ops,
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +0000802 MachineInstr *LoadMI) {
803 if (Ops.empty())
804 return false;
805 // Don't attempt folding in bundles.
806 MachineInstr *MI = Ops.front().first;
807 if (Ops.back().first != MI || MI->isBundled())
808 return false;
809
Jakob Stoklund Olesenc94c9672011-09-15 18:22:52 +0000810 bool WasCopy = MI->isCopy();
Jakob Stoklund Oleseneef48b62011-11-10 00:17:03 +0000811 unsigned ImpReg = 0;
812
Michael Kuperstein47eb85a2016-11-23 18:33:49 +0000813 // Spill subregs if the target allows it.
814 // We always want to spill subregs for stackmap/patchpoint pseudos.
815 bool SpillSubRegs = TII.isSubregFoldable() ||
816 MI->getOpcode() == TargetOpcode::STATEPOINT ||
817 MI->getOpcode() == TargetOpcode::PATCHPOINT ||
818 MI->getOpcode() == TargetOpcode::STACKMAP;
Andrew Trick10d5be42013-11-17 01:36:23 +0000819
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000820 // TargetInstrInfo::foldMemoryOperand only expects explicit, non-tied
821 // operands.
822 SmallVector<unsigned, 8> FoldOps;
Craig Topper73275a22015-12-24 05:20:40 +0000823 for (const auto &OpPair : Ops) {
824 unsigned Idx = OpPair.second;
825 assert(MI == OpPair.first && "Instruction conflict during operand folding");
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000826 MachineOperand &MO = MI->getOperand(Idx);
Jakob Stoklund Oleseneef48b62011-11-10 00:17:03 +0000827 if (MO.isImplicit()) {
828 ImpReg = MO.getReg();
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000829 continue;
Jakob Stoklund Oleseneef48b62011-11-10 00:17:03 +0000830 }
Michael Kuperstein47eb85a2016-11-23 18:33:49 +0000831
Andrew Trick10d5be42013-11-17 01:36:23 +0000832 if (!SpillSubRegs && MO.getSubReg())
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000833 return false;
Jakob Stoklund Olesenc6a20412011-02-08 19:33:55 +0000834 // We cannot fold a load instruction into a def.
835 if (LoadMI && MO.isDef())
836 return false;
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000837 // Tied use operands should not be passed to foldMemoryOperand.
838 if (!MI->isRegTiedToDefOperand(Idx))
839 FoldOps.push_back(Idx);
840 }
841
Quentin Colombetae3168d2016-12-08 00:06:51 +0000842 // If we only have implicit uses, we won't be able to fold that.
843 // Moreover, TargetInstrInfo::foldMemoryOperand will assert if we try!
844 if (FoldOps.empty())
845 return false;
846
Michael Liao8d6ea2d2019-07-05 20:23:59 +0000847 MachineInstrSpan MIS(MI, MI->getParent());
Mark Lacey9d8103d2013-08-14 23:50:16 +0000848
Jakob Stoklund Olesen3b2966d2010-12-18 03:04:14 +0000849 MachineInstr *FoldMI =
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +0000850 LoadMI ? TII.foldMemoryOperand(*MI, FoldOps, *LoadMI, &LIS)
Jonas Paulssonfdc4ea32019-06-08 06:19:15 +0000851 : TII.foldMemoryOperand(*MI, FoldOps, StackSlot, &LIS, &VRM);
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000852 if (!FoldMI)
853 return false;
Andrew Trick5749b8b2013-06-21 18:33:26 +0000854
855 // Remove LIS for any dead defs in the original MI not in FoldMI.
Duncan P. N. Exon Smithf9ab4162016-02-27 17:05:33 +0000856 for (MIBundleOperands MO(*MI); MO.isValid(); ++MO) {
Andrew Trick5749b8b2013-06-21 18:33:26 +0000857 if (!MO->isReg())
858 continue;
Daniel Sanders0c476112019-08-15 19:22:08 +0000859 Register Reg = MO->getReg();
Daniel Sanders2bea69b2019-08-01 23:27:28 +0000860 if (!Reg || Register::isVirtualRegister(Reg) || MRI.isReserved(Reg)) {
Andrew Trick5749b8b2013-06-21 18:33:26 +0000861 continue;
862 }
Andrew Trickdfacda32014-01-07 07:31:10 +0000863 // Skip non-Defs, including undef uses and internal reads.
864 if (MO->isUse())
865 continue;
Florian Hahn5154b022019-12-02 20:00:56 +0000866 PhysRegInfo RI = AnalyzePhysRegInBundle(*FoldMI, Reg, &TRI);
Matthias Braun60d69e22015-12-11 19:42:09 +0000867 if (RI.FullyDefined)
Andrew Trick5749b8b2013-06-21 18:33:26 +0000868 continue;
869 // FoldMI does not define this physreg. Remove the LI segment.
870 assert(MO->isDead() && "Cannot fold physreg def");
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +0000871 SlotIndex Idx = LIS.getInstructionIndex(*MI).getRegSlot();
Matthias Brauncfb8ad22015-01-21 18:50:21 +0000872 LIS.removePhysRegDefAt(Reg, Idx);
Andrew Trick5749b8b2013-06-21 18:33:26 +0000873 }
Mark Lacey9d8103d2013-08-14 23:50:16 +0000874
Wei Mi9a16d652016-04-13 03:08:27 +0000875 int FI;
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000876 if (TII.isStoreToStackSlot(*MI, FI) &&
877 HSpiller.rmFromMergeableSpills(*MI, FI))
Wei Mi9a16d652016-04-13 03:08:27 +0000878 --NumSpills;
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +0000879 LIS.ReplaceMachineInstrInMaps(*MI, *FoldMI);
Djordje Todorovic68908992020-02-10 09:49:14 +0100880 // Update the call site info.
881 if (MI->isCandidateForCallSiteEntry())
Nikola Prica98603a82019-10-08 15:43:12 +0000882 MI->getMF()->moveCallSiteInfo(MI, FoldMI);
Jakob Stoklund Olesenbd953d12010-07-09 17:29:08 +0000883 MI->eraseFromParent();
Jakob Stoklund Oleseneef48b62011-11-10 00:17:03 +0000884
Mark Lacey9d8103d2013-08-14 23:50:16 +0000885 // Insert any new instructions other than FoldMI into the LIS maps.
886 assert(!MIS.empty() && "Unexpected empty span of instructions!");
Craig Topper73275a22015-12-24 05:20:40 +0000887 for (MachineInstr &MI : MIS)
888 if (&MI != FoldMI)
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +0000889 LIS.InsertMachineInstrInMaps(MI);
Mark Lacey9d8103d2013-08-14 23:50:16 +0000890
Jakob Stoklund Oleseneef48b62011-11-10 00:17:03 +0000891 // TII.foldMemoryOperand may have left some implicit operands on the
892 // instruction. Strip them.
893 if (ImpReg)
894 for (unsigned i = FoldMI->getNumOperands(); i; --i) {
895 MachineOperand &MO = FoldMI->getOperand(i - 1);
896 if (!MO.isReg() || !MO.isImplicit())
897 break;
898 if (MO.getReg() == ImpReg)
899 FoldMI->RemoveOperand(i - 1);
900 }
901
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000902 LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(MIS.begin(), MIS.end(), LIS,
903 "folded"));
Mark Lacey9d8103d2013-08-14 23:50:16 +0000904
Jakob Stoklund Olesenc94c9672011-09-15 18:22:52 +0000905 if (!WasCopy)
906 ++NumFolded;
Wei Mi9a16d652016-04-13 03:08:27 +0000907 else if (Ops.front().second == 0) {
Jakob Stoklund Olesenc94c9672011-09-15 18:22:52 +0000908 ++NumSpills;
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +0000909 HSpiller.addToMergeableSpills(*FoldMI, StackSlot, Original);
Wei Mi9a16d652016-04-13 03:08:27 +0000910 } else
Jakob Stoklund Olesenc94c9672011-09-15 18:22:52 +0000911 ++NumReloads;
Jakob Stoklund Olesen8656a452010-07-01 00:13:04 +0000912 return true;
913}
914
Mark Lacey9d8103d2013-08-14 23:50:16 +0000915void InlineSpiller::insertReload(unsigned NewVReg,
Jakob Stoklund Olesen9f294a92011-04-18 20:23:27 +0000916 SlotIndex Idx,
Jakob Stoklund Olesenbde96ad2010-06-30 23:03:52 +0000917 MachineBasicBlock::iterator MI) {
918 MachineBasicBlock &MBB = *MI->getParent();
Mark Lacey9d8103d2013-08-14 23:50:16 +0000919
Michael Liao8d6ea2d2019-07-05 20:23:59 +0000920 MachineInstrSpan MIS(MI, &MBB);
Mark Lacey9d8103d2013-08-14 23:50:16 +0000921 TII.loadRegFromStackSlot(MBB, MI, NewVReg, StackSlot,
922 MRI.getRegClass(NewVReg), &TRI);
923
924 LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MI);
925
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000926 LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(MIS.begin(), MI, LIS, "reload",
927 NewVReg));
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000928 ++NumReloads;
Jakob Stoklund Olesenbde96ad2010-06-30 23:03:52 +0000929}
930
Quentin Colombetc6689352017-06-05 23:51:27 +0000931/// Check if \p Def fully defines a VReg with an undefined value.
932/// If that's the case, that means the value of VReg is actually
933/// not relevant.
934static bool isFullUndefDef(const MachineInstr &Def) {
935 if (!Def.isImplicitDef())
936 return false;
937 assert(Def.getNumOperands() == 1 &&
938 "Implicit def with more than one definition");
939 // We can say that the VReg defined by Def is undef, only if it is
940 // fully defined by Def. Otherwise, some of the lanes may not be
941 // undef and the value of the VReg matters.
942 return !Def.getOperand(0).getSubReg();
943}
944
Mark Lacey9d8103d2013-08-14 23:50:16 +0000945/// insertSpill - Insert a spill of NewVReg after MI.
946void InlineSpiller::insertSpill(unsigned NewVReg, bool isKill,
947 MachineBasicBlock::iterator MI) {
Jakob Stoklund Olesenbde96ad2010-06-30 23:03:52 +0000948 MachineBasicBlock &MBB = *MI->getParent();
Mark Lacey9d8103d2013-08-14 23:50:16 +0000949
Michael Liao8d6ea2d2019-07-05 20:23:59 +0000950 MachineInstrSpan MIS(MI, &MBB);
Quentin Colombet9e9d6382017-06-07 00:22:07 +0000951 bool IsRealSpill = true;
952 if (isFullUndefDef(*MI)) {
Quentin Colombetc6689352017-06-05 23:51:27 +0000953 // Don't spill undef value.
954 // Anything works for undef, in particular keeping the memory
955 // uninitialized is a viable option and it saves code size and
956 // run time.
957 BuildMI(MBB, std::next(MI), MI->getDebugLoc(), TII.get(TargetOpcode::KILL))
958 .addReg(NewVReg, getKillRegState(isKill));
Quentin Colombet9e9d6382017-06-07 00:22:07 +0000959 IsRealSpill = false;
960 } else
Quentin Colombetc6689352017-06-05 23:51:27 +0000961 TII.storeRegToStackSlot(MBB, std::next(MI), NewVReg, isKill, StackSlot,
962 MRI.getRegClass(NewVReg), &TRI);
Mark Lacey9d8103d2013-08-14 23:50:16 +0000963
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +0000964 LIS.InsertMachineInstrRangeInMaps(std::next(MI), MIS.end());
Mark Lacey9d8103d2013-08-14 23:50:16 +0000965
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000966 LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(std::next(MI), MIS.end(), LIS,
967 "spill"));
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +0000968 ++NumSpills;
Quentin Colombet9e9d6382017-06-07 00:22:07 +0000969 if (IsRealSpill)
970 HSpiller.addToMergeableSpills(*std::next(MI), StackSlot, Original);
Jakob Stoklund Olesenbde96ad2010-06-30 23:03:52 +0000971}
972
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000973/// spillAroundUses - insert spill code around each use of Reg.
974void InlineSpiller::spillAroundUses(unsigned Reg) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000975 LLVM_DEBUG(dbgs() << "spillAroundUses " << printReg(Reg) << '\n');
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +0000976 LiveInterval &OldLI = LIS.getInterval(Reg);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000977
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000978 // Iterate over instructions using Reg.
Owen Andersonabb90c92014-03-13 06:02:25 +0000979 for (MachineRegisterInfo::reg_bundle_iterator
980 RegI = MRI.reg_bundle_begin(Reg), E = MRI.reg_bundle_end();
981 RegI != E; ) {
Owen Andersonec5d4802014-03-14 05:02:18 +0000982 MachineInstr *MI = &*(RegI++);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +0000983
Jakob Stoklund Olesencf6c5c92010-07-02 19:54:40 +0000984 // Debug values are not allowed to affect codegen.
Shiva Chen21eab932018-05-16 02:57:26 +0000985 if (MI->isDebugValue()) {
Jakob Stoklund Olesencf6c5c92010-07-02 19:54:40 +0000986 // Modify DBG_VALUE now that the value is in a spill slot.
David Blaikie0252265b2013-06-16 20:34:15 +0000987 MachineBasicBlock *MBB = MI->getParent();
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000988 LLVM_DEBUG(dbgs() << "Modifying debug info due to spill:\t" << *MI);
Adrian Prantl6825fb62017-04-18 01:21:53 +0000989 buildDbgValueForSpill(*MBB, MI, *MI, StackSlot);
990 MBB->erase(MI);
Jakob Stoklund Olesencf6c5c92010-07-02 19:54:40 +0000991 continue;
992 }
993
Shiva Chen21eab932018-05-16 02:57:26 +0000994 assert(!MI->isDebugInstr() && "Did not expect to find a use in debug "
995 "instruction that isn't a DBG_VALUE");
996
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +0000997 // Ignore copies to/from snippets. We'll delete them.
998 if (SnippetCopies.count(MI))
999 continue;
1000
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +00001001 // Stack slot accesses may coalesce away.
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001002 if (coalesceStackAccess(MI, Reg))
Jakob Stoklund Olesen7fd49052010-08-04 22:35:11 +00001003 continue;
1004
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001005 // Analyze instruction.
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +00001006 SmallVector<std::pair<MachineInstr*, unsigned>, 8> Ops;
Florian Hahn5d062562019-12-02 19:41:09 +00001007 VirtRegInfo RI = AnalyzeVirtRegInBundle(*MI, Reg, &Ops);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001008
Jakob Stoklund Olesen9f294a92011-04-18 20:23:27 +00001009 // Find the slot index where this instruction reads and writes OldLI.
1010 // This is usually the def slot, except for tied early clobbers.
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +00001011 SlotIndex Idx = LIS.getInstructionIndex(*MI).getRegSlot();
Jakob Stoklund Olesen90b5e562011-11-13 20:45:27 +00001012 if (VNInfo *VNI = OldLI.getVNInfoAt(Idx.getRegSlot(true)))
Jakob Stoklund Olesen9f294a92011-04-18 20:23:27 +00001013 if (SlotIndex::isSameInstr(Idx, VNI->def))
1014 Idx = VNI->def;
1015
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +00001016 // Check for a sibling copy.
Duncan P. N. Exon Smith9cfc75c2016-06-30 00:01:54 +00001017 unsigned SibReg = isFullCopyOf(*MI, Reg);
Jakob Stoklund Olesene55003f2011-03-20 05:44:58 +00001018 if (SibReg && isSibling(SibReg)) {
Jakob Stoklund Olesen31a0b5e2011-05-11 18:25:10 +00001019 // This may actually be a copy between snippets.
1020 if (isRegToSpill(SibReg)) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001021 LLVM_DEBUG(dbgs() << "Found new snippet copy: " << *MI);
Jakob Stoklund Olesen31a0b5e2011-05-11 18:25:10 +00001022 SnippetCopies.insert(MI);
1023 continue;
1024 }
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +00001025 if (RI.Writes) {
Wei Mi9a16d652016-04-13 03:08:27 +00001026 if (hoistSpillInsideBB(OldLI, *MI)) {
Jakob Stoklund Olesene55003f2011-03-20 05:44:58 +00001027 // This COPY is now dead, the value is already in the stack slot.
1028 MI->getOperand(0).setIsDead();
1029 DeadDefs.push_back(MI);
1030 continue;
1031 }
1032 } else {
1033 // This is a reload for a sib-reg copy. Drop spills downstream.
Jakob Stoklund Olesene55003f2011-03-20 05:44:58 +00001034 LiveInterval &SibLI = LIS.getInterval(SibReg);
1035 eliminateRedundantSpills(SibLI, SibLI.getVNInfoAt(Idx));
1036 // The COPY will fold to a reload below.
1037 }
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +00001038 }
1039
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +00001040 // Attempt to fold memory ops.
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +00001041 if (foldMemoryOperand(Ops))
Jakob Stoklund Olesen96037182010-07-02 17:44:57 +00001042 continue;
1043
Mark Lacey9d8103d2013-08-14 23:50:16 +00001044 // Create a new virtual register for spill/fill.
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001045 // FIXME: Infer regclass from instruction alone.
Mark Lacey9d8103d2013-08-14 23:50:16 +00001046 unsigned NewVReg = Edit->createFrom(Reg);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001047
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +00001048 if (RI.Reads)
Mark Lacey9d8103d2013-08-14 23:50:16 +00001049 insertReload(NewVReg, Idx, MI);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001050
1051 // Rewrite instruction operands.
1052 bool hasLiveDef = false;
Craig Topper73275a22015-12-24 05:20:40 +00001053 for (const auto &OpPair : Ops) {
1054 MachineOperand &MO = OpPair.first->getOperand(OpPair.second);
Mark Lacey9d8103d2013-08-14 23:50:16 +00001055 MO.setReg(NewVReg);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001056 if (MO.isUse()) {
Craig Topper73275a22015-12-24 05:20:40 +00001057 if (!OpPair.first->isRegTiedToDefOperand(OpPair.second))
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001058 MO.setIsKill();
1059 } else {
1060 if (!MO.isDead())
1061 hasLiveDef = true;
1062 }
1063 }
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001064 LLVM_DEBUG(dbgs() << "\trewrite: " << Idx << '\t' << *MI << '\n');
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001065
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001066 // FIXME: Use a second vreg if instruction has no tied ops.
Mark Lacey9d8103d2013-08-14 23:50:16 +00001067 if (RI.Writes)
Jakob Stoklund Olesenabe8c092012-03-01 01:43:25 +00001068 if (hasLiveDef)
Mark Lacey9d8103d2013-08-14 23:50:16 +00001069 insertSpill(NewVReg, true, MI);
Jakob Stoklund Olesenf8889112010-06-29 23:58:39 +00001070 }
1071}
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001072
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001073/// spillAll - Spill all registers remaining after rematerialization.
1074void InlineSpiller::spillAll() {
1075 // Update LiveStacks now that we are committed to spilling.
1076 if (StackSlot == VirtRegMap::NO_STACK_SLOT) {
1077 StackSlot = VRM.assignVirt2StackSlot(Original);
1078 StackInt = &LSS.getOrCreateInterval(StackSlot, MRI.getRegClass(Original));
Jakob Stoklund Olesenad6b22e2012-02-04 05:20:49 +00001079 StackInt->getNextValue(SlotIndex(), LSS.getVNInfoAllocator());
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001080 } else
1081 StackInt = &LSS.getInterval(StackSlot);
1082
1083 if (Original != Edit->getReg())
1084 VRM.assignVirt2StackSlot(Edit->getReg(), StackSlot);
1085
1086 assert(StackInt->getNumValNums() == 1 && "Bad stack interval values");
Craig Topper73275a22015-12-24 05:20:40 +00001087 for (unsigned Reg : RegsToSpill)
1088 StackInt->MergeSegmentsInAsValue(LIS.getInterval(Reg),
Matthias Braun13ddb7c2013-10-10 21:28:43 +00001089 StackInt->getValNumInfo(0));
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001090 LLVM_DEBUG(dbgs() << "Merged spilled regs: " << *StackInt << '\n');
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001091
1092 // Spill around uses of all RegsToSpill.
Craig Topper73275a22015-12-24 05:20:40 +00001093 for (unsigned Reg : RegsToSpill)
1094 spillAroundUses(Reg);
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001095
1096 // Hoisted spills may cause dead code.
1097 if (!DeadDefs.empty()) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001098 LLVM_DEBUG(dbgs() << "Eliminating " << DeadDefs.size() << " dead defs\n");
Wei Mic0223702016-07-08 21:08:09 +00001099 Edit->eliminateDeadDefs(DeadDefs, RegsToSpill, AA);
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001100 }
1101
1102 // Finally delete the SnippetCopies.
Craig Topper73275a22015-12-24 05:20:40 +00001103 for (unsigned Reg : RegsToSpill) {
Owen Andersonabb90c92014-03-13 06:02:25 +00001104 for (MachineRegisterInfo::reg_instr_iterator
Craig Topper73275a22015-12-24 05:20:40 +00001105 RI = MRI.reg_instr_begin(Reg), E = MRI.reg_instr_end();
Owen Andersonabb90c92014-03-13 06:02:25 +00001106 RI != E; ) {
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +00001107 MachineInstr &MI = *(RI++);
1108 assert(SnippetCopies.count(&MI) && "Remaining use wasn't a snippet copy");
Jakob Stoklund Olesen31a0b5e2011-05-11 18:25:10 +00001109 // FIXME: Do this with a LiveRangeEdit callback.
Jakob Stoklund Olesen31a0b5e2011-05-11 18:25:10 +00001110 LIS.RemoveMachineInstrFromMaps(MI);
Duncan P. N. Exon Smith3ac9cc62016-02-27 06:40:41 +00001111 MI.eraseFromParent();
Jakob Stoklund Olesen31a0b5e2011-05-11 18:25:10 +00001112 }
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001113 }
1114
1115 // Delete all spilled registers.
Craig Topper73275a22015-12-24 05:20:40 +00001116 for (unsigned Reg : RegsToSpill)
1117 Edit->eraseVirtReg(Reg);
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001118}
1119
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001120void InlineSpiller::spill(LiveRangeEdit &edit) {
Jakob Stoklund Olesenc5a8c082011-05-05 17:22:53 +00001121 ++NumSpilledRanges;
Jakob Stoklund Olesena00bab22011-03-14 19:56:43 +00001122 Edit = &edit;
Daniel Sanders2bea69b2019-08-01 23:27:28 +00001123 assert(!Register::isStackSlot(edit.getReg()) &&
1124 "Trying to spill a stack slot.");
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +00001125 // Share a stack slot among all descendants of Original.
1126 Original = VRM.getOriginal(edit.getReg());
1127 StackSlot = VRM.getStackSlot(Original);
Craig Topperc0196b12014-04-14 00:51:57 +00001128 StackInt = nullptr;
Jakob Stoklund Olesena0d5ec12011-03-15 21:13:25 +00001129
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001130 LLVM_DEBUG(dbgs() << "Inline spilling "
1131 << TRI.getRegClassName(MRI.getRegClass(edit.getReg()))
1132 << ':' << edit.getParent() << "\nFrom original "
1133 << printReg(Original) << '\n');
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001134 assert(edit.getParent().isSpillable() &&
1135 "Attempting to spill already spilled value.");
Jakob Stoklund Olesen27320cb2011-03-18 04:23:06 +00001136 assert(DeadDefs.empty() && "Previous spill didn't remove dead defs");
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001137
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001138 collectRegsToSpill();
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001139 reMaterializeAll();
1140
1141 // Remat may handle everything.
Jakob Stoklund Olesene991f722011-03-29 21:20:19 +00001142 if (!RegsToSpill.empty())
1143 spillAll();
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001144
Benjamin Kramere2a1d892013-06-17 19:00:36 +00001145 Edit->calculateRegClassAndHint(MF, Loops, MBFI);
Jakob Stoklund Olesena86595e2011-03-12 04:17:20 +00001146}
Wei Mi9a16d652016-04-13 03:08:27 +00001147
1148/// Optimizations after all the reg selections and spills are done.
Wei Mi963f2df2016-04-15 23:16:44 +00001149void InlineSpiller::postOptimization() { HSpiller.hoistAllSpills(); }
Wei Mi9a16d652016-04-13 03:08:27 +00001150
1151/// When a spill is inserted, add the spill to MergeableSpills map.
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +00001152void HoistSpillHelper::addToMergeableSpills(MachineInstr &Spill, int StackSlot,
Wei Mi9a16d652016-04-13 03:08:27 +00001153 unsigned Original) {
Wei Mic0d06642017-09-13 21:41:30 +00001154 BumpPtrAllocator &Allocator = LIS.getVNInfoAllocator();
1155 LiveInterval &OrigLI = LIS.getInterval(Original);
1156 // save a copy of LiveInterval in StackSlotToOrigLI because the original
1157 // LiveInterval may be cleared after all its references are spilled.
1158 if (StackSlotToOrigLI.find(StackSlot) == StackSlotToOrigLI.end()) {
Jonas Devlieghere0eaee542019-08-15 15:54:37 +00001159 auto LI = std::make_unique<LiveInterval>(OrigLI.reg, OrigLI.weight);
Wei Mic0d06642017-09-13 21:41:30 +00001160 LI->assign(OrigLI, Allocator);
1161 StackSlotToOrigLI[StackSlot] = std::move(LI);
1162 }
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +00001163 SlotIndex Idx = LIS.getInstructionIndex(Spill);
Wei Mic0d06642017-09-13 21:41:30 +00001164 VNInfo *OrigVNI = StackSlotToOrigLI[StackSlot]->getVNInfoAt(Idx.getRegSlot());
Wei Mi9a16d652016-04-13 03:08:27 +00001165 std::pair<int, VNInfo *> MIdx = std::make_pair(StackSlot, OrigVNI);
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +00001166 MergeableSpills[MIdx].insert(&Spill);
Wei Mi9a16d652016-04-13 03:08:27 +00001167}
1168
1169/// When a spill is removed, remove the spill from MergeableSpills map.
1170/// Return true if the spill is removed successfully.
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +00001171bool HoistSpillHelper::rmFromMergeableSpills(MachineInstr &Spill,
Wei Mi9a16d652016-04-13 03:08:27 +00001172 int StackSlot) {
Wei Mic0d06642017-09-13 21:41:30 +00001173 auto It = StackSlotToOrigLI.find(StackSlot);
1174 if (It == StackSlotToOrigLI.end())
Wei Mi9a16d652016-04-13 03:08:27 +00001175 return false;
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +00001176 SlotIndex Idx = LIS.getInstructionIndex(Spill);
Wei Mic0d06642017-09-13 21:41:30 +00001177 VNInfo *OrigVNI = It->second->getVNInfoAt(Idx.getRegSlot());
Wei Mi9a16d652016-04-13 03:08:27 +00001178 std::pair<int, VNInfo *> MIdx = std::make_pair(StackSlot, OrigVNI);
Duncan P. N. Exon Smith91298732016-06-30 23:28:15 +00001179 return MergeableSpills[MIdx].erase(&Spill);
Wei Mi9a16d652016-04-13 03:08:27 +00001180}
1181
1182/// Check BB to see if it is a possible target BB to place a hoisted spill,
1183/// i.e., there should be a living sibling of OrigReg at the insert point.
Wei Mic0d06642017-09-13 21:41:30 +00001184bool HoistSpillHelper::isSpillCandBB(LiveInterval &OrigLI, VNInfo &OrigVNI,
Wei Mi9a16d652016-04-13 03:08:27 +00001185 MachineBasicBlock &BB, unsigned &LiveReg) {
1186 SlotIndex Idx;
Wei Mic0d06642017-09-13 21:41:30 +00001187 unsigned OrigReg = OrigLI.reg;
Wei Mif3c8f532016-05-23 19:39:19 +00001188 MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, BB);
Wei Mi9a16d652016-04-13 03:08:27 +00001189 if (MI != BB.end())
1190 Idx = LIS.getInstructionIndex(*MI);
1191 else
1192 Idx = LIS.getMBBEndIdx(&BB).getPrevSlot();
1193 SmallSetVector<unsigned, 16> &Siblings = Virt2SiblingsMap[OrigReg];
Wei Mic0d06642017-09-13 21:41:30 +00001194 assert(OrigLI.getVNInfoAt(Idx) == &OrigVNI && "Unexpected VNI");
Wei Mi9a16d652016-04-13 03:08:27 +00001195
1196 for (auto const SibReg : Siblings) {
1197 LiveInterval &LI = LIS.getInterval(SibReg);
1198 VNInfo *VNI = LI.getVNInfoAt(Idx);
1199 if (VNI) {
1200 LiveReg = SibReg;
1201 return true;
1202 }
1203 }
1204 return false;
1205}
1206
Eric Christopher75d661a2016-05-04 21:45:36 +00001207/// Remove redundant spills in the same BB. Save those redundant spills in
Wei Mi9a16d652016-04-13 03:08:27 +00001208/// SpillsToRm, and save the spill to keep and its BB in SpillBBToSpill map.
Wei Mi9a16d652016-04-13 03:08:27 +00001209void HoistSpillHelper::rmRedundantSpills(
1210 SmallPtrSet<MachineInstr *, 16> &Spills,
1211 SmallVectorImpl<MachineInstr *> &SpillsToRm,
1212 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill) {
1213 // For each spill saw, check SpillBBToSpill[] and see if its BB already has
1214 // another spill inside. If a BB contains more than one spill, only keep the
1215 // earlier spill with smaller SlotIndex.
1216 for (const auto CurrentSpill : Spills) {
1217 MachineBasicBlock *Block = CurrentSpill->getParent();
Bjorn Pettersson3c6ce732017-01-04 09:41:56 +00001218 MachineDomTreeNode *Node = MDT.getBase().getNode(Block);
Wei Mi9a16d652016-04-13 03:08:27 +00001219 MachineInstr *PrevSpill = SpillBBToSpill[Node];
1220 if (PrevSpill) {
1221 SlotIndex PIdx = LIS.getInstructionIndex(*PrevSpill);
1222 SlotIndex CIdx = LIS.getInstructionIndex(*CurrentSpill);
1223 MachineInstr *SpillToRm = (CIdx > PIdx) ? CurrentSpill : PrevSpill;
1224 MachineInstr *SpillToKeep = (CIdx > PIdx) ? PrevSpill : CurrentSpill;
1225 SpillsToRm.push_back(SpillToRm);
Bjorn Pettersson3c6ce732017-01-04 09:41:56 +00001226 SpillBBToSpill[MDT.getBase().getNode(Block)] = SpillToKeep;
Wei Mi9a16d652016-04-13 03:08:27 +00001227 } else {
Bjorn Pettersson3c6ce732017-01-04 09:41:56 +00001228 SpillBBToSpill[MDT.getBase().getNode(Block)] = CurrentSpill;
Wei Mi9a16d652016-04-13 03:08:27 +00001229 }
1230 }
1231 for (const auto SpillToRm : SpillsToRm)
1232 Spills.erase(SpillToRm);
1233}
1234
1235/// Starting from \p Root find a top-down traversal order of the dominator
1236/// tree to visit all basic blocks containing the elements of \p Spills.
1237/// Redundant spills will be found and put into \p SpillsToRm at the same
1238/// time. \p SpillBBToSpill will be populated as part of the process and
1239/// maps a basic block to the first store occurring in the basic block.
1240/// \post SpillsToRm.union(Spills\@post) == Spills\@pre
Wei Mi9a16d652016-04-13 03:08:27 +00001241void HoistSpillHelper::getVisitOrders(
1242 MachineBasicBlock *Root, SmallPtrSet<MachineInstr *, 16> &Spills,
1243 SmallVectorImpl<MachineDomTreeNode *> &Orders,
1244 SmallVectorImpl<MachineInstr *> &SpillsToRm,
1245 DenseMap<MachineDomTreeNode *, unsigned> &SpillsToKeep,
1246 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill) {
1247 // The set contains all the possible BB nodes to which we may hoist
1248 // original spills.
1249 SmallPtrSet<MachineDomTreeNode *, 8> WorkSet;
1250 // Save the BB nodes on the path from the first BB node containing
Eric Christopher75d661a2016-05-04 21:45:36 +00001251 // non-redundant spill to the Root node.
Wei Mi9a16d652016-04-13 03:08:27 +00001252 SmallPtrSet<MachineDomTreeNode *, 8> NodesOnPath;
1253 // All the spills to be hoisted must originate from a single def instruction
1254 // to the OrigReg. It means the def instruction should dominate all the spills
1255 // to be hoisted. We choose the BB where the def instruction is located as
1256 // the Root.
1257 MachineDomTreeNode *RootIDomNode = MDT[Root]->getIDom();
1258 // For every node on the dominator tree with spill, walk up on the dominator
1259 // tree towards the Root node until it is reached. If there is other node
1260 // containing spill in the middle of the path, the previous spill saw will
Eric Christopher75d661a2016-05-04 21:45:36 +00001261 // be redundant and the node containing it will be removed. All the nodes on
1262 // the path starting from the first node with non-redundant spill to the Root
Wei Mi9a16d652016-04-13 03:08:27 +00001263 // node will be added to the WorkSet, which will contain all the possible
1264 // locations where spills may be hoisted to after the loop below is done.
1265 for (const auto Spill : Spills) {
1266 MachineBasicBlock *Block = Spill->getParent();
1267 MachineDomTreeNode *Node = MDT[Block];
1268 MachineInstr *SpillToRm = nullptr;
1269 while (Node != RootIDomNode) {
1270 // If Node dominates Block, and it already contains a spill, the spill in
Eric Christopher75d661a2016-05-04 21:45:36 +00001271 // Block will be redundant.
Wei Mi9a16d652016-04-13 03:08:27 +00001272 if (Node != MDT[Block] && SpillBBToSpill[Node]) {
1273 SpillToRm = SpillBBToSpill[MDT[Block]];
1274 break;
1275 /// If we see the Node already in WorkSet, the path from the Node to
1276 /// the Root node must already be traversed by another spill.
1277 /// Then no need to repeat.
1278 } else if (WorkSet.count(Node)) {
1279 break;
1280 } else {
1281 NodesOnPath.insert(Node);
1282 }
1283 Node = Node->getIDom();
1284 }
1285 if (SpillToRm) {
1286 SpillsToRm.push_back(SpillToRm);
1287 } else {
1288 // Add a BB containing the original spills to SpillsToKeep -- i.e.,
1289 // set the initial status before hoisting start. The value of BBs
1290 // containing original spills is set to 0, in order to descriminate
1291 // with BBs containing hoisted spills which will be inserted to
1292 // SpillsToKeep later during hoisting.
1293 SpillsToKeep[MDT[Block]] = 0;
1294 WorkSet.insert(NodesOnPath.begin(), NodesOnPath.end());
1295 }
1296 NodesOnPath.clear();
1297 }
1298
1299 // Sort the nodes in WorkSet in top-down order and save the nodes
1300 // in Orders. Orders will be used for hoisting in runHoistSpills.
1301 unsigned idx = 0;
Bjorn Pettersson3c6ce732017-01-04 09:41:56 +00001302 Orders.push_back(MDT.getBase().getNode(Root));
Wei Mi9a16d652016-04-13 03:08:27 +00001303 do {
1304 MachineDomTreeNode *Node = Orders[idx++];
1305 const std::vector<MachineDomTreeNode *> &Children = Node->getChildren();
1306 unsigned NumChildren = Children.size();
1307 for (unsigned i = 0; i != NumChildren; ++i) {
1308 MachineDomTreeNode *Child = Children[i];
1309 if (WorkSet.count(Child))
1310 Orders.push_back(Child);
1311 }
1312 } while (idx != Orders.size());
1313 assert(Orders.size() == WorkSet.size() &&
1314 "Orders have different size with WorkSet");
1315
1316#ifndef NDEBUG
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001317 LLVM_DEBUG(dbgs() << "Orders size is " << Orders.size() << "\n");
Wei Mi9a16d652016-04-13 03:08:27 +00001318 SmallVector<MachineDomTreeNode *, 32>::reverse_iterator RIt = Orders.rbegin();
1319 for (; RIt != Orders.rend(); RIt++)
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001320 LLVM_DEBUG(dbgs() << "BB" << (*RIt)->getBlock()->getNumber() << ",");
1321 LLVM_DEBUG(dbgs() << "\n");
Wei Mi9a16d652016-04-13 03:08:27 +00001322#endif
1323}
1324
1325/// Try to hoist spills according to BB hotness. The spills to removed will
1326/// be saved in \p SpillsToRm. The spills to be inserted will be saved in
1327/// \p SpillsToIns.
Wei Mi9a16d652016-04-13 03:08:27 +00001328void HoistSpillHelper::runHoistSpills(
Wei Mic0d06642017-09-13 21:41:30 +00001329 LiveInterval &OrigLI, VNInfo &OrigVNI,
1330 SmallPtrSet<MachineInstr *, 16> &Spills,
Wei Mi9a16d652016-04-13 03:08:27 +00001331 SmallVectorImpl<MachineInstr *> &SpillsToRm,
1332 DenseMap<MachineBasicBlock *, unsigned> &SpillsToIns) {
1333 // Visit order of dominator tree nodes.
1334 SmallVector<MachineDomTreeNode *, 32> Orders;
1335 // SpillsToKeep contains all the nodes where spills are to be inserted
1336 // during hoisting. If the spill to be inserted is an original spill
1337 // (not a hoisted one), the value of the map entry is 0. If the spill
1338 // is a hoisted spill, the value of the map entry is the VReg to be used
1339 // as the source of the spill.
1340 DenseMap<MachineDomTreeNode *, unsigned> SpillsToKeep;
1341 // Map from BB to the first spill inside of it.
1342 DenseMap<MachineDomTreeNode *, MachineInstr *> SpillBBToSpill;
1343
1344 rmRedundantSpills(Spills, SpillsToRm, SpillBBToSpill);
1345
1346 MachineBasicBlock *Root = LIS.getMBBFromIndex(OrigVNI.def);
1347 getVisitOrders(Root, Spills, Orders, SpillsToRm, SpillsToKeep,
1348 SpillBBToSpill);
1349
1350 // SpillsInSubTreeMap keeps the map from a dom tree node to a pair of
1351 // nodes set and the cost of all the spills inside those nodes.
1352 // The nodes set are the locations where spills are to be inserted
1353 // in the subtree of current node.
Eugene Zelenko900b6332017-08-29 22:32:07 +00001354 using NodesCostPair =
1355 std::pair<SmallPtrSet<MachineDomTreeNode *, 16>, BlockFrequency>;
Wei Mi9a16d652016-04-13 03:08:27 +00001356 DenseMap<MachineDomTreeNode *, NodesCostPair> SpillsInSubTreeMap;
Eugene Zelenko900b6332017-08-29 22:32:07 +00001357
Wei Mi9a16d652016-04-13 03:08:27 +00001358 // Iterate Orders set in reverse order, which will be a bottom-up order
1359 // in the dominator tree. Once we visit a dom tree node, we know its
1360 // children have already been visited and the spill locations in the
1361 // subtrees of all the children have been determined.
1362 SmallVector<MachineDomTreeNode *, 32>::reverse_iterator RIt = Orders.rbegin();
1363 for (; RIt != Orders.rend(); RIt++) {
1364 MachineBasicBlock *Block = (*RIt)->getBlock();
1365
1366 // If Block contains an original spill, simply continue.
1367 if (SpillsToKeep.find(*RIt) != SpillsToKeep.end() && !SpillsToKeep[*RIt]) {
1368 SpillsInSubTreeMap[*RIt].first.insert(*RIt);
1369 // SpillsInSubTreeMap[*RIt].second contains the cost of spill.
1370 SpillsInSubTreeMap[*RIt].second = MBFI.getBlockFreq(Block);
1371 continue;
1372 }
1373
1374 // Collect spills in subtree of current node (*RIt) to
1375 // SpillsInSubTreeMap[*RIt].first.
1376 const std::vector<MachineDomTreeNode *> &Children = (*RIt)->getChildren();
1377 unsigned NumChildren = Children.size();
1378 for (unsigned i = 0; i != NumChildren; ++i) {
1379 MachineDomTreeNode *Child = Children[i];
1380 if (SpillsInSubTreeMap.find(Child) == SpillsInSubTreeMap.end())
1381 continue;
1382 // The stmt "SpillsInSubTree = SpillsInSubTreeMap[*RIt].first" below
1383 // should be placed before getting the begin and end iterators of
1384 // SpillsInSubTreeMap[Child].first, or else the iterators may be
1385 // invalidated when SpillsInSubTreeMap[*RIt] is seen the first time
1386 // and the map grows and then the original buckets in the map are moved.
1387 SmallPtrSet<MachineDomTreeNode *, 16> &SpillsInSubTree =
1388 SpillsInSubTreeMap[*RIt].first;
1389 BlockFrequency &SubTreeCost = SpillsInSubTreeMap[*RIt].second;
1390 SubTreeCost += SpillsInSubTreeMap[Child].second;
1391 auto BI = SpillsInSubTreeMap[Child].first.begin();
1392 auto EI = SpillsInSubTreeMap[Child].first.end();
1393 SpillsInSubTree.insert(BI, EI);
1394 SpillsInSubTreeMap.erase(Child);
1395 }
1396
1397 SmallPtrSet<MachineDomTreeNode *, 16> &SpillsInSubTree =
1398 SpillsInSubTreeMap[*RIt].first;
1399 BlockFrequency &SubTreeCost = SpillsInSubTreeMap[*RIt].second;
1400 // No spills in subtree, simply continue.
1401 if (SpillsInSubTree.empty())
1402 continue;
1403
1404 // Check whether Block is a possible candidate to insert spill.
1405 unsigned LiveReg = 0;
Wei Mic0d06642017-09-13 21:41:30 +00001406 if (!isSpillCandBB(OrigLI, OrigVNI, *Block, LiveReg))
Wei Mi9a16d652016-04-13 03:08:27 +00001407 continue;
1408
1409 // If there are multiple spills that could be merged, bias a little
1410 // to hoist the spill.
1411 BranchProbability MarginProb = (SpillsInSubTree.size() > 1)
1412 ? BranchProbability(9, 10)
1413 : BranchProbability(1, 1);
1414 if (SubTreeCost > MBFI.getBlockFreq(Block) * MarginProb) {
1415 // Hoist: Move spills to current Block.
1416 for (const auto SpillBB : SpillsInSubTree) {
1417 // When SpillBB is a BB contains original spill, insert the spill
1418 // to SpillsToRm.
1419 if (SpillsToKeep.find(SpillBB) != SpillsToKeep.end() &&
1420 !SpillsToKeep[SpillBB]) {
1421 MachineInstr *SpillToRm = SpillBBToSpill[SpillBB];
1422 SpillsToRm.push_back(SpillToRm);
1423 }
1424 // SpillBB will not contain spill anymore, remove it from SpillsToKeep.
1425 SpillsToKeep.erase(SpillBB);
1426 }
1427 // Current Block is the BB containing the new hoisted spill. Add it to
1428 // SpillsToKeep. LiveReg is the source of the new spill.
1429 SpillsToKeep[*RIt] = LiveReg;
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001430 LLVM_DEBUG({
Wei Mi9a16d652016-04-13 03:08:27 +00001431 dbgs() << "spills in BB: ";
1432 for (const auto Rspill : SpillsInSubTree)
1433 dbgs() << Rspill->getBlock()->getNumber() << " ";
1434 dbgs() << "were promoted to BB" << (*RIt)->getBlock()->getNumber()
1435 << "\n";
1436 });
1437 SpillsInSubTree.clear();
1438 SpillsInSubTree.insert(*RIt);
1439 SubTreeCost = MBFI.getBlockFreq(Block);
1440 }
1441 }
1442 // For spills in SpillsToKeep with LiveReg set (i.e., not original spill),
1443 // save them to SpillsToIns.
Mark de Wever8dc7b982020-01-01 17:23:21 +01001444 for (const auto &Ent : SpillsToKeep) {
Wei Mi9a16d652016-04-13 03:08:27 +00001445 if (Ent.second)
1446 SpillsToIns[Ent.first->getBlock()] = Ent.second;
1447 }
1448}
1449
Eric Christopher75d661a2016-05-04 21:45:36 +00001450/// For spills with equal values, remove redundant spills and hoist those left
Wei Mi9a16d652016-04-13 03:08:27 +00001451/// to less hot spots.
1452///
1453/// Spills with equal values will be collected into the same set in
1454/// MergeableSpills when spill is inserted. These equal spills are originated
Eric Christopher75d661a2016-05-04 21:45:36 +00001455/// from the same defining instruction and are dominated by the instruction.
1456/// Before hoisting all the equal spills, redundant spills inside in the same
1457/// BB are first marked to be deleted. Then starting from the spills left, walk
1458/// up on the dominator tree towards the Root node where the define instruction
Wei Mi9a16d652016-04-13 03:08:27 +00001459/// is located, mark the dominated spills to be deleted along the way and
1460/// collect the BB nodes on the path from non-dominated spills to the define
1461/// instruction into a WorkSet. The nodes in WorkSet are the candidate places
Eric Christopher75d661a2016-05-04 21:45:36 +00001462/// where we are considering to hoist the spills. We iterate the WorkSet in
1463/// bottom-up order, and for each node, we will decide whether to hoist spills
1464/// inside its subtree to that node. In this way, we can get benefit locally
1465/// even if hoisting all the equal spills to one cold place is impossible.
Wei Mi963f2df2016-04-15 23:16:44 +00001466void HoistSpillHelper::hoistAllSpills() {
1467 SmallVector<unsigned, 4> NewVRegs;
1468 LiveRangeEdit Edit(nullptr, NewVRegs, MF, LIS, &VRM, this);
1469
Wei Mi9a16d652016-04-13 03:08:27 +00001470 for (unsigned i = 0, e = MRI.getNumVirtRegs(); i != e; ++i) {
Daniel Sanders2bea69b2019-08-01 23:27:28 +00001471 unsigned Reg = Register::index2VirtReg(i);
Wei Mi9a16d652016-04-13 03:08:27 +00001472 unsigned Original = VRM.getPreSplitReg(Reg);
1473 if (!MRI.def_empty(Reg))
1474 Virt2SiblingsMap[Original].insert(Reg);
1475 }
1476
1477 // Each entry in MergeableSpills contains a spill set with equal values.
1478 for (auto &Ent : MergeableSpills) {
1479 int Slot = Ent.first.first;
Wei Mic0d06642017-09-13 21:41:30 +00001480 LiveInterval &OrigLI = *StackSlotToOrigLI[Slot];
Wei Mi9a16d652016-04-13 03:08:27 +00001481 VNInfo *OrigVNI = Ent.first.second;
1482 SmallPtrSet<MachineInstr *, 16> &EqValSpills = Ent.second;
1483 if (Ent.second.empty())
1484 continue;
1485
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001486 LLVM_DEBUG({
Wei Mi9a16d652016-04-13 03:08:27 +00001487 dbgs() << "\nFor Slot" << Slot << " and VN" << OrigVNI->id << ":\n"
1488 << "Equal spills in BB: ";
1489 for (const auto spill : EqValSpills)
1490 dbgs() << spill->getParent()->getNumber() << " ";
1491 dbgs() << "\n";
1492 });
1493
1494 // SpillsToRm is the spill set to be removed from EqValSpills.
1495 SmallVector<MachineInstr *, 16> SpillsToRm;
1496 // SpillsToIns is the spill set to be newly inserted after hoisting.
1497 DenseMap<MachineBasicBlock *, unsigned> SpillsToIns;
1498
Wei Mic0d06642017-09-13 21:41:30 +00001499 runHoistSpills(OrigLI, *OrigVNI, EqValSpills, SpillsToRm, SpillsToIns);
Wei Mi9a16d652016-04-13 03:08:27 +00001500
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001501 LLVM_DEBUG({
Wei Mi9a16d652016-04-13 03:08:27 +00001502 dbgs() << "Finally inserted spills in BB: ";
Mark de Wever8dc7b982020-01-01 17:23:21 +01001503 for (const auto &Ispill : SpillsToIns)
Wei Mi9a16d652016-04-13 03:08:27 +00001504 dbgs() << Ispill.first->getNumber() << " ";
1505 dbgs() << "\nFinally removed spills in BB: ";
1506 for (const auto Rspill : SpillsToRm)
1507 dbgs() << Rspill->getParent()->getNumber() << " ";
1508 dbgs() << "\n";
1509 });
1510
1511 // Stack live range update.
1512 LiveInterval &StackIntvl = LSS.getInterval(Slot);
Wei Mi8c4136b2016-05-11 22:37:43 +00001513 if (!SpillsToIns.empty() || !SpillsToRm.empty())
Wei Mi9a16d652016-04-13 03:08:27 +00001514 StackIntvl.MergeValueInAsValue(OrigLI, OrigVNI,
1515 StackIntvl.getValNumInfo(0));
Wei Mi9a16d652016-04-13 03:08:27 +00001516
1517 // Insert hoisted spills.
Mark de Wever8dc7b982020-01-01 17:23:21 +01001518 for (auto const &Insert : SpillsToIns) {
Wei Mi9a16d652016-04-13 03:08:27 +00001519 MachineBasicBlock *BB = Insert.first;
1520 unsigned LiveReg = Insert.second;
Wei Mif3c8f532016-05-23 19:39:19 +00001521 MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, *BB);
Wei Mi9a16d652016-04-13 03:08:27 +00001522 TII.storeRegToStackSlot(*BB, MI, LiveReg, false, Slot,
1523 MRI.getRegClass(LiveReg), &TRI);
1524 LIS.InsertMachineInstrRangeInMaps(std::prev(MI), MI);
1525 ++NumSpills;
1526 }
1527
Eric Christopher75d661a2016-05-04 21:45:36 +00001528 // Remove redundant spills or change them to dead instructions.
Wei Mi9a16d652016-04-13 03:08:27 +00001529 NumSpills -= SpillsToRm.size();
1530 for (auto const RMEnt : SpillsToRm) {
1531 RMEnt->setDesc(TII.get(TargetOpcode::KILL));
1532 for (unsigned i = RMEnt->getNumOperands(); i; --i) {
1533 MachineOperand &MO = RMEnt->getOperand(i - 1);
1534 if (MO.isReg() && MO.isImplicit() && MO.isDef() && !MO.isDead())
1535 RMEnt->RemoveOperand(i - 1);
1536 }
1537 }
Wei Mic0223702016-07-08 21:08:09 +00001538 Edit.eliminateDeadDefs(SpillsToRm, None, AA);
Wei Mi9a16d652016-04-13 03:08:27 +00001539 }
1540}
Wei Mi963f2df2016-04-15 23:16:44 +00001541
1542/// For VirtReg clone, the \p New register should have the same physreg or
1543/// stackslot as the \p old register.
1544void HoistSpillHelper::LRE_DidCloneVirtReg(unsigned New, unsigned Old) {
1545 if (VRM.hasPhys(Old))
1546 VRM.assignVirt2Phys(New, VRM.getPhys(Old));
1547 else if (VRM.getStackSlot(Old) != VirtRegMap::NO_STACK_SLOT)
1548 VRM.assignVirt2StackSlot(New, VRM.getStackSlot(Old));
1549 else
1550 llvm_unreachable("VReg should be assigned either physreg or stackslot");
1551}