blob: 7ea96f4014e5b03c5acbc7ddff0d7381a17a9da9 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
Douglas Gregore737f502010-08-12 20:07:10 +000015#include "clang/Sema/Sema.h"
John McCall781472f2010-08-25 08:40:02 +000016#include "clang/Sema/ScopeInfo.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000017#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000018#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000019#include "clang/AST/CharUnits.h"
John McCall384aff82010-08-25 07:42:41 +000020#include "clang/AST/DeclCXX.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000021#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000022#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000023#include "clang/AST/ExprObjC.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000024#include "clang/AST/DeclObjC.h"
25#include "clang/AST/StmtCXX.h"
26#include "clang/AST/StmtObjC.h"
Chris Lattner719e6152009-02-18 19:21:10 +000027#include "clang/Lex/LiteralSupport.h"
Chris Lattner59907c42007-08-10 20:18:51 +000028#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000029#include "llvm/ADT/BitVector.h"
30#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000031#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000032#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000033#include "clang/Basic/TargetInfo.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000034#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000035using namespace clang;
John McCall781472f2010-08-25 08:40:02 +000036using namespace sema;
Chris Lattner59907c42007-08-10 20:18:51 +000037
Chris Lattner60800082009-02-18 17:49:48 +000038/// getLocationOfStringLiteralByte - Return a source location that points to the
39/// specified byte of the specified string literal.
40///
41/// Strings are amazingly complex. They can be formed from multiple tokens and
42/// can have escape sequences in them in addition to the usual trigraph and
43/// escaped newline business. This routine handles this complexity.
44///
45SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
46 unsigned ByteNo) const {
47 assert(!SL->isWide() && "This doesn't work for wide strings yet");
Mike Stump1eb44332009-09-09 15:08:12 +000048
Chris Lattner60800082009-02-18 17:49:48 +000049 // Loop over all of the tokens in this string until we find the one that
50 // contains the byte we're looking for.
51 unsigned TokNo = 0;
52 while (1) {
53 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
54 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
Mike Stump1eb44332009-09-09 15:08:12 +000055
Chris Lattner60800082009-02-18 17:49:48 +000056 // Get the spelling of the string so that we can get the data that makes up
57 // the string literal, not the identifier for the macro it is potentially
58 // expanded through.
59 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
60
61 // Re-lex the token to get its length and original spelling.
62 std::pair<FileID, unsigned> LocInfo =
63 SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
Douglas Gregorf715ca12010-03-16 00:06:06 +000064 bool Invalid = false;
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000065 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
Douglas Gregorf715ca12010-03-16 00:06:06 +000066 if (Invalid)
Douglas Gregoraea67db2010-03-15 22:54:52 +000067 return StrTokSpellingLoc;
68
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000069 const char *StrData = Buffer.data()+LocInfo.second;
Mike Stump1eb44332009-09-09 15:08:12 +000070
Chris Lattner60800082009-02-18 17:49:48 +000071 // Create a langops struct and enable trigraphs. This is sufficient for
72 // relexing tokens.
73 LangOptions LangOpts;
74 LangOpts.Trigraphs = true;
Mike Stump1eb44332009-09-09 15:08:12 +000075
Chris Lattner60800082009-02-18 17:49:48 +000076 // Create a lexer starting at the beginning of this token.
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000077 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
78 Buffer.end());
Chris Lattner60800082009-02-18 17:49:48 +000079 Token TheTok;
80 TheLexer.LexFromRawLexer(TheTok);
Mike Stump1eb44332009-09-09 15:08:12 +000081
Chris Lattner443e53c2009-02-18 19:26:42 +000082 // Use the StringLiteralParser to compute the length of the string in bytes.
Douglas Gregorb90f4b32010-05-26 05:35:51 +000083 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
Chris Lattner443e53c2009-02-18 19:26:42 +000084 unsigned TokNumBytes = SLP.GetStringLength();
Mike Stump1eb44332009-09-09 15:08:12 +000085
Chris Lattner2197c962009-02-18 18:52:52 +000086 // If the byte is in this token, return the location of the byte.
Chris Lattner60800082009-02-18 17:49:48 +000087 if (ByteNo < TokNumBytes ||
88 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
Mike Stump1eb44332009-09-09 15:08:12 +000089 unsigned Offset =
Douglas Gregorb90f4b32010-05-26 05:35:51 +000090 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
91 /*Complain=*/false);
Mike Stump1eb44332009-09-09 15:08:12 +000092
Chris Lattner719e6152009-02-18 19:21:10 +000093 // Now that we know the offset of the token in the spelling, use the
94 // preprocessor to get the offset in the original source.
95 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
Chris Lattner60800082009-02-18 17:49:48 +000096 }
Mike Stump1eb44332009-09-09 15:08:12 +000097
Chris Lattner60800082009-02-18 17:49:48 +000098 // Move to the next string token.
99 ++TokNo;
100 ByteNo -= TokNumBytes;
101 }
102}
103
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000104/// CheckablePrintfAttr - does a function call have a "printf" attribute
105/// and arguments that merit checking?
106bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
107 if (Format->getType() == "printf") return true;
108 if (Format->getType() == "printf0") {
109 // printf0 allows null "format" string; if so don't check format/args
110 unsigned format_idx = Format->getFormatIdx() - 1;
Sebastian Redl4a2614e2009-11-17 18:02:24 +0000111 // Does the index refer to the implicit object argument?
112 if (isa<CXXMemberCallExpr>(TheCall)) {
113 if (format_idx == 0)
114 return false;
115 --format_idx;
116 }
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000117 if (format_idx < TheCall->getNumArgs()) {
118 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
Ted Kremenekefaff192010-02-27 01:41:03 +0000119 if (!Format->isNullPointerConstant(Context,
120 Expr::NPC_ValueDependentIsNull))
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000121 return true;
122 }
123 }
124 return false;
125}
Chris Lattner60800082009-02-18 17:49:48 +0000126
John McCall60d7b3a2010-08-24 06:29:42 +0000127ExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000128Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
John McCall60d7b3a2010-08-24 06:29:42 +0000129 ExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000130
Anders Carlssond406bf02009-08-16 01:56:34 +0000131 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000132 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000133 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000134 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000135 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000136 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000137 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000138 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000139 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000140 if (SemaBuiltinVAStart(TheCall))
141 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000142 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000143 case Builtin::BI__builtin_isgreater:
144 case Builtin::BI__builtin_isgreaterequal:
145 case Builtin::BI__builtin_isless:
146 case Builtin::BI__builtin_islessequal:
147 case Builtin::BI__builtin_islessgreater:
148 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000149 if (SemaBuiltinUnorderedCompare(TheCall))
150 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000151 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000152 case Builtin::BI__builtin_fpclassify:
153 if (SemaBuiltinFPClassification(TheCall, 6))
154 return ExprError();
155 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000156 case Builtin::BI__builtin_isfinite:
157 case Builtin::BI__builtin_isinf:
158 case Builtin::BI__builtin_isinf_sign:
159 case Builtin::BI__builtin_isnan:
160 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000161 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000162 return ExprError();
163 break;
Eli Friedman6cfda232008-05-20 08:23:37 +0000164 case Builtin::BI__builtin_return_address:
Eric Christopher691ebc32010-04-17 02:26:23 +0000165 case Builtin::BI__builtin_frame_address: {
166 llvm::APSInt Result;
167 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000168 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000169 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000170 }
171 case Builtin::BI__builtin_eh_return_data_regno: {
172 llvm::APSInt Result;
173 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Chris Lattner21fb98e2009-09-23 06:06:36 +0000174 return ExprError();
175 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000176 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000177 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000178 return SemaBuiltinShuffleVector(TheCall);
179 // TheCall will be freed by the smart pointer here, but that's fine, since
180 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000181 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000182 if (SemaBuiltinPrefetch(TheCall))
183 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000184 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000185 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000186 if (SemaBuiltinObjectSize(TheCall))
187 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000188 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000189 case Builtin::BI__builtin_longjmp:
190 if (SemaBuiltinLongjmp(TheCall))
191 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000192 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000193 case Builtin::BI__sync_fetch_and_add:
194 case Builtin::BI__sync_fetch_and_sub:
195 case Builtin::BI__sync_fetch_and_or:
196 case Builtin::BI__sync_fetch_and_and:
197 case Builtin::BI__sync_fetch_and_xor:
198 case Builtin::BI__sync_add_and_fetch:
199 case Builtin::BI__sync_sub_and_fetch:
200 case Builtin::BI__sync_and_and_fetch:
201 case Builtin::BI__sync_or_and_fetch:
202 case Builtin::BI__sync_xor_and_fetch:
203 case Builtin::BI__sync_val_compare_and_swap:
204 case Builtin::BI__sync_bool_compare_and_swap:
205 case Builtin::BI__sync_lock_test_and_set:
206 case Builtin::BI__sync_lock_release:
Chandler Carruthd2014572010-07-09 18:59:35 +0000207 return SemaBuiltinAtomicOverloaded(move(TheCallResult));
Nate Begeman26a31422010-06-08 02:47:44 +0000208 }
209
210 // Since the target specific builtins for each arch overlap, only check those
211 // of the arch we are compiling for.
212 if (BuiltinID >= Builtin::FirstTSBuiltin) {
213 switch (Context.Target.getTriple().getArch()) {
214 case llvm::Triple::arm:
215 case llvm::Triple::thumb:
216 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
217 return ExprError();
218 break;
219 case llvm::Triple::x86:
220 case llvm::Triple::x86_64:
221 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
222 return ExprError();
223 break;
224 default:
225 break;
226 }
227 }
228
229 return move(TheCallResult);
230}
231
232bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
233 switch (BuiltinID) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000234 case X86::BI__builtin_ia32_palignr128:
235 case X86::BI__builtin_ia32_palignr: {
236 llvm::APSInt Result;
237 if (SemaBuiltinConstantArg(TheCall, 2, Result))
Nate Begeman26a31422010-06-08 02:47:44 +0000238 return true;
Eric Christopher691ebc32010-04-17 02:26:23 +0000239 break;
240 }
Anders Carlsson71993dd2007-08-17 05:31:46 +0000241 }
Nate Begeman26a31422010-06-08 02:47:44 +0000242 return false;
243}
Mike Stump1eb44332009-09-09 15:08:12 +0000244
Nate Begeman61eecf52010-06-14 05:21:25 +0000245// Get the valid immediate range for the specified NEON type code.
246static unsigned RFT(unsigned t, bool shift = false) {
247 bool quad = t & 0x10;
248
249 switch (t & 0x7) {
250 case 0: // i8
Nate Begemand69ec162010-06-17 02:26:59 +0000251 return shift ? 7 : (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000252 case 1: // i16
Nate Begemand69ec162010-06-17 02:26:59 +0000253 return shift ? 15 : (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000254 case 2: // i32
Nate Begemand69ec162010-06-17 02:26:59 +0000255 return shift ? 31 : (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000256 case 3: // i64
Nate Begemand69ec162010-06-17 02:26:59 +0000257 return shift ? 63 : (1 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000258 case 4: // f32
259 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000260 return (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000261 case 5: // poly8
262 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000263 return (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000264 case 6: // poly16
265 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000266 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000267 case 7: // float16
268 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000269 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000270 }
271 return 0;
272}
273
Nate Begeman26a31422010-06-08 02:47:44 +0000274bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000275 llvm::APSInt Result;
276
Nate Begeman0d15c532010-06-13 04:47:52 +0000277 unsigned mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000278 unsigned TV = 0;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000279 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000280#define GET_NEON_OVERLOAD_CHECK
281#include "clang/Basic/arm_neon.inc"
282#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000283 }
284
Nate Begeman0d15c532010-06-13 04:47:52 +0000285 // For NEON intrinsics which are overloaded on vector element type, validate
286 // the immediate which specifies which variant to emit.
287 if (mask) {
288 unsigned ArgNo = TheCall->getNumArgs()-1;
289 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
290 return true;
291
Nate Begeman61eecf52010-06-14 05:21:25 +0000292 TV = Result.getLimitedValue(32);
293 if ((TV > 31) || (mask & (1 << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000294 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
295 << TheCall->getArg(ArgNo)->getSourceRange();
296 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000297
Nate Begeman0d15c532010-06-13 04:47:52 +0000298 // For NEON intrinsics which take an immediate value as part of the
299 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000300 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000301 switch (BuiltinID) {
302 default: return false;
Nate Begemanbb37f502010-07-29 22:48:34 +0000303 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
304 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begeman99c40bb2010-08-03 21:32:34 +0000305 case ARM::BI__builtin_arm_vcvtr_f:
306 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Nate Begemana23326b2010-06-17 04:17:01 +0000307#define GET_NEON_IMMEDIATE_CHECK
308#include "clang/Basic/arm_neon.inc"
309#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000310 };
311
Nate Begeman61eecf52010-06-14 05:21:25 +0000312 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000313 if (SemaBuiltinConstantArg(TheCall, i, Result))
314 return true;
315
Nate Begeman61eecf52010-06-14 05:21:25 +0000316 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000317 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000318 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000319 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Benjamin Kramer476d8b82010-08-11 14:47:12 +0000320 << l << u+l << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000321
Nate Begeman99c40bb2010-08-03 21:32:34 +0000322 // FIXME: VFP Intrinsics should error if VFP not present.
Nate Begeman26a31422010-06-08 02:47:44 +0000323 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000324}
Daniel Dunbarde454282008-10-02 18:44:07 +0000325
Anders Carlssond406bf02009-08-16 01:56:34 +0000326/// CheckFunctionCall - Check a direct function call for various correctness
327/// and safety properties not strictly enforced by the C type system.
328bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
329 // Get the IdentifierInfo* for the called function.
330 IdentifierInfo *FnInfo = FDecl->getIdentifier();
331
332 // None of the checks below are needed for functions that don't have
333 // simple names (e.g., C++ conversion functions).
334 if (!FnInfo)
335 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000336
Daniel Dunbarde454282008-10-02 18:44:07 +0000337 // FIXME: This mechanism should be abstracted to be less fragile and
338 // more efficient. For example, just map function ids to custom
339 // handlers.
340
Chris Lattner59907c42007-08-10 20:18:51 +0000341 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000342 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
Ted Kremenek826a3452010-07-16 02:11:22 +0000343 const bool b = Format->getType() == "scanf";
344 if (b || CheckablePrintfAttr(Format, TheCall)) {
Ted Kremenek3d692df2009-02-27 17:58:43 +0000345 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000346 CheckPrintfScanfArguments(TheCall, HasVAListArg,
347 Format->getFormatIdx() - 1,
348 HasVAListArg ? 0 : Format->getFirstArg() - 1,
349 !b);
Douglas Gregor3c385e52009-02-14 18:57:46 +0000350 }
Chris Lattner59907c42007-08-10 20:18:51 +0000351 }
Mike Stump1eb44332009-09-09 15:08:12 +0000352
Sean Huntcf807c42010-08-18 23:23:40 +0000353 specific_attr_iterator<NonNullAttr>
354 i = FDecl->specific_attr_begin<NonNullAttr>(),
355 e = FDecl->specific_attr_end<NonNullAttr>();
356
357 for (; i != e; ++i)
358 CheckNonNullArguments(*i, TheCall);
Sebastian Redl0eb23302009-01-19 00:08:26 +0000359
Anders Carlssond406bf02009-08-16 01:56:34 +0000360 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000361}
362
Anders Carlssond406bf02009-08-16 01:56:34 +0000363bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000364 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000365 const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000366 if (!Format)
Anders Carlssond406bf02009-08-16 01:56:34 +0000367 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000368
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000369 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
370 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000371 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000372
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000373 QualType Ty = V->getType();
374 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000375 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000376
Ted Kremenek826a3452010-07-16 02:11:22 +0000377 const bool b = Format->getType() == "scanf";
378 if (!b && !CheckablePrintfAttr(Format, TheCall))
Anders Carlssond406bf02009-08-16 01:56:34 +0000379 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000380
Anders Carlssond406bf02009-08-16 01:56:34 +0000381 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000382 CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
383 HasVAListArg ? 0 : Format->getFirstArg() - 1, !b);
Anders Carlssond406bf02009-08-16 01:56:34 +0000384
385 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000386}
387
Chris Lattner5caa3702009-05-08 06:58:22 +0000388/// SemaBuiltinAtomicOverloaded - We have a call to a function like
389/// __sync_fetch_and_add, which is an overloaded function based on the pointer
390/// type of its first argument. The main ActOnCallExpr routines have already
391/// promoted the types of arguments because all of these calls are prototyped as
392/// void(...).
393///
394/// This function goes through and does final semantic checking for these
395/// builtins,
John McCall60d7b3a2010-08-24 06:29:42 +0000396ExprResult
397Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000398 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000399 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
400 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
401
402 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000403 if (TheCall->getNumArgs() < 1) {
404 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
405 << 0 << 1 << TheCall->getNumArgs()
406 << TheCall->getCallee()->getSourceRange();
407 return ExprError();
408 }
Mike Stump1eb44332009-09-09 15:08:12 +0000409
Chris Lattner5caa3702009-05-08 06:58:22 +0000410 // Inspect the first argument of the atomic builtin. This should always be
411 // a pointer type, whose element is an integral scalar or pointer type.
412 // Because it is a pointer type, we don't have to worry about any implicit
413 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000414 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000415 Expr *FirstArg = TheCall->getArg(0);
Chandler Carruthd2014572010-07-09 18:59:35 +0000416 if (!FirstArg->getType()->isPointerType()) {
417 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
418 << FirstArg->getType() << FirstArg->getSourceRange();
419 return ExprError();
420 }
Mike Stump1eb44332009-09-09 15:08:12 +0000421
Chandler Carruthd2014572010-07-09 18:59:35 +0000422 QualType ValType =
423 FirstArg->getType()->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000424 if (!ValType->isIntegerType() && !ValType->isPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000425 !ValType->isBlockPointerType()) {
426 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
427 << FirstArg->getType() << FirstArg->getSourceRange();
428 return ExprError();
429 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000430
Chandler Carruth8d13d222010-07-18 20:54:12 +0000431 // The majority of builtins return a value, but a few have special return
432 // types, so allow them to override appropriately below.
433 QualType ResultType = ValType;
434
Chris Lattner5caa3702009-05-08 06:58:22 +0000435 // We need to figure out which concrete builtin this maps onto. For example,
436 // __sync_fetch_and_add with a 2 byte object turns into
437 // __sync_fetch_and_add_2.
438#define BUILTIN_ROW(x) \
439 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
440 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000441
Chris Lattner5caa3702009-05-08 06:58:22 +0000442 static const unsigned BuiltinIndices[][5] = {
443 BUILTIN_ROW(__sync_fetch_and_add),
444 BUILTIN_ROW(__sync_fetch_and_sub),
445 BUILTIN_ROW(__sync_fetch_and_or),
446 BUILTIN_ROW(__sync_fetch_and_and),
447 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000448
Chris Lattner5caa3702009-05-08 06:58:22 +0000449 BUILTIN_ROW(__sync_add_and_fetch),
450 BUILTIN_ROW(__sync_sub_and_fetch),
451 BUILTIN_ROW(__sync_and_and_fetch),
452 BUILTIN_ROW(__sync_or_and_fetch),
453 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000454
Chris Lattner5caa3702009-05-08 06:58:22 +0000455 BUILTIN_ROW(__sync_val_compare_and_swap),
456 BUILTIN_ROW(__sync_bool_compare_and_swap),
457 BUILTIN_ROW(__sync_lock_test_and_set),
458 BUILTIN_ROW(__sync_lock_release)
459 };
Mike Stump1eb44332009-09-09 15:08:12 +0000460#undef BUILTIN_ROW
461
Chris Lattner5caa3702009-05-08 06:58:22 +0000462 // Determine the index of the size.
463 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000464 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000465 case 1: SizeIndex = 0; break;
466 case 2: SizeIndex = 1; break;
467 case 4: SizeIndex = 2; break;
468 case 8: SizeIndex = 3; break;
469 case 16: SizeIndex = 4; break;
470 default:
Chandler Carruthd2014572010-07-09 18:59:35 +0000471 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
472 << FirstArg->getType() << FirstArg->getSourceRange();
473 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +0000474 }
Mike Stump1eb44332009-09-09 15:08:12 +0000475
Chris Lattner5caa3702009-05-08 06:58:22 +0000476 // Each of these builtins has one pointer argument, followed by some number of
477 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
478 // that we ignore. Find out which row of BuiltinIndices to read from as well
479 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000480 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000481 unsigned BuiltinIndex, NumFixed = 1;
482 switch (BuiltinID) {
483 default: assert(0 && "Unknown overloaded atomic builtin!");
484 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
485 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
486 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
487 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
488 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000489
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000490 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
491 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
492 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
493 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
494 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000495
Chris Lattner5caa3702009-05-08 06:58:22 +0000496 case Builtin::BI__sync_val_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000497 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000498 NumFixed = 2;
499 break;
500 case Builtin::BI__sync_bool_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000501 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000502 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000503 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000504 break;
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000505 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000506 case Builtin::BI__sync_lock_release:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000507 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000508 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000509 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000510 break;
511 }
Mike Stump1eb44332009-09-09 15:08:12 +0000512
Chris Lattner5caa3702009-05-08 06:58:22 +0000513 // Now that we know how many fixed arguments we expect, first check that we
514 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +0000515 if (TheCall->getNumArgs() < 1+NumFixed) {
516 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
517 << 0 << 1+NumFixed << TheCall->getNumArgs()
518 << TheCall->getCallee()->getSourceRange();
519 return ExprError();
520 }
Mike Stump1eb44332009-09-09 15:08:12 +0000521
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000522 // Get the decl for the concrete builtin from this, we can tell what the
523 // concrete integer type we should convert to is.
524 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
525 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
526 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000527 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000528 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
529 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +0000530
John McCallf871d0c2010-08-07 06:22:56 +0000531 // The first argument --- the pointer --- has a fixed type; we
532 // deduce the types of the rest of the arguments accordingly. Walk
533 // the remaining arguments, converting them to the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +0000534 for (unsigned i = 0; i != NumFixed; ++i) {
535 Expr *Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000536
Chris Lattner5caa3702009-05-08 06:58:22 +0000537 // If the argument is an implicit cast, then there was a promotion due to
538 // "...", just remove it now.
539 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
540 Arg = ICE->getSubExpr();
541 ICE->setSubExpr(0);
Chris Lattner5caa3702009-05-08 06:58:22 +0000542 TheCall->setArg(i+1, Arg);
543 }
Mike Stump1eb44332009-09-09 15:08:12 +0000544
Chris Lattner5caa3702009-05-08 06:58:22 +0000545 // GCC does an implicit conversion to the pointer or integer ValType. This
546 // can fail in some cases (1i -> int**), check for this error case now.
Anders Carlssoncdb61972009-08-07 22:21:05 +0000547 CastExpr::CastKind Kind = CastExpr::CK_Unknown;
John McCallf871d0c2010-08-07 06:22:56 +0000548 CXXCastPath BasePath;
Anders Carlsson5cf86ba2010-04-24 19:06:50 +0000549 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
Chandler Carruthd2014572010-07-09 18:59:35 +0000550 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +0000551
Chris Lattner5caa3702009-05-08 06:58:22 +0000552 // Okay, we have something that *can* be converted to the right type. Check
553 // to see if there is a potentially weird extension going on here. This can
554 // happen when you do an atomic operation on something like an char* and
555 // pass in 42. The 42 gets converted to char. This is even more strange
556 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000557 // FIXME: Do this check.
John McCallf871d0c2010-08-07 06:22:56 +0000558 ImpCastExprToType(Arg, ValType, Kind, ImplicitCastExpr::RValue, &BasePath);
Chris Lattner5caa3702009-05-08 06:58:22 +0000559 TheCall->setArg(i+1, Arg);
560 }
Mike Stump1eb44332009-09-09 15:08:12 +0000561
Chris Lattner5caa3702009-05-08 06:58:22 +0000562 // Switch the DeclRefExpr to refer to the new decl.
563 DRE->setDecl(NewBuiltinDecl);
564 DRE->setType(NewBuiltinDecl->getType());
Mike Stump1eb44332009-09-09 15:08:12 +0000565
Chris Lattner5caa3702009-05-08 06:58:22 +0000566 // Set the callee in the CallExpr.
567 // FIXME: This leaks the original parens and implicit casts.
568 Expr *PromotedCall = DRE;
569 UsualUnaryConversions(PromotedCall);
570 TheCall->setCallee(PromotedCall);
Mike Stump1eb44332009-09-09 15:08:12 +0000571
Chandler Carruthdb4325b2010-07-18 07:23:17 +0000572 // Change the result type of the call to match the original value type. This
573 // is arbitrary, but the codegen for these builtins ins design to handle it
574 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +0000575 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +0000576
577 return move(TheCallResult);
Chris Lattner5caa3702009-05-08 06:58:22 +0000578}
579
580
Chris Lattner69039812009-02-18 06:01:06 +0000581/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +0000582/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +0000583/// FIXME: GCC currently emits the following warning:
Mike Stump1eb44332009-09-09 15:08:12 +0000584/// "warning: input conversion stopped due to an input byte that does not
Steve Narofffd942622009-04-13 20:26:29 +0000585/// belong to the input codeset UTF-8"
586/// Note: It might also make sense to do the UTF-16 conversion here (would
587/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +0000588bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +0000589 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +0000590 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
591
592 if (!Literal || Literal->isWide()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000593 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
594 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000595 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000596 }
Mike Stump1eb44332009-09-09 15:08:12 +0000597
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +0000598 size_t NulPos = Literal->getString().find('\0');
599 if (NulPos != llvm::StringRef::npos) {
600 Diag(getLocationOfStringLiteralByte(Literal, NulPos),
601 diag::warn_cfstring_literal_contains_nul_character)
602 << Arg->getSourceRange();
Daniel Dunbarf015b032009-09-22 10:03:52 +0000603 }
Mike Stump1eb44332009-09-09 15:08:12 +0000604
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000605 return false;
Chris Lattner59907c42007-08-10 20:18:51 +0000606}
607
Chris Lattnerc27c6652007-12-20 00:05:45 +0000608/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
609/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +0000610bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
611 Expr *Fn = TheCall->getCallee();
612 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +0000613 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000614 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000615 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
616 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +0000617 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000618 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +0000619 return true;
620 }
Eli Friedman56f20ae2008-12-15 22:05:35 +0000621
622 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +0000623 return Diag(TheCall->getLocEnd(),
624 diag::err_typecheck_call_too_few_args_at_least)
625 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +0000626 }
627
Chris Lattnerc27c6652007-12-20 00:05:45 +0000628 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000629 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +0000630 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000631 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +0000632 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +0000633 else if (FunctionDecl *FD = getCurFunctionDecl())
634 isVariadic = FD->isVariadic();
635 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000636 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +0000637
Chris Lattnerc27c6652007-12-20 00:05:45 +0000638 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000639 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
640 return true;
641 }
Mike Stump1eb44332009-09-09 15:08:12 +0000642
Chris Lattner30ce3442007-12-19 23:59:04 +0000643 // Verify that the second argument to the builtin is the last argument of the
644 // current function or method.
645 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +0000646 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000647
Anders Carlsson88cf2262008-02-11 04:20:54 +0000648 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
649 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000650 // FIXME: This isn't correct for methods (results in bogus warning).
651 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +0000652 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000653 if (CurBlock)
654 LastArg = *(CurBlock->TheDecl->param_end()-1);
655 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +0000656 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000657 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000658 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000659 SecondArgIsLastNamedArgument = PV == LastArg;
660 }
661 }
Mike Stump1eb44332009-09-09 15:08:12 +0000662
Chris Lattner30ce3442007-12-19 23:59:04 +0000663 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +0000664 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +0000665 diag::warn_second_parameter_of_va_start_not_last_named_argument);
666 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +0000667}
Chris Lattner30ce3442007-12-19 23:59:04 +0000668
Chris Lattner1b9a0792007-12-20 00:26:33 +0000669/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
670/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +0000671bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
672 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +0000673 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000674 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +0000675 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +0000676 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000677 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000678 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000679 << SourceRange(TheCall->getArg(2)->getLocStart(),
680 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000681
Chris Lattner925e60d2007-12-28 05:29:59 +0000682 Expr *OrigArg0 = TheCall->getArg(0);
683 Expr *OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +0000684
Chris Lattner1b9a0792007-12-20 00:26:33 +0000685 // Do standard promotions between the two arguments, returning their common
686 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +0000687 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
Daniel Dunbar403bc2b2009-02-19 19:28:43 +0000688
689 // Make sure any conversions are pushed back into the call; this is
690 // type safe since unordered compare builtins are declared as "_Bool
691 // foo(...)".
692 TheCall->setArg(0, OrigArg0);
693 TheCall->setArg(1, OrigArg1);
Mike Stump1eb44332009-09-09 15:08:12 +0000694
Douglas Gregorcde01732009-05-19 22:10:17 +0000695 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
696 return false;
697
Chris Lattner1b9a0792007-12-20 00:26:33 +0000698 // If the common type isn't a real floating type, then the arguments were
699 // invalid for this operation.
700 if (!Res->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000701 return Diag(OrigArg0->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000702 diag::err_typecheck_call_invalid_ordered_compare)
Chris Lattnerd1625842008-11-24 06:25:27 +0000703 << OrigArg0->getType() << OrigArg1->getType()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000704 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000705
Chris Lattner1b9a0792007-12-20 00:26:33 +0000706 return false;
707}
708
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000709/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
710/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000711/// to check everything. We expect the last argument to be a floating point
712/// value.
713bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
714 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +0000715 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000716 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000717 if (TheCall->getNumArgs() > NumArgs)
718 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000719 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000720 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000721 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000722 (*(TheCall->arg_end()-1))->getLocEnd());
723
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000724 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +0000725
Eli Friedman9ac6f622009-08-31 20:06:00 +0000726 if (OrigArg->isTypeDependent())
727 return false;
728
Chris Lattner81368fb2010-05-06 05:50:07 +0000729 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +0000730 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000731 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000732 diag::err_typecheck_call_invalid_unary_fp)
733 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000734
Chris Lattner81368fb2010-05-06 05:50:07 +0000735 // If this is an implicit conversion from float -> double, remove it.
736 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
737 Expr *CastArg = Cast->getSubExpr();
738 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
739 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
740 "promotion from float to double is the only expected cast here");
741 Cast->setSubExpr(0);
Chris Lattner81368fb2010-05-06 05:50:07 +0000742 TheCall->setArg(NumArgs-1, CastArg);
743 OrigArg = CastArg;
744 }
745 }
746
Eli Friedman9ac6f622009-08-31 20:06:00 +0000747 return false;
748}
749
Eli Friedmand38617c2008-05-14 19:38:39 +0000750/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
751// This is declared to take (...), so we have to check everything.
John McCall60d7b3a2010-08-24 06:29:42 +0000752ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000753 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000754 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +0000755 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +0000756 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +0000757 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000758
Nate Begeman37b6a572010-06-08 00:16:34 +0000759 // Determine which of the following types of shufflevector we're checking:
760 // 1) unary, vector mask: (lhs, mask)
761 // 2) binary, vector mask: (lhs, rhs, mask)
762 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
763 QualType resType = TheCall->getArg(0)->getType();
764 unsigned numElements = 0;
765
Douglas Gregorcde01732009-05-19 22:10:17 +0000766 if (!TheCall->getArg(0)->isTypeDependent() &&
767 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000768 QualType LHSType = TheCall->getArg(0)->getType();
769 QualType RHSType = TheCall->getArg(1)->getType();
770
771 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000772 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000773 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000774 TheCall->getArg(1)->getLocEnd());
775 return ExprError();
776 }
Nate Begeman37b6a572010-06-08 00:16:34 +0000777
778 numElements = LHSType->getAs<VectorType>()->getNumElements();
779 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +0000780
Nate Begeman37b6a572010-06-08 00:16:34 +0000781 // Check to see if we have a call with 2 vector arguments, the unary shuffle
782 // with mask. If so, verify that RHS is an integer vector type with the
783 // same number of elts as lhs.
784 if (TheCall->getNumArgs() == 2) {
Douglas Gregorf6094622010-07-23 15:58:24 +0000785 if (!RHSType->hasIntegerRepresentation() ||
Nate Begeman37b6a572010-06-08 00:16:34 +0000786 RHSType->getAs<VectorType>()->getNumElements() != numElements)
787 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
788 << SourceRange(TheCall->getArg(1)->getLocStart(),
789 TheCall->getArg(1)->getLocEnd());
790 numResElements = numElements;
791 }
792 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000793 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000794 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000795 TheCall->getArg(1)->getLocEnd());
796 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +0000797 } else if (numElements != numResElements) {
798 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +0000799 resType = Context.getVectorType(eltType, numResElements,
800 VectorType::NotAltiVec);
Douglas Gregorcde01732009-05-19 22:10:17 +0000801 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000802 }
803
804 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000805 if (TheCall->getArg(i)->isTypeDependent() ||
806 TheCall->getArg(i)->isValueDependent())
807 continue;
808
Nate Begeman37b6a572010-06-08 00:16:34 +0000809 llvm::APSInt Result(32);
810 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
811 return ExprError(Diag(TheCall->getLocStart(),
812 diag::err_shufflevector_nonconstant_argument)
813 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +0000814
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000815 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000816 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000817 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000818 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000819 }
820
821 llvm::SmallVector<Expr*, 32> exprs;
822
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000823 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +0000824 exprs.push_back(TheCall->getArg(i));
825 TheCall->setArg(i, 0);
826 }
827
Nate Begemana88dc302009-08-12 02:10:25 +0000828 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +0000829 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +0000830 TheCall->getCallee()->getLocStart(),
831 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +0000832}
Chris Lattner30ce3442007-12-19 23:59:04 +0000833
Daniel Dunbar4493f792008-07-21 22:59:13 +0000834/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
835// This is declared to take (const void*, ...) and can take two
836// optional constant int args.
837bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000838 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000839
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000840 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +0000841 return Diag(TheCall->getLocEnd(),
842 diag::err_typecheck_call_too_many_args_at_most)
843 << 0 /*function call*/ << 3 << NumArgs
844 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000845
846 // Argument 0 is checked for us and the remaining arguments must be
847 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000848 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +0000849 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +0000850
Eli Friedman9aef7262009-12-04 00:30:06 +0000851 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +0000852 if (SemaBuiltinConstantArg(TheCall, i, Result))
853 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000854
Daniel Dunbar4493f792008-07-21 22:59:13 +0000855 // FIXME: gcc issues a warning and rewrites these to 0. These
856 // seems especially odd for the third argument since the default
857 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000858 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +0000859 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000860 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000861 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000862 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +0000863 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000864 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000865 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000866 }
867 }
868
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000869 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +0000870}
871
Eric Christopher691ebc32010-04-17 02:26:23 +0000872/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
873/// TheCall is a constant expression.
874bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
875 llvm::APSInt &Result) {
876 Expr *Arg = TheCall->getArg(ArgNum);
877 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
878 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
879
880 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
881
882 if (!Arg->isIntegerConstantExpr(Result, Context))
883 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +0000884 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +0000885
Chris Lattner21fb98e2009-09-23 06:06:36 +0000886 return false;
887}
888
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000889/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
890/// int type). This simply type checks that type is one of the defined
891/// constants (0-3).
Eric Christopherfee667f2009-12-23 03:49:37 +0000892// For compatability check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000893bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000894 llvm::APSInt Result;
895
896 // Check constant-ness first.
897 if (SemaBuiltinConstantArg(TheCall, 1, Result))
898 return true;
899
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000900 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000901 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000902 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
903 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000904 }
905
906 return false;
907}
908
Eli Friedman586d6a82009-05-03 06:04:26 +0000909/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +0000910/// This checks that val is a constant 1.
911bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
912 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +0000913 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +0000914
Eric Christopher691ebc32010-04-17 02:26:23 +0000915 // TODO: This is less than ideal. Overload this to take a value.
916 if (SemaBuiltinConstantArg(TheCall, 1, Result))
917 return true;
918
919 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +0000920 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
921 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
922
923 return false;
924}
925
Ted Kremenekd30ef872009-01-12 23:09:09 +0000926// Handle i > 1 ? "x" : "y", recursivelly
Ted Kremenek082d9362009-03-20 21:35:28 +0000927bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
928 bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000929 unsigned format_idx, unsigned firstDataArg,
930 bool isPrintf) {
931
Douglas Gregorcde01732009-05-19 22:10:17 +0000932 if (E->isTypeDependent() || E->isValueDependent())
933 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +0000934
935 switch (E->getStmtClass()) {
936 case Stmt::ConditionalOperatorClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000937 const ConditionalOperator *C = cast<ConditionalOperator>(E);
Ted Kremenek826a3452010-07-16 02:11:22 +0000938 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg,
939 format_idx, firstDataArg, isPrintf)
940 && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg,
941 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000942 }
943
944 case Stmt::ImplicitCastExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000945 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000946 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000947 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000948 }
949
950 case Stmt::ParenExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000951 const ParenExpr *Expr = cast<ParenExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000952 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000953 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000954 }
Mike Stump1eb44332009-09-09 15:08:12 +0000955
Ted Kremenek082d9362009-03-20 21:35:28 +0000956 case Stmt::DeclRefExprClass: {
957 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000958
Ted Kremenek082d9362009-03-20 21:35:28 +0000959 // As an exception, do not flag errors for variables binding to
960 // const string literals.
961 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
962 bool isConstant = false;
963 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +0000964
Ted Kremenek082d9362009-03-20 21:35:28 +0000965 if (const ArrayType *AT = Context.getAsArrayType(T)) {
966 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +0000967 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000968 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +0000969 PT->getPointeeType().isConstant(Context);
970 }
Mike Stump1eb44332009-09-09 15:08:12 +0000971
Ted Kremenek082d9362009-03-20 21:35:28 +0000972 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +0000973 if (const Expr *Init = VD->getAnyInitializer())
Ted Kremenek082d9362009-03-20 21:35:28 +0000974 return SemaCheckStringLiteral(Init, TheCall,
Ted Kremenek826a3452010-07-16 02:11:22 +0000975 HasVAListArg, format_idx, firstDataArg,
976 isPrintf);
Ted Kremenek082d9362009-03-20 21:35:28 +0000977 }
Mike Stump1eb44332009-09-09 15:08:12 +0000978
Anders Carlssond966a552009-06-28 19:55:58 +0000979 // For vprintf* functions (i.e., HasVAListArg==true), we add a
980 // special check to see if the format string is a function parameter
981 // of the function calling the printf function. If the function
982 // has an attribute indicating it is a printf-like function, then we
983 // should suppress warnings concerning non-literals being used in a call
984 // to a vprintf function. For example:
985 //
986 // void
987 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
988 // va_list ap;
989 // va_start(ap, fmt);
990 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
991 // ...
992 //
993 //
994 // FIXME: We don't have full attribute support yet, so just check to see
995 // if the argument is a DeclRefExpr that references a parameter. We'll
996 // add proper support for checking the attribute later.
997 if (HasVAListArg)
998 if (isa<ParmVarDecl>(VD))
999 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +00001000 }
Mike Stump1eb44332009-09-09 15:08:12 +00001001
Ted Kremenek082d9362009-03-20 21:35:28 +00001002 return false;
1003 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001004
Anders Carlsson8f031b32009-06-27 04:05:33 +00001005 case Stmt::CallExprClass: {
1006 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001007 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +00001008 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
1009 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
1010 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +00001011 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001012 unsigned ArgIndex = FA->getFormatIdx();
1013 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001014
1015 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001016 format_idx, firstDataArg, isPrintf);
Anders Carlsson8f031b32009-06-27 04:05:33 +00001017 }
1018 }
1019 }
1020 }
Mike Stump1eb44332009-09-09 15:08:12 +00001021
Anders Carlsson8f031b32009-06-27 04:05:33 +00001022 return false;
1023 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001024 case Stmt::ObjCStringLiteralClass:
1025 case Stmt::StringLiteralClass: {
1026 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001027
Ted Kremenek082d9362009-03-20 21:35:28 +00001028 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001029 StrE = ObjCFExpr->getString();
1030 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001031 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001032
Ted Kremenekd30ef872009-01-12 23:09:09 +00001033 if (StrE) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001034 CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx,
1035 firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001036 return true;
1037 }
Mike Stump1eb44332009-09-09 15:08:12 +00001038
Ted Kremenekd30ef872009-01-12 23:09:09 +00001039 return false;
1040 }
Mike Stump1eb44332009-09-09 15:08:12 +00001041
Ted Kremenek082d9362009-03-20 21:35:28 +00001042 default:
1043 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001044 }
1045}
1046
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001047void
Mike Stump1eb44332009-09-09 15:08:12 +00001048Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
1049 const CallExpr *TheCall) {
Sean Huntcf807c42010-08-18 23:23:40 +00001050 for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1051 e = NonNull->args_end();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001052 i != e; ++i) {
Chris Lattner12b97ff2009-05-25 18:23:36 +00001053 const Expr *ArgExpr = TheCall->getArg(*i);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001054 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001055 Expr::NPC_ValueDependentIsNotNull))
Chris Lattner12b97ff2009-05-25 18:23:36 +00001056 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
1057 << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001058 }
1059}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001060
Ted Kremenek826a3452010-07-16 02:11:22 +00001061/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1062/// functions) for correct use of format strings.
Chris Lattner59907c42007-08-10 20:18:51 +00001063void
Ted Kremenek826a3452010-07-16 02:11:22 +00001064Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg,
1065 unsigned format_idx, unsigned firstDataArg,
1066 bool isPrintf) {
1067
Ted Kremenek082d9362009-03-20 21:35:28 +00001068 const Expr *Fn = TheCall->getCallee();
Chris Lattner925e60d2007-12-28 05:29:59 +00001069
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001070 // The way the format attribute works in GCC, the implicit this argument
1071 // of member functions is counted. However, it doesn't appear in our own
1072 // lists, so decrement format_idx in that case.
1073 if (isa<CXXMemberCallExpr>(TheCall)) {
1074 // Catch a format attribute mistakenly referring to the object argument.
1075 if (format_idx == 0)
1076 return;
1077 --format_idx;
1078 if(firstDataArg != 0)
1079 --firstDataArg;
1080 }
1081
Ted Kremenek826a3452010-07-16 02:11:22 +00001082 // CHECK: printf/scanf-like function is called with no format string.
Chris Lattner925e60d2007-12-28 05:29:59 +00001083 if (format_idx >= TheCall->getNumArgs()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001084 Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string)
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001085 << Fn->getSourceRange();
Ted Kremenek71895b92007-08-14 17:39:48 +00001086 return;
1087 }
Mike Stump1eb44332009-09-09 15:08:12 +00001088
Ted Kremenek082d9362009-03-20 21:35:28 +00001089 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001090
Chris Lattner59907c42007-08-10 20:18:51 +00001091 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001092 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001093 // Dynamically generated format strings are difficult to
1094 // automatically vet at compile time. Requiring that format strings
1095 // are string literals: (1) permits the checking of format strings by
1096 // the compiler and thereby (2) can practically remove the source of
1097 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001098
Mike Stump1eb44332009-09-09 15:08:12 +00001099 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001100 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001101 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001102 // the same format string checking logic for both ObjC and C strings.
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001103 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
Ted Kremenek826a3452010-07-16 02:11:22 +00001104 firstDataArg, isPrintf))
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001105 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001106
Chris Lattner655f1412009-04-29 04:59:47 +00001107 // If there are no arguments specified, warn with -Wformat-security, otherwise
1108 // warn only with -Wformat-nonliteral.
1109 if (TheCall->getNumArgs() == format_idx+1)
Mike Stump1eb44332009-09-09 15:08:12 +00001110 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001111 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001112 << OrigFormatExpr->getSourceRange();
1113 else
Mike Stump1eb44332009-09-09 15:08:12 +00001114 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001115 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001116 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001117}
Ted Kremenek71895b92007-08-14 17:39:48 +00001118
Ted Kremeneke0e53132010-01-28 23:39:18 +00001119namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001120class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1121protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001122 Sema &S;
1123 const StringLiteral *FExpr;
1124 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001125 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001126 const unsigned NumDataArgs;
1127 const bool IsObjCLiteral;
1128 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001129 const bool HasVAListArg;
1130 const CallExpr *TheCall;
1131 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001132 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001133 bool usesPositionalArgs;
1134 bool atFirstArg;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001135public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001136 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001137 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001138 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001139 const char *beg, bool hasVAListArg,
1140 const CallExpr *theCall, unsigned formatIdx)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001141 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001142 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001143 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001144 IsObjCLiteral(isObjCLiteral), Beg(beg),
1145 HasVAListArg(hasVAListArg),
Ted Kremenekefaff192010-02-27 01:41:03 +00001146 TheCall(theCall), FormatIdx(formatIdx),
1147 usesPositionalArgs(false), atFirstArg(true) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001148 CoveredArgs.resize(numDataArgs);
1149 CoveredArgs.reset();
1150 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001151
Ted Kremenek07d161f2010-01-29 01:50:07 +00001152 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001153
Ted Kremenek826a3452010-07-16 02:11:22 +00001154 void HandleIncompleteSpecifier(const char *startSpecifier,
1155 unsigned specifierLen);
1156
Ted Kremenekefaff192010-02-27 01:41:03 +00001157 virtual void HandleInvalidPosition(const char *startSpecifier,
1158 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001159 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001160
1161 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1162
Ted Kremeneke0e53132010-01-28 23:39:18 +00001163 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001164
Ted Kremenek826a3452010-07-16 02:11:22 +00001165protected:
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001166 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1167 const char *startSpec,
1168 unsigned specifierLen,
1169 const char *csStart, unsigned csLen);
1170
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001171 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001172 CharSourceRange getSpecifierRange(const char *startSpecifier,
1173 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001174 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001175
Ted Kremenek0d277352010-01-29 01:06:55 +00001176 const Expr *getDataArg(unsigned i) const;
Ted Kremenek666a1972010-07-26 19:45:42 +00001177
1178 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1179 const analyze_format_string::ConversionSpecifier &CS,
1180 const char *startSpecifier, unsigned specifierLen,
1181 unsigned argIndex);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001182};
1183}
1184
Ted Kremenek826a3452010-07-16 02:11:22 +00001185SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001186 return OrigFormatExpr->getSourceRange();
1187}
1188
Ted Kremenek826a3452010-07-16 02:11:22 +00001189CharSourceRange CheckFormatHandler::
1190getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001191 SourceLocation Start = getLocationOfByte(startSpecifier);
1192 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
1193
1194 // Advance the end SourceLocation by one due to half-open ranges.
1195 End = End.getFileLocWithOffset(1);
1196
1197 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001198}
1199
Ted Kremenek826a3452010-07-16 02:11:22 +00001200SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001201 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001202}
1203
Ted Kremenek826a3452010-07-16 02:11:22 +00001204void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
1205 unsigned specifierLen){
Ted Kremenek808015a2010-01-29 03:16:21 +00001206 SourceLocation Loc = getLocationOfByte(startSpecifier);
1207 S.Diag(Loc, diag::warn_printf_incomplete_specifier)
Ted Kremenek826a3452010-07-16 02:11:22 +00001208 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek808015a2010-01-29 03:16:21 +00001209}
1210
Ted Kremenekefaff192010-02-27 01:41:03 +00001211void
Ted Kremenek826a3452010-07-16 02:11:22 +00001212CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1213 analyze_format_string::PositionContext p) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001214 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001215 S.Diag(Loc, diag::warn_format_invalid_positional_specifier)
1216 << (unsigned) p << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001217}
1218
Ted Kremenek826a3452010-07-16 02:11:22 +00001219void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00001220 unsigned posLen) {
1221 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001222 S.Diag(Loc, diag::warn_format_zero_positional_specifier)
1223 << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001224}
1225
Ted Kremenek826a3452010-07-16 02:11:22 +00001226void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
1227 // The presence of a null character is likely an error.
1228 S.Diag(getLocationOfByte(nullCharacter),
1229 diag::warn_printf_format_string_contains_null_char)
1230 << getFormatStringRange();
1231}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001232
Ted Kremenek826a3452010-07-16 02:11:22 +00001233const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
1234 return TheCall->getArg(FirstDataArg + i);
1235}
1236
1237void CheckFormatHandler::DoneProcessing() {
1238 // Does the number of data arguments exceed the number of
1239 // format conversions in the format string?
1240 if (!HasVAListArg) {
1241 // Find any arguments that weren't covered.
1242 CoveredArgs.flip();
1243 signed notCoveredArg = CoveredArgs.find_first();
1244 if (notCoveredArg >= 0) {
1245 assert((unsigned)notCoveredArg < NumDataArgs);
1246 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
1247 diag::warn_printf_data_arg_not_used)
1248 << getFormatStringRange();
1249 }
1250 }
1251}
1252
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001253bool
1254CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
1255 SourceLocation Loc,
1256 const char *startSpec,
1257 unsigned specifierLen,
1258 const char *csStart,
1259 unsigned csLen) {
1260
1261 bool keepGoing = true;
1262 if (argIndex < NumDataArgs) {
1263 // Consider the argument coverered, even though the specifier doesn't
1264 // make sense.
1265 CoveredArgs.set(argIndex);
1266 }
1267 else {
1268 // If argIndex exceeds the number of data arguments we
1269 // don't issue a warning because that is just a cascade of warnings (and
1270 // they may have intended '%%' anyway). We don't want to continue processing
1271 // the format string after this point, however, as we will like just get
1272 // gibberish when trying to match arguments.
1273 keepGoing = false;
1274 }
1275
1276 S.Diag(Loc, diag::warn_format_invalid_conversion)
1277 << llvm::StringRef(csStart, csLen)
1278 << getSpecifierRange(startSpec, specifierLen);
1279
1280 return keepGoing;
1281}
1282
Ted Kremenek666a1972010-07-26 19:45:42 +00001283bool
1284CheckFormatHandler::CheckNumArgs(
1285 const analyze_format_string::FormatSpecifier &FS,
1286 const analyze_format_string::ConversionSpecifier &CS,
1287 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
1288
1289 if (argIndex >= NumDataArgs) {
1290 if (FS.usesPositionalArg()) {
1291 S.Diag(getLocationOfByte(CS.getStart()),
1292 diag::warn_printf_positional_arg_exceeds_data_args)
1293 << (argIndex+1) << NumDataArgs
1294 << getSpecifierRange(startSpecifier, specifierLen);
1295 }
1296 else {
1297 S.Diag(getLocationOfByte(CS.getStart()),
1298 diag::warn_printf_insufficient_data_args)
1299 << getSpecifierRange(startSpecifier, specifierLen);
1300 }
1301
1302 return false;
1303 }
1304 return true;
1305}
1306
Ted Kremenek826a3452010-07-16 02:11:22 +00001307//===--- CHECK: Printf format string checking ------------------------------===//
1308
1309namespace {
1310class CheckPrintfHandler : public CheckFormatHandler {
1311public:
1312 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
1313 const Expr *origFormatExpr, unsigned firstDataArg,
1314 unsigned numDataArgs, bool isObjCLiteral,
1315 const char *beg, bool hasVAListArg,
1316 const CallExpr *theCall, unsigned formatIdx)
1317 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1318 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1319 theCall, formatIdx) {}
1320
1321
1322 bool HandleInvalidPrintfConversionSpecifier(
1323 const analyze_printf::PrintfSpecifier &FS,
1324 const char *startSpecifier,
1325 unsigned specifierLen);
1326
1327 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
1328 const char *startSpecifier,
1329 unsigned specifierLen);
1330
1331 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
1332 const char *startSpecifier, unsigned specifierLen);
1333 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
1334 const analyze_printf::OptionalAmount &Amt,
1335 unsigned type,
1336 const char *startSpecifier, unsigned specifierLen);
1337 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
1338 const analyze_printf::OptionalFlag &flag,
1339 const char *startSpecifier, unsigned specifierLen);
1340 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
1341 const analyze_printf::OptionalFlag &ignoredFlag,
1342 const analyze_printf::OptionalFlag &flag,
1343 const char *startSpecifier, unsigned specifierLen);
1344};
1345}
1346
1347bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
1348 const analyze_printf::PrintfSpecifier &FS,
1349 const char *startSpecifier,
1350 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001351 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001352 FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001353
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001354 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1355 getLocationOfByte(CS.getStart()),
1356 startSpecifier, specifierLen,
1357 CS.getStart(), CS.getLength());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001358}
1359
Ted Kremenek826a3452010-07-16 02:11:22 +00001360bool CheckPrintfHandler::HandleAmount(
1361 const analyze_format_string::OptionalAmount &Amt,
1362 unsigned k, const char *startSpecifier,
1363 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001364
1365 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001366 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001367 unsigned argIndex = Amt.getArgIndex();
1368 if (argIndex >= NumDataArgs) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001369 S.Diag(getLocationOfByte(Amt.getStart()),
1370 diag::warn_printf_asterisk_missing_arg)
Ted Kremenek826a3452010-07-16 02:11:22 +00001371 << k << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001372 // Don't do any more checking. We will just emit
1373 // spurious errors.
1374 return false;
1375 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001376
Ted Kremenek0d277352010-01-29 01:06:55 +00001377 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001378 // Although not in conformance with C99, we also allow the argument to be
1379 // an 'unsigned int' as that is a reasonably safe case. GCC also
1380 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001381 CoveredArgs.set(argIndex);
1382 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001383 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001384
1385 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1386 assert(ATR.isValid());
1387
1388 if (!ATR.matchesType(S.Context, T)) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001389 S.Diag(getLocationOfByte(Amt.getStart()),
1390 diag::warn_printf_asterisk_wrong_type)
1391 << k
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001392 << ATR.getRepresentativeType(S.Context) << T
Ted Kremenek826a3452010-07-16 02:11:22 +00001393 << getSpecifierRange(startSpecifier, specifierLen)
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001394 << Arg->getSourceRange();
Ted Kremenek0d277352010-01-29 01:06:55 +00001395 // Don't do any more checking. We will just emit
1396 // spurious errors.
1397 return false;
1398 }
1399 }
1400 }
1401 return true;
1402}
Ted Kremenek0d277352010-01-29 01:06:55 +00001403
Tom Caree4ee9662010-06-17 19:00:27 +00001404void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00001405 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001406 const analyze_printf::OptionalAmount &Amt,
1407 unsigned type,
1408 const char *startSpecifier,
1409 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001410 const analyze_printf::PrintfConversionSpecifier &CS =
1411 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001412 switch (Amt.getHowSpecified()) {
1413 case analyze_printf::OptionalAmount::Constant:
1414 S.Diag(getLocationOfByte(Amt.getStart()),
1415 diag::warn_printf_nonsensical_optional_amount)
1416 << type
1417 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001418 << getSpecifierRange(startSpecifier, specifierLen)
1419 << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001420 Amt.getConstantLength()));
1421 break;
1422
1423 default:
1424 S.Diag(getLocationOfByte(Amt.getStart()),
1425 diag::warn_printf_nonsensical_optional_amount)
1426 << type
1427 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001428 << getSpecifierRange(startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001429 break;
1430 }
1431}
1432
Ted Kremenek826a3452010-07-16 02:11:22 +00001433void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001434 const analyze_printf::OptionalFlag &flag,
1435 const char *startSpecifier,
1436 unsigned specifierLen) {
1437 // Warn about pointless flag with a fixit removal.
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001438 const analyze_printf::PrintfConversionSpecifier &CS =
1439 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001440 S.Diag(getLocationOfByte(flag.getPosition()),
1441 diag::warn_printf_nonsensical_flag)
1442 << flag.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001443 << getSpecifierRange(startSpecifier, specifierLen)
1444 << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1));
Tom Caree4ee9662010-06-17 19:00:27 +00001445}
1446
1447void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00001448 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001449 const analyze_printf::OptionalFlag &ignoredFlag,
1450 const analyze_printf::OptionalFlag &flag,
1451 const char *startSpecifier,
1452 unsigned specifierLen) {
1453 // Warn about ignored flag with a fixit removal.
1454 S.Diag(getLocationOfByte(ignoredFlag.getPosition()),
1455 diag::warn_printf_ignored_flag)
1456 << ignoredFlag.toString() << flag.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001457 << getSpecifierRange(startSpecifier, specifierLen)
1458 << FixItHint::CreateRemoval(getSpecifierRange(
Tom Caree4ee9662010-06-17 19:00:27 +00001459 ignoredFlag.getPosition(), 1));
1460}
1461
Ted Kremeneke0e53132010-01-28 23:39:18 +00001462bool
Ted Kremenek826a3452010-07-16 02:11:22 +00001463CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001464 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001465 const char *startSpecifier,
1466 unsigned specifierLen) {
1467
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001468 using namespace analyze_format_string;
Ted Kremenekefaff192010-02-27 01:41:03 +00001469 using namespace analyze_printf;
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001470 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremeneke0e53132010-01-28 23:39:18 +00001471
Ted Kremenekbaa40062010-07-19 22:01:06 +00001472 if (FS.consumesDataArgument()) {
1473 if (atFirstArg) {
1474 atFirstArg = false;
1475 usesPositionalArgs = FS.usesPositionalArg();
1476 }
1477 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1478 // Cannot mix-and-match positional and non-positional arguments.
1479 S.Diag(getLocationOfByte(CS.getStart()),
1480 diag::warn_format_mix_positional_nonpositional_args)
1481 << getSpecifierRange(startSpecifier, specifierLen);
1482 return false;
1483 }
Ted Kremenek0d277352010-01-29 01:06:55 +00001484 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001485
Ted Kremenekefaff192010-02-27 01:41:03 +00001486 // First check if the field width, precision, and conversion specifier
1487 // have matching data arguments.
1488 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
1489 startSpecifier, specifierLen)) {
1490 return false;
1491 }
1492
1493 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
1494 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001495 return false;
1496 }
1497
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001498 if (!CS.consumesDataArgument()) {
1499 // FIXME: Technically specifying a precision or field width here
1500 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001501 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001502 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001503
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001504 // Consume the argument.
1505 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00001506 if (argIndex < NumDataArgs) {
1507 // The check to see if the argIndex is valid will come later.
1508 // We set the bit here because we may exit early from this
1509 // function if we encounter some other error.
1510 CoveredArgs.set(argIndex);
1511 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001512
1513 // Check for using an Objective-C specific conversion specifier
1514 // in a non-ObjC literal.
1515 if (!IsObjCLiteral && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001516 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
1517 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001518 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001519
Tom Caree4ee9662010-06-17 19:00:27 +00001520 // Check for invalid use of field width
1521 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001522 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00001523 startSpecifier, specifierLen);
1524 }
1525
1526 // Check for invalid use of precision
1527 if (!FS.hasValidPrecision()) {
1528 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
1529 startSpecifier, specifierLen);
1530 }
1531
1532 // Check each flag does not conflict with any other component.
1533 if (!FS.hasValidLeadingZeros())
1534 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
1535 if (!FS.hasValidPlusPrefix())
1536 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00001537 if (!FS.hasValidSpacePrefix())
1538 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001539 if (!FS.hasValidAlternativeForm())
1540 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
1541 if (!FS.hasValidLeftJustified())
1542 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
1543
1544 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00001545 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
1546 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
1547 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001548 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
1549 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
1550 startSpecifier, specifierLen);
1551
1552 // Check the length modifier is valid with the given conversion specifier.
1553 const LengthModifier &LM = FS.getLengthModifier();
1554 if (!FS.hasValidLengthModifier())
1555 S.Diag(getLocationOfByte(LM.getStart()),
Ted Kremenek649aecf2010-07-20 20:03:43 +00001556 diag::warn_format_nonsensical_length)
Tom Caree4ee9662010-06-17 19:00:27 +00001557 << LM.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001558 << getSpecifierRange(startSpecifier, specifierLen)
1559 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001560 LM.getLength()));
1561
1562 // Are we using '%n'?
Ted Kremenek35d353b2010-07-20 20:04:10 +00001563 if (CS.getKind() == ConversionSpecifier::nArg) {
Tom Caree4ee9662010-06-17 19:00:27 +00001564 // Issue a warning about this being a possible security issue.
Ted Kremeneke82d8042010-01-29 01:35:25 +00001565 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
Ted Kremenek826a3452010-07-16 02:11:22 +00001566 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremeneke82d8042010-01-29 01:35:25 +00001567 // Continue checking the other format specifiers.
1568 return true;
1569 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001570
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001571 // The remaining checks depend on the data arguments.
1572 if (HasVAListArg)
1573 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001574
Ted Kremenek666a1972010-07-26 19:45:42 +00001575 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001576 return false;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001577
Michael J. Spencer96827eb2010-07-27 04:46:02 +00001578 // Now type check the data expression that matches the
1579 // format specifier.
1580 const Expr *Ex = getDataArg(argIndex);
1581 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
1582 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
1583 // Check if we didn't match because of an implicit cast from a 'char'
1584 // or 'short' to an 'int'. This is done because printf is a varargs
1585 // function.
1586 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
1587 if (ICE->getType() == S.Context.IntTy)
1588 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
1589 return true;
1590
1591 // We may be able to offer a FixItHint if it is a supported type.
1592 PrintfSpecifier fixedFS = FS;
1593 bool success = fixedFS.fixType(Ex->getType());
1594
1595 if (success) {
1596 // Get the fix string from the fixed format specifier
1597 llvm::SmallString<128> buf;
1598 llvm::raw_svector_ostream os(buf);
1599 fixedFS.toString(os);
1600
Ted Kremenek9325eaf2010-08-24 22:24:51 +00001601 // FIXME: getRepresentativeType() perhaps should return a string
1602 // instead of a QualType to better handle when the representative
1603 // type is 'wint_t' (which is defined in the system headers).
Michael J. Spencer96827eb2010-07-27 04:46:02 +00001604 S.Diag(getLocationOfByte(CS.getStart()),
1605 diag::warn_printf_conversion_argument_type_mismatch)
1606 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1607 << getSpecifierRange(startSpecifier, specifierLen)
1608 << Ex->getSourceRange()
1609 << FixItHint::CreateReplacement(
1610 getSpecifierRange(startSpecifier, specifierLen),
1611 os.str());
1612 }
1613 else {
1614 S.Diag(getLocationOfByte(CS.getStart()),
1615 diag::warn_printf_conversion_argument_type_mismatch)
1616 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1617 << getSpecifierRange(startSpecifier, specifierLen)
1618 << Ex->getSourceRange();
1619 }
1620 }
1621
Ted Kremeneke0e53132010-01-28 23:39:18 +00001622 return true;
1623}
1624
Ted Kremenek826a3452010-07-16 02:11:22 +00001625//===--- CHECK: Scanf format string checking ------------------------------===//
1626
1627namespace {
1628class CheckScanfHandler : public CheckFormatHandler {
1629public:
1630 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
1631 const Expr *origFormatExpr, unsigned firstDataArg,
1632 unsigned numDataArgs, bool isObjCLiteral,
1633 const char *beg, bool hasVAListArg,
1634 const CallExpr *theCall, unsigned formatIdx)
1635 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1636 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1637 theCall, formatIdx) {}
1638
1639 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
1640 const char *startSpecifier,
1641 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001642
1643 bool HandleInvalidScanfConversionSpecifier(
1644 const analyze_scanf::ScanfSpecifier &FS,
1645 const char *startSpecifier,
1646 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00001647
1648 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00001649};
Ted Kremenek07d161f2010-01-29 01:50:07 +00001650}
Ted Kremeneke0e53132010-01-28 23:39:18 +00001651
Ted Kremenekb7c21012010-07-16 18:28:03 +00001652void CheckScanfHandler::HandleIncompleteScanList(const char *start,
1653 const char *end) {
1654 S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete)
1655 << getSpecifierRange(start, end - start);
1656}
1657
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001658bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
1659 const analyze_scanf::ScanfSpecifier &FS,
1660 const char *startSpecifier,
1661 unsigned specifierLen) {
1662
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001663 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001664 FS.getConversionSpecifier();
1665
1666 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1667 getLocationOfByte(CS.getStart()),
1668 startSpecifier, specifierLen,
1669 CS.getStart(), CS.getLength());
1670}
1671
Ted Kremenek826a3452010-07-16 02:11:22 +00001672bool CheckScanfHandler::HandleScanfSpecifier(
1673 const analyze_scanf::ScanfSpecifier &FS,
1674 const char *startSpecifier,
1675 unsigned specifierLen) {
1676
1677 using namespace analyze_scanf;
1678 using namespace analyze_format_string;
1679
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001680 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001681
Ted Kremenekbaa40062010-07-19 22:01:06 +00001682 // Handle case where '%' and '*' don't consume an argument. These shouldn't
1683 // be used to decide if we are using positional arguments consistently.
1684 if (FS.consumesDataArgument()) {
1685 if (atFirstArg) {
1686 atFirstArg = false;
1687 usesPositionalArgs = FS.usesPositionalArg();
1688 }
1689 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1690 // Cannot mix-and-match positional and non-positional arguments.
1691 S.Diag(getLocationOfByte(CS.getStart()),
1692 diag::warn_format_mix_positional_nonpositional_args)
1693 << getSpecifierRange(startSpecifier, specifierLen);
1694 return false;
1695 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001696 }
1697
1698 // Check if the field with is non-zero.
1699 const OptionalAmount &Amt = FS.getFieldWidth();
1700 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
1701 if (Amt.getConstantAmount() == 0) {
1702 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
1703 Amt.getConstantLength());
1704 S.Diag(getLocationOfByte(Amt.getStart()),
1705 diag::warn_scanf_nonzero_width)
1706 << R << FixItHint::CreateRemoval(R);
1707 }
1708 }
1709
1710 if (!FS.consumesDataArgument()) {
1711 // FIXME: Technically specifying a precision or field width here
1712 // makes no sense. Worth issuing a warning at some point.
1713 return true;
1714 }
1715
1716 // Consume the argument.
1717 unsigned argIndex = FS.getArgIndex();
1718 if (argIndex < NumDataArgs) {
1719 // The check to see if the argIndex is valid will come later.
1720 // We set the bit here because we may exit early from this
1721 // function if we encounter some other error.
1722 CoveredArgs.set(argIndex);
1723 }
1724
Ted Kremenek1e51c202010-07-20 20:04:47 +00001725 // Check the length modifier is valid with the given conversion specifier.
1726 const LengthModifier &LM = FS.getLengthModifier();
1727 if (!FS.hasValidLengthModifier()) {
1728 S.Diag(getLocationOfByte(LM.getStart()),
1729 diag::warn_format_nonsensical_length)
1730 << LM.toString() << CS.toString()
1731 << getSpecifierRange(startSpecifier, specifierLen)
1732 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
1733 LM.getLength()));
1734 }
1735
Ted Kremenek826a3452010-07-16 02:11:22 +00001736 // The remaining checks depend on the data arguments.
1737 if (HasVAListArg)
1738 return true;
1739
Ted Kremenek666a1972010-07-26 19:45:42 +00001740 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek826a3452010-07-16 02:11:22 +00001741 return false;
Ted Kremenek826a3452010-07-16 02:11:22 +00001742
1743 // FIXME: Check that the argument type matches the format specifier.
1744
1745 return true;
1746}
1747
1748void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001749 const Expr *OrigFormatExpr,
1750 const CallExpr *TheCall, bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001751 unsigned format_idx, unsigned firstDataArg,
1752 bool isPrintf) {
1753
Ted Kremeneke0e53132010-01-28 23:39:18 +00001754 // CHECK: is the format string a wide literal?
1755 if (FExpr->isWide()) {
1756 Diag(FExpr->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001757 diag::warn_format_string_is_wide_literal)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001758 << OrigFormatExpr->getSourceRange();
1759 return;
1760 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001761
Ted Kremeneke0e53132010-01-28 23:39:18 +00001762 // Str - The format string. NOTE: this is NOT null-terminated!
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +00001763 llvm::StringRef StrRef = FExpr->getString();
1764 const char *Str = StrRef.data();
1765 unsigned StrLen = StrRef.size();
Ted Kremenek826a3452010-07-16 02:11:22 +00001766
Ted Kremeneke0e53132010-01-28 23:39:18 +00001767 // CHECK: empty format string?
Ted Kremeneke0e53132010-01-28 23:39:18 +00001768 if (StrLen == 0) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001769 Diag(FExpr->getLocStart(), diag::warn_empty_format_string)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001770 << OrigFormatExpr->getSourceRange();
1771 return;
1772 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001773
1774 if (isPrintf) {
1775 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1776 TheCall->getNumArgs() - firstDataArg,
1777 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1778 HasVAListArg, TheCall, format_idx);
1779
1780 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen))
1781 H.DoneProcessing();
1782 }
1783 else {
1784 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1785 TheCall->getNumArgs() - firstDataArg,
1786 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1787 HasVAListArg, TheCall, format_idx);
1788
1789 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen))
1790 H.DoneProcessing();
1791 }
Ted Kremenekce7024e2010-01-28 01:18:22 +00001792}
1793
Ted Kremenek06de2762007-08-17 16:46:58 +00001794//===--- CHECK: Return Address of Stack Variable --------------------------===//
1795
1796static DeclRefExpr* EvalVal(Expr *E);
1797static DeclRefExpr* EvalAddr(Expr* E);
1798
1799/// CheckReturnStackAddr - Check if a return statement returns the address
1800/// of a stack variable.
1801void
1802Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1803 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00001804
Ted Kremenek06de2762007-08-17 16:46:58 +00001805 // Perform checking for returned stack addresses.
Steve Naroffdd972f22008-09-05 22:11:13 +00001806 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001807 if (DeclRefExpr *DR = EvalAddr(RetValExp))
Chris Lattner3c73c412008-11-19 08:23:25 +00001808 Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
Chris Lattner08631c52008-11-23 21:45:46 +00001809 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001810
Steve Naroffc50a4a52008-09-16 22:25:10 +00001811 // Skip over implicit cast expressions when checking for block expressions.
Chris Lattner4ca606e2009-09-08 00:36:37 +00001812 RetValExp = RetValExp->IgnoreParenCasts();
Steve Naroffc50a4a52008-09-16 22:25:10 +00001813
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001814 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
Mike Stump397195b2009-04-17 00:09:41 +00001815 if (C->hasBlockDeclRefExprs())
1816 Diag(C->getLocStart(), diag::err_ret_local_block)
1817 << C->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001818
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001819 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1820 Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1821 << ALE->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001822
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001823 } else if (lhsType->isReferenceType()) {
1824 // Perform checking for stack values returned by reference.
Douglas Gregor49badde2008-10-27 19:41:14 +00001825 // Check for a reference to the stack
1826 if (DeclRefExpr *DR = EvalVal(RetValExp))
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001827 Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
Chris Lattner08631c52008-11-23 21:45:46 +00001828 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Ted Kremenek06de2762007-08-17 16:46:58 +00001829 }
1830}
1831
1832/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1833/// check if the expression in a return statement evaluates to an address
1834/// to a location on the stack. The recursion is used to traverse the
1835/// AST of the return expression, with recursion backtracking when we
1836/// encounter a subexpression that (1) clearly does not lead to the address
1837/// of a stack variable or (2) is something we cannot determine leads to
1838/// the address of a stack variable based on such local checking.
1839///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001840/// EvalAddr processes expressions that are pointers that are used as
1841/// references (and not L-values). EvalVal handles all other values.
Mike Stump1eb44332009-09-09 15:08:12 +00001842/// At the base case of the recursion is a check for a DeclRefExpr* in
Ted Kremenek06de2762007-08-17 16:46:58 +00001843/// the refers to a stack variable.
1844///
1845/// This implementation handles:
1846///
1847/// * pointer-to-pointer casts
1848/// * implicit conversions from array references to pointers
1849/// * taking the address of fields
1850/// * arbitrary interplay between "&" and "*" operators
1851/// * pointer arithmetic from an address of a stack variable
1852/// * taking the address of an array element where the array is on the stack
1853static DeclRefExpr* EvalAddr(Expr *E) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001854 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00001855 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00001856 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001857 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001858 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00001859
Ted Kremenek06de2762007-08-17 16:46:58 +00001860 // Our "symbolic interpreter" is just a dispatch off the currently
1861 // viewed AST node. We then recursively traverse the AST by calling
1862 // EvalAddr and EvalVal appropriately.
1863 switch (E->getStmtClass()) {
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001864 case Stmt::ParenExprClass:
1865 // Ignore parentheses.
1866 return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
Ted Kremenek06de2762007-08-17 16:46:58 +00001867
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001868 case Stmt::UnaryOperatorClass: {
1869 // The only unary operator that make sense to handle here
1870 // is AddrOf. All others don't make sense as pointers.
1871 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001872
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001873 if (U->getOpcode() == UnaryOperator::AddrOf)
1874 return EvalVal(U->getSubExpr());
1875 else
Ted Kremenek06de2762007-08-17 16:46:58 +00001876 return NULL;
1877 }
Mike Stump1eb44332009-09-09 15:08:12 +00001878
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001879 case Stmt::BinaryOperatorClass: {
1880 // Handle pointer arithmetic. All other binary operators are not valid
1881 // in this context.
1882 BinaryOperator *B = cast<BinaryOperator>(E);
1883 BinaryOperator::Opcode op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00001884
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001885 if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
1886 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001887
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001888 Expr *Base = B->getLHS();
1889
1890 // Determine which argument is the real pointer base. It could be
1891 // the RHS argument instead of the LHS.
1892 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00001893
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001894 assert (Base->getType()->isPointerType());
1895 return EvalAddr(Base);
1896 }
Steve Naroff61f40a22008-09-10 19:17:48 +00001897
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001898 // For conditional operators we need to see if either the LHS or RHS are
1899 // valid DeclRefExpr*s. If one of them is valid, we return it.
1900 case Stmt::ConditionalOperatorClass: {
1901 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001902
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001903 // Handle the GNU extension for missing LHS.
1904 if (Expr *lhsExpr = C->getLHS())
1905 if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1906 return LHS;
1907
1908 return EvalAddr(C->getRHS());
1909 }
Mike Stump1eb44332009-09-09 15:08:12 +00001910
Ted Kremenek54b52742008-08-07 00:49:01 +00001911 // For casts, we need to handle conversions from arrays to
1912 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00001913 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00001914 case Stmt::CStyleCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001915 case Stmt::CXXFunctionalCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00001916 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00001917 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00001918
Steve Naroffdd972f22008-09-05 22:11:13 +00001919 if (SubExpr->getType()->isPointerType() ||
1920 SubExpr->getType()->isBlockPointerType() ||
1921 SubExpr->getType()->isObjCQualifiedIdType())
Ted Kremenek54b52742008-08-07 00:49:01 +00001922 return EvalAddr(SubExpr);
1923 else if (T->isArrayType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001924 return EvalVal(SubExpr);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001925 else
Ted Kremenek54b52742008-08-07 00:49:01 +00001926 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001927 }
Mike Stump1eb44332009-09-09 15:08:12 +00001928
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001929 // C++ casts. For dynamic casts, static casts, and const casts, we
1930 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00001931 // through the cast. In the case the dynamic cast doesn't fail (and
1932 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001933 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00001934 // FIXME: The comment about is wrong; we're not always converting
1935 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00001936 // handle references to objects.
1937 case Stmt::CXXStaticCastExprClass:
1938 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001939 case Stmt::CXXConstCastExprClass:
1940 case Stmt::CXXReinterpretCastExprClass: {
1941 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00001942 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001943 return EvalAddr(S);
1944 else
1945 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001946 }
Mike Stump1eb44332009-09-09 15:08:12 +00001947
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001948 // Everything else: we simply don't reason about them.
1949 default:
1950 return NULL;
1951 }
Ted Kremenek06de2762007-08-17 16:46:58 +00001952}
Mike Stump1eb44332009-09-09 15:08:12 +00001953
Ted Kremenek06de2762007-08-17 16:46:58 +00001954
1955/// EvalVal - This function is complements EvalAddr in the mutual recursion.
1956/// See the comments for EvalAddr for more details.
1957static DeclRefExpr* EvalVal(Expr *E) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001958do {
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001959 // We should only be called for evaluating non-pointer expressions, or
1960 // expressions with a pointer type that are not used as references but instead
1961 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00001962
Ted Kremenek06de2762007-08-17 16:46:58 +00001963 // Our "symbolic interpreter" is just a dispatch off the currently
1964 // viewed AST node. We then recursively traverse the AST by calling
1965 // EvalAddr and EvalVal appropriately.
1966 switch (E->getStmtClass()) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001967 case Stmt::ImplicitCastExprClass: {
1968 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
1969 if (IE->getCategory() == ImplicitCastExpr::LValue) {
1970 E = IE->getSubExpr();
1971 continue;
1972 }
1973 return NULL;
1974 }
1975
Douglas Gregora2813ce2009-10-23 18:54:35 +00001976 case Stmt::DeclRefExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001977 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
1978 // at code that refers to a variable's name. We check if it has local
1979 // storage within the function, and if so, return the expression.
1980 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001981
Ted Kremenek06de2762007-08-17 16:46:58 +00001982 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Mike Stump1eb44332009-09-09 15:08:12 +00001983 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1984
Ted Kremenek06de2762007-08-17 16:46:58 +00001985 return NULL;
1986 }
Mike Stump1eb44332009-09-09 15:08:12 +00001987
Ted Kremenek68957a92010-08-04 20:01:07 +00001988 case Stmt::ParenExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001989 // Ignore parentheses.
Ted Kremenek68957a92010-08-04 20:01:07 +00001990 E = cast<ParenExpr>(E)->getSubExpr();
1991 continue;
1992 }
Mike Stump1eb44332009-09-09 15:08:12 +00001993
Ted Kremenek06de2762007-08-17 16:46:58 +00001994 case Stmt::UnaryOperatorClass: {
1995 // The only unary operator that make sense to handle here
1996 // is Deref. All others don't resolve to a "name." This includes
1997 // handling all sorts of rvalues passed to a unary operator.
1998 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001999
Ted Kremenek06de2762007-08-17 16:46:58 +00002000 if (U->getOpcode() == UnaryOperator::Deref)
2001 return EvalAddr(U->getSubExpr());
2002
2003 return NULL;
2004 }
Mike Stump1eb44332009-09-09 15:08:12 +00002005
Ted Kremenek06de2762007-08-17 16:46:58 +00002006 case Stmt::ArraySubscriptExprClass: {
2007 // Array subscripts are potential references to data on the stack. We
2008 // retrieve the DeclRefExpr* for the array variable if it indeed
2009 // has local storage.
Ted Kremenek23245122007-08-20 16:18:38 +00002010 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00002011 }
Mike Stump1eb44332009-09-09 15:08:12 +00002012
Ted Kremenek06de2762007-08-17 16:46:58 +00002013 case Stmt::ConditionalOperatorClass: {
2014 // For conditional operators we need to see if either the LHS or RHS are
2015 // non-NULL DeclRefExpr's. If one is non-NULL, we return it.
2016 ConditionalOperator *C = cast<ConditionalOperator>(E);
2017
Anders Carlsson39073232007-11-30 19:04:31 +00002018 // Handle the GNU extension for missing LHS.
2019 if (Expr *lhsExpr = C->getLHS())
2020 if (DeclRefExpr *LHS = EvalVal(lhsExpr))
2021 return LHS;
2022
2023 return EvalVal(C->getRHS());
Ted Kremenek06de2762007-08-17 16:46:58 +00002024 }
Mike Stump1eb44332009-09-09 15:08:12 +00002025
Ted Kremenek06de2762007-08-17 16:46:58 +00002026 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00002027 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00002028 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002029
Ted Kremenek06de2762007-08-17 16:46:58 +00002030 // Check for indirect access. We only want direct field accesses.
2031 if (!M->isArrow())
2032 return EvalVal(M->getBase());
2033 else
2034 return NULL;
2035 }
Mike Stump1eb44332009-09-09 15:08:12 +00002036
Ted Kremenek06de2762007-08-17 16:46:58 +00002037 // Everything else: we simply don't reason about them.
2038 default:
2039 return NULL;
2040 }
Ted Kremenek68957a92010-08-04 20:01:07 +00002041} while (true);
Ted Kremenek06de2762007-08-17 16:46:58 +00002042}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002043
2044//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
2045
2046/// Check for comparisons of floating point operands using != and ==.
2047/// Issue a warning if these are no self-comparisons, as they are not likely
2048/// to do what the programmer intended.
2049void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
2050 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00002051
Ted Kremenek4e99a5f2008-01-17 16:57:34 +00002052 Expr* LeftExprSansParen = lex->IgnoreParens();
Ted Kremenek32e97b62008-01-17 17:55:13 +00002053 Expr* RightExprSansParen = rex->IgnoreParens();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002054
2055 // Special case: check for x == x (which is OK).
2056 // Do not emit warnings for such cases.
2057 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
2058 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
2059 if (DRL->getDecl() == DRR->getDecl())
2060 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002061
2062
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002063 // Special case: check for comparisons against literals that can be exactly
2064 // represented by APFloat. In such cases, do not emit a warning. This
2065 // is a heuristic: often comparison against such literals are used to
2066 // detect if a value in a variable has not changed. This clearly can
2067 // lead to false negatives.
2068 if (EmitWarning) {
2069 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
2070 if (FLL->isExact())
2071 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00002072 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002073 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
2074 if (FLR->isExact())
2075 EmitWarning = false;
2076 }
2077 }
Mike Stump1eb44332009-09-09 15:08:12 +00002078
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002079 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00002080 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002081 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002082 if (CL->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002083 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002084
Sebastian Redl0eb23302009-01-19 00:08:26 +00002085 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002086 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002087 if (CR->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002088 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002089
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002090 // Emit the diagnostic.
2091 if (EmitWarning)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00002092 Diag(loc, diag::warn_floatingpoint_eq)
2093 << lex->getSourceRange() << rex->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002094}
John McCallba26e582010-01-04 23:21:16 +00002095
John McCallf2370c92010-01-06 05:24:50 +00002096//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
2097//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00002098
John McCallf2370c92010-01-06 05:24:50 +00002099namespace {
John McCallba26e582010-01-04 23:21:16 +00002100
John McCallf2370c92010-01-06 05:24:50 +00002101/// Structure recording the 'active' range of an integer-valued
2102/// expression.
2103struct IntRange {
2104 /// The number of bits active in the int.
2105 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00002106
John McCallf2370c92010-01-06 05:24:50 +00002107 /// True if the int is known not to have negative values.
2108 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00002109
John McCallf2370c92010-01-06 05:24:50 +00002110 IntRange(unsigned Width, bool NonNegative)
2111 : Width(Width), NonNegative(NonNegative)
2112 {}
John McCallba26e582010-01-04 23:21:16 +00002113
John McCallf2370c92010-01-06 05:24:50 +00002114 // Returns the range of the bool type.
2115 static IntRange forBoolType() {
2116 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00002117 }
2118
John McCallf2370c92010-01-06 05:24:50 +00002119 // Returns the range of an integral type.
2120 static IntRange forType(ASTContext &C, QualType T) {
2121 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00002122 }
2123
John McCallf2370c92010-01-06 05:24:50 +00002124 // Returns the range of an integeral type based on its canonical
2125 // representation.
2126 static IntRange forCanonicalType(ASTContext &C, const Type *T) {
2127 assert(T->isCanonicalUnqualified());
2128
2129 if (const VectorType *VT = dyn_cast<VectorType>(T))
2130 T = VT->getElementType().getTypePtr();
2131 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
2132 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00002133
2134 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
2135 EnumDecl *Enum = ET->getDecl();
2136 unsigned NumPositive = Enum->getNumPositiveBits();
2137 unsigned NumNegative = Enum->getNumNegativeBits();
2138
2139 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
2140 }
John McCallf2370c92010-01-06 05:24:50 +00002141
2142 const BuiltinType *BT = cast<BuiltinType>(T);
2143 assert(BT->isInteger());
2144
2145 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
2146 }
2147
2148 // Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002149 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00002150 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00002151 L.NonNegative && R.NonNegative);
2152 }
2153
2154 // Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002155 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00002156 return IntRange(std::min(L.Width, R.Width),
2157 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00002158 }
2159};
2160
2161IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
2162 if (value.isSigned() && value.isNegative())
2163 return IntRange(value.getMinSignedBits(), false);
2164
2165 if (value.getBitWidth() > MaxWidth)
2166 value.trunc(MaxWidth);
2167
2168 // isNonNegative() just checks the sign bit without considering
2169 // signedness.
2170 return IntRange(value.getActiveBits(), true);
2171}
2172
John McCall0acc3112010-01-06 22:57:21 +00002173IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
John McCallf2370c92010-01-06 05:24:50 +00002174 unsigned MaxWidth) {
2175 if (result.isInt())
2176 return GetValueRange(C, result.getInt(), MaxWidth);
2177
2178 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00002179 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
2180 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
2181 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
2182 R = IntRange::join(R, El);
2183 }
John McCallf2370c92010-01-06 05:24:50 +00002184 return R;
2185 }
2186
2187 if (result.isComplexInt()) {
2188 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
2189 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
2190 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00002191 }
2192
2193 // This can happen with lossless casts to intptr_t of "based" lvalues.
2194 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00002195 // FIXME: The only reason we need to pass the type in here is to get
2196 // the sign right on this one case. It would be nice if APValue
2197 // preserved this.
John McCallf2370c92010-01-06 05:24:50 +00002198 assert(result.isLValue());
John McCall0acc3112010-01-06 22:57:21 +00002199 return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
John McCall51313c32010-01-04 23:31:57 +00002200}
John McCallf2370c92010-01-06 05:24:50 +00002201
2202/// Pseudo-evaluate the given integer expression, estimating the
2203/// range of values it might take.
2204///
2205/// \param MaxWidth - the width to which the value will be truncated
2206IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
2207 E = E->IgnoreParens();
2208
2209 // Try a full evaluation first.
2210 Expr::EvalResult result;
2211 if (E->Evaluate(result, C))
John McCall0acc3112010-01-06 22:57:21 +00002212 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00002213
2214 // I think we only want to look through implicit casts here; if the
2215 // user has an explicit widening cast, we should treat the value as
2216 // being of the new, wider type.
2217 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
2218 if (CE->getCastKind() == CastExpr::CK_NoOp)
2219 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
2220
2221 IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
2222
John McCall60fad452010-01-06 22:07:33 +00002223 bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
2224 if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
2225 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
2226
John McCallf2370c92010-01-06 05:24:50 +00002227 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00002228 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00002229 return OutputTypeRange;
2230
2231 IntRange SubRange
2232 = GetExprRange(C, CE->getSubExpr(),
2233 std::min(MaxWidth, OutputTypeRange.Width));
2234
2235 // Bail out if the subexpr's range is as wide as the cast type.
2236 if (SubRange.Width >= OutputTypeRange.Width)
2237 return OutputTypeRange;
2238
2239 // Otherwise, we take the smaller width, and we're non-negative if
2240 // either the output type or the subexpr is.
2241 return IntRange(SubRange.Width,
2242 SubRange.NonNegative || OutputTypeRange.NonNegative);
2243 }
2244
2245 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
2246 // If we can fold the condition, just take that operand.
2247 bool CondResult;
2248 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
2249 return GetExprRange(C, CondResult ? CO->getTrueExpr()
2250 : CO->getFalseExpr(),
2251 MaxWidth);
2252
2253 // Otherwise, conservatively merge.
2254 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
2255 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
2256 return IntRange::join(L, R);
2257 }
2258
2259 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
2260 switch (BO->getOpcode()) {
2261
2262 // Boolean-valued operations are single-bit and positive.
2263 case BinaryOperator::LAnd:
2264 case BinaryOperator::LOr:
2265 case BinaryOperator::LT:
2266 case BinaryOperator::GT:
2267 case BinaryOperator::LE:
2268 case BinaryOperator::GE:
2269 case BinaryOperator::EQ:
2270 case BinaryOperator::NE:
2271 return IntRange::forBoolType();
2272
John McCallc0cd21d2010-02-23 19:22:29 +00002273 // The type of these compound assignments is the type of the LHS,
2274 // so the RHS is not necessarily an integer.
2275 case BinaryOperator::MulAssign:
2276 case BinaryOperator::DivAssign:
2277 case BinaryOperator::RemAssign:
2278 case BinaryOperator::AddAssign:
2279 case BinaryOperator::SubAssign:
2280 return IntRange::forType(C, E->getType());
2281
John McCallf2370c92010-01-06 05:24:50 +00002282 // Operations with opaque sources are black-listed.
2283 case BinaryOperator::PtrMemD:
2284 case BinaryOperator::PtrMemI:
2285 return IntRange::forType(C, E->getType());
2286
John McCall60fad452010-01-06 22:07:33 +00002287 // Bitwise-and uses the *infinum* of the two source ranges.
2288 case BinaryOperator::And:
John McCallc0cd21d2010-02-23 19:22:29 +00002289 case BinaryOperator::AndAssign:
John McCall60fad452010-01-06 22:07:33 +00002290 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
2291 GetExprRange(C, BO->getRHS(), MaxWidth));
2292
John McCallf2370c92010-01-06 05:24:50 +00002293 // Left shift gets black-listed based on a judgement call.
2294 case BinaryOperator::Shl:
John McCall3aae6092010-04-07 01:14:35 +00002295 // ...except that we want to treat '1 << (blah)' as logically
2296 // positive. It's an important idiom.
2297 if (IntegerLiteral *I
2298 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
2299 if (I->getValue() == 1) {
2300 IntRange R = IntRange::forType(C, E->getType());
2301 return IntRange(R.Width, /*NonNegative*/ true);
2302 }
2303 }
2304 // fallthrough
2305
John McCallc0cd21d2010-02-23 19:22:29 +00002306 case BinaryOperator::ShlAssign:
John McCallf2370c92010-01-06 05:24:50 +00002307 return IntRange::forType(C, E->getType());
2308
John McCall60fad452010-01-06 22:07:33 +00002309 // Right shift by a constant can narrow its left argument.
John McCallc0cd21d2010-02-23 19:22:29 +00002310 case BinaryOperator::Shr:
2311 case BinaryOperator::ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00002312 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2313
2314 // If the shift amount is a positive constant, drop the width by
2315 // that much.
2316 llvm::APSInt shift;
2317 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
2318 shift.isNonNegative()) {
2319 unsigned zext = shift.getZExtValue();
2320 if (zext >= L.Width)
2321 L.Width = (L.NonNegative ? 0 : 1);
2322 else
2323 L.Width -= zext;
2324 }
2325
2326 return L;
2327 }
2328
2329 // Comma acts as its right operand.
John McCallf2370c92010-01-06 05:24:50 +00002330 case BinaryOperator::Comma:
2331 return GetExprRange(C, BO->getRHS(), MaxWidth);
2332
John McCall60fad452010-01-06 22:07:33 +00002333 // Black-list pointer subtractions.
John McCallf2370c92010-01-06 05:24:50 +00002334 case BinaryOperator::Sub:
2335 if (BO->getLHS()->getType()->isPointerType())
2336 return IntRange::forType(C, E->getType());
2337 // fallthrough
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002338
John McCallf2370c92010-01-06 05:24:50 +00002339 default:
2340 break;
2341 }
2342
2343 // Treat every other operator as if it were closed on the
2344 // narrowest type that encompasses both operands.
2345 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2346 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
2347 return IntRange::join(L, R);
2348 }
2349
2350 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
2351 switch (UO->getOpcode()) {
2352 // Boolean-valued operations are white-listed.
2353 case UnaryOperator::LNot:
2354 return IntRange::forBoolType();
2355
2356 // Operations with opaque sources are black-listed.
2357 case UnaryOperator::Deref:
2358 case UnaryOperator::AddrOf: // should be impossible
John McCallf2370c92010-01-06 05:24:50 +00002359 return IntRange::forType(C, E->getType());
2360
2361 default:
2362 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
2363 }
2364 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00002365
2366 if (dyn_cast<OffsetOfExpr>(E)) {
2367 IntRange::forType(C, E->getType());
2368 }
John McCallf2370c92010-01-06 05:24:50 +00002369
2370 FieldDecl *BitField = E->getBitField();
2371 if (BitField) {
2372 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
2373 unsigned BitWidth = BitWidthAP.getZExtValue();
2374
2375 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
2376 }
2377
2378 return IntRange::forType(C, E->getType());
2379}
John McCall51313c32010-01-04 23:31:57 +00002380
John McCall323ed742010-05-06 08:58:33 +00002381IntRange GetExprRange(ASTContext &C, Expr *E) {
2382 return GetExprRange(C, E, C.getIntWidth(E->getType()));
2383}
2384
John McCall51313c32010-01-04 23:31:57 +00002385/// Checks whether the given value, which currently has the given
2386/// source semantics, has the same value when coerced through the
2387/// target semantics.
John McCallf2370c92010-01-06 05:24:50 +00002388bool IsSameFloatAfterCast(const llvm::APFloat &value,
2389 const llvm::fltSemantics &Src,
2390 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002391 llvm::APFloat truncated = value;
2392
2393 bool ignored;
2394 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
2395 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
2396
2397 return truncated.bitwiseIsEqual(value);
2398}
2399
2400/// Checks whether the given value, which currently has the given
2401/// source semantics, has the same value when coerced through the
2402/// target semantics.
2403///
2404/// The value might be a vector of floats (or a complex number).
John McCallf2370c92010-01-06 05:24:50 +00002405bool IsSameFloatAfterCast(const APValue &value,
2406 const llvm::fltSemantics &Src,
2407 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002408 if (value.isFloat())
2409 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
2410
2411 if (value.isVector()) {
2412 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
2413 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
2414 return false;
2415 return true;
2416 }
2417
2418 assert(value.isComplexFloat());
2419 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
2420 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
2421}
2422
John McCall323ed742010-05-06 08:58:33 +00002423void AnalyzeImplicitConversions(Sema &S, Expr *E);
2424
2425bool IsZero(Sema &S, Expr *E) {
2426 llvm::APSInt Value;
2427 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
2428}
2429
2430void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
2431 BinaryOperator::Opcode op = E->getOpcode();
2432 if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) {
2433 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2434 << "< 0" << "false"
2435 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2436 } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) {
2437 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2438 << ">= 0" << "true"
2439 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2440 } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) {
2441 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2442 << "0 >" << "false"
2443 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2444 } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) {
2445 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2446 << "0 <=" << "true"
2447 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2448 }
2449}
2450
2451/// Analyze the operands of the given comparison. Implements the
2452/// fallback case from AnalyzeComparison.
2453void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
2454 AnalyzeImplicitConversions(S, E->getLHS());
2455 AnalyzeImplicitConversions(S, E->getRHS());
2456}
John McCall51313c32010-01-04 23:31:57 +00002457
John McCallba26e582010-01-04 23:21:16 +00002458/// \brief Implements -Wsign-compare.
2459///
2460/// \param lex the left-hand expression
2461/// \param rex the right-hand expression
2462/// \param OpLoc the location of the joining operator
John McCalld1b47bf2010-03-11 19:43:18 +00002463/// \param BinOpc binary opcode or 0
John McCall323ed742010-05-06 08:58:33 +00002464void AnalyzeComparison(Sema &S, BinaryOperator *E) {
2465 // The type the comparison is being performed in.
2466 QualType T = E->getLHS()->getType();
2467 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
2468 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00002469
John McCall323ed742010-05-06 08:58:33 +00002470 // We don't do anything special if this isn't an unsigned integral
2471 // comparison: we're only interested in integral comparisons, and
2472 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregorf6094622010-07-23 15:58:24 +00002473 if (!T->hasUnsignedIntegerRepresentation())
John McCall323ed742010-05-06 08:58:33 +00002474 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00002475
John McCall323ed742010-05-06 08:58:33 +00002476 Expr *lex = E->getLHS()->IgnoreParenImpCasts();
2477 Expr *rex = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00002478
John McCall323ed742010-05-06 08:58:33 +00002479 // Check to see if one of the (unmodified) operands is of different
2480 // signedness.
2481 Expr *signedOperand, *unsignedOperand;
Douglas Gregorf6094622010-07-23 15:58:24 +00002482 if (lex->getType()->hasSignedIntegerRepresentation()) {
2483 assert(!rex->getType()->hasSignedIntegerRepresentation() &&
John McCall323ed742010-05-06 08:58:33 +00002484 "unsigned comparison between two signed integer expressions?");
2485 signedOperand = lex;
2486 unsignedOperand = rex;
Douglas Gregorf6094622010-07-23 15:58:24 +00002487 } else if (rex->getType()->hasSignedIntegerRepresentation()) {
John McCall323ed742010-05-06 08:58:33 +00002488 signedOperand = rex;
2489 unsignedOperand = lex;
John McCallba26e582010-01-04 23:21:16 +00002490 } else {
John McCall323ed742010-05-06 08:58:33 +00002491 CheckTrivialUnsignedComparison(S, E);
2492 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002493 }
2494
John McCall323ed742010-05-06 08:58:33 +00002495 // Otherwise, calculate the effective range of the signed operand.
2496 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00002497
John McCall323ed742010-05-06 08:58:33 +00002498 // Go ahead and analyze implicit conversions in the operands. Note
2499 // that we skip the implicit conversions on both sides.
2500 AnalyzeImplicitConversions(S, lex);
2501 AnalyzeImplicitConversions(S, rex);
John McCallba26e582010-01-04 23:21:16 +00002502
John McCall323ed742010-05-06 08:58:33 +00002503 // If the signed range is non-negative, -Wsign-compare won't fire,
2504 // but we should still check for comparisons which are always true
2505 // or false.
2506 if (signedRange.NonNegative)
2507 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002508
2509 // For (in)equality comparisons, if the unsigned operand is a
2510 // constant which cannot collide with a overflowed signed operand,
2511 // then reinterpreting the signed operand as unsigned will not
2512 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00002513 if (E->isEqualityOp()) {
2514 unsigned comparisonWidth = S.Context.getIntWidth(T);
2515 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00002516
John McCall323ed742010-05-06 08:58:33 +00002517 // We should never be unable to prove that the unsigned operand is
2518 // non-negative.
2519 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
2520
2521 if (unsignedRange.Width < comparisonWidth)
2522 return;
2523 }
2524
2525 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
2526 << lex->getType() << rex->getType()
2527 << lex->getSourceRange() << rex->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00002528}
2529
John McCall51313c32010-01-04 23:31:57 +00002530/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
John McCall323ed742010-05-06 08:58:33 +00002531void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
John McCall51313c32010-01-04 23:31:57 +00002532 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
2533}
2534
John McCall323ed742010-05-06 08:58:33 +00002535void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
2536 bool *ICContext = 0) {
2537 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00002538
John McCall323ed742010-05-06 08:58:33 +00002539 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
2540 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
2541 if (Source == Target) return;
2542 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00002543
2544 // Never diagnose implicit casts to bool.
2545 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
2546 return;
2547
2548 // Strip vector types.
2549 if (isa<VectorType>(Source)) {
2550 if (!isa<VectorType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002551 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
John McCall51313c32010-01-04 23:31:57 +00002552
2553 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
2554 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
2555 }
2556
2557 // Strip complex types.
2558 if (isa<ComplexType>(Source)) {
2559 if (!isa<ComplexType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002560 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
John McCall51313c32010-01-04 23:31:57 +00002561
2562 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
2563 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
2564 }
2565
2566 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
2567 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
2568
2569 // If the source is floating point...
2570 if (SourceBT && SourceBT->isFloatingPoint()) {
2571 // ...and the target is floating point...
2572 if (TargetBT && TargetBT->isFloatingPoint()) {
2573 // ...then warn if we're dropping FP rank.
2574
2575 // Builtin FP kinds are ordered by increasing FP rank.
2576 if (SourceBT->getKind() > TargetBT->getKind()) {
2577 // Don't warn about float constants that are precisely
2578 // representable in the target type.
2579 Expr::EvalResult result;
John McCall323ed742010-05-06 08:58:33 +00002580 if (E->Evaluate(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00002581 // Value might be a float, a float vector, or a float complex.
2582 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00002583 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2584 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00002585 return;
2586 }
2587
John McCall323ed742010-05-06 08:58:33 +00002588 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00002589 }
2590 return;
2591 }
2592
2593 // If the target is integral, always warn.
2594 if ((TargetBT && TargetBT->isInteger()))
2595 // TODO: don't warn for integer values?
John McCall323ed742010-05-06 08:58:33 +00002596 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
John McCall51313c32010-01-04 23:31:57 +00002597
2598 return;
2599 }
2600
John McCallf2370c92010-01-06 05:24:50 +00002601 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00002602 return;
2603
John McCall323ed742010-05-06 08:58:33 +00002604 IntRange SourceRange = GetExprRange(S.Context, E);
2605 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00002606
2607 if (SourceRange.Width > TargetRange.Width) {
John McCall51313c32010-01-04 23:31:57 +00002608 // People want to build with -Wshorten-64-to-32 and not -Wconversion
2609 // and by god we'll let them.
John McCallf2370c92010-01-06 05:24:50 +00002610 if (SourceRange.Width == 64 && TargetRange.Width == 32)
John McCall323ed742010-05-06 08:58:33 +00002611 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
2612 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
2613 }
2614
2615 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
2616 (!TargetRange.NonNegative && SourceRange.NonNegative &&
2617 SourceRange.Width == TargetRange.Width)) {
2618 unsigned DiagID = diag::warn_impcast_integer_sign;
2619
2620 // Traditionally, gcc has warned about this under -Wsign-compare.
2621 // We also want to warn about it in -Wconversion.
2622 // So if -Wconversion is off, use a completely identical diagnostic
2623 // in the sign-compare group.
2624 // The conditional-checking code will
2625 if (ICContext) {
2626 DiagID = diag::warn_impcast_integer_sign_conditional;
2627 *ICContext = true;
2628 }
2629
2630 return DiagnoseImpCast(S, E, T, DiagID);
John McCall51313c32010-01-04 23:31:57 +00002631 }
2632
2633 return;
2634}
2635
John McCall323ed742010-05-06 08:58:33 +00002636void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
2637
2638void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
2639 bool &ICContext) {
2640 E = E->IgnoreParenImpCasts();
2641
2642 if (isa<ConditionalOperator>(E))
2643 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
2644
2645 AnalyzeImplicitConversions(S, E);
2646 if (E->getType() != T)
2647 return CheckImplicitConversion(S, E, T, &ICContext);
2648 return;
2649}
2650
2651void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
2652 AnalyzeImplicitConversions(S, E->getCond());
2653
2654 bool Suspicious = false;
2655 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
2656 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
2657
2658 // If -Wconversion would have warned about either of the candidates
2659 // for a signedness conversion to the context type...
2660 if (!Suspicious) return;
2661
2662 // ...but it's currently ignored...
2663 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
2664 return;
2665
2666 // ...and -Wsign-compare isn't...
2667 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
2668 return;
2669
2670 // ...then check whether it would have warned about either of the
2671 // candidates for a signedness conversion to the condition type.
2672 if (E->getType() != T) {
2673 Suspicious = false;
2674 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
2675 E->getType(), &Suspicious);
2676 if (!Suspicious)
2677 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
2678 E->getType(), &Suspicious);
2679 if (!Suspicious)
2680 return;
2681 }
2682
2683 // If so, emit a diagnostic under -Wsign-compare.
2684 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
2685 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
2686 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
2687 << lex->getType() << rex->getType()
2688 << lex->getSourceRange() << rex->getSourceRange();
2689}
2690
2691/// AnalyzeImplicitConversions - Find and report any interesting
2692/// implicit conversions in the given expression. There are a couple
2693/// of competing diagnostics here, -Wconversion and -Wsign-compare.
2694void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
2695 QualType T = OrigE->getType();
2696 Expr *E = OrigE->IgnoreParenImpCasts();
2697
2698 // For conditional operators, we analyze the arguments as if they
2699 // were being fed directly into the output.
2700 if (isa<ConditionalOperator>(E)) {
2701 ConditionalOperator *CO = cast<ConditionalOperator>(E);
2702 CheckConditionalOperator(S, CO, T);
2703 return;
2704 }
2705
2706 // Go ahead and check any implicit conversions we might have skipped.
2707 // The non-canonical typecheck is just an optimization;
2708 // CheckImplicitConversion will filter out dead implicit conversions.
2709 if (E->getType() != T)
2710 CheckImplicitConversion(S, E, T);
2711
2712 // Now continue drilling into this expression.
2713
2714 // Skip past explicit casts.
2715 if (isa<ExplicitCastExpr>(E)) {
2716 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
2717 return AnalyzeImplicitConversions(S, E);
2718 }
2719
2720 // Do a somewhat different check with comparison operators.
2721 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
2722 return AnalyzeComparison(S, cast<BinaryOperator>(E));
2723
2724 // These break the otherwise-useful invariant below. Fortunately,
2725 // we don't really need to recurse into them, because any internal
2726 // expressions should have been analyzed already when they were
2727 // built into statements.
2728 if (isa<StmtExpr>(E)) return;
2729
2730 // Don't descend into unevaluated contexts.
2731 if (isa<SizeOfAlignOfExpr>(E)) return;
2732
2733 // Now just recurse over the expression's children.
2734 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
2735 I != IE; ++I)
2736 AnalyzeImplicitConversions(S, cast<Expr>(*I));
2737}
2738
2739} // end anonymous namespace
2740
2741/// Diagnoses "dangerous" implicit conversions within the given
2742/// expression (which is a full expression). Implements -Wconversion
2743/// and -Wsign-compare.
2744void Sema::CheckImplicitConversions(Expr *E) {
2745 // Don't diagnose in unevaluated contexts.
2746 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
2747 return;
2748
2749 // Don't diagnose for value- or type-dependent expressions.
2750 if (E->isTypeDependent() || E->isValueDependent())
2751 return;
2752
2753 AnalyzeImplicitConversions(*this, E);
2754}
2755
Mike Stumpf8c49212010-01-21 03:59:47 +00002756/// CheckParmsForFunctionDef - Check that the parameters of the given
2757/// function are appropriate for the definition of a function. This
2758/// takes care of any checks that cannot be performed on the
2759/// declaration itself, e.g., that the types of each of the function
2760/// parameters are complete.
2761bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2762 bool HasInvalidParm = false;
2763 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2764 ParmVarDecl *Param = FD->getParamDecl(p);
2765
2766 // C99 6.7.5.3p4: the parameters in a parameter type list in a
2767 // function declarator that is part of a function definition of
2768 // that function shall not have incomplete type.
2769 //
2770 // This is also C++ [dcl.fct]p6.
2771 if (!Param->isInvalidDecl() &&
2772 RequireCompleteType(Param->getLocation(), Param->getType(),
2773 diag::err_typecheck_decl_incomplete_type)) {
2774 Param->setInvalidDecl();
2775 HasInvalidParm = true;
2776 }
2777
2778 // C99 6.9.1p5: If the declarator includes a parameter type list, the
2779 // declaration of each parameter shall include an identifier.
2780 if (Param->getIdentifier() == 0 &&
2781 !Param->isImplicit() &&
2782 !getLangOptions().CPlusPlus)
2783 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00002784
2785 // C99 6.7.5.3p12:
2786 // If the function declarator is not part of a definition of that
2787 // function, parameters may have incomplete type and may use the [*]
2788 // notation in their sequences of declarator specifiers to specify
2789 // variable length array types.
2790 QualType PType = Param->getOriginalType();
2791 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
2792 if (AT->getSizeModifier() == ArrayType::Star) {
2793 // FIXME: This diagnosic should point the the '[*]' if source-location
2794 // information is added for it.
2795 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
2796 }
2797 }
Mike Stumpf8c49212010-01-21 03:59:47 +00002798 }
2799
2800 return HasInvalidParm;
2801}
John McCallb7f4ffe2010-08-12 21:44:57 +00002802
2803/// CheckCastAlign - Implements -Wcast-align, which warns when a
2804/// pointer cast increases the alignment requirements.
2805void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
2806 // This is actually a lot of work to potentially be doing on every
2807 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
2808 if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align)
2809 == Diagnostic::Ignored)
2810 return;
2811
2812 // Ignore dependent types.
2813 if (T->isDependentType() || Op->getType()->isDependentType())
2814 return;
2815
2816 // Require that the destination be a pointer type.
2817 const PointerType *DestPtr = T->getAs<PointerType>();
2818 if (!DestPtr) return;
2819
2820 // If the destination has alignment 1, we're done.
2821 QualType DestPointee = DestPtr->getPointeeType();
2822 if (DestPointee->isIncompleteType()) return;
2823 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
2824 if (DestAlign.isOne()) return;
2825
2826 // Require that the source be a pointer type.
2827 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
2828 if (!SrcPtr) return;
2829 QualType SrcPointee = SrcPtr->getPointeeType();
2830
2831 // Whitelist casts from cv void*. We already implicitly
2832 // whitelisted casts to cv void*, since they have alignment 1.
2833 // Also whitelist casts involving incomplete types, which implicitly
2834 // includes 'void'.
2835 if (SrcPointee->isIncompleteType()) return;
2836
2837 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
2838 if (SrcAlign >= DestAlign) return;
2839
2840 Diag(TRange.getBegin(), diag::warn_cast_align)
2841 << Op->getType() << T
2842 << static_cast<unsigned>(SrcAlign.getQuantity())
2843 << static_cast<unsigned>(DestAlign.getQuantity())
2844 << TRange << Op->getSourceRange();
2845}
2846